kevinrr888 commented on code in PR #5866:
URL: https://github.com/apache/accumulo/pull/5866#discussion_r2325302532
##########
pom.xml:
##########
@@ -1529,6 +1529,13 @@
<id>sunny</id>
<properties>
<failsafe.groups>SunnyDay</failsafe.groups>
+ <!--
+ exclude junit-platform-suite engine from this list of engines to run,
+ so it skips the SimpleSuite tests, which contain no sunny tests, to
+ prevent the suite engine from running the BeforeSuite and AfterSuite
+ minicluster setup and teardown unnecessarily for zero tests
+ -->
+
<failsafe.includeJUnit5Engines>junit-jupiter</failsafe.includeJUnit5Engines>
Review Comment:
Won't this be a problem if a SimpleSuite test is added to sunny in the
future? Maybe we are saying a SimpleSuite test can not be a sunny test (which
is fine as including a test as SimpleSuite is more of thing that's nice to
include when we can). If this is the case, this should be added to the
description for the `SimpleSharedMacTestSuiteIT` class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
