dlmarion commented on code in PR #5866: URL: https://github.com/apache/accumulo/pull/5866#discussion_r2324899584
########## test/src/main/java/org/apache/accumulo/test/suites/SimpleSharedMacTestSuiteIT.java: ########## @@ -43,7 +43,7 @@ * IMPORTANT NOTE: Only the concrete classes should be marked with "IT_SimpleSuite". For example, * marking an abstract class will not add its implementations to the suite. */ -@Suite +@Suite(failIfNoTests = false) Review Comment: I'm not sure we should make this change. We are excluding the junit-platform-suite engine during the sunny profile, so this should not run. With this change the test will succeed if no tests are found during the non-sunny test runs. ########## src/build/ci/check-module-package-conventions.sh: ########## @@ -0,0 +1,130 @@ +#! /usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# The purpose of this ci script is to ensure that a pull request +# doesn't unintentionally add a jar resource that would cause +# problems with jar sealing by breaking our package naming +# conventions, which are to use package names based on the +# module, so they are unique. +NUM_EXPECTED=0 +ALLOWED=( Review Comment: why not just allow everything in src/main/resources and src/test/resources? Do we need to enumerate here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
