ctubbsii commented on code in PR #5866:
URL: https://github.com/apache/accumulo/pull/5866#discussion_r2326219279
##########
pom.xml:
##########
@@ -1529,6 +1529,13 @@
<id>sunny</id>
<properties>
<failsafe.groups>SunnyDay</failsafe.groups>
+ <!--
+ exclude junit-platform-suite engine from this list of engines to run,
+ so it skips the SimpleSuite tests, which contain no sunny tests, to
+ prevent the suite engine from running the BeforeSuite and AfterSuite
+ minicluster setup and teardown unnecessarily for zero tests
+ -->
+
<failsafe.includeJUnit5Engines>junit-jupiter</failsafe.includeJUnit5Engines>
Review Comment:
Yes it would be a problem if we did that. But, if we did that, we can just
remove this line. This exists only to avoid starting and stopping a minicluster
for zero tests. If we add a sunny test to the SimpleSuite, then we wouldn't
have zero tests, and then it would be okay to have it started. That's why I put
this comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
