On Thu, 19 Dec 2019 15:27:59 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> As mentioned, I could copy the class of the library into the JavaFX-Project. >> Alternatively, I could remove the unit-test entirely. >> >> But to be honest, the current state related to memory-leaks in the JavaFX >> project is a bit questionable. JavaFX is filled with leaks and code which >> could have leaks. >> I would like to add many more tests like this into the JavaFX-CodeBase. But >> without the class/library I can only write unreadable code filled with >> sleeps, Weakreferences etc., which would be sad because now I know how to do >> it better. > > Florian, basically it's a single class isn't it? If so, it might be > acceptable to add that class to the test.xx.infrastructure package (don't > know if doing so would require a jbs issue) for now, you could have a look at ProgressIndicatorTest (or ProgressSkinTest) attemptGC - might not be optimal (don't know enough about the dirty details of gc :) but gets the test failing/passing before/after fixing a memory leak ------------- PR: https://git.openjdk.java.net/jfx/pull/71
