(Comments inline below, and apologies if I miss anything.... twas a long message ;-))

Rainer Orth wrote:
Btw., I'm currently working on

6414822 don't try to build packages with closed components

again.  The initial patch I sent to Mike consisted of just omitting any
packages with closed components in an open build.  Right now, I'm almost
done splitting off closed components in several packages into their own
packages, as described at the start of this thread.  Btw., do I need to
file a new bug for this work (splitting off packages), or can this be
handled with the same CR?

I think that can happen under the same CR... Mike may have a better opinion though.

While doing so, I noticed a couple of other problems:

When doing a nightly build without the -N flag and with -pz added, I get a
couple of errors which are partially due to the closed tar balls.  I've
filed

6439889 wrong directory permissions in closed tarballs
[snip]
and several more.  Those are due to the fact that the closed tar balls
deliver those directories with permissions that differ from what the
package files describe.  For the moment, I've manually fixed them (full
details in CR 6439889).  For those changes to take effect, I need to change
the toplevel Makefile in $SRC:

diff -r f7a1197187ee usr/src/Makefile
--- a/usr/src/Makefile  Mon May 29 13:01:03 2006 -0700
+++ b/usr/src/Makefile  Fri Jun 16 12:23:12 2006 +0200
@@ -125,7 +125,7 @@ closedbins: FRC $(ROOTDIRS)
                fi; \
                $(ECHO) "Copying closed binaries from $$ON_CLOSED_BINS"; \
                (cd $$ON_CLOSED_BINS/root_$(MACH); tar cf - .) | \
-                   (cd $(ROOT); tar xBf -); \
+                   (cd $(ROOT); tar xBpf -); \
        fi
$(SUBDIRS) head ucbhead pkgdefs: FRC

otherwise the directory permissions get lost when transferring the closed
binaries to $ROOT.

In addition, if I rerun nightly -i after a successful build, a couple of
additional directories get their permissions wrong since they are
overwritten from the closed tar ball and not corrected by the build.

It would be great if you could fix those issues for the closed tar balls.

Sorry, just trying to clarify: is the problem in the Makefile with the untarring of the closed-bins, or is the problem actually in the creation process of the closed-bins tarball? If the former, then definitely request a sponsor (I'll be happy to), and we can fix the bug. If the latter, then it's a bug in the way I'm creating the closed-bins tarball...

Even after those changes and with my patches to split off closed components
(which, btw, ignore those files that can be opened as mentioned upthread,
but are not yet in the open tree)

I'm moving these as part of the cfgadm plugins for sysctrl/ac. Should be ready next week.

Files missing from packages:

T File Name                      Reloc/Sym name       perm owner group inode 
lnk maj min package(s)
------------------------------------------------------------------------------------------------------------
f kernel/crypto/sparcv9/dprov    -                     755 -     -     246202  
2  -  -    proto
f kernel/drv/dprov.conf          -                     644 -     -          0  
1  -  -    proto
f kernel/drv/sparcv9/dprov       -                     755 -     -     246202  
2  -  -    proto

SUNWcryptoint

Distributed in source; the only parts missing from SUNWcryptoint are
etc/certs/SUNWosnetSolaris and etc/crypto/certs/SUNWosnet.  Perhaps those
should go into their own packages?  Any suggestions for a name?

Hrm... yeah, my feeling is those should probably be split into a separate package since the other parts of it are still interesting to open source - but the above two certs can not be distributed.
cc'ing Darren Moffat for a more expert opinion...

SUNWwrsu.u

It seems strange now that all of the wrs code can be distributed in source
form with the only exception of the wrsm and wrsmd kmdb modules.  Perhaps
this is an oversight which can be fixed?

6393468 move driver wrsmd to usr/src
I'll add this to my wad for next week...

I don't have a concrete answer for the other ones... hopefully Kupfer will weigh in. :)

cheers,
steve

--
stephen lau // [EMAIL PROTECTED] | 650.786.0845 | http://whacked.net
opensolaris // solaris kernel development
_______________________________________________
opensolaris-code mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code

Reply via email to