On Sat, Jan 16, 2016 at 3:45 AM, David Allouche <da...@allouche.net> wrote:
> Hello, > > I believe the Contributing to Pharo page > http://pharo.org/contribute-propose-fix > is out of date. > > I found a bug > > https://pharo.fogbugz.com/f/cases/17396/MonticelloRepositoryBrowser-example-MNU > > and a made a fix in in a clean image (50525), created by the newly fixed > PharoLauncher. > > Then I followed the instruction on the page. > > > - Create a slice (group of packages): > - Open the Monticello Browser. > - Open the Slice Maker by clicking the "Slice" button. > - In Slice Maker enter the Fogbugz issue number and "grab" the > issue summary. > - Select all dirty packages affected by your bug fix. > > I have no idea how the "list of dirty packages" is generated, but > > 1. it shows a bunch of packages I have not touched > 2. it does not show the package that contains my fix (Spec-Tools) > > I am curious on item 2. Was this just because the dirty package was sorted to the top of the list (per Nicolai's snapshots)? > I looked in the world menu, and I found this menu item called "Komitter". > That sounded like a good candidate. > I see how the term "Commit" is misleading here without context. Probably "Press the <Save> button to commit your slice to the inbox repository" would probably be better. > > Now, I guess I should select Pharo50Inbox as the Remote, write a commit > message, click Ok and hope for the best. > > Is that right? > > I guess contributors are expected to use a recent image. So I think it > would be good that someone updates the documentation. Or fix the slice > maker. Or both. > https://pharo.fogbugz.com/default.asp?17398 cheers -ben
