http://testes.aborla.net/phpdoc/install.windows.html
http://testes.aborla.net/phpdoc/faq.installation.html#faq.installation.addtopath

diff: http://testes.aborla.net/win.install.diff

Just a few notes :)

1.  > either manually  or by using the installer installer.
                                       ^^^^^^^^^^^^^^^^^^^
2. IMHO We should note on a big section level (like windows
   installer) that there are complete installation packages, and
   those install much more at once for you, but none of those
   are endorsed by PHP.net, as we beleive that the manual
   installation is the best choice to get to know the system.
   This is already noted in the manual install part, but IMHO
   we need to have a big section for all-in-one installers,
   so people will recognize our advice and warning of the
   applicability of those tools only for testing purposes :)

3. Planning for the future, I have also added an internal
   link on the ActiveScript engine stuff, so we can document
   how can it be registered as a Windows Scripting Host
   provider, and used for scripting. That is a short and easy
   to write part and should be included in the Windows install
   section (see the readme in the actionscript php source).

4. PHP5 -> PHP 5

5. For better maintenaice, we advice
              ^^^^^^^^^^^     ^^^^^^

6. Windows 95 should not be mentioned in the FAQ entry as it is
   not supported anymore.

7. I would not advise people to edit the registry. Instead I would
   recommend setting of PHPRC to users. The FAQ entry needs to be
   duplicated / generalized to cover both the PATH and PHPRC
   setting. It is better to reiterate the same procedure for two
   vars, then describing two different procedures for the two vars!

8. It is still not clear to me, how php[45]ts.dll is found by
   a CGI and an SAPI module setup, and what part of the install
   instructions guarantee that it will be found at the default
   place, where someone unzips PHP.

BTW I have not checked the Apache stuff thoroughly.

Please review my patch and let me know if I can commit it.
And if yes, can I do the change to the new install section (including
removing the old chapters/instal./.xml)?

First fix the problems. If you only commit the changes you made to the new install part, then go and do it now, but if you would like to commit all at once (including the removal of the old section), then please fix all complaints first :)


Goba

Reply via email to