On Thu, Dec 04, 2008 at 04:38:02PM -0600, Tom Mueller (pkg-discuss) wrote:
> webrev: http://cr.opensolaris.org/~tmueller/cr-unittests/
client.py:
- So is anything printed if the AttributeError is thrown? That is, does
the user have any idea the new BE hasn't been created? Given the
sketchiness of the way this is done right now -- relying on BE creation
to print a message, so sticking the success message printing in the try
block -- there should be a comment explaining that the AttributeError
is thrown by the dereferencing of "be" in the msg() call. I'm not sure
what the best answer for this mess is.
image.py:
- Why do you wrap update_installed_pkgs() in a try block, but you don't
make any attempt to do so for the catalog retrieval. Perhaps I wasn't
looking hard enough, but I didn't see how that didn't trigger an
exception if you didn't have permissions, either.
t_unix_usergrp.py:
- This test now seems pretty circular. I'm not sure it's worthwhile as
is. Perhaps bow out of the function if we're on MacOS?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
