Danek Duvall wrote:
> On Wed, Jan 21, 2009 at 09:40:01AM -0600, Tom Mueller wrote:
>
>
>> http://cr.opensolaris.org/~tmueller/cr-unittests-2/
>>
>
> image.py:
>
> - line 1156: I don't understand the comment -- of course the directory
> still exists -- the rmdir() failed. I'd also recast the second
> sentence as "Try to determine its emptiness another way".
>
Since we got an EACCES, we don't really know if the directory exists or
if it has content. If the directory that contains the directory is not
be readable by the user, we get the EACCES. There are several other
ways that the os.rmdir can return EACCES even though the state/installed
directory exists and has content.
I'll change the second sentence as you recommend. I'll change the first
sentence to:
The directory may exist and be non-empty even though we got EACCES.
Thanks for reviewing this again.
Tom
> Otherwise, looks fine.
>
> Danek
>
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
