On Thu, Jan 15, 2009 at 05:02:18PM -0800, [email protected] wrote:

> http://cr.opensolaris.org/~johansen/pkg-686/

Aside from the stuff we chatted about:

image.py:

  - line 1386: this method isn't used anywhere else; it should be prefixed
    with a double underscore

  - line 1419: no need for str() when passing to %s

  - line 1432: this comment really belongs in _valid_versions_test()

  - line 1463: "all" -> "any".  "remote servers" -> "authorities"?

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to