Shawn, Thanks for the review.
> > http://cr.opensolaris.org/~johansen/pkg-686/ > > Copyright years need updating? Probably. I'll double-check. > src/client.py: > I can't help but wonder if --no-net-checks should be a global > command-line option instead of one that is per-subcommand. That would > certainly be easier to document and allow us to not worry about which > commands may or may not trigger network checks or access. I've removed this entirely since Danek suggested a different approach for the checks. > Would InvalidVersionsException be better named as > InvalidAuthorityException or InvalidRepositoryException, etc.? I chose InvalidVersions because the command is parsing the output of versions/0. InvalidDepotException or InvalidRepositoryException sound alright to me. I'm starting to get confused by our terminologoy, though. Do we call the pkg server a depot in documentation and error messages that users see? It would probably be best to use whatever term we've defined for the server. > client/api_errors.py: > line 238: extra newline? Fixed, thanks. > client/image.py: > line 1463: don't you mean "any" instead of "all" since we just need one? Thanks. Already fixed. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
