[email protected] wrote: > The following webrev attempts to address problems where the client > thinks that it's talking to a valid package server, but really isn't. > This can happen due to mis-configuration or wifi subterfuge. > > http://cr.opensolaris.org/~johansen/pkg-686/ > > This change is relatively straight forward. In certain cases the client > checks that the server exists and can answer pkg specific HTTP requests. > Otherwise, it returns an error.
Copyright years need updating? src/client.py: I can't help but wonder if --no-net-checks should be a global command-line option instead of one that is per-subcommand. That would certainly be easier to document and allow us to not worry about which commands may or may not trigger network checks or access. I also wonder if this option should be "--no-authority-checks" to make this more agnostic in the face of possible, future transport methods. Would InvalidVersionsException be better named as InvalidAuthorityException or InvalidRepositoryException, etc.? client/api_errors.py: line 238: extra newline? client/image.py: line 1463: don't you mean "any" instead of "all" since we just need one? Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
