Danek,

Thanks for the speedy review.

> Aside from the stuff we chatted about:

I'll implement those changes and file a bug before I send out a new
webrev.  Thanks for stopping by to chat.

> image.py:
> 
>   - line 1386: this method isn't used anywhere else; it should be prefixed
>     with a double underscore

Fixed.

>   - line 1419: no need for str() when passing to %s

Thanks, fixed.

>   - line 1432: this comment really belongs in _valid_versions_test()

Moved, thanks.

>   - line 1463: "all" -> "any".  "remote servers" -> "authorities"?

Changed.

-K
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to