[email protected] wrote: >>> http://cr.opensolaris.org/~johansen/pkg-686-2/ >>> >> client/image.py: >> line 727: extra newline >> >> line 1544: s/portal/portal./ >> > > Thanks for catching those. > > >> client/api.py: >> In this webrev, you don't appear to have made any real changes to >> this file; so is the version increment still needed? >> > > That's a good question. I added a new exception to api_errors.py. The > new version of the API will throw this exception whereas the previous > version won't. You could argue that I haven't really changed the > interface, just it's behavior. However, it seemed like it would be a > good idea to increase the revision number. > > Please bump the client.py version number since it's now catching the new exception and add documentation to what's changed in client_api_versions.txt in the docs dir. Other things lgtm.
Brock > -j > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
