Hi Christoph, thanks a lot for the patches.
Regarding your suggestion for pymol.bat: I guess this will not work if you install with a custom prefix, since you make assumptions where to find pythonw.exe and the pymol module. I suggest to discuss this off-list, since it's quite specific. Cheers, Thomas Christoph Gohlke wrote, On 03/25/13 18:11: > On 3/24/2013 3:02 AM, Thomas Holder wrote: >> Dear PyMOL users, >> >> The pre-release version of PyMOL 1.6 has been pushed to the open >> source repository on SourceForge. Besides several minor fixes and >> improvements, this version should complete the transition to >> shader-based rendering for all on-screen drawing. For non-integrated >> chipsets this typically means higher quality and quicker rendering. >> >> Please also note that the URL of the SVN repository changed due to an >> upgrade of the SourceForge website: >> >> svn co svn://svn.code.sf.net/p/pymol/code/trunk/pymol >> >> As always, we welcome bug reports and positive feedback. >> >> Cheers, >> >> - The PyMOL Team at Schrödinger >> > > Hello, > > Please consider the attached changes for building with msvc on Windows. > > Also, the latest changes to vmdir.h don't compile with msvc. > <http://sourceforge.net/p/pymol/code/4025/tree//trunk/pymol/contrib/uiuc/plugins/molfile_plugin/src/vmddir.h?diff=50c0fc56e88f3d0bdf694277:4024> > > > Opening absolute paths does not work on Windows (e.g. C:\1bna.pdb): > > Index: pymol/modules/pymol/internal.py > =================================================================== > --- pymol/modules/pymol/internal.py (revision 4025) > +++ pymol/modules/pymol/internal.py (working copy) > @@ -303,7 +303,7 @@ > try: > if not isinstance(finfo, basestring): > handle = finfo > - elif ':' in finfo: > + elif '://' in finfo: > import urllib > handle = urllib.urlopen(finfo) > else: > > > The launch script, Scripts\pymol.bat, seems overly complicated and > doesn't always work for binary installers. Suggestion: > > Index: pymol/setup.py > =================================================================== > --- pymol/setup.py (revision 4025) > +++ pymol/setup.py (working copy) > @@ -119,9 +119,7 @@ > > with open(launch_script, 'w') as out: > if sys.platform.startswith('win'): > - out.write('set PYMOL_PATH=' + pymol_path + os.linesep) > - out.write('"%s" "%s"' % (python_exe, pymol_file)) > - out.write(' %1 %2 %3 %4 %5 %6 %7 %8 %9' + os.linesep) > + out.write(r'@%~dp0\..\pythonw.exe -m pymol.__init__ %*') > else: > out.write('#!/bin/sh' + os.linesep) > if sys.platform.startswith('darwin'): > > > Thanks, > > Christoph -- Thomas Holder PyMOL Developer Schrödinger Contractor ------------------------------------------------------------------------------ Own the Future-Intel® Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d _______________________________________________ PyMOL-users mailing list (PyMOL-users@lists.sourceforge.net) Info Page: https://lists.sourceforge.net/lists/listinfo/pymol-users Archives: http://www.mail-archive.com/pymol-users@lists.sourceforge.net
