On 28/5/26 21:40, Pierrick Bouvier wrote:
On 5/27/2026 1:13 PM, Philippe Mathieu-Daudé wrote:
Rather than adapting the array endianness when it it
filled, directly initialize the CODE words with the
correct endianness.

Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
  hw/riscv/boot.c | 30 +++++++++++++-----------------
  1 file changed, 13 insertions(+), 17 deletions(-)


One could argue original version is more readable.
Any specific reason for rewriting things this way (performance, personal
preference, other)?
Not a blocker, just want to understand the original motivation.

Looking at the following changes, I think it makes more sense to
have the CODE section const little-endian, while the DATA section
is swapped. Otherwise we'd need 2 distinct loops.


Reviewed-by: Pierrick Bouvier <[email protected]>

Regards,
Pierrick


Reply via email to