ye yuqiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13188 )
Change subject: replace nvml with memkind ...................................................................... Patch Set 9: > The TSAN version of client_symbol-test failed with: > > Found bad symbol 'operator delete[](void*)' > Found bad symbol 'operator delete[](void*, std::nothrow_t const&)' > Found bad symbol 'operator delete(void*)' > Found bad symbol 'operator delete(void*, std::nothrow_t const&)' > Found bad symbol 'operator new[](unsigned long)' > Found bad symbol 'operator new[](unsigned long, std::nothrow_t > const&)' > Found bad symbol 'operator new(unsigned long)' > Found bad symbol 'operator new(unsigned long, std::nothrow_t > const&)' > > These are probably jemalloc symbols, but it's strange that it only > manifested in the TSAN build. TSAN and RELEASE should have some logic for jemalloc compiling since it's a dependency for memkind. I did not find these symbol in jemalloc or memkind, but they are in llvm tsan_new_delete.cc Also, there's another unit test failure. http://dist-test.cloudera.org/job?job_id=jenkins-slave.1558363209.16531 1) testBasicMasterOperations(org.apache.kudu.client.TestAuthTokenReacquire) java.lang.AssertionError: test failed: unexpected errors at org.junit.Assert.fail(Assert.java:88) at org.apache.kudu.client.TestAuthTokenReacquire.testBasicMasterOperations(TestAuthTokenReacquire.java:153) I am still not sure how the patch will affect this unit test and other 5 unit test in DEBUG -- To view, visit http://gerrit.cloudera.org:8080/13188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08855c62bc42b9e6f7a4b3bfa27a708ed2c133f5 Gerrit-Change-Number: 13188 Gerrit-PatchSet: 9 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Tue, 21 May 2019 03:16:08 +0000 Gerrit-HasComments: No
