ye yuqiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13188 )
Change subject: replace nvml with memkind ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/13188/9/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/13188/9/thirdparty/build-definitions.sh@754 PS9, Line 754: $NUMACTL_SOURCE/configure \ > Could we feed EXTRA_CFLAGS, EXTRA_CXXFLAGS (if numactl is C++), LDFLAGS, an numactl can not pass the compile with tsan. Will have some issue like undefined reference to `__tsan_init' for some numa benchmark code, but no option to separate them from source code when we build numactl. Since it only a dependency for memkind, is it a MUST for us to add these flags? http://gerrit.cloudera.org:8080/#/c/13188/9/thirdparty/build-definitions.sh@777 PS9, Line 777: CFLAGS="$EXTRA_CFLAGS -O3" \ > thirdparty/build-thirdparty.sh sets -O2 in EXTRA_CXXFLAGS. Perhaps we shoul EXTRA_CXXFLAGS does not work for memkind. It's strange since I can find this FLAGS in memkind configure help. So I have to add -O3 in CFLAGS (will change to O2 if it's better) -- To view, visit http://gerrit.cloudera.org:8080/13188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08855c62bc42b9e6f7a4b3bfa27a708ed2c133f5 Gerrit-Change-Number: 13188 Gerrit-PatchSet: 9 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Tue, 21 May 2019 03:38:12 +0000 Gerrit-HasComments: Yes
