Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13188 )
Change subject: replace nvml with memkind ...................................................................... Patch Set 9: (2 comments) > Also, there's another unit test failure. > http://dist-test.cloudera.org/job?job_id=jenkins-slave.1558363209.16531 > > 1) testBasicMasterOperations(org.apache.kudu.client.TestAuthTokenReacquire) > java.lang.AssertionError: test failed: unexpected errors > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.kudu.client.TestAuthTokenReacquire.testBasicMasterOperations(TestAuthTokenReacquire.java:153) > > I am still not sure how the patch will affect this unit test and other 5 unit > test in DEBUG This failure is unrelated to your patch and you can ignore it. http://gerrit.cloudera.org:8080/#/c/13188/9/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/13188/9/thirdparty/build-definitions.sh@754 PS9, Line 754: $NUMACTL_SOURCE/configure \ > numactl can not pass the compile with tsan. Will have some issue like undef I tested this locally, and I was able to both repro the build error and fix it: Failed: CC=/home/adar/Source/kudu/thirdparty/clang-toolchain/bin/clang CFLAGS=-fsanitize=thread LDFLAGS="-L/home/adar/Source/kudu/thirdparty/installed/tsan/lib -Wl,-rpath=/home/adar/Source/kudu/thirdparty/installed/tsan/lib" ./configure && make Passed: CC=/home/adar/Source/kudu/thirdparty/clang-toolchain/bin/clang CFLAGS=-fsanitize=thread LDFLAGS="-fsanitize=thread -L/home/adar/Source/kudu/thirdparty/installed/tsan/lib -Wl,-rpath=/home/adar/Source/kudu/thirdparty/installed/tsan/lib" ./configure && make It seems like it's necessary to add -fsanitize=thread to LDFLAGS too. You can do that locally, or you could try to add it to EXTRA_LDFLAGS globally. http://gerrit.cloudera.org:8080/#/c/13188/9/thirdparty/build-definitions.sh@777 PS9, Line 777: CFLAGS="$EXTRA_CFLAGS -O3" \ > EXTRA_CXXFLAGS does not work for memkind. It's strange since I can find thi Yeah, memkind will ignore CXXFLAGS because it's not a C++ library. But hopefully CFLAGS will do the trick. -- To view, visit http://gerrit.cloudera.org:8080/13188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08855c62bc42b9e6f7a4b3bfa27a708ed2c133f5 Gerrit-Change-Number: 13188 Gerrit-PatchSet: 9 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2019 19:03:12 +0000 Gerrit-HasComments: Yes
