[Bug 825517] Review Request: egtk - The eGTK (elementary GTK) themes for GTK+2, GTK+3, Metacity and Xfwm4
https://bugzilla.redhat.com/show_bug.cgi?id=825517
--- Comment #6 from Mattia Meneguzzo ---
(In reply to comment #5)
> Your packages have to depend on the base package:
>
> Requires: %{name} = %{version}-%{release}
>
> See http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
So, what I should do is adding that "Requires" line to all of the "%package"
sections (including that related to the "common" subpackage)?
But then, when I try to install the packages built from the so-edited Spec
file, Yum complains about them requiring "egtk = 3.1-3.fc17" and doesn't allow
me to install.
Isn't "Requires: egtk-common" in all "%package" sections (except "common")
enough?
For example, have a look at the Spec file of this package:
http://kojipkgs.fedoraproject.org//packages/gnome-shell-extensions/3.4.0/1.fc17/src/gnome-shell-extensions-3.4.0-1.fc17.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833411] Review Request: realmd - Kerberos realm enrollment service
https://bugzilla.redhat.com/show_bug.cgi?id=833411 Matthias Clasen changed: What|Removed |Added CC||mcla...@redhat.com --- Comment #8 from Matthias Clasen --- I am a sponsor, and can sponsor you. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826563] Review Request: fuelmanager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 kc8...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826563] Review Request: fuelmanager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 kc8...@gmail.com changed: What|Removed |Added Summary|Review Request: Fuel|Review Request: fuelmanager |Manager - keep track of |- keep track of your fuel |your fuel mileage and |mileage and consumption |consumption | --- Comment #9 from kc8...@gmail.com --- New Package SCM Request === Package Name: fuelmanager Short Description: keep track of fuel mileage Owners: kc8hfi Branches: f16 f17 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834582] Review Request: java-deptools - Java RPM dependency tools
https://bugzilla.redhat.com/show_bug.cgi?id=834582 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826563] Review Request: Fuel Manager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 --- Comment #8 from Jon Ciesla --- SCM request package name and Bug summary package name don't match, please fix. Preferably fuelmanager. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826563] Review Request: Fuel Manager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 kc8...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from kc8...@gmail.com --- New Package SCM Request === Package Name: fuelmanager Short Description: keep track of fuel mileage Owners: kc8hfi Branches: f16 f17 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 808258] Review Request: python-sh - Python module to simplify calling shell commands
https://bugzilla.redhat.com/show_bug.cgi?id=808258 Ralph Bean changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|rb...@redhat.com Flags||fedora-review? --- Comment #12 from Ralph Bean --- Hi Andy - that sounds good! I'm all-in with co-maintaining this one. :) For formality's sake, can you run the script and patch the README like you said but also add a link back to this bug? Upload a new release of the srpm and spec and I'll do the reviewer's duty. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834098] Review Request: python-m2ext - M2Crypto Extensions.
https://bugzilla.redhat.com/show_bug.cgi?id=834098 --- Comment #5 from Ralph Bean --- Links to bodhi updates: - https://admin.fedoraproject.org/updates/FEDORA-2012-9765/python-m2ext-0.1-1.fc17?_csrf_token=9f36fbc08eaaf50e708ff3ee3ee078112759a9dd - https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-6218/python-m2ext-0.1-1.el6?_csrf_token=9f36fbc08eaaf50e708ff3ee3ee078112759a9dd -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834681] Review Request: python-sieve - XML Comparison Utils
https://bugzilla.redhat.com/show_bug.cgi?id=834681 Ralph Bean changed: What|Removed |Added Depends On||834732 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759823] Review Request: libkdtree++ - C++ template container implementation of kd-tree sorting
https://bugzilla.redhat.com/show_bug.cgi?id=759823 --- Comment #8 from Eric Smith --- Spec URL: http://fedorapeople.org/~brouhaha/libkdtree++/libkdtree++.spec SRPM URL: http://fedorapeople.org/~brouhaha/libkdtree++/libkdtree++-0.7.0-1.fc14.src.rpm Koji scratch build for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4189561 Updated based on Rich's comments. Added check section to spec includes pkg-config file includes Python bindings -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 759823] Review Request: libkdtree++ - C++ template container implementation of kd-tree sorting
https://bugzilla.redhat.com/show_bug.cgi?id=759823 --- Comment #7 from Eric Smith --- It doesn't appear to me that there was any consensus reached nor action taken regarding Michael's inquiry to the Fedora-Packaging list. I can't imagine any practical manner to treat C++ templates in -devel package other than simply allowing them. C++ templates, like Ada generics, *must* be compiled into an executable to be used. There is no way to turn them into a shared library. If this is considered to run afoul of Fedora's library packaging requirements, then Fedora will have to drop the C++ Standard Template Library (which would make Fedora non-compliant with the C++ standard), Boost, and many other packages. Given that the STL, Boost, and other C++ templates are in fact in Fedora, the only conclusion I can reach is that templates in C++ headers are allowed in -devel packages. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154
--- Comment #6 from Gerard Ryan ---
Spec URL:
http://galileo.fedorapeople.org/eclipse-wtp-jeetools/3.4.0/0.2.20120618cvs/eclipse-wtp-jeetools.spec
SRPM URL:
http://galileo.fedorapeople.org/eclipse-wtp-jeetools/3.4.0/0.2.20120618cvs/eclipse-wtp-jeetools-3.4.0-0.2.20120618cvs.fc17.src.rpm
- changed the patch names to be properly prefixed by %{name}
- added min versions to all BR/R except java and jpackage-utils
In your first review, it seems that eclipse-wtp-webservices wasn't included as
a dependency for some reason, even though it's in rawhide, as linked in comment
#4 above. Any ideas why that might be? Is there something I haven't done with
that package that's preventing it?
Thanks again for your time!
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816071] Review Request: f3 - Utility to test for fake flash drives and cards
https://bugzilla.redhat.com/show_bug.cgi?id=816071 Eric Smith changed: What|Removed |Added Flags|needinfo?(e...@brouhaha.com | |) | --- Comment #2 from Eric Smith --- Spec URL: http://fedorapeople.org/~brouhaha/f3/f3.spec SRPM URL: http://fedorapeople.org/~brouhaha/f3/f3-2-2.fc16.src.rpm Koji scratch build for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4189363 Updated per review comments. I believe the English grammar and usage is correct; as you point out, "filesystem" is domain-specific jargon. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787713] Review request: FreeSOLID - A 3D collision detection C++ library
https://bugzilla.redhat.com/show_bug.cgi?id=787713 --- Comment #30 from MartinKG --- %changelog * Fri Jun 22 2012 Martin Gansser 2.1.1-8.fc17 - added configure patch - rebuild for Fedora 17 Spec URL: http://dev.speed-dreams.org/Martin/FreeSOLID.spec SRPM URL: http://dev.speed-dreams.org/Martin/FreeSOLID-2.1.1-8.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785371] Review request: speed-dreams - The Open Racing Car Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=785371 --- Comment #37 from MartinKG --- Spec URL: http://dev.speed-dreams.org/Martin/speed-dreams.spec SRPM URL: http://dev.speed-dreams.org/Martin/speed-dreams-2.0.0-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834582] Review Request: java-deptools - Java RPM dependency tools
https://bugzilla.redhat.com/show_bug.cgi?id=834582 Mikolaj Izdebski changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Mikolaj Izdebski --- Thank you! New Package SCM Request === Package Name: java-deptools Short Description: Java RPM dependency tools Owners: mizdebsk Branches: f17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834681] New: Review Request: python-sieve - XML Comparison Utils
https://bugzilla.redhat.com/show_bug.cgi?id=834681
Bug ID: 834681
QA Contact: extras...@fedoraproject.org
Severity: medium
Version: rawhide
Priority: medium
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Assignee: nob...@fedoraproject.org
Summary: Review Request: python-sieve - XML Comparison Utils
Regression: ---
Story Points: ---
Classification: Fedora
OS: Linux
Reporter: rb...@redhat.com
Type: ---
Documentation: ---
Hardware: All
Mount Type: ---
Status: NEW
Component: Package Review
Product: Fedora
Spec URL: http://threebean.org/rpm/python-sieve.spec
SRPM URL: http://threebean.org/rpm/python-sieve-0.1.6-1.fc17.src.rpm
Description: XML Comparison Utils
Fedora Account System Username: ralph
rpmlint output:
--- ~/rpmbuild » rpmlint {SPECS,SRPMS}/python-sieve*
python-sieve.src: W: spelling-error %description -l en_US webapp -> web app,
web-app, weapon
python-sieve.src: W: spelling-error %description -l en_US eq -> e, q, seq
python-sieve.src: W: spelling-error %description -l en_US xml -> XML, ml, x ml
python-sieve.src: W: spelling-error %description -l en_US html -> HTML, ht ml,
ht-ml
1 packages and 1 specfiles checked; 0 errors, 4 warnings.
--- ~/rpmbuild » rpmlint /var/lib/mock/fedora-17-x86_64/result/*.rpm
python3-sieve.noarch: W: spelling-error %description -l en_US webapp -> web
app, web-app, weapon
python3-sieve.noarch: W: spelling-error %description -l en_US eq -> e, q, seq
python3-sieve.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x
ml
python3-sieve.noarch: W: spelling-error %description -l en_US html -> HTML, ht
ml, ht-ml
python-sieve.noarch: W: spelling-error %description -l en_US webapp -> web app,
web-app, weapon
python-sieve.noarch: W: spelling-error %description -l en_US eq -> e, q, seq
python-sieve.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x
ml
python-sieve.noarch: W: spelling-error %description -l en_US html -> HTML, ht
ml, ht-ml
python-sieve.src: W: spelling-error %description -l en_US webapp -> web app,
web-app, weapon
python-sieve.src: W: spelling-error %description -l en_US eq -> e, q, seq
python-sieve.src: W: spelling-error %description -l en_US xml -> XML, ml, x ml
python-sieve.src: W: spelling-error %description -l en_US html -> HTML, ht ml,
ht-ml
3 packages and 0 specfiles checked; 0 errors, 12 warnings.
koji f17 - http://koji.fedoraproject.org/koji/taskinfo?taskID=4189062
koji el6 - http://koji.fedoraproject.org/koji/taskinfo?taskID=4189060
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 820995] Review Request: java-oauth - An open protocol to allow API authentication
https://bugzilla.redhat.com/show_bug.cgi?id=820995 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-06-22 14:56:30 --- Comment #10 from Fedora Update System --- java-oauth-20100601-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829745] Review Request: shrinkwrap-resolver - ShrinkWrap Resolver
https://bugzilla.redhat.com/show_bug.cgi?id=829745 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-06-22 14:56:19 --- Comment #10 from Fedora Update System --- shrinkwrap-resolver-1.0.0-0.1.beta7.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830811] Review Request: perl-No-Worries - Perl coding without worries
https://bugzilla.redhat.com/show_bug.cgi?id=830811 --- Comment #17 from Fedora Update System --- perl-No-Worries-0.3-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834582] Review Request: java-deptools - Java RPM dependency tools
https://bugzilla.redhat.com/show_bug.cgi?id=834582
Gerard Ryan changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Gerard Ryan ---
(In reply to comment #3)
> It really *IS* named %{name}.spec. You can extract the SRPM and you'll see
> it is named "java-deptools.spec". Only the name in the URL used only for
> this review is different.
>
Ah yes, my mistake (or the mistake of fedora-review tool, rather).
>
> Guidelines says that "original files" should have their timestamps
> preserved, but files in "target/site/apidocs" are NOT original files -- they
> are being generated during build time. Their times are set during the build
> time and preserving them makes no sense. The only original file, pom.xml,
> does have its timestamp preserved.
Yes, you are right!
Everything else looks good, thanks for such a useful tool!
*** APPROVED ***
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830811] Review Request: perl-No-Worries - Perl coding without worries
https://bugzilla.redhat.com/show_bug.cgi?id=830811 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-06-22 14:54:15 --- Comment #16 from Fedora Update System --- perl-No-Worries-0.3-2.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830711] Review Request: jbosgi-metadata - JBoss OSGi Metadata
https://bugzilla.redhat.com/show_bug.cgi?id=830711 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-06-22 14:52:51 --- Comment #9 from Fedora Update System --- jbosgi-metadata-2.0.3-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825517] Review Request: egtk - The eGTK (elementary GTK) themes for GTK+2, GTK+3, Metacity and Xfwm4
https://bugzilla.redhat.com/show_bug.cgi?id=825517
--- Comment #5 from Mario Blättermann ---
Your packages have to depend on the base package:
Requires: %{name} = %{version}-%{release}
See http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834582] Review Request: java-deptools - Java RPM dependency tools
https://bugzilla.redhat.com/show_bug.cgi?id=834582
--- Comment #3 from Mikolaj Izdebski ---
(In reply to comment #2)
> 1. Changelog entry version is incorrect
> java-deptools.noarch: W: incoherent-version-in-changelog
> 0-0.1.20120621git20120621 ['0-0.1.20120621git2a6a72d.fc18',
> '0-0.1.20120621git2a6a72d']
Corrected:
Spec URL:
http://mizdebsk.fedorapeople.org/review/java-deptools/java-deptools-0-0.2.20120621git2a6a72d.spec
SRPM URL:
http://mizdebsk.fedorapeople.org/review/java-deptools/java-deptools-0-0.2.20120621git2a6a72d.fc16.src.rpm
> 2. specfile name should be java-deptools.spec
> [!]: MUST Spec file name must match the spec package %{name}, in the format
> %{name}.spec.
It really *IS* named %{name}.spec. You can extract the SRPM and you'll see it
is named "java-deptools.spec". Only the name in the URL used only for this
review is different.
> 3. Line 60 of specfile should have 'cp -pR' instead of 'cp -R'
> [!]: SHOULD Packages should try to preserve timestamps of original installed
> files.
Guidelines says that "original files" should have their timestamps preserved,
but files in "target/site/apidocs" are NOT original files -- they are being
generated during build time. Their times are set during the build time and
preserving them makes no sense. The only original file, pom.xml, does have its
timestamp preserved.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834582] Review Request: java-deptools - Java RPM dependency tools
https://bugzilla.redhat.com/show_bug.cgi?id=834582
--- Comment #2 from Gerard Ryan ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint java-deptools-0-0.1.20120621git2a6a72d.fc18.src.rpm
java-deptools.src: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint java-deptools-0-0.1.20120621git2a6a72d.fc18.noarch.rpm
java-deptools.noarch: I: enchant-dictionary-not-found en_US
java-deptools.noarch: W: incoherent-version-in-changelog
0-0.1.20120621git20120621 ['0-0.1.20120621git2a6a72d.fc18',
'0-0.1.20120621git2a6a72d']
java-deptools.noarch: W: class-path-in-manifest
/usr/share/java/java-deptools.jar
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint java-deptools-javadoc-0-0.1.20120621git2a6a72d.fc18.noarch.rpm
java-deptools-javadoc.noarch: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/packager/review/834582/ :
MD5SUM this package : None
MD5SUM upstream package : None
[x]: MUST Spec file is legible and written in American English.
[!]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
Note: java-deptools-0-0.1.20120621git2a6a72d.spec should be java-
deptools.spec
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languag
[Bug 805327] Review Request: pyrasite-gui - A graphical interface for monitoring and introspecting Python
https://bugzilla.redhat.com/show_bug.cgi?id=805327 Luke Macken changed: What|Removed |Added Flags||needinfo?(i...@ianweller.org ||) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739016] Review Request: erlang-poolboy - A hunky Erlang worker pool factory
https://bugzilla.redhat.com/show_bug.cgi?id=739016 --- Comment #14 from Fedora Update System --- erlang-poolboy-0.7.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 --- Comment #14 from Fedora Update System --- spacewalk-pylint-0.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 --- Comment #14 from Fedora Update System --- erlang-egeoip-0-0.3.20111025git45c32ad.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739014] Review Request: erlang-lager - A logging framework for Erlang/OTP
https://bugzilla.redhat.com/show_bug.cgi?id=739014 --- Comment #15 from Fedora Update System --- erlang-lager-1.0.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 --- Comment #13 from Fedora Update System --- spacewalk-pylint-0.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816124] Review Request: libdb4 - Oracle (Berkeley) DB package 4.x.x series
https://bugzilla.redhat.com/show_bug.cgi?id=816124 --- Comment #39 from Jon Ciesla --- Now it's just: ibdb4.x86_64: W: obsolete-not-provided db4 libdb4-cxx.x86_64: W: obsolete-not-provided db4-cxx libdb4-cxx-devel.x86_64: W: obsolete-not-provided db4-cxx-devel libdb4-devel.x86_64: W: obsolete-not-provided db4-devel libdb4-devel-static.x86_64: W: obsolete-not-provided db4-devel-static libdb4-java.x86_64: W: obsolete-not-provided db4-java libdb4-tcl.x86_64: W: obsolete-not-provided db4-tcl libdb4-utils.x86_64: W: obsolete-not-provided db4-utils If a package is obsoleted by a compatible replacement, the obsoleted package should also be provided in order to not cause unnecessary dependency breakage. If the obsoleting package is not a compatible replacement for the old one, leave out the Provides. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 Jitka Plesnikova changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Flags|fedora-cvs+ |fedora-cvs? Last Closed||2012-06-22 10:42:02 --- Comment #6 from Jitka Plesnikova --- Thank you for the review and the repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834582] Review Request: java-deptools - Java RPM dependency tools
https://bugzilla.redhat.com/show_bug.cgi?id=834582 Gerard Ryan changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|ger...@ryan.lt Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834582] Review Request: java-deptools - Java RPM dependency tools
https://bugzilla.redhat.com/show_bug.cgi?id=834582 Gerard Ryan changed: What|Removed |Added CC||ger...@ryan.lt --- Comment #1 from Gerard Ryan --- I'm taking this. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 Jitka Plesnikova changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Jitka Plesnikova --- New Package SCM Request === Package Name: perl-Devel-StringInfo Short Description: Gather information about strings Owners: jplesnik mmaslano ppisar psabata Branches: InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834582] Review Request: java-deptools - Java RPM dependency tools
https://bugzilla.redhat.com/show_bug.cgi?id=834582 Mikolaj Izdebski changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834582] New: Review Request: java-deptools - Java RPM dependency tools
https://bugzilla.redhat.com/show_bug.cgi?id=834582 Bug ID: 834582 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: java-deptools - Java RPM dependency tools Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: mizde...@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://mizdebsk.fedorapeople.org/review/java-deptools/java-deptools-0-0.1.20120621git2a6a72d.spec SRPM URL: http://mizdebsk.fedorapeople.org/review/java-deptools/java-deptools-0-0.1.20120621git2a6a72d.fc16.src.rpm Description: This package provides tools for tracking dependencies between Java packages in RPM-based distributions. Fedora Account System Username: mizdebsk -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516
Petr Pisar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar ---
Spec file changes:
--- perl-Devel-StringInfo.spec.old 2012-06-22 10:00:53.0 +0200
+++ perl-Devel-StringInfo.spec 2012-06-22 15:41:42.0 +0200
@@ -2,7 +2,7 @@
Version:0.04
Release:1%{?dist}
Summary:Gather information about strings
-License:GPL+ or Artistic
+License:GPL+ or Artistic or MIT
Group: Development/Libraries
URL:http://search.cpan.org/dist/Devel-StringInfo/
Source0:
http://www.cpan.org/authors/id/N/NU/NUFFIN/Devel-StringInfo-%{version}.tar.gz
@@ -20,6 +20,8 @@
BuildRequires: perl(Tie::IxHash)
BuildRequires: perl(YAML)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
+Requires: perl(Data::HexDump::XXD)
+Requires: perl(YAML)
%description
This module is a debugging aid that helps figure out more information
@@ -33,8 +35,6 @@
make %{?_smp_mflags}
%install
-rm -rf $RPM_BUILD_ROOT
-
make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
> FIX: Add `or MIT' to the licenses (lib/Devel/StringInfo.pm).
-License:GPL+ or Artistic
+License:GPL+ or Artistic or MIT
Ok.
> FIX: Run-require `perl(YAML)' (lib/Devel/StringInfo.pm:77).
+Requires: perl(YAML)
Ok.
> FIX: Run-require `perl(Data::HexDump::XXD)' (lib/Devel/StringInfo.pm:91).
+Requires: perl(Data::HexDump::XXD)
Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm |sort |uniq -c
1 perl(Data::HexDump::XXD)
1 perl(Encode)
1 perl(Encode::Guess)
1 perl(:MODULE_COMPAT_5.14.2)
1 perl(Moose)
1 perl(namespace::clean)
1 perl(Scalar::Util)
1 perl(Sub::Exporter)
1 perl(Tie::IxHash)
1 perl(utf8)
1 perl(YAML)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
Package builds in F18
(http://koji.fedoraproject.org/koji/taskinfo?taskID=4188268). Ok.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 --- Comment #2 from Jitka Plesnikova --- Updated. http://koji.fedoraproject.org/koji/taskinfo?taskID=4188205 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 --- Comment #5 from Gerard Ryan --- Issue (3): For the eclipse bundles, I understand that the versions for the osgi bundles are specified in the MANIFEST.MF files for each plugin. At the moment, they look like this by default: org.eclipse.wst.wsdl;bundle-version="[1.2.0,1.3.0)" - is that enough or should they require the exact bundle that's packaged in Fedora? In which case the above example would look like: org.eclipse.wst.wsdl;bundle-version="1.2.300" The default in that example seems to work fine[1]. I don't know why none of that stuff was being picked up when you tried to build. [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=4187879 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833462] Review Request: hawkey - A Library providing simplified C and Python API to libsolv
https://bugzilla.redhat.com/show_bug.cgi?id=833462 --- Comment #7 from Ales Kozumplik --- Updated version: http://akozumpl.fedorapeople.org/review/hawkey_3/hawkey.spec http://akozumpl.fedorapeople.org/review/hawkey_3/hawkey-0.2.4-7.git04ecf00.fc17.src.rpm I tried to resolve your comments, except: (In reply to comment #6) > https://fedoraproject.org/wiki/Packaging:ReviewGuidelines > > > > BuildRequires: python2 python2-devel > > This build requirement doesn't match the run-time requirement further below, > which makes it unsafe and not precise enough: > > | %package -n python-hawkey > | Requires: python > > Plus, > https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires > also applies here, and a comment in the spec file would be good. Not sure what you are suggesting should happen here here besides changing 'python' to 'python2'. Thanks, Ales -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834574] Review Request: reflections - Java run time meta data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=834574 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834574] Review Request: reflections - Java run time meta data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=834574 --- Comment #1 from gil cattaneo --- tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=4188033 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799089] Review Request: dyninst - An API for Run-time Code Generation
https://bugzilla.redhat.com/show_bug.cgi?id=799089 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833573] Review Request: nettle - Low level crytopgraphic library
https://bugzilla.redhat.com/show_bug.cgi?id=833573 --- Comment #7 from Michael Cronenworth --- Michael, thanks for the comments, but I have not posted a new spec yet due to the indecision on the package name. Fedora previously had this library as "nettle": https://admin.fedoraproject.org/pkgdb/acls/name/nettle If someone could give me a straight answer on the package name I can finish fixing the spec file. I do not have a preference of "nettle" or "libnettle". I just need to know which to put up for review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834574] New: Review Request: reflections - Java run time meta data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=834574 Bug ID: 834574 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: reflections - Java run time meta data analysis Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: punto...@libero.it Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://gil.fedorapeople.org/reflections.spec SRPM URL: http://gil.fedorapeople.org/reflections-0.9.8-1.fc16.src.rpm Description: A Java run time meta data analysis, in the spirit of Scannotations Reflections scans your classpath, indexes the meta data, allows you to query it on run time and may save and collect that information for many modules within your project. Using Reflections you can query your meta data such as: * get all sub types of some type * get all types/methods/fields annotated with some annotation, w/o annotation parameters matching * get all resources matching matching a regular expression Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799089] Review Request: dyninst - An API for Run-time Code Generation
https://bugzilla.redhat.com/show_bug.cgi?id=799089 William Cohen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from William Cohen --- New Package SCM Request === Package Name: dyninst Short Description: An API for Run-time Code Generation Owners: wcohen Branches: devel InitialCC: fche -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 --- Comment #1 from Petr Pisar --- Source file is original. Ok. Summary verified from lib/Devel/StringInfo.pm. FIX: Add `or MIT' to the licenses (lib/Devel/StringInfo.pm). Description verified from lib/Devel/StringInfo.pm. Ok. No XS code, noarch BuildArch is Ok. URL and Source0 are usable. Ok. Build-requires are Ok. All tests pass. Ok. $ rpmlint perl-Devel-StringInfo.spec ../SRPMS/perl-Devel-StringInfo-0.04-1.fc18.src.rpm ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm drwxr-xr-x2 rootroot0 Jun 22 15:04 /usr/share/doc/perl-Devel-StringInfo-0.04 -rw-r--r--1 rootroot 160 May 14 2009 /usr/share/doc/perl-Devel-StringInfo-0.04/Changes -rw-r--r--1 rootroot 3365 Jun 22 15:04 /usr/share/man/man3/Devel::StringInfo.3pm.gz drwxr-xr-x2 rootroot0 Jun 22 15:04 /usr/share/perl5/vendor_perl/Devel -rw-r--r--1 rootroot 7976 May 14 2009 /usr/share/perl5/vendor_perl/Devel/StringInfo.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm |sort |uniq -c 1 perl(Encode) 1 perl(Encode::Guess) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(Moose) 1 perl(namespace::clean) 1 perl(Scalar::Util) 1 perl(Sub::Exporter) 1 perl(Tie::IxHash) 1 perl(utf8) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require `perl(YAML)' (lib/Devel/StringInfo.pm:77). FIX: Run-require `perl(Data::HexDump::XXD)' (lib/Devel/StringInfo.pm:91). $ rpm -q --provides -p ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm |sort |uniq -c 1 perl(Devel::StringInfo) = 0.04 1 perl-Devel-StringInfo = 0.04-1.fc18 Binary provides are Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4188014). ??? Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' prefix issues and provides new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 Bug 834516 depends on bug 834512, which changed state. Bug 834512 Summary: Review Request: perl-Data-HexDump-XXD - Format hexadecimal dump like xxd https://bugzilla.redhat.com/show_bug.cgi?id=834512 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834512] Review Request: perl-Data-HexDump-XXD - Format hexadecimal dump like xxd
https://bugzilla.redhat.com/show_bug.cgi?id=834512 Jitka Plesnikova changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2012-06-22 08:42:23 --- Comment #4 from Jitka Plesnikova --- Thank you for the review and the repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834512] Review Request: perl-Data-HexDump-XXD - Format hexadecimal dump like xxd
https://bugzilla.redhat.com/show_bug.cgi?id=834512 --- Comment #3 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784239] Review Request: python-django-debug-toolbar - Configurable set of panels that display various debug information
https://bugzilla.redhat.com/show_bug.cgi?id=784239 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 --- Comment #4 from Gerard Ryan --- Thanks for taking this! Regarding Issue (1): Is this relating to the errors in this part?: [!]: MUST Package installs properly. All of the osgi packages that give an error there, are from eclipse-wtp-webservices, and indeed eclipse-wtp-webservices is throwing an error here. I don't understand this, as eclipse-wtp-webservices is already in rawhide[1]. Is it not finding this package, or am I misunderstanding the issue? [1] http://koji.fedoraproject.org/koji/packageinfo?packageID=14110 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825854] Review Request: zita-alsa-pcmi - alsa pcm libraries
https://bugzilla.redhat.com/show_bug.cgi?id=825854 --- Comment #24 from Jørn Lomax --- > This program is free software; you can redistribute it and/or modify > it under the terms of the GNU General Public License as published by > the Free Software Foundation; either version 2 of the License, or > (at your option) any later version. Doesn't that mean that it's possible to release it under GPLv3 at our option? There is no bugtracker or mailinglist for upstream as far as i know. I have contacted upstream about the patches and documentation. I will submit the updated package once i receive an answer from upstream -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784239] Review Request: python-django-debug-toolbar - Configurable set of panels that display various debug information
https://bugzilla.redhat.com/show_bug.cgi?id=784239 Matthias Runge changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #10 from Matthias Runge --- Package Change Request == Package Name: python-django-debug-toolbar New Branches: el6 Owners: mrunge -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834512] Review Request: perl-Data-HexDump-XXD - Format hexadecimal dump like xxd
https://bugzilla.redhat.com/show_bug.cgi?id=834512 Jitka Plesnikova changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Jitka Plesnikova --- New Package SCM Request === Package Name: perl-Data-HexDump-XXD Short Description: Format hexadecimal dump like xxd Owners: jplesnik mmaslano ppisar psabata Branches: InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|ppi...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834512] Review Request: perl-Data-HexDump-XXD - Format hexadecimal dump like xxd
https://bugzilla.redhat.com/show_bug.cgi?id=834512 Petr Pisar changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar --- Source file is original. Ok. Summary verified from lib/Data/HexDump/XXD.pm. Ok. License verified from lib/Data/HexDump/XXD.pm. Ok. Description verified from lib/Data/HexDump/XXD.pm. Ok. URL and Source0 are usable. Ok. TODO: You can remove the useless VERSION file from %doc No XS code, noarch BuildArch is Ok. TODO: You can remove cleaning the RPM_BUILD_ROOT from %install section. It's implicit. Build-time dependencies are Ok. All tests pass. Ok. $ rpmlint perl-Data-HexDump-XXD.spec ../SRPMS/perl-Data-HexDump-XXD-0.1.0-1.fc18.src.rpm ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm drwxr-xr-x2 rootroot0 Jun 22 13:21 /usr/share/doc/perl-Data-HexDump-XXD-0.1.0 -rw-r--r--1 rootroot 160 Nov 12 2007 /usr/share/doc/perl-Data-HexDump-XXD-0.1.0/Changes -rw-r--r--1 rootroot 805 Nov 12 2007 /usr/share/doc/perl-Data-HexDump-XXD-0.1.0/README -rw-r--r--1 rootroot 134 Nov 12 2007 /usr/share/doc/perl-Data-HexDump-XXD-0.1.0/VERSION -rw-r--r--1 rootroot 4842 Jun 22 13:21 /usr/share/man/man3/Data::HexDump::XXD.3pm.gz drwxr-xr-x2 rootroot0 Jun 22 13:21 /usr/share/perl5/vendor_perl/Data drwxr-xr-x2 rootroot0 Jun 22 13:21 /usr/share/perl5/vendor_perl/Data/HexDump -rw-r--r--1 rootroot 7490 Jun 22 13:21 /usr/share/perl5/vendor_perl/Data/HexDump/XXD.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm |sort |uniq -c 1 perl(base) 1 perl(Carp) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(version) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm |sort |uniq -c 1 perl(Data::HexDump::XXD) 1 perl-Data-HexDump-XXD = 0.1.0-1.fc18 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4187413). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' items before building this package. Resolution: Package APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834551] Review Request: poppler-sharp C sharp Bindings for Poppler
https://bugzilla.redhat.com/show_bug.cgi?id=834551 Ismael Olea changed: What|Removed |Added CC||elsupergo...@gmail.com --- Comment #1 from Ismael Olea --- *** Bug 607405 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834552] Review Request: pdfmod - A simple application for modifying PDF documents
https://bugzilla.redhat.com/show_bug.cgi?id=834552 Ismael Olea changed: What|Removed |Added CC||sebast...@when.com --- Comment #1 from Ismael Olea --- *** Bug 537640 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834548] Review Request: hyena - Hyena is a library of GUI and non-GUI C# code
https://bugzilla.redhat.com/show_bug.cgi?id=834548 Ismael Olea changed: What|Removed |Added Blocks||834552 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834552] Review Request: pdfmod - A simple application for modifying PDF documents
https://bugzilla.redhat.com/show_bug.cgi?id=834552 Ismael Olea changed: What|Removed |Added Depends On||834548, 834551 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834551] Review Request: poppler-sharp C sharp Bindings for Poppler
https://bugzilla.redhat.com/show_bug.cgi?id=834551 Ismael Olea changed: What|Removed |Added Blocks||834552 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834552] New: Review Request: pdfmod - A simple application for modifying PDF documents
https://bugzilla.redhat.com/show_bug.cgi?id=834552 Bug ID: 834552 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: pdfmod - A simple application for modifying PDF documents Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: ism...@olea.org Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://olea.org/tmp/pdfmod/pdfmod.spec SRPM URL: http://olea.org/tmp/pdfmod/pdfmod-0.9.1-2.fc17.src.rpm Description: You can reorder, rotate, and remove pages, export images from a document, edit the title, subject, author, and keywords, and combine documents via drag and drop. Fedora Account System Username: olea Related deps: #834548 and #834551 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834551] New: Review Request: poppler-sharp C sharp Bindings for Poppler
https://bugzilla.redhat.com/show_bug.cgi?id=834551 Bug ID: 834551 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: poppler-sharp C sharp Bindings for Poppler Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: ism...@olea.org Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://olea.org/tmp/pdfmod/poppler-sharp.spec SRPM URL: http://olea.org/tmp/pdfmod/poppler-sharp-0.0.3-1.fc17.src.rpm Description: Generates managed bindings for Poppler using the GAPI tools Fedora Account System Username: olea -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834548] Review Request: hyena - Hyena is a library of GUI and non-GUI C# code
https://bugzilla.redhat.com/show_bug.cgi?id=834548 Ismael Olea changed: What|Removed |Added CC||rle...@redhat.com --- Comment #1 from Ismael Olea --- *** Bug 530910 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834548] New: Review Request: hyena - Hyena is a library of GUI and non-GUI C# code
https://bugzilla.redhat.com/show_bug.cgi?id=834548 Bug ID: 834548 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: hyena - Hyena is a library of GUI and non-GUI C# code Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: ism...@olea.org Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://olea.org/tmp/pdfmod/hyena.spec SRPM URL: http://olea.org/tmp/pdfmod/hyena-0.5-2.fc17.src.rpm Description: This is a library of useful GUI and non-GUI C sharp code, originally used in Banshee. Fedora Account System Username: olea -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833573] Review Request: nettle - Low level crytopgraphic library
https://bugzilla.redhat.com/show_bug.cgi?id=833573
--- Comment #6 from Michael Schwendt ---
Just a brief look:
* https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming
As a precedent, Debian and openSUSE called it libnettle.
* https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
| MUST: rpmlint must be run on the source rpm and all binary rpms
| the build produces. The output should be posted in the review.[1]
That doesn't imply it's only the reviewer who must do this. rpmlint is also a
tool for packagers.
> Version: 2.5
> Release: 0.1pre%{?dist}
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages
A little bit pedantic, but Fedora adds another dot after the X.Y number:
Release: 0.1.pre%{?dist}
> License: LGPLv2.1+
https://fedoraproject.org/wiki/Licensing#Good_Licenses
> %package tools
> Group: System Environment/Libraries
As tools are not libraries, the package could fit into groups "System
Environment/Base" or "Development/Tools". The package description doesn't
expand on what these utility programs do, however.
> %package devel
> Summary: Development files for libnettle
> License: GPLv2+ and LGPLv2.1+
This will require a closer look. Why does the licensing here differ from the
base library packages?
> Requires: %{name} = %{version}-%{release}
> Requires: libhogweed = %{version}-%{release}
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
> %preun -p /sbin/ldconfig
>
> %preun -n libhogweed -p /sbin/ldconfig
%postun would be the correct place to execute this.
> %files tools
> %doc COPYING.LIB
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing
> testsuite
Please investigate whether this is suitable for running "make check" in the
%check section of the spec file.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833462] Review Request: hawkey - A Library providing simplified C and Python API to libsolv
https://bugzilla.redhat.com/show_bug.cgi?id=833462
--- Comment #6 from Michael Schwendt ---
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
| MUST: rpmlint must be run on the source rpm and all binary rpms
| the build produces. The output should be posted in the review.[1]
That doesn't imply it's only the reviewer who must do this. rpmlint is also a
tool for packagers.
> Summary: A Library providing simplified C and Python API to libsolv
Summaries without leading articles are more readable in package tools and
Anaconda.
> Group:Development/Libraries
"System Environment/Libraries" is the primary group for shared lib packages.
> Source0: hawkey-%{gitrev}.tar.xz
https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
> BuildRequires:python2 python2-devel
This build requirement doesn't match the run-time requirement further below,
which makes it unsafe and not precise enough:
| %package -n python-hawkey
| Requires:python
Plus,
https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
also applies here, and a comment in the spec file would be good.
> Requires: libsolv >= %{libsolv_version}
https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
Also, consider using %{?_isa} in such explicit dependencies, too.
> %description
> A Library providing simplified C and Python API to libsolv
Here, creating full sentences including punctuation would be the way to go.
> %files
> %doc COPYING README.md
> %files devel
> %doc COPYING
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing
> %_includedir/hawkey
When including entire directory trees like this, it's typically more readable
to add a trailing slash and make clear that it's not a single file to be
included only:
%_includedir/hawkey/
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833511] Review Request: dnf - A Yum fork on top of libsolv
https://bugzilla.redhat.com/show_bug.cgi?id=833511 Michael Schwendt changed: What|Removed |Added Depends On||833462 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833462] Review Request: hawkey - A Library providing simplified C and Python API to libsolv
https://bugzilla.redhat.com/show_bug.cgi?id=833462 Michael Schwendt changed: What|Removed |Added Blocks||833511 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833411] Review Request: realmd - Kerberos realm enrollment service
https://bugzilla.redhat.com/show_bug.cgi?id=833411 --- Comment #7 from Stef Walter --- Thanks. Fixed various rpmlint warnings, and removed polkit dep. Uploaded new spec and packages here: http://stefw.fedorapeople.org/rpm/realmd/ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749291] Review Request: dpm-xrootd - xroot interface to the Disk Pool Manager (DPM)
https://bugzilla.redhat.com/show_bug.cgi?id=749291 --- Comment #11 from Adrien Devresse --- correction on my side : License File is present under file COPYING -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749291] Review Request: dpm-xrootd - xroot interface to the Disk Pool Manager (DPM)
https://bugzilla.redhat.com/show_bug.cgi?id=749291
--- Comment #10 from Adrien Devresse ---
Conform to the requester wish, I take care of this.
First comments :
- build failure on f16/el/e6 ( I have not tested the other ) :
->http://koji.fedoraproject.org/koji/taskinfo?taskID=4187213
-> http://koji.fedoraproject.org/koji/taskinfo?taskID=4187245
-> BuildRequires
- %{isa} macro is not required on BuildRequires
- BuildRequires:xrootd-libs is implicite in xrootd-devel
- GPL 3 -> No license file or no license in headers.
- shadowutil dependency -> not needed if no user/group modifications
- It is a good pratice to use %macro or $macro but not both for lisibility
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 710383] Review Request: Agda - Commandline for dependently typed functional language
https://bugzilla.redhat.com/show_bug.cgi?id=710383 Jens Petersen changed: What|Removed |Added Whiteboard||NotReady -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830709] Review Request: robert-hooke - Extension mechanism for Clojure functions
https://bugzilla.redhat.com/show_bug.cgi?id=830709 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- robert-hooke-1.2.0-2.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823286] Review Request: dmlite - Common libraries for grid data management and storage
https://bugzilla.redhat.com/show_bug.cgi?id=823286 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-06-22 04:35:44 --- Comment #11 from Fedora Update System --- dmlite-0.2.0-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815098] Review Request: maven-processor-plugin - Maven Processor Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=815098 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- maven-processor-plugin-2.0.5-2.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829329] Review Request: jbosgi-parent - JBossOSGi Parent
https://bugzilla.redhat.com/show_bug.cgi?id=829329 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-06-22 04:33:09 --- Comment #7 from Fedora Update System --- jbosgi-parent-1.0.22-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833164] Review Request: python-pyudev - udev bindings for python
https://bugzilla.redhat.com/show_bug.cgi?id=833164 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- python-pyudev-0.15-1.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 749291] Review Request: dpm-xrootd - xroot interface to the Disk Pool Manager (DPM)
https://bugzilla.redhat.com/show_bug.cgi?id=749291 Adrien Devresse changed: What|Removed |Added CC||ade...@gmail.com Assignee|steve.tray...@cern.ch |ade...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819180] Review Request: kdesrc-build - A tool to allow you to easily build KDE from its source repositories
https://bugzilla.redhat.com/show_bug.cgi?id=819180 --- Comment #19 from Fedora Update System --- kdesrc-build-1.15.1-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819180] Review Request: kdesrc-build - A tool to allow you to easily build KDE from its source repositories
https://bugzilla.redhat.com/show_bug.cgi?id=819180 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-06-22 04:29:04 --- Comment #18 from Fedora Update System --- kdesrc-build-1.15.1-2.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834512] Review Request: perl-Data-HexDump-XXD - Format hexadecimal dump like xxd
https://bugzilla.redhat.com/show_bug.cgi?id=834512 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|ppi...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834516] New: Review Request: perl-Devel-StringInfo - Gather information about strings
https://bugzilla.redhat.com/show_bug.cgi?id=834516 Bug ID: 834516 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Depends On: 834512 Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: perl-Devel-StringInfo - Gather information about strings Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: jples...@redhat.com Type: Bug Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://jplesnik.fedorapeople.org/perl-Devel-StringInfo/perl-Devel-StringInfo.spec SRPM URL: http://jplesnik.fedorapeople.org/perl-Devel-StringInfo/perl-Devel-StringInfo-0.04-1.fc18.src.rpm Description: This module is a debugging aid that helps figure out more information about strings. Fedora Account System Username: jples...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834512] Review Request: perl-Data-HexDump-XXD - Format hexadecimal dump like xxd
https://bugzilla.redhat.com/show_bug.cgi?id=834512 Jitka Plesnikova changed: What|Removed |Added Blocks||834516 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154
Krzysztof Daniel changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #3 from Krzysztof Daniel ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[z]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[!]: MUST Package installs properly.
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.wsdl)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.ws.explorer)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.ws)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.command.env.core)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: eclipse-wtp-webservices
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.wsdl.validation)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.ws.parser)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.ws.ui)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.command.env)
[!]: MUST Requires correct, justified where necessary.
Eclipse bundles should have version specified (as they are very version
sensitive).
[x]: MUST Rpmlint output is silent.
rpmlint eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.src.rpm
eclipse-wtp-jeetools.src: W: invalid-url Source0:
eclipse-wtp-jeetools-3.4.0-HEAD-20120618cvs.tar.xz
1 packages and 0 specfiles check
[Bug 834512] New: Review Request: perl-Data-HexDump-XXD - Format hexadecimal dump like xxd
https://bugzilla.redhat.com/show_bug.cgi?id=834512 Bug ID: 834512 QA Contact: extras...@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: nott...@redhat.com, package-review@lists.fedoraproject.org Assignee: nob...@fedoraproject.org Summary: Review Request: perl-Data-HexDump-XXD - Format hexadecimal dump like xxd Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: jples...@redhat.com Type: Bug Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://jplesnik.fedorapeople.org/perl-Data-HexDump-XXD/perl-Data-HexDump-XXD.spec SRPM URL: http://jplesnik.fedorapeople.org/perl-Data-HexDump-XXD/perl-Data-HexDump-XXD-0.1.0-1.fc18.src.rpm Description: Produce an hexadecimal dump like the program xxd would do, and do the reverse as well. Fedora Account System Username: jples...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
