Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/#review117773
---



Patch looks great!

Reviews applied: [41787]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 4, 2016, 6:32 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41787/
> ---
> 
> (Updated Feb. 4, 2016, 6:32 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4158
> https://issues.apache.org/jira/browse/MESOS-4158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some tests are sped up by using clock, while some relies on the fix of 
> MESOS-4111 and a comment is put.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66 
> 
> Diff: https://reviews.apache.org/r/41787/diff/
> 
> 
> Testing
> ---
> 
> SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
> SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
> SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
> SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
> SlaveRecoveryTest/0.CleanupExecutor (474 ms total)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

[haosdent huang]

> On Feb. 4, 2016, 7:41 a.m., haosdent huang wrote:
> > Ship It!

You combine `src/...` and `3rdparty/...` in a same patch, usually we split them 
into different patches. And we have `support/hooks/pre-commit` to check this 
when you execute `git commit`. Do you have already run `./bootstrap` in local?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117771
---


On Feb. 4, 2016, 7:40 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> ---
> 
> (Updated Feb. 4, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
> https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
> f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
>   src/tests/containerizer/routing_tests.cpp 
> 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> ---
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117771
---


Ship it!




Ship It!

- haosdent huang


On Feb. 4, 2016, 7:40 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> ---
> 
> (Updated Feb. 4, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
> https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
> f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
>   src/tests/containerizer/routing_tests.cpp 
> 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> ---
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

[Andy Pang]

> On 二月 3, 2016, 8:43 a.m., haosdent huang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 71
> > 
> >
> > Do we also need fix similar ::clone syscall in routing_tests.cpp?
> > ```
> > TEST_F(RoutingVethTest, ROOT_LinkCreatePid)
> > {
> >   // Stack used in the child process.
> >   unsigned long long stack[32];
> > 
> >   pid_t pid = ::clone(child, &stack[31], CLONE_NEWNET | SIGCHLD, NULL);
> > ```

Add routing_tests.cpp support aarch64 cpu.


- Andy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117595
---


On 二月 4, 2016, 7:40 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> ---
> 
> (Updated 二月 4, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
> https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support libprocess build run in aarch64 cpu.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
> f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
>   src/tests/containerizer/routing_tests.cpp 
> 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> ---
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

[Andy Pang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/
---

(Updated 二月 4, 2016, 7:40 a.m.)


Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.


Changes
---

Add routing_tests.cpp support aarch64 cpu.


Bugs: MESOS-4577
https://issues.apache.org/jira/browse/MESOS-4577


Repository: mesos


Description (updated)
---

Support libprocess build run in aarch64 cpu.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 
  src/tests/containerizer/routing_tests.cpp 
4ebb01213ce20f954c2633df95e898cf66a2d9e9 

Diff: https://reviews.apache.org/r/43136/diff/


Testing
---

test run ok in AArch64.


Thanks,

Andy Pang

Re: Review Request 42753: Allowed `createLabel` to take an optional "value".

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42753/#review117767
---


Ship it!




Ship It!

- Guangya Liu


On Jan. 25, 2016, 11 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42753/
> ---
> 
> (Updated Jan. 25, 2016, 11 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This better matches the underlying protobuf definition.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 7280c9fe36726df6b02ff468c7bd5ecedf5f5023 
>   src/common/protobuf_utils.cpp 53324ab569751924f25290641d1a70da790c2104 
> 
> Diff: https://reviews.apache.org/r/42753/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42440: Create a test macro to advance `Clock` for `Future`.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42440/#review117766
---


Ship it!




Ship It!

- Jian Qiu


On 一月 22, 2016, 4:56 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42440/
> ---
> 
> (Updated 一月 22, 2016, 4:56 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jian Qiu, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4418
> https://issues.apache.org/jira/browse/MESOS-4418
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Create a test macro to advance `Clock` for `Future`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/gtest.hpp 
> 049152c0535c78e6986346610735d301fb6876bc 
> 
> Diff: https://reviews.apache.org/r/42440/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 二月 4, 2016, 6:32 a.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description (updated)
---

Some tests are sped up by using clock, while some relies on the fix of 
MESOS-4111 and a comment is put.


Diffs
-

  src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 41787: Speed up Speed up SlaveRecoveryTest.*.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41787/
---

(Updated 二月 4, 2016, 6:32 a.m.)


Review request for mesos, Alexander Rukletsov and Timothy Chen.


Summary (updated)
-

Speed up Speed up SlaveRecoveryTest.*.


Bugs: MESOS-4158
https://issues.apache.org/jira/browse/MESOS-4158


Repository: mesos


Description (updated)
---

Speed up Speed up SlaveRecoveryTest.*.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66 

Diff: https://reviews.apache.org/r/41787/diff/


Testing
---

SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total)
SlaveRecoveryTest/0.ReconnectExecutor (333 ms total)
SlaveRecoveryTest/0.ReconcileKillTask (443 ms total)
SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total)
SlaveRecoveryTest/0.CleanupExecutor (474 ms total)


Thanks,

Jian Qiu

Re: Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43177/#review117764
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On Feb. 4, 2016, 4:58 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43177/
> ---
> 
> (Updated Feb. 4, 2016, 4:58 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4585
> https://issues.apache.org/jira/browse/MESOS-4585
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Erased libprocess related env vars for mesos-fetcher.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/fetcher.cpp 
> dbf968df4b219fbbafd59d5560492b7c1ace83f3 
> 
> Diff: https://reviews.apache.org/r/43177/diff/
> 
> 
> Testing
> ---
> 
> Created a simple framework that launchs a task with a hdfs:// uri
> 
> - Without this patch: fetcher failed with traceback like reported in jira
> - With this patch: fetcher succeeds and the task is running
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Review Request 43177: Erased libprocess related env vars for mesos-fetcher.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43177/
---

Review request for mesos.


Bugs: MESOS-4585
https://issues.apache.org/jira/browse/MESOS-4585


Repository: mesos


Description
---

Erased libprocess related env vars for mesos-fetcher.


Diffs
-

  src/slave/containerizer/fetcher.cpp dbf968df4b219fbbafd59d5560492b7c1ace83f3 

Diff: https://reviews.apache.org/r/43177/diff/


Testing
---

Created a simple framework that launchs a task with a hdfs:// uri

- Without this patch: fetcher failed with traceback like reported in jira
- With this patch: fetcher succeeds and the task is running


Thanks,

Shuai Lin

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42782/
---

(Updated Feb. 4, 2016, 4:42 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344


Repository: mesos


Description
---

Added a unit-test to test net_cls major handles set from command line.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
8d101df957fd36adac388310eddba2db1f98c029 

Diff: https://reviews.apache.org/r/42782/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42780/
---

(Updated Feb. 4, 2016, 4:41 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345


Repository: mesos


Description
---

Changed the NetClsIsolatorTest to check for net_cls handles.


Diffs (updated)
-

  src/tests/containerizer/isolator_tests.cpp 
8d101df957fd36adac388310eddba2db1f98c029 

Diff: https://reviews.apache.org/r/42780/diff/


Testing
---

make and make check


Thanks,

Avinash sridharan

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

[James Peach]

> On Feb. 4, 2016, 3:18 a.m., Guangya Liu wrote:
> > docs/configuration.md, line 1680
> > 
> >
> > s/overridden/overwritten ?

No, "overridden" is correct here.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43165/#review117759
---


On Feb. 4, 2016, 12:17 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43165/
> ---
> 
> (Updated Feb. 4, 2016, 12:17 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document LIBPROCESS_THREAD_COUNT.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 
> 
> Diff: https://reviews.apache.org/r/43165/diff/
> 
> 
> Testing
> ---
> 
> Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

[haosdent huang]

> On Feb. 4, 2016, 1:11 a.m., Jiang Yan Xu wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 2207-2208
> > 
> >
> > Since we do LOG(WARNING) instead of LOG(FATAL), maybe say the below so 
> > it's clear that we ignored the variable and moved on with the default value.
> > 
> > `"Ignoring invalid value " << value.get() << " for 
> > LIBPROCESS_THREAD_COUNT";`
> 
> Guangya Liu wrote:
> What about adding more info for trouble shooting? Such as `"Ignoring 
> invalid value " << value.get() << " for LIBPROCESS_THREAD_COUNT, using system 
> defined value " << cpus;`

+1


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43149/#review117725
---


On Feb. 4, 2016, 12:40 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43149/
> ---
> 
> (Updated Feb. 4, 2016, 12:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check the LIBPROCESS_THREAD_COUNT environment variable to determine
> the number of threads in the libprocess thread pool.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 
> 
> Diff: https://reviews.apache.org/r/43149/diff/
> 
> 
> Testing
> ---
> 
> make check on OS X. Running in production for many months.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43165/#review117759
---




docs/configuration.md (line 1680)


s/overridden/overwritten ?


- Guangya Liu


On Feb. 4, 2016, 12:17 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43165/
> ---
> 
> (Updated Feb. 4, 2016, 12:17 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document LIBPROCESS_THREAD_COUNT.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 
> 
> Diff: https://reviews.apache.org/r/43165/diff/
> 
> 
> Testing
> ---
> 
> Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43083: Supported working dir in docker runtime isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43083/#review117758
---



Patch looks great!

Reviews applied: [43019, 43020, 43021, 43022, 43036, 43037, 43081, 43082, 
43166, 43167, 43168, 43083]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 4, 2016, 12:49 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43083/
> ---
> 
> (Updated Feb. 4, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4005
> https://issues.apache.org/jira/browse/MESOS-4005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported working dir in docker runtime isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 4b504dbb58823ce7675f1d2048dcc7a27c05663d 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43083/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

[Guangya Liu]

> On Feb. 4, 2016, 1:11 a.m., Jiang Yan Xu wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 2207-2208
> > 
> >
> > Since we do LOG(WARNING) instead of LOG(FATAL), maybe say the below so 
> > it's clear that we ignored the variable and moved on with the default value.
> > 
> > `"Ignoring invalid value " << value.get() << " for 
> > LIBPROCESS_THREAD_COUNT";`

What about adding more info for trouble shooting? Such as `"Ignoring invalid 
value " << value.get() << " for LIBPROCESS_THREAD_COUNT, using system defined 
value " << cpus;`


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43149/#review117725
---


On Feb. 4, 2016, 12:40 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43149/
> ---
> 
> (Updated Feb. 4, 2016, 12:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check the LIBPROCESS_THREAD_COUNT environment variable to determine
> the number of threads in the libprocess thread pool.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 
> 
> Diff: https://reviews.apache.org/r/43149/diff/
> 
> 
> Testing
> ---
> 
> make check on OS X. Running in production for many months.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 42841: WIP: Introducing appc image fetcher.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42841/
---

(Updated Feb. 4, 2016, 2:55 a.m.)


Review request for Jie Yu.


Changes
---

rebased.


Repository: mesos


Description
---

WIP: Introducing appc image fetcher.


Diffs (updated)
-

  src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp PRE-CREATION 
  src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
  src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 

Diff: https://reviews.apache.org/r/42841/diff/


Testing
---

make check; local image server


Thanks,

Jojy Varghese

Re: Review Request 43127: Introduced Appc image cache.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43127/
---

(Updated Feb. 4, 2016, 2:55 a.m.)


Review request for mesos and Jie Yu.


Changes
---

rebased.


Bugs: MESOS-4439 and MESOS-4575
https://issues.apache.org/jira/browse/MESOS-4439
https://issues.apache.org/jira/browse/MESOS-4575


Repository: mesos


Description
---

Image cache will cache metadata about all Appc images stores in the store's
image directory. This cache could be useful to:
  - Quickly query if an image is present in the store.
  - By sharing the cache with other components like fetcher, an image can be
  checked if its present before fetching it.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/appc/cache.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/cache.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 
  src/tests/containerizer/provisioner_appc_tests.cpp 
e3d08d9e49df93d5290099c8bfd917f60c93e51b 

Diff: https://reviews.apache.org/r/43127/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 42557: Moved CachedImage to a separate file.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42557/
---

(Updated Feb. 4, 2016, 2:53 a.m.)


Review request for mesos and Jie Yu.


Changes
---

review addressed.


Repository: mesos


Description (updated)
---

Currently CachedImage is private to the appc store. This will change as we
implement image fetchers (eg. simple discovery).


Diffs (updated)
-

  src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/slave/containerizer/mesos/provisioner/appc/cache.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/cache.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 

Diff: https://reviews.apache.org/r/42557/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 43003: Moved Appc spec proto messages to its own spec file.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43003/
---

(Updated Feb. 4, 2016, 2:52 a.m.)


Review request for mesos and Jie Yu.


Changes
---

review addressed.


Summary (updated)
-

Moved Appc spec proto messages to its own spec file.


Bugs: MESOS-4564
https://issues.apache.org/jira/browse/MESOS-4564


Repository: mesos


Description (updated)
---

Moved Appc spec proto messages to its own spec file.


Diffs (updated)
-

  include/mesos/appc/spec.proto PRE-CREATION 
  include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
  src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/slave/containerizer/mesos/provisioner/appc/paths.hpp 
dfeb3ffad2503444854c7830ee1b613ce076dfd8 
  src/slave/containerizer/mesos/provisioner/appc/paths.cpp 
94df5b2007d2988189e9c973b2348697a534ab7e 
  src/slave/containerizer/mesos/provisioner/appc/spec.hpp 
d4fd8cbfd5668da9ce4ac86baaadf42945c5abbd 
  src/slave/containerizer/mesos/provisioner/appc/spec.cpp 
324cdfec3766da4a8e324378a6e413477fa2b5d9 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 
  src/tests/containerizer/provisioner_appc_tests.cpp 
e3d08d9e49df93d5290099c8bfd917f60c93e51b 

Diff: https://reviews.apache.org/r/43003/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 42617: Cleaned up usage of namespace-qualified identifiers in stout.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42617/#review117748
---


Ship it!




Ship It!

- Michael Park


On Feb. 1, 2016, 10:07 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42617/
> ---
> 
> (Updated Feb. 1, 2016, 10:07 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For example, avoid using `std::string` in a .cpp file that already does
> `using std::string`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> 5a10f59f3698a6ad85b7c2386def9686af8a23a6 
>   3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 
> 21a98b85277d946b887cb23c4ebb4d32cfcb0c6b 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 01e4b2fff7cc05a47d7919d702543a38bf6c339d 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 4b7d1347f93261df7a7d512721146edca2703b34 
>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 
> c0be974ea2dc74c63ec3561403b3f4d3722a8df3 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 
> 7715fa4baa150f370bdd0fd5c2f98dc4c6f5fc55 
> 
> Diff: https://reviews.apache.org/r/42617/diff/
> 
> 
> Testing
> ---
> 
> "make check" on OSX and Arch Linux.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42616: Cleaned up usage of namespace-qualified identifiers in libprocess.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42616/#review117747
---


Ship it!




Ship It!

- Michael Park


On Feb. 1, 2016, 10:07 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42616/
> ---
> 
> (Updated Feb. 1, 2016, 10:07 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For example, avoid using `std::string` in a .cpp file that already does
> `using std::string`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/authenticator.cpp 
> 16b48cd599b10c09229fbf10f28139219855710b 
>   3rdparty/libprocess/src/http.cpp 762da9a9038fc0a81156b5c03b556084df1bd7e0 
>   3rdparty/libprocess/src/io.cpp 9530192e2c7afbfa4bd9aa2af2ff40f00ee505a9 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 
> 9321ce666a0c5c75cdbdd1c5a6d534fbc221bf5b 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> 3083b92b3fb67421265950b03272b52cec68daf9 
>   3rdparty/libprocess/src/pid.cpp 3cd04ecaddd045d9d5ecf132302417181d416f80 
>   3rdparty/libprocess/src/process.cpp 
> d8a74d7637d20c81f384e974e4fdeba22effb437 
>   3rdparty/libprocess/src/socket.cpp 6c1b16f69a21d116a0ffef21097a1b4372977b2e 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> df1c7b3f37ab1103991a4f27a9e0359bcf06cc68 
> 
> Diff: https://reviews.apache.org/r/42616/diff/
> 
> 
> Testing
> ---
> 
> "make check" on OSX and Arch Linux.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42615: Cleaned up usage of namespace-qualified identifiers in Mesos.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42615/#review117744
---


Fix it, then Ship it!





src/cli/execute.cpp (lines 201 - 203)


```cpp
foreachpair (
const string& name, const string& value, environment.get())
```



src/docker/docker.cpp (lines 385 - 386)


```cpp
const vector tokens =
  strings::tokenize(value.as().value, "=");
```


- Michael Park


On Feb. 1, 2016, 10:07 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42615/
> ---
> 
> (Updated Feb. 1, 2016, 10:07 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For example, avoid using `std::string` in a .cpp file that already does
> `using std::string`.
> 
> 
> Diffs
> -
> 
>   src/authentication/http/basic_authenticator_factory.cpp 
> 6eb1c5bd09b136d3bc20481ddcc65cb8bd153682 
>   src/cli/execute.cpp 0add77558e07ff49f0134ddb9085509501c61aab 
>   src/common/http.cpp b7e71eb79ccb8ef1d0bbd168d77d4d4591ecb09b 
>   src/common/protobuf_utils.cpp 53324ab569751924f25290641d1a70da790c2104 
>   src/docker/docker.cpp a83172674b385a59cfd6f344836740a5719f954e 
>   src/examples/balloon_framework.cpp 3c17676c92f72d41c501b2435a7017e3c9f01278 
>   src/examples/test_container_logger_module.cpp 
> 6b1f4dbd63145afe4de17830c0a2a6202a896be7 
>   src/examples/test_http_authenticator_module.cpp 
> acf51a6deb8e7dc4ab6ac0cf70380ddbb1839906 
>   src/examples/test_qos_controller_module.cpp 
> f8aa1d730f6cdf5ab3f11789e9699682cc08ddd5 
>   src/files/files.cpp dd64976ca454786152a8e29f590e8c1ed1df3b54 
>   src/health-check/main.cpp 0beaed575ec865d81e6e3d83d8a0c894613acba4 
>   src/hook/manager.cpp 6ee93038dce1247cffbc82c736a1c7a1ecb84bb0 
>   src/launcher/fetcher.cpp 902e927ce0cbcf70e41041375e61987752629957 
>   src/linux/routing/queueing/fq_codel.cpp 
> d840e383f28481ba58d8269217a8a194c4e87db5 
>   src/linux/routing/queueing/ingress.cpp 
> c25a93966caca5c5a9eef91e6caa5d9e29091bee 
>   src/linux/systemd.cpp d3f4a63d833a5bc599494e925d709ba0cc70d9ec 
>   src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f 
>   src/log/tool/initialize.cpp c9706d1e33659f7b0e375419197b207cb96d4ca9 
>   src/log/tool/read.cpp 9abf5a82338c554920283e0329cd83e4c787c103 
>   src/log/tool/replica.cpp 8baf79755da420cf594d706f31aa561b5d665051 
>   src/master/allocator/mesos/hierarchical.cpp 
> 1a07d69016407e5aad2209586da37fecbcddb765 
>   src/master/allocator/sorter/drf/sorter.cpp 
> db47d640e36c0302d7c6254a9c58caa878feac01 
>   src/master/main.cpp 7ebca788c35d5bb6898ae65df91b899c2b74f3d4 
>   src/master/maintenance.cpp df7cd6ca5a097611e5ca5a46cc988ef636da096b 
>   src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83 
>   src/module/manager.cpp a53f71b9965f7ab85aadb6c0c7af18de958faf38 
>   src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 
>   src/slave/containerizer/fetcher.cpp 
> f7e3f7de6d0ebc253d2ccfe4a66b10ed2eca2c11 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 61801fffe9bac1a995a57d8b4e8c004d624bbd63 
>   src/slave/containerizer/mesos/provisioner/docker/paths.cpp 
> 9c5c24992f9ea36159271691cca0147851240088 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> b74c760e90b12f5bf45b6e626e2b661f841e5a8d 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 71caeca9005b5846c56ff4dfd260b426958a73c5 
>   src/slave/paths.cpp 77e86a07b7c64775d1cb1542527cdfc38b6748ff 
>   src/slave/qos_controllers/load.cpp 52520d6220784423c09001b8bd59e090ebf787ec 
>   src/slave/state.cpp fae7738a1cb7168abc0cfe35b075bbc73306b820 
>   src/tests/attributes_tests.cpp 3f3dde1301566f279c3fc7dc24e3ef67039a4c14 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> 0d24809701c42dc036bbd051791545f4742d1e9a 
>   src/tests/containerizer/cgroups_tests.cpp 
> 5e15d44a472b2acd64475f69fd44cd4d2d9f729d 
>   src/tests/containerizer/external_containerizer_test.cpp 
> da52860f4a1d5363d7b61b9a8bb6abad02d89736 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> de99126aca8dccea0b4c04f975e4da4710b5a1f1 
>   src/tests/credentials_tests.cpp 6e3725c61a55a2c1d183ee278cf3d72be16a6e40 
>   src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 
>   src/tests/gc_tests.cpp ef5544b627ac4a9f9c13fe13b0c51b21d5b98a12 
>   src/tests/hierarchical_allocator_tests.cpp 
> f18e6eb10572b0f5b8bbff338384d9406f6ad62b 
>   src/tests/hook_tests.cpp 1a1bab49469485887e0a6a8fa1837bd70262d3b5 
>   src/tests/http_authenti

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43165/#review117745
---



Patch looks great!

Reviews applied: [43149, 43165]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 4, 2016, 12:17 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43165/
> ---
> 
> (Updated Feb. 4, 2016, 12:17 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document LIBPROCESS_THREAD_COUNT.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 
> 
> Diff: https://reviews.apache.org/r/43165/diff/
> 
> 
> Testing
> ---
> 
> Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 42751: Tweaked some resource test cases.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42751/#review117743
---




src/tests/resources_tests.cpp (line 185)


Let's fix this with `Resources::size()` as well :)


- Michael Park


On Feb. 3, 2016, 11:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42751/
> ---
> 
> (Updated Feb. 3, 2016, 11:04 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We should check that two reservations with the same role but different
> principals are considered distinct.
> 
> 
> Diffs
> -
> 
>   src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a 
> 
> Diff: https://reviews.apache.org/r/42751/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42751: Tweaked some resource test cases.

[Michael Park]

> On Feb. 3, 2016, 10:45 p.m., Michael Park wrote:
> > src/tests/resources_tests.cpp, line 957
> > 
> >
> > We used to have a `Resources::size()` function which essentially did 
> > this, but intentionally removed it so that people don't rely on number of 
> > `Resource` instances. Is there a reason why we want to check for this?
> > 
> > Here and below.
> 
> Neil Conway wrote:
> The # of `Resource` instances is part of the public API of `Resources` 
> (e.g., clients can iterate over every `Resource`). If it is part of the 
> public API, it seems like something it would be worth testing.
> 
> In this particular case, it doesn't matter that much, but in other test 
> cases (e.g., `AdditionDynamicallyReservedWithDistinctLabels`) it seems useful 
> to check.

Ok, synced with Jie on this as well. Let's re-introduce `Resources::size()` and 
use that instead.

I agree that the # of `Resource` instances is part of the public API since as 
you say, one can iterate and count.
However, this still does not mean that such iterator math works. For example, 
we could internally store the `Resource` objects
in a `std::set` (or any other data structure that does not guarantee contiguous 
memory), rather than `std::vector`.

Providing a `Resources::size()` would more accurately capture this intention 
anyway. Would you be ok taking that on?


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42751/#review117698
---


On Feb. 3, 2016, 11:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42751/
> ---
> 
> (Updated Feb. 3, 2016, 11:04 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We should check that two reservations with the same role but different
> principals are considered distinct.
> 
> 
> Diffs
> -
> 
>   src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a 
> 
> Diff: https://reviews.apache.org/r/42751/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43107/
---

(Updated Feb. 4, 2016, 1:52 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344


Repository: mesos


Description (updated)
---

The `cgroup/net_cls` isolator will use the primary handle, passed by the
operator using the --cgroup_net_cls_primary_handle, to initialize the
`NetClsHandleManager`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 

Diff: https://reviews.apache.org/r/43107/diff/


Testing
---

make and make check

Launched a slave by passing invalid flags to --cgroup_net_cls_primary_handle 
and made sure the slave correctly detects these invalid handles. 

Launched a slave with valid handle to make sure that the slave launches 
correctly.


Thanks,

Avinash sridharan

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/
---

(Updated Feb. 4, 2016, 1:48 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4344
https://issues.apache.org/jira/browse/MESOS-4344


Repository: mesos


Description
---

Added the --cgroups_net_cls_primary_handle flag to the slave.


Diffs (updated)
-

  src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
  src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 

Diff: https://reviews.apache.org/r/42781/diff/


Testing
---

Tested the flag by launching a mesos agent and checking that the slave takes 
the `--cgroups_net_cls_major_handles` flag.


Thanks,

Avinash sridharan

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

[Avinash sridharan]

> On Feb. 3, 2016, 8:12 p.m., Jie Yu wrote:
> > src/slave/constants.cpp, line 55
> > 
> >
> > I am thinking about whether we should introduce a default here or not.
> > 
> > I think I also want the option that Mesos will just do the cgroups 
> > creation without assigning handles.
> > 
> > That being said, can we make the flag optional and do not assign 
> > handles in net_cls cgroup if that flag is not set?

Made the flag optional.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42781/#review117668
---


On Feb. 3, 2016, 7:47 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42781/
> ---
> 
> (Updated Feb. 3, 2016, 7:47 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4344
> https://issues.apache.org/jira/browse/MESOS-4344
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the --cgroups_net_cls_primary_handle flag to the slave.
> 
> 
> Diffs
> -
> 
>   src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
>   src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
>   src/slave/flags.hpp 23ec158f4a95fa76d657d9eb6a4a6fe30d57e5b6 
>   src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 
> 
> Diff: https://reviews.apache.org/r/42781/diff/
> 
> 
> Testing
> ---
> 
> Tested the flag by launching a mesos agent and checking that the slave takes 
> the `--cgroups_net_cls_major_handles` flag.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42618/
---

(Updated Feb. 4, 2016, 1:42 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345


Repository: mesos


Description
---

Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b4bc52114389d1c1efce2830f4292bd89bb0de7c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 

Diff: https://reviews.apache.org/r/42618/diff/


Testing
---

make and make check


Thanks,

Avinash sridharan

Re: Review Request 42755: Added documentation for labeled reserved resources.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117729
---


Fix it, then Ship it!





docs/reservation.md (line 84)


Add newline.


- Michael Park


On Feb. 3, 2016, 10:40 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> ---
> 
> (Updated Feb. 3, 2016, 10:40 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for labeled reserved resources.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/42755/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42754: Added support for labels to resource reservations.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/#review117730
---




src/tests/reservation_endpoints_tests.cpp (lines 752 - 757)


Since the unreserve operation would rescind resources as necessary, I don't 
think we need to do this. Is this not the case?



src/tests/resources_tests.cpp (line 35)


Should come after `std` using declarations.



src/tests/resources_tests.cpp (line 1650)


`s/AdditionDynamicallyReserved/AdditionDynamicallyReservedWithoutLabels/`



src/tests/resources_tests.cpp (line 1666)



`s/AdditionDynamicallyReservedWithLabels/AdditionDynamicallyReservedWithSameLabels/`?



src/tests/resources_tests.cpp (line 1708)


Weird that we didn't have `SubtractionStaticallyReserved` and 
`SubtractionDynamicallyReserved` before. Can we take this opportunity to sync 
`Addition` and `Subtraction`? or do you think there's a good reason to keep 
them conflated in this case?

As written, it looks like we're expecting the correct portions (statically 
reserved from `r1` and dynamically reserved from `r2`) of `total` to be 
subtracted by `r7` and `r8`. I'd ok with keeping this pattern, and if we were 
to do that, I think we should add the labeled states into the `total` and 
expect the correct portions of them to be subtracted.

What do you think?


- Michael Park


On Feb. 3, 2016, 11:32 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42754/
> ---
> 
> (Updated Feb. 3, 2016, 11:32 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4479
> https://issues.apache.org/jira/browse/MESOS-4479
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Labels are free-form key-value pairs that can be used to associate
> metadata with reserved resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
>   include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a54411 
>   include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
>   include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 
>   src/common/resources.cpp 588a279c3cdebbeb58047bfbff5e78a42f53fc13 
>   src/common/type_utils.cpp 42e3061818c49c6b62d4fee2479db078dfe0fc89 
>   src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488 
>   src/tests/reservation_endpoints_tests.cpp 
> 35c093567b07a11ca6eee85e2ff91894a460a7af 
>   src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a 
>   src/v1/mesos.cpp 21b14cf7050270facab1ba2b844c3fde664665a4 
>   src/v1/resources.cpp be4a5d153e9313cb71a6e85d1ed25a358537f2b7 
> 
> Diff: https://reviews.apache.org/r/42754/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43161: Made `JSON::parse` disallow duplicate keys in libprocess.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43161/#review117733
---



Patch looks great!

Reviews applied: [43159, 43160, 43161]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 3, 2016, 11:10 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43161/
> ---
> 
> (Updated Feb. 3, 2016, 11:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4582
> https://issues.apache.org/jira/browse/MESOS-4582
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See [r43160](https://reviews.apache.org/r/43160) for details. This patch adds 
> a `picojson-1.3.0.patch` to restrict `picojson::parse` from allowing 
> duplicate keys.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 42c95a970b13ef4d72665d0b87bac87722f6decd 
>   3rdparty/libprocess/3rdparty/picojson-1.3.0.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43161/diff/
> 
> 
> Testing
> ---
> 
> See [r43160](https://reviews.apache.org/r/43160).
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43149/#review117725
---




3rdparty/libprocess/src/process.cpp (line 2203)


`Try count = numify(...)` since the thread count is an uint?



3rdparty/libprocess/src/process.cpp (lines 2207 - 2208)


Since we do LOG(WARNING) instead of LOG(FATAL), maybe say the below so it's 
clear that we ignored the variable and moved on with the default value.

`"Ignoring invalid value " << value.get() << " for 
LIBPROCESS_THREAD_COUNT";`


- Jiang Yan Xu


On Feb. 3, 2016, 4:40 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43149/
> ---
> 
> (Updated Feb. 3, 2016, 4:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check the LIBPROCESS_THREAD_COUNT environment variable to determine
> the number of threads in the libprocess thread pool.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 
> 
> Diff: https://reviews.apache.org/r/43149/diff/
> 
> 
> Testing
> ---
> 
> make check on OS X. Running in production for many months.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43083: Supported working dir in docker runtime isolator.

[Gilbert Song]

> On Feb. 2, 2016, 4:16 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 1029-1034
> > 
> >
> > We shouldn't allow executor to cd into an arbitrary directory if 
> > filesystem isolation is not used (because that'll create security issue).
> > 
> > I would do the following:
> > ```
> > if (rootfs.isSome()) {
> >   launchFlags.directory = workingDir.isSome()
> > ? workingDir.get()
> > : flags.sandbox_directory;
> > } else {
> >   // NOTE: If the executor shares the host filesystem, we
> >   // should not allow them to 'cd' into an arbitrary directory
> >   // because that'll create security issues.
> >   if (workingDir.isSome()) {
> > LOG(WARNING) << "Ignore working directory '" << workingDir.get()
> >  << "' specified in container launch info for container 
> > "
> >  << containerId << " since the executor is using the "
> >  << "host filesystem";
> >   }
> >   launchFlags.directory = directory;
> > }
> > ```

Note that this issue is fixed in /mesos/launch.cpp


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43083/#review117522
---


On Feb. 3, 2016, 4:49 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43083/
> ---
> 
> (Updated Feb. 3, 2016, 4:49 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4005
> https://issues.apache.org/jira/browse/MESOS-4005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported working dir in docker runtime isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 4b504dbb58823ce7675f1d2048dcc7a27c05663d 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43083/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43083: Supported working dir in docker runtime isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43083/
---

(Updated Feb. 3, 2016, 4:49 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4005
https://issues.apache.org/jira/browse/MESOS-4005


Repository: mesos


Description
---

Supported working dir in docker runtime isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
4b504dbb58823ce7675f1d2048dcc7a27c05663d 
  src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/43083/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Review Request 43168: Added working dir flag to command executor.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43168/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4005
https://issues.apache.org/jira/browse/MESOS-4005


Repository: mesos


Description
---

Added working dir flag to command executor.


Diffs
-

  src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 

Diff: https://reviews.apache.org/r/43168/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Review Request 43166: Renamed 'directory' flag to 'sandbox' in mesos containerizer launch.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43166/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Renamed 'directory' flag to 'sandbox' in mesos containerizer launch.


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
4b504dbb58823ce7675f1d2048dcc7a27c05663d 
  src/slave/containerizer/mesos/launch.hpp 
722031956494647c81436a95400d939eec4466de 
  src/slave/containerizer/mesos/launch.cpp 
0cfdc0ca1a7e8c6107f8ea46e7a4c6e52811d7ac 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 

Diff: https://reviews.apache.org/r/43166/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Review Request 43167: Added working dir flag to mesos containerizer launch.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43167/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4005
https://issues.apache.org/jira/browse/MESOS-4005


Repository: mesos


Description
---

Added working dir flag to mesos containerizer launch.


Diffs
-

  src/slave/containerizer/mesos/launch.hpp 
722031956494647c81436a95400d939eec4466de 
  src/slave/containerizer/mesos/launch.cpp 
0cfdc0ca1a7e8c6107f8ea46e7a4c6e52811d7ac 

Diff: https://reviews.apache.org/r/43167/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 42755: Added documentation for labeled reserved resources.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117723
---



Patch looks great!

Reviews applied: [42750, 42751, 42752, 42753, 42754, 42755]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 3, 2016, 10:40 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> ---
> 
> (Updated Feb. 3, 2016, 10:40 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for labeled reserved resources.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/42755/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43165/
---

(Updated Feb. 4, 2016, 12:17 a.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4592
https://issues.apache.org/jira/browse/MESOS-4592


Repository: mesos


Description
---

Document LIBPROCESS_THREAD_COUNT.


Diffs
-

  docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 

Diff: https://reviews.apache.org/r/43165/diff/


Testing
---

Source inspection.


Thanks,

James Peach

Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43165/
---

Review request for mesos and Jiang Yan Xu.


Repository: mesos


Description
---

Document LIBPROCESS_THREAD_COUNT.


Diffs
-

  docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 

Diff: https://reviews.apache.org/r/43165/diff/


Testing
---

Source inspection.


Thanks,

James Peach

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43149/
---

(Updated Feb. 4, 2016, 12:14 a.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4592
https://issues.apache.org/jira/browse/MESOS-4592


Repository: mesos


Description
---

Check the LIBPROCESS_THREAD_COUNT environment variable to determine
the number of threads in the libprocess thread pool.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 

Diff: https://reviews.apache.org/r/43149/diff/


Testing
---

make check on OS X. Running in production for many months.


Thanks,

James Peach

Re: Review Request 41291: Modified the scheduler tests to use the new executor HTTP based library.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41291/#review117703
---




src/tests/scheduler_tests.cpp (line 201)


s/execCallbacks/executorCallbacks/



src/tests/scheduler_tests.cpp (lines 266 - 267)


this expectation should be set much later. sometime after #287?



src/tests/scheduler_tests.cpp (lines 297 - 299)


It would be gret if we can send a TASK_RUNNING update right from here, like 
we did with the driver based executor to minimize the boiler plate code needed 
for every test.

This likely means that the ExecutorCallbacks class needs access to a 
pointer of TestMesos class.



src/tests/scheduler_tests.cpp (line 302)


s/exec/executor/



src/tests/scheduler_tests.cpp (line 360)


do the above changes for all the other tests below.


- Vinod Kone


On Jan. 22, 2016, 8:35 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41291/
> ---
> 
> (Updated Jan. 22, 2016, 8:35 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies the existing scheduler tests to use the new executor 
> HTTP library instead of the old driver based interface.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 67432109c7df6be0aa76e94a03bd5b2e9c96d14e 
> 
> Diff: https://reviews.apache.org/r/41291/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43019: Fixed non-camel case in protobuf field.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43019/#review117711
---


Ship it!




Ship It!

- Jie Yu


On Feb. 3, 2016, 8:41 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43019/
> ---
> 
> (Updated Feb. 3, 2016, 8:41 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed non-camel case in protobuf field.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/isolator.proto 8b7c54afc4467084b5d22387e55689d06078b504 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 4b504dbb58823ce7675f1d2048dcc7a27c05663d 
>   src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
> 57168c837aabf85c85866ca9d4b5480f281e3143 
>   src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 
> 34aa660204911ce4f22c7735af36c9f1af8b12b9 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 24ff8194bb5ea86a31224d2d2c20d367472168aa 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> bce5ab9a1913ee7cebaf55b5ee0b42fa4a325e87 
>   src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 
> 59ffd13920fb1c4fb8dbf04a2823d9cee75a8f27 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> d5dd93d892e3cde2011e208a050eec2b31891f54 
>   src/tests/containerizer/isolator_tests.cpp 
> 8d101df957fd36adac388310eddba2db1f98c029 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 182fe9217a5da9af603d6f9c203a1689eff4ca1b 
> 
> Diff: https://reviews.apache.org/r/43019/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 42754: Added support for labels to resource reservations.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/
---

(Updated Feb. 3, 2016, 11:32 p.m.)


Review request for mesos and Michael Park.


Changes
---

Address code review comments from Joerg.


Bugs: MESOS-4479
https://issues.apache.org/jira/browse/MESOS-4479


Repository: mesos


Description
---

Labels are free-form key-value pairs that can be used to associate
metadata with reserved resources.


Diffs (updated)
-

  include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
  include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a54411 
  include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
  include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 
  src/common/resources.cpp 588a279c3cdebbeb58047bfbff5e78a42f53fc13 
  src/common/type_utils.cpp 42e3061818c49c6b62d4fee2479db078dfe0fc89 
  src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488 
  src/tests/reservation_endpoints_tests.cpp 
35c093567b07a11ca6eee85e2ff91894a460a7af 
  src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a 
  src/v1/mesos.cpp 21b14cf7050270facab1ba2b844c3fde664665a4 
  src/v1/resources.cpp be4a5d153e9313cb71a6e85d1ed25a358537f2b7 

Diff: https://reviews.apache.org/r/42754/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 43160: Made `JSON::parse` disallow duplicate keys in stout.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43160/
---

(Updated Feb. 3, 2016, 11:12 p.m.)


Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Bugs: MESOS-4582
https://issues.apache.org/jira/browse/MESOS-4582


Repository: mesos


Description (updated)
---

Made `JSON::parse` disallow duplicate keys in stout.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
87d018386ea59b16bf69b529426b6567727ed545 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
4ea610c3cd373f05843954763173b9bd51d8d5f5 

Diff: https://reviews.apache.org/r/43160/diff/


Testing
---

Added `TEST(JsonTest, DuplicateKeys)` test to 
`3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp` + `make check`


Thanks,

Michael Park

Review Request 43159: Removed the duplicate "active" field in json schema of `Framework`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43159/
---

Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Bugs: MESOS-4582
https://issues.apache.org/jira/browse/MESOS-4582


Repository: mesos


Description
---

The new `jsonify` library is a writer-based approach, and does not keep track 
of the fields that have been written out so far.
The previous version of `summarize(framework)` and `model(framework)` had a 
duplicate `"active"` field which was de-duplicated since they simply get 
inserted to a `std::map`, overriding the previous value.

In the `jsonify` case, this pattern results in duplicate key in the JSON 
output. Although the presence of duplicate keys is technically not __invalid__ 
according to the JSON specification, some JSON libraries disallow them.
As such, we should generate JSON outputs without duplicate keys.


Diffs
-

  src/master/http.cpp 3d7a624b78fd85a8d99bce609e37411ed660678c 

Diff: https://reviews.apache.org/r/43159/diff/


Testing
---

Verified that `make check` __with__ https://reviews.apache.org/r/43160/ + 
https://reviews.apache.org/r/43161/ and __without__ this patch breaks.


Thanks,

Michael Park

Review Request 43160: Made `JSON::parse` disallow duplicate keys in stout.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43160/
---

Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Bugs: MESOS-4582
https://issues.apache.org/jira/browse/MESOS-4582


Repository: mesos


Description
---

Since some JSON libraries disallow the presence of duplicate keys, we should 
restrict our JSON library to disallow them as well, to help mitigate issues 
that arise with other restrictive JSON libraries.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
87d018386ea59b16bf69b529426b6567727ed545 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
4ea610c3cd373f05843954763173b9bd51d8d5f5 

Diff: https://reviews.apache.org/r/43160/diff/


Testing
---

Added `TEST(JsonTest, DuplicateKeys)` test to 
`3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp` + `make check`


Thanks,

Michael Park

Review Request 43161: Made `JSON::parse` disallow duplicate keys in libprocess.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43161/
---

Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Bugs: MESOS-4582
https://issues.apache.org/jira/browse/MESOS-4582


Repository: mesos


Description
---

See [r43160](https://reviews.apache.org/r/43160) for details. This patch adds a 
`picojson-1.3.0.patch` to restrict `picojson::parse` from allowing duplicate 
keys.


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am 
42c95a970b13ef4d72665d0b87bac87722f6decd 
  3rdparty/libprocess/3rdparty/picojson-1.3.0.patch PRE-CREATION 

Diff: https://reviews.apache.org/r/43161/diff/


Testing
---

See [r43160](https://reviews.apache.org/r/43160).


Thanks,

Michael Park

Re: Review Request 42754: Added support for labels to resource reservations.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/
---

(Updated Feb. 3, 2016, 11:05 p.m.)


Review request for mesos and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-4479
https://issues.apache.org/jira/browse/MESOS-4479


Repository: mesos


Description
---

Labels are free-form key-value pairs that can be used to associate
metadata with reserved resources.


Diffs (updated)
-

  include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
  include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a54411 
  include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
  include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 
  src/common/resources.cpp 588a279c3cdebbeb58047bfbff5e78a42f53fc13 
  src/common/type_utils.cpp 42e3061818c49c6b62d4fee2479db078dfe0fc89 
  src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488 
  src/tests/reservation_endpoints_tests.cpp 
35c093567b07a11ca6eee85e2ff91894a460a7af 
  src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a 
  src/v1/mesos.cpp 21b14cf7050270facab1ba2b844c3fde664665a4 
  src/v1/resources.cpp be4a5d153e9313cb71a6e85d1ed25a358537f2b7 

Diff: https://reviews.apache.org/r/42754/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 42752: Fixed some typos in test case comments.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42752/
---

(Updated Feb. 3, 2016, 11:05 p.m.)


Review request for mesos and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Fixed some typos in test case comments.


Diffs (updated)
-

  src/tests/containerizer/port_mapping_tests.cpp 
182fe9217a5da9af603d6f9c203a1689eff4ca1b 
  src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9 
  src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a 

Diff: https://reviews.apache.org/r/42752/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 42751: Tweaked some resource test cases.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42751/
---

(Updated Feb. 3, 2016, 11:04 p.m.)


Review request for mesos and Michael Park.


Changes
---

Code review from mpark.


Repository: mesos


Description
---

We should check that two reservations with the same role but different
principals are considered distinct.


Diffs (updated)
-

  src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a 

Diff: https://reviews.apache.org/r/42751/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 42753: Allowed `createLabel` to take an optional "value".

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42753/#review117704
---


Ship it!




Ship It!

- Kapil Arya


On Jan. 25, 2016, 6 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42753/
> ---
> 
> (Updated Jan. 25, 2016, 6 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This better matches the underlying protobuf definition.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 7280c9fe36726df6b02ff468c7bd5ecedf5f5023 
>   src/common/protobuf_utils.cpp 53324ab569751924f25290641d1a70da790c2104 
> 
> Diff: https://reviews.apache.org/r/42753/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42751: Tweaked some resource test cases.

[Neil Conway]

> On Feb. 3, 2016, 10:45 p.m., Michael Park wrote:
> > src/tests/resources_tests.cpp, line 957
> > 
> >
> > We used to have a `Resources::size()` function which essentially did 
> > this, but intentionally removed it so that people don't rely on number of 
> > `Resource` instances. Is there a reason why we want to check for this?
> > 
> > Here and below.

The # of `Resource` instances is part of the public API of `Resources` (e.g., 
clients can iterate over every `Resource`). If it is part of the public API, it 
seems like something it would be worth testing.

In this particular case, it doesn't matter that much, but in other test cases 
(e.g., `AdditionDynamicallyReservedWithDistinctLabels`) it seems useful to 
check.


> On Feb. 3, 2016, 10:45 p.m., Michael Park wrote:
> > src/tests/resources_tests.cpp, line 1603
> > 
> >
> > Can we just add the (same role, different principal) case rather than 
> > replacing it with the (different role, different principal) case?
> > 
> > For that matter, can we also add the (different role, same principal) 
> > case? This will be relevant once we have multi-role frameworks I think, 
> > right?

Sure thing. At some point it probably doesn't make sense to test the entire 
cross-product of different resource properties, but for now it should be fine.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42751/#review117698
---


On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42751/
> ---
> 
> (Updated Feb. 3, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We should check that two reservations with the same role but different
> principals are considered distinct.
> 
> 
> Diffs
> -
> 
>   src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a 
> 
> Diff: https://reviews.apache.org/r/42751/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41290: Modified `TestContainerizer` to handle HTTP based executors.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41290/#review117684
---




src/tests/containerizer.hpp (line 140)


s/v1callbacks/v1Callbacks/



src/tests/containerizer.hpp (line 144)


s/v1mesos/v1Mesos/



src/tests/containerizer.cpp (lines 104 - 108)


move this to #163



src/tests/containerizer.cpp (line 116)


kill this and just do a contains check below at #164.



src/tests/containerizer.cpp (line 157)


not yours, but can you fix the indentation here?


- Vinod Kone


On Jan. 22, 2016, 8:32 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41290/
> ---
> 
> (Updated Jan. 22, 2016, 8:32 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4457
> https://issues.apache.org/jira/browse/MESOS-4457
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies the `TestContainerizer` class to handle HTTP based 
> executors. Previously, the containerizer test class only used to handle the 
> driver interface.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer.hpp 25b64dacca65aa0ac49a05a2fbaf526aa0761471 
>   src/tests/containerizer.cpp 15c8b19f3116e60d80671c64ff33580b552dc1ec 
> 
> Diff: https://reviews.apache.org/r/41290/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42753: Allowed `createLabel` to take an optional "value".

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42753/#review117702
---


Ship it!




Ship It!

- Michael Park


On Jan. 25, 2016, 11 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42753/
> ---
> 
> (Updated Jan. 25, 2016, 11 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This better matches the underlying protobuf definition.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 7280c9fe36726df6b02ff468c7bd5ecedf5f5023 
>   src/common/protobuf_utils.cpp 53324ab569751924f25290641d1a70da790c2104 
> 
> Diff: https://reviews.apache.org/r/42753/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43134: Added output operator for unversioned executor protobuf.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43134/#review117700
---


Ship it!




Looks like the output operator for call is already used in slave/http.cpp :)

- Vinod Kone


On Feb. 3, 2016, 6:59 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43134/
> ---
> 
> (Updated Feb. 3, 2016, 6:59 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds the missing output operator for the unversioned executor 
> protobuf. These are not used in the source code currently and hence were 
> missing. The executor library uses the `v1` protobufs and the output operator 
> for them was already added.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor/executor.hpp 
> a7d40f6acaf24e086fb46ecfb74e97612ba326d4 
> 
> Diff: https://reviews.apache.org/r/43134/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42752: Fixed some typos in test case comments.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42752/#review117699
---


Ship it!




Ship It!

- Michael Park


On Feb. 3, 2016, 5:50 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42752/
> ---
> 
> (Updated Feb. 3, 2016, 5:50 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed some typos in test case comments.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 182fe9217a5da9af603d6f9c203a1689eff4ca1b 
>   src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9 
>   src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a 
> 
> Diff: https://reviews.apache.org/r/42752/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42751: Tweaked some resource test cases.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42751/#review117698
---


Fix it, then Ship it!





src/tests/resources_tests.cpp (line 957)


We used to have a `Resources::size()` function which essentially did this, 
but intentionally removed it so that people don't rely on number of `Resource` 
instances. Is there a reason why we want to check for this?

Here and below.



src/tests/resources_tests.cpp (line 1603)


Can we just add the (same role, different principal) case rather than 
replacing it with the (different role, different principal) case?

For that matter, can we also add the (different role, same principal) case? 
This will be relevant once we have multi-role frameworks I think, right?


- Michael Park


On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42751/
> ---
> 
> (Updated Feb. 3, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We should check that two reservations with the same role but different
> principals are considered distinct.
> 
> 
> Diffs
> -
> 
>   src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a 
> 
> Diff: https://reviews.apache.org/r/42751/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43096/
---

(Updated Feb. 3, 2016, 10:41 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added helper function in cgroup for supporting net_cls subsystem.


Diffs (updated)
-

  src/linux/cgroups.hpp 83b3e401ac69194bef496087dee32e0532b834ab 
  src/linux/cgroups.cpp bbc1fb3c60e53dffb1e8029942725e7102eb9aee 

Diff: https://reviews.apache.org/r/43096/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan

Re: Review Request 42755: Added documentation for labeled reserved resources.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/
---

(Updated Feb. 3, 2016, 10:40 p.m.)


Review request for mesos and Michael Park.


Changes
---

Address review comments from Joerg.


Repository: mesos


Description
---

Added documentation for labeled reserved resources.


Diffs (updated)
-

  docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 

Diff: https://reviews.apache.org/r/42755/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 43131: Modified existing usage of Slave constructor.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43131/
---

(Updated Feb. 3, 2016, 10:40 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Made local cluster use generated process ID's and not static ones.


Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255


Repository: mesos


Description
---

This change adds the argument process ID wherever the `Slave` object is 
constructed.


Diffs (updated)
-

  src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f 
  src/slave/main.cpp a412cebcaf533feaff54e8ed398ae7007263e51f 
  src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 

Diff: https://reviews.apache.org/r/43131/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 43151: Added 0.27.0 blog post.

[Kapil Arya]

> On Feb. 3, 2016, 5:27 p.m., Benjamin Bannier wrote:
> > site/source/blog/2016-02-02-mesos-0-27-0-released.md, line 41
> > 
> >
> > Not sure if the policy is just taking what `git log` reports, but right 
> > now we capitalize inconsitently here, e.g. `s/sridharan/Sridharan/`, 
> > `s/hasodent huang/Haosdent Huang/`.

I am not sure. The previous blog posts have the same inconsistency. I'll try to 
add it to the release guide to future releases.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43151/#review117691
---


On Feb. 3, 2016, 5:21 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43151/
> ---
> 
> (Updated Feb. 3, 2016, 5:21 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 0.27.0 blog post.
> 
> 
> Diffs
> -
> 
>   site/source/blog/2016-02-02-mesos-0-27-0-released.md PRE-CREATION 
>   site/source/index.html.md cfdc7cd18fdc99230a618d812264612bbb42c596 
> 
> Diff: https://reviews.apache.org/r/43151/diff/
> 
> 
> Testing
> ---
> 
> Generated site with rake and verified the post.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43148: Fixed typos in scheduler HTTP API docs.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43148/#review117694
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 3, 2016, 10:24 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43148/
> ---
> 
> (Updated Feb. 3, 2016, 10:24 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typos in scheduler HTTP API docs.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md 3c0b8ff8b831dfe595652229111b7f2ca1a2b933 
> 
> Diff: https://reviews.apache.org/r/43148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43151: Added 0.27.0 blog post.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43151/#review117691
---


Fix it, then Ship it!





site/source/blog/2016-02-02-mesos-0-27-0-released.md (line 19)


`s/whiltelist/whitelist/`



site/source/blog/2016-02-02-mesos-0-27-0-released.md (line 41)


Not sure if the policy is just taking what `git log` reports, but right now 
we capitalize inconsitently here, e.g. `s/sridharan/Sridharan/`, `s/hasodent 
huang/Haosdent Huang/`.


- Benjamin Bannier


On Feb. 3, 2016, 11:21 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43151/
> ---
> 
> (Updated Feb. 3, 2016, 11:21 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 0.27.0 blog post.
> 
> 
> Diffs
> -
> 
>   site/source/blog/2016-02-02-mesos-0-27-0-released.md PRE-CREATION 
>   site/source/index.html.md cfdc7cd18fdc99230a618d812264612bbb42c596 
> 
> Diff: https://reviews.apache.org/r/43151/diff/
> 
> 
> Testing
> ---
> 
> Generated site with rake and verified the post.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43149/#review117693
---



Bad patch!

Reviews applied: [43149]

Failed command: ./support/apply-review.sh -n -r 43149

Error:
2016-02-03 22:26:52 URL:https://reviews.apache.org/r/43149/diff/raw/ 
[1562/1562] -> "43149.patch" [1]
Total errors found: 0
Checking 1 files
ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
mesos:
  docs/configuration.md
libprocess:
  3rdparty/libprocess/src/process.cpp

Full log: https://builds.apache.org/job/mesos-reviewbot/11224/console

- Mesos ReviewBot


On Feb. 3, 2016, 9:38 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43149/
> ---
> 
> (Updated Feb. 3, 2016, 9:38 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Check the LIBPROCESS_THREAD_COUNT environment variable to determine
> the number of threads in the libprocess thread pool.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 
>   docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 
> 
> Diff: https://reviews.apache.org/r/43149/diff/
> 
> 
> Testing
> ---
> 
> make check on OS X. Running in production for many months.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 43148: Fixed typos in scheduler HTTP API docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43148/
---

Review request for mesos.


Repository: mesos


Description
---

Fixed typos in scheduler HTTP API docs.


Diffs
-

  docs/scheduler-http-api.md 3c0b8ff8b831dfe595652229111b7f2ca1a2b933 

Diff: https://reviews.apache.org/r/43148/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 43151: Added 0.27.0 blog post.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43151/
---

(Updated Feb. 3, 2016, 5:21 p.m.)


Review request for mesos and Michael Park.


Changes
---

Fixed wrapping.


Repository: mesos


Description
---

Added 0.27.0 blog post.


Diffs (updated)
-

  site/source/blog/2016-02-02-mesos-0-27-0-released.md PRE-CREATION 
  site/source/index.html.md cfdc7cd18fdc99230a618d812264612bbb42c596 

Diff: https://reviews.apache.org/r/43151/diff/


Testing
---

Generated site with rake and verified the post.


Thanks,

Kapil Arya

Re: Review Request 43151: Added 0.27.0 blog post.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43151/#review117685
---


Fix it, then Ship it!





site/source/blog/2016-02-02-mesos-0-27-0-released.md (lines 15 - 30)


I don't think we wrap these at 80. The previous blog posts didn't do so, 
and we don't wrap at 80 below either.


- Michael Park


On Feb. 3, 2016, 10:06 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43151/
> ---
> 
> (Updated Feb. 3, 2016, 10:06 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 0.27.0 blog post.
> 
> 
> Diffs
> -
> 
>   site/source/blog/2016-02-02-mesos-0-27-0-released.md PRE-CREATION 
>   site/source/index.html.md cfdc7cd18fdc99230a618d812264612bbb42c596 
> 
> Diff: https://reviews.apache.org/r/43151/diff/
> 
> 
> Testing
> ---
> 
> Generated site with rake and verified the post.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41288/
---

(Updated Feb. 3, 2016, 10:14 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Updated deps since the previous change has now been committed. Would address 
review comments in next iteration.


Bugs: MESOS-4433
https://issues.apache.org/jira/browse/MESOS-4433


Repository: mesos


Description
---

This change introduces a versioned callback interface for testing HTTP based 
executors. The reasoning is similar to `MESOS-3339` , the corresponding issue 
for Schedulers.


Diffs
-

  src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 

Diff: https://reviews.apache.org/r/41288/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 41288: Introduced an callback interface for testing HTTP based executors.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41288/#review117527
---




src/tests/mesos.hpp (line 839)


The naming here is a bit confusing.

How about putting this class and the above in an executor namespace and do 
something like this:

```
namespace mesos {
namespace internal {
namespace tests {
...
...
...
namespace executor {

template
class Callbacks
{

};

template 
class TestMesos:: public Mesos
{

};

}
...
...
...
}
}
}

```

One issue might be that someone might be confused between the top level 
MesosTest class and TestMesos class, but I think the namespace should alleviate 
 the confusion.



src/tests/mesos.hpp (line 850)


each argument should be on its own line when wrapping. put `lambda::_1` on 
the next line.



src/tests/mesos.hpp (line 853)


why is this public?



src/tests/mesos.hpp (line 863)


should this be an owned pointer?



src/tests/mesos.hpp (line 869)


new line.


- Vinod Kone


On Jan. 19, 2016, 10:28 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41288/
> ---
> 
> (Updated Jan. 19, 2016, 10:28 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-4433
> https://issues.apache.org/jira/browse/MESOS-4433
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces a versioned callback interface for testing HTTP based 
> executors. The reasoning is similar to `MESOS-3339` , the corresponding issue 
> for Schedulers.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 
> 
> Diff: https://reviews.apache.org/r/41288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 43151: Added 0.27.0 blog post.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43151/
---

Review request for mesos and Michael Park.


Repository: mesos


Description
---

Added 0.27.0 blog post.


Diffs
-

  site/source/blog/2016-02-02-mesos-0-27-0-released.md PRE-CREATION 
  site/source/index.html.md cfdc7cd18fdc99230a618d812264612bbb42c596 

Diff: https://reviews.apache.org/r/43151/diff/


Testing
---

Generated site with rake and verified the post.


Thanks,

Kapil Arya

Re: Review Request 43056: Fixed typo in 'verify_reviews.py'.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43056/#review117682
---


Ship it!




Ship It!

- Michael Park


On Feb. 3, 2016, 9:52 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43056/
> ---
> 
> (Updated Feb. 3, 2016, 9:52 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typo in 'verify_reviews.py'.
> 
> 
> Diffs
> -
> 
>   support/verify_reviews.py 25f3892cf8ba58e4c3fd8a08063f251982876bf4 
> 
> Diff: https://reviews.apache.org/r/43056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42750: Used `std::any_of` instead of `std::count_if` when validating IDs.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42750/#review117681
---


Ship it!




Ship It!

- Michael Park


On Jan. 25, 2016, 10:49 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42750/
> ---
> 
> (Updated Jan. 25, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This makes the intent slightly clearer. In principle it should save a
> few cycles as well, but nothing significant. Also, clarify the name of
> a helper function.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp f2bc1bad79e3b0812c019be3774cd65b58ea2d07 
> 
> Diff: https://reviews.apache.org/r/42750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43131: Modified existing usage of Slave constructor.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43131/
---

(Updated Feb. 3, 2016, 10:02 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Explicitly invoke `process::ID::generate` instead of hardcoding the constant.


Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255


Repository: mesos


Description
---

This change adds the argument process ID wherever the `Slave` object is 
constructed.


Diffs (updated)
-

  src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f 
  src/slave/main.cpp a412cebcaf533feaff54e8ed398ae7007263e51f 
  src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 

Diff: https://reviews.apache.org/r/43131/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 43131: Modified existing usage of Slave constructor.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43131/#review117678
---




src/slave/main.cpp (line 211)


lets use Procses::generate() as before?


- Vinod Kone


On Feb. 3, 2016, 7:56 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43131/
> ---
> 
> (Updated Feb. 3, 2016, 7:56 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4255
> https://issues.apache.org/jira/browse/MESOS-4255
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds the argument process ID wherever the `Slave` object is 
> constructed.
> 
> 
> Diffs
> -
> 
>   src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f 
>   src/slave/main.cpp a412cebcaf533feaff54e8ed398ae7007263e51f 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
> 
> Diff: https://reviews.apache.org/r/43131/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43144: Added env var to set upper bound on number of worker threads.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/#review117677
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On Feb. 3, 2016, 8:57 p.m., Maged Michael wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43144/
> ---
> 
> (Updated Feb. 3, 2016, 8:57 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added env var to set upper bound on number of worker threads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> d8a74d7637d20c81f384e974e4fdeba22effb437 
> 
> Diff: https://reviews.apache.org/r/43144/diff/
> 
> 
> Testing
> ---
> 
> Invocations of mesos-master, mesos-slave, and mesos-tests with the 
> LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
> "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system.
> 
> The results were as expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were 
> created, respectively. The last 3 tests generated warnings, e.g., 
> "LIBPROCESS_MAX_WORKER_THREADS=abc is invalid".
> 
> 
> Thanks,
> 
> Maged Michael
> 
>

Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43149/
---

Review request for mesos and Benjamin Hindman.


Bugs: MESOS-4592
https://issues.apache.org/jira/browse/MESOS-4592


Repository: mesos


Description
---

Check the LIBPROCESS_THREAD_COUNT environment variable to determine
the number of threads in the libprocess thread pool.


Diffs
-

  3rdparty/libprocess/src/process.cpp 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 
  docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 

Diff: https://reviews.apache.org/r/43149/diff/


Testing
---

make check on OS X. Running in production for many months.


Thanks,

James Peach

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43096/
---

(Updated Feb. 3, 2016, 9:17 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added helper function in cgroup for supporting net_cls subsystem.


Diffs (updated)
-

  src/linux/cgroups.hpp 83b3e401ac69194bef496087dee32e0532b834ab 
  src/linux/cgroups.cpp bbc1fb3c60e53dffb1e8029942725e7102eb9aee 

Diff: https://reviews.apache.org/r/43096/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

[Avinash sridharan]

> On Feb. 3, 2016, 7:50 a.m., Anand Mazumdar wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, line 58
> > 
> >
> > We generally leave a line before the comment and the TODO to correctly 
> > demarcate where the comment ends and where the TODO begins.
> > 
> > ```
> > // comments
> > //
> > // TODO(asridharan): 
> > //
> > ```

Done.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42587/#review117588
---


On Feb. 3, 2016, 6:46 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42587/
> ---
> 
> (Updated Feb. 3, 2016, 6:46 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the `NetClsHandleManager` class.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b4bc52114389d1c1efce2830f4292bd89bb0de7c 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 
> 
> Diff: https://reviews.apache.org/r/42587/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42587/
---

(Updated Feb. 3, 2016, 9:11 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345


Repository: mesos


Description
---

Implemented the `NetClsHandleManager` class.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b4bc52114389d1c1efce2830f4292bd89bb0de7c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 

Diff: https://reviews.apache.org/r/42587/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 42755: Added documentation for labeled reserved resources.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117675
---


Ship it!




After previous issues are resolved :-).

- Joerg Schad


On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> ---
> 
> (Updated Feb. 3, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for labeled reserved resources.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/42755/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 43144: Added env var to set upper bound on number of worker threads.

[Maged Michael]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/
---

Review request for mesos.


Summary (updated)
-

Added env var to set upper bound on number of worker threads.


Repository: mesos


Description (updated)
---

Added env var to set upper bound on number of worker threads.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp d8a74d7637d20c81f384e974e4fdeba22effb437 

Diff: https://reviews.apache.org/r/43144/diff/


Testing (updated)
---

Invocations of mesos-master, mesos-slave, and mesos-tests with the 
LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
"-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system.

The results were as expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were 
created, respectively. The last 3 tests generated warnings, e.g., 
"LIBPROCESS_MAX_WORKER_THREADS=abc is invalid".


Thanks,

Maged Michael

Re: Review Request 42755: Added documentation for labeled reserved resources.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review117674
---




docs/reservation.md (line 65)


Should we highlight `labelfree reservation`? As it is not true for dynamic 
reservations in general anymore.



docs/reservation.md (line 80)


s/agent/slave.In the rest of this document we use slave. Alternatively we 
can change all others to agent, but should be consistent.



docs/reservation.md (line 81)


into a single reservation despite having the same role.


- Joerg Schad


On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> ---
> 
> (Updated Feb. 3, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for labeled reserved resources.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/42755/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42586: Defined the NetClsHandleManager class.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42586/
---

(Updated Feb. 3, 2016, 8:43 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345


Repository: mesos


Description
---

This class will be responsible for keeping track of the free and allocated
net_cls handles.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b4bc52114389d1c1efce2830f4292bd89bb0de7c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 

Diff: https://reviews.apache.org/r/42586/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 43082: Added new flag to command executor for command passing.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43082/
---

(Updated Feb. 3, 2016, 12:42 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4004
https://issues.apache.org/jira/browse/MESOS-4004


Repository: mesos


Description
---

Added new flag to command executor for command passing.


Diffs (updated)
-

  src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 

Diff: https://reviews.apache.org/r/43082/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 43081: Supported entrypoint and cmd in docker runtime isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43081/
---

(Updated Feb. 3, 2016, 12:41 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4004
https://issues.apache.org/jira/browse/MESOS-4004


Repository: mesos


Description
---

Supported entrypoint and cmd in docker runtime isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
4b504dbb58823ce7675f1d2048dcc7a27c05663d 
  src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/43081/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 43022: Added protobuf fields for docker runtime isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43022/
---

(Updated Feb. 3, 2016, 12:41 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4517
https://issues.apache.org/jira/browse/MESOS-4517


Repository: mesos


Description
---

Added protobuf fields for docker runtime isolator.


Diffs (updated)
-

  include/mesos/slave/isolator.proto 8b7c54afc4467084b5d22387e55689d06078b504 

Diff: https://reviews.apache.org/r/43022/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 43037: Support env var in docker runtime isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43037/
---

(Updated Feb. 3, 2016, 12:41 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4383
https://issues.apache.org/jira/browse/MESOS-4383


Repository: mesos


Description
---

Support env var in docker runtime isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
4b504dbb58823ce7675f1d2048dcc7a27c05663d 
  src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/43037/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 43036: Plugged in docker runtime isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43036/
---

(Updated Feb. 3, 2016, 12:41 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4517
https://issues.apache.org/jira/browse/MESOS-4517


Repository: mesos


Description
---

Plugged in docker runtime isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
4b504dbb58823ce7675f1d2048dcc7a27c05663d 
  src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/43036/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 43020: Exposed accurate ProvisionInfo to command executor.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43020/
---

(Updated Feb. 3, 2016, 12:41 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Exposed accurate ProvisionInfo to command executor.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
4b504dbb58823ce7675f1d2048dcc7a27c05663d 

Diff: https://reviews.apache.org/r/43020/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 43021: Implemented docker runtime isolator interface.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43021/
---

(Updated Feb. 3, 2016, 12:41 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4517
https://issues.apache.org/jira/browse/MESOS-4517


Repository: mesos


Description
---

Implemented docker runtime isolator interface.


Diffs (updated)
-

  src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/43021/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 43019: Fixed non-camel case in protobuf field.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43019/
---

(Updated Feb. 3, 2016, 12:41 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Fixed non-camel case in protobuf field.


Diffs (updated)
-

  include/mesos/slave/isolator.proto 8b7c54afc4467084b5d22387e55689d06078b504 
  src/slave/containerizer/mesos/containerizer.cpp 
4b504dbb58823ce7675f1d2048dcc7a27c05663d 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
57168c837aabf85c85866ca9d4b5480f281e3143 
  src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 
34aa660204911ce4f22c7735af36c9f1af8b12b9 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
ddc1bf0939e5e8995e6f34fe7b8509b51704f63e 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
24ff8194bb5ea86a31224d2d2c20d367472168aa 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
bce5ab9a1913ee7cebaf55b5ee0b42fa4a325e87 
  src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 
59ffd13920fb1c4fb8dbf04a2823d9cee75a8f27 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
d5dd93d892e3cde2011e208a050eec2b31891f54 
  src/tests/containerizer/isolator_tests.cpp 
8d101df957fd36adac388310eddba2db1f98c029 
  src/tests/containerizer/port_mapping_tests.cpp 
182fe9217a5da9af603d6f9c203a1689eff4ca1b 

Diff: https://reviews.apache.org/r/43019/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 42754: Added support for labels to resource reservations.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/#review117667
---




src/tests/reservation_endpoints_tests.cpp (line 754)


just for my understanding: the filter does not effect reserved resources 
(as we still expect labeledResource2 to be offered below), correct?



src/tests/resources_tests.cpp (line 1623)


Shouldn't we also test that different labels are not considered equal?



src/tests/resources_tests.cpp (line 1666)


Even though this is not done in the rest of the file, a short comment 
explaining the tests intention is helpful and present in other test files. Feel 
free to drop if you disagree.



src/tests/resources_tests.cpp (line 1685)


see above, short comment of test intention.



src/tests/resources_tests.cpp (line 1740)


see above. Short comment describing tests intention.



src/tests/resources_tests.cpp (line 1756)


Isn't this already checked above?



src/tests/resources_tests.cpp (line 1757)


Checking each time the inverse case seems a little superfluous as both 
Resources only differ in the label. Still not a real issue for me



src/v1/resources.cpp (line 1494)


Fine with me, but in the case of volume we have one blank line between the 
last `stream <<` and return statement.


- Joerg Schad


On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42754/
> ---
> 
> (Updated Feb. 3, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4479
> https://issues.apache.org/jira/browse/MESOS-4479
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Labels are free-form key-value pairs that can be used to associate
> metadata with reserved resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
>   include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a54411 
>   include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
>   include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed 
>   src/common/resources.cpp 588a279c3cdebbeb58047bfbff5e78a42f53fc13 
>   src/common/type_utils.cpp 42e3061818c49c6b62d4fee2479db078dfe0fc89 
>   src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488 
>   src/tests/reservation_endpoints_tests.cpp 
> 35c093567b07a11ca6eee85e2ff91894a460a7af 
>   src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a 
>   src/v1/mesos.cpp 21b14cf7050270facab1ba2b844c3fde664665a4 
>   src/v1/resources.cpp be4a5d153e9313cb71a6e85d1ed25a358537f2b7 
> 
> Diff: https://reviews.apache.org/r/42754/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42557: Moved CachedImage to a separate file.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42557/#review117671
---




src/CMakeLists.txt (line 239)


Did you forget to update this patch. I saw it becomes cache.cpp in later 
patches.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 172)


Hum, we don't usually sneak in changes like this in a 'move' patch. It'll 
be very to hard to review. Can you separate this change into a separate patch?


- Jie Yu


On Jan. 30, 2016, 2:06 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42557/
> ---
> 
> (Updated Jan. 30, 2016, 2:06 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently CachedImage is private to the appc store. This will change as we
> implement image fetchers (eg. simple discovery).
> 
> This change will enable image fetcher to use the same structure.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0 
>   src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
>   src/slave/containerizer/mesos/provisioner/appc/image_cache.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/image_cache.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 
> 
> Diff: https://reviews.apache.org/r/42557/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 43003: Moved Appc spec protobuf messages to its own file.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43003/#review117092
---




include/mesos/appc/spec.proto (line 31)


s/AppcImageManifest/ImageManifest

You've already had appc in the namespace.



src/Makefile.am (line 153)


You need to create a PROTO for APPC_SPEC



src/Makefile.am (lines 405 - 413)


You need to do the similar to appc spec files as well.



src/Makefile.am (line 1012)


You need to add APPC_SPEC_PROTO here



src/slave/containerizer/mesos/provisioner/appc/spec.cpp (line 13)


Let's move this file to src/appc/spec.cpp like we did for docker spec files.


- Jie Yu


On Jan. 30, 2016, 2:13 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43003/
> ---
> 
> (Updated Jan. 30, 2016, 2:13 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4564
> https://issues.apache.org/jira/browse/MESOS-4564
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change enables clean separation of concerns and keep appc messages 
> loosely coupled from other mesos messages.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.proto PRE-CREATION 
>   include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 
>   src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
>   src/slave/containerizer/mesos/provisioner/appc/paths.hpp 
> dfeb3ffad2503444854c7830ee1b613ce076dfd8 
>   src/slave/containerizer/mesos/provisioner/appc/paths.cpp 
> 94df5b2007d2988189e9c973b2348697a534ab7e 
>   src/slave/containerizer/mesos/provisioner/appc/spec.hpp 
> d4fd8cbfd5668da9ce4ac86baaadf42945c5abbd 
>   src/slave/containerizer/mesos/provisioner/appc/spec.cpp 
> 324cdfec3766da4a8e324378a6e413477fa2b5d9 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> e3d08d9e49df93d5290099c8bfd917f60c93e51b 
> 
> Diff: https://reviews.apache.org/r/43003/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 42755: Added documentation for labeled reserved resources.

[Neil Conway]

> On Jan. 29, 2016, 1:25 a.m., Qian Zhang wrote:
> > docs/reservation.md, lines 80-81
> > 
> >
> > I understand the two reservations with different labels will not be 
> > combined. But what about the two reservation with same label? Do we need to 
> > describe its behavior here too?
> > 
> > I think the latter is a bit complex, e.g., one reservation made by 
> > framework with a label and another reservation made by operator with the 
> > same label. Will we combine them into one reservation? In this case, the 
> > principle of the two reservations could be different, right? So we will end 
> > up with two separate reservations with same label?

Hi Qian -- good points. If two reservations have different labels, they will 
not be merged. Similarly, if two reservations have the same label but different 
principals or roles, they will also not be merged. You basically need _all_ the 
metadata about two reservations (role, slave-id, principal, labels, etc.) to be 
the same for them to be merged.

Your point made me realize we don't have unit tests for the case where two 
reservations have the same role but different principals -- I opened 
https://issues.apache.org/jira/browse/MESOS-4590 to track that.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review116861
---


On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> ---
> 
> (Updated Feb. 3, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for labeled reserved resources.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/42755/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>