Re: Review Request 53814: GEODE-2100 Add new version of query client server messages

iew156087 --- On Nov. 16, 2016, 5:22 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53814/ > -

Review Request 53814: GEODE-2100 Add new version of query client server messages

/JUnit4DistributedTestCase.java 838bb29 Diff: https://reviews.apache.org/r/53814/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 53401: GEODE-1932: Protected use of global variables

/ClientServerFunctionExecutionDUnitTest.java (line 668) <https://reviews.apache.org/r/53401/#comment224277> the message is doing a list.get(0), but it should be doing a list.get(1) - Jason Huynh On Nov. 2, 2016, 8:14 p.m., nabarun nag

Re: Review Request 53399: Removing some string comparisons in the AttributesDescriptor

> On Nov. 2, 2016, 7:58 p.m., Jason Huynh wrote: > > Ship It! Do you think a unit test should be written for this? Not sure how difficult or useful it would be... - Jason --- This is an automatically generated e-mail. To rep

Re: Review Request 53399: Removing some string comparisons in the AttributesDescriptor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53399/#review154620 --- Ship it! Ship It! - Jason Huynh On Nov. 2, 2016, 7:29 p.m

Re: Review Request 53398: GEODE-1985: Updating the SAFE_QUERY_TIME after updating indexes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53398/#review154621 --- Ship it! Ship It! - Jason Huynh On Nov. 2, 2016, 7:26 p.m

Re: Review Request 52750: GEODE-1985: Check for index expression reevalaution using a time window

ernal/cache/GemFireCacheImpl.java (line 371) <https://reviews.apache.org/r/52750/#comment221083> Was this intended for this diff? - Jason Huynh On Oct. 11, 2016, 9:53 p.m., Dan Smith wrote: > > --- > This is an automati

Re: Review Request 52698: GEODE-1972: Move Geode Hibernate module to a feature branch

/geode/modules/Person.hbm.xml 2105b1d gradle/sonar.gradle 33140d3 settings.gradle 0b7002b Diff: https://reviews.apache.org/r/52698/diff/ Testing --- Thanks, Jason Huynh

Review Request 52698: GEODE-1972: Move Geode Hibernate module to a feature branch

removes hibernate from Geode Diffs - extensions/geode-modules-assembly/build.gradle f037aad gradle/sonar.gradle 33140d3 settings.gradle 0b7002b Diff: https://reviews.apache.org/r/52698/diff/ Testing --- Thanks, Jason Huynh

Re: Hibernate module and Geode 1.0 ?

+1 for moving to a feature branch. > > On Thu, Oct 6, 2016 at 9:32 AM Mark Bretl wrote: > > > +1 for feature branch as well. > > > > --Mark > > > > On Thu, Oct 6, 2016 at 9:30 AM, Dan Smith wrote: > > > > > +1 for moving it to a feature branch.

Re: Hibernate module and Geode 1.0 ?

Bumping to see if we have come to a decision on whether we want to move this to a feature branch and get rid of it for 1.0 or post 1.0, especially now that the 1.0 release branch has been cut On Fri, Sep 23, 2016 at 5:22 PM Anthony Baker wrote: Likewise! Geode provides an L2 cache for Hibernate

Review Request 52575: GEODE-1962: increment notQueuedConflated stat is peeked object is unresolvable from off heap

1a9b126 geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java f1d4408 Diff: https://reviews.apache.org/r/52575/diff/ Testing --- Thanks, Jason Huynh

Review Request 52518: GEODE-1963: Add lucene xsd to website

-CREATION Diff: https://reviews.apache.org/r/52518/diff/ Testing --- Thanks, Jason Huynh

Review Request 52366: GEODE-1675: Update the tomcat 8 context-fragment files for tcserver to use the new Tomcat8 manager

/ Testing --- Thanks, Jason Huynh

Review Request 52356: GEODE-1944: Index with method invocation in regionPath can throw exception when tombstones clean up during gii

nTest.java PRE-CREATION Diff: https://reviews.apache.org/r/52356/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 52176: GEODE-1926: Modification of peedAhead() function check if heapCopy is successful before adding the key to peekedIds

/SerialGatewaySenderQueue.java (line 796) <https://reviews.apache.org/r/52176/#comment218081> +1 on the less confusing part - Jason Huynh On Sept. 22, 2016, 9:46 p.m., nabarun nag wrote: > > --- > This is an automatically gener

Re: Review Request 52137: GEODE-1925 : Copy the resources directory inside build directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52137/#review150075 --- Ship it! Ship It! - Jason Huynh On Sept. 21, 2016, 9:56 p.m

Re: Review Request 51734: GEODE-1864: CompactMapRangeIndex not updating old keys properly

/cache/query/internal/index/MapRangeIndexMaintenanceJUnitTest.java 9833e43 Diff: https://reviews.apache.org/r/51734/diff/ Testing --- Thanks, Jason Huynh

Re: Need help on querying

Hi Kirk, I am not too familiar with the TypeJson class or how it was being used... for number 2, I am assuming the queryCollectionsDepth is a specific gfsh/function specific to gfsh. I don't think there is an equivalent oql keyword or call for that. -Jason On Wed, Sep 14, 2016 at 10:11 AM Kirk

Re: Build failed in Jenkins: Geode-nightly #591

I'll take a look at the failing test On Tue, Sep 13, 2016 at 7:53 AM Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > > Changes: > > [abaker] GEODE-1809: Fix NPE in GemFireVersion > > [upthewaterspout] GEODE-1881: Support

Review Request 51750: GEODE-1873: Updating geode session module to support Tomcat 7.0.70

iff: https://reviews.apache.org/r/51750/diff/ Testing --- Thanks, Jason Huynh

Review Request 51734: GEODE-1864: CompactMapRangeIndex not updating old keys properly

/index/MapRangeIndexMaintenanceJUnitTest.java e346522 Diff: https://reviews.apache.org/r/51734/diff/ Testing --- Thanks, Jason Huynh

Review Request 51735: GEODE-1840: Certain map queries combine OR predicates into an AND junction

--- Thanks, Jason Huynh

Re: Review Request 51590: GEODE-1838: remove unused test classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51590/#review147621 --- Ship it! Ship It! - Jason Huynh On Sept. 2, 2016, 12:18 a.m

Re: Review Request 51589: GEODE-1832: remove dependency on cacheRunner package

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51589/#review147620 --- Ship it! Ship It! - Jason Huynh On Sept. 2, 2016, 12:15 a.m

Re: Review Request 51184: GEODE-1675: Fix ClassCastException in ClientServer expiry. Also fix for NPE if manager is null

ples/RuleAndClassRuleTest.java (line 79) <https://reviews.apache.org/r/51184/#comment212359> Remove this diff - Jason Huynh On Aug. 17, 2016, 4:34 p.m., Jason Huynh wrote: > > --- > This is an automatical

Review Request 51184: GEODE-1675: Fix ClassCastException in ClientServer expiry. Also fix for NPE if manager is null

/session/catalina/callback/SessionExpirationCacheListener.java 5893c95 geode-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/examples/RuleAndClassRuleTest.java 4e69ec3 Diff: https://reviews.apache.org/r/51184/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

> On Aug. 11, 2016, 11:16 p.m., Jason Huynh wrote: > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java, > > line 189 > > <https://reviews.apache.org/r/51010/diff/1/?file=1471614#file1471614l

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

> On Aug. 11, 2016, 11:16 p.m., Jason Huynh wrote: > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java, > > line 189 > > <https://reviews.apache.org/r/51010/diff/1/?file=1471614#file1471614l

Re: Review Request 51044: GEODE-1737: gfsh query on region that does not exist may cause NPE

already noticed and fixed it. - Jason Huynh On Aug. 12, 2016, 4:44 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Review Request 51044: GEODE-1737: gfsh query on region that does not exist may cause NPE

/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

figDir get cleaned up after the test is run? Should this use a TemporaryFolder rule or something else? - Jason Huynh On Aug. 11, 2016, 10:34 p.m., anilkumar gingade wrote: > > --- > This is an automaticall

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

+1 - built from source distribution - started locator, server, listed members and created regions in gfsh from binary - started locator and server from source built gfsh On Fri, Aug 5, 2016 at 9:58 AM Dan Smith wrote: > +1 > > Verified > * Successful precheckin run of this release - > https://

Review Request 50858: GEODE-1675: Modifying tc server templates and adding the tomcat 8 jars to the tc server distributions

-fragment.xml PRE-CREATION extensions/geode-modules-assembly/release/tcserver/geode-p2p-tomcat-85/context-fragment.xml PRE-CREATION Diff: https://reviews.apache.org/r/50858/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 50818: GEODE-1728: Removing the dispatcher elements from the session filter

filter/SessionReplicationIntegrationJUnitTest.java (line 1251) <https://reviews.apache.org/r/50818/#comment210955> I think this is a typo too? and maybe remove the commented out code? - Jason Huynh On Aug. 4, 2016, 9:07 p.m., Dan Smith wrote: > > --

Re: Review Request 50811: GEODE-1241: Fixing the misspelt words in the geode-wan

/gemfire/cache/client/internal/GatewaySenderBatchOp.java <https://reviews.apache.org/r/50811/#comment210901> YES! This is the if/else that always bugged me - Jason Huynh On Aug. 4, 2016, 5:25 p.m., nabarun nag wrote: > > ---

Review Request 50615: GEODE-1676: Multiple Not Equals in query with Compact Range Index returns incorrect results

/internal/types/TypeUtilTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50615/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 50587: Merge from 82 and couple of other perf related improvements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50587/#review144041 --- Ship it! Ship It! - Jason Huynh On July 28, 2016, 11:43 p.m

Re: Review Request 50361: GEODE-1687: NPE during CqStatusListener method invocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50361/#review143976 --- Ship it! Ship It! - Jason Huynh On July 22, 2016, 10:02 p.m

Re: Review Request 50364: Adding support for Tomcat 8.5.4 for the session module

/r/50364/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 50420: there is a race that cache is still initializing, some components are not ready

/test/LuceneTestUtilities.java (line 125) <https://reviews.apache.org/r/50420/#comment209226> Should resumeSender call waitForRunningStatus()? Long term we should probably fix these asynch pause/resume calls and make them synchronous... - Jason Huynh On July 25, 2016, 9:42 p.m., xi

Review Request 50419: GEODE-1617: Metadata region was not having a cache listener attached

Description --- A minor refactoring accidently missed out on a cache listener. Diffs - extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/util/CreateRegionFunction.java 342968c Diff: https://reviews.apache.org/r/50419/diff/ Testing --- Thanks, Jason

Re: Review Request 50364: Adding support for Tomcat 8.5.4 for the session module

, Jason Huynh

Re: Review Request 50304: GEODE-1674: Using a immuatable object to pass the HashIndexSet and its mask

newHashIndexSetProperties, also remove the starting _ for the variable names? Lastly, computeNumFree can be added as a method into the new HashIndexSetProperties - Jason Huynh On July 21, 2016, 5:39 p.m., nabarun nag wrote: > > --- > T

Review Request 50364: Adding support for Tomcat 8.5.4 for the session module

3b7b2de gradle/dependency-versions.properties 196a4f8 settings.gradle ca34692 Diff: https://reviews.apache.org/r/50364/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 50361: GEODE-1687: NPE during CqStatusListener method invocation.

/cq/CqServiceImpl.java (line 2008) <https://reviews.apache.org/r/50361/#comment209067> Would it make sense to check the cq state prior to this and if it's not running to not check or send status? - Jason Huynh On July 22, 2016, 10:02 p.m., anilkumar gi

Re: Review Request 50089: GEODE-1669: Performance issue with Interest registration with impact on client side event processing

/FilterProfile.java (line 565) <https://reviews.apache.org/r/50089/#comment208024> I think this goes along with Bruce's review, but possibily not as big of a problem, but the keysUnregistered may contain keys that were never actually in the interest list - Jason Huynh On July 15,

Review Request 49904: GEODE-1644 ClassCastException is thrown with in queries against a map index

.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/PdxStringQueryDUnitTest.java 5124d85 Diff: https://reviews.apache.org/r/49904/diff/ Testing --- Thanks, Jason Huynh

Review Request 49772: CI failure: LuceneQueriesClientDUnitTest.entriesFlushedToIndexAfterWaitForFlushCalled

/LuceneQueriesBase.java e817d3b geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java 8aca11c Diff: https://reviews.apache.org/r/49772/diff/ Testing --- geode-lucene:precheckin Thanks, Jason Huynh

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

b178192 geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 358ffaf Diff: https://reviews.apache.org/r/49102/diff/ Testing --- Thanks, Jason Huynh

Re: Build failed in Jenkins: Geode-nightly #518

I'll revert the changes I made, it looks like they may be causing some timing/instability with some wan tests On Sun, Jul 3, 2016 at 7:30 AM Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > > -

Review Request 49471: GEODE-1374: Flaky tests will now have junit xml recorded into seperate directory

/49471/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

e scenarios are now unable to be hit. - Jason --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49102/#review140051 --- On June 22, 2016,

Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

/ConcurrentSerialGatewaySenderEventProcessor.java ff810ec geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java b178192 Diff: https://reviews.apache.org/r/49102/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 48757: GEODE-11: Cleaning up old IndexRepositoryImpls when buckets move

/internal/repository/IndexRepositoryImpl.java (line 62) <https://reviews.apache.org/r/48757/#comment203048> I think the method spelling is incorrect. Has one too many p's Not from this checkin but maybe we can fix that? - Jason Huynh On June 15, 2016, 9:13 p.m., Dan

Re: New committer and PPMC Member: Nabarun Nag

Congrats! On Tue, Jun 14, 2016 at 3:22 PM, Dave Barnes wrote: > Welcome, Nabarun! > > On Tue, Jun 14, 2016 at 3:07 PM, Dan Smith > wrote: > > > Please welcome the newest committer to the apache Geode project - Nabarun > > Nag! > > > > We appreciate all the work he has already contributed thus f

Re: Review Request 48699: GEODE-11: Support indexing values that are Strings or Numbers

> On June 14, 2016, 5:07 p.m., Jason Huynh wrote: > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/HeterogeneousLuceneSerializer.java, > > line 71 > > <https://reviews.apache.org/r/48699/diff/1/?file=1418740#file1418740lin

Re: Review Request 48695: Allows passing in a defaultField into the query search

/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java 15ef449 geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java 0cf8953 Diff: https://reviews.apache.org/r/48695/diff/ Testing --- Thanks, Jason

Re: Review Request 48699: GEODE-11: Support indexing values that are Strings or Numbers

see if the list is size of 1 also and prevent them from doing that? - Jason Huynh On June 14, 2016, 5:02 p.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 48695: Allows passing in a defaultField into the query search

> > default field is really specific to this StandardQueryParser, but the user > > may be constructing their query programatically and have no need for one. > > If they do need a default field, they can embed it in their > > LuceneQueryProvider. > > Jason Huynh

Re: Review Request 48695: Allows passing in a defaultField into the query search

ucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java > b7709bc > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java > 15ef449 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java > 0cf8953 > > Diff: https://reviews.apache.org/r/48695/diff/ > > > Testing > --- > > > Thanks, > > Jason Huynh > >

Review Request 48695: Allows passing in a defaultField into the query search

/cache/lucene/test/LuceneTestUtilities.java 0cf8953 Diff: https://reviews.apache.org/r/48695/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 48661: GEODE-1543: Changed the log level from error to warn

barun nag wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48661/ > --- > > (Updated June 13, 2016, 7:33 p.m.) > > > Review request for geode, anilkumar gingade,

Re: Review Request 48658: Change from MultiFieldQueryParser to StandardQueryParser

what the true default field should be... - Jason --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48658/#review137345 ------

Review Request 48658: Change from MultiFieldQueryParser to StandardQueryParser

/internal/StringQueryProvider.java 62cb65c geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProviderJUnitTest.java cfd8c32 Diff: https://reviews.apache.org/r/48658/diff/ Testing --- Thanks, Jason Huynh

Review Request 48556: Fixing spark connector build issue due to ConfigurationProperties name change

Diff: https://reviews.apache.org/r/48556/diff/ Testing --- Thanks, Jason Huynh

Re: Proposal to allow eviction and expiration operations/events with AsyncEventQueue.

*I will wait for other feedbacks/comments, if there is no objection i willchange it to "forwardExpirationDestroy" with default value set to true.* think you meant to say default value to set false :-) On Fri, Jun 3, 2016 at 11:47 AM, Anilkumar Gingade wrote: > Thanks Darrel... > > The name chan

Re: Review Request 48176: Changed cache xml property for spark tests to use new DistributionConfig property

/io/pivotal/geode/spark/connector/JavaApiIntegrationTest.java (line 61) <https://reviews.apache.org/r/48176/#comment200983> Yes, I believe you are correct. Fixing it! - Jason Huynh On June 2, 2016, 5:07 p.m., Jason Huynh

Review Request 48176: Changed cache xml property for spark tests to use new DistributionConfig property

/ Testing --- Thanks, Jason Huynh

Re: Review Request 48145: GEODE-11: Adding a method to LuceneIndexImpl to dump indexes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48145/#review135850 --- Ship it! Do the tests clean up the exported files? - Jason

Review Request 48153: Resolved compile warning for LuceneQueriesIntegrationTest

/diff/ Testing --- Thanks, Jason Huynh

Review Request 48151: Prevent lucene index from being created on region with eviction action local destroy

/LuceneServiceImpl.java f9bb8ba geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationIntegrationTest.java d1cd8ac Diff: https://reviews.apache.org/r/48151/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 48138: GEODE-11 Adding stats for the lucene file system.

/gemfire/cache/lucene/internal/LuceneIndexImpl.java (line 71) <https://reviews.apache.org/r/48138/#comment200872> Should these be passed in or be created in an overrideable method? Do we plan on having different stats/stat types for pr and replicated region in the future? - Jason

Re: Review Request 48086: GEODE-11: Adding a tool to dump the lucene index files

function argument (such as a bad location or a null location?) geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFiles.java (line 74) <https://reviews.apache.org/r/48086/#comment200702> Maybe check to see if index is null first? - Jason

Re: Review Request 47912: GEODE-11: Adding stats for lucene index updates and queries

his up into maybe the crud stats, and query? If we break it up per stat, I can see why that would be a bit tedious... - Jason Huynh On May 26, 2016, 6:26 p.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 47803: field value could be null, need to handle this case

/internal/repository/serializer/ReflectionLuceneSerializer.java (line 73) <https://reviews.apache.org/r/47803/#comment199714> If we wanted to do something similar we could change SerializerUtil to detect a null value and stuff a token in, but do we want to do that? - Jason Huynh On

Re: Review Request 47686: GEODE-11: Added changes to Lucene AEQ, to propagate destroy events due to eviction and expiration (by setting the flag ignoreEvictionAndExpiration()).

/LuceneIndexMaintenanceIntegrationTest.java (line 120) <https://reviews.apache.org/r/47686/#comment199153> is this supposed to be commented out? - Jason Huynh On May 21, 2016, 12:57 a.m., anilkumar gingade wrote: > > ---

Re: Review Request 47615: GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. The test stops the CQ and verifies no events are recieved in stopped state; it was doing that b

test now? - Jason Huynh On May 19, 2016, 10:54 p.m., anilkumar gingade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47615: GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. The test stops the CQ and verifies no events are recieved in stopped state; it was doing that b

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47615/#review134060 --- Ship it! - Jason Huynh On May 19, 2016, 9:47 p.m., anilkumar

Re: Review Request 47615: GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. The test stops the CQ and verifies no events are recieved in stopped state; it was doing that b

we have a wait for updated later and do not do any validation until after the update. - Jason Huynh On May 19, 2016, 9:47 p.m., anilkumar gingade wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 47496: Adding transaction tests for lucene indexes

che/lucene/LuceneIntegrationTest.java c302460 geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplIntegrationTest.java fa3392c Diff: https://reviews.apache.org/r/47496/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 47496: Adding transaction tests for lucene indexes

an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47496/#review133671 --- On May 17, 2016, 10:54 p.m., Jason Huynh wrote: > >

Re: Review Request 47496: Adding transaction tests for lucene indexes

they want to use and expect. - Jason --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47496/#review133663 --- On May

Review Request 47496: Adding transaction tests for lucene indexes

e. Diffs - geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplIntegrationTest.java fa3392c Diff: https://reviews.apache.org/r/47496/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 47004: a quick solution to wait for entry flushed into index

you could change the tests to use your new method and remove the old awaitility work arounds... Also, I was wondering if we should throw an exception if the flush method exceeds the max wait time. Then the test will know exactly that the queue did not flush properly... - Jason Huynh On May

Re: Review Request 47004: a quick solution to wait for entry flushed into index

, TimeUnit.MILLISECONDS).until(() -> assertEquals(0, queue.size())); } geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java (line 103) <https://reviews.apache.org/r/47004/#comment197790> Should we throw an exception if we never get to 0? -

Re: Review Request 46918: GEODE-11: Refactoring the LuceneFunctionReadPathDUnitTest

> On May 3, 2016, 9:20 p.m., Jason Huynh wrote: > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java, > > line 60 > > <https://reviews.apache.org/r/46918/diff/2/?file=1369368#file1369368line60> > > > > Should we pull

Re: Review Request 46918: GEODE-11: Refactoring the LuceneFunctionReadPathDUnitTest

ld be when we finally support creating indexes after the region has been created? - Jason Huynh On May 3, 2016, 12:12 a.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 46917: GEODE-625: Adding tests for exception handling of functions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46917/#review131559 --- Ship it! Ship It! - Jason Huynh On May 3, 2016, 1:03 a.m

Re: Review Request 46918: GEODE-11: Refactoring the LuceneFunctionReadPathDUnitTest

(line 26) <https://reviews.apache.org/r/46918/#comment195397> Remove? - Jason Huynh On May 2, 2016, 11:43 p.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 46917: GEODE-625: Adding tests for exception handling of functions

t.java (line 18) <https://reviews.apache.org/r/46917/#comment195388> Should this be proxy RR instead of remote RR? Is this a client or a peer proxy? - Jason Huynh On May 2, 2016, 10:57 p.m., Dan Smith wrote: > > --

Re: Upgrading Gradle to version 2.12

gt; > > > On Wed, Apr 27, 2016 at 10:41 AM, Jason Huynh wrote: > > > > > Hello Geode dev list, > > > > > > As a heads up, I am about to check in a change to upgrade the Gradle > > > version to 2.12. This will address GEODE-1259, GEODE-1085, GEOD

Upgrading Gradle to version 2.12

Hello Geode dev list, As a heads up, I am about to check in a change to upgrade the Gradle version to 2.12. This will address GEODE-1259, GEODE-1085, GEODE-1261. This change will now make the required minimum Gradle Version the same as the version used by the Gradle Wrapper Plugin. This may aff

Re: Review Request 46706: GEODE-1259: Upgrade gradle version to 2.12

; it both here and in gradle.properties? I moved the minimumGradleVersion to gradle.properties and removed the one in settings.gradle. Was there a reason to keep it in settings.gradle instead? On April 27, 2016, 1:46 p.m., Jason Huynh wrote: > > After running `gradle wrapper` with

Review Request 46706: GEODE-1259: Upgrade gradle version to 2.12

c579dce Diff: https://reviews.apache.org/r/46706/diff/ Testing --- Thanks, Jason Huynh

Review Request 46464: GEODE-1266: Removed Pivotal license header and also minor clean up

--- Thanks, Jason Huynh

Review Request 46463: GEODE-1188: Lucene indexes can be created with partition redundant regions

://reviews.apache.org/r/46463/diff/ Testing --- geode-lucene:precheckin Thanks, Jason Huynh

Re: Review Request 45897: Update gemfire-spark project to geode-spark project and also renamed packages and files

://reviews.apache.org/r/45897/diff/ Testing --- sbt clean compile package test it:test Thanks, Jason Huynh

Review Request 46239: UnitTest for LuceneIndexForPartitionedRegion

/LuceneIndexForPartitionedRegion.java 25b63a4 geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java PRE-CREATION Diff: https://reviews.apache.org/r/46239/diff/ Testing --- Thanks, Jason Huynh

Re: Review Request 46156: GEODE-679 Explore removing SocketIOWithTimeout and other classes related to FD soft leak

and SocketOutputStream along with these changes - Jason Huynh On April 13, 2016, 5:48 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

  1   2   3   >