Github user chrajeshbabu commented on the issue:
https://github.com/apache/phoenix/pull/238
+1 Kevin. Thanks for the update. Will commit it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r90192895
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForPartialBuildIT.java
---
@@ -217,39 +223,47 @@ public void testSecondaryIndex
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r90192647
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java ---
@@ -167,50 +180,152 @@ private void printHelpAndExit(Options
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r90188400
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -305,16 +305,27 @@
TENANT_ID
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r83832270
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -305,16 +305,27 @@
TENANT_ID
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r83827883
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java ---
@@ -167,50 +180,152 @@ private void printHelpAndExit(Options
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r83827393
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java ---
@@ -167,50 +180,152 @@ private void printHelpAndExit(Options
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r83824633
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java ---
@@ -85,7 +102,7 @@
private static final Option
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r83795678
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java
---
@@ -568,4 +580,52 @@ public void testAsyncCreatedDate
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r83795282
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java
---
@@ -568,4 +580,52 @@ public void testAsyncCreatedDate
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r83795010
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java
---
@@ -216,6 +219,15 @@ public void testIndexCreateDrop
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r83793592
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/OrderByIT.java ---
@@ -500,14 +500,12 @@ public void testOrderByWithExpression() throws
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r83793514
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForPartialBuildWithNamespaceEnabled.java
---
@@ -0,0 +1,71
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r83792778
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForPartialBuildIT.java
---
@@ -0,0 +1,264 @@
+/*
+ * Licensed to the
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r83792475
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForPartialBuildIT.java
---
@@ -0,0 +1,264 @@
+/*
+ * Licensed to the
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/211#discussion_r80925250
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -1445,6 +1445,9 @@ public MetaDataResponse call
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/211#discussion_r80916280
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1499,6 +1502,53 @@ public void createTable
Github user chrajeshbabu commented on the issue:
https://github.com/apache/phoenix/pull/202
@AyolaJayamaha we want these improvements and cleanup to be in 4.8.1
version. Any other things pending here? Is it ready for commit?
---
If your project is set up for it, you can reply to
Github user chrajeshbabu commented on the issue:
https://github.com/apache/phoenix/pull/202
Here are couple of issues found one while starting traceserver and one
while getting the results in UI.
Currently the eclipse jetty version used is 8.1.7.v20120910
From main pom.xml
Github user chrajeshbabu commented on the issue:
https://github.com/apache/phoenix/pull/193
@AyolaJayamaha Currently we are trying to get the webapp related files
form target directory in org.apache.phoenix.tracingwebapp.http.Main. Because of
this we cannot use the runnable jar
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r64123714
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinIT.java ---
@@ -187,13 +186,13 @@ public void initTable() throws Exception
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r64123637
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2455,6 +2409,19 @@ public Void call() throws
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/168#issuecomment-219617896
James as we discussed I have made a patch working with older versions of
HBase first and handled review comments here. Will create new pull request with
that
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463623
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java
---
@@ -160,6 +163,9 @@ public void
preBatchMutate
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463618
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/ParallelWriterIndexCommitter.java
---
@@ -116,7 +117,10 @@ public void write
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463584
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1016,7 +1016,7 @@ private MutationState
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463462
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/DelegateHTable.java ---
@@ -297,4 +297,28 @@ public boolean checkAndDelete(byte[] row
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463482
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
@@ -861,7 +871,12 @@ public Put buildUpdateMutation
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463350
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -202,7 +207,10 @@ protected
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/168#discussion_r63463302
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinIT.java ---
@@ -187,13 +186,13 @@ public void initTable() throws Exception
GitHub user chrajeshbabu opened a pull request:
https://github.com/apache/phoenix/pull/168
PHOENIX-1734 Local index improvements(Rajeshbabu)
This is the patch for new implementation of local index where we store
local index data in the separate column families in the same table
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/156#issuecomment-208184999
Thanks @JamesRTaylor for review. Will rebase the patch and commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/156#issuecomment-207582047
@JamesRTaylor Thanks for the review. Committed the changes handling the
review comments.
Refactored the code and added code comments where ever possible
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r59078097
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ChunkedResultIterator.java
---
@@ -56,6 +57,7 @@
private final MutationState
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r59077866
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
@@ -402,8 +405,8 @@ private RegionScanner
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r59077569
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -337,6 +384,22 @@ public boolean nextRaw
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r59077319
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -279,6 +301,31 @@ protected RegionScanner
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58642550
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String toString(List
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58642188
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58641031
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -326,11 +325,12 @@ private static void
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58640990
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -465,7 +465,14 @@ private static String toString(List
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58641009
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -465,7 +465,14 @@ private static String toString(List
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58640818
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String toString(List
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58640455
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String toString(List
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58640276
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -121,8 +170,21 @@ public synchronized void initScanner
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58639974
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58639989
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58639956
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58639845
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -80,13 +94,19
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58639358
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58638911
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
@@ -402,8 +405,8 @@ private RegionScanner
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58638946
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ---
@@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58638568
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
@@ -423,7 +426,14 @@ private RegionScanner
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58637933
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58632305
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ---
@@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58485551
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ---
@@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58485341
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
---
@@ -86,8 +98,8 @@ public static void doSetup() throws
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58485360
--- Diff:
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
---
@@ -157,6 +162,7 @@ public Reader
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58485324
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/LocalIndexIT.java ---
@@ -727,7 +727,7 @@ public void
GitHub user chrajeshbabu opened a pull request:
https://github.com/apache/phoenix/pull/156
PHOENIX-2628 Ensure split when iterating through results handled corrâ¦
The patch fixes issues with splits and merges while scanning local indexes.
You can merge this pull request into a
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46111265
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
@@ -134,7 +143,36 @@ private static void setValues(byte
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46111214
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -158,6 +162,10 @@ public
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/135#issuecomment-160454376
Thanks for review @JamesRTaylor. Please find my answers to the comments.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096498
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
---
@@ -158,6 +162,10 @@ public
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096442
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
@@ -134,7 +143,36 @@ private static void setValues(byte
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096413
--- Diff:
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
---
@@ -80,6 +81,9 @@ public Reader
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096395
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/HashJoinIT.java ---
@@ -873,7 +873,7 @@ public void initTable() throws Exception
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/135#discussion_r46096275
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java
---
@@ -186,7 +186,9 @@ private void testDeleteRange(boolean autoCommit
GitHub user chrajeshbabu opened a pull request:
https://github.com/apache/phoenix/pull/135
PHOENIX-1734 Local index improvements
Patch supports storing local indexing data in the same data table.
1) Removed code used HBase internals in balancer, split and merge.
2) Create
Github user chrajeshbabu closed the pull request at:
https://github.com/apache/phoenix/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chrajeshbabu closed the pull request at:
https://github.com/apache/phoenix/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/77#issuecomment-96969719
It's committed. Hence closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/77#issuecomment-96276745
Thanks @JamesRTaylor @samarthjain
I have addressed the review comments and added to pull request. If it's ok
I will commit this tomorrow morning IST and
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29103995
--- Diff: phoenix-core/src/main/antlr3/PhoenixSQL.g ---
@@ -114,6 +114,15 @@ tokens
ASYNC='async';
SAMPLING='sampling
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29103983
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098894
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098873
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/77#issuecomment-96145601
Thanks Samarth for reviews. Will update patch addressing the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098680
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java ---
@@ -289,24 +289,6 @@ public void testNegativeCountStar() throws
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098678
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098669
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -700,6 +1007,29 @@ private PTable loadTable
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098659
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/cache/GlobalCache.java ---
@@ -157,4 +159,18 @@ public TenantCache
getChildTenantCache
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098664
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateFunctionCompiler.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/77#discussion_r29098632
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
@@ -383,6 +448,85 @@ protected TableRef createTableRef
GitHub user chrajeshbabu opened a pull request:
https://github.com/apache/phoenix/pull/77
PHOENIX-538 Support UDFs
Patch to support UDFs. It mainly includes
- create temporary/permanent function query parsing
- storing function info
- dynamically loading udf jars
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48949296
Resolved the conflicts after PHOENIX-1002 also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14898689
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ParallelIterators.java ---
@@ -238,7 +240,12 @@ private void
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14898383
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -140,7 +142,14 @@ public boolean apply
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14898287
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -140,7 +142,14 @@ public boolean apply
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14897879
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java ---
@@ -169,6 +170,7 @@
SQLViewTypeFunction
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14897862
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ---
@@ -1134,8 +1135,15 @@ public static SelectStatement
optimize
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14897277
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/IndexStatementRewriter.java
---
@@ -96,6 +96,11 @@ public ParseNode visit
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14897250
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -568,8 +629,13 @@ public MutationState createIndex
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48945719
bq. Just add the check to disable creating local indexes on a table with
immutable rows and then let's check this in.
Changed pull request to disallow
GitHub user chrajeshbabu opened a pull request:
https://github.com/apache/phoenix/pull/3
PHOENIX-933 Local index support to Phoenix
Updated pull request after resolving conflicts and handling James review
comments.
You can merge this pull request into a Git repository by running
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/1#issuecomment-48839233
bq. Cleanest might be to just implement a simple
ParallelIteratorRegionSplitter for use when a local index is used that just
returns all regions:
I will add new
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14858124
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/SkipRangeParallelIteratorRegionSplitter.java
---
@@ -54,7 +55,8 @@ protected
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14853806
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
---
@@ -51,21 +51,38 @@ public static void doSetup() throws
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14853783
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ScanRegionObserver.java
---
@@ -100,7 +109,7 @@ public static void serializeIntoScan
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/1#issuecomment-48798867
Thanks for review @JamesRTaylor. I have resolved the conflicts and handled
all the comments locally. I will submit it once I verify OrderedResultIterator
scenario
1 - 100 of 114 matches
Mail list logo