gregormi added a comment.
In D21861#484556 <https://phabricator.kde.org/D21861#484556>, @dhaumann wrote:
> I'd like to drop the " Current" prefix in all the variables. It just makes
the names longer and I don't see any value for users. Comments?
Th
gregormi accepted this revision.
gregormi added a comment.
Looks good to me.
REPOSITORY
R304 KNewStuff
BRANCH
actions
REVISION DETAIL
https://phabricator.kde.org/D21931
To: nicolasfella, gregormi, ngraham, #vdg, #knewstuff
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
gregormi added a comment.
In D21293#467150 <https://phabricator.kde.org/D21293#467150>, @dhaumann wrote:
> New color is red: F6835074: Screenshot_20190519_175848.png
<https://phabricator.kde.org/F6835074>
>
> @gregormi If you want other colors, please
gregormi added a comment.
What I wonder: during the work with the .rc files I noticed that even the
Kate which is installed in root got affected by the changes I made in the
development version and I had to regularly change the version number to make
changes take effect. Is this normal
gregormi marked an inline comment as done.
gregormi added a comment.
This is what is looks like now (together with latest changes from
https://phabricator.kde.org/D17138):
F6547077: grafik.png <https://phabricator.kde.org/F6547077>
REPOSITORY
R39 KTextEditor
REVISION DETAIL
gregormi updated this revision to Diff 49369.
gregormi added a comment.
- Move "Save As..." out of the submenu
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17137?vs=46132&id=49369
BRANCH
arcpatch-D17137
REVISION
gregormi added a comment.
@loh.tar: I like the new status bar.
> Move the modified label from far right to far left This way have it a more
prominent position
Now, the "modified label" behaves like a button but with no visible action
when it is clicked. Two general
gregormi retitled this revision from "KTextEditor: Tweak keyboard shortcuts to
prepare for F6/Shift+F6 in Kate" to "KTextEditor: Tweak keyboard shortcuts to
free F keys".
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17442
To: gregormi
gregormi added a comment.
With respect to bringing this https://phabricator.kde.org/T10279 forward, how
should I proceed here? Can this go in as first step (after I removed F10 and
F11)? (see also https://phabricator.kde.org/D17443)
INLINE COMMENTS
> kateview.cpp:700
> ac->
gregormi added a comment.
If there are no further comments, would proceed with:
- Introduce "Save Variants" by leaving Save and Save as... top-level. I will
use the name 'file_save_variants'
- Introduce "Print and Export" submenu
- Introduce "Close
gregormi added a comment.
Yes, those shortcuts exist long time. I would like to change them for these
specific reasons which I think are worth to be considered:
1. Introduce a default shortcut pair for "Next / Prev Match" which is useful
and currently missing.
2. "Fr
gregormi added a comment.
In D17442#374054 <https://phabricator.kde.org/D17442#374054>, @ngraham wrote:
> In D17442#373755 <https://phabricator.kde.org/D17442#373755>, @gregormi
wrote:
>
> > In D17442#373708 <https://phabricator.kde.org/D174
gregormi added a comment.
In D17442#373708 <https://phabricator.kde.org/D17442#373708>, @ngraham wrote:
> I always re-bind Find Next and and Find Previous to use [Ctrl] + [G] and
[Ctrl] + [⇧] + [G]. These are the shortcuts that are used by most 3rd-party
apps, as well as all
gregormi edited the summary of this revision.
gregormi added a reviewer: Kate.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17442
To: gregormi, #kate
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns,
demsking, cullmann, sars, dhaumann
gregormi created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
gregormi requested review of this revision.
REVISION SUMMARY
The idea is to use F6 and Shift+F6 in Kate for Next and Previous Search
Match. These shortcuts
gregormi added a comment.
+1 for leaving Save As on top level.
Just for reference the File menu of the current master on my screen :)
F6464245: grafik.png <https://phabricator.kde.org/F6464245>
As for me, at least all the Close actions could be moved into a submenu.
REPO
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D6877
To: gladhorn, dfaure
Cc: kde-frameworks-devel, gregormi, dfaure, apol, cfeck, michaelh, ngraham,
bruns, #frameworks
gregormi retitled this revision from "File menu: Put Save, Print and Export in
submenus" to "KTextEditor: File menu: Put Save, Print and Export in submenus".
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17137
To: gregormi, #kate, #kdevelop
C
gregormi added inline comments.
INLINE COMMENTS
> kurlnavigatorbutton.cpp:414
> +url = KIO::upUrl(m_url);
> +} else if ((m_url.scheme() == QLatin1String("tar")) || (m_url.scheme()
> == QLatin1String("zip"))) {
> +// We are in an archive,
gregormi edited the summary of this revision.
gregormi added a reviewer: KDevelop.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17137
To: gregormi, #kate, #kdevelop
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking,
cullmann, sars
gregormi edited the summary of this revision.
gregormi added a reviewer: Kate.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17137
To: gregormi, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking,
cullmann, sars, dhaumann
gregormi updated this revision to Diff 46132.
gregormi added a comment.
rebase on master
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17137?vs=46128&id=46132
BRANCH
arcpatch-D17137
REVISION DETAIL
https://phabricator.kde.org/D17137
AFFE
gregormi retitled this revision from "File menu: Put Save, Print and Export in
submenus
With https://phabricator.kde.org/D16830 the file menu gets more entries. This
is a suggestion to do some cleanup before.
This is the corresponding patch for Kate: TODO (screenshots are there)..."
gregormi created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
gregormi requested review of this revision.
REVISION SUMMARY
...NOTE: I assume that dependent applications like KWrite and KDevelop must
be adapted, too. So, a
gregormi accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R304 KNewStuff
BRANCH
fix
REVISION DETAIL
https://phabricator.kde.org/D16145
To: nicolasfella, gregormi, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
gregormi added a comment.
I am rather familiar with KMoreTools but not with the rest of KNewStuff.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D13970
To: cordlandwehr, gregormi, nicolasfella, dhaumann, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham
gregormi added a comment.
The spirit goes in the right direction; please proceed :-). Note, that Kate's
project plugin also uses KMoreTools.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D13880
To: nicolasfella, gregormi, dhaumann, ngraham
Cc: kde-frame
gregormi added a comment.
> You are the most awesome person in the world today.
+1 :-)
> Pro: Very flat hierarchy, code could be simplified a lot
> Con: Unwanted and uninstalled tools would be present all the time.
Exactly my thoughts. The idea behind the More me
gregormi added a comment.
In D13706#282765 <https://phabricator.kde.org/D13706#282765>, @ngraham wrote:
> I'd like to see the missing AppStream URLs filled in for all the software
in this list. There are currently some claring omissions, especially for KDE
software (e.g.
gregormi accepted this revision.
gregormi added a comment.
Ok from my side. Probably Dominik also wants to approve.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D13706
To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh
gregormi added inline comments.
INLINE COMMENTS
> kmoretools_p.h:394
> +
> +QUrl appstreamUrl = QUrl(QStringLiteral("appstream://") %
> appstreamId);
> +
What does the % sign do here? Can this be used to concatenate strings? Did not
try it myself.
Otherwise r
gregormi added inline comments.
INLINE COMMENTS
> kmoretoolspresets.cpp:59
> //
> -ADD_ENTRY("angrysearch",0,
> "https://github.com/DoTheEvo/ANGRYsearch";);
> -ADD_ENTRY("com.uploadedlobster.peek", 0,
gregormi added inline comments.
INLINE COMMENTS
> kmoretools.h:500
> + */
> +void setAppstreamUrl(const QUrl& url);
> +
I am not so familiar with appstream. Why not only setting the COMPONENT-ID
instead of the whole URL? Then the method would be named
setApps
gregormi added a comment.
First of all, thanks for adding this feature. This was missing a long time
:-). I will do some comments in the code.
INLINE COMMENTS
> kmoretools.h:488-491
> +QUrl appstreamUrl() const;
> +
> +void setAppstreamUrl(const QUrl& url);
> +
P
gregormi added a comment.
In D11733#235208 <https://phabricator.kde.org/D11733#235208>, @rkflx wrote:
> and the bug reporter's use case of selecting a file in a web browser for
upload essentially wants the existing [F11] preview feature and perhaps a
better preview feat
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:bf82fe7c222f: Add vokoscreen to KMoreTools and add it to
the "screenrecorder" grouping (authored by gregormi).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D10390?vs=26772&am
gregormi added a comment.
Screenshot of test program: F5698743: grafik.png
<https://phabricator.kde.org/F5698743>. One can see the new item.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D10390
To: gregormi, ngraham
Cc: #frameworks, michaelh, ngraham
gregormi retitled this revision from "Minor fix: rename info file to
_README.md" to "Add vokoscreen to KMoreTools and add it to the "screenrecorder"
grouping".
gregormi edited the test plan for this revision.
gregormi added a reviewer: ngraham.
REPOSITORY
R
gregormi created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
gregormi requested review of this revision.
REVISION SUMMARY
Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping
TEST PLAN
gregormi accepted this revision.
gregormi added a comment.
This revision is now accepted and ready to land.
Approval from my side. Thanks.
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8848
To: sitter, #frameworks, whiting, gregormi
gregormi added a comment.
Thanks for committing, Nate.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: mak, ngraham, ltoscano, #frameworks
gregormi updated this revision to Diff 20781.
gregormi added a comment.
Rebase, run _update_all_files.sh and fix outdated desktop files
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7130?vs=17723&id=20781
BRANCH
mydev
REVISION DETAIL
h
gregormi added a comment.
> @ltoscano, can we commit this?
Hi Nate, thanks for pushing this forward.
> I still disagree in the way this is done, as it means manually periodically
updating the information and it's definitely not the right thing to do.
Hi Luigi,
I
gregormi added a comment.
In https://phabricator.kde.org/D7446#148135, @ngraham wrote:
> That said, the advantage to adding this as a Places item is that it shows
up in file open/save dialogs for free, which is where it's most useful.
This would support the use case p
gregormi added a comment.
In https://phabricator.kde.org/D7130#133389, @elvisangelaccio wrote:
> In https://phabricator.kde.org/D7130#132809, @gregormi wrote:
>
> > Hmm, this looks fine. Actually, KMoreTools uses KService to find out if
an application is installed by
gregormi added a comment.
In https://phabricator.kde.org/D7130#132857, @ltoscano wrote:
> In https://phabricator.kde.org/D7130#132425, @gregormi wrote:
>
> > In https://phabricator.kde.org/D7130#132409, @ltoscano wrote:
> >
> > > Just update the Engl
gregormi added a comment.
In https://phabricator.kde.org/D7130#132762, @elvisangelaccio wrote:
> In https://phabricator.kde.org/D7130#132742, @gregormi wrote:
>
> > In https://phabricator.kde.org/D7130#132640, @elvisangelaccio wrote:
> >
> > > It doesn
gregormi added a comment.
In https://phabricator.kde.org/D7130#132640, @elvisangelaccio wrote:
> It doesn't seem to fix the bug here, it's still saying that filelight and
partitionmanager are not installed (but they are).
Can you tell me what distro you are using
gregormi edited the summary of this revision.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio
Cc: ltoscano, #frameworks
gregormi added a comment.
BUG: 369646
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio
Cc: ltoscano, #frameworks
gregormi added a reviewer: elvisangelaccio.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio
Cc: ltoscano, #frameworks
gregormi edited the summary of this revision.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano
Cc: ltoscano, #frameworks
gregormi updated this revision to Diff 17723.
gregormi edited the summary of this revision.
gregormi added a comment.
- add FSearch and AngrySearch to search tools
- Add new grouping "screenrecorder" with Peek and Simples Screen Recorder
- Add new grouping "mouse-too
gregormi added a comment.
In https://phabricator.kde.org/D7130#132409, @ltoscano wrote:
> Just update the English messages.
> More generally, why do we need copies of the system desktop files (even
the ones developed by KDE, org.kde.filelight.desktop?) Isn't there a way
gregormi added a comment.
In https://phabricator.kde.org/D7130#132397, @ltoscano wrote:
> I think there is more than what you want: the translations of desktop are
handled automatically by scripty.
Thanks for the hint. I copied the desktop files from the system installation.
gregormi retitled this revision from "Update and fix desktopfiles" to
"KMoreTools: Update and fix desktopfiles".
gregormi edited the summary of this revision.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano
Cc: ltoscano, #frameworks
gregormi created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R304 KNewStuff
BRANCH
mydev
REVISION DETAIL
https://phabricator.kde.org/D7130
AFFECTED FILES
autotests/kmoretools/kmoretoolstest.cpp
57 matches
Mail list logo
