Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-26 Thread via GitHub
sanpwc merged PR #3629: URL: https://github.com/apache/ignite-3/pull/3629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-26 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580749014 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java: ## @@ -698,7 +698,9 @@ public CompletableFuture> dataNode

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-26 Thread via GitHub
alievmirza commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580743659 ## modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/distributionzones/ItIgniteDistributionZoneManagerNodeRestartTest.java: ## @@ -297,

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-26 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580723266 ## modules/runner/src/main/java/org/apache/ignite/internal/app/LifecycleManager.java: ## @@ -148,12 +153,11 @@ private synchronized void stopAllComponents() {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-26 Thread via GitHub
alievmirza commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580625464 ## modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/distributionzones/ItIgniteDistributionZoneManagerNodeRestartTest.java: ## @@ -297,

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-26 Thread via GitHub
alievmirza commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580625464 ## modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/distributionzones/ItIgniteDistributionZoneManagerNodeRestartTest.java: ## @@ -297,

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580096527 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java: ## @@ -91,11 +92,8 @@ public void beforeNodeStop() { }

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580096804 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java: ## @@ -126,10 +124,8 @@ public void beforeNodeStop() { }

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580096027 ## modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/ItSimpleCounterServerTest.java: ## @@ -97,14 +100,12 @@ void before() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579989020 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java: ## @@ -228,10 +230,16 @@ public void stop() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580051040 ## modules/runner/src/main/java/org/apache/ignite/internal/app/LifecycleManager.java: ## @@ -148,12 +153,11 @@ private synchronized void stopAllComponents() {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579989020 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java: ## @@ -228,10 +230,16 @@ public void stop() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579986903 ## modules/code-deployment/src/test/java/org/apache/ignite/deployment/metastore/DeploymentUnitStoreImplTest.java: ## @@ -102,12 +102,12 @@ public void setup() {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579984730 ## modules/core/src/main/java/org/apache/ignite/internal/manager/IgniteComponent.java: ## @@ -47,7 +47,7 @@ default void beforeNodeStop() { * Stops the component.

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579982932 ## modules/compute/src/test/java/org/apache/ignite/internal/compute/ComputeComponentImplTest.java: ## @@ -477,12 +478,12 @@ void remoteExecutionReleasesStopLock() throw

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579943253 ## modules/index/src/test/java/org/apache/ignite/internal/index/IndexManagerTest.java: ## @@ -226,7 +226,10 @@ private void createAndStartComponents() {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579939781 ## modules/index/src/test/java/org/apache/ignite/internal/index/IndexManagerTest.java: ## @@ -123,8 +123,8 @@ public void setUp() { } @AfterEach -void t

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579938244 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -452,7 +452,13 @@ public synchronized void stop() throws Excepti

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579935936 ## modules/client/src/test/java/org/apache/ignite/client/TestServer.java: ## @@ -315,10 +317,11 @@ public FakePlacementDriver placementDriver() { /** {@inheritDoc}

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579932468 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/BaseDistributionZoneManagerTest.java: ## @@ -138,11 +134,11 @@ public void tear

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579927727 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageManagerImplTest.java: ## @@ -139,9 +139,9 @@ void setUp(

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579922138 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageServiceTest.java: ## @@ -201,8 +201,8 @@ private static class N

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579915557 ## modules/network/src/testFixtures/java/org/apache/ignite/internal/network/utils/ClusterServiceTestUtils.java: ## @@ -178,24 +177,12 @@ public CompletableFuture start(

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579912671 ## modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/Node.java: ## @@ -52,13 +55,13 @@ class Node implements AutoCloseable {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579905344 ## modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/PlacementDriverManagerTest.java: ## @@ -209,14 +209,14 @@ private void s

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579903175 ## modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItLearnersTest.java: ## @@ -120,8 +120,8 @@ Peer asPeer() { } void start()

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579901568 ## modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItRaftGroupServiceTest.java: ## @@ -221,8 +221,8 @@ String name() { } void

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579900229 ## modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItRaftGroupServiceTest.java: ## @@ -258,7 +258,10 @@ void beforeNodeStop() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579896240 ## modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/JraftAbstractTest.java: ## @@ -171,7 +173,7 @@ protected JraftServerImpl startServer(int idx, Co

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579893056 ## modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java: ## @@ -195,19 +197,19 @@ public void beforeT

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579892848 ## modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java: ## @@ -195,19 +197,19 @@ public void beforeT

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579887023 ## modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildingManager.java: ## @@ -142,20 +143,26 @@ public CompletableFuture start() { } @Ov

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579885185 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandlerExceptionHandlingTest.java: ## @@ -53,18 +53,18 @@ public class DdlC

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579880642 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable e) {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579880267 ## modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildingManager.java: ## @@ -142,20 +143,26 @@ public CompletableFuture start() { } @Ov

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579870204 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable e) {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579867816 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandlerExceptionHandlingTest.java: ## @@ -53,18 +53,18 @@ public class DdlC

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579866759 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -452,7 +452,13 @@ public synchronized void stop() throws Excepti

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579864902 ## modules/runner/src/main/java/org/apache/ignite/internal/app/LifecycleManager.java: ## @@ -148,12 +153,11 @@ private synchronized void stopAllComponents() {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579860866 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/BaseCatalogManagerTest.java: ## @@ -104,19 +102,16 @@ void setUp() { () ->

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579859118 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable e) {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579859118 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable e) {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579857581 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable e) {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579857130 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerRecoveryTest.java: ## @@ -81,8 +81,8 @@ public class CatalogManagerRecoveryTest extend

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579846730 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java: ## @@ -698,7 +698,9 @@ public CompletableFuture> dataNode

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579840663 ## modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java: ## @@ -195,19 +197,19 @@ public void beforeT

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579841013 ## modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java: ## @@ -195,19 +197,19 @@ public void beforeT

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579840663 ## modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java: ## @@ -195,19 +197,19 @@ public void beforeT

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579824596 ## modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/JraftAbstractTest.java: ## @@ -171,7 +173,7 @@ protected JraftServerImpl startServer(int idx, Co

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579823834 ## modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/ItSimpleCounterServerTest.java: ## @@ -97,14 +100,12 @@ void before() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579729570 ## modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItRaftGroupServiceTest.java: ## @@ -258,7 +258,10 @@ void beforeNodeStop() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579727992 ## modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItLearnersTest.java: ## @@ -120,8 +120,8 @@ Peer asPeer() { } void start()

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579728997 ## modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItRaftGroupServiceTest.java: ## @@ -221,8 +221,8 @@ String name() { } void

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579724921 ## modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/PlacementDriverManagerTest.java: ## @@ -209,14 +209,14 @@ private void s

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579724136 ## modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/Node.java: ## @@ -52,13 +55,13 @@ class Node implements AutoCloseable {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579723031 ## modules/network/src/testFixtures/java/org/apache/ignite/internal/network/utils/ClusterServiceTestUtils.java: ## @@ -178,24 +177,12 @@ public CompletableFuture start(

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579703433 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageServiceTest.java: ## @@ -201,8 +201,8 @@ private static class N

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579701159 ## modules/index/src/test/java/org/apache/ignite/internal/index/IndexManagerTest.java: ## @@ -123,8 +123,8 @@ public void setUp() { } @AfterEach -void t

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579697076 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageManagerImplTest.java: ## @@ -139,9 +139,9 @@ void setUp(

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579697076 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageManagerImplTest.java: ## @@ -139,9 +139,9 @@ void setUp(

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579694364 ## modules/index/src/test/java/org/apache/ignite/internal/index/IndexManagerTest.java: ## @@ -226,7 +226,10 @@ private void createAndStartComponents() {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579654791 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/BaseDistributionZoneManagerTest.java: ## @@ -138,11 +134,11 @@ public void tear

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579648035 ## modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/distributionzones/ItIgniteDistributionZoneManagerNodeRestartTest.java: ## @@ -297,7 +3

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579640666 ## modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java: ## @@ -1175,24 +1176,58 @@ public static byte[] byteBufferToByteArray(ByteBuffer buffer

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579636368 ## modules/core/src/main/java/org/apache/ignite/internal/manager/IgniteComponent.java: ## @@ -47,7 +47,7 @@ default void beforeNodeStop() { * Stops the component.

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579617708 ## modules/compute/src/test/java/org/apache/ignite/internal/compute/ComputeComponentImplTest.java: ## @@ -477,12 +478,12 @@ void remoteExecutionReleasesStopLock() throw

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579605232 ## modules/code-deployment/src/test/java/org/apache/ignite/deployment/metastore/DeploymentUnitStoreImplTest.java: ## @@ -102,12 +102,12 @@ public void setup() {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579578818 ## modules/client/src/test/java/org/apache/ignite/client/TestServer.java: ## @@ -315,10 +317,11 @@ public FakePlacementDriver placementDriver() { /** {@inheritDoc}

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579572557 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java: ## @@ -228,10 +230,16 @@ public void stop() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579528313 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java: ## @@ -126,10 +124,8 @@ public void beforeNodeStop() { }

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579524843 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java: ## @@ -91,11 +92,8 @@ public void beforeNodeStop() { }

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579522019 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/BaseCatalogManagerTest.java: ## @@ -104,19 +102,16 @@ void setUp() { () ->

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579468084 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerRecoveryTest.java: ## @@ -81,8 +81,8 @@ public class CatalogManagerRecoveryTest extend

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576570458 ## modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/ItSimpleCounterServerTest.java: ## @@ -97,14 +99,16 @@ void before() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576566401 ## modules/network/src/testFixtures/java/org/apache/ignite/internal/network/utils/ClusterServiceTestUtils.java: ## @@ -178,24 +179,26 @@ public CompletableFuture start(

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576566038 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -239,9 +239,9 @@ public void testNoInteractionsAfterStop() throws

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576565805 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java: ## @@ -191,16 +191,18 @@ public CompletableFuture start() { upda

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576130991 ## modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/ItSimpleCounterServerTest.java: ## @@ -97,14 +99,16 @@ void before() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576119948 ## modules/network/src/testFixtures/java/org/apache/ignite/internal/network/utils/ClusterServiceTestUtils.java: ## @@ -178,24 +179,26 @@ public CompletableFuture start(

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576029691 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogTestUtilsTest.java: ## @@ -80,7 +80,7 @@ void testManagerWorksAsExpected() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576010330 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java: ## @@ -191,16 +191,18 @@ public CompletableFuture start() { upda

[PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-18 Thread via GitHub
Cyrill opened a new pull request, #3629: URL: https://github.com/apache/ignite-3/pull/3629 https://issues.apache.org/jira/browse/IGNITE-22071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s