Thanks for the review, Ansis!
Ansis Atteka writes:
> On Fri, 4 May 2018 at 11:28, Aaron Conole wrote:
>
>> Currently, Open vSwitch on linux embeds the logic of loading and unloading
>> kernel modules into the ovs-ctl and ovs-lib script files. This works, but
>> it me
the misspelling check.
I lost my group of broken patches that I used to test, so until I rig
up a few I hope that my limited run is okay. I have attached an
incremental to fold in that fixes an error in the print call.
Acked-by: Aaron Conole
diff --git a/utilities/checkpatch.py b/utiliti
Yi Yang writes:
Hi Yi,
Thanks for the patch! Just a brief review.
> From: Feng Yang
>
> GPRS Tunneling Protocol (GTP) is a group of IP-based communications
> protocols used to carry general packet radio service (GPRS) within
> GSM, UMTS and LTE networks.
>
> GTP can be decomposed into separat
Aaron Conole writes:
> Sometimes, DPDK initialization can fail, but ovs-vswitchd will abort in
> that case. When that occurs, ovs-vswitchd will be restarted by the
> monitor and immediately abort. This is rather unfriendly to users, who
> would prefer to possibly correct the issue
lucasago...@gmail.com writes:
> From: Lucas Alvares Gomes
>
> The commit [0] partially fixed the problem but in RHEL 7.5 neither
> .{min, max}_mtu or 'ndo_change_mtu' were being set/implemented for
> vport-internal_dev.c.
>
> As pointed out by commit [0], the ndo_change_mtu function pointer has b
Daniel Alvarez Sanchez writes:
> Thanks Lucas, this makes sense. There is something that this patch is
> fixing and I'm not sure why.
> Maybe someone can shed some light:
>
> Using datapath from OVS master, and a setup where we have a physical
> interface connected to
> an OVS bridge (br-ex) conn
Aaron Conole writes:
> lucasago...@gmail.com writes:
>
>> From: Lucas Alvares Gomes
>>
>> The commit [0] partially fixed the problem but in RHEL 7.5 neither
>> .{min, max}_mtu or 'ndo_change_mtu' were being set/implemented for
>> vport-internal_
Ansis Atteka writes:
> On Fri, 4 May 2018 at 11:28, Aaron Conole wrote:
>
>> Defines a type 'openvswitch_load_module_t' used exclusively for loading
>> modules. This means that the 'openvswitch_t' domain won't require
>> access to the modu
Ansis Atteka writes:
> On Fri, 4 May 2018 at 11:28, Aaron Conole wrote:
>
>> The rpm doesn't invoke all of the required selinux helpers to enact
> labeling
>> or relabeling on all versions of Fedora/RHEL. According to:
>> https://fedoraproject.org/wiki/SEL
t;
>
> Look ok overall, minor comments below that can be addressed on commit
> to DPDK_MERGE if you agree with them.
Okay. Whichever you prefer.
>> Signed-off-by: Aaron Conole
>> ---
>> Documentation/faq/configuration.rst | 8 +---
>> Document
Ben Pfaff writes:
> Reported-by: Aaron Conole
> Signed-off-by: Ben Pfaff
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi Sugesh (and robot),
0-day Robot writes:
> Bleep bloop. Greetings Sugesh Chandran, I am a robot and I have tried out
> your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> git-am:
> Failed to merge in the changes.
> P
s.
Thanks!
> Regards
> _Sugesh
>
>
>> -----Original Message-
>> From: Aaron Conole [mailto:acon...@bytheb.org]
>> Sent: Thursday, August 9, 2018 2:15 PM
>> To: 0-day Robot
>> Cc: Chandran, Sugesh ; d...@openvswitch.org
>> Subject: Re: [ovs-dev]
Kevin Traynor writes:
> dpdk-init is now a string. Add description of 'true' and 'try'.
>
> Fixes: 3e52fa5644cd ("dpdk: reflect status and version in the database")
> Cc: acon...@redhat.com
> Signed-off-by: Kevin Traynor
> --
Ben Pfaff writes:
> On Thu, Aug 09, 2018 at 12:40:39PM -0700, Ansis Atteka wrote:
>> On Tue, 7 Aug 2018 at 09:43, Qiuyu Xiao wrote:
>> >
>> > Added rules and files to create debian and rpm ovs-ipsec packages.
>> >
>> > Signed-off-by: Qiuyu Xiao
>> > Signed-off-by: Ansis Atteka
>> > Co-authored
Ben Pfaff writes:
> On Thu, Aug 09, 2018 at 06:31:31PM -0400, Aaron Conole wrote:
>> Ben Pfaff writes:
>>
>> > On Thu, Aug 09, 2018 at 12:40:39PM -0700, Ansis Atteka wrote:
>> >> On Tue, 7 Aug 2018 at 09:43, Qiuyu Xiao wrote:
>> >> >
>>
Ben Pfaff writes:
> This also makes a start at a testsuite for checkpatch.
>
> CC: Aaron Conole
> Signed-off-by: Ben Pfaff
> ---
I think it's close, but I still get this sort of error:
03:07:46 aconole {ipsec_selinux} ~/git/ovs$ ./utilities/checkpatch.py -1
== C
Aaron Conole writes:
> Ben Pfaff writes:
>
>> This also makes a start at a testsuite for checkpatch.
>>
>> CC: Aaron Conole
>> Signed-off-by: Ben Pfaff
>> ---
>
> I think it's close, but I still get this sort of error:
>
> 03:07:46 aconole
Ben Pfaff writes:
> This also makes a start at a testsuite for checkpatch.
>
> CC: Aaron Conole
> Signed-off-by: Ben Pfaff
> ---
Acked-by: Aaron Conole
Thanks for this work, Ben!
There's one more case that we could possibly consider (but it's rare
enough that may
Ben Pfaff writes:
> On Sun, Aug 12, 2018 at 07:43:14AM -0700, Ben Pfaff wrote:
>> On Sat, Aug 11, 2018 at 09:54:01AM -0400, Aaron Conole wrote:
>> > Ben Pfaff writes:
>> >
>> > > This also makes a start at a testsuite for checkpatch.
>> > >
Han Zhou writes:
> On Mon, Aug 13, 2018 at 1:06 AM, 0-day Robot wrote:
>>
>> Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your
> patch.
>> Thanks for your contribution.
>>
>> I encountered some error that I wasn't expecting. See the details below.
>>
>>
>> git-am:
>> fata
Han Zhou writes:
> On Mon, Aug 13, 2018 at 1:04 AM, 0-day Robot wrote:
>>
>> Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your
> patch.
>> Thanks for your contribution.
>>
>> I encountered some error that I wasn't expecting. See the details below.
>>
>>
>> checkpatch:
>>
0-day Robot writes:
> Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> git-am:
> fatal: sha1 information is lacking or useless (ovn/controller/lflo
Aaron Conole writes:
> 0-day Robot writes:
>
>> Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your
>> patch.
>> Thanks for your contribution.
>>
>> I encountered some error that I wasn't expecting. See the details below.
>&
0-day Robot writes:
> Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatch:
> ERROR: Committer 0-day Robot needs to sign off.
> Lines chec
Ian Stokes writes:
> On 8/15/2018 10:51 AM, Ophir Munk wrote:
>> Hi,
>> Please find comments inline.
>>
>>> -Original Message-
>>> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
>>> boun...@openvswitch.org] On Behalf Of Stokes, Ian
>>> Sent: Tuesday, August 14, 2018 7:42 PM
>>> To
Jiecheng Wu writes:
> Function ovs_ct_limit_cmd_get() defined in net/openvswitch/conntrack.c may
> cause a null pointer dereference as it calls nla_nest_start which may return
> NULL. The returned value is used in function nla_nest_end() later where the
> pointer is dereferenced.
> ---
> net/
Terry Wilson writes:
> On Thu, Aug 16, 2018 at 4:57 PM, Ben Pfaff wrote:
>> On Thu, Aug 16, 2018 at 07:55:09PM +, Terry Wilson wrote:
>>> Unix sockets were not being created with the permission 0770,
>>> instead using the current umask value. The manpage for fchmod()
>>> states that that if
Terry Wilson writes:
>> Gather 'round folks, and let me tell you the tale of a series long
>> ago posted:
>>
>> https://mail.openvswitch.org/pipermail/ovs-dev/2016-August/321866.html
>>
>> Something... something ... black magic...
>> I think the fchmod needs to happen after the bind for the permi
testsuite to make it
easier to use.
Aaron Conole (3):
system-dpdk: update test suite for non-phy testing
system-dpdk: Allow running the dpdk tests from a VM
system-dpdk: Use a different character marker for sed commands
Bala Sankaran (3):
system-dpdk: skip all tests if there are no hugepages
Aaron Conole
Signed-off-by: Aaron Conole
---
tests/system-dpdk.at | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at
index 834ba06fb..58dc8aaae 100644
--- a/tests/system-dpdk.at
+++ b/tests/system-dpdk.at
@@ -54,20 +54,20 @@ OVS_DPDK_
The default marker for sed commands according to the manual is /, but this
is inconvenient when working with paths. The solution is either to escape
all instances of / or use sed's \cREGEXc feature.
Signed-off-by: Aaron Conole
---
tests/system-dpdk.at | 14 +++---
1 file chang
From: Bala Sankaran
This adds a new test to the 'check-dpdk' subsystem that will exercise
allocations, PMDs, and the vhost-user code path.
Signed-off-by: Bala Sankaran
Co-authored-by: Aaron Conole
Signed-off-by: Aaron Conole
---
tests/system-dp
From: Bala Sankaran
A failure is quite harsh in this scenario. It's better to
simply skip all the tests and let the user look at the logs
to understand the missing hugepages.
Signed-off-by: Bala Sankaran
Co-authored-by: Aaron Conole
Signed-off-by: Aaron Conole
---
tests/system
Some VM configurations result in CPU flags that cause warnings to be issued by
the DPDK libraries. When these warnings are issued, the tests will fail.
This commit adds the unreliable tsc warning to the list of ignored warnings.
Signed-off-by: Aaron Conole
---
tests/system-dpdk.at | 3 +++
1
This allows a system that doesn't have a dedicated DPDK nic to
execute some DPDK tests. In this fashion, tests that operate on
virtual ports (such as dpdkvhostuserclient) can be executed in
a wider set of environments.
Signed-off-by: Aaron Conole
---
tests/system-dpdk-macros.at
Markos Chandras writes:
> On 28/08/18 12:57, 0-day Robot wrote:
>> Bleep bloop. Greetings Markos Chandras, I am a robot and I have
>> tried out your patch.
>> Thanks for your contribution.
>>
>> I encountered some error that I wasn't expecting. See the details below.
>>
>>
>> checkpatch:
>>
Ian Stokes writes:
> On 8/27/2018 5:16 PM, Ben Pfaff wrote:
>> I can help with some of these.
>>
>> On Mon, Aug 27, 2018 at 04:05:39PM +, Ophir Munk wrote:
>>> Ian, can you please specify the practical steps regarding the new branches?
>>> Specifically, what is the procedure for adding a new
K moves to v18.11.
> Hello Tiago,
>
> I agree, I did not happen to notice a workaround for this.
>
>>
>> On 28/08/2018 18:47, Bala Sankaran wrote:
>> > This adds a new test to the 'check-dpdk' subsystem that will exercise
>> > allocations, PMDs, and
As of June, the 0-day robot has tested over 450 patch series.
Occasionally it spams the list (apologies for that), but for the
majority of the time it has caught issues before they made it to the
tree - so it's accomplishing the initial goal just fine.
I see lots of ways it can improve. Currently
Ben Pfaff writes:
> On Thu, Sep 06, 2018 at 04:56:18AM -0400, Aaron Conole wrote:
>> As of June, the 0-day robot has tested over 450 patch series.
>> Occasionally it spams the list (apologies for that), but for the
>> majority of the time it has caught issues before they m
"Eelco Chaudron" writes:
> On 6 Sep 2018, at 10:56, Aaron Conole wrote:
>
>> As of June, the 0-day robot has tested over 450 patch series.
>> Occasionally it spams the list (apologies for that), but for the
>> majority of the time it has caught issues before the
Ophir Munk writes:
>> -Original Message-
>> From: Aaron Conole [mailto:acon...@bytheb.org]
>> Sent: Thursday, September 06, 2018 11:56 AM
>> To: Ian Stokes ; Kevin Traynor
>> ; Ophir Munk ; Ferruh
>> Yigit ; Luca Boccassi ; Jeremy
>> Pls
Ian Stokes writes:
> On 9/11/2018 4:51 PM, Aaron Conole wrote:
>> "Eelco Chaudron" writes:
>>
>>> On 6 Sep 2018, at 10:56, Aaron Conole wrote:
>>>
>>>> As of June, the 0-day robot has tested over 450 patch series.
>>>&g
"Eelco Chaudron" writes:
> On 11 Sep 2018, at 17:51, Aaron Conole wrote:
>
>> "Eelco Chaudron" writes:
>>
>>> On 6 Sep 2018, at 10:56, Aaron Conole wrote:
>>>
>>>> As of June, the 0-day robot has tested over 450 patch series.
&
0-day Robot writes:
> Bleep bloop. Greetings YueHaibing, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
Whoops - sorry for the noise. I will add patches to netdev to the list
of patc
Mark Michelson writes:
> What's below the dashed line was originally a Google Doc, which I have
> copy-pasted into text form. Some of the formatting has been lost as a
> result, but it should still be readable.
>
> There are quite a few open points of discussion below, including
> 1) Ideal repo s
("configure: Disable -Wnull-pointer-arithmetic Clang
> warning.")
> Signed-off-by: Ben Pfaff
> ---
I didn't get a chance to test this out, but the change looks sane.
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
0-day Robot writes:
> Bleep bloop. Greetings Bhargava Shastry, I am a robot and I have tried out
> your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatch:
> ERROR: Author Bhargava Shastry needs to sign off.
> W
0-day Robot writes:
> Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> build:
> /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE
Ben Pfaff writes:
> On Thu, Sep 27, 2018 at 08:57:23AM -0400, Aaron Conole wrote:
>> I think the issue here on the bot side is that the compiler is not able
>> to deal with this initialization semantic. I'll follow up and get it
>> fixed.
>
> I sent
Darrell Ball writes:
> Below is the recent private commit message I have for the patch:
>
> However, I plan to split out to 3 main patches, with probably a few minor
> cosmetic patches.
>
> 1/ cmap performance and code simplification.
> 2/ Eliminating exporting private datastructures to outside m
bshas...@sect.tu-berlin.de writes:
> From: Bhargava Shastry
>
> oss-fuzz options file must begin with a [libfuzzer] header.
> This was missing in the expr_parse_target.options file which this patch
> fixes.
>
> Signed-off-by: Bhargava Shastry
> ---
Just wanted to let you know that the bot is c
al email anyway (which
will include the From: field). They even just subscribe to the list
and then you offer it to them freely.
It might be best to keep with the well formatted signed-off-by lines for
now, and try to improve your spam filter technology.
> Regards,
> Bhargava
>
> On 09/2
Han Zhou writes:
> From: Han Zhou
>
> Current ovs-ctl forces to set full hostname in external-ids. In
> some situation users may want to set short hostname. For example,
> in OpenStack - OVN integration, Neutron uses the host-id provided
> by Nova, which is usually short hostname, to set "reques
Bhargava Shastry writes:
> Hello,
>
> I can take a look at these on Monday. In any case, they look easily fixable.
>
> P.S. I wonder why the build bot did not complain on the exact same
> code that has now been refactored out of flow_extract_target.c. As far
> as I can remember, that code also us
Ilya Maximets writes:
> Hi Aaron.
>
> What do you think about adding BSD build check to 0-day robot?
> It'll be cool to run, for example, FreeBSD VM for checking to
> cover bugs like this:
> https://patchwork.ozlabs.org/patch/984844/
>
> netdev-bsd and many other BSD related code is not cov
Hi Lorenzo,
Lorenzo Bianconi writes:
> Add the possibility to specify a given mac address prefix for
> dynamically generated mac address. Mac address prefix can be
> specified in nbdb NB_Global table, options:mac_prefix=
> This patch fix a possible issue of L2 address duplication if
> multiple O
Aaron Conole writes:
> Hi Lorenzo,
>
> Lorenzo Bianconi writes:
>
>> Add the possibility to specify a given mac address prefix for
>> dynamically generated mac address. Mac address prefix can be
>> specified in nbdb NB_Global table, options:mac_prefix=
>> T
Reported-by: Edgar Hoch
Signed-off-by: Aaron Conole
---
rhel/openvswitch-fedora.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index ba55fb55c..7a3fcf93a 100644
--- a/rhel/openvswitch-fedora.spec.in
Hi Han,
Han Zhou writes:
> From: Han Zhou
>
> When adding a new chassis, if there is an old chassis with same IP
> existed in Encap table, it is allowed to be added today. However,
> allowing it to be added results in problems:
>
> 1. The new chassis cannot work because none of the other chassi
nickcooper-zhangtonghao writes:
> when sys.stdin is passed to tcpdump via pipe,
> it will cause tcpdump to halt.
>
> Signed-off-by: nickcooper-zhangtonghao
> ---
Can you give an example of the keys you pressed that elicit the
behavior? I haven't observed this on rhel7, fedora 23 or fedora 24.
nickcooper-zhangtonghao writes:
> Signed-off-by: nickcooper-zhangtonghao
> ---
> utilities/ovs-tcpdump.in | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in
> index c189bc8..d03568d 100755
> --- a/utilities/ovs-tcpdum
nickcooper-zhangtonghao writes:
> On Nov 9, 2016, at 1:47 AM, Aaron Conole wrote:
>
> nickcooper-zhangtonghao writes:
>
> Signed-off-by: nickcooper-zhangtonghao
> ---
> utilities/ovs-tcpdump.in | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
&g
nickcooper-zhangtonghao writes:
> When using ovs-tcpdump, we always get the white line.
> Remove newline from readline() and ovs-tcpdump will
> format the output as tcpdump tool.
>
> Signed-off-by: nickcooper-zhangtonghao
> ---
Acke
) call needs to change to
readline() as just an example), and I can't seem to restore that behavior.
I think the original intent of this doesn't make sense anymore. Thanks
for your report, and this patch.
Acked-by: Aaron Conole
> utilities/ovs-tcpdump.in | 3 ---
> 1 file changed
", line 439, in main
> pipes.terminate()
> File "/usr/lib64/python2.7/subprocess.py", line 1551, in terminate
> self.send_signal(signal.SIGTERM)
> File "/usr/lib64/python2.7/subprocess.py", line 1546, in send_signal
> os.kill(self.pid, sig)
&
nickcooper-zhangtonghao writes:
> Signed-off-by: nickcooper-zhangtonghao
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
nickcooper-zhangtonghao writes:
> when sys.stdin is passed to tcpdump via pipe,
> it will cause tcpdump to halt.
>
> Signed-off-by: nickcooper-zhangtonghao
> ---
On further investigation, there are other issues around supporting
this properly, so:
Acked-b
nickcooper-zhangtonghao writes:
> Signed-off-by: nickcooper-zhangtonghao
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
pipes.terminate()
> +
Thanks for the work on this - do you think it would be okay to also add
something like:
sys.exit(pipes.returncode)
Or even:
if pipes.returncode < 0:
os.kill(os.getpid(), signal.SIGABRT)
else:
sys.exit(pipes.returncode)
?
Either way, the change you hav
nickcooper-zhangtonghao writes:
> When using ovs-tcpdump, we always get the white line.
> Remove newline from readline() and ovs-tcpdump will
> format the output as tcpdump tool.
>
> Signed-off-by: nickcooper-zhangtonghao
> ---
I acked this with V1, so:
Acke
writes:
> Hi All,
>
> Below are the configuration and patch details which provides the support
> for clearing statistics at Interface level.
> Description & Configuration:
> OVS by default has the support for the command ovs-vsctl clear interface
> statistics
> But in OVS the command functional
.
You also need to address the other point (how will non-dpdk enabled
openvswitch cope with this?)
I don't know the statistics system enough to comment on the validity of
the change you propose. Why is not clearing the database data good
enough?
> -----Original Message-
> From: Aaron
1149.200073 = 22.10 * 52.00
Catbert 5000.00 = 250.00 * 20.00
This can be tweaked by playing with the strings on lines 1193, and 1194 of
tests/test-util.c to change the output.
Aaron Conole (1):
Printing Table
'rows'. Each column has a label (header). Data can then be extracted by
specifying the exact column requested.
Currently, the format strings supported are very basic. Data can be extracted
by specifying a header name or column number within {} pairs. ex: {0} or
{column0}.
Signed-off
Ben Pfaff writes:
> On Fri, Nov 18, 2016 at 05:22:27PM -0500, Aaron Conole wrote:
>> During some recent face-to-face talks regarding debugging ovs, an issue
>> was raised regarding the output. The gist of the conversation was that as
>> it stands, ovs output is less
Aaron Conole writes:
> This series cleans up and clarifies certain issues in the checkpatch
> infrastructure. Additionally, a fix for the some of the matches is included.
>
> The two features added by this series are:
> 1. The ability to parse a non-patch file (useful for apply
eferred_argv_release () at lib/dpdk.c:261
> #5 __run_exit_handlers () from /lib64/libc.so.6
> #6 exit () from /lib64/libc.so.6
> #7 __libc_start_main () from /lib64/libc.so.6
> #8 _start ()
>
> Fix that by not calling free for the memory passed to DPDK.
>
---
Looks good; I'll need to learn how to use an ovn soon :).
Reviewed-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ben Pfaff writes:
> These actions looked up the MAC binding but failed to update eth.dst with
> the result.
>
> Signed-off-by: Ben Pfaff
> ---
This looks safe to me.
Reviewed-by: Aaron Conole
___
dev mailing list
d...@openvs
Ben Pfaff writes:
> On Fri, Oct 21, 2016 at 02:49:03PM -0400, Aaron Conole wrote:
>> This makes finding the warning and error marks much easier.
>>
>> Signed-off-by: Aaron Conole
>
> Thanks, I applied this to master, it's certainly going to be a help
> someti
Hi Ilya,
Ilya Maximets writes:
> On 28.11.2016 21:55, Aaron Conole wrote:
>> Ilya Maximets writes:
>>
>>> According to DPDK API (lib/librte_eal/common/include/rte_eal.h):
>>>
>>> "After the call to rte_eal_init(), all arguments argv[x]
>&
Daniele Di Proietto writes:
> On 29/11/2016 07:57, "Aaron Conole" wrote:
>
>>Hi Ilya,
>>
>>Ilya Maximets writes:
>>
>>> On 28.11.2016 21:55, Aaron Conole wrote:
>>>> Ilya Maximets writes:
>>>>
>>>>> A
ns(-)
I didn't build this, but it looks good to me; so a big 'ol
Reviewed-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ben Pfaff writes:
> On Tue, Dec 06, 2016 at 03:23:45PM -0500, Aaron Conole wrote:
>> Ben Pfaff writes:
>>
>> > The usage should not repeat the command name, but most of the dpctl
>> > commands' usage did repeat it. This fixes the problem.
>> >
&g
Adds a new --format="xx={0},..." to the table library, which allows
users to make table output formats to match their own needs.
Signed-off-by: Aaron Conole
---
v1 url:
https://mail.openvswitch.org/pipermail/ovs-dev/2016-November/325235.html
TODO: Still needs unit tests to check
Ben Pfaff writes:
> On Wed, Dec 07, 2016 at 10:55:54AM -0500, Aaron Conole wrote:
>> Adds a new --format="xx={0},..." to the table library, which allows
>> users to make table output formats to match their own needs.
>>
>> Signed-off-by: Aaron C
Ben Pfaff writes:
> On Wed, Dec 07, 2016 at 01:08:43PM -0500, Aaron Conole wrote:
>> Ben Pfaff writes:
>>
>> > On Wed, Dec 07, 2016 at 10:55:54AM -0500, Aaron Conole wrote:
>> >> Adds a new --format="xx={0},..." to the table library, which allo
found here:
http://dpdk.org/ml/archives/dev/2016-December/051812.html), which aims
to clarify the usage. If that's accepted, then I'd consider patch 2/2 to be
non-RFC.
Aaron Conole (2):
lib/dpdk: fix double free on exit
lib/dpdk: No more deferred release
lib/dpdk.c | 21 +
from cmdline to db")
Signed-off-by: Aaron Conole
---
lib/dpdk.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/dpdk.c b/lib/dpdk.c
index 49a589a..28f3485 100644
--- a/lib/dpdk.c
+++ b/lib/dpdk.c
@@ -250,7 +250,7 @@ get_dpdk_args(const struct smap *ovs_other_co
DPDK documentation is recently updated to reflect that DPDK does not
hold any references to, nor take ownership of, the argv/argc elements.
With that understanding, let's just release the memory asap.
Signed-off-by: Aaron Conole
---
NOTE: if the patch at
http://dpdk.org/ml/archive
Ben Pfaff writes:
> On Wed, Dec 07, 2016 at 02:15:12PM -0500, Aaron Conole wrote:
>> Ben Pfaff writes:
>> > On Wed, Dec 07, 2016 at 01:08:43PM -0500, Aaron Conole wrote:
>> >> Ben Pfaff writes:
>> >> To accomplish this, I'm going down the followi
Although I'm not Flavio, I do have some quick thoughts on this.
Russell Bryant writes:
> My main concern with this was that it implements a new python-ovs package
> and leaves the existing one alone. I'd like to figure out how to change
> the existing package so that we always use this approach
Ben Pfaff writes:
> On Mon, Dec 12, 2016 at 08:11:16PM -0500, Aaron Conole wrote:
>> Ben Pfaff writes:
>>
>> > On Wed, Dec 07, 2016 at 02:15:12PM -0500, Aaron Conole wrote:
>> >> Ben Pfaff writes:
>> >> > On Wed, Dec 07, 2016 at 01:08:43PM -0
Hi Bhanu,
Bhanuprakash Bodireddy writes:
> In exact match cache processing on an EMC hit, packets are queued in to
> batches matching the flow. Thereafter, packets are processed in batches
> for faster packet processing. This particularly is inefficient if there
> are fewer packets in a batch as
Ben Pfaff writes:
> On Tue, Dec 13, 2016 at 04:43:32PM -0500, Aaron Conole wrote:
>> Ben Pfaff writes:
>>
>> > On Mon, Dec 12, 2016 at 08:11:16PM -0500, Aaron Conole wrote:
>> >> Ben Pfaff writes:
>> >>
>> >> > On Wed, Dec 07, 2
Aaron Conole writes:
> DPDK documentation is recently updated to reflect that DPDK does not
> hold any references to, nor take ownership of, the argv/argc elements.
> With that understanding, let's just release the memory asap.
>
> Signed-off-by: Aaron Conole
> ---
Ben Pfaff writes:
> On Tue, Dec 13, 2016 at 01:45:05PM -0500, Aaron Conole wrote:
>> Also, FYI (and this is sortof a side-note) the libtool ABI versioning
>> information hasn't changed since 2014; bumping / managing that may
>> become an additional release burden if w
Bhanuprakash Bodireddy writes:
> Increase the DPDK pmd thread scheduling priority by lowering the nice
> value. This will advise the kernel scheduler to prioritize pmd thread
> over other processes.
>
> Signed-off-by: Bhanuprakash Bodireddy
> ---
Sorry for jumping into this so late. Is there a
501 - 600 of 1897 matches
Mail list logo
