Re: [HACKERS] Add more regression tests for dbcommands

2013-06-25 Thread Robins Tharakan
Hi Andres, Attached is a patch which does not CREATE DATABASE, but now the regression tests do not test the following: - ALTER DATABASE RENAME TO is not allowed on a database in use. Had to remove two tests that were using this. - ALTER DATABASE SET TABLESPACE is also not allowed on a database i

[HACKERS] Bloom Filter lookup for hash joins

2013-06-25 Thread Atri Sharma
Hi All, I have been researching bloom filters and discussed it on IRC with RhodiumToad and David Fetter, and they pointed me to the various places that could potentially have bloom filters, apart from the places that already have them currently. I have been reading the current implementation of h

Re: [HACKERS] Reduce maximum error in tuples estimation after vacuum.

2013-06-25 Thread Amit Kapila
On Tuesday, June 25, 2013 2:06 PM Kyotaro HORIGUCHI wrote: > Hello, > > > I have tried to reproduce the problem in different m/c's, but > couldn't > > reproduce it. > > I have ran tests with default configuration. > > I think you had reproduced it. > > > Output on Windows: > > --

Re: [HACKERS] fixing pg_ctl with relative paths

2013-06-25 Thread Hari Babu
On June 26, 2013 5:02 AM Josh Kupershmidt wrote: >Thanks for the feedback. Attached is a rebased version of the patch with the two small issues noted fixed. Patch is good, I marked the patch as ready for committer. Regards, Hari babu -- Sent via pgsql-hackers mailing list (pgsql-hackers@postg

Re: [HACKERS] pgbench --startup option

2013-06-25 Thread Jeff Janes
On Tuesday, June 25, 2013, Robert Haas wrote: > On Thu, Jun 20, 2013 at 1:46 PM, Jeff Janes > > > wrote: > > I've fixed a conflict, and I've removed extraneous semicolons from the C. > > > > I've left in the fixing of some existing bad indenting in the existing > code, > > which is not strictly r

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-25 Thread Amit Kapila
On Wednesday, June 26, 2013 5:03 AM Josh Berkus wrote: > > >> I'll also vote for postgresql.auto.conf. > > > > Thanks to all of you for suggesting meaningful names. I will change > the name of file to postgresql.auto.conf. > > Kindly let me know if there is any objection to it. > > There is n

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-25 Thread Amit Kapila
On Tuesday, June 25, 2013 10:23 AM Amit Langote wrote: > Hi, > > > > >> So our proposal on this problem is that we must ensure that master > should > > not make any file system level changes without confirming that the > >> corresponding WAL record is replicated to the standby. > > > > How will

[HACKERS] Computer VARSIZE_ANY(PTR) during debugging

2013-06-25 Thread Amit Langote
Hello, Is it possible to compute VARSIZE_ANY(PTR) during debugging? - #define VARSIZE_ANY(PTR) \ (VARATT_IS_1B_E(PTR) ? VARSIZE_1B_E(PTR) : \ (VARATT_IS_1B(PTR) ? VARSIZE_1B(PTR) : \ VARSIZE_4B(PTR))) #define VARA

Re: [HACKERS] updated emacs configuration

2013-06-25 Thread Peter Eisentraut
On Sun, 2013-06-23 at 16:37 -0400, Tom Lane wrote: > I'm un-thrilled with this as well, though for a slightly different > reason: we have a policy that the PG sources should be tool agnostic, > and in fact removed file-local emacs settings awhile back because of > that. We don't want to keep the t

Re: [HACKERS] Review: Patch to compute Max LSN of Data Pages

2013-06-25 Thread Amit Kapila
On Tuesday, June 25, 2013 11:12 PM Andres Freund wrote: > Hi, > > On 2013-06-16 17:19:49 -0700, Josh Berkus wrote: > > Amit posted a new version of this patch on January 23rd. But last > > comment on it by Tom is "not sure everyone wants this". > > > > https://commitfest.postgresql.org/action/pat

Re: [HACKERS] updated emacs configuration

2013-06-25 Thread Peter Eisentraut
On Sun, 2013-06-23 at 16:03 -0400, Noah Misch wrote: > > ((c-mode . ((c-basic-offset . 4) > > (fill-column . 79) > > I don't know whether you'd consider it to fall within the scope of this > update, but 78 is the fill-column setting that matches pgindent. Well, well, well. I did some

Re: [HACKERS] updated emacs configuration

2013-06-25 Thread Peter Eisentraut
On Sun, 2013-06-23 at 16:11 -0400, Andrew Dunstan wrote: > > The idea is a very good one in principle, but my short experiment with > > the provided .dir-locals.el didn't give me BSD style brace > > indentation. It works if we can do those "unsafe" things, but then we > > surely don't want to ha

Re: [HACKERS] updated emacs configuration

2013-06-25 Thread Peter Eisentraut
On Fri, 2013-06-21 at 11:20 +0200, Dimitri Fontaine wrote: > I've tested that on a new git clone and with the `emacs -q` command so > as not to load any of my local setup. While the indentation seemed ok, > the placement of the comments seems way off: > > Compare what you see using those commands:

Re: [HACKERS] [RFC] Minmax indexes

2013-06-25 Thread Alvaro Herrera
I just noticed that this patch was closed with "returned with feedback" in the commitfest app. This is good, IMV -- it's saying that the opinion of the various people commenting on the thread is positive, and therefore no more discussion is currently needed. I will post an actual patch to CF2, at

Re: [HACKERS] Patch to add regression tests for SCHEMA

2013-06-25 Thread Fabien COELHO
Please find attached an updated patch with the said changes. I'll try to update the other patches (if they pertain to this feedback) and update on their respective threads (as well as on Commitfest). Ok, this new version addresses my questions. The patch works for me (nothing to compile, the

Re: [HACKERS] [Review] Add SPI_gettypmod() to return a field's typemod from a TupleDesc

2013-06-25 Thread Mark Wong
rec->refname, recfield->fieldname))); > *typeid = SPI_gettypeid(rec->tupdesc, fno); > ! *typetypmod = SPI_gettypeid(rec->tupdesc, fno); > *value = SPI_getbinval(rec->tup, rec->tupdesc, fno, > isnull); >

Re: [HACKERS] Reduce maximum error in tuples estimation after vacuum.

2013-06-25 Thread Kyotaro HORIGUCHI
I've recovered from messing up. > Please let me have a bit of time to diagnose this. I was completely messed up and walking on the wrong way. I looked into the vacuum for UPDATEs, not DELETE's so it's quite resonable to have such results. The renewed test script attached shows the verbose outp

Re: [HACKERS] Review: UNNEST (and other functions) WITH ORDINALITY

2013-06-25 Thread Tom Lane
Josh Berkus writes: > ... and if arr1, 2 and 3 are exactly the same length, this creates a > coordinated dataset. I can even use the unnest_ordinality() extension > function to get the ordinality of this combined dataset: > SELECT id, > (unnest_ordinality(arr1)).element_number as array_in

Re: [HACKERS] Possible bug in CASE evaluation

2013-06-25 Thread Tom Lane
Andres Freund writes: > But I guess given the objections on performance the combined approach is > the way to go? I think the documentation approach is the way to go. It was pointed out in the pgsql-general thread about this that a naive user might expect that, say, syntax or datatype violations

Re: [HACKERS] Reduce maximum error in tuples estimation after vacuum.

2013-06-25 Thread Kyotaro HORIGUCHI
Sorry for lots of mistakes I've made, I noticed that I was dancing on the 9.3dev at sometime, so I reran on 9.4devel up to date, having the same result from the view of inaccuracy of pg_class.reltuples after vacuuming. Although, what differs from my old testset, vacuum reported that it sanned the

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread David Johnston
Brendan Jurd wrote > On 26 June 2013 03:17, Josh Berkus < > josh@ > > wrote: >> How should reviewers get credited in the release notes? >> >> a) not at all >> b) in a single block titled "Reviewers for this version" at the bottom. >> c) on the patch they reviewed, for each patch I think some con

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Claudio Freire
On Tue, Jun 25, 2013 at 6:52 PM, Kevin Grittner wrote: > I agree though, that having an index implementation that can do the > first level split faster than any partitioning mechanism can do is > better, and that the main benefits of partitioning are in > administration, *not* searching. Indeed,

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Brendan Jurd
On 26 June 2013 03:17, Josh Berkus wrote: > How should reviewers get credited in the release notes? > > a) not at all > b) in a single block titled "Reviewers for this version" at the bottom. > c) on the patch they reviewed, for each patch A weak preference for (c), with (b) running a close secon

Re: [HACKERS] Review: UNNEST (and other functions) WITH ORDINALITY

2013-06-25 Thread Josh Berkus
Folks, (the below was already discussed on IRC) Leaving names aside on this patch, I'm wondering about a piece of functionality I have with the current unnest() and with the unnest_ordinality()[1] extension: namely, the ability to unnest several arrays "in parallel" by using unnest() in the targe

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

2013-06-25 Thread Josh Berkus
> I know it's heresy in these parts, but maybe we should consider > adopting a non-spec syntax for this feature? In particular, it's > really un-obvious why the FILTER clause shouldn't be inside rather > than outside the aggregate's parens, like ORDER BY. Well, what other DBMSes support this fea

Re: [HACKERS] Possible bug in CASE evaluation

2013-06-25 Thread Andres Freund
Hi Noah, On 2013-06-25 19:05:15 -0400, Noah Misch wrote: > On Tue, Jun 25, 2013 at 03:01:52PM +0200, Andres Freund wrote: > > On 2013-06-24 21:35:53 -0400, Noah Misch wrote: > > > Simple enough, yes. The other point still stands. > > > > You mean performance? Primarily I still think we should fi

Re: [HACKERS] [PATCH] Fix conversion for Decimal arguments in plpython functions

2013-06-25 Thread Steve Singer
On 06/25/2013 06:42 AM, Szymon Guz wrote: Hi, I've attached a new patch. I've fixed all the problems you've found, except for the efficiency problem, which has been described in previous email. thanks, Szymon This version of the patch addresses the issues I mentioned. Thanks for looki

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-25 Thread Josh Berkus
>> I'll also vote for postgresql.auto.conf. > > Thanks to all of you for suggesting meaningful names. I will change the > name of file to postgresql.auto.conf. > Kindly let me know if there is any objection to it. There is no name you could come up with for which there would not be an objec

Re: [HACKERS] fixing pg_ctl with relative paths

2013-06-25 Thread Josh Kupershmidt
On Tue, Jun 25, 2013 at 2:28 AM, Hari Babu wrote: > Please find the review of the patch. Thank you for reviewing! > Code Review: > > +if (orig_post_opts) { > +post_opts = strip_datadirs(orig_post_opts); > +} > > No need of "{}" as the only one statement block is present in t

Re: [HACKERS] Possible bug in CASE evaluation

2013-06-25 Thread Noah Misch
On Tue, Jun 25, 2013 at 03:01:52PM +0200, Andres Freund wrote: > On 2013-06-24 21:35:53 -0400, Noah Misch wrote: > > Simple enough, yes. The other point still stands. > > You mean performance? Primarily I still think we should first worry > about correctness first and then about performance. And

Re: [HACKERS] LATERAL quals revisited

2013-06-25 Thread Tom Lane
Antonin Houska writes: > On 06/25/2013 10:00 PM, Tom Lane wrote: >> After some contemplation, I think that the most practical way to fix >> this is for deconstruct_recurse and distribute_qual_to_rels to >> effectively move such a qual to the place where it logically belongs; >> that is, rather tha

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Kevin Grittner
Claudio Freire wrote: > Did you try "select * from foo where (a % 16) = (1::int % 16)"? I did.  Using Robert's hashed partitioning table definitions: test=# explain select * from foo where a = 1 and (a % 16) = (1 % 16); QUERY PLAN     ---

Re: [HACKERS] LATERAL quals revisited

2013-06-25 Thread Antonin Houska
(Please excuse me if my proposal sounds silly, i'm still not too advanced in this area...) On 06/25/2013 10:00 PM, Tom Lane wrote: After some contemplation, I think that the most practical way to fix this is for deconstruct_recurse and distribute_qual_to_rels to effectively move such a qual to

[HACKERS] Review: query result history in psql

2013-06-25 Thread ian link
Hi Maciej, I've been reviewing your patch for the ongoing commitfest. First let me say that I think it's a great idea and provides some very useful functionality. However, there are a few minor problems. There were a few english/grammatical mistakes that I went ahead and fixed. Additionally, I th

Re: [HACKERS] XLogInsert scaling, revisited

2013-06-25 Thread Jeff Janes
On Sat, Jun 22, 2013 at 4:32 AM, Heikki Linnakangas wrote: > On 21.06.2013 21:55, Jeff Janes wrote: > >> >> Hmm, it looks like the xlog-switch is trying to wait for itself to > finish. The concurrent TRUNCATE is just being blocked behind the > xlog-switch, which is stuck on itself. > > I wasn't a

Re: [HACKERS] Optimizing pglz compressor

2013-06-25 Thread Heikki Linnakangas
On 19.06.2013 14:01, Amit Kapila wrote: Observations -- 1. For small data perforamce is always good with patch. 2. For random small/large data performace is good. 3. For medium and large text and same byte data(3K,5K text, 10K,100K,500K same byte), performance is degraded. Wow, that

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Claudio Freire
On Tue, Jun 25, 2013 at 4:32 PM, Tom Lane wrote: > However, I find it hard to think that hash partitioning as such is very > high on the to-do list. As was pointed out upthread, the main practical > advantage of partitioning is *not* performance of routine queries, but > improved bulk-data manage

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

2013-06-25 Thread Heikki Linnakangas
On 25.06.2013 23:03, Robert Haas wrote: On Tue, Jun 25, 2013 at 1:15 PM, Heikki Linnakangas wrote: I'm not sure it's a good idea to sleep proportionally to the time it took to complete the previous fsync. If you have a 1GB cache in the RAID controller, fsyncing the a 1GB segment will fill it u

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

2013-06-25 Thread Robert Haas
On Tue, Jun 25, 2013 at 1:15 PM, Heikki Linnakangas wrote: > I'm not sure it's a good idea to sleep proportionally to the time it took to > complete the previous fsync. If you have a 1GB cache in the RAID controller, > fsyncing the a 1GB segment will fill it up. But since it fits in cache, it > wi

[HACKERS] LATERAL quals revisited

2013-06-25 Thread Tom Lane
I've been studying the bug reported at http://www.postgresql.org/message-id/20130617235236.GA1636@jeremyevans.local that the planner can do the wrong thing with queries like SELECT * FROM i LEFT JOIN LATERAL (SELECT * FROM j WHERE i.n = j.n) j ON true; I think the fundamental problem is that, b

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Tom Lane
Christopher Browne writes: > There would indeed be merit in improving the partitioning apparatus, > and actually, I think it's been a couple of years since there has been > serious discussion of this. We could certainly use a partitioning mechanism that's easier to use than what we have now, whic

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread David Fetter
On Tue, Jun 25, 2013 at 10:17:07AM -0700, Josh Berkus wrote: > Hackers, > > I'd like to take a straw poll here on how we should acknowledge > reviewers. Please answer the below with your thoughts, either on-list > or via private email. > > How should reviewers get credited in the release notes?

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Josh Berkus
On 06/25/2013 12:23 PM, Tom Lane wrote: > Josh Berkus writes: >> However, can you tell me what exactly you are concerned about? lz4 is >> under the BSD license, and released by Google. Why are we worried, exactly? > > Patents. The license on the code doesn't matter --- worst case, if > someone

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Dean Rasheed
On 25 June 2013 18:17, Josh Berkus wrote: > Hackers, > > I'd like to take a straw poll here on how we should acknowledge > reviewers. Please answer the below with your thoughts, either on-list > or via private email. > > How should reviewers get credited in the release notes? > > a) not at all >

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Tom Lane
Josh Berkus writes: > However, can you tell me what exactly you are concerned about? lz4 is > under the BSD license, and released by Google. Why are we worried, exactly? Patents. The license on the code doesn't matter --- worst case, if someone objected, we could rewrite the algorithm ourselves

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Claudio Freire
On Tue, Jun 25, 2013 at 4:15 PM, Andres Freund wrote: >> However, can you tell me what exactly you are concerned about? lz4 is >> under the BSD license, and released by Google. > > Snappy is released/copyrighted by google. lz4 by Yann Collet. > > Both are under BSD licenses (3 and 2 clause variant

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Andres Freund
On 2013-06-25 12:08:22 -0700, Josh Berkus wrote: > On 06/25/2013 11:42 AM, Andres Freund wrote: > > True. So, how do we proceed on that? > > > > The ASF decided it was safe to use lz4 in cassandra. Does anybody have > > contacts over there? > > > > Btw, I have the feeling we hold this topic to a

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

2013-06-25 Thread Fabien COELHO
I think I'd like to quibble with some of the names a bit, though. That is a good idea, because I'm not a native English speaker and I was not so sure for many options. The patch adds --fill-factor, but I think we should spell it without the hyphen: --fillfactor. Fine with me. I think -

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Josh Berkus
On 06/25/2013 11:42 AM, Andres Freund wrote: > True. So, how do we proceed on that? > > The ASF decided it was safe to use lz4 in cassandra. Does anybody have > contacts over there? > > Btw, I have the feeling we hold this topic to a higher standard wrt > patent issues than other work in postgres

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Christopher Browne
On Tue, Jun 25, 2013 at 12:08 PM, Yuri Levinsky wrote: > Guys, > I am sorry for taking your time. The reason for my question is: > As former Oracle DBA and now simple beginner PostgreSQL DBA I would like > to say: the current partitioning mechanism might be improved. Sorry, it > seems to me far b

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Joshua D. Drake
On 06/25/2013 11:26 AM, Andres Freund wrote: On 2013-06-25 11:04:38 -0700, Joshua D. Drake wrote: a) not at all b) in a single block titled "Reviewers for this version" at the bottom. c) on the patch they reviewed, for each patch C. The idea that reviewers are somehow less than authors is ra

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Josh Berkus
On 06/25/2013 11:26 AM, Andres Freund wrote: > On 2013-06-25 11:04:38 -0700, Joshua D. Drake wrote: >>> a) not at all >>> b) in a single block titled "Reviewers for this version" at the bottom. >>> c) on the patch they reviewed, for each patch >> >> C. The idea that reviewers are somehow less than

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Claudio Freire
On Tue, Jun 25, 2013 at 2:17 PM, Josh Berkus wrote: > How should reviewers get credited in the release notes? > c) on the patch they reviewed, for each patch This not only makes sense, it also lets people reading release notes know there's been a review, and how thorough it was. I know, all chang

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Andres Freund
On 2013-06-25 12:22:31 -0400, Robert Haas wrote: > On Thu, Jun 20, 2013 at 8:09 PM, Andres Freund wrote: > > On 2013-06-15 12:20:28 +0200, Andres Freund wrote: > >> On 2013-06-14 21:56:52 -0400, Robert Haas wrote: > >> > I don't think we need it. I think what we need is to decide is which > >> >

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Andrew Dunstan
On 06/25/2013 01:17 PM, Josh Berkus wrote: Hackers, I'd like to take a straw poll here on how we should acknowledge reviewers. Please answer the below with your thoughts, either on-list or via private email. How should reviewers get credited in the release notes? a) not at all b) in a single

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Andres Freund
On 2013-06-25 11:04:38 -0700, Joshua D. Drake wrote: > >a) not at all > >b) in a single block titled "Reviewers for this version" at the bottom. > >c) on the patch they reviewed, for each patch > > C. The idea that reviewers are somehow less than authors is rather > disheartening. It's not about

Re: [HACKERS] pgbench --startup option

2013-06-25 Thread Fabien COELHO
OK, I like this idea a lot, but I have a question. Right now, to use this, you have to supply the startup SQL on the command line. And that could definitely be useful. But ISTM that you might also want to take the startup SQL from a file, and indeed you might well want to include metacommands

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-25 Thread Alexander Korotkov
On Tue, Jun 25, 2013 at 7:31 PM, Heikki Linnakangas wrote: > On 25.06.2013 01:24, Alexander Korotkov wrote: > >> On Wed, Jun 19, 2013 at 1:21 AM, Alexander Korotkov >> **wrote: >> >> On Mon, Jun 17, 2013 at 10:27 PM, Heikki Linnakangas< >>> hlinnakan...@vmware.com> wrote: >>> >>> That has some

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Claudio Freire
On Tue, Jun 25, 2013 at 12:55 PM, Robert Haas wrote: > Let me back up a minute. You told the OP that he could make hash > partitioning by writing his own constraint and trigger functions. I > think that won't work. But I'm happy to be proven wrong. Do you have > an example showing how to do it

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Alvaro Herrera
Yuri Levinsky escribió: > As former Oracle DBA and now simple beginner PostgreSQL DBA I would like > to say: the current partitioning mechanism might be improved. Sorry, it > seems to me far behind yesterday requirements. I don't think you'll find anybody that disagrees with this. -- Álvaro Her

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Joshua D. Drake
On 06/25/2013 10:17 AM, Josh Berkus wrote: Hackers, I'd like to take a straw poll here on how we should acknowledge reviewers. Please answer the below with your thoughts, either on-list or via private email. How should reviewers get credited in the release notes? a) not at all b) in a singl

Re: [HACKERS] INTERVAL overflow detection is terribly broken

2013-06-25 Thread Rok Kralj
So, any insights on these problems? They might not be critical, but might be silently corrupting someone's data. 2013/6/23 Rok Kralj > Hi, after studying ITERVAL and having a long chat with RhoidumToad and > StuckMojo on #postgresql, I am presenting you 3 bugs regarding INTERVAL. > > As far as

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Josh Berkus
On 06/25/2013 10:46 AM, Andres Freund wrote: > Not sure. Seems like it might be a way to spend a lot of effort without > achieving all that much. But I can also imagine that it feels nice and > encourages a casual reviewer/contributor. > > So it's either b) or c). Although I'd perhaps exclude regu

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Andres Freund
On 2013-06-25 10:17:07 -0700, Josh Berkus wrote: > How should reviewers get credited in the release notes? > > a) not at all > b) in a single block titled "Reviewers for this version" at the bottom. > c) on the patch they reviewed, for each patch b). If the review was substantial enough the revi

Re: [HACKERS] Review: Patch to compute Max LSN of Data Pages

2013-06-25 Thread Andres Freund
Hi, On 2013-06-16 17:19:49 -0700, Josh Berkus wrote: > Amit posted a new version of this patch on January 23rd. But last > comment on it by Tom is "not sure everyone wants this". > > https://commitfest.postgresql.org/action/patch_view?id=905 > ... so, what's the status of this patch? That comm

Re: [HACKERS] request a new feature in fuzzystrmatch

2013-06-25 Thread Liming Hu
On Mon, Jun 24, 2013 at 6:02 PM, Joe Conway wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/14/2013 12:08 PM, Liming Hu wrote: I have implemented the code according to Joe's suggestion, and put the code at: https://github.com/liminghu/fuzzystrmatch/tre

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Erik Rijkers
On Tue, June 25, 2013 19:17, Josh Berkus wrote: > How should reviewers get credited in the release notes? b) in a single block titled "Reviewers for this version" at the bottom. > Should there be a criteria for a "creditable" review? b) yes, they have to do more than "it compiles" > Should re

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Heikki Linnakangas
On 25.06.2013 20:17, Josh Berkus wrote: Hackers, I'd like to take a straw poll here on how we should acknowledge reviewers. Please answer the below with your thoughts, either on-list or via private email. How should reviewers get credited in the release notes? a) not at all b) in a single blo

Re: [HACKERS] Clean switchover

2013-06-25 Thread Fujii Masao
On Mon, Jun 24, 2013 at 3:41 PM, Andres Freund wrote: > On 2013-06-14 04:56:15 +0900, Fujii Masao wrote: >> On Wed, Jun 12, 2013 at 9:48 PM, Stephen Frost wrote: >> > * Magnus Hagander (mag...@hagander.net) wrote: >> >> On Wed, Jun 12, 2013 at 1:48 PM, Andres Freund >> >> wrote: >> >> > On 2013

[HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Josh Berkus
Hackers, I'd like to take a straw poll here on how we should acknowledge reviewers. Please answer the below with your thoughts, either on-list or via private email. How should reviewers get credited in the release notes? a) not at all b) in a single block titled "Reviewers for this version" at

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

2013-06-25 Thread Heikki Linnakangas
On 21.06.2013 11:29, KONDO Mitsumasa wrote: I took results of my separate patches and original PG. * Result of DBT-2 | TPS 90%tile Average Maximum -- original_0.7 | 3474.62 18.348328 5.739 36.977713 original_1.0 | 3469.03 18.637865 5.842 41.754

Re: [HACKERS] pg_filedump 9.3: checksums (and a few other fixes)

2013-06-25 Thread Jeff Davis
On Mon, 2013-06-24 at 20:34 -0400, Josh Kupershmidt wrote: > This patch is in the current CommitFest, does it still need to be > reviewed? If so, I notice that the version in pgfoundry's CVS is > rather different than the version the patch seems to have been built > against (presumably the pg_filed

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

2013-06-25 Thread Robert Haas
On Tue, Jun 25, 2013 at 12:17 PM, Tom Lane wrote: > Robert Haas writes: >> I would like to solicit opinions on whether this is a good idea. I >> understand that the patch author thinks it's a good idea, and I don't >> have a strong position either way. But I want to hear what other >> people th

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Robert Haas
On Thu, Jun 20, 2013 at 8:09 PM, Andres Freund wrote: > On 2013-06-15 12:20:28 +0200, Andres Freund wrote: >> On 2013-06-14 21:56:52 -0400, Robert Haas wrote: >> > I don't think we need it. I think what we need is to decide is which >> > algorithm is legally OK to use. And then put it in. >> > >

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Bruce Momjian
On Tue, Jun 25, 2013 at 12:08:34PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I looked at predtest.c but I can't see how we accept >= and <= ranges, > > but not CHECK (a % 16 == 3). It is the '%' operator? I am not sure why > > the hashme() function is there. Wouldn't it work if hashme(

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

2013-06-25 Thread Tom Lane
Robert Haas writes: > I would like to solicit opinions on whether this is a good idea. I > understand that the patch author thinks it's a good idea, and I don't > have a strong position either way. But I want to hear what other > people think. If it makes pgbench more consistent with psql's com

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

2013-06-25 Thread Alvaro Herrera
Robert Haas escribió: > On Thu, Jun 20, 2013 at 9:17 AM, Fabrízio de Royes Mello > wrote: > > On Thu, Jun 20, 2013 at 9:59 AM, Fabien COELHO wrote: > >>> Please fix that and re-send the patch. > >> Find attached diff wrt current master. > > Thanks. > > I would like to solicit opinions on whether

Re: [HACKERS] isolationtester and 'specs' subdirectory

2013-06-25 Thread Robert Haas
On Thu, Jun 20, 2013 at 7:10 PM, Josh Kupershmidt wrote: > I eventually tracked down the cause of this failure to a trailing ':' > in my $LIBRARY_PATH, which causes gcc to look inside the current > directory for a 'specs' file [1] among other things. Although I > probably don't need that trailing

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

2013-06-25 Thread Andres Freund
On 2013-06-25 12:11:06 -0400, Robert Haas wrote: > On Thu, Jun 20, 2013 at 9:17 AM, Fabrízio de Royes Mello > wrote: > > On Thu, Jun 20, 2013 at 9:59 AM, Fabien COELHO wrote: > >>> Please fix that and re-send the patch. > >> Find attached diff wrt current master. > > Thanks. > > I would like to

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

2013-06-25 Thread Robert Haas
On Thu, Jun 20, 2013 at 9:17 AM, Fabrízio de Royes Mello wrote: > On Thu, Jun 20, 2013 at 9:59 AM, Fabien COELHO wrote: >>> Please fix that and re-send the patch. >> Find attached diff wrt current master. > Thanks. I would like to solicit opinions on whether this is a good idea. I understand th

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Yuri Levinsky
Guys, I am sorry for taking your time. The reason for my question is: As former Oracle DBA and now simple beginner PostgreSQL DBA I would like to say: the current partitioning mechanism might be improved. Sorry, it seems to me far behind yesterday requirements. As model for improvement the Oracle m

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Tom Lane
Bruce Momjian writes: > I looked at predtest.c but I can't see how we accept >= and <= ranges, > but not CHECK (a % 16 == 3). It is the '%' operator? I am not sure why > the hashme() function is there. Wouldn't it work if hashme() was an > immutable function? No. Robert's description is exact

Re: [HACKERS] refresh materialized view concurrently

2013-06-25 Thread Robert Haas
On Fri, Jun 21, 2013 at 5:20 AM, Hitoshi Harada wrote: > If I don't miss something, the requirement for the CONCURRENTLY option is to > allow simple SELECT reader to read the matview concurrently while the view > is populating the new data, and INSERT/UPDATE/DELETE and SELECT FOR > UPDATE/SHARE ar

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-06-25 Thread Fujii Masao
On Tue, Jun 25, 2013 at 8:15 AM, Michael Paquier wrote: > Patch updated according to comments. Thanks for updating the patch! When I ran VACUUM FULL, I got the following error. ERROR: attempt to apply a mapping to unmapped relation 16404 STATEMENT: vacuum full; Could you let me clear why toa

Re: [HACKERS] pgbench --startup option

2013-06-25 Thread Robert Haas
On Thu, Jun 20, 2013 at 1:46 PM, Jeff Janes wrote: > I've fixed a conflict, and I've removed extraneous semicolons from the C. > > I've left in the fixing of some existing bad indenting in the existing code, > which is not strictly related to my change. OK, I like this idea a lot, but I have a qu

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Robert Haas
On Tue, Jun 25, 2013 at 11:45 AM, Bruce Momjian wrote: > On Tue, Jun 25, 2013 at 11:15:24AM -0400, Robert Haas wrote: >> On Tue, Jun 25, 2013 at 11:06 AM, Bruce Momjian wrote: >> >> Not really. Constraint exclusion won't kick in for a constraint like >> >> CHECK (hashme(a) % 16 == 3) and a WHERE

Re: [HACKERS] C++ compiler

2013-06-25 Thread Joshua D. Drake
On 06/24/2013 09:16 PM, Tom Lane wrote: Bruce Momjian writes: Right. I don't think there are any C features we want to avoid; are there any? We're avoiding C99-and-later features that are not in C89, such as // for comments, as well as more useful things. It might be time to reconsider whe

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Bruce Momjian
On Tue, Jun 25, 2013 at 11:15:24AM -0400, Robert Haas wrote: > On Tue, Jun 25, 2013 at 11:06 AM, Bruce Momjian wrote: > >> Not really. Constraint exclusion won't kick in for a constraint like > >> CHECK (hashme(a) % 16 == 3) and a WHERE clause of the form a = 42. > > > > Uh, I thought we checked

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-06-25 Thread Robert Haas
On Thu, Jun 20, 2013 at 2:32 PM, Fujii Masao wrote: > On Thu, Jun 20, 2013 at 11:43 AM, Satoshi Nagayasu wrote: >> (2013/06/17 4:02), Fujii Masao wrote: >>> >>> On Sat, Mar 9, 2013 at 3:23 PM, Satoshi Nagayasu wrote: It is obviously easy to keep two types of function interfaces, o

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-25 Thread Heikki Linnakangas
On 25.06.2013 01:24, Alexander Korotkov wrote: On Wed, Jun 19, 2013 at 1:21 AM, Alexander Korotkovwrote: On Mon, Jun 17, 2013 at 10:27 PM, Heikki Linnakangas< hlinnakan...@vmware.com> wrote: That has some obvious limitations. First of all, you can run out of memory. Yes, it is so. qsort sh

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Robert Haas
On Tue, Jun 25, 2013 at 11:06 AM, Bruce Momjian wrote: >> Not really. Constraint exclusion won't kick in for a constraint like >> CHECK (hashme(a) % 16 == 3) and a WHERE clause of the form a = 42. > > Uh, I thought we checked the constant against every CHECK constraint and > only scanned partiti

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-25 Thread Cédric Villemain
Le mardi 25 juin 2013 17:18:51, Andrew Dunstan a écrit : > On 06/24/2013 07:24 PM, Cédric Villemain wrote: > > Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a écrit : > >> On 06/24/2013 04:02 PM, Cédric Villemain wrote: > >>> WIth extension, we do have to set VPATH explicitely if we want to use >

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-25 Thread Andrew Dunstan
On 06/24/2013 07:24 PM, Cédric Villemain wrote: Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a écrit : On 06/24/2013 04:02 PM, Cédric Villemain wrote: WIth extension, we do have to set VPATH explicitely if we want to use VPATH (note that contribs/extensions must not care that postgresql has

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Bruce Momjian
On Tue, Jun 25, 2013 at 11:02:40AM -0400, Robert Haas wrote: > On Tue, Jun 25, 2013 at 9:21 AM, Bruce Momjian wrote: > > On Tue, Jun 25, 2013 at 03:48:19PM +0300, Yuri Levinsky wrote: > >> Hi, > >> > >> Do we have any plans to implement Hash Partitioning, maybe I missing this > >> feature? > > > >

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Robert Haas
On Tue, Jun 25, 2013 at 9:21 AM, Bruce Momjian wrote: > On Tue, Jun 25, 2013 at 03:48:19PM +0300, Yuri Levinsky wrote: >> Hi, >> >> Do we have any plans to implement Hash Partitioning, maybe I missing this >> feature? > > You can do it by writing your own constraint and trigger functions that > co

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

2013-06-25 Thread Robert Haas
On Sun, Jun 23, 2013 at 10:50 PM, Tom Lane wrote: > David Fetter writes: >> On Sun, Jun 23, 2013 at 07:44:26AM -0700, Kevin Grittner wrote: >>> I think it is OK if that gets a syntax error. If that's the "worst >>> case" I like this approach. > >> I think reducing the usefulness of error message

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Bruce Momjian
On Tue, Jun 25, 2013 at 05:19:47PM +0300, Yuri Levinsky wrote: > Bruce, > Many thanks. According to PostgreSQL documentation it's only range and > list partitions are supported. My question is: when I am following your > advice, is PostgreSQL will do partitioning pruning on select? My > expectation

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Yuri Levinsky
Bruce, Many thanks. According to PostgreSQL documentation it's only range and list partitions are supported. My question is: when I am following your advice, is PostgreSQL will do partitioning pruning on select? My expectation is: I divided my table on 128 hash partitions according let's say user_i

Re: [HACKERS] proposal: enable new error fields in plpgsql (9.4)

2013-06-25 Thread Pavel Stehule
Hello 2013/6/25 Rushabh Lathia : > Hi Pavel, > > I gone through the discussion over here and found that with this patch we > enable the new error fields in plpgsql. Its a simple patch to expose the new > error fields in plpgsql. > > Patch gets applied cleanly. make and make install too went smoo

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

2013-06-25 Thread Pavel Stehule
2013/6/25 Tom Lane : > Dean Rasheed writes: >> On 24 June 2013 03:50, Tom Lane wrote: >>> Going on the same principle, we could probably let FILTER be an >>> unreserved keyword while FILTER_FOLLOWED_BY_PAREN could be a >>> type_func_name_keyword. (I've not tried this though.) > >> I've not tried

  1   2   >