[Impala-ASF-CR] IMPALA-5318: Generate access events with fully qualified table names

2017-05-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6879 Change subject: IMPALA-5318: Generate access events with fully qualified table names .. IMPALA-5318: Generate access events with

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6406

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-09 Thread Dimitris Tsirogiannis (Code Review)
Hello Marcel Kornacker, Impala Public Jenkins, Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6406 to look at the new patch set (#10). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 9: Code-Review+2 Forgot to push some change. -- To view, visit http://g

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-09 Thread Dimitris Tsirogiannis (Code Review)
Hello Marcel Kornacker, Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6406 to look at the new patch set (#9). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 8: Code-Review+2 Rebase and fix minor test. Keep Marcel's +2. -- To vie

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-09 Thread Dimitris Tsirogiannis (Code Review)
Hello Marcel Kornacker, Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6406 to look at the new patch set (#8). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 20: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6495 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-06 Thread Dimitris Tsirogiannis (Code Review)
Hello Marcel Kornacker, Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6406 to look at the new patch set (#7). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/6406/5/fe/src/main/j

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-05 Thread Dimitris Tsirogiannis (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6406 to look at the new patch set (#6). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata ...

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 5: (21 comments) http://gerrit.cloudera.org:8080/#/c/6406/5/common/fbs/C

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 20: There is still one thing that is not clear to me. Why is it allowed to do an ALTER TABLE with an em

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/6495/18/testdata/workloads/functional-planner/queri

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 18: (2 comments) Thanks Lars. Some minor comments on testing. http://gerrit.cloudera.org:8080/#/c/6495

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/6495/17/fe/src/main/java/org/apache/impala/analysis

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 17: (7 comments) http://gerrit.cloudera.org:8080/#/c/6495/17//COMMIT_MSG Commit Message: PS17, Line 30

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 17: I think the interaction between the hint and clause confused me at some point. I'll take another lo

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 15: Quick question. Is there a reason why we don't remove the sortby hint in this patch? -- To view,

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6628

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 7: Code-Review+2 Rebase and minor test fix. Keep Dan's +2 -- To view,

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Dimitris Tsirogiannis (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6628 to look at the new patch set (#7). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution

[Impala-ASF-CR] IMPALA-5152: Gather all tables with missing metadata in analysis

2017-04-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5152: Gather all tables with missing metadata in analysis .. Patch Set 1: As we discussed offline, see if it makes sense to have a quick pre-analy

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This commit intro

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6628/5/be/src/servi

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This commit intro

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/6628/4/be/src/sched

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6628/1/be/src/schedu

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 3: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6651/2/fe/src/

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This commit intro

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6628/1/be/src/schedu

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 15: (19 comments) http://gerrit.cloudera.org:8080/#/c/6495/15/fe/src/main/java/org/apache/impala/analys

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 15: Doing another pass now... -- To view, visit http://gerrit.cloudera.org:8080/6495 To unsubscribe, v

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6406 to look at the new patch set (#5). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata ..

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/6406/3/common/fbs/C

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6628/1/be/src/schedu

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6628/1/be/src/schedu

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This commit intro

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6628/2/be/src/servi

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6651/1/fe/src/m

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This commit intro

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (15 comments) http://gerrit.cloudera.org:8080/#/c/6628/1/be/src/sche

[Impala-ASF-CR] IMPALA-3040: Fix test caching ddl test

2017-04-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3040: Fix test_caching_ddl test .. IMPALA-3040: Fix test_caching_ddl test This commmit adds a 30sec timeout on the validation step of test_caching_d

[Impala-ASF-CR] IMPALA-3040: Fix test caching ddl test

2017-04-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3040: Fix test_caching_ddl test .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6603/2/tests/query_test/test_hdfs_caching.py Fil

[Impala-ASF-CR] IMPALA-3040: Fix test caching ddl test

2017-04-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3040: Fix test_caching_ddl test .. Patch Set 2: (5 comments) Some comments/questions. No new patch until we answer these first. http://gerrit.cl

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6628 Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude ho

[Impala-ASF-CR] IMPALA-3040: Fix test caching ddl test

2017-04-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3040: Fix test_caching_ddl test .. IMPALA-3040: Fix test_caching_ddl test This commmit adds a 30sec timeout on the validation step of test_caching_d

[Impala-ASF-CR] IMPALA-3040: Fix test caching ddl test

2017-04-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3040: Fix test_caching_ddl test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6603/1/tests/query_test/test_hdfs_caching.py File

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-04-10 Thread Dimitris Tsirogiannis (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6406 to look at the new patch set (#4). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata ..

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-04-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 3: (14 comments) http://gerrit.cloudera.org:8080/#/c/6406/3/common/fbs/C

[Impala-ASF-CR] IMPALA-3040: Fix test caching ddl test

2017-04-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6603 Change subject: IMPALA-3040: Fix test_caching_ddl test .. IMPALA-3040: Fix test_caching_ddl test This commmit adds a 30sec timeo

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 2: (6 comments) Quick pass with some minor comments. I am still trying to wrap my

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-04-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 9: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/6495/9/fe/src/main/java/org/apache/im

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-04-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 7: (18 comments) http://gerrit.cloudera.org:8080/#/c/6495/7/fe/src/main/cup/sql-parser.cup File fe/src/

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-04-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 5: (5 comments) Responses to some comments. http://gerrit.cloudera.org:8080/#/c/6495/5/fe/src/main/jav

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-04-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 5: (20 comments) http://gerrit.cloudera.org:8080/#/c/6495/5/common/thrift/JniCatalog.thrift File common

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-03-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6495/3//COMMIT_MSG Commit Message: PS3, Line 13: Sp

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-03-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 3: (1 comment) Lars, a few high level questions before I start the next review iteration. Thanks http

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-03-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 2: (20 comments) Initial pass, haven't looked at the tests yet. http://gerrit.cloudera.org:8080/#/c/64

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 6: Code-Review+2 Keep Henry's +2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-28 Thread Dimitris Tsirogiannis (Code Review)
Hello Marcel Kornacker, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6344 to look at the new patch set (#6). Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators ...

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 5: (6 comments) Thanks Henry! http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-03-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. IMPALA-4029: Reduce memory requirements for storing file metadata This commit improve

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-03-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/6406/2/common/fbs/C

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-24 Thread Dimitris Tsirogiannis (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6344 to look at the new patch set (#5). Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators ...

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 4: (10 comments) I am not so sure about removing the catalog and

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. IMPALA-4041: Limit catalog and admission control updates to coordinators With

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 3: (12 comments) http://gerrit.cloudera.org:8080/#/c/6344/3/be/sr

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. IMPALA-4041: Limit catalog and admission control updates to coordinators With

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/6344/2/be/sr

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6408 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-03-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. IMPALA-4029: Reduce memory requirements for storing file metadata This commit improve

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-03-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 1: (15 comments) http://gerrit.cloudera.org:8080/#/c/6406/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6408/2/tests/metadata/test_recover_partit

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. IMPALA-4041: Limit catalog and admission control updates to coordinators With

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/6344/1/be/src

[Impala-ASF-CR] IMPALA-5072: Fix test recover partitions on S3

2017-03-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5072: Fix test_recover_partitions on S3 .. Patch Set 1: Code-Review+2 In terms of testing, you may run a private jenkins jobs to test your uncomm

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-03-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6406 Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. IMPALA-4029: Reduce memory requirements for

[Impala-ASF-CR] Fix typo in Flatbuffers cmake module

2017-03-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Fix typo in Flatbuffers cmake module .. Patch Set 1: Code-Review+2 Thanks Henry -- To view, visit http://gerrit.cloudera.org:8080/6398 To unsubscribe,

[Impala-ASF-CR] IMPALA-4482, IMPALA-4838: RECOVER PARTITIONS with tpcds.store sales

2017-03-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482, IMPALA-4838: RECOVER PARTITIONS with tpcds.store_sales .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/517

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6344 Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. IMPALA-4041: Limit catalog and admis

[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.

2017-03-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6296 To unsubscrib

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 4: Code-Review+2 Rebase and keep Henry's +2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6013 to look at the new patch set (#4). Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. IMPALA-4885:

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6013/3/be/src/util/thread.cc File be/src/

[Impala-ASF-CR] IMPALA-5028: Lock table in /catalog objects endpoint.

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5028: Lock table in /catalog_objects endpoint. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6296/1/tests/webserver/test_web_pa

[Impala-ASF-CR] IMPALA-4762: RECOVER PARTITIONS should batch partition updates

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4762: RECOVER PARTITIONS should batch partition updates .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6275/2/fe/s

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 3: Any more comments on this? Henry, lmk if you're swamped and I will ask someone else to tak

[Impala-ASF-CR] IMPALA-4762: RECOVER PARTITIONS should batch partition updates

2017-03-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4762: RECOVER PARTITIONS should batch partition updates .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6275/2/fe/src/main/java/

[Impala-ASF-CR] IMPALA-4762: RECOVER PARTITIONS should batch partition updates

2017-03-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4762: RECOVER PARTITIONS should batch partition updates .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/6275/1/fe/src/main/java/

[Impala-ASF-CR] IMPALA-4966: Add flatbuffers to build

2017-03-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4966: Add flatbuffers to build .. Patch Set 2: Code-Review+2 Rebase, keep Alex's +2 -- To view, visit http://gerrit.cloudera.org:8080/6180 To un

[Impala-ASF-CR] IMPALA-4998: Fix missing table lock acquisition.

2017-03-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6177/5/fe/src/main/java/o

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. IMPALA-4885: Expose Jvm thread info in web UI This commit exposes information about JVM threads to the imp

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/6013/2/be/src/util/thread.cc File be/src

[Impala-ASF-CR] IMPALA-4966: Add flatbuffers to build

2017-02-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6180 Change subject: IMPALA-4966: Add flatbuffers to build .. IMPALA-4966: Add flatbuffers to build FlatBuffers version 1.6.0 is alre

[Impala-ASF-CR] IMPALA-4902: Copy parameters map in HdfsPartition.toThrift().

2017-02-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4902: Copy parameters map in HdfsPartition.toThrift(). .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6127 To un

[Impala-ASF-CR] IMPALA-4902: Copy parameters map in HdfsPartition.toThrift().

2017-02-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4902: Copy parameters map in HdfsPartition.toThrift(). .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6127/2/fe/src/main/java/o

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 1: (10 comments) Thanks for the suggestions Henry. New screenshots are here: https://drive.go

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-02-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. IMPALA-4885: Expose Jvm thread info in web UI This commit exposes information about JVM threads to the imp

<    1   2   3   4   5   6   >