Re: [translate-pootle] Still problems committing with git

2008-07-03 Thread Christian Perrier
Quoting Lars Kruse ([EMAIL PROTECTED]): I think these are very valid comments. This whole conversation is about a bug anyway, and git is (as you mention) previously unsupported. If the code to support older git versions is available, we obviously use it, but I'm not too concerned about

Re: [translate-pootle] Still problems committing with git

2008-07-02 Thread Christian Perrier
Quoting Lars Kruse ([EMAIL PROTECTED]): C) - applying Miklos patches to the current git support - ignoring incompatibility with git=1.5.2 Personally I would prefer (A) over (B) due to the cleaner code (in the long-term). But of course, I would not mind (B), too. The current version of git

Re: [translate-pootle] Still problems committing with git

2008-07-02 Thread Christian Perrier
Quoting F Wolff ([EMAIL PROTECTED]): From Christians' feedback, I understand that things are well tested, and that we are happy with this working. (I haven't tested this yet.) s/well tested/tested :-) We don't have anything in prodcution yet (but I now really work on this, for translations

Re: [translate-pootle] Still problems committing with git

2008-07-02 Thread Miklos Vajna
On Wed, Jul 02, 2008 at 02:36:34AM +0200, Lars Kruse [EMAIL PROTECTED] wrote: 1) the current implementation does not work without the --work-tree parameter (e.g. with the two patches that were sent by Miklos (30.6.2008)) 2) git v1.5.3 (or higher) behaves as expected - it is

Re: [translate-pootle] Still problems committing with git

2008-07-02 Thread F Wolff
On Wo, 2008-07-02 at 23:18 +0200, Miklos Vajna wrote: On Wed, Jul 02, 2008 at 02:36:34AM +0200, Lars Kruse [EMAIL PROTECTED] wrote: ... C) - applying Miklos patches to the current git support - ignoring incompatibility with git=1.5.2 I think the situation where compabitility with

Re: [translate-pootle] Still problems committing with git

2008-07-02 Thread Lars Kruse
Hi, I just committed Miklos' patches for the git module as r7710. This should fix problems with git v1.5.3 (or higher). (I did it, since I did not notice any objections ...) I think if we want to support Debian stable, then we have to support 1.4.4.4, since that's the official version

Re: [translate-pootle] Still problems committing with git

2008-07-02 Thread F Wolff
On Do, 2008-07-03 at 01:56 +0200, Lars Kruse wrote: Hi, I just committed Miklos' patches for the git module as r7710. This should fix problems with git v1.5.3 (or higher). (I did it, since I did not notice any objections ...) Perfect! Thank you everybody for helping out to solve and test

Re: [translate-pootle] Still problems committing with git

2008-07-01 Thread Miklos Vajna
On Mon, Jun 30, 2008 at 11:35:13PM +0200, Miklos Vajna [EMAIL PROTECTED] wrote: here is a patch, on top of my previous one. Friedel, if you could review/commit these 2 patches, I would appreciate it. I think they are definitely useful not only for Debian but for anybody who use po files outside

Re: [translate-pootle] Still problems committing with git

2008-07-01 Thread Miklos Vajna
On Tue, Jul 01, 2008 at 09:03:37PM +0200, Wynand Winterbach [EMAIL PROTECTED] wrote: Miklos, I'll also review your changes tomorrow and try to check them in as soon as I can. If Friedel is slow to respond, it's because he's at a conference this week :). Oh, OK, I was not about to hurry you,

Re: [translate-pootle] Still problems committing with git

2008-07-01 Thread Lars Kruse
Hi, Does this solve bug 347 properly? (Do we now support the older versions of git?) I would just like to document this properly. Unfortunately no: $ ~/git/git/git --git-dir git/setup/.git --work-tree git/setup add HACKING Unknown option: --work-tree $ ~/git/git/git --version git

Re: [translate-pootle] Still problems committing with git

2008-07-01 Thread F Wolff
On Wo, 2008-07-02 at 02:36 +0200, Lars Kruse wrote: Hi, Does this solve bug 347 properly? (Do we now support the older versions of git?) I would just like to document this properly. Unfortunately no: $ ~/git/git/git --git-dir git/setup/.git --work-tree git/setup add HACKING

Re: [translate-pootle] Still problems committing with git

2008-06-30 Thread Christian Perrier
Quoting Miklos Vajna ([EMAIL PROTECTED]): On Sun, Jun 29, 2008 at 05:51:34PM +0200, Miklos Vajna [EMAIL PROTECTED] wrote: I'll send a patch to correct this later tonight. Could you try this one, please? As soon as possible, sure.

Re: [translate-pootle] Still problems committing with git

2008-06-30 Thread Christian Perrier
Quoting Miklos Vajna ([EMAIL PROTECTED]): On Mon, Jun 30, 2008 at 09:08:27AM +0200, Christian Perrier [EMAIL PROTECTED] wrote: The failure message changed..:-) [GIT] commit of ('/var/lib/pootle/di/level2/tasksel', 'debian/po/fr.po') failed: Heh. Are you sure there were actually

Re: [translate-pootle] Still problems committing with git

2008-06-29 Thread Miklos Vajna
On Sun, Jun 29, 2008 at 02:39:52PM +0200, Christian Perrier [EMAIL PROTECTED] wrote: Trace: 2008-06-29 13:58:19: Traceback (most recent call last): File /usr/lib/python2.4/site-packages/Pootle/users.py, line 259, in handle page = self.getpage(pathwords, session, argdict) File