Re: [chromium-dev] Any reason why we can't use Google's codesearch in chromium code base?

[Mohamed Mansour]

For example,
http://src.chromium.org/svn/trunk/src/chrome/common/chrome_switches.cc

<http://src.chromium.org/svn/trunk/src/chrome/common/chrome_switches.cc>Try
to search for the key that existed in the source tree couple of month ago.
http://www.google.com/codesearch?q=package:"http://src.chromium.org/svn/trunk/src"+kKioskMode<http://www.google.com/codesearch?q=package:%22http://src.chromium.org/svn/trunk/src%22+kKioskMode>

<http://www.google.com/codesearch?q=package:%22http://src.chromium.org/svn/trunk/src%22+kKioskMode>or
even couple of months ago:
http://www.google.com/codesearch?q=package:"http://src.chromium.org/svn/trunk/src"+kEnableSync<http://www.google.com/codesearch?q=package:%22http://src.chromium.org/svn/trunk/src%22+kEnableSync>

<http://www.google.com/codesearch?q=package:%22http://src.chromium.org/svn/trunk/src%22+kEnableSync>But
search for something that was in the tree when Chromium first started
http://www.google.com/codesearch?q=package:"http://src.chromium.org/svn/trunk/src"+kApp<http://www.google.com/codesearch?q=package:%22http://src.chromium.org/svn/trunk/src%22+kApp>

<http://www.google.com/codesearch?q=package:%22http://src.chromium.org/svn/trunk/src%22+kApp>Or
even something that was deleted from our current state that still exists
there:
http://www.google.com/codesearch?q=package:"http://src.chromium.org/svn/trunk/src"+kEnableWebSockets

That happens to everything. It seems it stopped indexing our source couple
of months ago (~6 or so)

-Mohamed Mansour


On Fri, Jan 1, 2010 at 12:52 PM, Evan Martin  wrote:

> On Fri, Jan 1, 2010 at 1:23 AM, Mohamed Mansour
>  wrote:
> > Hi everyone, first I want to say Happy New Years!
> > For the last year, it was very easy and super fast searching the code
> base
> > of Chromium via http://www.google.com/codesearch, everything was there.
> > Codesearch gave us nice set of code searching tools we can use. It was
> > faster than grep, ack-grep, etc... If I wanted to search for a variable,
> all
> > I do "package:src.chromium.org kSomePrefVariable" and instantaneously,
> it
> > gives me the results.
> > For the past month or so, I rarely get any results anymore. Try searching
> > for something that was committed last week, even couple of month ago, you
> > simply can't. Does anyone internal know whats wrong? Did we block some
> > crawling (similar thing to what WebKit did to their repository)?
> > It would be nice if we can re-enable whatever we disabled. It was a nice,
> > well presented feature to explore Chromium's massive source code
>
> I clicked around a bit and found that
>  package:"http://src.chromium.org/svn/trunk/src";
> seems to be our source tree.  I'm not sure if that counts as working
> or not.  Maybe you can include a query that is failing that you think
> ought to work?
>

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] Any reason why we can't use Google's codesearch in chromium code base?

[Mohamed Mansour]

Hi everyone, first I want to say Happy New Years!

For the last year, it was very easy and super fast searching the code base
of Chromium via http://www.google.com/codesearch, everything was there.
Codesearch gave us nice set of code searching tools we can use. It was
faster than grep, ack-grep, etc... If I wanted to search for a variable, all
I do "package:src.chromium.org kSomePrefVariable" and instantaneously, it
gives me the results.

For the past month or so, I rarely get any results anymore. Try searching
for something that was committed last week, even couple of month ago, you
simply can't. Does anyone internal know whats wrong? Did we block some
crawling (similar thing to what WebKit did to their repository)?

It would be nice if we can re-enable whatever we disabled. It was a nice,
well presented feature to explore Chromium's massive source code

-Mohamed

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] suppressing print dialog in kiosk mode

[Mohamed Mansour]

Why wont you just remove --supress-print-dialog and just include it in kiosk
instead. I don't believe there is a reason to have an extra command line
option for that. Unless other people want that ... I believe preferences is
a better task for this since it is going to persisted in the near future.


-Mohamed Mansour


On Thu, Dec 31, 2009 at 5:39 PM, Andy Ames  wrote:

> Thanks for the tips.
>
> I will put printer settings into the preferences as a dictionary instead of
> on the command-line.
>
> I'll create only one command-line switch called --suppress-print-dialog. I
> will make sure --kiosk implies that switch. For easier debugging, I will
> need to be able to suppress the print dialog when not in kiosk mode.
>
> I created 2 issues in the tracker for both the suppressing of the dialog
> and the printer settings:
>
> http://code.google.com/p/chromium/issues/detail?id=31395
> http://code.google.com/p/chromium/issues/detail?id=31396
>
> I will be working on these right away.
>
> Andy
>
> On Dec 31, 2009, at 12:11 PM, Mohamed Mansour wrote:
>
> On Thu, Dec 31, 2009 at 5:51 AM, Peter Kasting wrote:
>>
>> They don't seem orthogonal, since in kiosk mode it doesn't seem like you
>> would ever want to show a user a print dialog (or any other kind of system
>> configuration dialog).
>>
>
> I agree as well. 1+
>
>
>> Why not instead make these things that can be configured in the
>> preferences, which (being JSON) can be more descriptive without affecting
>> the command-line parsing code?
>>
>
> Thats the idea that was intended. Marc-Antoine, Sverrir and I actually did
> basic printer settings preferences a way back, (the definition of it) you
> can view the code here:
> http://src.chromium.org/viewvc/chrome?view=rev&revision=13426
>
> The definition of the preferences for printing (so far) is defined as
> follows:
>
> "printing": {
>"page": {
>   "header": {
>  "left": " ",
>  "center": " ",
>  "right": " "
>   },
>   "footer": {
>  "left": "{date}",
>  "center": " ",
>  "right": " "
>   }
>}
> }
>
> Those are not hooked up yet to our printing yet, and would be great to do
> so. We can offer other preferences for printing there as well. But make sure
> you inform Marc-Antoine (maruel@)  and the group before doing anything.
>
> I don't think its ideal to put --printer configurations in the command line
> parameter, it shouldn't be like that and it becomes confusing and cluttered.
> We already have a place in preferences for "printing".
>
> If you want, I can assist you on the Windows portion (I am an external
> contributor so my time is usually limited). There is a lot printing related
> issues related to threads that need to be fixed first before hooking it up
> the preferences printer settings to chrome.
> http://code.google.com/p/chromium/issues/list?q=label:Printing
>
>>
> Let us know and let me know if you need a Windows SideKick :)
>
>
>  --
> Chromium Developers mailing list: chromium-dev@googlegroups.com
> View archives, change email options, or unsubscribe:
> http://groups.google.com/group/chromium-dev
>

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] suppressing print dialog in kiosk mode

[Mohamed Mansour]

On Thu, Dec 31, 2009 at 5:51 AM, Peter Kasting  wrote:
>
> They don't seem orthogonal, since in kiosk mode it doesn't seem like you
> would ever want to show a user a print dialog (or any other kind of system
> configuration dialog).
>

I agree as well. 1+


> Why not instead make these things that can be configured in the
> preferences, which (being JSON) can be more descriptive without affecting
> the command-line parsing code?
>

Thats the idea that was intended. Marc-Antoine, Sverrir and I actually did
basic printer settings preferences a way back, (the definition of it) you
can view the code here:
http://src.chromium.org/viewvc/chrome?view=rev&revision=13426

The definition of the preferences for printing (so far) is defined as
follows:


"printing": {
   "page": {
  "header": {
 "left": " ",
 "center": " ",
 "right": " "
  },
  "footer": {
 "left": "{date}",
 "center": " ",
 "right": " "
  }
   }
}

Those are not hooked up yet to our printing yet, and would be great to do
so. We can offer other preferences for printing there as well. But make sure
you inform Marc-Antoine (maruel@)  and the group before doing anything.

I don't think its ideal to put --printer configurations in the command line
parameter, it shouldn't be like that and it becomes confusing and cluttered.
We already have a place in preferences for "printing".

If you want, I can assist you on the Windows portion (I am an external
contributor so my time is usually limited). There is a lot printing related
issues related to threads that need to be fixed first before hooking it up
the preferences printer settings to chrome.
http://code.google.com/p/chromium/issues/list?q=label:Printing

>
Let us know and let me know if you need a Windows SideKick :)

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Command Line switches persisted in Preferences

[Mohamed Mansour]

Yea, thinking about it again, Peter's reasoning is totally true.

The options that many people tend to use that I have seen in the forums are
(or group of people that is):
 --incognito (they always want to browse invincible)
 --bookmark-menu (many use this because they want a cleaner UI with no
bookmark bar)
 --user-dir (some people want to change the location instead of the default)

I could see the reasoning for them too.

On Thu, Dec 24, 2009 at 9:53 PM, Peter Kasting  wrote:

> On Thu, Dec 24, 2009 at 3:29 PM, Evan Martin  wrote:
>
>> You must use switches for a pretty common pattern ("separate profile
>> that goes through my work proxy") and I believe that's been wontfixed
>> in the past, so I'm not entirely unsympathetic to Mohamed's
>> suggestion, but I think Peter is right in principle.
>>
>
> The proxy case is definitely a case where it affects a small number of
> people but is a real need for that group.
>
> My impression is that on Mac this is less of an issue because you can set
> up separate Locations in the network settings (?).  On Windows, though,
> you're stuck with command-line options.  I wish I had an elegant solution
> for this that wasn't Firefox' "my network settings are entirely divorced
> from the rest of your system".
>
> I would hesitantly support some sort of network settings dialog that by
> default is all dimmed out with a checked checkbox at the top saying "use
> system settings".  Don't know that I could convince the UI leads to go for
> that, though.
>
> PK
>

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] Command Line switches persisted in Preferences

[Mohamed Mansour]

Hi everyone, first, I want to say Merry Christmas :)

We have many command line switches in Chromium that many users would like to
have switched on every time. And managing them using registry or even
modifying the shortcut directly doesn't always work (Windows7) and its very
tedious. Is their any argument not allowing command line options to be
persisted in the Preferences file? There is even a limit on how many
arguments you can put that small Shortcut Properties dialog which makes it
even more unusable.

Many users on the forums, would always like to run specific command line
switches, many of them run more than 1, some of them turn on ~5. Can't we
just include another pref name that we name "switches" that users can put
whatever they want inside that?

That will make many people happy. Since the UI team doesn't like to add more
customizable preferences in the UI, this would be the next simplest place to
tell users to customize a couple of stuff without affecting the UI at all.

-Mohamed Mansour

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] [WebGL] Recommending --no-sandbox

[Mohamed Mansour]

That would be nice to have. Everyone agrees that is a critical option to
turn on, so a light red tone info bar would be great for that.

-Mohamed Mansour


On Fri, Dec 11, 2009 at 12:49 AM, Finnur Thorarinsson
wrote:

> I wonder... should we show an infobar on startup when the sandbox is
> disabled?
>
>
> On Thu, Dec 10, 2009 at 21:38, John Abd-El-Malek  wrote:
>
>> We disable --single-process and --in-process-plugins on release Google
>> Chrome builds to avoid the support headache that it causes.  I think we
>> should do the same for --no-sandbox.
>>
>> On Thu, Dec 10, 2009 at 8:22 PM, Darin Fisher  wrote:
>>
>>> After reading the WebGL blog post today, and following the link to the
>>> wiki, it struck me as fairly *bad* that we are telling people to disable the
>>> sandbox.  A good number of folks are going to disable the sandbox and forget
>>> that they had ever done so.
>>>
>>> Once we can support WebGL in the sandbox, what will we do?  It would be
>>> nice if we could somehow restore the sandbox automatically.  But renaming
>>> --no-sandbox doesn't seem like a great choice, and it isn't a scalable
>>> solution for other things like this that come up in the future.
>>>
>>> Perhaps --enable-webgl should instead implicitly disable the sandbox
>>> today so that "tomorrow," when WebGL just works, folks won't have to change
>>> any command line options to restore sandbox functionality.  I can see a
>>> counter argument that people should have to explicitly opt-in to disabling
>>> the sandbox, but I'm not sure that out-weighs the cost of having a good
>>> number of dev channel users running *permanently* without the sandbox.
>>>
>>> Was this idea considered?  Any other ideas?
>>>
>>> -Darin
>>>
>>> --
>>> Chromium Developers mailing list: chromium-dev@googlegroups.com
>>> View archives, change email options, or unsubscribe:
>>> http://groups.google.com/group/chromium-dev
>>
>>
>>  --
>> Chromium Developers mailing list: chromium-dev@googlegroups.com
>> View archives, change email options, or unsubscribe:
>> http://groups.google.com/group/chromium-dev
>>
>
>  --
> Chromium Developers mailing list: chromium-dev@googlegroups.com
> View archives, change email options, or unsubscribe:
> http://groups.google.com/group/chromium-dev
>

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Extensions and the Mac

[Mohamed Mansour]

Can we at least deny installing the extension in Chromium if it contains
plugins that cannot be used in that operating system for now until a better
design for cross-platform manifest?

- Mohamed Mansour


On Thu, Dec 10, 2009 at 7:15 PM, Matt Perry  wrote:

> Yeah, that's very bad. I knew the NPAPI syntax sucked, but we punted on it
> because we didn't like any of the alternatives. (Even if we do have a
> manifest syntax for it, the extension package becomes bloated with plugin
> binaries for other platforms.) But I didn't realize that it could cause a
> crash. I'll definitely have to figure something out soon.
>
> On Thu, Dec 10, 2009 at 4:03 PM, Avi Drissman  wrote:
>
>> Andy sent me a CL for review about an extension crashing (
>> http://crbug.com/29584). Turns out the cause was a failure to load a
>> Windows .dll on the Mac.
>>
>> Huh? Then I went to look at the docs (
>> http://code.google.com/chrome/extensions/npapi.html):
>>
>> {
>>   "name": "My extension",
>>   ...
>>   *"plugins": [
>> { "path": "content_plugin.dll", "public": true },
>> { "path": "extension_plugin.dll" }
>>
>>
>>
>>
>>   ]*,
>>   ...
>> }
>>
>> Are you kidding me? How can we get away with not specifying what platform
>> the extension will run on? (Hint: we can't.)
>>
>> If we had something like:
>>
>> "plugins": {
>>   "mac": ...
>>   "win": ...
>>   "linux": ...
>> }
>>
>> then at least we could warn on the extensions website that a given
>> extension is only compatible with a certain platform. On a load attempt we
>> could know that the extension requires a certain native library and fail to
>> load it with a real user-friendly warning.
>>
>> And developers could *make* extensions that are cross-platform
>> compatible.
>>
>> Today?
>> - We can't tell in advance what platforms an extensions runs on, so we
>> can't warn the user (either on the extensions site or in the app)
>> - The developer has no way of creating a cross-platform extension.
>>
>> This is a *really* bad situation we've created. We need to get a new
>> syntax out for extensions to fix this, and soon, before world-breaking
>> becomes prohibitively expensive.
>>
>> Avi
>>
>> --
>> Chromium Developers mailing list: chromium-dev@googlegroups.com
>> View archives, change email options, or unsubscribe:
>> http://groups.google.com/group/chromium-dev
>
>
>  --
> Chromium Developers mailing list: chromium-dev@googlegroups.com
> View archives, change email options, or unsubscribe:
> http://groups.google.com/group/chromium-dev
>

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Re: Chromium Tech Talks

[Mohamed Mansour]

Awesome, nice work everyone!

On Tue, Dec 8, 2009 at 2:26 PM, Jeremy Orlow  wrote:

> On Tue, Dec 8, 2009 at 11:25 AM, Jeremy Orlow  wrote:
>
>> Last Friday we recorded 4 tech talks based on the feedback we got on what
>> topics would be interestingand here they are!
>>
>> http://www.youtube.com/watch?v=JFzC_Gx76E8
>> Darin Fisher talks about the recently upstreamed Chromium WebKit API.
>>
>> http://www.youtube.com/watch?v=bO3XEBuIDns
>> Pam Greene talks about how WebKit Layout Tests are used within Chromium.
>>
>> http://www.youtube.com/watch?v=A5-aXfSt-RA
>> Brett Wilson talks about the painting process in Chromium. Brett starts
>> from the render tree in WebKit, across the IPC boundaries, and all the way
>> to your screen. He also details many of the differences in painting between
>> platforms.
>>
>> http://www.youtube.com/watch?v=IpcOXzIsSlo
>> A deep dive into the guts of WebKit. Eric Seidel explains the process from
>> loading the resources, building the DOM tree, and the various trees involved
>> in rendering.
>>
>>
>> I can't tell you how impressed I was with all of the talks.  I learned a
>> couple things from even the talks that covered material I thought I knew
>> well.
>>
>> Enjoy!
>> J
>>
>
> P.S. All the talks (past and present) can be found here:
> http://sites.google.com/a/chromium.org/dev/developers/tech-talk-videos
>
>  --
> Chromium Developers mailing list: chromium-dev@googlegroups.com
> View archives, change email options, or unsubscribe:
> http://groups.google.com/group/chromium-dev
>



-- 
 - Mohamed Mansour

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Design doc: Geolocation

[Mohamed Mansour]

On Tue, Dec 1, 2009 at 6:07 PM, Alex Faaborg  wrote:

> Should the various browser vendors try to use common iconography for
> geolocation, similar to how a standard symbol for Web Feeds emerged?
> The external consistency would likely help users as they moved between
> multiple apps and sites that support geolocation.
> -Alex
>

I would like that. One thing I liked about the icon for RSS is that its
consistent.


 On Nov 28, 2009, at 5:07 PM, Adam Barth wrote:
>
> > Nice mocks.  A few questions:
> >
> > 1) Why green?  The other infobars in the product are yellow.
> > Historically, green in browsers has signaled extended validation.
> >
> > 2) Is there any difference in presentation for SSL versus non-SSL
> > sites?  From the mocks, it looks like we're showing the host name but
> > not the scheme.
> >
> > 3) Will there be an option to dismiss these dialogs for good (either
> > to accept them all or reject them all)?
> >
> > Thanks,
> > Adam
> >
> >
> > On Thu, Nov 26, 2009 at 10:03 AM, Jonathan Dixon 
> > wrote:
> >> I am implementung the geolocation API
> >> (http://www.w3.org/TR/geolocation-API/) in Chromium using the
> >> WebKit native
> >> bindings. Here is a short design doc for the changes:
> >> http://docs.google.com/View?id=dfbnm49n_0dpc7pxpx
> >>
> >> If you have any comments or questions please feel free to direct
> >> them to me.
> >>
> >> Cheers
> >> Jonathan
> >>
> >> --
> >> Chromium Developers mailing list: chromium-dev@googlegroups.com
> >> View archives, change email options, or unsubscribe:
> >> http://groups.google.com/group/chromium-dev
> >
> > --
> > Chromium Developers mailing list: chromium-dev@googlegroups.com
> > View archives, change email options, or unsubscribe:
> >http://groups.google.com/group/chromium-dev
>
> --
> Chromium Developers mailing list: chromium-dev@googlegroups.com
> View archives, change email options, or unsubscribe:
>http://groups.google.com/group/chromium-dev
>

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] 3d on Google OS

[Mohamed Mansour]

There has been a 3D plugin for a while now http://code.google.com/apis/o3d/ and
there is WebGL http://code.google.com/p/chromium/issues/detail?id=21852

 - Mohamed Mansour


On Sat, Nov 28, 2009 at 11:56 AM, sandrs  wrote:

> Hi guys
> I am a 3d designer. A lot of time I want to jump from Windows to
> Linux. However by the time it is impossible because a lot of 3d
> programs do not work on Linux. Could you offer  something to work with
> 3d programs in Google OS? I know that a lot of designers will jump
> from Windwos to Linux.
> Best.
>
> --
> Chromium Developers mailing list: chromium-dev@googlegroups.com
> View archives, change email options, or unsubscribe:
>http://groups.google.com/group/chromium-dev
>

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] user-contributed translations

[Mohamed Mansour]

I always link them to this page:
http://dev.chromium.org/developers/design-documents/ui-localization

<http://dev.chromium.org/developers/design-documents/ui-localization>It
would be hassle for users to manage their own translations, it has to be
updated daily, maybe if we had some web tool that people contribute
translations to and make that available to chromium. It would be quicker to
allow the community help with translation instead of waiting for Google
providing it for us.

 - Mohamed Mansour


On Thu, Nov 19, 2009 at 5:17 PM, Evan Martin  wrote:

> I persistently get questions from users wanting to provide
> localization for Chrome.
>
> I believe our answer is that we don't accept user-contributed translations.
> Is there a FAQ somewhere I can link these users to?  Where would such
> a FAQ belong?
>
> Also, another option for these users is to write their own
> translations and let downstream (Chromium distributors) ship them.
> For example, note the hundreds of translations in Ubuntu:
>  https://translations.launchpad.net/ubuntu/karmic/+translations
> Does anyone have pointers on how they might be able to set up these
> translations?
>
> --
> Chromium Developers mailing list: chromium-dev@googlegroups.com
> View archives, change email options, or unsubscribe:
>http://groups.google.com/group/chromium-dev
>

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Access keys are broken in 4.0

[Mohamed Mansour]

Yea, we added ALT+E and ALT+F for opening the menus to make them accessible
on Windows. (Similar to File/Edit in any Window screen menu). There was a
post long time ago regarding that and everyone agreed adding that. They were
added through the chrome_rc.grd file.

Now, if the shortcut key exists in the website, how would browser keyboard
shortcuts (that have the same keys) act? Should the browser shortcuts be
disabled once a renderer shortcut exists?

 - Mohamed Mansour


On Thu, Nov 12, 2009 at 1:28 PM, Nico Weber  wrote:

> +1 on filing a bug. Please paste a link to your bug here when you've filed
> it.
>
> In the meantime, I think mhm added alt-e and alt-t on windows. It
> sounds as if these mappings take effect before being sent to the
> renderer?
>
> On Thu, Nov 12, 2009 at 10:09 AM, Peter Kasting 
> wrote:
> > On Thu, Nov 12, 2009 at 9:14 AM, Jeff Mikels 
> wrote:
> >>
> >> I don't know if people consider this a problem or not, but 4.0
> >> introduced new behavior for access keys.
> >
> > What OS?  I'm guessing Linux?  (Keys are different on all OSes)
> > I have no idea what guarantees browsers try to make for alt+key.  I'm not
> > sure that on Windows pages can even get these events, and I'm not sure
> what
> > the typical shortcut is for accessing named menus on Linux.
> > It might be better to file a bug rather than emailing chromium-dev.
> > PK
> >
> > --
> > Chromium Developers mailing list: chromium-dev@googlegroups.com
> > View archives, change email options, or unsubscribe:
> > http://groups.google.com/group/chromium-dev
>

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] Re: how to debug in webkit

[Mohamed Mansour]

Hello,

Chrome is a multi process architecture, you would have to attach the running
child process with the debugger. The following document will show you how to
do so.
http://dev.chromium.org/developers/how-tos/debugging

<http://dev.chromium.org/developers/how-tos/debugging>
 - Mohamed Mansour


On Mon, Nov 9, 2009 at 10:03 PM, DavidZhang  wrote:

>
> Hi all:
>  I have complied the chrome source,but when i set the breakpoint in
> webkit,It doesn't work.
>  And i tried in other modules such as view,and it workes.
>  I want to know how does it happens,and how to make the breakpoint
> works?
>  That's all,thanks!
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Tech talk topics

[Mohamed Mansour]

+1 on the WebKit tech talks. And maybe on on the WebKitAPI infrastructure
that darin organized.

 - Mohamed Mansour


On Thu, Nov 5, 2009 at 5:17 PM, Scott Violet  wrote:

>
> It's not Chromium, but how about some WebKit tech talks? Such talks
> would be incredibly valuable to those helping out now and then with
> WebKit.
>
>  -Scott
>
> On Thu, Nov 5, 2009 at 1:35 PM, Jeremy Orlow  wrote:
> > About 6 months ago, we had a series of tech talks on various bits of
> > Chromium's architecture.  (They're listed
> > here: http://dev.chromium.org/developers/tech-talk-videos)  The youtube
> > ratings are pretty high, they've all had over a thousand views, and I've
> > seen them mentioned in a couple chromium-dev threadsso it seems like
> > they've been helpful.
> > So here's my question: are there any Chromium-internals related topics
> you
> > guys/gals would really like to hear more on?  If so, I'll see if we can't
> > find speakers, schedule some tech talks, get them recorded, and posted.
>  And
> > this time, we'll make sure the audio and video quality is much higher.
>  :-)
> > J
> >
> > >
> >
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: test_shell performance is bad compared to Chromium

[Mohamed Mansour]

On Thu, Nov 5, 2009 at 5:33 PM, Peter Kasting  wrote:

> On Thu, Nov 5, 2009 at 1:51 PM, Nico Weber  wrote:
>
>> http://codereview.chromium.org/244003/show might be what you want.
>
>
> I thought this was intentionally abandoned because it was growing out of
> control.  That's what I was alluding to before.
>
>
Not entirely abandoned, true it was getting out of control and that is why I
stopped to take a step back. Technically it should be what I did for patch
set one, which is just fullscreen + no statusbar. That is basically what the
functionality is. I will continue working on it tonight.

 - Mohamed Mansour

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Is there any document describing the overall architecture of the browser process?

[Mohamed Mansour]

Hi James, when I first started, I read the design documents here:
http://dev.chromium.org/developers/design-documents

 <http://dev.chromium.org/developers/design-documents>They helped me give me
the initial push in the architecture, they are pretty well done. Maybe the
one your looking for is:
http://dev.chromium.org/developers/design-documents/displaying-a-web-page-in-chrome

<http://dev.chromium.org/developers/design-documents/displaying-a-web-page-in-chrome>I
don't know how acurate those documents are anymore, a lot of refactoring has
been done, I don't know if the devs are updating them as they refactor.

 - Mohamed Mansour


On Wed, Nov 4, 2009 at 10:54 PM, James Su  wrote:

> Hi,
>   Recently, I'm studying the source code under chrome/browser and trying to
> understand the overall architecture, especially the relationship among those
> important classes, such as Browser, BrowserWindow, TabContents,
> TabContentsDelegate, TabContentsView, TabStripModel, RenderWidgetHost,
> RenderWidgetHostView, ExternalTabContainer, etc. Though I already have a
> rough picture of the architecture, there are still many aspects that I don't
> understand very well, such as:
>
> 1. The ownership among these classes.
> 2. The relationship between Browser and ExternalTabContainer classes, which
> both implement TabContentsDelegate interface. And how does an external tab
> work?
> 3. Does a TabContentsView always associate to a Browser?
>
>   I'm wondering if there is any document to help me understand these
> aspects? I searched on dev.chromium.org but found nothing related.
>
> Thanks
> James Su
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Proposal: rename CHROME_PERSONALIZATION to ENABLE_BROWSER_SYNC

[Mohamed Mansour]

BROWSER_SYNC++  I always thought PERSONALIZATION was weird.

 - Mohamed Mansour


On Wed, Oct 14, 2009 at 3:33 PM, Scott Violet  wrote:

>
> Why the ENABLE? Why not BROWSER_SYNC?
>
>  -Scott
>
> On Wed, Oct 14, 2009 at 12:23 PM, Munjal Doshi 
> wrote:
> > I like ENABLE_BROWSER_SYNC too.
> >
> > -Munjal
> >
> > On Wed, Oct 14, 2009 at 12:17 PM, Tim Steele  wrote:
> >>
> >> (chromium-dev-izing thread)
> >> Are we still a month from having the platforms build?  If we aren't do
> we
> >> have another way to disable a feature per platform, or just command line
> >> flags?
> >> I'm cool with ENABLE_BROWSER_SYNC though.
> >>
> >> On Wed, Oct 14, 2009 at 12:13 PM, Nick Carter 
> wrote:
> >>>
> >>> The #define CHROME_PERSONALIZATION is the last remaining vestige of
> sync
> >>> obfuscation.  We will need a feature define until sync is enabled by
> default
> >>> for all builds (mac, linux, chromeos).  That's a month or more.
> >>> In the meantime, CHROME_PERSONALIZATION is an unintuitive name.  I
> >>> propose changing it to ENABLE_BROWSER_SYNC.
> >>> Any objections or counter-proposals?
> >>>  - nick
> >>>
> >>> --
> >>>
> >>> You received this message because you are subscribed to the Google
> Groups
> >>> "chrome-sync-dev" group.
> >>> To post to this group, send email to chrome-sync-...@google.com.
> >>> To unsubscribe from this group, send email to
> >>> chrome-sync-dev+unsubscr...@google.com
> .
> >>> For more options, visit this group at
> >>> http://groups.google.com/a/google.com/group/chrome-sync-dev?hl=en.
> >>
> >>
> >>
> >
> >
> > >
> >
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: MSVC2005 vs Win7 PlatformSDK

[Mohamed Mansour]

Ah, I let Microsoft update to do all the updates for me and it worked fine.
 -Mohamed


On Fri, Oct 9, 2009 at 4:44 AM, yu...@chromium.org wrote:

>
> I installed VS80sp1-KB949009-X86-INTL.exe and it works fine. Sorry, I
> forgot that VS is 32 bit.
>
> Thanks,
> Yury
>
> On Oct 9, 12:21 pm, "yu...@chromium.org"  wrote:
> > I tried this one:
> > VS80sp1-KB949009-X64-INTL.exe
> >
> > On Oct 9, 12:06 am, Marc-Antoine Ruel  wrote:
> >
> >
> >
> > > Did you try the right file?
> >
> > > On Thu, Oct 8, 2009 at 1:20 PM, yu...@chromium.org  >wrote:
> >
> > > > When trying to install the hotfix on Win7/64 I'm getting following
> > > > message:
> >
> > > > "The upgrade patch cannot be installed by the Windows Installer
> > > > service
> > > >  because the program to be upgraded may be missing, or the upgrade
> > > > patch
> > > >  may update a different version of the program. Verify that the
> > > > program to be
> > > >  upgraded exists on your computer and that you have the correct
> > > > upgrade patch."
> >
> > > > Any ideas how to fix that?
> >
> > > > Thanks,
> > > > Yury
> >
> > > > On Sep 30, 9:39 pm, Stephen White  wrote:
> > > > > Just in case someone else runs into this:  I recently installed
> MSVC2005
> > > > and
> > > > > the Win7 Platform SDK on my win7/64 machine and it gave me this
> error at
> > > > > link time:
> > > > > shell32.lib(shguid.obj) : fatal error LNK1103: debugging
> information
> > > > > corrupt; recompile module
> >
> > > > > Installing hotfix 949009 (
> > > >
> https://connect.microsoft.com/VisualStudio/Downloads/DownloadDetails)
> > > > > fixed it. We currently have that hotfix listed in the build
> instructions
> > > > as
> > > > > "to be confirmed" (it's still in beta).
> >
> > > > > Stephen
> >
> > > > > --
> > > > > All truth passes through three stages. First, it is ridiculed.
> Second, it
> > > > is
> > > > > violently opposed. Third, it is accepted as being self-evident. --
> > > > > Schopenhauer
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Chrome Keyboard Access, opinions?

[Mohamed Mansour]

Hi everyone,
I was experimenting on how to visualize when we focus different tabs, and
(from a bug I was working on http://crbug.com/15228) I realized a few stuff.
If we enable "IsFocusable" for all the toolbars we have in Chromium, we will
have this "good" (or some people might be annoyed by it) focus bar around
the whole toolstrip. It looks like this:

http://i37.tinypic.com/25ugpc0.png


 What do you all think about having the focus ring when we traverse the
toolbars? I think it would be a nice additional. On a side note, the focus
ring only appears if you have pressed "ALT+SHIFT+T", otherwise no focus ring
will be shown.

Since we agreed in this email that we will be having "ALT+SHIFT+T" + tab, to
traverse through all the tool bars, that is only valid for "forwards
traverses" not "backward traverses". How are we planning to do that?

I suggest we do "ALT+T" to apply focus to the ToolBarView and when we press
"ALT+T+TAB" it will focus to the next tab, same thing with applying SHIFT
(go backwards).

 -Mohamed


On Wed, Sep 30, 2009 at 11:10 AM, Scott Violet  wrote:

> Sounds good to me.
>
>  -Scott
>
> On Tue, Sep 29, 2009 at 5:03 PM, Jonas Klink (Google)
>  wrote:
> > So, to clarify, we would then use ALT+SHIFT+T (currently focusing the
> > toolbar), to cycle keyboard focus through any open toolbars
> > (toolbar->bookmark bar->infobar (restore tabs etc, if
> visible)->Extensions
> > toolstrips). Does that makes sense to everyone? The shortcut is not
> ideal,
> > but it might be the best we've got...
> >
> > On Tue, Sep 29, 2009 at 4:26 PM, Scott Violet  wrote:
> >>
> >> I would just use the existing accelerator we have to focus the toolbar.
> >>
> >>  -Scott
> >>
> >> On Tue, Sep 29, 2009 at 3:58 PM, Mohamed Mansour 
> wrote:
> >> > What kind of accelerators do would you like to have? Maybe have
> >> > a accelerator that traverses only toolbars, and once we are in that
> >> > toolbar,
> >> > we can tab through the widgets.
> >> >  -Mohamed
> >> >
> >> >
> >> > On Tue, Sep 29, 2009 at 1:30 PM, Peter Kasting 
> >> > wrote:
> >> >>
> >> >> On Tue, Sep 29, 2009 at 10:25 AM, Scott Violet 
> >> >> wrote:
> >> >>>
> >> >>> On Tue, Sep 29, 2009 at 10:16 AM, Peter Kasting <
> pkast...@google.com>
> >> >>> wrote:> It seems like when these bars are open, their contents
> should
> >> >>> be in
> >> >>> the tab
> >> >>> > order.  You should be able to tab through the contents of a page,
> >> >>> > into
> >> >>> > the
> >> >>> > chrome, and eventually back into the page.
> >> >>>
> >> >>> I don't think most folks want tab from the omnibox to take you
> through
> >> >>> the menus, then bookmark buttons. I know that would drive me batty.
> I
> >> >>> could see some users wanting it, but I don't think it should be the
> >> >>> default.
> >> >>
> >> >> I admit that I totally failed to think through "tab in the omnibox"
> --
> >> >> I
> >> >> was thinking about all the other cases.
> >> >> That said, we've had TONS of requests to make tab from the omnibox
> work
> >> >> differently (i.e. "like how other browsers do it"):
> >> >> * When the popup is open, tab rotates through its items
> >> >> * Otherwise, tab moves to the next focusable element
> >> >> I kind of regret that we picked tab for "tab to search" because it
> >> >> prevents both of these, and I'm not sure we can change it now.  It
> does
> >> >> seem
> >> >> like a bug somehow that you can tab into the omnibox but not out, but
> I
> >> >> don't know how to fix :(
> >> >>>
> >> >>> Perhaps we
> >> >>> also need the ability to assign accelerators to individual
> >> >>> bookmarks/extensions.
> >> >>
> >> >> This has been requested a few times, and brakowski suggested it long
> >> >> ago
> >> >> as a replacement for the "home" button -- if you can drag a bookmark
> >> >> onto
> >> >> your main toolbar, and give it an alt-home shortcut, then you have
> your
> >> >> own
> >> >> "home" button.
> >> >> PK
> >> >
> >
> >
> > > >
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Friendly reminder: don't let changes rot

[Mohamed Mansour]

Actually, Chromium has improved big time on the review rate. When I first
started, some reviews usually stay unreviewed for more than a week, even
repinging didn't work correctly :) But for the last couple of months, when I
ask for a review, within the same hour I get a response, which is excellent.
I don't even mind if its a day, but if its more than a day, it becomes
unpleasant.
It depends on the people you send the review ;x Its hard for "external"
contributors to know who is on vacation while sending a review, so if they
don't send a reply within a day, I assume they are on vacation, then I ask
another person on irc for a review.

I believe its getting better, better than when the project stated. There are
still some people that once you give them a review, they forget about it and
you look at their list of reviews, and they are too many. Some people tend
to be busy with their important stuff, which is understandable, but 1 day
over turn rate should be the maximum.

 -Mohamed


On Thu, Oct 8, 2009 at 2:00 PM, Mike Pinkerton wrote:

>
> On Thu, Oct 8, 2009 at 1:55 PM, Evan Martin  wrote:
> > My rationale is: someone sends me a code review when they think the
> > code is "done", which means they're further along in their project
> > than I am in mine, and I am now in the critical path for them making
> > progress.  But I can also see the other side.
>
> The other way of looking at that is "they're at a convenient stopping
> point, I'm still busy working on something". What's that quip about
> just because something is an emergency to you doesn't mean it is to
> me? :-)
>
> All that said, I do try to get to code reviews as soon as possible.
>
> --
> Mike Pinkerton
> Mac Weenie
> pinker...@google.com
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Has anyone built successfully on Win7 64bit? I am getting bash.exe errors

[Mohamed Mansour]

I run "Cygwin Bash Shell" not from Command Prompt:

moha...@mohamed-pc ~$ bash


 -Mohamed


On Thu, Oct 1, 2009 at 5:32 PM, vha14  wrote:

>
> Hi Mohamed, can you run bash.exe from cmd? I get the following error:
>
> E:\chromium\home\chrome-svn\tarball\chromium\src\third_party\cygwin
> \bin>bash
>  9 [main] bash 8384 _cygtls::handle_exceptions: Exception:
> STATUS_ACCESS_VIOLATION
>   9964 [main] bash 8384 open_stackdumpfile: Dumping stack trace to
> bash.exe.stackdump
>  211065 [main] bash 8384 _cygtls::handle_exceptions: Exception:
> STATUS_ACCESS_VIOLATION
>  229623 [main] bash 8384 _cygtls::handle_exceptions: Error while
> dumping state (probably corrupted stack)
>
>
> On Oct 1, 2:17 pm, Mohamed Mansour  wrote:
> > Windows 7 64bit works fine here (using the default settings from
> > dev.chromium.org)  Make sure you have access to the folder your writing
> to.
> > Some folders require admin mode.
> >  -Mohamed
> >
> >
> >
> > On Thu, Oct 1, 2009 at 4:10 PM, vha14  wrote:
> >
> > > Detailed error message:
> >
> > > 1>-- Build started: Project: js2c, Configuration: Debug Win32
> > > --
> > > 1>js2c
> > > 2>-- Build started: Project: cygwin, Configuration: Debug Win32
> > > --
> > > 2>setup_mount
> > > 1> 30 [main] bash 8980 _cygtls::handle_exceptions: Exception:
> > > STATUS_ACCESS_VIOLATION
> > > 1>   3645 [main] bash 8980 open_stackdumpfile: Dumping stack trace to
> > > bash.exe.stackdump
> > > 2>The operation completed successfully.
> > > 2>The operation completed successfully.
> > > 1>Project : error PRJ0002 : Error result 35584 returned from 'C:
> > > \Windows\SysWow64\cmd.exe'.
> >
> > > Content of bash.exe.stackdump:
> >
> > > E:\chromium\home\chrome-svn\tarball\chromium\src\chrome>more
> > > bash.exe.stackdump
> > > Exception: STATUS_ACCESS_VIOLATION at eip=0043AE30
> > > eax= ebx= ecx=61106EC8 edx= esi=611021A0
> > > edi=0045A3E0
> > > ebp=0028CBC8 esp=0028C58C program=e:\chromium\home\chrome-svn\tarball
> > > \chromium\s
> > > rc\third_party\cygwin\bin\bash.exe, pid 8296, thread main
> > > cs=0023 ds=002B es=002B fs=0053 gs=002B ss=002B
> > > Stack trace:
> > > Frame Function  Args
> > > 0028CBC8  0043AE30  (0003, 02361C00, 02360090, 772F)
> > > 0028CD68  610060D8  (, 0028CDA0, 61005450, 0028CDA0)
> > > 61005450  61004416  (009C, A02404C7, E8611021, FF48)
> > >  431390 [main] bash 8296 _cygtls::handle_exceptions: Exception:
> > > STATUS_ACCESS_VI
> > > OLATION
> > >  509897 [main] bash 8296 _cygtls::handle_exceptions: Error while
> > > dumping state (
> > > probably corrupted stack)
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Has anyone built successfully on Win7 64bit? I am getting bash.exe errors

[Mohamed Mansour]

Windows 7 64bit works fine here (using the default settings from
dev.chromium.org)  Make sure you have access to the folder your writing to.
Some folders require admin mode.
 -Mohamed


On Thu, Oct 1, 2009 at 4:10 PM, vha14  wrote:

>
> Detailed error message:
>
> 1>-- Build started: Project: js2c, Configuration: Debug Win32
> --
> 1>js2c
> 2>-- Build started: Project: cygwin, Configuration: Debug Win32
> --
> 2>setup_mount
> 1> 30 [main] bash 8980 _cygtls::handle_exceptions: Exception:
> STATUS_ACCESS_VIOLATION
> 1>   3645 [main] bash 8980 open_stackdumpfile: Dumping stack trace to
> bash.exe.stackdump
> 2>The operation completed successfully.
> 2>The operation completed successfully.
> 1>Project : error PRJ0002 : Error result 35584 returned from 'C:
> \Windows\SysWow64\cmd.exe'.
>
> Content of bash.exe.stackdump:
>
> E:\chromium\home\chrome-svn\tarball\chromium\src\chrome>more
> bash.exe.stackdump
> Exception: STATUS_ACCESS_VIOLATION at eip=0043AE30
> eax= ebx= ecx=61106EC8 edx= esi=611021A0
> edi=0045A3E0
> ebp=0028CBC8 esp=0028C58C program=e:\chromium\home\chrome-svn\tarball
> \chromium\s
> rc\third_party\cygwin\bin\bash.exe, pid 8296, thread main
> cs=0023 ds=002B es=002B fs=0053 gs=002B ss=002B
> Stack trace:
> Frame Function  Args
> 0028CBC8  0043AE30  (0003, 02361C00, 02360090, 772F)
> 0028CD68  610060D8  (, 0028CDA0, 61005450, 0028CDA0)
> 61005450  61004416  (009C, A02404C7, E8611021, FF48)
>  431390 [main] bash 8296 _cygtls::handle_exceptions: Exception:
> STATUS_ACCESS_VI
> OLATION
>  509897 [main] bash 8296 _cygtls::handle_exceptions: Error while
> dumping state (
> probably corrupted stack)
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Chrome Keyboard Access, opinions?

[Mohamed Mansour]

Thanks for all the suggestions, I will try to work on it this weekend.
 -Mohamed


On Tue, Sep 29, 2009 at 8:42 PM, Jonas Klink (Google) wrote:

> From an accessibility point-of-view, I'd prefer having the first widget in
> each toolbar focused when the toolbar itself gains focus (including
> hottracked and displaying any tooltip that is displayed on mouseover of this
> widget).
>
>
> On Tue, Sep 29, 2009 at 5:28 PM, Mohamed Mansour  wrote:
>
>> What would differentiate which toolbar is currently focused? Would it be
>> ideal to assume the first widget in that toolbar would be focused
>> (hotkeyed), or we would draw some sort of ring around the whole toolbar?
>>  -Mohamed
>>
>>
>>
>> On Tue, Sep 29, 2009 at 8:03 PM, Jonas Klink (Google) > > wrote:
>>
>>> So, to clarify, we would then use ALT+SHIFT+T (currently focusing the
>>> toolbar), to cycle keyboard focus through any open toolbars
>>> (toolbar->bookmark bar->infobar (restore tabs etc, if visible)->Extensions
>>> toolstrips). Does that makes sense to everyone? The shortcut is not ideal,
>>> but it might be the best we've got...
>>>
>>>
>>> On Tue, Sep 29, 2009 at 4:26 PM, Scott Violet  wrote:
>>>
>>>> I would just use the existing accelerator we have to focus the toolbar.
>>>>
>>>>  -Scott
>>>>
>>>> On Tue, Sep 29, 2009 at 3:58 PM, Mohamed Mansour 
>>>> wrote:
>>>> > What kind of accelerators do would you like to have? Maybe have
>>>> > a accelerator that traverses only toolbars, and once we are in that
>>>> toolbar,
>>>> > we can tab through the widgets.
>>>> >  -Mohamed
>>>> >
>>>> >
>>>> > On Tue, Sep 29, 2009 at 1:30 PM, Peter Kasting 
>>>> wrote:
>>>> >>
>>>> >> On Tue, Sep 29, 2009 at 10:25 AM, Scott Violet 
>>>> wrote:
>>>> >>>
>>>> >>> On Tue, Sep 29, 2009 at 10:16 AM, Peter Kasting <
>>>> pkast...@google.com>
>>>> >>> wrote:> It seems like when these bars are open, their contents
>>>> should be in
>>>> >>> the tab
>>>> >>> > order.  You should be able to tab through the contents of a page,
>>>> into
>>>> >>> > the
>>>> >>> > chrome, and eventually back into the page.
>>>> >>>
>>>> >>> I don't think most folks want tab from the omnibox to take you
>>>> through
>>>> >>> the menus, then bookmark buttons. I know that would drive me batty.
>>>> I
>>>> >>> could see some users wanting it, but I don't think it should be the
>>>> >>> default.
>>>> >>
>>>> >> I admit that I totally failed to think through "tab in the omnibox"
>>>> -- I
>>>> >> was thinking about all the other cases.
>>>> >> That said, we've had TONS of requests to make tab from the omnibox
>>>> work
>>>> >> differently (i.e. "like how other browsers do it"):
>>>> >> * When the popup is open, tab rotates through its items
>>>> >> * Otherwise, tab moves to the next focusable element
>>>> >> I kind of regret that we picked tab for "tab to search" because it
>>>> >> prevents both of these, and I'm not sure we can change it now.  It
>>>> does seem
>>>> >> like a bug somehow that you can tab into the omnibox but not out, but
>>>> I
>>>> >> don't know how to fix :(
>>>> >>>
>>>> >>> Perhaps we
>>>> >>> also need the ability to assign accelerators to individual
>>>> >>> bookmarks/extensions.
>>>> >>
>>>> >> This has been requested a few times, and brakowski suggested it long
>>>> ago
>>>> >> as a replacement for the "home" button -- if you can drag a bookmark
>>>> onto
>>>> >> your main toolbar, and give it an alt-home shortcut, then you have
>>>> your own
>>>> >> "home" button.
>>>> >> PK
>>>> >
>>>>
>>>
>>>
>>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Kiosk Mode for Chrome

[Mohamed Mansour]

How about in kiosk mode, we only hide the "status bubble", control the
command dispatchers, and we leave the context menu as it is. That will solve
most of the issues and not complicate things.

Windows defined it pretty simple, http://support.microsoft.com/kb/154780,
they can open new windows, tabs, close, etc. I believe it is a correct way
to follow, its not illegal or anything to follow something that is good and
working. And it will make the patch easy and simple.

 -Mohamed


On Tue, Sep 29, 2009 at 8:27 PM, Marc-Antoine Ruel wrote:

> I think I'm right to say that a lot of the "knobs" stated by Mohamed
> can be achieved with content script. Everything that can be done with
> javascript for this particular use case should be done as javascript.
> For example, destroying the window.print prototype.
>
> I think you try to block to many things. For example, quitting the
> browser is probably a no-op, the script managing the browser life-time
> it should just restart it. It would be required anyway in case of a
> browser crash.
>
> Tabs aren't a big deal either. Can you can hook into tabs with
> extensions but I don't know if you can block their creation though.
>
> If this could be done with almost only pure javascript (in addition to
> --fullscreen or --app), that would be awesome, especially unit test
> wise.
>
> M-A
>
> On Tue, Sep 29, 2009 at 7:45 PM, Jacob Mandelson 
> wrote:
> >
> > On Tue, Sep 29, 2009 at 04:37:46PM -0700, Jeremy Orlow wrote:
> >> On Tue, Sep 29, 2009 at 4:20 PM, Brett Wilson 
> wrote:
> >> > On Tue, Sep 29, 2009 at 4:15 PM, Jeremy Orlow 
> wrote:
> >> > > I'm guessing different people/companies will have different needs
> for a
> >> > > kiosk mode.
> >> > > Maybe all of these should be separate flags rather than one "kiosk"
> flag?
> >> > >  We could then offer recommendations in a "Chromium for kiosks" Wiki
> >> > page?
> >> >
> >> > I think the reasoning for allowing this feature is that some minority
> >> > would find it helpful and it wouldn't hurt much. I'm concerned that it
> >> > is getting much too complicated. I think we shouldn't do it if it is
> >> > going to be this complicated.
> >> >
> >>
> >> Would multiple command line flags rather than one really complicate the
> >> design?  Mohamed's original patch was just a bunch of if statements
> keying
> >> off of one flag.  Seems like the same amount of work to have each if
> >> statement key off of a different one.  Or am I missing something?
> >
> > If nothing else, it grows the configuration space.
> > Supporting a kiosk mode seems like a good idea.
> > Supporting 2^N different flavors of kiosk mode sounds dicier.
> >
> > -- Jacob
> >
> > > >
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Chrome Keyboard Access, opinions?

[Mohamed Mansour]

What would differentiate which toolbar is currently focused? Would it be
ideal to assume the first widget in that toolbar would be focused
(hotkeyed), or we would draw some sort of ring around the whole toolbar?
 -Mohamed


On Tue, Sep 29, 2009 at 8:03 PM, Jonas Klink (Google) wrote:

> So, to clarify, we would then use ALT+SHIFT+T (currently focusing the
> toolbar), to cycle keyboard focus through any open toolbars
> (toolbar->bookmark bar->infobar (restore tabs etc, if visible)->Extensions
> toolstrips). Does that makes sense to everyone? The shortcut is not ideal,
> but it might be the best we've got...
>
>
> On Tue, Sep 29, 2009 at 4:26 PM, Scott Violet  wrote:
>
>> I would just use the existing accelerator we have to focus the toolbar.
>>
>>  -Scott
>>
>> On Tue, Sep 29, 2009 at 3:58 PM, Mohamed Mansour 
>> wrote:
>> > What kind of accelerators do would you like to have? Maybe have
>> > a accelerator that traverses only toolbars, and once we are in that
>> toolbar,
>> > we can tab through the widgets.
>> >  -Mohamed
>> >
>> >
>> > On Tue, Sep 29, 2009 at 1:30 PM, Peter Kasting 
>> wrote:
>> >>
>> >> On Tue, Sep 29, 2009 at 10:25 AM, Scott Violet 
>> wrote:
>> >>>
>> >>> On Tue, Sep 29, 2009 at 10:16 AM, Peter Kasting 
>> >>> wrote:> It seems like when these bars are open, their contents should
>> be in
>> >>> the tab
>> >>> > order.  You should be able to tab through the contents of a page,
>> into
>> >>> > the
>> >>> > chrome, and eventually back into the page.
>> >>>
>> >>> I don't think most folks want tab from the omnibox to take you through
>> >>> the menus, then bookmark buttons. I know that would drive me batty. I
>> >>> could see some users wanting it, but I don't think it should be the
>> >>> default.
>> >>
>> >> I admit that I totally failed to think through "tab in the omnibox" --
>> I
>> >> was thinking about all the other cases.
>> >> That said, we've had TONS of requests to make tab from the omnibox work
>> >> differently (i.e. "like how other browsers do it"):
>> >> * When the popup is open, tab rotates through its items
>> >> * Otherwise, tab moves to the next focusable element
>> >> I kind of regret that we picked tab for "tab to search" because it
>> >> prevents both of these, and I'm not sure we can change it now.  It does
>> seem
>> >> like a bug somehow that you can tab into the omnibox but not out, but I
>> >> don't know how to fix :(
>> >>>
>> >>> Perhaps we
>> >>> also need the ability to assign accelerators to individual
>> >>> bookmarks/extensions.
>> >>
>> >> This has been requested a few times, and brakowski suggested it long
>> ago
>> >> as a replacement for the "home" button -- if you can drag a bookmark
>> onto
>> >> your main toolbar, and give it an alt-home shortcut, then you have your
>> own
>> >> "home" button.
>> >> PK
>> >
>>
>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Kiosk Mode for Chrome

[Mohamed Mansour]

Peter is giving excellent comments, and he raised an important question
regarding what makes me decide what gets blocked. I have some questions to
ask the group and others who are interested.
What would you want Kiosk to block?  I am currently trying to block the
following areas:
- Save page (should I block this)
- Open new page
- Open tabs
- Open Incognito windows
- Print page (should I block this)
- Browser Exits (except ALT+F4)
- Copy Links/Images (should I block this)
- Status bar
- Fullscreen popup
- Popups (should I block this)

Any comments regarding the above?

 -Mohamed


On Fri, Sep 25, 2009 at 1:51 PM, Jeremy Orlow  wrote:

> No objections.
> I think it's a good idea, you're not the only one who wants this, and it
> seems like it can be done very cleanly.
>
>
> On Fri, Sep 25, 2009 at 10:47 AM, Adam Barth  wrote:
>
>> On Fri, Sep 25, 2009 at 10:43 AM, Mohamed Mansour 
>> wrote:
>> > I could submit a cleaner patch (which does it right) that introduces
>> Kiosk
>> > mode for Chrome. Are there any objections?
>>
>> None from me.  :)
>>
>> Adam
>>
>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Chrome Keyboard Access, opinions?

[Mohamed Mansour]

What kind of accelerators do would you like to have? Maybe have
a accelerator that traverses only toolbars, and once we are in that toolbar,
we can tab through the widgets.
 -Mohamed


On Tue, Sep 29, 2009 at 1:30 PM, Peter Kasting  wrote:

> On Tue, Sep 29, 2009 at 10:25 AM, Scott Violet  wrote:
>
>> On Tue, Sep 29, 2009 at 10:16 AM, Peter Kasting 
>> wrote:> It seems like when these bars are open, their contents should be in
>> the tab
>>  > order.  You should be able to tab through the contents of a page, into
>> the
>> > chrome, and eventually back into the page.
>>
>> I don't think most folks want tab from the omnibox to take you through
>> the menus, then bookmark buttons. I know that would drive me batty. I
>> could see some users wanting it, but I don't think it should be the
>> default.
>>
>
> I admit that I totally failed to think through "tab in the omnibox" -- I
> was thinking about all the other cases.
>
> That said, we've had TONS of requests to make tab from the omnibox work
> differently (i.e. "like how other browsers do it"):
> * When the popup is open, tab rotates through its items
> * Otherwise, tab moves to the next focusable element
>
> I kind of regret that we picked tab for "tab to search" because it prevents
> both of these, and I'm not sure we can change it now.  It does seem like a
> bug somehow that you can tab into the omnibox but not out, but I don't know
> how to fix :(
>
> Perhaps we
>> also need the ability to assign accelerators to individual
>> bookmarks/extensions.
>
>
> This has been requested a few times, and brakowski suggested it long ago as
> a replacement for the "home" button -- if you can drag a bookmark onto your
> main toolbar, and give it an alt-home shortcut, then you have your own
> "home" button.
>
> PK
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Chrome Keyboard Access, opinions?

[Mohamed Mansour]

I agree with James, ALT keys should be only used for accessibility, if we
want to be able to allow keyboard shortcuts to other toolbars, we need to
reorganize our current ones. It would be nice to have the following
combinations:
CTRL+SHIFT+T  --- Main Toolbar
CTRL+SHIFT+B --- Main Bookmarks bar
CTRL+SHIFT+E --- Extension bar

I wish we could use shorter `shortcuts`.  I am working with Mr Klink trying
to improve the keyboard shortcuts and accessibility within Chrome, and
currently Chrome is disabling keyboard users accessing other tool bars,
which is a problem.

Any suggestions is highly appreciated.

 -Mohamed


On Sat, Sep 26, 2009 at 9:00 PM, James Su  wrote:

>
>
> 2009/9/26 Jacob Mandelson 
>
>
>> On Sat, Sep 26, 2009 at 11:40:07AM -0400, Mohamed Mansour wrote:
>> > Hi all, (need UI team feedback and other keyboard guru's)
>> > We need a more coherent story for accessing various toolbars. The
>> current
>> > toolbars that exist right now are:
>> >
>> >- Toolbar
>> >- Bookmark bar
>> >- Extension bar
>> >- More in the future
>> >
>> > Currently ALT + SHIFT + T brings your focus to the toolbar, but there is
>> no
>> > way to get to the others. This blocks keyboard users accessing the other
>> > bars which is kind of annoying if your a keyboard user. According to
>> Jonas
>> > Klink (Accessibility guru) he said that shortcut was only a temporary
>> > solution and would like to get rid of it and replace it with something
>> more
>> > generic. So we need to think of a uniform access solution to all these
>> > toolbars.
>> [...]
>>
>> Maybe we could treat them akin to menus, and have Alt-SomeLetter go move
>> the active focus to the bar?
>> Alt-T and Alt-B seem unbound, but Alt-E (and not Alt-D) opens the Document
>> menu.  Alt-F opens the Wrench menu.
>>
> Can we use some other key bindings rather than Alt- something? Alt is used
> for activating accesskeys and already caused conflicts between some
> accelerators. See http://crbug.com/21624.
>
>
>> -- Jacob
>>
>> >>
>>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Error in using gclient

[Mohamed Mansour]

Hello, try running this command (from an Administrator command
prompt): netsh
interface tcp set global autotuninglevel=disabled

See if that works for you, then run gclient sync --force again.

 -Mohamed


On Sat, Sep 26, 2009 at 3:58 PM, Manni  wrote:

>
> Hi,
> I am trying to download the chrome source code. I have installed VS
> 2008 and Microsoft SDK. Later I downloaded the tarball and
> depot_tools. I updated the path with depot_tools too.
> But when i run command on vista -Sp2 it gives this error.
>
> C:\chromiumtrunk\home\chrome-svn\tarball\chromium\src\chrome>gclient
> runhooks --
> force
> Installing subversion ...
> [-] XMLHTTP 80072ee2: Cannot make HTTP request (The operation timed
> out
>
> ... Failed to checkout svn automatically.
> Please visit http://subversion.tigris.org to download the latest
> subversion clie
> nt
> before continuing.
> You can also get the "prebacked" version used at
> http://src.chromium.org/svn/tru
> nk/tools/third_party/
>
> I then downloaded tigris subversion and prebacked version too. But
> stil have to same problem.
> Can anyone help in getting started with the development?
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Chrome Keyboard Access, opinions?

[Mohamed Mansour]

Hi all, (need UI team feedback and other keyboard guru's)
We need a more coherent story for accessing various toolbars. The current
toolbars that exist right now are:

   - Toolbar
   - Bookmark bar
   - Extension bar
   - More in the future

Currently ALT + SHIFT + T brings your focus to the toolbar, but there is no
way to get to the others. This blocks keyboard users accessing the other
bars which is kind of annoying if your a keyboard user. According to Jonas
Klink (Accessibility guru) he said that shortcut was only a temporary
solution and would like to get rid of it and replace it with something more
generic. So we need to think of a uniform access solution to all these
toolbars.

In the meantime we could "partially" solve this. We have some
toggling features (collapse, and expand) for the bookmarks bar (CTRL + B),
and the extension bar (CTRL + ALT + B). Once we expand those bars, we can
apply focus to the first item. Similar to what we do with ALT + SHIFT + T
for the toolbar, and then use the arrow keys to traverse the bar, one item
after the other. Once that is implemented, that will allow keyboard users to
access chrome "partially". There are some problems though, what would we do
if we collapse? Maybe bring back the focus to the Renderer.

I would like to hear your opinions, if you have any, regarding uniform
toolbar access solution using a keyboard. We really want to get rid of ALT +
SHIFT + T, but we need to figure out a more elegant way to access all
toolbars. I would like your opinions on our partial solution, I think that
will give opportunity for keyboard users to access their toolbars quickly.
But can we assume whenever a user presses CTRL+B they want focus to the
bookmarks bar? I could safely assume so, but how about you all?

 -Mohamed

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: SVN hangs updating third_party/WebKit

[Mohamed Mansour]

Thanks! That worked for me on "Windows 7 64bit"!
 -Mohamed


On Fri, Sep 25, 2009 at 8:39 PM, David Levin  wrote:

> For windows (vista 64bit?), if you hit gclient hangs in general while
> sync'ing:
>
> Run this command (from an Administrator command prompt): netsh
> interface tcp set global autotuninglevel=disabled
>
> Hopefully, it will be fixed for you as it seems to be for me.
>
> Reference:
> http://blogs.technet.com/asiasupp/archive/2006/12/14/windows-vista-tcp-auto-tuning.aspx
>
> 
>
> 
>
> On Fri, Sep 25, 2009 at 5:22 PM, Nico Weber  wrote:
>
>>
>>
>> http://groups.google.com/group/chromium-dev/browse_thread/thread/64a19a5f78db8fba
>>
>> I had the impression that removing that folder once is enough, though
>> I didn't try it more than once yet.
>>
>> On Fri, Sep 25, 2009 at 5:18 PM, Finnur Thorarinsson
>>  wrote:
>> > At first I thought it was a fluke but now it just happened again. Is
>> anyone
>> > else seeing this?
>> > I do a gclient sync and it takes forever, showing this output and looks
>> > hung:
>> >
>> >  running 'svn update E:\code\src\third_party\WebKit --revision
>> > 27219' in
>> >  'E:\code'
>> > I wait and wait and wait and wait and nothing happens. I tried FileMon
>> and
>> > couldn't see any files being accessed. Re-running gclient sync just
>> hangs
>> > again in the same spot.
>> > The only workaround I know is to delete that folder and try again. That
>> was
>> > fine for the first time this happens, but is getting more exponentially
>> more
>> > frustrating with each time I have to do that. :s
>> > Anyone seen this?
>> > -F
>> > >
>> >
>>
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Kiosk Mode for Chrome

[Mohamed Mansour]

Hi Jeremy, ChromeFrame doesn't seem to work if you pass the URL in command
line for Internet Explorer. A simple example is visiting this page directly
(assuming you installed ChromeFrame)

   1. Open Internet Explorer
   2. Visit this http://haptisense.com/
   3. You will see the correct "After Browser" which is Chrome and "Original
   Browser" which is IE.

Now do this:

   1. cd "C:\Program Files\Internet Explorer"
   2. Type:  iexplorer.exe http://haptisense.com
   3. You will see the correct "Original Browser" but the "After Browser" is
   still IE (you can notice the Chrome renderer isn't replaced because there is
   IE right click and rendering is obviously IE)

Same thing happens to iexplorer.exe -k http://haptisense.com

The patch I submitted, does what I wanted to do for demo purposes, I
contribute to Chrome because I love everything about this browser, and
seeing the usage of IE in my day job is quite annoying (since our GIS web
apps are plotting horribly slow in comparison to Chrome if given a lot of
data).

I could submit a cleaner patch (which does it right) that introduces Kiosk
mode for Chrome. Are there any *objections*?

 -Mohamed


On Fri, Sep 25, 2009 at 12:51 PM, Jeremy Orlow  wrote:

> On Fri, Sep 25, 2009 at 5:30 AM, Mohamed Mansour  wrote:
>
>> I tried ChromeFrame it is very good, but it doesn't work if the Kiosk Mode
>> flag is set. If the Kiosk mode is set ( iexplorer.exe -k
>> http://www.google.com ) it renders it as IE Renderer. It renders it fine
>> in a Chrome Frame if its not in Kiosk mode. That must be a bug :)
>
>
> wait, did you do '... -k cf:http://www.google.com'?  (Or does the Google
> home page use Chrome Frame?)
>
> (Not that I'm saying this is the right route.  It sounds like a command
> line flag for Chrome might be the best way to go!)
>
> For IE, kiosk mode has a context menu, but people usually apply the
>> registry tweak to remove context menu from IE if they need to.
>>
>> For Chromium, it would be nice if stuff like this would be an extension,
>> an extension should allow us to show/hide various parts of the UI. In the
>> meantime, I quickly compiled a custom Chromium so that my CEO and VP could
>> see the benefits of using Chrome instead of IE on some of our web products.
>>
>> Stuff that would be cool and would be very lightweight to include for
>> kiosk mode would be:
>> - No Status Bar- Full Screen (with no exit, only alt+f4 should work)
>> - No Context Menus (should be an option)
>> - Disable downloading of files.
>> - No tabs
>> - No opening files
>> - many more
>>
>> I would rather that be an extension (but there are currently no way to
>> actually block users to remove extensions, maybe blocking users entering a
>> url would suffice) but not possible currently.
>>
>>  -Mohamed
>>
>>
>>
>> On Fri, Sep 25, 2009 at 1:52 AM, Amit Joshi  wrote:
>>
>>>
>>>
>>> On Thu, Sep 24, 2009 at 10:47 PM, Darin Fisher wrote:
>>>
>>>> Chrome Frame is a good option, but you'd still need a way to turn off
>>>> some features.  For example, a kiosk probably doesn't want to have a 
>>>> context
>>>> menu.
>>>
>>>
>>> Chrome Frame can/will offer control over the context menu. This is
>>> exactly the kind of customization Chrome Frame can offer. Too bad we don't
>>> have Linux, Mac versions yet, but we are open source now so patches welcome
>>> :)
>>>
>>>
>>>> -Darin
>>>>
>>>>
>>>> On Thu, Sep 24, 2009 at 10:24 PM, Amit Joshi  wrote:
>>>>
>>>>> I think you should really consider embedding chrome frame ActiveX in
>>>>> your own simple shell. That will not only enable the application to be
>>>>> started with desired real estate and get rid of status bubble but allow 
>>>>> you
>>>>> to customize it further if needed.
>>>>>
>>>>> On Thu, Sep 24, 2009 at 10:07 PM, Darin Fisher wrote:
>>>>>
>>>>>>
>>>>>> On Thu, Sep 24, 2009 at 11:37 AM, Mohamed Mansour 
>>>>>> wrote:
>>>>>>
>>>>>>> At work today, I talked to the CEO of my company to ship Chrome
>>>>>>> browser with all our Kiosk's and recommended Chrome to be our default
>>>>>>> browser for our web products. I bench marked our current web 
>>>>>>> applications
>>>>>>> with Chrome (ToT) vs IE 7, and our applications run at

[chromium-dev] Re: Kiosk Mode for Chrome

[Mohamed Mansour]

Something as simple as this:http://codereview.chromium.org/244003

<http://codereview.chromium.org/244003>Not necessarily clean, but this
thread is whether we would want to implement Kiosk mode in Chromium. That
will help many companies to use Chromium as their solution for hosting their
web products.

 -Mohamed


On Fri, Sep 25, 2009 at 8:47 AM, PhistucK  wrote:

> What are the major issues?Full screen with no escape hatch and no status
> bubble?
> Chrome developers already said the are willing to take care of those\accept
> patches for those.
> The rest are taken care of with disabling keyboard shortcuts, or am I
> wrong?
>
> ☆PhistucK
>
>
>
> On Fri, Sep 25, 2009 at 15:44, Mohamed Mansour  wrote:
>
>> The minor issues, yes, the major issues, no.
>>  -Mohamed
>>
>>
>>
>> On Fri, Sep 25, 2009 at 8:40 AM, PhistucK  wrote:
>>
>>> You can create a content script that will disable the shortcut keys of
>>> the browser and the right clicks, on all of the pages.About browsing to
>>> other pages (and so, downloading), you can apply a rule within a content
>>> script to always navigate to the home page of what you need, when going to
>>> any other URL.
>>> That would solve most of the issues you have in that list.
>>>
>>> ☆PhistucK
>>>
>>>
>>>
>>> On Fri, Sep 25, 2009 at 15:30, Mohamed Mansour  wrote:
>>>
>>>> I tried ChromeFrame it is very good, but it doesn't work if the Kiosk
>>>> Mode flag is set. If the Kiosk mode is set ( iexplorer.exe -k
>>>> http://www.google.com ) it renders it as IE Renderer. It renders it
>>>> fine in a Chrome Frame if its not in Kiosk mode. That must be a bug :)
>>>> For IE, kiosk mode has a context menu, but people usually apply the
>>>> registry tweak to remove context menu from IE if they need to.
>>>>
>>>> For Chromium, it would be nice if stuff like this would be an extension,
>>>> an extension should allow us to show/hide various parts of the UI. In the
>>>> meantime, I quickly compiled a custom Chromium so that my CEO and VP could
>>>> see the benefits of using Chrome instead of IE on some of our web products.
>>>>
>>>> Stuff that would be cool and would be very lightweight to include for
>>>> kiosk mode would be:
>>>> - No Status Bar- Full Screen (with no exit, only alt+f4 should work)
>>>> - No Context Menus (should be an option)
>>>> - Disable downloading of files.
>>>> - No tabs
>>>> - No opening files
>>>> - many more
>>>>
>>>> I would rather that be an extension (but there are currently no way to
>>>> actually block users to remove extensions, maybe blocking users entering a
>>>> url would suffice) but not possible currently.
>>>>
>>>>  -Mohamed
>>>>
>>>>
>>>>
>>>> On Fri, Sep 25, 2009 at 1:52 AM, Amit Joshi  wrote:
>>>>
>>>>>
>>>>>
>>>>> On Thu, Sep 24, 2009 at 10:47 PM, Darin Fisher wrote:
>>>>>
>>>>>> Chrome Frame is a good option, but you'd still need a way to turn off
>>>>>> some features.  For example, a kiosk probably doesn't want to have a 
>>>>>> context
>>>>>> menu.
>>>>>
>>>>>
>>>>> Chrome Frame can/will offer control over the context menu. This is
>>>>> exactly the kind of customization Chrome Frame can offer. Too bad we don't
>>>>> have Linux, Mac versions yet, but we are open source now so patches 
>>>>> welcome
>>>>> :)
>>>>>
>>>>>
>>>>>> -Darin
>>>>>>
>>>>>>
>>>>>> On Thu, Sep 24, 2009 at 10:24 PM, Amit Joshi wrote:
>>>>>>
>>>>>>> I think you should really consider embedding chrome frame ActiveX in
>>>>>>> your own simple shell. That will not only enable the application to be
>>>>>>> started with desired real estate and get rid of status bubble but allow 
>>>>>>> you
>>>>>>> to customize it further if needed.
>>>>>>>
>>>>>>> On Thu, Sep 24, 2009 at 10:07 PM, Darin Fisher 
>>>>>>> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, Sep 24, 2009 at 11:37 AM, Mohamed Mansour >>>>>&g

[chromium-dev] Re: Kiosk Mode for Chrome

[Mohamed Mansour]

The minor issues, yes, the major issues, no.
 -Mohamed


On Fri, Sep 25, 2009 at 8:40 AM, PhistucK  wrote:

> You can create a content script that will disable the shortcut keys of the
> browser and the right clicks, on all of the pages.About browsing to other
> pages (and so, downloading), you can apply a rule within a content script to
> always navigate to the home page of what you need, when going to any other
> URL.
> That would solve most of the issues you have in that list.
>
> ☆PhistucK
>
>
>
> On Fri, Sep 25, 2009 at 15:30, Mohamed Mansour  wrote:
>
>> I tried ChromeFrame it is very good, but it doesn't work if the Kiosk Mode
>> flag is set. If the Kiosk mode is set ( iexplorer.exe -k
>> http://www.google.com ) it renders it as IE Renderer. It renders it fine
>> in a Chrome Frame if its not in Kiosk mode. That must be a bug :)
>> For IE, kiosk mode has a context menu, but people usually apply the
>> registry tweak to remove context menu from IE if they need to.
>>
>> For Chromium, it would be nice if stuff like this would be an extension,
>> an extension should allow us to show/hide various parts of the UI. In the
>> meantime, I quickly compiled a custom Chromium so that my CEO and VP could
>> see the benefits of using Chrome instead of IE on some of our web products.
>>
>> Stuff that would be cool and would be very lightweight to include for
>> kiosk mode would be:
>> - No Status Bar- Full Screen (with no exit, only alt+f4 should work)
>> - No Context Menus (should be an option)
>> - Disable downloading of files.
>> - No tabs
>> - No opening files
>> - many more
>>
>> I would rather that be an extension (but there are currently no way to
>> actually block users to remove extensions, maybe blocking users entering a
>> url would suffice) but not possible currently.
>>
>>  -Mohamed
>>
>>
>>
>> On Fri, Sep 25, 2009 at 1:52 AM, Amit Joshi  wrote:
>>
>>>
>>>
>>> On Thu, Sep 24, 2009 at 10:47 PM, Darin Fisher wrote:
>>>
>>>> Chrome Frame is a good option, but you'd still need a way to turn off
>>>> some features.  For example, a kiosk probably doesn't want to have a 
>>>> context
>>>> menu.
>>>
>>>
>>> Chrome Frame can/will offer control over the context menu. This is
>>> exactly the kind of customization Chrome Frame can offer. Too bad we don't
>>> have Linux, Mac versions yet, but we are open source now so patches welcome
>>> :)
>>>
>>>
>>>> -Darin
>>>>
>>>>
>>>> On Thu, Sep 24, 2009 at 10:24 PM, Amit Joshi  wrote:
>>>>
>>>>> I think you should really consider embedding chrome frame ActiveX in
>>>>> your own simple shell. That will not only enable the application to be
>>>>> started with desired real estate and get rid of status bubble but allow 
>>>>> you
>>>>> to customize it further if needed.
>>>>>
>>>>> On Thu, Sep 24, 2009 at 10:07 PM, Darin Fisher wrote:
>>>>>
>>>>>>
>>>>>> On Thu, Sep 24, 2009 at 11:37 AM, Mohamed Mansour 
>>>>>> wrote:
>>>>>>
>>>>>>> At work today, I talked to the CEO of my company to ship Chrome
>>>>>>> browser with all our Kiosk's and recommended Chrome to be our default
>>>>>>> browser for our web products. I bench marked our current web 
>>>>>>> applications
>>>>>>> with Chrome (ToT) vs IE 7, and our applications run at average 10 times
>>>>>>> faster. (For windows, Mac speed differed)
>>>>>>> There are some stuff that he didn't like:
>>>>>>>
>>>>>>>1. Status Bubble: for a cashiering application, it keeps popping
>>>>>>>up every second since buttons are all over the place. It was 
>>>>>>> distracting him
>>>>>>>from the main product.
>>>>>>>2. Full screen mode "always" => Kiosk Mode. He wants the web app
>>>>>>>to stay full screen, in IE, there is kiosk mode command line switch. 
>>>>>>> In FF
>>>>>>>there is a plugin.
>>>>>>>3. JavaScript errors kept appearing intermittently (on the Mac),
>>>>>>>would work on initial deploy but require a "Clear browsing data" on
>>>>>>>

[chromium-dev] Re: Kiosk Mode for Chrome

[Mohamed Mansour]

I tried ChromeFrame it is very good, but it doesn't work if the Kiosk Mode
flag is set. If the Kiosk mode is set ( iexplorer.exe -k
http://www.google.com ) it renders it as IE Renderer. It renders it fine in
a Chrome Frame if its not in Kiosk mode. That must be a bug :)
For IE, kiosk mode has a context menu, but people usually apply the registry
tweak to remove context menu from IE if they need to.

For Chromium, it would be nice if stuff like this would be an extension, an
extension should allow us to show/hide various parts of the UI. In the
meantime, I quickly compiled a custom Chromium so that my CEO and VP could
see the benefits of using Chrome instead of IE on some of our web products.

Stuff that would be cool and would be very lightweight to include for kiosk
mode would be:
- No Status Bar- Full Screen (with no exit, only alt+f4 should work)
- No Context Menus (should be an option)
- Disable downloading of files.
- No tabs
- No opening files
- many more

I would rather that be an extension (but there are currently no way to
actually block users to remove extensions, maybe blocking users entering a
url would suffice) but not possible currently.

 -Mohamed


On Fri, Sep 25, 2009 at 1:52 AM, Amit Joshi  wrote:

>
>
> On Thu, Sep 24, 2009 at 10:47 PM, Darin Fisher  wrote:
>
>> Chrome Frame is a good option, but you'd still need a way to turn off some
>> features.  For example, a kiosk probably doesn't want to have a context
>> menu.
>
>
> Chrome Frame can/will offer control over the context menu. This is exactly
> the kind of customization Chrome Frame can offer. Too bad we don't have
> Linux, Mac versions yet, but we are open source now so patches welcome :)
>
>
>> -Darin
>>
>>
>> On Thu, Sep 24, 2009 at 10:24 PM, Amit Joshi  wrote:
>>
>>> I think you should really consider embedding chrome frame ActiveX in your
>>> own simple shell. That will not only enable the application to be started
>>> with desired real estate and get rid of status bubble but allow you to
>>> customize it further if needed.
>>>
>>> On Thu, Sep 24, 2009 at 10:07 PM, Darin Fisher wrote:
>>>
>>>>
>>>> On Thu, Sep 24, 2009 at 11:37 AM, Mohamed Mansour wrote:
>>>>
>>>>> At work today, I talked to the CEO of my company to ship Chrome browser
>>>>> with all our Kiosk's and recommended Chrome to be our default browser for
>>>>> our web products. I bench marked our current web applications with Chrome
>>>>> (ToT) vs IE 7, and our applications run at average 10 times faster. (For
>>>>> windows, Mac speed differed)
>>>>> There are some stuff that he didn't like:
>>>>>
>>>>>1. Status Bubble: for a cashiering application, it keeps popping up
>>>>>every second since buttons are all over the place. It was distracting 
>>>>> him
>>>>>from the main product.
>>>>>2. Full screen mode "always" => Kiosk Mode. He wants the web app to
>>>>>stay full screen, in IE, there is kiosk mode command line switch. In FF
>>>>>there is a plugin.
>>>>>3. JavaScript errors kept appearing intermittently (on the Mac),
>>>>>would work on initial deploy but require a "Clear browsing data" on
>>>>>subsequent runs. Works great on windows (chrome). I guess we would be 
>>>>> using
>>>>>linux/windows for kiosk anyhow.
>>>>>
>>>>> Will there be plans for us to introduce Kiosk Mode in Chrome? It seems
>>>>> the current audience is just targeted towards home users and there is no 
>>>>> way
>>>>> to use Google Chrome for other usages.
>>>>>
>>>>> Sure we could compile our own Chromium version, but many people (Chrome
>>>>> forums and elsewhere) would like to use Chrome commercially. In the
>>>>> meantime, I am going to compile a version with no status bar, but I 
>>>>> believe
>>>>> it would be nice to include it in future versions.
>>>>>
>>>>> Maybe we could allow extensions to control (hide/show) different areas
>>>>> in chrome.
>>>>>
>>>>>
>>>>
>>>> Maybe I'm in the minority, but it doesn't sound that unreasonable to
>>>> support command line options for disabling the status bubble and starting 
>>>> in
>>>> full screen mode.  We could lump these together into a --kiosk-mode command
>>>> line flag.  This seems like something that could be done in a fairly
>>>> lightweight manner.
>>>>
>>>> Maybe others object?
>>>>
>>>> -Darin
>>>>
>>>> >>>>
>>>>
>>>
>>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Build time doubled since May - what gives?

[Mohamed Mansour]

Hey Ben, same here ... I see this additional message today (havn't seen it
before) 59>LINK : C:\Sandbox\Code\Chrome\src\chrome\Debug\chrome.dll not
found or not built by the last incremental link; performing full link

Changing one file used to take me 5 minutes to build. But now it takes me
~10-15 minutes.

-Mohamed


On Thu, Sep 24, 2009 at 10:06 PM, Ben Goodger (Google) wrote:

>
> I just ran a build here at home on my i7 workstation. It took 14
> minutes. This is the same system that would build in 7 minutes when I
> set it up in May.
>
> What gives? We need to figure this out ASAP.
>
> -Ben
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Kiosk Mode for Chrome

[Mohamed Mansour]

At work today, I talked to the CEO of my company to ship Chrome browser with
all our Kiosk's and recommended Chrome to be our default browser for our web
products. I bench marked our current web applications with Chrome (ToT) vs
IE 7, and our applications run at average 10 times faster. (For windows, Mac
speed differed)
There are some stuff that he didn't like:

   1. Status Bubble: for a cashiering application, it keeps popping up every
   second since buttons are all over the place. It was distracting him from the
   main product.
   2. Full screen mode "always" => Kiosk Mode. He wants the web app to stay
   full screen, in IE, there is kiosk mode command line switch. In FF there is
   a plugin.
   3. JavaScript errors kept appearing intermittently (on the Mac), would
   work on initial deploy but require a "Clear browsing data" on subsequent
   runs. Works great on windows (chrome). I guess we would be using
   linux/windows for kiosk anyhow.

Will there be plans for us to introduce Kiosk Mode in Chrome? It seems the
current audience is just targeted towards home users and there is no way to
use Google Chrome for other usages.

Sure we could compile our own Chromium version, but many people (Chrome
forums and elsewhere) would like to use Chrome commercially. In the
meantime, I am going to compile a version with no status bar, but I believe
it would be nice to include it in future versions.

Maybe we could allow extensions to control (hide/show) different areas in
chrome.

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Question about UI and "classic views"

[Mohamed Mansour]

If you want to use the old new tab page, you can add this chrome
switch ( --old-new-tab-page
)

I personally like the 3x3 grid. I have a 24" screen and the new tab page is
so tiny, would of been nice if the user could fully customize it, that is
one of the popular features people want on the Chrome forums.

- Mohamed Mansour


On Wed, Sep 23, 2009 at 11:59 PM, Mike Belshe  wrote:

> I just got a fairly angry email from my sister about the new tab page UI.
> She writes:
>
>> "What’s up with the Chrome Tab page change?  I thought I screwed up my
>> page at home, but now my page at work has changed too.
>
>  I don’t like it.
>
>  Why do I have to have my tabs arranged 4x2 ? I liked 3x3.
>
>  What happened to the delete tabs?
>
>  Do we get no say in what our page looks like?  Google just gets to make
> the change without so much as a notice, “Your page has changed for the
> worse”.
>
>  Sorry to dump on you  but, it sure is nice thinking that I can gripe to
> someone at a giant company like Google and there actually might be someone
> listening."
>
>
> This is probably a good point; why didn't we offer a "classic view" option
> to users?  It is not like the current new-tab-page is all that radically
> different.  I'm sure we were aware that some users would feel this way?  But
> we think we know better than they do what this page should look like?
>
> BTW - I liked 3x3 better than 4x2 better too.
>
>
> Mike
>
>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: [linux] user feedback one month in

[Mohamed Mansour]

>
> Dislikes:
> - dropdown lists in wordpress admin panel "don't behave well"
> My response: any wordpress user here who can repro this?
>

It is a known regression from the last update. Many people started starring
it! It happens to every drop down list.

http://code.google.com/p/chromium/issues/detail?id=22120


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: I wish IE8 installed as fast as chrome...

[Mohamed Mansour]

Windows 7 has changed. I am really impressed with the Install times in
Windows 7.  You should give it a try :)
- Mohamed


On Sat, Sep 19, 2009 at 11:30 PM, Dan Kegel  wrote:

>
> Oddly, some of the biggest delays in updating my fresh
> vista box (including part of the ie8 delay) were due to
> the update requiring user intervention, but popping
> the user intervention dialog *under* the main update
> progress dialog.  It's luck if the user sees the dialog.
>
> So score one for our install speed, and score another
> for our unattended updates.
>
> On Sat, Sep 19, 2009 at 7:44 PM, Mike Belshe  wrote:
> > That's the advantage of knowing users have a forced path to install your
> > product.  While firefox, safari, opera, and chrome all focus on install
> > speed, Microsoft doesn't.  They know they'll get it on your box under all
> > circumstances.  So they just don't care.  Sad.
> > Think about the man-years (or man-lives) lost waiting for IE8 installs
> > around the world!
> >
> > Mike
> >
> > On Sat, Sep 19, 2009 at 6:48 PM, Dan Kegel  wrote:
> >>
> >> Chrome installs in finite time, whereas (judging by how long my
> >> Vista box has been saying "installing IE8") IE8 seems
> >> to require infinite time to install.
> >>
> >> I don't know how many people actually sit there and
> >> wait for software updates to finish, but lordy,
> >> watching ie8 update is like watching paint dry,
> >> maybe we could do a funny ad on the topic.
> >>
> >> >>
> >
> >
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Need help on how to send data from RenderView to a custom DOMUI instantly

[Mohamed Mansour]

The UI is going to be in JavaScript with callbacks from the DOMUI page same
as NTP, Downloads, History, etc... Therefore in render_view.cc, I need to
 replace the WebFrame with the DOMUI (I think). I don't want to introduce my
own set of methods that exposes this, that is why I am asking for some
thoughts, on the right approach.
How do you recommend making print preview to work? The UI team's mockup was
visioning a domui that handles the print preview/settings. Should we open a
new tab for print preview, or should we use the same tab? In either case,
how can I pass data, in particular the Bitmap image that is created in
RenderView to the DOMUI page so I can view it.

Any help is appreciated.

- Mohamed

On Wed, Sep 16, 2009 at 12:06 AM, Brett Wilson  wrote:

> On Tue, Sep 15, 2009 at 7:31 PM, Mohamed Mansour
>  wrote:
> > Hi all,
> > I am having trouble trying to figure out how I could replace the contents
> of
> > a specific WebFrame while I am in RenderView with a custom DOMUI page
> that I
> > have created.
> > Here is a scenario:
> >
> > User visits http://www.google.com
> > User waits till page is done loading
> > User selects Options > Print Preview
> > The current page will be replaced with a custom PrintPreview DOMUI page
> > (print:http://www.google.com)  where I would be passing some Data such
> as a
> > vector of bytes (image) from RenderView to PrintPreviewDOMUI
> >
> > I have created the DOMUI page and made sure it works, and created the
> bitmap
> > and encoded it with JPEGEncoder, but I am clueless on how the connection
> > would be from RenderView to DOMUI.
> > Any assistance is appreciated. The reason why I want to replace the
> current
> > contents is because print preview depends on what is exactly visible at
> that
> > time. Unless there is a better way.
> > Thanks in advance!
>
> Is the code you're writing in C++ or JS?
>
> Brett
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Need help on how to send data from RenderView to a custom DOMUI instantly

[Mohamed Mansour]

Hi all,

I am having trouble trying to figure out how I could replace the contents of
a specific WebFrame while I am in RenderView with a custom DOMUI page that I
have created.

Here is a scenario:

   1. User visits http://www.google.com
   2. User waits till page is done loading
   3. User selects Options > Print Preview
   4. The current page will be replaced with a custom PrintPreview DOMUI
   page (print:http://www.google.com)  where I would be passing some Data
   such as a vector of bytes (image) from RenderView to PrintPreviewDOMUI

I have created the DOMUI page and made sure it works, and created the bitmap
and encoded it with JPEGEncoder, but I am clueless on how the connection
would be from RenderView to DOMUI.
Any assistance is appreciated. The reason why I want to replace the current
contents is because print preview depends on what is exactly visible at that
time. Unless there is a better way.

Thanks in advance!

- Mohamed Mansour

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Removal of the Chrome window snap in Windows 7

[Mohamed Mansour]

Hi all,
Since Windows 7 implemented system specific window snap (in many
directions), what do you all think about removing it in Chrome for Windows 7
builds?

Or are we planning to keep both snaps in Windows 7?

- Mohamed

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Chromium core principles and multiplatform development?

[Mohamed Mansour]

Yea that already exists for "gcl" I don't know for "git-cl".

In a perfect world, I think we could do better, we should refactor the "gcl
try" code and make it even easier for us.

gcl try --issue 12345


That above syntax will grab the latest patch from that rietveld issue, email
who owns that issue, and send him/her the try results to their email in the
same time updating that rietveld try results online. The reason why we can't
do that approach is because we don't know the email, patch set. We can even
add optional overrideable parameters such as what exists right now (email,
patchurl, etc)

To implement that, we could edit our rietveld branch code and introduce an
easier way to fetch data, since the current way to fetch a description is by
requesting http://codereview.chromium.org/196105/description, it would be
cool if we could request info quickly as a json schema like
http://codereview.chromium.org/196105/info that way we can have information
such as "patch set", "email", "description", unless we parse it out directly
from the url.

But thats just in a perfect world.



- Mohamed Mansour


On Fri, Sep 11, 2009 at 10:20 PM, Evan Stade  wrote:

> On Fri, Sep 11, 2009 at 7:07 PM, Mohamed Mansour  wrote:
> > We could do this instead:
> > gcl try --url http://url/to/patch.diff --email contribut...@email.com
> > --issue rietveldIssueNumber
> > No need to download and apply the patch.
> > - Mohamed Mansour
>
> heh, when I first read that I thought you were suggesting a new
> interface. But all those flags are already implemented. How
> convenient!
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Chromium core principles and multiplatform development?

[Mohamed Mansour]

We could do this instead:gcl try --url http://url/to/patch.diff --email
contribut...@email.com --issue rietveldIssueNumber

No need to download and apply the patch.

- Mohamed Mansour


On Fri, Sep 11, 2009 at 10:03 PM, Evan Martin  wrote:

>
> I generally leave the "figure out the errors" bit to the committer.
>
> Once you've made sure a patch isn't malicious:
>  git checkout origin
>  git cl patch -b theirname 12345  # code review number
>  git try
>  git checkout branch_i_was_working_on
> You can then point them to the try server build page and say "search
> for your name for errors" if it fails.
>
> On Fri, Sep 11, 2009 at 6:58 PM, Evan Stade  wrote:
> >
> > I agree it should be the responsibility of the committer to make sure
> > the code passes the trybots on all platforms (I have in the past made
> > the mistake of thinking the trybots were open to everyone, but they
> > are not). I think many committers will not be willing to go through
> > very many iterations of "download/apply patch, send to try bot, sort
> > out whether the errors are due to the patch, send errors back to
> > contributor", so non-committers will likely meet with difficulty when
> > trying to get patches in that they only tried on a single platform. So
> > I don't think it's necessarily a _requirement_ to have all three
> > platforms sitting around but having at least one windows and one posix
> > will greatly expedite the process.
> >
> > >
> >
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: [extensions] RFC: NPAPI manifest change

[Mohamed Mansour]

Why not just let the extension developer do different versions him/herself.
When I download an extension, I don't want to download libraries/plugins
from 10 different architectures. If my operating system is Windows, I would
want to download just the .dll file. The extension developer could release
different versions:
hello_world_win32.crx
hello_world_linux32.crx

Choose whatever filename they please. Maybe include what John stated, a
manifest to tell it what the extension supportedPlatform is, so we would
know at install time that the extension is no supported.

- Mohamed Mansour


On Thu, Sep 10, 2009 at 2:36 PM, jat  wrote:

>
> I am building a GWT plugin for Chrome, and I think the manifest should
> definitely include some indication of which platform a particular
> binary is intended for.  Trying to load them all and letting them fail
> seems dangerous, as the differences between some platforms may not be
> sufficient to prevent the library from loading (say two ELF-based x86
> Unix distros).
>
> I think Chrome should come up with a set of platform identifiers that
> correspond to what are different builds, and the plugins should be
> able to be associated with a particular platform.  For backwards
> compatibility, we could try and load any plugin without a platform tag
> and hope it will fail to load if it isn't compatible, but that should
> be deprecated.  I think the proposal at the beginning of this thread
> is fine, or you could simply add a new tag on the plugins entry, like
> this:
>  ...
>  "plugins": [
> { "path": "WINNT_x86-msvc/foo.dll", "public": true, "platform":
> "WINNT_x86-msvc" },
> { "path": "Linux_x86_64-gcc3/libfoo.so", "public": true,
> "platform": "Linux_x86-gcc3" },
> { "path": "Linux_x86_g4-gcc3/libfoo.so", "public": true,
> "platform": "Linux_x86_64-gcc3" }
>  ],
>  ...
> (path could still be anyway the developer wanted to organize the
> libraries).  Using a fixed naming convention would work, but it seems
> awkward and doesn't save much over just specifying the platform
> explicitly.
>
> Also, we need a way to know at install time that the extension is not
> supported on the current platform.  Since conceivably the extension
> might have an optional plugin and still operate without it on some
> platforms, I think that means adding a new manifest entry like
> supportedPlatforms: [ platforms ], and when you try and install the
> CRX it will tell you the extension is not supported on your platform
> if that tag is present but does not contain the current platform.
>
> --
> John A. Tamplin
> Software Engineer (GWT), Google
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: autolinking BUG= lines in Rietveld

[Mohamed Mansour]

Rewriting commit messages are always risky, but it has been tested to work,
it just searches for BUG=# and formats it to BUG=http://crbug.com/#
Maybe we should just do what you said and format the buildbot instead.

- Mohamed Mansour


On Thu, Sep 10, 2009 at 6:08 PM, Paweł Hajdan Jr.
wrote:

> Putting HTML in the commit message doesn't sound good to me (or does your
> patch work differently?). Plain text is good in this case. And rewriting the
> commit message is risky as well (at least I should get a chance to see the
> rewritten message before it gets committed).
> On the other hand, maybe it would make more sense to autolink the BUG line
> in other places: buildbot waterfall, viewvc, ...
>
>
> On Thu, Sep 10, 2009 at 15:03, Mohamed Mansour  wrote:
>
>> I did the git and gcl patches, but it only does it when you "commit". What
>> ways do you guys like to use it? jam stated that he is opposed to
>> changing the commit log from what the person wrote.
>> - Mohamed Mansour
>>
>>
>>
>> On Thu, Sep 10, 2009 at 5:29 PM, Mohamed Mansour wrote:
>>
>>> Np! I will do one for gcl.
>>> -- Mohamed Mansour
>>>
>>>
>>>
>>> On Thu, Sep 10, 2009 at 3:31 AM, John Abd-El-Malek wrote:
>>>
>>>> This is just for Rietveld issues.  We can possibly do the same to the
>>>> commit log in gcl/git scripts, again patches welcome :)
>>>> Thanks Mohamed for the patch, I committed it and made it live with two
>>>> minor changes.
>>>>
>>>>
>>>> On Wed, Sep 9, 2009 at 10:04 PM, PhistucK  wrote:
>>>>
>>>>> Are we only talking about when it is viewed in Rietveld?What about
>>>>> when it is actually committed, can the change log be tweaked that way,
>>>>> automatically, too?
>>>>> That would be nice when reading change logs.
>>>>>
>>>>> Thank you!
>>>>>
>>>>> ☆PhistucK
>>>>>
>>>>>
>>>>>
>>>>> On Thu, Sep 10, 2009 at 05:01, John Abd-El-Malek wrote:
>>>>>
>>>>>> Thanks, glad you enjoy it :)
>>>>>> This was a side distraction to fix the annoying issue of having to
>>>>>> manually copying and pasting the bug ids.  It severely tested my regex-fu
>>>>>> and since the multiple bugs case should be rare, I'll hide behind the 
>>>>>> excuse
>>>>>> that if they're duplicates they should be marked as such and only end up
>>>>>> with one, and if they're different bugs there should be separate 
>>>>>> changelists
>>>>>> ;)  The rietveld change is at
>>>>>> http://code.google.com/p/rietveld/source/detail?r=455, if anyone
>>>>>> sends me a patch to make it work with multiple bug ids, I'd be happy to 
>>>>>> push
>>>>>> it.
>>>>>>
>>>>>>
>>>>>> On Wed, Sep 9, 2009 at 6:15 PM, Mohamed Mansour wrote:
>>>>>>
>>>>>>> Very nice, no longer I have to put crbug.com/#.  Whoever did that
>>>>>>> autolink, can you support multiple bugs as well? The format bugdroid 
>>>>>>> uses is
>>>>>>> BUG=1, 2, 3
>>>>>>> - Mohamed Mansour
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Sep 9, 2009 at 8:58 PM, Paweł Hajdan Jr. <
>>>>>>> phajdan...@chromium.org> wrote:
>>>>>>>
>>>>>>>> I just noticed that BUG=1234 lines are autolinked to the correct bug
>>>>>>>> when viewed in Rietveld (codereview.chromium.org). This is very
>>>>>>>> useful, thanks!
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>> >>>>>
>>>>>
>>>>
>>>
>>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: autolinking BUG= lines in Rietveld

[Mohamed Mansour]

I did the git and gcl patches, but it only does it when you "commit". What
ways do you guys like to use it? jam stated that he is opposed to changing
the commit log from what the person wrote.
- Mohamed Mansour


On Thu, Sep 10, 2009 at 5:29 PM, Mohamed Mansour  wrote:

> Np! I will do one for gcl.
> -- Mohamed Mansour
>
>
>
> On Thu, Sep 10, 2009 at 3:31 AM, John Abd-El-Malek wrote:
>
>> This is just for Rietveld issues.  We can possibly do the same to the
>> commit log in gcl/git scripts, again patches welcome :)
>> Thanks Mohamed for the patch, I committed it and made it live with two
>> minor changes.
>>
>>
>> On Wed, Sep 9, 2009 at 10:04 PM, PhistucK  wrote:
>>
>>> Are we only talking about when it is viewed in Rietveld?What about when
>>> it is actually committed, can the change log be tweaked that way,
>>> automatically, too?
>>> That would be nice when reading change logs.
>>>
>>> Thank you!
>>>
>>> ☆PhistucK
>>>
>>>
>>>
>>> On Thu, Sep 10, 2009 at 05:01, John Abd-El-Malek wrote:
>>>
>>>> Thanks, glad you enjoy it :)
>>>> This was a side distraction to fix the annoying issue of having to
>>>> manually copying and pasting the bug ids.  It severely tested my regex-fu
>>>> and since the multiple bugs case should be rare, I'll hide behind the 
>>>> excuse
>>>> that if they're duplicates they should be marked as such and only end up
>>>> with one, and if they're different bugs there should be separate 
>>>> changelists
>>>> ;)  The rietveld change is at
>>>> http://code.google.com/p/rietveld/source/detail?r=455, if anyone sends
>>>> me a patch to make it work with multiple bug ids, I'd be happy to push it.
>>>>
>>>>
>>>> On Wed, Sep 9, 2009 at 6:15 PM, Mohamed Mansour wrote:
>>>>
>>>>> Very nice, no longer I have to put crbug.com/#.  Whoever did that
>>>>> autolink, can you support multiple bugs as well? The format bugdroid uses 
>>>>> is
>>>>> BUG=1, 2, 3
>>>>> - Mohamed Mansour
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Sep 9, 2009 at 8:58 PM, Paweł Hajdan Jr. <
>>>>> phajdan...@chromium.org> wrote:
>>>>>
>>>>>> I just noticed that BUG=1234 lines are autolinked to the correct bug
>>>>>> when viewed in Rietveld (codereview.chromium.org). This is very
>>>>>> useful, thanks!
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>
>>> >>>
>>>
>>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: autolinking BUG= lines in Rietveld

[Mohamed Mansour]

Np! I will do one for gcl.
-- Mohamed Mansour


On Thu, Sep 10, 2009 at 3:31 AM, John Abd-El-Malek  wrote:

> This is just for Rietveld issues.  We can possibly do the same to the
> commit log in gcl/git scripts, again patches welcome :)
> Thanks Mohamed for the patch, I committed it and made it live with two
> minor changes.
>
>
> On Wed, Sep 9, 2009 at 10:04 PM, PhistucK  wrote:
>
>> Are we only talking about when it is viewed in Rietveld?What about when
>> it is actually committed, can the change log be tweaked that way,
>> automatically, too?
>> That would be nice when reading change logs.
>>
>> Thank you!
>>
>> ☆PhistucK
>>
>>
>>
>> On Thu, Sep 10, 2009 at 05:01, John Abd-El-Malek wrote:
>>
>>> Thanks, glad you enjoy it :)
>>> This was a side distraction to fix the annoying issue of having to
>>> manually copying and pasting the bug ids.  It severely tested my regex-fu
>>> and since the multiple bugs case should be rare, I'll hide behind the excuse
>>> that if they're duplicates they should be marked as such and only end up
>>> with one, and if they're different bugs there should be separate changelists
>>> ;)  The rietveld change is at
>>> http://code.google.com/p/rietveld/source/detail?r=455, if anyone sends
>>> me a patch to make it work with multiple bug ids, I'd be happy to push it.
>>>
>>>
>>> On Wed, Sep 9, 2009 at 6:15 PM, Mohamed Mansour wrote:
>>>
>>>> Very nice, no longer I have to put crbug.com/#.  Whoever did that
>>>> autolink, can you support multiple bugs as well? The format bugdroid uses 
>>>> is
>>>> BUG=1, 2, 3
>>>> - Mohamed Mansour
>>>>
>>>>
>>>>
>>>> On Wed, Sep 9, 2009 at 8:58 PM, Paweł Hajdan Jr. <
>>>> phajdan...@chromium.org> wrote:
>>>>
>>>>> I just noticed that BUG=1234 lines are autolinked to the correct bug
>>>>> when viewed in Rietveld (codereview.chromium.org). This is very
>>>>> useful, thanks!
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>
>> >>
>>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: autolinking BUG= lines in Rietveld

[Mohamed Mansour]

Hmm I was looking at my code, and its flawed (the usage of brackets). This
one should work better:

import re


def replace_bug(m):

bugs = re.split(r"[\s,]+", m.group(1))

return ", ".join("%s" %
(i, i) for i in bugs if i != "")
bug_pattern = r"(?<=BUG=)(\s*\d+\s*(?:,\s*\d+\s*)*)"
result = re.sub(bug_pattern, replace_bug, "\nBUG=1 , 2, 3 ")
print result

 <http://codepad.org/DmH9r8I6>I submitted the patch to rietveld:
 http://codereview.appspot.com/115083
<http://codereview.appspot.com/115083>
-- Mohamed Mansour


On Wed, Sep 9, 2009 at 11:44 PM, Mohamed Mansour  wrote:

> Then it would just be a simple regular expression:
>
>> def repl(m):
>
> issues = re.split('\,|\s', m.group(1))
>
> return ", ".join("%s" % (s, s)
>> for s in issues)
>
>
>> if __name__ == '__main__':
>
> description = "\nBUG=1,2, 3,4"
>
> description = re.sub("\nBUG=(\d+[\,\s?\d+]*)", repl, description)
>
>  print description
>
>
> - Mohamed Mansour
>
>
>
> On Wed, Sep 9, 2009 at 11:32 PM, Jeremy Orlow  wrote:
>
>> Would be nice if it still handled http://crbug.com/ and crbug.com/ since
>> people probably will continue using them for a while.
>> Also split(', ') ONLY works for when you do 'blah, blah'.  Not
>> 'blah,blah'.  Not 'blah blah'.  Or any other crazy things people might do.
>>
>> I didn't know that you could give re.sub a callback to format the replace
>> text though.  That's cool and could probably make my code simpler.
>>
>> J
>>
>>
>> On Thu, Sep 10, 2009 at 12:27 PM, Mohamed Mansour wrote:
>>
>>> How about just this:
>>> def repl(m):
>>> issues = m.group(1).split(', ')
>>> return ", ".join("%s" % (s, s)
>>> for s in issues)
>>>
>>> if __name__ == '__main__':
>>> description = "\nBUG=2, 3"
>>> description = re.sub("\nBUG=(\d+[, \d+]*)", repl, description)
>>> print description
>>>
>>>
>>> Works great!
>>>
>>> - Mohamed Mansour
>>>
>>>
>>>
>>> On Wed, Sep 9, 2009 at 11:25 PM, Jeremy Orlow wrote:
>>>
>>>> I don't have a rietveld dev environment set up, so I wrote a quick
>>>> script to test the general algorithm.  It's not as pythony as I'd like, but
>>>> it seems to be fairly robust:
>>>> #!/usr/bin/python
>>>> import re
>>>>
>>>> description = """\
>>>> Blah blah blah.
>>>> Blaaa
>>>>
>>>> TEST=none
>>>> BUG=123,456, 798,0
>>>> BUG=888
>>>> BUG=none
>>>>  BUG = none, 2349,2,asdf
>>>> BUG = http://crbug.com/123
>>>> BUG = crbug.com/234 crbug/82
>>>> """
>>>>
>>>> LINK = "%s"
>>>> def rewrite_bug_numbers(string):
>>>>   if ',' in string:
>>>> right, left = string.split(',', 1)
>>>> return rewrite_bug_numbers(right) + ',' + rewrite_bug_numbers(left)
>>>>   if ' ' in string:
>>>> right, left = string.split(' ', 1)
>>>> return rewrite_bug_numbers(right) + ' ' + rewrite_bug_numbers(left)
>>>>
>>>>   # Base cases:
>>>>   if string.isdigit():
>>>> return LINK % (string, string)
>>>>   match = re.search(r'^(http://|)crbug.com/(\d+)', string)
>>>>   if match:
>>>> return LINK % (match.group(2), string)
>>>>   return string
>>>>
>>>> output = []
>>>> for line in description.splitlines():
>>>>   match = re.search(r'^(\s*BUG\s*=)(.*)$', line)
>>>>   if match:
>>>> line = match.group(1) + rewrite_bug_numbers(match.group(2))
>>>>   output.append(line)
>>>> print "\n".join(output)
>>>>
>>>>
>>>>
>>>> Prints out
>>>>
>>>> Blah blah blah.
>>>> Blaaa
>>>> 
>>>> TEST=none
>>>> BUG=>>> href='http://code.google.com/p/chromium/issues/detail?id=123'>123,>>> href='http://code.google.com/p/chromium/issues/detail?id=456'>456,
>>>> 798,>>> href='http://code

[chromium-dev] Re: autolinking BUG= lines in Rietveld

[Mohamed Mansour]

Then it would just be a simple regular expression:

> def repl(m):

issues = re.split('\,|\s', m.group(1))

return ", ".join("%s" % (s, s)
> for s in issues)


> if __name__ == '__main__':

description = "\nBUG=1,2, 3,4"

description = re.sub("\nBUG=(\d+[\,\s?\d+]*)", repl, description)

 print description


- Mohamed Mansour


On Wed, Sep 9, 2009 at 11:32 PM, Jeremy Orlow  wrote:

> Would be nice if it still handled http://crbug.com/ and crbug.com/ since
> people probably will continue using them for a while.
> Also split(', ') ONLY works for when you do 'blah, blah'.  Not 'blah,blah'.
>  Not 'blah blah'.  Or any other crazy things people might do.
>
> I didn't know that you could give re.sub a callback to format the replace
> text though.  That's cool and could probably make my code simpler.
>
> J
>
>
> On Thu, Sep 10, 2009 at 12:27 PM, Mohamed Mansour wrote:
>
>> How about just this:
>> def repl(m):
>> issues = m.group(1).split(', ')
>> return ", ".join("%s" % (s, s)
>> for s in issues)
>>
>> if __name__ == '__main__':
>> description = "\nBUG=2, 3"
>> description = re.sub("\nBUG=(\d+[, \d+]*)", repl, description)
>> print description
>>
>>
>> Works great!
>>
>> - Mohamed Mansour
>>
>>
>>
>> On Wed, Sep 9, 2009 at 11:25 PM, Jeremy Orlow wrote:
>>
>>> I don't have a rietveld dev environment set up, so I wrote a quick script
>>> to test the general algorithm.  It's not as pythony as I'd like, but it
>>> seems to be fairly robust:
>>> #!/usr/bin/python
>>> import re
>>>
>>> description = """\
>>> Blah blah blah.
>>> Blaaa
>>>
>>> TEST=none
>>> BUG=123,456, 798,0
>>> BUG=888
>>> BUG=none
>>>  BUG = none, 2349,2,asdf
>>> BUG = http://crbug.com/123
>>> BUG = crbug.com/234 crbug/82
>>> """
>>>
>>> LINK = "%s"
>>> def rewrite_bug_numbers(string):
>>>   if ',' in string:
>>> right, left = string.split(',', 1)
>>> return rewrite_bug_numbers(right) + ',' + rewrite_bug_numbers(left)
>>>   if ' ' in string:
>>> right, left = string.split(' ', 1)
>>> return rewrite_bug_numbers(right) + ' ' + rewrite_bug_numbers(left)
>>>
>>>   # Base cases:
>>>   if string.isdigit():
>>> return LINK % (string, string)
>>>   match = re.search(r'^(http://|)crbug.com/(\d+)', string)
>>>   if match:
>>> return LINK % (match.group(2), string)
>>>   return string
>>>
>>> output = []
>>> for line in description.splitlines():
>>>   match = re.search(r'^(\s*BUG\s*=)(.*)$', line)
>>>   if match:
>>> line = match.group(1) + rewrite_bug_numbers(match.group(2))
>>>   output.append(line)
>>> print "\n".join(output)
>>>
>>>
>>>
>>> Prints out
>>>
>>> Blah blah blah.
>>> Blaaa
>>> 
>>> TEST=none
>>> BUG=>> href='http://code.google.com/p/chromium/issues/detail?id=123'>123,>> href='http://code.google.com/p/chromium/issues/detail?id=456'>456,
>>> 798,>> href='http://code.google.com/p/chromium/issues/detail?id=0'>0
>>> BUG=888
>>> BUG=none
>>>   BUG = none, 2349,>> href='http://code.google.com/p/chromium/issues/detail?id=2
>>> '>2,asdf
>>> BUG = 
>>> http://crbug.com/123
>>> BUG = 
>>> crbug.com/234 crbug/82
>>>
>>>
>>> If we weren't concerned about preserving formatting, you could do it with
>>> replace and split:
>>>
>>> line = "1234, 23 , 2"
>>> bugs = line.replace(",", " ").split()
>>>
>>>
>>> But it's not t much more work to keep in all the formatting.
>>>
>>>
>>> On Thu, Sep 10, 2009 at 11:01 AM, John Abd-El-Malek 
>>> wrote:
>>>
>>>> Thanks, glad you enjoy it :)
>>>> This was a side distraction to fix the annoying issue of having to
>>>> manually copying and pasting the bug ids.  It severely tested my regex-fu
>>>> and since the multiple bugs case should be rare, I'll hide behind the 
>>>> excuse
>>>> that if they're duplicates they should be marked as such and only end up
>>>> with one, and if they're different bugs there should be separate 
>>>> changelists
>>>> ;)  The rietveld change is at
>>>> http://code.google.com/p/rietveld/source/detail?r=455, if anyone sends
>>>> me a patch to make it work with multiple bug ids, I'd be happy to push it.
>>>>
>>>>
>>>> On Wed, Sep 9, 2009 at 6:15 PM, Mohamed Mansour wrote:
>>>>
>>>>> Very nice, no longer I have to put crbug.com/#.  Whoever did that
>>>>> autolink, can you support multiple bugs as well? The format bugdroid uses 
>>>>> is
>>>>> BUG=1, 2, 3
>>>>> - Mohamed Mansour
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Sep 9, 2009 at 8:58 PM, Paweł Hajdan Jr. <
>>>>> phajdan...@chromium.org> wrote:
>>>>>
>>>>>> I just noticed that BUG=1234 lines are autolinked to the correct bug
>>>>>> when viewed in Rietveld (codereview.chromium.org). This is very
>>>>>> useful, thanks!
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>> >>>>
>>>>
>>>
>>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: autolinking BUG= lines in Rietveld

[Mohamed Mansour]

How about just this:
def repl(m):
issues = m.group(1).split(', ')
return ", ".join("%s" % (s, s) for
s in issues)

if __name__ == '__main__':
description = "\nBUG=2, 3"
description = re.sub("\nBUG=(\d+[, \d+]*)", repl, description)
print description


Works great!

- Mohamed Mansour


On Wed, Sep 9, 2009 at 11:25 PM, Jeremy Orlow  wrote:

> I don't have a rietveld dev environment set up, so I wrote a quick script
> to test the general algorithm.  It's not as pythony as I'd like, but it
> seems to be fairly robust:
> #!/usr/bin/python
> import re
>
> description = """\
> Blah blah blah.
> Blaaa
>
> TEST=none
> BUG=123,456, 798,0
> BUG=888
> BUG=none
>  BUG = none, 2349,2,asdf
> BUG = http://crbug.com/123
> BUG = crbug.com/234 crbug/82
> """
>
> LINK = "%s"
> def rewrite_bug_numbers(string):
>   if ',' in string:
> right, left = string.split(',', 1)
> return rewrite_bug_numbers(right) + ',' + rewrite_bug_numbers(left)
>   if ' ' in string:
> right, left = string.split(' ', 1)
> return rewrite_bug_numbers(right) + ' ' + rewrite_bug_numbers(left)
>
>   # Base cases:
>   if string.isdigit():
> return LINK % (string, string)
>   match = re.search(r'^(http://|)crbug.com/(\d+)', string)
>   if match:
> return LINK % (match.group(2), string)
>   return string
>
> output = []
> for line in description.splitlines():
>   match = re.search(r'^(\s*BUG\s*=)(.*)$', line)
>   if match:
> line = match.group(1) + rewrite_bug_numbers(match.group(2))
>   output.append(line)
> print "\n".join(output)
>
>
>
> Prints out
>
> Blah blah blah.
> Blaaa
> 
> TEST=none
> BUG= href='http://code.google.com/p/chromium/issues/detail?id=123'>123, href='http://code.google.com/p/chromium/issues/detail?id=456'>456,  href='http://code.google.com/p/chromium/issues/detail?id=798'>798, href='http://code.google.com/p/chromium/issues/detail?id=0'>0
> BUG=888
> BUG=none
>   BUG = none, 2349, href='http://code.google.com/p/chromium/issues/detail?id=2'>2,asdf
> BUG = 
> http://crbug.com/123
> BUG = 
> crbug.com/234 crbug/82
>
>
> If we weren't concerned about preserving formatting, you could do it with
> replace and split:
>
> line = "1234, 23 , 2"
> bugs = line.replace(",", " ").split()
>
>
> But it's not t much more work to keep in all the formatting.
>
>
> On Thu, Sep 10, 2009 at 11:01 AM, John Abd-El-Malek wrote:
>
>> Thanks, glad you enjoy it :)
>> This was a side distraction to fix the annoying issue of having to
>> manually copying and pasting the bug ids.  It severely tested my regex-fu
>> and since the multiple bugs case should be rare, I'll hide behind the excuse
>> that if they're duplicates they should be marked as such and only end up
>> with one, and if they're different bugs there should be separate changelists
>> ;)  The rietveld change is at
>> http://code.google.com/p/rietveld/source/detail?r=455, if anyone sends me
>> a patch to make it work with multiple bug ids, I'd be happy to push it.
>>
>>
>> On Wed, Sep 9, 2009 at 6:15 PM, Mohamed Mansour  wrote:
>>
>>> Very nice, no longer I have to put crbug.com/#.  Whoever did that
>>> autolink, can you support multiple bugs as well? The format bugdroid uses is
>>> BUG=1, 2, 3
>>> - Mohamed Mansour
>>>
>>>
>>>
>>> On Wed, Sep 9, 2009 at 8:58 PM, Paweł Hajdan Jr. <
>>> phajdan...@chromium.org> wrote:
>>>
>>>> I just noticed that BUG=1234 lines are autolinked to the correct bug
>>>> when viewed in Rietveld (codereview.chromium.org). This is very useful,
>>>> thanks!
>>>>
>>>>
>>>
>>>
>>>
>>
>> >>
>>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: autolinking BUG= lines in Rietveld

[Mohamed Mansour]

Very nice, no longer I have to put crbug.com/#.  Whoever did that autolink,
can you support multiple bugs as well? The format bugdroid uses is BUG=1, 2,
3
- Mohamed Mansour


On Wed, Sep 9, 2009 at 8:58 PM, Paweł Hajdan Jr. wrote:

> I just noticed that BUG=1234 lines are autolinked to the correct bug when
> viewed in Rietveld (codereview.chromium.org). This is very useful, thanks!
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Sheriff swap for 9/11-14

[Mohamed Mansour]

No worries! Since I am an external contributor, I will be available for
sheriffing around ~5PM EST. So if someone can take morning shift, I could
take control afternoons (PST).
- Mohamed Mansour


On Mon, Aug 31, 2009 at 9:11 PM, Roland Steiner wrote:

> Thanks a lot!
>
> If you ever need me to switch in for you, just let me know!
>
> Cheers,
>
> Roland
>
>
>
> On Mon, Aug 31, 2009 at 11:49 PM, Mohamed Mansour <
> m0.interact...@gmail.com> wrote:
>
>> I could do it, no need to swap. I enjoy sherrifing :)
>> -- Mohamed Mansour
>>
>>
>> On Mon, Aug 31, 2009 at 4:17 AM, Roland Steiner > > wrote:
>>
>>> Hi all,
>>>
>>> I'm scheduled for build sheriff duty from 9/11 to 9/14. However, this
>>> overlaps our Japanese hackathon, so I wondered if there was a kind sould who
>>> would consider swapping sheriff duty with me (preferably with a later date).
>>>
>>>
>>> Cheers,
>>>
>>> Roland
>>>
>>> >>>
>>>
>>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Sheriff swap for 9/11-14

[Mohamed Mansour]

I could do it, no need to swap. I enjoy sherrifing :)
-- Mohamed Mansour


On Mon, Aug 31, 2009 at 4:17 AM, Roland Steiner wrote:

> Hi all,
>
> I'm scheduled for build sheriff duty from 9/11 to 9/14. However, this
> overlaps our Japanese hackathon, so I wondered if there was a kind sould who
> would consider swapping sheriff duty with me (preferably with a later date).
>
>
> Cheers,
>
> Roland
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Platform parity

[Mohamed Mansour]

I believe we should not close the tracker associated to the CL if a UI tweak
should be done in all platforms, and its up to the developer to know who to
delegate that task to. We shouldn't force anyone to develop this, we should
properly tag the issue tracker and add proper labels. As well, we should
properly cc people who are more active in that platform, so they will know
what is missing.
I don't know what a good solution is to cross platform development, unless
everyone should produce code in all three platforms whenever they work on a
patch or feature.

- Mohamed Mansour


On Sun, Aug 30, 2009 at 11:57 PM, Nico Weber  wrote:

>
> Hi,
>
> I happened to look at a CL today that adds a "Really delete all
> passwords?" dialog on Windows ( http://codereview.chromium.org/155291
> ). The patch was done by someone relatively new to the project (which
> is of course great). Sadly, neither the patch author nor one of the
> reviewers mentioned that this change might have to be done on the
> other platforms as well. As it happens, it's not necessary on OS X,
> but it might be required on Linux.
>
> What's out approach to make sure that such UI tweaks reach all
> platforms? Do we require that contributors who do a UI tweak implement
> it on all three platforms? Do we require that contributors who do such
> a change open bugs for the platforms they don't do the change on and
> hope someone else will do the change on the other platforms? Or do we
> simply not worry about this too much, as it doesn't happen that often
> anyway?
>
> Just curious.
> Nico
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: How to get statusbar information?

[Mohamed Mansour]

Hi,
A search result within *chrome/** brings:
http://www.google.com/codesearch?q=file:chrome/(.*)/status(.*)\.(cc|mm)$+package:src.chromium.org/svn/trunk/src

<http://www.google.com/codesearch?q=file:status(.*)\.cc$+package:src.chromium.org/svn/trunk/src>According
to this:
http://dev.chromium.org/developers/how-tos/getting-around-the-chrome-source-code

<http://dev.chromium.org/developers/how-tos/getting-around-the-chrome-source-code>For
Windows, everything under *views/* *represents the UI, all the others
represents the model for the views which is shared between all three
platforms.

According to your second question, I don't know, must be a UI decision.

- Mohamed Mansour


On Sun, Aug 30, 2009 at 4:03 AM, Jickae Davis  wrote:

> Hi, I'm curious about Chrome's statusbar which gives out informations like
> "waiting www.google.com" at the bottom left.
>
> I want to know where these statusbar codes lie?
>
> and why not add a progress bar here?
>
>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

[Mohamed Mansour]

I really want to name it tools as Peter stated, If anyone has any
objections, please let me know, it will now be:
ALT-T = Tools Menu (previously known as App menu)
ALT-P = Page Menu.

The only difference within these sets is that within the first set, it
"shows" the menu (the menu popup will be visible), the second set, it will
"highlight" the menu (will not show it)

-- Mohamed Mansour


On Fri, Aug 21, 2009 at 3:56 PM, Peter Kasting  wrote:

> On Fri, Aug 21, 2009 at 11:41 AM, Mohamed Mansour wrote:
>
>> Let me summarize what you all have stated:
>>
>>- ALT: Highlight App menu button
>>- ALT-P: Show Page menu
>>- ALT-A: Show App menu
>>
>> or..
>>
>>- ALT: Highlight App menu button
>>- ALT-P: Highlight Page menu button
>>- ALT-A: Highlight App menu button
>>
>> First set or second set?
>>
>
> Your sets are identical.
>
>  Also, I claim that it's the "Tools" menu, not the "App" menu, regardless
> of what Glen claims :)
>
> PK
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

[Mohamed Mansour]

Let me summarize what you all have stated:

   - ALT: Highlight App menu button
   - ALT-P: Show Page menu
   - ALT-A: Show App menu

or..

   - ALT: Highlight App menu button
   - ALT-P: Highlight Page menu button
   - ALT-A: Highlight App menu button


First set or second set?

Thanks!

- Mohamed Mansour


On Thu, Aug 20, 2009 at 12:11 PM, Evan Martin  wrote:

> For what it's worth, Alt-F is already used by extensions like
> FlashBlock for Chrome:
> http://userscripts.org/scripts/show/46673
>
> On Wed, Aug 19, 2009 at 4:33 PM, Peter Kasting wrote:
> > On Wed, Aug 19, 2009 at 4:31 PM, Mohamed Mansour 
> wrote:
> >>
> >> Are you guys referring to "alt" alone or "alt-f, alt-e" to highlight the
> >> menu item?.
> >>  "alt-f" if triggered appropriately brings up full screen which is
> another
> >> problem ...
> >
> > Alt alone.
> > Fullscreen is F11 on Windows, not alt-f.  (We are presumably talking
> about
> > Windows here, unless the other OSes happen to have copied its alt
> behavior.)
> > PK
> > > >
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

[Mohamed Mansour]

jhawkins++
I am with James on this one. Would save numerous clicks.

-- Mohamed Mansour


On Thu, Aug 20, 2009 at 5:57 PM, James Hawkins wrote:

>
> On Thu, Aug 20, 2009 at 2:41 PM, Peter Kasting
> wrote:
> > On Thu, Aug 20, 2009 at 2:02 PM, JT Olds  wrote:
> >>
> >> None of the below Linux browsers select the entire URL on the first
> click:
> >> Firefox
> >> Epiphany
> >> Seamonkey
> >> Galeon
> >> Midori
> >> Konqueror
> >> Dillo
> >>
> >> In fact, I can't find a single browser that does what you claim on
> Linux.
> >
> > I am on record
> > (
> http://groups.google.com/group/chromium-reviews/browse_thread/thread/878579dd61c53a00/213560d76d537337
>  )
> > as saying "It would be better to just not select the text at all (a la
> > Firefox) than to appear to select the text but not update the X primary
> > selection.  If the current behavior becomes intolerable, that is the
> route
> > I'd go."
> > "Intolerable" is more than just "not how the native controls normally
> work"
> > -- it's "dramatically interferes with user behavior".  That may well be
> true
> > on Linux.  In that thread, though, we discussed a lot of other alternate
> > methods of pasting in a URL, such as paste-and-go, middle-clicking blank
> > sections of the tabstrip, etc.  I'd want some Linux UI folks to be able
> to
> > say concretely, "we've lived with this for several weeks, and it's
> clearly
> > not enough; we need to change."
> > PK
> >
>
> Will you accept opinions of the opposite?  I love our current behavior
> and can't stand having to triple-click in Firefox.
>
> Consider the following cases.
>
> a) The user is trying to completely change the contents of the omnibox.
>  - Current behavior: 1 click
>  - Suggested behavior: 3 clicks
>
> b) The user is trying to modify the contents of the omnibox.
>  - Current behavior: 2 clicks
>  - Suggested behavior: 1 click
>
> I have no facts to back up this claim, but I'd say that 70% of
> operations are of the former (a), with the caveat that this is a
> conservative estimate based on my personal experience.
>
> 100 operations -
> Current behavior: 70*1 + 30*2 = 130 clicks
> Suggested behavior: 70*3 + 30*1 = 240 clicks
>
> This analysis only pertains to number of clicks and ignores the issue
> of nuking the PRIMARY selection, which I've personally never had a
> problem with.
>
> Linux UI devel,
> James Hawkins
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

[Mohamed Mansour]

Are you guys referring to "alt" alone or "alt-f, alt-e" to highlight the
menu item?.
 "alt-f" if triggered appropriately brings up full screen which is another
problem ...


- Mohamed Mansour


On Wed, Aug 19, 2009 at 7:01 PM, Nick Baum  wrote:

> I agree with Ben and Peter, alt should highlight the wrench menu.
> -Nick
>
> On Tue, Aug 18, 2009 at 9:43 PM, Peter Kasting wrote:
>
>> On Tue, Aug 18, 2009 at 9:40 PM, Evan Stade  wrote:
>>
>>> Also, I don't really care which one alt highlights, but it seems to me
>>> that alt just highlights the leftmost menu. This happens to always be
>>> File. If the File menu is not leftmost, then it's unclear which should
>>> be highlighted.
>>
>>
>> Highlighting the Tools menu is important for a similar reason that hooking
>> it to alt-f instead of alt-t is: people have ingrained key combos like
>> alt-f, x or alt, enter, x that they expect to work.
>>
>> PK
>>
>> >>
>>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

[Mohamed Mansour]

Alright, I have changed it to use alt+e and alt+f.
http://codereview.chromium.org/174044/show

<http://codereview.chromium.org/174044/show>Would be nice if a user presses
just "alt" and it would bring up the default "main" menu. The page menu is
used more than the app menu. Would be nice to incorporate that into
Chromium. What do you all think?

- Mohamed Mansour


On Tue, Aug 18, 2009 at 11:32 PM, Ben Goodger (Google) wrote:

> sgtm.
>
> -Ben
>
> On Tue, Aug 18, 2009 at 8:32 PM, Evan Stade wrote:
> > on linux we do alt+e for page menu and alt+f for wrench menu. The
> > reasoning is that these two menus are reasonable approximations of the
> > Edit and File menus, respectively.
> >
> > -- Evan Stade
> >
> >
> >
> > On Tue, Aug 18, 2009 at 8:14 PM, Ben Goodger (Google)
> wrote:
> >>
> >> I'm not sure about accesskeys, but my feeling is just pressing Alt
> >> should definitely hilight the one of the two menus.
> >>
> >> -Ben
> >>
> >> On Tue, Aug 18, 2009 at 8:11 PM, Mohamed Mansour
> wrote:
> >>> Hi all,
> >>> Currently, all the functionality in Chrome toolbar has a keyboard
> shortcut
> >>> connected to it, except for the App and Page menus. For a keyboard
> user,
> >>> currently, you can SHIFT+ALT+T and use the right arrow key to move
> focus to
> >>> the menus. This is not very effective and would be better to have a
> quick
> >>> way accessing these menus from the keyboard.
> >>> My suggestion would be: ALT+A for "App Menu" and ALT+P for "Page Menu".
> I
> >>> would like some of your suggestions before I implement and commit the
> >>> change. And I would need feedback from the UI Team.
> >>> The bug tracker for this would be:
> >>> http://crbug.com/906
> >>>
> >>> - Mohamed Mansour
> >>>
> >>
> >> > >>
> >>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Access keys for Chrome menus, what do you prefer?

[Mohamed Mansour]

Hi all,

Currently, all the functionality in Chrome toolbar has a keyboard shortcut
connected to it, except for the App and Page menus. For a keyboard user,
currently, you can SHIFT+ALT+T and use the right arrow key to move focus to
the menus. This is not very effective and would be better to have a quick
way accessing these menus from the keyboard.

My suggestion would be: ALT+A for "App Menu" and ALT+P for "Page Menu". I
would like some of your suggestions before I implement and commit the
change. And I would need feedback from the UI Team.

The bug tracker for this would be:
http://crbug.com/906


- Mohamed Mansour

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: windows build instructions correction

[Mohamed Mansour]

That will help many people! Nice find on that blog post!
-- Mohamed Mansour


On Wed, Aug 12, 2009 at 10:28 PM, cpu  wrote:

>
> If you followed the instructions in chromium (http://dev.chromium.org/
> developers/how-tos/build-instructions-windows) recently and chose to
> use VS2008 then this will be of interest.
>
> The order was wrong, I just changed it. You need to install in the
> following order:
>
> 1. VS2008 RTM
> 2. Windows SDK 6.1
> 3. VS2008 SP1
>
> If you followed the old instructions then you did step 3 before step
> 2. This causes a problem because the SP1 upgrades files in the SDK.
> The wrong order causes some un-versioned files to be overwritten to
> their older versions.
>
> This might or might not cause an immediate problem, but surely a
> problem will ensue at some point.
>
> My fix was to uninstall everything and re-install everything. I won't
> lie to you, it was quite painful.
>
> See here for more info:
>
> http://blogs.msdn.com/windowssdk/archive/2009/08/07/windows-sdk-for-server-2008-v6-1-overwrites-vs2008-sp1-crt-files.aspx
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: lan manager in cloud

[Mohamed Mansour]

Firefox and IE has "Kiosk" mode, where you can go full screen all the time.
"iexplore -k url"

We currently don't have that in Chromium, the closest we have is
"Application Mode". Kiosk mode is a browser with no frame (aka full screen
 with no exit)

-- Mohamed Mansour


On Tue, Aug 11, 2009 at 7:30 PM, Ricardo Vargas wrote:

> I guess he's looking at a way to prevent the browser from going out of full
> screen mode.
> My second guess is that the last comment is just a greeting (that's all for
> now).
>
>
> On Tue, Aug 11, 2009 at 3:37 PM, Dan Kegel  wrote:
>
>>
>> And are you looking to hire somebody to do the work?  (That's what I
>> seem to gather from your hourly comment.)
>>
>> On Tue, Aug 11, 2009 at 3:23 PM, Jeremy Orlow wrote:
>> > Even with the translation, it's difficult to understand what you're
>> saying
>> > and asking.  Chromium has a full screen feature and is open source so
>> you
>> > could tweak it to meet your needs.  Does that help?
>> >
>> > On Tue, Aug 11, 2009 at 3:16 PM, Wallace Araujo 
>> > wrote:
>> >>
>> >> Someone could help me in these disputes?
>> >>
>> >> it is an Opensource project.
>> >>
>> >>  Wallace Araujo
>> >>  cellphone: +55 (21) 7681-9846
>> >>  Follow me on Twitter: @wallacejvm
>> >>
>> >>
>> >> 2009/8/10 Wallace Araujo 
>> >>>
>> >>> Portugues( lingua nativa):
>> >>>
>> >>> Eu estou desenvolvendo um sistema para gerenciamento de lan house ou
>> >>> cyber cafés que funcione em nuvem.
>> >>> Necessito usar um browser para isso que me permita:
>> >>>
>> >>> - janela full screem e sem barra de titulo e controladores globais
>> >>> (minimizar, maximizar e fechar).
>> >>>
>> >>> De inicio usei o XUL da mozilla mas tive problemas com ele.
>> >>>
>> >>> Preciso de ajuda para saber se posso fazer isso com o chromium e como
>> >>> fazer isso com ele.
>> >>>
>> >>> Por hora é só.
>> >>>
>> >>> English ( google tradutor):
>> >>>
>> >>>
>> >>>
>> >>> I am developing a system to manage lan house or cyber cafes operating
>> >>> in the cloud.
>> >>> Need to use a browser that I can:
>> >>>
>> >>> - Screem full window without the title bar and drivers overall
>> >>> (minimize, maximize and close).
>> >>>
>> >>> From beginning I used the mozilla's XUL but I had problems with it.
>> >>>
>> >>> I need help to know if I can do this with the chromium and how to do
>> >>> this with him.
>> >>>
>> >>> Hourly is just.
>> >>>
>> >>> Span ( google tradutor)
>> >>>
>> >>>
>> >>>
>> >>> Estoy desarrollando un sistema para administrar Lan House o cibercafés
>> >>> que funcionan en la nube.
>> >>> Necesidad de utilizar un navegador que pueda:
>> >>>
>> >>> - Screem completo la ventana sin barra de título y conductores en
>> >>> general (minimizar, maximizar y cerrar).
>> >>>
>> >>> Desde el principio he usado Mozilla XUL, pero tuve problemas con él.
>> >>>
>> >>> Necesito ayuda para saber si puedo hacer esto con el cromo y cómo
>> >>> hacer esto con él.
>> >>>
>> >>> Cada hora que es justo.
>> >>>
>> >>> --
>> >>>  Wallace Araujo
>> >>>  cellphone: +55 (21) 7681-9846
>> >>>  Follow me on Twitter: @wallacejvm
>> >>
>> >>
>> >>
>> >
>> >
>> > >
>> >
>>
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

[Mohamed Mansour]

I kinda like that idea, I personally don't know what directions themes is
going. It seems like a hidden project that will just surprise us one day.
-- Mohamed Mansour


On Tue, Aug 11, 2009 at 7:03 PM, Meok  wrote:

>
> Just to add my two cents worth. Even though there is a full resource,
> I still see a need for users to be able to keep their favorites easily
> accessible. It;s the same philosophy of having a New Tab Page even
> though you can pull back your most visited sites from the bookmarks.
>
> I think it would have been cool to have a theme / look & feel page
> that works like the NTP. It will just give you a fixed number of thumb-
> previews of the themes you have chosen most often or most recently,
> maybe with the default theme being a fixed thumb. To the bottom, it
> would have a link to take you to the whole gallery. You can pin themes
> and stop themes from showing up in the list, but it would just be a
> fixed amount of thumbs, instead of a big dropdown menu.
>
> Here's a rough mockup:
> http://gowebnow.net/chrome/images/chrome-themes-ui.png
>
> On Aug 10, 8:02 pm, Aaron Boodman  wrote:
> > On Mon, Aug 10, 2009 at 11:09 AM, Avi Drissman wrote:
> > > On Mon, Aug 10, 2009 at 1:31 PM, Aaron Boodman 
> wrote:
> >
> > >> > Incidentally, two other asks:
> > >> > * When "installing" a theme, give the user a way to switch back to
> the
> > >> > previous theme (e.g. an infobar).  We currently have an option to
> switch
> > >> > back to the default theme, which is also useful, in different cases.
> >
> > >> We have a bug open on this. It requires some changes to thethemes
> > >> service. I think that Avi is working on this.
> >
> > > I am? Please assign the bug, then, because I was unaware of it.
> >
> > FYI, just so interested parties know the resolution, the work I was
> > thinking of Avi was working on, but it i done now. We can now
> > implement the undo UI, I will create a bug on myself.
> >
> > - a
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

[Mohamed Mansour]

How would this be done if installing a theme doesn't require any
authentication? If we are going this approach, it means the user should be
logged in to manage his/her own themes? I like this approach as well... but
why not just do this:
Create a chrome://themes/ page where we asynchronously fetch the theme data
from the remote website, that way, we can control how that page is rendered
with prefs (currently installed theme, last 5 installed themes, etc ) we
could even make that chrome://themes/ page fetch themes from different
sources (not only from Google) via syndication. Just a thought.

Later on, we could even have the chrome://themes/ page create custom colours
for themes (once again, easily done by altering the prefs) if the user
wants. Add tints, etc ... Many, many people on the forums want custom
colours. (Similar to GMail)

-- Mohamed Mansour


On Mon, Aug 10, 2009 at 1:13 PM, Amanda Walker  wrote:

> On Mon, Aug 10, 2009 at 1:05 PM, Peter Kasting wrote:
>
>> Or, instead of building this list in locally, we could build it in to the
>> themes gallery.  When you go there these MRU themes (and the default) are
>> right on the first page.  This can also help when you're trying to set up
>> another machine with the theme you like and need to remember what it is.
>>
>
> +1.  This also helps frame the UX as "pick", not "install".
>
> --Amanda
>
>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

[Mohamed Mansour]

When people change themes regularly, I believe their intension is to try out
themes. When "theme preview" is going to come in, that would be simpler. A
person isn't going to change themes every day, if they want to change
themes, they could just goto the UI and change to any theme they please.
I believe a drop down for a list of themes is a waste of space for the
options panel, people wont use that frequently. I have been told that once
you installed a new theme, the old theme will not be archived (stored on the
system), so switching themes would be harder when the CL comes in.

I thought you guys are picky when it comes to options, and introducing a
themes drop down is actually a useless control which will be rarely used.
There are many other areas where I would like to have options which actually
makes more sense compared to this.

Aaron, I believe the themes page could use a "currently installed theme"
that way the user would know what theme he/she installed. It was possible by
visiting chrome://extensions/, but now its removed from that page.

-- Mohamed Mansour


On Mon, Aug 10, 2009 at 1:46 AM, PhistucK  wrote:

> But people like to change themes periodically and also, to choose from
> themes they have already installed and new themes, you (currently) cannot
> incorporate both of them in the theme gallery.
> I saw that happening with regular, non techy users - all of the time (not
> in Chrome, obviously, since they did not have an option up until now, but
> with tons of other programs).
> They choose one, they choose another, they select from their collection
> again and also look for new ones.
> So these should either be combined (existing and total in one page), or an
> option to select a theme should be present, in my opinion.
>
> ☆PhistucK
>
>
>
> On Mon, Aug 10, 2009 at 08:19, Aaron Boodman  wrote:
>
>>
>> On Sun, Aug 9, 2009 at 5:51 PM, Peter Kasting wrote:
>> > FWIW, I'd prefer if all the ports have this.
>> > There are three reasons for this, one of them silly:
>> > (1) Shows themes you've gotten from sources other than the gallery (I
>> don't
>> > know if this is possible at this moment, but it will be someday, right?)
>>
>> No, why is it useful to see themes you've previously installed? I
>> mean, why is it anymore than seeing any other webpage you've
>> previously visited. We already have mechanisms to find things you
>> visited previously. Why does themes need it's own?
>>
>> > (2) Limited to the set of themes you've actually shown interest in by
>> using.
>> >  Think about if the gallery had several thousand themes (the way Firefox
>> has
>> > several thousand Personas).
>>
>> I don't even buy that this would work. You can't tell which themes you
>> like by looking at the picture. I suspect it is more typical to
>> actually try it on for size before deciding it is hideous/awesome.
>>
>> > (3) Usable while offline/unable to access gallery (silly reason).
>>
>> You're right, silly.
>>
>> > The first two are sufficient reasons to me that I've been surprised to
>> not
>> > see this kind of a switch in the WIndows UI.
>>
>> Funny, you recently argued in a different thread (about a different
>> feature request) that the cost for following a link is basically nil,
>> so there shouldn't be any separate UI other than that ;-).
>>
>> Agree right now that installing a theme is slightly higher cost than
>> following a link. But it shouldn't be.
>>
>> On Sun, Aug 9, 2009 at 9:02 PM, PhistucK wrote:
>> > Seeing as there is currently no UI for it other than actually installing
>> a
>> > theme again, I would say the theme selection dropdown is kind of a
>> needed
>> > element.
>>
>> We should change the word "install" to "pick". Why should there be a
>> different UI for re-picking a theme than there is for the initial
>> pick?
>>
>> On Sun, Aug 9, 2009 at 10:04 PM, Caleb Eggensperger
>> wrote:
>> > It would be nice for the UI for "installing" a theme to be the same as
>> > for choosing it again. Maybe the themes directory could have an
>> > "already installed" section, although I think the fact that I've
>> > installed a theme and moved on to another means I'm less interested in
>> > using it again.
>> >
>> > A dropdown would become kinda unmanageable with a large number of
>> > themes, unless there's a way to remove them, and not nearly as usable
>> > as the themes directory is now. What 

[chromium-dev] Re: gyp failing while triggering gclient sync in linux with git

[Mohamed Mansour]

What is stopping us doing "Massive" line endings commit for all the files in
our repository in src/chrome.
+1 on the presubmit check! Is there a way to force Visual Studio "Solutions"
or "Projects" to always save line endings in LF generated via gyp.

-- Mohamed Mansour


On Fri, Aug 7, 2009 at 1:48 AM, Bradley Nelson wrote:

> Yeah we should certainly handle this better.This was a known thing, but
> I've called it out in this gyp issue:
> http://code.google.com/p/gyp/issues/detail?id=38
>
> I do like have consistent line endings, but the error message leaves
> something to be desired (not to mention being different on each platform
> :-).
> Shouldn't be a big deal to fix.
>
> -BradN
>
>
> On Thu, Aug 6, 2009 at 10:39 PM, Evan Martin  wrote:
>
>> I am a little surprised that Python's "eval" isn't line-ending agnostic.
>> This thread
>>
>> http://mail.python.org/pipermail/pythonmac-sig/2004-September/011638.html
>> suggests it doesn't like \r even on Windows and offers a simple
>> workaround when reading the file:
>>  '\n'.join(s.splitlines())
>>
>> On Thu, Aug 6, 2009 at 9:28 PM, Bradley Nelson
>> wrote:
>> > Yes Mohamed, please do. Which files had the dos line endings?
>> > We should really add a presubmit check...
>> > -BradN
>> >
>> > On Thu, Aug 6, 2009 at 9:22 PM, Mohamed Mansour <
>> m0.interact...@gmail.com>
>> > wrote:
>> >>
>> >> Ah thank you Dan! It worked! I guess I should commit the line ending
>> then?
>> >> -- Mohamed Mansour
>> >>
>> >>
>> >> On Fri, Aug 7, 2009 at 12:17 AM, Dan Kegel  wrote:
>> >>>
>> >>> Please check to make sure the python scripts have UNIX
>> >>> line endings, not DOS ones.
>> >>
>> >>
>> >>
>> >
>> >
>> > >> >
>> >
>>
>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: gyp failing while triggering gclient sync in linux with git

[Mohamed Mansour]

Ah thank you Dan! It worked! I guess I should commit the line ending then?
-- Mohamed Mansour


On Fri, Aug 7, 2009 at 12:17 AM, Dan Kegel  wrote:

> Please check to make sure the python scripts have UNIX
> line endings, not DOS ones.
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: gyp failing while triggering gclient sync in linux with git

[Mohamed Mansour]

I don't believe I have any GYP_* env set:

m...@m0-desktop:~/chrome/src$ echo $PATH
~/chrome/depot_tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games


I don't have a directory called ~/.gyp/

m...@m0-desktop:~/chrome/src$ echo $PATH
~/chrome/depot_tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games


I got version 579

m...@m0-desktop:~/chrome/src/tools/gyp$ svn infoPath: .
URL: http://gyp.googlecode.com/svn/trunk
Repository Root: http://gyp.googlecode.com/svn
Repository UUID: 78cadc50-ecff-11dd-a971-7dbc132099af
Revision: 579
Node Kind: directory
Schedule: normal
Last Changed Author: gspen...@google.com
Last Changed Rev: 579
Last Changed Date: 2009-08-05 12:49:34 -0400 (Wed, 05 Aug 2009)


I really don't understand what is wrong.

-- Mohamed Mansour



On Fri, Aug 7, 2009 at 12:08 AM, Thomas Van Lenten 
 wrote:

> What version of GYP do you have in tools?
> Do you have any GYP_* env var set?
>
> Do you have anything in ~/.gyp/*
>
> TVL
>
>
> On Thu, Aug 6, 2009 at 11:58 PM, Mohamed Mansour  > wrote:
>
>> Tonight I was trying to sync my project so I did "git pull" and it worked
>> fine, then I did "gclient sync" as well as --force. But gyp is failing:
>>
>> m...@m0-desktop:~/chrome/src$ gclient sync found .git directory;
>> skipping src
>>
>>  running '/usr/bin/python src/tools/gyp/gyp_chromium' in
>> '/home/m0/chrome'
>> Updating projects from gyp files...
>> Traceback (most recent call last):
>>   File "src/tools/gyp/gyp_chromium", line 34, in 
>> sys.exit(gyp.main(args))
>>   File "src/tools/gyp/pylib/gyp/__init__.py", line 262, in main
>> params)
>>   File "src/tools/gyp/pylib/gyp/__init__.py", line 75, in Load
>> depth, generator_input_info)
>>   File "src/tools/gyp/pylib/gyp/input.py", line 1644, in Load
>> LoadTargetBuildFile(build_file, data, aux_data, variables, includes,
>> depth)
>>   File "src/tools/gyp/pylib/gyp/input.py", line 280, in
>> LoadTargetBuildFile
>> includes, depth)
>>   File "src/tools/gyp/pylib/gyp/input.py", line 280, in
>> LoadTargetBuildFile
>> includes, depth)
>>   File "src/tools/gyp/pylib/gyp/input.py", line 224, in
>> LoadTargetBuildFile
>> includes, True)
>>   File "src/tools/gyp/pylib/gyp/input.py", line 129, in LoadOneBuildFile
>> build_file_data = eval(build_file_contents, {'__builtins__': None},
>> None)
>>   File "/home/m0/chrome/src/chrome/third_party/hunspell/hunspell.gyp",
>> line 4
>>
>> ^
>> SyntaxError: invalid syntax
>> failed to run command: /usr/bin/python src/tools/gyp/gyp_chromium
>>
>>
>> I made sure I have no local changes (fresh out of git)
>>
>> m...@m0-desktop:~/chrome/src$ git log
>> commit 0954eb9b2987d50c54cb9c62ba3dfdeec1f1b01b
>> Author: gspen...@google.com > @0039d316-1c4b-4281-b951-d872f2087c98>
>> Date:   Fri Aug 7 03:38:01 2009 +
>>
>> This adds a stub for the mac installer so that the gyp generation
>> won't fail on Macs.
>> Review URL: http://codereview.chromium.org/165109
>>
>> git-svn-id: svn://svn.chromium.org/chrome/trunk/s...@22717
>>  0039d316-1c4b-4281-b951-d872f2087c98
>>
>>
>> But I still get the error. My "git status" is:
>>
>> m...@m0-desktop:~/chrome/src$ git status
>>
>> # On branch trunk# Untracked files:
>> #   (use "git add ..." to include in what will be committed)
>> #
>> # chrome/test/data/layout_tests/LayoutTests/
>> # valgrind-20090715/
>> # valgrind.tmp/
>> nothing added to commit but untracked files present (use "git add" to
>> track)
>>
>>
>> I really don't understand why it is happening, I diffed my hunspell.gyp
>> wrt to the version online and they are identical.
>>
>> Any help is appreciated, I would like to work a bit this weekend but
>> valgrind requires linux and I can't seem to gclient sync it :/
>>
>>
>> Thanks!
>>
>> -- Mohamed Mansour
>>
>> >>
>>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] gyp failing while triggering gclient sync in linux with git

[Mohamed Mansour]

Tonight I was trying to sync my project so I did "git pull" and it worked
fine, then I did "gclient sync" as well as --force. But gyp is failing:

m...@m0-desktop:~/chrome/src$ gclient sync found .git directory;
skipping src

 running '/usr/bin/python src/tools/gyp/gyp_chromium' in
'/home/m0/chrome'
Updating projects from gyp files...
Traceback (most recent call last):
  File "src/tools/gyp/gyp_chromium", line 34, in 
sys.exit(gyp.main(args))
  File "src/tools/gyp/pylib/gyp/__init__.py", line 262, in main
params)
  File "src/tools/gyp/pylib/gyp/__init__.py", line 75, in Load
depth, generator_input_info)
  File "src/tools/gyp/pylib/gyp/input.py", line 1644, in Load
LoadTargetBuildFile(build_file, data, aux_data, variables, includes,
depth)
  File "src/tools/gyp/pylib/gyp/input.py", line 280, in LoadTargetBuildFile
includes, depth)
  File "src/tools/gyp/pylib/gyp/input.py", line 280, in LoadTargetBuildFile
includes, depth)
  File "src/tools/gyp/pylib/gyp/input.py", line 224, in LoadTargetBuildFile
includes, True)
  File "src/tools/gyp/pylib/gyp/input.py", line 129, in LoadOneBuildFile
build_file_data = eval(build_file_contents, {'__builtins__': None},
None)
  File "/home/m0/chrome/src/chrome/third_party/hunspell/hunspell.gyp", line
4

^
SyntaxError: invalid syntax
failed to run command: /usr/bin/python src/tools/gyp/gyp_chromium


I made sure I have no local changes (fresh out of git)

m...@m0-desktop:~/chrome/src$ git log
commit 0954eb9b2987d50c54cb9c62ba3dfdeec1f1b01b
Author: gspen...@google.com 
Date:   Fri Aug 7 03:38:01 2009 +

This adds a stub for the mac installer so that the gyp generation won't
fail on Macs.
Review URL: http://codereview.chromium.org/165109

git-svn-id:
svn://svn.chromium.org/chrome/trunk/s...@227170039d316-1c4b-4281-b951-d872f2087c98


But I still get the error. My "git status" is:

m...@m0-desktop:~/chrome/src$ git status

# On branch trunk# Untracked files:
#   (use "git add ..." to include in what will be committed)
#
# chrome/test/data/layout_tests/LayoutTests/
# valgrind-20090715/
# valgrind.tmp/
nothing added to commit but untracked files present (use "git add" to track)


I really don't understand why it is happening, I diffed my hunspell.gyp wrt
to the version online and they are identical.

Any help is appreciated, I would like to work a bit this weekend but
valgrind requires linux and I can't seem to gclient sync it :/


Thanks!

-- Mohamed Mansour

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: [Chrome-team] Beware of any issues linking to trucountme.com

[Mohamed Mansour]

I was going to delete them when I saw them, but committers have no access to
delete posts :)  If only the issue tracker was open source, we could have
helped them implement it !
-- Mohamed Mansour


On Thu, Aug 6, 2009 at 12:19 AM, Ian Fette  wrote:

> Sadly there's about 60 of these, still cleaning them up. AFAIK there's no
> way for me to ban the user :(
> (Also, queuing up 60 tabs reminds me that I would really love a tab
> overflow solution :)
>
> 2009/8/5 Anthony LaForge 
>
> A friendly person appears to be spamming our issue tracker w/ a virus link.
>> Kind Regards,
>>
>> Anthony Laforge
>> Technical Program Manager
>> Mountain View, CA
>>
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: PSA: irc awareness [Was: Trick question: Who is "responsible" for repairing a red tree?]

[Mohamed Mansour]

I use Irssi so I do this:

/set bell_beeps ON/set beep_msg_level HILIGHT


When I used Mirc, I did this:

Options > Sounds > Enable event beepsOptions > IRC > Highlight > add your
name and trigger sound


-- Mohamed Mansour


On Wed, Aug 5, 2009 at 10:32 PM, Dimitri Glazkov wrote:

>
> On Colloquy (+ Growl), I set the toast with my name mentioned to never
> expire. So it's always there unless I "X" it out.
>
> :DG<
>
> On Wed, Aug 5, 2009 at 7:25 PM, Dirk Pranke wrote:
> >
> > I would love to enable that feature ... anyone know how to do that for
> > Adium on the Mac (IRC support is new in the 1.4 beta)?
> > Failing that, Colloquy?
> >
> > -- Dirk
> >
> > On Wed, Aug 5, 2009 at 5:48 PM, Marc-Antoine Ruel
> wrote:
> >> Most irc clients have an option to beep, flash or shutdown your computer
> >> when your nick is mentioned on a channel. It may not be enabled by
> default
> >> so please enable this. Ask around if you can't find how to enable this.
> >> Thanks,
> >> M-A
> >>
> >> On Wed, Aug 5, 2009 at 5:48 PM, Dan Kegel  wrote:
> >>>
> >>> On Wed, Aug 5, 2009 at 2:45 PM, Tim Steele wrote:
> >>> > you have to keep asking, unless you're always on IRC and can cleverly
> >>> > search
> >>> > the window contents.  A constant place to go looking for this would
> make
> >>> > it
> >>> > easier, at least in my opinion.  Like right now I don't know what's
> up
> >>> > with
> >>> > Chromium Mac (valgrind)
> >>>
> >>> You need to be on IRC and scroll back:
> >>>
> >>> [13:55] mac valgrind unit -> rohitrao?
> >>> [13:57]  dkegel: very likely
> >>> [13:58] emailed rohit
> >>> [14:02]   dkegel, jar: looking
> >>> [14:30]   jar, dkegel: reverted 22517
> >>>
> >>> I doubt anything more durable than IRC is going to help...
> >>> IRC and the tree status are the place to go, I'm afraid.
> >>>
> >>>
> >>
> >>
> >> >
> >>
> >
> > >
> >
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: new hunspell has tons of valgrind warnings... revert?

[Mohamed Mansour]

I am going to revert all the three suppression commits and the hunspell
change shortly.
-- Mohamed Mansour


On Mon, Aug 3, 2009 at 1:05 PM, Wan-Teh Chang  wrote:

>
> On Sat, Aug 1, 2009 at 2:54 PM, Dan Kegel wrote:
> >
> >
> http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/1671/steps/valgrind%20test:%20unit/logs/stdio
> > introduces 26 new unintialized memory references and two leaks.
> > That's a big enough batch that it might be a good idea
> > to revert it and commit something later that isn't full of warnings.
> >
> > Or we could just go la la la la la and suppress them all.
>
> Our Coverity static analyais on Aug 1 (Run 43, based on the
> "LATEST" revision at 2009-08-01 00:00:00 US Pacific Time)
> also reported many new defects in Hunspell.
>
> If you're on Google's intranet, you can look at these Coverity
> defects by logging into Coverity and clicking the "Hist. New Defects"
> link (it should say "75") for Run ID 43.
>
> Wan-Teh
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: I'm setting up my chromium account.

[Mohamed Mansour]

Hi,
If your source contents don't change, you can just copy the gcl_info
directory (chrome\src\.svn\gcl_info) and it will keep the change lists
intact.

If the source contents change after your new source tree, just upload them
to code review and fetch them back in when you got your clean tree. (you
still need the gcl_info folder contents if you want to keep the connection
between your cl's and rietveld)

Welcome to chromium :)

-- Mohamed Mansour


On Thu, Jul 30, 2009 at 12:56 AM, James Su  wrote:

> Hi,
>   I'm so happy that I just got my chromium account, and going to rebuild my
> local source tree with writable svn repository. But I have some pending CLs
> in my old readonly source tree, so I'm wondering is it possible to migrate
> those CLs to a new source tree?
>
> Regards
> James Su
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Can someone compile this patch for me?

[Mohamed Mansour]

Very nice, it passed all the try bot! I am adding Evan Marting and Evan
Stade to the reviewers! Thanks for your patch!
-- Mohamed Mansour


On Sun, Aug 2, 2009 at 11:11 PM, Anand Mistry  wrote:

> Thanks to all.  I didn't know about the try bot, so I've posted the patch
> for review and I'm watching the buildbot.
>
> On Mon, Aug 3, 2009 at 12:15 PM, Joel Stanley  wrote:
>
>> Hello,
>>
>> On Mon, Aug 3, 2009 at 11:35, Anand Mistry wrote:
>> > Hi all,
>> > I don't have the resources (disk space + tools) to compile my patch
>> under
>> > Windows and OSX, so can someone on this list quickly try it before I
>> post it
>> > for review?  And on Windows, do a sanity check on the about:memory page.
>> >  Patch is attached.
>>
>> The linux memory reporting code is something I have been working on
>> recently, thanks for taking it further.
>>
>> If you upload the patch to codereview.chromium.org, one of the
>> chromium devs can submit it to the tryservers which build for all
>> supported platforms.  This process is also used for code review rather
>> than submitting patches to the mailing list.
>>
>> http://dev.chromium.org/developers/contributing-code
>>
>> Cheers,
>>
>> Joel
>>
>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Can someone compile this patch for me?

[Mohamed Mansour]

Hello, thanks for the patch, but if you post it on the code review site, we
can send it to the try servers where it will build / test it for you.  It is
easier to apply the patch through code review than manually.
-- Mohamed Mansour


On Sun, Aug 2, 2009 at 10:05 PM, Anand Mistry  wrote:

> Hi all,
> I don't have the resources (disk space + tools) to compile my patch under
> Windows and OSX, so can someone on this list quickly try it before I post it
> for review?  And on Windows, do a sanity check on the about:memory page.
>  Patch is attached.
>
> Thanks,
> - Anand
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: new hunspell has tons of valgrind warnings... revert?

[Mohamed Mansour]

I was aware of that from last night. =(
Many suppressions, http://pastebin.com/m3b8f744f  I am trying to learn about
valgrind through the documentation,
http://dev.chromium.org/developers/how-tos/using-valgrind, and it seems its
Linux related, so I booted in Linux and installed all the valgrind tools.
I get the following error, but the syntax seems right:
m...@m0-desktop:~/chrome/src$ sh tools/valgrind/valgrind.sh
tools/valgrind/valgrind.sh: 23: Syntax error: "(" unexpected (expecting "}")

As well, doing the following but got a different error
http://pastebin.com/m6464a279:
$ sh tools/valgrind/chrome_tests.sh -t unit

Trying to get some help on what to do on IRC, but its long weekend.

All the suppressions are similar, I don't understand fully what to do. The
call stack all point to the thirdparty hunspell code not our ifdefs.

If anyone knows about valgrind and willing to help, I will be on IRC. This
hunspell update is needed for 3.


-- Mohamed Mansour


On Sat, Aug 1, 2009 at 5:54 PM, Dan Kegel  wrote:

>
>
> http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/1671/steps/valgrind%20test:%20unit/logs/stdio
> introduces 26 new unintialized memory references and two leaks.
> That's a big enough batch that it might be a good idea
> to revert it and commit something later that isn't full of warnings.
>
> Or we could just go la la la la la and suppress them all.
>
> Either way, we need the tree to go green.
>
> Opinions?
> - Dan
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?

[Mohamed Mansour]

I thought all those cc's from code reviews, is about the last couple of
people who edited that part of the code in the past. I have been getting a
couple of code reviews cc's and the code I was cc'd is what I have touched
within a month or so.
I could imagine Ben receiving a ton of reviews, he touched almost all
browser code base.


-- Mohamed Mansour


On Fri, Jul 31, 2009 at 8:44 PM, Rahul Kuchhal  wrote:

> I thought to: and -cc: would work in this case? Have you tried
> using that in "Has the words" on Filter edit screen?
>
> On Fri, Jul 31, 2009 at 5:18 PM, Brett Wilson  wrote:
>
>>
>> I added myself to some watchlists and I get a bunch of email about a
>> lot of reviews
>>
>> But this has confused my Gmail filters, which automatic ally label and
>> archive code reviews not addressed directly to me, and all of my CCd
>> code reviews show up in my inbox.
>>
>> Anybody know how to reliably detect the difference between "I'm the
>> reviewer" and "I'm CC'd on a review" in a Gmail filter?
>>
>> Brett
>>
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: browser/sync is moving in

[Mohamed Mansour]

Awesome! Many people will like this.
-- Mohamed Mansour


On Fri, Jul 31, 2009 at 6:08 PM, Tim Steele  wrote:

>
> Yep, what Peter said.  In the coming weeks, we will check in the full
> protocol definition itself, which is what we used to build the Google
> service for Google Chrome users.
>
>
> On Fri, Jul 31, 2009 at 3:05 PM, Peter Kasting wrote:
>
>> On Fri, Jul 31, 2009 at 3:04 PM, Mohamed Mansour wrote:
>>
>>> So we are going to tie up Chromium sync to just Google Services? Why not
>>> make the protocol open so any service could use it.
>>
>>
>> The protocol _is_ open.  Protobufs are open source and the sync spec built
>> on them is also open source.
>>
>> PK
>>
>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: browser/sync is moving in

[Mohamed Mansour]

So we are going to tie up Chromium sync to just Google Services? Why not
make the protocol open so any service could use it. So if anyone wants to
sync, they will install an extension to do so, instead of coupling it
directly to Google services.
-- Mohamed Mansour


On Fri, Jul 31, 2009 at 5:14 PM, Peter Kasting  wrote:

> On Fri, Jul 31, 2009 at 2:07 PM, Tim Steele  wrote:
>
>> Check out the sync developer 
>> page<http://sites.google.com/a/chromium.org/dev/developers/design-documents/sync>
>>  if
>> you're interested in low-level goals and technical details.
>>
>
> Since I suspect it will be a FAQ:
>
> According to that webpage, this currently only syncs bookmarks.  More data
> types may come some day.  (Personally, I hope they do.  I'm more interested
> in history/visited link/omnibox syncing than bookmarks.)
>
> PK
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: PSA: Consider upgrading to VS2008.

[Mohamed Mansour]

Are we planning to remove ATL so we can make Express people happy. We can do
a project plan and figure out a timeline on how to remove ATL. It will make
many people happy.
-- Mohamed Mansour


On Fri, Jul 31, 2009 at 2:01 PM, Ben Goodger (Google) wrote:

>
> A few changes are coming soon that mean using VS2008 is desirable:
>
> - /MP will be enabled by default for VS2008 debug builds, which will
> make your builds faster on newer multicore machines without you having
> to patch any files in your local tree.
> - We will eventually update the required SDK to the Windows 7 SDK. For
> this to work in VS2005 an additional hotfix is required.
>
> VS2005 will remain our base supported system however these benefits
> make upgrading to VS2008 desirable (especially if you are getting new
> hardware that needs everything to be set up on it anyway).
>
> -Ben
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Print Settings Mockup

[Mohamed Mansour]

Hi all,
I am looking into this again, and we implemented the "print:
http://www.google.com"; hookup functionality into chromium (ToT). So far it
just shows a webpage.

I am trying to figure out how we could bring the image in there,  so I
worked on this CL (http://codereview.chromium.org/159387) which introduces
the concept of "chrome://image/http://www.google.com";, where it fetches the
image from the current tab and places it on the domui. I got the idea from
another CL for extensions (http://codereview.chromium.org/144019).

The problem is that, we can't rely on that approach because of the following
(Gathered from extension code review comments):

Aaron Boodman said:

 That is an interesting idea. There would be a few challenges, though:

- We need a way to specify the desired format, size, etc. I guess they
could be querystring params?
- For printing in particular, it seems important to print the exact
thing the user sees, not re-request the URL

Without a solution to the second issue, I don't think the chrome://
URL idea is workable. But I do think that the code we used to
implement this extension API could easily be reused for for print
preview.



Erik Kay stated:

The way this code is currently written, it just grabs the backing store from
the current visible tab.  This means that it's the same size as the viewport
on the visible tab, no new layout happens.

Given this, I don't think this could be made to work with printing.  The two
obvious problems are the my browser width might not match paper width, and
that anything that's outside of the viewport (scrolled) won't be visible in
the preview.



I really don't know how to bring over the "printed" image, maybe because I
am inexperienced in the language, and I am asking for advice on what
approach should I take?

I want to reuse the same functionality of printing but what is the best way
to bring that image into the DOMUI. I tired with the chrome://image/url
approach, but as Erik and Aaron stated above, it wont work.

If you guys have the UI mockup of the settings, I could implement that now,
but since our previous comments, it is directly hooked up to the Print
Preview.

Any guidance is appreciated :)

-- Mohamed Mansour


On Tue, Jun 9, 2009 at 9:50 PM, Nick Baum  wrote:

>
>
> On Fri, Jun 5, 2009 at 9:03 PM, Mohamed Mansour 
> wrote:
>
>> I really like the mock-up, when can you do one for Settings?
>
>
> I'll put it on our list, but I don't expect to get to this in the next
> couple of weeks. In general, we try not to block engineers on UI, so if you
> make good progress on the preview, we'll prioritize this higher.
>
>>
>> If we are going to include settings to this page (such as margins,
>> headers, footers, etc), does that mean it would be per page? I was thinking
>> of global printer settings which will be persistent. I don't know how that
>> will fit this mock-up, or we could have both. We could have a dialog which
>> sole purpose is for printer settings and the inline page for per page
>> settings/preview customization. The inline page can have a link to the
>> global settings if needed.
>>
>
> I think the settings should just be global and sticky (just like default
> printer on the mac: it just uses the last one you used). Most people
> probably don't want to change print settings when they're not printing.
>
>>
>> That will seem to be too crowded, and my vision would be incorporating all
>> this (preview and settings) into the same page. I am just wondering how the
>> UI's team vision is, wrt to settings. Would be nice to see.
>>
>> We already started with Headers/Footers data persistence in a previous CL.
>> And would like to have a UI that will  let the user interact with such data
>> instead of editing the Preference file directly. Later on we could start the
>> print preview implementation, which I "think" is challenging.
>>
>
>
> I think Ben's opinion was that the preferences would be hard to understand 
> without the preview, so we should do the preview first. I can't comment on 
> the difficulty of it :)
>
>>
>>
>> -- Mohamed Mansour
>>
>>
>>
>> On Thu, Jun 4, 2009 at 9:12 PM, Nick Baum  wrote:
>>
>>> Hi guys,
>>> I've attached an old print settings mock up from
>>> Glen. I think it'd make a lot
>>> of sense to add the print settings on this page as well.
>>>
>>> If someone wants to take a stab at the print preview as pictured here, I
>>> think that'd be a great first step. Once we have that working, I'd be happy
>>> to mock up some ideas for settings.
>>>
>>> C

[chromium-dev] Re: WebContents class in chromium?

[Mohamed Mansour]

That article is not updated. WebContents is dead, there was a mail about it
couple of months ago, can't find it on chromium-dev seems to be lost, but
its here:
http://www.mail-archive.com/chromium-dev@googlegroups.com/msg03528.html

-- Mohamed Mansour


On Sat, Jul 25, 2009 at 7:27 PM, n179911  wrote:

>
> Hi,
>
> For
> http://dev.chromium.org/developers/how-tos/getting-around-the-chrome-source-code
> ,
> it said
> For web content, this specialization is WebContents in
> chrome/browser/web_contents.cc. There are also a few other types for
> more specialized tabs. We will assume we are creating a web page.
>
> But I checkout chromium source code, but I can't find the file
> web_contents.cc or I can't find the class WebContents anywhere.
> Can you please tell me what 'tab content' are created for Web content now?
>
> Thank you.
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Proposal for adding ChangeLog files to Chromium

[Mohamed Mansour]

I like Scott's idea, if you think your patch is ChangeLog worthy, add some
sort of "release-note-worthy" key on the bottom of the  commit description.
And as Peter stated, make sure the first line of the commit message is very
descriptive that explains what this release note worthy message is really
about.

I believe those two approaches will make it easier for the developers and
the managers to produce release notes. A simple script (python since you all
like python) could read the log since the last release and correctly parse
out "release-note-worthy"

Maybe modify bugdroid to parse out "release-note-worthy" and send an email
to the people responsible everytime that is there.

-- Mohamed Mansour


On Wed, Jul 22, 2009 at 3:48 PM, Jeremy Orlow  wrote:

> It sounds like better CL descriptions will make most of the problems go
> away.  Ojan started a new thread about this.
> If people don't put BUG='s in their CL descriptions or won't use the
> RELEASE_NOTES annotation, there's no hope for them using a ChangeLog.
>
> Is this dead horse sufficiently beaten?  :-)
>
> J
>
>
> On Wed, Jul 22, 2009 at 12:32 PM, Jon  wrote:
>
>> If you don't want to see this thread anymore you can use the 'm' shortcut
>> to mute it.
>> If you don't have a BUG in your commit comment then we probably won't even
>> see your CL and it won't make the release notes.
>>
>> It would be enough, IMHO, to have the first line of your commit comment
>> describe the change in a way that makes it clear that it should be
>> highlighted in the release notes.
>>
>> A tag would be even better, but I understand all that extra typing can be
>> tiresome.
>>
>> Anthony was not looking for a CHANGE_LOG like WebKit which included each
>> CL.  We already provide a link to all the CL 
>> comments<http://build.chromium.org/buildbot/perf/dashboard/ui/changelog.html?url=/trunk/src&range=20903:21176&mode=html>for
>>  a release.  He was looking for an entry to a file each time you have
>> something release note worthy.  My experience is that we have about 5 items
>> that rise to this level with each release.
>>
>> If you don't want to do any of these things then you should subscribe to
>> cr-rel-notify so you can see the proposed blog entry before it goes out.
>>  Then you can let us know when we have missed something interesting.
>>
>> Jon
>>
>>
>> On Wed, Jul 22, 2009 at 11:47 AM, Scott Hess  wrote:
>>
>>>
>>> BTW: if people aren't annotating their CL's with bugs, they SURELY
>>> won't annotate them with release notes or update the change log.  Just
>>> aiming for the path of least resistance, here.
>>>
>>> -scott
>>>
>>>
>>> On Wed, Jul 22, 2009 at 11:46 AM, Scott Hess wrote:
>>> > The stuff I'm implementing is important to _me_, but is it important
>>> > enough to be in the release notes?
>>> >
>>> > Maybe we should have a tag for the issue-tracker which indicates that
>>> > the issue is release-note-worthy, and we could use action on those
>>> > bugs to help figure out which items are worthy of being in the release
>>> > notes?  Then if someone complains that their change didn't make the
>>> > release notes, we can tell them how to arrange for that in the future.
>>> >  From there, regular bug triage activities may suffice to work it down
>>> > to a reasonable volume.
>>> >
>>> > -scott
>>> >
>>> >
>>> > On Wed, Jul 22, 2009 at 11:33 AM, Anthony LaForge
>>> wrote:
>>> >> (Warning: TPM perspective) The main problem with the current system is
>>> that
>>> >> it's a very time consuming process to parse through ~1000 revisions
>>> each
>>> >> week.  Even with filter tools which parse the SVN logs and look for
>>> >> revisions with closed bugs, specific keywords in the logs, specific
>>> files,
>>> >> auto-discarding reverts, etc... that still brings us down to about 150
>>> >> entries that require manual review.  Of those, a good portion are
>>> >> not immediately clear from either the bug title or the SVN summary as
>>> to
>>> >> exactly what the fix was for, which requires extra detective work.
>>>  Once
>>> >> that's done we end up re-writing/ clarifying the text.  Even with all
>>> that
>>> >> effort I'm not 100% satisfied that we're com

[chromium-dev] Re: Mozilla design challenge

[Mohamed Mansour]

Can't we have some similar challenge in Chromium for the domui pages? It
would be nice to have challenges such as, design the new downloads ui page,
history page, or even the new print preview and settings page, etc...
Would be nice to see what the users can do if they edit domui pages. Then
the UI team (or rest of chromium devs or even the world) will decide which
is worth implementing or including in the release.

-- Mohamed Mansour


On Tue, Jul 21, 2009 at 1:01 PM, Peter Kasting  wrote:

> On Tue, Jul 21, 2009 at 9:52 AM, Amanda Walker wrote:
>
>> On Tue, Jul 21, 2009 at 12:32 PM, Erik Kay wrote:
>> > In my use case, 80% of my tabs could easily be killed / suspended (or
>> even
>> > hidden altogether) without any downside to me.  The problem is that
>> there
>> > isn't a way to automatically figure out which ones are which.  Which
>> ones
>> > have pending state that might be lost?
>>
>> Well, to a first approximation, ones which have had user interaction
>> besides scrolling since they were opened? (typing, navigating a link,
>> etc.)
>>
>
> I frequently avoid interacting with articles from popular news sites for
> thirty seconds or so (as they sit in the background) to let their stupid
> interstitial ad timeouts fire.
>
> Scott Hess' comment that some tabs could be changed into static documents
> is accurate from a UX perspective, but as this thread has already mentioned
> it's hard to decide which tabs those are.  For example, today we load tabs
> opened from gmail in the same renderer process as gmail because we don't
> realize that those two pages are never going to script each other.  If we
> don't know page A and page B won't script each other, how can we freeze A or
> B?  To put it even more simply, if given a tab A, how do we know it won't
> run script at some point in the future?
>
> My own claim is that multiselection of tabs is implementable and useful,
> and we should start by implementing that (which in fact Ben is currently
> doing, I think), and then see if it helps any of our organization issues.
>  After that, perhaps some concept of tab pinning would be useful.  The idea
> here is to add things we know we can do in hopes that better usage patterns
> emerge, instead of trying to envision the ideal design from nothing :)
>
> PK
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Unable to download Chrome Source Code

[Mohamed Mansour]

It is explained here, read the section regarding "To check out directly from
SVN:":http://dev.chromium.org/developers/how-tos/get-the-code

Or you could use the awesomeness git.
http://code.google.com/p/chromium/wiki/UsingGit

<http://dev.chromium.org/developers/how-tos/get-the-code>
-- Mohamed Mansour


On Tue, Jul 21, 2009 at 2:04 AM, Pradeep  wrote:

>
> Hi Nakro,
>
> Thank you for the reply..
>
> Can you please guide me through the procedure to download via gclient
> tool, since I found no info regarding same on the website.
>
> Regards
> Pradeep
>
>
> On Jul 21, 1:20 am, nakro  wrote:
> > Pradeep, i was also never able to download the source via the tarball
> > what i did in the end was use gclient sync
> >
> > as it continues from where it left off, if the download is interrupted
> > also a friend of mine could only get the source code like this
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Buildbot performance issue.

[Mohamed Mansour]

I would like to see auto refresh turned off by default. That might help the
load.
-- Mohamed Mansour


On Tue, Jul 14, 2009 at 7:15 PM, Michael Nordman wrote:

> Turning off auto refresh by default sounds reasonable idea right now...
> with an option to enable it if really desired... &autorefresh[=] where n
> is a number of minutes maybe (defaults to 1) type thing.
> A fair amount of the load may just evaporate with that change.
>
>
>
> On Tue, Jul 14, 2009 at 3:32 PM, Jeremy Orlow  wrote:
>
>> On Tue, Jul 14, 2009 at 2:42 PM, Adam Langley  wrote:
>>
>>>
>>> On Tue, Jul 14, 2009 at 2:40 PM, Albert J. Wong
>>> (王重傑) wrote:
>>> > That is pretty nuts.  Is it calling fsync or something crazy?  Since
>>> you
>>> > said strace, I'm assmuming linux. In that case, the buffer cache should
>>> be
>>> > saving you from disk accesses for most everything.
>>>
>>> Of course, vmstat 1 will tell you what disk IO is happening. If you
>>> don't have noatime, that would probably be good.
>>
>>
>> atop is a really nice program for getting a birds eye view of what's going
>> on with the system.  It's not installed by default, but if you're running
>> ubuntu, it's easy to install.
>>
>>
>> More generally: I think there are a couple uses of the build bots:
>> 1) Most people just want to know "can I commit" and then are watching one
>> specific CL's status.  In this case, not auto-refreshing is fine and not
>> much history is fine.
>> 2) Sheriffing is the one case where I think you actually do need
>> auto-refreshing, but normally you don't need a lot of history.  That said,
>> sometimes things fail and then
>> 3) You're trying to fix things:  In this case you want to see a lot of
>> history (or at least need the option to see more) and you do NOT want it to
>> auto refresh.  I've definitely had times when I wish there was a "show me
>> more" button.  And I've definitely have been reading something far down the
>> page only to have it refresh on me.
>>
>> It seems to me that these requirements are diverse enough that one single
>> configuration isn't going to make everyone happy.  I know you can do a bunch
>> of customization so you can see exactly what you want, but I assume that
>> will only chew up more resources.  Maybe the right way to go is a couple
>> customized pages for each roll?  There's definitely much more information
>> there than people need most of the time, though.
>>
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: LayoutTest unexpected success

[Mohamed Mansour]

Lets wait a bit before re-enabling tests, but they seem to act happy, unlike
last night. If no one re-enables them, I can do it when I get home around 6
EST.
-- Mohamed Mansour


On Tue, Jul 14, 2009 at 8:24 AM, Amanda Walker  wrote:

>
> On Tue, Jul 14, 2009 at 3:38 AM, Adam Barth wrote:
> > Expected to crash, but passed (9):
> >  LayoutTests/fast/dom/offset-parent-positioned-and-inline.html
> >  LayoutTests/fast/events/message-channel-gc-2.html
> >  LayoutTests/fast/events/message-channel-gc-4.html
> >  LayoutTests/fast/events/message-channel-listener-circular-ownership.html
> >
>  LayoutTests/fast/events/message-port-constructor-for-deleted-document.html
> >  LayoutTests/fast/events/message-port-deleted-frame.html
> >  LayoutTests/fast/events/mouseover-mouseout2.html
> >  LayoutTests/fast/images/favicon-as-image.html
> >  LayoutTests/fast/images/pdf-as-background.html
>
> These started failing late yesterday afternoon--I'd double check to
> make sure they're actually happy again before re-enabling them.
>
> --Amanda
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Meeting Notes From 2/9/2009 Now Posted!

[Mohamed Mansour]

An OWP seems an excellent thing. The thing is, there seems to be a
separation between internal Google developers and External developers. For
instance, we are not brought into the loop regarding some processes. I know
some of you use the mailing list to bring out ideas which is awesome, and do
a discussion. But many features just come out of nowhere. Would be cool to
know the path of what chromium is going to become (I know stability,
security, etc, etc), and our (external) voice would matter on how the
development / discussion is going. More involvement into the project would
be better than just being considered as a "programmer" only.
Some projects do weekly or biweekly quick online meetings on IRC. Its
productive because its like a quick weekly scrum where we discuss next
release goals etc etc. I don't know how Chromium is organized or if it
applies to us.

-- Mohamed Mansour


On Fri, Jul 10, 2009 at 12:48 AM, Brian Rakowski  wrote:

> We stopped posting because (a) the notes seemed not to be very useful out
> of context and (b) removing any Google-specific info, though it was minimal,
> was pretty labor intensive. I think it may be more productive to try to keep
> some public roadmaps and tasklists updated. Ian is working on creating an
> OWP roadmap that will be updated weekly with the status of the main areas of
> work. If that works out, perhaps we can do the same for other areas of the
> project. It seems like that would be more helpful and also more practical.
> Does that seem like it would meet the needs of the external developers? I
> want to make sure contributors have the info they need to be productive, but
> I don't want to create unnecessary work.
> Brian
>
>
> On Thu, Jul 9, 2009 at 8:10 PM, Evan Stade  wrote:
>
>>
>> Is it possible to continue posting these? external developers have
>> requested it.
>>
>> -- Evan Stade
>>
>>
>>
>> On Wed, Feb 11, 2009 at 10:18 AM, Peter Kasting
>> wrote:
>> > On Tue, Feb 10, 2009 at 6:19 PM, Glenn Wilson 
>> wrote:
>> >>
>> >> Meeting notes from February 9, 2009 are now posted on the Chromium
>> >> developer documentation:
>> >>
>> >>
>> http://sites.google.com/a/chromium.org/dev/developers/meeting-notes#02092009
>> >> Please contact me if you have any questions, and enjoy!
>> >
>> > It might be nice to post these on a blog somewhere, primarily so they
>> can be
>> > grabbed via RSS; various Mozilla meeting notes are posted this way.
>> >
>> > PK
>> > >
>> >
>>
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Issue Fixed status

[Mohamed Mansour]

Thiago, I believe a better approach is replying back on that issue tracker
instead of in dev mailing list. The owner of the bug will receive an email
if you reply stating if it has been fixed.
-- Mohamed Mansour


On Thu, Jul 9, 2009 at 1:03 PM, Thiago Farina wrote:

>
> I think there is another issue:
> http://crbug.com/3215
>
> On Jul 9, 1:27 pm, dhhwai  wrote:
> > Jay's on the ball and has updatedhttp://crbug.com/15833
> >
> > On Jul 9, 7:43 am, Thiago Farina  wrote:
> >
> >
> >
> > > Thanks dhhwai!
> >
> > > I found another one.
> >
> > > This issue was committed, but the status is assigned, so I'm not sure
> > > if it has to be marked as fixed:http://crbug.com/15833
> >
> > > On Jul 9, 3:52 am, dhhwai  wrote:
> >
> > > > I have followed up and/or closed the above issues as appropriate.
> >
> > > > I expect Glen will update the status forhttp://crbug.com/5354assoon
> > > > as he has committed the patch.
> >
> > > > On Jul 8, 8:31 pm, Thiago Farina  wrote:
> >
> > > > > Hi dhhwai,
> >
> > > > >http://crbug.com/661http://crbug.com/5288
> >
> > > > > For this particulary issue, I've submitted the patch to Glen, so
> I'm
> > > > > waiting for he commit to me.http://crbug.com/5354
> >
> > > > > The flicker event in this issue still occuring, but the menu closes
> on
> > > > > second click.http://crbug.com/6242
> >
> > > > > These are the issues that I can remember now.
> >
> > > > > On Jul 8, 5:03 pm, dhhwai  wrote:
> >
> > > > > > Issue 7863 is fixed now.  We can ask the fix committers to review
> the
> > > > > > status of other unfixed issues.
> >
> > > > > > Do you have the issue numbers of other such issues?  You can list
> them
> > > > > > individually like:  http://crbug.com/N
> >
> > > > > > On Jul 8, 7:45 am, Thiago Farina 
> wrote:
> >
> > > > > > > I noticed that the Issue 7863, that me and jcampan, we fixed,
> are
> > > > > > > available until now. I saw there are some other Issues are with
> the
> > > > > > > status: Available, but already well fixed.
> >
> > > > > > > So some issues are being fixed but are not being updated in the
> Issue
> > > > > > > List.
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Reviewers

[Mohamed Mansour]

What I do is check the blame list (svn blame) for the files I touched.
-- Mohamed Mansour


On Mon, Jul 6, 2009 at 10:47 PM, Thiago Farina wrote:

>
> When I don't know who can review some patch for me what I have to do?
>
> Currently I have 3 patchs waiting for review, but I haven't received
> any feedback or contact until now.
>
> What I have to do in this cases?
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Any way to search rietveld issues?

[Mohamed Mansour]

The best way to search rietveld is through google groups:
http://groups.google.ca/group/chromium-reviews

<http://groups.google.ca/group/chromium-reviews>As far as I know ;x

-- Mohamed Mansour


On Mon, Jul 6, 2009 at 7:37 PM, Marshall Greenblatt
wrote:

> Hi All,
>
> Is there any way to search rietveld issues?  For instance, I would find it
> particularly useful if I could search for all open issues that touch certain
> source paths.
>
> Thanks,
> Marshall
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Some projects are always out of date

[Mohamed Mansour]

I always have this issue with the exact same projects (3 mentioned above), I
just build them anyways. Even if I clobber Debug folder, I still get them.
I don't know what is causing it, but its quick rebuild so it doesn't hurt
development that much.

-- Mohamed Mansour


On Sun, Jul 5, 2009 at 7:46 PM, Ben Goodger (Google) wrote:

>
> +BradN
>
> BTW, I think GYP is broken somehow, random different projects each
> time. Solution is always rm -rf Debug/. This is painful on most
> hardware.
>
> I'm escalating this if it's not already - Brad, are you aware of this
> issue?
>
> -Ben
>
> On Sun, Jul 5, 2009 at 9:31 AM, Finnur Thorarinsson
> wrote:
> > Yeah, I've had this happen a few times -- not these projects
> specifically,
> > but for example when Visual Studio wants to build Webcore every time I
> make
> > a change in the browser project. Most annoying, but usually it goes away
> if
> > I rebuild.
> > I would therefore suggest gclient sync and rebuild all. It will take some
> > time, of course, so plan accordingly. :)
> >
> > On Fri, Jul 3, 2009 at 20:10, Hua  wrote:
> >>
> >> Hi,
> >> Every time I hit F5 in VS2005, it will pop up a dialog say:
> >>
> >> These projects are out of date:
> >>cygwin - Debug Win32
> >>ffmpeg_binaries - Debug Win32
> >>lastchange - Debug Win32
> >> Would you like to build them?
> >> ...
> >>
> >> If I choose to build them, they will be built in a minute or so and
> >> then Chrome runs. But next time I hit F5 again (without any code
> >> changes), the same dialog will be shown again.
> >>
> >> Anyone else run into this?
> >>
> >> --
> >> Hua
> >>
> >>
> >
> >
> > >
> >
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Creating DOMUI for print preview and setup

[Mohamed Mansour]

Hi all,

I am trying to create a DOM UI for print preview and setup, so when we visit
print:http://www.google.ca it will bring up the PrintUI DOM page. I was
starting to implement it couple of days ago and I couldn't seem to make the
connection work.
I have followed view-source technique as well as history/downloads/newtab
DOMUI technique and did the following cl:

   - Creating the foundations for PrintUIDOM:
   http://codereview.chromium.org/150207
   - PrintUIDOM Implementation: http://codereview.chromium.org/155067


<http://codereview.chromium.org/150207>What happens is that when I visit
print:http://www.google.com it redirects to http://www.google.com and
doesn't show the print test page that the DOM has placed.

Any assistance is appreciated. I am an external contributor and I am stuck
on why its doing this. I thought the DOMUI Factory will deal with all this
stuff and appropriately handle the TabContents from the DOMUI I supply it
with.

Any ideas where I went wrong? The CL is quite small above.

Thanks
-- Mohamed Mansour

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: F5 Debug process

[Mohamed Mansour]

Would be nice if we can make multiprocess build (/MP) integrated with gyp.
Don't know how that could be done.
-- Mohamed Mansour


On Fri, Jul 3, 2009 at 2:10 PM, Jeremy Orlow  wrote:

> Actually, there are a couple spots to edit:
> http://codereview.chromium.org/155057  -- maybe more
>
> Is it time to make this default yet?  It speeds up the build considerably
> and almost everyone uses it now.  It does make things a bit less
> deterministic, but you can always clobber build if something gets into a bad
> state.  And it's _much_ faster.
>
> J
>
>
> On Fri, Jul 3, 2009 at 10:22 AM, Tommi  wrote:
>
>> Don't know if this is what most do but I ended up adding it to
>> build\common.gpyi (line 471 in my case)
>> ...
>>   'VCCLCompilerTool': {
>> *'AdditionalOptions': '/MP',*
>> 'MinimalRebuild': 'false',
>> 'ExceptionHandling': '0',
>> 'BufferSecurityCheck': 'true',
>> 'EnableFunctionLevelLinking': 'true',
>> 'RuntimeTypeInfo': 'false',
>> 'WarningLevel': '3',
>> 'WarnAsError': 'true',
>> 'DebugInformationFormat': '3',
>>   },
>> ...
>>
>> If that's not what everyone else is doing, please let me know.
>>
>> On Fri, Jul 3, 2009 at 1:11 PM, PhistucK  wrote:
>>
>>> Where exactly do I add "/MP" (using Visual Basic Professional 2005)? (I
>>> know extremely little about the whole environment..)
>>>
>>>
>>> Thank you.
>>>
>>> ☆PhistucK
>>>
>>>
>>>
>>> On Fri, Jul 3, 2009 at 20:08, Peter Kasting wrote:
>>>
>>>> On Fri, Jul 3, 2009 at 9:32 AM, Mohamed Mansour wrote:
>>>>
>>>>> It depends on the machine you have. CPU power. HD etc. ... If you have
>>>>> incremental build turned on /MP it will take less time to compile as well.
>>>>>
>>>>
>>>> Note: /MP is "multiprocess build", not "incremental build".
>>>>
>>>> PK
>>>>
>>>
>>>
>>>
>>>
>>
>> >>
>>
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: F5 Debug process

[Mohamed Mansour]

It depends on the machine you have. CPU power. HD etc. ... If you have
incremental build turned on /MP it will take less time to compile as well.
-- Mohamed Mansour


On Fri, Jul 3, 2009 at 12:26 PM, PhistucK  wrote:

> At least in Visual Studio 2005, you can right click on the solution and in
> "Configuration Options" (or something like that), you can select what to
> build and what not to build.It does speed up the compiling process by at
> least half (for me). It still, generally, takes a lot of time.
>
> ☆PhistucK
>
>
>
> On Fri, Jul 3, 2009 at 19:21, Thiago Farina wrote:
>
>>
>> Anyone knows how to speed up the process of debugging chromium in
>> Visual Studio 2008?
>>
>> Everytime I click in F5 to start debugging chromium it takes a long
>> time to compile and build project test with him.
>>
>> How can I avoid the project tests like ipc_tests,
>> interactive_ui_tests, perf_tests, etc, are compiled with chrome(exe)
>> project?
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: Trac

[Mohamed Mansour]

Since I am external, it would be nice to have access to the git web
interface. Trac seems too heavy weight, slow, and too crowded in my opinion.
ViewVC is great, maybe apply some sort of patch to ViewVC of what Darin has
done (which is very cool) and very useful.

-- Mohamed Mansour


On Thu, Jul 2, 2009 at 12:12 PM, Erik Kay  wrote:

> +evan
>
> Have any of you tried Evan's git web interface (sorry, it's currently
> inside google only)?  It's really fast, and very nice (although it appears
> to be a bit stale now).  Perhaps it would be worth it to set that up
> externally as an alternative to viewvc.
> Erik
>
>
> On Wed, Jul 1, 2009 at 9:32 PM, Eric Seidel  wrote:
>
>>
>> I will note that in WebKit's experience Trac is super-slow (at least
>> the version webkit.org is using).  Trac does not seem to do much (if
>> any) caching.
>>
>> -eric
>>
>> On Wed, Jul 1, 2009 at 7:27 PM, Jeremy Orlow wrote:
>> > Is there any reason we use ViewVC rather than something like trac (for
>> > example, trac.webkit.org)?  I wouldn't exactly call Trac amazing, but
>> there
>> > are a few cool features that I definitely missin ViewVC.
>> > J
>> > >
>> >
>>
>>
>>
>
> >
>

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---