svn commit: r24542 - /release/incubator/pulsar/KEYS

[hrsakai]

Author: hrsakai
Date: Tue Jan 30 07:21:49 2018
New Revision: 24542

Log:
Added gpg key for hrsakai

Modified:
release/incubator/pulsar/KEYS

Modified: release/incubator/pulsar/KEYS
==
--- release/incubator/pulsar/KEYS (original)
+++ release/incubator/pulsar/KEYS Tue Jan 30 07:21:49 2018
@@ -320,3 +320,62 @@ XDQkrodkTVOU/Qb6mMuix6/akdYtVIYKW9ZIJQ4g
 MYODllZTADQ/6omtfGFTjzD0/iE85VN5sw==
 =dDeQ
 -END PGP PUBLIC KEY BLOCK-
+pub   rsa4096 2018-01-26 [SC]
+  E3B690F9FC87D61BC87C1729CF2A679717747AD4
+uid   [ultimate] Hiroyuki Sakai (CODE SIGNING KEY) 
+sig 3CF2A679717747AD4 2018-01-26  Hiroyuki Sakai (CODE SIGNING KEY) 

+sub   rsa4096 2018-01-26 [E]
+sig  CF2A679717747AD4 2018-01-26  Hiroyuki Sakai (CODE SIGNING KEY) 

+
+-BEGIN PGP PUBLIC KEY BLOCK-
+
+mQINBFpq9EEBEADVK3Jkw5HL66thbUalV5kKlthTKKl38vTFJZOTdOgSvcpEX7ak
+XIPe0SS7jzF13H/f/9VzhBgocu4LEU7dfxMJTHdxvQ+DrMciTSk6yrWHCV5VXj+W
+tU+NaniGeeQWC765VPYEwRuD+qynbgLHY5goC2WVBYwn+3t++jTRIHrXeL7q29li
+tPjepybBL0tPKRaAduv92JAP2vYx44RhKm2huS7IEw7xBadMLO5G9WO49F82Y3pH
+PBiRJoJwWKOu4HwPLPOIzvedirjsebQD9yD5AweatFafsRqdOWC7JRLxJbSRIvP/
+wjXWNaHwvCzFerqQqN7Jh9HpJlrrPhZHsWXM1qwywewv3FQpqjA6wS0ZqXVQk1Yk
+EUDdlB2fkZcWGTW2CWiLKMlJY7iAoPgdoy3EvZk8Q9lOxjlMR8s3bKHj2qCbSUh+
+tLHPls0Vo8gp4SyKoGwrTc7Sg06CoNaOFe/OLVDjWaJ2eQ0UMFHWT/FpbtahD1fT
+FFn6odw4zS+ls3EHWjJ4c1xhsDmkDs4nwr9kHZzH2Eg4o8QhXl0T9H3bb+yJiwpP
+DriyJNfHfsNzoHO6DAEv6Y8Lbb/xo8QWxo514/U2Vcdi+SoLfr2fIwSnbVj3Rc0a
+/p9QfdPvPZsqFGZJhYh4Dkc27xP4eQ8xSvivKclo6uAP+/7FjqsFL6SlyQARAQAB
+tDZIaXJveXVraSBTYWthaSAoQ09ERSBTSUdOSU5HIEtFWSkgPGhyc2FrYWlAYXBh
+Y2hlLm9yZz6JAk4EEwEIADgCGwMCHgECF4AWIQTjtpD5/IfWG8h8FynPKmeXF3R6
+1AUCWmr5qwULCQgHAwUVCgkICwUWAgMBAAAKCRDPKmeXF3R61F4OEACm1SqlHynh
+gt2camTF7OJQlnNG7KbFFT3+truHZ5AIO9zEvqhmk5vIh9gvadXxSrC6G3F8c9qn
+MKafVSbsxuunxV0UWskf/V6EKrUWZpMcQaK743nj2TuLjuV3Ucp4rjDKGkJZX2QG
+l8xLQgOBeIBskPirSVTIhMQ6qLiQ8mdNb1M6/raxpQo64mbzi9ERZn+mQUgPKB+Y
+u5Hi+5wBecwP2TQJAs7szLO/tWxx0jMBe4pvRUubR39zgfvWEB5j9/zu7GgT8KPt
+tf17YAmsq4VEtR7AYaHhGK6C40ETF5dd8TLF5sH41ZpJv4sCglIS5LPWSjnosg8G
+ocvVAM9oCR6IVyvhR0X+dengqybL3Nbnz+SCuktqmVmVoFyFJZDRmymv2hiRPe01
+sf3CVlLp4RsQ7uPgCejNPxonOCZA/Ld0QzK6D4qHICzwLXCPbloAWUAm/smb50lx
+yxi8pBWWufPfSrRVTNXgmx65NRvoFe41KpkZMOj+8g3Fmf0NCp6KjL/6LI640gXC
+dG5pMrwQjnLZDi/UfW6QlSLDnl2/tvhZ0TSv1YJg9Ge43jdvYEJeuum5MV73Y1U8
+SXHtzYvK2B4kr/SdUGDwIJB8NSSY5OhDpseTZOe35Pk0WbgIXv37t89aQACXHaWo
+UJzpKSFDhIu+52Zlkhb+DtE6puNAxjEKU7kCDQRaavRBARAA5/5Pb9uzNVtHTpb0
+1Jr+K6lODGrj6Ek8MbX+6KEYcGf/RvuOK5BtlWOyOx4kzF1AHm4AZi+onsqtlhiI
+qwEHZGYN6UWxktfaeE1s3lxh8FRUfcf5iqyon+BbUEC1x4+AoVBGsgqlsF/Dxp4f
+UZwv4a7R1KiqlB1j5fV8sng1fxPmDS3OYN+88nA9Y9TsNr0n68eLq6I12/u13vvD
+R0TmxrGkr+O7dCZ4aIi3thjJ+znWNqEQwe9paUe5myNS+ftl+qp/vScDzGQWpU6y
+JC5zBZ3MSb53jH5GPHpz+G+t2DWSLwg5znhVK55JOSVxaPD/BRVFtkw0xFXgBAzv
+Rd00WzHkh+h7Uey9Y0uq2RZ9Y5JUpobY5kfEJcR1LoXz3yv9InNwenDPuvrHOxP/
+q8wW+t+P5yu28AIF90AAt4ahx7mqbRCxWYJ1FxqPdAndHALNX8467cWJWBSdjt5R
+aPx9MpUq9Y4g+S1oZZsuNjBrxUo0/rkSqd+NQ+ttYjICH5WJ4BjnmeznqZbteEMW
+77nw98Lfqgb2dN2vrmHYiP7oXFjpiHsBwzrXdZWTW9mctq1x8oDATQbUX1wXiwdA
+JDE/K/jkvytoIolsUxosMxGP2gQL3oDA8k7sdcpc3xrsAxa1v1K2jqdGHCjzZIq2
+0t78PIliSrss2ROIGG0jGVNABwMAEQEAAYkCNgQYAQgAIBYhBOO2kPn8h9YbyHwX
+Kc8qZ5cXdHrUBQJaavRBAhsMAAoJEM8qZ5cXdHrUdFUP/jGhS7SAwm9sTLjyraJu
+pjJvVFfXJlufIqe9uFaCJAG3ICWPAWmjl21lJ8vivnShQZmXAll4dj5uL2jEvnsG
+fC8zFhWEl0GcminDq2npkCO9QH0uCWv5JPk90juLrdtpw7te2Vs01fO97jpsWfyd
+1s+XAv6X2xmEzV18GkXAd+pbs9+s7L7nGOUhjMAEClkms4PFbBcyCLNEFICezeXY
+ktnVNTg7+zq6mdP0jazODPPPLWTMJhrhf8jW8DJF062AuBwjxx3q4h8gbqe1Ixi9
+d6Jd02qNVNL0hF2US3aPYou7+AIs36PbzO2wDWCsPOalk7+hGbtwnRKDkb+98w8l
+pUj62zXYGLx2OWbJl/HP6P6ssWD3Hu2RE/o0oSHjzC4ci/nTg8+8ZSYT+YCtj3D2
+zBcq7DYzyBf/fPVQwLWqUgC7g28zADndUvNnycVRmxz49xckslV8eaygHr4zn7TD
+m+bBA3oA5iD4U7XglSxrIIT2AzRWoG8FL86cpxUAUvl2HYIBRkxxDpP0jdPlvh/B
+E0GAwKJDuZXygmnqOQEbVQwTfrntZ9ELFRpYGoUKwLe0M9Z6mq1ai+Jb6EoS2wEn
+Ef5D3zsz3YwR1SMS2ZsX4aHaXhbSRTKYY83x5n0/tEnMMOMqvS+RgVc7Y36r4ezb
+4R/eV1EOkAVSbS98fTm/LlrV
+=0XPv
+-END PGP PUBLIC KEY BLOCK-

svn commit: r24541 - /dev/incubator/pulsar/KEYS

[hrsakai]

Author: hrsakai
Date: Tue Jan 30 07:15:32 2018
New Revision: 24541

Log:
Added gpg key for hrsakai

Modified:
dev/incubator/pulsar/KEYS

Modified: dev/incubator/pulsar/KEYS
==
--- dev/incubator/pulsar/KEYS (original)
+++ dev/incubator/pulsar/KEYS Tue Jan 30 07:15:32 2018
@@ -321,3 +321,62 @@ XDQkrodkTVOU/Qb6mMuix6/akdYtVIYKW9ZIJQ4g
 MYODllZTADQ/6omtfGFTjzD0/iE85VN5sw==
 =dDeQ
 -END PGP PUBLIC KEY BLOCK-
+pub   rsa4096 2018-01-26 [SC]
+  E3B690F9FC87D61BC87C1729CF2A679717747AD4
+uid   [ultimate] Hiroyuki Sakai (CODE SIGNING KEY) 
+sig 3CF2A679717747AD4 2018-01-26  Hiroyuki Sakai (CODE SIGNING KEY) 

+sub   rsa4096 2018-01-26 [E]
+sig  CF2A679717747AD4 2018-01-26  Hiroyuki Sakai (CODE SIGNING KEY) 

+
+-BEGIN PGP PUBLIC KEY BLOCK-
+
+mQINBFpq9EEBEADVK3Jkw5HL66thbUalV5kKlthTKKl38vTFJZOTdOgSvcpEX7ak
+XIPe0SS7jzF13H/f/9VzhBgocu4LEU7dfxMJTHdxvQ+DrMciTSk6yrWHCV5VXj+W
+tU+NaniGeeQWC765VPYEwRuD+qynbgLHY5goC2WVBYwn+3t++jTRIHrXeL7q29li
+tPjepybBL0tPKRaAduv92JAP2vYx44RhKm2huS7IEw7xBadMLO5G9WO49F82Y3pH
+PBiRJoJwWKOu4HwPLPOIzvedirjsebQD9yD5AweatFafsRqdOWC7JRLxJbSRIvP/
+wjXWNaHwvCzFerqQqN7Jh9HpJlrrPhZHsWXM1qwywewv3FQpqjA6wS0ZqXVQk1Yk
+EUDdlB2fkZcWGTW2CWiLKMlJY7iAoPgdoy3EvZk8Q9lOxjlMR8s3bKHj2qCbSUh+
+tLHPls0Vo8gp4SyKoGwrTc7Sg06CoNaOFe/OLVDjWaJ2eQ0UMFHWT/FpbtahD1fT
+FFn6odw4zS+ls3EHWjJ4c1xhsDmkDs4nwr9kHZzH2Eg4o8QhXl0T9H3bb+yJiwpP
+DriyJNfHfsNzoHO6DAEv6Y8Lbb/xo8QWxo514/U2Vcdi+SoLfr2fIwSnbVj3Rc0a
+/p9QfdPvPZsqFGZJhYh4Dkc27xP4eQ8xSvivKclo6uAP+/7FjqsFL6SlyQARAQAB
+tDZIaXJveXVraSBTYWthaSAoQ09ERSBTSUdOSU5HIEtFWSkgPGhyc2FrYWlAYXBh
+Y2hlLm9yZz6JAk4EEwEIADgCGwMCHgECF4AWIQTjtpD5/IfWG8h8FynPKmeXF3R6
+1AUCWmr5qwULCQgHAwUVCgkICwUWAgMBAAAKCRDPKmeXF3R61F4OEACm1SqlHynh
+gt2camTF7OJQlnNG7KbFFT3+truHZ5AIO9zEvqhmk5vIh9gvadXxSrC6G3F8c9qn
+MKafVSbsxuunxV0UWskf/V6EKrUWZpMcQaK743nj2TuLjuV3Ucp4rjDKGkJZX2QG
+l8xLQgOBeIBskPirSVTIhMQ6qLiQ8mdNb1M6/raxpQo64mbzi9ERZn+mQUgPKB+Y
+u5Hi+5wBecwP2TQJAs7szLO/tWxx0jMBe4pvRUubR39zgfvWEB5j9/zu7GgT8KPt
+tf17YAmsq4VEtR7AYaHhGK6C40ETF5dd8TLF5sH41ZpJv4sCglIS5LPWSjnosg8G
+ocvVAM9oCR6IVyvhR0X+dengqybL3Nbnz+SCuktqmVmVoFyFJZDRmymv2hiRPe01
+sf3CVlLp4RsQ7uPgCejNPxonOCZA/Ld0QzK6D4qHICzwLXCPbloAWUAm/smb50lx
+yxi8pBWWufPfSrRVTNXgmx65NRvoFe41KpkZMOj+8g3Fmf0NCp6KjL/6LI640gXC
+dG5pMrwQjnLZDi/UfW6QlSLDnl2/tvhZ0TSv1YJg9Ge43jdvYEJeuum5MV73Y1U8
+SXHtzYvK2B4kr/SdUGDwIJB8NSSY5OhDpseTZOe35Pk0WbgIXv37t89aQACXHaWo
+UJzpKSFDhIu+52Zlkhb+DtE6puNAxjEKU7kCDQRaavRBARAA5/5Pb9uzNVtHTpb0
+1Jr+K6lODGrj6Ek8MbX+6KEYcGf/RvuOK5BtlWOyOx4kzF1AHm4AZi+onsqtlhiI
+qwEHZGYN6UWxktfaeE1s3lxh8FRUfcf5iqyon+BbUEC1x4+AoVBGsgqlsF/Dxp4f
+UZwv4a7R1KiqlB1j5fV8sng1fxPmDS3OYN+88nA9Y9TsNr0n68eLq6I12/u13vvD
+R0TmxrGkr+O7dCZ4aIi3thjJ+znWNqEQwe9paUe5myNS+ftl+qp/vScDzGQWpU6y
+JC5zBZ3MSb53jH5GPHpz+G+t2DWSLwg5znhVK55JOSVxaPD/BRVFtkw0xFXgBAzv
+Rd00WzHkh+h7Uey9Y0uq2RZ9Y5JUpobY5kfEJcR1LoXz3yv9InNwenDPuvrHOxP/
+q8wW+t+P5yu28AIF90AAt4ahx7mqbRCxWYJ1FxqPdAndHALNX8467cWJWBSdjt5R
+aPx9MpUq9Y4g+S1oZZsuNjBrxUo0/rkSqd+NQ+ttYjICH5WJ4BjnmeznqZbteEMW
+77nw98Lfqgb2dN2vrmHYiP7oXFjpiHsBwzrXdZWTW9mctq1x8oDATQbUX1wXiwdA
+JDE/K/jkvytoIolsUxosMxGP2gQL3oDA8k7sdcpc3xrsAxa1v1K2jqdGHCjzZIq2
+0t78PIliSrss2ROIGG0jGVNABwMAEQEAAYkCNgQYAQgAIBYhBOO2kPn8h9YbyHwX
+Kc8qZ5cXdHrUBQJaavRBAhsMAAoJEM8qZ5cXdHrUdFUP/jGhS7SAwm9sTLjyraJu
+pjJvVFfXJlufIqe9uFaCJAG3ICWPAWmjl21lJ8vivnShQZmXAll4dj5uL2jEvnsG
+fC8zFhWEl0GcminDq2npkCO9QH0uCWv5JPk90juLrdtpw7te2Vs01fO97jpsWfyd
+1s+XAv6X2xmEzV18GkXAd+pbs9+s7L7nGOUhjMAEClkms4PFbBcyCLNEFICezeXY
+ktnVNTg7+zq6mdP0jazODPPPLWTMJhrhf8jW8DJF062AuBwjxx3q4h8gbqe1Ixi9
+d6Jd02qNVNL0hF2US3aPYou7+AIs36PbzO2wDWCsPOalk7+hGbtwnRKDkb+98w8l
+pUj62zXYGLx2OWbJl/HP6P6ssWD3Hu2RE/o0oSHjzC4ci/nTg8+8ZSYT+YCtj3D2
+zBcq7DYzyBf/fPVQwLWqUgC7g28zADndUvNnycVRmxz49xckslV8eaygHr4zn7TD
+m+bBA3oA5iD4U7XglSxrIIT2AzRWoG8FL86cpxUAUvl2HYIBRkxxDpP0jdPlvh/B
+E0GAwKJDuZXygmnqOQEbVQwTfrntZ9ELFRpYGoUKwLe0M9Z6mq1ai+Jb6EoS2wEn
+Ef5D3zsz3YwR1SMS2ZsX4aHaXhbSRTKYY83x5n0/tEnMMOMqvS+RgVc7Y36r4ezb
+4R/eV1EOkAVSbS98fTm/LlrV
+=0XPv
+-END PGP PUBLIC KEY BLOCK-

[GitHub] jai1 commented on a change in pull request #1123: Configure a max producer/consumer queue size enforced across partitions

[GitBox]

jai1 commented on a change in pull request #1123: Configure a max 
producer/consumer queue size enforced across partitions
URL: https://github.com/apache/incubator-pulsar/pull/1123#discussion_r164650547
 
 

 ##
 File path: pulsar-client-cpp/lib/ProducerConfiguration.cc
 ##
 @@ -73,6 +73,18 @@ ProducerConfiguration& 
ProducerConfiguration::setMaxPendingMessages(int maxPendi
 
 int ProducerConfiguration::getMaxPendingMessages() const { return 
impl_->maxPendingMessages; }
 
+ProducerConfiguration& 
ProducerConfiguration::setMaxPendingMessagesAcrossPartitions(int 
maxPendingMessages) {
+if (maxPendingMessages <= 0) {
 
 Review comment:
   Assert instead of throw


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hrsakai opened a new pull request #1146: Fix url option on client tool

[GitBox]

hrsakai opened a new pull request #1146: Fix url option on client tool
URL: https://github.com/apache/incubator-pulsar/pull/1146
 
 
   ### Motivation
   We can't use `pulsar-client` command without specifing 
`serviceUrl`,`brokerServiceUrl`, or `webServiceUrl`.
   
   ```
   $ cat /path/to/client.conf
   serviceUrl=
   brokerServiceUrl=
   webServiceUrl=
   authPlugin=
   authParams=
   useTls=
   
   $ pulsar-client --url  consume -s  
   
   ```
   
   I want to use client tool with only `--url` option.
   
   ### Modifications
   Enable `pulsar-client` command to be used with only `--url` option.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[incubator-pulsar] branch master updated: Fix race condition in testRedeliveryOnBlockedDistpatcher (#1144)

[mmerli]

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
 new 059149c  Fix race condition in testRedeliveryOnBlockedDistpatcher 
(#1144)
059149c is described below

commit 059149c494592a3913a4fb24ed6939e1b068fc58
Author: Matteo Merli 
AuthorDate: Mon Jan 29 20:12:09 2018 -0800

Fix race condition in testRedeliveryOnBlockedDistpatcher (#1144)
---
 .../client/api/DispatcherBlockConsumerTest.java| 52 ++
 1 file changed, 23 insertions(+), 29 deletions(-)

diff --git 
a/pulsar-broker/src/test/java/org/apache/pulsar/client/api/DispatcherBlockConsumerTest.java
 
b/pulsar-broker/src/test/java/org/apache/pulsar/client/api/DispatcherBlockConsumerTest.java
index 1a32776..3167006 100644
--- 
a/pulsar-broker/src/test/java/org/apache/pulsar/client/api/DispatcherBlockConsumerTest.java
+++ 
b/pulsar-broker/src/test/java/org/apache/pulsar/client/api/DispatcherBlockConsumerTest.java
@@ -31,6 +31,7 @@ import java.util.Arrays;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
+import java.util.Queue;
 import java.util.Set;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.Executors;
@@ -40,23 +41,14 @@ import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.Supplier;
 import java.util.stream.Collectors;
 
-import com.google.common.collect.Sets;
 import org.apache.pulsar.broker.namespace.NamespaceService;
 import org.apache.pulsar.broker.service.BrokerService;
 import 
org.apache.pulsar.broker.service.persistent.PersistentDispatcherMultipleConsumers;
 import org.apache.pulsar.broker.service.persistent.PersistentTopic;
-import org.apache.pulsar.client.api.Consumer;
-import org.apache.pulsar.client.api.ConsumerConfiguration;
-import org.apache.pulsar.client.api.Message;
-import org.apache.pulsar.client.api.MessageId;
-import org.apache.pulsar.client.api.Producer;
-import org.apache.pulsar.client.api.ProducerConfiguration;
-import org.apache.pulsar.client.api.PulsarClientException;
-import org.apache.pulsar.client.api.SubscriptionType;
 import org.apache.pulsar.client.impl.ConsumerImpl;
 import org.apache.pulsar.client.impl.MessageIdImpl;
-import org.apache.pulsar.common.policies.data.SubscriptionStats;
 import org.apache.pulsar.common.policies.data.PersistentTopicStats;
+import org.apache.pulsar.common.policies.data.SubscriptionStats;
 import org.apache.pulsar.common.util.collections.ConcurrentOpenHashSet;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -69,6 +61,8 @@ import org.testng.collections.Lists;
 import com.google.common.collect.ArrayListMultimap;
 import com.google.common.collect.Maps;
 import com.google.common.collect.Multimap;
+import com.google.common.collect.Queues;
+import com.google.common.collect.Sets;
 
 public class DispatcherBlockConsumerTest extends ProducerConsumerBase {
 private static final Logger log = 
LoggerFactory.getLogger(DispatcherBlockConsumerTest.class);
@@ -157,10 +151,10 @@ public class DispatcherBlockConsumerTest extends 
ProducerConsumerBase {
 fail("ack failed", e);
 }
 });
-
+
 // try to consume remaining messages: broker may take time to 
deliver so, retry multiple time to consume
 // all messages
-List result = Lists.newArrayList();
+Queue result = Queues.newConcurrentLinkedQueue();
 // expecting messages which are not received
 int expectedRemainingMessages = totalProducedMsgs - 
messages.size();
 CountDownLatch latch = new 
CountDownLatch(expectedRemainingMessages);
@@ -264,7 +258,7 @@ public class DispatcherBlockConsumerTest extends 
ProducerConsumerBase {
 
 // (4) try to consume remaining messages: broker may take time to 
deliver so, retry multiple time to consume
 // all messages
-List result = Lists.newArrayList();
+Queue result = Queues.newConcurrentLinkedQueue();
 CountDownLatch latch = new CountDownLatch(totalProducedMsgs);
 for (int i = 0; i < consumers.length; i++) {
 final int consumerCount = i;
@@ -495,7 +489,7 @@ public class DispatcherBlockConsumerTest extends 
ProducerConsumerBase {
 // try to consume remaining messages: broker may take time to 
deliver so, retry multiple time to consume
 // all messages
 CountDownLatch latch = new CountDownLatch(remainingMessages);
-List consumedMessages = Lists.newArrayList();
+Queue consumedMessages = 
Queues.newConcurrentLinkedQueue();
 for (int i = 0; i < consumers.length; i++) {
 final int counsumerIndex = i;
 for (int j = 0; j < remainingMessages; j++) {
@@ -666,26 +660,26 

[GitHub] merlimat closed issue #814: Intermittent test failure DispatcherBlockConsumerTest.testRedeliveryOnBlockedDistpatcher

[GitBox]

merlimat closed issue #814: Intermittent test failure 
DispatcherBlockConsumerTest.testRedeliveryOnBlockedDistpatcher
URL: https://github.com/apache/incubator-pulsar/issues/814
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1145: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice

[GitBox]

merlimat commented on issue #1145: Intermittent test failure in 
PersistentTopicTest.testClosingReplicationProducerTwice
URL: 
https://github.com/apache/incubator-pulsar/issues/1145#issuecomment-361471241
 
 
   This reproduces locally after running ~900 times.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat opened a new issue #1145: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice

[GitBox]

merlimat opened a new issue #1145: Intermittent test failure in 
PersistentTopicTest.testClosingReplicationProducerTwice
URL: https://github.com/apache/incubator-pulsar/issues/1145
 
 
   As seen in 
   
   
https://builds.apache.org/job/pulsar-pull-request/org.apache.pulsar$pulsar-broker/1344/testReport/junit/org.apache.pulsar.broker.service/PersistentTopicTest/testClosingReplicationProducerTwice/
   
   ```
   org.mockito.exceptions.verification.TooManyActualInvocations: 
   
   pulsarClientImpl.createProducerAsync(
   "persistent://prop/global/ns/testClosingReplicationProducerTwice",
   org.apache.pulsar.client.api.ProducerConfiguration@f74e835
   );
   Wanted 1 time:
   -> at 
org.apache.pulsar.broker.service.PersistentTopicTest.testClosingReplicationProducerTwice(PersistentTopicTest.java:965)
   But was 2 times. Undesired invocation:
   -> at 
org.apache.pulsar.broker.service.AbstractReplicator.startProducer(AbstractReplicator.java:124)
   
at 
org.apache.pulsar.broker.service.PersistentTopicTest.testClosingReplicationProducerTwice(PersistentTopicTest.java:965)
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat opened a new pull request #1144: Fix race condition in testRedeliveryOnBlockedDistpatcher

[GitBox]

merlimat opened a new pull request #1144: Fix race condition in 
testRedeliveryOnBlockedDistpatcher
URL: https://github.com/apache/incubator-pulsar/pull/1144
 
 
   ### Motivation
   
   The test is using `receiveAsync()` over multiple consumer objects and adding 
the message ids on an unsynchronized `List<>`. There are chances that some of 
the updates on the list are missed, leading the test to fail.
   
   ### Modifications
   
   Use a `ConcurrentLinkedQueue` to store the message ids.
   
   ### Result
   
   Fixes #814 
   
   ### Result
   
   After your change, what will change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1135: Added infinite time retention configuration option

[GitBox]

merlimat commented on a change in pull request #1135: Added infinite time 
retention configuration option
URL: https://github.com/apache/incubator-pulsar/pull/1135#discussion_r164624867
 
 

 ##
 File path: 
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
 ##
 @@ -300,10 +300,12 @@ void run() throws PulsarAdminException {
 private java.util.List params;
 
 @Parameter(names = { "--time",
-"-t" }, description = "Retention time in minutes (or minutes, 
hours,days,weeks eg: 100m, 3h, 2d, 5w)", required = true)
+"-t" }, description = "Retention time in minutes (or minutes, 
hours,days,weeks eg: 100m, 3h, 2d, 5w). "
 
 Review comment:
   Good point. I'll add it 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1097: Validate expected types in Python code wrapper

[GitBox]

merlimat commented on issue #1097: Validate expected types in Python code 
wrapper
URL: https://github.com/apache/incubator-pulsar/pull/1097#issuecomment-361454629
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat closed pull request #1139: Add timeouts to setup & teardown for ReplicatorTest

[GitBox]

merlimat closed pull request #1139: Add timeouts to setup & teardown for 
ReplicatorTest
URL: https://github.com/apache/incubator-pulsar/pull/1139
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
 
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
index e6d649834..25098a94a 100644
--- 
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
+++ 
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
@@ -81,13 +81,13 @@
 public class ReplicatorTest extends ReplicatorTestBase {
 
 @Override
-@BeforeClass
+@BeforeClass(timeOut = 3)
 void setup() throws Exception {
 super.setup();
 }
 
 @Override
-@AfterClass
+@AfterClass(timeOut = 3)
 void shutdown() throws Exception {
 super.shutdown();
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[incubator-pulsar] branch master updated: Add timeouts to setup & teardown for ReplicatorTest (#1139)

[mmerli]

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
 new 8a2b2f0  Add timeouts to setup & teardown for ReplicatorTest (#1139)
8a2b2f0 is described below

commit 8a2b2f0389554e0cf32960e175686a87e170e4a2
Author: Matteo Merli 
AuthorDate: Mon Jan 29 18:02:24 2018 -0800

Add timeouts to setup & teardown for ReplicatorTest (#1139)
---
 .../test/java/org/apache/pulsar/broker/service/ReplicatorTest.java| 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
 
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
index e6d6498..25098a9 100644
--- 
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
+++ 
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
@@ -81,13 +81,13 @@ import org.testng.collections.Lists;
 public class ReplicatorTest extends ReplicatorTestBase {
 
 @Override
-@BeforeClass
+@BeforeClass(timeOut = 3)
 void setup() throws Exception {
 super.setup();
 }
 
 @Override
-@AfterClass
+@AfterClass(timeOut = 3)
 void shutdown() throws Exception {
 super.shutdown();
 }

-- 
To stop receiving notification emails like this one, please contact
mme...@apache.org.

[GitHub] rdhabalia commented on a change in pull request #1135: Added infinite time retention configuration option

[GitBox]

rdhabalia commented on a change in pull request #1135: Added infinite time 
retention configuration option
URL: https://github.com/apache/incubator-pulsar/pull/1135#discussion_r164621919
 
 

 ##
 File path: 
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
 ##
 @@ -300,10 +300,12 @@ void run() throws PulsarAdminException {
 private java.util.List params;
 
 @Parameter(names = { "--time",
-"-t" }, description = "Retention time in minutes (or minutes, 
hours,days,weeks eg: 100m, 3h, 2d, 5w)", required = true)
+"-t" }, description = "Retention time in minutes (or minutes, 
hours,days,weeks eg: 100m, 3h, 2d, 5w). "
 
 Review comment:
   should we also update it in cli-admin docs?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rdhabalia commented on issue #1002: Making Pulsar Proxy more secure

[GitBox]

rdhabalia commented on issue #1002: Making Pulsar Proxy more secure
URL: https://github.com/apache/incubator-pulsar/pull/1002#issuecomment-361450629
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rdhabalia commented on issue #1002: Making Pulsar Proxy more secure

[GitBox]

rdhabalia commented on issue #1002: Making Pulsar Proxy more secure
URL: https://github.com/apache/incubator-pulsar/pull/1002#issuecomment-361450629
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rdhabalia commented on a change in pull request #1002: Making Pulsar Proxy more secure

[GitBox]

rdhabalia commented on a change in pull request #1002: Making Pulsar Proxy more 
secure
URL: https://github.com/apache/incubator-pulsar/pull/1002#discussion_r164619782
 
 

 ##
 File path: 
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/LookupProxyHandler.java
 ##
 @@ -54,6 +57,8 @@ public LookupProxyHandler(ProxyService proxy, 
ProxyConnection proxyConnection) {
 this.proxyConnection = proxyConnection;
 this.clientAddress = proxyConnection.clientAddress();
 this.connectWithTLS = 
proxy.getConfiguration().isTlsEnabledWithBroker();
+this.brokerServiceURL = this.connectWithTLS ? 
proxy.getConfiguration().getBrokerServiceURLTLS()
 
 Review comment:
   should we also add another check
   `this.connectWithTLS && 
isNotBlank(proxy.getConfiguration().getBrokerServiceURLTLS()) ? 
proxy.getConfiguration().getBrokerServiceURLTLS() : 
proxy.getConfiguration().getBrokerServiceURL()` ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rdhabalia commented on a change in pull request #1002: Making Pulsar Proxy more secure

[GitBox]

rdhabalia commented on a change in pull request #1002: Making Pulsar Proxy more 
secure
URL: https://github.com/apache/incubator-pulsar/pull/1002#discussion_r164620502
 
 

 ##
 File path: 
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationManager.java
 ##
 @@ -150,8 +153,46 @@ public boolean canLookup(DestinationName destination, 
String role) throws Except
 return canProduce(destination, role) || canConsume(destination, role, 
null);
 }
 
-private CompletableFuture checkAuthorization(DestinationName 
destination, String role,
-AuthAction action) {
+/**
+ * Check whether the specified role can perform a lookup for the specified 
destination.
+ *
+ * For that the caller needs to have producer or consumer permission.
+ *
+ * @param destination
+ * @param role
+ * @return
+ * @throws Exception
+ */
+public CompletableFuture canLookupAsync(DestinationName 
destination, String role) {
+CompletableFuture finalResult = new 
CompletableFuture();
+canProduceAsync(destination, role).whenComplete((produceAuthorized, 
ex) -> {
+if (ex == null) {
+if (produceAuthorized) {
+finalResult.complete(produceAuthorized);
+return;
+}
+} else if (log.isDebugEnabled()) {
 
 Review comment:
   ```
   else {
 if (log.isDebugEnabled()) {
   :
 }
   }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1003: Intermittent test failure DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAtDispatcher

[GitBox]

merlimat commented on issue #1003: Intermittent test failure 
DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAtDispatcher
URL: 
https://github.com/apache/incubator-pulsar/issues/1003#issuecomment-361438295
 
 
   Still happening: 
   
https://builds.apache.org/job/pulsar-pull-request/org.apache.pulsar$pulsar-broker/1323/testReport/junit/org.apache.pulsar.client.api/DispatcherBlockConsumerTest/testConsumerBlockingWithUnAckedMessagesAtDispatcher/
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat closed issue #1082: Intermittent test failures in DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAtDispatcher

[GitBox]

merlimat closed issue #1082: Intermittent test failures in 
DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAtDispatcher
URL: https://github.com/apache/incubator-pulsar/issues/1082
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nkurihar commented on issue #1133: Property name in documentation is incorrect

[GitBox]

nkurihar commented on issue #1133: Property name in documentation is incorrect
URL: https://github.com/apache/incubator-pulsar/pull/1133#issuecomment-361429583
 
 
   LGTM ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1115: In Kafka consumer wrapper, group multiple messages when the app polls

[GitBox]

merlimat commented on issue #1115: In Kafka consumer wrapper, group multiple 
messages when the app polls
URL: https://github.com/apache/incubator-pulsar/pull/1115#issuecomment-361425686
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #154: Retention 0mb and BacklogQuota 0mb

[GitBox]

merlimat commented on issue #154: Retention 0mb and BacklogQuota 0mb
URL: 
https://github.com/apache/incubator-pulsar/issues/154#issuecomment-361416957
 
 
   Added 2nd PR for docs changes: 
https://github.com/apache/incubator-pulsar/pull/1141


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat opened a new pull request #1141: Some clarifications on Retention documentation

[GitBox]

merlimat opened a new pull request #1141: Some clarifications on Retention 
documentation
URL: https://github.com/apache/incubator-pulsar/pull/1141
 
 
   ### Motivation
   
   Tried to simplify here a couple of statements on Retention and added 
references to infinite retention time as defined in #1135.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client

[GitBox]

jai1 commented on a change in pull request #1129: Added end to end encryption 
in C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164591461
 
 

 ##
 File path: pulsar-client-cpp/lib/ProducerImpl.cc
 ##
 @@ -50,7 +50,9 @@ ProducerImpl::ProducerImpl(ClientImplPtr client, const 
std::string& topic, const
   producerStr_("[" + topic_ + ", " + producerName_ + "] "),
   producerId_(client->newProducerId()),
   msgSequenceGenerator_(0),
-  sendTimer_() {
+  sendTimer_(),
+  msgCrypto_(),
+  dataKeyGenInterval_(4 * 60 * 60) {
 
 Review comment:
   dataKeyGenIntervalInMs_ (time unit missing)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lucperkins opened a new pull request #1140: Remove master/slave terminology from Pulsar (WIP)

[GitBox]

lucperkins opened a new pull request #1140: Remove master/slave terminology 
from Pulsar (WIP)
URL: https://github.com/apache/incubator-pulsar/pull/1140
 
 
   ### Motivation
   
   There is a broad consensus in our industry that "master/slave" terminology 
is damaging, unnecessary, and frequently misleading.
   
   ### Modifications
   
   This PR removes as many master and slave references from the Pulsar codebase 
and website as is currently feasible.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client

[GitBox]

jai1 commented on a change in pull request #1129: Added end to end encryption 
in C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164589275
 
 

 ##
 File path: pulsar-client-cpp/lib/ConsumerConfigurationImpl.h
 ##
 @@ -31,13 +31,18 @@ struct ConsumerConfigurationImpl {
 int receiverQueueSize;
 std::string consumerName;
 long brokerConsumerStatsCacheTimeInMs;
+CryptoKeyReader* cryptoKeyReader;
 
 Review comment:
   Can we use shared pointer instead like we do for MessageRouter


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client

[GitBox]

jai1 commented on a change in pull request #1129: Added end to end encryption 
in C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164588488
 
 

 ##
 File path: pulsar-client-cpp/lib/ConsumerConfiguration.cc
 ##
 @@ -74,4 +74,30 @@ void 
ConsumerConfiguration::setUnAckedMessagesTimeoutMs(const uint64_t milliSeco
 }
 impl_->unAckedMessagesTimeoutMs = milliSeconds;
 }
+
+bool ConsumerConfiguration::isEncryptionEnabled() const {
+if (impl_->cryptoKeyReader != NULL) {
 
 Review comment:
   return impl_->cryptoKeyReader != NULL


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client

[GitBox]

jai1 commented on a change in pull request #1129: Added end to end encryption 
in C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164587853
 
 

 ##
 File path: pulsar-client-cpp/include/pulsar/ConsumerCryptoFailureAction.h
 ##
 @@ -0,0 +1,41 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#ifndef LIB_CONSUMERCRYPTOFAILUREACTION_H_
+#define LIB_CONSUMERCRYPTOFAILUREACTION_H_
+
+using namespace pulsar;
 
 Review comment:
   Remove this line


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat opened a new pull request #1139: Add timeouts to setup & teardown for ReplicatorTest

[GitBox]

merlimat opened a new pull request #1139: Add timeouts to setup & teardown for 
ReplicatorTest
URL: https://github.com/apache/incubator-pulsar/pull/1139
 
 
   ### Motivation
   
   All the tests in `ReplicatorTest` already do have timeouts, though the build 
keeps getting stuck on this class. The only possible way left is that the test 
is getting stuck either in before or after. Adding missing timeouts so that 
next time we would see the stack trace where the test was stuck on.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat opened a new issue #1138: Test Timeouts in ReplicatorTest

[GitBox]

merlimat opened a new issue #1138: Test Timeouts in ReplicatorTest
URL: https://github.com/apache/incubator-pulsar/issues/1138
 
 
   I have been seeing a lot of CI builds timing out after 100 minutes, all were 
blocked on the `ReplicatorTest`. For example: 
   
   https://builds.apache.org/job/pulsar-pull-request/1321/console
   
   ```
   [INFO] Running org.apache.pulsar.broker.service.SubscriptionSeekTest
   [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.457 
s - in org.apache.pulsar.broker.service.SubscriptionSeekTest
   [INFO] Running org.apache.pulsar.broker.service.ReplicatorTest
   Build timed out (after 100 minutes). Marking the build as aborted.
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1126: Intermittent test failure in testSkipCorruptDataLedger

[GitBox]

merlimat commented on issue #1126: Intermittent test failure in 
testSkipCorruptDataLedger
URL: 
https://github.com/apache/incubator-pulsar/issues/1126#issuecomment-361408690
 
 
   @rdhabalia I have seen this test failing several times in the last few days. 
Can you take a look when you have the chance?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jai1 commented on issue #1002: Making Pulsar Proxy more secure

[GitBox]

jai1 commented on issue #1002: Making Pulsar Proxy more secure
URL: https://github.com/apache/incubator-pulsar/pull/1002#issuecomment-361408368
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker

[GitBox]

merlimat commented on a change in pull request #1132: Explicitly set zookeeper 
version in broker
URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164583151
 
 

 ##
 File path: pom.xml
 ##
 @@ -180,7 +200,7 @@ flexible messaging model and an intuitive client 
API.
 log4j
   
   
-org.jboss.netty
+io.netty
 
 Review comment:
   Got it, thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave commented on issue #1112: Broker schema registry (1/3)

[GitBox]

mgodave commented on issue #1112: Broker schema registry (1/3)
URL: https://github.com/apache/incubator-pulsar/pull/1112#issuecomment-361399155
 
 
   Replaced with https://github.com/apache/incubator-pulsar/pull/1137


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave opened a new pull request #1137: Schema registry

[GitBox]

mgodave opened a new pull request #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137
 
 
   ### Motivation
   
   Allow users of the system to store the structure and format of the data in a 
topic
   
   PIP: 
https://lists.apache.org/thread.html/6f5498bc90526efc44b0725eea0310b9332b4f71b04631233bd4daa1@%3Cdev.pulsar.apache.org%3E
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mgodave closed pull request #1112: Broker schema registry (1/3)

[GitBox]

mgodave closed pull request #1112: Broker schema registry (1/3)
URL: https://github.com/apache/incubator-pulsar/pull/1112
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
index 6cd56abcc..e69ff3cc5 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
@@ -48,6 +48,8 @@
 import org.apache.pulsar.broker.loadbalance.impl.LoadManagerShared;
 import org.apache.pulsar.broker.namespace.NamespaceService;
 import org.apache.pulsar.broker.service.BrokerService;
+import org.apache.pulsar.broker.service.schema.DefaultSchemaRegistryService;
+import org.apache.pulsar.broker.service.schema.SchemaRegistryService;
 import org.apache.pulsar.broker.service.Topic;
 import org.apache.pulsar.broker.stats.MetricsGenerator;
 import org.apache.pulsar.broker.stats.prometheus.PrometheusMetricsServlet;
@@ -116,6 +118,7 @@
 private final String brokerServiceUrl;
 private final String brokerServiceUrlTls;
 private final String brokerVersion;
+private SchemaRegistryService schemaRegistryService = null;
 
 private final MessagingServiceShutdownHook shutdownService;
 
@@ -220,6 +223,10 @@ public void close() throws PulsarServerException {
 loadManager.stop();
 }
 
+if (schemaRegistryService != null) {
+schemaRegistryService.close();
+}
+
 state = State.Closed;
 
 } catch (Exception e) {
@@ -249,6 +256,8 @@ public void start() throws PulsarServerException {
 throw new PulsarServerException("Cannot start the service once 
it was stopped");
 }
 
+schemaRegistryService = new DefaultSchemaRegistryService(this);
+
 // Now we are ready to start services
 localZooKeeperConnectionProvider = new 
LocalZooKeeperConnectionService(getZooKeeperClientFactory(),
 config.getZookeeperServers(), 
config.getZooKeeperSessionTimeoutMillis());
@@ -674,4 +683,8 @@ public String getBrokerServiceUrlTls() {
 public String getBrokerVersion() {
 return brokerVersion;
 }
+
+public SchemaRegistryService getSchemaRegistryService() {
+return schemaRegistryService;
+}
 }
diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/schema/SchemaRegistry.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/schema/SchemaRegistry.java
new file mode 100644
index 0..b51b8920a
--- /dev/null
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/schema/SchemaRegistry.java
@@ -0,0 +1,32 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.schema;
+
+import org.apache.pulsar.common.schema.Schema;
+import org.apache.pulsar.common.schema.SchemaType;
+
+public interface SchemaRegistry extends AutoCloseable {
+
+Schema getSchema(String schemaId);
+
+Schema getSchema(String schemaId, long version);
+
+long putSchema(String schemaId, SchemaType type, String schema);
+
+}
diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
index bd49fc76f..ff2b4a0d0 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
@@ -73,6 +73,7 @@
 import org.apache.pulsar.common.naming.Metadata;
 import org.apache.pulsar.common.policies.data.BacklogQuota;
 import org.apache.pulsar.common.policies.data.ConsumerStats;
+import org.apache.pulsar.common.schema.Schema;
 import org.apache.pulsar.common.util.collections.ConcurrentLongHashMap;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -355,6 +356,11 @@ protected void 

[GitHub] ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker

[GitBox]

ivankelly commented on a change in pull request #1132: Explicitly set zookeeper 
version in broker
URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164565853
 
 

 ##
 File path: pom.xml
 ##
 @@ -741,7 +761,7 @@ flexible messaging model and an intuitive client 
API.
 
 
   maven-compiler-plugin
-  2.3.2
+  3.7.0
 
 Review comment:
   oops, i didn't mean to push this. Will remove. Though it would be nice to 
get the other one in, as I end up changing this a couple of times a day. I 
rekicked a build on it earlier.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker

[GitBox]

ivankelly commented on a change in pull request #1132: Explicitly set zookeeper 
version in broker
URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164565510
 
 

 ##
 File path: pom.xml
 ##
 @@ -180,7 +200,7 @@ flexible messaging model and an intuitive client 
API.
 log4j
   
   
-org.jboss.netty
+io.netty
 
 Review comment:
   3.4.6 is already on the io groupId
   
   
http://search.maven.org/#artifactdetails%7Corg.apache.zookeeper%7Czookeeper%7C3.4.6%7Cpom


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker

[GitBox]

merlimat commented on a change in pull request #1132: Explicitly set zookeeper 
version in broker
URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164565191
 
 

 ##
 File path: pom.xml
 ##
 @@ -741,7 +761,7 @@ flexible messaging model and an intuitive client 
API.
 
 
   maven-compiler-plugin
-  2.3.2
+  3.7.0
 
 Review comment:
   I was seeing the errors in the other PR but wasn't able to figure out why 
would those test be failing with the newer compiler plugin.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker

[GitBox]

merlimat commented on a change in pull request #1132: Explicitly set zookeeper 
version in broker
URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164564840
 
 

 ##
 File path: pom.xml
 ##
 @@ -180,7 +200,7 @@ flexible messaging model and an intuitive client 
API.
 log4j
   
   
-org.jboss.netty
+io.netty
 
 Review comment:
   This one is actually the version of netty 3 used by ZK client


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ivankelly opened a new pull request #1136: Read compacted consumer flag

[GitBox]

ivankelly opened a new pull request #1136: Read compacted consumer flag
URL: https://github.com/apache/incubator-pulsar/pull/1136
 
 
   When enabled, a consumer will read messages from a compacted topic
   ledger if available. When disabled, the consumer will read from the
   message backlog as before, even if the topic has been compacted.
   
   The logic for actually reading from the compacted topic will be
   submitted in following patch.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1133: Property name in documentation is incorrect

[GitBox]

merlimat commented on issue #1133: Property name in documentation is incorrect
URL: https://github.com/apache/incubator-pulsar/pull/1133#issuecomment-361380688
 
 
   > @merlimat we should probably get someone who speaks japanese to look at 
that one
   
   Yep, sure. @yush1ga @nkurihar @massakam please take a look as well at the 
doc changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ivankelly commented on issue #1042: Update maven compiler plugin to newest version

[GitBox]

ivankelly commented on issue #1042: Update maven compiler plugin to newest 
version
URL: https://github.com/apache/incubator-pulsar/pull/1042#issuecomment-361374120
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker

[GitBox]

ivankelly commented on a change in pull request #1132: Explicitly set zookeeper 
version in broker
URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164548657
 
 

 ##
 File path: pulsar-broker/pom.xml
 ##
 @@ -119,6 +119,34 @@
   test
 
 
+
 
 Review comment:
   Ah, will move it there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat closed pull request #1044: Compact algo

[GitBox]

merlimat closed pull request #1044: Compact algo
URL: https://github.com/apache/incubator-pulsar/pull/1044
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/client/api/RawMessage.java 
b/pulsar-broker/src/main/java/org/apache/pulsar/client/api/RawMessage.java
index cc983e823..e6d3081b4 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/client/api/RawMessage.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/client/api/RawMessage.java
@@ -46,10 +46,10 @@
 ByteBuf getHeadersAndPayload();
 
 /**
- * Serialize a raw message to a ByteBufPair. The caller is responsible for 
releasing
- * the returned ByteBufPair.
+ * Serialize a raw message to a ByteBuf. The caller is responsible for 
releasing
+ * the returned ByteBuf.
  */
-ByteBufPair serialize();
+ByteBuf serialize();
 
 @Override
 void close();
diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawMessageImpl.java 
b/pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawMessageImpl.java
index 7160cc3be..d1b6e14bc 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawMessageImpl.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawMessageImpl.java
@@ -65,15 +65,18 @@ public void close() {
 }
 
 @Override
-public ByteBufPair serialize() {
+public ByteBuf serialize() {
+ByteBuf headersAndPayload = this.headersAndPayload.slice();
+
 // Format: [IdSize][Id][PayloadAndMetadataSize][PayloadAndMetadata]
 int idSize = id.getSerializedSize();
 int headerSize = 4 /* IdSize */ + idSize + 4 /* PayloadAndMetadataSize 
*/;
+int totalSize = headerSize + headersAndPayload.readableBytes();
 
-ByteBuf headers = PooledByteBufAllocator.DEFAULT.buffer(headerSize);
-headers.writeInt(idSize);
+ByteBuf buf = PooledByteBufAllocator.DEFAULT.buffer(totalSize);
+buf.writeInt(idSize);
 try {
-ByteBufCodedOutputStream outStream = 
ByteBufCodedOutputStream.get(headers);
+ByteBufCodedOutputStream outStream = 
ByteBufCodedOutputStream.get(buf);
 id.writeTo(outStream);
 outStream.recycle();
 } catch (IOException e) {
@@ -81,9 +84,10 @@ public ByteBufPair serialize() {
 log.error("IO exception serializing to ByteBuf (this shouldn't 
happen as operation is in-memory)", e);
 throw new RuntimeException(e);
 }
-headers.writeInt(headersAndPayload.readableBytes());
+buf.writeInt(headersAndPayload.readableBytes());
+buf.writeBytes(headersAndPayload);
 
-return ByteBufPair.get(headers, headersAndPayload);
+return buf;
 }
 
 static public RawMessage deserializeFrom(ByteBuf buffer) {
diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java 
b/pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java
new file mode 100644
index 0..62e5fcdee
--- /dev/null
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.compaction;
+
+import static java.nio.charset.StandardCharsets.UTF_8;
+
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ScheduledExecutorService;
+
+import org.apache.bookkeeper.client.BookKeeper;
+
+import org.apache.pulsar.broker.ServiceConfiguration;
+import org.apache.pulsar.client.api.PulsarClient;
+import org.apache.pulsar.client.api.RawReader;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Compactor for Pulsar topics
+*/
+public abstract class Compactor {
+private static final Logger log = LoggerFactory.getLogger(Compactor.class);
+private static final String COMPACTION_SUBSCRIPTION = "__compaction";
+private static final String COMPACTED_TOPIC_LEDGER_PROPERTY = 

[GitHub] merlimat commented on issue #154: Retention 0mb and BacklogQuota 0mb

[GitBox]

merlimat commented on issue #154: Retention 0mb and BacklogQuota 0mb
URL: 
https://github.com/apache/incubator-pulsar/issues/154#issuecomment-361367391
 
 
   Sorry @sschepens, I missed this issue back in the days. I just created #1135 
and I'll create another PR to clarify in the documentation


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ivankelly commented on issue #1044: Compact algo

[GitBox]

ivankelly commented on issue #1044: Compact algo
URL: https://github.com/apache/incubator-pulsar/pull/1044#issuecomment-361366560
 
 
   @merlimat CI is green now. I can push some more changes if this gets merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ivankelly commented on issue #1133: Property name in documentation is incorrect

[GitBox]

ivankelly commented on issue #1133: Property name in documentation is incorrect
URL: https://github.com/apache/incubator-pulsar/pull/1133#issuecomment-361366061
 
 
   @merlimat we should probably get someone who speaks japanese to look at that 
one


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat opened a new pull request #1135: Added infinite time retention configuration option

[GitBox]

merlimat opened a new pull request #1135: Added infinite time retention 
configuration option
URL: https://github.com/apache/incubator-pulsar/pull/1135
 
 
   ### Motivation
   
   Currently,  there is no direct way to configure an "infinite" retention time 
on data published on Pulsar topics, other than setting a very high value for 
both retention time and size.
   
   We should have a better way to mean "infinite", by allowing to specify -1. 
   
   ### Modifications
   
* Allow to get -1 for retention time and retention size
* Do not delete data or topics when infinite retention time is set
* Update CLI tool documentation to clarify the behavior
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1122: Use Optional for returning least loaded broker

[GitBox]

merlimat commented on issue #1122: Use Optional for returning least 
loaded broker
URL: https://github.com/apache/incubator-pulsar/pull/1122#issuecomment-361353480
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

[GitBox]

merlimat commented on a change in pull request #1129: Added end to end 
encryption in C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164523814
 
 

 ##
 File path: pulsar-client-cpp/lib/MessageCrypto.h
 ##
 @@ -0,0 +1,95 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#ifndef LIB_MESSAGECRYPTO_H_
+#define LIB_MESSAGECRYPTO_H_
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "SharedBuffer.h"
+#include "ExecutorService.h"
+#include "pulsar/CryptoKeyReader.h"
+#include "PulsarApi.pb.h"
+
+namespace pulsar {
+
+class MessageCrypto {
+ public:
+typedef std::map StringMap;
+typedef std::map> DataKeyCacheMap;
+
+MessageCrypto(std::string& logCtx, bool keyGenNeeded);
+~MessageCrypto();
+
+Result addPublicKeyCipher(std::set& keyNames, const 
CryptoKeyReader& keyReader);
+bool removeKeyCipher(std::string& keyName);
+
+bool encrypt(std::set& encKeys, const CryptoKeyReader& 
keyReader,
+proto::MessageMetadata& msgMetadata, SharedBuffer& payload, 
SharedBuffer& encryptedPayload);
+bool decrypt(const proto::MessageMetadata& msgMetadata, SharedBuffer& 
payload,
+const CryptoKeyReader& keyReader, SharedBuffer& decryptedPayload);
+
+ private:
+
+typedef boost::unique_lock Lock;
+boost::mutex mutex_;
+
+int dataKeyLen_;
+std::unique_ptr  dataKey_;
+
+int tagLen_;
+int ivLen_;
+std::unique_ptr iv_;
 
 Review comment:
   same here, `boost::scoped_ptr`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

[GitBox]

merlimat commented on a change in pull request #1129: Added end to end 
encryption in C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164524553
 
 

 ##
 File path: pulsar-client-cpp/lib/ProducerImpl.cc
 ##
 @@ -262,12 +295,21 @@ void ProducerImpl::sendAsync(const Message& msg, 
SendCallback callback) {
 SharedBuffer& payload = msg.impl_->payload;
 
 uint32_t uncompressedSize = payload.readableBytes();
+uint32_t compressedSize = uncompressedSize;
 
 if (!batchMessageContainer) {
 // If batching is enabled we compress all the payloads together before 
sending the batch
 payload = 
CompressionCodecProvider::getCodec(conf_.getCompressionType()).encode(payload);
+compressedSize = payload.readableBytes();
+
+// Encrypt the payload if enabled
+SharedBuffer encryptedPayload;
 
 Review comment:
   Check whether it's required before creating the `SharedBuffer`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

[GitBox]

merlimat commented on a change in pull request #1129: Added end to end 
encryption in C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164522672
 
 

 ##
 File path: pulsar-client-cpp/include/pulsar/CryptoKeyReader.h
 ##
 @@ -0,0 +1,51 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#ifndef LIB_CRYPTOKEYREADER_H_
+#define LIB_CRYPTOKEYREADER_H_
+
+#include 
+#include 
+
+#pragma GCC visibility push(default)
+
+using namespace pulsar;
+
+namespace pulsar {
+
+class CryptoKeyReader {
+
+ public:
 
 Review comment:
   Formatting will need to be adjusted, using the `make format` command


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

[GitBox]

merlimat commented on a change in pull request #1129: Added end to end 
encryption in C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164524311
 
 

 ##
 File path: pulsar-client-cpp/lib/ProducerImpl.cc
 ##
 @@ -262,12 +295,21 @@ void ProducerImpl::sendAsync(const Message& msg, 
SendCallback callback) {
 SharedBuffer& payload = msg.impl_->payload;
 
 uint32_t uncompressedSize = payload.readableBytes();
+uint32_t compressedSize = uncompressedSize;
 
 Review comment:
   The ways it sounds, it's a bit confusing ;) 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

[GitBox]

merlimat commented on a change in pull request #1129: Added end to end 
encryption in C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164524955
 
 

 ##
 File path: pulsar-client-cpp/run-unit-tests.sh
 ##
 @@ -23,7 +23,9 @@
 
 rm -rf ./pulsar-dist
 mkdir pulsar-dist
-tar xfz ../all/target/apache-pulsar*bin.tar.gz  -C pulsar-dist 
--strip-components 1
+for i in `ls ../all/target/apache-pulsar*bin.tar.gz`; do
 
 Review comment:
   The expectation here is that there will be a single tgz left after the build


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

[GitBox]

merlimat commented on a change in pull request #1129: Added end to end 
encryption in C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164523212
 
 

 ##
 File path: pulsar-client-cpp/lib/BatchMessageContainer.cc
 ##
 @@ -93,6 +93,10 @@ void BatchMessageContainer::sendMessage() {
 
impl_->metadata.set_num_messages_in_batch(messagesContainerListPtr_->size());
 compressPayLoad();
 
+SharedBuffer encryptedPayload;
 
 Review comment:
   Creating the `SharedBuffer` will need to malloc some stuff, can we just 
doing when encryption is enabled?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

[GitBox]

merlimat commented on a change in pull request #1129: Added end to end 
encryption in C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164523753
 
 

 ##
 File path: pulsar-client-cpp/lib/MessageCrypto.h
 ##
 @@ -0,0 +1,95 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#ifndef LIB_MESSAGECRYPTO_H_
+#define LIB_MESSAGECRYPTO_H_
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "SharedBuffer.h"
+#include "ExecutorService.h"
+#include "pulsar/CryptoKeyReader.h"
+#include "PulsarApi.pb.h"
+
+namespace pulsar {
+
+class MessageCrypto {
+ public:
+typedef std::map StringMap;
+typedef std::map> DataKeyCacheMap;
+
+MessageCrypto(std::string& logCtx, bool keyGenNeeded);
+~MessageCrypto();
+
+Result addPublicKeyCipher(std::set& keyNames, const 
CryptoKeyReader& keyReader);
+bool removeKeyCipher(std::string& keyName);
+
+bool encrypt(std::set& encKeys, const CryptoKeyReader& 
keyReader,
+proto::MessageMetadata& msgMetadata, SharedBuffer& payload, 
SharedBuffer& encryptedPayload);
+bool decrypt(const proto::MessageMetadata& msgMetadata, SharedBuffer& 
payload,
+const CryptoKeyReader& keyReader, SharedBuffer& decryptedPayload);
+
+ private:
+
+typedef boost::unique_lock Lock;
+boost::mutex mutex_;
+
+int dataKeyLen_;
+std::unique_ptr  dataKey_;
 
 Review comment:
   I think we should stick with `boost::scoped_ptr` instead of 
`std::unique_ptr` which depends on C++11


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1044: Compact algo

[GitBox]

merlimat commented on issue #1044: Compact algo
URL: https://github.com/apache/incubator-pulsar/pull/1044#issuecomment-360880464
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1124: Support Pulsar proxy from C++/Python client library

[GitBox]

merlimat commented on a change in pull request #1124: Support Pulsar proxy from 
C++/Python client library
URL: https://github.com/apache/incubator-pulsar/pull/1124#discussion_r164510154
 
 

 ##
 File path: pulsar-client-cpp/lib/Url.cc
 ##
 @@ -88,6 +88,12 @@ const std::string& Url::file() const { return file_; }
 
 const std::string& Url::parameter() const { return parameter_; }
 
+std::string Url::hostPort() const {
 
 Review comment:
   To return a reference, we would have to store the `hostPort` as a member 
variable. Since we don't always need the `hostPort()` in `Url` class, I prefer 
to just create it on the fly when needed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1124: Support Pulsar proxy from C++/Python client library

[GitBox]

merlimat commented on a change in pull request #1124: Support Pulsar proxy from 
C++/Python client library
URL: https://github.com/apache/incubator-pulsar/pull/1124#discussion_r164509672
 
 

 ##
 File path: pulsar-client-cpp/lib/ConnectionPool.cc
 ##
 @@ -33,36 +33,37 @@ ConnectionPool::ConnectionPool(const ClientConfiguration& 
conf, ExecutorServiceP
   poolConnections_(poolConnections),
   mutex_() {}
 
-Future 
ConnectionPool::getConnectionAsync(const std::string& endpoint) {
+Future ConnectionPool::getConnectionAsync(
+const std::string& logicalAddress, const std::string& physicalAddress) {
 boost::unique_lock lock(mutex_);
 
 if (poolConnections_) {
-PoolMap::iterator cnxIt = pool_.find(endpoint);
+PoolMap::iterator cnxIt = pool_.find(logicalAddress);
 
 Review comment:
   Yes, though, for efficiency reasons, the proxy maintains a 1-1 relationship 
for connections (client->proxy vs proxy->broker). This allows the proxy to 
degrade itself to a mere TCP proxy after the initial handshake, just copying 
buffers from one side to the other, without deserializing anything. 
   
   For this to work, the client needs to be aware that some connections are for 
some broker and some are for a different broker. In this case the 
"logicalAddress" is the final broker address.
   
   Eg: lookup for topic "t-1" returns "broker-1", with proxy flag turned on. 
   
   Client connects to proxy address and adds this connection to pool, marking 
this is for "broker-1". 
   
   Next time the client will need a connection to "broker-1", it will reuse the 
same connection to proxy.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jai1 commented on issue #1125: Added missing C++ enum values

[GitBox]

jai1 commented on issue #1125: Added missing C++ enum values
URL: https://github.com/apache/incubator-pulsar/pull/1125#issuecomment-361327943
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1044: Compact algo

[GitBox]

merlimat commented on a change in pull request #1044: Compact algo
URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r164508229
 
 

 ##
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/compaction/TwoPhaseCompactor.java
 ##
 @@ -0,0 +1,282 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.compaction;
+
+import com.google.common.collect.ImmutableMap;
+import io.netty.buffer.ByteBuf;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.Future;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.Semaphore;
+import java.util.concurrent.TimeoutException;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.bookkeeper.client.BKException;
+import org.apache.bookkeeper.client.BookKeeper;
+import org.apache.bookkeeper.client.LedgerHandle;
+
+import org.apache.pulsar.broker.ServiceConfiguration;
+import org.apache.pulsar.common.api.Commands;
+import org.apache.pulsar.common.api.proto.PulsarApi.MessageMetadata;
+import org.apache.pulsar.client.api.MessageId;
+import org.apache.pulsar.client.api.PulsarClient;
+import org.apache.pulsar.client.api.RawReader;
+import org.apache.pulsar.client.api.RawMessage;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Compaction will go through the topic in two passes. The first pass
+ * selects latest offset for each key in the topic. Then the second pass
+ * writes these values to a ledger.
+ *
+ * The two passes are required to avoid holding the payloads of each of
+ * the latest values in memory, as the payload can be many orders of
+ * magnitude larger than a message id.
+*/
+public class TwoPhaseCompactor extends Compactor {
+private static final Logger log = LoggerFactory.getLogger(Compactor.class);
+private static final int MAX_OUTSTANDING = 500;
+private static final String COMPACTED_TOPIC_LEDGER_PROPERTY = 
"CompactedTopicLedger";
+
+public TwoPhaseCompactor(ServiceConfiguration conf,
+ PulsarClient pulsar,
+ BookKeeper bk,
+ ScheduledExecutorService scheduler) {
+super(conf, pulsar, bk, scheduler);
+}
+
+@Override
+protected CompletableFuture doCompaction(RawReader reader, 
BookKeeper bk) {
+return phaseOne(reader).thenCompose(
+(r) -> phaseTwo(reader, r.from, r.to, r.latestForKey, bk));
+}
+
+private CompletableFuture phaseOne(RawReader reader) {
+Map latestForKey = new HashMap<>();
+
+CompletableFuture loopPromise = new 
CompletableFuture<>();
+phaseOneLoop(reader, Optional.empty(), Optional.empty(), latestForKey, 
loopPromise);
+return loopPromise;
+}
+
+private void phaseOneLoop(RawReader reader,
+  Optional firstMessageId,
+  Optional lastMessageId,
+  Map latestForKey,
+  CompletableFuture loopPromise) {
+if (loopPromise.isDone()) {
+return;
+}
+CompletableFuture future = reader.readNextAsync();
+scheduleTimeout(future);
+future.whenComplete(
+(m, exception) -> {
+try {
+if (exception != null) {
+if (exception instanceof TimeoutException
+&& firstMessageId.isPresent()) {
+loopPromise.complete(new 
PhaseOneResult(firstMessageId.get(),
+
lastMessageId.get(),
+
latestForKey));
+} else {
+loopPromise.completeExceptionally(exception);
+}
+return;
+}
+
+MessageId id = m.getMessageId();
+String key = extractKey(m);

[GitHub] jai1 commented on a change in pull request #1124: Support Pulsar proxy from C++/Python client library

[GitBox]

jai1 commented on a change in pull request #1124: Support Pulsar proxy from 
C++/Python client library
URL: https://github.com/apache/incubator-pulsar/pull/1124#discussion_r164505677
 
 

 ##
 File path: pulsar-client-cpp/lib/Url.h
 ##
 @@ -41,6 +41,8 @@ class Url {
 const std::string& parameter() const;
 friend std::ostream& operator<<(std::ostream& os, const Url& obj);
 
+std::string hostPort() const;
 
 Review comment:
   How about returning const reference:-
   const std::string& hostPort() const;


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1047: Add StatefulSet option for BookKeeper on Google Kubernetes Engine

[GitBox]

merlimat commented on issue #1047: Add StatefulSet option for BookKeeper on 
Google Kubernetes Engine
URL: https://github.com/apache/incubator-pulsar/pull/1047#issuecomment-361325066
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[incubator-pulsar] branch master updated: Comment in config breaks docker scripts (#1131)

[mmerli]

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
 new b3fe055  Comment in config breaks docker scripts (#1131)
b3fe055 is described below

commit b3fe055942b4bd4b8befc96b347140fdfe276f73
Author: Ivan Kelly 
AuthorDate: Mon Jan 29 18:39:30 2018 +0100

Comment in config breaks docker scripts (#1131)

docker/scripts/apply-config-from-env.py only accepts # comments, not
double slash.
---
 conf/broker.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/conf/broker.conf b/conf/broker.conf
index de8ab1a..7f9dd33 100644
--- a/conf/broker.conf
+++ b/conf/broker.conf
@@ -165,7 +165,7 @@ enableNonPersistentTopics=true
 # Enable to run bookie along with broker
 enableRunBookieTogether=false
 
-// Enable to run bookie autorecovery along with broker
+# Enable to run bookie autorecovery along with broker
 enableRunBookieAutoRecoveryTogether=false
 
 ### --- Authentication --- ###

-- 
To stop receiving notification emails like this one, please contact
mme...@apache.org.

[GitHub] merlimat closed pull request #1131: Comment in config breaks docker scripts

[GitBox]

merlimat closed pull request #1131: Comment in config breaks docker scripts
URL: https://github.com/apache/incubator-pulsar/pull/1131
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/conf/broker.conf b/conf/broker.conf
index de8ab1a2b..7f9dd3396 100644
--- a/conf/broker.conf
+++ b/conf/broker.conf
@@ -165,7 +165,7 @@ enableNonPersistentTopics=true
 # Enable to run bookie along with broker
 enableRunBookieTogether=false
 
-// Enable to run bookie autorecovery along with broker
+# Enable to run bookie autorecovery along with broker
 enableRunBookieAutoRecoveryTogether=false
 
 ### --- Authentication --- ###


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1134: [WIP] Docker compose files for pulsar

[GitBox]

merlimat commented on issue #1134: [WIP] Docker compose files for pulsar
URL: https://github.com/apache/incubator-pulsar/pull/1134#issuecomment-361319778
 
 
   Even though this is not technically a "prod" deployment, should we have it 
under the `deployment` folder?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker

[GitBox]

merlimat commented on a change in pull request #1132: Explicitly set zookeeper 
version in broker
URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164501056
 
 

 ##
 File path: pulsar-broker/pom.xml
 ##
 @@ -119,6 +119,34 @@
   test
 
 
+
 
 Review comment:
   I think the issue is that we're not specifying ZK in the 
`` section like most other dependencies. Right now we 
only have the `tests` ZK artifact defined there: 
https://github.com/apache/incubator-pulsar/blob/master/pom.xml#L168 
   
   Once we set it in the `dependencyManagement` it will override the ZK version 
for all the modules in the project (and transitive dependencies)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ivankelly commented on issue #1134: [WIP] Docker compose files for pulsar

[GitBox]

ivankelly commented on issue #1134: [WIP] Docker compose files for pulsar
URL: https://github.com/apache/incubator-pulsar/pull/1134#issuecomment-361294703
 
 
   Currently only works with docker images generated with #1131 and #1132 
applied.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ivankelly opened a new pull request #1134: Docker compose files for pulsar

[GitBox]

ivankelly opened a new pull request #1134: Docker compose files for pulsar
URL: https://github.com/apache/incubator-pulsar/pull/1134
 
 
   These files set up two clusters, US and EU, all on the local
   machine. Each cluster has 2 pulsar brokers, 3 bookies, and a 2
   zookeeper nodes, one in global ensemble and one standalone.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ivankelly opened a new pull request #1133: Property name in documentation is incorrect

[GitBox]

ivankelly opened a new pull request #1133: Property name in documentation is 
incorrect
URL: https://github.com/apache/incubator-pulsar/pull/1133
 
 
   The setup guides specify that test-prop is the property name, but then
   all later examples use test as the property name. This is obviously
   wrong, and this patch fixes that.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ivankelly opened a new pull request #1132: Explicitly set zookeeper version in broker

[GitBox]

ivankelly opened a new pull request #1132: Explicitly set zookeeper version in 
broker
URL: https://github.com/apache/incubator-pulsar/pull/1132
 
 
   The broker "shades" zookeeper via the aspectj stuff, but the version
   it shades is the one pulled in with bookkeeper-server, not the version
   specified in the top level pom. This is fairly harmless, but it breaks
   the pulsar zookeeper-shell command if you want to specify a zookeeper
   command from the commandline.
   
   This change explicitly pulls in the correct zookeeper version,
   excluding all the stuff that we usually exclude when pulling zookeeper.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ivankelly opened a new pull request #1131: Comment in config breaks docker scripts

[GitBox]

ivankelly opened a new pull request #1131: Comment in config breaks docker 
scripts
URL: https://github.com/apache/incubator-pulsar/pull/1131
 
 
   docker/scripts/apply-config-from-env.py only accepts # comments, not
   double slash.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jai1 commented on issue #1002: Making Pulsar Proxy more secure

[GitBox]

jai1 commented on issue #1002: Making Pulsar Proxy more secure
URL: https://github.com/apache/incubator-pulsar/pull/1002#issuecomment-361228242
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services