RE: [ACS42][Discuss] Netscaler as External LB Provider in VPC

2013-05-09 Thread Rajesh Battala


> -Original Message-
> From: Sailaja Mada [mailto:sailaja.m...@citrix.com]
> Sent: Monday, April 15, 2013 10:23 AM
> To: dev@cloudstack.apache.org
> Subject: RE: [ACS42][Discuss] Netscaler as External LB Provider in VPC
> 
> Hi Rajesh,
> 
> Few clarifications after going thru the FS :
> 
> 1. Do we support autoscale in VPC if the Netscaler added has support for
> autoscale ? Please update FS if it is not 2. It is mentioned as - User should
> select the offering "Default VPC offering with NS" -  I guess user has 
> flexibility
> to create the VPC offering ?
[Rajesh Battala] autoscale should be working, the way it should work in 
isolated guest network.
> 3. If I have both shared and dedicated mode Netscaler devices available, Do
> you have an implementation check to choose only dedicated mode Netscaler
> device if it is VPC webtier? How are you finding that it is of type VPC . Is 
> it
> thru the Network offering which is selected to create Tier ?
[Rajesh Battala]  for Netscaler to be in VPC,  it should be in dedicated mode.  
While creating n/w offering validation is taken care to make sure NS is in 
dedicated mode. 

>How about providing new parameter while adding Netscaler device if it is
> meant to be used for VPC.  Just a thought.
[Rajesh Battala] Nice thought but logic of existing dedication of NS holds good.
> 4. With Restart VPC/Remove VPC - Will you be taking care of cleanup @
> Netscaler ? - Please provide the details about it.
[Rajesh Battala] when Netscaler is not required cleanup will happen the same 
way it happens in isolated guest n/w.
> 5.  UI flow , Currently we enable only VPC VR while creating VPC Network
> offering. Now we should enable Netscaler while selecting Loadbalancer
> service.  
[Rajesh Battala]  NS should be enabled when VPC is getting created with the VPC 
offering where NS is required. It will be prompted to the user to do the same.
FS need to be updated with this.
> 
> Thanks,
> Sailaja.M
> 
> -Original Message-
> From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> Sent: Sunday, April 14, 2013 11:23 PM
> To: dev@cloudstack.apache.org
> Subject: [ACS42][Discuss] Netscaler as External LB Provider in VPC
> 
> Hi All,
> 
> I would be working on implementing Netscaler as External LB Provider in vpc.
> 
> Jira ticket for the feature:
> https://issues.apache.org/jira/browse/CLOUDSTACK-869
> 
> FS location for the Netscaler as External LB Provider in VPC.
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+of+Netsc
> aler+as+External+LoadBalancing+Provider+in+VPC
> 
> Please share your thoughts.
> 
> Thanks
> Rajesh Battala


RE: [ACS42][QA] Test Plan for Support of Netscaler as external LB in VPC

2013-05-09 Thread Rajesh Battala
Please see my comments in-line. Please let me know your comments.

> -Original Message-
> From: Sowmya Krishnan
> Sent: Tuesday, May 7, 2013 3:34 PM
> To: dev@cloudstack.apache.org
> Cc: Rajesh Battala
> Subject: [ACS42][QA] Test Plan for Support of Netscaler as external LB in VPC
> 
> I am planning to take up test execution for the feature : "Support for
> Netscaler as External Load Balancer in VPC"
> I've written some test cases for the same. Please review and let me know if
> any comments.
> Here are Test cases:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+Nets
> caler+as+External+Load+Balancer+in+VPC+Tests
> 
> Ref FS for the feature is here:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+of+Netsc
> aler+as+External+LoadBalancing+Provider+in+VPC
> 
[Rajesh Battala] 
48. Create VPC with shared NS : It should fail only when tier is created and 
implemented with NS as LB ( when NS of type only shared is available it should 
fail) not while creating VPC.


Tests cases that should/can be  include :
1. As External Devices (Netscaler) is involved while tier creation, cidr should 
be subset from the super cidr ( new cidr out of super cidr should not be 
generated)
2. When tier is created with LB as Netscaler ( and network is implemented) the 
VpcVR should have a new nic attached and the ip of the nic should be the 
gateway ip specified while creating the tier.
3. when tier is created with LB as NS,  when a dedicated NS is available  after 
tier got implemented NS state should be in allocated.
4. when the tier is delete where NS is dedicate, NS allocation state should be 
moved to free pool.
5. Deletion of NS device should fail if the device is in active/used in the 
tier. 


> There are few questions on the FS as I was writing the tests. Rajesh, could
> you please let me know your response for these. I'll update the Test plan
> accordingly.
> 
> 1. I am assuming upgrade of VPC offering from Default offering to "Default
> Offering with NS" is allowed. If not, need to update this in the FS if there 
> are
> any limitations on this front.
[Rajesh Battala] Upgrading  not supported currently. We can create an 
enhancement to track it.
> 2. On the same lines, upgrade of network offering of the network tier is also
> possible I assume . (For example, from LB provided by VpcVirtualRouter to LB
> provided by Netscaler) 
[Rajesh Battala]  Upgrading of LB is possible but not supported currently.
3. Also on the UI front, currently while creating
> network offering for the tier, if we choose VPC, Netscaler as service provider
> for LB is disabled. We need to enable this.
[Rajesh Battala] yes we need to enable this otherwise VPC n/w offering cannot 
be created. I will add it in FS.
> 
> Thanks,
> Sowmya


Fix for CLOUDSTACK-2277

2013-05-09 Thread Saksham Srivastava
Hi Mice ,

I just saw your commit for 
https://issues.apache.org/jira/browse/CLOUDSTACK-2277
So  I recently picked this bug, marked it  as "in progress" as I was 
working on it and was about to submit the patch for the same, but then I 
saw that you already fixed it :)

A quick comment :
The fix makes sure that if vm-tools are not running on the vm, 
add/remove nic fails.
What I have observed is that if vm-tools are not running, a reboot of 
the vm will actually show up the added NIC. IMO we should allow the api 
to pass, but provide a log message that reboot of vm will be required 
for added NIC to show up, rather than completely failing the api.

Your thoughts ?

Thanks,
Saksham

RE: Fix for CLOUDSTACK-2277

2013-05-09 Thread Mice Xia
Saksham,

Really sorry I didn’t notice it's in progress until I pushed the commit.. I can 
revert it if necessary.

Yes, without vmtool, a reboot of the VM can bring up the added NIC, but 
removing NIC fails in my environment, the nic is still there even after a 
reboot, can you confirm it in your env? 

Regards
Mice

-Original Message-
From: Saksham Srivastava [mailto:saksham.srivast...@citrix.com] 
Sent: Thursday, May 09, 2013 4:37 PM
To: Mice Xia; dev@cloudstack.apache.org
Subject: Fix for CLOUDSTACK-2277

Hi Mice ,

I just saw your commit for
https://issues.apache.org/jira/browse/CLOUDSTACK-2277
So  I recently picked this bug, marked it  as "in progress" as I was working on 
it and was about to submit the patch for the same, but then I saw that you 
already fixed it :)

A quick comment :
The fix makes sure that if vm-tools are not running on the vm, add/remove nic 
fails.
What I have observed is that if vm-tools are not running, a reboot of the vm 
will actually show up the added NIC. IMO we should allow the api to pass, but 
provide a log message that reboot of vm will be required for added NIC to show 
up, rather than completely failing the api.

Your thoughts ?

Thanks,
Saksham


RE: [ACS42][QA] Test Plan for Support of Netscaler as external LB in VPC

2013-05-09 Thread Sowmya Krishnan
Thanks Rajesh. Could you please let me know the technical reason why we are not 
supporting Upgrade of VPC network offering or network tier LB? 
This limitation needs to be documented. Also, could you please update the same 
in FS too.

> -Original Message-
> From: Rajesh Battala
> Sent: Thursday, May 09, 2013 1:54 PM
> To: Sowmya Krishnan; dev@cloudstack.apache.org
> Subject: RE: [ACS42][QA] Test Plan for Support of Netscaler as external LB in
> VPC
> 
> Please see my comments in-line. Please let me know your comments.
> 
> > -Original Message-
> > From: Sowmya Krishnan
> > Sent: Tuesday, May 7, 2013 3:34 PM
> > To: dev@cloudstack.apache.org
> > Cc: Rajesh Battala
> > Subject: [ACS42][QA] Test Plan for Support of Netscaler as external LB
> > in VPC
> >
> > I am planning to take up test execution for the feature : "Support for
> > Netscaler as External Load Balancer in VPC"
> > I've written some test cases for the same. Please review and let me
> > know if any comments.
> > Here are Test cases:
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+Net
> > s
> > caler+as+External+Load+Balancer+in+VPC+Tests
> >
> > Ref FS for the feature is here:
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+of+Nets
> > c
> > aler+as+External+LoadBalancing+Provider+in+VPC
> >
> [Rajesh Battala]
> 48. Create VPC with shared NS : It should fail only when tier is created and
> implemented with NS as LB ( when NS of type only shared is available it should
> fail) not while creating VPC.
> 
> 
> Tests cases that should/can be  include :
> 1. As External Devices (Netscaler) is involved while tier creation, cidr 
> should be
> subset from the super cidr ( new cidr out of super cidr should not be 
> generated)
> 2. When tier is created with LB as Netscaler ( and network is implemented) the
> VpcVR should have a new nic attached and the ip of the nic should be the
> gateway ip specified while creating the tier.
> 3. when tier is created with LB as NS,  when a dedicated NS is available  
> after tier
> got implemented NS state should be in allocated.
> 4. when the tier is delete where NS is dedicate, NS allocation state should be
> moved to free pool.
> 5. Deletion of NS device should fail if the device is in active/used in the 
> tier.
> 
> 
> > There are few questions on the FS as I was writing the tests. Rajesh, could
> > you please let me know your response for these. I'll update the Test plan
> > accordingly.
> >
> > 1. I am assuming upgrade of VPC offering from Default offering to "Default
> > Offering with NS" is allowed. If not, need to update this in the FS if 
> > there are
> > any limitations on this front.
> [Rajesh Battala] Upgrading  not supported currently. We can create an
> enhancement to track it.
> > 2. On the same lines, upgrade of network offering of the network tier is 
> > also
> > possible I assume . (For example, from LB provided by VpcVirtualRouter to LB
> > provided by Netscaler)
> [Rajesh Battala]  Upgrading of LB is possible but not supported currently.
> 3. Also on the UI front, currently while creating
> > network offering for the tier, if we choose VPC, Netscaler as service 
> > provider
> > for LB is disabled. We need to enable this.
> [Rajesh Battala] yes we need to enable this otherwise VPC n/w offering cannot
> be created. I will add it in FS.
> >
> > Thanks,
> > Sowmya


Re: [MERGE] CS-2163

2013-05-09 Thread Nitin Mehta


On 03/05/13 7:58 PM, "Chip Childers"  wrote:

>On Fri, May 03, 2013 at 04:11:21AM +, Murali Reddy wrote:
>> On 02/05/13 11:20 PM, "Chiradeep Vittal" 
>> wrote:
>> 
>> >
>> >
>> >On 5/2/13 6:24 AM, "Chip Childers"  wrote:
>> >
>> >>On Thu, May 02, 2013 at 12:40:45PM +0530, Abhinandan Prateek wrote:
>> >>> 
>> >>> The tags are name-value pairs basically meant to label resources by
>>a
>> >>>user.
>> >>> The purpose of the current API is to add useful meta information to
>> >>> resources so that they can be meaningfully controlled by external
>> >>>tools.
>> >>> 
>> >>> The current implementation of meta info API may look similar to tags
>> >>>with
>> >>> possible edition of a "system" or a "user" qualifier/flag in order
>>to
>> >>> control visibility.
>> >>> 
>> >>> But it is not so. Tags by definition are name value pairs where both
>> >>>name
>> >>> and value is a string. If we try to set the meta data information in
>> >>>the
>> >>> tags we are severely restricting the type of meta information that
>>can
>> >>>be
>> >>> contained in the tags. For example if the "data-type" information is
>> >>> required in this meta-data we will end up tweaking the tag system to
>> >>>serve
>> >>> some purpose that it is not meant for.
>> >>> 
>> >>> I strongly suggest that we do not try to contain the meta
>>information
>> >>>in a
>> >>> restricted framework provided by tags.
>> >>> 
>> >>> -abhi
>> >>
>> >>I don't understand this argument.  Most primary data types have string
>> >>representations, right?  (ref: JSON)
>> >>
>> >>Are you talking about complex types?  Or things like integers, long,
>> >>datetime, etc...?
>> >
>> >I didn't understand it either.
>> >Perhaps the issue is whether this meta-data is available to the
>>end-user
>> >or not? At least, tags are visible to the end-user. Is it the intention
>> >that this 3rd party service do its magic in cahoots with the admin?
>> >
>> >
>> 
>> I would like to see this as, meta-data that has semantic meaning to
>> CloudStack vs meta-data that's purely user meta-data that has no meaning
>> to CloudStack and its plug-ins. 'Tags' falls in second category.
>
>Aren't tags used quite a bit for placement functions?
>
>> From e.g.
>> use-case Nitin has put in FS, I do see valid case where a
>>plug-in/feature
>> of CloudStack or external systems like to book keep information of an
>> entity. We already have a pattern of storing such meta data of entities
>> (user_vm_details, cluster_details etc) in the details table which is
>> basically a key-value pair. IMO, I see no harm if we can generalise it.
>
>I agree with generalizing it, absolutely.
>
>I think my question is:  Are we talking about CS internals only?  Or are
>we talking about a truly generalized system that can contain metadata
>for the system, the admins and the users?  When I read the functional
>spec, 
>it seems confusing as to which of these are being focused on, and if not
>all of them are we getting ourselves into another situation where the
>data authorization model is limited to some specific use case and not
>flexible enough to extend in other ways?
>
>One other FS question:
>
>I see this: "DeployVM/UpdateVM/ - Add flag whether to display the VM to
>end user".  What's the definition of "end user" in this scenario?  Are
>account admins end users?  How about domain admins?  Is root admin the
>only one that can see these things?

Yes, currently as per the use case root admin is the only one allowed to
give him control over the first class objects, but again this can be
customized in future.

>
>It seems that the implementation is limited in scope yet again to a
>boolean flag.  Similar to the question of metadata scope, why would this
>not be designed to be a more robust data authorization model?
>
>It seems like this whole feature should be approached as:
>
>1 - Define a data structure (possibly extending tags) that allows for
>flexible key/value pairs being attached to virtual entities within CS.

As per suggestions by Murali, I am planning to introduce a generic api to
add semantic meta data to the first class objects.

>
>2 - Build an ACL model that's actually able to handle different ACL
>requirements for that metadata AS WELL AS for the foundational virtual
>resources.

Valid point. I am going to currently enable it for root admin but
certainly the design can be extended to handle ACL requirements in future
as well. 

>
>Perhaps I'm over complicating things, but this FS was only first created
>on April 25 and I think that these concerns need to be discussed /
>debated.
>
>-chip



RE: [ACS42][QA] Test Plan for Support of Netscaler as external LB in VPC

2013-05-09 Thread Rajesh Battala
There are two things, upgrading VPC, and upgrading VPC network offering. 
Upgrading VPC is not supported. 

Upgrading VPC networking offering (only valid scenario is LB vpc to NS Lb). 
upgrading the network where External device is involved changing the cidr. 
Will update in FS.

> -Original Message-
> From: Sowmya Krishnan
> Sent: Thursday, May 9, 2013 2:38 PM
> To: Rajesh Battala; dev@cloudstack.apache.org
> Subject: RE: [ACS42][QA] Test Plan for Support of Netscaler as external LB in
> VPC
> 
> Thanks Rajesh. Could you please let me know the technical reason why we
> are not supporting Upgrade of VPC network offering or network tier LB?
> This limitation needs to be documented. Also, could you please update the
> same in FS too.
> 
> > -Original Message-
> > From: Rajesh Battala
> > Sent: Thursday, May 09, 2013 1:54 PM
> > To: Sowmya Krishnan; dev@cloudstack.apache.org
> > Subject: RE: [ACS42][QA] Test Plan for Support of Netscaler as
> > external LB in VPC
> >
> > Please see my comments in-line. Please let me know your comments.
> >
> > > -Original Message-
> > > From: Sowmya Krishnan
> > > Sent: Tuesday, May 7, 2013 3:34 PM
> > > To: dev@cloudstack.apache.org
> > > Cc: Rajesh Battala
> > > Subject: [ACS42][QA] Test Plan for Support of Netscaler as external
> > > LB in VPC
> > >
> > > I am planning to take up test execution for the feature : "Support
> > > for Netscaler as External Load Balancer in VPC"
> > > I've written some test cases for the same. Please review and let me
> > > know if any comments.
> > > Here are Test cases:
> > >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+N
> > > et
> > > s
> > > caler+as+External+Load+Balancer+in+VPC+Tests
> > >
> > > Ref FS for the feature is here:
> > >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+of+Ne
> > > ts
> > > c
> > > aler+as+External+LoadBalancing+Provider+in+VPC
> > >
> > [Rajesh Battala]
> > 48. Create VPC with shared NS : It should fail only when tier is
> > created and implemented with NS as LB ( when NS of type only shared is
> > available it should
> > fail) not while creating VPC.
> >
> >
> > Tests cases that should/can be  include :
> > 1. As External Devices (Netscaler) is involved while tier creation,
> > cidr should be subset from the super cidr ( new cidr out of super cidr
> > should not be generated) 2. When tier is created with LB as Netscaler
> > ( and network is implemented) the VpcVR should have a new nic attached
> > and the ip of the nic should be the gateway ip specified while creating the
> tier.
> > 3. when tier is created with LB as NS,  when a dedicated NS is
> > available  after tier got implemented NS state should be in allocated.
> > 4. when the tier is delete where NS is dedicate, NS allocation state
> > should be moved to free pool.
> > 5. Deletion of NS device should fail if the device is in active/used in the
> tier.
> >
> >
> > > There are few questions on the FS as I was writing the tests.
> > > Rajesh, could you please let me know your response for these. I'll
> > > update the Test plan accordingly.
> > >
> > > 1. I am assuming upgrade of VPC offering from Default offering to
> > > "Default Offering with NS" is allowed. If not, need to update this
> > > in the FS if there are any limitations on this front.
> > [Rajesh Battala] Upgrading  not supported currently. We can create an
> > enhancement to track it.
> > > 2. On the same lines, upgrade of network offering of the network
> > > tier is also possible I assume . (For example, from LB provided by
> > > VpcVirtualRouter to LB provided by Netscaler)
> > [Rajesh Battala]  Upgrading of LB is possible but not supported currently.
> > 3. Also on the UI front, currently while creating
> > > network offering for the tier, if we choose VPC, Netscaler as
> > > service provider for LB is disabled. We need to enable this.
> > [Rajesh Battala] yes we need to enable this otherwise VPC n/w offering
> > cannot be created. I will add it in FS.
> > >
> > > Thanks,
> > > Sowmya


Re: [MERGE] CS-2163

2013-05-09 Thread Nitin Mehta
Updated the FS [1] as per the discussion. So the plan is to introduce a
generic api to
add semantic meta data to the first class objects.

AddResourceDetail - Add details to resource

* resourceIds - List of resource ids
* resourceType - Example - volume, nic etc.
* details - Map of key/value pairs

DeleteResourceDetail - Remove detail to resource

* resourceIds - List of resource ids
* resourceType - Example - volume, nic etc.
* details - Map of key/value pairs

ListResourceDetails - lists details for a resource

* resourceId 
* resourceType - Example - volume, nic etc.
* key
* value



[1] - 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Ability+to+have+bett
er+control+over+first+class+objects+in+CS


On 09/05/13 3:04 PM, "Nitin Mehta"  wrote:

>
>
>On 03/05/13 7:58 PM, "Chip Childers"  wrote:
>
>>On Fri, May 03, 2013 at 04:11:21AM +, Murali Reddy wrote:
>>> On 02/05/13 11:20 PM, "Chiradeep Vittal" 
>>> wrote:
>>> 
>>> >
>>> >
>>> >On 5/2/13 6:24 AM, "Chip Childers"  wrote:
>>> >
>>> >>On Thu, May 02, 2013 at 12:40:45PM +0530, Abhinandan Prateek wrote:
>>> >>> 
>>> >>> The tags are name-value pairs basically meant to label resources by
>>>a
>>> >>>user.
>>> >>> The purpose of the current API is to add useful meta information to
>>> >>> resources so that they can be meaningfully controlled by external
>>> >>>tools.
>>> >>> 
>>> >>> The current implementation of meta info API may look similar to
>>>tags
>>> >>>with
>>> >>> possible edition of a "system" or a "user" qualifier/flag in order
>>>to
>>> >>> control visibility.
>>> >>> 
>>> >>> But it is not so. Tags by definition are name value pairs where
>>>both
>>> >>>name
>>> >>> and value is a string. If we try to set the meta data information
>>>in
>>> >>>the
>>> >>> tags we are severely restricting the type of meta information that
>>>can
>>> >>>be
>>> >>> contained in the tags. For example if the "data-type" information
>>>is
>>> >>> required in this meta-data we will end up tweaking the tag system
>>>to
>>> >>>serve
>>> >>> some purpose that it is not meant for.
>>> >>> 
>>> >>> I strongly suggest that we do not try to contain the meta
>>>information
>>> >>>in a
>>> >>> restricted framework provided by tags.
>>> >>> 
>>> >>> -abhi
>>> >>
>>> >>I don't understand this argument.  Most primary data types have
>>>string
>>> >>representations, right?  (ref: JSON)
>>> >>
>>> >>Are you talking about complex types?  Or things like integers, long,
>>> >>datetime, etc...?
>>> >
>>> >I didn't understand it either.
>>> >Perhaps the issue is whether this meta-data is available to the
>>>end-user
>>> >or not? At least, tags are visible to the end-user. Is it the
>>>intention
>>> >that this 3rd party service do its magic in cahoots with the admin?
>>> >
>>> >
>>> 
>>> I would like to see this as, meta-data that has semantic meaning to
>>> CloudStack vs meta-data that's purely user meta-data that has no
>>>meaning
>>> to CloudStack and its plug-ins. 'Tags' falls in second category.
>>
>>Aren't tags used quite a bit for placement functions?
>>
>>> From e.g.
>>> use-case Nitin has put in FS, I do see valid case where a
>>>plug-in/feature
>>> of CloudStack or external systems like to book keep information of an
>>> entity. We already have a pattern of storing such meta data of entities
>>> (user_vm_details, cluster_details etc) in the details table which is
>>> basically a key-value pair. IMO, I see no harm if we can generalise it.
>>
>>I agree with generalizing it, absolutely.
>>
>>I think my question is:  Are we talking about CS internals only?  Or are
>>we talking about a truly generalized system that can contain metadata
>>for the system, the admins and the users?  When I read the functional
>>spec, 
>>it seems confusing as to which of these are being focused on, and if not
>>all of them are we getting ourselves into another situation where the
>>data authorization model is limited to some specific use case and not
>>flexible enough to extend in other ways?
>>
>>One other FS question:
>>
>>I see this: "DeployVM/UpdateVM/ - Add flag whether to display the VM to
>>end user".  What's the definition of "end user" in this scenario?  Are
>>account admins end users?  How about domain admins?  Is root admin the
>>only one that can see these things?
>
>Yes, currently as per the use case root admin is the only one allowed to
>give him control over the first class objects, but again this can be
>customized in future.
>
>>
>>It seems that the implementation is limited in scope yet again to a
>>boolean flag.  Similar to the question of metadata scope, why would this
>>not be designed to be a more robust data authorization model?
>>
>>It seems like this whole feature should be approached as:
>>
>>1 - Define a data structure (possibly extending tags) that allows for
>>flexible key/value pairs being attached to virtual entities within CS.
>
>As per suggestions by Murali, I am planning to introduce a generic api to
>add semantic meta data to the first class objects.
>
>>

error on starting devcloud2

2013-05-09 Thread Nazri Abdulah
Hi,

I just want to start my 1st DevCloud2 on my virtualbox in OSX Lion OS, but the 
following error appears, please advice?

Could not start the machine DevCloud2 because the following physical network 
interfaces were not found:

vboxnet0 (adapter 1)

Regards
Nazri


RE: error on starting devcloud2

2013-05-09 Thread Rajesh Battala
Hi Nazri,
Create a Adapter, of type Host-only Adapter and enable the adapter. It should 
work. 

Thanks
Rajesh Battala

> -Original Message-
> From: Nazri Abdulah [mailto:na...@kth.se]
> Sent: Thursday, May 9, 2013 2:51 PM
> To: cloudstack-...@incubator.apache.org
> Subject: error on starting devcloud2
> 
> Hi,
> 
> I just want to start my 1st DevCloud2 on my virtualbox in OSX Lion OS, but
> the following error appears, please advice?
> 
> Could not start the machine DevCloud2 because the following physical
> network interfaces were not found:
> 
> vboxnet0 (adapter 1)
> 
> Regards
> Nazri


RE: network guru refactor proposal

2013-05-09 Thread Daan Hoogland
Ok, got it. My picture won't be as pretty but I will put some wording there.

-Original Message-
From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] 
Sent: woensdag 8 mei 2013 19:14
To: dev@cloudstack.apache.org
Subject: Re: network guru refactor proposal

See for example the extensive documentation for 4.2 
https://cwiki.apache.org/confluence/x/dzXVAQ

The PVLAN one is a good one
https://cwiki.apache.org/confluence/x/c17VAQ


On 5/7/13 1:25 PM, "Daan Hoogland"  wrote:

>On 2013/5/7 19:18 , Chiradeep Vittal wrote:
>> For a major change, I'd expect a functional specification. It is 
>>still not  clear to me what is "nicira hosted private gateways". I can 
>>guess, but  without a concrete document, it is hard to see where you 
>>are going with  this.
>There is a jira ticket for it. Is this what you mean? Or do you want a 
>word-up with pre- and post conditions? The functional change is not 
>really big in comparison with the code change so a document seems 
>overkill to me but I am biased, so open to suggestions.
>
>in short: the user question is to be able to hook the newly to be 
>created vpc private gateway to an existing external network, in this 
>case a logical switch in nicira.
>
>regards,
>>
>> On 5/7/13 6:30 AM, "Daan Hoogland"  wrote:
>>
>>> The main objective is to have a nicira based private network guru to 
>>>use  for vpsgateways. I want to abstract common code with the 
>>>'generic' vlan  based private network but also abstract out 
>>>commonalities that might be  shared with the guest networks.  
>>>canHandle could be generalized and  called by all classes, though it 
>>>has another footprint now in the guest  networks then it has in 
>>>PrivateNetworkGuru.
>>>
>>> Alternatively I will copy code from NiciraNvpGuestNetworkGuru and  
>>>PrivateNetworkGuru to a new class and later refactor it, which is not 
>>>my  favorite way to go.
>>>
>>> I must admit that including network gurus that do not support any  
>>>extensions in the hierarchy is an esthetic touch if no code is shared.
>>>I
>>> will refrain if maintainability issues can be expected.
>>>
>>> Regards,
>>>
>>> -Original Message-
>>> From: Murali Reddy [mailto:murali.re...@citrix.com]
>>> Sent: dinsdag 7 mei 2013 15:17
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: network guru refactor proposal
>>>
>>> On 07/05/13 5:23 PM, "Daan Hoogland" 
>>>wrote:
>>>
 LS,

 I want to refactor the network guru hierarchy to put som 
 functionality in abstract base classes. This will come down to 
 extending the hierarchy for guest networks to include all gurus. 
 Are there any thoughts or gotchas to share?
>>> GuestNetworkGuru in some sense already acting as abstract base 
>>>class,  except for the fact that it is tied to 'Vlan' isolation. We 
>>>can  generalise the 'GuestNetworkGuru' and let the isolation type 
>>>specific  network design aspects to concrete classes. Other gurus 
>>>(direct, pod
>>> based) for guest networks does not have any extensions at this point 
>>>and  does not overlap much with GuestNetworkGuru, so they may remain 
>>>as is.
>>> Are there any specify observations that you think refactor will 
>>>address?
>>>
 This would be the second part of a three stage strategy I have to 
 support creating a nicira hosted private gateway for vpcs.
 The first one is making sure vlans are specified as uri throughout 
 the system. I will be submitting a patch for review for this part soon.
 The last part will be creating a guru based on Hugo's 
 NiciraNvpGuestNetworkGuru.

 Any comment is appreciated,
 Daan Hoogland

>>>



Re: Review Request: CLOUDSTACK-869-nTier-Apps-2.0_Support-NetScalar-as-external-LB-provider

2013-05-09 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10858/#review20374
---


Commit 2e2106002865cff8eb06b5c3a42bfd6f0f6848fb in branch refs/heads/master 
from Murali Reddy 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2e21060 ]

CLOUDSTACK-869 nTier Apps 2.0 : Support NetScalar as external LB provider


- ASF Subversion and Git Services


On May 8, 2013, 1:39 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10858/
> ---
> 
> (Updated May 8, 2013, 1:39 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala, Murali Reddy, Alena 
> Prokharchyk, Vijay Venkatachalam, and Ram Ganesh.
> 
> 
> Description
> ---
> 
> This feature will introduce Netscaler as external LB provider in VPC.
> As of now only 1 tier is support for external LB.
> A new VPC offering will be created "Default VPC Offering with NS" with all 
> the services provided by VPCVR and LB service with NetScaler.
> Existing NetscalerElement is used and implements VpcProvider.
> In VpcManager, Netscaler is added as one of the supported providers.
> Netscaler will be dedicated to the vpc.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/vpc/VpcOffering.java 3961d0a 
>   
> plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
>  7bd9c2e 
>   server/pom.xml 808dd3e 
>   server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92 
>   server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java b1606db 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9 
>   server/test/com/cloud/vpc/VpcTest.java PRE-CREATION 
>   
> server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java
>  cbb6c00 
> 
> Diff: https://reviews.apache.org/r/10858/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing:
> ==
> 1. Creation of Vpc with the default offering with NS is created successfully. 
> ( Enable Netscaler provider in network service providers)
> 2. Deletion of Vpc with the default offering with NS is deleted successfully.
> 3. Creation of new Vpc Network Offering with Netscaler as LB provider with 
> dedicated mode is created successfully.
> 4. Creation of new Vpc Network Offering with Netscaler as LB provider with 
> shared mode should throw exception.
> 5. Creation of tier (webtier) with the created Vpcnetscaler offering is 
> created successfully.
> 6. Verified Only one tier with netscaler as LB provider can be created. 
> 7. Verified deploying Instance in the tier is successful.
> 8. Verified a new nic got created with gateway ip from the tier cidr.
> 9. Verified deployed instance should get the ip from the specified tier cidr 
> range.
> 10. Acquire public ip in the vpc.
> 11. Verified creation on LB rule, is selecting only free dedicated Netscaler 
> device and necessary configuration is created and LB rule is created on NS
> 12. Deletion of LB rule is successful.
> 13. Modification of LB rule is successful
> 14. Creation of LB Health Check of TCP type is successful.
> 15. Deletion of LB Health Check of TCP type is successful.
> 16. Creation of LB Health Check of HTTP type is successful.
> 17. Deletion of LB Health Check of HTTP type is successful.
> 18. IpAssoc command is executed successful on Netscaler.
> 19. Deletion of tier will delete the tier and config on netscaler is cleared
> 20. Deletion of tier will mark the netscaler to be in free mode.
> 
> 
> Unit Test:
> ===
> Created VpcManger tests and added few tests to createNetworkOfferingTest
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>



Re: Review Request: CLOUDSTACK-869-nTier-Apps-2.0_Support-NetScalar-as-external-LB-provider

2013-05-09 Thread Murali Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10858/#review20375
---

Ship it!


Commit: 2e2106002865cff8eb06b5c3a42bfd6f0f6848fb

- Murali Reddy


On May 8, 2013, 1:39 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10858/
> ---
> 
> (Updated May 8, 2013, 1:39 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala, Murali Reddy, Alena 
> Prokharchyk, Vijay Venkatachalam, and Ram Ganesh.
> 
> 
> Description
> ---
> 
> This feature will introduce Netscaler as external LB provider in VPC.
> As of now only 1 tier is support for external LB.
> A new VPC offering will be created "Default VPC Offering with NS" with all 
> the services provided by VPCVR and LB service with NetScaler.
> Existing NetscalerElement is used and implements VpcProvider.
> In VpcManager, Netscaler is added as one of the supported providers.
> Netscaler will be dedicated to the vpc.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/vpc/VpcOffering.java 3961d0a 
>   
> plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
>  7bd9c2e 
>   server/pom.xml 808dd3e 
>   server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92 
>   server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java b1606db 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9 
>   server/test/com/cloud/vpc/VpcTest.java PRE-CREATION 
>   
> server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java
>  cbb6c00 
> 
> Diff: https://reviews.apache.org/r/10858/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing:
> ==
> 1. Creation of Vpc with the default offering with NS is created successfully. 
> ( Enable Netscaler provider in network service providers)
> 2. Deletion of Vpc with the default offering with NS is deleted successfully.
> 3. Creation of new Vpc Network Offering with Netscaler as LB provider with 
> dedicated mode is created successfully.
> 4. Creation of new Vpc Network Offering with Netscaler as LB provider with 
> shared mode should throw exception.
> 5. Creation of tier (webtier) with the created Vpcnetscaler offering is 
> created successfully.
> 6. Verified Only one tier with netscaler as LB provider can be created. 
> 7. Verified deploying Instance in the tier is successful.
> 8. Verified a new nic got created with gateway ip from the tier cidr.
> 9. Verified deployed instance should get the ip from the specified tier cidr 
> range.
> 10. Acquire public ip in the vpc.
> 11. Verified creation on LB rule, is selecting only free dedicated Netscaler 
> device and necessary configuration is created and LB rule is created on NS
> 12. Deletion of LB rule is successful.
> 13. Modification of LB rule is successful
> 14. Creation of LB Health Check of TCP type is successful.
> 15. Deletion of LB Health Check of TCP type is successful.
> 16. Creation of LB Health Check of HTTP type is successful.
> 17. Deletion of LB Health Check of HTTP type is successful.
> 18. IpAssoc command is executed successful on Netscaler.
> 19. Deletion of tier will delete the tier and config on netscaler is cleared
> 20. Deletion of tier will mark the netscaler to be in free mode.
> 
> 
> Unit Test:
> ===
> Created VpcManger tests and added few tests to createNetworkOfferingTest
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>



Re: Fix for CLOUDSTACK-2277

2013-05-09 Thread Saksham Srivastava
Mice, no need to revert. I also had similar issues that the NIC was 
present even after reboot.
May be we need to look into the difference in behavior.
But for now, I guess at-least the add api must be allowed to pass.
Your thoughts?

Thanks,
Saksham

On Thursday 09 May 2013 02:37 PM, Mice Xia wrote:
> Saksham,
>
> Really sorry I didn’t notice it's in progress until I pushed the commit.. I 
> can revert it if necessary.
>
> Yes, without vmtool, a reboot of the VM can bring up the added NIC, but 
> removing NIC fails in my environment, the nic is still there even after a 
> reboot, can you confirm it in your env?
>
> Regards
> Mice
>
> -Original Message-
> From: Saksham Srivastava [mailto:saksham.srivast...@citrix.com]
> Sent: Thursday, May 09, 2013 4:37 PM
> To: Mice Xia; dev@cloudstack.apache.org
> Subject: Fix for CLOUDSTACK-2277
>
> Hi Mice ,
>
> I just saw your commit for
> https://issues.apache.org/jira/browse/CLOUDSTACK-2277
> So  I recently picked this bug, marked it  as "in progress" as I was working 
> on it and was about to submit the patch for the same, but then I saw that you 
> already fixed it :)
>
> A quick comment :
> The fix makes sure that if vm-tools are not running on the vm, add/remove nic 
> fails.
> What I have observed is that if vm-tools are not running, a reboot of the vm 
> will actually show up the added NIC. IMO we should allow the api to pass, but 
> provide a log message that reboot of vm will be required for added NIC to 
> show up, rather than completely failing the api.
>
> Your thoughts ?
>
> Thanks,
> Saksham


Suport for Conserve Mode in a shared Network for Network Offering

2013-05-09 Thread Pranav Saxena
Hi ,

Could anyone confirm if  CloudStack supports enabling conserve mode while 
creating a Network Offering in a SHARED network . From what I know CloudStack 
used to support it only  for Isolated Networks .

Also as per Suresh , we can create a network offering for a shared network with 
Conserve Mode "On" using the API (CLOUDSTACK-2411)  which makes me think , if 
there has been any change in the code recently ?

Thanks,
Pranav


RE: [ACS42][QA] Test Plan for Support of Netscaler as external LB in VPC

2013-05-09 Thread Sowmya Krishnan


> -Original Message-
> From: Rajesh Battala
> Sent: Thursday, May 09, 2013 3:15 PM
> To: Sowmya Krishnan; dev@cloudstack.apache.org
> Subject: RE: [ACS42][QA] Test Plan for Support of Netscaler as external LB in
> VPC
> 
> There are two things, upgrading VPC, and upgrading VPC network offering.
> Upgrading VPC is not supported.
> 
Ok. I am talking about updateVPCOffering. Correct me if I am wrong here: we 
couldn't change VPC offering till now since we had only one offering for VPC: 
Default Offering. Now that we have a new offering (Default Offering with NS), 
shouldn't we allow updating the VPC offering? Otherwise, I don't see how we can 
upgrade the network tier offering to use External device without updating the 
VPC to use NS? 

> Upgrading VPC networking offering (only valid scenario is LB vpc to NS Lb).
> upgrading the network where External device is involved changing the cidr.

This is the network tier offering: updateNetwork. Are you saying this valid 
scenario is supported? Example: updateNetwork from offering which supports 
VPCVR as LB to offering which support NS as LB

> Will update in FS.

Thanks.

> 
> > -Original Message-
> > From: Sowmya Krishnan
> > Sent: Thursday, May 9, 2013 2:38 PM
> > To: Rajesh Battala; dev@cloudstack.apache.org
> > Subject: RE: [ACS42][QA] Test Plan for Support of Netscaler as
> > external LB in VPC
> >
> > Thanks Rajesh. Could you please let me know the technical reason why
> > we are not supporting Upgrade of VPC network offering or network tier LB?
> > This limitation needs to be documented. Also, could you please update
> > the same in FS too.
> >
> > > -Original Message-
> > > From: Rajesh Battala
> > > Sent: Thursday, May 09, 2013 1:54 PM
> > > To: Sowmya Krishnan; dev@cloudstack.apache.org
> > > Subject: RE: [ACS42][QA] Test Plan for Support of Netscaler as
> > > external LB in VPC
> > >
> > > Please see my comments in-line. Please let me know your comments.
> > >
> > > > -Original Message-
> > > > From: Sowmya Krishnan
> > > > Sent: Tuesday, May 7, 2013 3:34 PM
> > > > To: dev@cloudstack.apache.org
> > > > Cc: Rajesh Battala
> > > > Subject: [ACS42][QA] Test Plan for Support of Netscaler as
> > > > external LB in VPC
> > > >
> > > > I am planning to take up test execution for the feature : "Support
> > > > for Netscaler as External Load Balancer in VPC"
> > > > I've written some test cases for the same. Please review and let
> > > > me know if any comments.
> > > > Here are Test cases:
> > > >
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+N
> > > > et
> > > > s
> > > > caler+as+External+Load+Balancer+in+VPC+Tests
> > > >
> > > > Ref FS for the feature is here:
> > > >
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+of+Ne
> > > > ts
> > > > c
> > > > aler+as+External+LoadBalancing+Provider+in+VPC
> > > >
> > > [Rajesh Battala]
> > > 48. Create VPC with shared NS : It should fail only when tier is
> > > created and implemented with NS as LB ( when NS of type only shared
> > > is available it should
> > > fail) not while creating VPC.
> > >
> > >
> > > Tests cases that should/can be  include :
> > > 1. As External Devices (Netscaler) is involved while tier creation,
> > > cidr should be subset from the super cidr ( new cidr out of super
> > > cidr should not be generated) 2. When tier is created with LB as
> > > Netscaler ( and network is implemented) the VpcVR should have a new
> > > nic attached and the ip of the nic should be the gateway ip
> > > specified while creating the
> > tier.
> > > 3. when tier is created with LB as NS,  when a dedicated NS is
> > > available  after tier got implemented NS state should be in allocated.
> > > 4. when the tier is delete where NS is dedicate, NS allocation state
> > > should be moved to free pool.
> > > 5. Deletion of NS device should fail if the device is in active/used
> > > in the
> > tier.
> > >
> > >
> > > > There are few questions on the FS as I was writing the tests.
> > > > Rajesh, could you please let me know your response for these. I'll
> > > > update the Test plan accordingly.
> > > >
> > > > 1. I am assuming upgrade of VPC offering from Default offering to
> > > > "Default Offering with NS" is allowed. If not, need to update this
> > > > in the FS if there are any limitations on this front.
> > > [Rajesh Battala] Upgrading  not supported currently. We can create
> > > an enhancement to track it.
> > > > 2. On the same lines, upgrade of network offering of the network
> > > > tier is also possible I assume . (For example, from LB provided by
> > > > VpcVirtualRouter to LB provided by Netscaler)
> > > [Rajesh Battala]  Upgrading of LB is possible but not supported currently.
> > > 3. Also on the UI front, currently while creating
> > > > network offering for the tier, if we choose VPC, Netscaler as
> > > > service provider for LB is disabled. We need to enable this.
> > > [Rajesh Battala] yes we need to enable this otherwise VPC

Re: Suport for Conserve Mode in a shared Network for Network Offering

2013-05-09 Thread Murali Reddy
Yes, conserve mode is supported for network offerings for shared networks. Its 
likely that original UI behaviour was to disable the check box, it did not make 
sense when shared networks just had DNS, DHCP services. Checkbox should be 
enabled when any of source NAT, static NAT, LB, FW services are selected. I 
might have missed this UI requirement when I added network services in shared 
network.

From: Pranav Saxena mailto:pranav.sax...@citrix.com>>
Date: Thursday, 9 May 2013 4:13 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Cc: Suresh Sadhu mailto:suresh.sa...@citrix.com>>, 
Murali Reddy mailto:murali.re...@citrix.com>>, Alena 
Prokharchyk mailto:alena.prokharc...@citrix.com>>
Subject: Suport for Conserve Mode in a shared Network for Network Offering

Hi ,

Could anyone confirm if  CloudStack supports enabling conserve mode while 
creating a Network Offering in a SHARED network . From what I know CloudStack 
used to support it only  for Isolated Networks .

Also as per Suresh , we can create a network offering for a shared network with 
Conserve Mode “On” using the API (CLOUDSTACK-2411)  which makes me think , if 
there has been any change in the code recently ?

Thanks,
Pranav


RE: Suport for Conserve Mode in a shared Network for Network Offering

2013-05-09 Thread Pranav Saxena
Thanks Murali . I'll make the changes accordingly and commit the fix now .

From: Murali Reddy
Sent: Thursday, May 09, 2013 4:43 PM
To: Pranav Saxena; dev@cloudstack.apache.org
Cc: Suresh Sadhu; Alena Prokharchyk
Subject: Re: Suport for Conserve Mode in a shared Network for Network Offering

Yes, conserve mode is supported for network offerings for shared networks. Its 
likely that original UI behaviour was to disable the check box, it did not make 
sense when shared networks just had DNS, DHCP services. Checkbox should be 
enabled when any of source NAT, static NAT, LB, FW services are selected. I 
might have missed this UI requirement when I added network services in shared 
network.

From: Pranav Saxena mailto:pranav.sax...@citrix.com>>
Date: Thursday, 9 May 2013 4:13 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Cc: Suresh Sadhu mailto:suresh.sa...@citrix.com>>, 
Murali Reddy mailto:murali.re...@citrix.com>>, Alena 
Prokharchyk mailto:alena.prokharc...@citrix.com>>
Subject: Suport for Conserve Mode in a shared Network for Network Offering

Hi ,

Could anyone confirm if  CloudStack supports enabling conserve mode while 
creating a Network Offering in a SHARED network . From what I know CloudStack 
used to support it only  for Isolated Networks .

Also as per Suresh , we can create a network offering for a shared network with 
Conserve Mode "On" using the API (CLOUDSTACK-2411)  which makes me think , if 
there has been any change in the code recently ?

Thanks,
Pranav


Re: Suggestion needed for CLOUDSTACK-212

2013-05-09 Thread Dharmesh Kakadia
I have finished the refactoring (ran into eclipse refactoring bugs). I am
now trying to test. But I realized that it will be good to have tool/script
that does most of this refactoring rather than using eclipse. Anyone knows
any such tool/script ? Otherwise I plan to make one.

Thanks,
Dharmesh


On Wed, May 8, 2013 at 9:08 PM, Dharmesh Kakadia wrote:

> I have started refactoring !! I am planning to finish refactoring by
> tomorrow. I will then need help and guidance in doing testing,branching
> etc. Let's try this out !!
>
> Thanks,
> Dharmesh
>
>
> On Wed, May 8, 2013 at 7:20 PM, Sebastien Goasguen wrote:
>
>>
>> On May 8, 2013, at 9:30 AM, Chip Childers 
>> wrote:
>>
>> > Dharmesh,
>> >
>> > I'd also suggest that you actually plan on submitting this after the 4.2
>> > feature freeze, to be included in 4.3.  This is the type of change that
>> > has bitten us with almost every release...  and doing it close to the
>> > end of the merge window may not be a good idea.  Our general preference
>> > is to do these types of changes in master right *after* the latest
>> > feature release has it's branch cut.
>> >
>> > -chip
>>
>> To add to that, feature freeze for 4.2 is scheduled to be 5/31.
>>
>> We could have your code in a feature branch before that, and merge it
>> early june. It would then be included in 4.3
>>
>>
>>
>> >
>> > On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
>> >> ok. I will go with that.
>> >>
>> >> Thanks,
>> >> Dharmesh
>> >>
>> >> On Wed, May 8, 2013 at 1:08 AM, Chip Childers <
>> chip.child...@sungard.com>wrote:
>> >>
>> >>> On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
>>  Hi,
>> 
>>  I am trying to move java package structure from com.cloud to
>> org.apache (
>>  https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am
>> thinking of
>>  doing it the following way (Totally newbie), needed feedback on that.
>> 
>>  1. grep "com.cloud" on the entire repo.
>>  2. update all package declarations using eclipse.
>>  3. Update scripts etc found in 1 manually.
>> 
>>  Will it be a good way to do it ? Any better suggestion ?
>> 
>>  Thanks,
>>  Dharmesh
>> >>>
>> >>> That seems like a reasonable approach.  We will probably want to
>> create
>> >>> a branch when you submit a patch for this, and apply it there...  just
>> >>> to spend some time ensuring that the changes work.
>> >>>
>> >>> -chip
>> >>>
>>
>>
>


Re: Fix for CLOUDSTACK-2277

2013-05-09 Thread Mice Xia
I agree with you, provide message to user for adding case

Regards
Mice


On Thu, May 9, 2013 at 6:41 PM, Saksham Srivastava <
saksham.srivast...@citrix.com> wrote:

> Mice, no need to revert. I also had similar issues that the NIC was
> present even after reboot.
> May be we need to look into the difference in behavior.
> But for now, I guess at-least the add api must be allowed to pass.
> Your thoughts?
>
> Thanks,
> Saksham
>
> On Thursday 09 May 2013 02:37 PM, Mice Xia wrote:
> > Saksham,
> >
> > Really sorry I didn’t notice it's in progress until I pushed the
> commit.. I can revert it if necessary.
> >
> > Yes, without vmtool, a reboot of the VM can bring up the added NIC, but
> removing NIC fails in my environment, the nic is still there even after a
> reboot, can you confirm it in your env?
> >
> > Regards
> > Mice
> >
> > -Original Message-
> > From: Saksham Srivastava [mailto:saksham.srivast...@citrix.com]
> > Sent: Thursday, May 09, 2013 4:37 PM
> > To: Mice Xia; dev@cloudstack.apache.org
> > Subject: Fix for CLOUDSTACK-2277
> >
> > Hi Mice ,
> >
> > I just saw your commit for
> > https://issues.apache.org/jira/browse/CLOUDSTACK-2277
> > So  I recently picked this bug, marked it  as "in progress" as I was
> working on it and was about to submit the patch for the same, but then I
> saw that you already fixed it :)
> >
> > A quick comment :
> > The fix makes sure that if vm-tools are not running on the vm,
> add/remove nic fails.
> > What I have observed is that if vm-tools are not running, a reboot of
> the vm will actually show up the added NIC. IMO we should allow the api to
> pass, but provide a log message that reboot of vm will be required for
> added NIC to show up, rather than completely failing the api.
> >
> > Your thoughts ?
> >
> > Thanks,
> > Saksham
>


Re: Review Request: ACL on private gateway feature

2013-05-09 Thread Jayapal Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10942/
---

(Updated May 9, 2013, 12:08 p.m.)


Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Murali 
Reddy.


Changes
---

Updated the diff


Description
---

ACL on private gateway feature.
ACLs are implemented with the container model


This addresses bug CLOUDSTACK-768.


Diffs (updated)
-

  api/src/com/cloud/network/NetworkService.java 5d4fd67 
  api/src/com/cloud/network/element/VpcProvider.java 81b1cf3 
  api/src/com/cloud/network/vpc/NetworkACLService.java 0258333 
  api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 
  api/src/com/cloud/network/vpc/VpcService.java 23e2764 
  
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java
 2055695 
  
api/src/org/apache/cloudstack/api/command/user/network/ReplaceNetworkACLListCmd.java
 b8abc78 
  api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java 
ca76062 
  core/src/com/cloud/agent/api/routing/NetworkElementCommand.java 41ae80f 
  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 
b9bda4d 
  engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 
  engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 600d67f 
  engine/schema/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java a1cd934 
  patches/systemvm/debian/config/opt/cloud/bin/vpc_privategw_acl.sh 
PRE-CREATION 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 8fe8c88 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 030eff0 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 bac361d 
  server/src/com/cloud/api/ApiResponseHelper.java 9548062 
  server/src/com/cloud/network/element/VpcVirtualRouterElement.java 8b0c58a 
  server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManager.java 
306b1a8 
  
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 
1d901d9 
  server/src/com/cloud/network/vpc/NetworkACLManager.java 0ff3e88 
  server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java 71d6da4 
  server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java 7c50d90 
  server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java 4af9278 
  server/test/com/cloud/vpc/MockVpcManagerImpl.java b4851d6 
  server/test/com/cloud/vpc/MockVpcVirtualNetworkApplianceManager.java cd1373c 
  server/test/com/cloud/vpc/NetworkACLManagerTest.java dc53b2b 
  server/test/org/apache/cloudstack/privategw/AclOnPrivateGwTest.java 
PRE-CREATION 
  setup/db/db/schema-410to420.sql 8a42812 
  test/integration/smoke/test_network_acl.py 300fff9 
  test/integration/smoke/test_privategw_acl.py PRE-CREATION 

Diff: https://reviews.apache.org/r/10942/diff/


Testing
---

1. Tested creation of private gateway with acl id
2. replacenetworkacl for privategateway id
3. add new acl item and checking the applying item on private gw
4. restart router and see the rules are added or not.


Thanks,

Jayapal Reddy



[QA][Test Plan][ACS4.2]Granular Global Configuration Parameters

2013-05-09 Thread Prashant Kumar Mishra
Hi,

I have prepared test cases for "Granular Global Configuration Parameters" 
feature, please review and give your valuable  comments .

Details

1-Test plan
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Granular+Global+Configuration+Parameters

2-FS
https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+for+Granular+Global+Configuration+Parameters

Thanks
Prashant kumar Mishra





Review Request: CLOUDSTACK-2419 : Localization - Some Japanese are not working

2013-05-09 Thread Sanjay Tripathi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11021/
---

Review request for cloudstack, Fang Wang and Animesh Chaturvedi.


Description
---

CLOUDSTACK-2419 : Localization - Some Japanese are not working

The following JP keys are not working:
• ~ ^
• [{
• ]}
• ' @
• ; +
• : *
• Numpad *
• Numpad +
• Numpad -
• Numpad /
• CAPS Lock
• Kanji Key 


This addresses bug CLOUDSTACK-2419.


Diffs
-

  services/console-proxy/server/js/ajaxkeys.js 1ed41c5 

Diff: https://reviews.apache.org/r/11021/diff/


Testing
---

Tested on my local CloudStack setup.


Thanks,

Sanjay Tripathi



RE: "_Enhancer" Question

2013-05-09 Thread Alex Huang
You should be able to do that yourself. 

Click Browse and select Pages
Click on the Tree link

From there you can move the pages.

--Alex

> -Original Message-
> From: Kelven Yang [mailto:kelven.y...@citrix.com]
> Sent: Wednesday, May 8, 2013 11:31 PM
> To: dev@cloudstack.apache.org
> Subject: Re: "_Enhancer" Question
> 
> Could someone help move the linked wiki page to root level in wiki?
> although the work is done in Javelin branch, it now applies to all future
> releases.
> 
> Kelven
> 
> On 5/8/13 11:14 PM, "Kelven Yang"  wrote:
> 
> >I've updated the wiki page for some background information on how we
> >end up current way of doing this.
> >
> >https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+Spring+i
> n+
> >Clo
> >u
> >dStack
> >
> >
> >Kelven
> >
> >On 5/8/13 9:37 PM, "Mike Tutkowski" 
> wrote:
> >
> >>Hi,
> >>
> >>I was wondering if someone could explain to me the "_Enhancer" pattern
> >>we are using in CloudStack (below) and how this kind of class is created.
> >>
> >>class
> >>org.apache.cloudstack.storage.allocator.ZoneWideStoragePoolAllocator_E
> >>nha
> >>n
> >>cerByCloudStack_4ff7ea3a
> >>
> >>Thanks!
> >>
> >>--
> >>*Mike Tutkowski*
> >>*Senior CloudStack Developer, SolidFire Inc.*
> >>e: mike.tutkow...@solidfire.com
> >>o: 303.746.7302
> >>Advancing the way the world uses the
> >>cloud
> >>**
> >



Re: Review Request: Fixed Volume which is added thru upload volume is failed to attach to the instance saying Volume state must be in Allocated, Ready or in Uploaded state( Though uploaded Volume stat

2013-05-09 Thread Rajesh Battala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11022/
---

(Updated May 9, 2013, 12:49 p.m.)


Review request for cloudstack, Devdeep Singh and edison su.


Description
---

When user uploads the volume, successful uploaded volume state in DB is still 
marked as "UploadOp"

This is issue with the VolumeServiceImpl, after uploaded operation is 
successful it should call the stateTransit  "UploadOp" to "Uploaded".
Issue is fixed by call the volume state change and now the volume is moved to 
"uploaded" state which will not throw the exception as the volume is not in 
ready state.


This addresses bug CLOUDSTACK-2081.


Diffs
-

  
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
 b39502b 

Diff: https://reviews.apache.org/r/11022/diff/


Testing
---

Unittests are running successful.

1. Uploaded the volume, verified the state column in db. during uploading 
progress its is "UploadOp" after upload is successful it is moved to "Uploaded"


Thanks,

Rajesh Battala



RE: [ACS41] Release Blocker Update for 2013-05-08

2013-05-09 Thread Kishan Kavala


> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Wednesday, 8 May 2013 10:48 PM
> To: dev@cloudstack.apache.org
> Cc: Kishan Kavala
> Subject: [ACS41] Release Blocker Update for 2013-05-08
> 
> Here's where we stand:
> 
> CLOUDSTACK-2309
>   Upgrade from 2.2.14 to 4.1.0 : network static routes deleted on SSVM
> 
>   Kishan - any update on 2309?  Also note that Wei suggested a fix to the
>   reporter for 528.  However, you said you thought 2309 and 528 could be
>   related.  Can you review the suggestion?
> 
Chip,
 I successfully upgraded from 2.2.14 to 4.1 . SSVM came up after stopping and 
starting. All the routes were also properly configured.
I'll work with Nicolas to see if all the upgrades steps were followed.

Routes won't be configured if SecStorageVMSetupCommand is not sent to SSVM.

~kishan




Re: Review Request: generalisation of network code (needed for CLOUDSTACK-1532)

2013-05-09 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10970/
---

(Updated May 9, 2013, 1:02 p.m.)


Review request for cloudstack.


Changes
---

new diff file with some ommisions added


Description
---

converting vlan id to uri to support a broader range of networks in for 
instance vpc gateway connections


Diffs (updated)
-

  api/src/com/cloud/agent/api/to/IpAddressTO.java 82c7d99 
  api/src/com/cloud/agent/api/to/NetworkTO.java 3edd4c0 
  api/src/com/cloud/network/NetworkService.java 5d4fd67 
  api/src/com/cloud/network/Networks.java f085e9f 
  api/src/com/cloud/network/vpc/PrivateIp.java eb68433 
  api/src/com/cloud/network/vpc/StaticRouteProfile.java 54aa6e4 
  api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 
  api/src/com/cloud/network/vpc/VpcService.java 23e2764 
  
api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java
 2055695 
  api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java 
ca76062 
  api/test/com/cloud/agent/api/to/NetworkTOTest.java PRE-CREATION 
  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 
b9bda4d 
  engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 
  
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java
 6d14e3f 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
 b897df2 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 8fe8c88 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 
37761aa 
  plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java 
a626e31 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 030eff0 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 bac361d 
  
plugins/network-elements/cisco-vnmc/test/com/cloud/network/element/CiscoVnmcElementTest.java
 a16733b 
  
plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java 
1733712 
  
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
 a0068c3 
  
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
 98e1461 
  
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java
 b1ecaac 
  server/src/com/cloud/api/ApiResponseHelper.java d7eaa26 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793 
  server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 4a90a77 
  server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 
686f5bc 
  server/src/com/cloud/network/ExternalLoadBalancerUsageManagerImpl.java 
d405382 
  server/src/com/cloud/network/NetworkManager.java 4af716c 
  server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1 
  server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92 
  server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java cf27986 
  server/src/com/cloud/network/guru/PrivateNetworkGuru.java 2e266e7 
  server/src/com/cloud/network/guru/PublicNetworkGuru.java a83cdb3 
  
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 
ebf2d42 
  server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db 
  server/src/com/cloud/network/vpc/PrivateIpAddress.java 2f3cf53 
  server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9 
  server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION 
  server/test/com/cloud/network/MockNetworkManagerImpl.java 2f717c8 
  server/test/com/cloud/vpc/MockNetworkManagerImpl.java f884ba1 
  server/test/com/cloud/vpc/MockVpcManagerImpl.java baccbd0 
  setup/db/db/schema-410to420.sql c8ac1ec 

Diff: https://reviews.apache.org/r/10970/diff/


Testing (updated)
---

the NetworkTO is tested to accept uris with several initial states.
createPrivateNetwork in NetworkServiceImpl is tested (to accpet only vlan based 
networks for now)


Thanks,

daan Hoogland



Review Request: CLOUDSTACK-658: Scaling up CPU and RAM for running VMs - Vmware

2013-05-09 Thread Harikrishna Patnala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11025/
---

Review request for cloudstack, Nitin Mehta and Sateesh Chodapuneedi.


Description
---

CLOUDSTACK-658: Scaling up CPU and RAM for running VMs - Vmware

Adding support to scale up the vms in case of Vmware.

Including unit tests.


This addresses bug CLOUDSTACK-658.


Diffs
-

  plugins/hypervisors/vmware/pom.xml d65ef64 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 030eff0 
  
plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java
 PRE-CREATION 
  server/src/com/cloud/vm/UserVmManagerImpl.java bc25bed 
  vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 9c467dc 

Diff: https://reviews.apache.org/r/11025/diff/


Testing
---

Tested locally by scaling the vm to an higher service offering.


Thanks,

Harikrishna Patnala



Review Request: CLOUDSTACK-702: Tests for Multiple IP Ranges

2013-05-09 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11026/
---

Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.


Description
---

CLOUDSTACK-702: Tests for Multiple IP Ranges
1. Add ip range super set to existing CIDR
2. Add ip range subset to existing CIDR


This addresses bug CLOUDSTACK-702.


Diffs
-

  test/integration/component/test_multiple_ip_ranges.py 7e9eeb1 

Diff: https://reviews.apache.org/r/11026/diff/


Testing
---

yes


Thanks,

sanjeev n



Re: Review Request: CLOUDSTACK-658: Scaling up CPU and RAM for running VMs - Vmware

2013-05-09 Thread Nitin Mehta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11025/#review20378
---

Ship it!


Ship It!

- Nitin Mehta


On May 9, 2013, 1:22 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11025/
> ---
> 
> (Updated May 9, 2013, 1:22 p.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Sateesh Chodapuneedi.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-658: Scaling up CPU and RAM for running VMs - Vmware
> 
> Adding support to scale up the vms in case of Vmware.
> 
> Including unit tests.
> 
> 
> This addresses bug CLOUDSTACK-658.
> 
> 
> Diffs
> -
> 
>   plugins/hypervisors/vmware/pom.xml d65ef64 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  030eff0 
>   
> plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java
>  PRE-CREATION 
>   server/src/com/cloud/vm/UserVmManagerImpl.java bc25bed 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 9c467dc 
> 
> Diff: https://reviews.apache.org/r/11025/diff/
> 
> 
> Testing
> ---
> 
> Tested locally by scaling the vm to an higher service offering.
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: [ACS41] Release Blocker Update for 2013-05-08

2013-05-09 Thread Chip Childers
Thanks.

On May 9, 2013, at 8:54 AM, Kishan Kavala  wrote:

>
>
>> -Original Message-
>> From: Chip Childers [mailto:chip.child...@sungard.com]
>> Sent: Wednesday, 8 May 2013 10:48 PM
>> To: dev@cloudstack.apache.org
>> Cc: Kishan Kavala
>> Subject: [ACS41] Release Blocker Update for 2013-05-08
>>
>> Here's where we stand:
>>
>> CLOUDSTACK-2309
>>  Upgrade from 2.2.14 to 4.1.0 : network static routes deleted on SSVM
>>
>>  Kishan - any update on 2309?  Also note that Wei suggested a fix to the
>>  reporter for 528.  However, you said you thought 2309 and 528 could be
>>  related.  Can you review the suggestion?
> Chip,
> I successfully upgraded from 2.2.14 to 4.1 . SSVM came up after stopping and 
> starting. All the routes were also properly configured.
> I'll work with Nicolas to see if all the upgrades steps were followed.
>
> Routes won't be configured if SecStorageVMSetupCommand is not sent to SSVM.
>
> ~kishan
>
>
>


Re: "_Enhancer" Question

2013-05-09 Thread Kelven Yang
Thanks for the tip, done.

Kelven

On 5/9/13 5:31 AM, "Alex Huang"  wrote:

>You should be able to do that yourself.
>
>Click Browse and select Pages
>Click on the Tree link
>
>From there you can move the pages.
>
>--Alex
>
>> -Original Message-
>> From: Kelven Yang [mailto:kelven.y...@citrix.com]
>> Sent: Wednesday, May 8, 2013 11:31 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: "_Enhancer" Question
>> 
>> Could someone help move the linked wiki page to root level in wiki?
>> although the work is done in Javelin branch, it now applies to all
>>future
>> releases.
>> 
>> Kelven
>> 
>> On 5/8/13 11:14 PM, "Kelven Yang"  wrote:
>> 
>> >I've updated the wiki page for some background information on how we
>> >end up current way of doing this.
>> >
>> >https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+Spring+i
>> n+
>> >Clo
>> >u
>> >dStack
>> >
>> >
>> >Kelven
>> >
>> >On 5/8/13 9:37 PM, "Mike Tutkowski" 
>> wrote:
>> >
>> >>Hi,
>> >>
>> >>I was wondering if someone could explain to me the "_Enhancer" pattern
>> >>we are using in CloudStack (below) and how this kind of class is
>>created.
>> >>
>> >>class
>> >>org.apache.cloudstack.storage.allocator.ZoneWideStoragePoolAllocator_E
>> >>nha
>> >>n
>> >>cerByCloudStack_4ff7ea3a
>> >>
>> >>Thanks!
>> >>
>> >>--
>> >>*Mike Tutkowski*
>> >>*Senior CloudStack Developer, SolidFire Inc.*
>> >>e: mike.tutkow...@solidfire.com
>> >>o: 303.746.7302
>> >>Advancing the way the world uses the
>> >>cloud
>> >>**
>> >
>



Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-09 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11027/
---

Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Description
---

Cloudstack-702. Multiple ip ranges in different subnets. 

This feature enables adding of guest ip ranges (public ips)  form different 
subnets.

In order to provide the dhcp service to a different subnet we create an ipalias 
on the router. This allows the router to listen to the dhcp request from the 
guest vms and respond accordingly. Every time a vm is deployed in the new 
subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to 
provide dhcp service. We need to configure the dnsmasq to issue ips on the new 
subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq 
confg file, this file replaces the old config in the router. 

The details of the alias ips are stored in db in the nic_ip_alias table. Every 
time a new subnet is added one of the ip from the subnet is used to configure 
the ip alias. 

I have pushed the code to  
https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the 
code with master. 
I need to test the code for advanced sg enabled network using kvm.

This is duplicate of the pervious review request 
https://reviews.apache.org/r/10948/. please ignore it. 

I have added the unit test

Also accomodated some of the changes suggested by koushik. 
corrected the import statements. renamed the IpAlias command to createIpAlias 
command. 


This addresses bug Cloudstack-702.


Diffs
-

  api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION 
  api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION 
  api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c 
  api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION 
  client/tomcatconf/applicationContext.xml.in 36f232c 
  core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION 
  core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java PRE-CREATION 
  core/src/com/cloud/agent/api/routing/IpAliasTO.java PRE-CREATION 
  core/src/com/cloud/agent/api/routing/createIpAliasCommand.java PRE-CREATION 
  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 
b9bda4d 
  core/src/com/cloud/network/DnsMasqConfigurator.java PRE-CREATION 
  engine/schema/src/com/cloud/dc/dao/VlanDao.java cc82632 
  engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java 100295b 
  engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3d588fa 
  engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 73f310f 
  engine/schema/src/com/cloud/vm/dao/NicDao.java 67c1e07 
  engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java c70d194 
  patches/systemvm/debian/config/root/createIpAlias.sh PRE-CREATION 
  patches/systemvm/debian/config/root/deleteIpAlias.sh PRE-CREATION 
  patches/systemvm/debian/config/root/dnsmasq.sh PRE-CREATION 
  
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java
 b72d1c8 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 d87da64 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 bac361d 
  
plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java
 804e4a6 
  scripts/vm/hypervisor/xenserver/createipAlias.sh PRE-CREATION 
  scripts/vm/hypervisor/xenserver/deleteipAlias.sh PRE-CREATION 
  scripts/vm/hypervisor/xenserver/vmops 30b5300 
  scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb 
  scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d 
  scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f 
  scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 
  server/src/com/cloud/configuration/ConfigurationManager.java bce1776 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793 
  server/src/com/cloud/network/NetworkManager.java 4af716c 
  server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1 
  server/src/com/cloud/network/addr/PublicIp.java 25e9d30 
  server/src/com/cloud/network/element/VirtualRouterElement.java f601f4f 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 
f49ab79 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
6620e0a 
  server/src/com/cloud/vm/dao/NicIpAliasDao.java PRE-CREATION 
  server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java PRE-CREATION 
  server/src/com/cloud/vm/dao/NicIpAliasVO.java PRE-CREATION 
  server/test/com/cloud/configuration/ValidateIpRangeTest.java PRE-CREATION 
  server/test/com/cloud/network/MockNetworkManagerImpl.java 2f717c8 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 83b1924 
  server/test/com/cloud/vpc/MockNetworkManagerImpl.java f884ba1 
  server/test/com/cloud/vpc/MockVpcVirtualNetworkApplianceManage

Re: [ACS41] Release Blocker Update for 2013-05-08

2013-05-09 Thread Sebastien Goasguen

On May 9, 2013, at 8:54 AM, Kishan Kavala  wrote:

> 
> 
>> -Original Message-
>> From: Chip Childers [mailto:chip.child...@sungard.com]
>> Sent: Wednesday, 8 May 2013 10:48 PM
>> To: dev@cloudstack.apache.org
>> Cc: Kishan Kavala
>> Subject: [ACS41] Release Blocker Update for 2013-05-08
>> 
>> Here's where we stand:
>> 
>> CLOUDSTACK-2309
>>  Upgrade from 2.2.14 to 4.1.0 : network static routes deleted on SSVM
>> 
>>  Kishan - any update on 2309?  Also note that Wei suggested a fix to the
>>  reporter for 528.  However, you said you thought 2309 and 528 could be
>>  related.  Can you review the suggestion?
>> 
> Chip,
> I successfully upgraded from 2.2.14 to 4.1 . SSVM came up after stopping and 
> starting. All the routes were also properly configured.
> I'll work with Nicolas to see if all the upgrades steps were followed.
> 
> Routes won't be configured if SecStorageVMSetupCommand is not sent to SSVM.
> 
> ~kishan
> 

Kishan, which hypervisor and OS did you use 

thanks

-sebastien

> 



[GSOC] Student interviews

2013-05-09 Thread Sebastien Goasguen
Hi,

I would like to schedule phone/skype interviews with all the students who 
submitted proposals.
(This is authorized and recommended by ASF gsoc guidelines)

Please get in touch with me on IRC or direct email to set a meeting time.

Once the times are set I will send it to the list and welcome anyone who wants 
to participate in the call.

Cheers,

-Sebastien

Re: [MERGE] CLOUDSTACK-747 "nTier Apps 2.0 : Internal Load Balancing between the VPC tiers"

2013-05-09 Thread Alena Prokharchyk
If nobody objects, I'm going to merge code from interanllb branch into
master branch today, May 9th.

-Alena.

On 5/8/13 4:46 PM, "Chip Childers"  wrote:

>On Mon, May 06, 2013 at 10:33:51AM -0700, Alena Prokharchyk wrote:
>> Hi all,
>> 
>> I would like to merge the Internal LB feature from  asf/internallb
>>branch
>> to master.
>> 
>> - link to FS: 
>> 
>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Internal+Load+Bala
>>nc
>> ing+between+VPC+tiers
>> - Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-747
>> - UnitTests: the tests are added to
>> 
>> cloud-plugin-network-internallb/test (Internal LB element management):
>> 
>> * InternalLbElementServiceTest.java
>> * InternalLbElementTest.java
>> * InternalLBVMManagerTest.java
>> * InternalLBVMServiceTest.java
>> 
>> and cloud-server/test/lb (Internal LB rules management):
>> 
>> * ApplicationLoadBalancerTest.java
>> 
>> 
>> - Integration tests: python test is
>> test/integration/smoke/test_internal_lb.py
>> - As various people were working on the branch, so I did do daily merges
>> (not rebase) with the master branch, and internal lb commits are spread
>> over time. To fetch all the internal LB commits, execute this command:
>> 
>>  git log internallb ^master --no-merges
>> 
>> After the approval, the merge to master will be done as one squashed
>> commit.
>> 
>> - there is no UI for the feature yet; it will be developed in another
>> branch and merged to master branch separately.
>> - Attached is the RAT report that resulted in "0 Unknown Licenses"
>> 
>> 
>> 
>> Thank you,
>> -Alena.
>>
>
>+1 from me
>




RE: [ACS42] Schedule Remember - Feature freeze on 2013-05-31

2013-05-09 Thread Animesh Chaturvedi

> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Wednesday, May 08, 2013 10:55 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [ACS42] Schedule Remember - Feature freeze on 2013-05-31
> 
> Hi Animesh,
> 
> I have a quick question for you.
> 
> As you know, I'm in the process of developing a storage plug-in for 4.2.
> 
> I'm working with Edison on getting some issues out of the storage framework
> as well as completing the implementation of the plug-in.
> 
> Can you tell me how I should handle our situation in that we will likely be
> close, but not quite there yet, as of May 31st?
> 
> Can we check in what we have (as long as we don't break functionality that
> we're aware of) and then deal with remaining issues after?
> 
> Not sure exactly how the process works here.
> 
> Thanks!
> 
> 
[Animesh>] Mike as community we agreed to be on time based release and as such 
it means feature should be complete  with test and need to be in master by 5/31 
 to be included for 4.2. Would you have a logical chunk of working feature 
available by 5/31?



Re: [ACS42] Schedule Remember - Feature freeze on 2013-05-31

2013-05-09 Thread Mike Tutkowski
Yes...I believe I will have it working for XenServer by that time with
VMware and KVM to follow shortly thereafter.

It depends a bit on how many storage-framework issues I come across. For
example, last night I ran into code that assumed zone-wide storage was only
for KVM (at one time in development this was probably true).

I've also got a question pending to Edison about the grantAccess and
revokeAccess methods...if they will be utilized by the framework for 4.2.
Based on the answer, it will likely influence my work.


On Thu, May 9, 2013 at 11:30 AM, Animesh Chaturvedi <
animesh.chaturv...@citrix.com> wrote:

>
> > -Original Message-
> > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> > Sent: Wednesday, May 08, 2013 10:55 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [ACS42] Schedule Remember - Feature freeze on 2013-05-31
> >
> > Hi Animesh,
> >
> > I have a quick question for you.
> >
> > As you know, I'm in the process of developing a storage plug-in for 4.2.
> >
> > I'm working with Edison on getting some issues out of the storage
> framework
> > as well as completing the implementation of the plug-in.
> >
> > Can you tell me how I should handle our situation in that we will likely
> be
> > close, but not quite there yet, as of May 31st?
> >
> > Can we check in what we have (as long as we don't break functionality
> that
> > we're aware of) and then deal with remaining issues after?
> >
> > Not sure exactly how the process works here.
> >
> > Thanks!
> >
> >
> [Animesh>] Mike as community we agreed to be on time based release and as
> such it means feature should be complete  with test and need to be in
> master by 5/31  to be included for 4.2. Would you have a logical chunk of
> working feature available by 5/31?
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*


RE: [ACS42] Schedule Remember - Feature freeze on 2013-05-31

2013-05-09 Thread Animesh Chaturvedi


> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Thursday, May 09, 2013 10:39 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [ACS42] Schedule Remember - Feature freeze on 2013-05-31
> 
> Yes...I believe I will have it working for XenServer by that time with VMware
> and KVM to follow shortly thereafter.
> 
> It depends a bit on how many storage-framework issues I come across. For
> example, last night I ran into code that assumed zone-wide storage was only
> for KVM (at one time in development this was probably true).
> 
> I've also got a question pending to Edison about the grantAccess and
> revokeAccess methods...if they will be utilized by the framework for 4.2.
> Based on the answer, it will likely influence my work.
> 
> 
[Animesh>]  Edison when you get a chance can you respond to Mike's query


> On Thu, May 9, 2013 at 11:30 AM, Animesh Chaturvedi <
> animesh.chaturv...@citrix.com> wrote:
> 
> >
> > > -Original Message-
> > > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> > > Sent: Wednesday, May 08, 2013 10:55 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: [ACS42] Schedule Remember - Feature freeze on
> > > 2013-05-31
> > >
> > > Hi Animesh,
> > >
> > > I have a quick question for you.
> > >
> > > As you know, I'm in the process of developing a storage plug-in for 4.2.
> > >
> > > I'm working with Edison on getting some issues out of the storage
> > framework
> > > as well as completing the implementation of the plug-in.
> > >
> > > Can you tell me how I should handle our situation in that we will
> > > likely
> > be
> > > close, but not quite there yet, as of May 31st?
> > >
> > > Can we check in what we have (as long as we don't break
> > > functionality
> > that
> > > we're aware of) and then deal with remaining issues after?
> > >
> > > Not sure exactly how the process works here.
> > >
> > > Thanks!
> > >
> > >
> > [Animesh>] Mike as community we agreed to be on time based release
> and
> > as such it means feature should be complete  with test and need to be
> > in master by 5/31  to be included for 4.2. Would you have a logical
> > chunk of working feature available by 5/31?
> >
> >
> 
> 
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*


Re: Review Request: PVLAN provisioning support for vmware Distributed Virtual Switch deployments on cloudstack.

2013-05-09 Thread Venkata Siva Vijayendra Bhamidipati

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11019/
---

(Updated May 9, 2013, 5:47 p.m.)


Review request for cloudstack, Chip Childers, Sateesh Chodapuneedi, Kelven 
Yang, and Animesh Chaturvedi.


Changes
---

+Animesh to list of reviewers.


Description
---

Please find attached the diffs for pvlan support for vmware DVSwitch 
deployments on cloudstack. You will find two diffs - the parent diff is 
Sateesh's fix for CLOUSTACK-2316 which is needed to be cherry-picked on the 
pvlan branch from the master. The other diff contains the changes for pvlan 
support.

These diffs do not contain changes for pvlan provisioning on the Cisco Nexus 
1000v distributed virtual switch.


This addresses bug CLOUDSTACK-1456.


Diffs
-

  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 99ad1ca 
  server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 
  server/src/com/cloud/network/NetworkModelImpl.java bd62886 
  server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 
  
vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java 
247be2a 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
7f323c5 

Diff: https://reviews.apache.org/r/11019/diff/


Testing
---

The code has been tested on the Vmware DVSwitch for advanced shared networks on 
vmware cluster deployments on cloudstack. Unit tests will be the same as those 
provided by Sheng as part of the overall PVLAN support for XenServer and KVM, 
and will exercise the vmware pvlan code path when user VMs are created with 
vNICs sitting on advanced shared networks that have the optional Private VLAN 
value set during their creation. VM live migration using vmware vMotion has 
also been tested with these changes on vmware and it works as expected.

Further testing will be carried out and this review request will be updated 
accordingly.


Thanks,

Venkata Siva Vijayendra Bhamidipati



Re: Review Request: CLOUDSTACK-869-nTier-Apps-2.0_Support-NetScalar-as-external-LB-provider

2013-05-09 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10858/#review20382
---


Commit 2e2106002865cff8eb06b5c3a42bfd6f0f6848fb in branch refs/heads/internallb 
from Murali Reddy 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2e21060 ]

CLOUDSTACK-869 nTier Apps 2.0 : Support NetScalar as external LB provider


- ASF Subversion and Git Services


On May 8, 2013, 1:39 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10858/
> ---
> 
> (Updated May 8, 2013, 1:39 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala, Murali Reddy, Alena 
> Prokharchyk, Vijay Venkatachalam, and Ram Ganesh.
> 
> 
> Description
> ---
> 
> This feature will introduce Netscaler as external LB provider in VPC.
> As of now only 1 tier is support for external LB.
> A new VPC offering will be created "Default VPC Offering with NS" with all 
> the services provided by VPCVR and LB service with NetScaler.
> Existing NetscalerElement is used and implements VpcProvider.
> In VpcManager, Netscaler is added as one of the supported providers.
> Netscaler will be dedicated to the vpc.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/vpc/VpcOffering.java 3961d0a 
>   
> plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
>  7bd9c2e 
>   server/pom.xml 808dd3e 
>   server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92 
>   server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java b1606db 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9 
>   server/test/com/cloud/vpc/VpcTest.java PRE-CREATION 
>   
> server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java
>  cbb6c00 
> 
> Diff: https://reviews.apache.org/r/10858/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing:
> ==
> 1. Creation of Vpc with the default offering with NS is created successfully. 
> ( Enable Netscaler provider in network service providers)
> 2. Deletion of Vpc with the default offering with NS is deleted successfully.
> 3. Creation of new Vpc Network Offering with Netscaler as LB provider with 
> dedicated mode is created successfully.
> 4. Creation of new Vpc Network Offering with Netscaler as LB provider with 
> shared mode should throw exception.
> 5. Creation of tier (webtier) with the created Vpcnetscaler offering is 
> created successfully.
> 6. Verified Only one tier with netscaler as LB provider can be created. 
> 7. Verified deploying Instance in the tier is successful.
> 8. Verified a new nic got created with gateway ip from the tier cidr.
> 9. Verified deployed instance should get the ip from the specified tier cidr 
> range.
> 10. Acquire public ip in the vpc.
> 11. Verified creation on LB rule, is selecting only free dedicated Netscaler 
> device and necessary configuration is created and LB rule is created on NS
> 12. Deletion of LB rule is successful.
> 13. Modification of LB rule is successful
> 14. Creation of LB Health Check of TCP type is successful.
> 15. Deletion of LB Health Check of TCP type is successful.
> 16. Creation of LB Health Check of HTTP type is successful.
> 17. Deletion of LB Health Check of HTTP type is successful.
> 18. IpAssoc command is executed successful on Netscaler.
> 19. Deletion of tier will delete the tier and config on netscaler is cleared
> 20. Deletion of tier will mark the netscaler to be in free mode.
> 
> 
> Unit Test:
> ===
> Created VpcManger tests and added few tests to createNetworkOfferingTest
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>



[REMINDER] The CloudStack Conference CFP Deadline is Approaching! Submit Talks by Sunday

2013-05-09 Thread Joe Brockmeier
Are you using, supporting, or helping develop Apache CloudStack? Doing
interesting work around Apache CloudStack? If so, you should be
speaking at the second [1]CloudStack Collaboration Conference this June
in Santa Clara. 

## TL;DR

The deadline for submissions is Sunday, May 12th. You can submit talks
at [2]http://www.cloudstackcollab.com/CfP/. Ask questions to
market...@cloudstack.apache.org or plann...@cloudstackcollab.org. 

The Collaboration Conference will feature tracks for users, developers,
and integrators of Apache CloudStack. We're looking for presentations
that provide insight into best practices in deploying and developing
Apache CloudStack. This includes supporting technologies like
configuration management tools, monitoring solutions, and more.

This will be an outstanding opportunity for developers to collaborate,
exchange ideas, and get work done face-to-face with other Apache
CloudStack contributors to improve Apache CloudStack.

## Proposals

The program committee will be looking for presentations and workshops
related to working with and developing Apache CloudStack. This includes
everything from running CloudStack at scale, best practices for working
with IaaS clouds, discussions about CloudStack's architecture,
proposals for feature development, and more. We're also open to talks
that go hand-in-hand with managing Apache CloudStack, like
configuration management and monitoring tools.

In short, if it's relevant to Apache CloudStack development,
deployment, and integration, we're interested in what you might have to
say. For an example of what we're looking for, check out some of the
[3]videos from last year's event.

To submit your talk, just go to [4]http://www.cloudstackcollab.com/CfP/
and follow the steps there.

## Timeline and Deadlines

There's no time like the present to submit a proposal. We recommend
getting your proposal in early, and feel free to ask questions about
talk ideas on market...@cloudstack.apache.org if you want tips for
success! You can reach the CfP committee at
plann...@cloudstackcollab.org.

Dates for proposals are as follows:
  * Call for Proposals closes on May 12th.
  * Notifications will go out on May 17th.
  * Confirmations will be due by May 22nd.

## Travel Sponsorships

Not sure if you can afford the airfare and lodging to attend the
Collaboration Conference? Please don't let that stop you from
submitting your best proposal. We may be making a number of travel
sponsorships available for speakers who have useful information to
share with the Apache CloudStack community.

## Code of Conduct

The Apache CloudStack community is open to everyone. As such, we are
committed to providing a friendly, safe, and welcoming environment for
all - regardless of gender, sexual orientation, disability, ethnicity,
or religion. We respect and encourage diversity at our conference.

By agreeing to present at the conference, you are agreeing to abide by
the code of conduct. We expect all speakers and attendees to have read
and understood the code of conduct, and that all presentations will
meet this standard.

## Questions?

If you have questions or concerns, please don't hesitate to reach out
to the conference planning committee by sending an email to
plann...@cloudstackcollab.org.

## References

1. http://www.cloudstackcollab.com/
2. http://www.cloudstackcollab.com/CfP/
3. http://is.gd/CCC12vids
4. http://www.cloudstackcollab.com/CfP/

Best,

jzb
-- 
Joe Brockmeier
j...@zonker.net
Twitter: @jzb
http://www.dissociatedpress.net/


Re: Review Request: CLOUDSTACK-869-nTier-Apps-2.0_Support-NetScalar-as-external-LB-provider

2013-05-09 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10858/#review20385
---


Commit 2e2106002865cff8eb06b5c3a42bfd6f0f6848fb in branch 
refs/heads/ui-cisco-asa1000v-support from Murali Reddy 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2e21060 ]

CLOUDSTACK-869 nTier Apps 2.0 : Support NetScalar as external LB provider


- ASF Subversion and Git Services


On May 8, 2013, 1:39 p.m., Rajesh Battala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10858/
> ---
> 
> (Updated May 8, 2013, 1:39 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala, Murali Reddy, Alena 
> Prokharchyk, Vijay Venkatachalam, and Ram Ganesh.
> 
> 
> Description
> ---
> 
> This feature will introduce Netscaler as external LB provider in VPC.
> As of now only 1 tier is support for external LB.
> A new VPC offering will be created "Default VPC Offering with NS" with all 
> the services provided by VPCVR and LB service with NetScaler.
> Existing NetscalerElement is used and implements VpcProvider.
> In VpcManager, Netscaler is added as one of the supported providers.
> Netscaler will be dedicated to the vpc.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/vpc/VpcOffering.java 3961d0a 
>   
> plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
>  7bd9c2e 
>   server/pom.xml 808dd3e 
>   server/src/com/cloud/network/NetworkServiceImpl.java 5e8be92 
>   server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java b1606db 
>   server/src/com/cloud/network/vpc/VpcManagerImpl.java a7f06e9 
>   server/test/com/cloud/vpc/VpcTest.java PRE-CREATION 
>   
> server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java
>  cbb6c00 
> 
> Diff: https://reviews.apache.org/r/10858/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing:
> ==
> 1. Creation of Vpc with the default offering with NS is created successfully. 
> ( Enable Netscaler provider in network service providers)
> 2. Deletion of Vpc with the default offering with NS is deleted successfully.
> 3. Creation of new Vpc Network Offering with Netscaler as LB provider with 
> dedicated mode is created successfully.
> 4. Creation of new Vpc Network Offering with Netscaler as LB provider with 
> shared mode should throw exception.
> 5. Creation of tier (webtier) with the created Vpcnetscaler offering is 
> created successfully.
> 6. Verified Only one tier with netscaler as LB provider can be created. 
> 7. Verified deploying Instance in the tier is successful.
> 8. Verified a new nic got created with gateway ip from the tier cidr.
> 9. Verified deployed instance should get the ip from the specified tier cidr 
> range.
> 10. Acquire public ip in the vpc.
> 11. Verified creation on LB rule, is selecting only free dedicated Netscaler 
> device and necessary configuration is created and LB rule is created on NS
> 12. Deletion of LB rule is successful.
> 13. Modification of LB rule is successful
> 14. Creation of LB Health Check of TCP type is successful.
> 15. Deletion of LB Health Check of TCP type is successful.
> 16. Creation of LB Health Check of HTTP type is successful.
> 17. Deletion of LB Health Check of HTTP type is successful.
> 18. IpAssoc command is executed successful on Netscaler.
> 19. Deletion of tier will delete the tier and config on netscaler is cleared
> 20. Deletion of tier will mark the netscaler to be in free mode.
> 
> 
> Unit Test:
> ===
> Created VpcManger tests and added few tests to createNetworkOfferingTest
> 
> 
> Thanks,
> 
> Rajesh Battala
> 
>



Re: [MERGE] PVLAN branch to MASTER

2013-05-09 Thread Sheng Yang
On Wed, May 8, 2013 at 4:32 PM, Chip Childers wrote:

> On Wed, May 08, 2013 at 04:25:31PM -0700, Sheng Yang wrote:
> > FS at:
> >
> https://cwiki.apache.org/CLOUDSTACK/pvlan-for-isolation-within-a-vlan.html
> >
> > PVLAN branch has been under development for some time, and now the
> > functionality works on KVM and Xen, would be followed by VMware soon
> >
> > VM live migration is not supported so far, I am waiting for the fix of
> > https://issues.apache.org/jira/browse/CLOUDSTACK-1638 .
> >
> > We're using ovs/open flow to manipulate ingress/egress traffic to emulate
> > the isolation PVLAN function on KVM and Xen. The details are in the FS.
> >
> > The core code change is minimal and there is no DB change, because we
> took
> > advantage of "broadcast domain" to introduce "pvlan://" broadcast URI to
> > describe the primary and isolated PVLAN for the network.
> >
> > If there is no objection, I would merge the branch in 48 hours.
> >
> > Thanks.
> >
> > --Sheng
>
> Hey Sheng,
>
> Recently, merge requests have included things like:
>
> * Did you check the branch's RAT execution success?
>

Would check that.


> * Are there new dependencies introduced?
>

No.


> * What automated testing (unit and integration) is included in the new
> feature?

* What testing has been done to check for potential regressions?
>

Still working on testing part. Guess I would need to get it done before
another merge request.


>
> Some of these might be easily answered, but they're what we've agreed
> are the key elements of a feature merge request.
>

Thanks.

--Sheng

>
> -chip
>


Re: Review Request: CLOUDSTACK-2419 : Localization - Some Japanese are not working

2013-05-09 Thread Fang Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11021/#review20386
---

Ship it!


ship it! looks good

- Fang Wang


On May 9, 2013, 12:29 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11021/
> ---
> 
> (Updated May 9, 2013, 12:29 p.m.)
> 
> 
> Review request for cloudstack, Fang Wang and Animesh Chaturvedi.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2419 : Localization - Some Japanese are not working
> 
> The following JP keys are not working:
> • ~ ^
> • [{
> • ]}
> • ' @
> • ; +
> • : *
> • Numpad *
> • Numpad +
> • Numpad -
> • Numpad /
> • CAPS Lock
> • Kanji Key 
> 
> 
> This addresses bug CLOUDSTACK-2419.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/js/ajaxkeys.js 1ed41c5 
> 
> Diff: https://reviews.apache.org/r/11021/diff/
> 
> 
> Testing
> ---
> 
> Tested on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>



RE: NetApp Storage Integration

2013-05-09 Thread Kelcey Jamison Damage
Hi,

Do we have anyone working on storage integration with NetApp? I just got out of 
a non-nda meeting with them where they told me they are integrating both Swift 
and PNFS. Considering they are the primary curators of the NFS kernel, I'm 
hoping we might have at least 1 dev interested in maybe working with them?

They are also helping me design a 'Flex-Pod' for CloudStack which could have 
some cool implications for system integrators and builders.

Let's discuss.


Re: [GSOC] Student interviews

2013-05-09 Thread ADAMA COULIBALY
Hi Sebastien,

My phone number is (1) 267-243-3954
The best time to call me : 10:00 am to 12:00
2:pm   to 5: pm
any day after this Wednesday 15th May, ( From Monday to Wednesday I will be
busy with my final)
So let know the day and time then I will be ready for your phone call.

Best Regards,

Adama


On Thu, May 9, 2013 at 12:33 PM, Sebastien Goasguen wrote:

> Hi,
>
> I would like to schedule phone/skype interviews with all the students who
> submitted proposals.
> (This is authorized and recommended by ASF gsoc guidelines)
>
> Please get in touch with me on IRC or direct email to set a meeting time.
>
> Once the times are set I will send it to the list and welcome anyone who
> wants to participate in the call.
>
> Cheers,
>
> -Sebastien


Re: Review Request: PVLAN provisioning support for vmware Distributed Virtual Switch deployments on cloudstack.

2013-05-09 Thread Sheng Yang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11019/#review20387
---



server/src/com/cloud/network/NetworkModelImpl.java


What's this for?



server/src/com/cloud/vm/UserVmManagerImpl.java


Can VMware just ignore the command? Rather than put hypervisor specific 
code here.



server/src/com/cloud/vm/VirtualMachineManagerImpl.java


What's the change in this file for? Not used anywhere.



vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java


I am confused by pvlanid existed with vlanid here. Do you mean "isolated 
pvlan"(which is secondary vlan)? 



vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java


better using e.g. secondary vlan id. pvlanid is confusing.



vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java


Reason to remove type converting?


- Sheng Yang


On May 9, 2013, 5:47 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11019/
> ---
> 
> (Updated May 9, 2013, 5:47 p.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Sateesh Chodapuneedi, Kelven 
> Yang, and Animesh Chaturvedi.
> 
> 
> Description
> ---
> 
> Please find attached the diffs for pvlan support for vmware DVSwitch 
> deployments on cloudstack. You will find two diffs - the parent diff is 
> Sateesh's fix for CLOUSTACK-2316 which is needed to be cherry-picked on the 
> pvlan branch from the master. The other diff contains the changes for pvlan 
> support.
> 
> These diffs do not contain changes for pvlan provisioning on the Cisco Nexus 
> 1000v distributed virtual switch.
> 
> 
> This addresses bug CLOUDSTACK-1456.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  99ad1ca 
>   server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 
>   server/src/com/cloud/network/NetworkModelImpl.java bd62886 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 
>   
> vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java
>  247be2a 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
> 7f323c5 
> 
> Diff: https://reviews.apache.org/r/11019/diff/
> 
> 
> Testing
> ---
> 
> The code has been tested on the Vmware DVSwitch for advanced shared networks 
> on vmware cluster deployments on cloudstack. Unit tests will be the same as 
> those provided by Sheng as part of the overall PVLAN support for XenServer 
> and KVM, and will exercise the vmware pvlan code path when user VMs are 
> created with vNICs sitting on advanced shared networks that have the optional 
> Private VLAN value set during their creation. VM live migration using vmware 
> vMotion has also been tested with these changes on vmware and it works as 
> expected.
> 
> Further testing will be carried out and this review request will be updated 
> accordingly.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>



Re: Review Request: PVLAN provisioning support for vmware Distributed Virtual Switch deployments on cloudstack.

2013-05-09 Thread Venkata Siva Vijayendra Bhamidipati

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11019/
---

(Updated May 9, 2013, 7:09 p.m.)


Review request for cloudstack, Chip Childers, Sheng Yang, Sateesh Chodapuneedi, 
Kelven Yang, and Animesh Chaturvedi.


Changes
---

+Sheng


Description
---

Please find attached the diffs for pvlan support for vmware DVSwitch 
deployments on cloudstack. You will find two diffs - the parent diff is 
Sateesh's fix for CLOUSTACK-2316 which is needed to be cherry-picked on the 
pvlan branch from the master. The other diff contains the changes for pvlan 
support.

These diffs do not contain changes for pvlan provisioning on the Cisco Nexus 
1000v distributed virtual switch.


This addresses bug CLOUDSTACK-1456.


Diffs
-

  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 99ad1ca 
  server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 
  server/src/com/cloud/network/NetworkModelImpl.java bd62886 
  server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 
  
vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java 
247be2a 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
7f323c5 

Diff: https://reviews.apache.org/r/11019/diff/


Testing
---

The code has been tested on the Vmware DVSwitch for advanced shared networks on 
vmware cluster deployments on cloudstack. Unit tests will be the same as those 
provided by Sheng as part of the overall PVLAN support for XenServer and KVM, 
and will exercise the vmware pvlan code path when user VMs are created with 
vNICs sitting on advanced shared networks that have the optional Private VLAN 
value set during their creation. VM live migration using vmware vMotion has 
also been tested with these changes on vmware and it works as expected.

Further testing will be carried out and this review request will be updated 
accordingly.


Thanks,

Venkata Siva Vijayendra Bhamidipati



Cloud Stack compile error

2013-05-09 Thread MEHDI ALI SOLTANI
Hi Dears Developers
I want to build cloud stack according to 
https://cwiki.apache.org/CLOUDSTACK/how-to-build-on-master-branch.html .
I downloaded cloud stack from 
git clone https://git-wip-us.apache.org/repos/asf/cloudstack.git
and I thick that is a latest version. When I run mvn -pl :cloud-client-ui 
jetty:run it showed a message [sudo] password for mehdi: . 'mehdi' is my user 
name but, when I entered my password it showed me this message again. I am sure 
my password entered correctly. It can not continue  up to I press Ctrl+ c . 
please tell me why i shows this message and why it can not accept my password.
 

 
Thanks,
Mehdi Ali Soltani

[QA][PROPOSAL][ACS4.2] Test plan review: "Better Vm Sync"

2013-05-09 Thread Suresh Sadhu
HI,

Please review the test plan  for the feature "Better Vm sync" and let me know 
the review comments.


Test Plan:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Better+Vm+Sync


Functional Spec:  
https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+-+VMSync+improvement


regards
sadhu



Re: [jira] [Updated] (CLOUDSTACK-2307) Egress rules are not getting created under security groups.

2013-05-09 Thread Wei ZHOU
Hi,
I think this is duplicated by CLOUDSTACK-2319 which has been fixed.

2013/5/9, Jayapal Reddy (JIRA) :
>
>  [
> https://issues.apache.org/jira/browse/CLOUDSTACK-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Jayapal Reddy updated CLOUDSTACK-2307:
> --
>
> Assignee: Brian Federle
>
> Hi Pranv/Brian,
>
> This issue is not observed in the latest master.
> Please check this and update the bug.
>
> -Jayapal
>
>> Egress rules are not getting created under security groups.
>> ---
>>
>> Key: CLOUDSTACK-2307
>> URL:
>> https://issues.apache.org/jira/browse/CLOUDSTACK-2307
>> Project: CloudStack
>>  Issue Type: Bug
>>  Security Level: Public(Anyone can view this level - this is the
>> default.)
>>  Components: UI
>>Affects Versions: 4.2.0
>>Reporter: manasaveloori
>>Assignee: Brian Federle
>>Priority: Critical
>> Fix For: 4.2.0
>>
>>
>> Steps to reproduce:
>> 1.   Login as admin/regular user.
>> 2.   Go to Network->select security group from drop down.
>> 3.   Click on default security group and try to add Ingress and Egress
>> rules.
>> Observation:
>>  Egress rules are not getting created.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>


Re: [MERGE] CLOUDSTACK-747 "nTier Apps 2.0 : Internal Load Balancing between the VPC tiers"

2013-05-09 Thread Alena Prokharchyk
The code is in master; the merge commit is
2660a6b7a7f226ab757d2175222db62571813120.

-Alena.

On 5/9/13 9:52 AM, "Alena Prokharchyk" 
wrote:

>If nobody objects, I'm going to merge code from interanllb branch into
>master branch today, May 9th.
>
>-Alena.
>
>On 5/8/13 4:46 PM, "Chip Childers"  wrote:
>
>>On Mon, May 06, 2013 at 10:33:51AM -0700, Alena Prokharchyk wrote:
>>> Hi all,
>>> 
>>> I would like to merge the Internal LB feature from  asf/internallb
>>>branch
>>> to master.
>>> 
>>> - link to FS: 
>>> 
>>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Internal+Load+Bal
>>>a
>>>nc
>>> ing+between+VPC+tiers
>>> - Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-747
>>> - UnitTests: the tests are added to
>>> 
>>> cloud-plugin-network-internallb/test (Internal LB element management):
>>> 
>>> * InternalLbElementServiceTest.java
>>> * InternalLbElementTest.java
>>> * InternalLBVMManagerTest.java
>>> * InternalLBVMServiceTest.java
>>> 
>>> and cloud-server/test/lb (Internal LB rules management):
>>> 
>>> * ApplicationLoadBalancerTest.java
>>> 
>>> 
>>> - Integration tests: python test is
>>> test/integration/smoke/test_internal_lb.py
>>> - As various people were working on the branch, so I did do daily
>>>merges
>>> (not rebase) with the master branch, and internal lb commits are spread
>>> over time. To fetch all the internal LB commits, execute this command:
>>> 
>>> git log internallb ^master --no-merges
>>> 
>>> After the approval, the merge to master will be done as one squashed
>>> commit.
>>> 
>>> - there is no UI for the feature yet; it will be developed in another
>>> branch and merged to master branch separately.
>>> - Attached is the RAT report that resulted in "0 Unknown Licenses"
>>> 
>>> 
>>> 
>>> Thank you,
>>> -Alena.
>>>
>>
>>+1 from me
>>
>
>
>




Re: Review Request: PVLAN provisioning support for vmware Distributed Virtual Switch deployments on cloudstack.

2013-05-09 Thread Venkata Siva Vijayendra Bhamidipati


> On May 9, 2013, 6:54 p.m., Sheng Yang wrote:
> >

Thanks for the review Sheng. Please find my comments below. I'll upload newer 
diffs with some of the suggested changes shortly.


> On May 9, 2013, 6:54 p.m., Sheng Yang wrote:
> > server/src/com/cloud/network/NetworkModelImpl.java, line 933
> > 
> >
> > What's this for?

I hit an NPE at 
com.cloud.network.NetworkModelImpl.getNetworkRate(NetworkModelImpl.java:929) 
because the reference to VMInstanceVO would be null since the vm (router VM in 
this case) wouldn't exist yet. getNetworkOfferingNetworkRate() internally 
returns -1 to indicate unlimited network rate if it cannot obtain the 
networkRate from the provided networkofferingid and dcId. So I put in a check 
for null values and returned -1 if the call cannot be made. But I think it's 
better I pass null values instead if either is null, and let 
getNetworkOfferingNetworkRate() take care of the values passed in. Will make 
the required change.


> On May 9, 2013, 6:54 p.m., Sheng Yang wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 2848
> > 
> >
> > Can VMware just ignore the command? Rather than put hypervisor specific 
> > code here.

Yes VMWare can ignore it because the we configure the port groups in the start 
command path. The migration code path works differently with DVS since we don't 
have to plumb it on each host again after the first time when we configure the 
DVS (which pushes out the required config to each host it manages). The 
vmwareresource will still implement a stub of this method to not cause warnings 
when the VM is destroyed.


> On May 9, 2013, 6:54 p.m., Sheng Yang wrote:
> > server/src/com/cloud/vm/VirtualMachineManagerImpl.java, line 56
> > 
> >
> > What's the change in this file for? Not used anywhere.

Eclipse generated. Will remove it if it isn't being used anywhere.


> On May 9, 2013, 6:54 p.m., Sheng Yang wrote:
> > vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java,
> >  line 74
> > 
> >
> > I am confused by pvlanid existed with vlanid here. Do you mean 
> > "isolated pvlan"(which is secondary vlan)?

Yes


> On May 9, 2013, 6:54 p.m., Sheng Yang wrote:
> > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java, 
> > line 485
> > 
> >
> > better using e.g. secondary vlan id. pvlanid is confusing.

I'll change that to isolatedpvlanid, should be clearer that way.


> On May 9, 2013, 6:54 p.m., Sheng Yang wrote:
> > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java, 
> > line 746
> > 
> >
> > Reason to remove type converting?

Again, eclipse generated, but why would we need that cast? I would remove it.


- Venkata Siva Vijayendra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11019/#review20387
---


On May 9, 2013, 7:09 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11019/
> ---
> 
> (Updated May 9, 2013, 7:09 p.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Sheng Yang, Sateesh 
> Chodapuneedi, Kelven Yang, and Animesh Chaturvedi.
> 
> 
> Description
> ---
> 
> Please find attached the diffs for pvlan support for vmware DVSwitch 
> deployments on cloudstack. You will find two diffs - the parent diff is 
> Sateesh's fix for CLOUSTACK-2316 which is needed to be cherry-picked on the 
> pvlan branch from the master. The other diff contains the changes for pvlan 
> support.
> 
> These diffs do not contain changes for pvlan provisioning on the Cisco Nexus 
> 1000v distributed virtual switch.
> 
> 
> This addresses bug CLOUDSTACK-1456.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  99ad1ca 
>   server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 
>   server/src/com/cloud/network/NetworkModelImpl.java bd62886 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 
>   
> vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java
>  247be2a 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
> 7f323c5 
> 
> Diff: https://reviews.apache.org/r/11019

Re: "_Enhancer" Question

2013-05-09 Thread Mike Tutkowski
Thanks for the info on this!


On Thu, May 9, 2013 at 9:33 AM, Kelven Yang  wrote:

> Thanks for the tip, done.
>
> Kelven
>
> On 5/9/13 5:31 AM, "Alex Huang"  wrote:
>
> >You should be able to do that yourself.
> >
> >Click Browse and select Pages
> >Click on the Tree link
> >
> >From there you can move the pages.
> >
> >--Alex
> >
> >> -Original Message-
> >> From: Kelven Yang [mailto:kelven.y...@citrix.com]
> >> Sent: Wednesday, May 8, 2013 11:31 PM
> >> To: dev@cloudstack.apache.org
> >> Subject: Re: "_Enhancer" Question
> >>
> >> Could someone help move the linked wiki page to root level in wiki?
> >> although the work is done in Javelin branch, it now applies to all
> >>future
> >> releases.
> >>
> >> Kelven
> >>
> >> On 5/8/13 11:14 PM, "Kelven Yang"  wrote:
> >>
> >> >I've updated the wiki page for some background information on how we
> >> >end up current way of doing this.
> >> >
> >> >https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+Spring+i
> >> n+
> >> >Clo
> >> >u
> >> >dStack
> >> >
> >> >
> >> >Kelven
> >> >
> >> >On 5/8/13 9:37 PM, "Mike Tutkowski" 
> >> wrote:
> >> >
> >> >>Hi,
> >> >>
> >> >>I was wondering if someone could explain to me the "_Enhancer" pattern
> >> >>we are using in CloudStack (below) and how this kind of class is
> >>created.
> >> >>
> >> >>class
> >> >>org.apache.cloudstack.storage.allocator.ZoneWideStoragePoolAllocator_E
> >> >>nha
> >> >>n
> >> >>cerByCloudStack_4ff7ea3a
> >> >>
> >> >>Thanks!
> >> >>
> >> >>--
> >> >>*Mike Tutkowski*
> >> >>*Senior CloudStack Developer, SolidFire Inc.*
> >> >>e: mike.tutkow...@solidfire.com
> >> >>o: 303.746.7302
> >> >>Advancing the way the world uses the
> >> >>cloud
> >> >>* *
> >> >
> >
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*


Re: Review Request: PVLAN provisioning support for vmware Distributed Virtual Switch deployments on cloudstack.

2013-05-09 Thread Sheng Yang


> On May 9, 2013, 6:54 p.m., Sheng Yang wrote:
> > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java, 
> > line 746
> > 
> >
> > Reason to remove type converting?
> 
> Venkata Siva Vijayendra Bhamidipati wrote:
> Again, eclipse generated, but why would we need that cast? I would remove 
> it.

The original value is int, and the maximum of int is 2,147,483,647, in other 
word, the maximum bandwidth here would be 2G, then overflow. That's why you 
need convert it to long type here.


> On May 9, 2013, 6:54 p.m., Sheng Yang wrote:
> > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java, 
> > line 485
> > 
> >
> > better using e.g. secondary vlan id. pvlanid is confusing.
> 
> Venkata Siva Vijayendra Bhamidipati wrote:
> I'll change that to isolatedpvlanid, should be clearer that way.

Could you check if it's possible to represent a community secondary vlan in the 
future? If so, we'd better name it e.g. secondary pvlan.


- Sheng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11019/#review20387
---


On May 9, 2013, 7:09 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11019/
> ---
> 
> (Updated May 9, 2013, 7:09 p.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Sheng Yang, Sateesh 
> Chodapuneedi, Kelven Yang, and Animesh Chaturvedi.
> 
> 
> Description
> ---
> 
> Please find attached the diffs for pvlan support for vmware DVSwitch 
> deployments on cloudstack. You will find two diffs - the parent diff is 
> Sateesh's fix for CLOUSTACK-2316 which is needed to be cherry-picked on the 
> pvlan branch from the master. The other diff contains the changes for pvlan 
> support.
> 
> These diffs do not contain changes for pvlan provisioning on the Cisco Nexus 
> 1000v distributed virtual switch.
> 
> 
> This addresses bug CLOUDSTACK-1456.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  99ad1ca 
>   server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 
>   server/src/com/cloud/network/NetworkModelImpl.java bd62886 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 
>   
> vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java
>  247be2a 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
> 7f323c5 
> 
> Diff: https://reviews.apache.org/r/11019/diff/
> 
> 
> Testing
> ---
> 
> The code has been tested on the Vmware DVSwitch for advanced shared networks 
> on vmware cluster deployments on cloudstack. Unit tests will be the same as 
> those provided by Sheng as part of the overall PVLAN support for XenServer 
> and KVM, and will exercise the vmware pvlan code path when user VMs are 
> created with vNICs sitting on advanced shared networks that have the optional 
> Private VLAN value set during their creation. VM live migration using vmware 
> vMotion has also been tested with these changes on vmware and it works as 
> expected.
> 
> Further testing will be carried out and this review request will be updated 
> accordingly.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>



Eclipse Unit Testing

2013-05-09 Thread Soheil Eizadi
I have a problem with log4j when running my unit tests. It is not major as the 
tests run, but I want to get the logging to work. Here are the warning messages 
I get:
log4j:WARN No appenders could be found for logger 
(org.apache.commons.httpclient.HttpClient).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.

I read the wiki page on Unit Testing:
https://cwiki.apache.org/CLOUDSTACK/unit-testing-101.html
and
http://logging.apache.org/log4j/1.2/faq.html#noconfig

The wiki did not have detail on how to integrate with log4j infrastructure for 
Eclipse, I could create my own log4j.xml for my project and have Eclipse use 
it, but wanted to know if there were more elegant way to do this. I have not 
integrated with the main build and want to make sure what I do just works when 
I integrate my Maven project and not have to change.

-Soheil

RE: Cloud Stack compile error

2013-05-09 Thread Soheil Eizadi
Hi Mehdi,
Your subject said you have compile error but your problem happens when you are 
running CloudStack, i.e. mvn ... jetty:run.

You might want to look at the email thread below, there is a known issue that 
causes a Warning similar to error message you are getting. The CloudStack 
should still comes up and should work for you, i.e. you can log into the GUI.
-Soheil

http://markmail.org/search/list:org.apache.incubator.cloudstack-*?q=4.1+certificate+issue#query:list%3Aorg.apache.incubator.cloudstack-*%204.1%20certificate%20issue+page:1+mid:32v5btr2m3nvorvn+state:results


From: MEHDI ALI SOLTANI [mehdi_alisolt...@yahoo.com]
Sent: Thursday, May 09, 2013 12:28 PM
To: dev@cloudstack.apache.org
Subject: Cloud Stack compile error

Hi Dears Developers
I want to build cloud stack according to 
https://cwiki.apache.org/CLOUDSTACK/how-to-build-on-master-branch.html .
I downloaded cloud stack from

git clone https://git-wip-us.apache.org/repos/asf/cloudstack.git

and I thick that is a latest version. When I run mvn -pl :cloud-client-ui 
jetty:run it showed a message [sudo] password for mehdi: . 'mehdi' is my user 
name but, when I entered my password it showed me this message again. I am sure 
my password entered correctly. It can not continue  up to I press Ctrl+ c . 
please tell me why i shows this message and why it can not accept my password.



Thanks,
Mehdi Ali Soltani






Re: Cloud Stack compile error

2013-05-09 Thread Mike Tutkowski
I get this password request all the time, too.

If you hit ENTER about five or six times, the management-server startup
just continues OK.


On Thu, May 9, 2013 at 2:31 PM, Soheil Eizadi  wrote:

> Hi Mehdi,
> Your subject said you have compile error but your problem happens when you
> are running CloudStack, i.e. mvn ... jetty:run.
>
> You might want to look at the email thread below, there is a known issue
> that causes a Warning similar to error message you are getting. The
> CloudStack should still comes up and should work for you, i.e. you can log
> into the GUI.
> -Soheil
>
>
> http://markmail.org/search/list:org.apache.incubator.cloudstack-*?q=4.1+certificate+issue#query:list%3Aorg.apache.incubator.cloudstack-*%204.1%20certificate%20issue+page:1+mid:32v5btr2m3nvorvn+state:results
>
> 
> From: MEHDI ALI SOLTANI [mehdi_alisolt...@yahoo.com]
> Sent: Thursday, May 09, 2013 12:28 PM
> To: dev@cloudstack.apache.org
> Subject: Cloud Stack compile error
>
> Hi Dears Developers
> I want to build cloud stack according to
> https://cwiki.apache.org/CLOUDSTACK/how-to-build-on-master-branch.html .
> I downloaded cloud stack from
>
> git clone https://git-wip-us.apache.org/repos/asf/cloudstack.git
>
> and I thick that is a latest version. When I run mvn -pl :cloud-client-ui
> jetty:run it showed a message [sudo] password for mehdi: . 'mehdi' is my
> user name but, when I entered my password it showed me this message again.
> I am sure my password entered correctly. It can not continue  up to I press
> Ctrl+ c . please tell me why i shows this message and why it can not accept
> my password.
>
>
>
> Thanks,
> Mehdi Ali Soltani
>
>
>
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*


Re: haproxy on VMWare systemVM template

2013-05-09 Thread Sheng Yang
HAproxy is missing in Debian 7.0's repo, due to old maintainer is missing.

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674447
http://lists.debian.org/debian-qa/2013/04/msg00039.html

The new maintainer took over it at Apr 20th, but there is no schedule of
recovering yet.

That's why depends on everyday generated systemvm template is dangerous.

--Sheng


On Tue, Apr 23, 2013 at 12:09 AM, Rohit Yadav  wrote:

> On Mon, Apr 22, 2013 at 11:45 AM, Abhinandan Prateek <
> agneya2...@hotmail.com
> > wrote:
>
> > The haproxy and port map services are not installed on VMWare system VM
> > template. Is the path used to create the templates different for
> different
> > Hypervisor templates ? I was under the assumption that the services
> > installed on all the system VM templates meant for different hypervisors
> > should be same ?
> >
>
> No? Pl. see tools/appliance/systemvmtemplate/postinstall.sh, if it's there
> those pkgs will be installed.
> For the template I created, I had built it with veewee on my system and
> then imported it in vmware fusion to install the vmware-tools.
>
> Cheers.
>
>
> >
> > -abhi
> >
>


RE: Suggestion needed for CLOUDSTACK-212

2013-05-09 Thread Alex Huang
+1 to 4.3.  4.2 is too close to freeze date.

--Alex

> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Wednesday, May 8, 2013 6:31 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Suggestion needed for CLOUDSTACK-212
> 
> Dharmesh,
> 
> I'd also suggest that you actually plan on submitting this after the 4.2 
> feature
> freeze, to be included in 4.3.  This is the type of change that has bitten us
> with almost every release...  and doing it close to the end of the merge
> window may not be a good idea.  Our general preference is to do these types
> of changes in master right *after* the latest feature release has it's branch
> cut.
> 
> -chip
> 
> On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
> > ok. I will go with that.
> >
> > Thanks,
> > Dharmesh
> >
> > On Wed, May 8, 2013 at 1:08 AM, Chip Childers
> wrote:
> >
> > > On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
> > > > Hi,
> > > >
> > > > I am trying to move java package structure from com.cloud to
> > > > org.apache (
> > > > https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am
> thinking of doing it the following way (Totally newbie), needed feedback on
> that.
> > > >
> > > > 1. grep "com.cloud" on the entire repo.
> > > > 2. update all package declarations using eclipse.
> > > > 3. Update scripts etc found in 1 manually.
> > > >
> > > > Will it be a good way to do it ? Any better suggestion ?
> > > >
> > > > Thanks,
> > > > Dharmesh
> > >
> > > That seems like a reasonable approach.  We will probably want to
> > > create a branch when you submit a patch for this, and apply it
> > > there...  just to spend some time ensuring that the changes work.
> > >
> > > -chip
> > >


RE: Suggestion needed for CLOUDSTACK-212

2013-05-09 Thread Animesh Chaturvedi


> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Wednesday, May 08, 2013 6:31 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Suggestion needed for CLOUDSTACK-212
> 
> Dharmesh,
> 
> I'd also suggest that you actually plan on submitting this after the 4.2 
> feature
> freeze, to be included in 4.3.  This is the type of change that has bitten us
> with almost every release...  and doing it close to the end of the merge
> window may not be a good idea.  Our general preference is to do these types
> of changes in master right *after* the latest feature release has it's branch
> cut.
> 
> -chip
[Animesh>] yes 4.2 freeze is just 3 weeks out. This can be merged into master 
in early June
> 
> On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
> > ok. I will go with that.
> >
> > Thanks,
> > Dharmesh
> >
> > On Wed, May 8, 2013 at 1:08 AM, Chip Childers
> wrote:
> >
> > > On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
> > > > Hi,
> > > >
> > > > I am trying to move java package structure from com.cloud to
> > > > org.apache (
> > > > https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am
> thinking of doing it the following way (Totally newbie), needed feedback on
> that.
> > > >
> > > > 1. grep "com.cloud" on the entire repo.
> > > > 2. update all package declarations using eclipse.
> > > > 3. Update scripts etc found in 1 manually.
> > > >
> > > > Will it be a good way to do it ? Any better suggestion ?
> > > >
> > > > Thanks,
> > > > Dharmesh
> > >
> > > That seems like a reasonable approach.  We will probably want to
> > > create a branch when you submit a patch for this, and apply it
> > > there...  just to spend some time ensuring that the changes work.
> > >
> > > -chip
> > >


Re: haproxy on VMWare systemVM template

2013-05-09 Thread Chiradeep Vittal
Should we use the Ubuntu package for now?

On 5/9/13 2:03 PM, "Sheng Yang"  wrote:

>HAproxy is missing in Debian 7.0's repo, due to old maintainer is missing.
>
>http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674447
>http://lists.debian.org/debian-qa/2013/04/msg00039.html
>
>The new maintainer took over it at Apr 20th, but there is no schedule of
>recovering yet.
>
>That's why depends on everyday generated systemvm template is dangerous.
>
>--Sheng
>
>
>On Tue, Apr 23, 2013 at 12:09 AM, Rohit Yadav  wrote:
>
>> On Mon, Apr 22, 2013 at 11:45 AM, Abhinandan Prateek <
>> agneya2...@hotmail.com
>> > wrote:
>>
>> > The haproxy and port map services are not installed on VMWare system
>>VM
>> > template. Is the path used to create the templates different for
>> different
>> > Hypervisor templates ? I was under the assumption that the services
>> > installed on all the system VM templates meant for different
>>hypervisors
>> > should be same ?
>> >
>>
>> No? Pl. see tools/appliance/systemvmtemplate/postinstall.sh, if it's
>>there
>> those pkgs will be installed.
>> For the template I created, I had built it with veewee on my system and
>> then imported it in vmware fusion to install the vmware-tools.
>>
>> Cheers.
>>
>>
>> >
>> > -abhi
>> >
>>



Re: haproxy on VMWare systemVM template

2013-05-09 Thread Sheng Yang
No idea. Probably we should just grab some old generated systemvm for now.

--Sheng


On Thu, May 9, 2013 at 3:37 PM, Chiradeep Vittal <
chiradeep.vit...@citrix.com> wrote:

> Should we use the Ubuntu package for now?
>
> On 5/9/13 2:03 PM, "Sheng Yang"  wrote:
>
> >HAproxy is missing in Debian 7.0's repo, due to old maintainer is missing.
> >
> >http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674447
> >http://lists.debian.org/debian-qa/2013/04/msg00039.html
> >
> >The new maintainer took over it at Apr 20th, but there is no schedule of
> >recovering yet.
> >
> >That's why depends on everyday generated systemvm template is dangerous.
> >
> >--Sheng
> >
> >
> >On Tue, Apr 23, 2013 at 12:09 AM, Rohit Yadav 
> wrote:
> >
> >> On Mon, Apr 22, 2013 at 11:45 AM, Abhinandan Prateek <
> >> agneya2...@hotmail.com
> >> > wrote:
> >>
> >> > The haproxy and port map services are not installed on VMWare system
> >>VM
> >> > template. Is the path used to create the templates different for
> >> different
> >> > Hypervisor templates ? I was under the assumption that the services
> >> > installed on all the system VM templates meant for different
> >>hypervisors
> >> > should be same ?
> >> >
> >>
> >> No? Pl. see tools/appliance/systemvmtemplate/postinstall.sh, if it's
> >>there
> >> those pkgs will be installed.
> >> For the template I created, I had built it with veewee on my system and
> >> then imported it in vmware fusion to install the vmware-tools.
> >>
> >> Cheers.
> >>
> >>
> >> >
> >> > -abhi
> >> >
> >>
>
>


Re: haproxy on VMWare systemVM template

2013-05-09 Thread Chiradeep Vittal
How old? When did it disappear?

I propose using the Ubuntu  package.
In tools/appliance/definitions/systemvmtemplate/postinstall.sh

wget 
http://security.ubuntu.com/ubuntu/pool/main/h/haproxy/haproxy_1.4.18-0ubunt
u2.1_i386.deb

dpkg -i haproxy_1.4.18-0ubuntu2.1_i386.deb

Also do we know if the system vm template contains the version of dnsmasq
that is known to work for ipv6 support?

--
Chiradeep

On 5/9/13 3:48 PM, "Sheng Yang"  wrote:

>No idea. Probably we should just grab some old generated systemvm for now.
>
>--Sheng
>
>
>On Thu, May 9, 2013 at 3:37 PM, Chiradeep Vittal <
>chiradeep.vit...@citrix.com> wrote:
>
>> Should we use the Ubuntu package for now?
>>
>> On 5/9/13 2:03 PM, "Sheng Yang"  wrote:
>>
>> >HAproxy is missing in Debian 7.0's repo, due to old maintainer is
>>missing.
>> >
>> >http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674447
>> >http://lists.debian.org/debian-qa/2013/04/msg00039.html
>> >
>> >The new maintainer took over it at Apr 20th, but there is no schedule
>>of
>> >recovering yet.
>> >
>> >That's why depends on everyday generated systemvm template is
>>dangerous.
>> >
>> >--Sheng
>> >
>> >
>> >On Tue, Apr 23, 2013 at 12:09 AM, Rohit Yadav 
>> wrote:
>> >
>> >> On Mon, Apr 22, 2013 at 11:45 AM, Abhinandan Prateek <
>> >> agneya2...@hotmail.com
>> >> > wrote:
>> >>
>> >> > The haproxy and port map services are not installed on VMWare
>>system
>> >>VM
>> >> > template. Is the path used to create the templates different for
>> >> different
>> >> > Hypervisor templates ? I was under the assumption that the services
>> >> > installed on all the system VM templates meant for different
>> >>hypervisors
>> >> > should be same ?
>> >> >
>> >>
>> >> No? Pl. see tools/appliance/systemvmtemplate/postinstall.sh, if it's
>> >>there
>> >> those pkgs will be installed.
>> >> For the template I created, I had built it with veewee on my system
>>and
>> >> then imported it in vmware fusion to install the vmware-tools.
>> >>
>> >> Cheers.
>> >>
>> >>
>> >> >
>> >> > -abhi
>> >> >
>> >>
>>
>>



Re: haproxy on VMWare systemVM template

2013-05-09 Thread Sheng Yang
Don't know. We can use Ubuntu package for now if it possible.

or just use sid packages if possible?

dnsmasq version is 0.62, which is good enough for ipv6.

--Sheng


On Thu, May 9, 2013 at 4:04 PM, Chiradeep Vittal <
chiradeep.vit...@citrix.com> wrote:

> How old? When did it disappear?
>
> I propose using the Ubuntu  package.
> In tools/appliance/definitions/systemvmtemplate/postinstall.sh
>
> wget
> http://security.ubuntu.com/ubuntu/pool/main/h/haproxy/haproxy_1.4.18-0ubunt
> u2.1_i386.deb
>
> dpkg -i haproxy_1.4.18-0ubuntu2.1_i386.deb
>
> Also do we know if the system vm template contains the version of dnsmasq
> that is known to work for ipv6 support?
>
> --
> Chiradeep
>
> On 5/9/13 3:48 PM, "Sheng Yang"  wrote:
>
> >No idea. Probably we should just grab some old generated systemvm for now.
> >
> >--Sheng
> >
> >
> >On Thu, May 9, 2013 at 3:37 PM, Chiradeep Vittal <
> >chiradeep.vit...@citrix.com> wrote:
> >
> >> Should we use the Ubuntu package for now?
> >>
> >> On 5/9/13 2:03 PM, "Sheng Yang"  wrote:
> >>
> >> >HAproxy is missing in Debian 7.0's repo, due to old maintainer is
> >>missing.
> >> >
> >> >http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674447
> >> >http://lists.debian.org/debian-qa/2013/04/msg00039.html
> >> >
> >> >The new maintainer took over it at Apr 20th, but there is no schedule
> >>of
> >> >recovering yet.
> >> >
> >> >That's why depends on everyday generated systemvm template is
> >>dangerous.
> >> >
> >> >--Sheng
> >> >
> >> >
> >> >On Tue, Apr 23, 2013 at 12:09 AM, Rohit Yadav 
> >> wrote:
> >> >
> >> >> On Mon, Apr 22, 2013 at 11:45 AM, Abhinandan Prateek <
> >> >> agneya2...@hotmail.com
> >> >> > wrote:
> >> >>
> >> >> > The haproxy and port map services are not installed on VMWare
> >>system
> >> >>VM
> >> >> > template. Is the path used to create the templates different for
> >> >> different
> >> >> > Hypervisor templates ? I was under the assumption that the services
> >> >> > installed on all the system VM templates meant for different
> >> >>hypervisors
> >> >> > should be same ?
> >> >> >
> >> >>
> >> >> No? Pl. see tools/appliance/systemvmtemplate/postinstall.sh, if it's
> >> >>there
> >> >> those pkgs will be installed.
> >> >> For the template I created, I had built it with veewee on my system
> >>and
> >> >> then imported it in vmware fusion to install the vmware-tools.
> >> >>
> >> >> Cheers.
> >> >>
> >> >>
> >> >> >
> >> >> > -abhi
> >> >> >
> >> >>
> >>
> >>
>
>


RE: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

2013-05-09 Thread Animesh Chaturvedi
Abhi following up on this can you review and apply

> -Original Message-
> From: Prasanna Santhanam [mailto:nore...@reviews.apache.org] On Behalf
> Of Prasanna Santhanam
> Sent: Sunday, May 05, 2013 10:13 PM
> To: Harikrishna Patnala; Abhinandan Prateek
> Cc: Sateesh Chodapuneedi; Prasanna Santhanam; cloudstack; Wei Zhou
> Subject: Re: Review Request: (CLOUDSTACK-1325) add password in response
> of RestoreVM
> 
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9539/
> ---
> 
> (Updated May 6, 2013, 5:12 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Harikrishna Patnala.
> 
> 
> Changes
> ---
> 
> This is the same as Hari's patch and was submitted much earlier. Abhi - can
> you please review and apply this?
> 
> 
> Description
> ---
> 
> In 4.0.1, There is no password field in the respone of RestoreVM.
> Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325
> 
> This patch add a new password in the response.
> 
> 
> This addresses bug CLOUDSTACK-1325.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/UserVmService.java 6635657
>   server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8
> 
> Diff: https://reviews.apache.org/r/9539/diff/
> 
> 
> Testing
> ---
> 
> Testing manually ok.
> 
> command=restoreVirtualMachine&response=json&virtualmachineid=1a53a3
> 08-c870-452a-9eff-23975919286b
>  public $jobid =>
>  string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"
> 
> command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-
> 4449-a163-5c1af62019ab
>  public $password =>
>  string(9) "mD5qkzmdk"
> 
> 
> Thanks,
> 
> Wei Zhou



Re: Review Request: PVLAN provisioning support for vmware Distributed Virtual Switch deployments on cloudstack.

2013-05-09 Thread Venkata Siva Vijayendra Bhamidipati

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11019/
---

(Updated May 10, 2013, 2:32 a.m.)


Review request for cloudstack, Chip Childers, Sheng Yang, Sateesh Chodapuneedi, 
Kelven Yang, and Animesh Chaturvedi.


Changes
---

Incorporating changes following Sheng's comments.


Description
---

Please find attached the diffs for pvlan support for vmware DVSwitch 
deployments on cloudstack. You will find two diffs - the parent diff is 
Sateesh's fix for CLOUSTACK-2316 which is needed to be cherry-picked on the 
pvlan branch from the master. The other diff contains the changes for pvlan 
support.

These diffs do not contain changes for pvlan provisioning on the Cisco Nexus 
1000v distributed virtual switch.


This addresses bug CLOUDSTACK-1456.


Diffs (updated)
-

  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 99ad1ca 
  server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 
  server/src/com/cloud/network/NetworkModelImpl.java bd62886 
  server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 
  
vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java 
247be2a 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
7f323c5 

Diff: https://reviews.apache.org/r/11019/diff/


Testing
---

The code has been tested on the Vmware DVSwitch for advanced shared networks on 
vmware cluster deployments on cloudstack. Unit tests will be the same as those 
provided by Sheng as part of the overall PVLAN support for XenServer and KVM, 
and will exercise the vmware pvlan code path when user VMs are created with 
vNICs sitting on advanced shared networks that have the optional Private VLAN 
value set during their creation. VM live migration using vmware vMotion has 
also been tested with these changes on vmware and it works as expected.

Further testing will be carried out and this review request will be updated 
accordingly.


Thanks,

Venkata Siva Vijayendra Bhamidipati



Re: Review Request: CLOUDSTACK-658: Scaling up CPU and RAM for running VMs - Vmware

2013-05-09 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11025/#review20410
---


Commit 75a2457af639e6bcf751c2e97d1360df1a0265e4 in branch refs/heads/master 
from Nitin Mehta 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=75a2457 ]

CLOUDSTACK-658 - Adding scale vm support for vmware with unit tests
Signed off by : Nitin Mehta 


- ASF Subversion and Git Services


On May 9, 2013, 1:22 p.m., Harikrishna Patnala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11025/
> ---
> 
> (Updated May 9, 2013, 1:22 p.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta and Sateesh Chodapuneedi.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-658: Scaling up CPU and RAM for running VMs - Vmware
> 
> Adding support to scale up the vms in case of Vmware.
> 
> Including unit tests.
> 
> 
> This addresses bug CLOUDSTACK-658.
> 
> 
> Diffs
> -
> 
>   plugins/hypervisors/vmware/pom.xml d65ef64 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  030eff0 
>   
> plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java
>  PRE-CREATION 
>   server/src/com/cloud/vm/UserVmManagerImpl.java bc25bed 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java 9c467dc 
> 
> Diff: https://reviews.apache.org/r/11025/diff/
> 
> 
> Testing
> ---
> 
> Tested locally by scaling the vm to an higher service offering.
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>



Re: Review Request: CLOUDSTACK-658: Scaling up CPU and RAM for running VMs - Vmware

2013-05-09 Thread Nitin Mehta
Pushed with commit 75a2457af639e6bcf751c2e97d1360df1a0265e4 into master

On 09/05/13 7:32 PM, "Nitin Mehta"  wrote:

>
>---
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/11025/#review20378
>---
>
>Ship it!
>
>
>Ship It!
>
>- Nitin Mehta
>
>
>On May 9, 2013, 1:22 p.m., Harikrishna Patnala wrote:
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/11025/
>> ---
>> 
>> (Updated May 9, 2013, 1:22 p.m.)
>> 
>> 
>> Review request for cloudstack, Nitin Mehta and Sateesh Chodapuneedi.
>> 
>> 
>> Description
>> ---
>> 
>> CLOUDSTACK-658: Scaling up CPU and RAM for running VMs - Vmware
>> 
>> Adding support to scale up the vms in case of Vmware.
>> 
>> Including unit tests.
>> 
>> 
>> This addresses bug CLOUDSTACK-658.
>> 
>> 
>> Diffs
>> -
>> 
>>   plugins/hypervisors/vmware/pom.xml d65ef64
>>   
>>plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/Vmwar
>>eResource.java 030eff0
>>   
>>plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/Vmwa
>>reResourceTest.java PRE-CREATION
>>   server/src/com/cloud/vm/UserVmManagerImpl.java bc25bed
>>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java
>>9c467dc 
>> 
>> Diff: https://reviews.apache.org/r/11025/diff/
>> 
>> 
>> Testing
>> ---
>> 
>> Tested locally by scaling the vm to an higher service offering.
>> 
>> 
>> Thanks,
>> 
>> Harikrishna Patnala
>> 
>>
>



Re: Review Request: CLOUDSTACK-2419 : Localization - Some Japanese are not working

2013-05-09 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11021/#review20411
---


Commit fa9987753c530c8e9560297986ac8848b7526854 in branch refs/heads/master 
from Pranav Saxena 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fa99877 ]

CLOUDSTACK-2419 : Localization - Some Japanese are not working


- ASF Subversion and Git Services


On May 9, 2013, 12:29 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11021/
> ---
> 
> (Updated May 9, 2013, 12:29 p.m.)
> 
> 
> Review request for cloudstack, Fang Wang and Animesh Chaturvedi.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2419 : Localization - Some Japanese are not working
> 
> The following JP keys are not working:
> • ~ ^
> • [{
> • ]}
> • ' @
> • ; +
> • : *
> • Numpad *
> • Numpad +
> • Numpad -
> • Numpad /
> • CAPS Lock
> • Kanji Key 
> 
> 
> This addresses bug CLOUDSTACK-2419.
> 
> 
> Diffs
> -
> 
>   services/console-proxy/server/js/ajaxkeys.js 1ed41c5 
> 
> Diff: https://reviews.apache.org/r/11021/diff/
> 
> 
> Testing
> ---
> 
> Tested on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>



Re: Review Request: CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with Alerts

2013-05-09 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11004/#review20412
---


Commit 3aed20c9d27cbe97afc32fd47909a2f08c4550c8 in branch refs/heads/master 
from Pranav Saxena 
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3aed20c ]

CLOUDSTACK-1603: Management server .log Java Exceptions are displayed with 
Alerts


- ASF Subversion and Git Services


On May 8, 2013, 9:35 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11004/
> ---
> 
> (Updated May 8, 2013, 9:35 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Likitha Shetty, and Sateesh 
> Chodapuneedi.
> 
> 
> Description
> ---
> 
> CLOUDSTACK-1603 : Management server .log Java Exceptions are displayed with 
> Alerts
> 
> 
> This addresses bug CLOUDSTACK-1603.
> 
> 
> Diffs
> -
> 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
>  f2cb1c4 
> 
> Diff: https://reviews.apache.org/r/11004/diff/
> 
> 
> Testing
> ---
> 
> Tested on my local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>



Re: [GSOC] Student interviews

2013-05-09 Thread L Radhakrishna Rao
Please don't take it otherwise

May i know on how to submit proposal?

I would like to do this, I was unaware on this.

Regards,
RK


On Fri, May 10, 2013 at 12:21 AM, ADAMA COULIBALY wrote:

> Hi Sebastien,
>
> My phone number is (1) 267-243-3954
> The best time to call me : 10:00 am to 12:00
> 2:pm   to 5: pm
> any day after this Wednesday 15th May, ( From Monday to Wednesday I will be
> busy with my final)
> So let know the day and time then I will be ready for your phone call.
>
> Best Regards,
>
> Adama
>
>
> On Thu, May 9, 2013 at 12:33 PM, Sebastien Goasguen  >wrote:
>
> > Hi,
> >
> > I would like to schedule phone/skype interviews with all the students who
> > submitted proposals.
> > (This is authorized and recommended by ASF gsoc guidelines)
> >
> > Please get in touch with me on IRC or direct email to set a meeting time.
> >
> > Once the times are set I will send it to the list and welcome anyone who
> > wants to participate in the call.
> >
> > Cheers,
> >
> > -Sebastien
>


Re: Review Request: Fix test_global_settings.py which is checking for the wrong global setting

2013-05-09 Thread Harikrishna Patnala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11006/#review20414
---

Ship it!


Ship It!

- Harikrishna Patnala


On May 8, 2013, 9:15 a.m., SrikanteswaraRao Talluri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11006/
> ---
> 
> (Updated May 8, 2013, 9:15 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> ---
> 
> 1. test_global_settings.py is checking the wrong global setting while 
> validating the updated config
> 2. Need to add tags - advanced, basic, devcloud etc., 
> 
> 
> This addresses bug CLOUDSTACK-2382.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_global_settings.py a7cdb3e 
> 
> Diff: https://reviews.apache.org/r/11006/diff/
> 
> 
> Testing
> ---
> 
> tested
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>



RE: [ACS41] Release Blocker Update for 2013-05-08

2013-05-09 Thread Kishan Kavala


> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com]
> Sent: Thursday, 9 May 2013 9:45 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [ACS41] Release Blocker Update for 2013-05-08
> 
> 
> On May 9, 2013, at 8:54 AM, Kishan Kavala  wrote:
> 
> >
> >
> >> -Original Message-
> >> From: Chip Childers [mailto:chip.child...@sungard.com]
> >> Sent: Wednesday, 8 May 2013 10:48 PM
> >> To: dev@cloudstack.apache.org
> >> Cc: Kishan Kavala
> >> Subject: [ACS41] Release Blocker Update for 2013-05-08
> >>
> >> Here's where we stand:
> >>
> >> CLOUDSTACK-2309
> >>  Upgrade from 2.2.14 to 4.1.0 : network static routes deleted on SSVM
> >>
> >>  Kishan - any update on 2309?  Also note that Wei suggested a fix to
> >> the  reporter for 528.  However, you said you thought 2309 and 528
> >> could be  related.  Can you review the suggestion?
> >>
> > Chip,
> > I successfully upgraded from 2.2.14 to 4.1 . SSVM came up after stopping
> and starting. All the routes were also properly configured.
> > I'll work with Nicolas to see if all the upgrades steps were followed.
> >
> > Routes won't be configured if SecStorageVMSetupCommand is not sent to
> SSVM.
> >
> > ~kishan
> >
> 
> Kishan, which hypervisor and OS did you use
> 
> thanks
> 
> -sebastien
> 
[KK]  Sebastien, I tested it on XenServer/RHEL6.2.



Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-09 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11027/
---

(Updated May 10, 2013, 6:54 a.m.)


Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Changes
---

removed the stars in import statements from citrixResourceBase.


Description
---

Cloudstack-702. Multiple ip ranges in different subnets. 

This feature enables adding of guest ip ranges (public ips)  form different 
subnets.

In order to provide the dhcp service to a different subnet we create an ipalias 
on the router. This allows the router to listen to the dhcp request from the 
guest vms and respond accordingly. Every time a vm is deployed in the new 
subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to 
provide dhcp service. We need to configure the dnsmasq to issue ips on the new 
subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq 
confg file, this file replaces the old config in the router. 

The details of the alias ips are stored in db in the nic_ip_alias table. Every 
time a new subnet is added one of the ip from the subnet is used to configure 
the ip alias. 

I have pushed the code to  
https://github.com/bvbharatk/cloud-stack/tree/Cloudstack-702 , also rebased the 
code with master. 
I need to test the code for advanced sg enabled network using kvm.

This is duplicate of the pervious review request 
https://reviews.apache.org/r/10948/. please ignore it. 

I have added the unit test

Also accomodated some of the changes suggested by koushik. 
corrected the import statements. renamed the IpAlias command to createIpAlias 
command. 


This addresses bug Cloudstack-702.


Diffs (updated)
-

  api/src/com/cloud/agent/api/to/DnsmasqTO.java PRE-CREATION 
  api/src/com/cloud/exception/MissingParameterValueException.java PRE-CREATION 
  api/src/com/cloud/network/element/DhcpServiceProvider.java f73590c 
  api/src/com/cloud/vm/NicIpAlias.java PRE-CREATION 
  client/tomcatconf/applicationContext.xml.in 36f232c 
  core/src/com/cloud/agent/api/routing/DeleteIpAliasCommand.java PRE-CREATION 
  core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java PRE-CREATION 
  core/src/com/cloud/agent/api/routing/IpAliasTO.java PRE-CREATION 
  core/src/com/cloud/agent/api/routing/createIpAliasCommand.java PRE-CREATION 
  core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 
b9bda4d 
  core/src/com/cloud/network/DnsMasqConfigurator.java PRE-CREATION 
  engine/schema/src/com/cloud/dc/dao/VlanDao.java cc82632 
  engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java 100295b 
  engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3d588fa 
  engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 73f310f 
  engine/schema/src/com/cloud/vm/dao/NicDao.java 67c1e07 
  engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java c70d194 
  patches/systemvm/debian/config/root/createIpAlias.sh PRE-CREATION 
  patches/systemvm/debian/config/root/deleteIpAlias.sh PRE-CREATION 
  patches/systemvm/debian/config/root/dnsmasq.sh PRE-CREATION 
  
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java
 b72d1c8 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 d87da64 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 bac361d 
  
plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java
 804e4a6 
  scripts/vm/hypervisor/xenserver/createipAlias.sh PRE-CREATION 
  scripts/vm/hypervisor/xenserver/deleteipAlias.sh PRE-CREATION 
  scripts/vm/hypervisor/xenserver/vmops 30b5300 
  scripts/vm/hypervisor/xenserver/xcpserver/patch b7961bb 
  scripts/vm/hypervisor/xenserver/xenserver56/patch 36dba3d 
  scripts/vm/hypervisor/xenserver/xenserver56fp1/patch d20e60f 
  scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 
  server/src/com/cloud/configuration/ConfigurationManager.java bce1776 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 37ca793 
  server/src/com/cloud/network/NetworkManager.java 4af716c 
  server/src/com/cloud/network/NetworkManagerImpl.java 4fffbc1 
  server/src/com/cloud/network/addr/PublicIp.java 25e9d30 
  server/src/com/cloud/network/element/VirtualRouterElement.java f601f4f 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 
f49ab79 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
6620e0a 
  server/src/com/cloud/vm/dao/NicIpAliasDao.java PRE-CREATION 
  server/src/com/cloud/vm/dao/NicIpAliasDaoImpl.java PRE-CREATION 
  server/src/com/cloud/vm/dao/NicIpAliasVO.java PRE-CREATION 
  server/test/com/cloud/configuration/ValidateIpRangeTest.java PRE-CREATION 
  server/test/com/cloud/network/MockNetworkManagerImpl.java 2f717c8 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 83b1924