RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs
Kelven most likely in on a flight to US and may not see this
-Original Message-
From: Musayev, Ilya [mailto:imusa...@webmd.net]
Sent: Tuesday, July 23, 2013 7:36 PM
To: Kelven Yang; dev@cloudstack.apache.org
Subject: RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere
VMs
Kelven
We are unable release ACS 4.1.1 as we have issues with CLOUDSTACK-3433.
After several hours of testing, even after I redeploy CPVM, I still see
more errors in the logs (see below) and basic CPVM functionality is
broken. I'm not certain what we fix with CLOUDSTACK-3433, but currently
have many more issues.
Would it be possible to revert this commit and work on adding this
commit into 4.1.2 instead?
We have to wrap up ACS 4.1.1 release tomorrow.
Thanks
ilya
2013-07-23 22:30:47,132 WARN [utils.nio.Task] (AgentManager-Handler-
10:null) Caught the following exception but pushing on
com.google.gson.JsonParseException: The JsonDeserializer
com.cloud.agent.transport.ArrayTypeAdaptor@5ad2ee0f failed to
deserialize json object
[{StartupProxyCommand:{proxyPort:80,proxyVmId:260,type:ConsoleP
roxy,dataCenter:2,pod:2,guid:Proxy.260-
ConsoleProxyResource,name:v-260-CLOUD411,version:4.1.1-
SNAPSHOT,iqn:NoIqn,publicIpAddress:172.24.20.22,publicNetmask
:255.255.255.224,publicMacAddress:06:2a:5e:00:00:29,privateIpAddr
ess:172.24.20.25,privateMacAddress:06:3f:9e:00:00:2b,privateNetm
ask:255.255.255.224,storageIpAddress:172.24.20.25,storageNetmask
:255.255.255.224,storageMacAddress:06:3f:9e:00:00:2b,resourceNam
e:ConsoleProxyResource,contextMap:{},wait:0}}] given the type
class [Lcom.cloud.agent.api.Command;
at
com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeseria
lizerExceptionWrapper.java:64)
at
com.google.gson.JsonDeserializationVisitor.invokeCustomDeserializer(Json
DeserializationVisitor.java:92)
at
com.google.gson.JsonDeserializationVisitor.visitUsingCustomHandler(JsonD
eserializationVisitor.java:80)
at com.google.gson.ObjectNavigator.accept(ObjectNavigator.java:101)
at
com.google.gson.JsonDeserializationContextDefault.fromJsonArray(JsonDese
rializationContextDefault.java:67)
at
com.google.gson.JsonDeserializationContextDefault.deserialize(JsonDeseri
alizationContextDefault.java:52)
at com.google.gson.Gson.fromJson(Gson.java:551)
at com.google.gson.Gson.fromJson(Gson.java:498)
at com.cloud.agent.transport.Request.getCommands(Request.java:235)
at
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.processRequest(Age
ntManagerImpl.java:1221)
at
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.doTask(AgentManage
rImpl.java:1374)
at
com.cloud.agent.manager.ClusteredAgentManagerImpl$ClusteredAgentHandler.
doTask(ClusteredAgentManagerImpl.java:659)
at com.cloud.utils.nio.Task.run(Task.java:83)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.jav
a:1110)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.ja
va:603)
at java.lang.Thread.run(Thread.java:679)
Caused by: com.cloud.utils.exception.CloudRuntimeException: can't find
StartupProxyCommand
at
com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor.
java:75)
at
com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor.
java:36)
at
com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeseria
lizerExceptionWrapper.java:51)
... 15 more
rather urgently (tomorrow), if we cannot get it fixed by then, lets
consider pushing this into 4.1.2
-Original Message-
From: Kelven Yang [mailto:kelven.y...@citrix.com]
Sent: Thursday, July 18, 2013 7:16 PM
To: Musayev, Ilya; dev@cloudstack.apache.org
Subject: Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to
VSphere VMs
Yes, CPVM has to be destroyed and be re-deployed so that updates can
be pushed over to make it work
Kelven
On 7/18/13 2:54 PM, Musayev, Ilya imusa...@webmd.net wrote:
When I say upgraded, I mean it needs to be trashed and redeployed.
-Original Message-
From: Musayev, Ilya [mailto:imusa...@webmd.net]
Sent: Thursday, July 18, 2013 5:46 PM
To: Kelven Yang; dev@cloudstack.apache.org
Subject: RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to
VSphere VMs
Kelven,
Perhaps I missed it,
Does CPVM needs to be upgraded from 4.1 to 4.1.1?
Thanks
ilya
-Original Message-
From: Kelven Yang [mailto:kelven.y...@citrix.com]
Sent: Thursday, July 18, 2013 5:25 PM
To: Musayev, Ilya; dev@cloudstack.apache.org
Subject: Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to
VSphere VMs
I'll take a look at it. It seems that my devCloud environment
failed to get CPVM upgraded thus let my testing on this skipped
with success
Kelven
On 7/17/13 8:04 PM,
Re: [Proposal] Routing between guest networks in VLAN isolation method.
On 23/07/13 11:15 PM, Nguyen Anh Tu ng.t...@gmail.com wrote: @David: it just only add a feature for guest network mode. If a VPC has too much tiers, maybe one VPC router is not enough. If scale is a concern with VPC router, perhaps that could be addressed. I believe users can today deploy a routing appliance as an instance with NIC's in both guest networks that can provide inter-vlan routing, of course its not out-of-the box solution and needs setting up the static routes on the instances but works. [1] has pre-VPC reference solutions for VM connectivity across the guest networks. [1] http://www.slideshare.net/cloudstack/cloudstack-networking @Ahmad: this proposal use a route instead of a nat. Vms can talk via privateIP. Of course, VMs in two guest networks currently can reach each other via hairpinNAT. @Chip: For the beginning, I just wanna limit privilege to Root admin. If users can easily config route, maybe it cause some conflict rules. 2013/7/24 Chip Childers chip.child...@sungard.com On Tue, Jul 23, 2013 at 01:26:08PM -0400, David Nalley wrote: On Tue, Jul 23, 2013 at 1:21 PM, Nguyen Anh Tu ng.t...@gmail.com wrote: Hi guys, I write a proposal about implementing routing method for guest networks using VLAN isolation. At the moment, they can reach each other due to interVLAN routing in VPC model, but can not in Guest network model. So the key point is make some static routes between them, including iptables rules for filtering ports and protocols. Please take a look on my proposal, link below. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Routing+between+Gu est+networks Isn't this exactly the case that VPC is designed to solve? What's the benefit of doing this? If we did this, would we continue using VPC? --David Well right now, the main issue is that VPC follows the AWS VPC concepts of allocating a single block for the VPC. This isn't actually flexible enough for some environments, and Nguyen's proposal is something that I've been looking into myself. Nguyen, when you state All configurations are done by admin only., which admin? Root? If root only, why? -- N.g.U.y.e.N.A.n.H.t.U
Re: Review Request 12893: CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/#review23738 --- When I run it locally I see this: ERROR: Test Volumes limit per project -- Traceback (most recent call last): File /Users/tsp/workspace/cloudstack/incubator-cloudstack/test/integration/component/test_project_limits.py, line 830, in test_06_volumes_per_project projectid=self.project.id File /Library/Python/2.7/site-packages/marvin/integration/lib/base.py, line 388, in create virtual_machine = apiclient.deployVirtualMachine(cmd, method=method) File /Library/Python/2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py, line 1019, in deployVirtualMachine response = self.connection.marvin_request(command, response_type=response, method=method) File /Library/Python/2.7/site-packages/marvin/cloudstackConnection.py, line 222, in marvin_request response = jsonHelper.getResultObj(response.json(), response_type) File /Library/Python/2.7/site-packages/marvin/jsonHelper.py, line 148, in getResultObj raise cloudstackException.cloudstackAPIException(respname, errMsg) cloudstackAPIException: Execute cmd: deployvirtualmachine failed, due to: errorCode: 535, errorText:Maximum number of resources of type 'volume' for project name=Project-3RFNJB in domain id=3 has been exceeded. begin captured logging testclient.testcase.TestResourceLimitsProject: DEBUG: Updating volume resource limits for project: 2ca8db1a-a97a-4cf5-a459-648f01c833c1 testclient.testcase.TestResourceLimitsProject: DEBUG: Deploying VM for project: 2ca8db1a-a97a-4cf5-a459-648f01c833c1 I will attach the logs to the bug report - Prasanna Santhanam On July 24, 2013, 5 a.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/ --- (Updated July 24, 2013, 5 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3696 Repository: cloudstack-git Description --- CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project. Diffs - test/integration/component/test_project_limits.py 6e3f41d Diff: https://reviews.apache.org/r/12893/diff/ Testing --- Verified the marvin test locally on cloudstack setup. Thanks, Sanjay Tripathi
Re: Automated Tests: Account Cleanup in test modules
About the patch I committed, in fact it's not moving. It's fixing. Because: 1. The logical reason is, currently in many cases(which I committed the patches) the account is already create per test case rather than per module. And if account is created in setUp() rather than setUpClass(), the clean up would be in tearDown() rather than tearDownClass(), because they're useless anyway after setUp create another account and more VMs. My patch didn't move account creation from setUpClass(). 2. The more direct reason is too many test cases in regression test failed just because lack of resource to create new deployment. E.g. https://issues.apache.org/jira/browse/CLOUDSTACK-3643 . Whenever I saw Fail to create VPC or Fail to deploy VM, mostly it because the testing setup is overloaded. I know VM creating is very time consuming, and reuse the account and VM is really nice! But the fact is many of current test cases is not written in this way. So I think we should release the resource as soon as it's obsolete. About reusing the already deployed VM and account, it would be a case-by-case issue. For example, TestAddVmToSubDomain case in test_accounts do create the two VMs shared across the module(class), then tear it down when in tearDownClass(). But sometime there is not a easy way to do so. I think that's why there are not many VirtualMachine.create() happened in setUpClass(). --Sheng On Tue, Jul 23, 2013 at 10:56 PM, Prasanna Santhanam t...@apache.org wrote: In the test modules when you debug you will notice that accounts are created once per module in setUpClass() all resources created within it and tearDownClass() destroys the account initiating cleanup. All the resources are appended to a cleanup [] list and deleted in appropriate order at the end of the test module in tearDownClass() There are a few reasons for doing this for all the tests in the class at once as opposed to doing it for every test. Modules are grouped by feature eg: test_tags does tags related tests. And more often than not all tests in the module share similar patterns in the set of API calls made to achieve a test scenario. If an account was created per test the overhead of cleaning up is much higher than when cleaning up once per module. Because every new account needs a new VR for the first VM deployed in it. And almost every test will deploy a VM. So this slows down test run significantly and eats up resources like VLANs very quickly which are needed for every account. I saw a few fixes that moved the resource cleanup from tearDownClass() to tearDown and that prompted me to send this email. Hope this makes sense. I'd like to hear other's thoughts on how best to accomplish all the tests in the most optimum way without hurting resources on a deployment. Also - on the test infrastructure on jenkins.buildacloud.org there is no way to timeout a specific test if it takes up more time than necessary. So I'm going to introduce a timeout plugin in nose that will abort the test if it takes longer than 1/2hr. I think this should help weeding out test that do arbitrary 'sleeps' or wait for very long cleanup operations. That way we should be able to optimize the test as well Thoughts? -- Prasanna., Powered by BigRock.com
Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/ --- (Updated July 24, 2013, 6:30 a.m.) Review request for cloudstack and Kishan Kavala. Changes --- Updated diff, resolving merge conflicts with latest. Bugs: 2508 Repository: cloudstack-git Description --- Usage entries for template and iso should include virtual_size parameter. Added new column to usage_event table which contains the virtual size. Modified the usage event creation when a template is created. Diffs (updated) - api/src/org/apache/cloudstack/api/response/UsageRecordResponse.java 4b355cb api/src/org/apache/cloudstack/usage/Usage.java c74d3b7 engine/schema/src/com/cloud/event/UsageEventVO.java c92972b engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 004ab7c engine/schema/src/com/cloud/usage/UsageStorageVO.java 1337edc engine/schema/src/com/cloud/usage/UsageVO.java 18a3a6b engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java 2237d56 engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java 297c8f4 server/src/com/cloud/api/ApiResponseHelper.java e058105 server/src/com/cloud/event/UsageEventUtils.java 2d92fae server/src/com/cloud/template/TemplateManagerImpl.java c87f8eb usage/src/com/cloud/usage/UsageManagerImpl.java 4901dd9 usage/src/com/cloud/usage/parser/StorageUsageParser.java 337e8e2 Diff: https://reviews.apache.org/r/12852/diff/ Testing --- Usage event generated for creating template with virtual size. Thanks, Saksham Srivastava
Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs
Ilya,
Did you upgrade agent and systemvm.iso on host ?
2013/7/24 Musayev, Ilya imusa...@webmd.net
Kelven
We are unable release ACS 4.1.1 as we have issues with CLOUDSTACK-3433.
After several hours of testing, even after I redeploy CPVM, I still see
more errors in the logs (see below) and basic CPVM functionality is broken.
I'm not certain what we fix with CLOUDSTACK-3433, but currently have many
more issues.
Would it be possible to revert this commit and work on adding this commit
into 4.1.2 instead?
We have to wrap up ACS 4.1.1 release tomorrow.
Thanks
ilya
2013-07-23 22:30:47,132 WARN [utils.nio.Task]
(AgentManager-Handler-10:null) Caught the following exception but pushing on
com.google.gson.JsonParseException: The JsonDeserializer
com.cloud.agent.transport.ArrayTypeAdaptor@5ad2ee0f failed to deserialize
json object
[{StartupProxyCommand:{proxyPort:80,proxyVmId:260,type:ConsoleProxy,dataCenter:2,pod:2,guid:Proxy.260-ConsoleProxyResource,name:v-260-CLOUD411,version:4.1.1-SNAPSHOT,iqn:NoIqn,publicIpAddress:172.24.20.22,publicNetmask:255.255.255.224,publicMacAddress:06:2a:5e:00:00:29,privateIpAddress:172.24.20.25,privateMacAddress:06:3f:9e:00:00:2b,privateNetmask:255.255.255.224,storageIpAddress:172.24.20.25,storageNetmask:255.255.255.224,storageMacAddress:06:3f:9e:00:00:2b,resourceName:ConsoleProxyResource,contextMap:{},wait:0}}]
given the type class [Lcom.cloud.agent.api.Command;
at
com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeserializerExceptionWrapper.java:64)
at
com.google.gson.JsonDeserializationVisitor.invokeCustomDeserializer(JsonDeserializationVisitor.java:92)
at
com.google.gson.JsonDeserializationVisitor.visitUsingCustomHandler(JsonDeserializationVisitor.java:80)
at com.google.gson.ObjectNavigator.accept(ObjectNavigator.java:101)
at
com.google.gson.JsonDeserializationContextDefault.fromJsonArray(JsonDeserializationContextDefault.java:67)
at
com.google.gson.JsonDeserializationContextDefault.deserialize(JsonDeserializationContextDefault.java:52)
at com.google.gson.Gson.fromJson(Gson.java:551)
at com.google.gson.Gson.fromJson(Gson.java:498)
at com.cloud.agent.transport.Request.getCommands(Request.java:235)
at
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.processRequest(AgentManagerImpl.java:1221)
at
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.doTask(AgentManagerImpl.java:1374)
at
com.cloud.agent.manager.ClusteredAgentManagerImpl$ClusteredAgentHandler.doTask(ClusteredAgentManagerImpl.java:659)
at com.cloud.utils.nio.Task.run(Task.java:83)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:679)
Caused by: com.cloud.utils.exception.CloudRuntimeException: can't find
StartupProxyCommand
at
com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor.java:75)
at
com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor.java:36)
at
com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeserializerExceptionWrapper.java:51)
... 15 more
rather urgently (tomorrow), if we cannot get it fixed by then, lets
consider pushing this into 4.1.2
-Original Message-
From: Kelven Yang [mailto:kelven.y...@citrix.com]
Sent: Thursday, July 18, 2013 7:16 PM
To: Musayev, Ilya; dev@cloudstack.apache.org
Subject: Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere
VMs
Yes, CPVM has to be destroyed and be re-deployed so that updates can be
pushed over to make it work
Kelven
On 7/18/13 2:54 PM, Musayev, Ilya imusa...@webmd.net wrote:
When I say upgraded, I mean it needs to be trashed and redeployed.
-Original Message-
From: Musayev, Ilya [mailto:imusa...@webmd.net]
Sent: Thursday, July 18, 2013 5:46 PM
To: Kelven Yang; dev@cloudstack.apache.org
Subject: RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to
VSphere VMs
Kelven,
Perhaps I missed it,
Does CPVM needs to be upgraded from 4.1 to 4.1.1?
Thanks
ilya
-Original Message-
From: Kelven Yang [mailto:kelven.y...@citrix.com]
Sent: Thursday, July 18, 2013 5:25 PM
To: Musayev, Ilya; dev@cloudstack.apache.org
Subject: Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to
VSphere VMs
I'll take a look at it. It seems that my devCloud environment
failed to get CPVM upgraded thus let my testing on this skipped
with success
Kelven
On 7/17/13 8:04 PM, Musayev, Ilya imusa...@webmd.net wrote:
Kelven
Please review the commit
73a6aa78854f379e6439bf22457094a5272cbfed,
cloudstack-3433.
After reverting this commit, everything functioned
Re: Automated Tests: Account Cleanup in test modules
On Tue, Jul 23, 2013 at 11:20:22PM -0700, Sheng Yang wrote: About the patch I committed, in fact it's not moving. It's fixing. Because: 1. The logical reason is, currently in many cases(which I committed the patches) the account is already create per test case rather than per module. And if account is created in setUp() rather than setUpClass(), the clean up would be in tearDown() rather than tearDownClass(), because they're useless anyway after setUp create another account and more VMs. My patch didn't move account creation from setUpClass(). Sheng - thanks I saw your patches more clearly now. The diffs mislead me that they were perhaps moved. You're right that the cleanup list should add the account in the locality of where it was created ie per-test or per-module as the case may be. 2. The more direct reason is too many test cases in regression test failed just because lack of resource to create new deployment. E.g. https://issues.apache.org/jira/browse/CLOUDSTACK-3643 . Whenever I saw Fail to create VPC or Fail to deploy VM, mostly it because the testing setup is overloaded. Yes this is a concern. We are mislead by resource exhaustion to be a failure in the test. Do you think the tests could be better organized when run in a group against a limited resource deployment? I know VM creating is very time consuming, and reuse the account and VM is really nice! But the fact is many of current test cases is not written in this way. So I think we should release the resource as soon as it's obsolete. Yup that's the way it was intended. We probably deviated from there and will fix these tests during this sprint. About reusing the already deployed VM and account, it would be a case-by-case issue. For example, TestAddVmToSubDomain case in test_accounts do create the two VMs shared across the module(class), then tear it down when in tearDownClass(). But sometime there is not a easy way to do so. I think that's why there are not many VirtualMachine.create() happened in setUpClass(). Agreed on this. Much of this information is within the test cases and until you drill down in the scenario you won't be aware of it. But in general the guidelines probably were not clear (I got questions from others working on the tests) so it was better to spell them out. It's time to write up these guidelines in our wiki which has some basic guidelines already: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python#Marvin-TestingwithPython-Guidelinestochoosescenariosforintegration Thanks for sharing your thoughts, --Sheng On Tue, Jul 23, 2013 at 10:56 PM, Prasanna Santhanam t...@apache.org wrote: In the test modules when you debug you will notice that accounts are created once per module in setUpClass() all resources created within it and tearDownClass() destroys the account initiating cleanup. All the resources are appended to a cleanup [] list and deleted in appropriate order at the end of the test module in tearDownClass() There are a few reasons for doing this for all the tests in the class at once as opposed to doing it for every test. Modules are grouped by feature eg: test_tags does tags related tests. And more often than not all tests in the module share similar patterns in the set of API calls made to achieve a test scenario. If an account was created per test the overhead of cleaning up is much higher than when cleaning up once per module. Because every new account needs a new VR for the first VM deployed in it. And almost every test will deploy a VM. So this slows down test run significantly and eats up resources like VLANs very quickly which are needed for every account. I saw a few fixes that moved the resource cleanup from tearDownClass() to tearDown and that prompted me to send this email. Hope this makes sense. I'd like to hear other's thoughts on how best to accomplish all the tests in the most optimum way without hurting resources on a deployment. Also - on the test infrastructure on jenkins.buildacloud.org there is no way to timeout a specific test if it takes up more time than necessary. So I'm going to introduce a timeout plugin in nose that will abort the test if it takes longer than 1/2hr. I think this should help weeding out test that do arbitrary 'sleeps' or wait for very long cleanup operations. That way we should be able to optimize the test as well Thoughts? -- Prasanna., Powered by BigRock.com -- Prasanna., Powered by BigRock.com
RE: New Components on JIRA
-Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: Tuesday, July 23, 2013 9:32 PM To: dev@cloudstack.apache.org Subject: Re: New Components on JIRA On Tue, Jul 23, 2013 at 05:23:03PM +, Ram Ganesh wrote: -Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: 23 July 2013 22:36 To: CloudStack Dev Subject: New Components on JIRA The following new components have been added to JIRA to narrow down issues into the right buckets. (name, description) --- * Infra - Infrastructure managed by the project - CloudStack - (jenkins, builds, repos, mirrors) * SystemVM - SystemVM appliances, images, scripts, ssvm, cpvm * Virtual Router - Anything related to the Virtual Router appliance * XCP - Xen Cloud Platform --- Anyone see any problems? Prasanna, How about - automation-product and automation-script components? Automation-product for all product bugs discovered by the automation engine and automation-script for all automation script issues? Right now - that distinction is not clear at least from the bug reports. We're reusing the same report for both script and product failure. So anything filed from an automated test failure should just be automation and on further analysis if it is found to be product failure, a clearer bug report would be necessary within the right component of the product - api, network, systemvm etc. -- Prasanna., Powered by BigRock.com [Animesh] I also added a few new components last week UCS, Upgrade. Once we close down on 4.2 as community we should revisit the component list
[ACS42] Release Status Update: One week to code freeze
Folks We are now just 1 week from ACS 4.2 code freeze on 7/29. For the past 2 - 3 week there has been vibrant activity in filing and fixing issues. We have managed to contain open defects to less than 400 but blockers and critical are still in 90+. For the days remaining to code freeze, lets prioritize fixing blockers and critical over majors. As from last week in order to clear up our backlog I request you to help out on aggressively fixing the issues. The unassigned issue list is available at http://s.apache.org/BlH/. When you fix a bug in 4.2 please make sure it is also fixed in master. The outstanding resolved issues now stand at 492 with 250 blockers and critical still to be verified. As with fixing issues now we need to focus on blockers and critical first. The detailed bug status is captured below. Bugs| This Week| Last Week -+---+--+---+---+---+--+---+--- | Blocker Critical Major Total | Blocker Critical Major Total -+---+--+---+---+---+--+---+--- Incoming|29 48 64 144 |31 40 46 120 Outgoing|37 68 51 159 |33 38 65 140 Open Unassigned | 6 13 149 208 | 6 46 120 226 Open Total |24 68 239 392 |30 84 213 388 The status for features or improvement is depicted in table below |-+---+---| | New Features / Improvements | Today | Last Week | |-+---+---| | Closed |13 |12 | | Resolved|60 |59 | | In Progress | 9 |10 | | Reopened| 2 | 2 | | Ready To Review | 0 | 0 | | Open|18 |19 | |-+---+---| | Total | 102 | 102 | |-+---+---| You can always visit the 4.2 Release dashboard http://s.apache.org/M5k for the current status. Thanks Animesh
Re: Git Push Summary
Hi all, I've been working on re-factoring the dedication UI code in these days and just finished. I discussed the requirements with Pranav before. The changes are listed as following: 1. zone wizard: (JIRA ticket : https://issues.apache.org/jira/browse/CLOUDSTACK-3700) Add a dedication step to activating zone process with rules as: (A) if the user check the dedicate checkbox and provide correct account information, the wizard will have an extra dedicating step when activating the newly created zone(show in the activating steps). (B) if the user check the dedicate checkbox and provide incorrect account information, the wizard will return to Setup Zone step. Let the user has the opportunity to modify the acc or uncheck the dedicate checkbox. It runs into two cases after the user click on fix error through the wizard: (a) If the user unchecks the dedicate checkbox this time, the wizard will continue to finish the rest of the activating process without showing the dedicating step. (b) If the user provides the correct account this time, the wizard will process the dedicating step again(show in the wizard) and finish the rest of activating process 2. Create pod/cluster/host from dialog: (JIRA ticket : https://issues.apache.org/jira/browse/CLOUDSTACK-3388) Fix the dedication code to fit asynchronous dedication api commands. The UI now shows correct notification message for the dedication operation. Please let me know if you have any concerns, thanks! :) Regards Isaac On Fri, Jul 19, 2013 at 10:04 AM, Isaac Chiang isaacchi...@gmail.comwrote: Hi Pranav, I'll do more tests before applying the code to master in next few days. Since the UI code has been re-formatted yesterday, I'd like to copy/paste the modified part into master instead of merging the branch. Thanks for all the help and advice :) Regards On Thu, Jul 18, 2013 at 2:47 PM, Pranav Saxena psb...@gmail.com wrote: Hey Isaac , I verified your code changes in your private asf branch . The code changes look good to me. I am assuming that it would work fine for the following cases - 1) Dedication is a success , addition of resource is a success 2) Dedication is a failure , addition of resource is still a success 3) Dedication is a failure , addition is also a failure - All 3 cases should have notification displayed for each of the API calls getting triggered ( which I believe would be there after your code changes) - Also you could provide a setInterval waiting time function of say 2-3 seconds between two successive notifications. One thing which I realized after looking at your code changes is that you would have to bear the pain of resolving the merge conflicts when you merge your branch with master. Since your code modifications/additions have been done on the already existing code , I am pretty sure you would have to take care of these conflicts. Since the changes aren't that huge, you could manually copy them to the master branch or replace the entire system.js file in your branch in the master assuming you forked your branch out of master and there haven't been other changes in system.js file . First option is a safer approach though !! Thanks, Pranav On Thu, Jul 18, 2013 at 8:18 AM, Isaac Chiang isaacchi...@gmail.comwrote: Hi Pranav: I just pushed part of modified code in to the branch. Please have a look if the commit fix the issue as expected. Thanks, Regards -- Forwarded message -- From: Pranav Saxena psb...@gmail.com Date: Tue, Jul 16, 2013 at 4:52 PM Subject: Re: Git Push Summary To: dev@cloudstack.apache.org, jessica.w...@citrix.com, sonny.ch...@citrix.com Cc: comm...@cloudstack.apache.org Thanks Isaac for creating this branch. I'll keep an eye on the commits you make your here . Once the code for handling nested query API calls are ready , you can merge it into master. @Jessica - I have had conversations with Isaac and he is in the process of re-factoring the code for dedicated resources to handle the nested query API calls . You could review it once as well when he sends out a request for merge . It should not be a big change though ! Thanks, Pranav On Tue, Jul 16, 2013 at 2:00 PM, isaacchi...@apache.org wrote: Updated Branches: refs/heads/ui-dedicatedresources-refactoring [created] 22ddc3fa0
Re: Review Request 12886: Fix test case issue test_vm_life_cycle.py:test_09_expunge_vm : CLOUDSTACK-2899
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12886/#review23745 --- I think you should increase the number of expunge.workers in your deployment. The magic timeout here will again fail when the number of tests you are running in parallel increase exhausting the workers. Also we are already waiting for 2 cycles of the expunge thread to ensure that we don't miss because of expunge thread exhaustion - Prasanna Santhanam On July 24, 2013, 12:02 a.m., Rayees Namathponnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12886/ --- (Updated July 24, 2013, 12:02 a.m.) Review request for cloudstack, Alena Prokharchyk and Prasanna Santhanam. Bugs: CLOUDSTACK-2899 Repository: cloudstack-git Description --- Test case test_vm_life_cycle.py:test_09_expunge_vm failing during expunge; if there are more than one expunge operation; expunge will be executed in sequential; in this we need to add some extra delay in test apart from expunage delay and expunge wait; add 60 sec in test case Diffs - test/integration/smoke/test_vm_life_cycle.py c2c2592 Diff: https://reviews.apache.org/r/12886/diff/ Testing --- Tested in KVM and VMware Thanks, Rayees Namathponnan
RE: Git Push Summary
Not there in 4.2? -Original Message- From: Isaac Chiang [mailto:isaacchi...@gmail.com] Sent: Wednesday, July 24, 2013 3:12 PM To: Pranav Saxena Cc: dev@cloudstack.apache.org Subject: Re: Git Push Summary Hi all, I've been working on re-factoring the dedication UI code in these days and just finished. I discussed the requirements with Pranav before. The changes are listed as following: 1. zone wizard: (JIRA ticket : https://issues.apache.org/jira/browse/CLOUDSTACK-3700) Add a dedication step to activating zone process with rules as: (A) if the user check the dedicate checkbox and provide correct account information, the wizard will have an extra dedicating step when activating the newly created zone(show in the activating steps). (B) if the user check the dedicate checkbox and provide incorrect account information, the wizard will return to Setup Zone step. Let the user has the opportunity to modify the acc or uncheck the dedicate checkbox. It runs into two cases after the user click on fix error through the wizard: (a) If the user unchecks the dedicate checkbox this time, the wizard will continue to finish the rest of the activating process without showing the dedicating step. (b) If the user provides the correct account this time, the wizard will process the dedicating step again(show in the wizard) and finish the rest of activating process 2. Create pod/cluster/host from dialog: (JIRA ticket : https://issues.apache.org/jira/browse/CLOUDSTACK-3388) Fix the dedication code to fit asynchronous dedication api commands. The UI now shows correct notification message for the dedication operation. Please let me know if you have any concerns, thanks! :) Regards Isaac On Fri, Jul 19, 2013 at 10:04 AM, Isaac Chiang isaacchi...@gmail.comwrote: Hi Pranav, I'll do more tests before applying the code to master in next few days. Since the UI code has been re-formatted yesterday, I'd like to copy/paste the modified part into master instead of merging the branch. Thanks for all the help and advice :) Regards On Thu, Jul 18, 2013 at 2:47 PM, Pranav Saxena psb...@gmail.com wrote: Hey Isaac , I verified your code changes in your private asf branch . The code changes look good to me. I am assuming that it would work fine for the following cases - 1) Dedication is a success , addition of resource is a success 2) Dedication is a failure , addition of resource is still a success 3) Dedication is a failure , addition is also a failure - All 3 cases should have notification displayed for each of the API calls getting triggered ( which I believe would be there after your code changes) - Also you could provide a setInterval waiting time function of say 2-3 seconds between two successive notifications. One thing which I realized after looking at your code changes is that you would have to bear the pain of resolving the merge conflicts when you merge your branch with master. Since your code modifications/additions have been done on the already existing code , I am pretty sure you would have to take care of these conflicts. Since the changes aren't that huge, you could manually copy them to the master branch or replace the entire system.js file in your branch in the master assuming you forked your branch out of master and there haven't been other changes in system.js file . First option is a safer approach though !! Thanks, Pranav On Thu, Jul 18, 2013 at 8:18 AM, Isaac Chiang isaacchi...@gmail.comwrote: Hi Pranav: I just pushed part of modified code in to the branch. Please have a look if the commit fix the issue as expected. Thanks, Regards -- Forwarded message -- From: Pranav Saxena psb...@gmail.com Date: Tue, Jul 16, 2013 at 4:52 PM Subject: Re: Git Push Summary To: dev@cloudstack.apache.org, jessica.w...@citrix.com, sonny.ch...@citrix.com Cc: comm...@cloudstack.apache.org Thanks Isaac for creating this branch. I'll keep an eye on the commits you make your here . Once the code for handling nested query API calls are ready , you can merge it into master. @Jessica - I have had conversations with Isaac and he is in the process of re-factoring the code for dedicated resources to handle the nested query API calls . You could review it once as well when he sends out a request for merge . It should not be a big change though ! Thanks, Pranav On Tue, Jul 16, 2013 at 2:00 PM, isaacchi...@apache.org wrote: Updated Branches: refs/heads/ui-dedicatedresources-refactoring [created] 22ddc3fa0
Re: Git Push Summary
Thanks Isaac for making the relevant code changes there. I think you probably committed it only to master . You would need to cherry-pick it up to asf/4.2 as well . Otherwise the changes you have made look good and in accordance with the workflow we discussed . Regards, Pranav On Wed, Jul 24, 2013 at 3:18 PM, Saksham Srivastava saksham.srivast...@citrix.com wrote: Not there in 4.2? -Original Message- From: Isaac Chiang [mailto:isaacchi...@gmail.com] Sent: Wednesday, July 24, 2013 3:12 PM To: Pranav Saxena Cc: dev@cloudstack.apache.org Subject: Re: Git Push Summary Hi all, I've been working on re-factoring the dedication UI code in these days and just finished. I discussed the requirements with Pranav before. The changes are listed as following: 1. zone wizard: (JIRA ticket : https://issues.apache.org/jira/browse/CLOUDSTACK-3700) Add a dedication step to activating zone process with rules as: (A) if the user check the dedicate checkbox and provide correct account information, the wizard will have an extra dedicating step when activating the newly created zone(show in the activating steps). (B) if the user check the dedicate checkbox and provide incorrect account information, the wizard will return to Setup Zone step. Let the user has the opportunity to modify the acc or uncheck the dedicate checkbox. It runs into two cases after the user click on fix error through the wizard: (a) If the user unchecks the dedicate checkbox this time, the wizard will continue to finish the rest of the activating process without showing the dedicating step. (b) If the user provides the correct account this time, the wizard will process the dedicating step again(show in the wizard) and finish the rest of activating process 2. Create pod/cluster/host from dialog: (JIRA ticket : https://issues.apache.org/jira/browse/CLOUDSTACK-3388) Fix the dedication code to fit asynchronous dedication api commands. The UI now shows correct notification message for the dedication operation. Please let me know if you have any concerns, thanks! :) Regards Isaac On Fri, Jul 19, 2013 at 10:04 AM, Isaac Chiang isaacchi...@gmail.com wrote: Hi Pranav, I'll do more tests before applying the code to master in next few days. Since the UI code has been re-formatted yesterday, I'd like to copy/paste the modified part into master instead of merging the branch. Thanks for all the help and advice :) Regards On Thu, Jul 18, 2013 at 2:47 PM, Pranav Saxena psb...@gmail.com wrote: Hey Isaac , I verified your code changes in your private asf branch . The code changes look good to me. I am assuming that it would work fine for the following cases - 1) Dedication is a success , addition of resource is a success 2) Dedication is a failure , addition of resource is still a success 3) Dedication is a failure , addition is also a failure - All 3 cases should have notification displayed for each of the API calls getting triggered ( which I believe would be there after your code changes) - Also you could provide a setInterval waiting time function of say 2-3 seconds between two successive notifications. One thing which I realized after looking at your code changes is that you would have to bear the pain of resolving the merge conflicts when you merge your branch with master. Since your code modifications/additions have been done on the already existing code , I am pretty sure you would have to take care of these conflicts. Since the changes aren't that huge, you could manually copy them to the master branch or replace the entire system.js file in your branch in the master assuming you forked your branch out of master and there haven't been other changes in system.js file . First option is a safer approach though !! Thanks, Pranav On Thu, Jul 18, 2013 at 8:18 AM, Isaac Chiang isaacchi...@gmail.com wrote: Hi Pranav: I just pushed part of modified code in to the branch. Please have a look if the commit fix the issue as expected. Thanks, Regards -- Forwarded message -- From: Pranav Saxena psb...@gmail.com Date: Tue, Jul 16, 2013 at 4:52 PM Subject: Re: Git Push Summary To: dev@cloudstack.apache.org, jessica.w...@citrix.com, sonny.ch...@citrix.com Cc: comm...@cloudstack.apache.org Thanks Isaac for creating this branch. I'll keep an eye on the commits you make your here . Once the code for handling nested query API calls are ready , you can merge it into master. @Jessica - I have had conversations with Isaac and he is in the process of re-factoring the code for dedicated resources to handle the nested query API calls . You could review it once as well when he sends out a request for
RE: [GSOC]cannot add host with the lastest master
Hi Chiradeep,
Before I explore further, can I ask where StartupSecondaryStorageCommand
mentioned in the defect https://issues.apache.org/jira/browse/CLOUDSTACK-3377
gets used?
DL
-Original Message-
From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
Sent: 24 July 2013 6:01 AM
To: dev@cloudstack.apache.org
Subject: Re: [GSOC]cannot add host with the lastest master
Not sure what the vintage of the systemvm has to do with it. They do not
contain the agent (Java jar files) until the systemvm is created and started.
When first started, the jar files are copied into the system vm.
On 7/24/13 3:41 AM, Donal Lafferty donal.laffe...@citrix.com wrote:
Hi Meng,
You may also be having problems with your system VM. Let me explain:
The issue you see is caused by a change in JSON serialisation that
happened in 4.2.
Previously, we recorded an object's type using it's class' simple name.
Now, we are using the full class name, which include the package. E.g.
the serializer used to write { StartupRoutingCommand : ... }, but now
it records
{com.cloud.agent.api.com.cloud.agent.api.StartupRoutingCommand:...}
A lot of code compile against 4.1 will not be able to communicate with
the latest management server.
This means you also have to update your system VM templates. If you
don't, you get an error like
https://issues.apache.org/jira/browse/CLOUDSTACK-3377
Unfortunately, the default download URLs for system VMs are for 4.1.
If you have not already, download the latest system VMs from
http://jenkins.cloudstack.org/view/master/job/build-systemvm-master/
Cheers,
DL
-Original Message-
From: Wido den Hollander [mailto:w...@widodh.nl]
Sent: 23 July 2013 9:27 PM
To: dev@cloudstack.apache.org
Subject: Re: [GSOC]cannot add host with the lastest master
Hi Meng,
On 07/23/2013 09:28 PM, Han,Meng wrote:
Hi Wei,
Thank you for your reply.
On Wed, 24 Jul 2013 02:08:36 +0800, Wei ZHOU wrote:
I suggest updating the agent on host as well
I run yum install cloudstack-agent on the kvm host, it told me that
it's already the latest version. I found the post
here:https://issues.apache.org/jira/browse/CLOUDSTACK-3118
Rajesh Battala mentioned that he installed the latest agent from
the build CloudStack-non-OSS-MASTER-499-rhel6.3.
This is what you run into:
https://issues.apache.org/jira/browse/CLOUDSTACK-3714
Do you know where can I get that build and how to start the agent
if I have the build(will service cloudstack-agent start do) ?
I didn't find the build in
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=summary
I see you use RHEL/CentOS, with the packaging script in
packaging/rhel you should be able to build RPM packages from master.
Wido
Any help is appreciated.
Cheers,
Meng
RE: New Components on JIRA
-Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: 24 July 2013 10:02 To: dev@cloudstack.apache.org Subject: Re: New Components on JIRA On Tue, Jul 23, 2013 at 05:23:03PM +, Ram Ganesh wrote: -Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: 23 July 2013 22:36 To: CloudStack Dev Subject: New Components on JIRA The following new components have been added to JIRA to narrow down issues into the right buckets. (name, description) --- * Infra - Infrastructure managed by the project - CloudStack - (jenkins, builds, repos, mirrors) * SystemVM - SystemVM appliances, images, scripts, ssvm, cpvm * Virtual Router - Anything related to the Virtual Router appliance * XCP - Xen Cloud Platform --- Anyone see any problems? Prasanna, How about - automation-product and automation-script components? Automation-product for all product bugs discovered by the automation engine and automation-script for all automation script issues? Right now - that distinction is not clear at least from the bug reports. We're reusing the same report for both script and product failure. So anything filed from an automated test failure should just be automation and on further analysis if it is found to be product failure, a clearer bug report would be necessary within the right component of the product - api, network, systemvm etc. Yes you are right. Component is not the right field. Maybe we could use Label. A JIRA report which reports product issues discovered out of automation will be very valuable. Maybe label is a field for that. -- Prasanna., Powered by BigRock.com
Review Request 12896: General clean up of ldapplugin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/ --- Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. Repository: cloudstack-git Description --- Cleans up LDAP plugin based on feedback from sonar. Diffs - plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapAddConfigurationCmd.java 62736b16087561a7e25893cd46115795100c609e plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapDeleteConfigurationCmd.java 329b91b plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java 087d156 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java 6707878 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapUserSearchCmd.java e6a40d0 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java d583346 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 40ba0ce plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java 2916202 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 8f31ce5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java d3ff820 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java 30bdc5b plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java be9b3d5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 54802cf plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUtils.java 453dc0a plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy 91c9baf plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy 8135901 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy 664fd64 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListConfigurationCmdSpec.groovy a7c1979 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy d72878b Diff: https://reviews.apache.org/r/12896/diff/ Testing --- Complied... passed unit tests. Passed integration tests. Thanks, Ian Duffy
Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- (Updated July 24, 2013, 10:28 a.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Changes --- Fixed the issues pointed out in the review. Also added a fix to handle vms with multiple nics. Bugs: CLOUDSTACK-3694 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3694 wrote the dnsmasq config in bash instead of creating the config file in java and overwriting. Diffs (updated) - core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 0b26220 core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df patches/systemvm/debian/config/etc/init.d/cloud-early-config c04ff90 patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java c7f487e plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f80d4b6 scripts/vm/hypervisor/xenserver/vmops f8c0253 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6c0f7a1 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 7a4bf50 Diff: https://reviews.apache.org/r/12810/diff/ Testing --- Tested on old master using xenserver. Could not test on the latest one as it is broken. Thanks, bharat kumar
Re: Review Request 12896: General clean up of ldapplugin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/#review23746 --- Review 12896 failed the build test : FAILURE The url of build cloudstack-master-with-patch #29 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/29/ - Jenkins Cloudstack.org On July 24, 2013, 10:26 a.m., Ian Duffy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/ --- (Updated July 24, 2013, 10:26 a.m.) Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. Repository: cloudstack-git Description --- Cleans up LDAP plugin based on feedback from sonar. Diffs - plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapAddConfigurationCmd.java 62736b16087561a7e25893cd46115795100c609e plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapDeleteConfigurationCmd.java 329b91b plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java 087d156 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java 6707878 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapUserSearchCmd.java e6a40d0 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java d583346 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 40ba0ce plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java 2916202 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 8f31ce5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java d3ff820 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java 30bdc5b plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java be9b3d5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 54802cf plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUtils.java 453dc0a plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy 91c9baf plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy 8135901 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy 664fd64 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListConfigurationCmdSpec.groovy a7c1979 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy d72878b Diff: https://reviews.apache.org/r/12896/diff/ Testing --- Complied... passed unit tests. Passed integration tests. Thanks, Ian Duffy
Re: [DESIGN] Why is enum a class...
Thanks Frank and John,
I've been strugling with the enums in Networks.java. A discussion on those
is needed I think. BroadcastDomainType seems to be a hybrid of a stable and
a plugin extendible enum. It breaks my mind and my every change.
regards,
Daan
On Tue, Jul 23, 2013 at 8:37 PM, Frank Zhang frank.zh...@citrix.com wrote:
Speaking of method on enum, I used to think it's very handy feature but
finally I failed on some scenarios and switched to own defined class.
The problem is enum is singleton that you can't save stateful data in it.
For example:
public enum Type {
private Object userData;
private Object getUserData() {...}
private void setUserData(Object data) {...}
Type SOME_TYPE;
}
This kind of thing is somewhat useless, userData here is actually global,
every call to SOME_TYPE.setUserData() would change its value.
So for usage perspective the methods you define on enmu are like static
method on class which has its limitations.
As for methods in enmu body in your example, the only usage I can recall
now is like what TimeUnit does. For CloudStack, we can do the similar
thing: SizeUnit that translates storage/memory size in different
quantities.
public enum SizeUnit {
BYTE {
public long toKiloByte(long s) {
return (s / (k / b));
}
public long toMegaByte(long s) {
return (s / (m / b));
}
public long toGigaByte(long s) {
return (s / (g / b));
}
public long toTeraByte(long s) {
return (s / (t / b));
}
},
KILOBYTE {
public long toByte(long s) {
return (s * (k / b));
}
public long toMegaByte(long s) {
return (s / (m / k));
}
public long toGigaByte(long s) {
return (s / (g / k));
}
public long toTeraByte(long s) {
return (s / (t / k));
}
},
MEGABYTE {
public long toByte(long s) {
return (s * (m / b));
}
public long toKiloByte(long s) {
return (s * (m / k));
}
public long toGigaByte(long s) {
return (s / (g / m));
}
public long toTeraByte(long s) {
return (s / (t / m));
}
},
GIGABYTE {
public long toByte(long s) {
return (s * (g / b));
}
public long toKiloByte(long s) {
return (s * (g / k));
}
public long toMegaByte(long s) {
return (s * (g / m));
}
public long toTeraByte(long s) {
return (s / (t / g));
}
},
TERABYTE {
public long toByte(long s) {
return (s * (t / b));
}
public long toKiloByte(long s) {
return (s * (t / k));
}
public long toMegaByte(long s) {
return (s * (t / m));
}
public long toGigaByte(long s) {
return (s * (t / g));
}
};
private static final long b = 1;
private static final long k = b * 1024;
private static final long m = k * 1024;
private static final long g = m * 1024;
private static final long t = g * 1024;
public long toByte(long s) {
throw new AbstractMethodError();
}
public long toKiloByte(long s) {
throw new AbstractMethodError();
}
public long toMegaByte(long s) {
throw new AbstractMethodError();
}
public long toGigaByte(long s) {
throw new AbstractMethodError();
}
public long toTeraByte(long s) {
throw new AbstractMethodError();
}
}
This may explain some of my views on java enum. It does have lots of
advantages like compiler check, native == operator. Just like
Alex mentioned, for constants that unlikely to change in future, we can
stick to enum. But for types that plugin may extend, we'd
better to use own defined classes.
From: John Burwell [mailto:jburw...@basho.com]
Sent: Tuesday, July 23, 2013 6:25 AM
To: dev@cloudstack.apache.org
Subject: Re: [DESIGN] Why is enum a class...
All,
+1 to Alex's design suggestion. Another little know feature of
enumerations is the ability to define abstract methods. Therefore, Alex's
example can be expanded as follows:
public enum Type {
User(false)
{
@Override
public void doWork() {
}
},
DomainRouter(true)
{
@Override
public void doWork() {
}
},
ConsoleProxy(true)
{
@Override
public void doWork(){
{
},
SecondaryStorageVm(true)
{
@Override
public void doWork(){
Review Board/Jenkins
Hi, I uploaded a patch to review board for a specific branch, ldapplugin. Jenkins attempted to take the patch and apply it to master, resulting in a failed result. https://reviews.apache.org/r/12896/ http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/29/console
[DISCUSS} enums in Networks,.java
there has been some discussion on the proper use of enums recently. I've been strugling with the enums in Networks.java. A discussion on those is needed I think. BroadcastDomainType seems to be a hybrid of a stable and a plugin extendible enum. It breaks my mind and my every change. There are more in there and not all of them are needed I think or at least they overlap in meaning. IsolationType seems similar for instance BroadcastDomainType contain Vlan, Storage, Lswitch but also Mido and Ec2. The latter are clearly extensions that should be cougght in a more abstract enum value and a construct according to Franks* pattern. Any thoughts? * http://www.mail-archive.com/dev@cloudstack.apache.org/msg09955.html
Re: Review Request 12896: General clean up of ldapplugin
On July 24, 2013, 10:30 a.m., Jenkins Cloudstack.org wrote: Review 12896 failed the build test : FAILURE The url of build cloudstack-master-with-patch #29 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/29/ Jenkins attempted to patch master... patch is for ldapplugin branch. - Ian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/#review23746 --- On July 24, 2013, 10:26 a.m., Ian Duffy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/ --- (Updated July 24, 2013, 10:26 a.m.) Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. Repository: cloudstack-git Description --- Cleans up LDAP plugin based on feedback from sonar. Diffs - plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapAddConfigurationCmd.java 62736b16087561a7e25893cd46115795100c609e plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapDeleteConfigurationCmd.java 329b91b plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java 087d156 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java 6707878 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapUserSearchCmd.java e6a40d0 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java d583346 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 40ba0ce plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java 2916202 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 8f31ce5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java d3ff820 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java 30bdc5b plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java be9b3d5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 54802cf plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUtils.java 453dc0a plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy 91c9baf plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy 8135901 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy 664fd64 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListConfigurationCmdSpec.groovy a7c1979 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy d72878b Diff: https://reviews.apache.org/r/12896/diff/ Testing --- Complied... passed unit tests. Passed integration tests. Thanks, Ian Duffy
Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/ --- Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3594 Repository: cloudstack-git Description --- One of the patches introduced a regression where account and domainid parameters were changed. Therefore Affinity Groups for those accounts were not found and tests failed. Diffs - tools/marvin/marvin/integration/lib/base.py 6e49ae5 Diff: https://reviews.apache.org/r/12897/diff/ Testing --- Thanks, Girish Shilamkar
Re: Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/ --- (Updated July 24, 2013, 10:53 a.m.) Review request for cloudstack, Alena Prokharchyk and Kishan Kavala. Changes --- Updated Patch for 4.2 branch. Bugs: 3612 Repository: cloudstack-git Description --- This fix is a part of missing db_upgrade bug 3612. Adding column virtual_size that will be a part of fix for CS-2508 Diffs (updated) - setup/db/db/schema-410to420.sql f9417a0 Diff: https://reviews.apache.org/r/12811/diff/ Testing --- Thanks, Saksham Srivastava
RE: [GSOC]cannot add host with the lastest master
I had an offline conversation with Chiradeep to sort this out.
Provided the latest SystemVM code is built, there's no difficulty. E.g. using
mvn clean install -P developer,systemvm
See
https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+on+master+branch
That said, our instructions elsewhere, and for newbies in particular, are
different. I'm not sure what to do about that.
DL
-Original Message-
From: Donal Lafferty
Sent: 24 July 2013 11:04 AM
To: dev@cloudstack.apache.org
Subject: RE: [GSOC]cannot add host with the lastest master
Hi Chiradeep,
Before I explore further, can I ask where
StartupSecondaryStorageCommand mentioned in the defect
https://issues.apache.org/jira/browse/CLOUDSTACK-3377 gets used?
DL
-Original Message-
From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
Sent: 24 July 2013 6:01 AM
To: dev@cloudstack.apache.org
Subject: Re: [GSOC]cannot add host with the lastest master
Not sure what the vintage of the systemvm has to do with it. They do
not contain the agent (Java jar files) until the systemvm is created and
started.
When first started, the jar files are copied into the system vm.
On 7/24/13 3:41 AM, Donal Lafferty donal.laffe...@citrix.com wrote:
Hi Meng,
You may also be having problems with your system VM. Let me explain:
The issue you see is caused by a change in JSON serialisation that
happened in 4.2.
Previously, we recorded an object's type using it's class' simple name.
Now, we are using the full class name, which include the package. E.g.
the serializer used to write { StartupRoutingCommand : ... }, but
now it records
{com.cloud.agent.api.com.cloud.agent.api.StartupRoutingCommand:...}
A lot of code compile against 4.1 will not be able to communicate
with the latest management server.
This means you also have to update your system VM templates. If you
don't, you get an error like
https://issues.apache.org/jira/browse/CLOUDSTACK-3377
Unfortunately, the default download URLs for system VMs are for 4.1.
If you have not already, download the latest system VMs from
http://jenkins.cloudstack.org/view/master/job/build-systemvm-master/
Cheers,
DL
-Original Message-
From: Wido den Hollander [mailto:w...@widodh.nl]
Sent: 23 July 2013 9:27 PM
To: dev@cloudstack.apache.org
Subject: Re: [GSOC]cannot add host with the lastest master
Hi Meng,
On 07/23/2013 09:28 PM, Han,Meng wrote:
Hi Wei,
Thank you for your reply.
On Wed, 24 Jul 2013 02:08:36 +0800, Wei ZHOU wrote:
I suggest updating the agent on host as well
I run yum install cloudstack-agent on the kvm host, it told me
that it's already the latest version. I found the post
here:https://issues.apache.org/jira/browse/CLOUDSTACK-3118
Rajesh Battala mentioned that he installed the latest agent from
the build CloudStack-non-OSS-MASTER-499-rhel6.3.
This is what you run into:
https://issues.apache.org/jira/browse/CLOUDSTACK-3714
Do you know where can I get that build and how to start the agent
if I have the build(will service cloudstack-agent start do) ?
I didn't find the build in
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=summar
y
I see you use RHEL/CentOS, with the packaging script in
packaging/rhel you should be able to build RPM packages from master.
Wido
Any help is appreciated.
Cheers,
Meng
Re: Review Request 12858: CLOUDSTACK-3724: Test case test_vpc_vms_deployment.py failed to find network offering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12858/#review23749 --- Commit 2b8f1bde8f8e3c399baf44695c10866798e1fe45 in branch refs/heads/master from Prasanna Santhanam [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2b8f1bd ] CLOUDSTACK-3724: optimizing cleanup Signed-off-by: Prasanna Santhanam t...@apache.org (cherry picked from commit 8b7d00ee4de53d15a1d495c3c1fdd166b1651460) - ASF Subversion and Git Services On July 23, 2013, 2:53 p.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12858/ --- (Updated July 23, 2013, 2:53 p.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3724 Repository: cloudstack-git Description --- CLOUDSTACK-3724: Test case test_vpc_vms_deployment.py failed to find network offering. The test_script was broken because nw_off got appended twice for cleanup instead of nw_off_no_lb. Diffs - test/integration/component/test_vpc_vms_deployment.py c599d96 Diff: https://reviews.apache.org/r/12858/diff/ Testing --- Verified the marvin test locally on cloudstack setup. Thanks, Sanjay Tripathi
Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/#review23748 --- Commit b8a38ca7bd866db32dba644f8fc1be5d3406e16c in branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b8a38ca ] CLOUDSTACK-3594: Fix regression in Affinity Groups tests One of the patches introduced a regression where account and domainid parameters were changed. Therefore Affinity Groups for those accounts were not found and tests failed. Signed-off-by: Prasanna Santhanam t...@apache.org (cherry picked from commit 4a7f5d59d6f77fdeb5623937f4efa2542f891573) - ASF Subversion and Git Services On July 24, 2013, 10:51 a.m., Girish Shilamkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/ --- (Updated July 24, 2013, 10:51 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3594 Repository: cloudstack-git Description --- One of the patches introduced a regression where account and domainid parameters were changed. Therefore Affinity Groups for those accounts were not found and tests failed. Diffs - tools/marvin/marvin/integration/lib/base.py 6e49ae5 Diff: https://reviews.apache.org/r/12897/diff/ Testing --- Thanks, Girish Shilamkar
Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/#review23751 --- Commit 4a7f5d59d6f77fdeb5623937f4efa2542f891573 in branch refs/heads/4.2 from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4a7f5d5 ] CLOUDSTACK-3594: Fix regression in Affinity Groups tests One of the patches introduced a regression where account and domainid parameters were changed. Therefore Affinity Groups for those accounts were not found and tests failed. Signed-off-by: Prasanna Santhanam t...@apache.org - ASF Subversion and Git Services On July 24, 2013, 10:51 a.m., Girish Shilamkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/ --- (Updated July 24, 2013, 10:51 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3594 Repository: cloudstack-git Description --- One of the patches introduced a regression where account and domainid parameters were changed. Therefore Affinity Groups for those accounts were not found and tests failed. Diffs - tools/marvin/marvin/integration/lib/base.py 6e49ae5 Diff: https://reviews.apache.org/r/12897/diff/ Testing --- Thanks, Girish Shilamkar
Re: Review Request 12893: CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/#review23753 --- Commit 605a31eb70e8998b4476ffadf2514c969b83f7d7 in branch refs/heads/4.2 from Sanjay Tripathi [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=605a31e ] CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project. Signed-off-by: Prasanna Santhanam t...@apache.org - ASF Subversion and Git Services On July 24, 2013, 5 a.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/ --- (Updated July 24, 2013, 5 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3696 Repository: cloudstack-git Description --- CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project. Diffs - test/integration/component/test_project_limits.py 6e3f41d Diff: https://reviews.apache.org/r/12893/diff/ Testing --- Verified the marvin test locally on cloudstack setup. Thanks, Sanjay Tripathi
Re: Review Request 12858: CLOUDSTACK-3724: Test case test_vpc_vms_deployment.py failed to find network offering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12858/#review23752 --- Commit 74ac8575b09427c7511272bdd6592df092b55112 in branch refs/heads/4.2 from Prasanna Santhanam [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=74ac857 ] CLOUDSTACK-3724: optimizing cleanup Signed-off-by: Prasanna Santhanam t...@apache.org - ASF Subversion and Git Services On July 23, 2013, 2:53 p.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12858/ --- (Updated July 23, 2013, 2:53 p.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3724 Repository: cloudstack-git Description --- CLOUDSTACK-3724: Test case test_vpc_vms_deployment.py failed to find network offering. The test_script was broken because nw_off got appended twice for cleanup instead of nw_off_no_lb. Diffs - test/integration/component/test_vpc_vms_deployment.py c599d96 Diff: https://reviews.apache.org/r/12858/diff/ Testing --- Verified the marvin test locally on cloudstack setup. Thanks, Sanjay Tripathi
Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/#review23754 --- Review 12897 PASSED the build test The url of build cloudstack-master-with-patch #30 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/30/ - Jenkins Cloudstack.org On July 24, 2013, 10:51 a.m., Girish Shilamkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/ --- (Updated July 24, 2013, 10:51 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3594 Repository: cloudstack-git Description --- One of the patches introduced a regression where account and domainid parameters were changed. Therefore Affinity Groups for those accounts were not found and tests failed. Diffs - tools/marvin/marvin/integration/lib/base.py 6e49ae5 Diff: https://reviews.apache.org/r/12897/diff/ Testing --- Thanks, Girish Shilamkar
Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12809/ --- (Updated July 24, 2013, 11:43 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Bugs: CLOUDSTACK-3703 Repository: cloudstack-git Description --- CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing Diffs - server/src/com/cloud/vm/UserVmManagerImpl.java adcf475 server/test/com/cloud/vm/UserVmManagerTest.java 0eb9a08 Diff: https://reviews.apache.org/r/12809/diff/ Testing --- Thanks, Harikrishna Patnala
Review Request 12899: CLOUDSTACK-702: Tests for Multiple IP Ranges
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12899/ --- Review request for cloudstack, SrikanteswaraRao Talluri and Prasanna Santhanam. Repository: cloudstack-git Description --- 1.Removed advanced-sg tags from all the tests. At the movement tests only support basic zone. 2.Added a test to deploy guest vm after adding ip range in new CIDR Diffs - test/integration/component/test_multiple_ip_ranges.py 18409c5 Diff: https://reviews.apache.org/r/12899/diff/ Testing --- Yes. Tests on ACS 4.2 branch Thanks, sanjeev n
Re: [DESIGN] Why is enum a class...
Daan and Frank,
First, I think its important to separate when and where an enumeration should
be used from how to best employ enums when their use is appropriate. Enums are
a finite set of values defined at compile-time. Therefore, they shouldn't
employed in situations where extensibility of the value set is required whether
by clients (including plugins).
For plugins in particular, I think we should be preferring interfaces for all
extension points. To this end, our plugin model should be defining behavioral,
not data, extension points to reduce coupling between the orchestration
components and plugins. If we are running into situations where plugins can't
extend a data structure such as an enumeration, the root cause it likely that
we have too tightly coupled the plugin and should refine to a behavioral
extension point.
Thanks,
-John
On Jul 24, 2013, at 6:31 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:
Thanks Frank and John,
I've been strugling with the enums in Networks.java. A discussion on those
is needed I think. BroadcastDomainType seems to be a hybrid of a stable and
a plugin extendible enum. It breaks my mind and my every change.
regards,
Daan
On Tue, Jul 23, 2013 at 8:37 PM, Frank Zhang frank.zh...@citrix.com wrote:
Speaking of method on enum, I used to think it's very handy feature but
finally I failed on some scenarios and switched to own defined class.
The problem is enum is singleton that you can't save stateful data in it.
For example:
public enum Type {
private Object userData;
private Object getUserData() {...}
private void setUserData(Object data) {...}
Type SOME_TYPE;
}
This kind of thing is somewhat useless, userData here is actually global,
every call to SOME_TYPE.setUserData() would change its value.
So for usage perspective the methods you define on enmu are like static
method on class which has its limitations.
As for methods in enmu body in your example, the only usage I can recall
now is like what TimeUnit does. For CloudStack, we can do the similar
thing: SizeUnit that translates storage/memory size in different
quantities.
public enum SizeUnit {
BYTE {
public long toKiloByte(long s) {
return (s / (k / b));
}
public long toMegaByte(long s) {
return (s / (m / b));
}
public long toGigaByte(long s) {
return (s / (g / b));
}
public long toTeraByte(long s) {
return (s / (t / b));
}
},
KILOBYTE {
public long toByte(long s) {
return (s * (k / b));
}
public long toMegaByte(long s) {
return (s / (m / k));
}
public long toGigaByte(long s) {
return (s / (g / k));
}
public long toTeraByte(long s) {
return (s / (t / k));
}
},
MEGABYTE {
public long toByte(long s) {
return (s * (m / b));
}
public long toKiloByte(long s) {
return (s * (m / k));
}
public long toGigaByte(long s) {
return (s / (g / m));
}
public long toTeraByte(long s) {
return (s / (t / m));
}
},
GIGABYTE {
public long toByte(long s) {
return (s * (g / b));
}
public long toKiloByte(long s) {
return (s * (g / k));
}
public long toMegaByte(long s) {
return (s * (g / m));
}
public long toTeraByte(long s) {
return (s / (t / g));
}
},
TERABYTE {
public long toByte(long s) {
return (s * (t / b));
}
public long toKiloByte(long s) {
return (s * (t / k));
}
public long toMegaByte(long s) {
return (s * (t / m));
}
public long toGigaByte(long s) {
return (s * (t / g));
}
};
private static final long b = 1;
private static final long k = b * 1024;
private static final long m = k * 1024;
private static final long g = m * 1024;
private static final long t = g * 1024;
public long toByte(long s) {
throw new AbstractMethodError();
}
public long toKiloByte(long s) {
throw new AbstractMethodError();
}
public long toMegaByte(long s) {
throw new AbstractMethodError();
}
public long toGigaByte(long s) {
throw new AbstractMethodError();
}
public long toTeraByte(long s) {
throw new AbstractMethodError();
}
}
This may explain some of my views on java enum. It does have lots of
advantages like compiler check, native == operator. Just like
Alex mentioned, for constants that unlikely to change in future, we can
stick to enum. But for types that plugin may extend, we'd
better to use own defined classes.
From:
Re: Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/#review23756 --- Commit 2b9d9cf0360b22a703f27600292f22711f51c62f in branch refs/heads/master from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2b9d9cf ] CLOUDSTACK-3612: DB changes for template virtual size usage Conflicts: setup/db/db/schema-410to420.sql - ASF Subversion and Git Services On July 24, 2013, 10:53 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/ --- (Updated July 24, 2013, 10:53 a.m.) Review request for cloudstack, Alena Prokharchyk and Kishan Kavala. Bugs: 3612 Repository: cloudstack-git Description --- This fix is a part of missing db_upgrade bug 3612. Adding column virtual_size that will be a part of fix for CS-2508 Diffs - setup/db/db/schema-410to420.sql f9417a0 Diff: https://reviews.apache.org/r/12811/diff/ Testing --- Thanks, Saksham Srivastava
Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/#review23757 --- Commit 135a2e66c565044b6597e9178c3cf3d544712cca in branch refs/heads/master from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=135a2e6 ] CLOUDSTACK-2508: Template usage should report both physical and virtual sizes - ASF Subversion and Git Services On July 24, 2013, 6:30 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/ --- (Updated July 24, 2013, 6:30 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: 2508 Repository: cloudstack-git Description --- Usage entries for template and iso should include virtual_size parameter. Added new column to usage_event table which contains the virtual size. Modified the usage event creation when a template is created. Diffs - api/src/org/apache/cloudstack/api/response/UsageRecordResponse.java 4b355cb api/src/org/apache/cloudstack/usage/Usage.java c74d3b7 engine/schema/src/com/cloud/event/UsageEventVO.java c92972b engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 004ab7c engine/schema/src/com/cloud/usage/UsageStorageVO.java 1337edc engine/schema/src/com/cloud/usage/UsageVO.java 18a3a6b engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java 2237d56 engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java 297c8f4 server/src/com/cloud/api/ApiResponseHelper.java e058105 server/src/com/cloud/event/UsageEventUtils.java 2d92fae server/src/com/cloud/template/TemplateManagerImpl.java c87f8eb usage/src/com/cloud/usage/UsageManagerImpl.java 4901dd9 usage/src/com/cloud/usage/parser/StorageUsageParser.java 337e8e2 Diff: https://reviews.apache.org/r/12852/diff/ Testing --- Usage event generated for creating template with virtual size. Thanks, Saksham Srivastava
Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/#review23760 --- Ship it! commit d89115b5cff9013c917c8d2e984c596698389cfe - Kishan Kavala On July 24, 2013, noon, Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/ --- (Updated July 24, 2013, noon) Review request for cloudstack and Kishan Kavala. Bugs: 2508 Repository: cloudstack-git Description --- Usage entries for template and iso should include virtual_size parameter. Added new column to usage_event table which contains the virtual size. Modified the usage event creation when a template is created. Diffs - api/src/org/apache/cloudstack/api/response/UsageRecordResponse.java 4b355cb api/src/org/apache/cloudstack/usage/Usage.java c74d3b7 engine/schema/src/com/cloud/event/UsageEventVO.java c92972b engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 004ab7c engine/schema/src/com/cloud/usage/UsageStorageVO.java 1337edc engine/schema/src/com/cloud/usage/UsageVO.java 18a3a6b engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java 2237d56 engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java 297c8f4 server/src/com/cloud/api/ApiResponseHelper.java e058105 server/src/com/cloud/event/UsageEventUtils.java 2d92fae server/src/com/cloud/template/TemplateManagerImpl.java c87f8eb usage/src/com/cloud/usage/UsageManagerImpl.java 4901dd9 usage/src/com/cloud/usage/parser/StorageUsageParser.java 337e8e2 Diff: https://reviews.apache.org/r/12852/diff/ Testing --- Usage event generated for creating template with virtual size. Thanks, Saksham Srivastava
Re: Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/#review23758 --- Commit 743d35cae4985a8d898da06e5768ae282b32adb2 in branch refs/heads/4.2 from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=743d35c ] CLOUDSTACK-3612: DB changes for template virtual size usage - ASF Subversion and Git Services On July 24, 2013, 10:53 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/ --- (Updated July 24, 2013, 10:53 a.m.) Review request for cloudstack, Alena Prokharchyk and Kishan Kavala. Bugs: 3612 Repository: cloudstack-git Description --- This fix is a part of missing db_upgrade bug 3612. Adding column virtual_size that will be a part of fix for CS-2508 Diffs - setup/db/db/schema-410to420.sql f9417a0 Diff: https://reviews.apache.org/r/12811/diff/ Testing --- Thanks, Saksham Srivastava
Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/#review23759 --- Commit d89115b5cff9013c917c8d2e984c596698389cfe in branch refs/heads/4.2 from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d89115b ] CLOUDSTACK-2508: Template usage should report both physical and virtual sizes - ASF Subversion and Git Services On July 24, 2013, 6:30 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/ --- (Updated July 24, 2013, 6:30 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: 2508 Repository: cloudstack-git Description --- Usage entries for template and iso should include virtual_size parameter. Added new column to usage_event table which contains the virtual size. Modified the usage event creation when a template is created. Diffs - api/src/org/apache/cloudstack/api/response/UsageRecordResponse.java 4b355cb api/src/org/apache/cloudstack/usage/Usage.java c74d3b7 engine/schema/src/com/cloud/event/UsageEventVO.java c92972b engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 004ab7c engine/schema/src/com/cloud/usage/UsageStorageVO.java 1337edc engine/schema/src/com/cloud/usage/UsageVO.java 18a3a6b engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java 2237d56 engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java 297c8f4 server/src/com/cloud/api/ApiResponseHelper.java e058105 server/src/com/cloud/event/UsageEventUtils.java 2d92fae server/src/com/cloud/template/TemplateManagerImpl.java c87f8eb usage/src/com/cloud/usage/UsageManagerImpl.java 4901dd9 usage/src/com/cloud/usage/parser/StorageUsageParser.java 337e8e2 Diff: https://reviews.apache.org/r/12852/diff/ Testing --- Usage event generated for creating template with virtual size. Thanks, Saksham Srivastava
Re: Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/#review23761 --- Ship it! commit 743d35cae4985a8d898da06e5768ae282b32adb2 - Kishan Kavala On July 24, 2013, 4:23 p.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12811/ --- (Updated July 24, 2013, 4:23 p.m.) Review request for cloudstack, Alena Prokharchyk and Kishan Kavala. Bugs: 3612 Repository: cloudstack-git Description --- This fix is a part of missing db_upgrade bug 3612. Adding column virtual_size that will be a part of fix for CS-2508 Diffs - setup/db/db/schema-410to420.sql f9417a0 Diff: https://reviews.apache.org/r/12811/diff/ Testing --- Thanks, Saksham Srivastava
Re: Review Request 12898: CLOUDSTACK-3544: Xen 6.2 hosts are tagged with Xen 6.1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12898/#review23762 --- Review 12898 PASSED the build test The url of build cloudstack-master-with-patch #32 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/32/ - Jenkins Cloudstack.org On July 24, 2013, 12:10 p.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12898/ --- (Updated July 24, 2013, 12:10 p.m.) Review request for cloudstack, Abhinandan Prateek and Devdeep Singh. Bugs: CLOUDSTACK-3544 Repository: cloudstack-git Description --- CLOUDSTACK-3544: Xen 6.2 hosts are tagged with Xen 6.1. This commit will add the new xenserverresource file to support XenServer 6.2. Also add the guest OS list supported by xenserver 6.2 Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java bbb077c plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java c557631 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620Resource.java PRE-CREATION Diff: https://reviews.apache.org/r/12898/diff/ Testing --- Tests: 1. Setup a CS using Xenserver 6.2 host. 2. Deploy a user VM. Verified that userVM deployed successfully. Thanks, Sanjay Tripathi
Re: [DESIGN] Why is enum a class...
And as an example: the way the net should be isolated or the broadcast
should be constructed are typically behavioral issues, whilst the fact that
it is being used for storage or private network or routing can be caught in
a constant/enum value. right?
On Wed, Jul 24, 2013 at 2:37 PM, John Burwell jburw...@basho.com wrote:
Daan and Frank,
First, I think its important to separate when and where an enumeration
should be used from how to best employ enums when their use is appropriate.
Enums are a finite set of values defined at compile-time. Therefore, they
shouldn't employed in situations where extensibility of the value set is
required whether by clients (including plugins).
For plugins in particular, I think we should be preferring interfaces for
all extension points. To this end, our plugin model should be defining
behavioral, not data, extension points to reduce coupling between the
orchestration components and plugins. If we are running into situations
where plugins can't extend a data structure such as an enumeration, the
root cause it likely that we have too tightly coupled the plugin and should
refine to a behavioral extension point.
Thanks,
-John
On Jul 24, 2013, at 6:31 AM, Daan Hoogland daan.hoogl...@gmail.com
wrote:
Thanks Frank and John,
I've been strugling with the enums in Networks.java. A discussion on
those
is needed I think. BroadcastDomainType seems to be a hybrid of a stable
and
a plugin extendible enum. It breaks my mind and my every change.
regards,
Daan
On Tue, Jul 23, 2013 at 8:37 PM, Frank Zhang frank.zh...@citrix.com
wrote:
Speaking of method on enum, I used to think it's very handy feature but
finally I failed on some scenarios and switched to own defined class.
The problem is enum is singleton that you can't save stateful data in
it.
For example:
public enum Type {
private Object userData;
private Object getUserData() {...}
private void setUserData(Object data) {...}
Type SOME_TYPE;
}
This kind of thing is somewhat useless, userData here is actually
global,
every call to SOME_TYPE.setUserData() would change its value.
So for usage perspective the methods you define on enmu are like static
method on class which has its limitations.
As for methods in enmu body in your example, the only usage I can recall
now is like what TimeUnit does. For CloudStack, we can do the similar
thing: SizeUnit that translates storage/memory size in different
quantities.
public enum SizeUnit {
BYTE {
public long toKiloByte(long s) {
return (s / (k / b));
}
public long toMegaByte(long s) {
return (s / (m / b));
}
public long toGigaByte(long s) {
return (s / (g / b));
}
public long toTeraByte(long s) {
return (s / (t / b));
}
},
KILOBYTE {
public long toByte(long s) {
return (s * (k / b));
}
public long toMegaByte(long s) {
return (s / (m / k));
}
public long toGigaByte(long s) {
return (s / (g / k));
}
public long toTeraByte(long s) {
return (s / (t / k));
}
},
MEGABYTE {
public long toByte(long s) {
return (s * (m / b));
}
public long toKiloByte(long s) {
return (s * (m / k));
}
public long toGigaByte(long s) {
return (s / (g / m));
}
public long toTeraByte(long s) {
return (s / (t / m));
}
},
GIGABYTE {
public long toByte(long s) {
return (s * (g / b));
}
public long toKiloByte(long s) {
return (s * (g / k));
}
public long toMegaByte(long s) {
return (s * (g / m));
}
public long toTeraByte(long s) {
return (s / (t / g));
}
},
TERABYTE {
public long toByte(long s) {
return (s * (t / b));
}
public long toKiloByte(long s) {
return (s * (t / k));
}
public long toMegaByte(long s) {
return (s * (t / m));
}
public long toGigaByte(long s) {
return (s * (t / g));
}
};
private static final long b = 1;
private static final long k = b * 1024;
private static final long m = k * 1024;
private static final long g = m * 1024;
private static final long t = g * 1024;
public long toByte(long s) {
throw new AbstractMethodError();
}
public long toKiloByte(long s) {
throw new AbstractMethodError();
}
public long toMegaByte(long s) {
throw new AbstractMethodError();
}
public long toGigaByte(long s)
Re: Review Request 12896: General clean up of ldapplugin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/#review23763 --- Ship it! Ship It! - Abhinandan Prateek On July 24, 2013, 10:26 a.m., Ian Duffy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/ --- (Updated July 24, 2013, 10:26 a.m.) Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. Repository: cloudstack-git Description --- Cleans up LDAP plugin based on feedback from sonar. Diffs - plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapAddConfigurationCmd.java 62736b16087561a7e25893cd46115795100c609e plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapDeleteConfigurationCmd.java 329b91b plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java 087d156 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java 6707878 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapUserSearchCmd.java e6a40d0 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java d583346 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 40ba0ce plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java 2916202 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 8f31ce5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java d3ff820 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java 30bdc5b plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java be9b3d5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 54802cf plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUtils.java 453dc0a plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy 91c9baf plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy 8135901 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy 664fd64 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListConfigurationCmdSpec.groovy a7c1979 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy d72878b Diff: https://reviews.apache.org/r/12896/diff/ Testing --- Complied... passed unit tests. Passed integration tests. Thanks, Ian Duffy
Re: Review Request 12775: Migrate the dozens of ssh calls for KVM VmDataCommand to a single router command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12775/#review23764 --- Ship it! So it took me some time to get around reviewing this, but it seems fine to me. I patched a running 4.1 cluster with this and works like a charm. DHCP entries were loaded at the same rate, but the user metadata went a lot faster. - Wido den Hollander On July 19, 2013, 9:20 p.m., Marcus Sorensen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12775/ --- (Updated July 19, 2013, 9:20 p.m.) Review request for cloudstack, ilya musayev and Wido den Hollander. Bugs: cloudstack-3163 Repository: cloudstack-git Description --- Migrate the dozens of ssh calls for KVM VmDataCommand to a single router command. Diffs - core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 0b26220 patches/systemvm/debian/config/opt/cloud/bin/vmdata_kvm.py PRE-CREATION scripts/network/domr/vm_data.sh c861723 Diff: https://reviews.apache.org/r/12775/diff/ Testing --- Tested on 4.2 advanced zone, as well as a version against 4.1 (patch applies with fuzz) since that's what we happen to be using at the moment. Started VM, then ran 'curl http://10.1.1.1/latest/instance-id', then ran updateVirtualMachine, setting userdata, and pulled it on the guest via 'curl http://10.1.1.1/latest/user-data'. Thanks, Marcus Sorensen
RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs
Wei.
Yes, I recreated the systemvms by destroying them. I have no agents, if you
mean KVM/Xen agents, I'm running vSphere.
Regards
Ilya
-Original Message-
From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
Sent: Wednesday, July 24, 2013 2:37 AM
To: dev@cloudstack.apache.org
Subject: Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere
VMs
Ilya,
Did you upgrade agent and systemvm.iso on host ?
2013/7/24 Musayev, Ilya imusa...@webmd.net
Kelven
We are unable release ACS 4.1.1 as we have issues with CLOUDSTACK-
3433.
After several hours of testing, even after I redeploy CPVM, I still
see more errors in the logs (see below) and basic CPVM functionality is
broken.
I'm not certain what we fix with CLOUDSTACK-3433, but currently have
many more issues.
Would it be possible to revert this commit and work on adding this
commit into 4.1.2 instead?
We have to wrap up ACS 4.1.1 release tomorrow.
Thanks
ilya
2013-07-23 22:30:47,132 WARN [utils.nio.Task]
(AgentManager-Handler-10:null) Caught the following exception but
pushing on
com.google.gson.JsonParseException: The JsonDeserializer
com.cloud.agent.transport.ArrayTypeAdaptor@5ad2ee0f failed to
deserialize json object
[{StartupProxyCommand:{proxyPort:80,proxyVmId:260,type:Consol
eProxy,dataCenter:2,pod:2,guid:Proxy.260-ConsoleProxyResou
rce,name:v-260-CLOUD411,version:4.1.1-
SNAPSHOT,iqn:NoIqn,
publicIpAddress:172.24.20.22,publicNetmask:255.255.255.224,pu
blicMacAddress:06:2a:5e:00:00:29,privateIpAddress:172.24.20.25,
privateMacAddress:06:3f:9e:00:00:2b,privateNetmask:255.255.255.
224,storageIpAddress:172.24.20.25,storageNetmask:255.255.255.2
24,storageMacAddress:06:3f:9e:00:00:2b,resourceName:ConsolePro
xyResource,contextMap:{},wait:0}}]
given the type class [Lcom.cloud.agent.api.Command;
at
com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeserial
izerExceptionWrapper.java:64)
at
com.google.gson.JsonDeserializationVisitor.invokeCustomDeserializer(JsonD
eserializationVisitor.java:92)
at
com.google.gson.JsonDeserializationVisitor.visitUsingCustomHandler(JsonDe
serializationVisitor.java:80)
at com.google.gson.ObjectNavigator.accept(ObjectNavigator.java:101)
at
com.google.gson.JsonDeserializationContextDefault.fromJsonArray(JsonDes
erializationContextDefault.java:67)
at
com.google.gson.JsonDeserializationContextDefault.deserialize(JsonDeserial
izationContextDefault.java:52)
at com.google.gson.Gson.fromJson(Gson.java:551)
at com.google.gson.Gson.fromJson(Gson.java:498)
at
com.cloud.agent.transport.Request.getCommands(Request.java:235)
at
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.processReque
st(AgentManagerImpl.java:1221)
at
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.doTask(Agent
ManagerImpl.java:1374)
at
com.cloud.agent.manager.ClusteredAgentManagerImpl$ClusteredAgentHan
dler.doTask(ClusteredAgentManagerImpl.java:659)
at com.cloud.utils.nio.Task.run(Task.java:83)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.jav
a:1110)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.ja
va:603)
at java.lang.Thread.run(Thread.java:679)
Caused by: com.cloud.utils.exception.CloudRuntimeException: can't find
StartupProxyCommand
at
com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor
.java:75)
at
com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor
.java:36)
at
com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeserial
izerExceptionWrapper.java:51)
... 15 more
rather urgently (tomorrow), if we cannot get it fixed by then, lets
consider pushing this into 4.1.2
-Original Message-
From: Kelven Yang [mailto:kelven.y...@citrix.com]
Sent: Thursday, July 18, 2013 7:16 PM
To: Musayev, Ilya; dev@cloudstack.apache.org
Subject: Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to
VSphere VMs
Yes, CPVM has to be destroyed and be re-deployed so that updates can
be pushed over to make it work
Kelven
On 7/18/13 2:54 PM, Musayev, Ilya imusa...@webmd.net wrote:
When I say upgraded, I mean it needs to be trashed and redeployed.
-Original Message-
From: Musayev, Ilya [mailto:imusa...@webmd.net]
Sent: Thursday, July 18, 2013 5:46 PM
To: Kelven Yang; dev@cloudstack.apache.org
Subject: RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to
VSphere VMs
Kelven,
Perhaps I missed it,
Does CPVM needs to be upgraded from 4.1 to 4.1.1?
Thanks
ilya
-Original Message-
From: Kelven Yang [mailto:kelven.y...@citrix.com]
Sent: Thursday, July 18, 2013 5:25 PM
Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/#review23765 --- Ship it! Ship It! - Prasanna Santhanam On July 24, 2013, 10:51 a.m., Girish Shilamkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/ --- (Updated July 24, 2013, 10:51 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3594 Repository: cloudstack-git Description --- One of the patches introduced a regression where account and domainid parameters were changed. Therefore Affinity Groups for those accounts were not found and tests failed. Diffs - tools/marvin/marvin/integration/lib/base.py 6e49ae5 Diff: https://reviews.apache.org/r/12897/diff/ Testing --- Thanks, Girish Shilamkar
Re: Review Request 12874: Fix reboot failures with wait time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12874/#review23766 --- I think you forgot to attach the diff here. - Prasanna Santhanam On July 23, 2013, 5:20 p.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12874/ --- (Updated July 23, 2013, 5:20 p.m.) Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- Fix reboot failures with sleep time since Netscaler at times takes almost 60 - 90 seconds for identifying the service to be up after rebooting a VM. Diffs - Diff: https://reviews.apache.org/r/12874/diff/ Testing --- Tested locally and the script now passes Thanks, Sowmya Krishnan
Re: [rant] stupid test cases
On Tue, Jul 23, 2013 at 06:12:31PM +, Mathias Mullins wrote: Prasanna, If we broke these tests down into smaller test specific test cases, could we automate them into one specific end-to-end test together? I think this is called 'sequencing'. You have a bunch of individual operations and you put together different sets to form different scenarios. Is this what you mean? I.e. (And I'm over simplifying this for the sake of the e-mail) 1. Create Zone The zone configuration is entirely handled as a one time operation before a group of tests are run on it. So this operation is pre-performed. We have a cloud installed and we run tests on it. That's how this is organized. 2. Create Domain 3. Create Accounts 4. Create Users 5. Create Networks 6. Create VMs 7. Destroy VMs 8. Delete Users 9. Delete Accounts All these individual steps have a test associated with it. But they might be spread out in different 'suites'. 10. Delete Zone Each of these would have multiple steps and then would have a integration test where you could pick and choose the unit test cases to be ran together? I don't know the testing system well, but I know there are automated systems out there that have done this, so I'm asking what our systems can do. Yeah. I know that XenRT does this kind of testing. So - our framework has a library that aids putting togther unit-sized operations like the steps you listed out. But the number of combinations in which one can create an account/network/virtualmachine are myriad since the API takes a lot of parameters for various situations. So this kind of sequencing is absent at the moment. In regards to the test case I listed out below if you look at the individual steps in the test they don't look very different from the steps you listed out. So in that sense it is really stiching together such unit-sized operations. Matt On 7/23/13 1:26 PM, Ahmad Emneina aemne...@gmail.com wrote: In terms of integration tests, it could be broken up into smaller pieces, but as part of an overall 'networking functional' suite. Maybe we need to further divide the tests between functional tests and unit or integration tests. We really need to improve the testing around error handling and the lifecycle of a feature. For example network.gc does its job in cleaning up rules after a network has shut down. But when restarting a vm in said network, none of the previous rules get reinstated. That to me is brittle and needs to mature... sorry for the anti-rant :p On Tue, Jul 23, 2013 at 9:22 AM, Prasanna Santhanam t...@apache.org wrote: here's another one: def test_07_delete_network_with_rules(self): Test delete network that has PF/staticNat/LB rules/Network Acl # Validate the following # 1. Create a VPC with cidr - 10.1.1.1/16 # 2. Add network1(10.1.1.1/24) and network2(10.1.2.1/24) to this VPC. # 3. Deploy vm1 and vm2 in network1 and vm3 and vm4 in network2. # 4. Create a PF /Static Nat/LB rule for vms in network1. # 5. Create a PF /Static Nat/LB rule for vms in network2. # 6. Create ingress network ACL for allowing all the above rules from #public ip range on network1 and network2. # 7. Create egress network ACL for network1 and network2 to access #google.com. # 8. Create a private gateway for this VPC and add a static route to #this gateway # 9. Create a VPN gateway for this VPC and add a static route to this #gateway. # 10. Make sure that all the PF,LB, Static NAT rules work as expected # 11. Make sure that we are able to access google from all user Vms # 12. Make sure that the newly added private gateway's and VPN #gateway's static routes work as expected. # Steps: # 1. Delete the 1st network. # 2. Delete account # Validations: # 1. As part of network deletion all the resources attached with #network should get deleted. All other VMs and rules shall work as #expected # 2. All the resources associated with account should be deleted This is such a complicated test. I can see breaking it down into at least 5 tests. The point I'm trying to make here is simply this - When we don't have simple tests that make sure if ACLs are working correctly we shouldn't overindulge in this kind of testing. Bear in mind that testing that simple ACL ingress works correctly is also a system integration test. There's no reason why only unittests shold be the most condensed in form. if we had one test for ACL, one for VPC offerings, one for the VPN gw, one for the check whether ACLs are able to connect to an external service like 'google'. The tests can be much simpler to debug and much better indicators of failure This
Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs
Hi,
I reverted this commit in the 4.1 branch:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=a069f31f51d0ef1f255d85ef32d7649a5ec659c1
There has been no discussion about changing this API in the 4.1 series,
I even think we can't simply do that for 4.2 either.
You CAN'T break API compatibility in a minor release like 4.1.1.
Users rely on us to make stable releases, they don't want to be figuring
out why their perfectly working SSVM stops working during such a small
upgrade, same goes for their KVM agents.
Wido
On 07/24/2013 05:39 PM, Musayev, Ilya wrote:
Wei.
Yes, I recreated the systemvms by destroying them. I have no agents, if you
mean KVM/Xen agents, I'm running vSphere.
Regards
Ilya
-Original Message-
From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
Sent: Wednesday, July 24, 2013 2:37 AM
To: dev@cloudstack.apache.org
Subject: Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere
VMs
Ilya,
Did you upgrade agent and systemvm.iso on host ?
2013/7/24 Musayev, Ilya imusa...@webmd.net
Kelven
We are unable release ACS 4.1.1 as we have issues with CLOUDSTACK-
3433.
After several hours of testing, even after I redeploy CPVM, I still
see more errors in the logs (see below) and basic CPVM functionality is
broken.
I'm not certain what we fix with CLOUDSTACK-3433, but currently have
many more issues.
Would it be possible to revert this commit and work on adding this
commit into 4.1.2 instead?
We have to wrap up ACS 4.1.1 release tomorrow.
Thanks
ilya
2013-07-23 22:30:47,132 WARN [utils.nio.Task]
(AgentManager-Handler-10:null) Caught the following exception but
pushing on
com.google.gson.JsonParseException: The JsonDeserializer
com.cloud.agent.transport.ArrayTypeAdaptor@5ad2ee0f failed to
deserialize json object
[{StartupProxyCommand:{proxyPort:80,proxyVmId:260,type:Consol
eProxy,dataCenter:2,pod:2,guid:Proxy.260-ConsoleProxyResou
rce,name:v-260-CLOUD411,version:4.1.1-
SNAPSHOT,iqn:NoIqn,
publicIpAddress:172.24.20.22,publicNetmask:255.255.255.224,pu
blicMacAddress:06:2a:5e:00:00:29,privateIpAddress:172.24.20.25,
privateMacAddress:06:3f:9e:00:00:2b,privateNetmask:255.255.255.
224,storageIpAddress:172.24.20.25,storageNetmask:255.255.255.2
24,storageMacAddress:06:3f:9e:00:00:2b,resourceName:ConsolePro
xyResource,contextMap:{},wait:0}}]
given the type class [Lcom.cloud.agent.api.Command;
at
com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeserial
izerExceptionWrapper.java:64)
at
com.google.gson.JsonDeserializationVisitor.invokeCustomDeserializer(JsonD
eserializationVisitor.java:92)
at
com.google.gson.JsonDeserializationVisitor.visitUsingCustomHandler(JsonDe
serializationVisitor.java:80)
at com.google.gson.ObjectNavigator.accept(ObjectNavigator.java:101)
at
com.google.gson.JsonDeserializationContextDefault.fromJsonArray(JsonDes
erializationContextDefault.java:67)
at
com.google.gson.JsonDeserializationContextDefault.deserialize(JsonDeserial
izationContextDefault.java:52)
at com.google.gson.Gson.fromJson(Gson.java:551)
at com.google.gson.Gson.fromJson(Gson.java:498)
at
com.cloud.agent.transport.Request.getCommands(Request.java:235)
at
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.processReque
st(AgentManagerImpl.java:1221)
at
com.cloud.agent.manager.AgentManagerImpl$AgentHandler.doTask(Agent
ManagerImpl.java:1374)
at
com.cloud.agent.manager.ClusteredAgentManagerImpl$ClusteredAgentHan
dler.doTask(ClusteredAgentManagerImpl.java:659)
at com.cloud.utils.nio.Task.run(Task.java:83)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.jav
a:1110)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.ja
va:603)
at java.lang.Thread.run(Thread.java:679)
Caused by: com.cloud.utils.exception.CloudRuntimeException: can't find
StartupProxyCommand
at
com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor
.java:75)
at
com.cloud.agent.transport.ArrayTypeAdaptor.deserialize(ArrayTypeAdaptor
.java:36)
at
com.google.gson.JsonDeserializerExceptionWrapper.deserialize(JsonDeserial
izerExceptionWrapper.java:51)
... 15 more
rather urgently (tomorrow), if we cannot get it fixed by then, lets
consider pushing this into 4.1.2
-Original Message-
From: Kelven Yang [mailto:kelven.y...@citrix.com]
Sent: Thursday, July 18, 2013 7:16 PM
To: Musayev, Ilya; dev@cloudstack.apache.org
Subject: Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to
VSphere VMs
Yes, CPVM has to be destroyed and be re-deployed so that updates can
be pushed over to make it work
Kelven
On 7/18/13 2:54 PM, Musayev, Ilya imusa...@webmd.net wrote:
When I say upgraded, I mean it needs to be trashed and redeployed.
-Original Message-
From: Musayev, Ilya
Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)
Noah, Did you ever review / report / re-vote this? Thanks, Matt On 6/25/13 11:17 AM, Noah Slater nsla...@apache.org wrote: Thanks for the feedback, Matt. Anyone else got any feedback on this? Might cut a new vote. On 24 June 2013 05:12, Mathias Mullins mathias.mull...@citrix.com wrote: Noah, I agree that there needs to be a delineation. Here's my option on wording describing what is non-technical: +3.4.2. Non-Technical Decisions +Non-technical decisions should normally be made by the entire community using +discussion-lead consensus-building, and not through formal voting. + +Non-technical decisions are defined as a decision that do not directly affect +the code in any branch of the project. +Including coding, testing, documentation or management of the code base. + +Non-technical decisions can be made on whichever project mailing list is most +appropriate. + +Non-technical decisions cannot be vetoed, but if there is strong opposition +a formal vote can be used to resolve the dispute. + +If a formal vote is started for a non-technical decision, the vote will be held +as a lazy 2/3 majority of active committers. + +Any user, contributor, committer or PMC member can initiate a non-technical +decision making process. Matt Mullins Cloud Platforms Implementation Engineer Worldwide Cloud Services Citrix System, Inc. +1 (407) 920-1107 Office/Cell Phone matt.mull...@citrix.com On 6/20/13 11:59 AM, Noah Slater nsla...@apache.org wrote: Less terse follow up... ;) Note that our current by-laws effectively state that any technical decision needs to happen on dev@. I am just clarifying the intent. Note also that we currently do not define what a technical decision is, but it is my opinion that this is any decision which relates to the CloudStack source code. (We might want to make it a little broader than that. Open to suggestions.) Almost everything we do involves technology. Whether that is editing the website, wiki, JIRA, mailing lists, etc. That doesn't mean that those activities are technical activities or involve technical decisions. Do you think our by-laws need a section clarifying technical vs. non-technical? What should it say? On 20 June 2013 15:14, Joe Brockmeier j...@zonker.net wrote: On Thu, Jun 20, 2013, at 08:21 AM, Noah Slater wrote: Devs, I would like to call a vote on the following modification to our by-laws. This is in response to the Summary of changes: * Addition of 3.4.2. Non-Technical Decisions section. This specifies that non-technical decisions can be made on any appropriate list (i.e. marketing@) Erm. Does this mean that marketing can't make any technical decisions about the Web site, for instance? I think this needs to be better worded. Best, jzb -- Joe Brockmeier j...@zonker.net Twitter: @jzb http://www.dissociatedpress.net/ -- NS -- NS
Re: Review Request 12853: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12853/#review23771
---
There is no bug in current Java code, and the java part of this review ticket
shouldn't be checked in.
In the method cleanupDomain(), we try to remove every account before checking
if accounts marked for cleanup, exist.
// delete users which will also delete accounts and release resources for
those accounts
SearchCriteriaAccountVO sc = _accountDao.createSearchCriteria();
sc.addAnd(domainId, SearchCriteria.Op.EQ, domainId);
ListAccountVO accounts = _accountDao.search(sc, null);
for (AccountVO account : accounts) {
if (account.getType() != Account.ACCOUNT_TYPE_PROJECT) {
s_logger.debug(Deleting account + account + as a part of
domain id= + domainId + cleanup);
boolean deleteAccount = _accountMgr.deleteAccount(account,
UserContext.current().getCallerUserId(), UserContext.current().getCaller());
if (!deleteAccount) {
s_logger.warn(Failed to cleanup account id= +
account.getId() + as a part of domain cleanup);
}
Only after that we verify if there are accounts left. And only if the code
above failed, the code below returns non-empty list:
// don't remove the domain if there are accounts required cleanup
boolean deleteDomainSuccess = true;
ListAccountVO accountsForCleanup =
_accountDao.findCleanupsForRemovedAccounts(domainId);
So it works as expected.
- Alena Prokharchyk
On July 23, 2013, 12:34 p.m., Sanjay Tripathi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12853/
---
(Updated July 23, 2013, 12:34 p.m.)
Review request for cloudstack, Alena Prokharchyk, Devdeep Singh, and Prasanna
Santhanam.
Bugs: CLOUDSTACK-3688
Repository: cloudstack-git
Description
---
CLOUDSTACK-3688: Test cases
test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the
domain to delete and failed.
This issue is in CS product and not in the test_script.
The problem is coming because in case of deleteDomain with cleanup = true,
CS is not allowing deletion of domain if there are any account under that
domain needs clean up; though these accounts are removed and admin can't
see them in the listaccounts.
So CS should not restrict the deleteDomain in case of accounts needs
cleanup.
Diffs
-
server/src/com/cloud/user/DomainManagerImpl.java 1117ff0
test/integration/component/test_accounts.py 3c284bd
Diff: https://reviews.apache.org/r/12853/diff/
Testing
---
Verified marvin test on my local cloudstack setup.
Thanks,
Sanjay Tripathi
RE: Review Request 12874: Fix reboot failures with wait time
RB doesn’t accept the patch. Keeps failing. Here's the patch: From 02238e6903d3d399d402886513efd6cd2664696a Mon Sep 17 00:00:00 2001 From: Sowmya Krishnan sowmya.krish...@citrix.com Date: Tue, 23 Jul 2013 22:29:10 +0530 Subject: [PATCH] Add wait while Netscaler recognizes service to be up --- test/integration/component/test_netscaler_lb.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/test/integration/component/test_netscaler_lb.py b/test/integration/component/test_netscaler_lb.py index cd85659..d93a262 100644 --- a/test/integration/component/test_netscaler_lb.py +++ b/test/integration/component/test_netscaler_lb.py @@ -2772,6 +2772,8 @@ class TestVmWithLb(cloudstackTestCase): self.debug(Rebooting VM instance: %s % self.vm_2.name) self.vm_2.reboot(self.apiclient) self.debug(Rebooting VM: %s % self.vm_2.name) +self.debug(Waiting for Netscaler to get the service up) +time.sleep( 120 ) try: self.debug( -- 1.7.5.4 -Original Message- From: Prasanna Santhanam [mailto:nore...@reviews.apache.org] On Behalf Of Prasanna Santhanam Sent: Wednesday, July 24, 2013 9:56 PM To: Prasanna Santhanam Cc: cloudstack; Sowmya Krishnan Subject: Re: Review Request 12874: Fix reboot failures with wait time --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12874/#review23766 --- I think you forgot to attach the diff here. - Prasanna Santhanam On July 23, 2013, 5:20 p.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12874/ --- (Updated July 23, 2013, 5:20 p.m.) Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- Fix reboot failures with sleep time since Netscaler at times takes almost 60 - 90 seconds for identifying the service to be up after rebooting a VM. Diffs - Diff: https://reviews.apache.org/r/12874/diff/ Testing --- Tested locally and the script now passes Thanks, Sowmya Krishnan
Re: Review Request 12893: CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/ --- (Updated July 24, 2013, 5:12 p.m.) Review request for cloudstack and Prasanna Santhanam. Changes --- Updated patch, tested locally on cloudstack setup. Bugs: CLOUDSTACK-3696 Repository: cloudstack-git Description --- CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project. Diffs (updated) - test/integration/component/test_project_limits.py 6e3f41d Diff: https://reviews.apache.org/r/12893/diff/ Testing --- Verified the marvin test locally on cloudstack setup. Thanks, Sanjay Tripathi
Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs
Yes, definitely shouldn't be a 4.1.x change. I don't think we want people
to have to go through major pains on a minor point release unless there's
some major showstopper bug.
4.2, I don't know. I was always under the impression that going from 4.x to
4.y WAS a major release, per the versioning standards we have adopted. The
entire guts of cloudstack could change (see javelin), requiring system VM
upgrades (also required in the past and planned as a requirement for 4.2),
and as long as it doesn't break the user-facing api compatibility it would
remain the same major release number.
On Jul 24, 2013 10:57 AM, Wido den Hollander w...@widodh.nl wrote:
Hi,
I reverted this commit in the 4.1 branch: https://git-wip-us.apache.org/**
repos/asf?p=cloudstack.git;a=**commitdiff;h=**
a069f31f51d0ef1f255d85ef32d764**9a5ec659c1https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=a069f31f51d0ef1f255d85ef32d7649a5ec659c1
There has been no discussion about changing this API in the 4.1 series, I
even think we can't simply do that for 4.2 either.
You CAN'T break API compatibility in a minor release like 4.1.1.
Users rely on us to make stable releases, they don't want to be figuring
out why their perfectly working SSVM stops working during such a small
upgrade, same goes for their KVM agents.
Wido
On 07/24/2013 05:39 PM, Musayev, Ilya wrote:
Wei.
Yes, I recreated the systemvms by destroying them. I have no agents, if
you mean KVM/Xen agents, I'm running vSphere.
Regards
Ilya
-Original Message-
From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
Sent: Wednesday, July 24, 2013 2:37 AM
To: dev@cloudstack.apache.org
Subject: Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere
VMs
Ilya,
Did you upgrade agent and systemvm.iso on host ?
2013/7/24 Musayev, Ilya imusa...@webmd.net
Kelven
We are unable release ACS 4.1.1 as we have issues with CLOUDSTACK-
3433.
After several hours of testing, even after I redeploy CPVM, I still
see more errors in the logs (see below) and basic CPVM functionality is
broken.
I'm not certain what we fix with CLOUDSTACK-3433, but currently have
many more issues.
Would it be possible to revert this commit and work on adding this
commit into 4.1.2 instead?
We have to wrap up ACS 4.1.1 release tomorrow.
Thanks
ilya
2013-07-23 22:30:47,132 WARN [utils.nio.Task]
(AgentManager-Handler-10:null) Caught the following exception but
pushing on
com.google.gson.**JsonParseException: The JsonDeserializer
com.cloud.agent.transport.**ArrayTypeAdaptor@5ad2ee0f failed to
deserialize json object
[{StartupProxyCommand:{**proxyPort:80,proxyVmId:260,**
type:Consol
eProxy,dataCenter:2,pod**:2,guid:Proxy.260-**
ConsoleProxyResou
rce,name:v-260-CLOUD411,**version:4.1.1-
SNAPSHOT,iqn:NoIqn,
publicIpAddress:172.24.20.**22,publicNetmask:255.255.**
255.224,pu
blicMacAddress:06:2a:5e:00:**00:29,privateIpAddress:**
172.24.20.25,
privateMacAddress:06:3f:9e:**00:00:2b,privateNetmask:**
255.255.255.
224,storageIpAddress:172.**24.20.25,storageNetmask:**
255.255.255.2
24,storageMacAddress:06:**3f:9e:00:00:2b,resourceName**
:ConsolePro
xyResource,contextMap:{},**wait:0}}]
given the type class [Lcom.cloud.agent.api.Command;
at
com.google.gson.**JsonDeserializerExceptionWrapp**
er.deserialize(JsonDeserial
izerExceptionWrapper.java:64)
at
com.google.gson.**JsonDeserializationVisitor.**
invokeCustomDeserializer(JsonD
eserializationVisitor.java:92)
at
com.google.gson.**JsonDeserializationVisitor.**
visitUsingCustomHandler(JsonDe
serializationVisitor.java:80)
at com.google.gson.**ObjectNavigator.accept(**
ObjectNavigator.java:101)
at
com.google.gson.**JsonDeserializationContextDefa**
ult.fromJsonArray(JsonDes
erializationContextDefault.**java:67)
at
com.google.gson.**JsonDeserializationContextDefa**
ult.deserialize(JsonDeserial
izationContextDefault.java:52)
at com.google.gson.Gson.fromJson(**Gson.java:551)
at com.google.gson.Gson.fromJson(**Gson.java:498)
at
com.cloud.agent.transport.**Request.getCommands(Request.**java:235)
at
com.cloud.agent.manager.**AgentManagerImpl$AgentHandler.**processReque
st(AgentManagerImpl.java:1221)
at
com.cloud.agent.manager.**AgentManagerImpl$AgentHandler.**doTask(Agent
ManagerImpl.java:1374)
at
com.cloud.agent.manager.**ClusteredAgentManagerImpl$**
ClusteredAgentHan
dler.doTask(**ClusteredAgentManagerImpl.**java:659)
at com.cloud.utils.nio.Task.run(**Task.java:83)
at
java.util.concurrent.**ThreadPoolExecutor.runWorker(**
ThreadPoolExecutor.jav
a:1110)
at
java.util.concurrent.**ThreadPoolExecutor$Worker.run(**
ThreadPoolExecutor.ja
va:603)
at java.lang.Thread.run(Thread.**java:679)
Caused by: com.cloud.utils.exception.**CloudRuntimeException: can't
find
RE: [GSOC]cannot add host with the lastest master
Thank you all guys! If I am understanding this correctly, using mvn clean install -P developer,systemvm will build the latest management server and systemvm code. This latest management server is using fully qualified class name which requires the latest agent and system vm template to work well with it. About the latest systemvm template, I should use cloud-install-sys-tmplt with the latest template link (http://jenkins.cloudstack.org/view/master/job/build-systemvm-master/) to get the template installed. About the latest agent, I should use the packaging.sh scripts inside packaging directory to get the latest agent rpm. After I got this rpm, I can use yum install to install the latest agent. After the above two steps I will be able to add the host to Cloudstack. Is this right? Also in cloud.spec file (packaging/centos63/cloud.spec) the build command used is rpmbuild mvn -Pawsapi,systemvm clean install, do I need to modify it to mvn -Pdevelper,systemvm clean install? When I build the rpm packages using ./packaging.sh, I get the following error: [INFO] Apache CloudStack AWS API Bridge .. FAILURE [6.581s] [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 5:29.190s [INFO] Finished at: Wed Jul 24 13:09:56 EDT 2013 [INFO] Final Memory: 60M/337M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-awsapi: Compilation failure: Compilation failure: [ERROR] error: error reading /root/.m2/repository/org/apache/axis2/mex/1.5.4/mex-1.5.4-impl.jar; error in opening zip file [ERROR] error: error reading /root/.m2/repository/org/apache/axis2/axis2-mtompolicy/1.5.4/axis2-mtompolicy-1.5.4.jar; error in opening zip file [ERROR] error: error reading /root/.m2/repository/org/apache/ws/commons/axiom/axiom-dom/1.2.10/axiom-dom-1.2.10.jar; error in opening zip file [ERROR] error: error reading /root/.m2/repository/org/opensaml/opensaml1/1.1/opensaml1-1.1.jar; error in opening zip file [ERROR] - [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cloud-awsapi: Compilation failure at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:318) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:153) at org.apache.maven.cli.MavenCli.execute(MavenCli.java:555) at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:214) at org.apache.maven.cli.MavenCli.main(MavenCli.java:158) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:414) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:357) Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation failure at org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:729) at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:128) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 19 more [ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn
Re: Review Request 12853: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.
On July 24, 2013, 5:02 p.m., Alena Prokharchyk wrote:
There is no bug in current Java code, and the java part of this review
ticket shouldn't be checked in.
In the method cleanupDomain(), we try to remove every account before
checking if accounts marked for cleanup, exist.
// delete users which will also delete accounts and release resources for
those accounts
SearchCriteriaAccountVO sc = _accountDao.createSearchCriteria();
sc.addAnd(domainId, SearchCriteria.Op.EQ, domainId);
ListAccountVO accounts = _accountDao.search(sc, null);
for (AccountVO account : accounts) {
if (account.getType() != Account.ACCOUNT_TYPE_PROJECT) {
s_logger.debug(Deleting account + account + as a part
of domain id= + domainId + cleanup);
boolean deleteAccount = _accountMgr.deleteAccount(account,
UserContext.current().getCallerUserId(), UserContext.current().getCaller());
if (!deleteAccount) {
s_logger.warn(Failed to cleanup account id= +
account.getId() + as a part of domain cleanup);
}
Only after that we verify if there are accounts left. And only if the code
above failed, the code below returns non-empty list:
// don't remove the domain if there are accounts required cleanup
boolean deleteDomainSuccess = true;
ListAccountVO accountsForCleanup =
_accountDao.findCleanupsForRemovedAccounts(domainId);
So it works as expected.
But the accounts which are marked as cleanup=true are set as removed and admin
can't list them by using API call. So, the only thing admin can see is the
domain without any accounts. Please clarify if that makes sense.
- Sanjay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12853/#review23771
---
On July 23, 2013, 12:34 p.m., Sanjay Tripathi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12853/
---
(Updated July 23, 2013, 12:34 p.m.)
Review request for cloudstack, Alena Prokharchyk, Devdeep Singh, and Prasanna
Santhanam.
Bugs: CLOUDSTACK-3688
Repository: cloudstack-git
Description
---
CLOUDSTACK-3688: Test cases
test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the
domain to delete and failed.
This issue is in CS product and not in the test_script.
The problem is coming because in case of deleteDomain with cleanup = true,
CS is not allowing deletion of domain if there are any account under that
domain needs clean up; though these accounts are removed and admin can't
see them in the listaccounts.
So CS should not restrict the deleteDomain in case of accounts needs
cleanup.
Diffs
-
server/src/com/cloud/user/DomainManagerImpl.java 1117ff0
test/integration/component/test_accounts.py 3c284bd
Diff: https://reviews.apache.org/r/12853/diff/
Testing
---
Verified marvin test on my local cloudstack setup.
Thanks,
Sanjay Tripathi
Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)
Nope. Sorry. Feel free to run with it. If not, I can see about doing another vote in the next few days. On 24 July 2013 18:02, Mathias Mullins mathias.mull...@citrix.com wrote: Noah, Did you ever review / report / re-vote this? Thanks, Matt On 6/25/13 11:17 AM, Noah Slater nsla...@apache.org wrote: Thanks for the feedback, Matt. Anyone else got any feedback on this? Might cut a new vote. On 24 June 2013 05:12, Mathias Mullins mathias.mull...@citrix.com wrote: Noah, I agree that there needs to be a delineation. Here's my option on wording describing what is non-technical: +3.4.2. Non-Technical Decisions +Non-technical decisions should normally be made by the entire community using +discussion-lead consensus-building, and not through formal voting. + +Non-technical decisions are defined as a decision that do not directly affect +the code in any branch of the project. +Including coding, testing, documentation or management of the code base. + +Non-technical decisions can be made on whichever project mailing list is most +appropriate. + +Non-technical decisions cannot be vetoed, but if there is strong opposition +a formal vote can be used to resolve the dispute. + +If a formal vote is started for a non-technical decision, the vote will be held +as a lazy 2/3 majority of active committers. + +Any user, contributor, committer or PMC member can initiate a non-technical +decision making process. Matt Mullins Cloud Platforms Implementation Engineer Worldwide Cloud Services Citrix System, Inc. +1 (407) 920-1107 Office/Cell Phone matt.mull...@citrix.com On 6/20/13 11:59 AM, Noah Slater nsla...@apache.org wrote: Less terse follow up... ;) Note that our current by-laws effectively state that any technical decision needs to happen on dev@. I am just clarifying the intent. Note also that we currently do not define what a technical decision is, but it is my opinion that this is any decision which relates to the CloudStack source code. (We might want to make it a little broader than that. Open to suggestions.) Almost everything we do involves technology. Whether that is editing the website, wiki, JIRA, mailing lists, etc. That doesn't mean that those activities are technical activities or involve technical decisions. Do you think our by-laws need a section clarifying technical vs. non-technical? What should it say? On 20 June 2013 15:14, Joe Brockmeier j...@zonker.net wrote: On Thu, Jun 20, 2013, at 08:21 AM, Noah Slater wrote: Devs, I would like to call a vote on the following modification to our by-laws. This is in response to the Summary of changes: * Addition of 3.4.2. Non-Technical Decisions section. This specifies that non-technical decisions can be made on any appropriate list (i.e. marketing@) Erm. Does this mean that marketing can't make any technical decisions about the Web site, for instance? I think this needs to be better worded. Best, jzb -- Joe Brockmeier j...@zonker.net Twitter: @jzb http://www.dissociatedpress.net/ -- NS -- NS -- NS
RE: Inclusion of commons-httpclient-contrib jar
You can look at the code yourself and see if it's any different than what we copied. http://grepcode.com/file/repo1.maven.org/maven2/org.kuali.rice/rice-impl/1.0.3.1-BX/org/apache/commons/httpclient/contrib/ssl/EasySSLProtocolSocketFactory.java --Alex -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Wednesday, July 24, 2013 10:17 AM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : Warning: not-yet-commons-ssl-0.3.11 should be considered to be of Alpha quality! I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should go ahead with it. Thanks, Amogh On 7/23/13 10:51 PM, Alex Huang alex.hu...@citrix.com wrote: Amogh, I added the following to the pom.xml for cisco and it seems to compile with a few extra exceptions try-catch added. Can you check on if you can use this? dependency groupIdca.juliusdavies/groupId artifactIdnot-yet-commons-ssl/artifactId version0.3.11/version /dependency --Alx -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in commons-httpclient 3.1? http://grepcode.com/file/repo1.maven.org/maven2/commons- httpclient/commons- httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/EasyX509Trus tM anager.java --Alex -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:41 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar +1 @Frank, it is not a re-implementation, but a copy. On 7/24/13 2:14 AM, Amogh Vasekar amogh.vase...@citrix.com wrote: In the absence of an officially published jar on maven for contrib-ssl, the current idea is to put this package in cloud-utils (it is a dependency for both cisco-vnmc and ucs) for easier maintenance. Please let me know if this sounds good. Thanks, Amogh On 7/22/13 5:26 PM, Frank Zhang frank.zh...@citrix.com wrote: I prefer to just use httpclient-contribs.jar as it has been proven by lots of users. Reimplementing such code brings no gain but maintenance effort. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Monday, July 22, 2013 5:17 PM To: dev@cloudstack.apache.org Subject: Inclusion of commons-httpclient-contrib jar Hi All, I was working on a HTTPS related fix, and found this package in the codebase : https://github.com/apache/cloudstack/tree/master/plugins/networ k- elements/c isco-vnmc/src/org/apache/commons/httpclient/contrib/ssl I need to use the same classes, which are already a part of httpclient-contribs jar (http://www.java2s.com/Code/Jar/c/Downloadcommonshttpclient con tr ib31jar. htm ) Was wondering if there is a specific reason the jar was not included instead (probably since it is a contrib jar?) Thanks, Amogh
RE: Inclusion of commons-httpclient-contrib jar
It's only two files and they were not that huge if I recall correctly from my quick glance. --Alex -Original Message- From: Alex Huang Sent: Wednesday, July 24, 2013 10:22 AM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar You can look at the code yourself and see if it's any different than what we copied. http://grepcode.com/file/repo1.maven.org/maven2/org.kuali.rice/rice- impl/1.0.3.1- BX/org/apache/commons/httpclient/contrib/ssl/EasySSLProtocolSocketFact ory.java --Alex -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Wednesday, July 24, 2013 10:17 AM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : Warning: not-yet-commons-ssl-0.3.11 should be considered to be of Alpha quality! I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should go ahead with it. Thanks, Amogh On 7/23/13 10:51 PM, Alex Huang alex.hu...@citrix.com wrote: Amogh, I added the following to the pom.xml for cisco and it seems to compile with a few extra exceptions try-catch added. Can you check on if you can use this? dependency groupIdca.juliusdavies/groupId artifactIdnot-yet-commons-ssl/artifactId version0.3.11/version /dependency --Alx -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in commons-httpclient 3.1? http://grepcode.com/file/repo1.maven.org/maven2/commons- httpclient/commons- httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/EasyX509Tr us tM anager.java --Alex -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:41 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar +1 @Frank, it is not a re-implementation, but a copy. On 7/24/13 2:14 AM, Amogh Vasekar amogh.vase...@citrix.com wrote: In the absence of an officially published jar on maven for contrib-ssl, the current idea is to put this package in cloud-utils (it is a dependency for both cisco-vnmc and ucs) for easier maintenance. Please let me know if this sounds good. Thanks, Amogh On 7/22/13 5:26 PM, Frank Zhang frank.zh...@citrix.com wrote: I prefer to just use httpclient-contribs.jar as it has been proven by lots of users. Reimplementing such code brings no gain but maintenance effort. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Monday, July 22, 2013 5:17 PM To: dev@cloudstack.apache.org Subject: Inclusion of commons-httpclient-contrib jar Hi All, I was working on a HTTPS related fix, and found this package in the codebase : https://github.com/apache/cloudstack/tree/master/plugins/networ k- elements/c isco-vnmc/src/org/apache/commons/httpclient/contrib/ssl I need to use the same classes, which are already a part of httpclient-contribs jar (http://www.java2s.com/Code/Jar/c/Downloadcommonshttpclie nt con tr ib31jar. htm ) Was wondering if there is a specific reason the jar was not included instead (probably since it is a contrib jar?) Thanks, Amogh
RE: Inclusion of commons-httpclient-contrib jar
For now I think cloud-utils is the best option. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Wednesday, July 24, 2013 10:48 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : Warning: not-yet-commons-ssl-0.3.11 should be considered to be of Alpha quality! I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should go ahead with it. Thanks, Amogh On 7/23/13 10:51 PM, Alex Huang alex.hu...@citrix.com wrote: Amogh, I added the following to the pom.xml for cisco and it seems to compile with a few extra exceptions try-catch added. Can you check on if you can use this? dependency groupIdca.juliusdavies/groupId artifactIdnot-yet-commons-ssl/artifactId version0.3.11/version /dependency --Alx -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in commons-httpclient 3.1? http://grepcode.com/file/repo1.maven.org/maven2/commons- httpclient/commons- httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/EasyX509Trus tM anager.java --Alex -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:41 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar +1 @Frank, it is not a re-implementation, but a copy. On 7/24/13 2:14 AM, Amogh Vasekar amogh.vase...@citrix.com wrote: In the absence of an officially published jar on maven for contrib-ssl, the current idea is to put this package in cloud-utils (it is a dependency for both cisco-vnmc and ucs) for easier maintenance. Please let me know if this sounds good. Thanks, Amogh On 7/22/13 5:26 PM, Frank Zhang frank.zh...@citrix.com wrote: I prefer to just use httpclient-contribs.jar as it has been proven by lots of users. Reimplementing such code brings no gain but maintenance effort. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Monday, July 22, 2013 5:17 PM To: dev@cloudstack.apache.org Subject: Inclusion of commons-httpclient-contrib jar Hi All, I was working on a HTTPS related fix, and found this package in the codebase : https://github.com/apache/cloudstack/tree/master/plugins/networ k- elements/c isco-vnmc/src/org/apache/commons/httpclient/contrib/ssl I need to use the same classes, which are already a part of httpclient-contribs jar (http://www.java2s.com/Code/Jar/c/Downloadcommonshttpclientcon tr ib31jar. htm ) Was wondering if there is a specific reason the jar was not included instead (probably since it is a contrib jar?) Thanks, Amogh
Re: Inclusion of commons-httpclient-contrib jar
Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : Warning: not-yet-commons-ssl-0.3.11 should be considered to be of Alpha quality! I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should go ahead with it. Thanks, Amogh On 7/23/13 10:51 PM, Alex Huang alex.hu...@citrix.com wrote: Amogh, I added the following to the pom.xml for cisco and it seems to compile with a few extra exceptions try-catch added. Can you check on if you can use this? dependency groupIdca.juliusdavies/groupId artifactIdnot-yet-commons-ssl/artifactId version0.3.11/version /dependency --Alx -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in commons-httpclient 3.1? http://grepcode.com/file/repo1.maven.org/maven2/commons- httpclient/commons- httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/EasyX509TrustM anager.java --Alex -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:41 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar +1 @Frank, it is not a re-implementation, but a copy. On 7/24/13 2:14 AM, Amogh Vasekar amogh.vase...@citrix.com wrote: In the absence of an officially published jar on maven for contrib-ssl, the current idea is to put this package in cloud-utils (it is a dependency for both cisco-vnmc and ucs) for easier maintenance. Please let me know if this sounds good. Thanks, Amogh On 7/22/13 5:26 PM, Frank Zhang frank.zh...@citrix.com wrote: I prefer to just use httpclient-contribs.jar as it has been proven by lots of users. Reimplementing such code brings no gain but maintenance effort. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Monday, July 22, 2013 5:17 PM To: dev@cloudstack.apache.org Subject: Inclusion of commons-httpclient-contrib jar Hi All, I was working on a HTTPS related fix, and found this package in the codebase : https://github.com/apache/cloudstack/tree/master/plugins/network- elements/c isco-vnmc/src/org/apache/commons/httpclient/contrib/ssl I need to use the same classes, which are already a part of httpclient-contribs jar (http://www.java2s.com/Code/Jar/c/Downloadcommonshttpclientcon tr ib31jar. htm ) Was wondering if there is a specific reason the jar was not included instead (probably since it is a contrib jar?) Thanks, Amogh
Re: [DISCUSS] Bylaw changes for new committer / new PMC member votes
So I'm not even a committer yet, but this is an idea on how I think I would want to be voted in. For Committer - 2/3 Lazy This makes sure that at least 2 people basically nominated, and seconded and the votes were 2:1 in favor of the person coming in. For PMC - 3/4 Lazy This is the leadership of the project and there needs to be a true consensus and not just a majority to bring someone in. This allows for a higher consensus to be reached. For Chairman (I think you guys missed this one, maybe it was applied) - 3/4 Lazy with no -1 Binding Veto The PMC has to be in Consensus and there can't really be a major dissent in my thought process. Veto also requires a through explanation why. 2 cents, Matt On 7/19/13 1:27 PM, Noah Slater nsla...@apache.org wrote: Specifically, Chip is calling for us to change committer / PMC votes from lazy consensus to 2/3 majority. (That is, the vote type for that specific decision making process changes, but the vote type definitions are left alone.) On 19 July 2013 17:32, Chip Childers chip.child...@sungard.com wrote: On Fri, Jul 19, 2013 at 04:29:07PM +, Chiradeep Vittal wrote: There's several places in the by laws that call for Lazy Consensus. Are we discussing modifying all of them or just new committer votes? New committer and PMC membership. sorry, I think the email could be more clear. This is per the $subject: new committer / new PMC member votes only. On 7/19/13 9:02 PM, Chip Childers chip.child...@sungard.com wrote: As it stands now, we currently use a Lazy Consensus model (yes Noah, I know we didn't define that term correctly as of now, but I think that's a different discussion). We currently have that term defined as: Lazy Consensus - Lazy consensus requires 3 binding +1 votes and no binding -1 votes. I'd like to propose that we change the PMC and committer voting rule to use the Lazy 2/3 Majority approach defined as: Lazy 2/3 majority votes requires at least 3 binding votes and twice as many binding +1 votes as binding -1 votes. Are there any objections to me starting a VOTE on this change? -- NS
Re: [VOTE] Update by-laws to add section for non-technical decision making (Was: Re: [RESULTS][SUMMARY][DISCUSS][VOTE] List CloudStack related books on the website)
I'm not a committer so I don't want really to take this one on the Bylaws side. :-) Matt On 7/24/13 1:19 PM, Noah Slater nsla...@apache.org wrote: Nope. Sorry. Feel free to run with it. If not, I can see about doing another vote in the next few days. On 24 July 2013 18:02, Mathias Mullins mathias.mull...@citrix.com wrote: Noah, Did you ever review / report / re-vote this? Thanks, Matt On 6/25/13 11:17 AM, Noah Slater nsla...@apache.org wrote: Thanks for the feedback, Matt. Anyone else got any feedback on this? Might cut a new vote. On 24 June 2013 05:12, Mathias Mullins mathias.mull...@citrix.com wrote: Noah, I agree that there needs to be a delineation. Here's my option on wording describing what is non-technical: +3.4.2. Non-Technical Decisions +Non-technical decisions should normally be made by the entire community using +discussion-lead consensus-building, and not through formal voting. + +Non-technical decisions are defined as a decision that do not directly affect +the code in any branch of the project. +Including coding, testing, documentation or management of the code base. + +Non-technical decisions can be made on whichever project mailing list is most +appropriate. + +Non-technical decisions cannot be vetoed, but if there is strong opposition +a formal vote can be used to resolve the dispute. + +If a formal vote is started for a non-technical decision, the vote will be held +as a lazy 2/3 majority of active committers. + +Any user, contributor, committer or PMC member can initiate a non-technical +decision making process. Matt Mullins Cloud Platforms Implementation Engineer Worldwide Cloud Services Citrix System, Inc. +1 (407) 920-1107 Office/Cell Phone matt.mull...@citrix.com On 6/20/13 11:59 AM, Noah Slater nsla...@apache.org wrote: Less terse follow up... ;) Note that our current by-laws effectively state that any technical decision needs to happen on dev@. I am just clarifying the intent. Note also that we currently do not define what a technical decision is, but it is my opinion that this is any decision which relates to the CloudStack source code. (We might want to make it a little broader than that. Open to suggestions.) Almost everything we do involves technology. Whether that is editing the website, wiki, JIRA, mailing lists, etc. That doesn't mean that those activities are technical activities or involve technical decisions. Do you think our by-laws need a section clarifying technical vs. non-technical? What should it say? On 20 June 2013 15:14, Joe Brockmeier j...@zonker.net wrote: On Thu, Jun 20, 2013, at 08:21 AM, Noah Slater wrote: Devs, I would like to call a vote on the following modification to our by-laws. This is in response to the Summary of changes: * Addition of 3.4.2. Non-Technical Decisions section. This specifies that non-technical decisions can be made on any appropriate list (i.e. marketing@) Erm. Does this mean that marketing can't make any technical decisions about the Web site, for instance? I think this needs to be better worded. Best, jzb -- Joe Brockmeier j...@zonker.net Twitter: @jzb http://www.dissociatedpress.net/ -- NS -- NS -- NS
RE: Review Request 12874: Fix reboot failures with wait time
Can you rebase your branch and try to create a new patch; file that you modified might have got updated. --Sanjay -Original Message- From: Sowmya Krishnan [mailto:sowmya.krish...@citrix.com] Sent: Wednesday, July 24, 2013 10:37 PM To: dev@cloudstack.apache.org; Prasanna Santhanam Subject: RE: Review Request 12874: Fix reboot failures with wait time RB doesn’t accept the patch. Keeps failing. Here's the patch: From 02238e6903d3d399d402886513efd6cd2664696a Mon Sep 17 00:00:00 2001 From: Sowmya Krishnan sowmya.krish...@citrix.com Date: Tue, 23 Jul 2013 22:29:10 +0530 Subject: [PATCH] Add wait while Netscaler recognizes service to be up --- test/integration/component/test_netscaler_lb.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/test/integration/component/test_netscaler_lb.py b/test/integration/component/test_netscaler_lb.py index cd85659..d93a262 100644 --- a/test/integration/component/test_netscaler_lb.py +++ b/test/integration/component/test_netscaler_lb.py @@ -2772,6 +2772,8 @@ class TestVmWithLb(cloudstackTestCase): self.debug(Rebooting VM instance: %s % self.vm_2.name) self.vm_2.reboot(self.apiclient) self.debug(Rebooting VM: %s % self.vm_2.name) +self.debug(Waiting for Netscaler to get the service up) +time.sleep( 120 ) try: self.debug( -- 1.7.5.4 -Original Message- From: Prasanna Santhanam [mailto:nore...@reviews.apache.org] On Behalf Of Prasanna Santhanam Sent: Wednesday, July 24, 2013 9:56 PM To: Prasanna Santhanam Cc: cloudstack; Sowmya Krishnan Subject: Re: Review Request 12874: Fix reboot failures with wait time --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12874/#review23766 --- I think you forgot to attach the diff here. - Prasanna Santhanam On July 23, 2013, 5:20 p.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12874/ --- (Updated July 23, 2013, 5:20 p.m.) Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- Fix reboot failures with sleep time since Netscaler at times takes almost 60 - 90 seconds for identifying the service to be up after rebooting a VM. Diffs - Diff: https://reviews.apache.org/r/12874/diff/ Testing --- Tested locally and the script now passes Thanks, Sowmya Krishnan
Re: Review Request 12893: CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/#review23776 --- Commit 5009d3b82af4fa385490517185d071e1326cffaa in branch refs/heads/4.2 from Sanjay Tripathi [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5009d3b ] CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project. Signed-off-by: Prasanna Santhanam t...@apache.org - ASF Subversion and Git Services On July 24, 2013, 5:12 p.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12893/ --- (Updated July 24, 2013, 5:12 p.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3696 Repository: cloudstack-git Description --- CLOUDSTACK-3696: Test case test_project_limits.TestResourceLimitsProject.test_06_volumes_per_project failed due to volume usage exceeded for project. Diffs - test/integration/component/test_project_limits.py 6e3f41d Diff: https://reviews.apache.org/r/12893/diff/ Testing --- Verified the marvin test locally on cloudstack setup. Thanks, Sanjay Tripathi
Re: Review Request 12874: Fix reboot failures with wait time
Actually I just applied it. So it's okay. On Wed, Jul 24, 2013 at 05:34:27PM +, Sanjay Tripathi wrote: Can you rebase your branch and try to create a new patch; file that you modified might have got updated. --Sanjay -Original Message- From: Sowmya Krishnan [mailto:sowmya.krish...@citrix.com] Sent: Wednesday, July 24, 2013 10:37 PM To: dev@cloudstack.apache.org; Prasanna Santhanam Subject: RE: Review Request 12874: Fix reboot failures with wait time RB doesn???t accept the patch. Keeps failing. Here's the patch: From 02238e6903d3d399d402886513efd6cd2664696a Mon Sep 17 00:00:00 2001 From: Sowmya Krishnan sowmya.krish...@citrix.com Date: Tue, 23 Jul 2013 22:29:10 +0530 Subject: [PATCH] Add wait while Netscaler recognizes service to be up --- test/integration/component/test_netscaler_lb.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/test/integration/component/test_netscaler_lb.py b/test/integration/component/test_netscaler_lb.py index cd85659..d93a262 100644 --- a/test/integration/component/test_netscaler_lb.py +++ b/test/integration/component/test_netscaler_lb.py @@ -2772,6 +2772,8 @@ class TestVmWithLb(cloudstackTestCase): self.debug(Rebooting VM instance: %s % self.vm_2.name) self.vm_2.reboot(self.apiclient) self.debug(Rebooting VM: %s % self.vm_2.name) +self.debug(Waiting for Netscaler to get the service up) +time.sleep( 120 ) try: self.debug( -- 1.7.5.4 -Original Message- From: Prasanna Santhanam [mailto:nore...@reviews.apache.org] On Behalf Of Prasanna Santhanam Sent: Wednesday, July 24, 2013 9:56 PM To: Prasanna Santhanam Cc: cloudstack; Sowmya Krishnan Subject: Re: Review Request 12874: Fix reboot failures with wait time --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12874/#review23766 --- I think you forgot to attach the diff here. - Prasanna Santhanam On July 23, 2013, 5:20 p.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12874/ --- (Updated July 23, 2013, 5:20 p.m.) Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- Fix reboot failures with sleep time since Netscaler at times takes almost 60 - 90 seconds for identifying the service to be up after rebooting a VM. Diffs - Diff: https://reviews.apache.org/r/12874/diff/ Testing --- Tested locally and the script now passes Thanks, Sowmya Krishnan -- Prasanna., Powered by BigRock.com
Re: Review Request 12853: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.
The resources of those accounts might not be removed yet. Removing the domain
while these resources are still present, will introduce tons of NPEs when we
try to access the domain info for them.
So removing the domain should be done only after all the accounts are removed.
-Alena.
From: Sanjay Tripathi
sanjay.tripa...@citrix.commailto:sanjay.tripa...@citrix.com
Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org, Sanjay Tripathi
sanjay.tripa...@citrix.commailto:sanjay.tripa...@citrix.com
Date: Wednesday, July 24, 2013 10:18 AM
To: Prasanna Santhanam t...@apache.orgmailto:t...@apache.org, Devdeep Singh
devdeep.si...@citrix.commailto:devdeep.si...@citrix.com, Alena Prokharchyk
alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com
Cc:
cloudstack-...@incubator.apache.orgmailto:cloudstack-...@incubator.apache.org
cloudstack-...@incubator.apache.orgmailto:cloudstack-...@incubator.apache.org,
Sanjay Tripathi sanjay.tripa...@citrix.commailto:sanjay.tripa...@citrix.com
Subject: Re: Review Request 12853: CLOUDSTACK-3688: Test cases
test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the
domain to delete and failed.
On July 24, 2013, 5:02 p.m., Alena Prokharchyk wrote:
There is no bug in current Java code, and the java part of this review ticket
shouldn't be checked in.
In the method cleanupDomain(), we try to remove every account before checking
if accounts marked for cleanup, exist.
// delete users which will also delete accounts and release resources for
those accounts
SearchCriteriaAccountVO sc = _accountDao.createSearchCriteria();
sc.addAnd(domainId, SearchCriteria.Op.EQ, domainId);
ListAccountVO accounts = _accountDao.search(sc, null);
for (AccountVO account : accounts) {
if (account.getType() != Account.ACCOUNT_TYPE_PROJECT) {
s_logger.debug(Deleting account + account + as a part of
domain id= + domainId + cleanup);
boolean deleteAccount = _accountMgr.deleteAccount(account,
UserContext.current().getCallerUserId(), UserContext.current().getCaller());
if (!deleteAccount) {
s_logger.warn(Failed to cleanup account id= +
account.getId() + as a part of domain cleanup);
}
Only after that we verify if there are accounts left. And only if the code
above failed, the code below returns non-empty list:
// don't remove the domain if there are accounts required cleanup
boolean deleteDomainSuccess = true;
ListAccountVO accountsForCleanup =
_accountDao.findCleanupsForRemovedAccounts(domainId);
So it works as expected.
But the accounts which are marked as cleanup=true are set as removed and admin
can't list them by using API call. So, the only thing admin can see is the
domain without any accounts. Please clarify if that makes sense.
- Sanjay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12853/#review23771
---
On July 23, 2013, 12:34 p.m., Sanjay Tripathi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12853/
---
(Updated July 23, 2013, 12:34 p.m.)
Review request for cloudstack, Alena Prokharchyk, Devdeep Singh, and Prasanna
Santhanam.
Bugs: CLOUDSTACK-3688
Repository: cloudstack-git
Description
---
CLOUDSTACK-3688: Test cases
test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the
domain to delete and failed.
This issue is in CS product and not in the test_script.
The problem is coming because in case of deleteDomain with cleanup = true,
CS is not allowing deletion of domain if there are any account under that
domain needs clean up; though these accounts are removed and admin can't
see them in the listaccounts.
So CS should not restrict the deleteDomain in case of accounts needs
cleanup.
Diffs
-
server/src/com/cloud/user/DomainManagerImpl.java 1117ff0
test/integration/component/test_accounts.py 3c284bd
Diff: https://reviews.apache.org/r/12853/diff/
Testing
---
Verified marvin test on my local cloudstack setup.
Thanks,
Sanjay Tripathi
Re: Review Request 12723: test for Script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12723/ --- (Updated July 24, 2013, 5:42 p.m.) Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- a unit test for the most frequently used methods in the Script class Diffs - utils/test/com/cloud/utils/ScriptTest.java PRE-CREATION Diff: https://reviews.apache.org/r/12723/diff/ Testing --- yes, this is the test Thanks, Laszlo Hornyak
Review Request 12905: Multiple VLAN range API need to accept a list rather than add or remove per command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- Review request for cloudstack and Sheng Yang. Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than add or remove per command Diffs - api/src/com/cloud/network/NetworkService.java 59ccdbf api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 Diff: https://reviews.apache.org/r/12905/diff/ Testing --- Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Thanks, bharat kumar
RE: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs
Speaking of system vm upgrades, would you how to force an upgrade without
recreating the vm?
Thinking worse case would be to mount systemvm.iso and execute one of the
init.d scripts, but not certain.
We should not have to recreate system vms, in order for them to get new code.
-Original Message-
From: Marcus Sorensen [mailto:shadow...@gmail.com]
Sent: Wednesday, July 24, 2013 1:12 PM
To: dev@cloudstack.apache.org
Subject: Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere
VMs
Yes, definitely shouldn't be a 4.1.x change. I don't think we want people to
have to go through major pains on a minor point release unless there's some
major showstopper bug.
4.2, I don't know. I was always under the impression that going from 4.x to
4.y WAS a major release, per the versioning standards we have adopted. The
entire guts of cloudstack could change (see javelin), requiring system VM
upgrades (also required in the past and planned as a requirement for 4.2),
and as long as it doesn't break the user-facing api compatibility it would
remain the same major release number.
On Jul 24, 2013 10:57 AM, Wido den Hollander w...@widodh.nl wrote:
Hi,
I reverted this commit in the 4.1 branch:
https://git-wip-us.apache.org/**
repos/asf?p=cloudstack.git;a=**commitdiff;h=**
a069f31f51d0ef1f255d85ef32d764**9a5ec659c1https://git-wip-
us.apache.o
rg/repos/asf?p=cloudstack.git;a=commitdiff;h=a069f31f51d0ef1f255d85ef3
2d7649a5ec659c1
There has been no discussion about changing this API in the 4.1
series, I even think we can't simply do that for 4.2 either.
You CAN'T break API compatibility in a minor release like 4.1.1.
Users rely on us to make stable releases, they don't want to be
figuring out why their perfectly working SSVM stops working during
such a small upgrade, same goes for their KVM agents.
Wido
On 07/24/2013 05:39 PM, Musayev, Ilya wrote:
Wei.
Yes, I recreated the systemvms by destroying them. I have no agents,
if you mean KVM/Xen agents, I'm running vSphere.
Regards
Ilya
-Original Message-
From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
Sent: Wednesday, July 24, 2013 2:37 AM
To: dev@cloudstack.apache.org
Subject: Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to
VSphere VMs
Ilya,
Did you upgrade agent and systemvm.iso on host ?
2013/7/24 Musayev, Ilya imusa...@webmd.net
Kelven
We are unable release ACS 4.1.1 as we have issues with CLOUDSTACK-
3433.
After several hours of testing, even after I redeploy CPVM, I still
see more errors in the logs (see below) and basic CPVM
functionality is
broken.
I'm not certain what we fix with CLOUDSTACK-3433, but currently
have many more issues.
Would it be possible to revert this commit and work on adding this
commit into 4.1.2 instead?
We have to wrap up ACS 4.1.1 release tomorrow.
Thanks
ilya
2013-07-23 22:30:47,132 WARN [utils.nio.Task]
(AgentManager-Handler-10:null) Caught the following exception but
pushing on
com.google.gson.**JsonParseException: The JsonDeserializer
com.cloud.agent.transport.**ArrayTypeAdaptor@5ad2ee0f failed to
deserialize json object
[{StartupProxyCommand:{**proxyPort:80,proxyVmId:260,**
type:Consol
eProxy,dataCenter:2,pod**:2,guid:Proxy.260-**
ConsoleProxyResou
rce,name:v-260-CLOUD411,**version:4.1.1-
SNAPSHOT,iqn:NoIqn,
publicIpAddress:172.24.20.**22,publicNetmask:255.255.**
255.224,pu
blicMacAddress:06:2a:5e:00:**00:29,privateIpAddress:**
172.24.20.25,
privateMacAddress:06:3f:9e:**00:00:2b,privateNetmask:**
255.255.255.
224,storageIpAddress:172.**24.20.25,storageNetmask:**
255.255.255.2
24,storageMacAddress:06:**3f:9e:00:00:2b,resourceName**
:ConsolePro
xyResource,contextMap:{},**wait:0}}]
given the type class [Lcom.cloud.agent.api.Command;
at
com.google.gson.**JsonDeserializerExceptionWrapp**
er.deserialize(JsonDeserial
izerExceptionWrapper.java:64)
at
com.google.gson.**JsonDeserializationVisitor.**
invokeCustomDeserializer(JsonD
eserializationVisitor.java:92)
at
com.google.gson.**JsonDeserializationVisitor.**
visitUsingCustomHandler(JsonDe
serializationVisitor.java:80)
at com.google.gson.**ObjectNavigator.accept(**
ObjectNavigator.java:101)
at
com.google.gson.**JsonDeserializationContextDefa**
ult.fromJsonArray(JsonDes
erializationContextDefault.**java:67)
at
com.google.gson.**JsonDeserializationContextDefa**
ult.deserialize(JsonDeserial
izationContextDefault.java:52)
at com.google.gson.Gson.fromJson(**Gson.java:551)
at com.google.gson.Gson.fromJson(**Gson.java:498)
at
com.cloud.agent.transport.**Request.getCommands(Request.**java:235)
at
com.cloud.agent.manager.**AgentManagerImpl$AgentHandler.**processR
e
que
Review Request 12907: WIP: Add LDAP Account addition UI. Feedback and Help wanted.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12907/ --- Review request for cloudstack, Abhinandan Prateek, Brian Federle, Jessica Wang, Pranav Saxena, and Sebastien Goasguen. Repository: cloudstack-git Description --- Note: JS files were formatted with same formatting that was applied to origin/master. This is purely a work in progress. I'm submitting it as I'd like somebody to give *detailed* feedback/reviewal before I go much further. The code works/does-what-I-want but I'm not sure if its correct and follows cloudstack UI practices. I had to do some ugly css in order to get the display I wanted. I'm currently having issues with fields marked as required for some reason the requirement doesn't seem to be enforced. I'm not sure if a loader appears should the request to listAllLdapUsers be slow to respond. I'm not sure how to add a if ldapEnabled display this view else display old view condition. I'm not sure how to detail with cases where the user might not have firstname, lastname or email set in ldap. I'm not sure what happens if listAllLdapUsers returns a massive list of users... will it load on scroll? Does paging need to be implemented API side? How is this done? For testing purposes there is a ldap server included in this branch. You can launch it with: mvn -pl :cloud-plugin-user-authenticator-ldap ldap:run and then configure it at Global Settings - ldap.basedn = dc=cloudstack,dc=org Also global settings - LDAP Configuration, hostname: localhost, port: 10389. Diffs - client/tomcatconf/commands.properties.in 9e14d0f plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapAddConfigurationCmd.java 62736b16087561a7e25893cd46115795100c609e plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccount.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapDeleteConfigurationCmd.java 329b91b plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java 087d156 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java 6707878 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapUserSearchCmd.java e6a40d0 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java d583346 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 40ba0ce plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java 2916202 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 8f31ce5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java d3ff820 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java 30bdc5b plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManager.java c961d2c plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java be9b3d5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java 7c65e60 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 54802cf plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUtils.java 453dc0a plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapAddConfigurationCmdSpec.groovy ebade1e plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy 91c9baf plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy 8135901 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapContextFactorySpec.groovy bb20fb3 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy 664fd64 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListAllUsersCmdSpec.groovy 30cd7cc plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListConfigurationCmdSpec.groovy a7c1979 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy 5dfecb9 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy d72878b plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserManagerSpec.groovy 489c250 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy 105203b plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy 6131267 ui/css/cloudstack3.css 4545e96 ui/index.jsp 34f0c54
Re: Review Request 12907: WIP: Add LDAP Account addition UI. Feedback and Help wanted.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12907/ --- (Updated July 24, 2013, 5:52 p.m.) Review request for cloudstack, Abhinandan Prateek, Brian Federle, Jessica Wang, Pranav Saxena, and Sebastien Goasguen. Repository: cloudstack-git Description (updated) --- Note: JS files were formatted with same formatting that was applied to origin/master. This is purely a work in progress. I'm submitting it as I'd like somebody to give *detailed* feedback/reviewal before I go much further. The code works/does-what-I-want but I'm not sure if its correct and follows cloudstack UI practices. I had to do some ugly css in order to get the display I wanted. I'm currently having issues with fields marked as required for some reason the requirement doesn't seem to be enforced. I'm not sure if a loader appears should the request to listAllLdapUsers be slow to respond. I'm not sure how to add a if ldapEnabled display this view else display old view condition. I'm not sure how to detail with cases where the user might not have firstname, lastname or email set in ldap. I'm not sure what happens if listAllLdapUsers returns a massive list of users... will it load on scroll? Does paging need to be implemented API side? How is this done? I'm not sure how to get the newly created user to pop up in the table after the add account screen is closed. I'm not sure how to notify the administrator that their user has successfully created or failed to create via the little pop up box. For testing purposes there is a ldap server included in this branch. You can launch it with: mvn -pl :cloud-plugin-user-authenticator-ldap ldap:run and then configure it at Global Settings - ldap.basedn = dc=cloudstack,dc=org Also global settings - LDAP Configuration, hostname: localhost, port: 10389. Diffs - client/tomcatconf/commands.properties.in 9e14d0f plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapAddConfigurationCmd.java 62736b16087561a7e25893cd46115795100c609e plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccount.java PRE-CREATION plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapDeleteConfigurationCmd.java 329b91b plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java 087d156 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java 6707878 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapUserSearchCmd.java e6a40d0 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java d583346 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 40ba0ce plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java 2916202 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 8f31ce5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java d3ff820 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java 30bdc5b plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManager.java c961d2c plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java be9b3d5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java 7c65e60 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 54802cf plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUtils.java 453dc0a plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapAddConfigurationCmdSpec.groovy ebade1e plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy 91c9baf plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy 8135901 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapContextFactorySpec.groovy bb20fb3 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy 664fd64 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListAllUsersCmdSpec.groovy 30cd7cc plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListConfigurationCmdSpec.groovy a7c1979 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy 5dfecb9 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy d72878b plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserManagerSpec.groovy
RE: Inclusion of commons-httpclient-contrib jar
No it's not. I used to use commons-httpclient-contrib jar, it's separate -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in commons-httpclient 3.1? http://grepcode.com/file/repo1.maven.org/maven2/commons- httpclient/commons- httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/EasyX509TrustMana ger.java --Alex -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:41 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar +1 @Frank, it is not a re-implementation, but a copy. On 7/24/13 2:14 AM, Amogh Vasekar amogh.vase...@citrix.com wrote: In the absence of an officially published jar on maven for contrib-ssl, the current idea is to put this package in cloud-utils (it is a dependency for both cisco-vnmc and ucs) for easier maintenance. Please let me know if this sounds good. Thanks, Amogh On 7/22/13 5:26 PM, Frank Zhang frank.zh...@citrix.com wrote: I prefer to just use httpclient-contribs.jar as it has been proven by lots of users. Reimplementing such code brings no gain but maintenance effort. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Monday, July 22, 2013 5:17 PM To: dev@cloudstack.apache.org Subject: Inclusion of commons-httpclient-contrib jar Hi All, I was working on a HTTPS related fix, and found this package in the codebase : https://github.com/apache/cloudstack/tree/master/plugins/network- elements/c isco-vnmc/src/org/apache/commons/httpclient/contrib/ssl I need to use the same classes, which are already a part of httpclient-contribs jar (http://www.java2s.com/Code/Jar/c/Downloadcommonshttpclientcontr ib31jar. htm ) Was wondering if there is a specific reason the jar was not included instead (probably since it is a contrib jar?) Thanks, Amogh
RE: Review Request 12853: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.
Its correct that there is the possibility that resource of these accounts might
not be removed; but if we take the same scenario with deleteAccount API, where
we always return true as success response irrespective of the resources (except
project) are still attached to this account or not. If the resources are still
attached to the account, CS marks the cleanupRequired field in DB as true and
cleanup thread takes care of it in the next run.
So if we are allowing the accounts to get deleted then why are we checking for
accounts needs cleanup in deleteDomain API (though accounts are set as removed
in this case also).
--Sanjay
From: Alena Prokharchyk
Sent: Wednesday, July 24, 2013 11:09 PM
To: dev@cloudstack.apache.org; Sanjay Tripathi; Prasanna Santhanam; Devdeep
Singh
Cc: cloudstack
Subject: Re: Review Request 12853: CLOUDSTACK-3688: Test cases
test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the
domain to delete and failed.
The resources of those accounts might not be removed yet. Removing the domain
while these resources are still present, will introduce tons of NPEs when we
try to access the domain info for them.
So removing the domain should be done only after all the accounts are removed.
-Alena.
From: Sanjay Tripathi
sanjay.tripa...@citrix.commailto:sanjay.tripa...@citrix.com
Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org, Sanjay Tripathi
sanjay.tripa...@citrix.commailto:sanjay.tripa...@citrix.com
Date: Wednesday, July 24, 2013 10:18 AM
To: Prasanna Santhanam t...@apache.orgmailto:t...@apache.org, Devdeep Singh
devdeep.si...@citrix.commailto:devdeep.si...@citrix.com, Alena Prokharchyk
alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com
Cc:
cloudstack-...@incubator.apache.orgmailto:cloudstack-...@incubator.apache.org
cloudstack-...@incubator.apache.orgmailto:cloudstack-...@incubator.apache.org,
Sanjay Tripathi sanjay.tripa...@citrix.commailto:sanjay.tripa...@citrix.com
Subject: Re: Review Request 12853: CLOUDSTACK-3688: Test cases
test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the
domain to delete and failed.
On July 24, 2013, 5:02 p.m., Alena Prokharchyk wrote:
There is no bug in current Java code, and the java part of this review ticket
shouldn't be checked in.
In the method cleanupDomain(), we try to remove every account before checking
if accounts marked for cleanup, exist.
// delete users which will also delete accounts and release resources for
those accounts
SearchCriteriaAccountVO sc = _accountDao.createSearchCriteria();
sc.addAnd(domainId, SearchCriteria.Op.EQ, domainId);
ListAccountVO accounts = _accountDao.search(sc, null);
for (AccountVO account : accounts) {
if (account.getType() != Account.ACCOUNT_TYPE_PROJECT) {
s_logger.debug(Deleting account + account + as a part of
domain id= + domainId + cleanup);
boolean deleteAccount = _accountMgr.deleteAccount(account,
UserContext.current().getCallerUserId(), UserContext.current().getCaller());
if (!deleteAccount) {
s_logger.warn(Failed to cleanup account id= +
account.getId() + as a part of domain cleanup);
}
Only after that we verify if there are accounts left. And only if the code
above failed, the code below returns non-empty list:
// don't remove the domain if there are accounts required cleanup
boolean deleteDomainSuccess = true;
ListAccountVO accountsForCleanup =
_accountDao.findCleanupsForRemovedAccounts(domainId);
So it works as expected.
But the accounts which are marked as cleanup=true are set as removed and admin
can't list them by using API call. So, the only thing admin can see is the
domain without any accounts. Please clarify if that makes sense.
- Sanjay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12853/#review23771
---
On July 23, 2013, 12:34 p.m., Sanjay Tripathi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12853/
---
(Updated July 23, 2013, 12:34 p.m.)
Review request for cloudstack, Alena Prokharchyk, Devdeep Singh, and Prasanna
Santhanam.
Bugs: CLOUDSTACK-3688
Repository: cloudstack-git
Description
---
CLOUDSTACK-3688: Test cases
test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the
domain to delete and failed.
This issue is in CS product and not in the test_script.
The problem is coming because in case of deleteDomain with cleanup = true,
CS is not allowing deletion of domain if there are any
RE: Inclusion of commons-httpclient-contrib jar
Agree. Amogh actually has done it in cloud-utils -Original Message- From: Koushik Das [mailto:koushik@citrix.com] Sent: Wednesday, July 24, 2013 10:26 AM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar For now I think cloud-utils is the best option. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Wednesday, July 24, 2013 10:48 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : Warning: not-yet-commons-ssl-0.3.11 should be considered to be of Alpha quality! I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should go ahead with it. Thanks, Amogh On 7/23/13 10:51 PM, Alex Huang alex.hu...@citrix.com wrote: Amogh, I added the following to the pom.xml for cisco and it seems to compile with a few extra exceptions try-catch added. Can you check on if you can use this? dependency groupIdca.juliusdavies/groupId artifactIdnot-yet-commons-ssl/artifactId version0.3.11/version /dependency --Alx -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in commons-httpclient 3.1? http://grepcode.com/file/repo1.maven.org/maven2/commons- httpclient/commons- httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/EasyX509Tr us tM anager.java --Alex -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:41 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar +1 @Frank, it is not a re-implementation, but a copy. On 7/24/13 2:14 AM, Amogh Vasekar amogh.vase...@citrix.com wrote: In the absence of an officially published jar on maven for contrib-ssl, the current idea is to put this package in cloud-utils (it is a dependency for both cisco-vnmc and ucs) for easier maintenance. Please let me know if this sounds good. Thanks, Amogh On 7/22/13 5:26 PM, Frank Zhang frank.zh...@citrix.com wrote: I prefer to just use httpclient-contribs.jar as it has been proven by lots of users. Reimplementing such code brings no gain but maintenance effort. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Monday, July 22, 2013 5:17 PM To: dev@cloudstack.apache.org Subject: Inclusion of commons-httpclient-contrib jar Hi All, I was working on a HTTPS related fix, and found this package in the codebase : https://github.com/apache/cloudstack/tree/master/plugins/networ k- elements/c isco-vnmc/src/org/apache/commons/httpclient/contrib/ssl I need to use the same classes, which are already a part of httpclient-contribs jar (http://www.java2s.com/Code/Jar/c/Downloadcommonshttpclientcon tr ib31jar. htm ) Was wondering if there is a specific reason the jar was not included instead (probably since it is a contrib jar?) Thanks, Amogh
RE: DNS Network Domain
Thanks, it will have to be part of a bigger change to also change the UI to
update the Network when the Zone DNS Domain is updated.
-Soheil
From: Chiradeep Vittal [chiradeep.vit...@citrix.com]
Sent: Tuesday, July 23, 2013 9:56 PM
To: dev@cloudstack.apache.org
Subject: Re: DNS Network Domain
Not sure. I don't think it will break anything to remove this check.
On 7/24/13 3:04 AM, Soheil Eizadi seiz...@infoblox.com wrote:
Created Jira bug against this, was going to submit a UI patch:
https://issues.apache.org/jira/browse/CLOUDSTACK-3754
-Soheil
From: Soheil Eizadi [seiz...@infoblox.com]
Sent: Tuesday, July 02, 2013 6:36 PM
To: dev@cloudstack.apache.org
Subject: DNS Network Domain
I found that the DNS Network Domain set for Basic Networking is not
getting passed down to Network Plugins. I am trying to figure out how DNS
Network Domain is suppose to work for my plugin integration.
I was getting a NULL value for Basic Networking for the DNS Domain even
though I had set a value for it in the Wizard. After I set the value in
the database, it seems to be working but wanted to understand why it was
not set,I found code in the system that enforces this behavior, when I
try to set it from the API.
-Soheil
More detail logs .
The Domain is set in the Zone Setting to acme.com:
list zones
count = 1
zone:
name = testzone
..
domain = acme.com
..
It does not get passed down to the attached network.
API call list networks missing networkdomain field as it is NULL.
list networks
count = 1
network:
id = 1065fff0-a6e2-410a-94d5-50bc72f879db
name = defaultGuestNetwork
acltype = Domain
broadcastdomaintype = Native
.
I also tried to set it using API to set the value but get exception:
ERROR [cloud.async.AsyncJobManagerImpl] (Job-Executor-20:job-20)
Unexpected exception while executing
org.apache.cloudstack.api.command.user.network.UpdateNetworkCmd
com.cloud.exception.InvalidParameterValueException: NetworkOffering and
domain suffix upgrade can be perfomed for Isolated networks only
at
com.cloud.network.NetworkServiceImpl.updateGuestNetwork(NetworkServiceImpl
.java:1982)
at
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorD
ispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
Exception from here:
// network offering and domain suffix can be updated for Isolated
networks only in 3.0
if ((networkOfferingId != null || domainSuffix != null)
network.getGuestType() != GuestType.Isolated) {
throw new InvalidParameterValueException(NetworkOffering and
domain suffix upgrade can be perfomed for Isolated networks only);
}
I've patched the database and it works for me, trying to understand why
we have code to prevent it?
list networks
count = 1
network:
id = 1065fff0-a6e2-410a-94d5-50bc72f879db
name = defaultGuestNetwork
...
networkdomain = acme.com
INFO [network.element.InfobloxElement] (consoleproxy-1:)
InfobloxDeviceElement called to prepare Host Name soheil-test with DNS
Domain acme.com Gateway null Netmask null with MAC 06:97:84:00:00:16 with
IPv4 172.16.197.161
Re: Inclusion of commons-httpclient-contrib jar
Nobody has bothered to deal with the LICENSE file for the file described below. Anyone want to take this on, or at least give me the information required? On Wed, Jul 24, 2013 at 05:59:59PM +, Frank Zhang wrote: Agree. Amogh actually has done it in cloud-utils -Original Message- From: Koushik Das [mailto:koushik@citrix.com] Sent: Wednesday, July 24, 2013 10:26 AM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar For now I think cloud-utils is the best option. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Wednesday, July 24, 2013 10:48 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : Warning: not-yet-commons-ssl-0.3.11 should be considered to be of Alpha quality! I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should go ahead with it. Thanks, Amogh On 7/23/13 10:51 PM, Alex Huang alex.hu...@citrix.com wrote: Amogh, I added the following to the pom.xml for cisco and it seems to compile with a few extra exceptions try-catch added. Can you check on if you can use this? dependency groupIdca.juliusdavies/groupId artifactIdnot-yet-commons-ssl/artifactId version0.3.11/version /dependency --Alx -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in commons-httpclient 3.1? http://grepcode.com/file/repo1.maven.org/maven2/commons- httpclient/commons- httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/EasyX509Tr us tM anager.java --Alex -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:41 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar +1 @Frank, it is not a re-implementation, but a copy. On 7/24/13 2:14 AM, Amogh Vasekar amogh.vase...@citrix.com wrote: In the absence of an officially published jar on maven for contrib-ssl, the current idea is to put this package in cloud-utils (it is a dependency for both cisco-vnmc and ucs) for easier maintenance. Please let me know if this sounds good. Thanks, Amogh On 7/22/13 5:26 PM, Frank Zhang frank.zh...@citrix.com wrote: I prefer to just use httpclient-contribs.jar as it has been proven by lots of users. Reimplementing such code brings no gain but maintenance effort. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Monday, July 22, 2013 5:17 PM To: dev@cloudstack.apache.org Subject: Inclusion of commons-httpclient-contrib jar Hi All, I was working on a HTTPS related fix, and found this package in the codebase : https://github.com/apache/cloudstack/tree/master/plugins/networ k- elements/c isco-vnmc/src/org/apache/commons/httpclient/contrib/ssl I need to use the same classes, which are already a part of httpclient-contribs jar (http://www.java2s.com/Code/Jar/c/Downloadcommonshttpclientcon tr ib31jar. htm ) Was wondering if there is a specific reason the jar was not included instead (probably since it is a contrib jar?) Thanks, Amogh
RE: [VOTE] Apache Cloudstack 4.1.1
+1, I did QA of 4.1.1 to best of my abilities. -Original Message- From: Musayev, Ilya [mailto:imusa...@webmd.net] Sent: Wednesday, July 24, 2013 1:23 PM To: dev@cloudstack.apache.org Subject: [VOTE] Apache Cloudstack 4.1.1 Hi All, I've created a 4.1.1 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip- us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.1 Commit: 8fe3505cba45756a51e9e9ee97cd09bf1e71c79e Source release (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.1.1/ PGP release keys (signed using B7B5E7FD): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Vote will be open for 72 hours. For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why)
Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere VMs
It's going to be different for various things, depending on what is
being changed. Is it a conf for a service, that will need to be
restarted? Or the cloud-early-config init script itself, requiring a
reboot? Internally, we've written a plugin (upgradeRouterScripts
routerid=) that copies the cloud-scripts.tgz from the iso to the
router and extracts /opt/cloud/bin, for cases where we just want to
add/update a script, but 1) I'm not sure how that works on non-KVM
platforms, and 2) It seems like trouble to expect everyone to manage
the various upgrade types and know which changes require what actions,
or worse yet, writing a custom API call for the various things
(upgradeDnsMasq routerid=, etc.). You could do a catch all, but that
would likely require restarting all router services, might as well
just reboot it.
Rebooting the VM will be enough to upgrade the software. As far as
upgrading the template that the system vm uses, there are procedures
for that included with the cloudstack upgrade instructions. I'm not
entirely clear on how they work, but essentially you register the new
template and then restart the system vms. There's a helper script for
it, I believe.
On Wed, Jul 24, 2013 at 11:50 AM, Musayev, Ilya imusa...@webmd.net wrote:
Speaking of system vm upgrades, would you how to force an upgrade without
recreating the vm?
Thinking worse case would be to mount systemvm.iso and execute one of the
init.d scripts, but not certain.
We should not have to recreate system vms, in order for them to get new code.
-Original Message-
From: Marcus Sorensen [mailto:shadow...@gmail.com]
Sent: Wednesday, July 24, 2013 1:12 PM
To: dev@cloudstack.apache.org
Subject: Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to VSphere
VMs
Yes, definitely shouldn't be a 4.1.x change. I don't think we want people to
have to go through major pains on a minor point release unless there's some
major showstopper bug.
4.2, I don't know. I was always under the impression that going from 4.x to
4.y WAS a major release, per the versioning standards we have adopted. The
entire guts of cloudstack could change (see javelin), requiring system VM
upgrades (also required in the past and planned as a requirement for 4.2),
and as long as it doesn't break the user-facing api compatibility it would
remain the same major release number.
On Jul 24, 2013 10:57 AM, Wido den Hollander w...@widodh.nl wrote:
Hi,
I reverted this commit in the 4.1 branch:
https://git-wip-us.apache.org/**
repos/asf?p=cloudstack.git;a=**commitdiff;h=**
a069f31f51d0ef1f255d85ef32d764**9a5ec659c1https://git-wip-
us.apache.o
rg/repos/asf?p=cloudstack.git;a=commitdiff;h=a069f31f51d0ef1f255d85ef3
2d7649a5ec659c1
There has been no discussion about changing this API in the 4.1
series, I even think we can't simply do that for 4.2 either.
You CAN'T break API compatibility in a minor release like 4.1.1.
Users rely on us to make stable releases, they don't want to be
figuring out why their perfectly working SSVM stops working during
such a small upgrade, same goes for their KVM agents.
Wido
On 07/24/2013 05:39 PM, Musayev, Ilya wrote:
Wei.
Yes, I recreated the systemvms by destroying them. I have no agents,
if you mean KVM/Xen agents, I'm running vSphere.
Regards
Ilya
-Original Message-
From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
Sent: Wednesday, July 24, 2013 2:37 AM
To: dev@cloudstack.apache.org
Subject: Re: [ACS4.1.1][BLOCKER] Unable to launch VNC Console to
VSphere VMs
Ilya,
Did you upgrade agent and systemvm.iso on host ?
2013/7/24 Musayev, Ilya imusa...@webmd.net
Kelven
We are unable release ACS 4.1.1 as we have issues with CLOUDSTACK-
3433.
After several hours of testing, even after I redeploy CPVM, I still
see more errors in the logs (see below) and basic CPVM
functionality is
broken.
I'm not certain what we fix with CLOUDSTACK-3433, but currently
have many more issues.
Would it be possible to revert this commit and work on adding this
commit into 4.1.2 instead?
We have to wrap up ACS 4.1.1 release tomorrow.
Thanks
ilya
2013-07-23 22:30:47,132 WARN [utils.nio.Task]
(AgentManager-Handler-10:null) Caught the following exception but
pushing on
com.google.gson.**JsonParseException: The JsonDeserializer
com.cloud.agent.transport.**ArrayTypeAdaptor@5ad2ee0f failed to
deserialize json object
[{StartupProxyCommand:{**proxyPort:80,proxyVmId:260,**
type:Consol
eProxy,dataCenter:2,pod**:2,guid:Proxy.260-**
ConsoleProxyResou
rce,name:v-260-CLOUD411,**version:4.1.1-
SNAPSHOT,iqn:NoIqn,
publicIpAddress:172.24.20.**22,publicNetmask:255.255.**
255.224,pu
blicMacAddress:06:2a:5e:00:**00:29,privateIpAddress:**
172.24.20.25,
privateMacAddress:06:3f:9e:**00:00:2b,privateNetmask:**
255.255.255.
224,storageIpAddress:172.**24.20.25,storageNetmask:**
RE: Inclusion of commons-httpclient-contrib jar
Amogh has checked it's Apache 2. I am not sure if any process we need to go through -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 11:24 AM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Nobody has bothered to deal with the LICENSE file for the file described below. Anyone want to take this on, or at least give me the information required? On Wed, Jul 24, 2013 at 05:59:59PM +, Frank Zhang wrote: Agree. Amogh actually has done it in cloud-utils -Original Message- From: Koushik Das [mailto:koushik@citrix.com] Sent: Wednesday, July 24, 2013 10:26 AM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar For now I think cloud-utils is the best option. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Wednesday, July 24, 2013 10:48 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : Warning: not-yet-commons-ssl-0.3.11 should be considered to be of Alpha quality! I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should go ahead with it. Thanks, Amogh On 7/23/13 10:51 PM, Alex Huang alex.hu...@citrix.com wrote: Amogh, I added the following to the pom.xml for cisco and it seems to compile with a few extra exceptions try-catch added. Can you check on if you can use this? dependency groupIdca.juliusdavies/groupId artifactIdnot-yet-commons-ssl/artifactId version0.3.11/version /dependency --Alx -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in commons-httpclient 3.1? http://grepcode.com/file/repo1.maven.org/maven2/commons- httpclient/commons- httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/EasyX5 09Tr us tM anager.java --Alex -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:41 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar +1 @Frank, it is not a re-implementation, but a copy. On 7/24/13 2:14 AM, Amogh Vasekar amogh.vase...@citrix.com wrote: In the absence of an officially published jar on maven for contrib-ssl, the current idea is to put this package in cloud-utils (it is a dependency for both cisco-vnmc and ucs) for easier maintenance. Please let me know if this sounds good. Thanks, Amogh On 7/22/13 5:26 PM, Frank Zhang frank.zh...@citrix.com wrote: I prefer to just use httpclient-contribs.jar as it has been proven by lots of users. Reimplementing such code brings no gain but maintenance effort. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Monday, July 22, 2013 5:17 PM To: dev@cloudstack.apache.org Subject: Inclusion of commons-httpclient-contrib jar Hi All, I was working on a HTTPS related fix, and found this package in the codebase : https://github.com/apache/cloudstack/tree/master/plugins/networ k- elements/c isco-vnmc/src/org/apache/commons/httpclient/contrib/ssl I need to use the same classes, which are already a part of httpclient-contribs jar (http://www.java2s.com/Code/Jar/c/Downloadcommonshttpclientcon tr ib31jar. htm ) Was wondering if there is a specific reason the jar was not included instead (probably since it is a contrib jar?) Thanks, Amogh
Re: DNS Network Domain
Soheil, About network domain update. Changing network domain on the zone/account/domain/global level, will affect newly created networks only. It should stay this way. Once the network domain is determined and set for the network (during the network creation), it can be changed just by modifying the network itself via network offering update. Today its supported for Isolated networks only. For Shared networks, there is currently no way to update the network domain as network offering update is not supported. We have to fix it, but not by applying global config change to the existing networks. In case anyone interested on how the network domain is set for the network, here are the rules: http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.0-incubating/html-single/Admin_Guide/#customizing-dns Section 18.4 (copying here) The source of the network domain that is used depends on the following rules. * For all networks, if a network domain is specified as part of a network's own configuration, that value is used. * For an account-specific network, the network domain specified for the account is used. If none is specified, the system looks for a value in the domain, zone, and global configuration, in that order. * For a domain-specific network, the network domain specified for the domain is used. If none is specified, the system looks for a value in the zone and global configuration, in that order. * For a zone-specific network, the network domain specified for the zone is used. If none is specified, the system looks for a value in the global configuration. In Basic zone, the UI passes the networkDomain to the createZone call only. When the guest network created in the zone, it picks up the networkDomain from the zone configuration. As Basic zone can't have more than one guest networks, its ok to default networkDomain of the network to the network domain of the zone. -Alena. From: Soheil Eizadi seiz...@infoblox.commailto:seiz...@infoblox.com Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Date: Wednesday, July 24, 2013 11:13 AM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: RE: DNS Network Domain Thanks, it will have to be part of a bigger change to also change the UI to update the Network when the Zone DNS Domain is updated. -Soheil From: Chiradeep Vittal [chiradeep.vit...@citrix.commailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:56 PM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Re: DNS Network Domain Not sure. I don't think it will break anything to remove this check. On 7/24/13 3:04 AM, Soheil Eizadi seiz...@infoblox.commailto:seiz...@infoblox.com wrote: Created Jira bug against this, was going to submit a UI patch: https://issues.apache.org/jira/browse/CLOUDSTACK-3754 -Soheil From: Soheil Eizadi [seiz...@infoblox.commailto:seiz...@infoblox.com] Sent: Tuesday, July 02, 2013 6:36 PM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: DNS Network Domain I found that the DNS Network Domain set for Basic Networking is not getting passed down to Network Plugins. I am trying to figure out how DNS Network Domain is suppose to work for my plugin integration. I was getting a NULL value for Basic Networking for the DNS Domain even though I had set a value for it in the Wizard. After I set the value in the database, it seems to be working but wanted to understand why it was not set,I found code in the system that enforces this behavior, when I try to set it from the API. -Soheil More detail logs . The Domain is set in the Zone Setting to acme.com: list zones count = 1 zone: name = testzone .. domain = acme.com .. It does not get passed down to the attached network. API call list networks missing networkdomain field as it is NULL. list networks count = 1 network: id = 1065fff0-a6e2-410a-94d5-50bc72f879db name = defaultGuestNetwork acltype = Domain broadcastdomaintype = Native . I also tried to set it using API to set the value but get exception: ERROR [cloud.async.AsyncJobManagerImpl] (Job-Executor-20:job-20) Unexpected exception while executing org.apache.cloudstack.api.command.user.network.UpdateNetworkCmd com.cloud.exception.InvalidParameterValueException: NetworkOffering and domain suffix upgrade can be perfomed for Isolated networks only at com.cloud.network.NetworkServiceImpl.updateGuestNetwork(NetworkServiceImpl .java:1982) at com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorD ispatcher.intercept(ComponentInstantiationPostProcessor.java:125) Exception from here: // network offering and domain suffix can be updated for Isolated networks only in 3.0 if ((networkOfferingId != null || domainSuffix !=
Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23779 --- Ship it! Nice work! patches/systemvm/debian/config/root/dnsmasq.sh https://reviews.apache.org/r/12810/#comment47626 Typo here. I would fix it when check in the patch. - Sheng Yang On July 24, 2013, 10:28 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- (Updated July 24, 2013, 10:28 a.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Bugs: CLOUDSTACK-3694 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3694 wrote the dnsmasq config in bash instead of creating the config file in java and overwriting. Diffs - core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 0b26220 core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df patches/systemvm/debian/config/etc/init.d/cloud-early-config c04ff90 patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java c7f487e plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f80d4b6 scripts/vm/hypervisor/xenserver/vmops f8c0253 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6c0f7a1 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 7a4bf50 Diff: https://reviews.apache.org/r/12810/diff/ Testing --- Tested on old master using xenserver. Could not test on the latest one as it is broken. Thanks, bharat kumar
Review Request 12912: Fix for packaging defect CLOUDSTACK-2133
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12912/ --- Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den Hollander. Bugs: CLOUDSTACK-2133 Repository: cloudstack-git Description --- The Cisco VNMC xml files are present under plugins/network-elements/cisco-vnmc/scripts/network/cisco. All xml files present there needs to be included in the build package. Diffs - packaging/centos63/cloud.spec 61e00bd Diff: https://reviews.apache.org/r/12912/diff/ Testing --- Tested Thanks, Rayees Namathponnan
Re: Inclusion of commons-httpclient-contrib jar
We just need to include it in the legal docs. It's compatible, but all external code and dependencies need to be accounted for. I see that this is from the ASF actually, so adding it is easy. I'll take a look at doing it shortly. On Wed, Jul 24, 2013 at 2:28 PM, Frank Zhang frank.zh...@citrix.com wrote: Amogh has checked it's Apache 2. I am not sure if any process we need to go through -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 11:24 AM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Nobody has bothered to deal with the LICENSE file for the file described below. Anyone want to take this on, or at least give me the information required? On Wed, Jul 24, 2013 at 05:59:59PM +, Frank Zhang wrote: Agree. Amogh actually has done it in cloud-utils -Original Message- From: Koushik Das [mailto:koushik@citrix.com] Sent: Wednesday, July 24, 2013 10:26 AM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar For now I think cloud-utils is the best option. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Wednesday, July 24, 2013 10:48 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : Warning: not-yet-commons-ssl-0.3.11 should be considered to be of Alpha quality! I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should go ahead with it. Thanks, Amogh On 7/23/13 10:51 PM, Alex Huang alex.hu...@citrix.com wrote: Amogh, I added the following to the pom.xml for cisco and it seems to compile with a few extra exceptions try-catch added. Can you check on if you can use this? dependency groupIdca.juliusdavies/groupId artifactIdnot-yet-commons-ssl/artifactId version0.3.11/version /dependency --Alx -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in commons-httpclient 3.1? http://grepcode.com/file/repo1.maven.org/maven2/commons- httpclient/commons- httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/EasyX5 09Tr us tM anager.java --Alex -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:41 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar +1 @Frank, it is not a re-implementation, but a copy. On 7/24/13 2:14 AM, Amogh Vasekar amogh.vase...@citrix.com wrote: In the absence of an officially published jar on maven for contrib-ssl, the current idea is to put this package in cloud-utils (it is a dependency for both cisco-vnmc and ucs) for easier maintenance. Please let me know if this sounds good. Thanks, Amogh On 7/22/13 5:26 PM, Frank Zhang frank.zh...@citrix.com wrote: I prefer to just use httpclient-contribs.jar as it has been proven by lots of users. Reimplementing such code brings no gain but maintenance effort. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Monday, July 22, 2013 5:17 PM To: dev@cloudstack.apache.org Subject: Inclusion of commons-httpclient-contrib jar Hi All, I was working on a HTTPS related fix, and found this package in the codebase : https://github.com/apache/cloudstack/tree/master/plugins/networ k- elements/c isco-vnmc/src/org/apache/commons/httpclient/contrib/ssl I need to use the same classes, which are already a part of httpclient-contribs jar (http://www.java2s.com/Code/Jar/c/Downloadcommonshttpclientcon tr ib31jar. htm ) Was wondering if there is a specific reason the jar was not included instead (probably since it is a contrib jar?) Thanks, Amogh
RE: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs
Ok, I don't like changing this enum. I'd rather throw it out and start over but you are answering the question by sharing your views on school of programming, i think. BroadcastDomainType by its name implies it could be unknown but never undecided. Do you agree? I can comply with any school. Op 24 jul. 2013 19:19 schreef Alex Huang alex.hu...@citrix.com het volgende: Daan, ** ** Sorry for the late reply. Now, it kinda goes into code/design philosophy. I’ll tell you what mine is. ** ** There’s one school of thought that code should cover all bases. To me having undecided is in that school because it asks “could it be undecided” and the answer is of course yes because in cs everything is possible. ** ** The other is to say Undecided is never accepted because the code can never do anything with that. Having assert to tell developers that this is just not used in this manner and speaks louder and more accurate than an Undecided. I’m more in this school. I think it should ask the question “should it be undecided”. ** ** --Alex ** ** *From:* Daan Hoogland [mailto:daan.hoogl...@gmail.com] *Sent:* Sunday, July 21, 2013 8:37 AM *To:* Alex Huang *Cc:* Hugo Trippaers; cloudstack *Subject:* Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs ** ** Your remarks on the assert resembles a comment in the code that I didn't write ;) But seriously; If the string contains a scheme that is not in the enum, you want a exception to be thrown instead of UnDecided or UnDefined? regards, ** ** On Sun, Jul 21, 2013 at 5:32 PM, Alex Huang alex.hu...@citrix.com wrote: Daan, I’m not sure I understand what you’re saying here. --Alex *From:* Daan Hoogland [mailto:daan.hoogl...@gmail.com] *Sent:* Sunday, July 21, 2013 4:23 AM *To:* Alex Huang *Cc:* Hugo Trippaers; cloudstack *Subject:* Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs Alex, I saw you put you comments in the commit as comment...??? why not as code then? On Sat, Jul 20, 2013 at 3:42 PM, Alex Huang alex.hu...@citrix.com wrote: Daan, It should assert and throw a CloudRuntimeException. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Exceptions+and+logging --Alex *From:* Daan Hoogland [mailto:daan.hoogl...@gmail.com] *Sent:* Saturday, July 20, 2013 3:25 AM *To:* Alex Huang *Cc:* Hugo Trippaers; cloudstack *Subject:* Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs Alex, it falls through to 'UnDecided' if not known. Do you mean it should throw something? or maybe add an extra 'UnDefined'? On Fri, Jul 19, 2013 at 5:31 PM, Alex Huang alex.hu...@citrix.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12685/ Ship it! master: 2d4464d One review comment is if you are checking for the colon to see if the value has the schema already, then shouldn't it also check if the schema matches what's declared? But that shouldn't block this review. The code itself is technically sound. - Alex Huang On July 17th, 2013, 3:46 p.m. UTC, daan Hoogland wrote: Review request for cloudstack and Hugo Trippaers. By daan Hoogland. *Updated July 17, 2013, 3:46 p.m.* *Bugs: *CLOUDSTACK-1532 *Repository: *cloudstack-git Description the review for the complete patch was open to long and no longer applicable, so I am starting with smaller patches as this is really needed to implement CLOUDSTACK-1532 Testing unit testing Diffs - api/src/com/cloud/network/Networks.java (5aede05) - api/test/com/cloud/network/NetworksTest.java (PRE-CREATION) View Diff https://reviews.apache.org/r/12685/diff/ ** **
RE: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs
Daan, Agreed. If it's unknown, the variable of that type can just be null which is an accepted practice for saying the business logic hasn't determined the value yet. --Alex From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Wednesday, July 24, 2013 12:41 PM To: Alex Huang Cc: cloudstack Subject: RE: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs Ok, I don't like changing this enum. I'd rather throw it out and start over but you are answering the question by sharing your views on school of programming, i think. BroadcastDomainType by its name implies it could be unknown but never undecided. Do you agree? I can comply with any school. Op 24 jul. 2013 19:19 schreef Alex Huang alex.hu...@citrix.commailto:alex.hu...@citrix.com het volgende: Daan, Sorry for the late reply. Now, it kinda goes into code/design philosophy. I'll tell you what mine is. There's one school of thought that code should cover all bases. To me having undecided is in that school because it asks could it be undecided and the answer is of course yes because in cs everything is possible. The other is to say Undecided is never accepted because the code can never do anything with that. Having assert to tell developers that this is just not used in this manner and speaks louder and more accurate than an Undecided. I'm more in this school. I think it should ask the question should it be undecided. --Alex From: Daan Hoogland [mailto:daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com] Sent: Sunday, July 21, 2013 8:37 AM To: Alex Huang Cc: Hugo Trippaers; cloudstack Subject: Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs Your remarks on the assert resembles a comment in the code that I didn't write ;) But seriously; If the string contains a scheme that is not in the enum, you want a exception to be thrown instead of UnDecided or UnDefined? regards, On Sun, Jul 21, 2013 at 5:32 PM, Alex Huang alex.hu...@citrix.commailto:alex.hu...@citrix.com wrote: Daan, I'm not sure I understand what you're saying here. --Alex From: Daan Hoogland [mailto:daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com] Sent: Sunday, July 21, 2013 4:23 AM To: Alex Huang Cc: Hugo Trippaers; cloudstack Subject: Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs Alex, I saw you put you comments in the commit as comment...??? why not as code then? On Sat, Jul 20, 2013 at 3:42 PM, Alex Huang alex.hu...@citrix.commailto:alex.hu...@citrix.com wrote: Daan, It should assert and throw a CloudRuntimeException. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Exceptions+and+logging --Alex From: Daan Hoogland [mailto:daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com] Sent: Saturday, July 20, 2013 3:25 AM To: Alex Huang Cc: Hugo Trippaers; cloudstack Subject: Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs Alex, it falls through to 'UnDecided' if not known. Do you mean it should throw something? or maybe add an extra 'UnDefined'? On Fri, Jul 19, 2013 at 5:31 PM, Alex Huang alex.hu...@citrix.commailto:alex.hu...@citrix.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12685/ Ship it! master: 2d4464d One review comment is if you are checking for the colon to see if the value has the schema already, then shouldn't it also check if the schema matches what's declared? But that shouldn't block this review. The code itself is technically sound. - Alex Huang On July 17th, 2013, 3:46 p.m. UTC, daan Hoogland wrote: Review request for cloudstack and Hugo Trippaers. By daan Hoogland. Updated July 17, 2013, 3:46 p.m. Bugs: CLOUDSTACK-1532 Repository: cloudstack-git Description the review for the complete patch was open to long and no longer applicable, so I am starting with smaller patches as this is really needed to implement CLOUDSTACK-1532 Testing unit testing Diffs * api/src/com/cloud/network/Networks.java (5aede05) * api/test/com/cloud/network/NetworksTest.java (PRE-CREATION) View Diffhttps://reviews.apache.org/r/12685/diff/
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than add or remove per command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 24, 2013, 8:02 p.m.) Review request for cloudstack and Sheng Yang. Changes --- Fixed UpdatePhysicalNetworkTest and a bug which led to wrong display of the vnet string. Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than add or remove per command Diffs (updated) - api/src/com/cloud/network/NetworkService.java 59ccdbf api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 Diff: https://reviews.apache.org/r/12905/diff/ Testing --- Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Thanks, bharat kumar
KVM devs - notice for 4.2+
FYI, I just pushed a patch that contains a new router script. Existing routers in existing KVM dev environments will need to be rebooted after you pull this in.
RE: Inclusion of commons-httpclient-contrib jar
Thanks Chip. Let me know once you done so I can get Amogh's patch in -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 12:19 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar We just need to include it in the legal docs. It's compatible, but all external code and dependencies need to be accounted for. I see that this is from the ASF actually, so adding it is easy. I'll take a look at doing it shortly. On Wed, Jul 24, 2013 at 2:28 PM, Frank Zhang frank.zh...@citrix.com wrote: Amogh has checked it's Apache 2. I am not sure if any process we need to go through -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 11:24 AM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Nobody has bothered to deal with the LICENSE file for the file described below. Anyone want to take this on, or at least give me the information required? On Wed, Jul 24, 2013 at 05:59:59PM +, Frank Zhang wrote: Agree. Amogh actually has done it in cloud-utils -Original Message- From: Koushik Das [mailto:koushik@citrix.com] Sent: Wednesday, July 24, 2013 10:26 AM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar For now I think cloud-utils is the best option. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Wednesday, July 24, 2013 10:48 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : Warning: not-yet-commons-ssl-0.3.11 should be considered to be of Alpha quality! I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should go ahead with it. Thanks, Amogh On 7/23/13 10:51 PM, Alex Huang alex.hu...@citrix.com wrote: Amogh, I added the following to the pom.xml for cisco and it seems to compile with a few extra exceptions try-catch added. Can you check on if you can use this? dependency groupIdca.juliusdavies/groupId artifactIdnot-yet-commons-ssl/artifactId version0.3.11/version /dependency --Alx -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in commons-httpclient 3.1? http://grepcode.com/file/repo1.maven.org/maven2/commons- httpclient/commons- httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/Ea syX5 09Tr us tM anager.java --Alex -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:41 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar +1 @Frank, it is not a re-implementation, but a copy. On 7/24/13 2:14 AM, Amogh Vasekar amogh.vase...@citrix.com wrote: In the absence of an officially published jar on maven for contrib-ssl, the current idea is to put this package in cloud-utils (it is a dependency for both cisco-vnmc and ucs) for easier maintenance. Please let me know if this sounds good. Thanks, Amogh On 7/22/13 5:26 PM, Frank Zhang frank.zh...@citrix.com wrote: I prefer to just use httpclient-contribs.jar as it has been proven by lots of users. Reimplementing such code brings no gain but maintenance effort. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Monday, July 22, 2013 5:17 PM To: dev@cloudstack.apache.org Subject: Inclusion of commons-httpclient-contrib jar Hi All, I was working on a HTTPS related fix, and found this package in the codebase : https://github.com/apache/cloudstack/tree/master/plugins/netwo r k- elements/c isco-vnmc/src/org/apache/commons/httpclient/contrib/s sl I need to use the same classes, which are already a part of httpclient-contribs jar (http://www.java2s.com/Code/Jar/c/Downloadcommonshttpclient
Re: Inclusion of commons-httpclient-contrib jar
Hi, The files are currently in : http://bit.ly/18Ae7zH Thanks, Amogh On 7/24/13 1:22 PM, Chip Childers chip.child...@sungard.com wrote: I don't think you need to wait. I actually need the files in the repo to pick up on them anyway for the docs. On Wed, Jul 24, 2013 at 08:13:59PM +, Frank Zhang wrote: Thanks Chip. Let me know once you done so I can get Amogh's patch in -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 12:19 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar We just need to include it in the legal docs. It's compatible, but all external code and dependencies need to be accounted for. I see that this is from the ASF actually, so adding it is easy. I'll take a look at doing it shortly. On Wed, Jul 24, 2013 at 2:28 PM, Frank Zhang frank.zh...@citrix.com wrote: Amogh has checked it's Apache 2. I am not sure if any process we need to go through -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 11:24 AM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Nobody has bothered to deal with the LICENSE file for the file described below. Anyone want to take this on, or at least give me the information required? On Wed, Jul 24, 2013 at 05:59:59PM +, Frank Zhang wrote: Agree. Amogh actually has done it in cloud-utils -Original Message- From: Koushik Das [mailto:koushik@citrix.com] Sent: Wednesday, July 24, 2013 10:26 AM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar For now I think cloud-utils is the best option. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Wednesday, July 24, 2013 10:48 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : Warning: not-yet-commons-ssl-0.3.11 should be considered to be of Alpha quality! I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should go ahead with it. Thanks, Amogh On 7/23/13 10:51 PM, Alex Huang alex.hu...@citrix.com wrote: Amogh, I added the following to the pom.xml for cisco and it seems to compile with a few extra exceptions try-catch added. Can you check on if you can use this? dependency groupIdca.juliusdavies/groupId artifactIdnot-yet-commons-ssl/artifactId version0.3.11/version /dependency --Alx -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in commons-httpclient 3.1? http://grepcode.com/file/repo1.maven.org/maven2/commons- httpclient/commons- httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/Ea syX5 09Tr us tM anager.java --Alex -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:41 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar +1 @Frank, it is not a re-implementation, but a copy. On 7/24/13 2:14 AM, Amogh Vasekar amogh.vase...@citrix.com wrote: In the absence of an officially published jar on maven for contrib-ssl, the current idea is to put this package in cloud-utils (it is a dependency for both cisco-vnmc and ucs) for easier maintenance. Please let me know if this sounds good. Thanks, Amogh On 7/22/13 5:26 PM, Frank Zhang frank.zh...@citrix.com wrote: I prefer to just use httpclient-contribs.jar as it has been proven by lots of users. Reimplementing such code brings no gain but maintenance effort. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Monday, July 22, 2013 5:17 PM To: dev@cloudstack.apache.org Subject: Inclusion of commons-httpclient-contrib jar Hi All, I was working on a HTTPS related
Re: Automated Tests: Account Cleanup in test modules
On Tue, Jul 23, 2013 at 11:54 PM, Prasanna Santhanam t...@apache.org wrote: On Tue, Jul 23, 2013 at 11:20:22PM -0700, Sheng Yang wrote: About the patch I committed, in fact it's not moving. It's fixing. Because: 1. The logical reason is, currently in many cases(which I committed the patches) the account is already create per test case rather than per module. And if account is created in setUp() rather than setUpClass(), the clean up would be in tearDown() rather than tearDownClass(), because they're useless anyway after setUp create another account and more VMs. My patch didn't move account creation from setUpClass(). Sheng - thanks I saw your patches more clearly now. The diffs mislead me that they were perhaps moved. You're right that the cleanup list should add the account in the locality of where it was created ie per-test or per-module as the case may be. 2. The more direct reason is too many test cases in regression test failed just because lack of resource to create new deployment. E.g. https://issues.apache.org/jira/browse/CLOUDSTACK-3643 . Whenever I saw Fail to create VPC or Fail to deploy VM, mostly it because the testing setup is overloaded. Yes this is a concern. We are mislead by resource exhaustion to be a failure in the test. Do you think the tests could be better organized when run in a group against a limited resource deployment? I can think of following things: 1. The maximum parallel execution test cases number should leave some(but not too much) margin for wrong test cases. 2. Every test case should take care of it's own resources and release them ASAP after they're no longer in use. 3. Reduce the time out for failure operation. E.g. we don't need to wait tens of minutes for SSH timeout. 4. Check for unnecessary and duplicate test cases. If we can get test cases running faster, then they can release the resources sooner. I know VM creating is very time consuming, and reuse the account and VM is really nice! But the fact is many of current test cases is not written in this way. So I think we should release the resource as soon as it's obsolete. Yup that's the way it was intended. We probably deviated from there and will fix these tests during this sprint. About reusing the already deployed VM and account, it would be a case-by-case issue. For example, TestAddVmToSubDomain case in test_accounts do create the two VMs shared across the module(class), then tear it down when in tearDownClass(). But sometime there is not a easy way to do so. I think that's why there are not many VirtualMachine.create() happened in setUpClass(). Agreed on this. Much of this information is within the test cases and until you drill down in the scenario you won't be aware of it. But in general the guidelines probably were not clear (I got questions from others working on the tests) so it was better to spell them out. It's time to write up these guidelines in our wiki which has some basic guidelines already: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python#Marvin-TestingwithPython-Guidelinestochoosescenariosforintegration Yes, I've add some clean up guideline to it. --Sheng Thanks for sharing your thoughts, --Sheng On Tue, Jul 23, 2013 at 10:56 PM, Prasanna Santhanam t...@apache.org wrote: In the test modules when you debug you will notice that accounts are created once per module in setUpClass() all resources created within it and tearDownClass() destroys the account initiating cleanup. All the resources are appended to a cleanup [] list and deleted in appropriate order at the end of the test module in tearDownClass() There are a few reasons for doing this for all the tests in the class at once as opposed to doing it for every test. Modules are grouped by feature eg: test_tags does tags related tests. And more often than not all tests in the module share similar patterns in the set of API calls made to achieve a test scenario. If an account was created per test the overhead of cleaning up is much higher than when cleaning up once per module. Because every new account needs a new VR for the first VM deployed in it. And almost every test will deploy a VM. So this slows down test run significantly and eats up resources like VLANs very quickly which are needed for every account. I saw a few fixes that moved the resource cleanup from tearDownClass() to tearDown and that prompted me to send this email. Hope this makes sense. I'd like to hear other's thoughts on how best to accomplish all the tests in the most optimum way without hurting resources on a deployment. Also - on the test infrastructure on jenkins.buildacloud.org there is no way to timeout a specific test if it takes up more time than necessary. So I'm going to introduce a timeout plugin in nose that will abort the test if it
Re: Review Request 12877: Support HTTP to HTTPS redirect for UCS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12877/#review23782 --- Ship it! shipped in both 4.2/master - Frank Zhang On July 23, 2013, 7:56 p.m., Amogh Vasekar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12877/ --- (Updated July 23, 2013, 7:56 p.m.) Review request for cloudstack and Frank Zhang. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3285 Repository: cloudstack-git Description --- The patch uses EasySSLProtocolFactory from httpclient.contrib.ssl package. The implementation accepts self-signed certificates. This is similar to cloud-plugin-network-cisco-vnmc 's behavior. As a part of the patch, the contrib code has been moved to cloud-utils to avoid duplication. Since there is no maven published jar for contrib, the source currently has the actual code instead. This needs to be revisited. Diffs - plugins/hypervisors/ucs/src/com/cloud/ucs/manager/UcsHttpClient.java 66d2ed2 plugins/network-elements/cisco-vnmc/src/org/apache/commons/httpclient/contrib/ssl/EasySSLProtocolSocketFactory.java 52f0ea6 plugins/network-elements/cisco-vnmc/src/org/apache/commons/httpclient/contrib/ssl/EasyX509TrustManager.java ae9f938 utils/src/org/apache/commons/httpclient/contrib/ssl/EasySSLProtocolSocketFactory.java PRE-CREATION utils/src/org/apache/commons/httpclient/contrib/ssl/EasyX509TrustManager.java PRE-CREATION Diff: https://reviews.apache.org/r/12877/diff/ Testing --- Works on local environment + UCS cisco-vnmc not tested after refactoring Thanks, Amogh Vasekar
Re: Inclusion of commons-httpclient-contrib jar
Right, that's what I thought. Frank, what were you saying you were waiting for? On Wed, Jul 24, 2013 at 08:38:36PM +, Amogh Vasekar wrote: Hi, The files are currently in : http://bit.ly/18Ae7zH Thanks, Amogh On 7/24/13 1:22 PM, Chip Childers chip.child...@sungard.com wrote: I don't think you need to wait. I actually need the files in the repo to pick up on them anyway for the docs. On Wed, Jul 24, 2013 at 08:13:59PM +, Frank Zhang wrote: Thanks Chip. Let me know once you done so I can get Amogh's patch in -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 12:19 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar We just need to include it in the legal docs. It's compatible, but all external code and dependencies need to be accounted for. I see that this is from the ASF actually, so adding it is easy. I'll take a look at doing it shortly. On Wed, Jul 24, 2013 at 2:28 PM, Frank Zhang frank.zh...@citrix.com wrote: Amogh has checked it's Apache 2. I am not sure if any process we need to go through -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 11:24 AM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Nobody has bothered to deal with the LICENSE file for the file described below. Anyone want to take this on, or at least give me the information required? On Wed, Jul 24, 2013 at 05:59:59PM +, Frank Zhang wrote: Agree. Amogh actually has done it in cloud-utils -Original Message- From: Koushik Das [mailto:koushik@citrix.com] Sent: Wednesday, July 24, 2013 10:26 AM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar For now I think cloud-utils is the best option. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Wednesday, July 24, 2013 10:48 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : Warning: not-yet-commons-ssl-0.3.11 should be considered to be of Alpha quality! I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should go ahead with it. Thanks, Amogh On 7/23/13 10:51 PM, Alex Huang alex.hu...@citrix.com wrote: Amogh, I added the following to the pom.xml for cisco and it seems to compile with a few extra exceptions try-catch added. Can you check on if you can use this? dependency groupIdca.juliusdavies/groupId artifactIdnot-yet-commons-ssl/artifactId version0.3.11/version /dependency --Alx -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in commons-httpclient 3.1? http://grepcode.com/file/repo1.maven.org/maven2/commons- httpclient/commons- httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/Ea syX5 09Tr us tM anager.java --Alex -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:41 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar +1 @Frank, it is not a re-implementation, but a copy. On 7/24/13 2:14 AM, Amogh Vasekar amogh.vase...@citrix.com wrote: In the absence of an officially published jar on maven for contrib-ssl, the current idea is to put this package in cloud-utils (it is a dependency for both cisco-vnmc and ucs) for easier maintenance. Please let me know if this sounds good. Thanks, Amogh On 7/22/13 5:26 PM, Frank Zhang frank.zh...@citrix.com wrote: I prefer to just use httpclient-contribs.jar as it has been proven by lots of users. Reimplementing such code brings no gain but maintenance effort. -Original
Re: Review Request 12242: CLOUDSTACK-3302: [Multiple_IP_Ranges][VmWare] VM deployement failed due to dnsmasq configuration issue in case of multiple subnets in a vlan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12242/#review23783 --- Commit d09a088093568f167921597825110d5517ac535b in branch refs/heads/4.2 from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d09a088 ] CLOUDSTACK-3302: [Multiple_IP_Ranges][VmWare] VM deployement failed due to dnsmasq configuration issue in case of multiple subnets in a vlan Signed-off-by: Abhinandan Prateek aprat...@apache.org - ASF Subversion and Git Services On July 3, 2013, 11:08 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12242/ --- (Updated July 3, 2013, 11:08 a.m.) Review request for cloudstack and Abhinandan Prateek. Bugs: CLOUDSTACK-3302 Repository: cloudstack-git Description --- CLOUDSTACK-3302: [Multiple_IP_Ranges][VmWare] VM deployement failed due to dnsmasq configuration issue in case of multiple subnets in a vlan Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 46e5cf9 Diff: https://reviews.apache.org/r/12242/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
RE: Inclusion of commons-httpclient-contrib jar
No. I have checked in the patch -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 1:46 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Right, that's what I thought. Frank, what were you saying you were waiting for? On Wed, Jul 24, 2013 at 08:38:36PM +, Amogh Vasekar wrote: Hi, The files are currently in : http://bit.ly/18Ae7zH Thanks, Amogh On 7/24/13 1:22 PM, Chip Childers chip.child...@sungard.com wrote: I don't think you need to wait. I actually need the files in the repo to pick up on them anyway for the docs. On Wed, Jul 24, 2013 at 08:13:59PM +, Frank Zhang wrote: Thanks Chip. Let me know once you done so I can get Amogh's patch in -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 12:19 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar We just need to include it in the legal docs. It's compatible, but all external code and dependencies need to be accounted for. I see that this is from the ASF actually, so adding it is easy. I'll take a look at doing it shortly. On Wed, Jul 24, 2013 at 2:28 PM, Frank Zhang frank.zh...@citrix.com wrote: Amogh has checked it's Apache 2. I am not sure if any process we need to go through -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, July 24, 2013 11:24 AM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Nobody has bothered to deal with the LICENSE file for the file described below. Anyone want to take this on, or at least give me the information required? On Wed, Jul 24, 2013 at 05:59:59PM +, Frank Zhang wrote: Agree. Amogh actually has done it in cloud-utils -Original Message- From: Koushik Das [mailto:koushik@citrix.com] Sent: Wednesday, July 24, 2013 10:26 AM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar For now I think cloud-utils is the best option. -Original Message- From: Amogh Vasekar [mailto:amogh.vase...@citrix.com] Sent: Wednesday, July 24, 2013 10:48 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar Hi Alex, Thanks! I had looked at that initially, but found this disclaimer on the source website : Warning: not-yet-commons-ssl-0.3.11 should be considered to be of Alpha quality! I do not see a code update in it for the past 4 years, and thus was skeptical. Please let me know if we should go ahead with it. Thanks, Amogh On 7/23/13 10:51 PM, Alex Huang alex.hu...@citrix.com wrote: Amogh, I added the following to the pom.xml for cisco and it seems to compile with a few extra exceptions try-catch added. Can you check on if you can use this? dependency groupIdca.juliusdavies/groupId artifactIdnot-yet-commons-ssl/artifactId version0.3.11/version /dependency --Alx -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Tuesday, July 23, 2013 10:25 PM To: dev@cloudstack.apache.org Subject: RE: Inclusion of commons-httpclient-contrib jar Isn't this in commons-httpclient 3.1? http://grepcode.com/file/repo1.maven.org/maven2/comm ons- httpclient/commons- httpclient/3.1/org/apache/commons/httpclient/contrib/ssl/Ea syX5 09Tr us tM anager.java --Alex -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Tuesday, July 23, 2013 9:41 PM To: dev@cloudstack.apache.org Subject: Re: Inclusion of commons-httpclient-contrib jar +1 @Frank, it is not a re-implementation, but a copy. On 7/24/13 2:14 AM, Amogh Vasekar amogh.vase...@citrix.com wrote: In the absence of an officially published jar on maven for contrib-ssl, the current idea is to put this package in cloud-utils (it is a dependency for both
Re: Review Request 12883: DNS value in Zone is not getting set in the Network created for the Zone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12883/#review23785 --- After thinking about this some more I think a better way to fix this problem is to have the UI leave this NULL and have the Network Manager fill in the value by looking up the value in the Network, if it is NULL then lookup the value in the Zone. This behavior will avoid having additional code to handle the case where the Zone DNS field is updated. I will look at this some more and submitted another patch for this problem. - Soheil Eizadi On July 23, 2013, 10:03 p.m., Soheil Eizadi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12883/ --- (Updated July 23, 2013, 10:03 p.m.) Review request for cloudstack. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3754 Repository: cloudstack-git Description --- DNS value in Zone is not getting set in the Network created for the Zone. Due to this the prepare and release calls to the Network Plugins are missing this information for the VMs. see Jira bug https://issues.apache.org/jira/browse/CLOUDSTACK-3754 for additional details. Administrators-MacBook-Pro-7:cloudstack seizadi$ git diff diff --git a/ui/scripts/zoneWizard.js b/ui/scripts/zoneWizard.js index cb92c4e..9885b1d 100755 --- a/ui/scripts/zoneWizard.js +++ b/ui/scripts/zoneWizard.js @@ -3084,7 +3084,9 @@ zoneid: args.data.returnedZone.id, name: 'defaultGuestNetwork', displaytext: 'defaultGuestNetwork', - networkofferingid: args.data.zone.networkOfferingId + networkofferingid: args.data.zone.networkOfferingId, + networkDomain: args.data.returnedZone.domain }; //Advanced zone with SG Diffs - Diff: https://reviews.apache.org/r/12883/diff/ Testing --- Created Basic Network with Wizard and validated with FireFox debugger that value was properly set and validated with CloudMonkey that the defaultGuestNetwork created had the DNS Domain value set. I noted that there are other Ajax calls in UI that createNetwork() and don't set this field, also there is a use case where the zone value can be modified and this value would need to be updated in the attached Networks. So I would not close the Jira bug until those additional cases are fixed in the UI. Thanks, Soheil Eizadi
Re: Review Request 12883: DNS value in Zone is not getting set in the Network created for the Zone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12883/#review23786 --- After thinking about this some more I think a better way to fix this problem is to have the UI leave this NULL and have the Network Manager fill in the value by looking up the value in the Network, if it is NULL then lookup the value in the Zone. This behavior will avoid having additional code to handle the case where the Zone DNS field is updated. I will look at this some more and submitted another patch for this problem. - Soheil Eizadi On July 23, 2013, 10:03 p.m., Soheil Eizadi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12883/ --- (Updated July 23, 2013, 10:03 p.m.) Review request for cloudstack. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3754 Repository: cloudstack-git Description --- DNS value in Zone is not getting set in the Network created for the Zone. Due to this the prepare and release calls to the Network Plugins are missing this information for the VMs. see Jira bug https://issues.apache.org/jira/browse/CLOUDSTACK-3754 for additional details. Administrators-MacBook-Pro-7:cloudstack seizadi$ git diff diff --git a/ui/scripts/zoneWizard.js b/ui/scripts/zoneWizard.js index cb92c4e..9885b1d 100755 --- a/ui/scripts/zoneWizard.js +++ b/ui/scripts/zoneWizard.js @@ -3084,7 +3084,9 @@ zoneid: args.data.returnedZone.id, name: 'defaultGuestNetwork', displaytext: 'defaultGuestNetwork', - networkofferingid: args.data.zone.networkOfferingId + networkofferingid: args.data.zone.networkOfferingId, + networkDomain: args.data.returnedZone.domain }; //Advanced zone with SG Diffs - Diff: https://reviews.apache.org/r/12883/diff/ Testing --- Created Basic Network with Wizard and validated with FireFox debugger that value was properly set and validated with CloudMonkey that the defaultGuestNetwork created had the DNS Domain value set. I noted that there are other Ajax calls in UI that createNetwork() and don't set this field, also there is a use case where the zone value can be modified and this value would need to be updated in the attached Networks. So I would not close the Jira bug until those additional cases are fixed in the UI. Thanks, Soheil Eizadi
Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script
On July 24, 2013, 6:50 p.m., Sheng Yang wrote: Nice work! Fixed version pushed to 4.2 and MASTER. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23779 --- On July 24, 2013, 10:28 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ --- (Updated July 24, 2013, 10:28 a.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Bugs: CLOUDSTACK-3694 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3694 wrote the dnsmasq config in bash instead of creating the config file in java and overwriting. Diffs - core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 0b26220 core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df patches/systemvm/debian/config/etc/init.d/cloud-early-config c04ff90 patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java c7f487e plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f80d4b6 scripts/vm/hypervisor/xenserver/vmops f8c0253 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6c0f7a1 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 7a4bf50 Diff: https://reviews.apache.org/r/12810/diff/ Testing --- Tested on old master using xenserver. Could not test on the latest one as it is broken. Thanks, bharat kumar
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than add or remove per command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 24, 2013, 9:57 p.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Changes --- Add Alena as reviewer. Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than add or remove per command Diffs - api/src/com/cloud/network/NetworkService.java 59ccdbf api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 Diff: https://reviews.apache.org/r/12905/diff/ Testing --- Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Thanks, bharat kumar
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than add or remove per command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/#review23793 --- 1) Bharat, can you please check if your API allows you to set the vnet range with the multiple ranges. The command syntax should be like this - vnets should be specified and separated by comma: http://localhost:8096/?command=updatePhysicalNetworkid=200vlan=2001-2010,2012-2013 2) Also I find it very confusing that you are continuing to store the vnet field in physical_network table. Once the ranges were introduced, you should have moved them to the separate data structure as its very hard to update/validate the String representation as every single time you have to * split the ranges * validate each range against the new range you pass in - Alena Prokharchyk On July 24, 2013, 9:57 p.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 24, 2013, 9:57 p.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than add or remove per command Diffs - api/src/com/cloud/network/NetworkService.java 59ccdbf api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 Diff: https://reviews.apache.org/r/12905/diff/ Testing --- Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Thanks, bharat kumar
