Re: devcloud - new version (0.2) ready for testing

[chris snow]

Hi Ian,

Thanks for the link - I'm uploading to dropbox now (2 hours remaining).

I'll also take a look at sourceforge or github (although github
doesn't seem to like large files being uploaded, so I don't know how
2creatives get around that).

Best regards,

Chris

On Tue, Feb 25, 2014 at 4:38 AM, Ian Duffy  wrote:
> Hi Chris,
>
> Started testing this but the box was very slow to download averaging 282k/s
>
> Any chance of pushing the images into the "releases" section on github or
> the gh-pages branch to allow direct and faster downloading (5.0 MB/s
> average for me) from github's cdn?
>
> Like this project does:
> https://github.com/2creatives/vagrant-centos/releases
>
>
> On 24 February 2014 17:21, chris snow  wrote:
>
>> There is a new version of devcloud (version 0.2) ready for testing.
>>
>> The main change in this version is an upgrade to debian 7.4 and fix
>> for issue 14 [1]
>>
>> Instructions for running the vagrant box are here [2].
>>
>> This release has an issue with nfs [3].  Suggestions welcome for
>> fixing the issue.  Please report any new issues on the git hub project
>> page.
>>
>> Many thanks,
>>
>> Chris
>>
>> ---
>> [1] https://github.com/snowch/devcloud/issues/14
>> [2] https://github.com/snowch/devcloud/blob/master/README-minimal-box.md
>> [3] https://github.com/snowch/devcloud/issues/15
>>



-- 
Check out my professional profile and connect with me on LinkedIn.
http://lnkd.in/cw5k69

RE: Review Request 18310: dnsmasq fix for bridged networks

[Joris van Lieshout]

Hi Sheng,

Based on your feedback I did some testing and it appears that the issue is not 
with offering addresses but with dhcp-options. The static option indeed 
prevents addresses being leased to unknown macs but it does not prevent other 
dhcp-options, like dns servers, to be handed out. So far I have not been able 
to find any supporting documentation on this behavior but perhaps this 
explanation is sufficient.

What happens is that dhcp client on the other side of the bridge (physical Lan) 
don't get addresses from dnsmasq on the RVM but do get dhcp-option 6 from the 
dnsmasq on the RVM.

This is a bit of (scrutinized) logging where "dhcp-ignore=tag:!known" has been 
disabled (so here non ACS hosts are getting dns server settings from the RVM):
Feb 25 00:00:00 dnsmasq-dhcp[5017]: DHCPINFORM(eth0) 10.xxx.xxx.104 
xx:xx:xx:xx:xx:xx 
Feb 25 00:00:00 dnsmasq-dhcp[5017]: DHCPACK(eth0) 10.xxx.xxx.104 
xx:xx:xx:xx:xx:xx LAPTOP001

And here with "dhcp-ignore=tag:!known" enabled:
Feb 25 00:00:00 dnsmasq-dhcp[5079]: DHCPINFORM(eth0) 10...104 
xx:xx:xx:xx:xx:xx ignored

In both cases the dhcp-range option is set to by ACS:
dhcp-range=10.xxx.xxx.1,static

Kind regards, 
Joris van Lieshout

-Original Message-
From: Sheng Yang [mailto:sh...@yasker.org] 
Sent: maandag 24 februari 2014 23:30
To: Joris van Lieshout
Cc: daan Hoogland; Hugo Trippaers; cloudstack
Subject: Re: Review Request 18310: dnsmasq fix for bridged networks

Yes, it would provide extra failsafe.

But the issue is if there is anything wrong, this patch may or may not
prevent it. So I think it's necessary to identify the root cause
first.

The dhcp-range option already specified as "static" which means:


The optional  keyword may be static which tells dnsmasq to
enable DHCP for the network specified, but not to dynamically allocate
IP addresses: only hosts which have static addresses given via
dhcp-host or from /etc/ethers will be served. A static-only subnet
with address all zeros may be used as a "catch-all" address to enable
replies to all Information-request packets on a subnet which is
provided with stateless DHCPv6, ie --dhcp=range=::,static


So it should already served the purpose.

--Sheng

On Sat, Feb 22, 2014 at 9:28 AM, Joris van Lieshout
 wrote:
> Hi Sheng,
>
> First of thanks you for reviewing my first attempt to contribute :) and
> sorry for my late response. I want to gadder a bit more info because I've
> seen it hand out adresses. Besides that this setting should at least provide
> an extra failsafe.
>
> Regards, Joris
>
> Sent from my iPhone
>
> On 21 feb. 2014, at 20:00, "Sheng Yang"  wrote:
>
> Hi Joris,
>
> This patch hasn't been applied yet, sorry for my second thought.
>
> Could you comment on it?
>
> --Sheng
>
>
> On Thu, Feb 20, 2014 at 10:29 AM, Sheng Yang  wrote:
>>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/18310/
>>
>> On February 20th, 2014, 6:17 p.m. UTC, Sheng Yang wrote:
>>
>> Looks good to me.
>>
>> Also I've confirmed that even with this option, the MAC would show in
>> dnsmasq.log, which is necessary for debug.
>>
>> Applied to MASTER. Thanks!
>>
>> On February 20th, 2014, 6:28 p.m. UTC, Sheng Yang wrote:
>>
>> One moment, on a second thought, even with current setup, dnsmasq won't
>> hand out IP to unknown host. So why this option is needed?
>>
>> And the log would show "DHCPDISCOVER(eth0) 02:01:3a:d9:00:02 no address
>> available" instead of "DHCPDISCOVER(eth0) 02:01:3a:d9:00:02 ignored" with
>> the option.
>>
>> Is there anything I missed?
>>
>> And the patch hasn't been applied yet...
>>
>>
>> - Sheng
>>
>>
>> On February 20th, 2014, 2:01 p.m. UTC, Joris van Lieshout wrote:
>>
>> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng
>> Yang.
>> By Joris van Lieshout.
>>
>> Updated Feb. 20, 2014, 2:01 p.m.
>>
>> Repository: cloudstack-git
>>
>> Description
>>
>> When a ACS network is bridged to another non-ACS network (for instance
>> using a NSX Bridge) this will prevent dnsmasq from responding to requests
>> from the other network that have traversed the bridge.
>>
>> Testing
>>
>> We have been running this fix on our own version of the 4.2 and 3.0 SVM
>> for a couple months with success.
>>
>> Diffs
>>
>> systemvm/patches/debian/config/etc/dnsmasq.conf.tmpl (07c5902)
>>
>> View Diff
>
>

RE: [4.3] Cherry pick b44901c059e50ae34f55a56809cda74d4c0c08f9

[Rajesh Battala]

This commit will resolve the issue 
https://issues.apache.org/jira/browse/CLOUDSTACK-6159 

Thanks
Rajesh Battala

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] 
Sent: Tuesday, February 25, 2014 11:39 AM
To: dev@cloudstack.apache.org; Animesh Chaturvedi
Subject: [4.3] Cherry pick b44901c059e50ae34f55a56809cda74d4c0c08f9

Hi Animesh,
Can you please cherry-pick b44901c059e50ae34f55a56809cda74d4c0c08f9.
Code change is only to the hyper-v agent code.

Thanks
Rajesh Battala

[4.3] Cherry pick b44901c059e50ae34f55a56809cda74d4c0c08f9

[Rajesh Battala]

Hi Animesh,
Can you please cherry-pick b44901c059e50ae34f55a56809cda74d4c0c08f9.
Code change is only to the hyper-v agent code.

Thanks
Rajesh Battala

RE: [PROPOSAL] Windowsfication Of ACS

[Damoder Reddy]

Hi Alex,

 Apart from agent scripts, there are couple of scripts those gets executed for 
during the management server startup like injecting ssh keys into systemvm.iso 
etc.. Still I am in search of any other scripts will get called in management 
server, though I could not find any as of now.

Thanks & Regards
Damodar/

-Original Message-
From: Alex Huang [mailto:alex.hu...@citrix.com] 
Sent: Tuesday, February 25, 2014 10:10 AM
To: dev@cloudstack.apache.org
Subject: RE: [PROPOSAL] Windowsfication Of ACS

Abhi,

I think you misunderstood.  I meant that it should not depend on things later 
releases like .net framework.  See the following wiki page.

http://en.wikipedia.org/wiki/.NET_Framework#Versions

I would imagine .net framework 3 or 3.5 would be ideal.  If you use .net 
framework 4, then libraries need to be installed and they sometimes have 
conflicts with existing apps.  


As for python or shell scripts, I don't see why we should need any python 
scripts on management server, regardless if it's windows or Linux.  Python 
scripts can be included and executed by agents on Linux systems but I don't see 
a place for them on the management server.  For windows, specifically, asking a 
windows admin to install python is not unlike asking them to install Cygwin.

--Alex

> -Original Message-
> From: Abhinandan Prateek [mailto:abhinandan.prat...@citrix.com]
> Sent: Monday, February 24, 2014 8:31 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] Windowsfication Of ACS
> 
> Yes, that is one of the objective to make MS not dependant on cygwin 
> or any other windows tools and utilities. The bash scripts are all converted 
> to Python.
> 
> -abhi
> 
> 
> On 25/02/14 12:06 am, "Alex Huang"  wrote:
> 
> >One additional requirement I have would be don't use any windows 
> >components that don't come with the default systems targeted.  I know 
> >it sounds great to use the latest and greatest but actually the end 
> >users will have to install that and it may mess with their existing 
> >setup.  In this proposal, the purely windows parts are fairly basic 
> >parts of windows.  Don't bind it to libraries that require 
> >installation of additional libraries.
> >
> >--Alex
> >
> >> -Original Message-
> >> From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
> >> Sent: Friday, February 21, 2014 1:00 AM
> >> To: dev@cloudstack.apache.org
> >> Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >>
> >> I prefer the focus on support that comes with David's suggestion.
> >>Targeting
> >> the latest stable release for a new platform greatly reduces the 
> >>number of  permutations to test.
> >>
> >> Pursuing legacy systems limits the flexibility of ACS to evolve.  
> >>For instance,  we'll probably be on Java 7 in the next while, and 
> >>W2K3 doesn't appear on  the supported system list (see 
> >>https://www.java.com/en/download/help/sysreq.xml).  Likewise, older 
> >>versions of Internet Explorer can be quite different than what 
> >>Microsoft has  recently published.
> >>
> >> My guess is that the engineering effort to get ACS working on a 
> >> legacy system makes sense as a consultancy service offered 
> >> independent
> to ACS.
> >> That's the case of OS/2 support ;)
> >>
> >>
> >> DL
> >>
> >>
> >> > -Original Message-
> >> > From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
> >> > Sent: 20 February 2014 14:29
> >> > To: dev@cloudstack.apache.org
> >> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >> >
> >> > I agree totally, my point was that while there is nothing 
> >> > technically stopping us going for w2k3 there is little reason to do so.
> >> >
> >> >
> >> > Regards
> >> >
> >> > Alex Hitchins
> >> >
> >> > D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
> >> >
> >> > alex.hitch...@shapeblue.com
> >> >
> >> > -Original Message-
> >> > From: David Nalley [mailto:da...@gnsa.us]
> >> > Sent: 20 February 2014 13:24
> >> > To: dev@cloudstack.apache.org
> >> > Subject: Re: [PROPOSAL] Windowsfication Of ACS
> >> >
> >> > There's a difference in incidentally working and validated to work on.
> >> > I'd limit focus to making sure it works on 2k12r2.
> >> >
> >> > --David
> >> >
> >> > On Thu, Feb 20, 2014 at 6:37 AM, Alex Hitchins 
> >> >  wrote:
> >> > > I can't think of anything that wouldn't be possible on W2k3 - 
> >> > > that said It's
> >> > old and I can't see people having a need for it.
> >> > >
> >> > >
> >> > > Regards
> >> > >
> >> > > Alex Hitchins
> >> > >
> >> > > D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
> >> > >
> >> > > alex.hitch...@shapeblue.com
> >> > >
> >> > > -Original Message-
> >> > > From: Paul Angus [mailto:paul.an...@shapeblue.com]
> >> > > Sent: 20 February 2014 11:17
> >> > > To: dev@cloudstack.apache.org
> >> > > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >> > >
> >> > > Isn't the hyper-v support dependant on using 2012r2 ?
> >> > >
> >> > > So I don't know if I'd bother w

Re: Yet another mail on code quality

[Marcus]

Sometimes it's not easy to revert the commit, I suppose a bug should
be raised and assigned to the individual, in that case. For example,
someone branches and then merges without pulling in fixes that
occurred in between, this is fairly common and can be painful when
file locations are shifted around (as seems to happen quite frequently
between releases), since the old file with the fixes is simply removed
and the new, stale file is left.

On Mon, Feb 24, 2014 at 5:27 PM, Alex Huang  wrote:
> I think we should just revert the commits on problems.  It actually helps the 
> developers because it gives them a chance to redo it in the correct way and 
> hopefully, they gain more understanding of what needs to be done.  At worst, 
> they will remember if penalized enough times.  Sometimes, tough love is 
> necessary.
>
> --Alex
>
>> -Original Message-
>> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
>> Sent: Monday, February 24, 2014 8:15 AM
>> To: 
>> Subject: Yet another mail on code quality
>>
>> Guys,
>>
>> Please pay attention to the code you are committing. Today i fixed a number
>> of issues that were introduced in recent code, these are bugs that could have
>> been prevented from entering master by either testing or running the
>> findbugs checks. One was committed directly, the other one through a
>> reviewed patch.
>>
>>
>> @@ -116,7 +116,7 @@ public class Upgrade430to440 implements DbUpgrade
>> {
>>  if (networkRs.next()) {
>>  String guesttype = networkRs.getString(1);
>>
>> -if (guesttype == 
>> Network.GuestType.Shared.toString()) {
>> +if 
>> (guesttype.equals(Network.GuestType.Shared.toString()))
>> {
>>  pstmtUpdate = conn.prepareStatement("UPDATE
>> `cloud`.`user_ip_address` SET account_id = ?, domain_id= ? WHERE
>> public_ip_address = ?");
>>  pstmtUpdate.setLong(1,vmAccountId);
>>  pstmtUpdate.setLong(2,vmDomainId);
>>
>>
>>
>> @@ -80,11 +80,11 @@ public class LibvirtStoragePoolXMLParser {
>>  String targetPath = getTagValue("path", target);
>>
>>  String portValue = getAttrValue("host", "port", source);
>> -if (portValue != "")
>> +if (portValue != null && !portValue.isEmpty())
>>  port = Integer.parseInt(portValue);
>>
>>  return new
>> LibvirtStoragePoolDef(LibvirtStoragePoolDef.poolType.valueOf(format.toUp
>> perCase()),
>>
>>
>> To help, i've configured the slowbuild to alert if the number of high 
>> priority
>> findings from findbugs differs from the previous run. It will notify all
>> developers that had changes during this period (slowbuild runs every 4
>> hours).
>>
>> Cheers,
>>
>> Hugo

Re: developers and mysql

[Rajani Karuturi]

Can we move the mysql-connector-java dependency to the parent 
POM(SOURCE-ROOT/pom.xml) and define it different scopes for each profile?

ie)



  developer


  mysql
  mysql-connector-java
  compile




production


  mysql
  mysql-connector-java
  provided




Thanks,
~Rajani



On 24-Feb-2014, at 11:41 pm, Hugo Trippaers 
mailto:trip...@gmail.com>> wrote:

Indeed,

I've been fighting with maven all day to get the development profile to include 
MySql. No luck yet, will give it another shot tomorrow :-)

Hugo

Sent from my iPhone

On 24 feb. 2014, at 18:21, David Nalley mailto:da...@gnsa.us>> 
wrote:

So it should be ok to include the jar in non-default builds. developer
and deploydb are not what we'd expect a normal user to consume.
(Anyone else's head spinning?)

--David

On Mon, Feb 24, 2014 at 11:44 AM, John Kinsella 
mailto:j...@stratosec.co>> wrote:
I created CLOUDSTACK-6157 over the weekend to track this. Not sure adding the 
jar after compile will help the deploydb target, but will give it a try this 
morning.

Could we set up the pom.xmls to use the jar for execution if it's found in the 
user/system classpaths while respecting the legal requirements?

Rayees' suggestion for cloud.spec makes sense for the RPM builds, but doesn't 
affect the developer issues.

-He who needs more maven experience

On Feb 24, 2014, at 7:36 AM, Hugo Trippaers 
mailto:h...@trippaers.nl>> wrote:

Heya,

as the mysql dependency is now set to provided in all the poms to fix our 
license compliancy the jetty target and the deployed targets are not working.

I'm trying to configure an optional profile to enable those targets to include 
the mysql dependency while executing, but so far no luck. If anyone has some 
bright ideas on how to do this i'm all ears. In the meantime the best solutions 
i've found to continue working is to copy the mysql jar file into the directory 
client/target/cloud-client-ui-4.4.0-SNAPSHOT/WEB-INF/lib/ by hand after running 
mvm install and before running the jetty target (just don't run mvn clean).

Hopefully a better solution in the near future.

Cheers,

Hugo

Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review35373
---


Commit f501ec694ed94f6417354a24ea44ee09967cf25f in cloudstack's branch 
refs/heads/xenserverJAVA from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f501ec6 ]

CLOUDSTACK-6058: New XenServer 6.2sp1 SDKs

This commit replaces old XenServer SDKs with lastet XenServer release
i.e. 6.2sp1 SDKs. This SDK also includes new class "VGPU" to support
vGPU functionality in XenServer.


- ASF Subversion and Git Services


On Feb. 24, 2014, 5:07 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> ---
> 
> (Updated Feb. 24, 2014, 5:07 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
> https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Update the java bindings that are used in cloudstack with the latest one. 
> There are two parts for this change, 1st one is to replace the java bindings; 
> and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for 
> CloudStack.
> 
> 
> Diffs
> -
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppli

Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review35374
---


Commit 4e0c1bb4e1c4711ed40737fc20fafe6126de733b in cloudstack's branch 
refs/heads/xenserverJAVA from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4e0c1bb ]

CLOUDSTACK-6058: XenServer 6.2sp1 xenapi customization as per CloudStack 
resource code.


- ASF Subversion and Git Services


On Feb. 24, 2014, 5:07 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> ---
> 
> (Updated Feb. 24, 2014, 5:07 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
> https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Update the java bindings that are used in cloudstack with the latest one. 
> There are two parts for this change, 1st one is to replace the java bindings; 
> and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for 
> CloudStack.
> 
> 
> Diffs
> -
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
>   deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
>   deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
>   deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
>   deps/XenServerJava/src/com/

RE: [PROPOSAL] Windowsfication Of ACS

[Alex Huang]

Abhi,

I think you misunderstood.  I meant that it should not depend on things later 
releases like .net framework.  See the following wiki page.

http://en.wikipedia.org/wiki/.NET_Framework#Versions

I would imagine .net framework 3 or 3.5 would be ideal.  If you use .net 
framework 4, then libraries need to be installed and they sometimes have 
conflicts with existing apps.  


As for python or shell scripts, I don't see why we should need any python 
scripts on management server, regardless if it's windows or Linux.  Python 
scripts can be included and executed by agents on Linux systems but I don't see 
a place for them on the management server.  For windows, specifically, asking a 
windows admin to install python is not unlike asking them to install Cygwin.

--Alex

> -Original Message-
> From: Abhinandan Prateek [mailto:abhinandan.prat...@citrix.com]
> Sent: Monday, February 24, 2014 8:31 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] Windowsfication Of ACS
> 
> Yes, that is one of the objective to make MS not dependant on cygwin or any
> other windows tools and utilities. The bash scripts are all converted to 
> Python.
> 
> -abhi
> 
> 
> On 25/02/14 12:06 am, "Alex Huang"  wrote:
> 
> >One additional requirement I have would be don't use any windows
> >components that don't come with the default systems targeted.  I know
> >it sounds great to use the latest and greatest but actually the end
> >users will have to install that and it may mess with their existing
> >setup.  In this proposal, the purely windows parts are fairly basic
> >parts of windows.  Don't bind it to libraries that require installation
> >of additional libraries.
> >
> >--Alex
> >
> >> -Original Message-
> >> From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
> >> Sent: Friday, February 21, 2014 1:00 AM
> >> To: dev@cloudstack.apache.org
> >> Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >>
> >> I prefer the focus on support that comes with David's suggestion.
> >>Targeting
> >> the latest stable release for a new platform greatly reduces the
> >>number of  permutations to test.
> >>
> >> Pursuing legacy systems limits the flexibility of ACS to evolve.  For
> >>instance,  we'll probably be on Java 7 in the next while, and W2K3
> >>doesn't appear on  the supported system list (see
> >>https://www.java.com/en/download/help/sysreq.xml).  Likewise, older
> >>versions of Internet Explorer can be quite different than what
> >>Microsoft has  recently published.
> >>
> >> My guess is that the engineering effort to get ACS working on a
> >> legacy system makes sense as a consultancy service offered independent
> to ACS.
> >> That's the case of OS/2 support ;)
> >>
> >>
> >> DL
> >>
> >>
> >> > -Original Message-
> >> > From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
> >> > Sent: 20 February 2014 14:29
> >> > To: dev@cloudstack.apache.org
> >> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >> >
> >> > I agree totally, my point was that while there is nothing
> >> > technically stopping us going for w2k3 there is little reason to do so.
> >> >
> >> >
> >> > Regards
> >> >
> >> > Alex Hitchins
> >> >
> >> > D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
> >> >
> >> > alex.hitch...@shapeblue.com
> >> >
> >> > -Original Message-
> >> > From: David Nalley [mailto:da...@gnsa.us]
> >> > Sent: 20 February 2014 13:24
> >> > To: dev@cloudstack.apache.org
> >> > Subject: Re: [PROPOSAL] Windowsfication Of ACS
> >> >
> >> > There's a difference in incidentally working and validated to work on.
> >> > I'd limit focus to making sure it works on 2k12r2.
> >> >
> >> > --David
> >> >
> >> > On Thu, Feb 20, 2014 at 6:37 AM, Alex Hitchins
> >> >  wrote:
> >> > > I can't think of anything that wouldn't be possible on W2k3 -
> >> > > that said It's
> >> > old and I can't see people having a need for it.
> >> > >
> >> > >
> >> > > Regards
> >> > >
> >> > > Alex Hitchins
> >> > >
> >> > > D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
> >> > >
> >> > > alex.hitch...@shapeblue.com
> >> > >
> >> > > -Original Message-
> >> > > From: Paul Angus [mailto:paul.an...@shapeblue.com]
> >> > > Sent: 20 February 2014 11:17
> >> > > To: dev@cloudstack.apache.org
> >> > > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >> > >
> >> > > Isn't the hyper-v support dependant on using 2012r2 ?
> >> > >
> >> > > So I don't know if I'd bother with going back as far as 2003
> >> > >
> >> > > Regards,
> >> > >
> >> > > Paul Angus
> >> > > Cloud Architect
> >> > > S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
> >> > > paul.an...@shapeblue.com
> >> > >
> >> > > -Original Message-
> >> > > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> >> > > Sent: 20 February 2014 11:13
> >> > > To: dev@cloudstack.apache.org
> >> > > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >> > >
> >> > > AFAIK, it would be windows server 2k3, 2k8 2012, 2012R2.
> >> > >
> >> 

Re: devcloud - new version (0.2) ready for testing

[Ian Duffy]

Hi Chris,

Started testing this but the box was very slow to download averaging 282k/s

Any chance of pushing the images into the "releases" section on github or
the gh-pages branch to allow direct and faster downloading (5.0 MB/s
average for me) from github's cdn?

Like this project does:
https://github.com/2creatives/vagrant-centos/releases


On 24 February 2014 17:21, chris snow  wrote:

> There is a new version of devcloud (version 0.2) ready for testing.
>
> The main change in this version is an upgrade to debian 7.4 and fix
> for issue 14 [1]
>
> Instructions for running the vagrant box are here [2].
>
> This release has an issue with nfs [3].  Suggestions welcome for
> fixing the issue.  Please report any new issues on the git hub project
> page.
>
> Many thanks,
>
> Chris
>
> ---
> [1] https://github.com/snowch/devcloud/issues/14
> [2] https://github.com/snowch/devcloud/blob/master/README-minimal-box.md
> [3] https://github.com/snowch/devcloud/issues/15
>

Re: [PROPOSAL] Windowsfication Of ACS

[Abhinandan Prateek]

Yes, that is one of the objective to make MS not dependant on cygwin or
any other windows tools and utilities. The bash scripts are all converted
to Python. 

-abhi


On 25/02/14 12:06 am, "Alex Huang"  wrote:

>One additional requirement I have would be don't use any windows
>components that don't come with the default systems targeted.  I know it
>sounds great to use the latest and greatest but actually the end users
>will have to install that and it may mess with their existing setup.  In
>this proposal, the purely windows parts are fairly basic parts of
>windows.  Don't bind it to libraries that require installation of
>additional libraries.
>
>--Alex
>
>> -Original Message-
>> From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
>> Sent: Friday, February 21, 2014 1:00 AM
>> To: dev@cloudstack.apache.org
>> Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> 
>> I prefer the focus on support that comes with David's suggestion.
>>Targeting
>> the latest stable release for a new platform greatly reduces the number
>>of
>> permutations to test.
>> 
>> Pursuing legacy systems limits the flexibility of ACS to evolve.  For
>>instance,
>> we'll probably be on Java 7 in the next while, and W2K3 doesn't appear
>>on
>> the supported system list (see
>> https://www.java.com/en/download/help/sysreq.xml).  Likewise, older
>> versions of Internet Explorer can be quite different than what
>>Microsoft has
>> recently published.
>> 
>> My guess is that the engineering effort to get ACS working on a legacy
>> system makes sense as a consultancy service offered independent to ACS.
>> That's the case of OS/2 support ;)
>> 
>> 
>> DL
>> 
>> 
>> > -Original Message-
>> > From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
>> > Sent: 20 February 2014 14:29
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> >
>> > I agree totally, my point was that while there is nothing technically
>> > stopping us going for w2k3 there is little reason to do so.
>> >
>> >
>> > Regards
>> >
>> > Alex Hitchins
>> >
>> > D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
>> >
>> > alex.hitch...@shapeblue.com
>> >
>> > -Original Message-
>> > From: David Nalley [mailto:da...@gnsa.us]
>> > Sent: 20 February 2014 13:24
>> > To: dev@cloudstack.apache.org
>> > Subject: Re: [PROPOSAL] Windowsfication Of ACS
>> >
>> > There's a difference in incidentally working and validated to work on.
>> > I'd limit focus to making sure it works on 2k12r2.
>> >
>> > --David
>> >
>> > On Thu, Feb 20, 2014 at 6:37 AM, Alex Hitchins
>> >  wrote:
>> > > I can't think of anything that wouldn't be possible on W2k3 - that
>> > > said It's
>> > old and I can't see people having a need for it.
>> > >
>> > >
>> > > Regards
>> > >
>> > > Alex Hitchins
>> > >
>> > > D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
>> > >
>> > > alex.hitch...@shapeblue.com
>> > >
>> > > -Original Message-
>> > > From: Paul Angus [mailto:paul.an...@shapeblue.com]
>> > > Sent: 20 February 2014 11:17
>> > > To: dev@cloudstack.apache.org
>> > > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> > >
>> > > Isn't the hyper-v support dependant on using 2012r2 ?
>> > >
>> > > So I don't know if I'd bother with going back as far as 2003
>> > >
>> > > Regards,
>> > >
>> > > Paul Angus
>> > > Cloud Architect
>> > > S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
>> > > paul.an...@shapeblue.com
>> > >
>> > > -Original Message-
>> > > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
>> > > Sent: 20 February 2014 11:13
>> > > To: dev@cloudstack.apache.org
>> > > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> > >
>> > > AFAIK, it would be windows server 2k3, 2k8 2012, 2012R2.
>> > >
>> > > Thanks
>> > > Rajesh Battala
>> > >
>> > > -Original Message-
>> > > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
>> > > Sent: Thursday, February 20, 2014 4:32 PM
>> > > To: dev@cloudstack.apache.org
>> > > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> > >
>> > > One question I have is, Which version of windows we need to target?
>> > >
>> > > Thanks & Regards
>> > > Damodar/
>> > >
>> > >
>> > > -Original Message-
>> > > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
>> > > Sent: Thursday, February 20, 2014 2:04 PM
>> > > To: dev@cloudstack.apache.org
>> > > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> > >
>> > > I have tried to put all together in FS at
>> >
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Win
>> > dowsfication as Feedback section and added my comments there.
>> > >
>> > > Please verify once and let me know if anything is to be added there.
>> > >
>> > > Thanks & Regards
>> > > Damodar/
>> > >
>> > >
>> > > -Original Message-
>> > > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
>> > > Sent: Thursday, February 20, 2014 12:32 PM
>> > > To: dev@cloudstack.apache.org
>> > > Subject: RE: [PROPOSAL] Windows

RE: developers and mysql

[Alex Huang]

Hugo,

I understand removing mysql jar during compile time by switching the scope to 
'provided', but I don't understand why it's necessary to remove it from jetty 
run and deploy db.  In a normal build, these two targets are not run.  They're 
just convenience targets.

--Alex

> -Original Message-
> From: Hugo Trippaers [mailto:trip...@gmail.com]
> Sent: Monday, February 24, 2014 10:12 AM
> To: dev@cloudstack.apache.org
> Cc: dev@cloudstack.apache.org
> Subject: Re: developers and mysql
> 
> Indeed,
> 
> I've been fighting with maven all day to get the development profile to
> include MySql. No luck yet, will give it another shot tomorrow :-)
> 
> Hugo
> 
> Sent from my iPhone
> 
> > On 24 feb. 2014, at 18:21, David Nalley  wrote:
> >
> > So it should be ok to include the jar in non-default builds. developer
> > and deploydb are not what we'd expect a normal user to consume.
> > (Anyone else's head spinning?)
> >
> > --David
> >
> >> On Mon, Feb 24, 2014 at 11:44 AM, John Kinsella 
> wrote:
> >> I created CLOUDSTACK-6157 over the weekend to track this. Not sure
> adding the jar after compile will help the deploydb target, but will give it 
> a try
> this morning.
> >>
> >> Could we set up the pom.xmls to use the jar for execution if it's found in
> the user/system classpaths while respecting the legal requirements?
> >>
> >> Rayees' suggestion for cloud.spec makes sense for the RPM builds, but
> doesn't affect the developer issues.
> >>
> >> -He who needs more maven experience
> >>
> >>> On Feb 24, 2014, at 7:36 AM, Hugo Trippaers  wrote:
> >>>
> >>> Heya,
> >>>
> >>> as the mysql dependency is now set to provided in all the poms to fix our
> license compliancy the jetty target and the deployed targets are not working.
> >>>
> >>> I'm trying to configure an optional profile to enable those targets to
> include the mysql dependency while executing, but so far no luck. If anyone
> has some bright ideas on how to do this i'm all ears. In the meantime the best
> solutions i've found to continue working is to copy the mysql jar file into 
> the
> directory client/target/cloud-client-ui-4.4.0-SNAPSHOT/WEB-INF/lib/ by
> hand after running mvm install and before running the jetty target (just don't
> run mvn clean).
> >>>
> >>> Hopefully a better solution in the near future.
> >>>
> >>> Cheers,
> >>>
> >>> Hugo
> >>
> >>

RE: Yet another mail on code quality

[Alex Huang]

I think we should just revert the commits on problems.  It actually helps the 
developers because it gives them a chance to redo it in the correct way and 
hopefully, they gain more understanding of what needs to be done.  At worst, 
they will remember if penalized enough times.  Sometimes, tough love is 
necessary.

--Alex

> -Original Message-
> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
> Sent: Monday, February 24, 2014 8:15 AM
> To: 
> Subject: Yet another mail on code quality
> 
> Guys,
> 
> Please pay attention to the code you are committing. Today i fixed a number
> of issues that were introduced in recent code, these are bugs that could have
> been prevented from entering master by either testing or running the
> findbugs checks. One was committed directly, the other one through a
> reviewed patch.
> 
> 
> @@ -116,7 +116,7 @@ public class Upgrade430to440 implements DbUpgrade
> {
>  if (networkRs.next()) {
>  String guesttype = networkRs.getString(1);
> 
> -if (guesttype == 
> Network.GuestType.Shared.toString()) {
> +if 
> (guesttype.equals(Network.GuestType.Shared.toString()))
> {
>  pstmtUpdate = conn.prepareStatement("UPDATE
> `cloud`.`user_ip_address` SET account_id = ?, domain_id= ? WHERE
> public_ip_address = ?");
>  pstmtUpdate.setLong(1,vmAccountId);
>  pstmtUpdate.setLong(2,vmDomainId);
> 
> 
> 
> @@ -80,11 +80,11 @@ public class LibvirtStoragePoolXMLParser {
>  String targetPath = getTagValue("path", target);
> 
>  String portValue = getAttrValue("host", "port", source);
> -if (portValue != "")
> +if (portValue != null && !portValue.isEmpty())
>  port = Integer.parseInt(portValue);
> 
>  return new
> LibvirtStoragePoolDef(LibvirtStoragePoolDef.poolType.valueOf(format.toUp
> perCase()),
> 
> 
> To help, i've configured the slowbuild to alert if the number of high priority
> findings from findbugs differs from the previous run. It will notify all
> developers that had changes during this period (slowbuild runs every 4
> hours).
> 
> Cheers,
> 
> Hugo

Re: [DISCUSS] Policy blocker?

[Nate Gordon]

Just to be thorough, is using provided scope good enough? Sure it doesn't
pull it into the final product and isn't in transitive dependencies, but it
is still downloaded for the compile process. From your previous emails, it
sounded like we can not download it whatsoever during the build. Building
cloud-framework-db still downloads the jar to build that specific sub
project (Just validated off of latest 4.3), which is necessary for the
overall project build.

Not trying to be a pain, just trying to make sure we don't miss something,
but I could be misunderstanding the situation.

Thanks,

-Nate


On Mon, Feb 24, 2014 at 9:53 AM, Hugo Trippaers  wrote:

> Guys,
>
> I did a quick check using the scanner at
> http://www.sonatype.com/application-health-check.  According to that
> report we need to do some additional checking of our dependencies.
>
> Licenses:
>   Copyleft: 2
>   Non-standard: 9
>   Weak-copyleft: 15
>   Liberal: 82
>
> I can't get the exact details as that requires the full report ($499
> ouch..), but at least it warrants investigation before we can release.
>
> Here is the printout of the report:
> https://dl.dropboxusercontent.com/u/70226362/app-check.pdf
>
> Cheers,
>
> Hugo
>
>
> On 23 feb. 2014, at 07:24, Rayees Namathponnan <
> rayees.namathpon...@citrix.com> wrote:
>
> > Hi David,
> >
> > One doubt, while building cloudstack we are using "mysql-connector-java
> version 5.1.29"; is it not mandatory we should supposed to use same version
> of mysql-connector during run time?
> >
> > Regards,
> > Rayees
> >
> > -Original Message-
> > From: David Nalley [mailto:da...@gnsa.us]
> > Sent: Saturday, February 22, 2014 7:59 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [DISCUSS] Policy blocker?
> >
> > Hi folks:
> >
> > I think this issue is resolved in the 4.3 branch. The default build
> system no longer seems to grab the mysql jar, and I've adjusted tomcat to
> load the mysql jar from the system library.
> >
> > Commit 0c2ad0338e34f6117cecc24ec00c7746dd481465 should have the
> necessary changes.
> >
> > I did some quick testing, and this seems to work, but obviously it needs
> more eyes and testing.
> >
> > --David
> >
> > On Thu, Feb 20, 2014 at 8:37 AM, David Nalley  wrote:
> >> Hi folks,
> >>
> >> I cringe to raise this issue. After 6 RCs I am sure we are all feeling
> >> a little bit of release vote fatigue. Especially Animesh. I apologize
> >> in advance; in all other respects I am ready to give a +1 to RC6.
> >>
> >> I've been playing with 4.3.0-rc6 for a couple of days now. I attempted
> >> to build some RPMs and had problems with dependency resolution in
> >> maven. This led me to looking at a number of different poms, and I
> >> noticed mysql-connector-java is listed as a runtime dependency. For
> >> our end users, this really isn't necessary - the debs and rpms specify
> >> a requirement (effectively a system requirement in the terms of
> >> policy) for mysql-connector-java. We don't need it to build the
> >> software (at least not in any location I've seen) - just when running.
> >> (And thus its a system dependency, much like MySQL is.)
> >>
> >> mysql-connector-java is GPLv2; which is Cat X. By including it as a
> >> dependency in the pom it automatically gets downloaded. The 3rd Party
> >> software policy has this line in it:
> >>
> >> "YOU MUST NOT distribute build scripts or documentation within an
> >> Apache product with the purpose of causing the default/standard build
> >> of an Apache product to include any part of aprohibited work."
> >>
> >> We've released software with this dependency previously. Is this a
> >> blocker for 4.3 or do we fix going forward? (If we hadn't already
> >> shipped releases with this problem I'd lean a bit more towards it
> >> being a blocker - but its more murky now.)
> >>
> >> Thoughts, comments, flames?
> >>
> >> --David
> >>
> >> [1] https://www.apache.org/legal/3party.html
>
>


-- 


*Nate Gordon*Director of Technology | Appcore - the business of cloud
computing(R)

Office +1.800.735.7104  |  Direct +1.515.612.7787
nate.gor...@appcore.com  |  www.appcore.com

--

The information in this message is intended for the named recipients only.
It may contain information that is privileged, confidential or otherwise
protected from disclosure. If you are not the intended recipient, you are
hereby notified that any disclosure, copying, distribution, or the taking
of any action in reliance on the contents of this message is strictly
prohibited. If you have received this e-mail in error, do not print it or
disseminate it or its contents. In such event, please notify the sender by
return e-mail and delete the e-mail file immediately thereafter. Thank you.

Re: Event Interceptor fix - contrail plugin : Review Request

[Suresh Balineni]

Thanks Darren.
It has been checked in.

Thanks,
Suresh

From: Darren Shepherd 
mailto:darren.sheph...@citrix.com>>
Date: Monday, February 24, 2014 11:53 AM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Suresh Balineni 
mailto:sbalin...@juniper.net>>
Cc: Sunil Bakhru mailto:sbak...@juniper.net>>, Sheng Yang 
mailto:sh...@yasker.org>>, Hugo 
mailto:h...@trippaers.nl>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>
Subject: Re: Event Interceptor fix - contrail plugin : Review Request

I'm sorry, I thought I did this weeks ago.  Do you not see the commit in 
master?  I'll double check, maybe I forgot to push.

Darren




From: Suresh Balineni mailto:sbalin...@juniper.net>>
Date: 2014-02-24 19:19:57 +
To: Darren Shepherd 
mailto:darren.sheph...@citrix.com>>,dev@cloudstack.apache.org
 mailto:dev@cloudstack.apache.org>>
Subject: Re: Event Interceptor fix - contrail plugin : Review Request
Cc: Sheng Yang mailto:sh...@yasker.org>>,Hugo 
mailto:h...@trippaers.nl>>,Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>,Sunil 
Bakhru mailto:sbak...@juniper.net>>

Hi Darren,

Can  you please review and ship these changes (Master branch)? Without this, 
contrail implementation won't work.

Thanks,
Suresh

From: Suresh Balineni 
mailto:sbalin...@junipernetworks.onmicrosoft.com>>
Date: Monday, February 10, 2014 12:10 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Darren Shepherd 
mailto:darren.sheph...@citrix.com>>
Cc: Darren Shepherd 
mailto:darren.sheph...@citrix.com>>, Hugo 
mailto:h...@trippaers.nl>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>, Sheng 
Yang mailto:sh...@yasker.org>>, Sunil Bakhru 
mailto:sbak...@juniper.net>>
Subject: Re: Event Interceptor fix - contrail plugin : Review Request

Hi Darren,

Can you please review this ?

Thanks,
Suresh

From: Suresh Balineni mailto:sbalin...@juniper.net>>
Date: Monday, February 3, 2014 3:24 PM
Cc: Darren Shepherd 
mailto:darren.sheph...@citrix.com>>, Hugo 
mailto:h...@trippaers.nl>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>, Sheng 
Yang mailto:sh...@yasker.org>>, Sunil Bakhru 
mailto:sbak...@juniper.net>>
Subject: Re: Event Interceptor fix - contrail plugin : Review Request

Hi Darren,

Can you review this?

Thanks,
Suresh


On Jan 30, 2014, at 4:23 PM, "Suresh Balineni" 
mailto:sbalin...@juniper.net>> wrote:

Hi Darren,

Can you please review and ship the following event interceptor fix in CS master 
branch?
I have implemented this as per your suggestion and it works fine.

https://reviews.apache.org/r/17337/

This review is pending for while

Thanks,
Suresh

Re: developers and mysql

[John Kinsella]

Nope. That’s the current state of things.

On Feb 24, 2014, at 2:28 PM, Alena Prokharchyk 
mailto:alena.prokharc...@citrix.com>> wrote:

Sorry, forgot to mention the steps I¹ve done:

mvn install -P developer,systemvm -DskipTests
cp mysql-connector-java-5.1.21.jar
client/target/cloud-client-ui-4.4.0-SNAPSHOT/WEB-INF/lib/
mvn -pl :cloud-client-ui jetty:run

And I still hitting the error below. Am I missing something?

Thanks,
Alena.



On 2/24/14, 11:41 AM, "Alena Prokharchyk" 
mailto:alena.prokharc...@citrix.com>>
wrote:

Hugo, fail to start latest master build on my machine, here is the error:

ERROR [c.c.u.d.Merovingian2] (main:null) Unable to get a new db connection
java.sql.SQLException: No suitable driver found for
jdbc:mysql://localhost:3306/cloud?autoReconnect=true&prepStmtCacheSize=517
&
cachePrepStmts=true
at java.sql.DriverManager.getConnection(DriverManager.java:596)
at java.sql.DriverManager.getConnection(DriverManager.java:215)



Can you please tell me what needs to be done in order to fix it?

Thanks,
Alena.

On 2/24/14, 10:11 AM, "Hugo Trippaers" 
mailto:trip...@gmail.com>> wrote:

Indeed,

I've been fighting with maven all day to get the development profile to
include MySql. No luck yet, will give it another shot tomorrow :-)

Hugo

Sent from my iPhone

On 24 feb. 2014, at 18:21, David Nalley mailto:da...@gnsa.us>> 
wrote:

So it should be ok to include the jar in non-default builds. developer
and deploydb are not what we'd expect a normal user to consume.
(Anyone else's head spinning?)

--David

On Mon, Feb 24, 2014 at 11:44 AM, John Kinsella 
mailto:j...@stratosec.co>>
wrote:
I created CLOUDSTACK-6157 over the weekend to track this. Not sure
adding the jar after compile will help the deploydb target, but will
give it a try this morning.

Could we set up the pom.xmls to use the jar for execution if it's
found in the user/system classpaths while respecting the legal
requirements?

Rayees' suggestion for cloud.spec makes sense for the RPM builds, but
doesn't affect the developer issues.

-He who needs more maven experience

On Feb 24, 2014, at 7:36 AM, Hugo Trippaers 
mailto:h...@trippaers.nl>>
wrote:

Heya,

as the mysql dependency is now set to provided in all the poms to fix
our license compliancy the jetty target and the deployed targets are
not working.

I'm trying to configure an optional profile to enable those targets
to include the mysql dependency while executing, but so far no luck.
If anyone has some bright ideas on how to do this i'm all ears. In the
meantime the best solutions i've found to continue working is to copy
the mysql jar file into the directory
client/target/cloud-client-ui-4.4.0-SNAPSHOT/WEB-INF/lib/ by hand
after running mvm install and before running the jetty target (just
don't run mvn clean).

Hopefully a better solution in the near future.

Cheers,

Hugo





Stratosec - Compliance as a Service
o: 415.315.9385
@johnlkinsella

Re: [Question][Proposal] Functionality when editing a shared ACL by NetworkId

[Chiradeep Vittal]

Surely this can be done by a few well crafted API calls from CloudMonkey?

On 2/24/14 4:55 AM, "Antonio Fornié Casarrubios"
 wrote:

>Hi all,
>
>There is this functionality that seems to be wrong and I would like to
>double check with you all. Actually this functionality could be considered
>very important so I appreciate collaboration.
>
>It's about the functionality for ACLs shared among networks. Let's say you
>have a VPC with Networks NW1 and NW2, and you have and ACL (what
>Cloudstack
>calls ACLList) with several rules, and you choose this ACL as the ACL for
>both NW1 and NW2. The current functionality is that in general if you
>modify the ACL this change will affect NW1 and NW2 of course.
>
>But there is a special case: you could send the parameter networkid. It
>makes sense that if you send a createNetowrkACL request to allow
>additional
>traffic and you specifically state NW1, this should not affect NW2.
>
>The proposal then is to change this functionality so that, if and only if
>the request specifies a networkid, the command should only affect the
>specified network. Which in Java terms will mean that if other networks
>use
>the same ACLList, it will be cloned and then the command will be applied
>to
>the new clone that will be assigned to the given network.
>
>Note that:
>* The new clone ACL List is created only if it is actually shared with
>more
>networks, otherwise it doesn't make sense.
>* The name for the new ACL List will be the same old name plus a random
>suffix.
>
>
>Any thoughts? Reasons not to go this way?
>
>Thanks and cheers
>
>Antonio
>Schuberg Philis - MCE

Re: Review Request 18310: dnsmasq fix for bridged networks

[Sheng Yang]

Yes, it would provide extra failsafe.

But the issue is if there is anything wrong, this patch may or may not
prevent it. So I think it's necessary to identify the root cause
first.

The dhcp-range option already specified as "static" which means:


The optional  keyword may be static which tells dnsmasq to
enable DHCP for the network specified, but not to dynamically allocate
IP addresses: only hosts which have static addresses given via
dhcp-host or from /etc/ethers will be served. A static-only subnet
with address all zeros may be used as a "catch-all" address to enable
replies to all Information-request packets on a subnet which is
provided with stateless DHCPv6, ie --dhcp=range=::,static


So it should already served the purpose.

--Sheng

On Sat, Feb 22, 2014 at 9:28 AM, Joris van Lieshout
 wrote:
> Hi Sheng,
>
> First of thanks you for reviewing my first attempt to contribute :) and
> sorry for my late response. I want to gadder a bit more info because I've
> seen it hand out adresses. Besides that this setting should at least provide
> an extra failsafe.
>
> Regards, Joris
>
> Sent from my iPhone
>
> On 21 feb. 2014, at 20:00, "Sheng Yang"  wrote:
>
> Hi Joris,
>
> This patch hasn't been applied yet, sorry for my second thought.
>
> Could you comment on it?
>
> --Sheng
>
>
> On Thu, Feb 20, 2014 at 10:29 AM, Sheng Yang  wrote:
>>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/18310/
>>
>> On February 20th, 2014, 6:17 p.m. UTC, Sheng Yang wrote:
>>
>> Looks good to me.
>>
>> Also I've confirmed that even with this option, the MAC would show in
>> dnsmasq.log, which is necessary for debug.
>>
>> Applied to MASTER. Thanks!
>>
>> On February 20th, 2014, 6:28 p.m. UTC, Sheng Yang wrote:
>>
>> One moment, on a second thought, even with current setup, dnsmasq won't
>> hand out IP to unknown host. So why this option is needed?
>>
>> And the log would show "DHCPDISCOVER(eth0) 02:01:3a:d9:00:02 no address
>> available" instead of "DHCPDISCOVER(eth0) 02:01:3a:d9:00:02 ignored" with
>> the option.
>>
>> Is there anything I missed?
>>
>> And the patch hasn't been applied yet...
>>
>>
>> - Sheng
>>
>>
>> On February 20th, 2014, 2:01 p.m. UTC, Joris van Lieshout wrote:
>>
>> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng
>> Yang.
>> By Joris van Lieshout.
>>
>> Updated Feb. 20, 2014, 2:01 p.m.
>>
>> Repository: cloudstack-git
>>
>> Description
>>
>> When a ACS network is bridged to another non-ACS network (for instance
>> using a NSX Bridge) this will prevent dnsmasq from responding to requests
>> from the other network that have traversed the bridge.
>>
>> Testing
>>
>> We have been running this fix on our own version of the 4.2 and 3.0 SVM
>> for a couple months with success.
>>
>> Diffs
>>
>> systemvm/patches/debian/config/etc/dnsmasq.conf.tmpl (07c5902)
>>
>> View Diff
>
>

Re: developers and mysql

[Alena Prokharchyk]

Sorry, forgot to mention the steps I¹ve done:

mvn install -P developer,systemvm -DskipTests
cp mysql-connector-java-5.1.21.jar
client/target/cloud-client-ui-4.4.0-SNAPSHOT/WEB-INF/lib/
mvn -pl :cloud-client-ui jetty:run

And I still hitting the error below. Am I missing something?

Thanks,
Alena.



On 2/24/14, 11:41 AM, "Alena Prokharchyk" 
wrote:

>Hugo, fail to start latest master build on my machine, here is the error:
>
>ERROR [c.c.u.d.Merovingian2] (main:null) Unable to get a new db connection
>java.sql.SQLException: No suitable driver found for
>jdbc:mysql://localhost:3306/cloud?autoReconnect=true&prepStmtCacheSize=517
>&
>cachePrepStmts=true
>   at java.sql.DriverManager.getConnection(DriverManager.java:596)
>   at java.sql.DriverManager.getConnection(DriverManager.java:215)
>
>
>
>Can you please tell me what needs to be done in order to fix it?
>
>Thanks,
>Alena.
>
>On 2/24/14, 10:11 AM, "Hugo Trippaers"  wrote:
>
>>Indeed,
>>
>>I've been fighting with maven all day to get the development profile to
>>include MySql. No luck yet, will give it another shot tomorrow :-)
>>
>>Hugo
>>
>>Sent from my iPhone
>>
>>> On 24 feb. 2014, at 18:21, David Nalley  wrote:
>>> 
>>> So it should be ok to include the jar in non-default builds. developer
>>> and deploydb are not what we'd expect a normal user to consume.
>>> (Anyone else's head spinning?)
>>> 
>>> --David
>>> 
 On Mon, Feb 24, 2014 at 11:44 AM, John Kinsella 
wrote:
 I created CLOUDSTACK-6157 over the weekend to track this. Not sure
adding the jar after compile will help the deploydb target, but will
give it a try this morning.
 
 Could we set up the pom.xmls to use the jar for execution if it's
found in the user/system classpaths while respecting the legal
requirements?
 
 Rayees' suggestion for cloud.spec makes sense for the RPM builds, but
doesn't affect the developer issues.
 
 -He who needs more maven experience
 
> On Feb 24, 2014, at 7:36 AM, Hugo Trippaers 
>wrote:
> 
> Heya,
> 
> as the mysql dependency is now set to provided in all the poms to fix
>our license compliancy the jetty target and the deployed targets are
>not working.
> 
> I'm trying to configure an optional profile to enable those targets
>to include the mysql dependency while executing, but so far no luck.
>If anyone has some bright ideas on how to do this i'm all ears. In the
>meantime the best solutions i've found to continue working is to copy
>the mysql jar file into the directory
>client/target/cloud-client-ui-4.4.0-SNAPSHOT/WEB-INF/lib/ by hand
>after running mvm install and before running the jetty target (just
>don't run mvn clean).
> 
> Hopefully a better solution in the near future.
> 
> Cheers,
> 
> Hugo
 
 
>

Re: developers and mysql

[Alena Prokharchyk]

Sorry, forgot to mention the steps I¹ve done:


On 2/24/14, 11:41 AM, "Alena Prokharchyk" 
wrote:

>Hugo, fail to start latest master build on my machine, here is the error:
>
>ERROR [c.c.u.d.Merovingian2] (main:null) Unable to get a new db connection
>java.sql.SQLException: No suitable driver found for
>jdbc:mysql://localhost:3306/cloud?autoReconnect=true&prepStmtCacheSize=517
>&
>cachePrepStmts=true
>   at java.sql.DriverManager.getConnection(DriverManager.java:596)
>   at java.sql.DriverManager.getConnection(DriverManager.java:215)
>
>
>
>Can you please tell me what needs to be done in order to fix it?
>
>Thanks,
>Alena.
>
>On 2/24/14, 10:11 AM, "Hugo Trippaers"  wrote:
>
>>Indeed,
>>
>>I've been fighting with maven all day to get the development profile to
>>include MySql. No luck yet, will give it another shot tomorrow :-)
>>
>>Hugo
>>
>>Sent from my iPhone
>>
>>> On 24 feb. 2014, at 18:21, David Nalley  wrote:
>>> 
>>> So it should be ok to include the jar in non-default builds. developer
>>> and deploydb are not what we'd expect a normal user to consume.
>>> (Anyone else's head spinning?)
>>> 
>>> --David
>>> 
 On Mon, Feb 24, 2014 at 11:44 AM, John Kinsella 
wrote:
 I created CLOUDSTACK-6157 over the weekend to track this. Not sure
adding the jar after compile will help the deploydb target, but will
give it a try this morning.
 
 Could we set up the pom.xmls to use the jar for execution if it's
found in the user/system classpaths while respecting the legal
requirements?
 
 Rayees' suggestion for cloud.spec makes sense for the RPM builds, but
doesn't affect the developer issues.
 
 -He who needs more maven experience
 
> On Feb 24, 2014, at 7:36 AM, Hugo Trippaers 
>wrote:
> 
> Heya,
> 
> as the mysql dependency is now set to provided in all the poms to fix
>our license compliancy the jetty target and the deployed targets are
>not working.
> 
> I'm trying to configure an optional profile to enable those targets
>to include the mysql dependency while executing, but so far no luck.
>If anyone has some bright ideas on how to do this i'm all ears. In the
>meantime the best solutions i've found to continue working is to copy
>the mysql jar file into the directory
>client/target/cloud-client-ui-4.4.0-SNAPSHOT/WEB-INF/lib/ by hand
>after running mvm install and before running the jetty target (just
>don't run mvn clean).
> 
> Hopefully a better solution in the near future.
> 
> Cheers,
> 
> Hugo
 
 
>

Re: Event Interceptor fix - contrail plugin : Review Request

[Darren Shepherd]

I'm sorry, I thought I did this weeks ago.  Do you not see the commit in 
master?  I'll double check, maybe I forgot to push.

Darren




From: Suresh Balineni 
Date: 2014-02-24 19:19:57 +
To: Darren Shepherd ,dev@cloudstack.apache.org 

Subject: Re: Event Interceptor fix - contrail plugin : Review Request
Cc: Sheng Yang ,Hugo ,Animesh Chaturvedi 
,Sunil Bakhru 

Hi Darren,

Can  you please review and ship these changes (Master branch)? Without this, 
contrail implementation won't work.

Thanks,
Suresh

From: Suresh Balineni 
mailto:sbalin...@junipernetworks.onmicrosoft.com>>
Date: Monday, February 10, 2014 12:10 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Darren Shepherd 
mailto:darren.sheph...@citrix.com>>
Cc: Darren Shepherd 
mailto:darren.sheph...@citrix.com>>, Hugo 
mailto:h...@trippaers.nl>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>, Sheng 
Yang mailto:sh...@yasker.org>>, Sunil Bakhru 
mailto:sbak...@juniper.net>>
Subject: Re: Event Interceptor fix - contrail plugin : Review Request

Hi Darren,

Can you please review this ?

Thanks,
Suresh

From: Suresh Balineni mailto:sbalin...@juniper.net>>
Date: Monday, February 3, 2014 3:24 PM
Cc: Darren Shepherd 
mailto:darren.sheph...@citrix.com>>, Hugo 
mailto:h...@trippaers.nl>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>, Sheng 
Yang mailto:sh...@yasker.org>>, Sunil Bakhru 
mailto:sbak...@juniper.net>>
Subject: Re: Event Interceptor fix - contrail plugin : Review Request

Hi Darren,

Can you review this?

Thanks,
Suresh


On Jan 30, 2014, at 4:23 PM, "Suresh Balineni" 
mailto:sbalin...@juniper.net>> wrote:

Hi Darren,

Can you please review and ship the following event interceptor fix in CS master 
branch?
I have implemented this as per your suggestion and it works fine.

https://reviews.apache.org/r/17337/

This review is pending for while

Thanks,
Suresh

Re: Review Request 18432: Fixed some resource files issues

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18432/#review35320
---


looks great

- Laszlo Hornyak


On Feb. 24, 2014, 5:47 p.m., Konstantina Chremmou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18432/
> ---
> 
> (Updated Feb. 24, 2014, 5:47 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed some resource files issues, namely 1) invalid text and duplicate keys 
> resulting from bad merge and 2) trailing spaces which can potentially cause 
> UI issues.
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties bd4a27d 
>   client/WEB-INF/classes/resources/messages_es.properties 31a9c93 
>   client/WEB-INF/classes/resources/messages_ja_JP.properties 7dd5bd1 
>   client/WEB-INF/classes/resources/messages_nl_NL.properties b1bfadb 
>   client/WEB-INF/classes/resources/messages_pl.properties 9024030 
>   client/WEB-INF/classes/resources/messages_pt_BR.properties 07fd3f4 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 88b13a1 
> 
> Diff: https://reviews.apache.org/r/18432/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Konstantina Chremmou
> 
>

Re: Review Request 18358: NetUtils unit testing

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18358/#review35319
---


 Verified, looks good. Daan, ok to merge?

- Laszlo Hornyak


On Feb. 22, 2014, 1:41 p.m., Miguel Ferreira wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18358/
> ---
> 
> (Updated Feb. 22, 2014, 1:41 p.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> - Refactor tests:
>   - Upgrade tests to use jUnit4
>   - Break big tests in small unit tests
>   - Replace assertTrue/False with complex conditions by assertThat with
> specific matchers
> - Remove dead code:
>   - Private static method never called locally
> - Add test for method that validates CIDRs
> 
> 
> Diffs
> -
> 
>   pom.xml 1e9e8d8 
>   utils/src/com/cloud/utils/net/NetUtils.java c22e39a 
>   utils/test/com/cloud/utils/net/NetUtilsTest.java d3e283c 
> 
> Diff: https://reviews.apache.org/r/18358/diff/
> 
> 
> Testing
> ---
> 
> Ran all the tests in the test class before and after refactoring.
> 
> 
> Thanks,
> 
> Miguel Ferreira
> 
>

Re: developers and mysql

[Alena Prokharchyk]

Hugo, fail to start latest master build on my machine, here is the error:

ERROR [c.c.u.d.Merovingian2] (main:null) Unable to get a new db connection
java.sql.SQLException: No suitable driver found for
jdbc:mysql://localhost:3306/cloud?autoReconnect=true&prepStmtCacheSize=517&
cachePrepStmts=true
at java.sql.DriverManager.getConnection(DriverManager.java:596)
at java.sql.DriverManager.getConnection(DriverManager.java:215)



Can you please tell me what needs to be done in order to fix it?

Thanks,
Alena.

On 2/24/14, 10:11 AM, "Hugo Trippaers"  wrote:

>Indeed,
>
>I've been fighting with maven all day to get the development profile to
>include MySql. No luck yet, will give it another shot tomorrow :-)
>
>Hugo
>
>Sent from my iPhone
>
>> On 24 feb. 2014, at 18:21, David Nalley  wrote:
>> 
>> So it should be ok to include the jar in non-default builds. developer
>> and deploydb are not what we'd expect a normal user to consume.
>> (Anyone else's head spinning?)
>> 
>> --David
>> 
>>> On Mon, Feb 24, 2014 at 11:44 AM, John Kinsella 
>>>wrote:
>>> I created CLOUDSTACK-6157 over the weekend to track this. Not sure
>>>adding the jar after compile will help the deploydb target, but will
>>>give it a try this morning.
>>> 
>>> Could we set up the pom.xmls to use the jar for execution if it's
>>>found in the user/system classpaths while respecting the legal
>>>requirements?
>>> 
>>> Rayees' suggestion for cloud.spec makes sense for the RPM builds, but
>>>doesn't affect the developer issues.
>>> 
>>> -He who needs more maven experience
>>> 
 On Feb 24, 2014, at 7:36 AM, Hugo Trippaers  wrote:
 
 Heya,
 
 as the mysql dependency is now set to provided in all the poms to fix
our license compliancy the jetty target and the deployed targets are
not working.
 
 I'm trying to configure an optional profile to enable those targets
to include the mysql dependency while executing, but so far no luck.
If anyone has some bright ideas on how to do this i'm all ears. In the
meantime the best solutions i've found to continue working is to copy
the mysql jar file into the directory
client/target/cloud-client-ui-4.4.0-SNAPSHOT/WEB-INF/lib/ by hand
after running mvm install and before running the jetty target (just
don't run mvn clean).
 
 Hopefully a better solution in the near future.
 
 Cheers,
 
 Hugo
>>> 
>>> 

Re: Event Interceptor fix - contrail plugin : Review Request

[Suresh Balineni]

Hi Darren,

Can  you please review and ship these changes (Master branch)? Without this, 
contrail implementation won't work.

Thanks,
Suresh

From: Suresh Balineni 
mailto:sbalin...@junipernetworks.onmicrosoft.com>>
Date: Monday, February 10, 2014 12:10 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>, Darren Shepherd 
mailto:darren.sheph...@citrix.com>>
Cc: Darren Shepherd 
mailto:darren.sheph...@citrix.com>>, Hugo 
mailto:h...@trippaers.nl>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>, Sheng 
Yang mailto:sh...@yasker.org>>, Sunil Bakhru 
mailto:sbak...@juniper.net>>
Subject: Re: Event Interceptor fix - contrail plugin : Review Request

Hi Darren,

Can you please review this ?

Thanks,
Suresh

From: Suresh Balineni mailto:sbalin...@juniper.net>>
Date: Monday, February 3, 2014 3:24 PM
Cc: Darren Shepherd 
mailto:darren.sheph...@citrix.com>>, Hugo 
mailto:h...@trippaers.nl>>, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>>, Sheng 
Yang mailto:sh...@yasker.org>>, Sunil Bakhru 
mailto:sbak...@juniper.net>>
Subject: Re: Event Interceptor fix - contrail plugin : Review Request

Hi Darren,

Can you review this?

Thanks,
Suresh


On Jan 30, 2014, at 4:23 PM, "Suresh Balineni" 
mailto:sbalin...@juniper.net>> wrote:

Hi Darren,

Can you please review and ship the following event interceptor fix in CS master 
branch?
I have implemented this as per your suggestion and it works fine.

https://reviews.apache.org/r/17337/

This review is pending for while

Thanks,
Suresh

Review Request 18433: Test Suite for Testing Remote Access VPN on VPC

[Chandan Purushothama]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18433/
---

Review request for cloudstack, Girish Shilamkar, sanjeev n, Santhosh Edukulla, 
and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Test Suite for Testing Remote Access VPN on VPC. 

I successfully automated the following components:

1.Developed a component that automates VPN Client Configuration and services.
2.Component that efficiently verifies Remote VPN Access between client and the 
Server.
3.Test Cases of the Feature
4.Tested the Code multiple times on XenServer and fixed the bugs.


Diffs
-

  test/integration/component/test_remotevpn_vpc.py PRE-CREATION 
  tools/marvin/marvin/config/config.cfg 5849fe8 

Diff: https://reviews.apache.org/r/18433/diff/


Testing
---

Test case no : Enable VPN for Public IP Address on the VPC ... ok
Test case no : Remote a VPN User ... ok
Test case no : Add a Different VPN User and Test Access with already existing 
VPN User ... ok
Test case no : Add a Previously Removed VPN User from the VPC and Test the VPN 
Connectivity ... ok
Test case no : Disable the VPN Service on the VPC ... ok
Test case no : Enabled Previously Dsiabled VPN Access to VPC. ... ok
Test case no : Create Nine VPN Users to test the remote.vpn.user.limit=8 
Configuration parameter ... ok

--
Ran 7 tests in 817.606s

OK


Thanks,

Chandan Purushothama

Re: Yet another mail on code quality

[Laszlo Hornyak]

Hi,

Guys if you feel like, look around in sonar sometimes, it registers and
tracks tons of such issues (and the app is cool, nice and super-trendy)

https://analysis.apache.org/dashboard/index/100206

For incorrect use of == operator, sonar knows 14 more cases in ACS, There
are some that "not nice but works", but quite a few seem to be a positive.

https://analysis.apache.org/drilldown/issues/100206?&rule=pmd%3ACompareObjectsWithEquals&rule_sev=MAJOR&severity=MAJOR

Regards,
Laszlo


On Mon, Feb 24, 2014 at 5:14 PM, Hugo Trippaers  wrote:

> Guys,
>
> Please pay attention to the code you are committing. Today i fixed a
> number of issues that were introduced in recent code, these are bugs that
> could have been prevented from entering master by either testing or running
> the findbugs checks. One was committed directly, the other one through a
> reviewed patch.
>
>
> @@ -116,7 +116,7 @@ public class Upgrade430to440 implements DbUpgrade {
>  if (networkRs.next()) {
>  String guesttype = networkRs.getString(1);
>
> -if (guesttype ==
> Network.GuestType.Shared.toString()) {
> +if
> (guesttype.equals(Network.GuestType.Shared.toString())) {
>  pstmtUpdate =
> conn.prepareStatement("UPDATE `cloud`.`user_ip_address` SET account_id = ?,
> domain_id= ? WHERE public_ip_address = ?");
>  pstmtUpdate.setLong(1,vmAccountId);
>  pstmtUpdate.setLong(2,vmDomainId);
>
>
>
> @@ -80,11 +80,11 @@ public class LibvirtStoragePoolXMLParser {
>  String targetPath = getTagValue("path", target);
>
>  String portValue = getAttrValue("host", "port", source);
> -if (portValue != "")
> +if (portValue != null && !portValue.isEmpty())
>  port = Integer.parseInt(portValue);
>
>  return new
> LibvirtStoragePoolDef(LibvirtStoragePoolDef.poolType.valueOf(format.toUpperCase()),
>
>
> To help, i've configured the slowbuild to alert if the number of high
> priority findings from findbugs differs from the previous run. It will
> notify all developers that had changes during this period (slowbuild runs
> every 4 hours).
>
> Cheers,
>
> Hugo




-- 

EOF

RE: [PROPOSAL] Windowsfication Of ACS

[Alex Huang]

One additional requirement I have would be don't use any windows components 
that don't come with the default systems targeted.  I know it sounds great to 
use the latest and greatest but actually the end users will have to install 
that and it may mess with their existing setup.  In this proposal, the purely 
windows parts are fairly basic parts of windows.  Don't bind it to libraries 
that require installation of additional libraries.

--Alex

> -Original Message-
> From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
> Sent: Friday, February 21, 2014 1:00 AM
> To: dev@cloudstack.apache.org
> Subject: RE: [PROPOSAL] Windowsfication Of ACS
> 
> I prefer the focus on support that comes with David's suggestion.  Targeting
> the latest stable release for a new platform greatly reduces the number of
> permutations to test.
> 
> Pursuing legacy systems limits the flexibility of ACS to evolve.  For 
> instance,
> we'll probably be on Java 7 in the next while, and W2K3 doesn't appear on
> the supported system list (see
> https://www.java.com/en/download/help/sysreq.xml).  Likewise, older
> versions of Internet Explorer can be quite different than what Microsoft has
> recently published.
> 
> My guess is that the engineering effort to get ACS working on a legacy
> system makes sense as a consultancy service offered independent to ACS.
> That's the case of OS/2 support ;)
> 
> 
> DL
> 
> 
> > -Original Message-
> > From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
> > Sent: 20 February 2014 14:29
> > To: dev@cloudstack.apache.org
> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >
> > I agree totally, my point was that while there is nothing technically
> > stopping us going for w2k3 there is little reason to do so.
> >
> >
> > Regards
> >
> > Alex Hitchins
> >
> > D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
> >
> > alex.hitch...@shapeblue.com
> >
> > -Original Message-
> > From: David Nalley [mailto:da...@gnsa.us]
> > Sent: 20 February 2014 13:24
> > To: dev@cloudstack.apache.org
> > Subject: Re: [PROPOSAL] Windowsfication Of ACS
> >
> > There's a difference in incidentally working and validated to work on.
> > I'd limit focus to making sure it works on 2k12r2.
> >
> > --David
> >
> > On Thu, Feb 20, 2014 at 6:37 AM, Alex Hitchins
> >  wrote:
> > > I can't think of anything that wouldn't be possible on W2k3 - that
> > > said It's
> > old and I can't see people having a need for it.
> > >
> > >
> > > Regards
> > >
> > > Alex Hitchins
> > >
> > > D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
> > >
> > > alex.hitch...@shapeblue.com
> > >
> > > -Original Message-
> > > From: Paul Angus [mailto:paul.an...@shapeblue.com]
> > > Sent: 20 February 2014 11:17
> > > To: dev@cloudstack.apache.org
> > > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> > >
> > > Isn't the hyper-v support dependant on using 2012r2 ?
> > >
> > > So I don't know if I'd bother with going back as far as 2003
> > >
> > > Regards,
> > >
> > > Paul Angus
> > > Cloud Architect
> > > S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
> > > paul.an...@shapeblue.com
> > >
> > > -Original Message-
> > > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> > > Sent: 20 February 2014 11:13
> > > To: dev@cloudstack.apache.org
> > > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> > >
> > > AFAIK, it would be windows server 2k3, 2k8 2012, 2012R2.
> > >
> > > Thanks
> > > Rajesh Battala
> > >
> > > -Original Message-
> > > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
> > > Sent: Thursday, February 20, 2014 4:32 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> > >
> > > One question I have is, Which version of windows we need to target?
> > >
> > > Thanks & Regards
> > > Damodar/
> > >
> > >
> > > -Original Message-
> > > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
> > > Sent: Thursday, February 20, 2014 2:04 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> > >
> > > I have tried to put all together in FS at
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Win
> > dowsfication as Feedback section and added my comments there.
> > >
> > > Please verify once and let me know if anything is to be added there.
> > >
> > > Thanks & Regards
> > > Damodar/
> > >
> > >
> > > -Original Message-
> > > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
> > > Sent: Thursday, February 20, 2014 12:32 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> > >
> > > Thank you all for your inputs.
> > >
> > >  I will aggregate all these things into FS  as appendix and will put
> > > comments
> > there instead of replying here one by one. Once I am done with update
> > in FS I will notify so that we can verify whether we are covering all or 
> > not.
> > >
> > > Thanks & Regards
> > > Da

Re: developers and mysql

[Hugo Trippaers]

Indeed,

I've been fighting with maven all day to get the development profile to include 
MySql. No luck yet, will give it another shot tomorrow :-)  

Hugo

Sent from my iPhone

> On 24 feb. 2014, at 18:21, David Nalley  wrote:
> 
> So it should be ok to include the jar in non-default builds. developer
> and deploydb are not what we'd expect a normal user to consume.
> (Anyone else's head spinning?)
> 
> --David
> 
>> On Mon, Feb 24, 2014 at 11:44 AM, John Kinsella  wrote:
>> I created CLOUDSTACK-6157 over the weekend to track this. Not sure adding 
>> the jar after compile will help the deploydb target, but will give it a try 
>> this morning.
>> 
>> Could we set up the pom.xmls to use the jar for execution if it's found in 
>> the user/system classpaths while respecting the legal requirements?
>> 
>> Rayees' suggestion for cloud.spec makes sense for the RPM builds, but 
>> doesn't affect the developer issues.
>> 
>> -He who needs more maven experience
>> 
>>> On Feb 24, 2014, at 7:36 AM, Hugo Trippaers  wrote:
>>> 
>>> Heya,
>>> 
>>> as the mysql dependency is now set to provided in all the poms to fix our 
>>> license compliancy the jetty target and the deployed targets are not 
>>> working.
>>> 
>>> I'm trying to configure an optional profile to enable those targets to 
>>> include the mysql dependency while executing, but so far no luck. If anyone 
>>> has some bright ideas on how to do this i'm all ears. In the meantime the 
>>> best solutions i've found to continue working is to copy the mysql jar file 
>>> into the directory 
>>> client/target/cloud-client-ui-4.4.0-SNAPSHOT/WEB-INF/lib/ by hand after 
>>> running mvm install and before running the jetty target (just don't run mvn 
>>> clean).
>>> 
>>> Hopefully a better solution in the near future.
>>> 
>>> Cheers,
>>> 
>>> Hugo
>> 
>> 

Re: CLOUDSTACK-5663

[Alena Prokharchyk]

Saurav, can you please put me to the list of the Reviewers for the bug
once the Reviewboard ticket is created?

As for the bug, you need to be added to the Jira users DB in order to
become an assignee. Whoever administers Jira, can you please do it?

-Alena.


On 2/24/14, 5:01 AM, "Saurav Lahiri"  wrote:

>Hi All,
>
>I started looking at https://issues.apache.org/jira/browse/CLOUDSTACK-5663
>If anybody is actively looking into this please let me know else i can
>continue with this.
>
>
>
>Parth
>It looks like it is hitting the code path for non shared networks.You have
>mentioned that you are using shared networks.  Can you please provide some
>more details as to how did u create the network. Was it via the ui or did
>u
>use API and what were the parameters specified.
>
>While it is true that cidr is not required when creating networks it
>should
>be generated based on the ip params specified. This looks like some thing
>went wrong when creating the network.
>
>Thanks
>Saurav
>
>P.S: Can somebody please provide privileges so that I can assign tickets
>to
>myself.

Review Request 18432: Fixed some resource files issues

[Konstantina Chremmou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18432/
---

Review request for cloudstack, Brian Federle and Jessica Wang.


Repository: cloudstack-git


Description
---

Fixed some resource files issues, namely 1) invalid text and duplicate keys 
resulting from bad merge and 2) trailing spaces which can potentially cause UI 
issues.


Diffs
-

  client/WEB-INF/classes/resources/messages.properties bd4a27d 
  client/WEB-INF/classes/resources/messages_es.properties 31a9c93 
  client/WEB-INF/classes/resources/messages_ja_JP.properties 7dd5bd1 
  client/WEB-INF/classes/resources/messages_nl_NL.properties b1bfadb 
  client/WEB-INF/classes/resources/messages_pl.properties 9024030 
  client/WEB-INF/classes/resources/messages_pt_BR.properties 07fd3f4 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 88b13a1 

Diff: https://reviews.apache.org/r/18432/diff/


Testing
---


Thanks,

Konstantina Chremmou

RE: [PROPOSAL] Windowsfication Of ACS

[Donal Lafferty]

WiX (see http://wixtoolset.org/)



> -Original Message-
> From: Abhinandan Prateek [mailto:abhinandan.prat...@citrix.com]
> Sent: 24 February 2014 12:11
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] Windowsfication Of ACS
> 
> Anyone, is there an open source windows installer tool ?
> 
> -abhi
> 
> 
> 
> On 21/02/14 2:30 pm, "Donal Lafferty"  wrote:
> 
> >I prefer the focus on support that comes with David's suggestion.
> >Targeting the latest stable release for a new platform greatly reduces
> >the number of permutations to test.
> >
> >Pursuing legacy systems limits the flexibility of ACS to evolve.  For
> >instance, we'll probably be on Java 7 in the next while, and W2K3
> >doesn't appear on the supported system list (see
> >https://www.java.com/en/download/help/sysreq.xml).  Likewise, older
> >versions of Internet Explorer can be quite different than what
> >Microsoft has recently published.
> >
> >My guess is that the engineering effort to get ACS working on a legacy
> >system makes sense as a consultancy service offered independent to ACS.
> >That's the case of OS/2 support ;)
> >
> >
> >DL
> >
> >
> >> -Original Message-
> >> From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
> >> Sent: 20 February 2014 14:29
> >> To: dev@cloudstack.apache.org
> >> Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >>
> >> I agree totally, my point was that while there is nothing technically
> >>stopping  us going for w2k3 there is little reason to do so.
> >>
> >>
> >> Regards
> >>
> >> Alex Hitchins
> >>
> >> D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
> >>
> >> alex.hitch...@shapeblue.com
> >>
> >> -Original Message-
> >> From: David Nalley [mailto:da...@gnsa.us]
> >> Sent: 20 February 2014 13:24
> >> To: dev@cloudstack.apache.org
> >> Subject: Re: [PROPOSAL] Windowsfication Of ACS
> >>
> >> There's a difference in incidentally working and validated to work on.
> >> I'd limit focus to making sure it works on 2k12r2.
> >>
> >> --David
> >>
> >> On Thu, Feb 20, 2014 at 6:37 AM, Alex Hitchins
> >>  wrote:
> >> > I can't think of anything that wouldn't be possible on W2k3 - that
> >>said It's
> >> old and I can't see people having a need for it.
> >> >
> >> >
> >> > Regards
> >> >
> >> > Alex Hitchins
> >> >
> >> > D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
> >> >
> >> > alex.hitch...@shapeblue.com
> >> >
> >> > -Original Message-
> >> > From: Paul Angus [mailto:paul.an...@shapeblue.com]
> >> > Sent: 20 February 2014 11:17
> >> > To: dev@cloudstack.apache.org
> >> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >> >
> >> > Isn't the hyper-v support dependant on using 2012r2 ?
> >> >
> >> > So I don't know if I'd bother with going back as far as 2003
> >> >
> >> > Regards,
> >> >
> >> > Paul Angus
> >> > Cloud Architect
> >> > S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
> >> > paul.an...@shapeblue.com
> >> >
> >> > -Original Message-
> >> > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
> >> > Sent: 20 February 2014 11:13
> >> > To: dev@cloudstack.apache.org
> >> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >> >
> >> > AFAIK, it would be windows server 2k3, 2k8 2012, 2012R2.
> >> >
> >> > Thanks
> >> > Rajesh Battala
> >> >
> >> > -Original Message-
> >> > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
> >> > Sent: Thursday, February 20, 2014 4:32 PM
> >> > To: dev@cloudstack.apache.org
> >> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >> >
> >> > One question I have is, Which version of windows we need to target?
> >> >
> >> > Thanks & Regards
> >> > Damodar/
> >> >
> >> >
> >> > -Original Message-
> >> > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
> >> > Sent: Thursday, February 20, 2014 2:04 PM
> >> > To: dev@cloudstack.apache.org
> >> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >> >
> >> > I have tried to put all together in FS at
> >>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Win
> >> dowsfication as Feedback section and added my comments there.
> >> >
> >> > Please verify once and let me know if anything is to be added there.
> >> >
> >> > Thanks & Regards
> >> > Damodar/
> >> >
> >> >
> >> > -Original Message-
> >> > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
> >> > Sent: Thursday, February 20, 2014 12:32 PM
> >> > To: dev@cloudstack.apache.org
> >> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
> >> >
> >> > Thank you all for your inputs.
> >> >
> >> >  I will aggregate all these things into FS  as appendix and will
> >> > put
> >>comments
> >> there instead of replying here one by one. Once I am done with update
> >>in FS  I will notify so that we can verify whether we are covering all
> >>or not.
> >> >
> >> > Thanks & Regards
> >> > Damodar/
> >> >
> >> > -Original Message-
> >> > From: abhisek basu [mailto:abhisekb...@msn.com]
> >> > Sent: Sunday, February 16, 2014 9:16 AM
> >> > 

Re: developers and mysql

[David Nalley]

So it should be ok to include the jar in non-default builds. developer
and deploydb are not what we'd expect a normal user to consume.
(Anyone else's head spinning?)

--David

On Mon, Feb 24, 2014 at 11:44 AM, John Kinsella  wrote:
> I created CLOUDSTACK-6157 over the weekend to track this. Not sure adding the 
> jar after compile will help the deploydb target, but will give it a try this 
> morning.
>
> Could we set up the pom.xmls to use the jar for execution if it's found in 
> the user/system classpaths while respecting the legal requirements?
>
> Rayees' suggestion for cloud.spec makes sense for the RPM builds, but doesn't 
> affect the developer issues.
>
> -He who needs more maven experience
>
> On Feb 24, 2014, at 7:36 AM, Hugo Trippaers  wrote:
>
>> Heya,
>>
>> as the mysql dependency is now set to provided in all the poms to fix our 
>> license compliancy the jetty target and the deployed targets are not working.
>>
>> I'm trying to configure an optional profile to enable those targets to 
>> include the mysql dependency while executing, but so far no luck. If anyone 
>> has some bright ideas on how to do this i'm all ears. In the meantime the 
>> best solutions i've found to continue working is to copy the mysql jar file 
>> into the directory client/target/cloud-client-ui-4.4.0-SNAPSHOT/WEB-INF/lib/ 
>> by hand after running mvm install and before running the jetty target (just 
>> don't run mvn clean).
>>
>> Hopefully a better solution in the near future.
>>
>> Cheers,
>>
>> Hugo
>
>

devcloud - new version (0.2) ready for testing

[chris snow]

There is a new version of devcloud (version 0.2) ready for testing.

The main change in this version is an upgrade to debian 7.4 and fix
for issue 14 [1]

Instructions for running the vagrant box are here [2].

This release has an issue with nfs [3].  Suggestions welcome for
fixing the issue.  Please report any new issues on the git hub project
page.

Many thanks,

Chris

---
[1] https://github.com/snowch/devcloud/issues/14
[2] https://github.com/snowch/devcloud/blob/master/README-minimal-box.md
[3] https://github.com/snowch/devcloud/issues/15

Re: [PROPOSAL] Change systemvm template URL in master to s3 bucket

[John Kinsella]

Who’s paying for the s3 storage (sorry if I missed something there)? How long 
do you keep old images?

Vaguely related - I was pondering seeding ACS and/or VM image torrents - wonder 
if folks would be interested in that? I realize bittorrent isn’t always welcome 
in corp environments...

On Feb 24, 2014, at 1:51 AM, Hugo Trippaers 
mailto:h...@trippaers.nl>> wrote:

Hey all,

I’ve finally fixed the configuration to automagically upload the systemvm 
templates to an s3 bucket. The jobs build-systemvm-master and 
build-systemvm64-master will rebuild the systemvm template on a daily basis and 
send the resulting files to that S3 bucket.

I would like to update the URLs in the docs and in the database to make master 
point to these new locations. The locations will look like : 
https://s3.amazonaws.com/systemvm-templates.cloudstack.org/master/64/systemvm64template-master-hyperv.vhd

Why?
 Anyone using master will automagically use the latest and greatest images.
 Transparent process from build script to distribution.
 Accessible logging for folks willing to track number of downloads etc.


Any thoughts?

Cheers,

Hugo



Stratosec - Compliance as a Service
o: 415.315.9385
@johnlkinsella

Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

[Sanjay Tripathi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/
---

(Updated Feb. 24, 2014, 5:07 p.m.)


Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.


Changes
---

Incorporated the changes suggested by Hugo and rebased the patch with latest 
master.


Bugs: CLOUDSTACK-6058
https://issues.apache.org/jira/browse/CLOUDSTACK-6058


Repository: cloudstack-git


Description
---

Update the java bindings that are used in cloudstack with the latest one. There 
are two parts for this change, 1st one is to replace the java bindings; and 
second part is to add the customization's made in xenapi for Cloudstack.

1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for 
CloudStack.


Diffs (updated)
-

  deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
  deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
  deps/XenServerJava/src/README.txt PRE-CREATION 
  deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
  deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
  deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
  deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
  deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
  deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
  deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
  deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
  deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
  deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
  deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
  deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
  deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
  deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
  deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
  deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
  deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
  deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
  deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
  deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
  deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
  deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
  deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
  deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
  deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
  deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
  deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
  deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
  deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
  deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
  deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
  deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
  deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
  deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
  deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
  deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
  deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
  deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
  deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
  deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
  deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
  deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
  deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
  deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
  deps/XenServerJava/src/com/xensource/xenapi/VM.java cfa5e6c 
  deps/XenServerJava/src/com/xensource/xenapi/VMAppliance.java b7e7e36 
  deps/XenServerJava/src/com/xensource/xenapi/VMGuestMetrics.java 08d88e3 
  deps/XenServerJava/src/com/xensource/xenapi/VMMetrics.java 5f9a7a4 
  deps/XenServerJava/src/com/xensource/xenapi/VMPP.java 0ee0b3e 
  deps/XenServerJava/src/com/xensource/xenapi/VTPM.java 25c3320 
  deps/XenServerJava/src/com/xensource/xenapi/XenAPIObject.java b9821ee 

Diff: https://reviews.apache.org/r/17843/diff/


Testing
---


Thanks,

Sanjay Tripathi

Re: [Discuss] GRE Tunnel issue on XenServer 6.2

[Nguyen Anh Tu]

Murali,

This patch worked but not perfect. It can skip throwing exeption when
plugging Dom0's VIF to network but actually the bridge is still not
recognized from HOSTs. Everything is done if we plug a DomU's VIF instead.
I don't know why.

--Tuna


On Mon, Feb 24, 2014 at 7:18 PM, Murali Reddy wrote:

>  Problem is just creating network does not create bridge apparently on
> XenServer as the comments on 'enableXenServerNetwork' method indicate. So
> when findOrCreateTunnelNetwork is called to see if the network exists,
> since network object is present across cluster function just returns but
> bridge is not created.
>
>  Trick is to create bridge explicitly. Below diff worked for me, but did
> not have time to test it and submit. Will look into it tomorrow.
>
>  diff --git
> a/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
> b/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
> index cf5c6d6..a935d3f 100644
> ---
> a/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
> +++
> b/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
> @@ -900,8 +900,16 @@ public abstract class CitrixResourceBase implements
> ServerResource, HypervisorRe
>  dom0vif = VIF.create(conn, vifr);
>  }
>  // At this stage we surely have a VIF
> -dom0vif.plug(conn);
> -dom0vif.unplug(conn);
> +try {
> +dom0vif.plug(conn);
> +} catch (Exception e) {
> +// ignore fake exception
> +}
> +try {
> +dom0vif.unplug(conn);
> +} catch (Exception e) {
> +// ignore fake exception
> +}
>  synchronized (_tmpDom0Vif) {
>  _tmpDom0Vif.add(dom0vif);
>  }
> @@ -923,8 +931,8 @@ public abstract class CitrixResourceBase implements
> ServerResource, HypervisorRe
>  } else {
>  vswitchNw = networks.iterator().next();
>  }
> -if (!is_xcp())
> -enableXenServerNetwork(conn, vswitchNw, "vswitch",
> "vswitch network");
> +
> +enableXenServerNetwork(conn, vswitchNw, "vswitch",
> "vswitch network");
>  _host.vswitchNetwork = vswitchNw;
>  }
>  return _host.vswitchNetwork;
> @@ -963,6 +971,7 @@ public abstract class CitrixResourceBase implements
> ServerResource, HypervisorRe
>  s_logger.debug("### Xen Server network for tunnels
> created:" + nwName);
>  } else {
>  nw = networks.iterator().next();
> +enableXenServerNetwork(conn, nw, nwName, "tunnel network
> for account " + key);
>  s_logger.debug("Xen Server network for tunnels found:" +
> nwName);
>  }
>  return nw;
>
>   From: Nguyen Anh Tu 
> Date: Saturday, 22 February 2014 12:32 AM
> To: "dev@cloudstack.apache.org" 
> Cc: Murali Reddy 
> Subject: [Discuss] GRE Tunnel issue on XenServer 6.2
>
>   Hi guys,
>
>  Some people (Florin and Benoit) complain about the GRE tunnel issue on
> XenServer 6.2. Actually it has not been fixed completely, although Murali
> submitted a patch to bypass without any exception. Personally I stuck in
> how can we make XenServer 6.2 HOSTs recognize the GRE network created by an
> another HOST in one cluster. I confirm the "enableXenServer" (the tricky)
> method doesn't work in that case.
>
>  Anyone can help?
>
>  Thanks,
>
>   --Tuna
>

Re: developers and mysql

[John Kinsella]

I created CLOUDSTACK-6157 over the weekend to track this. Not sure adding the 
jar after compile will help the deploydb target, but will give it a try this 
morning.

Could we set up the pom.xmls to use the jar for execution if it’s found in the 
user/system classpaths while respecting the legal requirements?

Rayees’ suggestion for cloud.spec makes sense for the RPM builds, but doesn’t 
affect the developer issues.

-He who needs more maven experience

On Feb 24, 2014, at 7:36 AM, Hugo Trippaers  wrote:

> Heya,
> 
> as the mysql dependency is now set to provided in all the poms to fix our 
> license compliancy the jetty target and the deployed targets are not working. 
> 
> I’m trying to configure an optional profile to enable those targets to 
> include the mysql dependency while executing, but so far no luck. If anyone 
> has some bright ideas on how to do this i’m all ears. In the meantime the 
> best solutions i’ve found to continue working is to copy the mysql jar file 
> into the directory client/target/cloud-client-ui-4.4.0-SNAPSHOT/WEB-INF/lib/ 
> by hand after running mvm install and before running the jetty target (just 
> don’t run mvn clean).
> 
> Hopefully a better solution in the near future.
> 
> Cheers,
> 
> Hugo

Re: OVS plugin in CloudStack 4.3.0

[Nguyen Anh Tu]

On Mon, Feb 24, 2014 at 7:01 PM, Murali Reddy wrote:

> Opened UI bug for 4.3 CLOUDSTACK-6162 if some one can help fixing the UI
> part.
>

Murali,

We'll get it in the end of February, I promise!

--Tuna

Re: [PROPOSAL] Windowsfication Of ACS

[David Nalley]

Perhaps worth looking at what AOO is using. They clearly make use of a
Windows installer.

--David

On Mon, Feb 24, 2014 at 7:10 AM, Abhinandan Prateek
 wrote:
> Anyone, is there an open source windows installer tool ?
>
> -abhi
>
>
>
> On 21/02/14 2:30 pm, "Donal Lafferty"  wrote:
>
>>I prefer the focus on support that comes with David's suggestion.
>>Targeting the latest stable release for a new platform greatly reduces
>>the number of permutations to test.
>>
>>Pursuing legacy systems limits the flexibility of ACS to evolve.  For
>>instance, we'll probably be on Java 7 in the next while, and W2K3 doesn't
>>appear on the supported system list (see
>>https://www.java.com/en/download/help/sysreq.xml).  Likewise, older
>>versions of Internet Explorer can be quite different than what Microsoft
>>has recently published.
>>
>>My guess is that the engineering effort to get ACS working on a legacy
>>system makes sense as a consultancy service offered independent to ACS.
>>That's the case of OS/2 support ;)
>>
>>
>>DL
>>
>>
>>> -Original Message-
>>> From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
>>> Sent: 20 February 2014 14:29
>>> To: dev@cloudstack.apache.org
>>> Subject: RE: [PROPOSAL] Windowsfication Of ACS
>>>
>>> I agree totally, my point was that while there is nothing technically
>>>stopping
>>> us going for w2k3 there is little reason to do so.
>>>
>>>
>>> Regards
>>>
>>> Alex Hitchins
>>>
>>> D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
>>>
>>> alex.hitch...@shapeblue.com
>>>
>>> -Original Message-
>>> From: David Nalley [mailto:da...@gnsa.us]
>>> Sent: 20 February 2014 13:24
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: [PROPOSAL] Windowsfication Of ACS
>>>
>>> There's a difference in incidentally working and validated to work on.
>>> I'd limit focus to making sure it works on 2k12r2.
>>>
>>> --David
>>>
>>> On Thu, Feb 20, 2014 at 6:37 AM, Alex Hitchins
>>>  wrote:
>>> > I can't think of anything that wouldn't be possible on W2k3 - that
>>>said It's
>>> old and I can't see people having a need for it.
>>> >
>>> >
>>> > Regards
>>> >
>>> > Alex Hitchins
>>> >
>>> > D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
>>> >
>>> > alex.hitch...@shapeblue.com
>>> >
>>> > -Original Message-
>>> > From: Paul Angus [mailto:paul.an...@shapeblue.com]
>>> > Sent: 20 February 2014 11:17
>>> > To: dev@cloudstack.apache.org
>>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>>> >
>>> > Isn't the hyper-v support dependant on using 2012r2 ?
>>> >
>>> > So I don't know if I'd bother with going back as far as 2003
>>> >
>>> > Regards,
>>> >
>>> > Paul Angus
>>> > Cloud Architect
>>> > S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
>>> > paul.an...@shapeblue.com
>>> >
>>> > -Original Message-
>>> > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
>>> > Sent: 20 February 2014 11:13
>>> > To: dev@cloudstack.apache.org
>>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>>> >
>>> > AFAIK, it would be windows server 2k3, 2k8 2012, 2012R2.
>>> >
>>> > Thanks
>>> > Rajesh Battala
>>> >
>>> > -Original Message-
>>> > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
>>> > Sent: Thursday, February 20, 2014 4:32 PM
>>> > To: dev@cloudstack.apache.org
>>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>>> >
>>> > One question I have is, Which version of windows we need to target?
>>> >
>>> > Thanks & Regards
>>> > Damodar/
>>> >
>>> >
>>> > -Original Message-
>>> > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
>>> > Sent: Thursday, February 20, 2014 2:04 PM
>>> > To: dev@cloudstack.apache.org
>>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>>> >
>>> > I have tried to put all together in FS at
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Win
>>> dowsfication as Feedback section and added my comments there.
>>> >
>>> > Please verify once and let me know if anything is to be added there.
>>> >
>>> > Thanks & Regards
>>> > Damodar/
>>> >
>>> >
>>> > -Original Message-
>>> > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
>>> > Sent: Thursday, February 20, 2014 12:32 PM
>>> > To: dev@cloudstack.apache.org
>>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>>> >
>>> > Thank you all for your inputs.
>>> >
>>> >  I will aggregate all these things into FS  as appendix and will put
>>>comments
>>> there instead of replying here one by one. Once I am done with update
>>>in FS
>>> I will notify so that we can verify whether we are covering all or not.
>>> >
>>> > Thanks & Regards
>>> > Damodar/
>>> >
>>> > -Original Message-
>>> > From: abhisek basu [mailto:abhisekb...@msn.com]
>>> > Sent: Sunday, February 16, 2014 9:16 AM
>>> > To: dev@cloudstack.apache.org
>>> > Cc: dev@cloudstack.apache.org
>>> > Subject: Re: [PROPOSAL] Windowsfication Of ACS
>>> >
>>> > Getting a Windows version will expand ACS reach to a large no of
>>> > audience and make it more OS indepe

Yet another mail on code quality

[Hugo Trippaers]

Guys,

Please pay attention to the code you are committing. Today i fixed a number of 
issues that were introduced in recent code, these are bugs that could have been 
prevented from entering master by either testing or running the findbugs 
checks. One was committed directly, the other one through a reviewed patch.


@@ -116,7 +116,7 @@ public class Upgrade430to440 implements DbUpgrade {
 if (networkRs.next()) {
 String guesttype = networkRs.getString(1);
 
-if (guesttype == 
Network.GuestType.Shared.toString()) {
+if 
(guesttype.equals(Network.GuestType.Shared.toString())) {
 pstmtUpdate = conn.prepareStatement("UPDATE 
`cloud`.`user_ip_address` SET account_id = ?, domain_id= ? WHERE 
public_ip_address = ?");
 pstmtUpdate.setLong(1,vmAccountId);
 pstmtUpdate.setLong(2,vmDomainId);



@@ -80,11 +80,11 @@ public class LibvirtStoragePoolXMLParser {
 String targetPath = getTagValue("path", target);
 
 String portValue = getAttrValue("host", "port", source);
-if (portValue != "")
+if (portValue != null && !portValue.isEmpty())
 port = Integer.parseInt(portValue);
 
 return new 
LibvirtStoragePoolDef(LibvirtStoragePoolDef.poolType.valueOf(format.toUpperCase()),


To help, i’ve configured the slowbuild to alert if the number of high priority 
findings from findbugs differs from the previous run. It will notify all 
developers that had changes during this period (slowbuild runs every 4 hours).

Cheers,

Hugo

RE: developers and mysql

[Rayees Namathponnan]

Hi Hugo,

How about making below changes in cloud.spec file ?

#1)
Requires: nfs-utils
Requires: wget
# mysql-connector 5.1.29 will be installed before installing management server 
Requires: mysql-connector-java = 5.1.29

#2)

# Don't package the scripts in the management webapp
rm -rf 
${RPM_BUILD_ROOT}%{_datadir}/%{name}-management/webapps/client/WEB-INF/classes/scripts
rm -rf 
${RPM_BUILD_ROOT}%{_datadir}/%{name}-management/webapps/client/WEB-INF/classes/vms
#Remove mysql connector , which is used while building cloudstack
rm -rf 
${RPM_BUILD_ROOT}%{_datadir}/%{name}-management/webapps/client/WEB-INF/lib/mysql-connector-java*

#3)
if [ -f "%{_sysconfdir}/cloud.rpmsave/management/cloud.keystore" ]; then
cp -p %{_sysconfdir}/cloud.rpmsave/management/cloud.keystore 
%{_sysconfdir}/%{name}/management/cloudmanagementserver.keystore
# make sure we only do this on the first install of this RPM, don't want to 
overwrite on a reinstall
mv %{_sysconfdir}/cloud.rpmsave/management/cloud.keystore 
%{_sysconfdir}/cloud.rpmsave/management/cloud.keystore.rpmsave
fi

#Copy installed mysql to cloudstack-management lib folder
cp -p /usr/share/java/ mysql-connector-java-5.1.29.jar 
%{_datadir}/%{name}-management/webapps/client/WEB-INF/lib


If we don't want to use mysql-connector 5.1.29, we can make some changes to use 
any version of mysql-connector

Regards,
Rayees 

-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Monday, February 24, 2014 7:36 AM
To: 
Subject: developers and mysql

Heya,

as the mysql dependency is now set to provided in all the poms to fix our 
license compliancy the jetty target and the deployed targets are not working. 

I'm trying to configure an optional profile to enable those targets to include 
the mysql dependency while executing, but so far no luck. If anyone has some 
bright ideas on how to do this i'm all ears. In the meantime the best solutions 
i've found to continue working is to copy the mysql jar file into the directory 
client/target/cloud-client-ui-4.4.0-SNAPSHOT/WEB-INF/lib/ by hand after running 
mvm install and before running the jetty target (just don't run mvn clean).

Hopefully a better solution in the near future.

Cheers,

Hugo

RE: [PROPOSAL] Change systemvm template URL in master to s3 bucket

[Rayees Namathponnan]

Hi Hugo,

This is only for master alone always or will be making the same for next 
current release ie 4.4?

Regards,
Rayees 

-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Monday, February 24, 2014 1:51 AM
To: 
Subject: [PROPOSAL] Change systemvm template URL in master to s3 bucket

Hey all,

I've finally fixed the configuration to automagically upload the systemvm 
templates to an s3 bucket. The jobs build-systemvm-master and 
build-systemvm64-master will rebuild the systemvm template on a daily basis and 
send the resulting files to that S3 bucket.

I would like to update the URLs in the docs and in the database to make master 
point to these new locations. The locations will look like : 
https://s3.amazonaws.com/systemvm-templates.cloudstack.org/master/64/systemvm64template-master-hyperv.vhd

Why? 
  Anyone using master will automagically use the latest and greatest images.
  Transparent process from build script to distribution.
  Accessible logging for folks willing to track number of downloads etc.


Any thoughts?

Cheers,

Hugo

Re: [DISCUSS] Policy blocker?

[Hugo Trippaers]

Guys,

I did a quick check using the scanner at 
http://www.sonatype.com/application-health-check.  According to that report we 
need to do some additional checking of our dependencies. 

Licenses:
  Copyleft: 2
  Non-standard: 9
  Weak-copyleft: 15
  Liberal: 82

I can’t get the exact details as that requires the full report ($499 ouch..), 
but at least it warrants investigation before we can release. 

Here is the printout of the report: 
https://dl.dropboxusercontent.com/u/70226362/app-check.pdf

Cheers,

Hugo


On 23 feb. 2014, at 07:24, Rayees Namathponnan  
wrote:

> Hi David, 
> 
> One doubt, while building cloudstack we are using "mysql-connector-java 
> version 5.1.29"; is it not mandatory we should supposed to use same version 
> of mysql-connector during run time? 
> 
> Regards,
> Rayees 
> 
> -Original Message-
> From: David Nalley [mailto:da...@gnsa.us] 
> Sent: Saturday, February 22, 2014 7:59 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Policy blocker?
> 
> Hi folks:
> 
> I think this issue is resolved in the 4.3 branch. The default build system no 
> longer seems to grab the mysql jar, and I've adjusted tomcat to load the 
> mysql jar from the system library.
> 
> Commit 0c2ad0338e34f6117cecc24ec00c7746dd481465 should have the necessary 
> changes.
> 
> I did some quick testing, and this seems to work, but obviously it needs more 
> eyes and testing.
> 
> --David
> 
> On Thu, Feb 20, 2014 at 8:37 AM, David Nalley  wrote:
>> Hi folks,
>> 
>> I cringe to raise this issue. After 6 RCs I am sure we are all feeling 
>> a little bit of release vote fatigue. Especially Animesh. I apologize 
>> in advance; in all other respects I am ready to give a +1 to RC6.
>> 
>> I've been playing with 4.3.0-rc6 for a couple of days now. I attempted 
>> to build some RPMs and had problems with dependency resolution in 
>> maven. This led me to looking at a number of different poms, and I 
>> noticed mysql-connector-java is listed as a runtime dependency. For 
>> our end users, this really isn't necessary - the debs and rpms specify 
>> a requirement (effectively a system requirement in the terms of
>> policy) for mysql-connector-java. We don't need it to build the 
>> software (at least not in any location I've seen) - just when running.
>> (And thus its a system dependency, much like MySQL is.)
>> 
>> mysql-connector-java is GPLv2; which is Cat X. By including it as a 
>> dependency in the pom it automatically gets downloaded. The 3rd Party 
>> software policy has this line in it:
>> 
>> "YOU MUST NOT distribute build scripts or documentation within an 
>> Apache product with the purpose of causing the default/standard build 
>> of an Apache product to include any part of aprohibited work."
>> 
>> We've released software with this dependency previously. Is this a 
>> blocker for 4.3 or do we fix going forward? (If we hadn't already 
>> shipped releases with this problem I'd lean a bit more towards it 
>> being a blocker - but its more murky now.)
>> 
>> Thoughts, comments, flames?
>> 
>> --David
>> 
>> [1] https://www.apache.org/legal/3party.html

developers and mysql

[Hugo Trippaers]

Heya,

as the mysql dependency is now set to provided in all the poms to fix our 
license compliancy the jetty target and the deployed targets are not working. 

I’m trying to configure an optional profile to enable those targets to include 
the mysql dependency while executing, but so far no luck. If anyone has some 
bright ideas on how to do this i’m all ears. In the meantime the best solutions 
i’ve found to continue working is to copy the mysql jar file into the directory 
client/target/cloud-client-ui-4.4.0-SNAPSHOT/WEB-INF/lib/ by hand after running 
mvm install and before running the jetty target (just don’t run mvn clean).

Hopefully a better solution in the near future.

Cheers,

Hugo

RE: [PROPOSAL] Windowsfication Of ACS

[Alex Hitchins]

I've used the Nullsoft installer a long time ago, looks like it's still about.

http://nsis.sourceforge.net/Main_Page

I can't comment on it as it's a long, long time since I used it.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Abhinandan Prateek [mailto:abhinandan.prat...@citrix.com]
Sent: 24 February 2014 12:11
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] Windowsfication Of ACS

Anyone, is there an open source windows installer tool ?

-abhi



On 21/02/14 2:30 pm, "Donal Lafferty"  wrote:

>I prefer the focus on support that comes with David's suggestion.
>Targeting the latest stable release for a new platform greatly reduces
>the number of permutations to test.
>
>Pursuing legacy systems limits the flexibility of ACS to evolve.  For
>instance, we'll probably be on Java 7 in the next while, and W2K3
>doesn't appear on the supported system list (see
>https://www.java.com/en/download/help/sysreq.xml).  Likewise, older
>versions of Internet Explorer can be quite different than what
>Microsoft has recently published.
>
>My guess is that the engineering effort to get ACS working on a legacy
>system makes sense as a consultancy service offered independent to ACS.
>That's the case of OS/2 support ;)
>
>
>DL
>
>
>> -Original Message-
>> From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
>> Sent: 20 February 2014 14:29
>> To: dev@cloudstack.apache.org
>> Subject: RE: [PROPOSAL] Windowsfication Of ACS
>>
>> I agree totally, my point was that while there is nothing technically
>>stopping  us going for w2k3 there is little reason to do so.
>>
>>
>> Regards
>>
>> Alex Hitchins
>>
>> D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
>>
>> alex.hitch...@shapeblue.com
>>
>> -Original Message-
>> From: David Nalley [mailto:da...@gnsa.us]
>> Sent: 20 February 2014 13:24
>> To: dev@cloudstack.apache.org
>> Subject: Re: [PROPOSAL] Windowsfication Of ACS
>>
>> There's a difference in incidentally working and validated to work on.
>> I'd limit focus to making sure it works on 2k12r2.
>>
>> --David
>>
>> On Thu, Feb 20, 2014 at 6:37 AM, Alex Hitchins
>>  wrote:
>> > I can't think of anything that wouldn't be possible on W2k3 - that
>>said It's
>> old and I can't see people having a need for it.
>> >
>> >
>> > Regards
>> >
>> > Alex Hitchins
>> >
>> > D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
>> >
>> > alex.hitch...@shapeblue.com
>> >
>> > -Original Message-
>> > From: Paul Angus [mailto:paul.an...@shapeblue.com]
>> > Sent: 20 February 2014 11:17
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> >
>> > Isn't the hyper-v support dependant on using 2012r2 ?
>> >
>> > So I don't know if I'd bother with going back as far as 2003
>> >
>> > Regards,
>> >
>> > Paul Angus
>> > Cloud Architect
>> > S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
>> > paul.an...@shapeblue.com
>> >
>> > -Original Message-
>> > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
>> > Sent: 20 February 2014 11:13
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> >
>> > AFAIK, it would be windows server 2k3, 2k8 2012, 2012R2.
>> >
>> > Thanks
>> > Rajesh Battala
>> >
>> > -Original Message-
>> > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
>> > Sent: Thursday, February 20, 2014 4:32 PM
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> >
>> > One question I have is, Which version of windows we need to target?
>> >
>> > Thanks & Regards
>> > Damodar/
>> >
>> >
>> > -Original Message-
>> > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
>> > Sent: Thursday, February 20, 2014 2:04 PM
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> >
>> > I have tried to put all together in FS at
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Win
>> dowsfication as Feedback section and added my comments there.
>> >
>> > Please verify once and let me know if anything is to be added there.
>> >
>> > Thanks & Regards
>> > Damodar/
>> >
>> >
>> > -Original Message-
>> > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
>> > Sent: Thursday, February 20, 2014 12:32 PM
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> >
>> > Thank you all for your inputs.
>> >
>> >  I will aggregate all these things into FS  as appendix and will
>> > put
>>comments
>> there instead of replying here one by one. Once I am done with update
>>in FS  I will notify so that we can verify whether we are covering all
>>or not.
>> >
>> > Thanks & Regards
>> > Damodar/
>> >
>> > -Original Message-
>> > From: abhisek basu [mailto:abhisekb...@msn.com]
>> > Sent: Sunday, February 16, 2014 9:16 AM
>> > To: dev@cloudstack.apache.org
>> > Cc: dev@c

Re: Review Request 16385: Fix for CloudStack JIRA 4406

[daan Hoogland]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16385/#review35276
---


I'll download and money test. please adjust the description to indicate that 
calling cleanup is the default (I hope it is) and that not calling it is the 
exception that helps with performance.

regards

- daan Hoogland


On Feb. 24, 2014, 2:38 p.m., Mandar Barve wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16385/
> ---
> 
> (Updated Feb. 24, 2014, 2:38 p.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Bugs: CLOUDSTACK-4406
> https://issues.apache.org/jira/browse/CLOUDSTACK-4406
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> JIRA 4406 expects removal of cleanString() call for performance 
> improvements. This is called when building audit trail for command responses 
> and used for removing sensitive data (passwords, secret keys) from the log 
> buffer. All the API responses do not carry such sensitive information so 
> pattern matching done by cleanString against all API response strings can be 
> costly. 
> 
> I propose following for a solution:
> 
> * Modify BaseCmd class to add flags that will store cmd/response sensitivity
> * At init these flags will be set to false indicating no cmd req/resp carries 
> sensitive data
> * any child api cmd class that will carry sensitive data in the req/resp 
> should set the respective flags
> * before calling any logging function the flag should be checked and 
> cleanString should be called only for cmds with flags set
> 
> Pro: This approach will scale well as new cmds get added and no additional 
> changes should be required.
> Con: Big change upfront as it will touch all API cmd classes that carry 
> sensitive information along with BaseCmd class. 
> 
> NOTE: changes should be simple and straightforward though spread across 
> multiple classes.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/APICommand.java 5587a48 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
> c5a2d1a 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
> 7c1b206 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java
>  6fdbefe 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
> 59d6acd 
>   api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
> 93ec1be 
>   
> api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
> a8cf63f 
>   api/src/org/apache/cloudstack/api/command/admin/alert/GenerateAlertCmd.java 
> 3eaa053 
>   
> api/src/org/apache/cloudstack/api/command/admin/autoscale/CreateCounterCmd.java
>  6c4b81b 
>   
> api/src/org/apache/cloudstack/api/command/admin/autoscale/DeleteCounterCmd.java
>  50477f5 
>   api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java 
> d0e7380 
>   
> api/src/org/apache/cloudstack/api/command/admin/cluster/DeleteClusterCmd.java 
> e1bc585 
>   
> api/src/org/apache/cloudstack/api/command/admin/cluster/ListClustersCmd.java 
> 8640f37 
>   
> api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java 
> b13f81a 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 
> 517807d 
>   
> api/src/org/apache/cloudstack/api/command/admin/config/ListDeploymentPlannersCmd.java
>  1d9d2d9 
>   
> api/src/org/apache/cloudstack/api/command/admin/config/ListHypervisorCapabilitiesCmd.java
>  16adf66 
>   api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 
> 9bc9b3c 
>   
> api/src/org/apache/cloudstack/api/command/admin/config/UpdateHypervisorCapabilitiesCmd.java
>  5cb5f9c 
>   api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
> 4737555 
>   api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
> b1075c1 
>   
> api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainChildrenCmd.java
>  e1ba178 
>   api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainsCmd.java 
> 5a3786c 
>   api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
> 8acfcd5 
>   api/src/org/apache/cloudstack/api/command/admin/host/AddHostCmd.java 
> 363bcd6 
>   
> api/src/org/apache/cloudstack/api/command/admin/host/AddSecondaryStorageCmd.java
>  b573bea 
>   
> api/src/org/apache/cloudstack/api/command/admin/host/CancelMaintenanceCmd.java
>  46289ee 
>   api/src/org/apache/cloudstack/api/command/admin/host/DeleteHostCmd.java 
> 5a4478e 
>   
> api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java
>  0faf72c 
>   api/src/org/apache/cloudstack/api/

Review Request 17995: Added fix for CLOUDSTACK - 6164

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17995/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-6164
https://issues.apache.org/jira/browse/CLOUDSTACK-6164


Repository: cloudstack-git


Description
---

Currently,Host class has a create method, uses addHost Command, but 

1. It does not verify the output of addHost command is valid output in all 
forms. 
2. Tests some times directly goes to using Host post Host.create, but we are 
not sure whether the host is up or not, they have to explicitly call again 
listHosts api call, so every where host is added list host is called. Instead, 
the create method now returns the FAILED or host object based upon the api 
success and whether the host is up. 
3. Added a try\except block and return FAILED to tests in case of an exception. 


Diffs
-

  tools/marvin/marvin/config/test_data.py PRE-CREATION 
  tools/marvin/marvin/deployDataCenter.py c8feaaf 

Diff: https://reviews.apache.org/r/17995/diff/


Testing
---

Tested indentation and import changes.


Thanks,

Santhosh Edukulla

Re: Review Request 16385: Fix for CloudStack JIRA 4406

[Mandar Barve]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16385/
---

(Updated Feb. 24, 2014, 2:38 p.m.)


Review request for cloudstack and daan Hoogland.


Bugs: CLOUDSTACK-4406
https://issues.apache.org/jira/browse/CLOUDSTACK-4406


Repository: cloudstack-git


Description
---

JIRA 4406 expects removal of cleanString() call for performance 
improvements. This is called when building audit trail for command responses 
and used for removing sensitive data (passwords, secret keys) from the log 
buffer. All the API responses do not carry such sensitive information so 
pattern matching done by cleanString against all API response strings can be 
costly. 

I propose following for a solution:

* Modify BaseCmd class to add flags that will store cmd/response sensitivity
* At init these flags will be set to false indicating no cmd req/resp carries 
sensitive data
* any child api cmd class that will carry sensitive data in the req/resp should 
set the respective flags
* before calling any logging function the flag should be checked and 
cleanString should be called only for cmds with flags set

Pro: This approach will scale well as new cmds get added and no additional 
changes should be required.
Con: Big change upfront as it will touch all API cmd classes that carry 
sensitive information along with BaseCmd class. 

NOTE: changes should be simple and straightforward though spread across 
multiple classes.


Diffs
-

  api/src/org/apache/cloudstack/api/APICommand.java 5587a48 
  api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
c5a2d1a 
  api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
7c1b206 
  
api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java 
6fdbefe 
  api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
59d6acd 
  api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
93ec1be 
  api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
a8cf63f 
  api/src/org/apache/cloudstack/api/command/admin/alert/GenerateAlertCmd.java 
3eaa053 
  
api/src/org/apache/cloudstack/api/command/admin/autoscale/CreateCounterCmd.java 
6c4b81b 
  
api/src/org/apache/cloudstack/api/command/admin/autoscale/DeleteCounterCmd.java 
50477f5 
  api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java 
d0e7380 
  api/src/org/apache/cloudstack/api/command/admin/cluster/DeleteClusterCmd.java 
e1bc585 
  api/src/org/apache/cloudstack/api/command/admin/cluster/ListClustersCmd.java 
8640f37 
  api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java 
b13f81a 
  api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 
517807d 
  
api/src/org/apache/cloudstack/api/command/admin/config/ListDeploymentPlannersCmd.java
 1d9d2d9 
  
api/src/org/apache/cloudstack/api/command/admin/config/ListHypervisorCapabilitiesCmd.java
 16adf66 
  api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 
9bc9b3c 
  
api/src/org/apache/cloudstack/api/command/admin/config/UpdateHypervisorCapabilitiesCmd.java
 5cb5f9c 
  api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
4737555 
  api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
b1075c1 
  
api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainChildrenCmd.java
 e1ba178 
  api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainsCmd.java 
5a3786c 
  api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
8acfcd5 
  api/src/org/apache/cloudstack/api/command/admin/host/AddHostCmd.java 363bcd6 
  
api/src/org/apache/cloudstack/api/command/admin/host/AddSecondaryStorageCmd.java
 b573bea 
  
api/src/org/apache/cloudstack/api/command/admin/host/CancelMaintenanceCmd.java 
46289ee 
  api/src/org/apache/cloudstack/api/command/admin/host/DeleteHostCmd.java 
5a4478e 
  
api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java
 0faf72c 
  api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 
eda821b 
  
api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java
 23cfacf 
  api/src/org/apache/cloudstack/api/command/admin/host/ReconnectHostCmd.java 
1ce888b 
  
api/src/org/apache/cloudstack/api/command/admin/host/ReleaseHostReservationCmd.java
 b60feca 
  api/src/org/apache/cloudstack/api/command/admin/host/UpdateHostCmd.java 
d778b37 
  
api/src/org/apache/cloudstack/api/command/admin/host/UpdateHostPasswordCmd.java 
69480b1 
  
api/src/org/apache/cloudstack/api/command/admin/internallb/ConfigureInternalLoadBalancerElementCmd.java
 51da760 
  
api/src/org/apache/cloudstack/api/command/admin/internallb/CreateInternalLoadBalancerElementCmd.java
 a6ece72 
  
api/src/org/apache/clouds

Re: Review Request 16385: Fix for CloudStack JIRA 4406

[Mandar Barve]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16385/
---

(Updated Feb. 24, 2014, 2:37 p.m.)


Review request for cloudstack and daan Hoogland.


Changes
---

Hi Daan,
   I have updated the patch with all API commands changed to use the new 
annotation. Please take a look. Also let me know if you are looking for any 
specific testing.

Thanks,
Mandar


Bugs: CLOUDSTACK-4406
https://issues.apache.org/jira/browse/CLOUDSTACK-4406


Repository: cloudstack-git


Description
---

JIRA 4406 expects removal of cleanString() call for performance 
improvements. This is called when building audit trail for command responses 
and used for removing sensitive data (passwords, secret keys) from the log 
buffer. All the API responses do not carry such sensitive information so 
pattern matching done by cleanString against all API response strings can be 
costly. 

I propose following for a solution:

* Modify BaseCmd class to add flags that will store cmd/response sensitivity
* At init these flags will be set to false indicating no cmd req/resp carries 
sensitive data
* any child api cmd class that will carry sensitive data in the req/resp should 
set the respective flags
* before calling any logging function the flag should be checked and 
cleanString should be called only for cmds with flags set

Pro: This approach will scale well as new cmds get added and no additional 
changes should be required.
Con: Big change upfront as it will touch all API cmd classes that carry 
sensitive information along with BaseCmd class. 

NOTE: changes should be simple and straightforward though spread across 
multiple classes.


Diffs (updated)
-

  api/src/org/apache/cloudstack/api/APICommand.java 5587a48 
  api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java 
c5a2d1a 
  api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 
7c1b206 
  
api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java 
6fdbefe 
  api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 
59d6acd 
  api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 
93ec1be 
  api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java 
a8cf63f 
  api/src/org/apache/cloudstack/api/command/admin/alert/GenerateAlertCmd.java 
3eaa053 
  
api/src/org/apache/cloudstack/api/command/admin/autoscale/CreateCounterCmd.java 
6c4b81b 
  
api/src/org/apache/cloudstack/api/command/admin/autoscale/DeleteCounterCmd.java 
50477f5 
  api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java 
d0e7380 
  api/src/org/apache/cloudstack/api/command/admin/cluster/DeleteClusterCmd.java 
e1bc585 
  api/src/org/apache/cloudstack/api/command/admin/cluster/ListClustersCmd.java 
8640f37 
  api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java 
b13f81a 
  api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 
517807d 
  
api/src/org/apache/cloudstack/api/command/admin/config/ListDeploymentPlannersCmd.java
 1d9d2d9 
  
api/src/org/apache/cloudstack/api/command/admin/config/ListHypervisorCapabilitiesCmd.java
 16adf66 
  api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 
9bc9b3c 
  
api/src/org/apache/cloudstack/api/command/admin/config/UpdateHypervisorCapabilitiesCmd.java
 5cb5f9c 
  api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 
4737555 
  api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java 
b1075c1 
  
api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainChildrenCmd.java
 e1ba178 
  api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainsCmd.java 
5a3786c 
  api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 
8acfcd5 
  api/src/org/apache/cloudstack/api/command/admin/host/AddHostCmd.java 363bcd6 
  
api/src/org/apache/cloudstack/api/command/admin/host/AddSecondaryStorageCmd.java
 b573bea 
  
api/src/org/apache/cloudstack/api/command/admin/host/CancelMaintenanceCmd.java 
46289ee 
  api/src/org/apache/cloudstack/api/command/admin/host/DeleteHostCmd.java 
5a4478e 
  
api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java
 0faf72c 
  api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 
eda821b 
  
api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java
 23cfacf 
  api/src/org/apache/cloudstack/api/command/admin/host/ReconnectHostCmd.java 
1ce888b 
  
api/src/org/apache/cloudstack/api/command/admin/host/ReleaseHostReservationCmd.java
 b60feca 
  api/src/org/apache/cloudstack/api/command/admin/host/UpdateHostCmd.java 
d778b37 
  
api/src/org/apache/cloudstack/api/command/admin/host/UpdateHostPasswordCmd.java 
69480b1 
  
api/src/org/apache/cloudstack/api

Re: Review Request 18352: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool

[Saksham Srivastava]

> On Feb. 24, 2014, 7:10 a.m., Koushik Das wrote:
> > engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java,
> >  line 118
> > 
> >
> > If you specify the host then you don't need dc, pod, cluster.

The reason why I added this was to make sure in case the hostId is passed as 
null, we could return tagged storagePools by calling 
findLocalStoragePoolsByTags.
This is more of an extra check that we should return all hosts with matching 
tags even when host is not passed. 
As suggested it may not be required as there are not other cases where one 
would call this utility.


> On Feb. 24, 2014, 7:10 a.m., Koushik Das wrote:
> > engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java,
> >  line 68
> > 
> >
> > I would recommend that you use the createSearchBuilder() approach 
> > instead of hardcoding the sql query. Refer to PrimaryDataStoreDaoImpl() 
> > ctor.

To return local storage pools of matching tags and matching host id requires 
join of 3 tables (storage_pools, storage_host_ref and storage_pool_details). 
Further , all the methods that search for tagged pools in this file are 
currently using the same technique of filling the base sql query with custom 
search parameters, I have also gone the same way.
But as you have mentioned I will update the patch using createSearchBuilder() 
method.


> On Feb. 24, 2014, 7:10 a.m., Koushik Das wrote:
> > engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java,
> >  line 366
> > 
> >
> > What is the use case for null host id? Make it long instead of Long.

This is just because I was checking for null hostIds, since the check may not 
be required, I will change it to long.


- Saksham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18352/#review35257
---


On Feb. 21, 2014, 11:36 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18352/
> ---
> 
> (Updated Feb. 21, 2014, 11:36 a.m.)
> 
> 
> Review request for cloudstack, Koushik Das and Prachi Damle.
> 
> 
> Bugs: CLOUDSTACK-6151
> https://issues.apache.org/jira/browse/CLOUDSTACK-6151
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Attaching a disk created from local disk offering with tags, to a VM was 
> going to wrong local storage pool.
> Cause : In LocalStoragePoolAlocator-
> List hostPools = 
> _poolHostDao.listByHostId(plan.getHostId());
> It return pools by hostId, but nowhere were the tags being compared.
> 
> Added new method findLocalStoragePoolsByHostAndTags() that returns stoage 
> pools by hostid and tags both.
> 
> 
> Diffs
> -
> 
>   
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
>  59c338e 
>   
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
>  d35aa44 
>   
> engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java
>  1f61e8b 
> 
> Diff: https://reviews.apache.org/r/18352/diff/
> 
> 
> Testing
> ---
> 
> Tested the folowing scenarios:
> attaching local volume with tags
> attaching local volume without tags
> attaching local volume with different tags
> attaching shared volume
> 
> Build passes successfully.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

unable to deploy ubuntu as guest vm

[Tejas Gadaria]

Hi,

I am using CS 4.0.2 with basic zone, xenserver (6.0.2) as hypervisor.
I am able to deploy Windows 7 vm from ISO but not ubuntu.
Also I tried to deploy centOS 5 from ISO, where graphics doesn't supports.

Any help would be appreciated.



2014-02-24 17:33:17,601 DEBUG [xen.resource.CitrixResourceBase]
(DirectAgent-26:null) Creating VIF for i-2-3-VM on nic
[Nic:Guest-10.129.151.107-vlan://untagged]
2014-02-24 17:33:17,653 DEBUG [xen.resource.CitrixResourceBase]
(DirectAgent-26:null) Created a vif a77b6f5e-c663-f0a4-29fb-4be2511479b8 on
0
2014-02-24 17:33:17,936 DEBUG [agent.manager.DirectAgentAttache]
(DirectAgent-13:null) Ping from 1
2014-02-24 17:33:18,320 DEBUG [agent.manager.DirectAgentAttache]
(DirectAgent-148:null) Seq 1-410714114: Executing request
2014-02-24 17:33:18,549 WARN  [xen.resource.CitrixResourceBase]
(DirectAgent-148:null) Ignoring VM i-2-3-VM in transition state starting.
2014-02-24 17:33:18,549 DEBUG [agent.manager.DirectAgentAttache]
(DirectAgent-148:null) Seq 1-410714114: Response Received:
2014-02-24 17:33:18,550 DEBUG [agent.transport.Request]
(DirectAgent-148:null) Seq 1-410714114: Processing:  { Ans: , MgmtId:
345049281638, via: 1, Ver: v1, Flags: 10,
[{"ClusterSyncAnswer":{"_clusterId":1,"_newStates":{},"_isExecuted":false,"result":true,"wait":0}}]
}
2014-02-24 17:33:18,639 DEBUG [cloud.server.StatsCollector]
(StatsCollector-3:null) StorageCollector is running...
2014-02-24 17:33:18,695 DEBUG [agent.transport.Request]
(StatsCollector-3:null) Seq 4-356385005: Received:  { Ans: , MgmtId:
345049281638, via: 4, Ver: v1, Flags: 10, { GetStorageStatsAnswer } }
2014-02-24 17:33:18,699 DEBUG [agent.manager.DirectAgentAttache]
(DirectAgent-130:null) Seq 1-410714197: Executing request
2014-02-24 17:33:19,192 DEBUG [agent.manager.DirectAgentAttache]
(DirectAgent-130:null) Seq 1-410714197: Response Received:
2014-02-24 17:33:19,193 DEBUG [agent.transport.Request]
(StatsCollector-3:null) Seq 1-410714197: Received:  { Ans: , MgmtId:
345049281638, via: 1, Ver: v1, Flags: 10, { GetStorageStatsAnswer } }
2014-02-24 17:33:20,792 DEBUG [cloud.server.StatsCollector]
(StatsCollector-3:null) HostStatsCollector is running...
2014-02-24 17:33:20,800 DEBUG [agent.manager.DirectAgentAttache]
(DirectAgent-129:null) Seq 1-410714198: Executing request
2014-02-24 17:33:20,976 DEBUG [agent.manager.DirectAgentAttache]
(DirectAgent-129:null) Seq 1-410714198: Response Received:
2014-02-24 17:33:20,977 DEBUG [agent.transport.Request]
(StatsCollector-3:null) Seq 1-410714198: Received:  { Ans: , MgmtId:
345049281638, via: 1, Ver: v1, Flags: 10, { GetHostStatsAnswer } }
2014-02-24 17:33:21,712 WARN  [xen.resource.CitrixResourceBase]
(DirectAgent-26:null) Task failed! Task record: uuid:
8f05db8d-5b3e-2fc9-0a35-919336415ca1
   nameLabel: Async.VM.start_on
 nameDescription:
   allowedOperations: []
   currentOperations: {}
 created: Mon Feb 24 17:33:17 IST 2014
finished: Mon Feb 24 17:33:20 IST 2014
  status: FAILURE
  residentOn: com.xensource.xenapi.Host@dadd4d39
progress: 1.0
type: 
  result:
   errorInfo: [INVALID_SOURCE, Unable to access a required file in
the specified repository:
file:///tmp/cdrom-repo-5hkOHp/install.amd/xen/vmlinuz., ]
 otherConfig: {}
   subtaskOf: com.xensource.xenapi.Task@aaf13f6f
subtasks: []

2014-02-24 17:33:21,719 WARN  [xen.resource.CitrixResourceBase]
(DirectAgent-26:null) Unable to start VM(i-2-3-VM) on
host(f8701eb8-3edb-4b58-94e4-1889da729595) due to Task failed! Task
record: uuid: 8f05db8d-5b3e-2fc9-0a35-919336415ca1
   nameLabel: Async.VM.start_on
 nameDescription:
   allowedOperations: []
   currentOperations: {}
 created: Mon Feb 24 17:33:17 IST 2014
finished: Mon Feb 24 17:33:20 IST 2014
  status: FAILURE
  residentOn: com.xensource.xenapi.Host@dadd4d39
progress: 1.0
type: 
  result:
   errorInfo: [INVALID_SOURCE, Unable to access a required file in
the specified repository:
file:///tmp/cdrom-repo-5hkOHp/install.amd/xen/vmlinuz., ]
 otherConfig: {}
   subtaskOf: com.xensource.xenapi.Task@aaf13f6f
subtasks: []

Task failed! Task record: uuid:
8f05db8d-5b3e-2fc9-0a35-919336415ca1
   nameLabel: Async.VM.start_on
 nameDescription:
   allowedOperations: []
   currentOperations: {}
 created: Mon Feb 24 17:33:17 IST 2014
finished: Mon Feb 24 17:33:20 IST 2014
  status: FAILURE
  residentOn: com.xensource.xenapi.Host@dadd4d39
progress: 1.0
type: 
  result:
   errorInfo: [INVALID_SOURCE, Unable to access a required file in
the specified repository:
file:///tmp/cdrom-repo-5hkOHp/install.amd/xen/vmlinuz., ]
 otherConfig: {}
   subtaskOf: com.xensource.xenapi.Task

Re: Review Request 18419: Added changes related to CLOUDSTACK-6160

[Girish Shilamkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18419/#review35273
---

Ship it!


Ship It!

- Girish Shilamkar


On Feb. 24, 2014, 10:53 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18419/
> ---
> 
> (Updated Feb. 24, 2014, 10:53 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-6160
> https://issues.apache.org/jira/browse/CLOUDSTACK-6160
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added few changes for CLOUDSTACK-6160.
> 
> Removed references for apiclient.hypervisor. Few changes pending for 
> VirtualMachine class.
> More information inside the bug.
> 
> 
> Diffs
> -
> 
>   test/integration/component/maint/test_redundant_router.py e282272 
>   test/integration/component/test_accounts.py 45df911 
>   test/integration/component/test_base_image_updation.py 2d6c83b 
>   test/integration/component/test_blocker_bugs.py 1ecbc77 
>   test/integration/component/test_deploy_vm_userdata_reg.py fa0a88c 
>   test/integration/component/test_routers.py 368db60 
>   test/integration/component/test_stopped_vm.py 5f3cea2 
>   test/integration/component/test_templates.py 6babe7e 
>   test/integration/smoke/test_hosts.py 31af7fc 
>   test/integration/smoke/test_routers.py 4432e90 
>   test/integration/smoke/test_ssvm.py d67c55d 
>   tools/marvin/marvin/cloudstackTestClient.py adb7ce3 
>   tools/marvin/marvin/lib/base.py aa23029 
> 
> Diff: https://reviews.apache.org/r/18419/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 18413: Added fix for CLOUDSTACK-6158

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18413/#review35271
---


Commit d06f2b6a70f4ed399f6edddef82b7cae81d0b71a in cloudstack's branch 
refs/heads/marvin from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d06f2b6 ]

CLOUDSTACK-6158: Fix few changes


- ASF Subversion and Git Services


On Feb. 23, 2014, 5:03 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18413/
> ---
> 
> (Updated Feb. 23, 2014, 5:03 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-6158
> https://issues.apache.org/jira/browse/CLOUDSTACK-6158
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added few changes as mentioned under CLOUDSTACK-6158 as below.
>  
> 1. There is no way to delete a data center created earlier. Added a new 
> DeleteDataCenter Interface to delete the earlier created datacenter. If user 
> wants to delete a datacenter created and recreate, deleting has to be manual 
> earlier. With this change, he can delete a data center created earlier. It 
> will be useful at many places for testing to destroy and recreate with new 
> settings etc.
> 
> 2.  when deploy data center runs, it does not adequately verifies whether a 
> given entry is created or not, it just continues. Added checks to see if an 
> entry is not  successful, it reports, dumps to log and exit gracefully.
> 
> 3. DataCenter creation as Transaction : At any given point of time during 
> deploy data center, if an issue happens  half way through, earlier created 
> entries were still available in CS, it wont clean up i.e., data center is 
> half created,  Again, if tried to recreate , the earlier existing entries 
> wont allow to recreate. Now, data center works as transaction, either all 
> entries are created as part of data center or none, added a clean up to 
> delete the half created data center.
> 
> 4. Export the created Data Center so that user can use it to further delete 
> the data center with these exported entries etc.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/cloudstackConnection.py ee1ff00 
>   tools/marvin/marvin/cloudstackTestClient.py adb7ce3 
>   tools/marvin/marvin/deployDataCenter.py bf4b688 
>   tools/marvin/marvin/marvinLog.py 80120c9 
>   tools/marvin/marvin/marvinPlugin.py e6986cc 
> 
> Diff: https://reviews.apache.org/r/18413/diff/
> 
> 
> Testing
> ---
> 
> Tested deleting deploy dc scenarios.
> Tested deploy and clean up if an issue occurs.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 18419: Added changes related to CLOUDSTACK-6160

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18419/#review35272
---


Commit bf77e9d66931468e785ca48222a564abf557fad7 in cloudstack's branch 
refs/heads/marvin from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bf77e9d ]

CLOUDSTACK-6160: Changes to marvin apiclient

Removed apiclient.hypervisor references. More details in the bug
Few other changes pending for this related to VirtualMachine.create
need to be cleaned up


- ASF Subversion and Git Services


On Feb. 24, 2014, 10:53 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18419/
> ---
> 
> (Updated Feb. 24, 2014, 10:53 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-6160
> https://issues.apache.org/jira/browse/CLOUDSTACK-6160
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added few changes for CLOUDSTACK-6160.
> 
> Removed references for apiclient.hypervisor. Few changes pending for 
> VirtualMachine class.
> More information inside the bug.
> 
> 
> Diffs
> -
> 
>   test/integration/component/maint/test_redundant_router.py e282272 
>   test/integration/component/test_accounts.py 45df911 
>   test/integration/component/test_base_image_updation.py 2d6c83b 
>   test/integration/component/test_blocker_bugs.py 1ecbc77 
>   test/integration/component/test_deploy_vm_userdata_reg.py fa0a88c 
>   test/integration/component/test_routers.py 368db60 
>   test/integration/component/test_stopped_vm.py 5f3cea2 
>   test/integration/component/test_templates.py 6babe7e 
>   test/integration/smoke/test_hosts.py 31af7fc 
>   test/integration/smoke/test_routers.py 4432e90 
>   test/integration/smoke/test_ssvm.py d67c55d 
>   tools/marvin/marvin/cloudstackTestClient.py adb7ce3 
>   tools/marvin/marvin/lib/base.py aa23029 
> 
> Diff: https://reviews.apache.org/r/18419/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 18413: Added fix for CLOUDSTACK-6158

[Girish Shilamkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18413/#review35270
---

Ship it!


Ship It!

- Girish Shilamkar


On Feb. 23, 2014, 5:03 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18413/
> ---
> 
> (Updated Feb. 23, 2014, 5:03 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-6158
> https://issues.apache.org/jira/browse/CLOUDSTACK-6158
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added few changes as mentioned under CLOUDSTACK-6158 as below.
>  
> 1. There is no way to delete a data center created earlier. Added a new 
> DeleteDataCenter Interface to delete the earlier created datacenter. If user 
> wants to delete a datacenter created and recreate, deleting has to be manual 
> earlier. With this change, he can delete a data center created earlier. It 
> will be useful at many places for testing to destroy and recreate with new 
> settings etc.
> 
> 2.  when deploy data center runs, it does not adequately verifies whether a 
> given entry is created or not, it just continues. Added checks to see if an 
> entry is not  successful, it reports, dumps to log and exit gracefully.
> 
> 3. DataCenter creation as Transaction : At any given point of time during 
> deploy data center, if an issue happens  half way through, earlier created 
> entries were still available in CS, it wont clean up i.e., data center is 
> half created,  Again, if tried to recreate , the earlier existing entries 
> wont allow to recreate. Now, data center works as transaction, either all 
> entries are created as part of data center or none, added a clean up to 
> delete the half created data center.
> 
> 4. Export the created Data Center so that user can use it to further delete 
> the data center with these exported entries etc.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/cloudstackConnection.py ee1ff00 
>   tools/marvin/marvin/cloudstackTestClient.py adb7ce3 
>   tools/marvin/marvin/deployDataCenter.py bf4b688 
>   tools/marvin/marvin/marvinLog.py 80120c9 
>   tools/marvin/marvin/marvinPlugin.py e6986cc 
> 
> Diff: https://reviews.apache.org/r/18413/diff/
> 
> 
> Testing
> ---
> 
> Tested deleting deploy dc scenarios.
> Tested deploy and clean up if an issue occurs.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

CLOUDSTACK-5663

[Saurav Lahiri]

Hi All,

I started looking at https://issues.apache.org/jira/browse/CLOUDSTACK-5663
If anybody is actively looking into this please let me know else i can
continue with this.



Parth
It looks like it is hitting the code path for non shared networks.You have
mentioned that you are using shared networks.  Can you please provide some
more details as to how did u create the network. Was it via the ui or did u
use API and what were the parameters specified.

While it is true that cidr is not required when creating networks it should
be generated based on the ip params specified. This looks like some thing
went wrong when creating the network.

Thanks
Saurav

P.S: Can somebody please provide privileges so that I can assign tickets to
myself.

[Question][Proposal] Functionality when editing a shared ACL by NetworkId

[Antonio Fornié Casarrubios]

Hi all,

There is this functionality that seems to be wrong and I would like to
double check with you all. Actually this functionality could be considered
very important so I appreciate collaboration.

It's about the functionality for ACLs shared among networks. Let's say you
have a VPC with Networks NW1 and NW2, and you have and ACL (what Cloudstack
calls ACLList) with several rules, and you choose this ACL as the ACL for
both NW1 and NW2. The current functionality is that in general if you
modify the ACL this change will affect NW1 and NW2 of course.

But there is a special case: you could send the parameter networkid. It
makes sense that if you send a createNetowrkACL request to allow additional
traffic and you specifically state NW1, this should not affect NW2.

The proposal then is to change this functionality so that, if and only if
the request specifies a networkid, the command should only affect the
specified network. Which in Java terms will mean that if other networks use
the same ACLList, it will be cloned and then the command will be applied to
the new clone that will be assigned to the given network.

Note that:
* The new clone ACL List is created only if it is actually shared with more
networks, otherwise it doesn't make sense.
* The name for the new ACL List will be the same old name plus a random
suffix.


Any thoughts? Reasons not to go this way?

Thanks and cheers

Antonio
Schuberg Philis - MCE

Re: [Discuss] GRE Tunnel issue on XenServer 6.2

[Murali Reddy]

Problem is just creating network does not create bridge apparently on XenServer 
as the comments on 'enableXenServerNetwork' method indicate. So when 
findOrCreateTunnelNetwork is called to see if the network exists, since network 
object is present across cluster function just returns but bridge is not 
created.

Trick is to create bridge explicitly. Below diff worked for me, but did not 
have time to test it and submit. Will look into it tomorrow.

diff --git 
a/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 
b/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
index cf5c6d6..a935d3f 100644
--- 
a/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
+++ 
b/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
@@ -900,8 +900,16 @@ public abstract class CitrixResourceBase implements 
ServerResource, HypervisorRe
 dom0vif = VIF.create(conn, vifr);
 }
 // At this stage we surely have a VIF
-dom0vif.plug(conn);
-dom0vif.unplug(conn);
+try {
+dom0vif.plug(conn);
+} catch (Exception e) {
+// ignore fake exception
+}
+try {
+dom0vif.unplug(conn);
+} catch (Exception e) {
+// ignore fake exception
+}
 synchronized (_tmpDom0Vif) {
 _tmpDom0Vif.add(dom0vif);
 }
@@ -923,8 +931,8 @@ public abstract class CitrixResourceBase implements 
ServerResource, HypervisorRe
 } else {
 vswitchNw = networks.iterator().next();
 }
-if (!is_xcp())
-enableXenServerNetwork(conn, vswitchNw, "vswitch", 
"vswitch network");
+
+enableXenServerNetwork(conn, vswitchNw, "vswitch", "vswitch 
network");
 _host.vswitchNetwork = vswitchNw;
 }
 return _host.vswitchNetwork;
@@ -963,6 +971,7 @@ public abstract class CitrixResourceBase implements 
ServerResource, HypervisorRe
 s_logger.debug("### Xen Server network for tunnels created:" + 
nwName);
 } else {
 nw = networks.iterator().next();
+enableXenServerNetwork(conn, nw, nwName, "tunnel network for 
account " + key);
 s_logger.debug("Xen Server network for tunnels found:" + 
nwName);
 }
 return nw;

From: Nguyen Anh Tu mailto:t...@apache.org>>
Date: Saturday, 22 February 2014 12:32 AM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Cc: Murali Reddy mailto:murali.re...@citrix.com>>
Subject: [Discuss] GRE Tunnel issue on XenServer 6.2

Hi guys,

Some people (Florin and Benoit) complain about the GRE tunnel issue on 
XenServer 6.2. Actually it has not been fixed completely, although Murali 
submitted a patch to bypass without any exception. Personally I stuck in how 
can we make XenServer 6.2 HOSTs recognize the GRE network created by an another 
HOST in one cluster. I confirm the "enableXenServer" (the tricky) method 
doesn't work in that case.

Anyone can help?

Thanks,

--Tuna

Re: [PROPOSAL] Windowsfication Of ACS

[Abhinandan Prateek]

Anyone, is there an open source windows installer tool ?

-abhi



On 21/02/14 2:30 pm, "Donal Lafferty"  wrote:

>I prefer the focus on support that comes with David's suggestion.
>Targeting the latest stable release for a new platform greatly reduces
>the number of permutations to test.
>
>Pursuing legacy systems limits the flexibility of ACS to evolve.  For
>instance, we'll probably be on Java 7 in the next while, and W2K3 doesn't
>appear on the supported system list (see
>https://www.java.com/en/download/help/sysreq.xml).  Likewise, older
>versions of Internet Explorer can be quite different than what Microsoft
>has recently published.
>
>My guess is that the engineering effort to get ACS working on a legacy
>system makes sense as a consultancy service offered independent to ACS.
>That's the case of OS/2 support ;)
>
>
>DL
>
>
>> -Original Message-
>> From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
>> Sent: 20 February 2014 14:29
>> To: dev@cloudstack.apache.org
>> Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> 
>> I agree totally, my point was that while there is nothing technically
>>stopping
>> us going for w2k3 there is little reason to do so.
>> 
>> 
>> Regards
>> 
>> Alex Hitchins
>> 
>> D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
>> 
>> alex.hitch...@shapeblue.com
>> 
>> -Original Message-
>> From: David Nalley [mailto:da...@gnsa.us]
>> Sent: 20 February 2014 13:24
>> To: dev@cloudstack.apache.org
>> Subject: Re: [PROPOSAL] Windowsfication Of ACS
>> 
>> There's a difference in incidentally working and validated to work on.
>> I'd limit focus to making sure it works on 2k12r2.
>> 
>> --David
>> 
>> On Thu, Feb 20, 2014 at 6:37 AM, Alex Hitchins
>>  wrote:
>> > I can't think of anything that wouldn't be possible on W2k3 - that
>>said It's
>> old and I can't see people having a need for it.
>> >
>> >
>> > Regards
>> >
>> > Alex Hitchins
>> >
>> > D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
>> >
>> > alex.hitch...@shapeblue.com
>> >
>> > -Original Message-
>> > From: Paul Angus [mailto:paul.an...@shapeblue.com]
>> > Sent: 20 February 2014 11:17
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> >
>> > Isn't the hyper-v support dependant on using 2012r2 ?
>> >
>> > So I don't know if I'd bother with going back as far as 2003
>> >
>> > Regards,
>> >
>> > Paul Angus
>> > Cloud Architect
>> > S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
>> > paul.an...@shapeblue.com
>> >
>> > -Original Message-
>> > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
>> > Sent: 20 February 2014 11:13
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> >
>> > AFAIK, it would be windows server 2k3, 2k8 2012, 2012R2.
>> >
>> > Thanks
>> > Rajesh Battala
>> >
>> > -Original Message-
>> > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
>> > Sent: Thursday, February 20, 2014 4:32 PM
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> >
>> > One question I have is, Which version of windows we need to target?
>> >
>> > Thanks & Regards
>> > Damodar/
>> >
>> >
>> > -Original Message-
>> > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
>> > Sent: Thursday, February 20, 2014 2:04 PM
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> >
>> > I have tried to put all together in FS at
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+Win
>> dowsfication as Feedback section and added my comments there.
>> >
>> > Please verify once and let me know if anything is to be added there.
>> >
>> > Thanks & Regards
>> > Damodar/
>> >
>> >
>> > -Original Message-
>> > From: Damoder Reddy [mailto:damoder.re...@citrix.com]
>> > Sent: Thursday, February 20, 2014 12:32 PM
>> > To: dev@cloudstack.apache.org
>> > Subject: RE: [PROPOSAL] Windowsfication Of ACS
>> >
>> > Thank you all for your inputs.
>> >
>> >  I will aggregate all these things into FS  as appendix and will put
>>comments
>> there instead of replying here one by one. Once I am done with update
>>in FS
>> I will notify so that we can verify whether we are covering all or not.
>> >
>> > Thanks & Regards
>> > Damodar/
>> >
>> > -Original Message-
>> > From: abhisek basu [mailto:abhisekb...@msn.com]
>> > Sent: Sunday, February 16, 2014 9:16 AM
>> > To: dev@cloudstack.apache.org
>> > Cc: dev@cloudstack.apache.org
>> > Subject: Re: [PROPOSAL] Windowsfication Of ACS
>> >
>> > Getting a Windows version will expand ACS reach to a large no of
>> > audience and make it more OS independent from its core. As far as the
>> > tools are concern, I am sure it's achievable, we have the most
>> > enthusiastic community contributors behind :)
>> >
>> > Sent from my iPhone
>> >
>> >> On 16 Feb 2014, at 1:08 am, "Alex Hitchins"
>>  wrote:
>> >>
>> >> I would guess that Windows has tools for mana

Re: OVS plugin in CloudStack 4.3.0

[Murali Reddy]

Opened UI bug for 4.3 CLOUDSTACK-6162 if some one can help fixing the UI
part.

On 24/02/14 1:30 AM, "Florin Dumitrascu"
 wrote:

>Hi everyone,
>
>Following Murali's guideline, I was able to use GRE with 4.3 RC (and
>XenServer 6.1)
>There are actually 3 APIs one needs to invoke and I show the example
>below for anyone else who is lost trying to get this working using solely
>the GUI.
>
>I still strongly believe we need to have these APIs supported in the GUI
>for 4.3 release. The API is a powerful tool, but the beginner/average
>user cannot be expected to use it like this.
>I would gladly volunteer for implementing this, but as my CS code
>learning curve is very steep, I am sure there is someone else here who
>can do it ten times faster and in time for 4.3
>
>Would really appreciate your help, and I am sure it would be for the
>benefit of many other CS users.
>
>1. Create OVS connectivity offering
>
>http://192.168.20.112:8080/client/api?command=createNetworkOffering&sessio
>nkey=0YutiBb19VkXgepJYf/wq2Wii4Q=&name=ovs-connectivity-offering&displayTe
>xt=ovs-connectivity-offering&guestIpType=Isolated&lbType=publicLb&servicec
>apabilitylist[0].service=SourceNat&servicecapabilitylist[0].capabilitytype
>=SupportedSourceNatTypes&servicecapabilitylist[0].capabilityvalue=peraccou
>nt&servicecapabilitylist[1].service=lb&servicecapabilitylist[1].capability
>type=SupportedLbIsolation&servicecapabilitylist[1].capabilityvalue=dedicat
>ed&availability=Optional&egresspolicy=ALLOW&state=Creating&status=Creating
>&allocationstate=Creating&supportedServices=Dhcp,Dns,Firewall,Lb,SourceNat
>,StaticNat,PortForwarding,Connectivity&specifyIpRanges=false&specifyVlan=f
>alse&isPersistent=false&conservemode=false&serviceProviderList[0].service=
>Dhcp&serviceProviderList[0].provider=VirtualRouter&serviceProviderList[1].
>service=Dns&serviceProviderList[1].provider=VirtualRouter&serviceProviderL
>ist[2].service=Firewall&serviceProviderList[2].provider=VirtualRouter&serv
>iceProviderList[3].service=Lb&serviceProviderList[3].provider=VirtualRoute
>r&serviceProviderList[4].service=SourceNat&serviceProviderList[4].provider
>=VirtualRouter&serviceProviderList[5].service=StaticNat&serviceProviderLis
>t[5].provider=VirtualRouter&serviceProviderList[6].service=PortForwarding&
>serviceProviderList[6].provider=VirtualRouter&serviceProviderList[7].servi
>ce=Connectivity&serviceProviderList[7].provider=Ovs&egressdefaultpolicy=tr
>ue&traffictype=GUEST
>
>2. Get the OVS provider id
>
>http://192.168.20.112:8080/client/api?command=listNetworkServiceProviders&;
>sessionkey=Ztlr1jtjM8RlnpeBzHujm4Zh/DI=&name=Ovs
>
>3. Enable OVS provider
>
>http://192.168.20.112:8080/client/api?command=updateNetworkServiceProvider
>&sessionkey=CUBGAK4lfGgJIlQhuCfr3ZNlUbs=&id=b209154a-73bf-44d6-b2cf-41358a
>79cbf4&state=Enabled
>
>Thanks and kind regards,
>Florin
>
>
>-Original Message-
>From: Florin Dumitrascu [mailto:florin.dumitra...@intunenetworks.com]
>Sent: Friday, February 21, 2014 10:00 AM
>To: dev@cloudstack.apache.org
>Subject: RE: OVS plugin in CloudStack 4.3.0
>
>Hi Murali,
>
>Thanks for clarifying this.
>However, I would not consider bug CLOUDSTACK-5967 fixed until UI support
>is restored for this basic functionality.
>It is a hack. We cannot expect an end user to go into that level of
>detail. Will look at how much effort is involved to add UI support.
>From a personal point of view, this is a -1 for this release.
>
>Regards,
>Florin
>
>
>
>-Original Message-
>From: Murali Reddy [mailto:murali.re...@citrix.com]
>Sent: Thursday, February 20, 2014 5:48 PM
>To: dev@cloudstack.apache.org
>Subject: Re: OVS plugin in CloudStack 4.3.0
>
>On 20/02/14 8:40 PM, "Florin Dumitrascu"
> wrote:
>
>>Yes,
>>
>>sdn.ovs.controller = true
>>sdn.ovs.controller.default.label = GUEST  // label used on XenServer
>>guest network
>>
>>Without the OVS controller switched on, I think one will not see the
>>OVS bridge created.
>>The first part of the setup works, allocating a GRE key from the VLAN
>>range, setting up the OVS bridge.
>>The second part involving configuring the OVS bridge and creating the
>>tunnel interface doesn't take place.
>
>This issue was discussed in [1], and is fixed as part of the bug
>CLOUDSTACK-5967. So 'Ovs' is added as provider of 'Connectivity' service
>as part of the fix. You need to create a network offering with 'Ovs'
>selected as 'Connectivity' service provider. When you create network with
>such network offering you should see tunnels established as well. There
>no ui support unfortunaley , so you need to use api. Please see [2] for
>sample api call to create network offering with 'Ovs' as 'Connectivity'
>service provider
>
>[1] http://markmail.org/message/h5pcpeeuo5zp42t6
>[2] http://pastebin.com/n3fbdjAP
>
>
>>
>>I double checked to see that I am doing exactly the same steps as in
>>4.1.1.
>>
>>Regards,
>>Florin
>>
>>-Original Message-
>>From: Paul Angus [mailto:paul.an...@shapeblue.com]
>>Sent: Thursday, February 20, 2014 

[PROPOSAL] distributed routing and network ACL with OVS plug-in

[Murali Reddy]

I would like to propose an enhancement to OVS plug-in to support
distributed routing and network ACL's for 4.4. Tracking bug is [1] and
functional specification is available at [2]. This proposal is
complementary to proposed reason level VPC feature [3][4] to avoid traffic
trombone [5] problem.

Please share your feedback.

[1] https://issues.apache.org/jira/browse/CLOUDSTACK-6161
[2] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/OVS+distributed+rout
ing+and+network+ACL
[3] http://markmail.org/message/mzefophgoth5hr53
[4]cwiki.apache.org/confluence/display/CLOUDSTACK/Region+level+VPC+and+gues
t+network+spanning+multiple+zones
[5]http://blog.ipspace.net/2011/02/traffic-trombone-what-it-is-and-how-you.
html

RE: [PROPOSAL] Change systemvm template URL in master to s3 bucket

[Rajesh Battala]

Awesome  +1
This is very nice

Any plans to update  urls in DB also?

Thanks
Rajesh Battala

-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Monday, February 24, 2014 3:21 PM
To: 
Subject: [PROPOSAL] Change systemvm template URL in master to s3 bucket

Hey all,

I've finally fixed the configuration to automagically upload the systemvm 
templates to an s3 bucket. The jobs build-systemvm-master and 
build-systemvm64-master will rebuild the systemvm template on a daily basis and 
send the resulting files to that S3 bucket.

I would like to update the URLs in the docs and in the database to make master 
point to these new locations. The locations will look like : 
https://s3.amazonaws.com/systemvm-templates.cloudstack.org/master/64/systemvm64template-master-hyperv.vhd

Why? 
  Anyone using master will automagically use the latest and greatest images.
  Transparent process from build script to distribution.
  Accessible logging for folks willing to track number of downloads etc.


Any thoughts?

Cheers,

Hugo

Re: [PROPOSAL] Change systemvm template URL in master to s3 bucket

[Prasanna Santhanam]

On Mon, Feb 24, 2014 at 10:51:05AM +0100, Hugo Trippaers wrote:
> Hey all,
> 
> I?ve finally fixed the configuration to automagically upload the systemvm 
> templates to an s3 bucket. The jobs build-systemvm-master and 
> build-systemvm64-master will rebuild the systemvm template on a daily basis 
> and send the resulting files to that S3 bucket.
> 
> I would like to update the URLs in the docs and in the database to make 
> master point to these new locations. The locations will look like : 
> https://s3.amazonaws.com/systemvm-templates.cloudstack.org/master/64/systemvm64template-master-hyperv.vhd
> 
> Why? 
>   Anyone using master will automagically use the latest and greatest images.
>   Transparent process from build script to distribution.
>   Accessible logging for folks willing to track number of downloads etc.
> 
> 
> Any thoughts?
+1 - long overdue. good job.

> 
> Cheers,
> 
> Hugo
> 

-- 
Prasanna.,


Powered by BigRock.com

Review Request 18419: Added changes related to CLOUDSTACK-6160

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18419/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-6160
https://issues.apache.org/jira/browse/CLOUDSTACK-6160


Repository: cloudstack-git


Description
---

Added few changes for CLOUDSTACK-6160.

Removed references for apiclient.hypervisor. Few changes pending for 
VirtualMachine class.
More information inside the bug.


Diffs
-

  test/integration/component/maint/test_redundant_router.py e282272 
  test/integration/component/test_accounts.py 45df911 
  test/integration/component/test_base_image_updation.py 2d6c83b 
  test/integration/component/test_blocker_bugs.py 1ecbc77 
  test/integration/component/test_deploy_vm_userdata_reg.py fa0a88c 
  test/integration/component/test_routers.py 368db60 
  test/integration/component/test_stopped_vm.py 5f3cea2 
  test/integration/component/test_templates.py 6babe7e 
  test/integration/smoke/test_hosts.py 31af7fc 
  test/integration/smoke/test_routers.py 4432e90 
  test/integration/smoke/test_ssvm.py d67c55d 
  tools/marvin/marvin/cloudstackTestClient.py adb7ce3 
  tools/marvin/marvin/lib/base.py aa23029 

Diff: https://reviews.apache.org/r/18419/diff/


Testing
---


Thanks,

Santhosh Edukulla

ACS + KVM + GRE + Infiniband

[Andrei Mikhailovsky]

Hello guys, 


I was wondering if anyone could give me some tips on how to setup an infinband 
network for the guests using KVM hypervisor. In particular,, I am looking at 
providing guest vms with the IPoIB interface which is available on the KVM 
hypervisor hosts. The current implementation of IPoIB support in Linux does not 
allow for bridging over the infiniband interface, so you can't really create a 
bridge interface, feed it to ACS and let vm guests use the high speed network. 
If I understand correctly, there should be a way to use network segmentation 
with GRE tunnelling, which should not need the creation of bridge interfaces. 
If this is so, I should be able to utilise IPoIB network interface with GRE 
separation as the guest network. 


Has anyone attempted to do something similar? 


Another question, does ACS advanced networking support the functionality of 
having two or more different network types within one zone/pod/cluster? For 
instance, could I have two guest network offerings, one with vlan separation 
over ethernet and another with GRE separation over IPoIB interface? 


Cheers 


Andrei 

Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

[Hugo Trippaers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review35264
---


Before we commit this, can you have a look at these two remarks?


deps/XenServerJava/src/Makefile


can you remove the Makefile? We would using maven and we should try not to 
confuse our developers with other make methods.



deps/XenServerJava/src/README.txt


I've we want to include this README, we should be a note in it that this is 
a modified version.


- Hugo Trippaers


On Feb. 19, 2014, 7:31 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> ---
> 
> (Updated Feb. 19, 2014, 7:31 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
> https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Update the java bindings that are used in cloudstack with the latest one. 
> There are two parts for this change, 1st one is to replace the java bindings; 
> and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for 
> CloudStack.
> 
> 
> Diffs
> -
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/Makefile PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/xenapi/SM.java 0ec3626 
>   deps/XenServerJava/src/com/xensource/xenapi/SR.java db6770f 
>   deps/XenServerJava/src/com/xensource/xenapi/Secret.java 870725f 
>   deps/XenServerJava/src/com/xensource/xenapi/Session.java bdf3b4c 
>   deps/XenServerJava/src/com/xensource/xenapi/Subject.java a599f237 
>   deps/XenServerJava/src/com/xensource/xenapi/Task.java 59d59f6 
>   deps/XenServerJava/src/com/xensource/xenapi/Tunnel.java 44b236d 
>   deps/XenServerJava/src/com/xensource/xenapi/Types.java 777d580 
>   deps/XenServerJava/src/com/xensource/xenapi/User.java dff27f5 
>   deps/XenServerJava/src/com/xensource/xenapi/VBD.java 56e6f4b 
>   deps/XenServerJava/src/com/xensource/xenapi/VBDMetrics.java 1f678fa 
>   deps/XenServerJava/src/com/xensource/xenapi/VDI.java 992a6a6 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPU.java 19c88fd 
>   deps/XenServerJava/src/com/xensource/xenapi/VGPUType.java PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/VIF.java 8302800 
>   deps/XenServerJava/src/com/xensource/xenapi/VIFMetrics.java 0c17217 
>   deps/XenServerJava/src/com/xensource/xenapi/VLAN.java 9bea039 
>   deps/XenServerJava/s

Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

[Hugo Trippaers]

> On Feb. 19, 2014, 9:27 p.m., Hugo Trippaers wrote:
> > It looks like a lot of the license headers are wrong in this file. Please 
> > make sure they are complying to the license headers as they should be for 
> > CloudStack code. See the LICENSE.header file for examples, especially the 
> > copyright notice should not be there.
> > 
> > Also isn't this a good time to feed the changes we need in the java 
> > bindings back to the xen-api-sdk project on github 
> > (https://github.com/xapi-project/xen-api-sdk)? It would be nice if we could 
> > just depend on that project instead of having to include a copy in our own 
> > source tree.
> 
> David Nalley wrote:
> This is not CloudStack code. This is a dependency that we've effectively 
> forked. We have no standing to change the license headers; it's not ours. 
> 
> Wholeheartedly agree - I'd far prefer we upstream our changes and stop 
> bundling this dependency. 
> 
> --David
> 
> Sanjay Tripathi wrote:
> That's right, we cannot change the Licence headers.
> 
> As of now, with the released java bindings, there is some customization 
> required to make it work with CloudStack (see the patch 
> https://reviews.apache.org/r/17844/).
> 
> If i am right, in the upcoming XenServer hotfix release, all the 
> customization related to CloudStack code has been taken care of. So, in 
> future, with that release, we can directly use the build instead of building 
> it of our own.
> 
> Please share your thoughts on this.
> 
> Also, this patch has the support of vGPU functionality in XenServer which 
> is a dependency for upcoming feature "GPU and vGPU support for CloudStack 
> guestVms".
> 
> --Sanjay

Sanjay,

I double checked the license headers. This is a BSD two clause license, so 
perfectly OK to include in our sourcecode. Consider my worries resolved :-)


- Hugo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review34930
---


On Feb. 19, 2014, 7:31 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> ---
> 
> (Updated Feb. 19, 2014, 7:31 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
> https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Update the java bindings that are used in cloudstack with the latest one. 
> There are two parts for this change, 1st one is to replace the java bindings; 
> and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for 
> CloudStack.
> 
> 
> Diffs
> -
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/Makefile PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFM

Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

[Sanjay Tripathi]

> On Feb. 19, 2014, 9:27 p.m., Hugo Trippaers wrote:
> > It looks like a lot of the license headers are wrong in this file. Please 
> > make sure they are complying to the license headers as they should be for 
> > CloudStack code. See the LICENSE.header file for examples, especially the 
> > copyright notice should not be there.
> > 
> > Also isn't this a good time to feed the changes we need in the java 
> > bindings back to the xen-api-sdk project on github 
> > (https://github.com/xapi-project/xen-api-sdk)? It would be nice if we could 
> > just depend on that project instead of having to include a copy in our own 
> > source tree.
> 
> David Nalley wrote:
> This is not CloudStack code. This is a dependency that we've effectively 
> forked. We have no standing to change the license headers; it's not ours. 
> 
> Wholeheartedly agree - I'd far prefer we upstream our changes and stop 
> bundling this dependency. 
> 
> --David

That's right, we cannot change the Licence headers.

As of now, with the released java bindings, there is some customization 
required to make it work with CloudStack (see the patch 
https://reviews.apache.org/r/17844/).

If i am right, in the upcoming XenServer hotfix release, all the customization 
related to CloudStack code has been taken care of. So, in future, with that 
release, we can directly use the build instead of building it of our own.

Please share your thoughts on this.

Also, this patch has the support of vGPU functionality in XenServer which is a 
dependency for upcoming feature "GPU and vGPU support for CloudStack guestVms".

--Sanjay


- Sanjay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17843/#review34930
---


On Feb. 19, 2014, 7:31 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17843/
> ---
> 
> (Updated Feb. 19, 2014, 7:31 p.m.)
> 
> 
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6058
> https://issues.apache.org/jira/browse/CLOUDSTACK-6058
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Update the java bindings that are used in cloudstack with the latest one. 
> There are two parts for this change, 1st one is to replace the java bindings; 
> and second part is to add the customization's made in xenapi for Cloudstack.
> 
> 1. https://reviews.apache.org/r/17843/ - Replaces the java bindings.
> 2. https://reviews.apache.org/r/17844/ - Customizations in xenapi for 
> CloudStack.
> 
> 
> Diffs
> -
> 
>   deps/XenServerJava/src/LICENSE.Apache-2.0.txt PRE-CREATION 
>   deps/XenServerJava/src/LICENSE.txt PRE-CREATION 
>   deps/XenServerJava/src/Makefile PRE-CREATION 
>   deps/XenServerJava/src/README.txt PRE-CREATION 
>   deps/XenServerJava/src/com/xensource/xenapi/APIVersion.java 8d7247d 
>   deps/XenServerJava/src/com/xensource/xenapi/Auth.java cffaaac 
>   deps/XenServerJava/src/com/xensource/xenapi/Blob.java 494b928 
>   deps/XenServerJava/src/com/xensource/xenapi/Bond.java 935fd98 
>   deps/XenServerJava/src/com/xensource/xenapi/Connection.java a652450 
>   deps/XenServerJava/src/com/xensource/xenapi/Console.java ac2c9a7 
>   deps/XenServerJava/src/com/xensource/xenapi/Crashdump.java be11588 
>   deps/XenServerJava/src/com/xensource/xenapi/DRTask.java 14a5e40 
>   deps/XenServerJava/src/com/xensource/xenapi/DataSource.java 5f777a3 
>   deps/XenServerJava/src/com/xensource/xenapi/Event.java ec43814 
>   deps/XenServerJava/src/com/xensource/xenapi/GPUGroup.java 9070446 
>   deps/XenServerJava/src/com/xensource/xenapi/Host.java 2195048 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCpu.java 15fcfa7 
>   deps/XenServerJava/src/com/xensource/xenapi/HostCrashdump.java 02c3bd9 
>   deps/XenServerJava/src/com/xensource/xenapi/HostMetrics.java b41277a 
>   deps/XenServerJava/src/com/xensource/xenapi/HostPatch.java fa77588 
>   deps/XenServerJava/src/com/xensource/xenapi/Marshalling.java 865bc16 
>   deps/XenServerJava/src/com/xensource/xenapi/Message.java a3658e3 
>   deps/XenServerJava/src/com/xensource/xenapi/Network.java e9194ef 
>   deps/XenServerJava/src/com/xensource/xenapi/PBD.java d289824 
>   deps/XenServerJava/src/com/xensource/xenapi/PCI.java e11230a 
>   deps/XenServerJava/src/com/xensource/xenapi/PGPU.java 0f5ddb4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIF.java 27618b4 
>   deps/XenServerJava/src/com/xensource/xenapi/PIFMetrics.java ab6268e 
>   deps/XenServerJava/src/com/xensource/xenapi/Pool.java 7ceebb0 
>   deps/XenServerJava/src/com/xensource/xenapi/PoolPatch.java 7361bc7 
>   deps/XenServerJava/src/com/xensource/xenapi/Role.java 5808b13 
>   deps/XenServerJava/src/com/xensource/x

Re: [PROPOSAL] Change systemvm template URL in master to s3 bucket

[Sebastien Goasguen]

On Feb 24, 2014, at 4:51 AM, Hugo Trippaers  wrote:

> Hey all,
> 
> I’ve finally fixed the configuration to automagically upload the systemvm 
> templates to an s3 bucket. The jobs build-systemvm-master and 
> build-systemvm64-master will rebuild the systemvm template on a daily basis 
> and send the resulting files to that S3 bucket.
> 
> I would like to update the URLs in the docs and in the database to make 
> master point to these new locations. The locations will look like : 
> https://s3.amazonaws.com/systemvm-templates.cloudstack.org/master/64/systemvm64template-master-hyperv.vhd
> 
> Why? 
>  Anyone using master will automagically use the latest and greatest images.
>  Transparent process from build script to distribution.
>  Accessible logging for folks willing to track number of downloads etc.
> 
> 
> Any thoughts?
> 

+1 , I can fix the docs.

> Cheers,
> 
> Hugo
> 
> 

[PROPOSAL] Change systemvm template URL in master to s3 bucket

[Hugo Trippaers]

Hey all,

I’ve finally fixed the configuration to automagically upload the systemvm 
templates to an s3 bucket. The jobs build-systemvm-master and 
build-systemvm64-master will rebuild the systemvm template on a daily basis and 
send the resulting files to that S3 bucket.

I would like to update the URLs in the docs and in the database to make master 
point to these new locations. The locations will look like : 
https://s3.amazonaws.com/systemvm-templates.cloudstack.org/master/64/systemvm64template-master-hyperv.vhd

Why? 
  Anyone using master will automagically use the latest and greatest images.
  Transparent process from build script to distribution.
  Accessible logging for folks willing to track number of downloads etc.


Any thoughts?

Cheers,

Hugo

Re: Review Request 16867: Test Suite for Testing Remote Access VPN on VPC

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16867/#review35259
---

Ship it!


Ship It!

- Santhosh Edukulla


On Feb. 21, 2014, 11:52 p.m., Chandan Purushothama wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16867/
> ---
> 
> (Updated Feb. 21, 2014, 11:52 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, sanjeev n, Santhosh 
> Edukulla, SrikanteswaraRao Talluri, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Test Suite for Testing Remote Access VPN on VPC. 
> 
> I successfully automated the following components:
> 
> 1.VPN Client Installation on Linux
> 2.Component that efficiently verifies Remote VPN Access between client and 
> the Server.
> 3.Developed a component that automates VPN Client Configuration and services.
> 4.Test Cases of the Feature
> 5.Tested the Code multiple times on XenServer and fixed the bugs.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_remotevpn_vpc.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16867/diff/
> 
> 
> Testing
> ---
> 
> Test case no : Enable VPN for Public IP Address on the VPC ... ok
> Test case no : Remote a VPN User ... ok
> Test case no : Add a Different VPN User and Test Access with already existing 
> VPN User ... ok
> Test case no : Add a Previously Removed VPN User from the VPC and Test the 
> VPN Connectivity ... ok
> Test case no : Disable the VPN Service on the VPC ... ok
> Test case no : Enabled Previously Dsiabled VPN Access to VPC. ... ok
> Test case no : Create Nine VPN Users to test the remote.vpn.user.limit=8 
> Configuration parameter ... ok
> 
> --
> Ran 7 tests in 817.606s
> 
> OK
> 
> 
> File Attachments
> 
> 
> 0001-Test-Suite-for-Remote-Access-VPN-on-VPC.patch
>   
> https://reviews.apache.org/media/uploaded/files/2014/01/14/c6d3f593-d0eb-407c-aad2-574ebf9ca0f8__0001-Test-Suite-for-Remote-Access-VPN-on-VPC.patch
> Test Suite for review
>   
> https://reviews.apache.org/media/uploaded/files/2014/02/21/52861fbf-ca90-4f57-96b0-85a67262811f__0001-Test-Suite-for-Remote-Access-VPN-on-VPC.patch
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>

[JENKINS] Upgraded Jenkins to 1.551

[Hugo Trippaers]

This release fixes several critical security vulnerabilities.


Cheers,

Hugo

devcloud - can't mount 192.168.56.10:/opt/storage/secondary/template/tmpl/1/1

[chris snow]

I've fixed one issue with the new devcloud environment that I'm
working on, but I'm now running into another issue when running python
../marvin/marvin/deployDataCenter.py -i devcloud.cfg

WARN  [c.c.h.x.r.XenServerStorageProcessor]
(DirectAgent-5:ctx-c5ad1fa5) can't mount
192.168.56.10:/opt/storage/secondary/template/tmpl/1/1 to
/var/run/cloud_mount/ad3779f0-a29d-42c0-a894-9f5198e46022
WARN  [c.c.h.x.r.XenServerStorageProcessor]
(DirectAgent-5:ctx-c5ad1fa5) Catch Exception
com.cloud.utils.exception.CloudRuntimeException for template +  due to
com.cloud.utils.exception.CloudRuntimeException: can't mount
192.168.56.10:/opt/storage/secondary/template/tmpl/1/1 to
/var/run/cloud_mount/ad3779f0-a29d-42c0-a894-9f5198e46022
com.cloud.utils.exception.CloudRuntimeException: can't mount
192.168.56.10:/opt/storage/secondary/

See here for more information: https://github.com/snowch/devcloud/issues/15

The only nfs setup that I'm doing is here:
https://github.com/snowch/devcloud/blob/master/packer/scripts/postinstall_nfs.sh

Any pointers to help me resolve this will be gratefully received!

Many thanks.

Chris