[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150770063 Thanks for your feedback guys, I've opened a new PR #174. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9685 Enhanced the fix for the iOS9 lo...
GitHub user EddyVerbruggen opened a pull request: https://github.com/apache/cordova-ios/pull/174 CB-9685 Enhanced the fix for the iOS9 longpress magnifying glass issue This feature is now disabled by default and can be enabled for longpress in `config.xml`: `` When 3D Touching the webview (apply pressure during your touch) the magnification glass will also pop up. It won't even wait for a longpress in this case. To disable this issue as well, add this to `config.xml`: `` Note that if the former is true, the latter is ignored since they essentially use the same gesture `UILongPressGestureRecognizer` (which is a shame but that's how Apple implemented it). The other way around works fine, so to have the behavior of the previous version of this plugin, you'd do: ```xml ``` Omitting the properties is the same as setting both to`false`. The reason for having the developer explictly enabling these features is that disabling longpress may break text selection (most relevantly in input fields). The reason there's a sep property for 3D Touch is it will break onclick handlers, but ontouchend works just fine, so it really depends on your app/framework if it's a workable fix. Please merge this so I can sleep better at night. You can merge this pull request into a Git repository by running: $ git pull https://github.com/EddyVerbruggen/cordova-ios master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/174.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #174 commit b6348f7a0cb55ca3972334cb40ad310823792fa9 Author: EddyVerbruggen Date: 2015-09-22T10:02:36Z CB-9685 A fix for the magnifying glass popping up on iOS9 when longpressing the webview commit 842997cba173ca90bd5e4f1943653533be69942b Author: EddyVerbruggen Date: 2015-10-24T05:58:58Z Merge remote-tracking branch 'upstream/master' commit 371c136315b0c4f481ee479242dd769c4280b932 Author: EddyVerbruggen Date: 2015-10-24T06:41:07Z CB-9685 A fix for the magnifying glass popping up on iOS9 when longpressing the webview. This is now disabled by default and can be enabled for longpress in config.xml: and also for 3D Touch: note that if the former is true, the latter is ignored --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface
it is!
My team is hiring!
@purplecabbage
risingj.com
On Fri, Oct 23, 2015 at 7:15 PM, Carlos Santana
wrote:
> +1 if what Simon and Jesse are saying is the same thing :-)
>
>
> On Fri, Oct 23, 2015 at 7:42 PM Jesse wrote:
>
> > Let's go ahead with renaming CordovaWebView => CordovaWebInterface, and
> > keeping around a CordovaWebView object so that nothing breaks.
> >
> > We should also deprecate CordovaWebView, and document the change so that
> > people who are using it have some notice, and people who are new know
> what
> > NOT to use.
> >
> > We don't have to remove it immediately, or even on our next major bump,
> > just sometime down the road.
> > If we don't move forward we will just be stuck with it forever ...
> >
> >
> >
> >
> > My team is hiring!
> > @purplecabbage
> > risingj.com
> >
> > On Fri, Oct 23, 2015 at 1:19 PM, Nikhil Khandelwal <
> nikhi...@microsoft.com
> > >
> > wrote:
> >
> > > I understand that it won't break currently and it will break on the
> next
> > > major version bump. IMHO it's just not worth it for this name change.
> > >
> > > Historically, we've had challenges with giving sufficient notice from
> > > breaking changes. I would avoid them unless absolutely needed.
> > >
> > > -Nikhil
> > >
> > > -Original Message-
> > > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> > > Sent: Thursday, October 22, 2015 12:14 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [Android][Discuss] Change name of CordovaWebView to
> > > CordovaWebInterface
> > >
> > > Let's just be clear that in Cordova Android 5.0 nothing will break.
> > > The interface CordovaWebView has been renamed to CordovaWebInterface
> but
> > > that won't break anything as we introduce a new class called, wait for
> > it,
> > > CordovaWebView that extends the new CordovaWebInterface. This way all
> > > current code that uses CordovaWebView will continue to work without
> > > modification.
> > >
> > > If we start updating our documentation, i.e. how to write a
> CordovaPlugin
> > > for Android, and give people plenty of notice that this is going to
> > happen
> > > then I don't see why we wouldn't want to move forward.
> > >
> > > That's just my 2 cents.
> > >
> > > Simon Mac Donald
> > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald&data=01%7c01%7cnikhilkh%40microsoft.com%7caf6077fb55224d7b1d2c08d2db1508fe%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=50aLt1e0sp9z4TrrSBiMnAaBdSj1RrUuIEcnPaHGD1U%3d
> > >
> > >
> > > On Wed, Oct 21, 2015 at 6:13 PM, Nikhil Khandelwal <
> > nikhi...@microsoft.com>
> > > wrote:
> > > > Thanks, Joe for the summary of the impact later.
> > > >
> > > > -1. IMO - a naming change is no worth the effort and future breakage.
> > > >
> > > > -Nikhil
> > > >
> > > > -Original Message-
> > > > From: Joe Bowser [mailto:bows...@gmail.com]
> > > > Sent: Wednesday, October 21, 2015 11:06 AM
> > > > To: dev
> > > > Subject: Re: [Android][Discuss] Change name of CordovaWebView to
> > > > CordovaWebInterface
> > > >
> > > > Yes, I do. I had to search through mobilespec, but here it is:
> > > >
> > > > private static final boolean HAS_BUILT_IN_SPLASH_SCREEN =
> > > > Integer.valueOf(CordovaWebView.CORDOVA_VERSION.split("\\.")[0]) < 4;
> > > >
> > > > Also, every plugin that calls initialize requires a CordovaWebView
> > > passed into it. That's a pretty big change. I also haven't touched on
> > > Third Party WebViews like Crosswalk, which would have to do the change.
> > > >
> > > >
> > > > On Tue, Oct 20, 2015 at 1:59 PM, Steven Gill >
> > > wrote:
> > > >
> > > >> Joe, do you have a small example of what could break with this
> change.
> > > >> What is a usecase for someone to reference CordovaWebView
> > > >>
> > > >> On Tue, Oct 20, 2015 at 1:38 PM, Joe Bowser
> > wrote:
> > > >>
> > > >> > I'll pull this in at the end of the day. This small change may
> > > >> > break
> > > >> stuff
> > > >> > further down the road, so people should comment on it now.
> > > >> >
> > > >> > On Tue, Oct 20, 2015 at 1:37 PM, Joe Bowser
> > > wrote:
> > > >> >
> > > >> > > OK, Going to pull this in.
> > > >> > >
> > > >> > > On Tue, Oct 20, 2015 at 10:02 AM, Simon MacDonald <
> > > >> > > simon.macdon...@gmail.com> wrote:
> > > >> > >
> > > >> > >> +1 from me as I'm the one that initiated the PR.
> > > >> > >>
> > > >> > >> Simon Mac Donald
> > > >> > >>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2f
> > > >> > >> h
> > > >> > >> i.im%2fsimonmacdonald&data=01%7c01%7cnikhilkh%40microsoft.com
> %7c
> > > >> > >> 8
> > > >> > >>
> 619031b1eef484bd48508d2da425e41%7c72f988bf86f141af91ab2d7cd011db
> > > >> > >> 4
> 7%7c1&sdata=IXoWw2z2L7EhCorf4kK4EJ7Ux89hdUjmP%2bKsF%2bJdwf0%3d
> > > >> > >>
> > > >> > >> On Tue, Oct 20, 2015 at 12:23 PM, Darryl Pogue
> > > >> > >>
> > > >> > wrote:
> > > >> > >>
> > > >> > >> > +1 for doing this with the major version bump
> > > >> > >> >
> > > >> > >> > On 20 October 2015 at 09
[GitHub] cordova-plugin-camera pull request: CB-9490 Fixed cleanup function
Github user cojomojo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-150748364 @infil00p Yes, it would still have the problem. I submitted this fix still because it is trivial (this PR won't change how the plugin is used at all, and only changes 2 lines, outside of the function itself), while the fix for 9506 will be non-trivial. Therefore, I think that unless 9506 is going to be fixed soon we should still patch 9490 with this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Introduction
Welcome Ryan, feel free to use the dev mailing list and Slack for any questions On Mon, Oct 19, 2015 at 6:39 PM Tommy Williams wrote: > Welcome, indeed. > > > On 20 October 2015 at 04:08:16, Ryan J. Salva (rsa...@microsoft.com) > wrote: > > Welcome, Ryan! > > > rjs > > Ryan J. Salva | Principal Program Manager Lead > Visual Studio Tools for Apache Cordova > rsa...@microsoft.com > 206 612 5079 mobile > > > > -Original Message- > From: Jesse [mailto:purplecabb...@gmail.com] > Sent: Monday, October 19, 2015 9:57 AM > To: dev@cordova.apache.org > Subject: Re: Introduction > > Welcome, happy to have more hands. > > > > On Oct 19, 2015, at 7:28 AM, Steven Gill wrote: > > > > Welcome! > >> On Oct 19, 2015 6:50 AM, "Fiorini, Ryan" > wrote: > >> > >> Hi Everyone, > >> > >> My name is Ryan Fiorini and I am a software engineer for Intel on > >> the Intel XDK project. My primary duties are on the Windows platform > >> test application (Intel AppPreview) including Windows Phone and have > >> been using apache cordova for quite a while now. I plan on > >> contributing towards the Windows platform. > >> > >> > >> Thank you, > >> Ryan > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >> For additional commands, e-mail: dev-h...@cordova.apache.org > >> > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: npm install on cordova platform/plugin add
It's still a requirement, I didn't say I was going to skip it :-) maybe we print a warning that requirement is not met, or something like that On Fri, Oct 23, 2015 at 10:19 PM Steven Gill wrote: > I agree that we should use exact versions for dependencies of Cordova > Platforms and Plugins and still bundle dependencies. > > I don't think we should enforce that requirement on plugin authors. We can > have our plugin docs suggest that they use exact versions but I don't think > we should skip npm install it if they don't. > > On Fri, Oct 23, 2015 at 7:13 PM, Carlos Santana > wrote: > > > The requirement will be that 3rd party plugins put exact versions of > > dependencies, not assuming that user will need to run npm install or npm > > update after adding the plugin to refresh the npm dependencies > > > > Apache Foundation Cordova Platforms and Plugins should ship with it's > > dependencies bundled, or use exact versions for dependencies. > > This way all users get the same software at the time of adding a platform > > or plugin. If not it becomes a big mess of having a certain version of > the > > platform or plugin if not guarantee to have the same software as everyone > > else (not reproducible, not consistent) > > > > > > > > On Fri, Oct 23, 2015 at 7:39 PM Steven Gill > > wrote: > > > > > Issue: https://issues.apache.org/jira/browse/CB-9858 > > > > > > > > > On Fri, Oct 23, 2015 at 1:05 PM, Mefire O. > > wrote: > > > > > > > Ah, it makes sense in both platforms and plugins. > > > > > > > > Thanks, > > > > > > > > -Original Message- > > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > > Sent: Thursday, October 22, 2015 4:46 PM > > > > To: dev@cordova.apache.org > > > > Subject: Re: npm install on cordova platform/plugin add > > > > > > > > Yeah. Cordova-common is the main reason for platforms. IMO It doesn't > > > make > > > > sense to check it into platforms. It makes sense to have it as a > > > > bundleDependency but if you cordova platform add it via git url, the > > > > dependency won't be around. Hence the npm install On Oct 22, 2015 > 4:24 > > > PM, > > > > "Darryl Pogue" wrote: > > > > > > > > > One example would be the ios-sim and ios-deploy node modules that > the > > > > > iOS platform needs for launching the simulator and deploying to a > > > device. > > > > > Currently these are bundled dependencies and checked in to git. > > > > > > > > > > Another example is the Platform API that's been added to > > > > > cordova-android, which depends on cordova-common. > > > > > > > > > > On 22 October 2015 at 16:17, Mefire O. > > wrote: > > > > > > > > > > > I can definitely see the case for adding deps specified in > plugins' > > > > > > package.json, which is to make 'tools plugins' development > easier. > > > > > > > > > > > > But I don't understand the use case for platforms. What scenario > > are > > > > > > we trying to fulfill there ? > > > > > > > > > > > > Thanks, > > > > > > Omar Mefire > > > > > > > > > > > > -Original Message- > > > > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > > > > Sent: Thursday, October 22, 2015 2:54 PM > > > > > > To: dev@cordova.apache.org > > > > > > Subject: npm install on cordova platform/plugin add > > > > > > > > > > > > We discussed running `npm install` on `cordova plugin add` at the > > > > > > Cordova F2F. > > > > > > > > > > > > I want to see how people feel about this. > > > > > > > > > > > > For installing a platform via git url, the dependency won't exist > > > > > > unless we check it in to the repo. This can cause problems. > > > > > > bundleDependencies > > > > > are > > > > > > only useful for installing via npm > > > > > > > > > > > > For platforms: > > > > > > > > > > > > i believe this is how it would work: > > > > > > > > > > > > Adding via `npm` > > > > > > > > > > > > 1) `cordova platform add ios` > > > > > > > > > > > > 2) cordova fetches `cordova-ios` from npm, adds it to global > > cordova > > > > > > directory > > > > > > > > > > > > 3) I'd like tools to run `npm install` , but these deps are most > > > > > > likely already included in fetched version due to > > > > > > `bundleDependecies`. So it wouldn't do anything > > > > > > > > > > > > Adding locally > > > > > > > > > > > > 1) `cordova platform add /YourLocalCordovaIOS` > > > > > > > > > > > > 2) cordova uses your `cordova-ios` > > > > > > > > > > > > 3) tools to run `npm install` which should have no impact > (Assuming > > > > > you've > > > > > > done it manually) > > > > > > > > > > > > Adding via Git url > > > > > > > > > > > > 1) `cordova platform add > > > > > > > > > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu > > > > > b.com%2fapache%2fcordova-ios%60&data=01%7c01%7commenjik% > > 40microsoft.co > > > > > > > m%7c8b52f2866d674b08c10b08d2db2b5347%7c72f988bf86f141af91ab2d7cd011db4 > > > > > 7%7c1&sdata=zdpqgA08JQxJ4h5DpWCpBiggl1RTZu%2fMN8gE%2fbXHPG8%3d > > > > > > > > > > > > 2) cordova clones it (i b
Re: [DISCUSS] CocoaPods dependencies for iOS plugins
I mean is that I should be allow to add a plugin from a windows/linux machine where cocoapod client is not present, then compile on a Mac where the pod client is available and "pod install" can run Will need to work out the details with engine, I just want to make sure that engine tag doesn't stop the whole plugin from being added on a windows/linux machine. On Fri, Oct 23, 2015 at 8:33 PM Shazron wrote: > Send PR's or comment on a line in a commit. I think. > > Not sure what you mean -- the purpose of Cocoapods is to > install/uninstall a pod. It is thus a plugin add/install step. > > On Fri, Oct 23, 2015 at 5:12 PM, Carlos Santana > wrote: > > How does this discussion repo works again? > > Do we create a github issue pointing to the proposal to have the > > discussion there with comments? > > > > One thing I notice is that engine the way they work today this will not > > work, since we want to allow the plugin to be installed, and cocoapod is > > only need it on compile step not plugin add/install step. > > > > > > > > On Tue, Oct 20, 2015 at 6:05 AM Vladimir Kotikov (Akvelon) < > > v-vlk...@microsoft.com> wrote: > > > >> Hey, guys. > >> > >> After ios refactoring the handling definitely will be a part > >> of platform. As for tag, I guess it make sense to keep this > logic > >> in LIB and let cordova itself check availability of cocoapods/nuget. > >> > >> - > >> Best regards, Vladimir > >> > >> -Original Message- > >> From: Steven Gill [mailto:stevengil...@gmail.com] > >> Sent: Tuesday, October 20, 2015 2:36 AM > >> To: dev@cordova.apache.org > >> Subject: Re: [DISCUSS] CocoaPods dependencies for iOS plugins > >> > >> Sweet! Yeah lets see where this lands after the refactor. Dependencies > are > >> still handled by lib as far as I know. Not sure about framework but I > >> assume the same. Vladimir would know about where that code will live > after > >> the refactor. > >> > >> Engine + framework tag looks good. Engine tag will have to be extended > to > >> actually fetch cocoapods + nuget I imagine. > >> > >> On Mon, Oct 19, 2015 at 4:23 PM, Shazron wrote: > >> > >> > This is not a platform specific issue, at least for cordova-ios, and > >> > is the domain of the cordova-lib/cli currently (I think the > >> > cordova-lib re-factor changes this?) > >> > > >> > There will be a cordova-discuss doc, but the gist of it is: > >> > > >> > > >> > > >> > > >> > > >> > > >> > >> > src="path/to/mynu.nuspec" type="nuspec" /> > >> > > >> > The above use existing documented attributes for both the and > >> > tags: > >> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcordo > >> > va.apache.org > %2fdocs%2fen%2f5.1.1%2fplugin_ref%2fspec.html&data=01%7c0 > >> > 1%7cv-vlkoti%40064d.mgd.microsoft.com > %7c5e3acbf36e3e43b1eb4d08d2d8de29 > >> > 40%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=MVFyYNFESBtyyUxn2mvK5% > >> > 2bnOxizyDMAP2WIaCWxJwUM%3d > >> > > >> > > >> > On Sat, Oct 17, 2015 at 11:56 PM, Steven Gill > > >> > wrote: > >> > > At the Cordova F2F, everyone seemed to agree that we should bring > >> > CocoaPods > >> > > support to plugins as dependencies for iOS. > >> > > > >> > > Cordova-android currently uses Gradle as a way to enable external > >> > > dependency resolution for plugins using the framework tag. > >> > > > >> > > A suggestion about using the engine tag to fetch cocoapods-cli (mac) > >> > > & NuGet (windows) followed by using the framework tag was discussed. > >> > > > >> > > The minutes[1] show Carlos, Shaz and Raghav as looking into the > design. > >> > > Someone should write up a proposal on cordova-discuss[2] and create > >> > > the issues. Post them in this thread. > >> > > > >> > > This shouldn't take priority over cordova-ios 4 issues. > >> > > > >> > > [1] > >> > > > >> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdocs > . > >> > google.com > %2fdocument%2fd%2f1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCk > >> > bU%2fedit%3fusp%3dsharing&data=01%7c01%7cv-vlkoti%40064d.mgd.microsoft > >> > .com%7c5e3acbf36e3e43b1eb4d08d2d8de2940%7c72f988bf86f141af91ab2d7cd011 > >> > db47%7c1&sdata=GPpiC70BVEDo4gvljKi6OqXsdGUOLPHmhaDKXH6P7kQ%3d > >> > > [2] > >> > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit > >> > > hub.com > %2fcordova%2fcordova-discuss&data=01%7c01%7cv-vlkoti%40064d.m > >> > > gd.microsoft.com > %7c5e3acbf36e3e43b1eb4d08d2d8de2940%7c72f988bf86f141 > >> > > af91ab2d7cd011db47%7c1&sdata=t4gpBVojZ3H94gCLRboa%2fvkHlBCoVxZsWuiCH > >> > > TVkylo%3d > >> > > >> > - > >> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >> > For additional commands, e-mail: dev-h...@cordova.apache.org > >> > > >> > > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: npm install on cordova platform/plugin add
I agree that we should use exact versions for dependencies of Cordova Platforms and Plugins and still bundle dependencies. I don't think we should enforce that requirement on plugin authors. We can have our plugin docs suggest that they use exact versions but I don't think we should skip npm install it if they don't. On Fri, Oct 23, 2015 at 7:13 PM, Carlos Santana wrote: > The requirement will be that 3rd party plugins put exact versions of > dependencies, not assuming that user will need to run npm install or npm > update after adding the plugin to refresh the npm dependencies > > Apache Foundation Cordova Platforms and Plugins should ship with it's > dependencies bundled, or use exact versions for dependencies. > This way all users get the same software at the time of adding a platform > or plugin. If not it becomes a big mess of having a certain version of the > platform or plugin if not guarantee to have the same software as everyone > else (not reproducible, not consistent) > > > > On Fri, Oct 23, 2015 at 7:39 PM Steven Gill > wrote: > > > Issue: https://issues.apache.org/jira/browse/CB-9858 > > > > > > On Fri, Oct 23, 2015 at 1:05 PM, Mefire O. > wrote: > > > > > Ah, it makes sense in both platforms and plugins. > > > > > > Thanks, > > > > > > -Original Message- > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > Sent: Thursday, October 22, 2015 4:46 PM > > > To: dev@cordova.apache.org > > > Subject: Re: npm install on cordova platform/plugin add > > > > > > Yeah. Cordova-common is the main reason for platforms. IMO It doesn't > > make > > > sense to check it into platforms. It makes sense to have it as a > > > bundleDependency but if you cordova platform add it via git url, the > > > dependency won't be around. Hence the npm install On Oct 22, 2015 4:24 > > PM, > > > "Darryl Pogue" wrote: > > > > > > > One example would be the ios-sim and ios-deploy node modules that the > > > > iOS platform needs for launching the simulator and deploying to a > > device. > > > > Currently these are bundled dependencies and checked in to git. > > > > > > > > Another example is the Platform API that's been added to > > > > cordova-android, which depends on cordova-common. > > > > > > > > On 22 October 2015 at 16:17, Mefire O. > wrote: > > > > > > > > > I can definitely see the case for adding deps specified in plugins' > > > > > package.json, which is to make 'tools plugins' development easier. > > > > > > > > > > But I don't understand the use case for platforms. What scenario > are > > > > > we trying to fulfill there ? > > > > > > > > > > Thanks, > > > > > Omar Mefire > > > > > > > > > > -Original Message- > > > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > > > Sent: Thursday, October 22, 2015 2:54 PM > > > > > To: dev@cordova.apache.org > > > > > Subject: npm install on cordova platform/plugin add > > > > > > > > > > We discussed running `npm install` on `cordova plugin add` at the > > > > > Cordova F2F. > > > > > > > > > > I want to see how people feel about this. > > > > > > > > > > For installing a platform via git url, the dependency won't exist > > > > > unless we check it in to the repo. This can cause problems. > > > > > bundleDependencies > > > > are > > > > > only useful for installing via npm > > > > > > > > > > For platforms: > > > > > > > > > > i believe this is how it would work: > > > > > > > > > > Adding via `npm` > > > > > > > > > > 1) `cordova platform add ios` > > > > > > > > > > 2) cordova fetches `cordova-ios` from npm, adds it to global > cordova > > > > > directory > > > > > > > > > > 3) I'd like tools to run `npm install` , but these deps are most > > > > > likely already included in fetched version due to > > > > > `bundleDependecies`. So it wouldn't do anything > > > > > > > > > > Adding locally > > > > > > > > > > 1) `cordova platform add /YourLocalCordovaIOS` > > > > > > > > > > 2) cordova uses your `cordova-ios` > > > > > > > > > > 3) tools to run `npm install` which should have no impact (Assuming > > > > you've > > > > > done it manually) > > > > > > > > > > Adding via Git url > > > > > > > > > > 1) `cordova platform add > > > > > > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu > > > > b.com%2fapache%2fcordova-ios%60&data=01%7c01%7commenjik% > 40microsoft.co > > > > > m%7c8b52f2866d674b08c10b08d2db2b5347%7c72f988bf86f141af91ab2d7cd011db4 > > > > 7%7c1&sdata=zdpqgA08JQxJ4h5DpWCpBiggl1RTZu%2fMN8gE%2fbXHPG8%3d > > > > > > > > > > 2) cordova clones it (i believe into global cordova directory) > > > > > > > > > > 3) tools to run `npm install` which is important because packages > > > > > aren't bundled unless we manually check them in > > > > > > > > > > For Plugins > > > > > It would allow plugins to have 3rd party npm dependencies and not > > > > > have to check them in. This will be even more important once we > > > > > switch to browserify method. > > > > > > > > > > Thoughts? > > > > > > > > > > > > > >
Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface
+1 if what Simon and Jesse are saying is the same thing :-)
On Fri, Oct 23, 2015 at 7:42 PM Jesse wrote:
> Let's go ahead with renaming CordovaWebView => CordovaWebInterface, and
> keeping around a CordovaWebView object so that nothing breaks.
>
> We should also deprecate CordovaWebView, and document the change so that
> people who are using it have some notice, and people who are new know what
> NOT to use.
>
> We don't have to remove it immediately, or even on our next major bump,
> just sometime down the road.
> If we don't move forward we will just be stuck with it forever ...
>
>
>
>
> My team is hiring!
> @purplecabbage
> risingj.com
>
> On Fri, Oct 23, 2015 at 1:19 PM, Nikhil Khandelwal >
> wrote:
>
> > I understand that it won't break currently and it will break on the next
> > major version bump. IMHO it's just not worth it for this name change.
> >
> > Historically, we've had challenges with giving sufficient notice from
> > breaking changes. I would avoid them unless absolutely needed.
> >
> > -Nikhil
> >
> > -Original Message-
> > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> > Sent: Thursday, October 22, 2015 12:14 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [Android][Discuss] Change name of CordovaWebView to
> > CordovaWebInterface
> >
> > Let's just be clear that in Cordova Android 5.0 nothing will break.
> > The interface CordovaWebView has been renamed to CordovaWebInterface but
> > that won't break anything as we introduce a new class called, wait for
> it,
> > CordovaWebView that extends the new CordovaWebInterface. This way all
> > current code that uses CordovaWebView will continue to work without
> > modification.
> >
> > If we start updating our documentation, i.e. how to write a CordovaPlugin
> > for Android, and give people plenty of notice that this is going to
> happen
> > then I don't see why we wouldn't want to move forward.
> >
> > That's just my 2 cents.
> >
> > Simon Mac Donald
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald&data=01%7c01%7cnikhilkh%40microsoft.com%7caf6077fb55224d7b1d2c08d2db1508fe%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=50aLt1e0sp9z4TrrSBiMnAaBdSj1RrUuIEcnPaHGD1U%3d
> >
> >
> > On Wed, Oct 21, 2015 at 6:13 PM, Nikhil Khandelwal <
> nikhi...@microsoft.com>
> > wrote:
> > > Thanks, Joe for the summary of the impact later.
> > >
> > > -1. IMO - a naming change is no worth the effort and future breakage.
> > >
> > > -Nikhil
> > >
> > > -Original Message-
> > > From: Joe Bowser [mailto:bows...@gmail.com]
> > > Sent: Wednesday, October 21, 2015 11:06 AM
> > > To: dev
> > > Subject: Re: [Android][Discuss] Change name of CordovaWebView to
> > > CordovaWebInterface
> > >
> > > Yes, I do. I had to search through mobilespec, but here it is:
> > >
> > > private static final boolean HAS_BUILT_IN_SPLASH_SCREEN =
> > > Integer.valueOf(CordovaWebView.CORDOVA_VERSION.split("\\.")[0]) < 4;
> > >
> > > Also, every plugin that calls initialize requires a CordovaWebView
> > passed into it. That's a pretty big change. I also haven't touched on
> > Third Party WebViews like Crosswalk, which would have to do the change.
> > >
> > >
> > > On Tue, Oct 20, 2015 at 1:59 PM, Steven Gill
> > wrote:
> > >
> > >> Joe, do you have a small example of what could break with this change.
> > >> What is a usecase for someone to reference CordovaWebView
> > >>
> > >> On Tue, Oct 20, 2015 at 1:38 PM, Joe Bowser
> wrote:
> > >>
> > >> > I'll pull this in at the end of the day. This small change may
> > >> > break
> > >> stuff
> > >> > further down the road, so people should comment on it now.
> > >> >
> > >> > On Tue, Oct 20, 2015 at 1:37 PM, Joe Bowser
> > wrote:
> > >> >
> > >> > > OK, Going to pull this in.
> > >> > >
> > >> > > On Tue, Oct 20, 2015 at 10:02 AM, Simon MacDonald <
> > >> > > simon.macdon...@gmail.com> wrote:
> > >> > >
> > >> > >> +1 from me as I'm the one that initiated the PR.
> > >> > >>
> > >> > >> Simon Mac Donald
> > >> > >> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2f
> > >> > >> h
> > >> > >> i.im%2fsimonmacdonald&data=01%7c01%7cnikhilkh%40microsoft.com%7c
> > >> > >> 8
> > >> > >> 619031b1eef484bd48508d2da425e41%7c72f988bf86f141af91ab2d7cd011db
> > >> > >> 4 7%7c1&sdata=IXoWw2z2L7EhCorf4kK4EJ7Ux89hdUjmP%2bKsF%2bJdwf0%3d
> > >> > >>
> > >> > >> On Tue, Oct 20, 2015 at 12:23 PM, Darryl Pogue
> > >> > >>
> > >> > wrote:
> > >> > >>
> > >> > >> > +1 for doing this with the major version bump
> > >> > >> >
> > >> > >> > On 20 October 2015 at 09:15, Joe Bowser
> > wrote:
> > >> > >> >
> > >> > >> > > Hey
> > >> > >> > >
> > >> > >> > > We're close to getting 5.0.x ready for release, but I want
> > >> > >> > > to add
> > >> > one
> > >> > >> > more
> > >> > >> > > pull request:
> > >> > >> > >
> > >> > >> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%
> > >> > >> > > 2
> > >> > >> > > f%2fgithub.com%2fapache%2fcordova-android%2fpull%2f2
Re: npm install on cordova platform/plugin add
The requirement will be that 3rd party plugins put exact versions of dependencies, not assuming that user will need to run npm install or npm update after adding the plugin to refresh the npm dependencies Apache Foundation Cordova Platforms and Plugins should ship with it's dependencies bundled, or use exact versions for dependencies. This way all users get the same software at the time of adding a platform or plugin. If not it becomes a big mess of having a certain version of the platform or plugin if not guarantee to have the same software as everyone else (not reproducible, not consistent) On Fri, Oct 23, 2015 at 7:39 PM Steven Gill wrote: > Issue: https://issues.apache.org/jira/browse/CB-9858 > > > On Fri, Oct 23, 2015 at 1:05 PM, Mefire O. wrote: > > > Ah, it makes sense in both platforms and plugins. > > > > Thanks, > > > > -Original Message- > > From: Steven Gill [mailto:stevengil...@gmail.com] > > Sent: Thursday, October 22, 2015 4:46 PM > > To: dev@cordova.apache.org > > Subject: Re: npm install on cordova platform/plugin add > > > > Yeah. Cordova-common is the main reason for platforms. IMO It doesn't > make > > sense to check it into platforms. It makes sense to have it as a > > bundleDependency but if you cordova platform add it via git url, the > > dependency won't be around. Hence the npm install On Oct 22, 2015 4:24 > PM, > > "Darryl Pogue" wrote: > > > > > One example would be the ios-sim and ios-deploy node modules that the > > > iOS platform needs for launching the simulator and deploying to a > device. > > > Currently these are bundled dependencies and checked in to git. > > > > > > Another example is the Platform API that's been added to > > > cordova-android, which depends on cordova-common. > > > > > > On 22 October 2015 at 16:17, Mefire O. wrote: > > > > > > > I can definitely see the case for adding deps specified in plugins' > > > > package.json, which is to make 'tools plugins' development easier. > > > > > > > > But I don't understand the use case for platforms. What scenario are > > > > we trying to fulfill there ? > > > > > > > > Thanks, > > > > Omar Mefire > > > > > > > > -Original Message- > > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > > Sent: Thursday, October 22, 2015 2:54 PM > > > > To: dev@cordova.apache.org > > > > Subject: npm install on cordova platform/plugin add > > > > > > > > We discussed running `npm install` on `cordova plugin add` at the > > > > Cordova F2F. > > > > > > > > I want to see how people feel about this. > > > > > > > > For installing a platform via git url, the dependency won't exist > > > > unless we check it in to the repo. This can cause problems. > > > > bundleDependencies > > > are > > > > only useful for installing via npm > > > > > > > > For platforms: > > > > > > > > i believe this is how it would work: > > > > > > > > Adding via `npm` > > > > > > > > 1) `cordova platform add ios` > > > > > > > > 2) cordova fetches `cordova-ios` from npm, adds it to global cordova > > > > directory > > > > > > > > 3) I'd like tools to run `npm install` , but these deps are most > > > > likely already included in fetched version due to > > > > `bundleDependecies`. So it wouldn't do anything > > > > > > > > Adding locally > > > > > > > > 1) `cordova platform add /YourLocalCordovaIOS` > > > > > > > > 2) cordova uses your `cordova-ios` > > > > > > > > 3) tools to run `npm install` which should have no impact (Assuming > > > you've > > > > done it manually) > > > > > > > > Adding via Git url > > > > > > > > 1) `cordova platform add > > > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu > > > b.com%2fapache%2fcordova-ios%60&data=01%7c01%7commenjik%40microsoft.co > > > m%7c8b52f2866d674b08c10b08d2db2b5347%7c72f988bf86f141af91ab2d7cd011db4 > > > 7%7c1&sdata=zdpqgA08JQxJ4h5DpWCpBiggl1RTZu%2fMN8gE%2fbXHPG8%3d > > > > > > > > 2) cordova clones it (i believe into global cordova directory) > > > > > > > > 3) tools to run `npm install` which is important because packages > > > > aren't bundled unless we manually check them in > > > > > > > > For Plugins > > > > It would allow plugins to have 3rd party npm dependencies and not > > > > have to check them in. This will be even more important once we > > > > switch to browserify method. > > > > > > > > Thoughts? > > > > > > > > > >
Re: [Discuss] Cordova-common release
I'm disappointed Steve, the npm team will remember you as the guy that
keeps publishing 0.x packages like it was 2013 LOL
On Fri, Oct 23, 2015 at 9:24 PM Steven Gill wrote:
> Those are good points about the readme. I thought the same thing about the
> version but was going to let it slide :P.
>
>
>
> On Fri, Oct 23, 2015 at 6:14 PM, Carlos Santana
> wrote:
>
> > Not excited about putting this on npm, I feel you can just name it
> > cordova-lib2
> > But if we are going to do it let's at least follow the npm way:
> > The version should be 1.0.0, because shipping 0.x is kind lame this days
> > What is the API of this first release? I hope there is a good README that
> > will be display on npmjs.com
> > cdvCommon = require('cordova-common')
> > cdvCommon.x does x
> > cdvCommon.y does y
> > Since there is no "npm test" or test folder, the README should talk about
> > how this code in the npm module get's tested from cordova-lib
> >
> >
> >
> >
> > On Thu, Oct 22, 2015 at 2:46 PM Steven Gill
> > wrote:
> >
> > > DO IT!
> > >
> > > On Thu, Oct 22, 2015 at 11:44 AM, Vladimir Kotikov (Akvelon) <
> > > v-vlk...@microsoft.com> wrote:
> > >
> > > > So if there is no -1, I'm going to start VOTE thread tomorrow.
> > > >
> > > > -
> > > > Best regards, Vladimir
> > > >
> > > > -Original Message-
> > > > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> > > > Sent: Thursday, October 22, 2015 2:09 PM
> > > > To: dev@cordova.apache.org
> > > > Subject: RE: [Discuss] Cordova-common release
> > > >
> > > > > From what I understand, it's release ready with no known issues.
> > > > Vladimir: Is that correct?
> > > > Confirm. The only one problem is missing license header for Adb.js.
> > Added
> > > > it in 78b7ae7. Right now everything is ready for release.
> > > >
> > > > -
> > > > Best regards, Vladimir
> > > >
> > > > -Original Message-
> > > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> > > > Sent: Wednesday, October 21, 2015 7:31 PM
> > > > To: dev@cordova.apache.org
> > > > Subject: RE: [Discuss] Cordova-common release
> > > >
> > > > It should not - it's a good change for Android 5.0. However, it does
> > > > represent a big change and we need more testing. From what I
> > understand,
> > > > it's release ready with no known issues. Vladimir: Is that correct?
> > > >
> > > > As for the cordova-common dependency, cordova-android will bundle it.
> > And
> > > > we don't have to wait for a cordova-common release to release
> > > > cordova-android.
> > > >
> > > > -Nikhil
> > > >
> > > > -Original Message-
> > > > From: Joe Bowser [mailto:bows...@gmail.com]
> > > > Sent: Wednesday, October 21, 2015 9:19 AM
> > > > To: dev
> > > > Subject: Re: [Discuss] Cordova-common release
> > > >
> > > > OK, how will this impact the 5.0 release of Android?
> > > >
> > > > On Tue, Oct 20, 2015 at 6:07 PM, Nikhil Khandelwal <
> > > nikhi...@microsoft.com
> > > > >
> > > > wrote:
> > > >
> > > > > It got checked in earlier this morning.
> > > > >
> > > > > -Nikhil
> > > > >
> > > > > -Original Message-
> > > > > From: Joe Bowser [mailto:bows...@gmail.com]
> > > > > Sent: Tuesday, October 20, 2015 2:34 PM
> > > > > To: dev
> > > > > Subject: Re: [Discuss] Cordova-common release
> > > > >
> > > > > So, when did the PlatformAPI change land in Android?
> > > > >
> > > > > On Tue, Oct 20, 2015 at 2:32 PM, Parashuram N <
> > panar...@microsoft.com>
> > > > > wrote:
> > > > >
> > > > > > +1 - YES please. Requiring cordoba-common for my
> > > > > > react-native-cordova-plugin adapter was a nightmare !!
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > On 10/20/15, 2:23 PM, "Nikhil Khandelwal" <
> nikhi...@microsoft.com>
> > > > > wrote:
> > > > > >
> > > > > > >+1 to publishing cordova-common to npm.
> > > > > > >
> > > > > > >-Nikhil
> > > > > > >
> > > > > > >-Original Message-
> > > > > > >From: Steven Gill [mailto:stevengil...@gmail.com]
> > > > > > >Sent: Tuesday, October 20, 2015 2:20 PM
> > > > > > >To: dev@cordova.apache.org
> > > > > > >Subject: Re: [Discuss] Cordova-common release
> > > > > > >
> > > > > > >I want to revisit this.
> > > > > > >
> > > > > > >So cordova-android has a dependency now on cordova-common. It
> is a
> > > > > > bundledDependency so when we generate a tar to release
> > > > > > cordova-android, it will be included. It will also be in the
> > > > > > cordova-android package that gets downloaded with cordova
> platform
> > > add.
> > > > > > >
> > > > > > >This is fine for released work, but more annoying for
> development.
> > > > > > >I need
> > > > > > to npm link cordova-common into cordova-android (and soon every
> > > > > > platform which implements common platformAPI). We could check in
> > > > > > cordova-common into cordova-android but that isn't a great
> solution
> > > > > either.
> > > > > > >
> > > > > > >I agree that we should be going towards smaller modules and not
> > > > > > >having a
> > > > > > case of c
Re: [DISCUSS] Curating Apps
Sure, I’m also down for removing the “add your app” option. Switching to putting apps up only at our own discretion makes sense. My only concern is that I personally haven’t tried out many Cordova apps, so I would expect us to have a shortage of apps this way. But if other PMC members have apps to suggest, then we should be good. To move forward with Carlos’ proposal, we ought to: - curate the existing list - have someone explain the change of policy to the PRs still open Any takers for those two tasks? Kindly, Dmitry > On Oct 23, 2015, at 6:01 PM, Steven Gill wrote: > > YES! Removing the "add a tool" and "add a plugin" is the best way to go. > Those PRs require way to much management. Leave it up to PMC to nominate > apps. > > On Fri, Oct 23, 2015 at 5:41 PM, Nikhil Khandelwal > wrote: > >> I like Carlos' proposal. Reviewing PRs for these apps and judging by >> whatever criteria we finally decide (however objective/subjective) will not >> be worth our time. The volume of PRs over the last couple of weeks has been >> quite significant in this area. >> >> At the end of the day, we just need 5-10 showcase apps. >> >> -Nikhil >> >> -Original Message- >> From: Carlos Santana [mailto:csantan...@gmail.com] >> Sent: Friday, October 23, 2015 5:37 PM >> To: dev@cordova.apache.org >> Subject: Re: [DISCUSS] Curating Apps >> >> I think we make it more simpler, a PMC member to propose to add an app >> that he/she tried out and feels that it deserves to be show case as a good >> example of a great Cordova App. >> - remove the "add your app" >> - PMC members mails the list, that he evaluated the app and a short >> description on why to added and he is planning to added, and ask if someone >> opposed with a -1 >> - Like Joe said, we don't need a tons of Apps, just a few will satisfy the >> goal >> - The Apache way, if there are no -1 app get's added. >> >> >> >> >> On Wed, Oct 21, 2015 at 7:27 PM Dmitry Blotsky >> wrote: >> >>> Sounds like we’ve got some (potentially mutually exclusive) points: >>> - request detailed app descriptions from submitters >>> - curate based on detailed criteria >>> - curate based on loose criteria >>> - only accept blog posts, and get rid of the showcase >>> - just accept all requests >>> >>> Should this be a proposal on cordova-discuss? Or does someone feel >>> like we have a consensus? The ultimate goal is to have something that >>> displays good use of Cordova. I’d personally like to go with the >>> easiest way to achieve this. >>> >>> Kindly, >>> Dmitry >>> On Oct 19, 2015, at 1:28 PM, Joerg Holz wrote: I like the slogan: "submit something that helps other developers build a >>> better app“. I disagree about your app store points, staring, public store, we don’t >>> need that. And my opion is, that we should promote apps, which are clean or mostly >>> clean from any Framework. Joerg > Am 19.10.2015 um 20:11 schrieb Ryan J. Salva : > > The original goal for including the app showcase was to demonstrate >>> that developers can build rockstar-quality apps using Cordova. I agree >>> that by opening the invitation to anyone without a vetting process, we >>> fall short of the original goal. Indeed, we might end up with a throng >>> of hobo-quality apps using any technology under the sun :-) > > At the same time, I don't want to sign up any of the Cordova > committers >>> to navigate the prejudicial question of "what counts as good?" Thus, I >>> like Jörg's proposal that we raise the empirical bar for entry. App >>> developers need to prove not only that their app is a Cordova app, but >>> they have to submit something that helps other developers build a better >> app. > > Here's a straw man proposal intended to provoke response: > > Must appear in a public store > Must use Cordova > Minimum 4 start rating > Minimum 1,000 downloads > Submitter must write a 200+ word blog post answering – Which > platforms are supported (minimum two) – Which plugins are used? > – Which frameworks are used, if any? > – Syncing, languages, support for disabled people, … – Something > about problems – Development environment and tools used > > Thoughts? > rjs > > Ryan J. Salva | Principal Program Manager Lead Visual Studio > Tools for Apache Cordova rsa...@microsoft.com > 206 612 5079 mobile > > > > -Original Message- > From: Joerg Holz [mailto:h...@hamburg.de] > Sent: Monday, October 19, 2015 8:11 AM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Curating Apps > > thx for agreeing, but I see things different: > > – What means pretty good, who will decide this, how to measure? > > – What mean's popular, count of downloads? > > Cordova as project has to have a view from Cordova -> Apps and not > from >>> the o
Re: [Discuss] Cordova-common release
Those are good points about the readme. I thought the same thing about the
version but was going to let it slide :P.
On Fri, Oct 23, 2015 at 6:14 PM, Carlos Santana
wrote:
> Not excited about putting this on npm, I feel you can just name it
> cordova-lib2
> But if we are going to do it let's at least follow the npm way:
> The version should be 1.0.0, because shipping 0.x is kind lame this days
> What is the API of this first release? I hope there is a good README that
> will be display on npmjs.com
> cdvCommon = require('cordova-common')
> cdvCommon.x does x
> cdvCommon.y does y
> Since there is no "npm test" or test folder, the README should talk about
> how this code in the npm module get's tested from cordova-lib
>
>
>
>
> On Thu, Oct 22, 2015 at 2:46 PM Steven Gill
> wrote:
>
> > DO IT!
> >
> > On Thu, Oct 22, 2015 at 11:44 AM, Vladimir Kotikov (Akvelon) <
> > v-vlk...@microsoft.com> wrote:
> >
> > > So if there is no -1, I'm going to start VOTE thread tomorrow.
> > >
> > > -
> > > Best regards, Vladimir
> > >
> > > -Original Message-
> > > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> > > Sent: Thursday, October 22, 2015 2:09 PM
> > > To: dev@cordova.apache.org
> > > Subject: RE: [Discuss] Cordova-common release
> > >
> > > > From what I understand, it's release ready with no known issues.
> > > Vladimir: Is that correct?
> > > Confirm. The only one problem is missing license header for Adb.js.
> Added
> > > it in 78b7ae7. Right now everything is ready for release.
> > >
> > > -
> > > Best regards, Vladimir
> > >
> > > -Original Message-
> > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> > > Sent: Wednesday, October 21, 2015 7:31 PM
> > > To: dev@cordova.apache.org
> > > Subject: RE: [Discuss] Cordova-common release
> > >
> > > It should not - it's a good change for Android 5.0. However, it does
> > > represent a big change and we need more testing. From what I
> understand,
> > > it's release ready with no known issues. Vladimir: Is that correct?
> > >
> > > As for the cordova-common dependency, cordova-android will bundle it.
> And
> > > we don't have to wait for a cordova-common release to release
> > > cordova-android.
> > >
> > > -Nikhil
> > >
> > > -Original Message-
> > > From: Joe Bowser [mailto:bows...@gmail.com]
> > > Sent: Wednesday, October 21, 2015 9:19 AM
> > > To: dev
> > > Subject: Re: [Discuss] Cordova-common release
> > >
> > > OK, how will this impact the 5.0 release of Android?
> > >
> > > On Tue, Oct 20, 2015 at 6:07 PM, Nikhil Khandelwal <
> > nikhi...@microsoft.com
> > > >
> > > wrote:
> > >
> > > > It got checked in earlier this morning.
> > > >
> > > > -Nikhil
> > > >
> > > > -Original Message-
> > > > From: Joe Bowser [mailto:bows...@gmail.com]
> > > > Sent: Tuesday, October 20, 2015 2:34 PM
> > > > To: dev
> > > > Subject: Re: [Discuss] Cordova-common release
> > > >
> > > > So, when did the PlatformAPI change land in Android?
> > > >
> > > > On Tue, Oct 20, 2015 at 2:32 PM, Parashuram N <
> panar...@microsoft.com>
> > > > wrote:
> > > >
> > > > > +1 - YES please. Requiring cordoba-common for my
> > > > > react-native-cordova-plugin adapter was a nightmare !!
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On 10/20/15, 2:23 PM, "Nikhil Khandelwal"
> > > > wrote:
> > > > >
> > > > > >+1 to publishing cordova-common to npm.
> > > > > >
> > > > > >-Nikhil
> > > > > >
> > > > > >-Original Message-
> > > > > >From: Steven Gill [mailto:stevengil...@gmail.com]
> > > > > >Sent: Tuesday, October 20, 2015 2:20 PM
> > > > > >To: dev@cordova.apache.org
> > > > > >Subject: Re: [Discuss] Cordova-common release
> > > > > >
> > > > > >I want to revisit this.
> > > > > >
> > > > > >So cordova-android has a dependency now on cordova-common. It is a
> > > > > bundledDependency so when we generate a tar to release
> > > > > cordova-android, it will be included. It will also be in the
> > > > > cordova-android package that gets downloaded with cordova platform
> > add.
> > > > > >
> > > > > >This is fine for released work, but more annoying for development.
> > > > > >I need
> > > > > to npm link cordova-common into cordova-android (and soon every
> > > > > platform which implements common platformAPI). We could check in
> > > > > cordova-common into cordova-android but that isn't a great solution
> > > > either.
> > > > > >
> > > > > >I agree that we should be going towards smaller modules and not
> > > > > >having a
> > > > > case of cordovaLib1, cordovaLib2, etc. I think this is still going
> > > > > to be a work in progress and will take some time.
> > > > > >
> > > > > >For the interim, I recommend we publish cordova-common. Of course,
> > > > > continue to add it as a bundledDependency so users don't need to
> npm
> > > > > install it with released packages.
> > > > > >
> > > > > >On Wed, Sep 30, 2015 at 7:24 AM, Vladimir Kotikov (Akvelon) <
> > > > > v-vlk...@microsoft.com> wrote:
> > > > > >
> > >
Re: [DISCUSS] Curating Apps
Just want to add that I feel offended that no one from the PhoneGap team has added Untappd Shame on you all !!! On Fri, Oct 23, 2015 at 9:01 PM Steven Gill wrote: > YES! Removing the "add a tool" and "add a plugin" is the best way to go. > Those PRs require way to much management. Leave it up to PMC to nominate > apps. > > On Fri, Oct 23, 2015 at 5:41 PM, Nikhil Khandelwal > > wrote: > > > I like Carlos' proposal. Reviewing PRs for these apps and judging by > > whatever criteria we finally decide (however objective/subjective) will > not > > be worth our time. The volume of PRs over the last couple of weeks has > been > > quite significant in this area. > > > > At the end of the day, we just need 5-10 showcase apps. > > > > -Nikhil > > > > -Original Message- > > From: Carlos Santana [mailto:csantan...@gmail.com] > > Sent: Friday, October 23, 2015 5:37 PM > > To: dev@cordova.apache.org > > Subject: Re: [DISCUSS] Curating Apps > > > > I think we make it more simpler, a PMC member to propose to add an app > > that he/she tried out and feels that it deserves to be show case as a > good > > example of a great Cordova App. > > - remove the "add your app" > > - PMC members mails the list, that he evaluated the app and a short > > description on why to added and he is planning to added, and ask if > someone > > opposed with a -1 > > - Like Joe said, we don't need a tons of Apps, just a few will satisfy > the > > goal > > - The Apache way, if there are no -1 app get's added. > > > > > > > > > > On Wed, Oct 21, 2015 at 7:27 PM Dmitry Blotsky > > wrote: > > > > > Sounds like we’ve got some (potentially mutually exclusive) points: > > > - request detailed app descriptions from submitters > > > - curate based on detailed criteria > > > - curate based on loose criteria > > > - only accept blog posts, and get rid of the showcase > > > - just accept all requests > > > > > > Should this be a proposal on cordova-discuss? Or does someone feel > > > like we have a consensus? The ultimate goal is to have something that > > > displays good use of Cordova. I’d personally like to go with the > > > easiest way to achieve this. > > > > > > Kindly, > > > Dmitry > > > > > > > On Oct 19, 2015, at 1:28 PM, Joerg Holz wrote: > > > > > > > > I like the slogan: "submit something that helps other developers > > > > build a > > > better app“. > > > > > > > > I disagree about your app store points, staring, public store, we > > > > don’t > > > need that. > > > > > > > > And my opion is, that we should promote apps, which are clean or > > > > mostly > > > clean from any Framework. > > > > > > > > > > > > Joerg > > > > > > > > > > > >> Am 19.10.2015 um 20:11 schrieb Ryan J. Salva >: > > > >> > > > >> The original goal for including the app showcase was to demonstrate > > > that developers can build rockstar-quality apps using Cordova. I agree > > > that by opening the invitation to anyone without a vetting process, we > > > fall short of the original goal. Indeed, we might end up with a throng > > > of hobo-quality apps using any technology under the sun :-) > > > >> > > > >> At the same time, I don't want to sign up any of the Cordova > > > >> committers > > > to navigate the prejudicial question of "what counts as good?" Thus, I > > > like Jörg's proposal that we raise the empirical bar for entry. App > > > developers need to prove not only that their app is a Cordova app, but > > > they have to submit something that helps other developers build a > better > > app. > > > >> > > > >> Here's a straw man proposal intended to provoke response: > > > >> > > > >> Must appear in a public store > > > >> Must use Cordova > > > >> Minimum 4 start rating > > > >> Minimum 1,000 downloads > > > >> Submitter must write a 200+ word blog post answering – Which > > > >> platforms are supported (minimum two) – Which plugins are used? > > > >> – Which frameworks are used, if any? > > > >> – Syncing, languages, support for disabled people, … – Something > > > >> about problems – Development environment and tools used > > > >> > > > >> Thoughts? > > > >> rjs > > > >> > > > >> Ryan J. Salva | Principal Program Manager Lead Visual Studio > > > >> Tools for Apache Cordova rsa...@microsoft.com > > > >> 206 612 5079 mobile > > > >> > > > >> > > > >> > > > >> -Original Message- > > > >> From: Joerg Holz [mailto:h...@hamburg.de] > > > >> Sent: Monday, October 19, 2015 8:11 AM > > > >> To: dev@cordova.apache.org > > > >> Subject: Re: [DISCUSS] Curating Apps > > > >> > > > >> thx for agreeing, but I see things different: > > > >> > > > >> – What means pretty good, who will decide this, how to measure? > > > >> > > > >> – What mean's popular, count of downloads? > > > >> > > > >> Cordova as project has to have a view from Cordova -> Apps and not > > > >> from > > > the other side. People have to say, why Cordova is good, Cordova has > > > not to say why an app is good. > > > >> > > > >> > > > >> And, yes, there is a need to have a blog or someting
Re: [Discuss] Cordova-common release
Not excited about putting this on npm, I feel you can just name it
cordova-lib2
But if we are going to do it let's at least follow the npm way:
The version should be 1.0.0, because shipping 0.x is kind lame this days
What is the API of this first release? I hope there is a good README that
will be display on npmjs.com
cdvCommon = require('cordova-common')
cdvCommon.x does x
cdvCommon.y does y
Since there is no "npm test" or test folder, the README should talk about
how this code in the npm module get's tested from cordova-lib
On Thu, Oct 22, 2015 at 2:46 PM Steven Gill wrote:
> DO IT!
>
> On Thu, Oct 22, 2015 at 11:44 AM, Vladimir Kotikov (Akvelon) <
> v-vlk...@microsoft.com> wrote:
>
> > So if there is no -1, I'm going to start VOTE thread tomorrow.
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
> > Sent: Thursday, October 22, 2015 2:09 PM
> > To: dev@cordova.apache.org
> > Subject: RE: [Discuss] Cordova-common release
> >
> > > From what I understand, it's release ready with no known issues.
> > Vladimir: Is that correct?
> > Confirm. The only one problem is missing license header for Adb.js. Added
> > it in 78b7ae7. Right now everything is ready for release.
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> > Sent: Wednesday, October 21, 2015 7:31 PM
> > To: dev@cordova.apache.org
> > Subject: RE: [Discuss] Cordova-common release
> >
> > It should not - it's a good change for Android 5.0. However, it does
> > represent a big change and we need more testing. From what I understand,
> > it's release ready with no known issues. Vladimir: Is that correct?
> >
> > As for the cordova-common dependency, cordova-android will bundle it. And
> > we don't have to wait for a cordova-common release to release
> > cordova-android.
> >
> > -Nikhil
> >
> > -Original Message-
> > From: Joe Bowser [mailto:bows...@gmail.com]
> > Sent: Wednesday, October 21, 2015 9:19 AM
> > To: dev
> > Subject: Re: [Discuss] Cordova-common release
> >
> > OK, how will this impact the 5.0 release of Android?
> >
> > On Tue, Oct 20, 2015 at 6:07 PM, Nikhil Khandelwal <
> nikhi...@microsoft.com
> > >
> > wrote:
> >
> > > It got checked in earlier this morning.
> > >
> > > -Nikhil
> > >
> > > -Original Message-
> > > From: Joe Bowser [mailto:bows...@gmail.com]
> > > Sent: Tuesday, October 20, 2015 2:34 PM
> > > To: dev
> > > Subject: Re: [Discuss] Cordova-common release
> > >
> > > So, when did the PlatformAPI change land in Android?
> > >
> > > On Tue, Oct 20, 2015 at 2:32 PM, Parashuram N
> > > wrote:
> > >
> > > > +1 - YES please. Requiring cordoba-common for my
> > > > react-native-cordova-plugin adapter was a nightmare !!
> > > >
> > > >
> > > >
> > > >
> > > > On 10/20/15, 2:23 PM, "Nikhil Khandelwal"
> > > wrote:
> > > >
> > > > >+1 to publishing cordova-common to npm.
> > > > >
> > > > >-Nikhil
> > > > >
> > > > >-Original Message-
> > > > >From: Steven Gill [mailto:stevengil...@gmail.com]
> > > > >Sent: Tuesday, October 20, 2015 2:20 PM
> > > > >To: dev@cordova.apache.org
> > > > >Subject: Re: [Discuss] Cordova-common release
> > > > >
> > > > >I want to revisit this.
> > > > >
> > > > >So cordova-android has a dependency now on cordova-common. It is a
> > > > bundledDependency so when we generate a tar to release
> > > > cordova-android, it will be included. It will also be in the
> > > > cordova-android package that gets downloaded with cordova platform
> add.
> > > > >
> > > > >This is fine for released work, but more annoying for development.
> > > > >I need
> > > > to npm link cordova-common into cordova-android (and soon every
> > > > platform which implements common platformAPI). We could check in
> > > > cordova-common into cordova-android but that isn't a great solution
> > > either.
> > > > >
> > > > >I agree that we should be going towards smaller modules and not
> > > > >having a
> > > > case of cordovaLib1, cordovaLib2, etc. I think this is still going
> > > > to be a work in progress and will take some time.
> > > > >
> > > > >For the interim, I recommend we publish cordova-common. Of course,
> > > > continue to add it as a bundledDependency so users don't need to npm
> > > > install it with released packages.
> > > > >
> > > > >On Wed, Sep 30, 2015 at 7:24 AM, Vladimir Kotikov (Akvelon) <
> > > > v-vlk...@microsoft.com> wrote:
> > > > >
> > > > >> > I still do not understand what are you trying to solve by
> > > > >> > having all
> > > > >> that content published as big blob.
> > > > >> Code deduplication is the main reason. All the things from
> > > > >> 'cordova-common' will be used by platforms intensively, so we
> > > > >> need to share this code and keep it separately from LIB to share
> > easily.
> > > > >> Publishing is basically doesn't required for this, and bundling
> > > > >> 'cordova-common' i
[GitHub] cordova-plugin-device-motion pull request: CB-8096 Pended auto tes...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Curating Apps
YES! Removing the "add a tool" and "add a plugin" is the best way to go. Those PRs require way to much management. Leave it up to PMC to nominate apps. On Fri, Oct 23, 2015 at 5:41 PM, Nikhil Khandelwal wrote: > I like Carlos' proposal. Reviewing PRs for these apps and judging by > whatever criteria we finally decide (however objective/subjective) will not > be worth our time. The volume of PRs over the last couple of weeks has been > quite significant in this area. > > At the end of the day, we just need 5-10 showcase apps. > > -Nikhil > > -Original Message- > From: Carlos Santana [mailto:csantan...@gmail.com] > Sent: Friday, October 23, 2015 5:37 PM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Curating Apps > > I think we make it more simpler, a PMC member to propose to add an app > that he/she tried out and feels that it deserves to be show case as a good > example of a great Cordova App. > - remove the "add your app" > - PMC members mails the list, that he evaluated the app and a short > description on why to added and he is planning to added, and ask if someone > opposed with a -1 > - Like Joe said, we don't need a tons of Apps, just a few will satisfy the > goal > - The Apache way, if there are no -1 app get's added. > > > > > On Wed, Oct 21, 2015 at 7:27 PM Dmitry Blotsky > wrote: > > > Sounds like we’ve got some (potentially mutually exclusive) points: > > - request detailed app descriptions from submitters > > - curate based on detailed criteria > > - curate based on loose criteria > > - only accept blog posts, and get rid of the showcase > > - just accept all requests > > > > Should this be a proposal on cordova-discuss? Or does someone feel > > like we have a consensus? The ultimate goal is to have something that > > displays good use of Cordova. I’d personally like to go with the > > easiest way to achieve this. > > > > Kindly, > > Dmitry > > > > > On Oct 19, 2015, at 1:28 PM, Joerg Holz wrote: > > > > > > I like the slogan: "submit something that helps other developers > > > build a > > better app“. > > > > > > I disagree about your app store points, staring, public store, we > > > don’t > > need that. > > > > > > And my opion is, that we should promote apps, which are clean or > > > mostly > > clean from any Framework. > > > > > > > > > Joerg > > > > > > > > >> Am 19.10.2015 um 20:11 schrieb Ryan J. Salva : > > >> > > >> The original goal for including the app showcase was to demonstrate > > that developers can build rockstar-quality apps using Cordova. I agree > > that by opening the invitation to anyone without a vetting process, we > > fall short of the original goal. Indeed, we might end up with a throng > > of hobo-quality apps using any technology under the sun :-) > > >> > > >> At the same time, I don't want to sign up any of the Cordova > > >> committers > > to navigate the prejudicial question of "what counts as good?" Thus, I > > like Jörg's proposal that we raise the empirical bar for entry. App > > developers need to prove not only that their app is a Cordova app, but > > they have to submit something that helps other developers build a better > app. > > >> > > >> Here's a straw man proposal intended to provoke response: > > >> > > >> Must appear in a public store > > >> Must use Cordova > > >> Minimum 4 start rating > > >> Minimum 1,000 downloads > > >> Submitter must write a 200+ word blog post answering – Which > > >> platforms are supported (minimum two) – Which plugins are used? > > >> – Which frameworks are used, if any? > > >> – Syncing, languages, support for disabled people, … – Something > > >> about problems – Development environment and tools used > > >> > > >> Thoughts? > > >> rjs > > >> > > >> Ryan J. Salva | Principal Program Manager Lead Visual Studio > > >> Tools for Apache Cordova rsa...@microsoft.com > > >> 206 612 5079 mobile > > >> > > >> > > >> > > >> -Original Message- > > >> From: Joerg Holz [mailto:h...@hamburg.de] > > >> Sent: Monday, October 19, 2015 8:11 AM > > >> To: dev@cordova.apache.org > > >> Subject: Re: [DISCUSS] Curating Apps > > >> > > >> thx for agreeing, but I see things different: > > >> > > >> – What means pretty good, who will decide this, how to measure? > > >> > > >> – What mean's popular, count of downloads? > > >> > > >> Cordova as project has to have a view from Cordova -> Apps and not > > >> from > > the other side. People have to say, why Cordova is good, Cordova has > > not to say why an app is good. > > >> > > >> > > >> And, yes, there is a need to have a blog or someting else for > > >> helping > > people and doing the small, but important, things. > > >> > > >> The most important thing is, that a lot of people starting with > > >> Cordova > > don’t know a lot about javascript, htlm and css and that is the reason > > why a lot of questions on SO are unanswered. > > >> > > >> > > >> Jörg > > >> > > >> > > >>> Am 19.10.2015 um 16:37 schrieb Parashuram N >: > > >>> > > >>> I agree with Joerg. The onl
[GitHub] cordova-plugin-device-motion pull request: Returning an OK PluginR...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: Update index.md
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: Update README.md
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: add JIRA issue tracker ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Update whitelist version to...
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/14 Update whitelist version to 2.0.0 to support older versions of the CLI Older versions of the CLI using cordova-app-hello-world template that references v1 of this plugin and adding a cordova-ios 4.x requirement will cause warnings to show up on existing projects. This is rated as one of the most voted cordova problems on stack overflow: http://stackoverflow.com/questions/30991828/cordova-plugin-whitelist-failed-asking-for-cordova-ios-4/30992364#30992364 I know it's just a warning but users get confused. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nikhilkh/cordova-plugin-whitelist version-bump Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-whitelist/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit 3078c72c36d1b081de5da7b367ebbded32b046d6 Author: Nikhil Khandelwal Date: 2015-10-24T00:52:27Z Update whitelist version to 2.0.0 as older versions of cordova CLI refernce v1 of this plugin and adding a cordova-ios 4.x requirement will cause warnings to show up on existing projects --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [DISCUSS] Curating Apps
I like Carlos' proposal. Reviewing PRs for these apps and judging by whatever criteria we finally decide (however objective/subjective) will not be worth our time. The volume of PRs over the last couple of weeks has been quite significant in this area. At the end of the day, we just need 5-10 showcase apps. -Nikhil -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Friday, October 23, 2015 5:37 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Curating Apps I think we make it more simpler, a PMC member to propose to add an app that he/she tried out and feels that it deserves to be show case as a good example of a great Cordova App. - remove the "add your app" - PMC members mails the list, that he evaluated the app and a short description on why to added and he is planning to added, and ask if someone opposed with a -1 - Like Joe said, we don't need a tons of Apps, just a few will satisfy the goal - The Apache way, if there are no -1 app get's added. On Wed, Oct 21, 2015 at 7:27 PM Dmitry Blotsky wrote: > Sounds like we’ve got some (potentially mutually exclusive) points: > - request detailed app descriptions from submitters > - curate based on detailed criteria > - curate based on loose criteria > - only accept blog posts, and get rid of the showcase > - just accept all requests > > Should this be a proposal on cordova-discuss? Or does someone feel > like we have a consensus? The ultimate goal is to have something that > displays good use of Cordova. I’d personally like to go with the > easiest way to achieve this. > > Kindly, > Dmitry > > > On Oct 19, 2015, at 1:28 PM, Joerg Holz wrote: > > > > I like the slogan: "submit something that helps other developers > > build a > better app“. > > > > I disagree about your app store points, staring, public store, we > > don’t > need that. > > > > And my opion is, that we should promote apps, which are clean or > > mostly > clean from any Framework. > > > > > > Joerg > > > > > >> Am 19.10.2015 um 20:11 schrieb Ryan J. Salva : > >> > >> The original goal for including the app showcase was to demonstrate > that developers can build rockstar-quality apps using Cordova. I agree > that by opening the invitation to anyone without a vetting process, we > fall short of the original goal. Indeed, we might end up with a throng > of hobo-quality apps using any technology under the sun :-) > >> > >> At the same time, I don't want to sign up any of the Cordova > >> committers > to navigate the prejudicial question of "what counts as good?" Thus, I > like Jörg's proposal that we raise the empirical bar for entry. App > developers need to prove not only that their app is a Cordova app, but > they have to submit something that helps other developers build a better app. > >> > >> Here's a straw man proposal intended to provoke response: > >> > >> Must appear in a public store > >> Must use Cordova > >> Minimum 4 start rating > >> Minimum 1,000 downloads > >> Submitter must write a 200+ word blog post answering – Which > >> platforms are supported (minimum two) – Which plugins are used? > >> – Which frameworks are used, if any? > >> – Syncing, languages, support for disabled people, … – Something > >> about problems – Development environment and tools used > >> > >> Thoughts? > >> rjs > >> > >> Ryan J. Salva | Principal Program Manager Lead Visual Studio > >> Tools for Apache Cordova rsa...@microsoft.com > >> 206 612 5079 mobile > >> > >> > >> > >> -Original Message- > >> From: Joerg Holz [mailto:h...@hamburg.de] > >> Sent: Monday, October 19, 2015 8:11 AM > >> To: dev@cordova.apache.org > >> Subject: Re: [DISCUSS] Curating Apps > >> > >> thx for agreeing, but I see things different: > >> > >> – What means pretty good, who will decide this, how to measure? > >> > >> – What mean's popular, count of downloads? > >> > >> Cordova as project has to have a view from Cordova -> Apps and not > >> from > the other side. People have to say, why Cordova is good, Cordova has > not to say why an app is good. > >> > >> > >> And, yes, there is a need to have a blog or someting else for > >> helping > people and doing the small, but important, things. > >> > >> The most important thing is, that a lot of people starting with > >> Cordova > don’t know a lot about javascript, htlm and css and that is the reason > why a lot of questions on SO are unanswered. > >> > >> > >> Jörg > >> > >> > >>> Am 19.10.2015 um 16:37 schrieb Parashuram N : > >>> > >>> I agree with Joerg. The only reason we have curated apps on the > >>> page > is to show people that Cordova can be used for building real apps. One > perception people have today is that Cordova and WebView is not fast > enough, or that serious applications are written in native languages. > >>> > >>> I think that any app on the showcase should emphasize 3 things > >>> > >>> - The app is pretty good, and feels like native and performs like one. > >>> - The app works ac
[GitHub] cordova-docs pull request: Add ReactEurope App to Showcase
Github user csantanapr closed the pull request at: https://github.com/apache/cordova-docs/pull/379 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Curating Apps
I think we make it more simpler, a PMC member to propose to add an app that he/she tried out and feels that it deserves to be show case as a good example of a great Cordova App. - remove the "add your app" - PMC members mails the list, that he evaluated the app and a short description on why to added and he is planning to added, and ask if someone opposed with a -1 - Like Joe said, we don't need a tons of Apps, just a few will satisfy the goal - The Apache way, if there are no -1 app get's added. On Wed, Oct 21, 2015 at 7:27 PM Dmitry Blotsky wrote: > Sounds like we’ve got some (potentially mutually exclusive) points: > - request detailed app descriptions from submitters > - curate based on detailed criteria > - curate based on loose criteria > - only accept blog posts, and get rid of the showcase > - just accept all requests > > Should this be a proposal on cordova-discuss? Or does someone feel like we > have a consensus? The ultimate goal is to have something that displays good > use of Cordova. I’d personally like to go with the easiest way to achieve > this. > > Kindly, > Dmitry > > > On Oct 19, 2015, at 1:28 PM, Joerg Holz wrote: > > > > I like the slogan: "submit something that helps other developers build a > better app“. > > > > I disagree about your app store points, staring, public store, we don’t > need that. > > > > And my opion is, that we should promote apps, which are clean or mostly > clean from any Framework. > > > > > > Joerg > > > > > >> Am 19.10.2015 um 20:11 schrieb Ryan J. Salva : > >> > >> The original goal for including the app showcase was to demonstrate > that developers can build rockstar-quality apps using Cordova. I agree that > by opening the invitation to anyone without a vetting process, we fall > short of the original goal. Indeed, we might end up with a throng of > hobo-quality apps using any technology under the sun :-) > >> > >> At the same time, I don't want to sign up any of the Cordova committers > to navigate the prejudicial question of "what counts as good?" Thus, I like > Jörg's proposal that we raise the empirical bar for entry. App developers > need to prove not only that their app is a Cordova app, but they have to > submit something that helps other developers build a better app. > >> > >> Here's a straw man proposal intended to provoke response: > >> > >> Must appear in a public store > >> Must use Cordova > >> Minimum 4 start rating > >> Minimum 1,000 downloads > >> Submitter must write a 200+ word blog post answering > >> – Which platforms are supported (minimum two) > >> – Which plugins are used? > >> – Which frameworks are used, if any? > >> – Syncing, languages, support for disabled people, … > >> – Something about problems > >> – Development environment and tools used > >> > >> Thoughts? > >> rjs > >> > >> Ryan J. Salva | Principal Program Manager Lead > >> Visual Studio Tools for Apache Cordova > >> rsa...@microsoft.com > >> 206 612 5079 mobile > >> > >> > >> > >> -Original Message- > >> From: Joerg Holz [mailto:h...@hamburg.de] > >> Sent: Monday, October 19, 2015 8:11 AM > >> To: dev@cordova.apache.org > >> Subject: Re: [DISCUSS] Curating Apps > >> > >> thx for agreeing, but I see things different: > >> > >> – What means pretty good, who will decide this, how to measure? > >> > >> – What mean's popular, count of downloads? > >> > >> Cordova as project has to have a view from Cordova -> Apps and not from > the other side. People have to say, why Cordova is good, Cordova has not to > say why an app is good. > >> > >> > >> And, yes, there is a need to have a blog or someting else for helping > people and doing the small, but important, things. > >> > >> The most important thing is, that a lot of people starting with Cordova > don’t know a lot about javascript, htlm and css and that is the reason why > a lot of questions on SO are unanswered. > >> > >> > >> Jörg > >> > >> > >>> Am 19.10.2015 um 16:37 schrieb Parashuram N : > >>> > >>> I agree with Joerg. The only reason we have curated apps on the page > is to show people that Cordova can be used for building real apps. One > perception people have today is that Cordova and WebView is not fast > enough, or that serious applications are written in native languages. > >>> > >>> I think that any app on the showcase should emphasize 3 things > >>> > >>> - The app is pretty good, and feels like native and performs like one. > >>> - The app works across multiple platforms, ensuring code sharing > >>> - The app is popular, something that our users may have come across, > or would like to try. > >>> > >>> While it would be great to talk about how the app was built, I fear > that it would be hard to get apps to write all that information. It would > actually be awesome if we have blog posts that has articles from these app > authors, describing their experience with writing Cordova apps. > >>> > >>> > >>> > >>> On 10/19/15, 5:46 AM, "Joerg Holz" wrote: > >>> > I don’t like the phonegap app pa
[GitHub] cordova-coho pull request: Adding docs around JIRA issue triage
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-coho/pull/97#issuecomment-150727908 I made some more tweaks based on feedback. Please take another look. Thanks! What should we do with auto-assignment behavior? https://issues.apache.org/jira/plugins/servlet/project-config/CB/components I believe it primarily affects @purplecabbage for Windows & WP8 and @TimBarham for Browser & CordovaServe. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] CocoaPods dependencies for iOS plugins
Send PR's or comment on a line in a commit. I think. Not sure what you mean -- the purpose of Cocoapods is to install/uninstall a pod. It is thus a plugin add/install step. On Fri, Oct 23, 2015 at 5:12 PM, Carlos Santana wrote: > How does this discussion repo works again? > Do we create a github issue pointing to the proposal to have the > discussion there with comments? > > One thing I notice is that engine the way they work today this will not > work, since we want to allow the plugin to be installed, and cocoapod is > only need it on compile step not plugin add/install step. > > > > On Tue, Oct 20, 2015 at 6:05 AM Vladimir Kotikov (Akvelon) < > v-vlk...@microsoft.com> wrote: > >> Hey, guys. >> >> After ios refactoring the handling definitely will be a part >> of platform. As for tag, I guess it make sense to keep this logic >> in LIB and let cordova itself check availability of cocoapods/nuget. >> >> - >> Best regards, Vladimir >> >> -Original Message- >> From: Steven Gill [mailto:stevengil...@gmail.com] >> Sent: Tuesday, October 20, 2015 2:36 AM >> To: dev@cordova.apache.org >> Subject: Re: [DISCUSS] CocoaPods dependencies for iOS plugins >> >> Sweet! Yeah lets see where this lands after the refactor. Dependencies are >> still handled by lib as far as I know. Not sure about framework but I >> assume the same. Vladimir would know about where that code will live after >> the refactor. >> >> Engine + framework tag looks good. Engine tag will have to be extended to >> actually fetch cocoapods + nuget I imagine. >> >> On Mon, Oct 19, 2015 at 4:23 PM, Shazron wrote: >> >> > This is not a platform specific issue, at least for cordova-ios, and >> > is the domain of the cordova-lib/cli currently (I think the >> > cordova-lib re-factor changes this?) >> > >> > There will be a cordova-discuss doc, but the gist of it is: >> > >> > >> > >> > >> > >> > >> > > > src="path/to/mynu.nuspec" type="nuspec" /> >> > >> > The above use existing documented attributes for both the and >> > tags: >> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcordo >> > va.apache.org%2fdocs%2fen%2f5.1.1%2fplugin_ref%2fspec.html&data=01%7c0 >> > 1%7cv-vlkoti%40064d.mgd.microsoft.com%7c5e3acbf36e3e43b1eb4d08d2d8de29 >> > 40%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=MVFyYNFESBtyyUxn2mvK5% >> > 2bnOxizyDMAP2WIaCWxJwUM%3d >> > >> > >> > On Sat, Oct 17, 2015 at 11:56 PM, Steven Gill >> > wrote: >> > > At the Cordova F2F, everyone seemed to agree that we should bring >> > CocoaPods >> > > support to plugins as dependencies for iOS. >> > > >> > > Cordova-android currently uses Gradle as a way to enable external >> > > dependency resolution for plugins using the framework tag. >> > > >> > > A suggestion about using the engine tag to fetch cocoapods-cli (mac) >> > > & NuGet (windows) followed by using the framework tag was discussed. >> > > >> > > The minutes[1] show Carlos, Shaz and Raghav as looking into the design. >> > > Someone should write up a proposal on cordova-discuss[2] and create >> > > the issues. Post them in this thread. >> > > >> > > This shouldn't take priority over cordova-ios 4 issues. >> > > >> > > [1] >> > > >> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdocs. >> > google.com%2fdocument%2fd%2f1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCk >> > bU%2fedit%3fusp%3dsharing&data=01%7c01%7cv-vlkoti%40064d.mgd.microsoft >> > .com%7c5e3acbf36e3e43b1eb4d08d2d8de2940%7c72f988bf86f141af91ab2d7cd011 >> > db47%7c1&sdata=GPpiC70BVEDo4gvljKi6OqXsdGUOLPHmhaDKXH6P7kQ%3d >> > > [2] >> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit >> > > hub.com%2fcordova%2fcordova-discuss&data=01%7c01%7cv-vlkoti%40064d.m >> > > gd.microsoft.com%7c5e3acbf36e3e43b1eb4d08d2d8de2940%7c72f988bf86f141 >> > > af91ab2d7cd011db47%7c1&sdata=t4gpBVojZ3H94gCLRboa%2fvkHlBCoVxZsWuiCH >> > > TVkylo%3d >> > >> > - >> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> > For additional commands, e-mail: dev-h...@cordova.apache.org >> > >> > >> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42926950
--- Diff: src/ios/CDVFileTransfer.m ---
@@ -552,6 +552,8 @@ -
(void)connectionDidFinishLoading:(NSURLConnection*)connection
if (self.direction == CDV_TRANSFER_UPLOAD) {
uploadResponse = [[NSString alloc] initWithData:self.responseData
encoding:NSUTF8StringEncoding];
+if (uploadResponse == nil)
+uploadResponse = [[NSString alloc] initWithData:
self.responseData encoding:NSISOLatin1StringEncoding];
--- End diff --
It does not look like there is a straightforward way to support this in
Android, Windows. Perhaps we should make iOS itself consistent - in terms of
handling both `upload` & `download` for this encoding. Document the limited
support only in iOS, and file a `Feature Request` JIRA to add support in
Windows, Android. Also, we need to add a test case. @codable Would you be able
to help with some of this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...
Github user codable commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42926656
--- Diff: src/ios/CDVFileTransfer.m ---
@@ -552,6 +552,8 @@ -
(void)connectionDidFinishLoading:(NSURLConnection*)connection
if (self.direction == CDV_TRANSFER_UPLOAD) {
uploadResponse = [[NSString alloc] initWithData:self.responseData
encoding:NSUTF8StringEncoding];
+if (uploadResponse == nil)
+uploadResponse = [[NSString alloc] initWithData:
self.responseData encoding:NSISOLatin1StringEncoding];
--- End diff --
Did you try encoding Windows-1252 or CP-1252 on windows? Sorry, I don't
have such environment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] CocoaPods dependencies for iOS plugins
How does this discussion repo works again? Do we create a github issue pointing to the proposal to have the discussion there with comments? One thing I notice is that engine the way they work today this will not work, since we want to allow the plugin to be installed, and cocoapod is only need it on compile step not plugin add/install step. On Tue, Oct 20, 2015 at 6:05 AM Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Hey, guys. > > After ios refactoring the handling definitely will be a part > of platform. As for tag, I guess it make sense to keep this logic > in LIB and let cordova itself check availability of cocoapods/nuget. > > - > Best regards, Vladimir > > -Original Message- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Tuesday, October 20, 2015 2:36 AM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] CocoaPods dependencies for iOS plugins > > Sweet! Yeah lets see where this lands after the refactor. Dependencies are > still handled by lib as far as I know. Not sure about framework but I > assume the same. Vladimir would know about where that code will live after > the refactor. > > Engine + framework tag looks good. Engine tag will have to be extended to > actually fetch cocoapods + nuget I imagine. > > On Mon, Oct 19, 2015 at 4:23 PM, Shazron wrote: > > > This is not a platform specific issue, at least for cordova-ios, and > > is the domain of the cordova-lib/cli currently (I think the > > cordova-lib re-factor changes this?) > > > > There will be a cordova-discuss doc, but the gist of it is: > > > > > > > > > > > > > > > src="path/to/mynu.nuspec" type="nuspec" /> > > > > The above use existing documented attributes for both the and > > tags: > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcordo > > va.apache.org%2fdocs%2fen%2f5.1.1%2fplugin_ref%2fspec.html&data=01%7c0 > > 1%7cv-vlkoti%40064d.mgd.microsoft.com%7c5e3acbf36e3e43b1eb4d08d2d8de29 > > 40%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=MVFyYNFESBtyyUxn2mvK5% > > 2bnOxizyDMAP2WIaCWxJwUM%3d > > > > > > On Sat, Oct 17, 2015 at 11:56 PM, Steven Gill > > wrote: > > > At the Cordova F2F, everyone seemed to agree that we should bring > > CocoaPods > > > support to plugins as dependencies for iOS. > > > > > > Cordova-android currently uses Gradle as a way to enable external > > > dependency resolution for plugins using the framework tag. > > > > > > A suggestion about using the engine tag to fetch cocoapods-cli (mac) > > > & NuGet (windows) followed by using the framework tag was discussed. > > > > > > The minutes[1] show Carlos, Shaz and Raghav as looking into the design. > > > Someone should write up a proposal on cordova-discuss[2] and create > > > the issues. Post them in this thread. > > > > > > This shouldn't take priority over cordova-ios 4 issues. > > > > > > [1] > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdocs. > > google.com%2fdocument%2fd%2f1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCk > > bU%2fedit%3fusp%3dsharing&data=01%7c01%7cv-vlkoti%40064d.mgd.microsoft > > .com%7c5e3acbf36e3e43b1eb4d08d2d8de2940%7c72f988bf86f141af91ab2d7cd011 > > db47%7c1&sdata=GPpiC70BVEDo4gvljKi6OqXsdGUOLPHmhaDKXH6P7kQ%3d > > > [2] > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit > > > hub.com%2fcordova%2fcordova-discuss&data=01%7c01%7cv-vlkoti%40064d.m > > > gd.microsoft.com%7c5e3acbf36e3e43b1eb4d08d2d8de2940%7c72f988bf86f141 > > > af91ab2d7cd011db47%7c1&sdata=t4gpBVojZ3H94gCLRboa%2fvkHlBCoVxZsWuiCH > > > TVkylo%3d > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
Re: [VOTE] Cordova-common release
+1 * Ran coho audit-license-headers over the repo * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran coho verify-archive successfully. On Fri, Oct 23, 2015 at 1:34 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Please review and vote on this Cordova-common Release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-9850 > > Both tools have been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/CB-9850/ > > The packages were published from their corresponding git tags: > cordova-lib: common-0.1.0 (6ec023d295) > > Upon a successful vote I will upload the archives to dist/, publish them > to NPM, and post the corresponding blog post. > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the repo > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ensured test were passing when repo was tagged > > - > Best regards, Vladimir > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface
Let's go ahead with renaming CordovaWebView => CordovaWebInterface, and
keeping around a CordovaWebView object so that nothing breaks.
We should also deprecate CordovaWebView, and document the change so that
people who are using it have some notice, and people who are new know what
NOT to use.
We don't have to remove it immediately, or even on our next major bump,
just sometime down the road.
If we don't move forward we will just be stuck with it forever ...
My team is hiring!
@purplecabbage
risingj.com
On Fri, Oct 23, 2015 at 1:19 PM, Nikhil Khandelwal
wrote:
> I understand that it won't break currently and it will break on the next
> major version bump. IMHO it's just not worth it for this name change.
>
> Historically, we've had challenges with giving sufficient notice from
> breaking changes. I would avoid them unless absolutely needed.
>
> -Nikhil
>
> -Original Message-
> From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> Sent: Thursday, October 22, 2015 12:14 PM
> To: dev@cordova.apache.org
> Subject: Re: [Android][Discuss] Change name of CordovaWebView to
> CordovaWebInterface
>
> Let's just be clear that in Cordova Android 5.0 nothing will break.
> The interface CordovaWebView has been renamed to CordovaWebInterface but
> that won't break anything as we introduce a new class called, wait for it,
> CordovaWebView that extends the new CordovaWebInterface. This way all
> current code that uses CordovaWebView will continue to work without
> modification.
>
> If we start updating our documentation, i.e. how to write a CordovaPlugin
> for Android, and give people plenty of notice that this is going to happen
> then I don't see why we wouldn't want to move forward.
>
> That's just my 2 cents.
>
> Simon Mac Donald
>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald&data=01%7c01%7cnikhilkh%40microsoft.com%7caf6077fb55224d7b1d2c08d2db1508fe%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=50aLt1e0sp9z4TrrSBiMnAaBdSj1RrUuIEcnPaHGD1U%3d
>
>
> On Wed, Oct 21, 2015 at 6:13 PM, Nikhil Khandelwal
> wrote:
> > Thanks, Joe for the summary of the impact later.
> >
> > -1. IMO - a naming change is no worth the effort and future breakage.
> >
> > -Nikhil
> >
> > -Original Message-
> > From: Joe Bowser [mailto:bows...@gmail.com]
> > Sent: Wednesday, October 21, 2015 11:06 AM
> > To: dev
> > Subject: Re: [Android][Discuss] Change name of CordovaWebView to
> > CordovaWebInterface
> >
> > Yes, I do. I had to search through mobilespec, but here it is:
> >
> > private static final boolean HAS_BUILT_IN_SPLASH_SCREEN =
> > Integer.valueOf(CordovaWebView.CORDOVA_VERSION.split("\\.")[0]) < 4;
> >
> > Also, every plugin that calls initialize requires a CordovaWebView
> passed into it. That's a pretty big change. I also haven't touched on
> Third Party WebViews like Crosswalk, which would have to do the change.
> >
> >
> > On Tue, Oct 20, 2015 at 1:59 PM, Steven Gill
> wrote:
> >
> >> Joe, do you have a small example of what could break with this change.
> >> What is a usecase for someone to reference CordovaWebView
> >>
> >> On Tue, Oct 20, 2015 at 1:38 PM, Joe Bowser wrote:
> >>
> >> > I'll pull this in at the end of the day. This small change may
> >> > break
> >> stuff
> >> > further down the road, so people should comment on it now.
> >> >
> >> > On Tue, Oct 20, 2015 at 1:37 PM, Joe Bowser
> wrote:
> >> >
> >> > > OK, Going to pull this in.
> >> > >
> >> > > On Tue, Oct 20, 2015 at 10:02 AM, Simon MacDonald <
> >> > > simon.macdon...@gmail.com> wrote:
> >> > >
> >> > >> +1 from me as I'm the one that initiated the PR.
> >> > >>
> >> > >> Simon Mac Donald
> >> > >> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2f
> >> > >> h
> >> > >> i.im%2fsimonmacdonald&data=01%7c01%7cnikhilkh%40microsoft.com%7c
> >> > >> 8
> >> > >> 619031b1eef484bd48508d2da425e41%7c72f988bf86f141af91ab2d7cd011db
> >> > >> 4 7%7c1&sdata=IXoWw2z2L7EhCorf4kK4EJ7Ux89hdUjmP%2bKsF%2bJdwf0%3d
> >> > >>
> >> > >> On Tue, Oct 20, 2015 at 12:23 PM, Darryl Pogue
> >> > >>
> >> > wrote:
> >> > >>
> >> > >> > +1 for doing this with the major version bump
> >> > >> >
> >> > >> > On 20 October 2015 at 09:15, Joe Bowser
> wrote:
> >> > >> >
> >> > >> > > Hey
> >> > >> > >
> >> > >> > > We're close to getting 5.0.x ready for release, but I want
> >> > >> > > to add
> >> > one
> >> > >> > more
> >> > >> > > pull request:
> >> > >> > >
> >> > >> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%
> >> > >> > > 2
> >> > >> > > f%2fgithub.com%2fapache%2fcordova-android%2fpull%2f227&data=
> >> > >> > > 0
> >> > >> > > 1%7c01%7cnikhilkh%40microsoft.com%7c8619031b1eef484bd48508d2
> >> > >> > > d
> >> > >> > > a425e41%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=w5TYcbC
> >> > >> > > H %2fhLIhbrZImOsVFgGMfp%2bIk0Dl6Qk6ADzMVc%3d
> >> > >> > >
> >> > >> > > This is a trivial pull request, but I want to get buy-in
> >> > >> > > from the
> >> > list
> >> > >> > for
> >> > >> >
Re: npm install on cordova platform/plugin add
Issue: https://issues.apache.org/jira/browse/CB-9858 On Fri, Oct 23, 2015 at 1:05 PM, Mefire O. wrote: > Ah, it makes sense in both platforms and plugins. > > Thanks, > > -Original Message- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Thursday, October 22, 2015 4:46 PM > To: dev@cordova.apache.org > Subject: Re: npm install on cordova platform/plugin add > > Yeah. Cordova-common is the main reason for platforms. IMO It doesn't make > sense to check it into platforms. It makes sense to have it as a > bundleDependency but if you cordova platform add it via git url, the > dependency won't be around. Hence the npm install On Oct 22, 2015 4:24 PM, > "Darryl Pogue" wrote: > > > One example would be the ios-sim and ios-deploy node modules that the > > iOS platform needs for launching the simulator and deploying to a device. > > Currently these are bundled dependencies and checked in to git. > > > > Another example is the Platform API that's been added to > > cordova-android, which depends on cordova-common. > > > > On 22 October 2015 at 16:17, Mefire O. wrote: > > > > > I can definitely see the case for adding deps specified in plugins' > > > package.json, which is to make 'tools plugins' development easier. > > > > > > But I don't understand the use case for platforms. What scenario are > > > we trying to fulfill there ? > > > > > > Thanks, > > > Omar Mefire > > > > > > -Original Message- > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > Sent: Thursday, October 22, 2015 2:54 PM > > > To: dev@cordova.apache.org > > > Subject: npm install on cordova platform/plugin add > > > > > > We discussed running `npm install` on `cordova plugin add` at the > > > Cordova F2F. > > > > > > I want to see how people feel about this. > > > > > > For installing a platform via git url, the dependency won't exist > > > unless we check it in to the repo. This can cause problems. > > > bundleDependencies > > are > > > only useful for installing via npm > > > > > > For platforms: > > > > > > i believe this is how it would work: > > > > > > Adding via `npm` > > > > > > 1) `cordova platform add ios` > > > > > > 2) cordova fetches `cordova-ios` from npm, adds it to global cordova > > > directory > > > > > > 3) I'd like tools to run `npm install` , but these deps are most > > > likely already included in fetched version due to > > > `bundleDependecies`. So it wouldn't do anything > > > > > > Adding locally > > > > > > 1) `cordova platform add /YourLocalCordovaIOS` > > > > > > 2) cordova uses your `cordova-ios` > > > > > > 3) tools to run `npm install` which should have no impact (Assuming > > you've > > > done it manually) > > > > > > Adding via Git url > > > > > > 1) `cordova platform add > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu > > b.com%2fapache%2fcordova-ios%60&data=01%7c01%7commenjik%40microsoft.co > > m%7c8b52f2866d674b08c10b08d2db2b5347%7c72f988bf86f141af91ab2d7cd011db4 > > 7%7c1&sdata=zdpqgA08JQxJ4h5DpWCpBiggl1RTZu%2fMN8gE%2fbXHPG8%3d > > > > > > 2) cordova clones it (i believe into global cordova directory) > > > > > > 3) tools to run `npm install` which is important because packages > > > aren't bundled unless we manually check them in > > > > > > For Plugins > > > It would allow plugins to have 3rd party npm dependencies and not > > > have to check them in. This will be even more important once we > > > switch to browserify method. > > > > > > Thoughts? > > > > > >
[GitHub] cordova-windows pull request: remove publisherId since its overrid...
Github user pke commented on the pull request: https://github.com/apache/cordova-windows/pull/127#issuecomment-150705467 There seem to be more places where this needs to be removed. Will create a more complete PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Replace the "CordovaApp" description...
Github user pke closed the pull request at: https://github.com/apache/cordova-windows/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: remove publisherId since its overrid...
Github user pke closed the pull request at: https://github.com/apache/cordova-windows/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Replace the "CordovaApp" description...
Github user pke commented on the pull request: https://github.com/apache/cordova-windows/pull/128#issuecomment-150705390 Hmm something wrong with that. Have to test locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Replace the "CordovaApp" description...
GitHub user pke opened a pull request: https://github.com/apache/cordova-windows/pull/128 Replace the "CordovaApp" description with the real description from config.xml The description was read from the `config.xml` but never used to modify the apps manifest files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pke/cordova-windows patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/128.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #128 commit f86740a6765d9071711125f396b555ca6817fad4 Author: Philipp Kursawe Date: 2015-10-23T22:04:22Z Replace the "CordovaApp" description with the real description from config.xml The description was read from the `config.xml` but never used to modify the apps manifest files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ubuntu pull request: CB-9836 Add .gitattributes to prevent...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ubuntu/pull/17 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-ubuntu CB-9836 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ubuntu/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit e22b0358be901224cf762f947f7df62bbd73ab2c Author: daserge Date: 2015-10-23T22:00:33Z CB-9836 Add .gitattributes to prevent CRLF line endings in repos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-webos pull request: CB-9836 Add .gitattributes to prevent ...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-webos/pull/6 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-webos CB-9836 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-webos/pull/6.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6 commit 61ecf1b53657ec7674c03c45a709fef65aa41a17 Author: daserge Date: 2015-10-23T21:57:51Z CB-9836 Add .gitattributes to prevent CRLF line endings in repos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9490 Fixed cleanup function
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/115#issuecomment-150703173 @cojomojo Won't this still have the problem you found when you filed this? https://issues.apache.org/jira/browse/CB-9506 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: remove publisherId since its overrid...
GitHub user pke opened a pull request: https://github.com/apache/cordova-windows/pull/127 remove publisherId since its overridden by the certficate during build 1. The publisherId set here is __always__ overridden by the `CN` from the projects associated certificate. That is by default, the Cordova certificate that has `CN=The Cordova Team`. Therefor the resulting `AppxManifest.xml` will always have `Publisher="CN=The Cordova Team"` set regardless of what one puts into `publisherId`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pke/cordova-windows patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/127.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #127 commit 62c7eb1eab1eeb0e47ee8f3c8dbeaae7cd26e6bb Author: Philipp Kursawe Date: 2015-10-23T21:58:46Z remove publisherId since its overridden by the certficate during build 1. The publisherId set here is __always__ overridden by the `CN` from the projects associated certificate. That is by default, the Cordova certificate that has `CN=The Cordova Team`. Therefor the resulting `AppxManifest.xml` will always have `Publisher="CN=The Cordova Team"` set regardless of what one puts into `publisherId`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request: CB-9836 Add .gitattributes to preven...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-browser/pull/22 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-browser CB-9836 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-browser/pull/22.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22 commit 298a9ffb4a400216ea7adf9dbed3eb1cb89e3c25 Author: daserge Date: 2015-10-23T21:52:10Z CB-9836 Add .gitattributes to prevent CRLF line endings in repos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: CB-9836 Add .gitattributes to prevent CR...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-wp8/pull/89 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-wp8 CB-9836 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-wp8/pull/89.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #89 commit 9db91d4560d98a08367519ce4de56553d3b0cbe9 Author: daserge Date: 2015-10-23T21:50:29Z CB-9836 Add .gitattributes to prevent CRLF line endings in repos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-blackberry pull request: CB-9836 Add .gitattributes to pre...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-blackberry/pull/193 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-blackberry CB-9836 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-blackberry/pull/193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #193 commit 9a184e7e8d81fa5ca92ca210e1d91c52e357ac28 Author: daserge Date: 2015-10-23T21:45:06Z CB-9836 Add .gitattributes to prevent CRLF line endings in repos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Remove misleading reference to "publish...
GitHub user pke opened a pull request: https://github.com/apache/cordova-docs/pull/402 Remove misleading reference to "publisherId" cause it is ignored The only way to override the `Publisher` value in the generated `AppxManifest.xml` is to provide a custom signing certificate. Merely setting the "publisherId" does not do anything. I've tried it a whole day. Only when I set a custom signing certificate my applications manifest looked like it should. And then setting "publisherId" to anything did not affect how the resulting manifest file looked. So I propose to remove the value from the docs (and it should also be removed from the Cordova Windows plugin). You can merge this pull request into a Git repository by running: $ git pull https://github.com/pke/cordova-docs patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/402.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #402 commit 62b148bb62714676aff0c02b7bd719a6746a7e24 Author: Philipp Kursawe Date: 2015-10-23T21:45:51Z Remove misleading reference to "publisherId" cause it is ignored The only way to override the `Publisher` value in the generated `AppxManifest.xml` is to provide a custom signing certificate. Merely setting the "publisherId" does not do anything. I've tried it a whole day. Only when I set a custom signing certificate my applications manifest looked like it should. And then setting "publisherId" to anything did not affect how the resulting manifest file looked. So I propose to remove the value from the docs (and it should also be removed from the Cordova Windows plugin). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9836 Add .gitattributes to prevent CR...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/173 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios CB-9836 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/173.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #173 commit dc1783f68bf5629536fccb55ec4f6c5d8d2a5db3 Author: daserge Date: 2015-10-23T21:33:17Z CB-9836 Add .gitattributes to prevent CRLF line endings in repos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Tools Release
Okay. I will start work on this release Monday unless anyone has concerns. -Steve On Fri, Oct 23, 2015 at 12:57 PM, Nikhil Khandelwal wrote: > +1 - I'm hoping we'll release iOS as well before the next CLI release. > > -Nikhil > > -Original Message- > From: Carlos Santana [mailto:csantan...@gmail.com] > Sent: Friday, October 23, 2015 12:48 PM > To: dev@cordova.apache.org > Subject: [DISCUSS] Tools Release > > I think we should release a version of the CLI now, from what Steve told > me there is a lot changes going in, and also contains the switch to use npm > instead of CPR, and other changes around npm3 and nodejs4 > > This will allow for trains to move forward and get feedback on the > releases. > > Propose sequence: > 1. Release CLI > 2. Release Android > 3. Release Plugins > 4. Release CLI with latest released platformed pinned > > Rinse and repeat while singing choo choo ! >
[GitHub] cordova-windows pull request: CB-9836 Add .gitattributes to preven...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/126 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-9836 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/126.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #126 commit 429cdb25101228061ad62e3effd8c9211c7da6a4 Author: daserge Date: 2015-10-23T21:31:26Z CB-9836 Add .gitattributes to prevent CRLF line endings in repos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9836 Add .gitattributes to prevent CR...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-cli/pull/225 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-cli CB-9836 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/225.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #225 commit 4fa55c2156e15fde6dd21965acce8451a524f872 Author: daserge Date: 2015-10-23T21:25:17Z CB-9836 Add .gitattributes to prevent CRLF line endings in repos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9836 Add .gitattributes to prevent C...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-coho/pull/98 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-coho CB-9836 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/98.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #98 commit 6c67f0cca13b509ae2f3d51eafbdcb82ef3af6ba Author: daserge Date: 2015-10-23T21:20:29Z CB-9836 Add .gitattributes to prevent CRLF line endings in repos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Marshmallow/Cordova Android 5....
Github user infil00p closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Marshmallow/Cordova Android 5....
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/128#issuecomment-150695843 Closing pull request. Code has now been rebased and merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [Android][Discuss] Change name of CordovaWebView to CordovaWebInterface
I understand that it won't break currently and it will break on the next major
version bump. IMHO it's just not worth it for this name change.
Historically, we've had challenges with giving sufficient notice from breaking
changes. I would avoid them unless absolutely needed.
-Nikhil
-Original Message-
From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
Sent: Thursday, October 22, 2015 12:14 PM
To: dev@cordova.apache.org
Subject: Re: [Android][Discuss] Change name of CordovaWebView to
CordovaWebInterface
Let's just be clear that in Cordova Android 5.0 nothing will break.
The interface CordovaWebView has been renamed to CordovaWebInterface but that
won't break anything as we introduce a new class called, wait for it,
CordovaWebView that extends the new CordovaWebInterface. This way all current
code that uses CordovaWebView will continue to work without modification.
If we start updating our documentation, i.e. how to write a CordovaPlugin for
Android, and give people plenty of notice that this is going to happen then I
don't see why we wouldn't want to move forward.
That's just my 2 cents.
Simon Mac Donald
https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%2fsimonmacdonald&data=01%7c01%7cnikhilkh%40microsoft.com%7caf6077fb55224d7b1d2c08d2db1508fe%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=50aLt1e0sp9z4TrrSBiMnAaBdSj1RrUuIEcnPaHGD1U%3d
On Wed, Oct 21, 2015 at 6:13 PM, Nikhil Khandelwal
wrote:
> Thanks, Joe for the summary of the impact later.
>
> -1. IMO - a naming change is no worth the effort and future breakage.
>
> -Nikhil
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Wednesday, October 21, 2015 11:06 AM
> To: dev
> Subject: Re: [Android][Discuss] Change name of CordovaWebView to
> CordovaWebInterface
>
> Yes, I do. I had to search through mobilespec, but here it is:
>
> private static final boolean HAS_BUILT_IN_SPLASH_SCREEN =
> Integer.valueOf(CordovaWebView.CORDOVA_VERSION.split("\\.")[0]) < 4;
>
> Also, every plugin that calls initialize requires a CordovaWebView passed
> into it. That's a pretty big change. I also haven't touched on Third Party
> WebViews like Crosswalk, which would have to do the change.
>
>
> On Tue, Oct 20, 2015 at 1:59 PM, Steven Gill wrote:
>
>> Joe, do you have a small example of what could break with this change.
>> What is a usecase for someone to reference CordovaWebView
>>
>> On Tue, Oct 20, 2015 at 1:38 PM, Joe Bowser wrote:
>>
>> > I'll pull this in at the end of the day. This small change may
>> > break
>> stuff
>> > further down the road, so people should comment on it now.
>> >
>> > On Tue, Oct 20, 2015 at 1:37 PM, Joe Bowser wrote:
>> >
>> > > OK, Going to pull this in.
>> > >
>> > > On Tue, Oct 20, 2015 at 10:02 AM, Simon MacDonald <
>> > > simon.macdon...@gmail.com> wrote:
>> > >
>> > >> +1 from me as I'm the one that initiated the PR.
>> > >>
>> > >> Simon Mac Donald
>> > >> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2f
>> > >> h
>> > >> i.im%2fsimonmacdonald&data=01%7c01%7cnikhilkh%40microsoft.com%7c
>> > >> 8
>> > >> 619031b1eef484bd48508d2da425e41%7c72f988bf86f141af91ab2d7cd011db
>> > >> 4 7%7c1&sdata=IXoWw2z2L7EhCorf4kK4EJ7Ux89hdUjmP%2bKsF%2bJdwf0%3d
>> > >>
>> > >> On Tue, Oct 20, 2015 at 12:23 PM, Darryl Pogue
>> > >>
>> > wrote:
>> > >>
>> > >> > +1 for doing this with the major version bump
>> > >> >
>> > >> > On 20 October 2015 at 09:15, Joe Bowser wrote:
>> > >> >
>> > >> > > Hey
>> > >> > >
>> > >> > > We're close to getting 5.0.x ready for release, but I want
>> > >> > > to add
>> > one
>> > >> > more
>> > >> > > pull request:
>> > >> > >
>> > >> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%
>> > >> > > 2
>> > >> > > f%2fgithub.com%2fapache%2fcordova-android%2fpull%2f227&data=
>> > >> > > 0
>> > >> > > 1%7c01%7cnikhilkh%40microsoft.com%7c8619031b1eef484bd48508d2
>> > >> > > d
>> > >> > > a425e41%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=w5TYcbC
>> > >> > > H %2fhLIhbrZImOsVFgGMfp%2bIk0Dl6Qk6ADzMVc%3d
>> > >> > >
>> > >> > > This is a trivial pull request, but I want to get buy-in
>> > >> > > from the
>> > list
>> > >> > for
>> > >> > > doing the rename for CordovaWebView class to be changed
>> > >> > > before we
>> > >> start
>> > >> > > deprecating it. This means we're probably going to remove
>> > >> > > the
>> shim
>> > in
>> > >> > the
>> > >> > > next major version.
>> > >> > >
>> > >> > > Thoughts?
>> > >> > >
>> > >> > > Joe
>> > >> > >
>> > >> >
>> > >>
>> > >
>> > >
>> >
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
RE: npm install on cordova platform/plugin add
Ah, it makes sense in both platforms and plugins. Thanks, -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, October 22, 2015 4:46 PM To: dev@cordova.apache.org Subject: Re: npm install on cordova platform/plugin add Yeah. Cordova-common is the main reason for platforms. IMO It doesn't make sense to check it into platforms. It makes sense to have it as a bundleDependency but if you cordova platform add it via git url, the dependency won't be around. Hence the npm install On Oct 22, 2015 4:24 PM, "Darryl Pogue" wrote: > One example would be the ios-sim and ios-deploy node modules that the > iOS platform needs for launching the simulator and deploying to a device. > Currently these are bundled dependencies and checked in to git. > > Another example is the Platform API that's been added to > cordova-android, which depends on cordova-common. > > On 22 October 2015 at 16:17, Mefire O. wrote: > > > I can definitely see the case for adding deps specified in plugins' > > package.json, which is to make 'tools plugins' development easier. > > > > But I don't understand the use case for platforms. What scenario are > > we trying to fulfill there ? > > > > Thanks, > > Omar Mefire > > > > -Original Message- > > From: Steven Gill [mailto:stevengil...@gmail.com] > > Sent: Thursday, October 22, 2015 2:54 PM > > To: dev@cordova.apache.org > > Subject: npm install on cordova platform/plugin add > > > > We discussed running `npm install` on `cordova plugin add` at the > > Cordova F2F. > > > > I want to see how people feel about this. > > > > For installing a platform via git url, the dependency won't exist > > unless we check it in to the repo. This can cause problems. > > bundleDependencies > are > > only useful for installing via npm > > > > For platforms: > > > > i believe this is how it would work: > > > > Adding via `npm` > > > > 1) `cordova platform add ios` > > > > 2) cordova fetches `cordova-ios` from npm, adds it to global cordova > > directory > > > > 3) I'd like tools to run `npm install` , but these deps are most > > likely already included in fetched version due to > > `bundleDependecies`. So it wouldn't do anything > > > > Adding locally > > > > 1) `cordova platform add /YourLocalCordovaIOS` > > > > 2) cordova uses your `cordova-ios` > > > > 3) tools to run `npm install` which should have no impact (Assuming > you've > > done it manually) > > > > Adding via Git url > > > > 1) `cordova platform add > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu > b.com%2fapache%2fcordova-ios%60&data=01%7c01%7commenjik%40microsoft.co > m%7c8b52f2866d674b08c10b08d2db2b5347%7c72f988bf86f141af91ab2d7cd011db4 > 7%7c1&sdata=zdpqgA08JQxJ4h5DpWCpBiggl1RTZu%2fMN8gE%2fbXHPG8%3d > > > > 2) cordova clones it (i believe into global cordova directory) > > > > 3) tools to run `npm install` which is important because packages > > aren't bundled unless we manually check them in > > > > For Plugins > > It would allow plugins to have 3rd party npm dependencies and not > > have to check them in. This will be even more important once we > > switch to browserify method. > > > > Thoughts? > > >
RE: [DISCUSS] Tools Release
+1 - I'm hoping we'll release iOS as well before the next CLI release. -Nikhil -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Friday, October 23, 2015 12:48 PM To: dev@cordova.apache.org Subject: [DISCUSS] Tools Release I think we should release a version of the CLI now, from what Steve told me there is a lot changes going in, and also contains the switch to use npm instead of CPR, and other changes around npm3 and nodejs4 This will allow for trains to move forward and get feedback on the releases. Propose sequence: 1. Release CLI 2. Release Android 3. Release Plugins 4. Release CLI with latest released platformed pinned Rinse and repeat while singing choo choo !
[DISCUSS] Tools Release
I think we should release a version of the CLI now, from what Steve told me there is a lot changes going in, and also contains the switch to use npm instead of CPR, and other changes around npm3 and nodejs4 This will allow for trains to move forward and get feedback on the releases. Propose sequence: 1. Release CLI 2. Release Android 3. Release Plugins 4. Release CLI with latest released platformed pinned Rinse and repeat while singing choo choo !
Re: [DISCUSS] Cordova-Android 5.0.x
+! My team is hiring! @purplecabbage risingj.com On Fri, Oct 23, 2015 at 3:46 AM, Shazron wrote: > +1 > > On Thu, Oct 22, 2015 at 10:38 AM, Joe Bowser wrote: > > BUMP! I'd like to start the vote thread on Monday! > > > > On Tue, Oct 20, 2015 at 10:01 AM, Joe Bowser wrote: > > > >> Hey > >> > >> I would like to release Cordova-Android 5.0.x soon so that I can then > move > >> on to releasing each of the plugins that depend on it so we can get > ready > >> to release a CLI version by the end of the year. Is there anything > that's > >> currently blocking us from doing this other than minor class name > changes? > >> > >> Is there any reason we shouldn't start the release process once we > change > >> the name of CordovaWebView to CordovaWebInterface? Respond in this > thread. > >> > >> Thanks > >> > >> Joe > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42891905
--- Diff: src/ios/CDVFileTransfer.m ---
@@ -552,6 +552,8 @@ -
(void)connectionDidFinishLoading:(NSURLConnection*)connection
if (self.direction == CDV_TRANSFER_UPLOAD) {
uploadResponse = [[NSString alloc] initWithData:self.responseData
encoding:NSUTF8StringEncoding];
+if (uploadResponse == nil)
+uploadResponse = [[NSString alloc] initWithData:
self.responseData encoding:NSISOLatin1StringEncoding];
--- End diff --
Looks there is [no easy
way](http://stackoverflow.com/questions/21488674/readtextasync-in-windows-store-app-with-multibyte-file-and-javascript)
to fix that on Windows.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42887803
--- Diff: src/ios/CDVFileTransfer.m ---
@@ -552,6 +552,8 @@ -
(void)connectionDidFinishLoading:(NSURLConnection*)connection
if (self.direction == CDV_TRANSFER_UPLOAD) {
uploadResponse = [[NSString alloc] initWithData:self.responseData
encoding:NSUTF8StringEncoding];
+if (uploadResponse == nil)
+uploadResponse = [[NSString alloc] initWithData:
self.responseData encoding:NSISOLatin1StringEncoding];
--- End diff --
On Android Latin1 spec symbols result in � in webview.
On Windows such an exception occurs on reading the response stream:
```
Exception is about to be caught by JavaScript library code at line 178,
column 37 in
ms-appx://io.cordova.hellocordova/www/plugins/cordova-plugin-file-transfer/src/windows/FileTransferProxy.js
0x80070459 - JavaScript runtime error: No mapping for the Unicode character
exists in the target multi-byte code page.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device pull request: add isSimulator for iOS & Andr...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150621997 Yes. Except it is only useful for plugins that depends on device. Accelerometer should not depend on device. I would like to move this directly into platforms, another discussion... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...
GitHub user srgpqt opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2 Handle opening links in new window Makes links with target="_blank" behave as expected. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cortexmedia/cordova-plugin-wkwebview-engine master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2 commit f495e8292b0131c446f354198654b5b7e435c7ca Author: Serge Paquet Date: 2015-10-23T15:59:19Z Handle opening links in new window --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8307: Adding a 25-year expiration...
Github user pke commented on the pull request: https://github.com/apache/cordova-windows/pull/65#issuecomment-150586166 This somehow prevents me from specifying a publisherId myself for store submissions. I always get "CN=Apache Cordova Team". What do I have to do, to prevent that? `config.publisherId` set from build.json is ignored too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device pull request: add isSimulator for iOS & Andr...
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150563793 @nikhilkh this is essentially what I needed so I will use this to pend unsupported tests on iOS simulator I guess this will add a cordova-plugin-device dependency to test plugin though --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device pull request: add isSimulator for iOS & Andr...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-150561368 @alsorokin Isn't this what you needed for disabling failing tests on iOS simulator? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] cordova-ios 4.0.0 release
Sorry for the late reply -- took a sick day. I'd really like to just get cordova-ios 4.x out without a patch release in between, since there are just a few more issues left before we can clear the board (I'll triage it again), and a 4.x release would follow closely a 3.9.2 release. After mulling it over -- what I want and what is needed is of course two things. I really don't want the headache of third-party plugin breakage issues on the first day of release, which will happen. The API removals (although our prerogative) never had a deprecation warning. In a perfect world, after blogging about it and communicating it to plugin authors, they would update their plugins in a backwards compatible way immediately (which I plan to write a howto included in the platform and/or blog post -- there's a jira issue for it) No plugin author updates things without encountering a breakage after hearing from their users -- blog posts just don't have the impact that code breakage does :) So -- here's a plan: A cordova-ios-3.9.2 release, there should be two goals: 1. iOS 9 / Xcode 7 fixes (scan the 4.x kanban board for all fixed issues) 2. Add deprecation/removal warnings through the macro (https://github.com/apache/cordova-ios/blob/master/CordovaLib/Classes/Public/CDVAvailabilityDeprecated.h#L23). Not a deprecation, but a removal since that is our prerogative for major version bumps. For #2, for the API items that have been removed (through the macros) -- we include strong language and pointers on how to fix it, and/or instructions for users to contact the plugin author to fix. Not sure how hard -- we could have some introspection in the plugin to actually print out the plugin id responsible. For cordova-ios-3.9.2 I would create a kanban board "cordova-ios-3.9.2" (linked to label 'cordova-ios-3.9.2'), then go through the cordova-ios-4.x board, see what issues apply, then add the label "cordova-ios-3.9.2" which would automatically appear on the new board. Go through the items in the new board, and cherry-pick the patches into the 3.9.x branch. Can Microsoft take on this 3.9.2 release while I continue to get the 4.x release out? FYI -- ATS is handled by the CLI (should be in the next cli release) and is not dependent on the cordova-ios platform. Thoughts? On Wed, Oct 21, 2015 at 10:24 AM, Nikhil Khandelwal wrote: > Sent the message before completing it. > > What are good tasks to be poached on cordova-ios-4.x? In particular, my team > can help out with cordova-lib related ios tasks. Also, fixing plugins or > filing issues for upcoming breakages are great areas we can help out. ios 4.x > has critical fixes for XCode 7 usage which people need sooner rather than > later [1]. Could you mark them with a tag 'poachable'? We can follow up on > slack as well if this requires back and forth. I'll ping you later today. > > As for breaking change below, I've not been keeping up ios-4.x as closely - I > must've missed the communication on it. I understand there is a possibility > of breaking because of how "categories" work in Objective-C (I just read up > on it - it's a nifty feature). I also understand that they were not > *intended* to be used. AFAIK we do not document our platform APIs and even > our core plugins (camera) was using this particular API. As we discussed in > cordova F2F, developers do not have high confidence with the version of > plugins (particularly third party) to pick and choose and anything we could > do in how we version our API/manage breaking changes - will make Cordova a > smoother experience. The impact of this breaking change is HIGH from the > small sample set of plugins we tested. > > As far as I understand, Cordova-ios 3.9.x is not usable with XCODE 7 - ATS, > ENABLE_BITCODE being two issues[2]. Cordova-ios 4.x is not ready and will > likely break the third-party plugins they use when it releases. Should we > really push for a patch release for cordova-ios 3.9.x to fix XCODE 7 issues? > @Shaz: How feasible would this be? I know some of us at Microsoft can help do > this with guidance. > > [1] http://stackoverflow.com/search?q=ENABLE_BITCODE+%5Bcordova%5D > [2] http://stackoverflow.com/search?q=%22XCODE+7%22+%5Bcordova%5D > > -Original Message- > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] > Sent: Wednesday, October 21, 2015 7:09 AM > To: dev@cordova.apache.org > Subject: RE: [DISCUSS] cordova-ios 4.0.0 release > > What are good tasks to be poached on cordova-ios-4.x? In particular, my team > can help out with cordova-lib related ios tasks. Also, fixing plugins or > filing issues for upcoming breakages are great areas we can help out. ios 4.x > has critical fixes for XCode 7 usage which people need sooner rather than > later [1]. Could you mark them with a tag 'poachable'? We can follow up on > slack as well if this requires back and forth. I'll ping you later today. > > As for breaking change below, I've not been keeping up ios-4.x as closely - I
[GitHub] cordova-docs pull request: orubase
Github user Krishnarajd commented on the pull request: https://github.com/apache/cordova-docs/pull/389#issuecomment-150552416  Could please use this attached image. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Master
Github user Krishnarajd closed the pull request at: https://github.com/apache/cordova-docs/pull/401 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Master
GitHub user Krishnarajd opened a pull request: https://github.com/apache/cordova-docs/pull/401 Master orubase tools information added. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cordova-docs master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/401.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #401 commit 49a9a129c0975fd054d8f2cfb78b2c57e60e3267 Author: Andrey Kurdyumov Date: 2015-07-24T12:05:22Z Prevent loading GA when working locally commit b10e2dfb28d7cfa6be0a7b13fd7239f33ffcfc51 Author: Andrey Kurdyumov Date: 2015-07-25T06:18:29Z CB-8885 Fixed link to outdated Apple doc page They also change the name of article, so that changed too commit 7b7fbf412bf29f011e5658394a6c2a50242b5b4f Author: Andrey Kurdyumov Date: 2015-07-25T06:27:41Z CB-7279 Make clear that setting PATH instructions apply to both Linux and Mac commit 15616223d5d4d4a3c6d792d177a5c291826e40ae Author: Andrey Kurdyumov Date: 2015-07-25T06:39:00Z CB-6176 Remove support of HideKeyboardFormAccessoryBar on iOS commit 219bfa7693bfb456546d07f9d0cb987d3404b123 Author: Andrey Kurdyumov Date: 2015-07-25T06:57:02Z CB-8751 Fix markdown formatting commit 696507ce55a455f78a80670fbce87e149c03f9b0 Author: Andrey Kurdyumov Date: 2015-07-25T07:20:42Z CB-9373 Fixed formatting in the Installing Core Plugins section commit 8d68687ba5d9d88be335e6d1af5acb813a5c6588 Author: Andrey Kurdyumov Date: 2015-07-27T09:40:43Z CB-8701 Fixed links in outdated docs commit 0c1b081d28334c11d972e6d0c76d29618fec7b11 Author: Andrey Kurdyumov Date: 2015-08-02T18:22:16Z Fix grammar mistake commit 8bc30bd21091753ccfddf2eefcfc77d04a82e675 Author: Andrey Kurdyumov Date: 2015-08-02T19:53:39Z Format files to fix Markdown errors and simplify translation effort commit a3e37a0475d589910e25fed5b7d39543a9195e8c Author: Max Deepfield Date: 2015-08-03T15:57:20Z Update index.md some typo fixes commit b5795d21c484dbbd052f981a17f83f53f1108cee Author: Victor Sosa Date: 2015-08-04T02:41:04Z CB-9444 cordova-docs documentation translation: cordova-docs commit 8bee38146ca0f61d78313396b5bb724b7ff194d7 Author: Andrey Kurdyumov Date: 2015-08-06T03:45:49Z Fix typo found during translation commit c504c5eadb8be1532b0a77b4fcd64014606b0136 Author: Andrey Kurdyumov Date: 2015-08-06T03:46:33Z Fix typo found during translation commit d7ef64da6564caab97db93ab350008661afef090 Author: Andrey Kurdyumov Date: 2015-08-06T04:02:05Z Fix YAML headers for Chinese commit af808219670150e7f02d57ca1a43063258dadb23 Author: Andrey Kurdyumov Date: 2015-08-06T04:02:45Z Fix YAML headers inside Polish translation commit a8be11e27bda2b137e8a6a349103361ef41761dd Author: Andrey Kurdyumov Date: 2015-08-06T04:03:19Z Fix YAML headers for Korean commit fe0a09910f7e7817d292c3c0681cf4ed9a6effda Author: Andrey Kurdyumov Date: 2015-08-06T04:03:40Z Fix YAML headers for Japanese commit 69e292ac14a1dc6dfc0dda0f118e979963c85443 Author: Andrey Kurdyumov Date: 2015-08-06T04:04:00Z Fix YAML headers for Italian commit 56931217e93cf543c4e47d2eea9ec0ffd489b25e Author: Andrey Kurdyumov Date: 2015-08-06T04:04:12Z Fix YAML headers for French commit f4c7eca8ff1c10f4eca9a9d992172dd9f186820f Author: Andrey Kurdyumov Date: 2015-08-06T04:06:04Z Fix YAML headers for Spanish commit e2fb1c2143fb17ac38acc8206563ceb39caed9ba Author: Andrey Kurdyumov Date: 2015-08-06T04:07:04Z Fix YAML headers for German commit 74e97ced7a764837341d2db19dfa13eccd761b40 Author: Andrey Kurdyumov Date: 2015-08-06T04:23:52Z Move version selector dropdown under header This is comes as preparation for splitting lang/version dropdown on two separate parts which will work independently commit 5da39583c18ae437523e1230de1f46f4c9b6e7a5 Author: Andrey Kurdyumov Date: 2015-08-06T04:47:55Z Add gap between left screen border and text in the sidebar commit 396503ac599ea0de836f6fd57e77620033097149 Author: Andrey Kurdyumov Date: 2015-08-06T04:55:52Z Document templates folders structure commit a2ee176844e16b030ca2f7121c9c7cf4dc1c393f Author: Andrey Kurdyumov Date: 2015-08-06T13:29:10Z Split language and version selector dropdown on two parts Now languages are hardcoded during generation, and versions populated from shared script. Language population should also take data from some shared file, and versions should be pregenerated to have better UI experience on slow networks. commit fcfc86932ae42d5d7af475dce9e34c084531ae2f Author: Andrey Kurdyumov Date: 2015-08-06T13:52:38Z Add GA event which will track language changes. Also remove deprecated code commit de8bd4b67c18749d8fab
[GitHub] cordova-docs pull request: Orubase tool information added
Github user Krishnarajd closed the pull request at: https://github.com/apache/cordova-docs/pull/390 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Master
Github user Krishnarajd closed the pull request at: https://github.com/apache/cordova-docs/pull/400 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Added note about iOS9 a...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/103#issuecomment-150545749 The next version of the CLI will automatically convert `access` and `allow-navigation` tags to the correct ATS directives. If you are using cordova-ios-3.x you would only need the upcoming (unreleased) version of the CLI to have this feature. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42854285
--- Diff: src/ios/CDVFileTransfer.m ---
@@ -552,6 +552,8 @@ -
(void)connectionDidFinishLoading:(NSURLConnection*)connection
if (self.direction == CDV_TRANSFER_UPLOAD) {
uploadResponse = [[NSString alloc] initWithData:self.responseData
encoding:NSUTF8StringEncoding];
+if (uploadResponse == nil)
--- End diff --
Nit: This one-liner should be encapsulated in a block as a best practice
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Master
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-docs/pull/400#issuecomment-150544323 I think you did something wrong Files changed 19,185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Master
GitHub user Krishnarajd opened a pull request: https://github.com/apache/cordova-docs/pull/400 Master orubase tools information added. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cordova-docs master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/400.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #400 commit 49a9a129c0975fd054d8f2cfb78b2c57e60e3267 Author: Andrey Kurdyumov Date: 2015-07-24T12:05:22Z Prevent loading GA when working locally commit b10e2dfb28d7cfa6be0a7b13fd7239f33ffcfc51 Author: Andrey Kurdyumov Date: 2015-07-25T06:18:29Z CB-8885 Fixed link to outdated Apple doc page They also change the name of article, so that changed too commit 7b7fbf412bf29f011e5658394a6c2a50242b5b4f Author: Andrey Kurdyumov Date: 2015-07-25T06:27:41Z CB-7279 Make clear that setting PATH instructions apply to both Linux and Mac commit 15616223d5d4d4a3c6d792d177a5c291826e40ae Author: Andrey Kurdyumov Date: 2015-07-25T06:39:00Z CB-6176 Remove support of HideKeyboardFormAccessoryBar on iOS commit 219bfa7693bfb456546d07f9d0cb987d3404b123 Author: Andrey Kurdyumov Date: 2015-07-25T06:57:02Z CB-8751 Fix markdown formatting commit 696507ce55a455f78a80670fbce87e149c03f9b0 Author: Andrey Kurdyumov Date: 2015-07-25T07:20:42Z CB-9373 Fixed formatting in the Installing Core Plugins section commit 8d68687ba5d9d88be335e6d1af5acb813a5c6588 Author: Andrey Kurdyumov Date: 2015-07-27T09:40:43Z CB-8701 Fixed links in outdated docs commit 0c1b081d28334c11d972e6d0c76d29618fec7b11 Author: Andrey Kurdyumov Date: 2015-08-02T18:22:16Z Fix grammar mistake commit 8bc30bd21091753ccfddf2eefcfc77d04a82e675 Author: Andrey Kurdyumov Date: 2015-08-02T19:53:39Z Format files to fix Markdown errors and simplify translation effort commit a3e37a0475d589910e25fed5b7d39543a9195e8c Author: Max Deepfield Date: 2015-08-03T15:57:20Z Update index.md some typo fixes commit b5795d21c484dbbd052f981a17f83f53f1108cee Author: Victor Sosa Date: 2015-08-04T02:41:04Z CB-9444 cordova-docs documentation translation: cordova-docs commit 8bee38146ca0f61d78313396b5bb724b7ff194d7 Author: Andrey Kurdyumov Date: 2015-08-06T03:45:49Z Fix typo found during translation commit c504c5eadb8be1532b0a77b4fcd64014606b0136 Author: Andrey Kurdyumov Date: 2015-08-06T03:46:33Z Fix typo found during translation commit d7ef64da6564caab97db93ab350008661afef090 Author: Andrey Kurdyumov Date: 2015-08-06T04:02:05Z Fix YAML headers for Chinese commit af808219670150e7f02d57ca1a43063258dadb23 Author: Andrey Kurdyumov Date: 2015-08-06T04:02:45Z Fix YAML headers inside Polish translation commit a8be11e27bda2b137e8a6a349103361ef41761dd Author: Andrey Kurdyumov Date: 2015-08-06T04:03:19Z Fix YAML headers for Korean commit fe0a09910f7e7817d292c3c0681cf4ed9a6effda Author: Andrey Kurdyumov Date: 2015-08-06T04:03:40Z Fix YAML headers for Japanese commit 69e292ac14a1dc6dfc0dda0f118e979963c85443 Author: Andrey Kurdyumov Date: 2015-08-06T04:04:00Z Fix YAML headers for Italian commit 56931217e93cf543c4e47d2eea9ec0ffd489b25e Author: Andrey Kurdyumov Date: 2015-08-06T04:04:12Z Fix YAML headers for French commit f4c7eca8ff1c10f4eca9a9d992172dd9f186820f Author: Andrey Kurdyumov Date: 2015-08-06T04:06:04Z Fix YAML headers for Spanish commit e2fb1c2143fb17ac38acc8206563ceb39caed9ba Author: Andrey Kurdyumov Date: 2015-08-06T04:07:04Z Fix YAML headers for German commit 74e97ced7a764837341d2db19dfa13eccd761b40 Author: Andrey Kurdyumov Date: 2015-08-06T04:23:52Z Move version selector dropdown under header This is comes as preparation for splitting lang/version dropdown on two separate parts which will work independently commit 5da39583c18ae437523e1230de1f46f4c9b6e7a5 Author: Andrey Kurdyumov Date: 2015-08-06T04:47:55Z Add gap between left screen border and text in the sidebar commit 396503ac599ea0de836f6fd57e77620033097149 Author: Andrey Kurdyumov Date: 2015-08-06T04:55:52Z Document templates folders structure commit a2ee176844e16b030ca2f7121c9c7cf4dc1c393f Author: Andrey Kurdyumov Date: 2015-08-06T13:29:10Z Split language and version selector dropdown on two parts Now languages are hardcoded during generation, and versions populated from shared script. Language population should also take data from some shared file, and versions should be pregenerated to have better UI experience on slow networks. commit fcfc86932ae42d5d7af475dce9e34c084531ae2f Author: Andrey Kurdyumov Date: 2015-08-06T13:52:38Z Add GA event which will track language changes. Also remove deprecated code commit de8bd4b67c18749d8fab
[GitHub] cordova-plugin-file pull request: CB-9851 Document cdvfile protoco...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file/pull/141 CB-9851 Document cdvfile protocol quirk - using cdvfile:// in the DOM⦠⦠is not supported on Windows [Jira issue](https://issues.apache.org/jira/browse/CB-9851) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-file CB-9851 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/141.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #141 commit 667462eccd9489cefdaebbb66ebf174e2c36512a Author: daserge Date: 2015-10-23T10:50:33Z CB-9851 Document cdvfile protocol quirk - using cdvfile:// in the DOM is not supported on Windows --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Removing Tizen From Support Matrix
+1 On Thu, Oct 22, 2015 at 1:39 PM, Dmitry Blotsky wrote: > Hey folks, > > A few weeks back I heard someone mention that we should strike Tizen from > this matrix: > http://cordova.apache.org/docs/en/5.1.1/guide/support/index.html. Should I > proceed with that? Should we be removing Tizen entirely from our docs? > > Kindly, > Dmitry - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Cordova-Android 5.0.x
+1 On Thu, Oct 22, 2015 at 10:38 AM, Joe Bowser wrote: > BUMP! I'd like to start the vote thread on Monday! > > On Tue, Oct 20, 2015 at 10:01 AM, Joe Bowser wrote: > >> Hey >> >> I would like to release Cordova-Android 5.0.x soon so that I can then move >> on to releasing each of the plugins that depend on it so we can get ready >> to release a CLI version by the end of the year. Is there anything that's >> currently blocking us from doing this other than minor class name changes? >> >> Is there any reason we shouldn't start the release process once we change >> the name of CordovaWebView to CordovaWebInterface? Respond in this thread. >> >> Thanks >> >> Joe >> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-150526428 @purplecabbage On Android, the strings were previously [hardcoded](https://github.com/apache/cordova-plugin-camera/pull/104/files#diff-f2e83abdaf34884df7e74b6493cf2dd7L79) into the plugin. My commit actually [moved them out into plugin.xml](https://github.com/apache/cordova-plugin-camera/pull/104/files#diff-53f390d375398624afe1cfe1125f42bfR79) so they could actually be localized. The other strings (e.g. the intent names) are actually provided by the OS based on the available activities. For WP, it is all built in to the OS, and for iOS the one new string (Library) is added in a localizable manner consistent with other strings in plugins. I don't necessarily disagree with your approach to splitting this into multiple plugins, however I really do believe there is a useful scenario where the camera UI launches first, but the user has a quick escape into the library. That wouldn't be supported by splitting into 3 plugins. Instead if you really want more of a consistent experience you just have to write to the native camera APIs directly on each platform and built a custom "Cordova" standard UI on top of them. Having a modal source chooser step just adds complexity to the user experience in most cases. Far better from a UX perspective to default to the 90% case (as determined by the developer for their app) but allow easy toggling between the various options. In any case, it seems that there's no future hope for this PR in its current form. I still do advocate that the problem I'm trying to solve is a valuable and important addition to the Cordova plugins, but I'm certainly open to the form it takes as long as it meets the user experience bar we're trying to achieve. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[VOTE] Cordova-common release
Please review and vote on this Cordova-common Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9850 Both tools have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9850/ The packages were published from their corresponding git tags: cordova-lib: common-0.1.0 (6ec023d295) Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the repo * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ensured test were passing when repo was tagged - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150498299 Sounds good, can you get the code in a new pull request and reference the same CB-9685? I'll re-open it once you do so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
