Re: [DISCUSS] Moving JIRA issues to Github

[Filip Maj]

> The one I was thinking of was cordova-plugins. Do we want some way to track
> issues for inactive platforms too or should those be considered permanently
> closed?

Possibly. I think we will still have JIRA around w/ deprecated
components, maybe? I'm not sure. Shaz?

> For example a new platform or core plugin is created. I'd assume we could
> create an empty repository, but I'm not sure what the overhead of
> requesting a new repo is. Experimental plugins or research might fall into
> this category as well. I guess the more general question is are there any
> Jira tasks we use that aren't tied to a repo and if so where should track
> them in Github?

To create new repos, we will have to go through Infra anyways.
Experimental code in cordova has gone into branches in the
cordova-labs repo in the past.

> Is there going to be a default repository to hold them before they're
> triaged and organized?

Oh I think I see what you mean now. As in, what do we do with JIRA
issues without an assigned component that does maps to one of the new
GH repos, what do we do with those? That's a good question. Perhaps
that points to us doing a big JIRA issue cleanup before we undergo a
migration. FWIW I did a couple weeks back already and am fairly
confident most relevant issues have an assigned component.

On Wed, Aug 2, 2017 at 6:51 PM, Connor Pearson  wrote:
>>> Since it looks like not all repositories will be migrated where should
> their issues go?
>> All repositories will be migrated.
>
> The one I was thinking of was cordova-plugins. Do we want some way to track
> issues for inactive platforms too or should those be considered permanently
> closed?
>
>>> What about issues for repositories that don’t yet exist
>> Can you give me an example?
>
> For example a new platform or core plugin is created. I'd assume we could
> create an empty repository, but I'm not sure what the overhead of
> requesting a new repo is. Experimental plugins or research might fall into
> this category as well. I guess the more general question is are there any
> Jira tasks we use that aren't tied to a repo and if so where should track
> them in Github?
>
>>> If we migrate before triaging where will all the un-triaged issues end
> up?
>> They would end up in GitHub, at which point we'd triage them within
> GitHub.
>
> Is there going to be a default repository to hold them before they're
> triaged and organized?
>
> On a slightly different note, I'm looking forward to the new PR process. It
> always felt a little strange in the past.
>
>
>
> On Wed, Aug 2, 2017 at 9:13 PM, Filip Maj  wrote:
>
>> > Since it looks like not all repositories will be migrated where should
>> their issues go?
>>
>> All repositories will be migrated.
>>
>> > What about issues for repositories that don’t yet exist
>>
>> Can you give me an example?
>>
>> > or cross-cutting issues?
>>
>> I think if you absolutely need issues related to multiple repos, you
>> can always create multiple issues in all relevant repos and
>> cross-reference them.
>>
>> > As a user, I’ll occasionally skim the recently opened bugs in Jira
>> across the entire project to see if any may affect us. Is there going to be
>> a way to do this with Github? Subscribing to notifications could be a
>> work-around but it’s not ideal.
>>
>> Good question. I can't really think of a way to do this...
>>
>> > Are we going to get more high quality bug reports using Github? This may
>> not be answerable without trying it out, but making issues easier to create
>> issues could cause an influx of questions and non-cordova related bugs.
>> This could add on to the difficulties of triaging and migrating bugs across
>> repos.
>>
>> To be fair, we already get painful triage-work via GitHub just by
>> opening up Pull Requests to the public. People will use those to post
>> questions or issues, because they are unaware that there are other
>> support and issue filing avenues (they will mask them as PRs merging a
>> release branch into master). At least those people now have a more
>> obvious place to file issues: the Issues section on GitHub. We already
>> have a lot of triage work on JIRA as it is. I doubt this will go down.
>> That said, I don't think that's necessarily bad. Will we have more
>> work? Probably. Will we be able to more easily identify issues, and
>> earlier, and generally be also more accessible to our community? I
>> would think yes. Double-edged sword. I say let's see how it goes.
>>
>> > If we migrate before triaging where will all the un-triaged issues end
>> up?
>>
>> They would end up in GitHub, at which point we'd triage them within GitHub.
>>
>> > Also if we enable Github issues before phase 2 are we going to be using
>> both Jira and Github Issues for a period of time?
>>
>> Yes.
>>
>> Different topic: Shaz, based on your INFRA ticket / phase breakdown,
>> the implication is that there will be leftover cordova repos in Apache
>> Git (cordova-medic, weinre, 

Re: [GITHUB MOVE] Phase 1 Complete, next steps

[Steven Gill]

Yes!

On Aug 2, 2017 6:16 PM, "Filip Maj"  wrote:

> at some point should we migrate / create a cordova-discuss repo [1] to
> the apache org?
>
> [1] https://github.com/cordova/cordova-discuss
>
> On Wed, Aug 2, 2017 at 12:42 PM, Shazron  wrote:
> > Phase 1 complete:
> > https://issues.apache.org/jira/browse/INFRA-14347
> >
> > We need to:
> >
> > 1. Update some of our tools, mainly Coho, to point directly to Github,
> > since the git-wip-us.a.o repo is now gone.
> > 2. Update our docs
> > 3. Update our website (contribution)
> >
> > I think we need to do 2. and 3. once Phases 2 and 3 are done as well.
> > We can do gradual updates of 1. as repos are migrated (should just be a
> > json file).
> >
> > The Git repo now exists on Apache at:
> > https://gitbox.apache.org/repos/asf?p=REPO-NAME.git
> >
> > .. but we will primarily push to Github.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: [DISCUSS] Moving JIRA issues to Github

[Connor Pearson]

>> Since it looks like not all repositories will be migrated where should
their issues go?
> All repositories will be migrated.

The one I was thinking of was cordova-plugins. Do we want some way to track
issues for inactive platforms too or should those be considered permanently
closed?

>> What about issues for repositories that don’t yet exist
> Can you give me an example?

For example a new platform or core plugin is created. I'd assume we could
create an empty repository, but I'm not sure what the overhead of
requesting a new repo is. Experimental plugins or research might fall into
this category as well. I guess the more general question is are there any
Jira tasks we use that aren't tied to a repo and if so where should track
them in Github?

>> If we migrate before triaging where will all the un-triaged issues end
up?
> They would end up in GitHub, at which point we'd triage them within
GitHub.

Is there going to be a default repository to hold them before they're
triaged and organized?

On a slightly different note, I'm looking forward to the new PR process. It
always felt a little strange in the past.



On Wed, Aug 2, 2017 at 9:13 PM, Filip Maj  wrote:

> > Since it looks like not all repositories will be migrated where should
> their issues go?
>
> All repositories will be migrated.
>
> > What about issues for repositories that don’t yet exist
>
> Can you give me an example?
>
> > or cross-cutting issues?
>
> I think if you absolutely need issues related to multiple repos, you
> can always create multiple issues in all relevant repos and
> cross-reference them.
>
> > As a user, I’ll occasionally skim the recently opened bugs in Jira
> across the entire project to see if any may affect us. Is there going to be
> a way to do this with Github? Subscribing to notifications could be a
> work-around but it’s not ideal.
>
> Good question. I can't really think of a way to do this...
>
> > Are we going to get more high quality bug reports using Github? This may
> not be answerable without trying it out, but making issues easier to create
> issues could cause an influx of questions and non-cordova related bugs.
> This could add on to the difficulties of triaging and migrating bugs across
> repos.
>
> To be fair, we already get painful triage-work via GitHub just by
> opening up Pull Requests to the public. People will use those to post
> questions or issues, because they are unaware that there are other
> support and issue filing avenues (they will mask them as PRs merging a
> release branch into master). At least those people now have a more
> obvious place to file issues: the Issues section on GitHub. We already
> have a lot of triage work on JIRA as it is. I doubt this will go down.
> That said, I don't think that's necessarily bad. Will we have more
> work? Probably. Will we be able to more easily identify issues, and
> earlier, and generally be also more accessible to our community? I
> would think yes. Double-edged sword. I say let's see how it goes.
>
> > If we migrate before triaging where will all the un-triaged issues end
> up?
>
> They would end up in GitHub, at which point we'd triage them within GitHub.
>
> > Also if we enable Github issues before phase 2 are we going to be using
> both Jira and Github Issues for a period of time?
>
> Yes.
>
> Different topic: Shaz, based on your INFRA ticket / phase breakdown,
> the implication is that there will be leftover cordova repos in Apache
> Git (cordova-medic, weinre, deprecated platforms / plugins). What do
> we do with those? Separate discussion?
>
> On Wed, Aug 2, 2017 at 5:32 PM, Connor Pearson  wrote:
> > I have a few questions about moving issues to GitHub. I haven’t used
> Github
> > issues much so these all may be easily solvable.
> >
> > * Since it looks like not all repositories will be migrated where should
> > their issues go? What about issues for repositories that don’t yet exist
> or
> > cross-cutting issues?
> > * As a user, I’ll occasionally skim the recently opened bugs in Jira
> across
> > the entire project to see if any may affect us. Is there going to be a
> way
> > to do this with Github? Subscribing to notifications could be a
> work-around
> > but it’s not ideal.
> > * Are we going to get more high quality bug reports using Github? This
> may
> > not be answerable without trying it out, but making issues easier to
> create
> > issues could cause an influx of questions and non-cordova related bugs.
> > This could add on to the difficulties of triaging and migrating bugs
> across
> > repos.
> > * If we migrate before triaging where will all the un-triaged issues end
> > up? Also if we enable Github issues before phase 2 are we going to be
> using
> > both Jira and Github Issues for a period of time?
> >
> > -Connor
> >
> >
> > On August 2, 2017 at 7:08:18 PM, Jan Piotrowski (piotrow...@gmail.com)
> > wrote:
> >
> > If people post their issue at the wrong repo (which of course can and
> > 

Re: cordova 8 proposal

[Filip Maj]

Thanks for kicking this off. Lotsa good stuff in there, but lots to
sort through. Recommend everyone take a look!

On Wed, Aug 2, 2017 at 4:51 PM, Steven Gill  wrote:
> Let me know what you think!
> https://github.com/cordova/cordova-discuss/pull/72

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [GITHUB MOVE] Phase 1 Complete, next steps

[Filip Maj]

at some point should we migrate / create a cordova-discuss repo [1] to
the apache org?

[1] https://github.com/cordova/cordova-discuss

On Wed, Aug 2, 2017 at 12:42 PM, Shazron  wrote:
> Phase 1 complete:
> https://issues.apache.org/jira/browse/INFRA-14347
>
> We need to:
>
> 1. Update some of our tools, mainly Coho, to point directly to Github,
> since the git-wip-us.a.o repo is now gone.
> 2. Update our docs
> 3. Update our website (contribution)
>
> I think we need to do 2. and 3. once Phases 2 and 3 are done as well.
> We can do gradual updates of 1. as repos are migrated (should just be a
> json file).
>
> The Git repo now exists on Apache at:
> https://gitbox.apache.org/repos/asf?p=REPO-NAME.git
>
> .. but we will primarily push to Github.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Moving JIRA issues to Github

[Filip Maj]

> Since it looks like not all repositories will be migrated where should their 
> issues go?

All repositories will be migrated.

> What about issues for repositories that don’t yet exist

Can you give me an example?

> or cross-cutting issues?

I think if you absolutely need issues related to multiple repos, you
can always create multiple issues in all relevant repos and
cross-reference them.

> As a user, I’ll occasionally skim the recently opened bugs in Jira across the 
> entire project to see if any may affect us. Is there going to be a way to do 
> this with Github? Subscribing to notifications could be a work-around but 
> it’s not ideal.

Good question. I can't really think of a way to do this...

> Are we going to get more high quality bug reports using Github? This may not 
> be answerable without trying it out, but making issues easier to create 
> issues could cause an influx of questions and non-cordova related bugs. This 
> could add on to the difficulties of triaging and migrating bugs across repos.

To be fair, we already get painful triage-work via GitHub just by
opening up Pull Requests to the public. People will use those to post
questions or issues, because they are unaware that there are other
support and issue filing avenues (they will mask them as PRs merging a
release branch into master). At least those people now have a more
obvious place to file issues: the Issues section on GitHub. We already
have a lot of triage work on JIRA as it is. I doubt this will go down.
That said, I don't think that's necessarily bad. Will we have more
work? Probably. Will we be able to more easily identify issues, and
earlier, and generally be also more accessible to our community? I
would think yes. Double-edged sword. I say let's see how it goes.

> If we migrate before triaging where will all the un-triaged issues end up?

They would end up in GitHub, at which point we'd triage them within GitHub.

> Also if we enable Github issues before phase 2 are we going to be using both 
> Jira and Github Issues for a period of time?

Yes.

Different topic: Shaz, based on your INFRA ticket / phase breakdown,
the implication is that there will be leftover cordova repos in Apache
Git (cordova-medic, weinre, deprecated platforms / plugins). What do
we do with those? Separate discussion?

On Wed, Aug 2, 2017 at 5:32 PM, Connor Pearson  wrote:
> I have a few questions about moving issues to GitHub. I haven’t used Github
> issues much so these all may be easily solvable.
>
> * Since it looks like not all repositories will be migrated where should
> their issues go? What about issues for repositories that don’t yet exist or
> cross-cutting issues?
> * As a user, I’ll occasionally skim the recently opened bugs in Jira across
> the entire project to see if any may affect us. Is there going to be a way
> to do this with Github? Subscribing to notifications could be a work-around
> but it’s not ideal.
> * Are we going to get more high quality bug reports using Github? This may
> not be answerable without trying it out, but making issues easier to create
> issues could cause an influx of questions and non-cordova related bugs.
> This could add on to the difficulties of triaging and migrating bugs across
> repos.
> * If we migrate before triaging where will all the un-triaged issues end
> up? Also if we enable Github issues before phase 2 are we going to be using
> both Jira and Github Issues for a period of time?
>
> -Connor
>
>
> On August 2, 2017 at 7:08:18 PM, Jan Piotrowski (piotrow...@gmail.com)
> wrote:
>
> If people post their issue at the wrong repo (which of course can and
> will happen from time to time), there is a way to move them over with
> minimal loss of information:
>
> https://github.com/ionic-team/ionic/issues/12542
> https://github.com/ionic-team/ionic-cli/issues/2597
>
> This works for issues where several people replied already in the
> exact same way:
>
> https://github.com/ionic-team/ionic/issues/11898
> https://github.com/ionic-team/ionic-cli/issues/2386
>
> As the original poster of the issue and each reply is @-mentioned they
> are notified about the "new" issue and can continue participating.
> Replying users also can just include the @username in their new
> replies again to make sure people get notified.
>
> -J
>
>
>
> 2017-08-02 21:53 GMT+02:00 Filip Maj :
>> I think the ease of use of GitHub issues overcomes potential problems
>> about cross-referencing issues. Worth noting on this topic that GitHub
>> already provides good support for referencing pull requests from
>> issues across repos / orgs.
>>
>> The benefit of having issues and PRs in one place, to me, is a benefit
>> too tasty to pass up.
>>
>> Darryl, do you have examples of issues that you think could be
>> problematic in a GitHub-based world?
>>
>> On Wed, Aug 2, 2017 at 12:43 PM, Darryl Pogue  wrote:
>>> My concern with GitHub issues is that we have a tonne of repos and
> 

Re: [DISCUSS] Moving JIRA issues to Github

[Connor Pearson]

I have a few questions about moving issues to GitHub. I haven’t used Github
issues much so these all may be easily solvable.

* Since it looks like not all repositories will be migrated where should
their issues go? What about issues for repositories that don’t yet exist or
cross-cutting issues?
* As a user, I’ll occasionally skim the recently opened bugs in Jira across
the entire project to see if any may affect us. Is there going to be a way
to do this with Github? Subscribing to notifications could be a work-around
but it’s not ideal.
* Are we going to get more high quality bug reports using Github? This may
not be answerable without trying it out, but making issues easier to create
issues could cause an influx of questions and non-cordova related bugs.
This could add on to the difficulties of triaging and migrating bugs across
repos.
* If we migrate before triaging where will all the un-triaged issues end
up? Also if we enable Github issues before phase 2 are we going to be using
both Jira and Github Issues for a period of time?

-Connor


On August 2, 2017 at 7:08:18 PM, Jan Piotrowski (piotrow...@gmail.com)
wrote:

If people post their issue at the wrong repo (which of course can and
will happen from time to time), there is a way to move them over with
minimal loss of information:

https://github.com/ionic-team/ionic/issues/12542
https://github.com/ionic-team/ionic-cli/issues/2597

This works for issues where several people replied already in the
exact same way:

https://github.com/ionic-team/ionic/issues/11898
https://github.com/ionic-team/ionic-cli/issues/2386

As the original poster of the issue and each reply is @-mentioned they
are notified about the "new" issue and can continue participating.
Replying users also can just include the @username in their new
replies again to make sure people get notified.

-J



2017-08-02 21:53 GMT+02:00 Filip Maj :
> I think the ease of use of GitHub issues overcomes potential problems
> about cross-referencing issues. Worth noting on this topic that GitHub
> already provides good support for referencing pull requests from
> issues across repos / orgs.
>
> The benefit of having issues and PRs in one place, to me, is a benefit
> too tasty to pass up.
>
> Darryl, do you have examples of issues that you think could be
> problematic in a GitHub-based world?
>
> On Wed, Aug 2, 2017 at 12:43 PM, Darryl Pogue  wrote:
>> My concern with GitHub issues is that we have a tonne of repos and
issues
>> can easily span across them, and we'd lose the one central place for
issue
>> tracking and triage. I worry that we'd be inundated with issues on the
>> wrong repos, or without additional information, and triaging would
become
>> an insurmountable chore leading to a worse backlog than we already have
in
>> JIRA.
>>
>> On 2 August 2017 at 12:38, Shazron  wrote:
>>
>>> Phase 1 of our move to Github is complete, see:
>>> https://issues.apache.org/jira/browse/INFRA-14347
>>>
>>> We need a migration plan for moving JIRA issues to Github Issues before
we
>>> enable Github Issues on those repos.
>>>
>>> Once we figure those out, we can proceed with Phase 2:
>>> https://issues.apache.org/jira/browse/INFRA-14398
>>>
>>> I'll start it off by saying that ideally we:
>>> 1. Triage issues
>>> 2. Automate migration of existing open issues to Github issues
>>> 3. "Close off" the JIRA issues
>>>
>>> The impact of this is, the original reporters will not get notified of
>>> further updates to the issue except for a link to the new issue on
Github
>>> as a JIRA comment (since they will not be subscribed to the Github
issue).
>>>
>>> We could also migrate every open issue first, then triage later in
Github,
>>> as well.
>>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #587: CB-13056 : added deprecation notice for webos

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/587


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #585: CB-13057 : added deprecation warning for cord...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/585


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

cordova 8 proposal

[Steven Gill]

Let me know what you think!
https://github.com/cordova/cordova-discuss/pull/72

[GitHub] cordova-plugin-dialogs pull request #96: CB-12895 : setup eslint and removed...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-plugin-dialogs/pull/96

CB-12895 : setup eslint and removed jshint



### Platforms affected


### What does this PR do?
Setup eslint and removed jshint.

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-plugin-dialogs CB-12895

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-dialogs/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #96


commit 0b532b6eeb04c6adbccfea60f132f88de0c14755
Author: Audrey So 
Date:   2017-06-09T23:01:13Z

CB-12895 : setup eslint and removed jshint




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Moving JIRA issues to Github

[Jan Piotrowski]

If people post their issue at the wrong repo (which of course can and
will happen from time to time), there is a way to move them over with
minimal loss of information:

https://github.com/ionic-team/ionic/issues/12542
https://github.com/ionic-team/ionic-cli/issues/2597

This works for issues where several people replied already in the
exact same way:

https://github.com/ionic-team/ionic/issues/11898
https://github.com/ionic-team/ionic-cli/issues/2386

As the original poster of the issue and each reply is @-mentioned they
are notified about the "new" issue and can continue participating.
Replying users also can just include the @username in their new
replies again to make sure people get notified.

-J



2017-08-02 21:53 GMT+02:00 Filip Maj :
> I think the ease of use of GitHub issues overcomes potential problems
> about cross-referencing issues. Worth noting on this topic that GitHub
> already provides good support for referencing pull requests from
> issues across repos / orgs.
>
> The benefit of having issues and PRs in one place, to me, is a benefit
> too tasty to pass up.
>
> Darryl, do you have examples of issues that you think could be
> problematic in a GitHub-based world?
>
> On Wed, Aug 2, 2017 at 12:43 PM, Darryl Pogue  wrote:
>> My concern with GitHub issues is that we have a tonne of repos and issues
>> can easily span across them, and we'd lose the one central place for issue
>> tracking and triage. I worry that we'd be inundated with issues on the
>> wrong repos, or without additional information, and triaging would become
>> an insurmountable chore leading to a worse backlog than we already have in
>> JIRA.
>>
>> On 2 August 2017 at 12:38, Shazron  wrote:
>>
>>> Phase 1 of our move to Github is complete, see:
>>> https://issues.apache.org/jira/browse/INFRA-14347
>>>
>>> We need a migration plan for moving JIRA issues to Github Issues before we
>>> enable Github Issues on those repos.
>>>
>>> Once we figure those out, we can proceed with Phase 2:
>>> https://issues.apache.org/jira/browse/INFRA-14398
>>>
>>> I'll start it off by saying that ideally we:
>>> 1. Triage issues
>>> 2. Automate migration of existing open issues to Github issues
>>> 3. "Close off" the JIRA issues
>>>
>>> The impact of this is, the original reporters will not get notified of
>>> further updates to the issue except for a link to the new issue on Github
>>> as a JIRA comment (since they will not be subscribed to the Github issue).
>>>
>>> We could also migrate every open issue first, then triage later in Github,
>>> as well.
>>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request #70: CB-12895 : Setup eslint and removed ...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-plugin-device/pull/70

CB-12895 : Setup eslint and removed jshint



### Platforms affected


### What does this PR do?
Setup eslint and removed jshint

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-plugin-device CB-12895

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-device/pull/70.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #70


commit 042ce62ed25d9e2fa7c5b8295a426c622ebe5654
Author: Audrey So 
Date:   2017-06-09T22:27:27Z

CB-12895 : setup eslint and removed jshint




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request #82: CB-12895 : Added eslint and r...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/82

CB-12895 : Added eslint and removed jshint



### Platforms affected


### What does this PR do?
Added eslint and removed jshint

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-plugin-media-capture CB-12895

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media-capture/pull/82.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #82


commit 1694228a2cd01bdea8b15fb0d6b6f8d4dbcb091f
Author: Audrey So 
Date:   2017-06-12T18:03:09Z

CB-12895 : added eslint and removed jshint




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Moving JIRA issues to Github

[Filip Maj]

I think the ease of use of GitHub issues overcomes potential problems
about cross-referencing issues. Worth noting on this topic that GitHub
already provides good support for referencing pull requests from
issues across repos / orgs.

The benefit of having issues and PRs in one place, to me, is a benefit
too tasty to pass up.

Darryl, do you have examples of issues that you think could be
problematic in a GitHub-based world?

On Wed, Aug 2, 2017 at 12:43 PM, Darryl Pogue  wrote:
> My concern with GitHub issues is that we have a tonne of repos and issues
> can easily span across them, and we'd lose the one central place for issue
> tracking and triage. I worry that we'd be inundated with issues on the
> wrong repos, or without additional information, and triaging would become
> an insurmountable chore leading to a worse backlog than we already have in
> JIRA.
>
> On 2 August 2017 at 12:38, Shazron  wrote:
>
>> Phase 1 of our move to Github is complete, see:
>> https://issues.apache.org/jira/browse/INFRA-14347
>>
>> We need a migration plan for moving JIRA issues to Github Issues before we
>> enable Github Issues on those repos.
>>
>> Once we figure those out, we can proceed with Phase 2:
>> https://issues.apache.org/jira/browse/INFRA-14398
>>
>> I'll start it off by saying that ideally we:
>> 1. Triage issues
>> 2. Automate migration of existing open issues to Github issues
>> 3. "Close off" the JIRA issues
>>
>> The impact of this is, the original reporters will not get notified of
>> further updates to the issue except for a link to the new issue on Github
>> as a JIRA comment (since they will not be subscribed to the Github issue).
>>
>> We could also migrate every open issue first, then triage later in Github,
>> as well.
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [GITHUB MOVE] Phase 1 Complete, next steps

[Filip Maj]

This makes me so happy :)

On Wed, Aug 2, 2017 at 12:42 PM, Shazron  wrote:
> Phase 1 complete:
> https://issues.apache.org/jira/browse/INFRA-14347
>
> We need to:
>
> 1. Update some of our tools, mainly Coho, to point directly to Github,
> since the git-wip-us.a.o repo is now gone.
> 2. Update our docs
> 3. Update our website (contribution)
>
> I think we need to do 2. and 3. once Phases 2 and 3 are done as well.
> We can do gradual updates of 1. as repos are migrated (should just be a
> json file).
>
> The Git repo now exists on Apache at:
> https://gitbox.apache.org/repos/asf?p=REPO-NAME.git
>
> .. but we will primarily push to Github.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] shazron closed pull request #40: Test again, the sequel. No JIRA prefix.

[git]

shazron closed pull request #40: Test again, the sequel. No JIRA prefix.
URL: https://github.com/apache/cordova-browser/pull/40
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] shazron closed pull request #39: CB-123 - Test again

[git]

shazron closed pull request #39: CB-123 - Test again
URL: https://github.com/apache/cordova-browser/pull/39
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Moving JIRA issues to Github

[Darryl Pogue]

My concern with GitHub issues is that we have a tonne of repos and issues
can easily span across them, and we'd lose the one central place for issue
tracking and triage. I worry that we'd be inundated with issues on the
wrong repos, or without additional information, and triaging would become
an insurmountable chore leading to a worse backlog than we already have in
JIRA.

On 2 August 2017 at 12:38, Shazron  wrote:

> Phase 1 of our move to Github is complete, see:
> https://issues.apache.org/jira/browse/INFRA-14347
>
> We need a migration plan for moving JIRA issues to Github Issues before we
> enable Github Issues on those repos.
>
> Once we figure those out, we can proceed with Phase 2:
> https://issues.apache.org/jira/browse/INFRA-14398
>
> I'll start it off by saying that ideally we:
> 1. Triage issues
> 2. Automate migration of existing open issues to Github issues
> 3. "Close off" the JIRA issues
>
> The impact of this is, the original reporters will not get notified of
> further updates to the issue except for a link to the new issue on Github
> as a JIRA comment (since they will not be subscribed to the Github issue).
>
> We could also migrate every open issue first, then triage later in Github,
> as well.
>

[GITHUB MOVE] Phase 1 Complete, next steps

[Shazron]

Phase 1 complete:
https://issues.apache.org/jira/browse/INFRA-14347

We need to:

1. Update some of our tools, mainly Coho, to point directly to Github,
since the git-wip-us.a.o repo is now gone.
2. Update our docs
3. Update our website (contribution)

I think we need to do 2. and 3. once Phases 2 and 3 are done as well.
We can do gradual updates of 1. as repos are migrated (should just be a
json file).

The Git repo now exists on Apache at:
https://gitbox.apache.org/repos/asf?p=REPO-NAME.git

.. but we will primarily push to Github.

[DISCUSS] Moving JIRA issues to Github

[Shazron]

Phase 1 of our move to Github is complete, see:
https://issues.apache.org/jira/browse/INFRA-14347

We need a migration plan for moving JIRA issues to Github Issues before we
enable Github Issues on those repos.

Once we figure those out, we can proceed with Phase 2:
https://issues.apache.org/jira/browse/INFRA-14398

I'll start it off by saying that ideally we:
1. Triage issues
2. Automate migration of existing open issues to Github issues
3. "Close off" the JIRA issues

The impact of this is, the original reporters will not get notified of
further updates to the issue except for a link to the new issue on Github
as a JIRA comment (since they will not be subscribed to the Github issue).

We could also migrate every open issue first, then triage later in Github,
as well.

[GitHub] shazron commented on issue #39: CB-123 - Test again

[git]

shazron commented on issue #39: CB-123 - Test again
URL: https://github.com/apache/cordova-browser/pull/39#issuecomment-319768397
 
 
   Test comment (with prefix)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] shazron commented on issue #40: Test again, the sequel. No JIRA prefix.

[git]

shazron commented on issue #40: Test again, the sequel. No JIRA prefix.
URL: https://github.com/apache/cordova-browser/pull/40#issuecomment-319768329
 
 
   Test comment (no prefix)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request #58: CB-12895 : Added eslint and ...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/58

CB-12895 : Added eslint and removed jshint



### Platforms affected


### What does this PR do?
Added eslint and removed jshint

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-plugin-battery-status 
CB-12895

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #58


commit 835acc8d4daf4693d21c4be086fb06d1bdf9fc81
Author: Audrey So 
Date:   2017-06-09T21:41:05Z

CB-12895 : added eslint and removed jshint




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-network-information pull request #58: CB-12895 : added eslint...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-plugin-network-information/pull/58

CB-12895 : added eslint and removed jshint



### Platforms affected


### What does this PR do?
Added eslint and removed jshint

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-plugin-network-information 
CB-12895

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-network-information/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #58


commit 78691e43e16d753603f41d646ca7e71b3212c282
Author: Audrey So 
Date:   2017-06-12T18:15:35Z

CB-12895 : added eslint and removed eslint




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration pull request #59: CB-12895 : added eslint and remov...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-plugin-vibration/pull/59

CB-12895 : added eslint and removed jshint



### Platforms affected


### What does this PR do?


### What testing has been done on this change?

Added eslint and removed jshint

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-plugin-vibration CB-12895

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-vibration/pull/59.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #59


commit d23d7a870ed9fcfe6df076fe1ec49d4a71780d8d
Author: Audrey So 
Date:   2017-06-12T18:43:21Z

CB-12895 : added eslint and removed jshint




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #235: Download permissions

[adirel]

Github user adirel closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/235


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #235: Download permissions

[adirel]

GitHub user adirel opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/235

Download permissions



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jonasof/cordova-plugin-inappbrowser 
download-permissions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #235


commit 4063179c35bbd6c4bd1f3deaef005fd2c95fe36b
Author: Gorebar 
Date:   2016-12-12T11:49:19Z

(Android) Implement Download Files from URL on Android WebView.

commit 45214911cbeb3268f98e0a64081ec80732829659
Author: Gorebar 
Date:   2016-12-12T11:57:28Z

Change Toast.

commit 358b6804b2bd96d900daa0f6cc964169205ae400
Author: Gorebar 
Date:   2016-12-12T12:49:51Z

Add imports

commit 162a81eb86b15ecfaea612971c89a87e025df534
Author: Mèir Noordermeer 
Date:   2017-03-20T11:47:16Z

Merge branch 'master' of 
https://github.com/Gorebar/cordova-plugin-inappbrowser

commit c56232f31e520f9e9ebedb699b7fa0ad35e23000
Author: Mèir Noordermeer 
Date:   2017-03-20T15:03:35Z

Catch errors when user has not given storage permissions on Android

commit 7b6700ab2344b1321045403db2e85bda086c2792
Author: Mèir Noordermeer 
Date:   2017-03-20T15:51:15Z

Add isStoragePermissionGranted to DownloadListener and catch 
DownloadManager errors

commit f0cc7c4ee7473fbda29cf9a51db362ff7380e0cf
Author: Jonas Oliveira 
Date:   2017-04-14T15:07:41Z

External Storage permissions to AndroidManifest.xml

Without this the plugin cannot ask for user permissions

commit a72880146f4c74d51d1379baef501e935ec5
Author: Jonas Oliveira 
Date:   2017-04-14T15:15:23Z

Download file immediately after user authorize

Currently the user needs to click again do download after he authorizes
file privilegies, so I create a new class to handle the download code,
saving to memory (via class proprieties) the download url and other info
and handling the callback "onRequestPermissionResult"

I also have changed the requester to "cordova.requestPermission", maybe
this has compatibility problems with older versions of cordova or
cordova-android.

commit 4ea9e4f747d79cd6a97e49f5801b9177465bd3ab
Author: Jonas Oliveira 
Date:   2017-04-14T16:05:09Z

Change download folder to system default, instead of cache




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser issue #221: CB-12834: (android) Fix bug when ope...

[adirel]

Github user adirel commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/221
  
I join this request. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request #213: Add mandatory iOS 10 privacy descript...

[shishlina]

Github user shishlina closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/213


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org