FYI: Nightly builds moved to GitHub Actions
We've had nightly builds of the Cordova tooling and platforms for a few years now. Recently the ASF Infrastructure team was replacing the Jenkins system that previously ran them, so Bryan Ellis ported the build scripts over to GitHub actions. For those who are curious, the workflow lives in the Cordova-Coho repo: https://github.com/apache/cordova-coho/blob/master/.github/workflows/nightly.yml Thanks Bryan for porting Jenkins scripts to GitHub yml and making it more accessible and probably more reliable. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
Yes, that makes sense. What I meant was the opposite: When specifying a
range, it should not be fulfilled with a suffixed version.
On 2018-09-13 16:20, Chris Brody wrote:
If I would try the following command in master branch of
cordova-common (just an experiment):
npm install cordova-common@^3.0.0-nightly
I would see the following change in package.json:
"dependencies": {
-"cordova-common": "^2.2.0",
+"cordova-common": "^3.0.0-nightly.2018.9.13.9c6cda3d",
Next experiment (again just an experiment): remove generated
node_modules and package-lock.json artifacts (package-lock.json is not
yet committed in cordova-common and update package.json as follows:
diff --git a/package.json b/package.json
index 9f3bdc23..e488c149 100644
--- a/package.json
+++ b/package.json
@@ -19,3 +19,3 @@
"dependencies": {
-"cordova-common": "^2.2.0",
+"cordova-common": "^3.0.0-nightly",
"cordova-create": "^1.1.0",
then after npm install I get the following result from grep version
node_modules/cordova-common/package.json:
"version": "3.0.0-nightly.2018.9.13.9c6cda3d"
One more experiment: if I would try the following change to package.json:
diff --git a/package.json b/package.json
index 9f3bdc23..01c549dc 100644
--- a/package.json
+++ b/package.json
@@ -19,3 +19,3 @@
"dependencies": {
-"cordova-common": "^2.2.0",
+"cordova-common": "^2.2.1-nightly",
"cordova-create": "^1.1.0",
then do clean npm install (node_modules and package-lock.json
artifacts removed) I get the following result from grep version
node_modules/cordova-common/package.json:
"version": "2.2.5"
These results indicate to me that depending on "-rc" version with
caret (^) should do what we want: use latest "-rc" version available
until we publish the major release, and then use the major release.
FYI this seems to be documented in
https://github.com/npm/node-semver#prerelease-tags which is linked by
https://semver.npmjs.com/.
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
If I would try the following command in master branch of
cordova-common (just an experiment):
npm install cordova-common@^3.0.0-nightly
I would see the following change in package.json:
"dependencies": {
-"cordova-common": "^2.2.0",
+"cordova-common": "^3.0.0-nightly.2018.9.13.9c6cda3d",
Next experiment (again just an experiment): remove generated
node_modules and package-lock.json artifacts (package-lock.json is not
yet committed in cordova-common and update package.json as follows:
diff --git a/package.json b/package.json
index 9f3bdc23..e488c149 100644
--- a/package.json
+++ b/package.json
@@ -19,3 +19,3 @@
"dependencies": {
-"cordova-common": "^2.2.0",
+"cordova-common": "^3.0.0-nightly",
"cordova-create": "^1.1.0",
then after npm install I get the following result from grep version
node_modules/cordova-common/package.json:
"version": "3.0.0-nightly.2018.9.13.9c6cda3d"
One more experiment: if I would try the following change to package.json:
diff --git a/package.json b/package.json
index 9f3bdc23..01c549dc 100644
--- a/package.json
+++ b/package.json
@@ -19,3 +19,3 @@
"dependencies": {
-"cordova-common": "^2.2.0",
+"cordova-common": "^2.2.1-nightly",
"cordova-create": "^1.1.0",
then do clean npm install (node_modules and package-lock.json
artifacts removed) I get the following result from grep version
node_modules/cordova-common/package.json:
"version": "2.2.5"
These results indicate to me that depending on "-rc" version with
caret (^) should do what we want: use latest "-rc" version available
until we publish the major release, and then use the major release.
FYI this seems to be documented in
https://github.com/npm/node-semver#prerelease-tags which is linked by
https://semver.npmjs.com/.
On Thu, Sep 13, 2018 at 9:48 AM Oliver Salzburg
wrote:
>
> To my understanding, any suffixed version is never matched by a range.
> They have to be targeted explicitly.
>
> This can be easily observed at https://semver.npmjs.com/ by entering no
> range or *
>
> On 2018-09-13 12:53, Chris Brody wrote:
> > I would really favor the idea of publishing -rc suffixed versions to
> > resolve the dilemma discussed here. I would favor starting with something
> > like -rc.01 which could gracefully handle up to 99 rc versions.
> >
> > Assuming that -rc suffixed versions should be considered stable enough for
> > master then using caret (^) in dependencies means that we should be able to
> > do this just once per Cordova package in a major release.
> >
> > On Thu, Sep 13, 2018, 6:08 AM Oliver Salzburg
> > wrote:
> >
> >> Alright, as long as we're talking about a manual process to resolve this
> >> conflict temporarily, I see it as a valid suggestion.
> >> However, I would still prefer if a -rc.0 suffixed version was published
> >> and then depended upon, for clarity.
> >>
> >> On 2018-09-13 11:49, Jan Piotrowski wrote:
> >>> Chris didn't really mention the actual problem he tried to solve with
> >>> this PR in his initial email, and half the discussion here was about
> >>> something totally different.
> >>>
> >>> My understanding of what he did was that he tried to find a way to
> >>> test a new version of corova-create that requires new versions of
> >>> cordova-fetch and cordova-common, which have necessary updates in
> >>> master but that have not been released to npm yet. Setting the
> >>> dependencies to nightly releases theoretically makes this possible.
> >>>
> >>> An alternative solution of course is to create releases for
> >>> cordova-fetch and cordova-common first, then update cordova-create to
> >>> use those.
> >>>
> >>> Stumbling block here is that Cordova package releases seem to be a big
> >>> deal, historically, and quite some process to follow.
> >>> If we find a way to make cutting a release of a library a quick and
> >>> simple thing, this should be much less of an issue. Correct?
> >>>
> >>> -J
> >>>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
To my understanding, any suffixed version is never matched by a range. They have to be targeted explicitly. This can be easily observed at https://semver.npmjs.com/ by entering no range or * On 2018-09-13 12:53, Chris Brody wrote: I would really favor the idea of publishing -rc suffixed versions to resolve the dilemma discussed here. I would favor starting with something like -rc.01 which could gracefully handle up to 99 rc versions. Assuming that -rc suffixed versions should be considered stable enough for master then using caret (^) in dependencies means that we should be able to do this just once per Cordova package in a major release. On Thu, Sep 13, 2018, 6:08 AM Oliver Salzburg wrote: Alright, as long as we're talking about a manual process to resolve this conflict temporarily, I see it as a valid suggestion. However, I would still prefer if a -rc.0 suffixed version was published and then depended upon, for clarity. On 2018-09-13 11:49, Jan Piotrowski wrote: Chris didn't really mention the actual problem he tried to solve with this PR in his initial email, and half the discussion here was about something totally different. My understanding of what he did was that he tried to find a way to test a new version of corova-create that requires new versions of cordova-fetch and cordova-common, which have necessary updates in master but that have not been released to npm yet. Setting the dependencies to nightly releases theoretically makes this possible. An alternative solution of course is to create releases for cordova-fetch and cordova-common first, then update cordova-create to use those. Stumbling block here is that Cordova package releases seem to be a big deal, historically, and quite some process to follow. If we find a way to make cutting a release of a library a quick and simple thing, this should be much less of an issue. Correct? -J - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
I would really favor the idea of publishing -rc suffixed versions to resolve the dilemma discussed here. I would favor starting with something like -rc.01 which could gracefully handle up to 99 rc versions. Assuming that -rc suffixed versions should be considered stable enough for master then using caret (^) in dependencies means that we should be able to do this just once per Cordova package in a major release. On Thu, Sep 13, 2018, 6:08 AM Oliver Salzburg wrote: > Alright, as long as we're talking about a manual process to resolve this > conflict temporarily, I see it as a valid suggestion. > However, I would still prefer if a -rc.0 suffixed version was published > and then depended upon, for clarity. > > On 2018-09-13 11:49, Jan Piotrowski wrote: > > Chris didn't really mention the actual problem he tried to solve with > > this PR in his initial email, and half the discussion here was about > > something totally different. > > > > My understanding of what he did was that he tried to find a way to > > test a new version of corova-create that requires new versions of > > cordova-fetch and cordova-common, which have necessary updates in > > master but that have not been released to npm yet. Setting the > > dependencies to nightly releases theoretically makes this possible. > > > > An alternative solution of course is to create releases for > > cordova-fetch and cordova-common first, then update cordova-create to > > use those. > > > > Stumbling block here is that Cordova package releases seem to be a big > > deal, historically, and quite some process to follow. > > If we find a way to make cutting a release of a library a quick and > > simple thing, this should be much less of an issue. Correct? > > > > -J > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [DISCUSS] Update dependencies for nightly builds in master
Alright, as long as we're talking about a manual process to resolve this conflict temporarily, I see it as a valid suggestion. However, I would still prefer if a -rc.0 suffixed version was published and then depended upon, for clarity. On 2018-09-13 11:49, Jan Piotrowski wrote: Chris didn't really mention the actual problem he tried to solve with this PR in his initial email, and half the discussion here was about something totally different. My understanding of what he did was that he tried to find a way to test a new version of corova-create that requires new versions of cordova-fetch and cordova-common, which have necessary updates in master but that have not been released to npm yet. Setting the dependencies to nightly releases theoretically makes this possible. An alternative solution of course is to create releases for cordova-fetch and cordova-common first, then update cordova-create to use those. Stumbling block here is that Cordova package releases seem to be a big deal, historically, and quite some process to follow. If we find a way to make cutting a release of a library a quick and simple thing, this should be much less of an issue. Correct? -J - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
Chris didn't really mention the actual problem he tried to solve with this PR in his initial email, and half the discussion here was about something totally different. My understanding of what he did was that he tried to find a way to test a new version of corova-create that requires new versions of cordova-fetch and cordova-common, which have necessary updates in master but that have not been released to npm yet. Setting the dependencies to nightly releases theoretically makes this possible. An alternative solution of course is to create releases for cordova-fetch and cordova-common first, then update cordova-create to use those. Stumbling block here is that Cordova package releases seem to be a big deal, historically, and quite some process to follow. If we find a way to make cutting a release of a library a quick and simple thing, this should be much less of an issue. Correct? -J 2018-09-13 10:55 GMT+02:00 Oliver Salzburg : > On 2018-09-13 00:34, Chris Brody wrote: > >> In case of major version bump each Cordova package will continue to >> keep dependency on previous patch release of other packages until we >> make the new release. >> > Reading this makes me think I didn't understand an important part of the > discussion. Isn't this basic semantic versioning? > > If you have a 1.x of your main package, you want to release 2.x and you have > a dependency of which you want to include a newer version than is covered by > your current semver range, then update the range in your package.json before > you release 2.x. > > There is also nothing wrong with bumping dependency semver ranges in a > module in master. Then you can install the new dependency version when you > pull the latest changes and update your dependencies. This should obviously > only be done when there was an important change in the dependency that is > required in master. > > This seems very obvious and is covered thoroughly in at least the > documentation of npm. What am I missing? > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
On 2018-09-13 00:34, Chris Brody wrote: In case of major version bump each Cordova package will continue to keep dependency on previous patch release of other packages until we make the new release. Reading this makes me think I didn't understand an important part of the discussion. Isn't this basic semantic versioning? If you have a 1.x of your main package, you want to release 2.x and you have a dependency of which you want to include a newer version than is covered by your current semver range, then update the range in your package.json before you release 2.x. There is also nothing wrong with bumping dependency semver ranges in a module in master. Then you can install the new dependency version when you pull the latest changes and update your dependencies. This should obviously only be done when there was an important change in the dependency that is required in master. This seems very obvious and is covered thoroughly in at least the documentation of npm. What am I missing? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
I will close this and cordova-create#31 as not wanted. But I think the issue remains unresolved. In case of major version bump each Cordova package will continue to keep dependency on previous patch release of other packages until we make the new release. I think this should be documented. On Wed, Sep 12, 2018 at 5:06 PM wrote: > > > I think, if anything, what is needed is an overall test of all the pieces > > > together, but I don't think this means modifying every package.json of > > > every module every night. > > > > > > > That is exactly what my proposal aims to accomplish. > > > > I agree that we should test all the pieces together frequently. > We don't need to mess with our committed master versions for this. > Instead we should do nightly integration tests. That means we would be > modifying every package.json of every module every night. > __Temporarily, on the build server and NOT in the repository__ > > Finally, I agree with Oliver Salzburg. Setting up these tests will be some > work. > And I would rather not have the additional integration testing at all, than > to > regularly depend on nightly versions in master. > > Am Mi., 12. Sep. 2018 um 22:54 Uhr schrieb Chris Brody < > chris.br...@gmail.com>: > > > On Wed, Sep 12, 2018, 4:35 PM Jesse wrote: > > > > > nightly is just master on any given 'night' right? > > > > > > > Yes, that is my understanding. > > > > We don't want to update dependent versions of everything all the time ... > > > > > > > Agreed. My proposal would use the caret (^) character in the nightly > > dependency versions to automatically use the latest nightly build of each > > Cordova dependency (in master branch). > > > > I think, if anything, what is needed is an overall test of all the pieces > > > together, but I don't think this means modifying every package.json of > > > every module every night. > > > > > > > That is exactly what my proposal aims to accomplish. > > > > If we wanted more flexibility, maybe the git-master version of each > > > package.json points at the git-master of each other module ... but I > > don't > > > think this helps us. > > > > > > > That would have been a worthwhile solution if we did not have the nightly > > packages published on npm. Since we do have the nightly packages published > > on npm then yes that idea is not needed. > > > > I think is is best to just expect that things are going to break, > > > > > > Yes > > > > and we will have to resolve dependencies when we choose to release. > > > > > > > As I said before: according to my proposal we should be able to drop the > > "-nightly*" part from dependency versions when making major releases. > > > > The one criticism that I would agree with is that I don't see anyone else > > working quite this way. If this proposal is accepted I think it should be > > documented thoroughly and carefully. > > > > In case this proposal is accepted, I am thinking we may want to rename the > > default branch to something like "edge", "dev", or "unstable" to better > > reflect the actual less-stable situation. > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
> I think, if anything, what is needed is an overall test of all the pieces > > together, but I don't think this means modifying every package.json of > > every module every night. > > > > That is exactly what my proposal aims to accomplish. > I agree that we should test all the pieces together frequently. We don't need to mess with our committed master versions for this. Instead we should do nightly integration tests. That means we would be modifying every package.json of every module every night. __Temporarily, on the build server and NOT in the repository__ Finally, I agree with Oliver Salzburg. Setting up these tests will be some work. And I would rather not have the additional integration testing at all, than to regularly depend on nightly versions in master. Am Mi., 12. Sep. 2018 um 22:54 Uhr schrieb Chris Brody < chris.br...@gmail.com>: > On Wed, Sep 12, 2018, 4:35 PM Jesse wrote: > > > nightly is just master on any given 'night' right? > > > > Yes, that is my understanding. > > We don't want to update dependent versions of everything all the time ... > > > > Agreed. My proposal would use the caret (^) character in the nightly > dependency versions to automatically use the latest nightly build of each > Cordova dependency (in master branch). > > I think, if anything, what is needed is an overall test of all the pieces > > together, but I don't think this means modifying every package.json of > > every module every night. > > > > That is exactly what my proposal aims to accomplish. > > If we wanted more flexibility, maybe the git-master version of each > > package.json points at the git-master of each other module ... but I > don't > > think this helps us. > > > > That would have been a worthwhile solution if we did not have the nightly > packages published on npm. Since we do have the nightly packages published > on npm then yes that idea is not needed. > > I think is is best to just expect that things are going to break, > > > Yes > > and we will have to resolve dependencies when we choose to release. > > > > As I said before: according to my proposal we should be able to drop the > "-nightly*" part from dependency versions when making major releases. > > The one criticism that I would agree with is that I don't see anyone else > working quite this way. If this proposal is accepted I think it should be > documented thoroughly and carefully. > > In case this proposal is accepted, I am thinking we may want to rename the > default branch to something like "edge", "dev", or "unstable" to better > reflect the actual less-stable situation. >
Re: [DISCUSS] Update dependencies for nightly builds in master
On Wed, Sep 12, 2018, 4:35 PM Jesse wrote: > nightly is just master on any given 'night' right? > Yes, that is my understanding. We don't want to update dependent versions of everything all the time ... > Agreed. My proposal would use the caret (^) character in the nightly dependency versions to automatically use the latest nightly build of each Cordova dependency (in master branch). I think, if anything, what is needed is an overall test of all the pieces > together, but I don't think this means modifying every package.json of > every module every night. > That is exactly what my proposal aims to accomplish. If we wanted more flexibility, maybe the git-master version of each > package.json points at the git-master of each other module ... but I don't > think this helps us. > That would have been a worthwhile solution if we did not have the nightly packages published on npm. Since we do have the nightly packages published on npm then yes that idea is not needed. I think is is best to just expect that things are going to break, Yes and we will have to resolve dependencies when we choose to release. > As I said before: according to my proposal we should be able to drop the "-nightly*" part from dependency versions when making major releases. The one criticism that I would agree with is that I don't see anyone else working quite this way. If this proposal is accepted I think it should be documented thoroughly and carefully. In case this proposal is accepted, I am thinking we may want to rename the default branch to something like "edge", "dev", or "unstable" to better reflect the actual less-stable situation.
Re: [DISCUSS] Update dependencies for nightly builds in master
On Wed, Sep 12, 2018 at 12:29 PM Chris Brody wrote: > > Potentially controversial proposal. > > For example: https://github.com/apache/cordova-create/pull/31 > > The proposal is that Cordova packages in the master branch should > depend on nightly builds, not on old patch release. > > If accepted, I think we should apply a similar change to the master > branch of all other Cordova tools and platform packages. > > I think this would give us better integrity of nightly builds. We should not need to make any changes to the master branch for nightlies to point at other nightlies. As part of the nightly build process, all the other cordova dependencies of each module are updated to point to the equivalent nightly versions. So cordova-cli@nightly-x.y.z is using cordova-create@nightly-x.y.z and cordova-lib@nightly-x.y.z and cordova-common@nightly.x.y.z. They reference those explicitly, not using the "nightly" tag. We should definitely NOT be pointing anything on the master branch to specific nightly builds. It should point to whatever version (even unreleased) we depend on, with a ^ caret so npm will grab the latest. Reminder that nightly builds are for Cordova developer testing, not for use by end users because they are not approved releases per Apache policy. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
I agree that this kind of situation should be addressed by a proper release of the dependency. If it's a breaking change, so be it. I don't mind if we have cordova-common 23.5.7 in a year from now. Am Mi., 12. Sep. 2018 um 22:44 Uhr schrieb Oliver Salzburg < oliver.salzb...@gmail.com>: > On 2018-09-12 22:40, Jan Piotrowski wrote: > > cordova-create uses cordova-common and cordova-fetch. Right now two > > existing releases are pinned as dependencies. cordova-common and > > cordova-fetch have changes in master, that are necessary for new > > things in cordova-create to work. Right now there is no way to change > > cordova-create to do this. Using nightly of cordova-comand and > > cordova-fetch would enable this. Correct? > > Why not just publish the new version? I mean, properly, not a -nightly. > > Then the projects could depend on these new versions on work properly in > master as well. > > For the time being, the -nightly release would work fine for the > purpose, but something like that should be occasional, not regular. I > believe the latter case would produce more failures than it solves. > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [DISCUSS] Update dependencies for nightly builds in master
On 2018-09-12 22:40, Jan Piotrowski wrote: > cordova-create uses cordova-common and cordova-fetch. Right now two > existing releases are pinned as dependencies. cordova-common and > cordova-fetch have changes in master, that are necessary for new > things in cordova-create to work. Right now there is no way to change > cordova-create to do this. Using nightly of cordova-comand and > cordova-fetch would enable this. Correct? Why not just publish the new version? I mean, properly, not a -nightly. Then the projects could depend on these new versions on work properly in master as well. For the time being, the -nightly release would work fine for the purpose, but something like that should be occasional, not regular. I believe the latter case would produce more failures than it solves. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
On 2018-09-12 22:31, raphine...@gmail.com wrote: > Yeah, I mean that's what we do with the nightlies already. I agree that it > would be great to be notified of integration problems ASAP. But to achieve > that, we should test the nightlies produced during the nightly build. On 2018-09-12 21:36, Jan Piotrowski wrote: > How do other libraries handle this inter-connectedness between libraries? That is what we do. We don't produce nightly builds, we trigger integration jobs on each build of a dependency. The integration job checks the latest snapshot of the dependency against its dependents. That's a bit of work to set up, but I would rather just not do it at all then start committing nightly versions into your dependency tree. This will lead to you constantly having to rebuild your local dependency tree on every git pull. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
Another aspect I thought this should solve: cordova-create uses cordova-common and cordova-fetch. Right now two existing releases are pinned as dependencies. cordova-common and cordova-fetch have changes in master, that are necessary for new things in cordova-create to work. Right now there is no way to change cordova-create to do this. Using nightly of cordova-comand and cordova-fetch would enable this. Correct? 2018-09-12 22:34 GMT+02:00 Jesse : > nightly is just master on any given 'night' right? > We don't want to update dependent versions of everything all the time ... > > I think, if anything, what is needed is an overall test of all the pieces > together, but I don't think this means modifying every package.json of > every module every night. > If we wanted more flexibility, maybe the git-master version of each > package.json points at the git-master of each other module ... but I don't > think this helps us. > I think is is best to just expect that things are going to break, and we > will have to resolve dependencies when we choose to release. > > > > @purplecabbage > risingj.com > > > On Wed, Sep 12, 2018 at 1:27 PM Oliver Salzburg > wrote: > >> On 2018-09-12 21:29, Chris Brody wrote: >> > I think this would give us better integrity of nightly builds. >> >> I don't think I understand the proposal. >> >> If the goal is to produce nightly builds, why not change the dependency >> version during the nightly build, publish the nightly and leave master >> dependent on the stable dependency? >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
nightly is just master on any given 'night' right? We don't want to update dependent versions of everything all the time ... I think, if anything, what is needed is an overall test of all the pieces together, but I don't think this means modifying every package.json of every module every night. If we wanted more flexibility, maybe the git-master version of each package.json points at the git-master of each other module ... but I don't think this helps us. I think is is best to just expect that things are going to break, and we will have to resolve dependencies when we choose to release. @purplecabbage risingj.com On Wed, Sep 12, 2018 at 1:27 PM Oliver Salzburg wrote: > On 2018-09-12 21:29, Chris Brody wrote: > > I think this would give us better integrity of nightly builds. > > I don't think I understand the proposal. > > If the goal is to produce nightly builds, why not change the dependency > version during the nightly build, publish the nightly and leave master > dependent on the stable dependency? > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [DISCUSS] Update dependencies for nightly builds in master
Yeah, I mean that's what we do with the nightlies already. I agree that it would be great to be notified of integration problems ASAP. But to achieve that, we should test the nightlies produced during the nightly build. Am Mi., 12. Sep. 2018 um 22:27 Uhr schrieb Oliver Salzburg < oliver.salzb...@gmail.com>: > On 2018-09-12 21:29, Chris Brody wrote: > > I think this would give us better integrity of nightly builds. > > I don't think I understand the proposal. > > If the goal is to produce nightly builds, why not change the dependency > version during the nightly build, publish the nightly and leave master > dependent on the stable dependency? > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [DISCUSS] Update dependencies for nightly builds in master
On 2018-09-12 21:29, Chris Brody wrote: > I think this would give us better integrity of nightly builds. I don't think I understand the proposal. If the goal is to produce nightly builds, why not change the dependency version during the nightly build, publish the nightly and leave master dependent on the stable dependency? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
> > Plus, with package-lock.json committed no version update would be picked up > automatically. That's the idea behind committing it in the first place. > Newer versions of npm seemed to respect the caret (^) when making package-lock.json; caret seemed to show up in package-lock.json. But I may be mistaken here. I would be happy to experiment and test this sometime later today or tonight.
Re: [DISCUSS] Update dependencies for nightly builds in master
Am Mi., 12. Sep. 2018 um 22:01 Uhr schrieb Chris Brody < chris.br...@gmail.com>: > On Wed, Sep 12, 2018 at 3:48 PM wrote: > > > > Am Mi., 12. Sep. 2018 um 21:36 Uhr schrieb Jan Piotrowski < > > piotrow...@gmail.com>: > > > > > This uses specific nightlies the developer has to select manually, > right? > > > > > I would say it would have to, since nightly alone would be an unstable > > moving target that would regularly break our CI tests. > > I would disagree. I thought that work in master branch *should* > already be considered to be a non-stable "dev" version. If a change in > a lower-level dependency would causes another Cordova package to stop > working, I would rather we discover and resolve this asap. > Well then we agree to disagree ;) IMHO, CI tests should run against a known-to-work state, so we can reliably see from the CI tests if a __PR__ breaks the tests or not. If we want to test integration between Cordova components, we should run tests with all the master branches linked together during our nightly builds. Plus, with package-lock.json committed no version update would be picked up automatically. That's the idea behind committing it in the first place. > > > How do other libraries handle this inter-connectedness between > libraries? > > > > You could have a look at Babel. They have a lot of packages (managed by > > lerna AFAIK) > > Does that mean we should consider migrating to some kind of a monorepo? > No, I was not suggesting anything. Just mentioning that they used it.
Re: [DISCUSS] Update dependencies for nightly builds in master
On Wed, Sep 12, 2018 at 3:48 PM wrote: > > Am Mi., 12. Sep. 2018 um 21:36 Uhr schrieb Jan Piotrowski < > piotrow...@gmail.com>: > > > This uses specific nightlies the developer has to select manually, right? > > > I would say it would have to, since nightly alone would be an unstable > moving target that would regularly break our CI tests. I would disagree. I thought that work in master branch *should* already be considered to be a non-stable "dev" version. If a change in a lower-level dependency would causes another Cordova package to stop working, I would rather we discover and resolve this asap. FYI a command like npm install cordova-fetch@nightly would normally uses a caret (^). This should match all newer nightly builds and even continue to match once we publish major release of the dependency. The one caveat here is that the nightly build name seems to not always use 2-digit month number. I would propose the following alternative workaround solutions: * manually remove everything after the year in the nightly build version number * we fix the nightly build server to always use 2-digit month and hold off until October or November 2018 > > How would this change the release process? Another commit to change > > and pin the dependency? > > > I think this shouldn't change anything regarding the release process. It > just changes the version we are switching away from during release. Right. We would probably just want to drop the "-nightly*" from the dependency version number for clarity. > > How do other libraries handle this inter-connectedness between libraries? > > You could have a look at Babel. They have a lot of packages (managed by > lerna AFAIK) Does that mean we should consider migrating to some kind of a monorepo? If so, I would rather to discuss this idea in its own thread. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Update dependencies for nightly builds in master
Am Mi., 12. Sep. 2018 um 21:36 Uhr schrieb Jan Piotrowski < piotrow...@gmail.com>: > This uses specific nightlies the developer has to select manually, right? > I would say it would have to, since nightly alone would be an unstable moving target that would regularly break our CI tests. > How would this change the release process? Another commit to change > and pin the dependency? > I think this shouldn't change anything regarding the release process. It just changes the version we are switching away from during release. > How do other libraries handle this inter-connectedness between libraries? You could have a look at Babel. They have a lot of packages (managed by lerna AFAIK)
Re: [DISCUSS] Update dependencies for nightly builds in master
Interesting suggestion, had a similar discussion with @Erisu today. This uses specific nightlies the developer has to select manually, right? How would this change the release process? Another commit to change and pin the dependency? How do other libraries handle this inter-connectedness between libraries? -J 2018-09-12 21:29 GMT+02:00 Chris Brody : > Potentially controversial proposal. > > For example: https://github.com/apache/cordova-create/pull/31 > > The proposal is that Cordova packages in the master branch should > depend on nightly builds, not on old patch release. > > If accepted, I think we should apply a similar change to the master > branch of all other Cordova tools and platform packages. > > I think this would give us better integrity of nightly builds. > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] Update dependencies for nightly builds in master
Potentially controversial proposal. For example: https://github.com/apache/cordova-create/pull/31 The proposal is that Cordova packages in the master branch should depend on nightly builds, not on old patch release. If accepted, I think we should apply a similar change to the master branch of all other Cordova tools and platform packages. I think this would give us better integrity of nightly builds. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Nightly builds
Thanks Darryl! On Thu, Jul 19, 2018 at 1:05 PM Darryl Pogue wrote: > > Apologies for the Jenkins spam, the builds were failing after npm > revoked all auth tokens and we needed to reauthenticate. > > I've figured that part out, so our nightly builds are back to usually > failing for flaky reasons instead of consistently failing for auth > reasons. It's an improvement... of sorts... > > ~Darryl > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Nightly builds
Apologies for the Jenkins spam, the builds were failing after npm revoked all auth tokens and we needed to reauthenticate. I've figured that part out, so our nightly builds are back to usually failing for flaky reasons instead of consistently failing for auth reasons. It's an improvement... of sorts... ~Darryl - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [NIGHTLY BUILDS] Missing
yay! @purplecabbage risingj.com On Wed, Mar 22, 2017 at 11:18 PM, Filip Maj wrote: > yay! that seemed to have fixed it! > > On Tue, Mar 21, 2017 at 10:51 PM, Filip Maj wrote: > > Just added apachebuilds as owner to both cordova-android and cordova-ios. > > > > On Tue, Mar 21, 2017 at 8:10 PM, Darryl Pogue > wrote: > >> Hey Vladimir, > >> > >> I noticed we were getting Jenkins build failures for the nightlies, > >> but it was correctly publishing cordova-lib and cordova nightlies to > >> npm. It's failing on cordova-android with a permissions error. > >> It looks to me like the only thing we need to do to get these working > >> is to grant publish permissions on cordova-android (and probably > >> cordova-ios) to the apachebuilds npm user? > >> > >> One of the npm owners want to give that a shot? In particular, it > >> would be nice to have nightly builds for Android while we're trying to > >> verify the new Android SDK fixes. > >> > >> ~Darryl > >> > >> On 15 February 2017 at 01:36, Vladimir Kotikov (Akvelon) > >> wrote: > >>> > >>> Hey Shazron and Fil > >>> > >>> The thing with nightly builds is that they are running (or it’d better > to say they had been running until Dec, 9) on Apache infrastructure. More > specifically, this is a build job that is used to run ‘coho nightly’: > https://builds.apache.org/view/All/job/cordova-nightly > >>> > >>> There were 2 issues: > >>> 1. job was using node label that doesn’t have any nodes attached – it > has been changed by infra at the mid of November > >>> 2. NPM credentials, we were using to publish nightlies (user > apachebuilds, https://www.npmjs.com/~apachebuilds) are now incorrect, at > least I’m not able to login to NPM with these credentials. > >>> > >>> I have updated the job to run on proper set of nodes, but until we get > new credentials (or at least valid token) we’re blocked on this. > >>> > >>> - > >>> Best regards, Vladimir > >>> > >>> > >>> On 2/15/17, 03:58, "Filip Maj" wrote: > >>> > >>> I recall Alex saying he enabled parallel builds on cloudapp within > the > >>> last week, sounds like it might be relevant. We'll need our MSFT > >>> friends and cloudapp admins to rescue us in this situation! > >>> > >>> On Tue, Feb 14, 2017 at 4:12 PM, Shazron > wrote: > >>> > I believe they don't run anymore. The last one was on > >>> > 2016-12-09T03:21:01.541Z > >>> > > >>> > Does anyone know what happened? > >>> > >>> > - > >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >>> For additional commands, e-mail: dev-h...@cordova.apache.org > >>> > >>> > >>> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >> For additional commands, e-mail: dev-h...@cordova.apache.org > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [NIGHTLY BUILDS] Missing
yay! that seemed to have fixed it! On Tue, Mar 21, 2017 at 10:51 PM, Filip Maj wrote: > Just added apachebuilds as owner to both cordova-android and cordova-ios. > > On Tue, Mar 21, 2017 at 8:10 PM, Darryl Pogue wrote: >> Hey Vladimir, >> >> I noticed we were getting Jenkins build failures for the nightlies, >> but it was correctly publishing cordova-lib and cordova nightlies to >> npm. It's failing on cordova-android with a permissions error. >> It looks to me like the only thing we need to do to get these working >> is to grant publish permissions on cordova-android (and probably >> cordova-ios) to the apachebuilds npm user? >> >> One of the npm owners want to give that a shot? In particular, it >> would be nice to have nightly builds for Android while we're trying to >> verify the new Android SDK fixes. >> >> ~Darryl >> >> On 15 February 2017 at 01:36, Vladimir Kotikov (Akvelon) >> wrote: >>> >>> Hey Shazron and Fil >>> >>> The thing with nightly builds is that they are running (or it’d better to >>> say they had been running until Dec, 9) on Apache infrastructure. More >>> specifically, this is a build job that is used to run ‘coho nightly’: >>> https://builds.apache.org/view/All/job/cordova-nightly >>> >>> There were 2 issues: >>> 1. job was using node label that doesn’t have any nodes attached – it has >>> been changed by infra at the mid of November >>> 2. NPM credentials, we were using to publish nightlies (user apachebuilds, >>> https://www.npmjs.com/~apachebuilds) are now incorrect, at least I’m not >>> able to login to NPM with these credentials. >>> >>> I have updated the job to run on proper set of nodes, but until we get new >>> credentials (or at least valid token) we’re blocked on this. >>> >>> - >>> Best regards, Vladimir >>> >>> >>> On 2/15/17, 03:58, "Filip Maj" wrote: >>> >>> I recall Alex saying he enabled parallel builds on cloudapp within the >>> last week, sounds like it might be relevant. We'll need our MSFT >>> friends and cloudapp admins to rescue us in this situation! >>> >>> On Tue, Feb 14, 2017 at 4:12 PM, Shazron wrote: >>> > I believe they don't run anymore. The last one was on >>> > 2016-12-09T03:21:01.541Z >>> > >>> > Does anyone know what happened? >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> For additional commands, e-mail: dev-h...@cordova.apache.org >>> >>> >>> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [NIGHTLY BUILDS] Missing
Just added apachebuilds as owner to both cordova-android and cordova-ios. On Tue, Mar 21, 2017 at 8:10 PM, Darryl Pogue wrote: > Hey Vladimir, > > I noticed we were getting Jenkins build failures for the nightlies, > but it was correctly publishing cordova-lib and cordova nightlies to > npm. It's failing on cordova-android with a permissions error. > It looks to me like the only thing we need to do to get these working > is to grant publish permissions on cordova-android (and probably > cordova-ios) to the apachebuilds npm user? > > One of the npm owners want to give that a shot? In particular, it > would be nice to have nightly builds for Android while we're trying to > verify the new Android SDK fixes. > > ~Darryl > > On 15 February 2017 at 01:36, Vladimir Kotikov (Akvelon) > wrote: >> >> Hey Shazron and Fil >> >> The thing with nightly builds is that they are running (or it’d better to >> say they had been running until Dec, 9) on Apache infrastructure. More >> specifically, this is a build job that is used to run ‘coho nightly’: >> https://builds.apache.org/view/All/job/cordova-nightly >> >> There were 2 issues: >> 1. job was using node label that doesn’t have any nodes attached – it has >> been changed by infra at the mid of November >> 2. NPM credentials, we were using to publish nightlies (user apachebuilds, >> https://www.npmjs.com/~apachebuilds) are now incorrect, at least I’m not >> able to login to NPM with these credentials. >> >> I have updated the job to run on proper set of nodes, but until we get new >> credentials (or at least valid token) we’re blocked on this. >> >> - >> Best regards, Vladimir >> >> >> On 2/15/17, 03:58, "Filip Maj" wrote: >> >> I recall Alex saying he enabled parallel builds on cloudapp within the >> last week, sounds like it might be relevant. We'll need our MSFT >> friends and cloudapp admins to rescue us in this situation! >> >> On Tue, Feb 14, 2017 at 4:12 PM, Shazron wrote: >> > I believe they don't run anymore. The last one was on >> > 2016-12-09T03:21:01.541Z >> > >> > Does anyone know what happened? >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> >> > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [NIGHTLY BUILDS] Missing
Hey Vladimir, I noticed we were getting Jenkins build failures for the nightlies, but it was correctly publishing cordova-lib and cordova nightlies to npm. It's failing on cordova-android with a permissions error. It looks to me like the only thing we need to do to get these working is to grant publish permissions on cordova-android (and probably cordova-ios) to the apachebuilds npm user? One of the npm owners want to give that a shot? In particular, it would be nice to have nightly builds for Android while we're trying to verify the new Android SDK fixes. ~Darryl On 15 February 2017 at 01:36, Vladimir Kotikov (Akvelon) wrote: > > Hey Shazron and Fil > > The thing with nightly builds is that they are running (or it’d better to say > they had been running until Dec, 9) on Apache infrastructure. More > specifically, this is a build job that is used to run ‘coho nightly’: > https://builds.apache.org/view/All/job/cordova-nightly > > There were 2 issues: > 1. job was using node label that doesn’t have any nodes attached – it has > been changed by infra at the mid of November > 2. NPM credentials, we were using to publish nightlies (user apachebuilds, > https://www.npmjs.com/~apachebuilds) are now incorrect, at least I’m not able > to login to NPM with these credentials. > > I have updated the job to run on proper set of nodes, but until we get new > credentials (or at least valid token) we’re blocked on this. > > - > Best regards, Vladimir > > > On 2/15/17, 03:58, "Filip Maj" wrote: > > I recall Alex saying he enabled parallel builds on cloudapp within the > last week, sounds like it might be relevant. We'll need our MSFT > friends and cloudapp admins to rescue us in this situation! > > On Tue, Feb 14, 2017 at 4:12 PM, Shazron wrote: > > I believe they don't run anymore. The last one was on > > 2016-12-09T03:21:01.541Z > > > > Does anyone know what happened? > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [NIGHTLY BUILDS] Missing
Hey Shazron and Fil The thing with nightly builds is that they are running (or it’d better to say they had been running until Dec, 9) on Apache infrastructure. More specifically, this is a build job that is used to run ‘coho nightly’: https://builds.apache.org/view/All/job/cordova-nightly There were 2 issues: 1. job was using node label that doesn’t have any nodes attached – it has been changed by infra at the mid of November 2. NPM credentials, we were using to publish nightlies (user apachebuilds, https://www.npmjs.com/~apachebuilds) are now incorrect, at least I’m not able to login to NPM with these credentials. I have updated the job to run on proper set of nodes, but until we get new credentials (or at least valid token) we’re blocked on this. - Best regards, Vladimir On 2/15/17, 03:58, "Filip Maj" wrote: I recall Alex saying he enabled parallel builds on cloudapp within the last week, sounds like it might be relevant. We'll need our MSFT friends and cloudapp admins to rescue us in this situation! On Tue, Feb 14, 2017 at 4:12 PM, Shazron wrote: > I believe they don't run anymore. The last one was on > 2016-12-09T03:21:01.541Z > > Does anyone know what happened? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [NIGHTLY BUILDS] Missing
I recall Alex saying he enabled parallel builds on cloudapp within the last week, sounds like it might be relevant. We'll need our MSFT friends and cloudapp admins to rescue us in this situation! On Tue, Feb 14, 2017 at 4:12 PM, Shazron wrote: > I believe they don't run anymore. The last one was on > 2016-12-09T03:21:01.541Z > > Does anyone know what happened? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[NIGHTLY BUILDS] Missing
I believe they don't run anymore. The last one was on 2016-12-09T03:21:01.541Z Does anyone know what happened?
[GitHub] cordova-docs pull request #641: CB-11884 - Edit Nightly Builds page based on...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/641 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #641: CB-11884 - Edit Nightly Builds page based on...
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/641 CB-11884 - Edit Nightly Builds page based on Apache Board feedback You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-docs CB-11884 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/641.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #641 commit 2e1526f1378387501da93f5f53404fa1dada5cdf Author: Shazron Abdullah Date: 2016-09-23T19:20:23Z CB-11884 - Edit Nightly Builds page based on Apache Board feedback --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Nightly builds - npm publish issue
FYI. In case if anyone else is interested - coho just invokes 'npm publish', so in order to fix nightiles we've updated npm used by nightly job on Jenkins to 3.10.x., so nightlies are now alive again. - Best regards, Vladimir -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Monday, August 29, 2016 11:23 AM To: dev@cordova.apache.org Subject: Nightly builds - npm publish issue See: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-11778&data=01%7c01%7cv-vlkoti%40microsoft.com%7c7309836d15dd4071566a08d3cfe5c2b1%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=n1hRjVzXVZbRJYRrsdJb71DohM6x758AquTlPwpBtWU%3d Long story short -- we need to use node 6.x to publish the npm nightlies. I know the nightly CI uses coho, is it a matter of just updating coho code and the CI picks it up, or do we have to do something else?
Nightly builds - npm publish issue
See: https://issues.apache.org/jira/browse/CB-11778 Long story short -- we need to use node 6.x to publish the npm nightlies. I know the nightly CI uses coho, is it a matter of just updating coho code and the CI picks it up, or do we have to do something else?
[GitHub] cordova-docs issue #613: CB-11477 Add a page about nightly builds
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-docs/pull/613 Updated and merged. Thanks, @dblotsky, @stevengill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #613: CB-11477 Add a page about nightly builds
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/613 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #613: CB-11477 Add a page about nightly builds
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/613 LGTM. Want me to merge it in? Maybe make the change @dblotsky recommended. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #613: CB-11477 Add a page about nightly builds
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/613#discussion_r73905131
--- Diff: www/contribute/index.html ---
@@ -22,6 +22,7 @@
Join the Dev mailing
list and send a brief introduction of yourself to it
Join the discussion on http://slack.cordova.io/";>Slack
Sign the http://www.apache.org/licenses/#clas";>Individual Contributor License
Agreement (ICLA) and mailto:secret...@apache.org";>submit
it
+Try out the next version of Cordova using nightly builds
--- End diff --
Maybe use an absolute link like `{{ site.baseurl
}}/contribute/nightly_builds.html` here, in case this page ever moves.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #613: CB-11477 Add a page about nightly builds
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-docs/pull/613 @stevengill, ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #613: CB-11477 Add a page about nightly builds
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-docs/pull/613 @nikhilkh, @stevengill, could you please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #613: CB-11477 Add a page about nightly builds
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/613 CB-11477 Add a page about nightly builds The PR adds a separate page under `contributing` directory with the information about nightly builds usage You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladimir-kotikov/cordova-docs CB-11477 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/613.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #613 commit 962ff2de488b76845641d4790417b81e5216a26f Author: Vladimir Kotikov Date: 2016-06-23T14:26:46Z CB-11477 Add a page about nightly builds --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [DISCUSS] Nightly builds for Cordova
Yeah, right. I somehow pasted the wrong link, sorry. The correct one is https://github.com/cordova/cordova-discuss/pull/47 - Best regards, Vladimir -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Saturday, May 14, 2016 1:53 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Nightly builds for Cordova Is it here instead? https://github.com/cordova/cordova-discuss/pull/47 +1 Just to emphasize from the PR discussion, nightlies are fine, they are not considered official releases and should have the appropriate disclaimers. From: https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.apache.org%2fdev%2frelease.html%23what&data=01%7c01%7cv-vlkoti%40microsoft.com%7cb08cb5309b6f41043bff08d37b817998%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=xpUOvLFJyJ4o76BNCvRtXzNvGhSAQbhKtYYWXoLv7o4%3d "Do not include any links on the project website that might encourage non-developers to download and use nightly builds, snapshots, release candidates, or any other similar package." My interpretation is, don't put the nightly links on the main page to install Cordova, which is the main page that we tell "users" to install it. "Devs" is of course those developing Cordova itself. Precedent (from what Vladimir K has posted): https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fant.apache.org%2fnightlies.html&data=01%7c01%7cv-vlkoti%40microsoft.com%7cb08cb5309b6f41043bff08d37b817998%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=C4OEA0eVBmK%2fI7Zy570o%2bEphIu1OAsM99T00T75KB04%3d --> Under "Contributing" https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fjmeter.apache.org%2fnightly.html&data=01%7c01%7cv-vlkoti%40microsoft.com%7cb08cb5309b6f41043bff08d37b817998%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=0%2bZ7mcECdP6H7uKpboN86HsSGgxKWU6AsTXkr7xgSc0%3d --> Under "Downloads" https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fzookeeper.apache.org%2freleases.html&data=01%7c01%7cv-vlkoti%40microsoft.com%7cb08cb5309b6f41043bff08d37b817998%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=IqJCaQOpzRfPLYnZqQPJDcRe4s9IdAmsNVC1ZIvNSjw%3d --> Under "Releases" (mixed stable, and alpha) https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fcouchdb.apache.org%2f%23download&data=01%7c01%7cv-vlkoti%40microsoft.com%7cb08cb5309b6f41043bff08d37b817998%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=9GNwl6w2ROhsWpZYXXw8J8RZL52YfjGaefE81nv0QJg%3d -> Under "Download", Developer Preview section. To be absolutely clear that this is a dev thing, we should put the nightly link under https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fcordova.apache.org%2fcontribute%2f&data=01%7c01%7cv-vlkoti%40microsoft.com%7cb08cb5309b6f41043bff08d37b817998%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=d6ouf5k%2bozwWRWCc6%2btsa1ddjvTbPePzK4Ly3Snp4cI%3d On Fri, May 13, 2016 at 2:14 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Hi list > > I've created a proposal for releasing nightly builds for Cordova. > Please find details here: https://github.com/cordova/cordova-discuss/pull/42. > I will appreciate any suggestions and feedback. > > - > Best regards, Vladimir > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [DISCUSS] Nightly builds for Cordova
Is it here instead? https://github.com/cordova/cordova-discuss/pull/47 +1 Just to emphasize from the PR discussion, nightlies are fine, they are not considered official releases and should have the appropriate disclaimers. From: http://www.apache.org/dev/release.html#what "Do not include any links on the project website that might encourage non-developers to download and use nightly builds, snapshots, release candidates, or any other similar package." My interpretation is, don't put the nightly links on the main page to install Cordova, which is the main page that we tell "users" to install it. "Devs" is of course those developing Cordova itself. Precedent (from what Vladimir K has posted): https://ant.apache.org/nightlies.html --> Under "Contributing" http://jmeter.apache.org/nightly.html --> Under "Downloads" http://zookeeper.apache.org/releases.html --> Under "Releases" (mixed stable, and alpha) http://couchdb.apache.org/#download -> Under "Download", Developer Preview section. To be absolutely clear that this is a dev thing, we should put the nightly link under http://cordova.apache.org/contribute/ On Fri, May 13, 2016 at 2:14 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Hi list > > I've created a proposal for releasing nightly builds for Cordova. Please > find details here: https://github.com/cordova/cordova-discuss/pull/42. > I will appreciate any suggestions and feedback. > > - > Best regards, Vladimir > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [DISCUSS] Nightly builds for Cordova
Love it +1 Always wanted to be able to $ npm install -g cordova@canary - Carlos @csantanapr > On May 13, 2016, at 5:14 AM, Vladimir Kotikov (Akvelon) > wrote: > > Hi list > > I've created a proposal for releasing nightly builds for Cordova. Please find > details here: https://github.com/cordova/cordova-discuss/pull/42. > I will appreciate any suggestions and feedback. > > - > Best regards, Vladimir > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] Nightly builds for Cordova
Hi list I've created a proposal for releasing nightly builds for Cordova. Please find details here: https://github.com/cordova/cordova-discuss/pull/42. I will appreciate any suggestions and feedback. - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Cordova Nightly Builds
Can we also run Medic on these nightlies ? My team could volunteer to do that work, if you guys think it is useful. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Monday, November 3, 2014 7:58 PM To: dev Subject: Re: Cordova Nightly Builds so long as we unpublish old ones, I believe the list of versions shouldn't grow indefinitely. On Mon, Nov 3, 2014 at 4:42 PM, Marcel Kinard wrote: > Nice! > > Doing an "npm info cordova" will yield a nightly-increasing number of > entries in the 'version' key? > > These would not be artifacts that we could vote on, correct? > > On Oct 30, 2014, at 1:16 AM, Steven Gill wrote: > > > I have been doing some work on releasing nightlys recently. > > > > Please review PR [1] and comment on the issue [2]. > > > > [1] https://github.com/apache/cordova-coho/pull/58 > > [2] https://issues.apache.org/jira/browse/CB-7904 > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova Nightly Builds
so long as we unpublish old ones, I believe the list of versions shouldn't grow indefinitely. On Mon, Nov 3, 2014 at 4:42 PM, Marcel Kinard wrote: > Nice! > > Doing an "npm info cordova" will yield a nightly-increasing number of > entries in the 'version' key? > > These would not be artifacts that we could vote on, correct? > > On Oct 30, 2014, at 1:16 AM, Steven Gill wrote: > > > I have been doing some work on releasing nightlys recently. > > > > Please review PR [1] and comment on the issue [2]. > > > > [1] https://github.com/apache/cordova-coho/pull/58 > > [2] https://issues.apache.org/jira/browse/CB-7904 > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: Cordova Nightly Builds
Tools release automation proposal + issue: https://issues.apache.org/jira/browse/CB-7930 On Mon, Nov 3, 2014 at 1:50 PM, Steven Gill wrote: > These are not artifacts we could vote on. I am looking into adding a new > command to coho that would do the same steps as nightly but for RCs that we > could vote on and release. > > Update for nightlys: Been merged into master, waiting on jenkins access > from apache so I can setup the chronjob to run it once a night. > > On Mon, Nov 3, 2014 at 1:42 PM, Marcel Kinard wrote: > >> Nice! >> >> Doing an "npm info cordova" will yield a nightly-increasing number of >> entries in the 'version' key? >> >> These would not be artifacts that we could vote on, correct? >> >> On Oct 30, 2014, at 1:16 AM, Steven Gill wrote: >> >> > I have been doing some work on releasing nightlys recently. >> > >> > Please review PR [1] and comment on the issue [2]. >> > >> > [1] https://github.com/apache/cordova-coho/pull/58 >> > [2] https://issues.apache.org/jira/browse/CB-7904 >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> >
Re: Cordova Nightly Builds
These are not artifacts we could vote on. I am looking into adding a new command to coho that would do the same steps as nightly but for RCs that we could vote on and release. Update for nightlys: Been merged into master, waiting on jenkins access from apache so I can setup the chronjob to run it once a night. On Mon, Nov 3, 2014 at 1:42 PM, Marcel Kinard wrote: > Nice! > > Doing an "npm info cordova" will yield a nightly-increasing number of > entries in the 'version' key? > > These would not be artifacts that we could vote on, correct? > > On Oct 30, 2014, at 1:16 AM, Steven Gill wrote: > > > I have been doing some work on releasing nightlys recently. > > > > Please review PR [1] and comment on the issue [2]. > > > > [1] https://github.com/apache/cordova-coho/pull/58 > > [2] https://issues.apache.org/jira/browse/CB-7904 > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: Cordova Nightly Builds
Nice! Doing an "npm info cordova" will yield a nightly-increasing number of entries in the 'version' key? These would not be artifacts that we could vote on, correct? On Oct 30, 2014, at 1:16 AM, Steven Gill wrote: > I have been doing some work on releasing nightlys recently. > > Please review PR [1] and comment on the issue [2]. > > [1] https://github.com/apache/cordova-coho/pull/58 > [2] https://issues.apache.org/jira/browse/CB-7904 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova Nightly Builds
any way I think having nightly builds it's great, next conquer the world with a nightly mobilespec app ready to run on a device using the nightly build :-) On Thu, Oct 30, 2014 at 11:22 AM, Steven Gill wrote: > Really appreciate the comments and feedback. > > execOrPretend was implemented by Andrew in cadence release script for > tagging + pushing. I just moved it out to executil so other functions can > use it. > On Oct 30, 2014 8:19 AM, "Carlos Santana" wrote: > > > Thanks Steve, this is a very useful feature to implement. > > I like the the dryrun idea "execOrPretend" > > > > On Thu, Oct 30, 2014 at 10:11 AM, Andrew Grieve > > wrote: > > > > > Cool! Left some minor comments. > > > > > > On Thu, Oct 30, 2014 at 1:16 AM, Steven Gill > > > wrote: > > > > > > > I have been doing some work on releasing nightlys recently. > > > > > > > > Please review PR [1] and comment on the issue [2]. > > > > > > > > [1] https://github.com/apache/cordova-coho/pull/58 > > > > [2] https://issues.apache.org/jira/browse/CB-7904 > > > > > > > > > > > > > > > -- > > Carlos Santana > > > > > -- Carlos Santana
Re: Cordova Nightly Builds
Really appreciate the comments and feedback. execOrPretend was implemented by Andrew in cadence release script for tagging + pushing. I just moved it out to executil so other functions can use it. On Oct 30, 2014 8:19 AM, "Carlos Santana" wrote: > Thanks Steve, this is a very useful feature to implement. > I like the the dryrun idea "execOrPretend" > > On Thu, Oct 30, 2014 at 10:11 AM, Andrew Grieve > wrote: > > > Cool! Left some minor comments. > > > > On Thu, Oct 30, 2014 at 1:16 AM, Steven Gill > > wrote: > > > > > I have been doing some work on releasing nightlys recently. > > > > > > Please review PR [1] and comment on the issue [2]. > > > > > > [1] https://github.com/apache/cordova-coho/pull/58 > > > [2] https://issues.apache.org/jira/browse/CB-7904 > > > > > > > > > -- > Carlos Santana > >
Re: Cordova Nightly Builds
Thanks Steve, this is a very useful feature to implement. I like the the dryrun idea "execOrPretend" On Thu, Oct 30, 2014 at 10:11 AM, Andrew Grieve wrote: > Cool! Left some minor comments. > > On Thu, Oct 30, 2014 at 1:16 AM, Steven Gill > wrote: > > > I have been doing some work on releasing nightlys recently. > > > > Please review PR [1] and comment on the issue [2]. > > > > [1] https://github.com/apache/cordova-coho/pull/58 > > [2] https://issues.apache.org/jira/browse/CB-7904 > > > -- Carlos Santana
Re: Cordova Nightly Builds
Cool! Left some minor comments. On Thu, Oct 30, 2014 at 1:16 AM, Steven Gill wrote: > I have been doing some work on releasing nightlys recently. > > Please review PR [1] and comment on the issue [2]. > > [1] https://github.com/apache/cordova-coho/pull/58 > [2] https://issues.apache.org/jira/browse/CB-7904 >
Cordova Nightly Builds
I have been doing some work on releasing nightlys recently. Please review PR [1] and comment on the issue [2]. [1] https://github.com/apache/cordova-coho/pull/58 [2] https://issues.apache.org/jira/browse/CB-7904
