Re: Can't build compiler.jx in Eclipse
Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It should download all dependant libraries. Cyrill On Fri, Mar 29, 2013 at 2:12 PM, Gordon Smith gosm...@adobe.com wrote: When I import the compiler.jx project into Eclipse, I get Project 'compiler.jx' is missing required library: 'lib/commons-io.jar' Project 'compiler.jx' is missing required library: 'lib/google/closure-compiler/compiler.jar' There is no 'lib' directory in flex-falcon/compiler.jx. What am I doing wrong? - Gordon -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: Can't build compiler.jx in Eclipse
When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It should download all dependant libraries. Cyrill On Fri, Mar 29, 2013 at 2:12 PM, Gordon Smith gosm...@adobe.com wrote: When I import the compiler.jx project into Eclipse, I get Project 'compiler.jx' is missing required library: 'lib/commons-io.jar' Project 'compiler.jx' is missing required library: 'lib/google/closure-compiler/compiler.jar' There is no 'lib' directory in flex-falcon/compiler.jx. What am I doing wrong? - Gordon -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: Can't build compiler.jx in Eclipse
Normally, we don't. Some documentation might come in handy, though. EdB On Fri, Mar 29, 2013 at 7:25 AM, Alex Harui aha...@adobe.com wrote: When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It should download all dependant libraries. Cyrill On Fri, Mar 29, 2013 at 2:12 PM, Gordon Smith gosm...@adobe.com wrote: When I import the compiler.jx project into Eclipse, I get Project 'compiler.jx' is missing required library: 'lib/commons-io.jar' Project 'compiler.jx' is missing required library: 'lib/google/closure-compiler/compiler.jar' There is no 'lib' directory in flex-falcon/compiler.jx. What am I doing wrong? - Gordon -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: Can't build compiler.jx in Eclipse
The .classpath files in compiler.jx and compiler.jx/tests are showing up as modified in git. Should we put them in .gitignore? I wouldn't mind having them in there as a starting point. On 3/28/13 11:55 PM, Erik de Bruin e...@ixsoftware.nl wrote: Normally, we don't. Some documentation might come in handy, though. EdB On Fri, Mar 29, 2013 at 7:25 AM, Alex Harui aha...@adobe.com wrote: When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It should download all dependant libraries. Cyrill On Fri, Mar 29, 2013 at 2:12 PM, Gordon Smith gosm...@adobe.com wrote: When I import the compiler.jx project into Eclipse, I get Project 'compiler.jx' is missing required library: 'lib/commons-io.jar' Project 'compiler.jx' is missing required library: 'lib/google/closure-compiler/compiler.jar' There is no 'lib' directory in flex-falcon/compiler.jx. What am I doing wrong? - Gordon -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: Update about Utilities repo migration
Hi, The flex-utilities git repo is now read/write. It is available here: https://git-wip-us.apache.org/repos/asf/flex-utilities.git Also, https://git-wip-us.apache.org/repos/asf/flex-external.git is up for review. Alex, if you can get this reviewed, I will go ahead and ask them to open it up for read/write. Thanks, Om On Wed, Mar 27, 2013 at 8:04 AM, Jose Barragan jose.barra...@codeoscopic.com wrote: +1 -- Jose Barragan Chief Software Architect Codeoscopic Madrid C/. Infanta Mercedes, 92. Planta 5. 505. 28020 Madrid. Tel.: +34 912 94 80 80 On Mar 27, 2013, at 10:39 AM, Carlos Rovira carlos.rov...@codeoscopic.com wrote: +1 2013/3/27 Frédéric THOMAS webdoubl...@hotmail.com +1 too -Fred -Message d'origine- From: Erik de Bruin Sent: Wednesday, March 27, 2013 8:18 AM To: dev@flex.apache.org Subject: Re: Update about Utilities repo migration +1 EdB On Wed, Mar 27, 2013 at 4:18 AM, Alex Harui aha...@adobe.com wrote: Yup, let's get it done. On 3/26/13 7:55 PM, Om bigosma...@gmail.com wrote: Here is David@Infra's note about the missing history in the flex-utilities git repo. I think we should accept the repo as it is and move ahead. Any objections? We can go back to SVN for any history that is missing. I doubt we would need that because it was the early days of the Installer project and I am pretty sure that there is anything mission critical there. Thanks, Om David Nalley commented on INFRA-5549: --**--- Okay folks: I tried running through utilities 2 more times - came up with the same result. Here's the issue - because there are differences in how git and svn handle branches and tags, when we look to convert a SVN tree we have to specify a layout. (e.g. where tags, branches and trunk, live in the tree) The problem is that on August 15 the tree layout was changed [1], which is the expected layout - so prior to that layout existing, in the eyes of the migration process nothing existed in that repo. In short - that layout change essentially (from a git perspective.) restarted history. (BTW - Paul Davis provided the sanity to catch this problem, many thanks for that.) Let me know how you want to proceed with this. [1] http://svn.apache.org/viewvc?**view=revisionrevision=1373617 http://svn.apache.org/viewvc?view=revisionrevision=1373617 -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl -- Carlos Rovira Director de Tecnología M: +34 607 22 60 05 F: +34 912 94 80 80 http://www.codeoscopic.com http://www.directwriter.es http://www.avant2.es
Re: Can't build compiler.jx in Eclipse
Currently its quite easy to setup the eclipse falcon project. Import falcon projects in eclipse, run ant script, sometimes refresh the projects and you are ready to go.. Wouldn't it get more complicated if you put classpath to gitignore? Then I always have to add the libraries by myself. Just my thoughts Cyrill Sent from my iPhone On 29.03.2013, at 17:28, Alex Harui aha...@adobe.com wrote: The .classpath files in compiler.jx and compiler.jx/tests are showing up as modified in git. Should we put them in .gitignore? I wouldn't mind having them in there as a starting point. On 3/28/13 11:55 PM, Erik de Bruin e...@ixsoftware.nl wrote: Normally, we don't. Some documentation might come in handy, though. EdB On Fri, Mar 29, 2013 at 7:25 AM, Alex Harui aha...@adobe.com wrote: When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It should download all dependant libraries. Cyrill On Fri, Mar 29, 2013 at 2:12 PM, Gordon Smith gosm...@adobe.com wrote: When I import the compiler.jx project into Eclipse, I get Project 'compiler.jx' is missing required library: 'lib/commons-io.jar' Project 'compiler.jx' is missing required library: 'lib/google/closure-compiler/compiler.jar' There is no 'lib' directory in flex-falcon/compiler.jx. What am I doing wrong? - Gordon -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [FalconJx] progress update
Uh oh... Turns out I was testing against an outdated ASJS lib
(pre-fb614905ac), so FalconJx DOESN'T WORK against the current
iteration of FlexJS. Sorry about that. I will work on that today, but
I don't have a lot of time, so it might be a while before I can catch
up, due to next week's travel to the land of golden opportunity.
EdB
On Thu, Mar 28, 2013 at 5:24 PM, Erik de Bruin e...@ixsoftware.nl wrote:
And another update (things are going much better than I expected):
FalconJx can now emit a fully functional version of the
FlexJSTest_again demo application. You can see it in action here
(provided you use Chrome or Firefox, I just noticed):
http://people.apache.org/~erikdebruin/flexjs/
Onwards and upwards ;-)
EdB
On Wed, Mar 27, 2013 at 9:58 PM, Erik de Bruin e...@ixsoftware.nl wrote:
I'd have to look into it for specifics, but of the top of my head it
seems that this most depends on the implementation in the FlexJS JS
framework. Emitting the strings required by that framework should
really be easy enough. If needed we can look forward into AST to
look for binding information. I do this in several other places
already. Even the binding expressions shouldn't be too much of a
problem, again depending on how this will be handled by the JS
framework.
EdB
On Wed, Mar 27, 2013 at 9:36 PM, Alex Harui aha...@adobe.com wrote:
[Bindable] results in extra codegen. Binding expressions with {} is a whole
other ball of work.
I think in FalconJX you might have to modify the node tree in several places
when you hit a [Bindable] node.
It isn't working correctly in FalconJS either, but my customer needs it so
I'm hacking a fix.
On 3/27/13 1:28 PM, Erik de Bruin e...@ixsoftware.nl wrote:
No, not yet. How is this set up in FlexJS? I'm sure I can read Metadata and
Databinding information, so I guess it depends on the requirements for the
emitted JS if I can easily implement this ;-)
EdB
On Wednesday, March 27, 2013, Alex Harui wrote:
Does FalconJX handle [Bindable]? My customer is using it.
On 3/27/13 11:56 AM, Michael Schmalle apa...@teotigraphix.com wrote:
Quoting Erik de Bruin e...@ixsoftware.nl:
Another one popped into my head just now: I have a gut feeling there
is a bit of circular logic going on in the whole 'backend',
'blockwalker' and 'emitter' construct. More specifically in the way
the references to them are passed around as arguments in the
constructors for the various classes. But I can't wrap around it well
enough to figure out whether it's wrong and if so, what might be done
about it. Don't get me wrong, it works well, it's just that it somehow
isn't elegant. And that's in no way a comment on the effectiveness
or quality of your code, just something I thought I'd share and see
what you think.
Actually I think it works fine. The problem you are facing is with the
MXML emitter I am sure. This adds complexity to what you are trying to
accomplish and it is circular from the perspective of using AS within
MXML.
There is a buffer writer(output stream), a writer, a visitor and emitter.
Each one takes a dependency of its parent. Trust me, if there is a
child that knows about its parent I am blind. Like I said, the block
walker is a visitor and the emitter is a visitor. You cannot escape
the fact there is recursion.
If you can think of a more elegant way to set it up, by all means
write a prototype. Remember, I wrote this with an atom bomb under me
and lighting in the sky, there may be parts that could be logicalized.
I have another full compiler in Randori that I am going to use as a
proof of concept with compiler plugins and my ASDoc compiler I wrote.
So I guess we both can experiment, we can agree to leave the core
alone for the time being.
EdB
On Wed, Mar 27, 2013 at 7:41 PM, Erik de Bruin e...@ixsoftware.nl
wrote:
Mike,
Just kidding ;-)
I'm really happy with FalconJx, once you get to know it it's a
pleasure to work with. I hope my last commits didn't give you any
additional work in your other projects? I did my best to leave all the
APIs alone.
There are plenty of TODOs in the code, and I would also like to
suggest some kind of code review or something (I'm not used to working
in groups, but that seems like a nice thing to do), since I've been
piling on stuff. I did my best to keep everything clean and in line
with the spirit of the rest of the code, but there are some areas
where I'd like to have a second opinion. Like with the code that is
copied between the DOC and JS emitters, seems there might be room for
improvement there. Also of note is the way I've implemented the AS
emitting within the MXML emitter, not really sure if I did the right
thing there. And finally (not really, but this is all I can think of
for now, after the marathon hacking I did today) there is the whole
programming to interfaces, not implementations part that we nearly
adhere to, but not quite, we might have another
Re: Welcome our newest Apache Flex committer Mark Kessler
Welcome aboard Mark -Jose On Mar 29, 2013, at 2:52 AM, Mark Kessler kesslerconsult...@gmail.com wrote: Thank you, Bit about what I use Flex for and what I plan on working on with the SDK... I started building web based applications in 2007 up to the present day. I currently have 12 active apps, so I have quite a vested interest with the future of Flex. I plan on doing bug fixes, new feature implementations, and generally updating the core of Flex. It will be nice to undo some of the local fixes in my applications and apply the fixes directly in the SDK. In about a week from now I'll try to have a working example hosted on my Apache web space for a feature/upgrade I'd like to discuss. -Mark On Thu, Mar 28, 2013 at 8:12 PM, Justin Mclean jus...@classsoftware.comwrote: Hi, The Project Management Committee (PMC) for Apache Flex has asked Mark Kessler to become a committer and we are pleased to announce that he has accepted. Mark has been contributing to Apache Flex for many months both on the mailing list, in JIRA and providing many patches including one change that enables the datagrid to handle double clicks on cells and rows. Congratulations Justin Mclean for the Flex PMC
Re: Falcon functional test failure
Hi, this my fault. I'll commit the fix ASAP. thanks for seeing this. Best, Carlos 2013/3/29 Cyrill Zadra cyrill.za...@gmail.com Same here.. It's a new warning which is introduced through this commit. https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=commitdiff;h=461281f5818f25319391c6188805512cebc4d977 . I guess we should rename it to _item? On Fri, Mar 29, 2013 at 2:20 PM, Gordon Smith gosm...@adobe.com wrote: The frameworkSWC() test in SDKSWCTests is failing for me due to two compilation warnings warnings: [junit] Expected: is 0 [junit] got: 2 [junit] Warning: variable definition duplicates function parameter: item. [junit] ) [junit] var item:Object = removeItemAt(getItemIndex(item)); [junit] ^ [junit] [junit] D:\asf\flex-sdk\frameworks\projects\framework\src\mx\collections\XMLListAdapter.as:419 [junit] Warning: variable definition duplicates function parameter: item. [junit] var item:Object = removeItemAt[getItemIndex(item)]; I get the same thing in Eclipse. Does anybody else get this failure? - Gordon -- Carlos Rovira Director de Tecnología M: +34 607 22 60 05 F: +34 912 94 80 80 http://www.codeoscopic.com http://www.directwriter.es http://www.avant2.es
Re: Falcon functional test failure
commited. Sorry for the inconvenience. Carlos 2013/3/29 Carlos Rovira carlos.rov...@codeoscopic.com Hi, this my fault. I'll commit the fix ASAP. thanks for seeing this. Best, Carlos 2013/3/29 Cyrill Zadra cyrill.za...@gmail.com Same here.. It's a new warning which is introduced through this commit. https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=commitdiff;h=461281f5818f25319391c6188805512cebc4d977 . I guess we should rename it to _item? On Fri, Mar 29, 2013 at 2:20 PM, Gordon Smith gosm...@adobe.com wrote: The frameworkSWC() test in SDKSWCTests is failing for me due to two compilation warnings warnings: [junit] Expected: is 0 [junit] got: 2 [junit] Warning: variable definition duplicates function parameter: item. [junit] ) [junit] var item:Object = removeItemAt(getItemIndex(item)); [junit] ^ [junit] [junit] D:\asf\flex-sdk\frameworks\projects\framework\src\mx\collections\XMLListAdapter.as:419 [junit] Warning: variable definition duplicates function parameter: item. [junit] var item:Object = removeItemAt[getItemIndex(item)]; I get the same thing in Eclipse. Does anybody else get this failure? - Gordon -- Carlos Rovira Director de Tecnología M: +34 607 22 60 05 F: +34 912 94 80 80 http://www.codeoscopic.com http://www.directwriter.es http://www.avant2.es -- Carlos Rovira Director de Tecnología M: +34 607 22 60 05 F: +34 912 94 80 80 http://www.codeoscopic.com http://www.directwriter.es http://www.avant2.es
Re: Welcome our newest Apache Flex committer Mark Kessler
Welcome Mark! 2013/3/29 Jose Barragan jose.barra...@codeoscopic.com Welcome aboard Mark -Jose On Mar 29, 2013, at 2:52 AM, Mark Kessler kesslerconsult...@gmail.com wrote: Thank you, Bit about what I use Flex for and what I plan on working on with the SDK... I started building web based applications in 2007 up to the present day. I currently have 12 active apps, so I have quite a vested interest with the future of Flex. I plan on doing bug fixes, new feature implementations, and generally updating the core of Flex. It will be nice to undo some of the local fixes in my applications and apply the fixes directly in the SDK. In about a week from now I'll try to have a working example hosted on my Apache web space for a feature/upgrade I'd like to discuss. -Mark On Thu, Mar 28, 2013 at 8:12 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, The Project Management Committee (PMC) for Apache Flex has asked Mark Kessler to become a committer and we are pleased to announce that he has accepted. Mark has been contributing to Apache Flex for many months both on the mailing list, in JIRA and providing many patches including one change that enables the datagrid to handle double clicks on cells and rows. Congratulations Justin Mclean for the Flex PMC -- Carlos Rovira Director de Tecnología M: +34 607 22 60 05 F: +34 912 94 80 80 http://www.codeoscopic.com http://www.directwriter.es http://www.avant2.es
[Git + Falcon] all projects in one basket?
Hi, A question for the git gurus out there: Currently all 5 Falcon projects (compiler, js, js and 2x tests) are all in one repo. This means that on my system, all these repos will be on the same branch. Now, if at some point in the future we want to work on Jx in one branch (say a BugFix), but want to use the changes made to the compiler on the 'develop' branch. How do we go about this? Wouldn't it make more sense to have 5 different repos - or three, if we include the tests with their respective projects? Or am I just missing some magic sequence of checkout/pull/rebase that might be used? Thanks, EdB -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: [Git + Falcon] all projects in one basket?
The normal git workflow imply you have 1 project per repo, unit tests included, functional tests could stand in another one. That's not currently the case, so project1 can live on a branch, when you needs commits from another branch/project, depending of what you need, you can do a 'git rebase origin anotherbranch to get all the work done onto this remote branch into your working branch or 'git cherry-pick HASH1 HASH2 HASHx' HASHx can be obtain if you first do a 'git pull --rebase' from the anotherbranch and then a 'git hist' to get the HASHs of the commits you need to introduce in your working branch (the 'git cherry-pick' should be done from your branch/project). -Fred -Message d'origine- From: Erik de Bruin Sent: Friday, March 29, 2013 9:15 AM To: dev@flex.apache.org Subject: [Git + Falcon] all projects in one basket? Hi, A question for the git gurus out there: Currently all 5 Falcon projects (compiler, js, js and 2x tests) are all in one repo. This means that on my system, all these repos will be on the same branch. Now, if at some point in the future we want to work on Jx in one branch (say a BugFix), but want to use the changes made to the compiler on the 'develop' branch. How do we go about this? Wouldn't it make more sense to have 5 different repos - or three, if we include the tests with their respective projects? Or am I just missing some magic sequence of checkout/pull/rebase that might be used? Thanks, EdB -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: [Git + Falcon] all projects in one basket?
Well, I don't know the specifics of your projects, I mean how those projects have things in common, so don't take my answer as 100% adapted for your case. Tell more specific case, maybe I can't be more specific as well. -Fred -Message d'origine- From: Frédéric THOMAS Sent: Friday, March 29, 2013 9:29 AM To: dev@flex.apache.org Subject: Re: [Git + Falcon] all projects in one basket? The normal git workflow imply you have 1 project per repo, unit tests included, functional tests could stand in another one. That's not currently the case, so project1 can live on a branch, when you needs commits from another branch/project, depending of what you need, you can do a 'git rebase origin anotherbranch to get all the work done onto this remote branch into your working branch or 'git cherry-pick HASH1 HASH2 HASHx' HASHx can be obtain if you first do a 'git pull --rebase' from the anotherbranch and then a 'git hist' to get the HASHs of the commits you need to introduce in your working branch (the 'git cherry-pick' should be done from your branch/project). -Fred -Message d'origine- From: Erik de Bruin Sent: Friday, March 29, 2013 9:15 AM To: dev@flex.apache.org Subject: [Git + Falcon] all projects in one basket? Hi, A question for the git gurus out there: Currently all 5 Falcon projects (compiler, js, js and 2x tests) are all in one repo. This means that on my system, all these repos will be on the same branch. Now, if at some point in the future we want to work on Jx in one branch (say a BugFix), but want to use the changes made to the compiler on the 'develop' branch. How do we go about this? Wouldn't it make more sense to have 5 different repos - or three, if we include the tests with their respective projects? Or am I just missing some magic sequence of checkout/pull/rebase that might be used? Thanks, EdB -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: [Git + Falcon] all projects in one basket?
Hi, That's not currently the case, so project1 can live on a branch, when you needs commits from another branch/project Please -1 to this. Just work in develop as was voted on. Why do we need to make things far more complex than they need to be? Justin
Re: [Git + Falcon] all projects in one basket?
True Justin, it's not my intention, maybe my misunderstanding of the projects living together, having apparently, from what I can understand things in common but not in the same development line ? it is where I'm lost maybe. If it is just to create a bugFix branch and get back the work (or a part) done on the develop branch time to time, it's like the flex-sdk git usage. -Fred -Message d'origine- From: Justin Mclean Sent: Friday, March 29, 2013 10:31 AM To: dev@flex.apache.org Subject: Re: [Git + Falcon] all projects in one basket? Hi, That's not currently the case, so project1 can live on a branch, when you needs commits from another branch/project Please -1 to this. Just work in develop as was voted on. Why do we need to make things far more complex than they need to be? Justin
Re: [Git + Falcon] all projects in one basket?
Just two ideas: 1- clone again in your hard disk to establish each current branch and related each together, just for your local usage 2- separate those subprojects as git submodules, by this way, you can establish any pointer at any submodule related from a single commit in master project. -Jose On Mar 29, 2013, at 10:39 AM, Frédéric THOMAS webdoubl...@hotmail.com wrote: True Justin, it's not my intention, maybe my misunderstanding of the projects living together, having apparently, from what I can understand things in common but not in the same development line ? it is where I'm lost maybe. If it is just to create a bugFix branch and get back the work (or a part) done on the develop branch time to time, it's like the flex-sdk git usage. -Fred -Message d'origine- From: Justin Mclean Sent: Friday, March 29, 2013 10:31 AM To: dev@flex.apache.org Subject: Re: [Git + Falcon] all projects in one basket? Hi, That's not currently the case, so project1 can live on a branch, when you needs commits from another branch/project Please -1 to this. Just work in develop as was voted on. Why do we need to make things far more complex than they need to be? Justin
Re: Can't build compiler.jx in Eclipse
Is there a way to have a file in git that is also in gitignore? That way you get it when you clone, but when you modify it, it doesn't get checked back in. On 3/29/13 12:27 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: Currently its quite easy to setup the eclipse falcon project. Import falcon projects in eclipse, run ant script, sometimes refresh the projects and you are ready to go.. Wouldn't it get more complicated if you put classpath to gitignore? Then I always have to add the libraries by myself. Just my thoughts Cyrill Sent from my iPhone On 29.03.2013, at 17:28, Alex Harui aha...@adobe.com wrote: The .classpath files in compiler.jx and compiler.jx/tests are showing up as modified in git. Should we put them in .gitignore? I wouldn't mind having them in there as a starting point. On 3/28/13 11:55 PM, Erik de Bruin e...@ixsoftware.nl wrote: Normally, we don't. Some documentation might come in handy, though. EdB On Fri, Mar 29, 2013 at 7:25 AM, Alex Harui aha...@adobe.com wrote: When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It should download all dependant libraries. Cyrill On Fri, Mar 29, 2013 at 2:12 PM, Gordon Smith gosm...@adobe.com wrote: When I import the compiler.jx project into Eclipse, I get Project 'compiler.jx' is missing required library: 'lib/commons-io.jar' Project 'compiler.jx' is missing required library: 'lib/google/closure-compiler/compiler.jar' There is no 'lib' directory in flex-falcon/compiler.jx. What am I doing wrong? - Gordon -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: Can't build compiler.jx in Eclipse
I can't remember I tried it but logically, removing the .classpath from the .gitignore, committing only the .classpath then re-adding it in the .gitignore should work but still, I think it's better to write a guideline than checkin IDE files :) -Fred -Message d'origine- From: Alex Harui Sent: Friday, March 29, 2013 2:30 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Is there a way to have a file in git that is also in gitignore? That way you get it when you clone, but when you modify it, it doesn't get checked back in. On 3/29/13 12:27 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: Currently its quite easy to setup the eclipse falcon project. Import falcon projects in eclipse, run ant script, sometimes refresh the projects and you are ready to go.. Wouldn't it get more complicated if you put classpath to gitignore? Then I always have to add the libraries by myself. Just my thoughts Cyrill Sent from my iPhone On 29.03.2013, at 17:28, Alex Harui aha...@adobe.com wrote: The .classpath files in compiler.jx and compiler.jx/tests are showing up as modified in git. Should we put them in .gitignore? I wouldn't mind having them in there as a starting point. On 3/28/13 11:55 PM, Erik de Bruin e...@ixsoftware.nl wrote: Normally, we don't. Some documentation might come in handy, though. EdB On Fri, Mar 29, 2013 at 7:25 AM, Alex Harui aha...@adobe.com wrote: When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It should download all dependant libraries. Cyrill On Fri, Mar 29, 2013 at 2:12 PM, Gordon Smith gosm...@adobe.com wrote: When I import the compiler.jx project into Eclipse, I get Project 'compiler.jx' is missing required library: 'lib/commons-io.jar' Project 'compiler.jx' is missing required library: 'lib/google/closure-compiler/compiler.jar' There is no 'lib' directory in flex-falcon/compiler.jx. What am I doing wrong? - Gordon -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [FalconJx] progress update
Nearly there...
EdB
On Fri, Mar 29, 2013 at 2:30 PM, Alex Harui aha...@adobe.com wrote:
No worries. Might be a good way for me to learn how it works by getting it
to work.
On 3/29/13 12:31 AM, Erik de Bruin e...@ixsoftware.nl wrote:
Uh oh... Turns out I was testing against an outdated ASJS lib
(pre-fb614905ac), so FalconJx DOESN'T WORK against the current
iteration of FlexJS. Sorry about that. I will work on that today, but
I don't have a lot of time, so it might be a while before I can catch
up, due to next week's travel to the land of golden opportunity.
EdB
On Thu, Mar 28, 2013 at 5:24 PM, Erik de Bruin e...@ixsoftware.nl wrote:
And another update (things are going much better than I expected):
FalconJx can now emit a fully functional version of the
FlexJSTest_again demo application. You can see it in action here
(provided you use Chrome or Firefox, I just noticed):
http://people.apache.org/~erikdebruin/flexjs/
Onwards and upwards ;-)
EdB
On Wed, Mar 27, 2013 at 9:58 PM, Erik de Bruin e...@ixsoftware.nl wrote:
I'd have to look into it for specifics, but of the top of my head it
seems that this most depends on the implementation in the FlexJS JS
framework. Emitting the strings required by that framework should
really be easy enough. If needed we can look forward into AST to
look for binding information. I do this in several other places
already. Even the binding expressions shouldn't be too much of a
problem, again depending on how this will be handled by the JS
framework.
EdB
On Wed, Mar 27, 2013 at 9:36 PM, Alex Harui aha...@adobe.com wrote:
[Bindable] results in extra codegen. Binding expressions with {} is a
whole
other ball of work.
I think in FalconJX you might have to modify the node tree in several
places
when you hit a [Bindable] node.
It isn't working correctly in FalconJS either, but my customer needs it
so
I'm hacking a fix.
On 3/27/13 1:28 PM, Erik de Bruin e...@ixsoftware.nl wrote:
No, not yet. How is this set up in FlexJS? I'm sure I can read Metadata
and
Databinding information, so I guess it depends on the requirements for
the
emitted JS if I can easily implement this ;-)
EdB
On Wednesday, March 27, 2013, Alex Harui wrote:
Does FalconJX handle [Bindable]? My customer is using it.
On 3/27/13 11:56 AM, Michael Schmalle apa...@teotigraphix.com wrote:
Quoting Erik de Bruin e...@ixsoftware.nl:
Another one popped into my head just now: I have a gut feeling there
is a bit of circular logic going on in the whole 'backend',
'blockwalker' and 'emitter' construct. More specifically in the way
the references to them are passed around as arguments in the
constructors for the various classes. But I can't wrap around it well
enough to figure out whether it's wrong and if so, what might be done
about it. Don't get me wrong, it works well, it's just that it somehow
isn't elegant. And that's in no way a comment on the effectiveness
or quality of your code, just something I thought I'd share and see
what you think.
Actually I think it works fine. The problem you are facing is with the
MXML emitter I am sure. This adds complexity to what you are trying to
accomplish and it is circular from the perspective of using AS within
MXML.
There is a buffer writer(output stream), a writer, a visitor and
emitter.
Each one takes a dependency of its parent. Trust me, if there is a
child that knows about its parent I am blind. Like I said, the block
walker is a visitor and the emitter is a visitor. You cannot escape
the fact there is recursion.
If you can think of a more elegant way to set it up, by all means
write a prototype. Remember, I wrote this with an atom bomb under me
and lighting in the sky, there may be parts that could be logicalized.
I have another full compiler in Randori that I am going to use as a
proof of concept with compiler plugins and my ASDoc compiler I wrote.
So I guess we both can experiment, we can agree to leave the core
alone for the time being.
EdB
On Wed, Mar 27, 2013 at 7:41 PM, Erik de Bruin e...@ixsoftware.nl
wrote:
Mike,
Just kidding ;-)
I'm really happy with FalconJx, once you get to know it it's a
pleasure to work with. I hope my last commits didn't give you any
additional work in your other projects? I did my best to leave all
the
APIs alone.
There are plenty of TODOs in the code, and I would also like to
suggest some kind of code review or something (I'm not used to
working
in groups, but that seems like a nice thing to do), since I've been
piling on stuff. I did my best to keep everything clean and in line
with the spirit of the rest of the code, but there are some areas
where I'd like to have a second opinion. Like with the code that is
copied between the DOC and JS emitters, seems there might be room for
improvement there. Also of note is the way I've implemented the AS
emitting within the MXML emitter, not really sure if I did the
Re: [FalconJx] progress update
Ah, and there's plenty left for you to learn from :-)
EdB
On Fri, Mar 29, 2013 at 2:30 PM, Alex Harui aha...@adobe.com wrote:
No worries. Might be a good way for me to learn how it works by getting it
to work.
On 3/29/13 12:31 AM, Erik de Bruin e...@ixsoftware.nl wrote:
Uh oh... Turns out I was testing against an outdated ASJS lib
(pre-fb614905ac), so FalconJx DOESN'T WORK against the current
iteration of FlexJS. Sorry about that. I will work on that today, but
I don't have a lot of time, so it might be a while before I can catch
up, due to next week's travel to the land of golden opportunity.
EdB
On Thu, Mar 28, 2013 at 5:24 PM, Erik de Bruin e...@ixsoftware.nl wrote:
And another update (things are going much better than I expected):
FalconJx can now emit a fully functional version of the
FlexJSTest_again demo application. You can see it in action here
(provided you use Chrome or Firefox, I just noticed):
http://people.apache.org/~erikdebruin/flexjs/
Onwards and upwards ;-)
EdB
On Wed, Mar 27, 2013 at 9:58 PM, Erik de Bruin e...@ixsoftware.nl wrote:
I'd have to look into it for specifics, but of the top of my head it
seems that this most depends on the implementation in the FlexJS JS
framework. Emitting the strings required by that framework should
really be easy enough. If needed we can look forward into AST to
look for binding information. I do this in several other places
already. Even the binding expressions shouldn't be too much of a
problem, again depending on how this will be handled by the JS
framework.
EdB
On Wed, Mar 27, 2013 at 9:36 PM, Alex Harui aha...@adobe.com wrote:
[Bindable] results in extra codegen. Binding expressions with {} is a
whole
other ball of work.
I think in FalconJX you might have to modify the node tree in several
places
when you hit a [Bindable] node.
It isn't working correctly in FalconJS either, but my customer needs it
so
I'm hacking a fix.
On 3/27/13 1:28 PM, Erik de Bruin e...@ixsoftware.nl wrote:
No, not yet. How is this set up in FlexJS? I'm sure I can read Metadata
and
Databinding information, so I guess it depends on the requirements for
the
emitted JS if I can easily implement this ;-)
EdB
On Wednesday, March 27, 2013, Alex Harui wrote:
Does FalconJX handle [Bindable]? My customer is using it.
On 3/27/13 11:56 AM, Michael Schmalle apa...@teotigraphix.com wrote:
Quoting Erik de Bruin e...@ixsoftware.nl:
Another one popped into my head just now: I have a gut feeling there
is a bit of circular logic going on in the whole 'backend',
'blockwalker' and 'emitter' construct. More specifically in the way
the references to them are passed around as arguments in the
constructors for the various classes. But I can't wrap around it well
enough to figure out whether it's wrong and if so, what might be done
about it. Don't get me wrong, it works well, it's just that it somehow
isn't elegant. And that's in no way a comment on the effectiveness
or quality of your code, just something I thought I'd share and see
what you think.
Actually I think it works fine. The problem you are facing is with the
MXML emitter I am sure. This adds complexity to what you are trying to
accomplish and it is circular from the perspective of using AS within
MXML.
There is a buffer writer(output stream), a writer, a visitor and
emitter.
Each one takes a dependency of its parent. Trust me, if there is a
child that knows about its parent I am blind. Like I said, the block
walker is a visitor and the emitter is a visitor. You cannot escape
the fact there is recursion.
If you can think of a more elegant way to set it up, by all means
write a prototype. Remember, I wrote this with an atom bomb under me
and lighting in the sky, there may be parts that could be logicalized.
I have another full compiler in Randori that I am going to use as a
proof of concept with compiler plugins and my ASDoc compiler I wrote.
So I guess we both can experiment, we can agree to leave the core
alone for the time being.
EdB
On Wed, Mar 27, 2013 at 7:41 PM, Erik de Bruin e...@ixsoftware.nl
wrote:
Mike,
Just kidding ;-)
I'm really happy with FalconJx, once you get to know it it's a
pleasure to work with. I hope my last commits didn't give you any
additional work in your other projects? I did my best to leave all
the
APIs alone.
There are plenty of TODOs in the code, and I would also like to
suggest some kind of code review or something (I'm not used to
working
in groups, but that seems like a nice thing to do), since I've been
piling on stuff. I did my best to keep everything clean and in line
with the spirit of the rest of the code, but there are some areas
where I'd like to have a second opinion. Like with the code that is
copied between the DOC and JS emitters, seems there might be room for
improvement there. Also of note is the way I've implemented the AS
emitting within the MXML
RE: Falcon functional test failure
Ah, I see Carlos took care of it. Thanks, Carlos! - Gordon -Original Message- From: Gordon Smith [mailto:gosm...@adobe.com] Sent: Friday, March 29, 2013 10:12 AM To: dev@flex.apache.org Subject: RE: Falcon functional test failure Aha, I should have realized that it was likely a recent change to the framework. I recommend renaming it to removedItem. I try not to change the SDK because I'm not sure what tests I have to run. Are you willing to do it? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Thursday, March 28, 2013 9:52 PM To: dev@flex.apache.org Subject: Re: Falcon functional test failure Same here.. It's a new warning which is introduced through this commit. https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=commitdiff;h=461281f5818f25319391c6188805512cebc4d977. I guess we should rename it to _item? On Fri, Mar 29, 2013 at 2:20 PM, Gordon Smith gosm...@adobe.com wrote: The frameworkSWC() test in SDKSWCTests is failing for me due to two compilation warnings warnings: [junit] Expected: is 0 [junit] got: 2 [junit] Warning: variable definition duplicates function parameter: item. [junit] ) [junit] var item:Object = removeItemAt(getItemIndex(item)); [junit] ^ [junit] [junit] D:\asf\flex-sdk\frameworks\projects\framework\src\mx\collections\XMLListAdapter.as:419 [junit] Warning: variable definition duplicates function parameter: item. [junit] var item:Object = removeItemAt[getItemIndex(item)]; I get the same thing in Eclipse. Does anybody else get this failure? - Gordon
Re: Falcon functional test failure
Thanks to you for bring it out Gordon :) 2013/3/29 Gordon Smith gosm...@adobe.com Ah, I see Carlos took care of it. Thanks, Carlos! - Gordon -Original Message- From: Gordon Smith [mailto:gosm...@adobe.com] Sent: Friday, March 29, 2013 10:12 AM To: dev@flex.apache.org Subject: RE: Falcon functional test failure Aha, I should have realized that it was likely a recent change to the framework. I recommend renaming it to removedItem. I try not to change the SDK because I'm not sure what tests I have to run. Are you willing to do it? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Thursday, March 28, 2013 9:52 PM To: dev@flex.apache.org Subject: Re: Falcon functional test failure Same here.. It's a new warning which is introduced through this commit. https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=commitdiff;h=461281f5818f25319391c6188805512cebc4d977 . I guess we should rename it to _item? On Fri, Mar 29, 2013 at 2:20 PM, Gordon Smith gosm...@adobe.com wrote: The frameworkSWC() test in SDKSWCTests is failing for me due to two compilation warnings warnings: [junit] Expected: is 0 [junit] got: 2 [junit] Warning: variable definition duplicates function parameter: item. [junit] ) [junit] var item:Object = removeItemAt(getItemIndex(item)); [junit] ^ [junit] [junit] D:\asf\flex-sdk\frameworks\projects\framework\src\mx\collections\XMLListAdapter.as:419 [junit] Warning: variable definition duplicates function parameter: item. [junit] var item:Object = removeItemAt[getItemIndex(item)]; I get the same thing in Eclipse. Does anybody else get this failure? - Gordon -- Carlos Rovira Director de Tecnología M: +34 607 22 60 05 F: +34 912 94 80 80 http://www.codeoscopic.com http://www.directwriter.es http://www.avant2.es
Re: Can't build compiler.jx in Eclipse
Gordon, Did you get it to work with the checked-in project files? On 3/29/13 10:14 AM, Gordon Smith gosm...@adobe.com wrote: The project files should be under source control and they should build without tweaking when you import them. The only exception is having to configure things at the workspace level. For example, the compiler project requires that ANT_JAR be set in the classpath of the workspace. - Gordon -Original Message- From: Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Sent: Friday, March 29, 2013 6:44 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse I can't remember I tried it but logically, removing the .classpath from the .gitignore, committing only the .classpath then re-adding it in the .gitignore should work but still, I think it's better to write a guideline than checkin IDE files :) -Fred -Message d'origine- From: Alex Harui Sent: Friday, March 29, 2013 2:30 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Is there a way to have a file in git that is also in gitignore? That way you get it when you clone, but when you modify it, it doesn't get checked back in. On 3/29/13 12:27 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: Currently its quite easy to setup the eclipse falcon project. Import falcon projects in eclipse, run ant script, sometimes refresh the projects and you are ready to go.. Wouldn't it get more complicated if you put classpath to gitignore? Then I always have to add the libraries by myself. Just my thoughts Cyrill Sent from my iPhone On 29.03.2013, at 17:28, Alex Harui aha...@adobe.com wrote: The .classpath files in compiler.jx and compiler.jx/tests are showing up as modified in git. Should we put them in .gitignore? I wouldn't mind having them in there as a starting point. On 3/28/13 11:55 PM, Erik de Bruin e...@ixsoftware.nl wrote: Normally, we don't. Some documentation might come in handy, though. EdB On Fri, Mar 29, 2013 at 7:25 AM, Alex Harui aha...@adobe.com wrote: When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It should download all dependant libraries. Cyrill On Fri, Mar 29, 2013 at 2:12 PM, Gordon Smith gosm...@adobe.com wrote: When I import the compiler.jx project into Eclipse, I get Project 'compiler.jx' is missing required library: 'lib/commons-io.jar' Project 'compiler.jx' is missing required library: 'lib/google/closure-compiler/compiler.jar' There is no 'lib' directory in flex-falcon/compiler.jx. What am I doing wrong? - Gordon -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: Can't build compiler.jx in Eclipse
A happy middle would be to affix a .template extension and check that in. And the actual file extension would be added to gitignore. For example, .project would be added to gitignore. But, .project.template can be checked in. Whoever wants to use it, can copy the file into .project locally and tweak it as needed. Thanks, Om On Fri, Mar 29, 2013 at 11:17 AM, Michael Schmalle apa...@teotigraphix.comwrote: I will add my 2 cents. I think the people that say keep the IDE files out are used to maven and other such tools that can setup your IDE for you. The falcon framework has non of this and until it does, the Eclipse project IDE files stay in the repo. Mike Quoting Alex Harui aha...@adobe.com: Gordon, Did you get it to work with the checked-in project files? On 3/29/13 10:14 AM, Gordon Smith gosm...@adobe.com wrote: The project files should be under source control and they should build without tweaking when you import them. The only exception is having to configure things at the workspace level. For example, the compiler project requires that ANT_JAR be set in the classpath of the workspace. - Gordon -Original Message- From: Frédéric THOMAS [mailto:webdoublefx@hotmail.**comwebdoubl...@hotmail.com ] Sent: Friday, March 29, 2013 6:44 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse I can't remember I tried it but logically, removing the .classpath from the .gitignore, committing only the .classpath then re-adding it in the .gitignore should work but still, I think it's better to write a guideline than checkin IDE files :) -Fred -Message d'origine- From: Alex Harui Sent: Friday, March 29, 2013 2:30 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Is there a way to have a file in git that is also in gitignore? That way you get it when you clone, but when you modify it, it doesn't get checked back in. On 3/29/13 12:27 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: Currently its quite easy to setup the eclipse falcon project. Import falcon projects in eclipse, run ant script, sometimes refresh the projects and you are ready to go.. Wouldn't it get more complicated if you put classpath to gitignore? Then I always have to add the libraries by myself. Just my thoughts Cyrill Sent from my iPhone On 29.03.2013, at 17:28, Alex Harui aha...@adobe.com wrote: The .classpath files in compiler.jx and compiler.jx/tests are showing up as modified in git. Should we put them in .gitignore? I wouldn't mind having them in there as a starting point. On 3/28/13 11:55 PM, Erik de Bruin e...@ixsoftware.nl wrote: Normally, we don't. Some documentation might come in handy, though. EdB On Fri, Mar 29, 2013 at 7:25 AM, Alex Harui aha...@adobe.com wrote: When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com**] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It should download all dependant libraries. Cyrill On Fri, Mar 29, 2013 at 2:12 PM, Gordon Smith gosm...@adobe.com wrote: When I import the compiler.jx project into Eclipse, I get Project 'compiler.jx' is missing required library: 'lib/commons-io.jar' Project 'compiler.jx' is missing required library: 'lib/google/closure-compiler/**compiler.jar' There is no 'lib' directory in flex-falcon/compiler.jx. What am I doing wrong? - Gordon -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Michael Schmalle - Teoti Graphix, LLC http://www.teotigraphix.com http://blog.teotigraphix.com
Re: [FalconJx] progress update
Ok, we're back in business! I think this time I have been working with
the right version of FlexJS (the one with the timer and the drop down
list?) and it looks to work as advertised:
http://people.apache.org/~erikdebruin/flexjs/
Time to get packing for the long flight ;-)
EdB
On Fri, Mar 29, 2013 at 3:15 PM, Erik de Bruin e...@ixsoftware.nl wrote:
Ah, and there's plenty left for you to learn from :-)
EdB
On Fri, Mar 29, 2013 at 2:30 PM, Alex Harui aha...@adobe.com wrote:
No worries. Might be a good way for me to learn how it works by getting it
to work.
On 3/29/13 12:31 AM, Erik de Bruin e...@ixsoftware.nl wrote:
Uh oh... Turns out I was testing against an outdated ASJS lib
(pre-fb614905ac), so FalconJx DOESN'T WORK against the current
iteration of FlexJS. Sorry about that. I will work on that today, but
I don't have a lot of time, so it might be a while before I can catch
up, due to next week's travel to the land of golden opportunity.
EdB
On Thu, Mar 28, 2013 at 5:24 PM, Erik de Bruin e...@ixsoftware.nl wrote:
And another update (things are going much better than I expected):
FalconJx can now emit a fully functional version of the
FlexJSTest_again demo application. You can see it in action here
(provided you use Chrome or Firefox, I just noticed):
http://people.apache.org/~erikdebruin/flexjs/
Onwards and upwards ;-)
EdB
On Wed, Mar 27, 2013 at 9:58 PM, Erik de Bruin e...@ixsoftware.nl wrote:
I'd have to look into it for specifics, but of the top of my head it
seems that this most depends on the implementation in the FlexJS JS
framework. Emitting the strings required by that framework should
really be easy enough. If needed we can look forward into AST to
look for binding information. I do this in several other places
already. Even the binding expressions shouldn't be too much of a
problem, again depending on how this will be handled by the JS
framework.
EdB
On Wed, Mar 27, 2013 at 9:36 PM, Alex Harui aha...@adobe.com wrote:
[Bindable] results in extra codegen. Binding expressions with {} is a
whole
other ball of work.
I think in FalconJX you might have to modify the node tree in several
places
when you hit a [Bindable] node.
It isn't working correctly in FalconJS either, but my customer needs it
so
I'm hacking a fix.
On 3/27/13 1:28 PM, Erik de Bruin e...@ixsoftware.nl wrote:
No, not yet. How is this set up in FlexJS? I'm sure I can read Metadata
and
Databinding information, so I guess it depends on the requirements for
the
emitted JS if I can easily implement this ;-)
EdB
On Wednesday, March 27, 2013, Alex Harui wrote:
Does FalconJX handle [Bindable]? My customer is using it.
On 3/27/13 11:56 AM, Michael Schmalle apa...@teotigraphix.com
wrote:
Quoting Erik de Bruin e...@ixsoftware.nl:
Another one popped into my head just now: I have a gut feeling there
is a bit of circular logic going on in the whole 'backend',
'blockwalker' and 'emitter' construct. More specifically in the way
the references to them are passed around as arguments in the
constructors for the various classes. But I can't wrap around it well
enough to figure out whether it's wrong and if so, what might be done
about it. Don't get me wrong, it works well, it's just that it
somehow
isn't elegant. And that's in no way a comment on the effectiveness
or quality of your code, just something I thought I'd share and see
what you think.
Actually I think it works fine. The problem you are facing is with the
MXML emitter I am sure. This adds complexity to what you are trying to
accomplish and it is circular from the perspective of using AS within
MXML.
There is a buffer writer(output stream), a writer, a visitor and
emitter.
Each one takes a dependency of its parent. Trust me, if there is a
child that knows about its parent I am blind. Like I said, the block
walker is a visitor and the emitter is a visitor. You cannot escape
the fact there is recursion.
If you can think of a more elegant way to set it up, by all means
write a prototype. Remember, I wrote this with an atom bomb under me
and lighting in the sky, there may be parts that could be logicalized.
I have another full compiler in Randori that I am going to use as a
proof of concept with compiler plugins and my ASDoc compiler I wrote.
So I guess we both can experiment, we can agree to leave the core
alone for the time being.
EdB
On Wed, Mar 27, 2013 at 7:41 PM, Erik de Bruin e...@ixsoftware.nl
wrote:
Mike,
Just kidding ;-)
I'm really happy with FalconJx, once you get to know it it's a
pleasure to work with. I hope my last commits didn't give you any
additional work in your other projects? I did my best to leave all
the
APIs alone.
There are plenty of TODOs in the code, and I would also like to
suggest some kind of code review or something (I'm not used to
working
in groups, but that seems like a nice thing to do), since I've been
piling
RE: Can't build compiler.jx in Eclipse
downloads.xml downloads those 2 deps. Don't know why it is not doing that for you. I am no build file nija either. Mike Quoting Gordon Smith gosm...@adobe.com: Did you get it to work with the checked-in project files? No, I haven't had time to figure out what the problem is. The compiler.jx project is looking for google/closure-compiler/compiler.jar. Running 'ant clean main' at the level of flex-falcon doesn't produce such a file anywhere. I suspect that I need to run targets at the level of compiler.jx. But that's not the design I was following when I introduced the top-level build.xml for flex-falcon. You should be able to do all the basic stuff (command-line build, setup for Eclipse builds, test) at the top level. - Gordon -Original Message- From: Alex Harui [mailto:aha...@adobe.com] Sent: Friday, March 29, 2013 11:07 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Gordon, Did you get it to work with the checked-in project files? On 3/29/13 10:14 AM, Gordon Smith gosm...@adobe.com wrote: The project files should be under source control and they should build without tweaking when you import them. The only exception is having to configure things at the workspace level. For example, the compiler project requires that ANT_JAR be set in the classpath of the workspace. - Gordon -Original Message- From: Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Sent: Friday, March 29, 2013 6:44 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse I can't remember I tried it but logically, removing the .classpath from the .gitignore, committing only the .classpath then re-adding it in the .gitignore should work but still, I think it's better to write a guideline than checkin IDE files :) -Fred -Message d'origine- From: Alex Harui Sent: Friday, March 29, 2013 2:30 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Is there a way to have a file in git that is also in gitignore? That way you get it when you clone, but when you modify it, it doesn't get checked back in. On 3/29/13 12:27 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: Currently its quite easy to setup the eclipse falcon project. Import falcon projects in eclipse, run ant script, sometimes refresh the projects and you are ready to go.. Wouldn't it get more complicated if you put classpath to gitignore? Then I always have to add the libraries by myself. Just my thoughts Cyrill Sent from my iPhone On 29.03.2013, at 17:28, Alex Harui aha...@adobe.com wrote: The .classpath files in compiler.jx and compiler.jx/tests are showing up as modified in git. Should we put them in .gitignore? I wouldn't mind having them in there as a starting point. On 3/28/13 11:55 PM, Erik de Bruin e...@ixsoftware.nl wrote: Normally, we don't. Some documentation might come in handy, though. EdB On Fri, Mar 29, 2013 at 7:25 AM, Alex Harui aha...@adobe.com wrote: When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It should download all dependant libraries. Cyrill On Fri, Mar 29, 2013 at 2:12 PM, Gordon Smith gosm...@adobe.com wrote: When I import the compiler.jx project into Eclipse, I get Project 'compiler.jx' is missing required library: 'lib/commons-io.jar' Project 'compiler.jx' is missing required library: 'lib/google/closure-compiler/compiler.jar' There is no 'lib' directory in flex-falcon/compiler.jx. What am I doing wrong? - Gordon -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Michael Schmalle - Teoti Graphix, LLC http://www.teotigraphix.com http://blog.teotigraphix.com
RE: Can't build compiler.jx in Eclipse
I know Ant well enough to figure it out. - Gordon -Original Message- From: Michael Schmalle [mailto:apa...@teotigraphix.com] Sent: Friday, March 29, 2013 12:14 PM To: dev@flex.apache.org Subject: RE: Can't build compiler.jx in Eclipse downloads.xml downloads those 2 deps. Don't know why it is not doing that for you. I am no build file nija either. Mike Quoting Gordon Smith gosm...@adobe.com: Did you get it to work with the checked-in project files? No, I haven't had time to figure out what the problem is. The compiler.jx project is looking for google/closure-compiler/compiler.jar. Running 'ant clean main' at the level of flex-falcon doesn't produce such a file anywhere. I suspect that I need to run targets at the level of compiler.jx. But that's not the design I was following when I introduced the top-level build.xml for flex-falcon. You should be able to do all the basic stuff (command-line build, setup for Eclipse builds, test) at the top level. - Gordon -Original Message- From: Alex Harui [mailto:aha...@adobe.com] Sent: Friday, March 29, 2013 11:07 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Gordon, Did you get it to work with the checked-in project files? On 3/29/13 10:14 AM, Gordon Smith gosm...@adobe.com wrote: The project files should be under source control and they should build without tweaking when you import them. The only exception is having to configure things at the workspace level. For example, the compiler project requires that ANT_JAR be set in the classpath of the workspace. - Gordon -Original Message- From: Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Sent: Friday, March 29, 2013 6:44 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse I can't remember I tried it but logically, removing the .classpath from the .gitignore, committing only the .classpath then re-adding it in the .gitignore should work but still, I think it's better to write a guideline than checkin IDE files :) -Fred -Message d'origine- From: Alex Harui Sent: Friday, March 29, 2013 2:30 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Is there a way to have a file in git that is also in gitignore? That way you get it when you clone, but when you modify it, it doesn't get checked back in. On 3/29/13 12:27 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: Currently its quite easy to setup the eclipse falcon project. Import falcon projects in eclipse, run ant script, sometimes refresh the projects and you are ready to go.. Wouldn't it get more complicated if you put classpath to gitignore? Then I always have to add the libraries by myself. Just my thoughts Cyrill Sent from my iPhone On 29.03.2013, at 17:28, Alex Harui aha...@adobe.com wrote: The .classpath files in compiler.jx and compiler.jx/tests are showing up as modified in git. Should we put them in .gitignore? I wouldn't mind having them in there as a starting point. On 3/28/13 11:55 PM, Erik de Bruin e...@ixsoftware.nl wrote: Normally, we don't. Some documentation might come in handy, though. EdB On Fri, Mar 29, 2013 at 7:25 AM, Alex Harui aha...@adobe.com wrote: When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It should download all dependant libraries. Cyrill On Fri, Mar 29, 2013 at 2:12 PM, Gordon Smith gosm...@adobe.com wrote: When I import the compiler.jx project into Eclipse, I get Project 'compiler.jx' is missing required library: 'lib/commons-io.jar' Project 'compiler.jx' is missing required library: 'lib/google/closure-compiler/compiler.jar' There is no 'lib' directory in flex-falcon/compiler.jx. What am I doing wrong? - Gordon -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Michael Schmalle - Teoti Graphix, LLC http://www.teotigraphix.com http://blog.teotigraphix.com
RE: Can't build compiler.jx in Eclipse
I see no reason not to have Eclipse projects under source control. Why would this be bad practice? - Gordon -Original Message- From: omup...@gmail.com [mailto:omup...@gmail.com] On Behalf Of Om Sent: Friday, March 29, 2013 11:28 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse A happy middle would be to affix a .template extension and check that in. And the actual file extension would be added to gitignore. For example, .project would be added to gitignore. But, .project.template can be checked in. Whoever wants to use it, can copy the file into .project locally and tweak it as needed. Thanks, Om On Fri, Mar 29, 2013 at 11:17 AM, Michael Schmalle apa...@teotigraphix.comwrote: I will add my 2 cents. I think the people that say keep the IDE files out are used to maven and other such tools that can setup your IDE for you. The falcon framework has non of this and until it does, the Eclipse project IDE files stay in the repo. Mike Quoting Alex Harui aha...@adobe.com: Gordon, Did you get it to work with the checked-in project files? On 3/29/13 10:14 AM, Gordon Smith gosm...@adobe.com wrote: The project files should be under source control and they should build without tweaking when you import them. The only exception is having to configure things at the workspace level. For example, the compiler project requires that ANT_JAR be set in the classpath of the workspace. - Gordon -Original Message- From: Frédéric THOMAS [mailto:webdoublefx@hotmail.**comwebdoubl...@hotmail.com ] Sent: Friday, March 29, 2013 6:44 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse I can't remember I tried it but logically, removing the .classpath from the .gitignore, committing only the .classpath then re-adding it in the .gitignore should work but still, I think it's better to write a guideline than checkin IDE files :) -Fred -Message d'origine- From: Alex Harui Sent: Friday, March 29, 2013 2:30 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Is there a way to have a file in git that is also in gitignore? That way you get it when you clone, but when you modify it, it doesn't get checked back in. On 3/29/13 12:27 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: Currently its quite easy to setup the eclipse falcon project. Import falcon projects in eclipse, run ant script, sometimes refresh the projects and you are ready to go.. Wouldn't it get more complicated if you put classpath to gitignore? Then I always have to add the libraries by myself. Just my thoughts Cyrill Sent from my iPhone On 29.03.2013, at 17:28, Alex Harui aha...@adobe.com wrote: The .classpath files in compiler.jx and compiler.jx/tests are showing up as modified in git. Should we put them in .gitignore? I wouldn't mind having them in there as a starting point. On 3/28/13 11:55 PM, Erik de Bruin e...@ixsoftware.nl wrote: Normally, we don't. Some documentation might come in handy, though. EdB On Fri, Mar 29, 2013 at 7:25 AM, Alex Harui aha...@adobe.com wrote: When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com**] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It should download all dependant libraries. Cyrill On Fri, Mar 29, 2013 at 2:12 PM, Gordon Smith gosm...@adobe.com wrote: When I import the compiler.jx project into Eclipse, I get Project 'compiler.jx' is missing required library: 'lib/commons-io.jar' Project 'compiler.jx' is missing required library: 'lib/google/closure-compiler/**compiler.jar' There is no 'lib' directory in flex-falcon/compiler.jx. What am I doing wrong? - Gordon -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui -- Michael Schmalle - Teoti Graphix, LLC http://www.teotigraphix.com http://blog.teotigraphix.com
Re: Can't build compiler.jx in Eclipse
I think what's meant by bad practice is that most Eclipse projects are set up with local system dependencies in them, like paths etc. Having that type of information under version control would mean that everyone would change the information in the project to their required settings, end up with a changed file, which would then become part of the next commit, overwriting everyone else's file, who then have to change it... ad infinitum. I we set up the Falcon project files such that no changes need to be made, I'm perfectly happy to have them be under source control. Will make life much easier every time you have to set up these project anew. EdB On Fri, Mar 29, 2013 at 8:15 PM, Gordon Smith gosm...@adobe.com wrote: I see no reason not to have Eclipse projects under source control. Why would this be bad practice? - Gordon -Original Message- From: omup...@gmail.com [mailto:omup...@gmail.com] On Behalf Of Om Sent: Friday, March 29, 2013 11:28 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse A happy middle would be to affix a .template extension and check that in. And the actual file extension would be added to gitignore. For example, .project would be added to gitignore. But, .project.template can be checked in. Whoever wants to use it, can copy the file into .project locally and tweak it as needed. Thanks, Om On Fri, Mar 29, 2013 at 11:17 AM, Michael Schmalle apa...@teotigraphix.comwrote: I will add my 2 cents. I think the people that say keep the IDE files out are used to maven and other such tools that can setup your IDE for you. The falcon framework has non of this and until it does, the Eclipse project IDE files stay in the repo. Mike Quoting Alex Harui aha...@adobe.com: Gordon, Did you get it to work with the checked-in project files? On 3/29/13 10:14 AM, Gordon Smith gosm...@adobe.com wrote: The project files should be under source control and they should build without tweaking when you import them. The only exception is having to configure things at the workspace level. For example, the compiler project requires that ANT_JAR be set in the classpath of the workspace. - Gordon -Original Message- From: Frédéric THOMAS [mailto:webdoublefx@hotmail.**comwebdoubl...@hotmail.com ] Sent: Friday, March 29, 2013 6:44 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse I can't remember I tried it but logically, removing the .classpath from the .gitignore, committing only the .classpath then re-adding it in the .gitignore should work but still, I think it's better to write a guideline than checkin IDE files :) -Fred -Message d'origine- From: Alex Harui Sent: Friday, March 29, 2013 2:30 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Is there a way to have a file in git that is also in gitignore? That way you get it when you clone, but when you modify it, it doesn't get checked back in. On 3/29/13 12:27 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: Currently its quite easy to setup the eclipse falcon project. Import falcon projects in eclipse, run ant script, sometimes refresh the projects and you are ready to go.. Wouldn't it get more complicated if you put classpath to gitignore? Then I always have to add the libraries by myself. Just my thoughts Cyrill Sent from my iPhone On 29.03.2013, at 17:28, Alex Harui aha...@adobe.com wrote: The .classpath files in compiler.jx and compiler.jx/tests are showing up as modified in git. Should we put them in .gitignore? I wouldn't mind having them in there as a starting point. On 3/28/13 11:55 PM, Erik de Bruin e...@ixsoftware.nl wrote: Normally, we don't. Some documentation might come in handy, though. EdB On Fri, Mar 29, 2013 at 7:25 AM, Alex Harui aha...@adobe.com wrote: When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com**] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It should download all dependant libraries. Cyrill On Fri, Mar 29, 2013 at 2:12 PM, Gordon Smith gosm...@adobe.com wrote: When I import the compiler.jx project into Eclipse, I get Project 'compiler.jx' is missing
Re: Can't build compiler.jx in Eclipse
OK, sounds like we have reached consensus. I will try to get everything working again. On 3/29/13 1:51 PM, Erik de Bruin e...@ixsoftware.nl wrote: I think what's meant by bad practice is that most Eclipse projects are set up with local system dependencies in them, like paths etc. Having that type of information under version control would mean that everyone would change the information in the project to their required settings, end up with a changed file, which would then become part of the next commit, overwriting everyone else's file, who then have to change it... ad infinitum. I we set up the Falcon project files such that no changes need to be made, I'm perfectly happy to have them be under source control. Will make life much easier every time you have to set up these project anew. EdB On Fri, Mar 29, 2013 at 8:15 PM, Gordon Smith gosm...@adobe.com wrote: I see no reason not to have Eclipse projects under source control. Why would this be bad practice? - Gordon -Original Message- From: omup...@gmail.com [mailto:omup...@gmail.com] On Behalf Of Om Sent: Friday, March 29, 2013 11:28 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse A happy middle would be to affix a .template extension and check that in. And the actual file extension would be added to gitignore. For example, .project would be added to gitignore. But, .project.template can be checked in. Whoever wants to use it, can copy the file into .project locally and tweak it as needed. Thanks, Om On Fri, Mar 29, 2013 at 11:17 AM, Michael Schmalle apa...@teotigraphix.comwrote: I will add my 2 cents. I think the people that say keep the IDE files out are used to maven and other such tools that can setup your IDE for you. The falcon framework has non of this and until it does, the Eclipse project IDE files stay in the repo. Mike Quoting Alex Harui aha...@adobe.com: Gordon, Did you get it to work with the checked-in project files? On 3/29/13 10:14 AM, Gordon Smith gosm...@adobe.com wrote: The project files should be under source control and they should build without tweaking when you import them. The only exception is having to configure things at the workspace level. For example, the compiler project requires that ANT_JAR be set in the classpath of the workspace. - Gordon -Original Message- From: Frédéric THOMAS [mailto:webdoublefx@hotmail.**comwebdoubl...@hotmail.com ] Sent: Friday, March 29, 2013 6:44 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse I can't remember I tried it but logically, removing the .classpath from the .gitignore, committing only the .classpath then re-adding it in the .gitignore should work but still, I think it's better to write a guideline than checkin IDE files :) -Fred -Message d'origine- From: Alex Harui Sent: Friday, March 29, 2013 2:30 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Is there a way to have a file in git that is also in gitignore? That way you get it when you clone, but when you modify it, it doesn't get checked back in. On 3/29/13 12:27 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: Currently its quite easy to setup the eclipse falcon project. Import falcon projects in eclipse, run ant script, sometimes refresh the projects and you are ready to go.. Wouldn't it get more complicated if you put classpath to gitignore? Then I always have to add the libraries by myself. Just my thoughts Cyrill Sent from my iPhone On 29.03.2013, at 17:28, Alex Harui aha...@adobe.com wrote: The .classpath files in compiler.jx and compiler.jx/tests are showing up as modified in git. Should we put them in .gitignore? I wouldn't mind having them in there as a starting point. On 3/28/13 11:55 PM, Erik de Bruin e...@ixsoftware.nl wrote: Normally, we don't. Some documentation might come in handy, though. EdB On Fri, Mar 29, 2013 at 7:25 AM, Alex Harui aha...@adobe.com wrote: When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon Smith gosm...@adobe.com wrote: I ran 'ant clean main'. Do I need more targets? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com**] Sent: Thursday, March 28, 2013 8:45 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Hi Gordon Did you run build.xml first? It
Re: Can't build compiler.jx in Eclipse
OK, I added an 'all' target to the flex-falcon build.xml. I wasn't sure Gordon wanted to wait for the FalconJX stuff when running the default main target. Running 'all' should also set up Eclipse properly for FalconJX. I was able to use the .classpath files as-is after that. On 3/29/13 1:58 PM, Alex Harui aha...@adobe.com wrote: OK, sounds like we have reached consensus. I will try to get everything working again. On 3/29/13 1:51 PM, Erik de Bruin e...@ixsoftware.nl wrote: I think what's meant by bad practice is that most Eclipse projects are set up with local system dependencies in them, like paths etc. Having that type of information under version control would mean that everyone would change the information in the project to their required settings, end up with a changed file, which would then become part of the next commit, overwriting everyone else's file, who then have to change it... ad infinitum. I we set up the Falcon project files such that no changes need to be made, I'm perfectly happy to have them be under source control. Will make life much easier every time you have to set up these project anew. EdB On Fri, Mar 29, 2013 at 8:15 PM, Gordon Smith gosm...@adobe.com wrote: I see no reason not to have Eclipse projects under source control. Why would this be bad practice? - Gordon -Original Message- From: omup...@gmail.com [mailto:omup...@gmail.com] On Behalf Of Om Sent: Friday, March 29, 2013 11:28 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse A happy middle would be to affix a .template extension and check that in. And the actual file extension would be added to gitignore. For example, .project would be added to gitignore. But, .project.template can be checked in. Whoever wants to use it, can copy the file into .project locally and tweak it as needed. Thanks, Om On Fri, Mar 29, 2013 at 11:17 AM, Michael Schmalle apa...@teotigraphix.comwrote: I will add my 2 cents. I think the people that say keep the IDE files out are used to maven and other such tools that can setup your IDE for you. The falcon framework has non of this and until it does, the Eclipse project IDE files stay in the repo. Mike Quoting Alex Harui aha...@adobe.com: Gordon, Did you get it to work with the checked-in project files? On 3/29/13 10:14 AM, Gordon Smith gosm...@adobe.com wrote: The project files should be under source control and they should build without tweaking when you import them. The only exception is having to configure things at the workspace level. For example, the compiler project requires that ANT_JAR be set in the classpath of the workspace. - Gordon -Original Message- From: Frédéric THOMAS [mailto:webdoublefx@hotmail.**comwebdoubl...@hotmail.com ] Sent: Friday, March 29, 2013 6:44 AM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse I can't remember I tried it but logically, removing the .classpath from the .gitignore, committing only the .classpath then re-adding it in the .gitignore should work but still, I think it's better to write a guideline than checkin IDE files :) -Fred -Message d'origine- From: Alex Harui Sent: Friday, March 29, 2013 2:30 PM To: dev@flex.apache.org Subject: Re: Can't build compiler.jx in Eclipse Is there a way to have a file in git that is also in gitignore? That way you get it when you clone, but when you modify it, it doesn't get checked back in. On 3/29/13 12:27 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: Currently its quite easy to setup the eclipse falcon project. Import falcon projects in eclipse, run ant script, sometimes refresh the projects and you are ready to go.. Wouldn't it get more complicated if you put classpath to gitignore? Then I always have to add the libraries by myself. Just my thoughts Cyrill Sent from my iPhone On 29.03.2013, at 17:28, Alex Harui aha...@adobe.com wrote: The .classpath files in compiler.jx and compiler.jx/tests are showing up as modified in git. Should we put them in .gitignore? I wouldn't mind having them in there as a starting point. On 3/28/13 11:55 PM, Erik de Bruin e...@ixsoftware.nl wrote: Normally, we don't. Some documentation might come in handy, though. EdB On Fri, Mar 29, 2013 at 7:25 AM, Alex Harui aha...@adobe.com wrote: When I first imported the project it did not build and I ended up tweaking the project properties. Do we want the project files in Git? On 3/28/13 11:22 PM, Erik de Bruin e...@ixsoftware.nl wrote: Or sometimes plain Refresh (F5) on the project helps. EdB On Fri, Mar 29, 2013 at 4:55 AM, Cyrill Zadra cyrill.za...@gmail.com wrote: No that should be enough. You could also try 'ant super-clean main'. Sometimes you need to reopen and rebuild the eclipse project. Cyrill On Fri, Mar 29, 2013 at 2:19 PM, Gordon
Re: [DISCUSS] Apache Flex SDK Installer 2.5 RC4 (was: [DISCUSS] Apache Flex SDK Installer 2.5 RC3)
HI, Can you please build RC4 before I go for a vote, I just committed the sources and the release files ? Think this needs a minor change before calling for a new RC. installer/src/org/apache/flex/packageflexsdk/view/components/Tracker.mxml is missing an apache header. Justin
[jira] [Commented] (FLEX-28915) Data disappears from DataGrid when tablet state changed from portrait to landscape
[
https://issues.apache.org/jira/browse/FLEX-28915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617995#comment-13617995
]
Alex Harui commented on FLEX-28915:
---
Possible workaround:
Add script block to HomeView.mxml
fx:Script
![CDATA[
private function fixDG():void
{
systemManager.stage.addEventListener(orientationChanging,
orientationChangingHandler, true);
}
private function
orientationChangingHandler(event:Event):void
{
dg.grid.invalidateDisplayList();
}
]]
/fx:Script
Call it from creationComplete in view:
s:View xmlns:fx=http://ns.adobe.com/mxml/2009;
xmlns:s=library://ns.adobe.com/flex/spark title=HomeView
creationComplete=fixDG()
Let me know if this works for you, then we'll figure out a better actual fix
for the SDK.
Data disappears from DataGrid when tablet state changed from portrait to
landscape
--
Key: FLEX-28915
URL: https://issues.apache.org/jira/browse/FLEX-28915
Project: Apache Flex
Issue Type: Bug
Components: Spark: DataGrid
Affects Versions: Adobe Flex SDK Previous
Environment: Affected OS(s): Google Android
Language Found: English
Reporter: Adobe JIRA
Attachments: dataGridMobileRotate.zip
Steps to reproduce:
1.Run attached app on Android tablet
2.Turn the tablet
3.
Actual Results:
DataGrid looks empty
Expected Results:
data should stay
Workaround (if any):
on scroll data reappears
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLEX-28915) Data disappears from DataGrid when tablet state changed from portrait to landscape
[ https://issues.apache.org/jira/browse/FLEX-28915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Harui reassigned FLEX-28915: - Assignee: Alex Harui Data disappears from DataGrid when tablet state changed from portrait to landscape -- Key: FLEX-28915 URL: https://issues.apache.org/jira/browse/FLEX-28915 Project: Apache Flex Issue Type: Bug Components: Spark: DataGrid Affects Versions: Adobe Flex SDK Previous Environment: Affected OS(s): Google Android Language Found: English Reporter: Adobe JIRA Assignee: Alex Harui Attachments: dataGridMobileRotate.zip Steps to reproduce: 1.Run attached app on Android tablet 2.Turn the tablet 3. Actual Results: DataGrid looks empty Expected Results: data should stay Workaround (if any): on scroll data reappears -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-28915) Data disappears from DataGrid when tablet state changed from portrait to landscape
[ https://issues.apache.org/jira/browse/FLEX-28915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617998#comment-13617998 ] Alex Harui commented on FLEX-28915: --- Scroller calls clearVirtualCache on GridLayout when orientation changes. This sets all renderers.visible=false, but no updateDisplayList happens. Data disappears from DataGrid when tablet state changed from portrait to landscape -- Key: FLEX-28915 URL: https://issues.apache.org/jira/browse/FLEX-28915 Project: Apache Flex Issue Type: Bug Components: Spark: DataGrid Affects Versions: Adobe Flex SDK Previous Environment: Affected OS(s): Google Android Language Found: English Reporter: Adobe JIRA Assignee: Alex Harui Attachments: dataGridMobileRotate.zip Steps to reproduce: 1.Run attached app on Android tablet 2.Turn the tablet 3. Actual Results: DataGrid looks empty Expected Results: data should stay Workaround (if any): on scroll data reappears -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
