[VOTE] Release flink-connector-mongodb v1.1.0, release candidate #2

2024-01-30 Thread Leonard Xu
Hey all,

Please help review and vote on the release candidate #2 for the version v1.1.0 
of the
Apache Flink MongoDB Connector as follows:

[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* The official Apache source release to be deployed to dist.apache.org [2],
which are signed with the key with fingerprint
5B2F6608732389AEB67331F5B197E1F1108998AD [3],
* All artifacts to be deployed to the Maven Central Repository [4],
* Source code tag v1.1.0-rc2 [5],
* Website pull request listing the new release [6].

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.


Best,
Leonard
[1] 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353483
[2] 
https://dist.apache.org/repos/dist/dev/flink/flink-connector-mongodb-1.1.0-rc2/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1705/
[5] https://github.com/apache/flink-connector-mongodb/tree/v1.1.0-rc2
[6] https://github.com/apache/flink-web/pull/719

Re: [VOTE] Release flink-connector-opensearch v1.1.0, release candidate #1

2024-01-30 Thread Leonard Xu
Sorry for late verification, +1(binding)

- built from source code succeeded
- verified signatures
- verified hashsums 
- checked the contents contains jar and pom files in apache repo 
- checked Github release tag 
- checked release notes
- reviewed the web PR


Best,
Leonard

> 2024年1月13日 下午4:41,Jiabao Sun  写道:
> 
> +1 (non-binding)
> 
> - Validated hashes
> - Verified signature
> - Verified tags
> - Verified no binaries in the source archive
> - Reviewed web pr and found that there're some conflicts need to be resolved
> 
> Best,
> Jiabao
> 
> 
>> 2024年1月12日 23:58,Danny Cranmer  写道:
>> 
>> Apologies I jumped the gun on this one. We only have 2 binding votes.
>> Reopening the thread.
>> 
>> On Fri, Jan 12, 2024 at 3:43 PM Danny Cranmer 
>> wrote:
>> 
>>> Thanks all, this vote is now closed, I will announce the results on a
>>> separate thread.
>>> 
>>> Thanks,
>>> Danny
>>> 
>>> On Fri, Jan 12, 2024 at 3:43 PM Danny Cranmer 
>>> wrote:
>>> 
 +1 (binding)
 
 - Verified signatures and checksums
 - Reviewed release notes
 - Verified no binaries in the source archive
 - Source builds using Maven
 - Reviewed NOTICE files (I suppose the copyright needs to be 2024 now!)
 
 Thanks,
 Danny
 
 On Fri, Jan 12, 2024 at 12:56 PM Martijn Visser 
 wrote:
 
> One non blocking nit: the version for flink.version in the main POM is
> set to 1.17.1. I think this should be 1.17.0 (since that's the lowest
> possible Flink version that's supported).
> 
> +1 (binding)
> 
> - Validated hashes
> - Verified signature
> - Verified that no binaries exist in the source archive
> - Build the source with Maven
> - Verified licenses
> - Verified web PRs
> 
> On Mon, Jan 1, 2024 at 11:57 AM Danny Cranmer 
> wrote:
>> 
>> Hey,
>> 
>> Gordon, apologies for the delay. Yes this is the correct
> understanding, all
>> connectors follow a similar pattern.
>> 
>> Would appreciate some PMC eyes on this release.
>> 
>> Thanks,
>> Danny
>> 
>> On Thu, 23 Nov 2023, 23:28 Tzu-Li (Gordon) Tai, 
> wrote:
>> 
>>> Hi Danny,
>>> 
>>> Thanks for starting a RC for this.
>>> 
>>> From the looks of the staged POMs for 1.1.0-1.18, the flink versions
> for
>>> Flink dependencies still point to 1.17.1.
>>> 
>>> My understanding is that this is fine, as those provided scope
>>> dependencies (e.g. flink-streaming-java) will have their versions
>>> overwritten by the user POM if they do intend to compile their jobs
> against
>>> Flink 1.18.x.
>>> Can you clarify if this is the correct understanding of how we
> intend the
>>> externalized connector artifacts to be published? Related discussion
> on
>>> [1].
>>> 
>>> Thanks,
>>> Gordon
>>> 
>>> [1] https://lists.apache.org/thread/x1pyrrrq7o1wv1lcdovhzpo4qhd4tvb4
>>> 
>>> On Thu, Nov 23, 2023 at 3:14 PM Sergey Nuyanzin > 
>>> wrote:
>>> 
 +1 (non-binding)
 
 - downloaded artifacts
 - built from source
 - verified checksums and signatures
 - reviewed web pr
 
 
 On Mon, Nov 6, 2023 at 5:31 PM Ryan Skraba
> >>> 
 wrote:
 
> Hello! +1 (non-binding) Thanks for the release!
> 
> I've validated the source for the RC1:
> * flink-connector-opensearch-1.1.0-src.tgz at r64995
> * The sha512 checksum is OK.
> * The source file is signed correctly.
> * The signature 0F79F2AFB2351BC29678544591F9C1EC125FD8DB is
> found in
>>> the
> KEYS file, and on https://keyserver.ubuntu.com/
> * The source file is consistent with the GitHub tag v1.1.0-rc1,
> which
> corresponds to commit 0f659cc65131c9ff7c8c35eb91f5189e80414ea1
> - The files explicitly excluded by create_pristine_sources (such
> as
> .gitignore and the submodule tools/releasing/shared) are not
> present.
> * Has a LICENSE file and a NOTICE file
> * Does not contain any compiled binaries.
> 
> * The sources can be compiled and unit tests pass with
> flink.version
 1.17.1
> and flink.version 1.18.0
> 
> * Nexus has three staged artifact ids for 1.1.0-1.17 and
> 1.1.0-1.18
> - flink-connector-opensearch (.jar, -javadoc.jar, -sources.jar,
> -tests.jar and .pom)
> - flink-sql-connector-opensearch (.jar, -sources.jar and .pom)
> - flink-connector-gcp-pubsub-parent (only .pom)
> 
> All my best, Ryan
> 
> On Fri, Nov 3, 2023 at 10:29 AM Danny Cranmer <
> dannycran...@apache.org
 
> wrote:
>> 
>> Hi everyone,
>> 
>> Please review and vote on the release candidate #1 for the
> version
 1.1.0
>

Re: [VOTE] Release flink-connector-jdbc, release candidate #2

2024-01-31 Thread Leonard Xu
Thanks Sergey for driving this!
 
-1(binding) as we discussed on the web PR[1], looking forward next RC.

Best,
Leonard
[1] https://github.com/apache/flink-web/pull/707#discussion_r1471090061

> 2024年1月30日 上午8:17,Sergey Nuyanzin  写道:
> 
> Hi everyone,
> Please review and vote on the release candidate #2 for the version
> 3.1.2, as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> This version is compatible with Flink 1.16.x, 1.17.x and 1.18.x.
> 
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2], which are signed with the key with fingerprint
> 1596BBF0726835D8 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.1.2-rc2 [5],
> * website pull request listing the new release [6].
> 
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
> 
> Thanks,
> Release Manager
> 
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354088
> [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.1.2-rc2
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1704/
> [5] https://github.com/apache/flink-connector-jdbc/releases/tag/v3.1.2-rc2
> [6] https://github.com/apache/flink-web/pull/707



Re: [VOTE] Release flink-connector-mongodb v1.1.0, release candidate #2

2024-02-19 Thread Leonard Xu
+1 (binding)

- built from source code succeeded
- verified signatures
- verified hashsums 
- checked the contents contains jar and pom files in apache repo 
- checked Github release tag 
- checked release notes

Best,
Leonard

> 2024年2月8日 下午11:37,Martijn Visser  写道:
> 
> +1 (binding)
> 
> - Validated hashes
> - Verified signature
> - Verified that no binaries exist in the source archive
> - Build the source with Maven
> - Verified licenses
> - Verified web PRs
> 
> On Wed, Jan 31, 2024 at 10:41 AM Danny Cranmer  
> wrote:
>> 
>> Thanks for driving this Leonard!
>> 
>> +1 (binding)
>> 
>> - Release notes look ok
>> - Signatures/checksums of source archive are good
>> - Verified there are no binaries in the source archive
>> - Built sources locally successfully
>> - v1.0.0-rc2 tag exists in github
>> - Tag build passing on CI [1]
>> - Contents of Maven dist look complete
>> - Verified signatures/checksums of binary in maven dist is correct
>> - Verified NOTICE files and bundled dependencies
>> 
>> Thanks,
>> Danny
>> 
>> [1]
>> https://github.com/apache/flink-connector-mongodb/actions/runs/7709467379
>> 
>> On Wed, Jan 31, 2024 at 7:54 AM gongzhongqiang 
>> wrote:
>> 
>>> +1(non-binding)
>>> 
>>> - Signatures and Checksums are good
>>> - No binaries in the source archive
>>> - Tag is present
>>> - Build successful with jdk8 on ubuntu 22.04
>>> 
>>> 
>>> Leonard Xu  于2024年1月30日周二 18:23写道:
>>> 
>>>> Hey all,
>>>> 
>>>> Please help review and vote on the release candidate #2 for the version
>>>> v1.1.0 of the
>>>> Apache Flink MongoDB Connector as follows:
>>>> 
>>>> [ ] +1, Approve the release
>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>> 
>>>> The complete staging area is available for your review, which includes:
>>>> * JIRA release notes [1],
>>>> * The official Apache source release to be deployed to dist.apache.org
>>>> [2],
>>>> which are signed with the key with fingerprint
>>>> 5B2F6608732389AEB67331F5B197E1F1108998AD [3],
>>>> * All artifacts to be deployed to the Maven Central Repository [4],
>>>> * Source code tag v1.1.0-rc2 [5],
>>>> * Website pull request listing the new release [6].
>>>> 
>>>> The vote will be open for at least 72 hours. It is adopted by majority
>>>> approval, with at least 3 PMC affirmative votes.
>>>> 
>>>> 
>>>> Best,
>>>> Leonard
>>>> [1]
>>>> 
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353483
>>>> [2]
>>>> 
>>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-mongodb-1.1.0-rc2/
>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>>> [4]
>>>> https://repository.apache.org/content/repositories/orgapacheflink-1705/
>>>> [5] https://github.com/apache/flink-connector-mongodb/tree/v1.1.0-rc2
>>>> [6] https://github.com/apache/flink-web/pull/719
>>> 



Re: [VOTE] Release flink-connector-mongodb v1.1.0, release candidate #2

2024-02-19 Thread Leonard Xu
Thanks all for the voting, I’ll summarize the result in another mail.

Best,
Leonard


> 2024年2月19日 下午4:46,Leonard Xu  写道:
> 
> +1 (binding)
> 
> - built from source code succeeded
> - verified signatures
> - verified hashsums 
> - checked the contents contains jar and pom files in apache repo 
> - checked Github release tag 
> - checked release notes
> 
> Best,
> Leonard
> 
>> 2024年2月8日 下午11:37,Martijn Visser  写道:
>> 
>> +1 (binding)
>> 
>> - Validated hashes
>> - Verified signature
>> - Verified that no binaries exist in the source archive
>> - Build the source with Maven
>> - Verified licenses
>> - Verified web PRs
>> 
>> On Wed, Jan 31, 2024 at 10:41 AM Danny Cranmer  
>> wrote:
>>> 
>>> Thanks for driving this Leonard!
>>> 
>>> +1 (binding)
>>> 
>>> - Release notes look ok
>>> - Signatures/checksums of source archive are good
>>> - Verified there are no binaries in the source archive
>>> - Built sources locally successfully
>>> - v1.0.0-rc2 tag exists in github
>>> - Tag build passing on CI [1]
>>> - Contents of Maven dist look complete
>>> - Verified signatures/checksums of binary in maven dist is correct
>>> - Verified NOTICE files and bundled dependencies
>>> 
>>> Thanks,
>>> Danny
>>> 
>>> [1]
>>> https://github.com/apache/flink-connector-mongodb/actions/runs/7709467379
>>> 
>>> On Wed, Jan 31, 2024 at 7:54 AM gongzhongqiang 
>>> wrote:
>>> 
>>>> +1(non-binding)
>>>> 
>>>> - Signatures and Checksums are good
>>>> - No binaries in the source archive
>>>> - Tag is present
>>>> - Build successful with jdk8 on ubuntu 22.04
>>>> 
>>>> 
>>>> Leonard Xu  于2024年1月30日周二 18:23写道:
>>>> 
>>>>> Hey all,
>>>>> 
>>>>> Please help review and vote on the release candidate #2 for the version
>>>>> v1.1.0 of the
>>>>> Apache Flink MongoDB Connector as follows:
>>>>> 
>>>>> [ ] +1, Approve the release
>>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>>> 
>>>>> The complete staging area is available for your review, which includes:
>>>>> * JIRA release notes [1],
>>>>> * The official Apache source release to be deployed to dist.apache.org
>>>>> [2],
>>>>> which are signed with the key with fingerprint
>>>>> 5B2F6608732389AEB67331F5B197E1F1108998AD [3],
>>>>> * All artifacts to be deployed to the Maven Central Repository [4],
>>>>> * Source code tag v1.1.0-rc2 [5],
>>>>> * Website pull request listing the new release [6].
>>>>> 
>>>>> The vote will be open for at least 72 hours. It is adopted by majority
>>>>> approval, with at least 3 PMC affirmative votes.
>>>>> 
>>>>> 
>>>>> Best,
>>>>> Leonard
>>>>> [1]
>>>>> 
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353483
>>>>> [2]
>>>>> 
>>>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-mongodb-1.1.0-rc2/
>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>>>> [4]
>>>>> https://repository.apache.org/content/repositories/orgapacheflink-1705/
>>>>> [5] https://github.com/apache/flink-connector-mongodb/tree/v1.1.0-rc2
>>>>> [6] https://github.com/apache/flink-web/pull/719
>>>> 
> 



[RESULT][VOTE] Release flink-connector-mongodb 1.1.0, release candidate #2

2024-02-19 Thread Leonard Xu
I'm happy to announce that we have unanimously approved this release.

There are 6 approving votes, 3 of which are binding:

* Jiabao Sun (non-binding) 
* gongzhongqiang (non-binding)
* Hang Ruan (non-binding)
* Danny Cranmer (binding)
* Martijn Visser (binding)
* Leonard Xu (binding)

There are no disapproving votes.

Thanks all! and I’ll complete the release soon and announce it soon after this 
email.

Best,
Leonard

Re: [ANNOUNCE] New Apache Flink Committer - Jiabao Sun

2024-02-19 Thread Leonard Xu
Congratulations, Jiabao! Well deserved.


Best,
Leonard


> 2024年2月19日 下午6:21,David Radley  写道:
> 
> Congratulations Jiabao!
> 
> From: Swapnal Varma 
> Date: Monday, 19 February 2024 at 10:14
> To: dev@flink.apache.org 
> Subject: [EXTERNAL] Re: [ANNOUNCE] New Apache Flink Committer - Jiabao Sun
> Congratulations Jiabao!
> 
> Best,
> Swapnal
> 
> On Mon, 19 Feb 2024, 15:37 weijie guo,  wrote:
> 
>> Congratulations, Jiabao :)
>> 
>> Best regards,
>> 
>> Weijie
>> 
>> 
>> Hang Ruan  于2024年2月19日周一 18:04写道:
>> 
>>> Congratulations, Jiabao!
>>> 
>>> Best,
>>> Hang
>>> 
>>> Qingsheng Ren  于2024年2月19日周一 17:53写道:
>>> 
 Hi everyone,
 
 On behalf of the PMC, I'm happy to announce Jiabao Sun as a new Flink
 Committer.
 
 Jiabao began contributing in August 2022 and has contributed 60+
>> commits
 for Flink main repo and various connectors. His most notable
>> contribution
 is being the core author and maintainer of MongoDB connector, which is
 fully functional in DataStream and Table/SQL APIs. Jiabao is also the
 author of FLIP-377 and the main contributor of JUnit 5 migration in
>>> runtime
 and table planner modules.
 
 Beyond his technical contributions, Jiabao is an active member of our
 community, participating in the mailing list and consistently
>>> volunteering
 for release verifications and code reviews with enthusiasm.
 
 Please join me in congratulating Jiabao for becoming an Apache Flink
 committer!
 
 Best,
 Qingsheng (on behalf of the Flink PMC)
 
>>> 
>> 
> 
> Unless otherwise stated above:
> 
> IBM United Kingdom Limited
> Registered in England and Wales with number 741598
> Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU



[ANNOUNCE] Apache flink-connector-mongodb 1.1.0 released

2024-02-19 Thread Leonard Xu
The Apache Flink community is very happy to announce the release of Apache
flink-connector-mongodb 1.1.0. This release is compatible with Flink 1.17.x and 
1.18.x series.

Apache Flink® is an open-source stream processing framework for
distributed, high-performing, always-available, and accurate data streaming
applications.

The release is available for download at:
https://flink.apache.org/downloads.html

The full release notes are available in Jira:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353483

We would like to thank all contributors of the Apache Flink community who
made this release possible!

Best,
Leonard

Re: [VOTE] Release flink-connector-parent 1.1.0 release candidate #2

2024-02-19 Thread Leonard Xu
+1 (binding)

- verified signatures
- verified hashsums
- built from source code succeeded
- checked Github release tag 
- checked release notes
- reviewed all Jira tickets have been resolved
- reviewed the web PR

Best,
Leonard


> 2024年2月20日 上午11:14,Rui Fan <1996fan...@gmail.com> 写道:
> 
> Thanks for driving this, Etienne!
> 
> +1 (non-binding)
> 
> - Verified checksum and signature
> - Verified pom content
> - Build source on my Mac with jdk8
> - Verified no binaries in source
> - Checked staging repo on Maven central
> - Checked source code tag
> - Reviewed web PR
> 
> Best,
> Rui
> 
> On Tue, Feb 20, 2024 at 10:33 AM Qingsheng Ren  wrote:
> 
>> Thanks for driving this, Etienne!
>> 
>> +1 (binding)
>> 
>> - Checked release note
>> - Verified checksum and signature
>> - Verified pom content
>> - Verified no binaries in source
>> - Checked staging repo on Maven central
>> - Checked source code tag
>> - Reviewed web PR
>> - Built Kafka connector from source with parent pom in staging repo
>> 
>> Best,
>> Qingsheng
>> 
>> On Tue, Feb 20, 2024 at 1:34 AM Etienne Chauchot 
>> wrote:
>> 
>>> Hi everyone,
>>> Please review and vote on the release candidate #2 for the version
>>> 1.1.0, as follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>> 
>>> 
>>> The complete staging area is available for your review, which includes:
>>> * JIRA release notes [1],
>>> * the official Apache source release to be deployed to dist.apache.org
>>> [2], which are signed with the key with fingerprint
>>> D1A76BA19D6294DD0033F6843A019F0B8DD163EA [3],
>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> * source code tag v1.1.0-rc2 [5],
>>> * website pull request listing the new release [6].
>>> 
>>> * confluence wiki: connector parent upgrade to version 1.1.0 that will
>>> be validated after the artifact is released (there is no PR mechanism on
>>> the wiki) [7]
>>> 
>>> 
>>> The vote will be open for at least 72 hours. It is adopted by majority
>>> approval, with at least 3 PMC affirmative votes.
>>> 
>>> Thanks,
>>> Etienne
>>> 
>>> [1]
>>> 
>>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353442
>>> [2]
>>> 
>>> 
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-parent-1.1.0-rc2
>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> [4]
>> https://repository.apache.org/content/repositories/orgapacheflink-1707
>>> [5]
>>> 
>>> 
>> https://github.com/apache/flink-connector-shared-utils/releases/tag/v1.1.0-rc2
>>> 
>>> [6] https://github.com/apache/flink-web/pull/717
>>> 
>>> [7]
>>> 
>>> 
>> https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development
>>> 
>> 



Re: [VOTE] Release flink-connector-jdbc, release candidate #3

2024-02-20 Thread Leonard Xu
Thanks Sergey for driving this release.

+1 (binding)

- verified signatures
- verified hashsums
- built from source code with Maven 3.8.1 and Scala 2.12 succeeded
- checked Github release tag 
- checked release notes
- reviewed all jira tickets has been resolved
- reviewed the web PR and left one minor comment about backporting bugfix to 
main branch
**Note** The release date in jira[1] need to be updated

Best,
Leonard
[1] https://issues.apache.org/jira/projects/FLINK/versions/12354088


> 2024年2月20日 下午5:15,Sergey Nuyanzin  写道:
> 
> +1 (non-binding)
> 
> - Validated checksum hash
> - Verified signature from another machine
> - Checked that tag is present in Github
> - Built the source
> 
> On Tue, Feb 20, 2024 at 10:13 AM Sergey Nuyanzin 
> wrote:
> 
>> Hi David
>> thanks for checking and sorry for the late reply
>> 
>> yep, that's ok this just means that you haven't signed my key which is ok
>> (usually it could happen during virtual key signing parties)
>> 
>> For release checking it is ok to check that the key which was used to sign
>> the artifacts is included into Flink release KEYS file [1]
>> 
>> [1] https://dist.apache.org/repos/dist/release/flink/KEYS
>> 
>> On Thu, Feb 8, 2024 at 3:50 PM David Radley 
>> wrote:
>> 
>>> Thanks Sergey,
>>> 
>>> It looks better now.
>>> 
>>> gpg --verify flink-connector-jdbc-3.1.2-1.18.jar.asc
>>> 
>>> gpg: assuming signed data in 'flink-connector-jdbc-3.1.2-1.18.jar'
>>> 
>>> gpg: Signature made Thu  1 Feb 10:54:45 2024 GMT
>>> 
>>> gpg:using RSA key F7529FAE24811A5C0DF3CA741596BBF0726835D8
>>> 
>>> gpg: Good signature from "Sergey Nuyanzin (CODE SIGNING KEY)
>>> snuyan...@apache.org" [unknown]
>>> 
>>> gpg: aka "Sergey Nuyanzin (CODE SIGNING KEY)
>>> snuyan...@gmail.com" [unknown]
>>> 
>>> gpg: aka "Sergey Nuyanzin snuyan...@gmail.com>> snuyan...@gmail.com>" [unknown]
>>> 
>>> gpg: WARNING: This key is not certified with a trusted signature!
>>> 
>>> gpg:  There is no indication that the signature belongs to the
>>> owner.
>>> 
>>> I assume the warning is ok,
>>>  Kind regards, David.
>>> 
>>> From: Sergey Nuyanzin 
>>> Date: Thursday, 8 February 2024 at 14:39
>>> To: dev@flink.apache.org 
>>> Subject: [EXTERNAL] Re: FW: RE: [VOTE] Release flink-connector-jdbc,
>>> release candidate #3
>>> Hi David
>>> 
>>> it looks like in your case you don't specify the jar itself and probably
>>> it
>>> is not in current dir
>>> so it should be something like that (assuming that both asc and jar file
>>> are downloaded and are in current folder)
>>> gpg --verify flink-connector-jdbc-3.1.2-1.16.jar.asc
>>> flink-connector-jdbc-3.1.2-1.16.jar
>>> 
>>> Here it is a more complete guide how to do it for Apache projects [1]
>>> 
>>> [1] https://www.apache.org/info/verification.html#CheckingSignatures
>>> 
>>> On Thu, Feb 8, 2024 at 12:38 PM David Radley 
>>> wrote:
>>> 
 Hi,
 I was looking more at the asc files. I imported the keys and tried.
 
 
 gpg --verify flink-connector-jdbc-3.1.2-1.16.jar.asc
 
 gpg: no signed data
 
 gpg: can't hash datafile: No data
 
 This seems to be the same for all the asc file. It does not look right;
>>> am
 I doing doing incorrect?
   Kind regards, David.
 
 
 From: David Radley 
 Date: Thursday, 8 February 2024 at 10:46
 To: dev@flink.apache.org 
 Subject: [EXTERNAL] RE: [VOTE] Release flink-connector-jdbc, release
 candidate #3
 +1 (non-binding)
 
 I assume that thttps://github.com/apache/flink-web/pull/707 and be
 completed after the release is out.
 
 From: Martijn Visser 
 Date: Friday, 2 February 2024 at 08:38
 To: dev@flink.apache.org 
 Subject: [EXTERNAL] Re: [VOTE] Release flink-connector-jdbc, release
 candidate #3
 +1 (binding)
 
 - Validated hashes
 - Verified signature
 - Verified that no binaries exist in the source archive
 - Build the source with Maven
 - Verified licenses
 - Verified web PRs
 
 On Fri, Feb 2, 2024 at 9:31 AM Yanquan Lv  wrote:
 
> +1 (non-binding)
> 
> - Validated checksum hash
> - Verified signature
> - Build the source with Maven and jdk8/11/17
> - Check that the jar is built by jdk8
> - Verified that no binaries exist in the source archive
> 
> Sergey Nuyanzin  于2024年2月1日周四 19:50写道:
> 
>> Hi everyone,
>> Please review and vote on the release candidate #3 for the version
 3.1.2,
>> as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific
>>> comments)
>> 
>> This version is compatible with Flink 1.16.x, 1.17.x and 1.18.x.
>> 
>> The complete staging area is available for your review, which
>>> includes:
>> * JIRA release notes [1],
>> * the official Apache source release to be deployed to
>>> dist.apache

Re: [DISCUSS] Apache Bahir retired

2024-02-26 Thread Leonard Xu
Hey, Ferenc

Thanks for initiating this discussion. Apache Bahir is a great project that 
provided significant assistance to many Apache Flink/Spark users. It's pity 
news that it has been retired.

I believe that connectivity is crucial for building the ecosystem of the Flink 
such a computing engine. The community, or at least I, would actively support 
the introduction and maintenance of new connectors. Therefore, adding a Kudu 
connector or other connectors from Bahir makes sense to me, as long as we 
adhere to the development process for connectors in the Flink community[1].
I recently visited the Bahir Flink repository. Although the last release of 
Bahir Flink was in August ’22[2] which is compatible with Flink 1.14, its 
latest code is compatible with Flink 1.17[3]. So, based on the existing 
codebase, developing an official Apache Flink connector for Kudu or other 
connectors should be manageable. One point to consider is that if we're not 
developing a connector entirely from scratch but based on an existing 
repository, we must ensure that there are no copyright issues. Here, "no 
issues" means satisfying both Apache Bahir's and Apache Flink's copyright 
requirements. Honestly, I'm not an expert in copyright or legal matters. If 
you're interested in contributing to the Kudu connector, it might be necessary 
to attract other experienced community members to participate in this aspect.

Best,
Leonard

[1] https://cwiki.apache.org/confluence/display/FLINK/FLIP+Connector+Template
[2] https://github.com/apache/bahir-flink/releases/tag/v1.1.0
[3] https://github.com/apache/bahir-flink/blob/master/pom.xml#L116



> 2024年2月22日 下午6:37,Ferenc Csaky  写道:
> 
> Hello devs,
> 
> Just saw that the Bahir project is retired [1]. Any plans on what's happening 
> with the Flink connectors that were part of this project? We specifically use 
> the Kudu connector and integrate it to our platform at Cloudera, so we would 
> be okay to maintain it. Would it be possible to carry it over as separate 
> connector repu under the Apache umbrella similarly as it happened with the 
> external connectors previously?
> 
> Thanks,
> Ferenc



Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir

2024-03-06 Thread Leonard Xu
Thanks Ferenc for kicking off this discussion, I left some comments here:

(1) About the release version, could you specify kudu connector version instead 
of flink version 1.18 as external connector version is different with flink ?

(2) About the connector config options, could you enumerate these options so 
that we can review they’re reasonable or not?

(3) Metrics is also key part of connector, could you add the supported 
connector metrics to public interface as well?


Best,
Leonard


> 2024年3月6日 下午11:23,Ferenc Csaky  写道:
> 
> Hello devs,
> 
> Opening this thread to discuss a FLIP [1] about externalizing the Kudu 
> connector, as recently
> the Apache Bahir project were moved to the attic [2]. Some details were 
> discussed already
> in another thread [3]. I am proposing to externalize this connector and keep 
> it maintainable,
> and up to date.
> 
> Best regards,
> Ferenc
> 
> [1] 
> https://docs.google.com/document/d/1vHF_uVe0FTYCb6PRVStovqDeqb_C_FKjt2P5xXa7uhE
> [2] https://bahir.apache.org/
> [3] https://lists.apache.org/thread/2nb8dxxfznkyl4hlhdm3vkomm8rk4oyq



Re: [DISCUSS] FLIP-399: Flink Connector Doris

2024-03-06 Thread Leonard Xu
Thanks wudi for the updating, the FLIP generally looks good to me, I only left 
two minor suggestions:

(1) The suffix `.s` in configoption doris.request.query.timeout.s looks strange 
to me, could we change all time interval related option value type to Duration ?

(2) Could you check and improve all config options  like `doris.exec.mem.limit` 
to make them to follow flink config option naming and value type?

Best,
Leonard


> 
> 
>> 2024年3月6日 06:12,Jing Ge  写道:
>> 
>> Hi Di,
>> 
>> Thanks for your proposal. +1 for the contribution. I'd like to know your
>> thoughts about the following questions:
>> 
>> 1. According to your clarification of the exactly-once, thanks for it BTW,
>> no PreCommitTopology is required. Does it make sense to let DorisSink[1]
>> implement SupportsCommitter, since the TwoPhaseCommittingSink is
>> deprecated[2] before turning the Doris connector into a Flink connector?
>> 2. OLAP engines are commonly used as the tail/downstream of a data pipeline
>> to support further e.g. ad-hoc query or cube with feasible pre-aggregation.
>> Just out of curiosity, would you like to share some real use cases that
>> will use OLAP engines as the source of a streaming data pipeline? Or it
>> will only be used as the source for the batch?
>> 3. The E2E test only covered sink[3], if I am not mistaken. Would you like
>> to test the source in E2E too?
>> 
>> [1]
>> https://github.com/apache/doris-flink-connector/blob/43e0e5cf9b832854ea228fb093077872e3a311b6/flink-doris-connector/src/main/java/org/apache/doris/flink/sink/DorisSink.java#L55
>> [2]
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Enhance+and+synchronize+Sink+API+to+match+the+Source+API
>> [3]
>> https://github.com/apache/doris-flink-connector/blob/43e0e5cf9b832854ea228fb093077872e3a311b6/flink-doris-connector/src/test/java/org/apache/doris/flink/tools/cdc/MySQLDorisE2ECase.java#L96
>> 
>> Best regards,
>> Jing
>> 
>> On Tue, Mar 5, 2024 at 11:18 AM wudi <676366...@qq.com.invalid> wrote:
>> 
>>> Hi, Jeyhun Karimov.
>>> Thanks for your question.
>>> 
>>> - How to ensure Exactly-Once?
>>> 1. When the Checkpoint Barrier arrives, DorisSink will trigger the
>>> precommit api of StreamLoad to complete the persistence of data in Doris
>>> (the data will not be visible at this time), and will also pass this TxnID
>>> to the Committer.
>>> 2. When this Checkpoint of the entire Job is completed, the Committer will
>>> call the commit api of StreamLoad and commit TxnID to complete the
>>> visibility of the transaction.
>>> 3. When the task is restarted, the Txn with successful precommit and
>>> failed commit will be aborted based on the label-prefix, and Doris' abort
>>> API will be called. (At the same time, Doris will also abort transactions
>>> that have not been committed for a long time)
>>> 
>>> ps: At the same time, this part of the content has been updated in FLIP
>>> 
>>> - Because the default table model in Doris is Duplicate (
>>> https://doris.apache.org/docs/data-table/data-model/), which does not
>>> have a primary key, batch writing may cause data duplication, but UNIQ The
>>> model has a primary key, which ensures the idempotence of writing, thus
>>> achieving Exactly-Once
>>> 
>>> Brs,
>>> di.wu
>>> 
>>> 
 2024年3月2日 17:50,Jeyhun Karimov  写道:
 
 Hi,
 
 Thanks for the proposal. +1 for the FLIP.
 I have a few questions:
 
 - How exactly the two (Stream Load's two-phase commit and Flink's
>>> two-phase
 commit) combination will ensure the e2e exactly-once semantics?
 
 - The FLIP proposes to combine Doris's batch writing with the primary key
 table to achieve Exactly-Once semantics. Could you elaborate more on
>>> that?
 Why it is not the default behavior but a workaround?
 
 Regards,
 Jeyhun
 
 On Sat, Mar 2, 2024 at 10:14 AM Yanquan Lv  wrote:
 
> Thanks for driving this.
> The content is very detailed, it is recommended to add a section on Test
> Plan for more completeness.
> 
> Di Wu  于2024年1月25日周四 15:40写道:
> 
>> Hi all,
>> 
>> Previously, we had some discussions about contributing Flink Doris
>> Connector to the Flink community [1]. I want to further promote this
> work.
>> I hope everyone will help participate in this FLIP discussion and
>>> provide
>> more valuable opinions and suggestions.
>> Thanks.
>> 
>> [1] https://lists.apache.org/thread/lvh8g9o6qj8bt3oh60q81z0o1cv3nn8p
>> 
>> Brs,
>> di.wu
>> 
>> 
>> 
>> On 2023/12/07 05:02:46 wudi wrote:
>>> 
>>> Hi all,
>>> 
>>> As discussed in the previous email [1], about contributing the Flink
>> Doris Connector to the Flink community.
>>> 
>>> 
>>> Apache Doris[2] is a high-performance, real-time analytical database
>> based on MPP architecture, for scenarios where Flink is used for data
>> analysis, processing, or real-time writing on Doris, Flink Doris
> Conn

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread Leonard Xu

+1 (binding)

- verified signatures
- verified hashsums
- checked Github release tag 
- started SQL Client, used MySQL CDC connector to read records from database , 
the result is expected
- checked Jira issues for 1.19.0 and discussed with RMs that  FLINK-29114 won’t 
block this RC
- checked release notes
- reviewed the web PR 

Best,
Leonard

> 2024年3月14日 下午9:36,Sergey Nuyanzin  写道:
> 
> +1 (non-binding)
> 
> - Checked the pre-built jars are generated with jdk8
> - Verified signature and checksum
> - Verified no binary in source
> - Verified source code tag
> - Reviewed release note
> - Reviewed web PR
> - Built from source
> - Run a simple job successfully
> 
> On Thu, Mar 14, 2024 at 2:21 PM Martijn Visser 
> wrote:
> 
>> +1 (binding)
>> 
>> - Validated hashes
>> - Verified signature
>> - Verified that no binaries exist in the source archive
>> - Build the source with Maven via mvn clean install -Pcheck-convergence
>> -Dflink.version=1.19.0
>> - Verified licenses
>> - Verified web PR
>> - Started a cluster and the Flink SQL client, successfully read and wrote
>> with the Kafka connector to Confluent Cloud with AVRO and Schema Registry
>> enabled
>> 
>> On Thu, Mar 14, 2024 at 1:32 PM gongzhongqiang 
>> wrote:
>> 
>>> +1 (non-binding)
>>> 
>>> - Verified no binary files in source code
>>> - Verified signature and checksum
>>> - Build source code and run a simple job successfully
>>> - Reviewed the release announcement PR
>>> 
>>> Best,
>>> 
>>> Zhongqiang Gong
>>> 
>>> Ferenc Csaky  于2024年3月14日周四 20:07写道:
>>> 
 +1 (non-binding)
 
 - Verified checksum and signature
 - Verified no binary in src
 - Built from src
 - Reviewed release note PR
 - Reviewed web PR
 - Tested a simple datagen query and insert to blackhole sink via SQL
 Gateway
 
 Best,
 Ferenc
 
 
 
 
 On Thursday, March 14th, 2024 at 12:14, Jane Chan <
>> qingyue@gmail.com
 
 wrote:
 
> 
> 
> Hi Lincoln,
> 
> Thank you for the prompt response and the effort to provide clarity
>> on
 this
> matter.
> 
> Best,
> Jane
> 
> On Thu, Mar 14, 2024 at 6:02 PM Lincoln Lee lincoln.8...@gmail.com
 wrote:
> 
>> Hi Jane,
>> 
>> Thank you for raising this question. I saw the discussion in the
>> Jira
>> (include Matthias' point)
>> and sought advice from several PMCs (including the previous RMs),
>> the
>> majority of people
>> are in favor of merging the bugfix into the release branch even
>>> during
 the
>> release candidate
>> (RC) voting period, so we should accept all bugfixes (unless there
>>> is a
>> specific community
>> rule preventing it).
>> 
>> Thanks again for contributing to the community!
>> 
>> Best,
>> Lincoln Lee
>> 
>> Matthias Pohl matthias.p...@aiven.io.invalid 于2024年3月14日周四
>> 17:50写道:
>> 
>>> Update on FLINK-34227 [1] which I mentioned above: Chesnay helped
>>> identify
>>> a concurrency issue in the JobMaster shutdown logic which seems
>> to
 be in
>>> the code for quite some time. I created a PR fixing the issue
>>> hoping
 that
>>> the test instability is resolved with it.
>>> 
>>> The concurrency issue doesn't really explain why it only started
>> to
>>> appear
>>> recently in a specific CI setup (GHA with AdaptiveScheduler).
>> There
 is no
>>> hint in the git history indicating that it's caused by some newly
>>> introduced change. That is why I wouldn't make FLINK-34227 a
>> reason
 to
>>> cancel rc2. Instead, the fix can be provided in subsequent patch
>>> releases.
>>> 
>>> Matthias
>>> 
>>> [1] https://issues.apache.org/jira/browse/FLINK-34227
>>> 
>>> On Thu, Mar 14, 2024 at 8:49 AM Jane Chan qingyue@gmail.com
 wrote:
>>> 
 Hi Yun, Jing, Martijn and Lincoln,
 
 I'm seeking guidance on whether merging the bugfix[1][2] at
>> this
 stage
 is
 appropriate. I want to ensure that the actions align with the
 current
 release process and do not disrupt the ongoing preparations.
 
 [1] https://issues.apache.org/jira/browse/FLINK-29114
 [2] https://github.com/apache/flink/pull/24492
 
 Best,
 Jane
 
 On Thu, Mar 14, 2024 at 1:33 PM Yun Tang myas...@live.com
>> wrote:
 
> +1 (non-binding)
> 
> *
> Verified the signature and checksum.
> *
> Reviewed the release note PR
> *
> Reviewed the web announcement PR
> *
> Start a standalone cluster to submit the state machine
>> example,
 which
> works well.
> *
> Checked the pre-built jars are generated via JDK8
> *
> Verified the process profiler works well after setting
> rest.profiling.enabled: true
> 
>

Re: [DISCUSS] FLIP-436: Introduce "SHOW CREATE CATALOG" Syntax

2024-03-14 Thread Leonard Xu
Hi Yubin,

Thanks for driving the discussion, generally +1 for the FLIP, big +1 to 
finalize the whole catalog syntax story in one FLIP, 
thus I want to jump into the discussion again after you completed the whole 
catalog syntax story.

Best,
Leonard



> 2024年3月14日 下午8:39,Roc Marshal  写道:
> 
> Hi, Yubin
> 
> 
> Thank you for initiating this discussion! +1 for the proposal.
> 
> 
> 
> 
> 
> 
> Best,
> Yuepeng Pan
> 
> 
> 
> 
> 
> 
> 
> 
> 
> At 2024-03-14 18:57:35, "Ferenc Csaky"  wrote:
>> Hi Yubin,
>> 
>> Thank you for initiating this discussion! +1 for the proposal.
>> 
>> I also think it makes sense to group the missing catalog related
>> SQL syntaxes under this FLIP.
>> 
>> Looking forward to these features!
>> 
>> Best,
>> Ferenc
>> 
>> 
>> 
>> 
>> On Thursday, March 14th, 2024 at 08:31, Jane Chan  
>> wrote:
>> 
>>> 
>>> 
>>> Hi Yubin,
>>> 
>>> Thanks for leading the discussion. I'm +1 for the FLIP.
>>> 
>>> As Jark said, it's a good opportunity to enhance the syntax for Catalog
>>> from a more comprehensive perspective. So, I suggest expanding the scope of
>>> this FLIP by focusing on the mechanism instead of one use case to enhance
>>> the overall functionality. WDYT?
>>> 
>>> Best,
>>> Jane
>>> 
>>> On Thu, Mar 14, 2024 at 11:38 AM Hang Ruan ruanhang1...@gmail.com wrote:
>>> 
 Hi, Yubin.
 
 Thanks for the FLIP. +1 for it.
 
 Best,
 Hang
 
 Yubin Li lyb5...@gmail.com 于2024年3月14日周四 10:15写道:
 
> Hi Jingsong, Feng, and Jeyhun
> 
> Thanks for your support and feedback!
> 
>> However, could we add a new method `getCatalogDescriptor()` to
>> CatalogManager instead of directly exposing CatalogStore?
> 
> Good point, Besides the audit tracking issue, The proposed feature
> only requires `getCatalogDescriptor()` function. Exposing components
> with excessive functionality will bring unnecessary risks, I have made
> modifications in the FLIP doc [1]. Thank Feng :)
> 
>> Showing the SQL parser implementation in the FLIP for the SQL syntax
>> might be a bit confusing. Also, the formal definition is missing for
>> this SQL clause.
> 
> Thank Jeyhun for pointing it out :) I have updated the doc [1] .
> 
> [1]
 
 https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=296290756
 
> Best,
> Yubin
> 
> On Thu, Mar 14, 2024 at 2:18 AM Jeyhun Karimov je.kari...@gmail.com
> wrote:
> 
>> Hi Yubin,
>> 
>> Thanks for the proposal. +1 for it.
>> I have one comment:
>> 
>> I would like to see the SQL syntax for the proposed statement. Showing
>> the
>> SQL parser implementation in the FLIP
>> for the SQL syntax might be a bit confusing. Also, the formal
>> definition
>> is
>> missing for this SQL clause.
>> Maybe something like [1] might be useful. WDYT?
>> 
>> Regards,
>> Jeyhun
>> 
>> [1]
 
 https://github.com/apache/flink/blob/0da60ca1a4754f858cf7c52dd4f0c97ae0e1b0cb/docs/content/docs/dev/table/sql/show.md?plain=1#L620-L632
 
>> On Wed, Mar 13, 2024 at 3:28 PM Feng Jin jinfeng1...@gmail.com
>> wrote:
>> 
>>> Hi Yubin
>>> 
>>> Thank you for initiating this FLIP.
>>> 
>>> I have just one minor question:
>>> 
>>> I noticed that we added a new function `getCatalogStore` to expose
>>> CatalogStore, and it seems fine.
>>> However, could we add a new method `getCatalogDescriptor()` to
>>> CatalogManager instead of directly exposing CatalogStore?
>>> By only providing the `getCatalogDescriptor()` interface, it may be
>>> easier
>>> for us to implement audit tracking in CatalogManager in the future.
>>> WDYT ?
>>> Although we have only collected some modified events at the
>>> moment.[1]
>>> 
>>> [1].
 
 https://cwiki.apache.org/confluence/display/FLINK/FLIP-294%3A+Support+Customized+Catalog+Modification+Listener
 
>>> Best,
>>> Feng
>>> 
>>> On Wed, Mar 13, 2024 at 5:31 PM Jingsong Li jingsongl...@gmail.com
>>> wrote:
>>> 
 +1 for this.
 
 We are missing a series of catalog related syntaxes.
 Especially after the introduction of catalog store. [1]
 
 [1]
 
 https://cwiki.apache.org/confluence/display/FLINK/FLIP-295%3A+Support+lazy+initialization+of+catalogs+and+persistence+of+catalog+configurations
 
 Best,
 Jingsong
 
 On Wed, Mar 13, 2024 at 5:09 PM Yubin Li lyb5...@gmail.com
 wrote:
 
> Hi devs,
> 
> I'd like to start a discussion about FLIP-436: Introduce "SHOW
> CREATE
> CATALOG" Syntax [1].
> 
> At present, the `SHOW CREATE TABLE` statement provides strong
> support
> for
> users to easily
> reuse created tables. However, despite the increasing importance
> of the
>

Re: Apache Flink : Vector database connector

2024-03-17 Thread Leonard Xu
Hey, Asimansu

Happy to hear you’re interested to integrate vector database and Apache Flink, 
I’ve talked similar topic with milvus community[1] members, 
I am also very familiar with the CDC, thus I know the underlying value well 
that the integration of the two can bring to AI users.

If you are willing to contribute the corresponding connector, I will be very 
happy to take time to help review FLIP[2] and code in the community. 

Best,
Leonard

[1] https://github.com/milvus-io/milvus
[2] https://cwiki.apache.org/confluence/display/FLINK/FLIP+Connector+Template


> 2024年3月17日 上午2:18,Asimansu Bera  写道:
> 
> Hello Dev,
> 
> Vector databases like Waveiate are utilized in GenAI-based applications to
> store vector data in numeric format, supporting CRUD operations.
> Write-ahead logging (WAL) is employed to capture any changes made to the
> vector databases. For streaming-based applications, it's uncertain if
> tracking changes in vector classes and objects is significant. However,
> incorporating CDC (Change Data Capture) connectors can enhance processing
> capabilities for vector data in streaming applications, especially for
> LLM-based applications focused on data ingestion.
> 
> https://lnkd.in/gByTZYDY
> 
> Thoughts?
> 
> Note: all RDBMS are introducing support for vector data.



Re: [ANNOUNCE] Apache Flink 1.19.0 released

2024-03-18 Thread Leonard Xu
Congratulations, thanks release managers and all involved for the great work!


Best,
Leonard

> 2024年3月18日 下午4:32,Jingsong Li  写道:
> 
> Congratulations!
> 
> On Mon, Mar 18, 2024 at 4:30 PM Rui Fan <1996fan...@gmail.com> wrote:
>> 
>> Congratulations, thanks for the great work!
>> 
>> Best,
>> Rui
>> 
>> On Mon, Mar 18, 2024 at 4:26 PM Lincoln Lee  wrote:
>>> 
>>> The Apache Flink community is very happy to announce the release of Apache 
>>> Flink 1.19.0, which is the fisrt release for the Apache Flink 1.19 series.
>>> 
>>> Apache Flink® is an open-source stream processing framework for 
>>> distributed, high-performing, always-available, and accurate data streaming 
>>> applications.
>>> 
>>> The release is available for download at:
>>> https://flink.apache.org/downloads.html
>>> 
>>> Please check out the release blog post for an overview of the improvements 
>>> for this bugfix release:
>>> https://flink.apache.org/2024/03/18/announcing-the-release-of-apache-flink-1.19/
>>> 
>>> The full release notes are available in Jira:
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353282
>>> 
>>> We would like to thank all contributors of the Apache Flink community who 
>>> made this release possible!
>>> 
>>> 
>>> Best,
>>> Yun, Jing, Martijn and Lincoln



Re: [VOTE] FLIP-436: Introduce Catalog-related Syntax

2024-03-19 Thread Leonard Xu
+1(binding)


Best,
Leonard
> 2024年3月19日 下午9:03,Lincoln Lee  写道:
> 
> +1 (binding)
> 
> Best,
> Lincoln Lee
> 
> 
> Feng Jin  于2024年3月19日周二 19:59写道:
> 
>> +1 (non-binding)
>> 
>> Best,
>> Feng
>> 
>> On Tue, Mar 19, 2024 at 7:46 PM Ferenc Csaky 
>> wrote:
>> 
>>> +1 (non-binding).
>>> 
>>> Best,
>>> Ferenc
>>> 
>>> 
>>> 
>>> 
>>> On Tuesday, March 19th, 2024 at 12:39, Jark Wu  wrote:
>>> 
 
 
 +1 (binding)
 
 Best,
 Jark
 
 On Tue, 19 Mar 2024 at 19:05, Yuepeng Pan panyuep...@apache.org wrote:
 
> Hi, Yubin
> 
> Thanks for driving it !
> 
> +1 non-binding.
> 
> Best,
> Yuepeng Pan.
> 
> At 2024-03-19 17:56:42, "Yubin Li" lyb5...@gmail.com wrote:
> 
>> Hi everyone,
>> 
>> Thanks for all the feedback, I'd like to start a vote on the
>>> FLIP-436:
>> Introduce Catalog-related Syntax [1]. The discussion thread is here
>> [2].
>> 
>> The vote will be open for at least 72 hours unless there is an
>> objection or insufficient votes.
>> 
>> [1]
>> 
>>> 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-436%3A+Introduce+Catalog-related+Syntax
>> [2]
>> https://lists.apache.org/thread/10k1bjb4sngyjwhmfqfky28lyoo7sv0z
>> 
>> Best regards,
>> Yubin
>>> 
>> 



Re: [SUMMARY] Flink 1.19 last sync summary on 03/19/2024

2024-03-19 Thread Leonard Xu


Thanks for your continuous release sync summary,  Lincoln.  It help me a lot.


Best,
Leonard

> 2024年3月19日 下午11:49,Lincoln Lee  写道:
> 
> Hi everyone,
> 
> Flink 1.19.0 has been officially released yesterday[1].
> 
> I'd like to share some highlights of the last release sync of 1.19:
> 
> - Remaining works
> 
> The official docker image is still in progress[2], will be available once
> the related pr been merged[3].
> In addition, some follow-up items are being processed[4], and about end of
> support for lower versions will be discussed in separate mail.
> 
> Thanks to all contributors for your great work on 1.19 and the support for
> the release!
> 
> The new 1.20 release cycle[5] has set off, welcome to continue contributing!
> 
> [1] https://lists.apache.org/thread/sofmxytbh6y20nwot1gywqqc2lqxn4hm
> [2] https://issues.apache.org/jira/browse/FLINK-34701
> [3] https://github.com/docker-library/official-images/pull/16430
> [4] https://issues.apache.org/jira/browse/FLINK-34706
> [5] https://lists.apache.org/thread/80h3nzk08v276xmllswbbbg1z7m3v70t
> 
> 
> Best,
> Yun, Jing, Martijn and Lincoln



[ANNOUNCE] Donation Flink CDC into Apache Flink has Completed

2024-03-20 Thread Leonard Xu
Hi devs and users,

We are thrilled to announce that the donation of Flink CDC as a sub-project of 
Apache Flink has completed. We invite you to explore the new resources 
available:

- GitHub Repository: https://github.com/apache/flink-cdc
- Flink CDC Documentation: 
https://nightlies.apache.org/flink/flink-cdc-docs-stable

After Flink community accepted this donation[1], we have completed software 
copyright signing, code repo migration, code cleanup, website migration, CI 
migration and github issues migration etc. 
Here I am particularly grateful to Hang Ruan, Zhongqaing Gong, Qingsheng Ren, 
Jiabao Sun, LvYanquan, loserwang1024 and other contributors for their 
contributions and help during this process!


For all previous contributors: The contribution process has slightly changed to 
align with the main Flink project. To report bugs or suggest new features, 
please open tickets 
Apache Jira (https://issues.apache.org/jira).  Note that we will no longer 
accept GitHub issues for these purposes.


Welcome to explore the new repository and documentation. Your feedback and 
contributions are invaluable as we continue to improve Flink CDC.

Thanks everyone for your support and happy exploring Flink CDC!

Best,
Leonard
[1] https://lists.apache.org/thread/cw29fhsp99243yfo95xrkw82s5s418ob



Re: [VOTE] FLIP-439: Externalize Kudu Connector from Bahir

2024-03-21 Thread Leonard Xu
+1(binding)

Best,
Leonard

> 2024年3月21日 下午5:21,Martijn Visser  写道:
> 
> +1 (binding)
> 
> On Thu, Mar 21, 2024 at 8:01 AM gongzhongqiang 
> wrote:
> 
>> +1 (non-binding)
>> 
>> Bests,
>> Zhongqiang Gong
>> 
>> Ferenc Csaky  于2024年3月20日周三 22:11写道:
>> 
>>> Hello devs,
>>> 
>>> I would like to start a vote about FLIP-439 [1]. The FLIP is about to
>>> externalize the Kudu
>>> connector from the recently retired Apache Bahir project [2] to keep it
>>> maintainable and
>>> make it up to date as well. Discussion thread [3].
>>> 
>>> The vote will be open for at least 72 hours (until 2024 March 23 14:03
>>> UTC) unless there
>>> are any objections or insufficient votes.
>>> 
>>> Thanks,
>>> Ferenc
>>> 
>>> [1]
>>> 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-439%3A+Externalize+Kudu+Connector+from+Bahir
>>> [2] https://attic.apache.org/projects/bahir.html
>>> [3] https://lists.apache.org/thread/oydhcfkco2kqp4hdd1glzy5vkw131rkz
>> 



Re: [DISCUSS] Planning Flink 1.20

2024-03-21 Thread Leonard Xu
+1 for the proposed release managers (Weijie Guo, Rui Fan), both the two 
candidates are pretty active committers thus I believe they know the 
community development process well. The recent releases have four release 
managers, and I am also looking forward to having other volunteers
 join the management of Flink 1.20.

+1 for targeting date (feature freeze: June 15, 2024), referring to the release 
cycle of recent versions, release cycle of 4 months makes sense to me.


I'd like to help you if you need some help like permissions from PMC side, 
please feel free to ping me.

Best,
Leonard


> 2024年3月19日 下午5:35,Rui Fan <1996fan...@gmail.com> 写道:
> 
> Hi Weijie,
> 
> Thanks for kicking off 1.20! I'd like to join you and participate in the
> 1.20 release.
> 
> Best,
> Rui
> 
> On Tue, Mar 19, 2024 at 5:30 PM weijie guo 
> wrote:
> 
>> Hi everyone,
>> 
>> With the release announcement of Flink 1.19, it's a good time to kick off
>> discussion of the next release 1.20.
>> 
>> 
>> - Release managers
>> 
>> 
>> I'd like to volunteer as one of the release managers this time. It has been
>> good practice to have a team of release managers from different
>> backgrounds, so please raise you hand if you'd like to volunteer and get
>> involved.
>> 
>> 
>> 
>> - Timeline
>> 
>> 
>> Flink 1.19 has been released. With a target release cycle of 4 months,
>> we propose a feature freeze date of *June 15, 2024*.
>> 
>> 
>> 
>> - Collecting features
>> 
>> 
>> As usual, we've created a wiki page[1] for collecting new features in 1.20.
>> 
>> 
>> In addition, we already have a number of FLIPs that have been voted or are
>> in the process, including pre-works for version 2.0.
>> 
>> 
>> In the meantime, the release management team will be finalized in the next
>> few days, and we'll continue to create Jira Boards and Sync meetings
>> to make it easy
>> for everyone to get an overview and track progress.
>> 
>> 
>> 
>> Best regards,
>> 
>> Weijie
>> 
>> 
>> 
>> [1] https://cwiki.apache.org/confluence/display/FLINK/1.20+Release
>> 



Re: [DISCUSS] Flink Website Menu Adjustment

2024-03-25 Thread Leonard Xu
Thanks Zhongqiang for starting this discussion, updating documentation menus 
according to sub-projects' activities makes sense to me.  

+1 for the proposed menus:

> After:
> 
> With Flink
> With Flink Kubernetes Operator
> With Flink CDC
> With Flink ML
> With Flink Stateful Functions
> Training Course



Best,
Leonard

> 2024年3月25日 下午3:48,gongzhongqiang  写道:
> 
> Hi everyone,
> 
> I'd like to start a discussion on adjusting the Flink website [1] menu to
> improve accuracy and usability.While migrating Flink CDC documentation
> to the website, I found outdated links, need to review and update menus
> for the most relevant information for our users.
> 
> 
> Proposal:
> 
> - Remove Paimon [2] from the "Getting Started" and "Documentation" menus:
> Paimon [2] is now an independent top project of ASF. CC: jingsong lees
> 
> - Sort the projects in the subdirectory by the activity of the projects.
> Here I list the number of releases for each project in the past year.
> 
> Flink Kubernetes Operator : 7
> Flink CDC : 5
> Flink ML  : 2
> Flink Stateful Functions : 1
> 
> 
> Expected Outcome :
> 
> - Menu "Getting Started"
> 
> Before:
> 
> With Flink
> 
> With Flink Stateful Functions
> 
> With Flink ML
> 
> With Flink Kubernetes Operator
> 
> With Paimon(incubating) (formerly Flink Table Store)
> 
> With Flink CDC
> 
> Training Course
> 
> 
> After:
> 
> With Flink
> With Flink Kubernetes Operator
> 
> With Flink CDC
> 
> With Flink ML
> 
> With Flink Stateful Functions
> 
> Training Course
> 
> 
> - Menu "Documentation" will same with "Getting Started"
> 
> 
> I look forward to hearing your thoughts and suggestions on this proposal.
> 
> [1] https://flink.apache.org/
> [2] https://github.com/apache/incubator-paimon
> [3] https://github.com/apache/flink-statefun
> 
> 
> 
> Best regards,
> 
> Zhongqiang Gong



Re: [ANNOUNCE] Apache Flink Kubernetes Operator 1.8.0 released

2024-03-25 Thread Leonard Xu
Congratulations!  Thanks Maximilian for the release work and all involved.

Best,
Leonard



> 2024年3月25日 下午7:04,Muhammet Orazov  写道:
> 
> Great! Thanks Maximilian and everyone involved for the effort and release!
> 
> Best,
> Muhammet
> 
> On 2024-03-25 10:35, Maximilian Michels wrote:
>> The Apache Flink community is very happy to announce the release of
>> the Apache Flink Kubernetes Operator version 1.8.0.
>> The Flink Kubernetes Operator allows users to manage their Apache
>> Flink applications on Kubernetes through all aspects of their
>> lifecycle.
>> Release highlights:
>> - Flink Autotuning automatically adjusts TaskManager memory
>> - Flink Autoscaling metrics and decision accuracy improved
>> - Improve standalone Flink Autoscaling
>> - Savepoint trigger nonce for savepoint-based restarts
>> - Operator stability improvements for cluster shutdown
>> Blog post: 
>> https://flink.apache.org/2024/03/21/apache-flink-kubernetes-operator-1.8.0-release-announcement/
>> The release is available for download at:
>> https://flink.apache.org/downloads.html
>> Maven artifacts for Flink Kubernetes Operator can be found at:
>> https://search.maven.org/artifact/org.apache.flink/flink-kubernetes-operator
>> Official Docker image for Flink Kubernetes Operator can be found at:
>> https://hub.docker.com/r/apache/flink-kubernetes-operator
>> The full release notes are available in Jira:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353866&projectId=12315522
>> We would like to thank the Apache Flink community and its contributors
>> who made this release possible!
>> Cheers,
>> Max



Re: [DISCUSS] Planning Flink 1.20

2024-03-25 Thread Leonard Xu
Wow, happy to see Ufuk and Robert join the release managers group.

+1 for the release manager candidates(Weijie, Rui Fan,Ufuk and Robert) from my 
side.


Best,
Leonard



> 2024年3月25日 下午6:09,Robert Metzger  写道:
> 
> Hi, thanks for starting the discussion.
> 
> +1 for the proposed timeline and the three proposed release managers.
> 
> I'm happy to join the release managers group as well, as a backup for Ufuk
> (unless there are objections about the number of release managers)
> 
> On Mon, Mar 25, 2024 at 11:04 AM Ufuk Celebi  wrote:
> 
>> Hey all,
>> 
>> I'd like to join the release managers for 1.20 as well. I'm looking
>> forward to getting more actively involved again.
>> 
>> Cheers,
>> 
>> Ufuk
>> 
>> On Sun, Mar 24, 2024, at 11:27 AM, Ahmed Hamdy wrote:
>>> +1 for the proposed timeline and release managers.
>>> Best Regards
>>> Ahmed Hamdy
>>> 
>>> 
>>> On Fri, 22 Mar 2024 at 07:41, Xintong Song 
>> wrote:
>>> 
>>>> +1 for the proposed timeline and Weijie & Rui as the release managers.
>>>> 
>>>> I think it would be welcomed if another 1-2 volunteers join as the
>> release
>>>> managers, but that's not a must. We used to have only 1-2 release
>> managers
>>>> for each release,
>>>> 
>>>> Best,
>>>> 
>>>> Xintong
>>>> 
>>>> 
>>>> 
>>>> On Fri, Mar 22, 2024 at 2:55 PM Jark Wu  wrote:
>>>> 
>>>>> Thanks for kicking this off.
>>>>> 
>>>>> +1 for the volunteered release managers (Weijie Guo, Rui Fan) and the
>>>>> targeting date (feature freeze: June 15).
>>>>> 
>>>>> Best,
>>>>> Jark
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> On Fri, 22 Mar 2024 at 14:00, Rui Fan <1996fan...@gmail.com> wrote:
>>>>> 
>>>>>> Thanks Leonard for this feedback and help!
>>>>>> 
>>>>>> Best,
>>>>>> Rui
>>>>>> 
>>>>>> On Fri, Mar 22, 2024 at 12:36 PM weijie guo <
>> guoweijieres...@gmail.com
>>>>> 
>>>>>> wrote:
>>>>>> 
>>>>>>> Thanks Leonard!
>>>>>>> 
>>>>>>>> I'd like to help you if you need some help like permissions
>> from
>>>> PMC
>>>>>>> side, please feel free to ping me.
>>>>>>> 
>>>>>>> Nice to know. It'll help a lot!
>>>>>>> 
>>>>>>> Best regards,
>>>>>>> 
>>>>>>> Weijie
>>>>>>> 
>>>>>>> 
>>>>>>> Leonard Xu  于2024年3月22日周五 12:09写道:
>>>>>>> 
>>>>>>>> +1 for the proposed release managers (Weijie Guo, Rui Fan),
>> both the
>>>>> two
>>>>>>>> candidates are pretty active committers thus I believe they
>> know the
>>>>>>>> community development process well. The recent releases have
>> four
>>>>>> release
>>>>>>>> managers, and I am also looking forward to having other
>> volunteers
>>>>>>>> join the management of Flink 1.20.
>>>>>>>> 
>>>>>>>> +1 for targeting date (feature freeze: June 15, 2024),
>> referring to
>>>>> the
>>>>>>>> release cycle of recent versions, release cycle of 4 months
>> makes
>>>>> sense
>>>>>> to
>>>>>>>> me.
>>>>>>>> 
>>>>>>>> 
>>>>>>>> I'd like to help you if you need some help like permissions
>> from PMC
>>>>>>>> side, please feel free to ping me.
>>>>>>>> 
>>>>>>>> Best,
>>>>>>>> Leonard
>>>>>>>> 
>>>>>>>> 
>>>>>>>>> 2024年3月19日 下午5:35,Rui Fan <1996fan...@gmail.com> 写道:
>>>>>>>>> 
>>>>>>>>> Hi Weijie,
>>>>>>>>> 
>>>>>>>>> Thanks for kicking off 1.20! I'd like to join you and
>> participate
>>>> in
>>>>

Re: [DISCUSS] Externalized Google Cloud Connectors

2024-04-01 Thread Leonard Xu
Hey, Claire

Thanks starting this discussion, all flink external connector repos are 
sub-projects of Apache Flink, including  
https://github.com/apache/flink-connector-aws.

Creating a flink external connector repo  named flink-connectors-gcp as 
sub-project of Apache Beam is not a good idea from my side. 

>   Currently, we have no Flink committers on our team. We are actively
>   involved in the Apache Beam community and have a number of ASF members on
>   the team.

Not having Flink committer should not be a strong reason in this case,  Flink 
community welcome contributors to contribute and maintain the connectors, as a 
contributor, through continuous connector development and maintenance work in 
the community, you will also have the opportunity to become a Committer.

Best,
Leonard


> 2024年2月14日 上午12:24,Claire McCarthy  写道:
> 
> Hi Devs!
> 
> I’d like to kick off a discussion on setting up a repo for a new fleet of
> Google Cloud connectors.
> 
> A bit of context:
> 
>   -
> 
>   We have a team of Google engineers who are looking to build/maintain
>   5-10 GCP connectors for Flink.
>   -
> 
>   We are wondering if it would make sense to host our connectors under the
>   ASF umbrella following a similar repo structure as AWS (
>   https://github.com/apache/flink-connector-aws). In our case:
>   apache/flink-connectors-gcp.
>   -
> 
>   Currently, we have no Flink committers on our team. We are actively
>   involved in the Apache Beam community and have a number of ASF members on
>   the team.
> 
> 
> We saw that one of the original motivations for externalizing connectors
> was to encourage more activity and contributions around connectors by
> easing the contribution overhead. We understand that the decision was
> ultimately made to host the externalized connector repos under the ASF
> organization. For the same reasons (release infra, quality assurance,
> integration with the community, etc.), we would like all GCP connectors to
> live under the ASF organization.
> 
> We want to ask the Flink community what you all think of this idea, and
> what would be the best way for us to go about contributing something like
> this. We are excited to contribute and want to learn and follow your
> practices.
> 
> A specific issue we know of is that our changes need approval from Flink
> committers. Do you have a suggestion for how best to go about a new
> contribution like ours from a team that does not have committers? Is it
> possible, for example, to partner with a committer (or a small cohort) for
> tight engagement? We also know about ASF voting and release process, but
> that doesn't seem to be as much of a potential hurdle.
> 
> Huge thanks in advance for sharing your thoughts!
> 
> 
> Claire



Re: [DISCUSS] FLIP-434: Support optimizations for pre-partitioned data sources

2024-04-02 Thread Leonard Xu
Hey, Jeyhun 

Thanks for kicking off this discussion. I have two questions about streaming 
sources:

(1)The FLIP  motivation section says Kafka broker is already partitioned w.r.t. 
some key[s] , Is this the main use case in Kafka world? Partitioning by key 
fields is not the default partitioner of Kafka default partitioner[1] IIUC.

(2) Considering the FLIP’s optimization scope aims to both Batch and Streaming 
pre-partitioned source, could you add a Streaming Source example to help me 
understand the  FLIP better? I think Kafka Source is a good candidates for 
streaming source example, file source is a good one for batch source and it 
really helped me to follow-up the FLIP.

Best,
Leonard
[1]https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/producer/internals/DefaultPartitioner.java#L31



> 2024年4月3日 上午5:53,Jeyhun Karimov  写道:
> 
> Hi Lincoln,
> 
> Thanks a lot for your comments. Please find my answers below.
> 
> 
> 1. Is this flip targeted only at batch scenarios or does it include
>> streaming?
>> (The flip and the discussion did not explicitly mention this, but in the
>> draft pr, I only
>> saw the implementation for batch scenarios
>> 
>> https://github.com/apache/flink/pull/24437/files#diff-a6d71dd7d9bf0e7776404f54473b504e1de1240e93f820214fa5d1f082fb30c8
>> <
>> https://github.com/apache/flink/pull/24437/files#diff-a6d71dd7d9bf0e7776404f54473b504e1de1240e93f820214fa5d1f082fb30c8%EF%BC%89
>>> 
>> )
>> If we expect this also apply to streaming, then we need to consider the
>> stricter
>> shuffle restrictions of streaming compared to batch (if support is
>> considered,
>> more discussion is needed here, let’s not expand for now). If it only
>> applies to batch,
>> it is recommended to clarify in the flip.
> 
> 
> - The FLIP targets both streaming and batch scenarios.
> Could you please elaborate more on what you mean by additional
> restrictions?
> 
> 
> 2. In the current implementation, the optimized plan seems to have some
>> problems.
>> As described in the class comments:
>> 
>> https://github.com/apache/flink/blob/d6e3b51fdb9a2e565709e8d7bc619234b3768ed1/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/RemoveRedundantShuffleRule.java#L60
> 
> BatchPhysicalHashAggregate (local)
> 
>   +- BatchPhysicalLocalHashAggregate (local)
>>  +- BatchPhysicalTableSourceScan
>> The `BatchPhysicalLocalHashAggregate` here is redundant (in the case of
>> one-phase
>> hashAgg, localAgg is not necessary, which is the scenario currently handled
>> by
>> `RemoveRedundantLocalHashAggRule` and other rules)
> 
> 
> - Yes, you are completely right. Note that the PR you referenced is just a
> quick PoC.
> Redundant operators you mentioned exist because
> `RemoveRedundantShuffleRule` just removes the Exchange operator,
> without modifying upstream/downstream operators.
> As I mentioned, the implementation is just a PoC and the end implementation
> will make sure that existing redundancy elimination rules remove redundant
> operators.
> 
> 
> Also, in the draft pr,
>> the optimization of `testShouldEliminatePartitioning1` &
>> `testShouldEliminatePartitioning2`
>> seems didn't take effect?
>> 
>> https://github.com/apache/flink/blob/d6e3b51fdb9a2e565709e8d7bc619234b3768ed1/flink-table/flink-table-planner/src/test/resources/org/apache/flink/connector/file/table/BatchFileSystemTableSourceTest.xml#L38
> 
> 
> -  Note that in this example, Exchange operator have a
> property KEEP_INPUT_AS_IS that indicates that data distribution is the same
> as its input.
> Since we have redundant operators (as shown above, two aggregate operators)
> one of the rules (not in this FLIP)
> adds this Exchange operator with KEEP_INPUT_AS_IS in between.
> Similar to my comment above, the end implementation will be except from
> redundant operators.
> 
> In conjunction with question 2, I am wondering if we have a better choice
>> (of course, not simply adding the current `PHYSICAL_OPT_RULES`'s
>> `RemoveRedundantLocalXXRule`s
>> to the `PHYSICAL_REWRITE`).
>> For example, let the source actively provide some traits (including
>> `FlinkRelDistribution`
>> and `RelCollation`) to the planner. The advantage of doing this is to
>> directly reuse the
>> current shuffle remove optimization (as `FlinkExpandConversionRule`
>> implemented),
>> and according to the data distribution characteristics provided by the
>> source, the planner
>> may choose a physical operator with a cheaper costs (for example, according
>> to `RelCollation`,
>> the planner can use sortAgg, no need for a separate local sort operation).
>> WDYT?
> 
> 
> - Good point. Makes sense to me. I will check FlinkExpandConversionRule to
> be utilized in the implementation.
> 
> 
> Regards,
> Jeyhun
> 
> 
> 
> On Tue, Apr 2, 2024 at 6:01 PM Lincoln Lee  wrote:
> 
>> Hi Jeyhun,
>> 
>> Thank you for driving this, it would be very useful optimization!
>> 
>> Sorry for joining the discussion now(I or

Re: [VOTE] FLIP-437: Support ML Models in Flink SQL

2024-04-03 Thread Leonard Xu
+1(binding)

Best,
Leonard

> 2024年4月3日 下午3:37,Piotr Nowojski  写道:
> 
> +1 (binding)
> 
> Best,
> Piotrek
> 
> śr., 3 kwi 2024 o 04:29 Yu Chen  napisał(a):
> 
>> +1 (non-binding)
>> 
>> Looking forward to this future.
>> 
>> Thanks,
>> Yu Chen
>> 
>>> 2024年4月3日 10:23,Jark Wu  写道:
>>> 
>>> +1 (binding)
>>> 
>>> Best,
>>> Jark
>>> 
>>> On Tue, 2 Apr 2024 at 15:12, Timo Walther  wrote:
>>> 
 +1 (binding)
 
 Thanks,
 Timo
 
 On 29.03.24 17:30, Hao Li wrote:
> Hi devs,
> 
> I'd like to start a vote on the FLIP-437: Support ML Models in Flink
> SQL [1]. The discussion thread is here [2].
> 
> The vote will be open for at least 72 hours unless there is an
>> objection
 or
> insufficient votes.
> 
> [1]
> 
 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-437%3A+Support+ML+Models+in+Flink+SQL
> 
> [2] https://lists.apache.org/thread/9z94m2bv4w265xb5l2mrnh4lf9m28ccn
> 
> Thanks,
> Hao
> 
 
 
>> 
>> 



Re: [DISCUSS] FLIP-399: Flink Connector Doris

2024-04-06 Thread Leonard Xu
;>>> option is only used for error recovery scenarios, such as when a
>>>>>> transaction is cleared by the server but you want to reuse the upstream
>>>>>> offset from the checkpoint.
>>>>>> 
>>>>>> 3. Also, thank you for pointing out the issue with the parameter. It has
>>>>>> already been addressed[2], but the FLIP changes were overlooked. It has
>>>>>> been updated.
>>>>>> 
>>>>>> [1]
>>>>>> 
>>>> https://github.com/apache/doris-flink-connector/blob/master/flink-doris-connector/src/main/java/org/apache/doris/flink/sink/committer/DorisCommitter.java#L150-L160
>>>>>> [2]
>>>>>> 
>>>> https://github.com/apache/doris-flink-connector/blob/master/flink-doris-connector/src/main/java/org/apache/doris/flink/table/DorisConfigOptions.java#L89-L98
>>>>>> 
>>>>>> Brs
>>>>>> di.wu
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>>> 2024年3月22日 18:28,Feng Jin  写道:
>>>>>>> 
>>>>>>> Hi Di,
>>>>>>> 
>>>>>>> Thank you for the update, as well as quickly implementing corresponding
>>>>>>> capabilities including filter push down and project push down.
>>>>>>> 
>>>>>>> Regarding the transaction timeout, I still have some doubts. I would
>>>> like
>>>>>>> to confirm if we can control this timeout parameter in the connector,
>>>>>> such
>>>>>>> as setting it to 10 minutes or 1 hour.
>>>>>>> Also, when a transaction is cleared by the server, the commit operation
>>>>>> of
>>>>>>> the connector will fail, leading to job failure. In this case, can
>>>> users
>>>>>>> only choose to delete the checkpoint and re-consume historical data?
>>>>>>> 
>>>>>>> There is also a small question regarding the parameters*: *
>>>>>>> *doris.request.connect.timeout.ms <
>>>>>> http://doris.request.connect.timeout.ms>*
>>>>>>> and d*oris.request.read.timeout.ms <
>>>> http://oris.request.read.timeout.ms
>>>>>>> *,
>>>>>>> can we change them to Duration type and remove the "ms" suffix.?
>>>>>>> This way, all time parameters can be kept uniform in type as duration.
>>>>>>> 
>>>>>>> 
>>>>>>> Best,
>>>>>>> Feng
>>>>>>> 
>>>>>>> On Fri, Mar 22, 2024 at 4:46 PM wudi <676366...@qq.com.invalid> wrote:
>>>>>>> 
>>>>>>>> Hi, Feng,
>>>>>>>> Thank you, that's a great suggestion !
>>>>>>>> 
>>>>>>>> I have already implemented FilterPushDown and removed that parameter
>>>> on
>>>>>>>> DorisDynamicTableSource[1], and also updated FLIP.
>>>>>>>> 
>>>>>>>> Regarding the mention of [Doris also aborts transactions], it may not
>>>>>> have
>>>>>>>> been described accurately. It mainly refers to the automatic
>>>> expiration
>>>>>> of
>>>>>>>> long-running transactions in Doris that have not been committed for a
>>>>>>>> prolonged period.
>>>>>>>> 
>>>>>>>> As for two-phase commit, when a commit fails, the checkpoint will also
>>>>>>>> fail, and the job will be continuously retried.
>>>>>>>> 
>>>>>>>> [1]
>>>>>>>> 
>>>>>> 
>>>> https://github.com/apache/doris-flink-connector/blob/master/flink-doris-connector/src/main/java/org/apache/doris/flink/table/DorisDynamicTableSource.java#L58
>>>>>>>> 
>>>>>>>> Brs
>>>>>>>> di.wu
>>>>>>>> 
>>>>>>>> 
>>>>>>>>> 2024年3月15日 14:53,Feng Jin  写道:
>>>>>>>>> 
>>>>>>>>> Hi Di
>>>>>>>>> 
>>>>>>>>> Thank you for initiating this FLIP, +1 for this.
>>>>>>>>> 
>>>>>>>>> Regarding the opti

Re: [VOTE] FLIP-399: Flink Connector Doris

2024-04-09 Thread Leonard Xu
+1 (binding)

Best,
Leonard

> 2024年4月9日 下午5:11,Muhammet Orazov  写道:
> 
> Hey Wudi,
> 
> Thanks for your efforts.
> 
> +1 (non-binding)
> 
> Best,
> Muhammet
> 
> On 2024-04-09 02:47, wudi wrote:
>> Hi devs,
>> I would like to start a vote about FLIP-399 [1]. The FLIP is about 
>> contributing the Flink Doris Connector[2] to the Flink community. Discussion 
>> thread [3].
>> The vote will be open for at least 72 hours unless there is an objection or
>> insufficient votes.
>> Thanks,
>> Di.Wu
>> [1] 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-399%3A+Flink+Connector+Doris
>> [2] https://github.com/apache/doris-flink-connector
>> [3] https://lists.apache.org/thread/p3z4wsw3ftdyfs9p2wd7bbr2gfyl3xnh



Re: [ANNOUNCE] New Apache Flink PMC Member - Jing Ge

2024-04-14 Thread Leonard Xu
Congratulations, Jing~

Best,
Leonard

> 2024年4月14日 下午4:23,Xia Sun  写道:
> 
> Congratulations, Jing!
> 
> Best,
> Xia
> 
> Ferenc Csaky  于2024年4月13日周六 00:50写道:
> 
>> Congratulations, Jing!
>> 
>> Best,
>> Ferenc
>> 
>> 
>> 
>> On Friday, April 12th, 2024 at 13:54, Ron liu  wrote:
>> 
>>> 
>>> 
>>> Congratulations, Jing!
>>> 
>>> Best,
>>> Ron
>>> 
>>> Junrui Lee jrlee@gmail.com 于2024年4月12日周五 18:54写道:
>>> 
 Congratulations, Jing!
 
 Best,
 Junrui
 
 Aleksandr Pilipenko z3d...@gmail.com 于2024年4月12日周五 18:28写道:
 
> Congratulations, Jing!
> 
> Best Regards,
> Aleksandr
>> 



Re: [ANNOUNCE] New Apache Flink PMC Member - Lincoln Lee

2024-04-14 Thread Leonard Xu
Congratulations, Lincoln~

Best,
Leonard



> 2024年4月12日 下午4:40,Yuepeng Pan  写道:
> 
> Congratulations, Lincoln!
> 
> Best,Yuepeng Pan
> At 2024-04-12 16:24:01, "Yun Tang"  wrote:
>> Congratulations, Lincoln!
>> 
>> 
>> Best
>> Yun Tang
>> 
>> From: Jark Wu 
>> Sent: Friday, April 12, 2024 15:59
>> To: dev 
>> Cc: Lincoln Lee 
>> Subject: [ANNOUNCE] New Apache Flink PMC Member - Lincoln Lee
>> 
>> Hi everyone,
>> 
>> On behalf of the PMC, I'm very happy to announce that Lincoln Lee has
>> joined the Flink PMC!
>> 
>> Lincoln has been an active member of the Apache Flink community for
>> many years. He mainly works on Flink SQL component and has driven
>> /pushed many FLIPs around SQL, including FLIP-282/373/415/435 in
>> the recent versions. He has a great technical vision of Flink SQL and
>> participated in plenty of discussions in the dev mailing list. Besides
>> that,
>> he is community-minded, such as being the release manager of 1.19,
>> verifying releases, managing release syncs, writing the release
>> announcement etc.
>> 
>> Congratulations and welcome Lincoln!
>> 
>> Best,
>> Jark (on behalf of the Flink PMC)



Re: [ANNOUNCE] New Apache Flink Committer - Zakelly Lan

2024-04-15 Thread Leonard Xu
Congratulations Zakelly!


Best,
Leonard
> 2024年4月15日 下午3:56,Samrat Deb  写道:
> 
> Congratulations Zakelly!



Re: [ANNOUNCE] New Apache Flink Committer - Lijie Wang

2022-08-17 Thread Leonard Xu
Congratulations, Lijie!

Best,
Leonard

> 2022年8月18日 上午11:26,Zhipeng Zhang  写道:
> 
> Congratulations, Lijie!
> 
> Xintong Song  于2022年8月18日周四 11:23写道:
>> 
>> Congratulations Lijie, and welcome~!
>> 
>> Best,
>> 
>> Xintong
>> 
>> 
>> 
>> On Thu, Aug 18, 2022 at 11:12 AM Xingbo Huang  wrote:
>> 
>>> Congrats, Lijie
>>> 
>>> Best,
>>> Xingbo
>>> 
>>> Lincoln Lee  于2022年8月18日周四 11:01写道:
>>> 
 Congratulations, Lijie!
 
 Best,
 Lincoln Lee
 
 
 Benchao Li  于2022年8月18日周四 10:51写道:
 
> Congratulations Lijie!
> 
> yanfei lei  于2022年8月18日周四 10:44写道:
> 
>> Congratulations, Lijie!
>> 
>> Best,
>> Yanfei
>> 
>> JunRui Lee  于2022年8月18日周四 10:35写道:
>> 
>>> Congratulations, Lijie!
>>> 
>>> Best,
>>> JunRui
>>> 
>>> Timo Walther  于2022年8月17日周三 19:30写道:
>>> 
 Congratulations and welcome to the committer team :-)
 
 Regards,
 Timo
 
 
 On 17.08.22 12:50, Yuxin Tan wrote:
> Congratulations, Lijie!
> 
> Best,
> Yuxin
> 
> 
> Guowei Ma  于2022年8月17日周三 18:42写道:
> 
>> Congratulations, Lijie. Welcome on board~!
>> Best,
>> Guowei
>> 
>> 
>> On Wed, Aug 17, 2022 at 6:25 PM Zhu Zhu 
 wrote:
>> 
>>> Hi everyone,
>>> 
>>> On behalf of the PMC, I'm very happy to announce Lijie Wang
>>> as
>>> a new Flink committer.
>>> 
>>> Lijie has been contributing to Flink project for more than 2
> years.
>>> He mainly works on the runtime/coordination part, doing
>>> feature
>>> development, problem debugging and code reviews. He has also
>>> driven the work of FLIP-187(Adaptive Batch Scheduler) and
>>> FLIP-224(Blocklist for Speculative Execution), which are
> important
>>> to run batch jobs.
>>> 
>>> Please join me in congratulating Lijie for becoming a Flink
>>> committer!
>>> 
>>> Cheers,
>>> Zhu
>>> 
>> 
> 
 
 
>>> 
>> 
> 
> 
> --
> 
> Best,
> Benchao Li
> 
 
>>> 
> 
> 
> 
> -- 
> best,
> Zhipeng



Re: [ANNOUNCE] New Apache Flink Committer - Junhan Yang

2022-08-17 Thread Leonard Xu
Congratulations, Junhan!

Best,

> 2022年8月18日 上午11:27,Zhipeng Zhang  写道:
> 
> Congratulations, Junhan!
> 
> Xintong Song  于2022年8月18日周四 11:21写道:
>> 
>> Hi everyone,
>> 
>> On behalf of the PMC, I'm very happy to announce Junhan Yang as a new Flink
>> committer.
>> 
>> Junhan has been contributing to the Flink project for more than 1 year. His
>> contributions are mostly identified in the web frontend, including
>> FLIP-241, FLIP-249 and various maintenance efforts of Flink's frontend
>> frameworks.
>> 
>> Please join me in congratulating Junhan for becoming a Flink committer!
>> 
>> Best,
>> Xintong
> 
> 
> 
> -- 
> best,
> Zhipeng



Re: [VOTE] FLIP-262: MongoDB Connector

2022-10-09 Thread Leonard Xu
Thanks Jiabao for driving this work.

+1(binding)

Best,
Leonard Xu

> 2022年9月30日 下午5:02,jiabao.sun  写道:
> 
> Hi everyone,
> 
> 
> Thanks for all your feedback for FLIP-262[1]: MongoDB Connector in the 
> discussion thread[2],
> I'd like to start a vote for it.
> 
> 
> The vote will be open for at least 72 hours.
> 
> 
> [1] 
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-262%3A+Introduce+MongoDB+connector
> [2] https://lists.apache.org/thread/bhzj70t9g6ofdk8hqtfjjlxqnl0l4xwn
> 
> 
> Best,
> Jiabao Sun



Re: [DISCUSS] Reverting sink metric name changes made in 1.15

2022-10-10 Thread Leonard Xu
Thanks Qingsheng for starting this thread.

+1 on reverting sink metric name and releasing 1.15.3 to fix this inconsistent 
behavior.


Best,
Leonard





> 2022年10月10日 下午3:06,Jark Wu  写道:
> 
> Thanks for discovering this problem, Qingsheng!
> 
> I'm also +1 for reverting the breaking changes. 
> 
> IIUC, currently, the behavior of "numXXXOut" metrics of the new and old sink 
> is inconsistent. 
> We have to break one of them to have consistent behavior. Sink V2 is an 
> evolving API which is just introduced in 1.15. 
> I think it makes sense to break the unstable API instead of the stable API 
> which many connectors and users depend on.
> 
> Best,
> Jark
> 
> 
> 
> On Mon, 10 Oct 2022 at 11:36, Jingsong Li  > wrote:
> Thanks for driving, Qingsheng.
> 
> +1 for reverting sink metric name.
> 
> We often forget that metric is also one of the important APIs.
> 
> +1 for releasing 1.15.3 to fix this.
> 
> Best,
> Jingsong
> 
> On Sun, Oct 9, 2022 at 11:35 PM Becket Qin  > wrote:
> >
> > Thanks for raising the discussion, Qingsheng,
> >
> > +1 on reverting the breaking changes.
> >
> > In addition, we might want to release a 1.15.3 to fix this and update the 
> > previous release docs with this known issue, so that users can upgrade to 
> > 1.15.3 when they hit it. It would also be good to add some backwards 
> > compatibility tests on metrics to avoid unintended breaking changes like 
> > this in the future.
> >
> > Thanks,
> >
> > Jiangjie (Becket) Qin
> >
> > On Sun, Oct 9, 2022 at 10:35 AM Qingsheng Ren  > > wrote:
> >>
> >> Hi devs and users,
> >>
> >> I’d like to start a discussion about reverting a breaking change about 
> >> sink metrics made in 1.15 by FLINK-26126 [1] and FLINK-26492 [2].
> >>
> >> TL;DR
> >>
> >> All sink metrics with name “numXXXOut” defined in FLIP-33 are replace by 
> >> “numXXXSend” in FLINK-26126 and FLINK-26492. Considering metric names are 
> >> public APIs, this is a breaking change to end users and not backward 
> >> compatible. Also unfortunately this breaking change was not discussed in 
> >> the mailing list before.
> >>
> >> Background
> >>
> >> As defined previously in FLIP-33 (the FLIP page has been changed so please 
> >> refer to the old version [3] ), metric “numRecordsOut” is used for 
> >> reporting the total number of output records since the sink started 
> >> (number of records written to the external system), and similarly for 
> >> “numRecordsOutPerSecond”, “numBytesOut”, “numBytesOutPerSecond” and 
> >> “numRecordsOutError”. Most sinks are following this naming and definition. 
> >> However, these metrics are ambiguous in the new Sink API as “numXXXOut” 
> >> could be used by the output of SinkWriterOperator for reporting number of 
> >> Committables delivered to SinkCommitterOperator. In order to resolve the 
> >> conflict, FLINK-26126 and FLINK-26492 changed names of these metrics with 
> >> “numXXXSend”.
> >>
> >> Necessity of reverting this change
> >>
> >> - Metric names are actually public API, as end users need to configure 
> >> metric collecting and alerting system with metric names. Users have to 
> >> reset all configurations related to affected metrics.
> >> - This could also affect custom and external sinks not maintained by 
> >> Flink, which might have implemented with numXXXOut metrics.
> >> - The number of records sent to external system is way more important than 
> >> the number of Committables sent to SinkCommitterOperator, as the latter 
> >> one is just an internal implementation of sink. We could have a new metric 
> >> name for the latter one instead.
> >> - We could avoid splitting the project by version (like “plz use numXXXOut 
> >> before 1.15 and use numXXXSend after”) if we revert it ASAP, cosidering 
> >> 1.16 is still not released for now.
> >>
> >> As a consequence, I’d like to hear from devs and users about your opinion 
> >> on changing these metrics back to “numXXXOut”.
> >>
> >> Looking forward to your reply!
> >>
> >> [1] https://issues.apache.org/jira/browse/FLINK-26126 
> >> 
> >> [2] https://issues.apache.org/jira/browse/FLINK-26492 
> >> 
> >> [1] FLIP-33, version 18: 
> >> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211883136 
> >> 
> >>
> >> Best,
> >> Qingsheng



Re: [ANNOUNCE] New Apache Flink PMC Member - Danny Cranmer

2022-10-11 Thread Leonard Xu
Congratulations Danny!


Best,
Leonard



Re: [VOTE] Remove HCatalog connector

2022-10-12 Thread Leonard Xu
Thanks martijn for driving this work.

+1

Best,
Leonard


> 2022年10月13日 下午12:29,Gyula Fóra  写道:
> 
> +1
> 
> On Thu, 13 Oct 2022 at 04:53, yuxia  wrote:
> 
>> +1 (non-binding)
>> Thanks for driving.
>> 
>> Best regards,
>> Yuxia
>> 
>> - 原始邮件 -
>> 发件人: "Hang Ruan" 
>> 收件人: "dev" 
>> 发送时间: 星期四, 2022年 10 月 13日 上午 10:16:46
>> 主题: Re: [VOTE] Remove HCatalog connector
>> 
>> +1,
>> 
>> Best,
>> Hang
>> 
>> Jingsong Li  于2022年10月13日周四 10:09写道:
>> 
>>> +1
>>> 
>>> Thanks for driving.
>>> 
>>> Best,
>>> Jingsong
>>> 
>>> On Thu, Oct 13, 2022 at 3:46 AM Martijn Visser >> 
>>> wrote:
 
 Hi everyone,
 
 Since no comments were made, I'm opening a vote to remove the HCatalog
 connector [1]
 
 The voting period will be open at least 72hrs.
 
 Best regards,
 
 Martijn
 
 [1]
 https://lists.apache.org/thread/j8jc5zrhnqlv8y3lkmc3wdo9ysgmsr84
 --
 Martijn
 https://twitter.com/MartijnVisser82
 https://github.com/MartijnVisser
>>> 
>> 



Re: [VOTE] Release 1.16.0, release candidate #2

2022-10-24 Thread Leonard Xu
+1 (non-binding)

- verified signatures and hashsums
- built from source code succeeded
- checked all dependency artifacts are 1.16
- started a cluster, ran a wordcount job, the result is expected, no suspicious 
log output
- started SQL Gateway, tested several rest APIs, the SQL query results are 
expected

Best,
Leonard Xu


> 2022年10月24日 下午8:49,Xingbo Huang  写道:
> 
> +1 (non-binding)
> 
> - verify signatures and checksums
> - no binaries found in source archive
> - build from source code
> - verify python wheel package contents
> - pip install apache-flink-libraries and apache-flink wheel packages
> - thread mode works as expected in Python DataStream API
> - the Python DataStream Window works as expected
> - the Python Sideoutput works as expected
> 
> Best,
> Xingbo
> 
> Lijie Wang  于2022年10月24日周一 16:09写道:
> 
>> +1 (non-binding) for this candidate
>> 
>>  *   Built from the source code.
>>  *   Verified the signature and checksum
>>  *   Ran both streaming/batch jobs on yarn cluster
>>  *   The new speculative execution works as expected
>> 
>> Best,
>> Lijie
>> 
>> Yun Tang  于2022年10月22日周六 15:20写道:
>> 
>>> +1 (non-binding)
>>> 
>>> 
>>>  *   build from the source code.
>>>  *   verified the signature of the release binaries.
>>>  *   launched a standalone cluster with examples for both
>> streaming/batch
>>> execution modes.
>>>  *   checked rocksdb's log would exist under Flink's default log folder.
>>>  *   reviewed the flink-web PR
>>> 
>>> Best
>>> Yun Tang
>>> 
>>> From: Xintong Song 
>>> Sent: Friday, October 21, 2022 18:29
>>> To: dev@flink.apache.org 
>>> Subject: Re: [VOTE] Release 1.16.0, release candidate #2
>>> 
>>> +1 (binding) for this release candidate
>>> 
>>> - verified checksum & signature
>>> - build from source
>>> - tried example jobs with standalone cluster, web ui & logs look good
>>> - the new completed jobs & history server features work as expected
>>> - the new hybrid shuffle mode works as expected
>>> 
>>> Best,
>>> 
>>> Xintong
>>> 
>>> 
>>> 
>>> On Fri, Oct 21, 2022 at 11:09 AM godfrey he  wrote:
>>> 
>>>> +1 to make 1.16.0 released as soon as possible,
>>>> it's been more than two months since feature freeze,
>>>> 1.17 already starts kicking off. We can fix the critical bugs in
>> 1.16.1.
>>>> 
>>>> Best,
>>>> Godfrey
>>>> 
>>>> Xintong Song  于2022年10月21日周五 09:57写道:
>>>>> 
>>>>> BTW, missing 1.16.0 is probably not that bad. From my experience, the
>>>> x.y.0
>>>>> releases are usually considered unstable and are mainly for trying
>> out
>>>>> purposes. Most users do not upgrade to the new version in production
>>>> until
>>>>> the x.y.1/2 releases, which are considered more stable. As this
>> bug-fix
>>>> is
>>>>> making 1.16.1 anyway, it barely misses anything.
>>>>> 
>>>>> Best,
>>>>> 
>>>>> Xintong
>>>>> 
>>>>> 
>>>>> 
>>>>> On Fri, Oct 21, 2022 at 5:10 AM Danny Cranmer <
>> dannycran...@apache.org
>>>> 
>>>>> wrote:
>>>>> 
>>>>>> We had a similar situation for Flink 1.15.1 where a non-regression
>>>>>> "critical" bug was impacting a connector [1]. We decided to not
>> block
>>>> the
>>>>>> release to address this issue. Based on this, I am inclined to
>> agree
>>>> with
>>>>>> Martijn and move forward with the release. This bug is not marked
>> as
>>> a
>>>>>> "blocker" and we should respect that.
>>>>>> 
>>>>>> I am happy to manage a 1.15.3 or 1.16.1 release follow up to
>> address
>>>> these
>>>>>> concerns.
>>>>>> 
>>>>>> [1]
>> https://lists.apache.org/thread/8hxz5n6x2v4c6v8z33hdz51h1bhn768d
>>>>>> 
>>>>>> Thanks,
>>>>>> Danny
>>>>>> 
>>>>>> On Thu, Oct 20, 2022 at 5:01 PM Martijn Visser <
>>>> martijnvis...@apache.org>
>>>>>> wrote:
>>>>>> 
>>>&g

Re: [VOTE] Release 1.16.0, release candidate #2

2022-10-24 Thread Leonard Xu
 
> BTW, the "Add New" button in "Submit New Job" tab can't work in my local
> standalone cluster, is this as expected?

I checked this case it works well in my local env(MacOS + Chrome),it should be 
your env issue.

Best,
Leonard Xu







>> +1 (non-binding) for this candidate
>> 
>>  *   Built from the source code.
>>  *   Ran batch wordcount jobs with slow nodes of different source types on
>> the yarn cluster.
>>  *   The new source speculative execution works as expected, the result is
>> expected, no suspicious log output.
>>  *   Slow nodes are successfully added to the blocklist and subsequently
>> removed as expected.
>>  *   Ran large parallelism batch jobs and performance does not degrade.
>> 
>> Best,
>> JunRui
>> 
>> yuxia  于2022年10月25日周二 09:23写道:
>> 
>>> +1 (non-binding)
>>> * Build from source
>>> * Use Flink Sql client create catalog/tables
>>> * Use Hive dialect to run some queries and insert statements
>>> 
>>> Best regards,
>>> Yuxia
>>> 
>>> - 原始邮件 -
>>> 发件人: "Teoh, Hong" 
>>> 收件人: "dev" 
>>> 发送时间: 星期二, 2022年 10 月 25日 上午 4:35:39
>>> 主题: Re: [VOTE] Release 1.16.0, release candidate #2
>>> 
>>> +1 (non-binding)
>>> 
>>> * Hashes and Signatures look good
>>> * All required files on dist.apache.org
>>> * Tag is present in Github
>>> * Verified source archive does not contain any binary files
>>> * Source archive builds using maven
>>> * Deployed standalone session cluster and ran TopSpeedWindowing example
>> in
>>> streaming with checkpointing enabled. Looks ok
>>> 
>>> Cheers,
>>> Hong
>>> 
>>> On 24/10/2022, 16:06, "Gyula Fóra"  wrote:
>>> 
>>>CAUTION: This email originated from outside of the organization. Do
>>> not click links or open attachments unless you can confirm the sender and
>>> know the content is safe.
>>> 
>>> 
>>> 
>>>+1 (binding)
>>> 
>>>* Verified checksums/GPG signatures
>>>* Built from source
>>>* Tested with Kubernetes operator, including simple jobs,
>>> checkpointing etc.
>>>* Metrics, logs look good.
>>> 
>>>Gyula
>>> 
>>>On Mon, Oct 24, 2022 at 4:54 PM Matthias Pohl
>>> wrote:
>>> 
>>>> +1 (non-binding)
>>>> 
>>>> * Downloaded artifacts
>>>> * Verified checksums/GPG signatures
>>>> * Compared checkout with provided sources
>>>> * Verified pom file versions
>>>> * Went over NOTICE file/pom files changes without finding anything
>>>> suspicious
>>>> * Build Flink from sources
>>>> * Deployed standalone session cluster and ran WordCount example in
>>> batch
>>>> and streaming: Nothing suspicious in log files found
>>>> 
>>>> On Mon, Oct 24, 2022 at 3:51 PM Sergey Nuyanzin <
>> snuyan...@gmail.com
>>>> 
>>>> wrote:
>>>> 
>>>>> +1 (non-binding)
>>>>> 
>>>>> - checked hashes and signatures
>>>>> - built from sources
>>>>> - started cluster, ran different simple jobs
>>>>> - checked sql client
>>>>> 
>>>>> 
>>>>> On Mon, Oct 24, 2022 at 3:14 PM Leonard Xu 
>>> wrote:
>>>>> 
>>>>>> +1 (non-binding)
>>>>>> 
>>>>>> - verified signatures and hashsums
>>>>>> - built from source code succeeded
>>>>>> - checked all dependency artifacts are 1.16
>>>>>> - started a cluster, ran a wordcount job, the result is
>>> expected, no
>>>>>> suspicious log output
>>>>>> - started SQL Gateway, tested several rest APIs, the SQL query
>>> results
>>>>> are
>>>>>> expected
>>>>>> 
>>>>>> Best,
>>>>>> Leonard Xu
>>>>>> 
>>>>>> 
>>>>>>> 2022年10月24日 下午8:49,Xingbo Huang  写道:
>>>>>>> 
>>>>>>> +1 (non-binding)
>>>>>>> 
>>>>>>> - verify signatures and checksums
>>>>>>> - no binaries found in source archive
>>>>>>> - build from source code
>>>>>>> - verify

Re: [DISCUSS] Release Flink 1.15.3

2022-10-25 Thread Leonard Xu
Thanks Fabian for driving this.

+1 to release 1.15.3.

The bug tickets FLINK-26394 and FLINK-27148 should be fixed as well, I’ll help 
to address them soon.

Best,
Leonard Xu



> 2022年10月25日 下午8:28,Jing Ge  写道:
> 
> +1 The timing is good to have 1.15.3 release. Thanks Fabian for bringing
> this to our attention.
> 
> I just checked PRs and didn't find the 1.15 backport of FLINK-29567
> <https://issues.apache.org/jira/browse/FLINK-29567>. Please be aware of it.
> Thanks!
> 
> Best regards,
> Jing
> 
> On Tue, Oct 25, 2022 at 11:44 AM Xintong Song  wrote:
> 
>> Thanks for bringing this up, Fabian.
>> 
>> +1 for creating a 1.15.3 release. I've also seen users requiring this
>> version [1].
>> 
>> I can help with actions that require a PMC role, if needed.
>> 
>> Best,
>> 
>> Xintong
>> 
>> 
>> [1] https://lists.apache.org/thread/501q4l1c6gs8hwh433bw3v1y8fs9cw2n
>> 
>> 
>> 
>> On Tue, Oct 25, 2022 at 5:11 PM Fabian Paul  wrote:
>> 
>>> Hi all,
>>> 
>>> I want to start the discussion of creating a new 1.15 patch release
>>> (1.15.3). The last 1.15 release is almost two months old, and since then,
>>> ~60 tickets have been closed, targeting 1.15.3. It includes critical
>>> changes to the sink architecture, including:
>>> 
>>> - Reverting the sink metric naming [1]
>>> - Recovery problems for sinks using the GlobalCommitter [2][3][4]
>>> 
>>> If the community agrees to create a new patch release, I could volunteer
>> as
>>> the release manager.
>>> 
>>> Best,
>>> Fabian
>>> 
>>> [1] https://issues.apache.org/jira/browse/FLINK-29567
>>> [2] https://issues.apache.org/jira/browse/FLINK-29509
>>> [3] https://issues.apache.org/jira/browse/FLINK-29512
>>> [4] https://issues.apache.org/jira/browse/FLINK-29627
>>> 
>> 



[DISCUSS] Delete useless branches from Flink repository

2022-10-27 Thread Leonard Xu
Hi, all

Recently I checked our repo and founded there are some useless branches[1][2], 
maybe they were pushed accidentally or experimental purpose.

I would like to suggest removing them to keep the code branch clean, how do you 
think? 


The following branches could be safely deleted from my side, please correct me 
if I’m wrong or missing something.
FLINK-29638-1.15
FLINK-29638-1.16
28733
revert-16606-materialization_on_runtime
release0 Updated 2 years ago
benchmark-requestUpdated 16 months ago
exp_github_actions   Updated 7 months
experiment_gha_docs  Updated 8 months
docs_experimental__docs  Updated 2 years ago
docs_experimental__docs_compile Updated 3 years ago


Best,
Leonard

[1]https://github.com/apache/flink/tree/FLINK-29638-1.15
[2]https://github.com/apache/flink/tree/28733










Re: [DISCUSS] Delete useless branches from Flink repository

2022-10-27 Thread Leonard Xu
Thanks Matthias and Chesnay for the quick ACK.

I’ve deleted following branches. 
> FLINK-29638-1.15
> FLINK-29638-1.16
> 28733
> revert-16606-materialization_on_runtime
> release0   Updated 2 years ago
> docs_experimental__docsUpdated 2 years ago
> docs_experimental__docs_compile Updated 3 years ago

BTW, I fork a Flink repo [1] as a backup to avoid we delete required branches.


Best,
Leonard
[1] https://github.com/flink-tpc-ds/flink-221027

Re: Would like to fix "FLINK-27246 Code of method "processElement...grows beyond 64 KB"

2022-10-30 Thread Leonard Xu
Hi, Chielewski

The author of JavaCodeSplitter Caizhi has kindly replied under the jira ticket, 
we can remove the discussion to jira now。


Best,
Leonard

> 2022年10月29日 上午3:55,Krzysztof Chmielewski  写道:
> 
> Hi community,
> I would like to work on fixing FLINK-27246 [1].
> I verified that it still happens on current master branch.
> 
> I also did an initial investigation and I believe I've found what seems to
> be a cause of this problem. I have added comment to the ticket [2] where
> I've asked couple of question.
> 
> I would appreciate for comment if my analysis is correct.
> 
> Thanks,
> Krzysztof Chielewski
> 
> [1] https://issues.apache.org/jira/browse/FLINK-27246
> [2]
> https://issues.apache.org/jira/browse/FLINK-27246?focusedCommentId=17625871&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17625871



Re: [DISCUSS] Delete useless branches from Flink repository

2022-10-31 Thread Leonard Xu
> So the
> benchmark_request could be deleted, but only if someone would also clean
> up/adjust the Jenkins's job default parameters.

Thanks @Piotr for suppling this background. 
As an upstream repository, I tend to keep it as clean as possible.
These users(I think they’re experienced developers)  with benchmark 
requirements can also checkout/adjust branch from their own repository. 
Thus I tend to delete this branch now,HDYT?

Best,
Leonard

> 
> Best,
> Piotrek
> 
> pon., 31 paź 2022 o 03:23 Jark Wu  napisał(a):
> 
>> Thank you for driving this effort, Leonard!
>> 
>> Best,
>> Jark
>> 
>>> 2022年10月28日 11:25,Yuan Mei  写道:
>>> 
>>> Hey Leonard,
>>> 
>>> Thanks for your efforts to clean up our repo!
>>> 
>>> Best
>>> Yuan
>>> 
>>> 
>>> 
>>> On Thu, Oct 27, 2022 at 11:55 PM Leonard Xu  wrote:
>>> 
>>>> Thanks Matthias and Chesnay for the quick ACK.
>>>> 
>>>> I’ve deleted following branches.
>>>>> FLINK-29638-1.15
>>>>> FLINK-29638-1.16
>>>>> 28733
>>>>> revert-16606-materialization_on_runtime
>>>>> release0   Updated 2 years ago
>>>>> docs_experimental__docsUpdated 2 years ago
>>>>> docs_experimental__docs_compile Updated 3 years ago
>>>> 
>>>> BTW, I fork a Flink repo [1] as a backup to avoid we delete required
>>>> branches.
>>>> 
>>>> 
>>>> Best,
>>>> Leonard
>>>> [1] https://github.com/flink-tpc-ds/flink-221027
>> 
>> 



Re: [DISCUSS] Delete useless branches from Flink repository

2022-10-31 Thread Leonard Xu

> Actually I double checked it and the default branch on jenkins is `master`.

Great, I’ve deleted benchmark-request branch. Now, our repo looks better.

Best,
Leonard

Re: [jira] [Created] (FLINK-29807) Drop TypeSerializerConfigSnapshot and savepoint support from Flink versions < 1.8.0

2022-10-31 Thread Leonard Xu
Hi, 15725139602

Please send email to dev-unsubscr...@flink.apache.org if you want to 
unsubscribe the mail from dev ,
and you can refer[1] for more details.

Best,
Leonard
[1]https://flink.apache.org/community.html#mailing-lists



> 2022年10月31日 下午6:02,m15725139602 <15725139...@163.com> 写道:
> 
> unsubscribe
> 
> 
> 
> | |
> 15725139...@163.com
> |
> |
> 邮箱:15725139...@163.com
> |
> 
> 
> 
> 
>  Replied Message 
> | From | Piotr Nowojski (Jira) |
> | Date | 10/31/2022 17:55 |
> | To | dev@flink.apache.org |
> | Cc | |
> | Subject | [jira] [Created] (FLINK-29807) Drop TypeSerializerConfigSnapshot 
> and savepoint support from Flink versions < 1.8.0 |
> Piotr Nowojski created FLINK-29807:
> --
> 
>Summary: Drop TypeSerializerConfigSnapshot and savepoint support 
> from Flink versions < 1.8.0
>Key: FLINK-29807
>URL: https://issues.apache.org/jira/browse/FLINK-29807
>Project: Flink
> Issue Type: Improvement
> Components: Runtime / Checkpointing
>   Affects Versions: 1.17
>   Reporter: Piotr Nowojski
>   Assignee: Piotr Nowojski
>Fix For: 1.17
> 
> 
> The motivation behind this move is two fold. One reason is that it 
> complicates our code base unnecessarily and creates confusion on how to 
> actually implement custom serializers. The immediate reason is that I wanted 
> to clean up Flink's configuration stack a bit and refactor the 
> ExecutionConfig class [2]. This refactor would keep the API compatibility of 
> the ExecutionConfig, but it would break savepoint compatibility with 
> snapshots written with some of the old serializers, which had ExecutionConfig 
> as a field and were serialized in the snapshot. This issue has been resolved 
> by the introduction of TypeSerializerSnapshot in Flink 1.7 [3], where 
> serializers are no longer part of the snapshot.
> 
> TypeSerializerConfigSnapshot has been deprecated and no longer used by 
> built-in serializers since Flink 1.8 [4] and [5]. Users were encouraged to 
> migrate to TypeSerializerSnapshot since then with their own custom 
> serializers. That has been plenty of time for the migration.
> 
> This proposal would have the following impact for the users:
> 1. we would drop support for recovery from savepoints taken with Flink < 
> 1.7.0 for all built in types serializers
> 2. we would drop support for recovery from savepoints taken with Flink < 
> 1.8.0 for built in kryo serializers
> 3. we would drop support for recovery from savepoints taken with Flink < 1.17 
> for custom serializers using deprecated TypeSerializerConfigSnapshot
> 
> 1. and 2. would have a simple migration path. Users migrating from those old 
> savepoints would have to first start his job using a Flink version from the 
> [1.8, 1.16] range, and take a new savepoint that would be compatible with 
> Flink 1.17.
> 3. This is a bit more problematic, because users would have to first migrate 
> their own custom serializers to use TypeSerializerSnapshot (using a Flink 
> version from the [1.8, 1.16]), take a savepoint, and only then migrate to 
> Flink 1.17. However users had already 4 years to migrate, which in my opinion 
> has been plenty of time to do so.
> 
> *As discussed and vote is currently in progress*: 
> https://lists.apache.org/thread/x5d0p08pf2wx47njogsgqct0k5rpfrl4
> 
> 
> 
> --
> This message was sent by Atlassian Jira
> (v8.20.10#820010)



Re: [DISCUSS] Delete useless branches from Flink repository

2022-11-01 Thread Leonard Xu
Thanks Yun Tang for joining the discussion.

I’ve deleted these branches with same name tag except  release-1.14.6-rc2 which 
has no same name tag.

 release-1.12.3-rc1
  release-1.13.2-rc2
  release-1.14.3-rc1
  release-1.15.0-rc1
  release-1.14.6-rc2

Best,
Leonard



> 
> Hi Leonard,
> 
> Thanks for driving this topic, I think the release candidate branch after 
> flink-1.10 could be deleted.
> 
> I believe those branches are created by mistake as the release manager should 
> use tags instead of branch to hold the release candidate.
> Those branches are:
>release-1.12.3-rc1
>release-1.13.2-rc2
>release-1.14.3-rc1
>release-1.14.6-rc2
>release-1.15.0-rc1
> 
> 
> Best
> Yun Tang
> 
> From: Leonard Xu 
> Sent: Monday, October 31, 2022 20:07
> To: dev@flink.apache.org 
> Subject: Re: [DISCUSS] Delete useless branches from Flink repository
> 
> 
>> Actually I double checked it and the default branch on jenkins is `master`.
> 
> Great, I’ve deleted benchmark-request branch. Now, our repo looks better.
> 
> Best,
> Leonard



Re: [flink] branch master updated: [hotfix][docs] Set proper watermark and description for event-time temporal table join example

2022-11-05 Thread Leonard Xu
Hi, Michael

Please send email to commits-unsubscr...@flink.apache.org if you want to 
unsubscribe the mail from comm...@flink.apache.org, you can refer[1] for more 
details.

Best,
Leonard
[1]https://flink.apache.org/community.html#mailing-lists


> 2022年11月5日 下午10:04,Michael Stollery  写道:
> 
> unsubscribe
> 
> Best Regards,
> 
> Michael Stollery
> 
> 
> On Sat, Nov 5, 2022 at 6:17 AM  wrote:
> 
>> This is an automated email from the ASF dual-hosted git repository.
>> 
>> leonard pushed a commit to branch master
>> in repository https://gitbox.apache.org/repos/asf/flink.git
>> 
>> 
>> The following commit(s) were added to refs/heads/master by this push:
>> new 6a76233bef3 [hotfix][docs] Set proper watermark and description
>> for event-time temporal table join example
>> 6a76233bef3 is described below
>> 
>> commit 6a76233bef3ab2b11952a96013604d8562496353
>> Author: Jing Ge 
>> AuthorDate: Sat Nov 5 14:16:55 2022 +0100
>> 
>>[hotfix][docs] Set proper watermark and description for event-time
>> temporal table join example
>> ---
>> docs/content.zh/docs/dev/table/sql/queries/joins.md | 8 +---
>> docs/content/docs/dev/table/sql/queries/joins.md| 8 +---
>> 2 files changed, 10 insertions(+), 6 deletions(-)
>> 
>> diff --git a/docs/content.zh/docs/dev/table/sql/queries/joins.md
>> b/docs/content.zh/docs/dev/table/sql/queries/joins.md
>> index 0a5fd96f71c..2ba849153a4 100644
>> --- a/docs/content.zh/docs/dev/table/sql/queries/joins.md
>> +++ b/docs/content.zh/docs/dev/table/sql/queries/joins.md
>> @@ -143,7 +143,7 @@ CREATE TABLE orders (
>> price   DECIMAL(32,2),
>> currencySTRING,
>> order_time  TIMESTAMP(3),
>> -WATERMARK FOR order_time AS order_time
>> +WATERMARK FOR order_time AS order_time - INTERVAL '15' SECOND
>> ) WITH (/* ... */);
>> 
>> -- Define a versioned table of currency rates.
>> @@ -154,7 +154,7 @@ CREATE TABLE currency_rates (
>> currency STRING,
>> conversion_rate DECIMAL(32, 2),
>> update_time TIMESTAMP(3) METADATA FROM `values.source.timestamp`
>> VIRTUAL,
>> -WATERMARK FOR update_time AS update_time,
>> +WATERMARK FOR update_time AS update_time - INTERVAL '15' SECOND,
>> PRIMARY KEY(currency) NOT ENFORCED
>> ) WITH (
>> 'connector' = 'kafka',
>> @@ -179,7 +179,9 @@ o_002 12.51  EUR   1.10 12:06:00
>> 
>> ```
>> 
>> -**Note:** The event-time temporal join is triggered by a watermark from
>> the left and right sides; please ensure both sides of the join have set
>> watermark correctly.
>> +**Note:** The event-time temporal join is triggered by a watermark from
>> the left and right sides.
>> +The `INTERVAL` time subtraction is used to wait for late events in order
>> to make sure the join will meet the expectation.
>> +Please ensure both sides of the join have set watermark correctly.
>> 
>> **Note:** The event-time temporal join requires the primary key contained
>> in the equivalence condition of the temporal join condition, e.g., The
>> primary key `currency_rates.currency` of table `currency_rates` to be
>> constrained in the condition `orders.currency = currency_rates.currency`.
>> 
>> diff --git a/docs/content/docs/dev/table/sql/queries/joins.md
>> b/docs/content/docs/dev/table/sql/queries/joins.md
>> index 4674ffeeb84..97f672ab8ac 100644
>> --- a/docs/content/docs/dev/table/sql/queries/joins.md
>> +++ b/docs/content/docs/dev/table/sql/queries/joins.md
>> @@ -143,7 +143,7 @@ CREATE TABLE orders (
>> price   DECIMAL(32,2),
>> currencySTRING,
>> order_time  TIMESTAMP(3),
>> -WATERMARK FOR order_time AS order_time
>> +WATERMARK FOR order_time AS order_time - INTERVAL '15' SECOND
>> ) WITH (/* ... */);
>> 
>> -- Define a versioned table of currency rates.
>> @@ -154,7 +154,7 @@ CREATE TABLE currency_rates (
>> currency STRING,
>> conversion_rate DECIMAL(32, 2),
>> update_time TIMESTAMP(3) METADATA FROM `values.source.timestamp`
>> VIRTUAL,
>> -WATERMARK FOR update_time AS update_time,
>> +WATERMARK FOR update_time AS update_time - INTERVAL '15' SECOND,
>> PRIMARY KEY(currency) NOT ENFORCED
>> ) WITH (
>>'connector' = 'kafka',
>> @@ -179,7 +179,9 @@ o_002 12.51  EUR   1.10 12:06:00
>> 
>> ```
>> 
>> -**Note:** The event-time temporal join is triggered by a watermark from
>> the left and right sides; please ensure both sides of the join have set
>> watermark correctly.
>> +**Note:** The event-time temporal join is triggered by a watermark from
>> the left and right sides.
>> +The `INTERVAL` time subtraction is used to wait for late events in order
>> to make sure the join will meet the expectation.
>> +Please ensure both sides of the join have set watermark correctly.
>> 
>> **Note:** The event-time temporal join requires the primary key contained
>> in the equivalence condition of the temporal join condition, e.g., The
>> primary key `currency_rates.currency` of table `currency_rates` to be
>> constrained in the condition

Re: Questions about Flink Table Store

2022-11-08 Thread Leonard Xu
Hi, Alexander

Happy to hear that you’re willing to contribute to Flink, the answer of these 
specific tech design/functionality questions may need to dig the code.
I’m not familiar with  FTS code base, but I’v CC my colleagues who are the core 
maintainers of FTS and maybe they can give your some insights.


Best,
Leonard

> 2022年11月7日 下午10:59,Alexander Sorokoumov  写道:
> 
> I’m Alexander from Confluent. I am new to Flink and its community. I would
> like to contribute to the Flink Table Store, but am missing certain
> details. Can someone please clarify the points mentioned below to me?
> 
>   - Given that there is always a single writer to a stream, in what
>   situations can concurrent writes ever happen to Flink Table Store? FLIP-188
>   mentions reprocessing and snapshot generation, but I do not understand how
>   these cases can lead to more than a single writer.
>   - If there are concurrent INSERTs into a table baked by Flink Table
>   Store, how and by what component are they serialized?
>   - Is Flink Table Store going to support ACID transactions?
>   - Do Flink Table Store snapshots correspond 1:1 to Flink checkpoints?
>   - Does Flink Table Store (plan to) support secondary indexes?
>   - Is there an open roadmap for this Flink Table Store?
> 
> Thank you,
> Alexander



Re: [ACCOUNCE] Apache Flink Elasticsearch Connector 3.0.0 released

2022-11-10 Thread Leonard Xu
Thanks Chesnay and Martijn for the great work!   I believe the 
flink-connector-shared-utils[1] you built will help Flink connector developers 
a lot.


Best,
Leonard
[1] https://github.com/apache/flink-connector-shared-utils

> 2022年11月10日 下午9:53,Martijn Visser  写道:
> 
> Really happy with the first externalized connector for Flink. Thanks a lot to 
> all of you involved!
> 
> On Thu, Nov 10, 2022 at 12:51 PM Chesnay Schepler  > wrote:
> The Apache Flink community is very happy to announce the release of 
> Apache Flink Elasticsearch Connector 3.0.0.
> 
> Apache Flink® is an open-source stream processing framework for 
> distributed, high-performing, always-available, and accurate data 
> streaming applications.
> 
> The release is available for download at:
> https://flink.apache.org/downloads.html 
> 
> 
> This release marks the first time we have released a connector 
> separately from the main Flink release.
> Over time more connectors will be migrated to this release model.
> 
> This release is equivalent to the connector version released alongside 
> Flink 1.16.0 and acts as a drop-in replacement.
> 
> The full release notes are available in Jira:
> https://issues.apache.org/jira/projects/FLINK/versions/12352291 
> 
> 
> We would like to thank all contributors of the Apache Flink community 
> who made this release possible!
> 
> Regards,
> Chesnay



Re: [DISCUSS] Issue tracking workflow

2022-11-13 Thread Leonard Xu


> The mailing list has been created and I've opened a PR  to update the docs
> https://github.com/apache/flink-web/pull/583

Thanks @Martijn for the nice work.
I am willing to review this document PR, because the PR also provides Chinese 
part, which is great, I should be able to offer some tips.

Best,
Leonard



> 
> Op zo 13 nov. 2022 om 09:40 schreef Martijn Visser > 
> 
>> Agreed. I've requested a new private mailing list [1]
>> 
>> [1] https://issues.apache.org/jira/browse/INFRA-23898
>> 
>> On Sat, Nov 12, 2022 at 12:09 PM Márton Balassi 
>> wrote:
>> 
>>> Hi Martjin,
>>> 
>>> Given the situation let us set up the Jira signup mailing list following
>>> the Calcite model. This seems the most sensible to me as of now.
>>> 
>>> On Fri, Nov 11, 2022 at 7:26 PM Martijn Visser 
>>> wrote:
>>> 
 Hi everyone,
 
 Unfortunately ASF Infra has already implemented the change and new Jira
 users can't sign up.
 
 I think there is consensus that we shouldn't move from Jira now. My
 proposal would be to setup a separate mailing list to which users can
>>> send
 their request for an account, which gets sent to the PMC so they can
>>> create
 accounts for them. I don't see any other short term solution.
 
 If agreed, let's open up a vote thread on this.
 
 Thanks, Martijn
 
 
 Op do 3 nov. 2022 om 04:51 schreef Xintong Song 
 
> Thanks all for the valuable feedback, opinions and suggestions.
> 
> # Option 1.
> I know this is the first choice for pretty much everyone. Many people
 from
> the Flink community (including myself) have shared their opinion with
> Infra. However, based on the feedback so far, TBH I don't think things
> would turn out the way we want. I don't see what else we can do. Does
> anyone have more suggestions on this option? Or we probably have to
> scratch it out of the list.
> 
> # Option 4.
> Seems there are also quite some concerns on using solely GH issues:
 limited
> features (thus the significant changes to the current issue/release
> management processes), migration cost, source of truth, etc. I think
>>> I'm
> also convinced that this may not be a good choice.
> 
> # Option 2 & 3.
> Between the two options, I'm leaning towards option 2.
> - IMO, making it as easy as possible for users to report issues should
 be a
> top priority. Having to wait for a human response for creating an
>>> account
> does not meet that requirement. That makes a strong objection to
>>> option 3
> from my side.
> - Using GH issues for consumer-facing issues and reflecting the valid
 ones
> back to Jira (either manually by committers or by bot) sounds good to
>>> me.
> The status (open/closed) and labels should make tracking the issues
 easier
> compared to in mailing lists / slack, in terms of whether an issue has
 been
> taken care of / reflected to Jira / closed as invalid. That does not
>>> mean
> we should not reflect things from mailing lists / slack to Jira.
>>> Ideally,
> we leverage every possible channel for collecting user issues /
>>> feedback,
> while guiding / suggesting users to choose GH issues over the others.
> - For new contributors, they still need to request an account from a
>>> PMC
> member. They can even make that request on GH issues, if they do not
>>> mind
> posting the email address publicly.
> - I would not be worried very much about the privacy issue, if the
>>> Jira
> account creation is restricted to contributors. Contributors are
>>> exposing
> their email addresses publicly anyway, in dev@ mailing list and
>>> commit
> history. I'm also not strongly against creating a dedicated mailing
>>> list
> though.
> 
> Best,
> 
> Xintong
> 
> 
> 
> On Wed, Nov 2, 2022 at 9:16 PM Chesnay Schepler 
> wrote:
> 
>> Calcite just requested a separate mailing list for users to request
>>> a
>> JIRA account.
>> 
>> 
>> I think I'd try going a similar route. While I prefer the openness
>>> of
>> github issues, they are really limited, and while some things can be
>> replicated with labels (like fix versions / components), things like
>> release notes can't.
>> We'd also lose a central place for collecting issues, since we'd
>>> have
 to
>> (?) scope issues per repo.
>> 
>> I wouldn't want to import everything into GH issues (it's just a
>>> flawed
>> approach in the long-term imo), but on the other hand I don't know
>>> if
>> the auto linker even works if it has to link to either jira or a GH
> issue.
>> 
>> Given that we need to change workflows in any case, I think I'd
>>> prefer
>> sticking to JIRA.
>> For reported bugs I'd wager that in most cases we can file the
>>> tickets
>> ourselves and communicate with users on slack/MLs to gat

[SUMMARY] Flink 1.17 Release Sync 11/15/2022

2022-11-15 Thread Leonard Xu
Hi devs and users,

I’d like to share some highlights about the 1.17 release sync on 11/15/2022.

- Release tracking page:
 - The community has collected some great features on the 1.17 page[1]
 - @committers Please continuously update the page in the coming week
 
- JIRA account apply :
  - Martijn updated the issue tracking flow[2][3]
  - Users without JIRA account can follow this doc[2][3] to apply JIRA 
account as well join as Flink contributor

- Blockers:
- Blocker FLINK-29387 has been fixed
- PR for blocker FLINK-29315 is opened and waiting for review.
- Blocker FLINK-29818 is reopened, Yang Wang is looking into this ticket

- Build stability: Number of growing test stability issues with “Exit code 137 
errors”
- Matthias and Qingsheng investigated the memory issue due to multiple 
azure agents on one machine use too much resources
- We’ve reduced the agents number from 7 to 5, let’s keep an eyes on this 
issue.
- Leonard offered a workaround to skip slack clickable issue in slack 
#builds channel

The next release sync will be on November 29th, 2022.

Google Meet: https://meet.google.com/wcx-fjbt-hhz
Dial-in: https://tel.meet/wcx-fjbt-hhz?pin=1940846765126  

Best regards,
Martijn, Qingsheng, Matthias and Leonard 

[1] https://cwiki.apache.org/confluence/display/FLINK/1.17+Release
[2] https://flink.apache.org/community.html
[3] https://flink.apache.org/zh/community.html



Re: [ANNOUNCE] New Apache Flink Committer - Matyas Orhidi

2022-11-21 Thread Leonard Xu
Congratulations Matyas, well deserved!

Best,
Leonard

> On Nov 22, 2022, at 9:38 AM, Dian Fu  wrote:
> 
> Congrats Matyas!
> 
> On Tue, Nov 22, 2022 at 9:00 AM Tony Wei  wrote:
> 
>> Congrats Matyas!
>> 
>> Thomas Weise  於 2022年11月22日 週二 上午8:56寫道:
>> 
>>> Congrats Matyas!
>>> 
>>> 
>>> On Mon, Nov 21, 2022 at 6:28 PM Őrhidi Mátyás 
>>> wrote:
>>> 
 Thanks folks,
 
 So proud and honored to be part of the pack!
 
 Cheers,
 Matyas
 
 On Mon, Nov 21, 2022 at 12:32 PM Danny Cranmer <
>> dannycran...@apache.org>
 wrote:
 
> Congrats Matyas!
> 
> On Mon, 21 Nov 2022, 17:51 ramkrishna vasudevan, <
 ramvasu.fl...@gmail.com>
> wrote:
> 
>> Congrats Matayas
>> 
>> On Mon, Nov 21, 2022 at 10:06 PM Jim Busche 
 wrote:
>> 
>>> Congratulations Matyas!
>>> 
>>> Jim
>>> --
>>> James Busche | Sr. Software Engineer, Watson AI and Data Open
> Technology
>> |
>>> 408-460-0737 | jbus...@us.ibm.com
>>> 
>>> 
>>> 
>>> 
>>> From: Márton Balassi 
>>> Date: Monday, November 21, 2022 at 6:18 AM
>>> To: Flink Dev , morh...@apache.org <
>>> morh...@apache.org>
>>> Subject: [EXTERNAL] [ANNOUNCE] New Apache Flink Committer -
>> Matyas
> Orhidi
>>> Hi everyone,
>>> 
>>> On behalf of the PMC, I'm very happy to announce Matyas Orhidi
>> as a
 new
>>> Flink
>>> committer.
>>> 
>>> Matyas has over a decade of experience of the Big Data ecosystem
>>> and
> has
>>> been working with Flink full time for the past 3 years. In the
>> open
>> source
>>> community he is one of the key driving members of the Kubernetes
> Operator
>>> subproject. He implemented multiple key features in the operator
>> including
>>> the metrics system and the ability to dynamically configure
>> watched
>>> namespaces. He enjoys spreading the word about Flink and
>> regularly
 does
>> so
>>> via authoring blogposts and giving talks or interviews
>> representing
 the
>>> community.
>>> 
>>> Please join me in congratulating Matyas for becoming a Flink
 committer!
>>> 
>>> Best,
>>> Marton
>>> 
>> 
> 
 
>>> 
>> 



Re: [ANNOUNCE] New Apache Flink PMC Members - Godfrey He, Xingbo Huang

2022-11-22 Thread Leonard Xu
Congratulations,Godfrey and Xingbo!

Best,
Leonard

> On Nov 23, 2022, at 12:32 PM, Geng Biao  wrote:
> 
> Congrats,Godfrey and Xingbo!
> Best,



[SUMMARY] Flink 1.17 Release Sync 12/13/2022

2022-12-13 Thread Leonard Xu
Hi devs and users,

I’d like to share the highlights about the 1.17 release sync on 12/13/2022.

- Release tracking page:
 -  1.17 development is moving forward [1], we have 5 weeks remaining
 - @committers Please continuously update the the progress in the 1.17 page

- Externalized Connectors :
  - flink-connector-aws v4.0.0 released
  - flink-connector-pulsar v3.0.0 started the VOTE
  - flink-connector-kafka PR is reviewing

- Blockers:
- Blockers FLINK-28766 and FLINK-29461 have been FIXED
- FLINK-29405 - InputFormatCacheLoaderTest is unstable OPEN 
  Qingsheng will have a look at the PR
- FLINK-26974 - Python EmbeddedThreadDependencyTests.test_add_python_file 
failed on azure OPEN 
  Xingbo is working on this
- FLINK-18356 - flink-table-planner Exit code 137 returned from process 
REOPENED 
  Leonard will ping Godfrey to take a look
- FLINK-27916 - HybridSourceReaderTest.testReader failed with 
AssertionError REOPENED
  Martijn will ping Thomas once more

- How to have monitoring and quality control for the externalized connectors? 
  Martijn will make a proposal and open a dev discussion.

- Will the feature freeze date be affected by COVID and Spring Festival 
holiday?   
  Leonard will discuss with Chinese devs firstly and then make a proposal if 
needed before the next release sync.

The next release sync will be on December 27th, 2022, feel free to join us  if 
you are interested!

Google Meet: https://meet.google.com/wcx-fjbt-hhz
Dial-in: https://tel.meet/wcx-fjbt-hhz?pin=1940846765126  

Best regards,
Martijn, Qingsheng, Matthias and Leonard 

[1] https://cwiki.apache.org/confluence/display/FLINK/1.17+Release

Re: [VOTE] FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2022-12-26 Thread Leonard Xu
+1 (binding)

Best,
Leonard


> On Dec 26, 2022, at 4:22 PM, Qingsheng Ren  wrote:
> 
> +1 (binding)
> 
> Best,
> Qingsheng
> Ververica (Alibaba)
> 
> On Wed, Dec 21, 2022 at 3:13 PM Dong Lin  wrote:
> 
>> Hi all,
>> 
>> We would like to start the vote for FLIP-208: Add RecordEvaluator to
>> dynamically stop source based on de-serialized records [1]. This FLIP was
>> discussed in this thread [2].
>> 
>> This feature is needed by users who currently depend on
>> KafkaDeserializationSchema::isEndOfStream() to migrate their Flink job from
>> FlinkKafkaConsumer to KafkaSource. And we won't be able to
>> remove FlinkKafkaConsumer and FlinkKafkaProducer before adding this
>> feature.
>> 
>> Thanks,
>> Dong
>> 
>> [1]
>> 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-208%3A+Add+RecordEvaluator+to+dynamically+stop+source+based+on+de-serialized+records
>> [2] https://lists.apache.org/thread/z87m68ggzkx0s427tmrllswm4l1g7owc
>> 



Re: [DISCUSS] Extending the feature freezing date of Flink 1.17

2022-12-29 Thread Leonard Xu
Thanks Qingsheng for the proposal, the pandemic has really impacted development 
schedules.

Jan 31st makes sense to me.


Best,
Leonard



Re: [VOTE] FLIP-274: Introduce metric group for OperatorCoordinator

2023-01-05 Thread Leonard Xu
Thanks for driving this FLIP, Hang!

+1 (binding)

Best,
Leonard

> On Jan 5, 2023, at 3:08 AM, Martijn Visser  wrote:
> 
> Hi Hang,
> 
> I haven't had time to read the FLIP yet since this is still a holiday
> period in Europe. I would like to read it in the next few days. Can you
> keep the vote open a little longer?
> 
> Best regards,
> 
> Martijn
> 
> On Wed, Jan 4, 2023 at 2:01 PM Dong Lin  wrote:
> 
>> Thanks for proposing the FLIP!
>> 
>> +1 (binding)
>> 
>> Regards,
>> Dong
>> 
>> On Wed, Jan 4, 2023 at 10:08 AM Hang Ruan  wrote:
>> 
>>> Hi all,
>>> 
>>> Thanks for all the feedback so far.
>>> Based on the discussion[1], we have come to a consensus, so I would like
>> to
>>> start a vote on FLIP-274: Introduce metric group for
>>> OperatorCoordinator[2].
>>> 
>>> The vote will last for at least 72 hours (Jan 7th at 11:00 GMT) unless
>>> there is an objection or insufficient votes.
>>> 
>>> [1] https://lists.apache.org/thread/63m9w60rndqnrqvgb6qosvt2bcbww53k
>>> [2]
>>> 
>>> 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-274%3A+Introduce+metric+group+for+OperatorCoordinator
>>> 
>>> Best,
>>> Hang
>>> 
>> 



Re: [ANNOUNCE] New Apache Flink Committer - Lincoln Lee

2023-01-09 Thread Leonard Xu
Congratulations, Lincoln!

Impressive work in streaming semantics, well deserved!


Best,
Leonard


> On Jan 10, 2023, at 11:52 AM, Jark Wu  wrote:
> 
> Hi everyone,
> 
> On behalf of the PMC, I'm very happy to announce Lincoln Lee as a new Flink
> committer.
> 
> Lincoln Lee has been a long-term Flink contributor since 2017. He mainly
> works on Flink
> SQL parts and drives several important FLIPs, e.g., FLIP-232 (Retry Async
> I/O), FLIP-234 (
> Retryable Lookup Join), FLIP-260 (TableFunction Finish). Besides, He also
> contributed
> much to Streaming Semantics, including the non-determinism problem and the
> message
> ordering problem.
> 
> Please join me in congratulating Lincoln for becoming a Flink committer!
> 
> Cheers,
> Jark Wu



Re: [DISCUSS] Enabling dynamic partition discovery by default in Kafka source

2023-01-12 Thread Leonard Xu
Thanks Qingsheng for driving this, enable the dynamic partition discovery would 
be very useful for kafka topic scale partitions scenarios.

+1 for the change.

CC: Becket 


Best,
Leonard 



> On Jan 13, 2023, at 3:15 PM, Jark Wu  wrote:
> 
> +1 for the change. I think this is beneficial for users and is compatible.
> 
> Best,
> Jark
> 
> On Fri, 13 Jan 2023 at 14:22, 何军  wrote:
> 
>>> 
>>> +1 for this idea, we have enabled kafka dynamic partition discovery in
>> all
>>> jobs.
>>> 
>>> 
>> 



Re: [ANNOUNCE] FRocksDB 6.20.3-ververica-2.0 released

2023-01-31 Thread Leonard Xu
Thanks Yanfei for driving the release ! !


Best,
Leonard

> On Jan 31, 2023, at 3:43 PM, Yun Tang  wrote:
> 
> Thanks Yuanfei for driving the frocksdb release!
> 
> Best
> Yun Tang
> From: Yuan Mei 
> Sent: Tuesday, January 31, 2023 15:09
> To: Jing Ge 
> Cc: Yanfei Lei ; dev@flink.apache.org 
> ; user ; 
> user...@flink.apache.org 
> Subject: Re: [ANNOUNCE] FRocksDB 6.20.3-ververica-2.0 released
>  
> Thanks Yanfei for driving the release!
> 
> Best
> Yuan
> 
> On Mon, Jan 30, 2023 at 8:46 PM Jing Ge via user  > wrote:
> Hi Yanfei,
> 
> Thanks for your effort. Looking forward to checking it.
> 
> Best regards,
> Jing
> 
> On Mon, Jan 30, 2023 at 1:42 PM Yanfei Lei  > wrote:
> It is very happy to announce the release of FRocksDB 6.20.3-ververica-2.0.
> 
> Compiled files for Linux x86, Linux arm, Linux ppc64le, MacOS x86,
> MacOS arm, and Windows are included in FRocksDB 6.20.3-ververica-2.0
> jar, and the FRocksDB in Flink 1.17 would be updated to
> 6.20.3-ververica-2.0.
> 
> Release highlights:
> - [FLINK-30457] Add periodic_compaction_seconds option to RocksJava[1].
> - [FLINK-30321] Upgrade ZLIB of FRocksDB to 1.2.13[2].
> - Avoid expensive ToString() call when not in debug[3].
> - [FLINK-24932] Support build FRocksDB Java on Apple silicon[4].
> 
> Maven artifacts for FRocksDB can be found at:
> https://mvnrepository.com/artifact/com.ververica/frocksdbjni 
> 
> 
> We would like to thank all efforts from the Apache Flink community
> that made this release possible!
> 
> [1] https://issues.apache.org/jira/browse/FLINK-30457 
> 
> [2] https://issues.apache.org/jira/browse/FLINK-30321 
> 
> [3] https://github.com/ververica/frocksdb/pull/55 
> 
> [4] https://issues.apache.org/jira/browse/FLINK-24932 
> 
> 
> Best regards,
> Yanfei
> Ververica(Alibaba)



Re: [DISCUSS] Delete useless branches from Flink repository

2023-02-01 Thread Leonard Xu
The blink branch was created when Alibaba contributes its internal Flink 
version to Flink Community, blink related code(e.g. flink-table-planner-blink, 
flink-table-runtime-blink) have been adopted as the default code 
(flink-table-planner, flink-table-runtime)[1],  I think we can remove it now 
safely.

Best,
Leonard

[1] https://issues.apache.org/jira/browse/FLINK-14437


> On Feb 1, 2023, at 7:10 PM, Matthias Pohl  wrote:
> 
> I'm documenting the branches that shouldn't be deleted in the release 
> management docs [1]. While going through the remote branches I noticed the 
> remote branch blink [2] which was created by Kurt in 2019. It feels like that 
> one could be deleted as well.
> 
> Are there any objections in deleting the blink remote branch? @Leonard was 
> there any reason you skipped that one?
> 
> [1] 
> https://cwiki.apache.org/confluence/display/FLINK/Flink+Release+Management 
> <https://cwiki.apache.org/confluence/display/FLINK/Flink+Release+Management>
> [2] https://github.com/apache/flink/tree/blink 
> <https://github.com/apache/flink/tree/blink>
> 
> On Tue, Nov 1, 2022 at 11:26 AM Leonard Xu  <mailto:xbjt...@gmail.com>> wrote:
> Thanks Yun Tang for joining the discussion.
> 
> I’ve deleted these branches with same name tag except  release-1.14.6-rc2 
> which has no same name tag.
> 
>  release-1.12.3-rc1
>   release-1.13.2-rc2
>   release-1.14.3-rc1
>   release-1.15.0-rc1
>   release-1.14.6-rc2
> 
> Best,
> Leonard
> 
> 
> 
> > 
> > Hi Leonard,
> > 
> > Thanks for driving this topic, I think the release candidate branch after 
> > flink-1.10 could be deleted.
> > 
> > I believe those branches are created by mistake as the release manager 
> > should use tags instead of branch to hold the release candidate.
> > Those branches are:
> >release-1.12.3-rc1
> >release-1.13.2-rc2
> >release-1.14.3-rc1
> >release-1.14.6-rc2
> >release-1.15.0-rc1
> > 
> > 
> > Best
> > Yun Tang
> > 
> > From: Leonard Xu mailto:xbjt...@gmail.com>>
> > Sent: Monday, October 31, 2022 20:07
> > To: dev@flink.apache.org <mailto:dev@flink.apache.org> 
> > mailto:dev@flink.apache.org>>
> > Subject: Re: [DISCUSS] Delete useless branches from Flink repository
> > 
> > 
> >> Actually I double checked it and the default branch on jenkins is `master`.
> > 
> > Great, I’ve deleted benchmark-request branch. Now, our repo looks better.
> > 
> > Best,
> > Leonard
> 



Re: [VOTE] FLIP-274: Introduce metric group for OperatorCoordinator

2023-02-02 Thread Leonard Xu
+1

Best,
Leonard

> On Feb 3, 2023, at 9:49 AM, Dong Lin  wrote:
> 
> +1
> 
> On Thu, Feb 2, 2023 at 9:31 PM Hang Ruan  wrote:
> 
>> Hi all,
>> 
>> Thanks for all the help about this FLIP. Now let's start the vote again.
>> Based on the discussion[1], we have come to a consensus, so I would like to
>> start a vote on FLIP-274: Introduce metric group for
>> OperatorCoordinator[2].
>> 
>> The vote will last for at least 72 hours (Feb 8th at 11:00 GMT) unless
>> there is an objection or insufficient votes.
>> 
>> [1] https://lists.apache.org/thread/63m9w60rndqnrqvgb6qosvt2bcbww53k
>> [2]
>> 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-274%3A+Introduce+metric+group+for+OperatorCoordinator
>> 
>> Best,
>> Hang
>> 



Re: [Vote] FLIP-438: Amazon SQS Sink Connector

2024-04-16 Thread Leonard Xu
+1 (binding)

Best,
Leonard

> 2024年4月17日 上午2:25,Robert Metzger  写道:
> 
> +1 binding
> 
> On Tue, Apr 16, 2024 at 2:05 PM Jeyhun Karimov  wrote:
> 
>> Thanks Priya for driving the FLIP.
>> 
>> +1 (non-binding)
>> 
>> Regards,
>> Jeyhun
>> 
>> On Tue, Apr 16, 2024 at 12:37 PM Hong Liang  wrote:
>> 
>>> +1 (binding)
>>> 
>>> Thanks Priya for driving this! This has been a requested feature for a
>>> while now, and will benefit the community :)
>>> 
>>> Hong
>>> 
>>> On Tue, Apr 16, 2024 at 3:23 AM Muhammet Orazov
>>>  wrote:
>>> 
 +1 (non-binding)
 
 Thanks Priya for the FLIP and driving it!
 
 Best,
 Muhammet
 
 On 2024-04-12 21:56, Dhingra, Priya wrote:
> Hi devs,
> 
> 
> 
> Thank you to everyone for the feedback on FLIP-438: Amazon SQS Sink
> Connector<
 
>>> 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-438%3A+Amazon+SQS+Sink+Connector
> 
> 
> 
> 
> I would like to start a vote for it. The vote will be open for at
>> least
> 72
> 
> hours unless there is an objection or not enough votes.
> 
> 
> 
> 
 
>>> 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-438%3A+Amazon+SQS+Sink+Connector
> 
> Regards
> Priya
 
>>> 
>> 



Re: [VOTE] FLIP-435: Introduce a New Materialized Table for Simplifying Data Pipelines

2024-04-17 Thread Leonard Xu
+1(binding)

Best,
Leonard

> 2024年4月17日 下午8:31,Lincoln Lee  写道:
> 
> +1(binding)
> 
> Best,
> Lincoln Lee
> 
> 
> Ferenc Csaky  于2024年4月17日周三 19:58写道:
> 
>> +1 (non-binding)
>> 
>> Best,
>> Ferenc
>> 
>> 
>> 
>> 
>> On Wednesday, April 17th, 2024 at 10:26, Ahmed Hamdy 
>> wrote:
>> 
>>> 
>>> 
>>> + 1 (non-binding)
>>> 
>>> Best Regards
>>> Ahmed Hamdy
>>> 
>>> 
>>> On Wed, 17 Apr 2024 at 08:28, Yuepeng Pan panyuep...@apache.org wrote:
>>> 
 +1(non-binding).
 
 Best,
 Yuepeng Pan
 
 At 2024-04-17 14:27:27, "Ron liu" ron9@gmail.com wrote:
 
> Hi Dev,
> 
> Thank you to everyone for the feedback on FLIP-435: Introduce a New
> Materialized Table for Simplifying Data Pipelines[1][2].
> 
> I'd like to start a vote for it. The vote will be open for at least
>> 72
> hours unless there is an objection or not enough votes.
> 
> [1]
 
 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-435%3A+Introduce+a+New+Materialized+Table+for+Simplifying+Data+Pipelines
 
> [2] https://lists.apache.org/thread/c1gnn3bvbfs8v1trlf975t327s4rsffs
> 
> Best,
> Ron
>> 



Re: [VOTE] FLIP-436: Introduce Catalog-related Syntax

2024-04-26 Thread Leonard Xu
+1 for the new layout, it’s a minor but good improvement.

Best,
Leonard
 

> 2024年4月26日 下午2:03,Jark Wu  写道:
> 
> Thanks for driving this, Jane and Yubin.
> 
> +1. The new layout looks good to me.
> 
> Best,
> Jark
> 
> On Fri, 26 Apr 2024 at 13:57, Jane Chan  wrote:
> 
>> Hi Yubin,
>> 
>> Thanks for your effort. +1 with the display layout change (binding).
>> 
>> Best,
>> Jane
>> 
>> On Wed, Apr 24, 2024 at 5:28 PM Ahmed Hamdy  wrote:
>> 
>>> Hi, +1 (non-binding)
>>> Best Regards
>>> Ahmed Hamdy
>>> 
>>> 
>>> On Wed, 24 Apr 2024 at 09:58, Yubin Li  wrote:
>>> 
 Hi everyone,
 
 During the implementation of the "describe catalog" syntax, it was
 found that the original output style needed to be improved.
 ```
 desc catalog extended cat2;
 
 
>>> 
>> +--+-+
 | catalog_description_item |
 catalog_description_value |
 
 
>>> 
>> +--+-+
 | Name |
 cat2 |
 | Type |
 generic_in_memory |
 |  Comment |
  |
 |   Properties | ('default-database','db'),
 ('type','generic_in_memory') |
 
 
>>> 
>> +--+-+
 4 rows in set
 ```
 After offline discussions with Jane Chan and Jark Wu, we suggest
 improving it to the following form:
 ```
 desc catalog extended cat2;
 +-+---+
 |   info name |info value |
 +-+---+
 |name |  cat2 |
 |type | generic_in_memory |
 | comment |   |
 | option:default-database |db |
 +-+---+
 4 rows in set
 ```
 
 For the following reasons:
 1. The title should be consistent with engines such as Databricks for
 easy understanding, and it should also be consistent with Flink's own
 naming style. Therefore, the title adopts "info name", "info value",
 and the key name should be unified in lowercase, so "Name" is replaced
 by "name".
 Note: Databricks output style [1] as follows:
 ```
> DESCRIBE CATALOG main;
 info_name info_value
   
 Catalog Name  main
  Comment   Main catalog (auto-created)
Owner metastore-admin-users
 Catalog Type   Regular
 ```
 2. There may be many attributes of the catalog, and it is very poor in
 readability when displayed in one line. It should be expanded into
 multiple lines, and the key name is prefixed with "option:" to
 identify that this is an attribute row. And since `type` is an
 important information of the catalog, even if `extended` is not
 specified, it should also be displayed, and correspondingly,
 "option:type" should be removed to avoid redundancy.
 
 WDYT? Looking forward to your reply!
 
 [1]
 
>>> 
>> https://learn.microsoft.com/zh-tw/azure/databricks/sql/language-manual/sql-ref-syntax-aux-describe-catalog
 
 Best,
 Yubin
 
 On Wed, Mar 20, 2024 at 2:15 PM Benchao Li 
>> wrote:
> 
> +1 (binding)
> 
> gongzhongqiang  于2024年3月20日周三 11:40写道:
>> 
>> +1 (non-binding)
>> 
>> Best,
>> Zhongqiang Gong
>> 
>> Yubin Li  于2024年3月19日周二 18:03写道:
>> 
>>> Hi everyone,
>>> 
>>> Thanks for all the feedback, I'd like to start a vote on the
 FLIP-436:
>>> Introduce Catalog-related Syntax [1]. The discussion thread is
>> here
>>> [2].
>>> 
>>> The vote will be open for at least 72 hours unless there is an
>>> objection or insufficient votes.
>>> 
>>> [1]
>>> 
 
>>> 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-436%3A+Introduce+Catalog-related+Syntax
>>> [2]
>>> https://lists.apache.org/thread/10k1bjb4sngyjwhmfqfky28lyoo7sv0z
>>> 
>>> Best regards,
>>> Yubin
>>> 
> 
> 
> 
> --
> 
> Best,
> Benchao Li
 
>>> 
>> 



Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-06 Thread Leonard Xu
+1 from my side, thanks Martijn for the effort.

Best,
Leonard

> 2024年5月4日 下午7:41,Ahmed Hamdy  写道:
> 
> Hi Martijn
> Thanks for the proposal +1 from me.
> Should this change take place in 1.20, what are the planned release steps
> for connectors that only offer a deprecated interface in this case (i.e.
> RabbitMQ, Cassandra, pusbub, Hbase)? Are we going to refrain from releases
> that support 1.20+ till the blockers are implemented?
> Best Regards
> Ahmed Hamdy
> 
> 
> On Fri, 3 May 2024 at 14:32, Péter Váry  wrote:
> 
>>> With regards to FLINK-35149, the fix version indicates a change at Flink
>> CDC; is that indeed correct, or does it require a change in the SinkV2
>> interface?
>> 
>> The fix doesn't need change in SinkV2, so we are good there.
>> The issue is that the new SinkV2 SupportsCommitter/SupportsPreWriteTopology
>> doesn't work with the CDC yet.
>> 
>> Martijn Visser  ezt írta (időpont: 2024. máj.
>> 3.,
>> P, 14:06):
>> 
>>> Hi Ferenc,
>>> 
>>> You're right, 1.20 it is :)
>>> 
>>> I've assigned the HBase one to you!
>>> 
>>> Thanks,
>>> 
>>> Martijn
>>> 
>>> On Fri, May 3, 2024 at 1:55 PM Ferenc Csaky 
>>> wrote:
>>> 
 Hi Martijn,
 
 +1 for the proposal.
 
> targeted for Flink 1.19
 
 I guess you meant Flink 1.20 here.
 
 Also, I volunteer to take updating the HBase sink, feel free to assign
 that task to me.
 
 Best,
 Ferenc
 
 
 
 
 On Friday, May 3rd, 2024 at 10:20, Martijn Visser <
 martijnvis...@apache.org> wrote:
 
> 
> 
> Hi Peter,
> 
> I'll add it for completeness, thanks!
> With regards to FLINK-35149, the fix version indicates a change at
>>> Flink
> CDC; is that indeed correct, or does it require a change in the
>> SinkV2
> interface?
> 
> Best regards,
> 
> Martijn
> 
> 
> On Fri, May 3, 2024 at 7:47 AM Péter Váry
>> peter.vary.apa...@gmail.com
> 
> wrote:
> 
>> Hi Martijn,
>> 
>> We might want to add FLIP-371 [1] to the list. (Or we aim only for
 higher
>> level FLIPs?)
>> 
>> We are in the process of using the new API in Iceberg connector
>> [2] -
 so
>> far, so good.
>> 
>> I know of one minor known issue about the sink [3], which should be
 ready
>> for the release.
>> 
>> All-in-all, I think we are in good shape, and we could move forward
 with
>> the promotion.
>> 
>> Thanks,
>> Peter
>> 
>> [1] -
>> 
>> 
 
>>> 
>> https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=263430387
>> [2] - https://github.com/apache/iceberg/pull/10179
>> [3] - https://issues.apache.org/jira/browse/FLINK-35149
>> 
>> On Thu, May 2, 2024, 09:47 Muhammet Orazov
 mor+fl...@morazow.com.invalid
>> wrote:
>> 
>>> Got it, thanks!
>>> 
>>> On 2024-05-02 06:53, Martijn Visser wrote:
>>> 
 Hi Muhammet,
 
 Thanks for joining the discussion! The changes in this FLIP
>> would
 be
 targeted for Flink 1.19, since it's only a matter of changing
>> the
 annotation.
 
 Best regards,
 
 Martijn
 
 On Thu, May 2, 2024 at 7:26 AM Muhammet Orazov
 mor+fl...@morazow.com
 wrote:
 
> Hello Martijn,
> 
> Thanks for the FLIP and detailed history of changes, +1.
> 
> Would FLIP changes target for 2.0? I think it would be good
> to have clear APIs on 2.0 release.
> 
> Best,
> Muhammet
> 
> On 2024-05-01 15:30, Martijn Visser wrote:
> 
>> Hi everyone,
>> 
>> I would like to start a discussion on FLIP-453: Promote
 Unified Sink
>> API V2
>> to Public and Deprecate SinkFunction
>> https://cwiki.apache.org/confluence/x/rIobEg
>> 
>> This FLIP proposes to promote the Unified Sink API V2 from
>> PublicEvolving
>> to Public and to mark the SinkFunction as Deprecated.
>> 
>> I'm looking forward to your thoughts.
>> 
>> Best regards,
>> 
>> Martijn
 
>>> 
>> 



Re: [DISCUSS] Flink CDC 3.2 Release Planning

2024-05-08 Thread Leonard Xu
+1 for the proposal code freeze date and RM candidate.

Best,
Leonard

> 2024年5月8日 下午10:27,gongzhongqiang  写道:
> 
> Hi Qingsheng
> 
> Thank you for driving the release.
> Agree with the goal and I'm willing to help.
> 
> Best,
> Zhongqiang Gong
> 
> Qingsheng Ren  于2024年5月8日周三 14:22写道:
> 
>> Hi devs,
>> 
>> As we are in the midst of the release voting process for Flink CDC 3.1.0, I
>> think it's a good time to kick off the upcoming Flink CDC 3.2 release
>> cycle.
>> 
>> In this release cycle I would like to focus on the stability of Flink CDC,
>> especially for the newly introduced YAML-based data integration
>> framework. To ensure we can iterate and improve swiftly, I propose to make
>> 3.2 a relatively short release cycle, targeting a feature freeze by May 24,
>> 2024.
>> 
>> For developers that are interested in participating and contributing new
>> features in this release cycle, please feel free to list your planning
>> features in the wiki page [1].
>> 
>> I'm happy to volunteer as a release manager and of course open to work
>> together with someone on this.
>> 
>> What do you think?
>> 
>> Best,
>> Qingsheng
>> 
>> [1]
>> https://cwiki.apache.org/confluence/display/FLINK/Flink+CDC+3.2+Release
>> 



Re: [RESULT][VOTE] FLIP-454: New Apicurio Avro format

2024-05-08 Thread Leonard Xu
Thanks David for driving the FLIP forward,  but we need 3 +1(binding)  votes 
according Flink Bylaws[1] before community accepted it.


Best,
Leonard
[1] https://cwiki.apache.org/confluence/display/FLINK/Flink+Bylaws

> 2024年5月8日 下午11:05,David Radley  写道:
> 
> Hi everyone,
> I am happy to say that FLIP-454: New Apicurio Avro format [1] has been 
> accepted and voted through this thread [2].
> 
> The proposal has been accepted with 4 approving votes and there
> are no vetos:
> 
> - Ahmed Hamdy (non-binding)
> - Jeyhun Karimov (non-binding)
> - Mark Nuttall (non-binding)
> - Nic Townsend (non-binding)
> 
> Martijn:
> Please could you update the Flip with:
> - the voting thread link
> - the accepted status
> - the Jira number (https://issues.apache.org/jira/browse/FLINK-35311).
> As the involved committer, are you willing to assign me the Jira to work on 
> and merge once you approve the changes?
> 
> [1] 
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-454%3A+New+Apicurio+Avro+format
> [2] https://lists.apache.org/list?dev@flink.apache.org:lte=1M:apicurio
> 
> Thanks to all involved.
> 
> Kind regards,
> David
> 
> Unless otherwise stated above:
> 
> IBM United Kingdom Limited
> Registered in England and Wales with number 741598
> Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU



Re: [VOTE] Apache Flink CDC Release 3.1.0, release candidate #3

2024-05-14 Thread Leonard Xu
+1 (binding)

- verified signatures
- verified hashsums
- checked Github release tag 
- checked release notes
- Run pipeline from MySQL to StarRocks with fields projection, the result is 
expected
- Run pipeline from MySQL to StarRocks with filter, the result is expected
- reviewed Jira issues for cdc-3.1.0,and closed invalid issue for incorrect 
version 3.1.0
- reviewed the web PR and left two minor comments 

Best,
Leonard

> 2024年5月14日 下午6:07,Yanquan Lv  写道:
> 
> +1 (non-binding)
> - Validated checksum hash
> - Build the source with Maven and jdk8
> - Verified web PR
> - Check that the jar is built by jdk8
> - Check synchronizing from mysql to paimon
> - Check synchronizing from mysql to kafka
> 
> Hang Ruan  于2024年5月13日周一 13:55写道:
> 
>> +1 (non-binding)
>> 
>> - Validated checksum hash
>> - Verified signature
>> - Verified that no binaries exist in the source archive
>> - Build the source with Maven and jdk8
>> - Verified web PR
>> - Check that the jar is built by jdk8
>> - Check synchronizing schemas and data from mysql to starrocks following
>> the quickstart
>> 
>> Best,
>> Hang
>> 
>> Qingsheng Ren  于2024年5月11日周六 10:10写道:
>> 
>>> Hi everyone,
>>> 
>>> Please review and vote on the release candidate #3 for the version 3.1.0
>> of
>>> Apache Flink CDC, as follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>> 
>>> **Release Overview**
>>> 
>>> As an overview, the release consists of the following:
>>> a) Flink CDC source release to be deployed to dist.apache.org
>>> b) Maven artifacts to be deployed to the Maven Central Repository
>>> 
>>> **Staging Areas to Review**
>>> 
>>> The staging areas containing the above mentioned artifacts are as
>> follows,
>>> for your review:
>>> * All artifacts for a) can be found in the corresponding dev repository
>> at
>>> dist.apache.org [1], which are signed with the key with fingerprint
>>> A1BD477F79D036D2C30CA7DBCA8AEEC2F6EB040B [2]
>>> * All artifacts for b) can be found at the Apache Nexus Repository [3]
>>> 
>>> Other links for your review:
>>> * JIRA release notes [4]
>>> * Source code tag "release-3.1.0-rc3" with commit hash
>>> 5452f30b704942d0ede64ff3d4c8699d39c63863 [5]
>>> * PR for release announcement blog post of Flink CDC 3.1.0 in flink-web
>> [6]
>>> 
>>> **Vote Duration**
>>> 
>>> The voting time will run for at least 72 hours, adopted by majority
>>> approval with at least 3 PMC affirmative votes.
>>> 
>>> Thanks,
>>> Qingsheng Ren
>>> 
>>> [1] https://dist.apache.org/repos/dist/dev/flink/flink-cdc-3.1.0-rc3/
>>> [2] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> [3]
>> https://repository.apache.org/content/repositories/orgapacheflink-1733
>>> [4]
>>> 
>>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354387
>>> [5] https://github.com/apache/flink-cdc/releases/tag/release-3.1.0-rc3
>>> [6] https://github.com/apache/flink-web/pull/739
>>> 
>> 



Re: [ANNOUNCE] Apache Flink CDC 3.1.0 released

2024-05-17 Thread Leonard Xu
Congratulations !

Thanks Qingsheng for the great work and all contributors involved !!

Best,
Leonard


> 2024年5月17日 下午5:32,Qingsheng Ren  写道:
> 
> The Apache Flink community is very happy to announce the release of
> Apache Flink CDC 3.1.0.
> 
> Apache Flink CDC is a distributed data integration tool for real time
> data and batch data, bringing the simplicity and elegance of data
> integration via YAML to describe the data movement and transformation
> in a data pipeline.
> 
> Please check out the release blog post for an overview of the release:
> https://flink.apache.org/2024/05/17/apache-flink-cdc-3.1.0-release-announcement/
> 
> The release is available for download at:
> https://flink.apache.org/downloads.html
> 
> Maven artifacts for Flink CDC can be found at:
> https://search.maven.org/search?q=g:org.apache.flink%20cdc
> 
> The full release notes are available in Jira:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354387
> 
> We would like to thank all contributors of the Apache Flink community
> who made this release possible!
> 
> Regards,
> Qingsheng Ren



Re: [VOTE] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-17 Thread Leonard Xu
+1(binding)

Best,
Leonard

> 2024年5月17日 下午5:40,Hang Ruan  写道:
> 
> +1(non-binding)
> 
> Best,
> Hang
> 
> Yuepeng Pan  于2024年5月17日周五 16:15写道:
> 
>> +1(non-binding)
>> 
>> 
>> Best,
>> Yuepeng Pan
>> 
>> 
>> At 2024-05-15 21:09:04, "Jing Ge"  wrote:
>>> +1(binding) Thanks Martijn!
>>> 
>>> Best regards,
>>> Jing
>>> 
>>> On Wed, May 15, 2024 at 7:00 PM Muhammet Orazov
>>>  wrote:
>>> 
 Thanks Martijn driving this! +1 (non-binding)
 
 Best,
 Muhammet
 
 On 2024-05-14 06:43, Martijn Visser wrote:
> Hi everyone,
> 
> With no more discussions being open in the thread [1] I would like to
> start
> a vote on FLIP-453: Promote Unified Sink API V2 to Public and
>> Deprecate
> SinkFunction [2]
> 
> The vote will be open for at least 72 hours unless there is an
> objection or
> insufficient votes.
> 
> Best regards,
> 
> Martijn
> 
> [1] https://lists.apache.org/thread/hod6bg421bzwhbfv60lwsck7r81dvo59
> [2]
> 
 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-453%3A+Promote+Unified+Sink+API+V2+to+Public+and+Deprecate+SinkFunction
 
>> 



Re: [VOTE] FLIP-449: Reorganization of flink-connector-jdbc

2024-05-21 Thread Leonard Xu
+1(binding),  thanks Joao Boto for driving this FLIP.

Best,
Leonard

> 2024年5月17日 下午4:34,Ahmed Hamdy  写道:
> 
> Hi all,
> +1 (non-binding)
> Best Regards
> Ahmed Hamdy
> 
> 
> On Fri, 17 May 2024 at 02:13, Jiabao Sun  wrote:
> 
>> Thanks for driving this proposal!
>> 
>> +1 (binding)
>> 
>> Best,
>> Jiabao
>> 
>> 
>> On 2024/05/10 22:18:04 Jeyhun Karimov wrote:
>>> Thanks for driving this!
>>> 
>>> +1 (non-binding)
>>> 
>>> Regards,
>>> Jeyhun
>>> 
>>> On Fri, May 10, 2024 at 12:50 PM Muhammet Orazov
>>>  wrote:
>>> 
 Thanks João for your efforts and driving this!
 
 +1 (non-binding)
 
 Best,
 Muhammet
 
 On 2024-05-09 12:01, Joao Boto wrote:
> Hi everyone,
> 
> Thanks for all the feedback, I'd like to start a vote on the
>> FLIP-449:
> Reorganization of flink-connector-jdbc [1].
> The discussion thread is here [2].
> 
> The vote will be open for at least 72 hours unless there is an
> objection or
> insufficient votes.
> 
> [1]
> 
 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-449%3A+Reorganization+of+flink-connector-jdbc
> [2] https://lists.apache.org/thread/jc1yvvo35xwqzlxl5mj77qw3hq6f5sgr
> 
> Best
> Joao Boto
 
>>> 
>> 



Re: [DISCUSS] FLIP-XXX: Improve JDBC connector extensibility for Table API

2024-05-21 Thread Leonard Xu
Thanks Lorenzo for kicking off this discussion.

+1 for the motivation, and I left some comments as following:

(1) Please add API annotation for all Proposed public interfaces

(2) 
JdbcConnectionOptionsParser/JdbcReadOptionsParser/JdbcExecutionOptionsParser  
offer two methods validate and parse, it’s a little stranger to me as your POC 
code call them at the same time, could we finish validate action in parse 
method internal? And thus a Parser interface offers a parse method makes sense 
to me. It’s better introduce a Validator to support validation If you want to 
do some connection validations during job compile phase.

(3) Above methods return InternalJdbcConnectionOptions with fixed members, if 
the example db requires extra connection options like acessKey, acessId and 
etc, we need to change InternalJdbcConnectionOptions as well, how we show our 
extensibility?

Best,
Leonard


> 2024年5月15日 下午10:17,Ahmed Hamdy  写道:
> 
> Hi Lorenzo,
> This seems like a very useful addition.
> +1 (non-binding) from my side. I echo Jeyhun's question about backward
> compatibility as it is not mentioned in the FLIP.
> Best Regards
> Ahmed Hamdy
> 
> 
> On Wed, 15 May 2024 at 08:12,  wrote:
> 
>> Hello Muhammet and Jeyhun!
>> Thanks for your comments!
>> 
>> @Jeyhun:
>> 
>>> Could you please elaborate more on how the new approach will be backwards
>> compatible?
>> 
>> In the FLIP I provide how the current Factories in JDBC would be changed
>> with this refactor, do you mean something different? Can you be more
>> specific with your request?
>> On May 14, 2024 at 12:32 +0200, Jeyhun Karimov ,
>> wrote:
>>> Hi Lorenzo,
>>> 
>>> Thanks for driving this FLIP. +1 for it.
>>> 
>>> Could you please elaborate more on how the new approach will be backwards
>>> compatible?
>>> 
>>> Regards,
>>> Jeyhun
>>> 
>>> On Tue, May 14, 2024 at 10:00 AM Muhammet Orazov
>>>  wrote:
>>> 
 Hey Lorenzo,
 
 Thanks for driving this FLIP! +1
 
 It will improve the user experience of using JDBC based
 connectors and help developers to build with different drivers.
 
 Best,
 Muhammet
 
 On 2024-05-13 10:20, lorenzo.affe...@ververica.com.INVALID wrote:
>> Hello dev!
>> 
>> I want to share a draft of my FLIP to refactor the JDBC connector
>> to
>> improve its extensibility [1].
>> The goal is to allow implementers to write new connectors on top
>> of the
>> JDBC one for Table API with clean and maintainable code.
>> 
>> Any feedback from the community is more and welcome.
>> 
>> [1]
>> 
 
>> https://docs.google.com/document/d/1kl_AikMlqPUI-LNiPBraAFVZDRg1LF4bn6uiNtR4dlY/edit?usp=sharing
 
>> 



Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-21 Thread Leonard Xu
Thanks Ahmed for kicking off this discussion, sorry for jumping the discussion 
late.

(1)I’m confused about the discuss thread name ‘FLIP-451: Refactor Async sink 
API’  and FLIP title/vote thread name '
FLIP-451: Introduce timeout configuration to AsyncSink API 
’,
 they are different for me. Could you help explain the change history?

(2) The FLIP-451 aims to introduce a timeout configuration, but I didn’t find 
the configuration in FLIP even I lookup some historical versions of the FLIP. 
Did I miss some key informations?

(3) About the code change part, there’re some un-complete pieces in 
AsyncSinkWriter for example `submitRequestEntries(List 
requestEntries,);` is incorrect and `sendTime` variable I didn’t 
find the place we define it and where we use it.

Sorry for jumping the discussion thread during vote phase again.

Best,
Leonard


> 2024年5月21日 下午3:49,Ahmed Hamdy  写道:
> 
> Hi Hong,
> Thanks for pointing that out, no we are not
> deprecating getFatalExceptionCons(). I have updated the FLIP
> Best Regards
> Ahmed Hamdy
> 
> 
> On Mon, 20 May 2024 at 15:40, Hong Liang  wrote:
> 
>> Hi Ahmed,
>> Thanks for putting this together! Should we still be marking
>> getFatalExceptionCons() as @Deprecated in this FLIP, if we are not
>> providing a replacement?
>> 
>> Regards,
>> Hong
>> 
>> On Mon, May 13, 2024 at 7:58 PM Ahmed Hamdy  wrote:
>> 
>>> Hi David,
>>> yes there error classification was initially left to sink implementers to
>>> handle while we provided utilities to classify[1] and bubble up[2] fatal
>>> exceptions to avoid retrying them.
>>> Additionally some sink implementations provide an option to short circuit
>>> the failures by exposing a `failOnError` flag as in
>> KinesisStreamsSink[3],
>>> however this FLIP scope doesn't include any changes for retry mechanisms.
>>> 
>>> 1-
>>> 
>>> 
>> https://github.com/apache/flink/blob/015867803ff0c128b1c67064c41f37ca0731ed86/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java#L32
>>> 2-
>>> 
>>> 
>> https://github.com/apache/flink/blob/015867803ff0c128b1c67064c41f37ca0731ed86/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java#L533
>>> 3-
>>> 
>>> 
>> https://github.com/apache/flink-connector-aws/blob/c6e0abb65a0e51b40dd218b890a111886fbf797f/flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkWriter.java#L106
>>> 
>>> Best Regards
>>> Ahmed Hamdy
>>> 
>>> 
>>> On Mon, 13 May 2024 at 16:20, David Radley 
>>> wrote:
>>> 
 Hi,
 I wonder if the way that the async request fails could be a retriable
>> or
 non-retriable error, so it would retry only for retriable (transient)
 errors (like IOExceptions) . I see some talk on the internet around
 retriable SQL errors.
 If this was the case then we may need configuration to limit the
>> number
 of retries of retriable errors.
Kind regards, David
 
 
 From: Muhammet Orazov 
 Date: Monday, 13 May 2024 at 10:30
 To: dev@flink.apache.org 
 Subject: [EXTERNAL] Re: [DISCUSS] FLIP-451: Refactor Async sink API
 Great, thanks for clarifying!
 
 Best,
 Muhammet
 
 
 On 2024-05-06 13:40, Ahmed Hamdy wrote:
> Hi Muhammet,
> Thanks for the feedback.
> 
>> Could you please add more here why it is harder? Would the
>> `completeExceptionally`
>> method be related to it? Maybe you can add usage example for it
>> also.
>> 
> 
> this is mainly due to the current implementation of fatal exception
> failures which depends on base `getFatalExceptionConsumer` method
>> that
> is
> decoupled from the actual called method `submitRequestEntries`, Since
> this
> is now not the primary concern of the FLIP, I have removed it from
>> the
> motivation so that the scope is defined around introducing the
>> timeout
> configuration.
> 
>> Should we add a list of possible connectors that this FLIP would
>> improve?
> 
> Good call, I have added under migration plan.
> 
> Best Regards
> Ahmed Hamdy
> 
> 
> On Mon, 6 May 2024 at 08:49, Muhammet Orazov 
> wrote:
> 
>> Hey Ahmed,
>> 
>> Thanks for the FLIP! +1 (non-binding)
>> 
>>> Additionally the current interface for passing fatal exceptions
>> and
>>> retrying records relies on java consumers which makes it harder to
>>> understand.
>> 
>> Could you please add more here why it is harder? Would the
>> `completeExceptionally`
>> method be related to it? Maybe you can add usage example for it
>> also.
>> 
>>> we should proceed by adding support in all supporting connector
>>> repos.
>> 
>> Should we add li

Re: [DISCUSS] Add a JDBC Sink Plugin to Flink-CDC-Pipeline

2024-05-21 Thread Leonard Xu
Thanks Jerry for kicking off this thread, the idea makes sense to me, JDBC Sink 
is users’ need and Flink CDC project should support it soon.

Could you share your design docs(FLIP) firstly[1]? And then we can continue the 
design discussion.

Please feel free to ping me if you have any concerns about FLIP process or 
Flink CDC design part.

Best,
Leonard
[1] https://cwiki.apache.org/confluence/display/FLINK/FLIP+Template 


> 2024年5月15日 下午3:06,Jerry  写道:
> 
> Hi all
> My name is ZhengjunZhou, an user and developer of FlinkCDC. In my recent
> projects, I realized that we could enhance the capabilities of
> Flink-CDC-Pipeline by introducing a JDBC Sink plugin, enabling FlinkCDC to
> directly output change data capture (CDC) to various JDBC-supported
> database systems.
> 
> Currently, while FlinkCDC offers support for a wide range of data sources,
> there is no direct solution for sinks, especially for common relational
> databases. I believe that adding a JDBC Sink plugin will significantly
> boost its applicability in data integration scenarios.
> 
> Specifically, this plugin would allow users to configure database
> connections and stream data directly to SQL databases via the standard JDBC
> interface. This could be used for data migration tasks as well as real-time
> data synchronization.
> 
> To further discuss this proposal and gather feedback from the community, I
> have prepared a preliminary design draft and hope to discuss it in detail
> in the upcoming community meeting. Please consider the potential value of
> this feature and provide your insights and guidance.
> 
> Thank you for your time and consideration. I look forward to your active
> feedback and further discussion.
> 
> [1] https://github.com/apache/flink-connector-jdbc



Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-21 Thread Leonard Xu
Thanks for your reply, Ahmed.

> (2) The FLIP-451 aims to introduce a timeout configuration, but I didn’t
>> find the configuration in FLIP even I lookup some historical versions of
>> the FLIP. Did I miss some key informations?
>> 
> 
> Yes, I tried to implicitly point that it will be added to the existing
> AsyncSinkWriterConfiguration to not inflate the FLIP, but I get it might be
> confusing. I have added the changes to the configuration classes in the
> FLIP to make it clearer.

(1) Implicitly point a public API change is not enough, Could you add a section 
Public Interfaces to enumerate all Public APIs that you proposed and you 
changed?
It’s a standard part of a FLIP template[1]. 

(2) About the proposed public interface ResultHandler, Could you 
explain or show how to use the methods #completeExceptionally and 
#retryForEntries? I didn’t find 
detail explanation or Usage example code to understand them.

(3) Could you add necessary java documents for all public API changes like new 
method AsyncSinkWriterConfiguration#setRequestTimeoutMs ? The java doc of [2] 
is a good example.

(4) Another minor reminder AsyncSinkBase is a @PublicEvolving interface too, 
please correct it, and please ensure the backward compatibility has been 
considered for all public interfaces the FLIP changed.


Best,
Leonard
[1]https://cwiki.apache.org/confluence/display/FLINK/FLIP+Template
[2]https://cwiki.apache.org/confluence/display/FLINK/FLIP-171%3A+Async+Sink


> 
> 
> On Tue, 21 May 2024 at 14:56, Leonard Xu  wrote:
> 
>> Thanks Ahmed for kicking off this discussion, sorry for jumping the
>> discussion late.
>> 
>> (1)I’m confused about the discuss thread name ‘FLIP-451: Refactor Async
>> sink API’  and FLIP title/vote thread name '
>> FLIP-451: Introduce timeout configuration to AsyncSink API <
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-451%3A+Introduce+timeout+configuration+to+AsyncSink+API>’,
>> they are different for me. Could you help explain the change history?
>> 
>> (2) The FLIP-451 aims to introduce a timeout configuration, but I didn’t
>> find the configuration in FLIP even I lookup some historical versions of
>> the FLIP. Did I miss some key informations?
>> 
>> (3) About the code change part, there’re some un-complete pieces in
>> AsyncSinkWriter for example `submitRequestEntries(List
>> requestEntries,);` is incorrect and `sendTime` variable I didn’t
>> find the place we define it and where we use it.
>> 
>> Sorry for jumping the discussion thread during vote phase again.
>> 
>> Best,
>> Leonard
>> 
>> 
>>> 2024年5月21日 下午3:49,Ahmed Hamdy  写道:
>>> 
>>> Hi Hong,
>>> Thanks for pointing that out, no we are not
>>> deprecating getFatalExceptionCons(). I have updated the FLIP
>>> Best Regards
>>> Ahmed Hamdy
>>> 
>>> 
>>> On Mon, 20 May 2024 at 15:40, Hong Liang  wrote:
>>> 
>>>> Hi Ahmed,
>>>> Thanks for putting this together! Should we still be marking
>>>> getFatalExceptionCons() as @Deprecated in this FLIP, if we are not
>>>> providing a replacement?
>>>> 
>>>> Regards,
>>>> Hong
>>>> 
>>>> On Mon, May 13, 2024 at 7:58 PM Ahmed Hamdy 
>> wrote:
>>>> 
>>>>> Hi David,
>>>>> yes there error classification was initially left to sink implementers
>> to
>>>>> handle while we provided utilities to classify[1] and bubble up[2]
>> fatal
>>>>> exceptions to avoid retrying them.
>>>>> Additionally some sink implementations provide an option to short
>> circuit
>>>>> the failures by exposing a `failOnError` flag as in
>>>> KinesisStreamsSink[3],
>>>>> however this FLIP scope doesn't include any changes for retry
>> mechanisms.
>>>>> 
>>>>> 1-
>>>>> 
>>>>> 
>>>> 
>> https://github.com/apache/flink/blob/015867803ff0c128b1c67064c41f37ca0731ed86/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java#L32
>>>>> 2-
>>>>> 
>>>>> 
>>>> 
>> https://github.com/apache/flink/blob/015867803ff0c128b1c67064c41f37ca0731ed86/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java#L533
>>>>> 3-
>>>>> 
>>>>> 
>>>> 
>> https://github.com/apache/flink-connector-aws/blob/c6e0abb65a0e51b40dd218b890a111886fbf797f/flink-connector-

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-22 Thread Leonard Xu
Thanks Ahmed for the update, the FLIP looks good to me now.

Best,
Leonard

> 2024年5月22日 下午4:34,Ahmed Hamdy  写道:
> 
>> 
>> (1) Implicitly point a public API change is not enough, Could you add a
>> section Public Interfaces to enumerate all Public APIs that you proposed
>> and you changed?
>> It’s a standard part of a FLIP template[1].
>> 
> yes this is updated in the FLIP now.
> 
> 
> 
>> (2) About the proposed public interface ResultHandler,
>> Could you explain or show how to use the methods #completeExceptionally and
>> #retryForEntries? I didn’t find
>> detail explanation or Usage example code to understand them.
>> 
> 
> Added to the FLIP now.
> 
> 
> 
>> (3) Could you add necessary java documents for all public API changes like
>> new method AsyncSinkWriterConfiguration#setRequestTimeoutMs ? The java doc
>> of [2] is a good example.
>> 
> 
> sure, Added now.
> 
> (4) Another minor reminder AsyncSinkBase is a @PublicEvolving interface
>> too, please correct it, and please ensure the backward compatibility has
>> been considered for all public interfaces the FLIP changed.
>> 
> Done
> 
> Best Regards
> Ahmed Hamdy
> 
> 
> On Wed, 22 May 2024 at 04:16, Leonard Xu  wrote:
> 
>> Thanks for your reply, Ahmed.
>> 
>>> (2) The FLIP-451 aims to introduce a timeout configuration, but I didn’t
>>>> find the configuration in FLIP even I lookup some historical versions of
>>>> the FLIP. Did I miss some key informations?
>>>> 
>>> 
>>> Yes, I tried to implicitly point that it will be added to the existing
>>> AsyncSinkWriterConfiguration to not inflate the FLIP, but I get it might
>> be
>>> confusing. I have added the changes to the configuration classes in the
>>> FLIP to make it clearer.
>> 
>> (1) Implicitly point a public API change is not enough, Could you add a
>> section Public Interfaces to enumerate all Public APIs that you proposed
>> and you changed?
>> It’s a standard part of a FLIP template[1].
>> 
>> (2) About the proposed public interface ResultHandler,
>> Could you explain or show how to use the methods #completeExceptionally and
>> #retryForEntries? I didn’t find
>> detail explanation or Usage example code to understand them.
>> 
>> (3) Could you add necessary java documents for all public API changes like
>> new method AsyncSinkWriterConfiguration#setRequestTimeoutMs ? The java doc
>> of [2] is a good example.
>> 
>> (4) Another minor reminder AsyncSinkBase is a @PublicEvolving interface
>> too, please correct it, and please ensure the backward compatibility has
>> been considered for all public interfaces the FLIP changed.
>> 
>> 
>> Best,
>> Leonard
>> [1]https://cwiki.apache.org/confluence/display/FLINK/FLIP+Template
>> [2]
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-171%3A+Async+Sink
>> 
>> 
>>> 
>>> 
>>> On Tue, 21 May 2024 at 14:56, Leonard Xu  wrote:
>>> 
>>>> Thanks Ahmed for kicking off this discussion, sorry for jumping the
>>>> discussion late.
>>>> 
>>>> (1)I’m confused about the discuss thread name ‘FLIP-451: Refactor Async
>>>> sink API’  and FLIP title/vote thread name '
>>>> FLIP-451: Introduce timeout configuration to AsyncSink API <
>>>> 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-451%3A+Introduce+timeout+configuration+to+AsyncSink+API
>>> ’,
>>>> they are different for me. Could you help explain the change history?
>>>> 
>>>> (2) The FLIP-451 aims to introduce a timeout configuration, but I didn’t
>>>> find the configuration in FLIP even I lookup some historical versions of
>>>> the FLIP. Did I miss some key informations?
>>>> 
>>>> (3) About the code change part, there’re some un-complete pieces in
>>>> AsyncSinkWriter for example `submitRequestEntries(List
>>>> requestEntries,);` is incorrect and `sendTime` variable I didn’t
>>>> find the place we define it and where we use it.
>>>> 
>>>> Sorry for jumping the discussion thread during vote phase again.
>>>> 
>>>> Best,
>>>> Leonard
>>>> 
>>>> 
>>>>> 2024年5月21日 下午3:49,Ahmed Hamdy  写道:
>>>>> 
>>>>> Hi Hong,
>>>>> Thanks for pointing that out, no we are not
>>>>> deprecating getFatalExceptionCons(). I have updated the FLIP
>>>>

Re: [VOTE] FLIP-451: Introduce timeout configuration to AsyncSink

2024-05-22 Thread Leonard Xu


After discuss with Ahmed, the updated FLIP looks good to me.

+1(binding)


Best,
Leonard

> 2024年5月21日 下午6:12,Hong Liang  写道:
> 
> +1 (binding)
> 
> Thanks Ahmed
> 
> On Tue, May 14, 2024 at 11:51 AM David Radley 
> wrote:
> 
>> Thanks for the clarification Ahmed
>> 
>> +1 (non-binding)
>> 
>> From: Ahmed Hamdy 
>> Date: Monday, 13 May 2024 at 19:58
>> To: dev@flink.apache.org 
>> Subject: [EXTERNAL] Re: [VOTE] FLIP-451: Introduce timeout configuration
>> to AsyncSink
>> Thanks David,
>> I have replied to your question in the discussion thread.
>> Best Regards
>> Ahmed Hamdy
>> 
>> 
>> On Mon, 13 May 2024 at 16:21, David Radley 
>> wrote:
>> 
>>> Hi,
>>> I raised a question on the discussion thread, around retriable errors, as
>>> a possible alternative,
>>>  Kind regards, David.
>>> 
>>> 
>>> From: Aleksandr Pilipenko 
>>> Date: Monday, 13 May 2024 at 16:07
>>> To: dev@flink.apache.org 
>>> Subject: [EXTERNAL] Re: [VOTE] FLIP-451: Introduce timeout configuration
>>> to AsyncSink
>>> Thanks for driving this!
>>> 
>>> +1 (non-binding)
>>> 
>>> Thanks,
>>> Aleksandr
>>> 
>>> On Mon, 13 May 2024 at 14:08, 
>>> wrote:
>>> 
 Thanks Ahmed!
 
 +1 non binding
 On May 13, 2024 at 12:40 +0200, Jeyhun Karimov ,
 wrote:
> Thanks for driving this Ahmed.
> 
> +1 (non-binding)
> 
> Regards,
> Jeyhun
> 
> On Mon, May 13, 2024 at 12:37 PM Muhammet Orazov
>  wrote:
> 
>> Thanks Ahmed, +1 (non-binding)
>> 
>> Best,
>> Muhammet
>> 
>> On 2024-05-13 09:50, Ahmed Hamdy wrote:
 Hi all,
 
 Thanks for the feedback on the discussion thread[1], I would
>> like
 to
 start
 a vote on FLIP-451[2]: Introduce timeout configuration to
>>> AsyncSink
 
 The vote will be open for at least 72 hours unless there is an
 objection or
 insufficient votes.
 
 1-
>>> https://lists.apache.org/thread/ft7wcw7kyftvww25n5fm4l925tlgdfg0
 2-
 
>> 
 
>>> 
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-451%3A+Introduce+timeout+configuration+to+AsyncSink+API
 Best Regards
 Ahmed Hamdy
>> 
 
>>> 
>>> Unless otherwise stated above:
>>> 
>>> IBM United Kingdom Limited
>>> Registered in England and Wales with number 741598
>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU
>>> 
>> 
>> Unless otherwise stated above:
>> 
>> IBM United Kingdom Limited
>> Registered in England and Wales with number 741598
>> Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU
>> 



Re: [VOTE] Release flink-connector-aws v4.3.0, release candidate #2

2024-05-22 Thread Leonard Xu
+1 (binding)

- verified signatures
- verified hashsums
- built from source code with java 1.8 succeeded
- checked Github release tag 
- checked release notes
- reviewed the web PR

Best,
Leonard

> 2024年4月28日 下午11:56,Aleksandr Pilipenko  写道:
> 
> +1 (non-binding)
> 
> - Verified checksums
> - Verified signatures
> - Checked that no binaries exist in the source archive
> - Reviewed Web PR
> - Built source
> 
> Thanks,
> Aleksandr
> 
> On Mon, 22 Apr 2024 at 09:31, Ahmed Hamdy  wrote:
> 
>> Thanks Danny,
>> +1 (non-binding)
>> 
>> - Verified Checksums
>> - Verified Signatures
>> - No binaries exists in source archive
>> - Built source
>> - Reviewed Web PR
>> - Run basic Kinesis example
>> 
>> 
>> Best Regards
>> Ahmed Hamdy
>> 
>> 
>> On Sun, 21 Apr 2024 at 14:25, Hang Ruan  wrote:
>> 
>>> +1 (non-binding)
>>> 
>>> - Validated checksum hash
>>> - Verified signature
>>> - Verified that no binaries exist in the source archive
>>> - Build the source with Maven and jdk8
>>> - Verified web PR
>>> - Check that the jar is built by jdk8
>>> 
>>> Best,
>>> Hang
>>> 
>>> Danny Cranmer  于2024年4月19日周五 18:08写道:
>>> 
 Hi everyone,
 
 Please review and vote on release candidate #2 for flink-connector-aws
 v4.3.0, as follows:
 [ ] +1, Approve the release
 [ ] -1, Do not approve the release (please provide specific comments)
 
 This version supports Flink 1.18 and 1.19.
 
 The complete staging area is available for your review, which includes:
 * JIRA release notes [1],
 * the official Apache source release to be deployed to dist.apache.org
 [2],
 which are signed with the key with fingerprint 125FD8DB [3],
 * all artifacts to be deployed to the Maven Central Repository [4],
 * source code tag v4.3.0-rc2 [5],
 * website pull request listing the new release [6].
 * CI build of the tag [7].
 
 The vote will be open for at least 72 hours. It is adopted by majority
 approval, with at least 3 PMC affirmative votes.
 
 Thanks,
 Release Manager
 
 [1]
 
 
>>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353793
 [2]
 
>>> 
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-aws-4.3.0-rc2
 [3] https://dist.apache.org/repos/dist/release/flink/KEYS
 [4]
 
>> https://repository.apache.org/content/repositories/orgapacheflink-1721/
 [5]
>>> https://github.com/apache/flink-connector-aws/releases/tag/v4.3.0-rc2
 [6] https://github.com/apache/flink-web/pull/733
 [7]
>>> https://github.com/apache/flink-connector-aws/actions/runs/8751694197
 
>>> 
>> 



Re: [VOTE] Release flink-connector-cassandra v3.2.0, release candidate #1

2024-05-22 Thread Leonard Xu
+1 (binding)

- verified signatures
- verified hashsums
- built from source code with java 1.8 succeeded
- checked Github release tag 
- checked release notes status which only left one issue is used for release 
tracking
- reviewed the web PR

Best,
Leonard

> 2024年5月22日 下午6:10,weijie guo  写道:
> 
> +1(non-binding)
> 
> -Validated checksum hash
> -Verified signature
> -Build from source
> 
> Best regards,
> 
> Weijie
> 
> 
> Hang Ruan  于2024年5月22日周三 10:12写道:
> 
>> +1 (non-binding)
>> 
>> - Validated checksum hash
>> - Verified signature
>> - Verified that no binaries exist in the source archive
>> - Build the source with Maven and jdk8
>> - Verified web PR
>> - Check that the jar is built by jdk8
>> 
>> Best,
>> Hang
>> 
>> Muhammet Orazov  于2024年5月22日周三 04:15写道:
>> 
>>> Hey all,
>>> 
>>> Could we please get some more votes to proceed with the release?
>>> 
>>> Thanks and best,
>>> Muhammet
>>> 
>>> On 2024-04-22 13:04, Danny Cranmer wrote:
 Hi everyone,
 
 Please review and vote on release candidate #1 for
 flink-connector-cassandra v3.2.0, as follows:
 [ ] +1, Approve the release
 [ ] -1, Do not approve the release (please provide specific comments)
 
 This release supports Flink 1.18 and 1.19.
 
 The complete staging area is available for your review, which includes:
 * JIRA release notes [1],
 * the official Apache source release to be deployed to dist.apache.org
 [2],
 which are signed with the key with fingerprint 125FD8DB [3],
 * all artifacts to be deployed to the Maven Central Repository [4],
 * source code tag v3.2.0-rc1 [5],
 * website pull request listing the new release [6].
 * CI build of the tag [7].
 
 The vote will be open for at least 72 hours. It is adopted by majority
 approval, with at least 3 PMC affirmative votes.
 
 Thanks,
 Danny
 
 [1]
 
>>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353148
 [2]
 
>>> 
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-cassandra-3.2.0-rc1
 [3] https://dist.apache.org/repos/dist/release/flink/KEYS
 [4]
 https://repository.apache.org/content/repositories/orgapacheflink-1722
 [5]
 
>>> 
>> https://github.com/apache/flink-connector-cassandra/releases/tag/v3.2.0-rc1
 [6] https://github.com/apache/flink-web/pull/737
 [7]
 
>>> 
>> https://github.com/apache/flink-connector-cassandra/actions/runs/8784310241
>>> 
>> 



Re: [VOTE] Release flink-connector-gcp-pubsub v3.1.0, release candidate #1

2024-05-22 Thread Leonard Xu


+1 (binding)

- verified signatures
- verified hashsums
- built from source code with java 1.8 succeeded
- checked Github release tag 
- checked release notes
- reviewed the web PR

Best,
Leonard

> 2024年4月21日 下午9:52,Hang Ruan  写道:
> 
> +1 (non-binding)
> 
> - Validated checksum hash
> - Verified signature
> - Verified that no binaries exist in the source archive
> - Build the source with Maven and jdk8
> - Verified web PR
> - Check that the jar is built by jdk8
> 
> Best,
> Hang
> 
> Ahmed Hamdy  于2024年4月18日周四 20:01写道:
> 
>> Hi Danny,
>> +1 (non-binding)
>> 
>> -  verified hashes and checksums
>> - verified signature
>> - verified source contains no binaries
>> - tag exists in github
>> - reviewed web PR
>> 
>> Best Regards
>> Ahmed Hamdy
>> 
>> 
>> On Thu, 18 Apr 2024 at 11:32, Danny Cranmer 
>> wrote:
>> 
>>> Hi everyone,
>>> 
>>> Please review and vote on release candidate #1 for
>>> flink-connector-gcp-pubsub v3.1.0, as follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>> 
>>> This release supports Flink 1.18 and 1.19.
>>> 
>>> The complete staging area is available for your review, which includes:
>>> * JIRA release notes [1],
>>> * the official Apache source release to be deployed to dist.apache.org
>>> [2],
>>> which are signed with the key with fingerprint 125FD8DB [3],
>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> * source code tag v3.1.0-rc1 [5],
>>> * website pull request listing the new release [6].
>>> * CI build of the tag [7].
>>> 
>>> The vote will be open for at least 72 hours. It is adopted by majority
>>> approval, with at least 3 PMC affirmative votes.
>>> 
>>> Thanks,
>>> Danny
>>> 
>>> [1]
>>> 
>>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353813
>>> [2]
>>> 
>>> 
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-gcp-pubsub-3.1.0-rc1
>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> [4]
>> https://repository.apache.org/content/repositories/orgapacheflink-1720
>>> [5]
>>> 
>>> 
>> https://github.com/apache/flink-connector-gcp-pubsub/releases/tag/v3.1.0-rc1
>>> [6] https://github.com/apache/flink-web/pull/736/files
>>> [7]
>>> 
>>> 
>> https://github.com/apache/flink-connector-gcp-pubsub/actions/runs/8735952883
>>> 
>> 



Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-05-22 Thread Leonard Xu
+1 (binding)

- verified signatures
- verified hashsums
- built from source code with java 1.8 succeeded
- checked Github release tag 
- checked release notes
- reviewed the web PR

Best,
Leonard

> 2024年4月21日 下午9:42,Hang Ruan  写道:
> 
> +1 (non-binding)
> 
> - Validated checksum hash
> - Verified signature
> - Verified that no binaries exist in the source archive
> - Build the source with Maven and jdk8
> - Verified web PR
> - Check that the jar is built by jdk8
> 
> Best,
> Hang
> 
> Ahmed Hamdy  于2024年4月18日周四 21:37写道:
> 
>> +1 (non-binding)
>> 
>> - Verified Checksums and hashes
>> - Verified Signatures
>> - No binaries in source
>> - Build source
>> - Github tag exists
>> - Reviewed Web PR
>> 
>> 
>> Best Regards
>> Ahmed Hamdy
>> 
>> 
>> On Thu, 18 Apr 2024 at 11:22, Danny Cranmer 
>> wrote:
>> 
>>> Sorry for typos:
>>> 
 Please review and vote on the release candidate #1 for the version
>> 3.2.0,
>>> as follows:
>>> Should be "release candidate #2"
>>> 
 * source code tag v3.2.0-rc1 [5],
>>> Should be "source code tag v3.2.0-rc2"
>>> 
>>> Thanks,
>>> Danny
>>> 
>>> On Thu, Apr 18, 2024 at 11:19 AM Danny Cranmer 
>>> wrote:
>>> 
 Hi everyone,
 
 Please review and vote on the release candidate #1 for the version
>> 3.2.0,
 as follows:
 [ ] +1, Approve the release
 [ ] -1, Do not approve the release (please provide specific comments)
 
 This release supports Flink 1.18 and 1.19.
 
 The complete staging area is available for your review, which includes:
 * JIRA release notes [1],
 * the official Apache source release to be deployed to dist.apache.org
 [2], which are signed with the key with fingerprint 125FD8DB [3],
 * all artifacts to be deployed to the Maven Central Repository [4],
 * source code tag v3.2.0-rc1 [5],
 * website pull request listing the new release [6].
 * CI run of tag [7].
 
 The vote will be open for at least 72 hours. It is adopted by majority
 approval, with at least 3 PMC affirmative votes.
 
 Thanks,
 Danny
 
 [1]
 
>>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353143
 [2]
 
>>> 
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
 [3] https://dist.apache.org/repos/dist/release/flink/KEYS
 [4]
 
>> https://repository.apache.org/content/repositories/orgapacheflink-1718/
 [5]
>>> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
 [6] https://github.com/apache/flink-web/pull/734
 [7]
>>> https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
 
>>> 
>> 



Re: [VOTE] Release flink-connector-kafka v3.2.0, release candidate #1

2024-05-22 Thread Leonard Xu
+1 (binding)

- verified signatures
- verified hashsums
- built from source code with java 1.8 succeeded
- checked Github release tag 
- reviewed the web PR
- checked the CI result, 
  minor: the link [7] you post should be [1]
- checked release notes, 
  minor: the issue FLINK-34961[2] should move to next version


Best,
Leonard

[1] https://github.com/apache/flink-connector-kafka/actions/runs/8785158288
[2] https://issues.apache.org/jira/browse/FLINK-34961


> 2024年4月29日 上午12:34,Aleksandr Pilipenko  写道:
> 
> +1 (non-binding)
> 
> - Validated checksum
> - Verified signature
> - Checked that no binaries exist in the source archive
> - Build source
> - Verified web PR
> 
> Thanks,
> Aleksandr
> 
> On Sun, 28 Apr 2024 at 11:35, Hang Ruan  wrote:
> 
>> +1 (non-binding)
>> 
>> - Validated checksum hash
>> - Verified signature
>> - Verified that no binaries exist in the source archive
>> - Build the source with Maven and jdk8
>> - Verified web PR
>> - Check that the jar is built by jdk8
>> 
>> Best,
>> Hang
>> 
>> Ahmed Hamdy  于2024年4月24日周三 17:21写道:
>> 
>>> Thanks Danny,
>>> +1 (non-binding)
>>> 
>>> - Verified Checksums and hashes
>>> - Verified Signatures
>>> - Reviewed web PR
>>> - github tag exists
>>> - Build source
>>> 
>>> 
>>> Best Regards
>>> Ahmed Hamdy
>>> 
>>> 
>>> On Tue, 23 Apr 2024 at 03:47, Muhammet Orazov
>>> 
>>> wrote:
>>> 
 Thanks Danny, +1 (non-binding)
 
 - Checked 512 hash
 - Checked gpg signature
 - Reviewed pr
 - Built the source with JDK 11 & 8
 
 Best,
 Muhammet
 
 On 2024-04-22 13:55, Danny Cranmer wrote:
> Hi everyone,
> 
> Please review and vote on release candidate #1 for
> flink-connector-kafka
> v3.2.0, as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> This release supports Flink 1.18 and 1.19.
> 
> The complete staging area is available for your review, which
>> includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to
>> dist.apache.org
> [2],
> which are signed with the key with fingerprint 125FD8DB [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.2.0-rc1 [5],
> * website pull request listing the new release [6].
> * CI build of the tag [7].
> 
> The vote will be open for at least 72 hours. It is adopted by
>> majority
> approval, with at least 3 PMC affirmative votes.
> 
> Thanks,
> Danny
> 
> [1]
> 
 
>>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354209
> [2]
> 
 
>>> 
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.2.0-rc1
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4]
> 
>> https://repository.apache.org/content/repositories/orgapacheflink-1723
> [5]
> 
>>> https://github.com/apache/flink-connector-kafka/releases/tag/v3.2.0-rc1
> [6] https://github.com/apache/flink-web/pull/738
> [7] https://github.com/apache/flink-connector-kafka
 
>>> 
>> 



Re: [VOTE] Release flink-connector-mongodb v1.2.0, release candidate #2

2024-05-22 Thread Leonard Xu
+1 (binding)

- verified signatures
- verified hashsums
- built from source code with java 1.8 succeeded
- checked Github release tag 
- checked release notes
- reviewed the web PR

Best,
Leonard

> 2024年5月22日 下午4:16,Qingsheng Ren  写道:
> 
> +1 (binding)
> 
> - Verified checksum and signature
> - Built from source with Java 8
> - Verified source release contains no binaries
> - Verified tag exists on GitHub
> - Verified JARs on Maven repo is built by Java 8
> - Reviewed web PR
> 
> Thanks for the awesome work, Danny!
> 
> Best,
> Qingsheng
> 
> On Mon, May 20, 2024 at 2:53 PM Jiabao Sun  wrote:
>> 
>> We need more votes for this release.
>> Much appreciated for helping with this release verification.
>> 
>> Best,
>> Jiabao
>> 
>> Jiabao Sun  于2024年4月21日周日 21:35写道:
>> 
>>> +1 (non-binding)
>>> 
>>> - Validated checksum hash
>>> - Verified signature
>>> - Tag is present
>>> - Build successful with jdk8, jdk11 and jdk17
>>> - Checked the dist jar was built by jdk8
>>> - Reviewed web PR
>>> Best,
>>> Jiabao
>>> 
>>> Hang Ruan  于2024年4月21日周日 21:33写道:
>>> 
 +1 (non-binding)
 
 - Validated checksum hash
 - Verified signature
 - Verified that no binaries exist in the source archive
 - Build the source with Maven and jdk8
 - Verified web PR
 - Check that the jar is built by jdk8
 
 Best,
 Hang
 
 Ahmed Hamdy  于2024年4月18日周四 21:40写道:
 
> +1 (non-binding)
> 
> -  verified hashes and checksums
> - verified signature
> - verified source contains no binaries
> - tag exists in github
> - reviewed web PR
> 
> 
> Best Regards
> Ahmed Hamdy
> 
> 
> On Thu, 18 Apr 2024 at 11:21, Danny Cranmer 
> wrote:
> 
>> Hi everyone,
>> 
>> Please review and vote on the release candidate #2 for v1.2.0, as
> follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>> 
>> This release supports Flink 1.18 and 1.19.
>> 
>> The complete staging area is available for your review, which
 includes:
>> * JIRA release notes [1],
>> * the official Apache source release to be deployed to
 dist.apache.org
>> [2],
>> which are signed with the key with fingerprint 125FD8DB [3],
>> * all artifacts to be deployed to the Maven Central Repository [4],
>> * source code tag v1.2.0-rc2 [5],
>> * website pull request listing the new release [6].
>> * CI build of tag [7].
>> 
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PMC affirmative votes.
>> 
>> Thanks,
>> Danny
>> 
>> [1]
>> 
>> 
> 
 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354192
>> [2]
>> 
>> 
> 
 https://dist.apache.org/repos/dist/dev/flink/flink-connector-mongodb-1.2.0-rc2
>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> [4]
>> 
 https://repository.apache.org/content/repositories/orgapacheflink-1719/
>> [5]
>> 
> 
 https://github.com/apache/flink-connector-mongodb/releases/tag/v1.2.0-rc2
>> [6] https://github.com/apache/flink-web/pull/735
>> [7]
>> 
> 
 https://github.com/apache/flink-connector-mongodb/actions/runs/8735987710
>> 
> 
 
>>> 



Re: [VOTE] Release flink-connector-opensearch v2.0.0, release candidate #1

2024-05-22 Thread Leonard Xu
+1 (binding)

- verified signatures
- verified hashsums
- built from source code with JDK 1.8 succeeded
- checked Github release tag 
- checked release notes
- reviewed the web PR

Best,
Leonard

> 2024年5月16日 上午6:58,Andrey Redko  写道:
> 
> +1 (non-binding), thanks Sergey!
> 
> On Wed, May 15, 2024, 6:00 p.m. Sergey Nuyanzin  wrote:
> 
>> Hi everyone,
>> Please review and vote on release candidate #1 for
>> flink-connector-opensearch v2.0.0, as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>> 
>> 
>> The complete staging area is available for your review, which includes:
>> * JIRA release notes [1],
>> * the official Apache source release to be deployed to dist.apache.org
>> [2],
>> which are signed with the key with fingerprint
>> F7529FAE24811A5C0DF3CA741596BBF0726835D8 [3],
>> * all artifacts to be deployed to the Maven Central Repository [4],
>> * source code tag v2.0.0-rc1 [5],
>> * website pull request listing the new release [6].
>> * CI build of the tag [7].
>> 
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PMC affirmative votes.
>> 
>> Note that this release is for Opensearch v2.x
>> 
>> Thanks,
>> Release Manager
>> 
>> [1] https://issues.apache.org/jira/projects/FLINK/versions/12354674
>> [2]
>> 
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-opensearch-2.0.0-rc1
>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> [4]
>> https://repository.apache.org/content/repositories/orgapacheflink-1735/
>> [5]
>> 
>> https://github.com/apache/flink-connector-opensearch/releases/tag/v2.0.0-rc1
>> [6] https://github.com/apache/flink-web/pull/741
>> [7]
>> 
>> https://github.com/apache/flink-connector-opensearch/actions/runs/9102980808
>> 



Re: [VOTE] Release flink-connector-opensearch v2.0.0, release candidate #1

2024-05-22 Thread Leonard Xu


> +1 (binding)
> 
> - verified signatures
> - verified hashsums
> - built from source code with JDK 1.8 succeeded
> - checked Github release tag 
> - checked release notes
> - reviewed the web PR

Supply more information about build from source code with JDK 1.8

> - built from source code with JDK 1.8 succeeded
It’s correct as we don’t activate opensearch2 profile by default.

- built from source code with JDK 1.8 and -Popensearch2 failed
- built from source code with JDK 11 and -Popensearch2 succeeded

Best,
Leonard


> 
> 
>> 2024年5月16日 上午6:58,Andrey Redko  写道:
>> 
>> +1 (non-binding), thanks Sergey!
>> 
>> On Wed, May 15, 2024, 6:00 p.m. Sergey Nuyanzin  wrote:
>> 
>>> Hi everyone,
>>> Please review and vote on release candidate #1 for
>>> flink-connector-opensearch v2.0.0, as follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>> 
>>> 
>>> The complete staging area is available for your review, which includes:
>>> * JIRA release notes [1],
>>> * the official Apache source release to be deployed to dist.apache.org
>>> [2],
>>> which are signed with the key with fingerprint
>>> F7529FAE24811A5C0DF3CA741596BBF0726835D8 [3],
>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> * source code tag v2.0.0-rc1 [5],
>>> * website pull request listing the new release [6].
>>> * CI build of the tag [7].
>>> 
>>> The vote will be open for at least 72 hours. It is adopted by majority
>>> approval, with at least 3 PMC affirmative votes.
>>> 
>>> Note that this release is for Opensearch v2.x
>>> 
>>> Thanks,
>>> Release Manager
>>> 
>>> [1] https://issues.apache.org/jira/projects/FLINK/versions/12354674
>>> [2]
>>> 
>>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-opensearch-2.0.0-rc1
>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> [4]
>>> https://repository.apache.org/content/repositories/orgapacheflink-1735/
>>> [5]
>>> 
>>> https://github.com/apache/flink-connector-opensearch/releases/tag/v2.0.0-rc1
>>> [6] https://github.com/apache/flink-web/pull/741
>>> [7]
>>> 
>>> https://github.com/apache/flink-connector-opensearch/actions/runs/9102980808
>>> 
> 



Re: [VOTE] Release flink-connector-opensearch v1.2.0, release candidate #1

2024-05-22 Thread Leonard Xu
+1 (binding)

- verified signatures
- verified hashsums
- built from source code with JDK 1.8 succeeded
- checked Github release tag 
- checked release notes
- reviewed the web PR

Best,
Leonard

> 2024年5月16日 上午6:58,Andrey Redko  写道:
> 
> +1 (non-binding), thanks Sergey!
> 
> On Wed, May 15, 2024, 5:56 p.m. Sergey Nuyanzin  wrote:
> 
>> Hi everyone,
>> Please review and vote on release candidate #1 for
>> flink-connector-opensearch v1.2.0, as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>> 
>> 
>> The complete staging area is available for your review, which includes:
>> * JIRA release notes [1],
>> * the official Apache source release to be deployed to dist.apache.org
>> [2],
>> which are signed with the key with fingerprint
>> F7529FAE24811A5C0DF3CA741596BBF0726835D8 [3],
>> * all artifacts to be deployed to the Maven Central Repository [4],
>> * source code tag v1.2.0-rc1 [5],
>> * website pull request listing the new release [6].
>> * CI build of the tag [7].
>> 
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PMC affirmative votes.
>> 
>> Note that this release is for Opensearch v1.x
>> 
>> Thanks,
>> Release Manager
>> 
>> [1] https://issues.apache.org/jira/projects/FLINK/versions/12353812
>> [2]
>> 
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-opensearch-1.2.0-rc1
>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> [4] https://repository.apache.org/content/repositories/orgapacheflink-1734
>> [5]
>> 
>> https://github.com/apache/flink-connector-opensearch/releases/tag/v1.2.0-rc1
>> [6] https://github.com/apache/flink-web/pull/740
>> [7]
>> 
>> https://github.com/apache/flink-connector-opensearch/actions/runs/9102334125
>> 



Re: [DISCUSSION] FLIP-457: Improve Table/SQL Configuration for Flink 2.0

2024-05-22 Thread Leonard Xu
Thanks Jane for the refine work, +1 from my side. 
I adjusted the table format of FLIP so that it can display all content in one 
page.

Best,
Leonard


> 2024年5月22日 下午3:42,Jane Chan  写道:
> 
> Hi Lincoln,
> 
> Thanks for your suggestion. I've reviewed the comments from the previous PR
> review[1], and the agreement at the time was that any configuration options
> not included in ExecutionConfigOptions and OptimizerConfigOptions should
> have the Experimental annotation explicitly added. Since this annotation
> has been relatively stable from 1.9.0 until now, you make a valid point,
> and we can elevate it to the PublicEvolving level.
> 
> Please let me know if you have any questions.
> 
> [1] https://github.com/apache/flink/pull/8980
> 
> Best,
> Jane
> 
> On Tue, May 21, 2024 at 10:25 PM Lincoln Lee  wrote:
> 
>> Hi Jane,
>> 
>> Thanks for the updates!
>> 
>> Just one small comment on the options in IncrementalAggregateRule
>> & RelNodeBlock, should we also change the API level from Experimental
>> to PublicEvolving?
>> 
>> 
>> Best,
>> Lincoln Lee
>> 
>> 
>> Jane Chan  于2024年5月21日周二 16:41写道:
>> 
>>> Hi all,
>>> 
>>> Thanks for your valuable feedback!
>>> 
>>> To @Xuannan
>>> 
>>> For options to be moved to another module/package, I think we have to
 mark the old option deprecated in 1.20 for it to be removed in 2.0,
 according to the API compatibility guarantees[1]. We can introduce the
 new option in 1.20 with the same option key in the intended class.
>>> 
>>> 
>>> Good point, fixed.
>>> 
>>> To @Lincoln and @Benchao
>>> 
>>> Thanks for sharing the insights into the historical context of which I
>> was
>>> unaware. I've reorganized the sheet.
>>> 
>>> 3. Regarding WindowEmitStrategy, IIUC it is currently unsupported on TVF
 window, so it's recommended to keep it untouched for now and follow up
>> in
 FLINK-29692
>>> 
>>> 
>>> How to tackle the configuration is up to whether to remove the legacy
>>> window aggregate in 2.0, and I've updated the FLIP to leverage this part
>> to
>>> FLINK-29692.
>>> 
>>> Please let me know if that answers your questions or if you have other
>>> comments.
>>> 
>>> Best,
>>> Jane
>>> 
>>> 
>>> On Mon, May 20, 2024 at 1:52 PM Ron Liu  wrote:
>>> 
 Hi, Lincoln
 
> 2. Regarding the options in HashAggCodeGenerator, since this new
>>> feature
 has gone
 through a couple of release cycles and could be considered for
 PublicEvolving now,
 cc @Ron Liu   WDYT?
 
 Thanks for cc'ing me,  +1 for public these options now.
 
 Best,
 Ron
 
 Benchao Li  于2024年5月20日周一 13:08写道:
 
> I agree with Lincoln about the experimental features.
> 
> Some of these configurations do not even have proper implementation,
> take 'table.exec.range-sort.enabled' as an example, there was a
> discussion[1] about it before.
> 
> [1] https://lists.apache.org/thread/q5h3obx36pf9po28r0jzmwnmvtyjmwdr
> 
> Lincoln Lee  于2024年5月20日周一 12:01写道:
>> 
>> Hi Jane,
>> 
>> Thanks for the proposal!
>> 
>> +1 for the changes except for these annotated as experimental ones.
>> 
>> For the options annotated as experimental,
>> 
>> +1 for the moving of IncrementalAggregateRule & RelNodeBlock.
>> 
>> For the rest of the options, there are some suggestions:
>> 
>> 1. for the batch related parameters, it's recommended to either
>>> delete
>> them (leaving the necessary defaults value in place) or leave them
>> as
> they
>> are. Including:
>> FlinkRelMdRowCount
>> FlinkRexUtil
>> BatchPhysicalSortRule
>> JoinDeriveNullFilterRule
>> BatchPhysicalJoinRuleBase
>> BatchPhysicalSortMergeJoinRule
>> 
>> What I understand about the history of these options is that they
>>> were
> once
>> used for fine
>> tuning for tpc testing, and the current flink planner no longer
>>> relies
 on
>> these internal
>> options when testing tpc[1]. In addition, these options are too
>>> obscure
> for
>> SQL users,
>> and some of them are actually magic numbers.
>> 
>> 2. Regarding the options in HashAggCodeGenerator, since this new
 feature
>> has gone
>> through a couple of release cycles and could be considered for
>> PublicEvolving now,
>> cc @Ron Liu   WDYT?
>> 
>> 3. Regarding WindowEmitStrategy, IIUC it is currently unsupported
>> on
 TVF
>> window, so
>> it's recommended to keep it untouched for now and follow up in
>> FLINK-29692[2]. cc @Xuyang 
>> 
>> [1]
>> 
> 
 
>>> 
>> https://github.com/ververica/flink-sql-benchmark/blob/master/tools/common/flink-conf.yaml
>> [2] https://issues.apache.org/jira/browse/FLINK-29692
>> 
>> 
>> Best,
>> Lincoln Lee
>> 
>> 
>> Yubin Li  于2024年5月17日周五 10:49写道:
>> 
>>> Hi Jane,
>>> 
>>> Thank Jane for driving this proposal !
>>> 
>>> This makes se

Re: [DISCUSS] Flink CDC Upgrade Debezium version to 2.x

2024-05-22 Thread Leonard Xu
Thanks zhongqiang for bringing this discussion.

I also noticed you also sent a mail to Debezium’s dev mailing list, it will 
help us a lot if they can help maintain a LTS version for their 1.x serials. 

I can accept the proposal to reference DBZ 2.0’s doc as a temporary solution in 
current situation. 

About upgrade Debezium version and bump JDK version as well, we’ve to consider 
that flink’s default JDK version is still JDK1.8, it’s a hard decision 
to make at this moment, but I agree we need to bump DBZ version and JDK version 
finally.


Best,
Leonard


> 2024年5月23日 下午1:24,gongzhongqiang  写道:
> 
> Hi all,
> 
> I would like to start a discussion about upgrading Debezium to version 2.x.
> 
> Background:
> Currently, the Debezium community no longer maintains versions prior to
> 2.0,
> and the website has taken down the documentation for versions before 2.0.
> However, Flink CDC depends on Debezium version 1.9, and the documentation
> references links to that version.
> 
> 
> Problem:
> - References to Debezium's documentation links report errors [1]
> - The Debezium community will no longer maintain versions prior to 2.0.
> Flink CDC
> synchronizes bug fixes from Debezium 2.0 by overwriting classes, but the
> classes differ significantly between 2.x and 1.9.
> 
> 
> Compatibility and Deprecation:
> - Debezium uses JDK 11 starting from version 2.0 [2]
> 
> 
> Plan:
> - Migrate references in Flink CDC documentation from Debezium 1.9 to 2.0
> - Upgrade Debezium to version 2.x
> 
> [1]
> https://github.com/apache/flink-cdc/actions/runs/9192497396/job/25281283926#step:4:1148
> [2] https://debezium.io/releases/2.0/
> 
> Best,
> Zhongqiang Gong



Re: [VOTE] FLIP-457: Improve Table/SQL Configuration for Flink 2.0

2024-05-23 Thread Leonard Xu
+1

Best,
Leonard

> 2024年5月24日 下午1:27,weijie guo  写道:
> 
> +1(binding)
> 
> Best regards,
> 
> Weijie
> 
> 
> Lincoln Lee  于2024年5月24日周五 12:20写道:
> 
>> +1(binding)
>> 
>> Best,
>> Lincoln Lee
>> 
>> 
>> Jane Chan  于2024年5月24日周五 09:52写道:
>> 
>>> Hi all,
>>> 
>>> I'd like to start a vote on FLIP-457[1] after reaching a consensus
>> through
>>> the discussion thread[2].
>>> 
>>> The vote will be open for at least 72 hours unless there is an objection
>> or
>>> insufficient votes.
>>> 
>>> 
>>> [1]
>>> 
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=307136992
>>> [2] https://lists.apache.org/thread/1sthbv6q00sq52pp04n2p26d70w4fqj1
>>> 
>>> Best,
>>> Jane
>>> 
>> 



Re: [DISCUSS] Flink 1.19.1 release

2024-05-26 Thread Leonard Xu
+1 for the 1.19.1 release and +1 for Hong as release manager.

Best,
Leonard

> 2024年5月25日 上午2:55,Danny Cranmer  写道:
> 
> +1 for the 1.19.1 release and +1 for Hong as release manager.



Re: [DISCUSS] Flink CDC 3.2 Release Planning

2024-05-27 Thread Leonard Xu
Hey, Xiqian

> In 3.2 KO plannings, it is expected to add some strongly demanded feature to 
> meet YAML pipeline job users’ needs [1]. However, 0 out of 10 3.2 feature 
> tickets have been completed till now, and it’s very unlikely for us to catch 
> up with planned feature freeze (May 25th) and release deadline (June 1st) [2].
> 
> I hereby suggest postponing release schedule by 2 weeks, extending feature 
> freeze day to June 8th and release day to June 15th. Considering its wide 
> affect, please leave your comments & concerns about this suggestion.

Thanks for the proposal, +1 for extending 2 weeks as the 3.1 release requires 
more work than expected.


Best,
Leonard

> 
> Regards,
> Xiqian
> 
> [1] https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=607
> [2] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=303794651
> 
> 
> De : Peter Huang 
> Date : jeudi, 9 mai 2024 à 23:31
> À : dev@flink.apache.org 
> Objet : Re: [DISCUSS] Flink CDC 3.2 Release Planning
> Thanks Qingsheng for driving the release!
> 
> +1. I also would like to provide some help on CDC 3.2.
> 
> 
> Best Regards
> Peter Huang
> 
> On Thu, May 9, 2024 at 3:21 AM Xiqian YU  wrote:
> 
>> Thanks Qingsheng for driving the release!
>> 
>> +1. Would love to provide my help on CDC 3.2.
>> 
>> Regards,
>> Xiqian
>> 
>> De : Hang Ruan 
>> Date : jeudi, 9 mai 2024 à 17:50
>> À : dev@flink.apache.org 
>> Objet : Re: [DISCUSS] Flink CDC 3.2 Release Planning
>> Thanks Qinsheng for driving.
>> 
>> I would like to provide some helps for this verison too. +1.
>> 
>> Best,
>> Hang
>> 
>> Hongshun Wang  于2024年5月9日周四 14:16写道:
>> 
>>> Thanks Qinsheng for driving,
>>> +1 from my side.
>>> 
>>> Besi,
>>> Hongshun
>>> 
>>> On Wed, May 8, 2024 at 11:41 PM Leonard Xu  wrote:
>>> 
>>>> +1 for the proposal code freeze date and RM candidate.
>>>> 
>>>> Best,
>>>> Leonard
>>>> 
>>>>> 2024年5月8日 下午10:27,gongzhongqiang  写道:
>>>>> 
>>>>> Hi Qingsheng
>>>>> 
>>>>> Thank you for driving the release.
>>>>> Agree with the goal and I'm willing to help.
>>>>> 
>>>>> Best,
>>>>> Zhongqiang Gong
>>>>> 
>>>>> Qingsheng Ren  于2024年5月8日周三 14:22写道:
>>>>> 
>>>>>> Hi devs,
>>>>>> 
>>>>>> As we are in the midst of the release voting process for Flink CDC
>>>> 3.1.0, I
>>>>>> think it's a good time to kick off the upcoming Flink CDC 3.2
>> release
>>>>>> cycle.
>>>>>> 
>>>>>> In this release cycle I would like to focus on the stability of
>> Flink
>>>> CDC,
>>>>>> especially for the newly introduced YAML-based data integration
>>>>>> framework. To ensure we can iterate and improve swiftly, I propose
>> to
>>>> make
>>>>>> 3.2 a relatively short release cycle, targeting a feature freeze by
>>> May
>>>> 24,
>>>>>> 2024.
>>>>>> 
>>>>>> For developers that are interested in participating and contributing
>>> new
>>>>>> features in this release cycle, please feel free to list your
>> planning
>>>>>> features in the wiki page [1].
>>>>>> 
>>>>>> I'm happy to volunteer as a release manager and of course open to
>> work
>>>>>> together with someone on this.
>>>>>> 
>>>>>> What do you think?
>>>>>> 
>>>>>> Best,
>>>>>> Qingsheng
>>>>>> 
>>>>>> [1]
>>>>>> 
>>> https://cwiki.apache.org/confluence/display/FLINK/Flink+CDC+3.2+Release
>>>>>> 
>>>> 
>>>> 
>>> 
>> 



Re: [DISCUSS] Add Flink CDC Channel to Apache Flink Slack Workspace

2024-05-27 Thread Leonard Xu


Thanks Zhongqiang for the proposal, we need the Channel and I should have been 
created it but not yet, +1 from my side.

Best,
Leonard

> 2024年5月28日 上午11:54,gongzhongqiang  写道:
> 
> Hi devs,
> 
> I would like to propose adding a dedicated Flink CDC channel to the Apache
> Flink Slack workspace.
> 
> Creating a channel focused on Flink CDC will help community members easily
> find previous discussions
> and target new discussions and questions to the correct place. Flink CDC is
> a sufficiently distinct component
> within the Apache Flink ecosystem, and having a dedicated channel will make
> it viable and useful for
> those specifically working with or interested in this technology.
> 
> Looking forward to your feedback and support on this proposal.
> 
> 
> Best,
> Zhongqiang Gong



Re: [DISCUSS] Flink CDC 3.1.1 Release

2024-05-28 Thread Leonard Xu
Thanks XIqian for kicking off the discussion, +1 from my side.

Best,
Leonard


> 2024年5月28日 下午7:43,Xiqian YU  写道:
> 
> Hi devs,
> 
> I would like to make a proposal about creating a new Flink CDC 3.1 patch 
> release (3.1.1). It’s been a week since the last CDC version 3.1.0 got 
> released [1], and since then, 7 tickets have been closed, 4 of them are of 
> high priority.
> 
> Currently, there are 5 items open at the moment: 1 of them is a blocker, 
> which stops users from restoring with existed checkpoints after upgrading 
> [2]. There’s a PR ready and will be merged soon. Other 4 of them have 
> approved PRs, and will be merged soon [3][4][5][6]. I propose that a patch 
> version could be released after all pending tickets closed.
> 
> Please reply if there are any unresolved blocking issues you’d like to 
> include in this release.
> 
> Regards,
> Xiqian
> 
> [1] 
> https://flink.apache.org/2024/05/17/apache-flink-cdc-3.1.0-release-announcement/
> [2] https://issues.apache.org/jira/browse/FLINK-35464
> [3] https://issues.apache.org/jira/browse/FLINK-35149
> [4] https://issues.apache.org/jira/browse/FLINK-35323
> [5] https://issues.apache.org/jira/browse/FLINK-35430
> [6] https://issues.apache.org/jira/browse/FLINK-35447
> 



Re: [DISCUSS] Flink CDC 3.2 Release Planning

2024-06-03 Thread Leonard Xu
Hey, qingsheng

Thanks for driving the 3.2 release forward, it involved more contributions and 
work than we plan at the beginning.
I’d like to help the release management as one release manager, feel free to 
ping me if you need any help from my side.

Best,
Leonard

> 2024年6月3日 下午4:21,Qingsheng Ren  写道:
> 
> Hi devs,
> 
> Considering the current timeline and my workload, it would be great to
> have someone help with managing this release cycle of Flink CDC. Feel
> free to contact me if you are interested!
> 
> Best,
> Qingsheng
> 
> On Mon, May 27, 2024 at 7:39 PM Leonard Xu  wrote:
>> 
>> Hey, Xiqian
>> 
>>> In 3.2 KO plannings, it is expected to add some strongly demanded feature 
>>> to meet YAML pipeline job users’ needs [1]. However, 0 out of 10 3.2 
>>> feature tickets have been completed till now, and it’s very unlikely for us 
>>> to catch up with planned feature freeze (May 25th) and release deadline 
>>> (June 1st) [2].
>>> 
>>> I hereby suggest postponing release schedule by 2 weeks, extending feature 
>>> freeze day to June 8th and release day to June 15th. Considering its wide 
>>> affect, please leave your comments & concerns about this suggestion.
>> 
>> Thanks for the proposal, +1 for extending 2 weeks as the 3.1 release 
>> requires more work than expected.
>> 
>> 
>> Best,
>> Leonard
>> 
>>> 
>>> Regards,
>>> Xiqian
>>> 
>>> [1] https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=607
>>> [2] 
>>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=303794651
>>> 
>>> 
>>> De : Peter Huang 
>>> Date : jeudi, 9 mai 2024 à 23:31
>>> À : dev@flink.apache.org 
>>> Objet : Re: [DISCUSS] Flink CDC 3.2 Release Planning
>>> Thanks Qingsheng for driving the release!
>>> 
>>> +1. I also would like to provide some help on CDC 3.2.
>>> 
>>> 
>>> Best Regards
>>> Peter Huang
>>> 
>>> On Thu, May 9, 2024 at 3:21 AM Xiqian YU  wrote:
>>> 
>>>> Thanks Qingsheng for driving the release!
>>>> 
>>>> +1. Would love to provide my help on CDC 3.2.
>>>> 
>>>> Regards,
>>>> Xiqian
>>>> 
>>>> De : Hang Ruan 
>>>> Date : jeudi, 9 mai 2024 à 17:50
>>>> À : dev@flink.apache.org 
>>>> Objet : Re: [DISCUSS] Flink CDC 3.2 Release Planning
>>>> Thanks Qinsheng for driving.
>>>> 
>>>> I would like to provide some helps for this verison too. +1.
>>>> 
>>>> Best,
>>>> Hang
>>>> 
>>>> Hongshun Wang  于2024年5月9日周四 14:16写道:
>>>> 
>>>>> Thanks Qinsheng for driving,
>>>>> +1 from my side.
>>>>> 
>>>>> Besi,
>>>>> Hongshun
>>>>> 
>>>>> On Wed, May 8, 2024 at 11:41 PM Leonard Xu  wrote:
>>>>> 
>>>>>> +1 for the proposal code freeze date and RM candidate.
>>>>>> 
>>>>>> Best,
>>>>>> Leonard
>>>>>> 
>>>>>>> 2024年5月8日 下午10:27,gongzhongqiang  写道:
>>>>>>> 
>>>>>>> Hi Qingsheng
>>>>>>> 
>>>>>>> Thank you for driving the release.
>>>>>>> Agree with the goal and I'm willing to help.
>>>>>>> 
>>>>>>> Best,
>>>>>>> Zhongqiang Gong
>>>>>>> 
>>>>>>> Qingsheng Ren  于2024年5月8日周三 14:22写道:
>>>>>>> 
>>>>>>>> Hi devs,
>>>>>>>> 
>>>>>>>> As we are in the midst of the release voting process for Flink CDC
>>>>>> 3.1.0, I
>>>>>>>> think it's a good time to kick off the upcoming Flink CDC 3.2
>>>> release
>>>>>>>> cycle.
>>>>>>>> 
>>>>>>>> In this release cycle I would like to focus on the stability of
>>>> Flink
>>>>>> CDC,
>>>>>>>> especially for the newly introduced YAML-based data integration
>>>>>>>> framework. To ensure we can iterate and improve swiftly, I propose
>>>> to
>>>>>> make
>>>>>>>> 3.2 a relatively short release cycle, targeting a feature freeze by
>>>>> May
>>>>>> 24,
>>>>>>>> 2024.
>>>>>>>> 
>>>>>>>> For developers that are interested in participating and contributing
>>>>> new
>>>>>>>> features in this release cycle, please feel free to list your
>>>> planning
>>>>>>>> features in the wiki page [1].
>>>>>>>> 
>>>>>>>> I'm happy to volunteer as a release manager and of course open to
>>>> work
>>>>>>>> together with someone on this.
>>>>>>>> 
>>>>>>>> What do you think?
>>>>>>>> 
>>>>>>>> Best,
>>>>>>>> Qingsheng
>>>>>>>> 
>>>>>>>> [1]
>>>>>>>> 
>>>>> https://cwiki.apache.org/confluence/display/FLINK/Flink+CDC+3.2+Release
>>>>>>>> 
>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>> 



Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-06-03 Thread Leonard Xu

> -1 (non-binding)
> blocked by https://issues.apache.org/jira/browse/FLINK-35496.


I just replied in https://issues.apache.org/jira/browse/FLINK-35496 
<https://issues.apache.org/jira/browse/FLINK-35496>, I think the API annotation 
understanding is incorrect in this case, hope to see your comments

Best,
Leonard




> Best, 
> Yuepeng Pan
> 
> 
> On 2024/05/22 12:13:51 Leonard Xu wrote:
>> +1 (binding)
>> 
>> - verified signatures
>> - verified hashsums
>> - built from source code with java 1.8 succeeded
>> - checked Github release tag 
>> - checked release notes
>> - reviewed the web PR
>> 
>> Best,
>> Leonard
>> 
>>> 2024年4月21日 下午9:42,Hang Ruan  写道:
>>> 
>>> +1 (non-binding)
>>> 
>>> - Validated checksum hash
>>> - Verified signature
>>> - Verified that no binaries exist in the source archive
>>> - Build the source with Maven and jdk8
>>> - Verified web PR
>>> - Check that the jar is built by jdk8
>>> 
>>> Best,
>>> Hang
>>> 
>>> Ahmed Hamdy  于2024年4月18日周四 21:37写道:
>>> 
>>>> +1 (non-binding)
>>>> 
>>>> - Verified Checksums and hashes
>>>> - Verified Signatures
>>>> - No binaries in source
>>>> - Build source
>>>> - Github tag exists
>>>> - Reviewed Web PR
>>>> 
>>>> 
>>>> Best Regards
>>>> Ahmed Hamdy
>>>> 
>>>> 
>>>> On Thu, 18 Apr 2024 at 11:22, Danny Cranmer 
>>>> wrote:
>>>> 
>>>>> Sorry for typos:
>>>>> 
>>>>>> Please review and vote on the release candidate #1 for the version
>>>> 3.2.0,
>>>>> as follows:
>>>>> Should be "release candidate #2"
>>>>> 
>>>>>> * source code tag v3.2.0-rc1 [5],
>>>>> Should be "source code tag v3.2.0-rc2"
>>>>> 
>>>>> Thanks,
>>>>> Danny
>>>>> 
>>>>> On Thu, Apr 18, 2024 at 11:19 AM Danny Cranmer 
>>>>> wrote:
>>>>> 
>>>>>> Hi everyone,
>>>>>> 
>>>>>> Please review and vote on the release candidate #1 for the version
>>>> 3.2.0,
>>>>>> as follows:
>>>>>> [ ] +1, Approve the release
>>>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>>>> 
>>>>>> This release supports Flink 1.18 and 1.19.
>>>>>> 
>>>>>> The complete staging area is available for your review, which includes:
>>>>>> * JIRA release notes [1],
>>>>>> * the official Apache source release to be deployed to dist.apache.org
>>>>>> [2], which are signed with the key with fingerprint 125FD8DB [3],
>>>>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>>>>> * source code tag v3.2.0-rc1 [5],
>>>>>> * website pull request listing the new release [6].
>>>>>> * CI run of tag [7].
>>>>>> 
>>>>>> The vote will be open for at least 72 hours. It is adopted by majority
>>>>>> approval, with at least 3 PMC affirmative votes.
>>>>>> 
>>>>>> Thanks,
>>>>>> Danny
>>>>>> 
>>>>>> [1]
>>>>>> 
>>>>> 
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353143
>>>>>> [2]
>>>>>> 
>>>>> 
>>>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-jdbc-3.2.0-rc2
>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>>>>> [4]
>>>>>> 
>>>> https://repository.apache.org/content/repositories/orgapacheflink-1718/
>>>>>> [5]
>>>>> https://github.com/apache/flink-connector-jdbc/releases/tag/v3.2.0-rc2
>>>>>> [6] https://github.com/apache/flink-web/pull/734
>>>>>> [7]
>>>>> https://github.com/apache/flink-connector-jdbc/actions/runs/8736019099
>>>>>> 
>>>>> 
>>>> 
>> 
>> 



Re: [DISCUSS] Add Flink CDC Channel to Apache Flink Slack Workspace

2024-06-03 Thread Leonard Xu
I’ve created flink-cdc channel in Apache Flink Slack Workspace via 
https://issues.apache.org/jira/browse/FLINK-35514 
<https://issues.apache.org/jira/browse/FLINK-35514>

Best,
Leonard

> 2024年5月29日 下午9:53,Ahmed Hamdy  写道:
> 
> Thanks Zhongqiang, +1 for sure.
> Best Regards
> Ahmed Hamdy
> 
> 
> On Wed, 29 May 2024 at 13:48, ConradJam  wrote:
> 
>> +1 best
>> 
>> Hang Ruan  于2024年5月29日周三 11:28写道:
>> 
>>> Hi, zhongqiang.
>>> 
>>> Thanks for the proposal. +1 for it.
>>> 
>>> Best,
>>> Hang
>>> 
>>> Leonard Xu  于2024年5月28日周二 11:58写道:
>>> 
>>>> 
>>>> Thanks Zhongqiang for the proposal, we need the Channel and I should
>> have
>>>> been created it but not yet, +1 from my side.
>>>> 
>>>> Best,
>>>> Leonard
>>>> 
>>>>> 2024年5月28日 上午11:54,gongzhongqiang  写道:
>>>>> 
>>>>> Hi devs,
>>>>> 
>>>>> I would like to propose adding a dedicated Flink CDC channel to the
>>>> Apache
>>>>> Flink Slack workspace.
>>>>> 
>>>>> Creating a channel focused on Flink CDC will help community members
>>>> easily
>>>>> find previous discussions
>>>>> and target new discussions and questions to the correct place. Flink
>>> CDC
>>>> is
>>>>> a sufficiently distinct component
>>>>> within the Apache Flink ecosystem, and having a dedicated channel
>> will
>>>> make
>>>>> it viable and useful for
>>>>> those specifically working with or interested in this technology.
>>>>> 
>>>>> Looking forward to your feedback and support on this proposal.
>>>>> 
>>>>> 
>>>>> Best,
>>>>> Zhongqiang Gong
>>>> 
>>>> 
>>> 
>> 
>> 
>> --
>> Best
>> 
>> ConradJam
>> 



<    1   2   3   4   5   6   7   >