Re: svn commit: r1752972 - in /ofbiz/trunk/applications: accounting/config/AccountingUiLabels.xml order/template/return/QuickReturn.ftl party/template/party/EditGiftCard.ftl party/template/party/profi

[Vikas Mayur]

Just for a cosmetic and trivial (JIRA issue indicates that) change loosing
the translation to 15 odd languages, is it desirable? It might be years
effort to have the label defined in those languages.


Regards
Vikas

On Sat, Jul 16, 2016 at 9:22 AM,  wrote:

> Author: pranayp
> Date: Sat Jul 16 14:22:18 2016
> New Revision: 1752972
>
> URL: http://svn.apache.org/viewvc?rev=1752972&view=rev
> Log:
> [OFBIZ-7707] Improved payment method information UI on party profile
> screen for creating new payment methods. Thanks Chandan Khandelwal for the
> contribution.
>
> Modified:
> ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
> ofbiz/trunk/applications/order/template/return/QuickReturn.ftl
> ofbiz/trunk/applications/party/template/party/EditGiftCard.ftl
>
> ofbiz/trunk/applications/party/template/party/profileblocks/PaymentMethods.ftl
>
> Modified: ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml?rev=1752972&r1=1752971&r2=1752972&view=diff
>
> ==
> --- ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
> (original)
> +++ ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml Sat
> Jul 16 14:22:18 2016
> @@ -3555,6 +3555,18 @@
>  æ–°å»ºæˆ æœ¬ç»„ä»¶è®¡ç®—
>  æ–°å»ºæˆ æœ¬å…ƒä»¶è¨ˆç®—
>  
> +
> +Create Credit Card
> +कॠरेडिट कारॠड
> बनाठठ
> +
> +
> +Create EFT Account
> +ईठफ़टी(EFT) खाता
> बनाठठ
> +
> +
> +Create Gift Card
> +उपहार कारॠड
> बनाठठ
> +
>  
>  Berechtigungsfehler: Um
> 'createFixedAssetMaintOrder' auszuführen muss man ACCOUNTING_CREATEUPDATE
> or ACCOUNTING_ADMIN Berechtigungen haben
>  Security Error: to run
> createFixedAssetMaintOrder you must have the ACCOUNTING_CREATEUPDATE or
> ACCOUNTING_ADMIN permission, or the limited ACCOUNTING_ROLE_CREATE
> permission
> @@ -3570,25 +3582,6 @@
>  å®‰å…¨é”™è¯¯ï¼šè¦ è¿
> è¡Œæ–°å»ºå›ºå®šèµ„äº§ç»´ä¿®ä¿ å…»è®¢å
> •(createFixedAssetMaintOrder)ï¼Œä½ 
> 必须有ACCOUNTING_CREATEUPDATE或ACCOUNTING_ADMINæ
> ƒé™ ï¼Œæˆ–è€…å —é™ åˆ¶çš„ACCOUNTING_ROLE_CREATEæ ƒé™ 
>  安全錯誤:è¦
> 執行新建固定資產維修ä¿
> 養訂單(createFixedAssetMaintOrder),ä½ å¿…é 
> ˆæœ‰ACCOUNTING_CREATEUPDATE或ACCOUNTING_ADMIN權é™
> ,æˆ–è€…å —é™ åˆ¶çš„ACCOUNTING_ROLE_CREATEæ¬Šé™ 
>  
> -
> -خلق بطاقة ائتمان
> جديدة
> -Neue Kreditkarte erstellen
> -Create New Credit Card
> -Crear nueva tarjeta de crédito
> -Enregistrer une nouvelle carte de
> crédit
> -नया कॠरेडिट
> कारॠड बनाठठ
> -Creare Nuova Carta Credito
> -æ–°è¦ ã‚¯ãƒ¬ã‚¸ãƒƒãƒˆã‚«ãƒ¼ãƒ‰ã‚’ä½œæˆ
> 
> -Nieuwe kredietkaart aanmaken
> -Criar Novo Cartão de Crédito
> ->Criar Novo Cartão de Crédito
> -Creaza Noua Carte de Credit
> -Создать новую кредитную
> карту
> - xml:lang="th">สร้างบัตรเครดิตใหม่
> -Thêm mới Thẻ tín dụng
> -åˆ›å»ºæ–°ä¿¡ç”¨å ¡
> -æ–°å»ºæ–°ä¿¡ç”¨å ¡
> -
>  
>  خلق د٠عة ايداع جديدة
>  Neue Einzahlung
> @@ -3637,25 +3630,6 @@
>  为财务账户新建存款å
> •ï¼š${finAccount.finAccountName} [${finAccountId}]
>   xml:lang="zh-TW">為財務帳戶新建存款單:${finAccount.finAccountName}
> [${finAccountId}]
>  
> -
> -خلق حساب EFT جديد
> -Neue Bankverbindung erstellen
> -Create New EFT Account
> -Crear una nueva cuenta EFT
> -Enregistrer un nouveau compte de virement
> électronique
> -नया  ईठफ़टी(EFT)
> खाता बनाठठ
> -Creare Nuovo Conto EFT
> -æ–°è¦ é›»å­ å
> –引(EFT)ã‚¢ã‚«ã‚¦ãƒ³ãƒˆã‚’ä½œæˆ 
> -Nieuwe bankrekening aanmaken
> -Criar Nova Conta EFT
> ->Criar Nova Conta EFT
> -Creaza un Cont nou EFT
> -Создать новый банковÑ
> кий Ñ Ñ‡ÐµÑ‚
> -สร้างบัà¸
> ชีธนาคารใหม่
> -Tạo mới tà i khoản EFT
> -åˆ›å»ºæ–°ç”µå­ èµ„é‡‘è½¬è´¦
> -æ–°å»ºæ–°é›»å­ è³‡é‡‘è½‰å¸³
> -
>  
>  خلق حساب مالي جديد
>  Neues Finanzkonto erstellen
> @@ -3679,24 +3653,6 @@
>  新建财务账目对账
>  æ–°å»ºè²¡å‹™å¸³ç›®å° å¸³
>  
> -
> -خلق بطاقة هدية جديدة
> -Neuen Gutschein erstellen
> -Create New Gift Card
> -Crear nuevo certificado de regalo
> -Créer une nouvelle carte cadeau
> - 

Naming pattern of test definition files

[Vikas Mayur]

Hi,

The test definition files name is not consistent throughout the  
project. Some of the files name is all lowercase and others have camel  
case pattern.


I think we can follow the pattern used in service definition files.

The files under accounting/testdef are

accountingtests.xml
invoicetests.xml
paymenttests.xml
fixedassettests.xml

and would be (after this change)

tests.xml (generic test)
tests_invoice.xml (tests specific to invoices)
tests_payment.xml (tests specific to payments)
tests_fixedasset.xml (tests specific to fixed assets)
etc..

Any thoughts?

Vikas



smime.p7s
Description: S/MIME cryptographic signature

Re: Naming pattern of test definition files

[Vikas Mayur]

Yes but the definition and implementation of a test need two separate  
files. Same is true for a service except the entity-auto feature.


There is an example btw.

party/script/org/ofbiz/party/test/PartyTests.xml
party/testdef/PartyTests.xml

Both of files above reside in different folders in the structure and  
thus there purpose is obvious but still it is very useful to identify  
the purpose of the file when you do lookup in the editor


and I think it is far easier to refer a test definition file if we  
follow the pattern applied to services.


Exceptions are always there but I think they have their own advantages  
if it helps in making an easier reference to a file in this case or  
any thing else.


Vikas

On Dec 30, 2009, at 1:54 PM, Jacques Le Roux wrote:

I was for the  tests-*.xml type of file because it was consistent  
with services defintions files names. But I should say that I don't  
like to have dashes and underscores in names at large (should I say  
that it remains me my 1st and only short experience with Cobol 25  
years ago ). It would be even easier to have camel-cased and an  
upper-case first letter almost everywhere it makes sense (of course  
keeping uppercase for static var and camel-cased and a lower-case  
first letter for methods, and anyway Sun conventions for Java  
languages). Then you don't have to guess about how to write a name.


So +1 for David's proposition.

Jacques

From: "David E Jones" 


Actually, most XML files in OFBiz these days (with just a few  
exceptions) follow a patterns like:


*Services.xml
*Forms.xml
*Screens.xml
*Data.xml
... etc

By that pattern the test files should be *Tests.xml, with the rest  
of the file camel-cased and an upper-case first letter.


-David


On Dec 29, 2009, at 6:44 PM, David E Jones wrote:



Why not camel case them like most other files?

-David


On Dec 29, 2009, at 1:05 PM, Bilgin Ibryam wrote:


Vikas Mayur wrote:

Hi,

The test definition files name is not consistent throughout the  
project. Some of the files name is all lowercase and others have  
camel case pattern.


I think we can follow the pattern used in service definition  
files.


The files under accounting/testdef are

accountingtests.xml
invoicetests.xml
paymenttests.xml
fixedassettests.xml

and would be (after this change)

tests.xml (generic test)
tests_invoice.xml (tests specific to invoices)
tests_payment.xml (tests specific to payments)
tests_fixedasset.xml (tests specific to fixed assets)
etc..

Any thoughts?

Vikas


+ 1 for a naming pattern. The above proposal is fine for me.

Bilgin









smime.p7s
Description: S/MIME cryptographic signature

Actual completion date of a fixed asset maintenance

[Vikas Mayur]

Hi Devs,

In revision 912532 I have introduced an automated test
testUpdateFixedAssetMaintAndWorkEffortComplete for testing the process of
updating a fixed asset maintenance. In the commit I have also removed
WorkEffort.actualCompletionDate from the previous tests as this newly added
test uses the same maintenance data created by previous tests.

This test pass only after I removed actualCompletionDate as mentioned above.

Is there any business process/scenario in assetmaint application where an
admin user creates a maintenance along with actualCompletionDate of the
maintenance?

In my opinion actualCompletionDate of maintenance should only be speficied
when the maintenance is completed and not when maintenance is intially
created.

Please share your thoughts.

Thanks
Vikas

Re: svn commit: r930470 - /ofbiz/trunk/framework/entity/data/TenantDemoData.xml

[Vikas Mayur]

+1

Vikas

On Sun, Apr 4, 2010 at 12:03 AM, BJ Freeman  wrote:

> how about put a link to the wiki page
>
> =
> BJ Freeman
> http://bjfreeman.elance.com
> Strategic Power Office with Supplier Automation <
> http://www.businessesnetwork.com/automation/viewforum.php?f=93>
> Specialtymarket.com 
>
> Systems Integrator-- Glad to Assist
>
> Chat  Y! messenger: bjfr33man
> Linkedin
> <
> http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
> >
>
>
> adri...@apache.org sent the following on 4/2/2010 9:41 PM:
> > Author: adrianc
> > Date: Sat Apr  3 04:41:21 2010
> > New Revision: 930470
> >
> > URL: http://svn.apache.org/viewvc?rev=930470&view=rev
> > Log:
> > Changed a demo data comment to help clear up some confusion.
> >
> > Modified:
> > ofbiz/trunk/framework/entity/data/TenantDemoData.xml
> >
> > Modified: ofbiz/trunk/framework/entity/data/TenantDemoData.xml
> > URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/data/TenantDemoData.xml?rev=930470&r1=930469&r2=930470&view=diff
> >
> ==
> > --- ofbiz/trunk/framework/entity/data/TenantDemoData.xml (original)
> > +++ ofbiz/trunk/framework/entity/data/TenantDemoData.xml Sat Apr  3
> 04:41:21 2010
> > @@ -18,9 +18,7 @@ specific language governing permissions
> >  under the License.
> >  -->
> >  
> > -
> > +
> >  
> >   >  jdbcUri="jdbc:derby:ofbiz_DEMO1;create=true"
> jdbcUsername="ofbiz" jdbcPassword="ofbiz"/>
> >
> >
> >
>
>
>

Re: [VOTE] [BRANCH] Creation of the Release Branch "release10.04"

[Vikas Mayur]

+1

Regards
Vikas

On Wed, Apr 28, 2010 at 1:40 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxmedia.com> wrote:

> This is the vote thread to create a new release branch (not a release yet)
> named "release10.04".
> This branch will represent a feature freeze and releases will be created
> over time out of it: all the commits in this  branch will be for bug fixes
> only, no new features.
>
> Vote:
>
> [ +1] create the branch "release10.04"
> [ -1] do not create the branch
>
> We will use the same rules for votes on releases (vote passes if there are
> more binding +1 than -1 and if there are at least 3 binding +1)
> For more details about this process please read this
> http://www.apache.org/foundation/voting.html
>
> Kind Regards,
>
> Jacopo
>

Re: New branch is now available for upcoming releases of 10.04 series

[Vikas Mayur]

Thanks Jacopo for all of your hard work to make it happen.

Btw I am not sure if this is a good question to you (and others of course)
about commit policy to the release branch.

We all know that the main idea behind the release branch is to provide a
more stable version of OFBiz.

I was just wondering if we could also change the commit policy to back port
unit test besides bug fixes.

This way there would be more code coverage with the additional unit tests
resulted by backporting to the release branch.

I am sorry if this has been already discussed in past.

Regards
Vikas



On Sat, May 1, 2010 at 1:28 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxmedia.com> wrote:

> The new release branch "10.04" is now available here:
>
> http://svn.apache.org/repos/asf/ofbiz/branches/release10.04
>
> Checkout instructions are, as usual, here:
> https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Source+Repository+and+Access
>
> There is now a new version "Release Branch 10.04" in Jira that can be used
> to mark Jira tickets that contain patches (or bug reports) specifically
> addressed to this branch.
>
> We will only accept bug fixes for this branch and we will issue official
> releases over time (tentatively every quarter).
>
> To the whole community: please help to stabilize the branch with tests, bug
> reports and fixes; the quality of the upcoming releases in the 10.04 series
> will be determined by the activity and contribution of the community.
>
> Kind regards,
>
> Jacopo
>
>

Re: New branch is now available for upcoming releases of 10.04 series

[Vikas Mayur]

Do we need any formal vote procedure to conclude whether we should backport
unit test or not?

Regards
Vikas

On Sat, May 1, 2010 at 9:09 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxmedia.com> wrote:

> This looks like a good idea to me and I don't see why we should not allow
> to backport automated tests.
>
> Jacopo
>
> On May 1, 2010, at 10:59 AM, Vikas Mayur wrote:
>
> > Thanks Jacopo for all of your hard work to make it happen.
> >
> > Btw I am not sure if this is a good question to you (and others of
> course)
> > about commit policy to the release branch.
> >
> > We all know that the main idea behind the release branch is to provide a
> > more stable version of OFBiz.
> >
> > I was just wondering if we could also change the commit policy to back
> port
> > unit test besides bug fixes.
> >
> > This way there would be more code coverage with the additional unit tests
> > resulted by backporting to the release branch.
> >
> > I am sorry if this has been already discussed in past.
> >
> > Regards
> > Vikas
> >
> >
> >
> > On Sat, May 1, 2010 at 1:28 PM, Jacopo Cappellato <
> > jacopo.cappell...@hotwaxmedia.com> wrote:
> >
> >> The new release branch "10.04" is now available here:
> >>
> >> http://svn.apache.org/repos/asf/ofbiz/branches/release10.04
> >>
> >> Checkout instructions are, as usual, here:
> >>
> https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Source+Repository+and+Access
> >>
> >> There is now a new version "Release Branch 10.04" in Jira that can be
> used
> >> to mark Jira tickets that contain patches (or bug reports) specifically
> >> addressed to this branch.
> >>
> >> We will only accept bug fixes for this branch and we will issue official
> >> releases over time (tentatively every quarter).
> >>
> >> To the whole community: please help to stabilize the branch with tests,
> bug
> >> reports and fixes; the quality of the upcoming releases in the 10.04
> series
> >> will be determined by the activity and contribution of the community.
> >>
> >> Kind regards,
> >>
> >> Jacopo
> >>
> >>
>
>

Re: New branch is now available for upcoming releases of 10.04 series

[Vikas Mayur]

Yeah it looks evident from the discussion that most of the people are  
in favor of backporting unit tests (Thanks Everyone!)


and it is good to assume that one can backport a unit test from now  
onwards, right?


I am sorry but I thought generally changes in policy are concluded  
through voting.


Regards
Vikas

On May 3, 2010, at 4:09 PM, Scott Gray wrote:

I don't think anybody is going to be against adding tests and it  
shouldn't need to be discussed first.


BTW, we still need to ask Infra to get buildbot running the 10.04  
tests if anyone wants to volunteer.


Regards
Scott

On 3/05/2010, at 10:05 PM, Jacques Le Roux wrote:

I don't think so, tests could be backported IMO. Maybe discussed  
for each case on dev ML before?


Jacques

From: "Vikas Mayur" 
Do we need any formal vote procedure to conclude whether we should  
backport

unit test or not?
Regards
Vikas
On Sat, May 1, 2010 at 9:09 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxmedia.com> wrote:
This looks like a good idea to me and I don't see why we should  
not allow

to backport automated tests.

Jacopo

On May 1, 2010, at 10:59 AM, Vikas Mayur wrote:


Thanks Jacopo for all of your hard work to make it happen.

Btw I am not sure if this is a good question to you (and others of

course)

about commit policy to the release branch.

We all know that the main idea behind the release branch is to  
provide a

more stable version of OFBiz.

I was just wondering if we could also change the commit policy  
to back

port

unit test besides bug fixes.

This way there would be more code coverage with the additional  
unit tests

resulted by backporting to the release branch.

I am sorry if this has been already discussed in past.

Regards
Vikas



On Sat, May 1, 2010 at 1:28 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxmedia.com> wrote:


The new release branch "10.04" is now available here:

http://svn.apache.org/repos/asf/ofbiz/branches/release10.04

Checkout instructions are, as usual, here:


https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Source+Repository+and+Access


There is now a new version "Release Branch 10.04" in Jira that  
can be

used
to mark Jira tickets that contain patches (or bug reports)  
specifically

addressed to this branch.

We will only accept bug fixes for this branch and we will issue  
official

releases over time (tentatively every quarter).

To the whole community: please help to stabilize the branch  
with tests,

bug
reports and fixes; the quality of the upcoming releases in the  
10.04

series
will be determined by the activity and contribution of the  
community.


Kind regards,

Jacopo

Re: if purchase shipment received is more then ordered no invoice created.

[Vikas Mayur]

Hans,

In this particular case you just need to force the system to set the  
shipment status to Received i.e PURCH_SHIP_RECEIVED


You can do this by selecting the checkbox "Set Shipment as Received"  
on Receive Inventory screen.


This will change the quantity on OrderItem and ShipmentItem to the  
quantity received and will create the invoice for the actual quantity  
received.


Regards
Vikas

On May 3, 2010, at 12:19 PM, Hans Bakker wrote:


For the purchase order specialist.

When a purchase order is created and approved and the related shipment
is sent to the appropriate warehouse there is a problem when the
quantities are more than was ordered: no invoice is generated.

In the ShipmentServices.java when the quantities are not the same in  
the

service updatePurchaseShipmentFromReceipt in line 916 the service will
successfully return and but will not update the shipment status and no
invoice will be created.

Removing the lines 916 and 917 will fix the invoice creation problem,
however why are these 2 lines in here?

Any specialist in this area can help me out on this?

Thanks in advance,

regards,
Hans

--
Ofbiz on twitter: http://twitter.com/apache_ofbiz
Myself on twitter: http://twitter.com/hansbak
Antwebsystems.com: Quality services for competitive rates.

Re: svn commit: r943417 - in /ofbiz/trunk/applications/accounting: script/org/ofbiz/accounting/payment/PaymentServices.xml servicedef/secas_invoice.xml servicedef/secas_payment.xml servicedef/services

[Vikas Mayur]

Hi Hans,

Isn't the following code at line 732 in  
InvoiceServices.createInvoiceForOrder is doing the same thing?


[snip]

// check for previous order payments
List orderPaymentPrefs =  
delegator.findByAnd("OrderPaymentPreference",  
UtilMisc.toMap("orderId", orderId));
List currentPayments =  
FastList.newInstance();

for (GenericValue paymentPref : orderPaymentPrefs) {
List payments =  
paymentPref.getRelated("Payment");

currentPayments.addAll(payments);
}
// apply these payments to the invoice if they have any  
remaining amount to apply

for (GenericValue payment : currentPayments) {
BigDecimal notApplied =  
PaymentWorker.getPaymentNotApplied(payment);

if (notApplied.signum() > 0) {
Map appl = FastMap.newInstance();
appl.put("paymentId", payment.get("paymentId"));
appl.put("invoiceId", invoiceId);
appl.put("billingAccountId", billingAccountId);
appl.put("amountApplied", notApplied);
appl.put("userLogin", userLogin);
Map createPayApplResult =  
dispatcher.runSync("createPaymentApplication", appl);

if (ServiceUtil.isError(createPayApplResult)) {
return  
ServiceUtil 
.returnError 
(UtilProperties 
.getMessage 
(resource,"AccountingErrorCreatingInvoiceFromOrder",locale), null,  
null, createPayApplResult);

}
}

Regards
Vikas

On May 12, 2010, at 2:50 PM, hans...@apache.org wrote:


Author: hansbak
Date: Wed May 12 09:20:44 2010
New Revision: 943417

URL: http://svn.apache.org/viewvc?rev=943417&view=rev
Log:
if an invoice is approved or a payment is set to sent or received  
this service will try to find a matching payment/invoice and when  
found create the payment application


Modified:
   ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ 
payment/PaymentServices.xml

   ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml
   ofbiz/trunk/applications/accounting/servicedef/secas_payment.xml
   ofbiz/trunk/applications/accounting/servicedef/services_payment.xml

Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/ 
accounting/payment/PaymentServices.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml?rev=943417&r1=943416&r2=943417&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ 
payment/PaymentServices.xml (original)
+++ ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ 
payment/PaymentServices.xml Wed May 12 09:20:44 2010

@@ -814,4 +814,79 @@ under the License.
name="updatePayment"/>
name="paymentId"/>


-
\ No newline at end of file
+
+short-description="Create a payment application if either the  
invoice of payment could be found">

+
+
+
+class-name="org.ofbiz.accounting.invoice.InvoiceWorker" ret- 
field="invoiceTotal">

+
+
+name="Payment">

+
+value="PMNT_CONFIRMED" operator="not-equals"/>
+from-field="invoice.partyId" operator="equals"/>
+field="invoice.partyIdFrom" operator="equals"/>
+field="invoiceTotal" operator="equals"/>

+
+
+
+
+
+name="PaymentApplication">
+field="payments[0].paymentId"/>

+
+
+field="payments[0].paymentId"/>
+field="parameters.invoiceId"/>
+field="invoiceTotal"/>

+
+
+
+
+
+
+
+
+name="Invoice">

+
+value="INVOICE_READY" operator="not-equals"/>
+value="INVOICE_PAID" operator="not-equals"/>
+value="INVOICE_CANCELLED" operator="not-equals"/>
+value="INVOICE_WRITEOFF" operator="not-equals"/>
+from-field="payment.partyIdTo"/>
+field="payment.partyIdFrom"/>

+
+
+
+
+name="getInvoiceTotal" class- 
name="org.ofbiz.accounting.invoice.InvoiceWorker" ret- 
field="invoiceTotal">

+
+
+field="invoiceTotal" to-field="payment.amount">
+fie

Re: svn commit: r943417 - in /ofbiz/trunk/applications/accounting: script/org/ofbiz/accounting/payment/PaymentServices.xml servicedef/secas_invoice.xml servicedef/secas_payment.xml servicedef/services

[Vikas Mayur]

Hi Hans,

Let me elaborate a little more if that wasn't helpful.

I see two commits in succession from you related to purchase orders.

1. Create Payment when a purchase order is approved.

2. Apply payment when an invoice is approved or payment is sent/ 
received. (though only payment sent is applicable in case of purchase  
invoice so the eca on payment received is not required)


I know both process are configurable at this stage but still I would  
like to understand the objective of this commit.


My understanding is that once you receive the shipment, it will create  
the invoice through service createInvoiceFromShipment which


will eventually call createInvoiceForOrder.

In my last reply I posted the specific code snippet which apply the  
payments to the invoice in a better way then it is done here.


If you are following the same way to generate the purchase invoice  
then I think the code in this commit is redundant because the payment  
application


is already handle in the service createInvoiceForOrder and the payment  
will be already applied to the invoice in process status and changing  
the status


of the invoice or payment later on will not have any effect.

Moreover I agree with Scott because this implementation takes a  
guessing path to determine the invoice to be used for payment  
application.


Looking forward to see your reply!

Regards
Vikas



On May 13, 2010, at 11:38 PM, Vikas Mayur wrote:


Hi Hans,

Isn't the following code at line 732 in  
InvoiceServices.createInvoiceForOrder is doing the same thing?


[snip]

   // check for previous order payments
   List orderPaymentPrefs =  
delegator.findByAnd("OrderPaymentPreference",  
UtilMisc.toMap("orderId", orderId));
   List currentPayments =  
FastList.newInstance();

   for (GenericValue paymentPref : orderPaymentPrefs) {
   List payments =  
paymentPref.getRelated("Payment");

   currentPayments.addAll(payments);
   }
   // apply these payments to the invoice if they have any  
remaining amount to apply

   for (GenericValue payment : currentPayments) {
   BigDecimal notApplied =  
PaymentWorker.getPaymentNotApplied(payment);

   if (notApplied.signum() > 0) {
   Map appl = FastMap.newInstance();
   appl.put("paymentId", payment.get("paymentId"));
   appl.put("invoiceId", invoiceId);
   appl.put("billingAccountId", billingAccountId);
   appl.put("amountApplied", notApplied);
   appl.put("userLogin", userLogin);
   Map createPayApplResult =  
dispatcher.runSync("createPaymentApplication", appl);

   if (ServiceUtil.isError(createPayApplResult)) {
   return  
ServiceUtil 
.returnError 
(UtilProperties 
.getMessage 
(resource,"AccountingErrorCreatingInvoiceFromOrder",locale), null,  
null, createPayApplResult);

   }
   }

Regards
Vikas

On May 12, 2010, at 2:50 PM, hans...@apache.org wrote:


Author: hansbak
Date: Wed May 12 09:20:44 2010
New Revision: 943417

URL: http://svn.apache.org/viewvc?rev=943417&view=rev
Log:
if an invoice is approved or a payment is set to sent or received  
this service will try to find a matching payment/invoice and when  
found create the payment application


Modified:
  ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ 
payment/PaymentServices.xml

  ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml
  ofbiz/trunk/applications/accounting/servicedef/secas_payment.xml
  ofbiz/trunk/applications/accounting/servicedef/services_payment.xml

Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/ 
accounting/payment/PaymentServices.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml?rev=943417&r1=943416&r2=943417&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ 
payment/PaymentServices.xml (original)
+++ ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ 
payment/PaymentServices.xml Wed May 12 09:20:44 2010

@@ -814,4 +814,79 @@ under the License.
   name="updatePayment"/>
   name="paymentId"/>

   
-
\ No newline at end of file
+
+short-description="Create a payment application if either the  
invoice of payment could be found">

+
+name="Invoice"/>

+
+class-name="org.ofbiz.accounting.invoice.InvoiceWorker" ret- 
field="invoiceTotal">

+
+
+name=&

Re: Account Locking facility in ofbiz

[Vikas Mayur]

This feature do exists in OFBiz.

Please refer to following property in file framework/security/config/ 
security.properties


# -- disable the account for this many minutes (if 0, then  
indefinate) --

login.disable.minutes=5


Regards
Vikas

On May 18, 2010, at 3:19 PM, gopal123 wrote:



Hi.
Is there any account locking facility in ofbiz?
Actually i want that if a user enters invalid login credentials for  
more
than thrice the account should  be locked.How can i achieve this? 
Please help

me out...
Thanks in advance.
--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Account-Locking-facility-in-ofbiz-tp2221005p2221005.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Re: svn commit: r943417 - in /ofbiz/trunk/applications/accounting: script/org/ofbiz/accounting/payment/PaymentServices.xml servicedef/secas_invoice.xml servicedef/secas_payment.xml servicedef/services

[Vikas Mayur]

Hans,

Thanks for your inputs. Make lot of sense now.

Regards
Vikas

On May 16, 2010, at 12:52 PM, Hans Bakker wrote:


Hi Vikas,

I agree completely with you that in the case of the purchase order  
only,

the second commit is not required and is a duplication of the code you
were referring to.

The second commit however twas meant to be more general, We often use
the payment and invoice without the order and would like at least that
the application is created automatically of the amounts that match  
what

happens in most cases. Therefore also the seca for payment received.

Regards,
Hans

On Fri, 2010-05-14 at 23:25 +0530, Vikas Mayur wrote:

Hi Hans,

Let me elaborate a little more if that wasn't helpful.

I see two commits in succession from you related to purchase orders.

1. Create Payment when a purchase order is approved.

2. Apply payment when an invoice is approved or payment is sent/
received. (though only payment sent is applicable in case of purchase
invoice so the eca on payment received is not required)

I know both process are configurable at this stage but still I would
like to understand the objective of this commit.

My understanding is that once you receive the shipment, it will  
create

the invoice through service createInvoiceFromShipment which

will eventually call createInvoiceForOrder.

In my last reply I posted the specific code snippet which apply the
payments to the invoice in a better way then it is done here.

If you are following the same way to generate the purchase invoice
then I think the code in this commit is redundant because the payment
application

is already handle in the service createInvoiceForOrder and the  
payment

will be already applied to the invoice in process status and changing
the status

of the invoice or payment later on will not have any effect.

Moreover I agree with Scott because this implementation takes a
guessing path to determine the invoice to be used for payment
application.

Looking forward to see your reply!

Regards
Vikas



On May 13, 2010, at 11:38 PM, Vikas Mayur wrote:


Hi Hans,

Isn't the following code at line 732 in
InvoiceServices.createInvoiceForOrder is doing the same thing?

[snip]

  // check for previous order payments
  List orderPaymentPrefs =
delegator.findByAnd("OrderPaymentPreference",
UtilMisc.toMap("orderId", orderId));
  List currentPayments =
FastList.newInstance();
  for (GenericValue paymentPref : orderPaymentPrefs) {
  List payments =
paymentPref.getRelated("Payment");
  currentPayments.addAll(payments);
  }
  // apply these payments to the invoice if they have any
remaining amount to apply
  for (GenericValue payment : currentPayments) {
  BigDecimal notApplied =
PaymentWorker.getPaymentNotApplied(payment);
  if (notApplied.signum() > 0) {
  Map appl = FastMap.newInstance();
  appl.put("paymentId", payment.get("paymentId"));
  appl.put("invoiceId", invoiceId);
  appl.put("billingAccountId", billingAccountId);
  appl.put("amountApplied", notApplied);
  appl.put("userLogin", userLogin);
  Map createPayApplResult =
dispatcher.runSync("createPaymentApplication", appl);
  if (ServiceUtil.isError(createPayApplResult)) {
  return
ServiceUtil
.returnError
(UtilProperties
.getMessage
(resource,"AccountingErrorCreatingInvoiceFromOrder",locale), null,
null, createPayApplResult);
  }
  }

Regards
Vikas

On May 12, 2010, at 2:50 PM, hans...@apache.org wrote:


Author: hansbak
Date: Wed May 12 09:20:44 2010
New Revision: 943417

URL: http://svn.apache.org/viewvc?rev=943417&view=rev
Log:
if an invoice is approved or a payment is set to sent or received
this service will try to find a matching payment/invoice and when
found create the payment application

Modified:
 ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/
payment/PaymentServices.xml
 ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml
 ofbiz/trunk/applications/accounting/servicedef/secas_payment.xml
 ofbiz/trunk/applications/accounting/servicedef/ 
services_payment.xml


Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/
accounting/payment/PaymentServices.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml?rev=943417&r1=943416&r2=943417&view=diff
=
=
=
=
=
=
=
=
=
= 
= 
===
--- ofbiz/trunk/applications/accounting/script/org/ofbiz/ 
accounting/

payment/PaymentServices.xml (original)
+++ ofbiz/trunk/applications/accounting/script/org/ofbiz/ 
accounting/

Re: Account Locking facility in ofbiz

[Vikas Mayur]

On May 19, 2010, at 10:42 AM, gopal123 wrote:



Thanks a lot Vikas for your co-operation.Actually my account is  
getting

locked after 3 unsuccessful attempts,


This is the default setting for property max.failed.logins in  
security.properties file so this is fine, but of course you can change  
it as your custom needs.



but no messages are displaying like
"Your account has been locked."


If you are testing this on OOTB application then it should be coming  
fine but if you are using custom implementation then you should first  
check your application decorator screen


Looks to me that you have not included the template that renders  
events and error messages.


Refer to screen for an example to build your decorator screen -  
specialpurpose/ecommerce/widget/CommonScreens.xml#main-decorator



Also there is no alert message like "You
have x no. of chances left" are displaying.


This feature does not exists in OFBiz but it should not be difficult  
to implement it.


The successive failed attempts of login are saved in the UserLogin  
entity and you can probably use that counter to show this message on  
this screen.


May be you can consider to contribute it back to the project if you  
are really going to work on this thing.



So can you help me out how to
achieve this or is this present in ofbiz.


HTH

Regards
Vikas


Thanks in advance.
Regards
Gopal
--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Account-Locking-facility-in-ofbiz-tp2221005p286.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Re: svn commit: r946100 - in /ofbiz/trunk/applications/order/widget/ordermgr: CommonScreens.xml QuoteScreens.xml

[Vikas Mayur]

Hi Anil,

I was a bit unsure but based on your suggestion I have migrated all of  
the code to 10.04 branch.


Regards
Vikas

On May 19, 2010, at 10:31 PM, Anil Patel wrote:

I think this commit and r946105, 946108 should be applied to 10.04  
as well.
These commits have no functional changes. They fix permission check  
and decorator screen location issues.


Thanks and Regards
Anil Patel
HotWax Media Inc
Find us on the web at www.hotwaxmedia.com or Google Keyword "ofbiz"

On May 19, 2010, at 6:04 AM, m...@apache.org wrote:


Author: mor
Date: Wed May 19 10:04:17 2010
New Revision: 946100

URL: http://svn.apache.org/viewvc?rev=946100&view=rev
Log:
Removed an unnecessary decorator screen CommonQuotePriceDecorator  
related to Order Manager Quotes. The only difference between this  
and screen
CommonQuoteDecorator is that the the former has a permission check  
for ORDERMGR__QUOTE_PRICE where as latter has a check for permission
ORDERMGR_VIEW. The permission ORDERMGR_QUOTE_PRICE is though  
already checked at menu level and hence is not required explicity

at the decorator level.

Modified:
  ofbiz/trunk/applications/order/widget/ordermgr/CommonScreens.xml
  ofbiz/trunk/applications/order/widget/ordermgr/QuoteScreens.xml

Re: svn commit: r943802 - /ofbiz/trunk/applications/party/widget/partymgr/CommonScreens.xml

[Vikas Mayur]

What is the real benefit of this decorator screen when we have a  
similar decorator CommonCommunicationEventDecorator present in the  
same file?


The difference b/w these two decorators is just negligible.

The CommonMyCommunicationEventDecorator screen does not have a  
headerItem and a permission check in the "pre-body" section but  
CommonCommunicationEventDecorator screen does have it.


Moreover I do not think it is correct approach to append some funny  
parameter (My) in the URL to determine which decorator to be used.


Regards
Vikas

On May 13, 2010, at 10:36 AM, hans...@apache.org wrote:


Author: hansbak
Date: Thu May 13 05:06:06 2010
New Revision: 943802

URL: http://svn.apache.org/viewvc?rev=943802&view=rev
Log:
fixed email send error reported in issue: 3465

Modified:
   ofbiz/trunk/applications/party/widget/partymgr/CommonScreens.xml

Modified: ofbiz/trunk/applications/party/widget/partymgr/ 
CommonScreens.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/widget/partymgr/CommonScreens.xml?rev=943802&r1=943801&r2=943802&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/party/widget/partymgr/CommonScreens.xml  
(original)
+++ ofbiz/trunk/applications/party/widget/partymgr/CommonScreens.xml  
Thu May 13 05:06:06 2010

@@ -202,6 +202,34 @@ under the License.



+
+
+
+

+
+
+

+
+
+

+
+
+
+
+permission="PARTYMGR"/>

+
+
+name="body"/>

+
+
+$ 
{uiLabelMap.PartyMgrViewPermissionError}

+
+
+
+
+
+
+

Re: svn commit: r950900 - in /ofbiz/branches/release10.04: ./ framework/common/data/GeoData_DE.xml

[Vikas Mayur]

Shouldn't it be reverted in 10.04 and 09.04 as Adam actually fixed the  
issue in trunk r951062?


Regards
Vikas

On Jun 3, 2010, at 1:02 PM, jler...@apache.org wrote:


Author: jleroux
Date: Thu Jun  3 07:32:21 2010
New Revision: 950900

URL: http://svn.apache.org/viewvc?rev=950900&view=rev
Log:
"Applied fix from trunk for revision: 950893"

r950893 | jleroux | 2010-06-03 09:12:39 +0200 (jeu. 03 juin 2010) |  
5 lignes


A patch from Atul Vani for an issue reported by R.S."States of th  
country Germany shows zero results from both webtools and using  
services." (https://issues.apache.org/jira/browse/OFBIZ-3799) -  
OFBIZ-3799


Data to associate the country with states isn't present. This issue  
is with reference to discussion started by R.S. on user-mailing list  
subjected as "StateList"

R.S., thanks for reporting the issue.




Modified:
   ofbiz/branches/release10.04/   (props changed)
   ofbiz/branches/release10.04/framework/common/data/GeoData_DE.xml

Propchange: ofbiz/branches/release10.04/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Jun  3 07:32:21 2010
@@ -1,3 +1,3 @@
/ofbiz/branches/addbirt:831210-885099,885686-886087
/ofbiz/branches/multitenant20100310:921280-927264
-/ofbiz/trunk: 
939988,939990,93,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870
+/ofbiz/trunk: 
939988,939990,93,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893


Modified: ofbiz/branches/release10.04/framework/common/data/ 
GeoData_DE.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/branches/release10.04/framework/common/data/GeoData_DE.xml?rev=950900&r1=950899&r2=950900&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/branches/release10.04/framework/common/data/GeoData_DE.xml  
(original)
+++ ofbiz/branches/release10.04/framework/common/data/GeoData_DE.xml  
Thu Jun  3 07:32:21 2010

@@ -35,4 +35,21 @@ under the License.
geoName="Sachsen" geoTypeId="STATE"/>
geoName="Sachsen-Anhalt" geoTypeId="STATE"/>
geoName="Thüringen" geoTypeId="STATE"/>

-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file

Re: buildbot failure in ASF Buildbot on ofbiz-branch9

[Vikas Mayur]

Is it the same issue or the build actually failed this time?

Regards
Vikas

On Jun 3, 2010, at 9:54 AM, build...@apache.org wrote:

The Buildbot has detected a new failure of ofbiz-branch9 on ASF  
Buildbot.

Full details are available at:
http://ci.apache.org/builders/ofbiz-branch9/builds/4

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: isis_ubuntu

Build Reason:
Build Source Stamp: [branch ofbiz/branches/release09.04] 950868
Blamelist: jleroux

BUILD FAILED: failed compile

sincerely,
-The Buildbot

Re: svn commit: r950900 - in /ofbiz/branches/release10.04: ./ framework/common/data/GeoData_DE.xml

[Vikas Mayur]

Thanks Jacques!

Regards
Vikas

On Jun 4, 2010, at 9:55 PM, Jacques Le Roux wrote:

Thanks for the reminder Vikas, done at r951476 in R10.04, r951475 in  
R9.04


Actually I should not have backported them in 1st place, but now  
it's ok


Jacques

From: "Vikas Mayur" 
Shouldn't it be reverted in 10.04 and 09.04 as Adam actually fixed  
the  issue in trunk r951062?


Regards
Vikas

On Jun 3, 2010, at 1:02 PM, jler...@apache.org wrote:


Author: jleroux
Date: Thu Jun  3 07:32:21 2010
New Revision: 950900

URL: http://svn.apache.org/viewvc?rev=950900&view=rev
Log:
"Applied fix from trunk for revision: 950893"

r950893 | jleroux | 2010-06-03 09:12:39 +0200 (jeu. 03 juin 2010)  
|  5 lignes


A patch from Atul Vani for an issue reported by R.S."States of th   
country Germany shows zero results from both webtools and using   
services." (https://issues.apache.org/jira/browse/OFBIZ-3799) -   
OFBIZ-3799


Data to associate the country with states isn't present. This  
issue  is with reference to discussion started by R.S. on user- 
mailing list  subjected as "StateList"

R.S., thanks for reporting the issue.




Modified:
  ofbiz/branches/release10.04/   (props changed)
  ofbiz/branches/release10.04/framework/common/data/GeoData_DE.xml

Propchange: ofbiz/branches/release10.04/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Jun  3 07:32:21 2010
@@ -1,3 +1,3 @@
/ofbiz/branches/addbirt:831210-885099,885686-886087
/ofbiz/branches/multitenant20100310:921280-927264
-/ofbiz/trunk:  
939988,939990,93,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870
+/ofbiz/trunk:  
939988,939990,93,940025,940053,940234,940248,940309,940401,940410,940425,940779,940815,940849,941007,941047,941109,941177,941199,941261,941440,941600,941999,942084,942406,942414,942671,942883-942884,943168,943271-943272,944614,944621,944623,944647,944669,944797,944895,945010,945018,945026,945118,945573,945578,945580,945582,945610,945619,945848,945852,945857,946061,946066,946073,946075,946080,946309,946313,946320,946322,946596,947004-947005,947392,947424,947679,947988,948017,948694,949174,949710,949844,950866,950870,950893


Modified: ofbiz/branches/release10.04/framework/common/data/  
GeoData_DE.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/branches/release10.04/framework/common/data/GeoData_DE.xml?rev=950900&r1=950899&r2=950900&view=diff
= = = = = = = =  
= 
= 

--- ofbiz/branches/release10.04/framework/common/data/ 
GeoData_DE.xml  (original)
+++ ofbiz/branches/release10.04/framework/common/data/ 
GeoData_DE.xml  Thu Jun  3 07:32:21 2010

@@ -35,4 +35,21 @@ under the License.
   geoName="Sachsen" geoTypeId="STATE"/>
   geoName="Sachsen-Anhalt" geoTypeId="STATE"/>
   geoName="Thüringen" geoTypeId="STATE"/>

-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file

Re: buildbot failure in ASF Buildbot on ofbiz-branch9

[Vikas Mayur]

Thanks Adrian for checking. Sorry I think I misunderstood the issue  
with the other one I reported at the same time.


Regards
Vikas

On Jun 4, 2010, at 9:33 PM, Adrian Crum wrote:


I just ran a clean and build on the latest 9.04 - it compiles fine.

-Adrian

On 6/4/2010 8:59 AM, Vikas Mayur wrote:

Is it the same issue or the build actually failed this time?

Regards
Vikas

On Jun 3, 2010, at 9:54 AM, build...@apache.org wrote:

The Buildbot has detected a new failure of ofbiz-branch9 on ASF  
Buildbot.

Full details are available at:
http://ci.apache.org/builders/ofbiz-branch9/builds/4

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: isis_ubuntu

Build Reason:
Build Source Stamp: [branch ofbiz/branches/release09.04] 950868
Blamelist: jleroux

BUILD FAILED: failed compile

sincerely,
-The Buildbot






--
Adrian Crum
Hallmark-Southwest Corporation

Re: Extending a form which uses auto-fields-service

[Vikas Mayur]

To position some of the fields in a separate column you would need to  
explicitly define those fields and with a position attribute on it.


Regards
Vikas

On Jun 24, 2010, at 7:16 PM, Ravindra Mandre wrote:

Yes , I also tried the sort-order but this does not fulfill the  
requirement
, as suppose I want to arrange two fields in a horizontal way , then  
this

does not work . for example  :
A)
firstName
lastName




but sort-order does like this
B)
firstName
lastName

, if there is any other way for doing case A please let me know .

Ravi

On Thu, Jun 24, 2010 at 5:47 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Did you try also sort-order?

Jacques

From: "Ravindra Mandre" 

Yes , when we use auto-fields-service in a form then, this does not  
allow

us
to arrange the fields as we want , means position tag inside the  
field

becomes useless .

Ravi


On Tue, Jun 22, 2010 at 9:58 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

Sorry, it's not related to auto-fields-service. I was able to extend

another form which uses auto-fields-service
I will dig in when I will get time...

Forget it

Jacques

From: "Jacques Le Roux" 

Looks like extending a form which uses auto-fields-service does  
not work



properly. Has someone some experience witht that?

Thanks

Jacques

Re: svn commit: r1061192 - in /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart: ShoppingCart.java ShoppingCartEvents.java product/ProductPromoWorker.java

[Vikas Mayur]

Thanks Chirag!

Improvements committed to trunk in r1061239

Regards
Vikas

On Thu, Jan 20, 2011 at 4:09 PM, Chirag Manocha wrote:

> Hi Vikas,
> I am bit confused with the method addProductPromoCode in ShoppingCart
> class.
> In ShoppingCartEvent you are calling this method on cart object and passing
> the cart object as parameter too.
> There is no need of passing the cart object, you can use keyword this
> instead.
>
> Regards
> --
> Chirag Manocha
> Emforium Software Pvt. Ltd. | ALL-IN Software
> +91-98735-47457 | +91-98263-19099
> Please don't print this Email unless you really need to - this will
> preserve trees on planet earth.
>
>
>
>
> From: m...@apache.org
> To: comm...@ofbiz.apache.org
> Sent: Thursday, January 20, 2011 3:54:21 PM
> Subject: svn commit: r1061192 - in
> /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart:
> ShoppingCart.java ShoppingCartEvents.java product/ProductPromoWorker.java
>
> Author: mor
> Date: Thu Jan 20 10:24:20 2011
> New Revision: 1061192
>
> URL: http://svn.apache.org/viewvc?rev=1061192&view=rev
> Log:
> Bug fix: In a multiple store app now onwards a coupon code belonging to a
> particular store will not be accepted if used on a different store. If user
> attempts to do it, the
> system will notify user that it is an invalid coupon code. Earlier the
> coupon code was accepted but wasn't applied. Also it was preventing the user
> to add
> a correct coupon code.
>
>

Re: svn commit: r1063233 - in /ofbiz/branches/release10.04/applications/product/widget/catalog: CommonScreens.xml ProductScreens.xml

[Vikas Mayur]

Sorry for late reply - Jacques.

It does not relates to a real bug but I think the changes does no harm to
the release either.

is that okay?

Regards
Vikas

On Tue, Jan 25, 2011 at 5:23 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Mmm... is that a bug?
>
> Jacques
>
>
> m...@apache.org wrote:
>
>> Author: mor
>> Date: Tue Jan 25 11:32:24 2011
>> New Revision: 1063233
>>
>> URL: http://svn.apache.org/viewvc?rev=1063233&view=rev
>> Log:
>> Merged from trunk r1063227. Log: Parameterized CommonProductDecorator
>> screen location so that custom apps can override it easily.
>>
>> Modified:
>>
>> ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml
>>
>> ofbiz/branches/release10.04/applications/product/widget/catalog/ProductScreens.xml
>>
>> Modified:
>> ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml
>> URL:
>>
>> http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml?rev=1063233&r1=1063232&r2=1063233&view=diff
>> ==
>> ---
>> ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml
>> (original) +++
>> ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml
>> Tue Jan 25 11:32:24 2011 @@ -48,92 +48,6 @@
>>under the License. 
>>
>>
>> -
>> -
>> -
>> -> map-name="uiLabelMap" global="true"/>
>> -> map-name="uiLabelMap" global="true"/>
>> -> from-field="parameters.productId"/>
>> -
>> -> from-field="product.productName"/>
>> -
>> -
>> -> location="${parameters.mainDecoratorLocation}">
>> -
>> -
>> -
>> -
>> -> permission="CATALOG" action="_VIEW"/>
>> -> field="product"/>
>> -
>> -
>> -
>> -> location="component://product/widget/catalog/CatalogMenus.xml"/>
>> -
>> -
>> -
>> -
>> -
>> -
>> -
>> -
>> -
>> -
>> -> action="_VIEW"/>
>> -
>> -
>> -
>> -
>> -> field="product"/>
>> -
>> -
>> -
>> -> style="h1">${uiLabelMap[labelTitleProperty]} ${uiLabelMap.CommonFor}:
>> ${product.internalName} [${uiLabelMap.CommonId}:${productId}]
>>  ${${extraFunctionName}}
>> -> src="${product.smallImageUrl}" height="40" width="40" url-mode="content"
>> alt="${product.internalName}"/>
>> -
>> -
>> -
>> -
>> -> text="${uiLabelMap.ProductNewProduct}" style="buttontext
>> create"/>
>> -> target="CreateVirtualWithVariantsForm"
>> text="${uiLabelMap.ProductNewVirtualProduct}" style="buttontext create"/>
>> -> target="/ecommerce/control/product" url-mode="inter-app"
>> text="${uiLabelMap.ProductProductPage}" style="buttontext">
>> -> param-name="product_id" from-field="productId"/>
>> -
>> -> target="ProductBarCode.pdf" target-window="_blank"
>> text="${uiLabelMap.ProductBarcode}" style="buttontext">
>> -> param-name="productId"/>
>> -> param-name="productName"/>
>> -
>> -
>> -> target="javascript:expandAll(true);"  text="${uiLabelMap.CommonExpandAll}"
>> style="buttontext expand-all" url-mode="plain"/>
>> -> target="javascript:expandAll(false);" text="${uiLabelMap.CommonCollapseAll}"
>> style="buttontext collapse-all" url-mode="plain"/>
>> -
>> -
>> -
>> -
>> -   

Re: svn commit: r1063233 - in /ofbiz/branches/release10.04/applications/product/widget/catalog: CommonScreens.xml ProductScreens.xml

[Vikas Mayur]

Jacques,

I completely agree with you. Will keep an eye on others response and if
required will revert.

Regards
Vikas

On Sat, Jan 29, 2011 at 3:04 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Vikas,
>
> If nobody see a problem with it and you are sure it's safe, why not...
> Just that it should be considered as really exceptional
>
> Thanks
>
> Jacques
>
> From: "Vikas Mayur" 
>
>  Sorry for late reply - Jacques.
>>
>> It does not relates to a real bug but I think the changes does no harm to
>> the release either.
>>
>> is that okay?
>>
>> Regards
>> Vikas
>>
>> On Tue, Jan 25, 2011 at 5:23 PM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>>  Mmm... is that a bug?
>>>
>>> Jacques
>>>
>>>
>>> m...@apache.org wrote:
>>>
>>>  Author: mor
>>>> Date: Tue Jan 25 11:32:24 2011
>>>> New Revision: 1063233
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1063233&view=rev
>>>> Log:
>>>> Merged from trunk r1063227. Log: Parameterized CommonProductDecorator
>>>> screen location so that custom apps can override it easily.
>>>>
>>>> Modified:
>>>>
>>>>
>>>> ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml
>>>>
>>>>
>>>> ofbiz/branches/release10.04/applications/product/widget/catalog/ProductScreens.xml
>>>>
>>>> Modified:
>>>>
>>>> ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml
>>>> URL:
>>>>
>>>>
>>>> http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml?rev=1063233&r1=1063232&r2=1063233&view=diff
>>>>
>>>> ==
>>>> ---
>>>>
>>>> ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml
>>>> (original) +++
>>>>
>>>> ofbiz/branches/release10.04/applications/product/widget/catalog/CommonScreens.xml
>>>> Tue Jan 25 11:32:24 2011 @@ -48,92 +48,6 @@
>>>>   under the License. 
>>>>   
>>>>
>>>> -
>>>> -
>>>> -
>>>> ->>> map-name="uiLabelMap" global="true"/>
>>>> ->>> map-name="uiLabelMap" global="true"/>
>>>> ->>> from-field="parameters.productId"/>
>>>> ->>> value-field="product"/>
>>>> ->>> from-field="product.productName"/>
>>>> -
>>>> -
>>>> ->>> location="${parameters.mainDecoratorLocation}">
>>>> -
>>>> -
>>>> -
>>>> -
>>>> ->>> permission="CATALOG" action="_VIEW"/>
>>>> ->>> field="product"/>
>>>> -
>>>> -
>>>> -
>>>> ->>> location="component://product/widget/catalog/CatalogMenus.xml"/>
>>>> -
>>>> -
>>>> -
>>>> -
>>>> -
>>>> -
>>>> -
>>>> -
>>>> -
>>>> -
>>>> ->>> action="_VIEW"/>
>>>> -
>>>> -
>>>> -
>>>> -
>>>> ->>> field="product"/>
>>>> -
>>>> -

Re: svn commit: r1063459 - in /ofbiz/trunk/specialpurpose/ebay: config/EbayUiLabels.xml src/org/ofbiz/ebay/EbayOrderServices.java src/org/ofbiz/ebay/ImportOrdersFromEbay.java

[Vikas Mayur]

+ 1

Regards
Vikas

On Thu, Jan 27, 2011 at 4:51 AM, Scott Gray wrote:

> The problem is that when you mix code changes with formatting changes
> reviewers then have inspect every chunk closely in order to figure out what
> (if anything) changed in those lines.
>
> I can't force you to do anything but if you want your code reviewed
> properly then I'd really recommend splitting the two types of changes.
>
> Regards
> Scott
>
> On 27/01/2011, at 9:33 AM, risali...@gmail.com wrote:
>
> > Hi Scott,
> >
> > we discuss on the dev mailing list that when we change something in the
> code and we found long lines stripped we could replace it with long lines.
> > In this case It was what I would like to do it but I forgot to do it,
> probably in this case there was a tab and I have simply replaced it with 4
> spaces.
> >
> > Thanks
> > Marco
> >
> > Il giorno 26/gen/2011, alle ore 21.24, Scott Gray ha scritto:
> >
> >> Hi Marco,
> >>
> >> Could please try and avoid including formatting changes in with actual
> code changes?  It makes review much more difficult.
> >>
> >> Many thanks
> >> Scott
> >>
> >> HotWax Media
> >> http://www.hotwaxmedia.com
> >>
> >> On 26/01/2011, at 10:00 AM, mrisal...@apache.org wrote:
> >>
> >>> Author: mrisaliti
> >>> Date: Tue Jan 25 21:00:03 2011
> >>> New Revision: 1063459
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=1063459&view=rev
> >>> Log:
> >>> Internationalization of java services for ebay component and remove a
> java compile warning (OFBIZ-4091)
> >>>
> >>> Modified:
> >>>  ofbiz/trunk/specialpurpose/ebay/config/EbayUiLabels.xml
> >>>
>  ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java
> >>>
>  ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/ImportOrdersFromEbay.java
> >>
> >> [snip]
> >>
> >>> Modified:
> ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java
> >>> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java?rev=1063459&r1=1063458&r2=1063459&view=diff
> >>>
> ==
> >>> ---
> ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java
> (original)
> >>> +++
> ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java
> Tue Jan 25 21:00:03 2011
> >>> @@ -1119,9 +1119,9 @@ public class EbayOrderServices {
> >>>   EbayHelper.correctCityStateCountry(dispatcher,
> shippingAddressCtx, city, state, country);
> >>>
> >>>   List shipInfo =
> >>> -
> PartyWorker.findMatchingPersonPostalAddresses
> >>> -   (delegator,
> >>> -
>  shippingAddressCtx.get("shippingAddressStreet1").toString(),
> >>> +PartyWorker.findMatchingPersonPostalAddresses
> >>> +(delegator,
> >>> +
> shippingAddressCtx.get("shippingAddressStreet1").toString(),
> >>>
> (UtilValidate.isEmpty(shippingAddressCtx.get("shippingAddressStreet2")) ?
> null : shippingAddressCtx.get("shippingAddressStreet2").toString()),
> >>>shippingAddressCtx.get("city").toString(),
> >>>
> (UtilValidate.isEmpty(shippingAddressCtx.get("stateProvinceGeoId")) ? null :
> shippingAddressCtx.get("stateProvinceGeoId").toString()),
> >>
> >> [snip]
> >
>
>

Re: svn commit: r1225641 - in /ofbiz/branches/release11.04/applications/order/src/org/ofbiz/order: order/OrderServices.java shoppingcart/ShoppingCart.java

[Vikas Mayur]

I think this is a fix to a certain extent as without the association you
can't really query the records with ship group.

Regards
Vikas


On Fri, Dec 30, 2011 at 2:02 AM, Adrian Crum <
adrian.c...@sandglass-software.com> wrote:

> Is this a bug fix?
>
> -Adrian
>
>
> On 12/29/2011 8:30 PM, m...@apache.org wrote:
>
>> Author: mor
>> Date: Thu Dec 29 20:30:56 2011
>> New Revision: 1225641
>>
>> URL: 
>> http://svn.apache.org/viewvc?**rev=1225641&view=rev
>> Log:
>> Merged from trunk r1225639&  r1225640. Log: Added support to associate
>> ship groups of sales and drop ship purchase orders.
>>
>>
>> Modified:
>> ofbiz/branches/release11.04/**applications/order/src/org/**
>> ofbiz/order/order/**OrderServices.java
>> ofbiz/branches/release11.04/**applications/order/src/org/**
>> ofbiz/order/shoppingcart/**ShoppingCart.java
>>
>> Modified: ofbiz/branches/release11.04/**applications/order/src/org/**
>> ofbiz/order/order/**OrderServices.java
>> URL: http://svn.apache.org/viewvc/**ofbiz/branches/release11.04/**
>> applications/order/src/org/**ofbiz/order/order/**OrderServices.java?rev=*
>> *1225641&r1=1225640&r2=1225641&**view=diff
>> ==**==**
>> ==
>> --- ofbiz/branches/release11.04/**applications/order/src/org/**
>> ofbiz/order/order/**OrderServices.java (original)
>> +++ ofbiz/branches/release11.04/**applications/order/src/org/**
>> ofbiz/order/order/**OrderServices.java Thu Dec 29 20:30:56 2011
>> @@ -4803,7 +4803,6 @@ public class OrderServices {
>>  sci.setAssociatedOrderId(**orderId);
>>  sci.**setAssociatedOrderItemSeqId(**
>> item.getString("**orderItemSeqId"));
>>  sci.setOrderItemAssocTypeId("**
>> DROP_SHIPMENT");
>> -// TODO: we should consider also the
>> ship group in the association between sales and purchase orders
>>  } catch (Exception e) {
>>  return ServiceUtil.returnError(**
>> UtilProperties.getMessage(**resource,
>>  "**
>> OrderOrderCreatingDropShipment**sError",
>> @@ -4819,11 +4818,12 @@ public class OrderServices {
>>  cart.**setDefaultCheckoutOptions(**
>> dispatcher);
>>  // the shipping address is the one of the
>> customer
>>  cart.setShippingContactMechId(**
>> shipGroup.getString("**contactMechId"));
>> +// associate ship groups of sales and
>> purchase orders
>> +ShoppingCart.CartShipInfo cartShipInfo =
>> cart.getShipGroups().get(0);
>> +cartShipInfo.**setAssociatedShipGroupSeqId(*
>> *shipGroup.getString("**shipGroupSeqId"));
>>  // create the order
>>  CheckOutHelper coh = new
>> CheckOutHelper(dispatcher, delegator, cart);
>>  coh.createOrder(userLogin);
>> -
>> -// TODO: associate the new purchase order
>> with the sales order (ship group)
>>  } else {
>>  // if there are no items to drop ship, then
>> clear out the supplier partyId
>>  Debug.logWarning("No drop ship items found
>> for order [" + shipGroup.getString("orderId") + "] and ship group [" +
>> shipGroup.getString("**shipGroupSeqId") + "] and supplier party [" +
>> shipGroup.getString("**supplierPartyId") + "].  Supplier party
>> information will be cleared for this ship group", module);
>>
>> Modified: ofbiz/branches/release11.04/**applications/order/src/org/**
>> ofbiz/order/shoppingcart/**ShoppingCart.java
>> URL: http://svn.apache.org/viewvc/**ofbiz/branches/release11.04/**
>> applications/order/src/org/**ofbiz/order/shoppingcart/**
>> ShoppingCart.java?rev=1225641&**r1=1225640&r2=1225641&view=**diff
>> ==**==**
>> ==
>> --- ofbiz/branches/release11.04/**applications/order/src/org/**
>> ofbiz/order/shoppingcart/**ShoppingCart.java (original)
>> +++ ofbiz/branches/release11.04/**applications/order/src/org/**
>> ofbiz/order/shoppingcart/**ShoppingCart.java Thu Dec 29 20:30:56 2011
>> @@ -4015,36 +4015,39 @@ public class ShoppingCart implements Ite
>>  public List  makeAllOrderItemAssociations() {
>>  List  allOrderItemAssociations = new
>> LinkedList();
>>
>> -

Re: Error finding Service with name updatePracticePerson for auto-fields-service in a form widget

[Vikas Mayur]

You also need to add the service definition, look for an example in
applications/party/servicedef

Regards
Vikas

On Tue, Feb 21, 2012 at 11:00 PM, Shuany Yu  wrote:

> I'm trying to finish the part 2 of the tutorial but I haven't found where
> the updatePracticePerson service is defined in the tutorial. Thus, I'm
> recieving the following error message when I try to open the personform
> page.
>  exception report
> -- Error finding
> Service with name updatePracticePerson for auto-fields-service in a form
> widget Exception: org.ofbiz.service.GenericServiceException Message: Cannot
> locate service by name (updatePracticePerson)  stack trace
> ---
> org.ofbiz.service.GenericServiceException: Cannot locate service by name
> (updatePracticePerson)
> org.ofbiz.service.DispatchContext.getModelService(DispatchContext.java:190)
> org.ofbiz.widget.form.ModelForm.addAutoFieldsFromService(ModelForm.java:681)
> org.ofbiz.widget.form.ModelForm.initForm(ModelForm.java:497)
> org.ofbiz.widget.form.ModelForm.(ModelForm.java:213)
> org.ofbiz.widget.form.FormFactory.createModelForm(FormFactory.java:154)
> org.ofbiz.widget.form.FormFactory.createModelForm(FormFactory.java:150)
> org.ofbiz.widget.form.FormFactory.getFormFromLocation(FormFactory.java:85)
> org.ofbiz.widget.screen.ModelScreenWidget$Form.getModelForm(ModelScreenWidget.java:857)
> org.ofbiz.widget.screen.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:837who
> can help me, thanks?

Re: Lose Weight Program for OFBiz

[Vikas Mayur]

Hi Jacopo,

I have few questions on the proposed idea for Extras.

-- Since the projects will be hosted as Apache OFBiz Extras and not officially 
under ASF, In future does this means these projects should strictly follow the 
ASF license? What if user group and/or the code maintainer of the project tries 
to change any such thing over time? 
-- Will all committers from OFBiz other than the maintainer still have a commit 
rights to Extras? I believe maintainer would be any existing committer(s) or 
new committer(s) assigned to the project(s) in Extras.
-- Will the OFBiz community in general still be keeping track of development, 
discussions, future of these projects or any other activities?
-- Is it necessary for Apache OFBiz Extras projects to follow the release 
policy similar to OFBiz?
-- If no one come forward for a certain project under specialpurpose, it will 
be moved to Attic. What if, in future someone show interest in the project, 
will the project be moved Extras or not?

Regards
Vikas

On Mar 18, 2012, at 2:40 PM, Jacopo Cappellato wrote:

> In the last period the OFBiz project has grown a lot in shape: the implicitly 
> accepted (or tolerated) strategy operated by the active committers was that 
> the more features you could add to the official repository the better was: 
> you make happy the contributors, making them feel like they are a part of 
> something, and each committer could manage the code implemented for his/her 
> own projects directly in the OFBiz codebase.
> 
> We operated under the concept that, since the code if "free" and the author 
> (committer or not) is willing to contribute it, then no one should/could 
> complain if it is added to the repository, if it doesn't cause immediate 
> problems to others; all in all it is an additional feature that may be used 
> by someone else in the future or if not would simply stay there without 
> causing any harm.
> Following this strategy we got a lot of code like for example Webslinger, 
> seleniumxml, debian packages, all sort of specialpurpose applications etc...
> 
> Since there was not a central and agreed upon roadmap, no one could really 
> state that a contribution was not a good fit for the project: each and every 
> committer could add what, in his own personal vision, was good for the 
> project.
> 
> The wrong assumption is that, since the code if "free" then it doesn't harm 
> to include it. This is completely *wrong*: the code is not *free* at all 
> because as soon as you add it to the repository then you add a future cost to 
> the community: you all know that in the software industry the cost to 
> maintain a piece of code is by far greater than the cost to write it; and you 
> *have* to maintain the code unless you want to have and distribute stale code.
> And this is exactly what we have now:
> * high costs to maintain the code (e.g. I recently spent a lot of hours to 
> remove the Webslinger component)
> * stale/unused/half baked code that causes confusion and bad impression to 
> user evaluating the quality of our product
> 
> The message to all the committers is: when you add code to the repository, 
> you are asking the community to take care of its maintenance costs forever. 
> So please, add new code only when it is really beneficial to the project and 
> to a large audience of committers and users.
> 
> It is like feeding a wild animal at the zoo with chips: everyone knows it is 
> bad for its health but when you are there it is so nice when it picks the 
> food from your own hands and you cannot resist and have to feed it.
> 
> OFBiz is now suffering from serious weight issues: the committers community 
> is having an hard time to maintain the huge codebase, it is difficult to keep 
> track of all the features in the system etc...
> 
> I think it is important to start a new phase of the project and focus our 
> energy in cleanup and consolidation of what we have. One step in this 
> direction is for OFBiz to lose weight.
> 
> In order to get the ball rolling and focus on some concrete tasks I am 
> providing here some examples of stuff that I would like to see removed from 
> the project.
> 
> IMPORTANT: Please consider that the list is not based on what I think the 
> perfect framework should be (so PLEASE do not reply stating what your ideal 
> framework should have), but simply on the following considerations:
> * can the component be easily removed by the project? is it independent and 
> can live outside as a plugin?
> * do we need all this custom code? can't we find a simpler, lighter and 
> better way to implement this?
> * is this feature used by other code in the system?
> * is the feature functional? or is it largely incomplete?
> * is this an old component/code?
> * is this used by a lot of persons? (this is tricky to decide but you can get 
> a feeling of it by reading the mailing lists, considering commit activity, 
> the status of the feature etc...)
> 
> DISCLAIMER: I know it will be a painful

Re: Lose Weight Program for OFBiz

[Vikas Mayur]

Thanks Jacopo for your quick response. It clears my doubt.

Regards
Vikas

On Mar 21, 2012, at 1:41 PM, Jacopo Cappellato wrote:

> Hi Vikas,
> 
> I am sharing my ideas about this new process (they are also based on my 
> reading of various documents provided by ASF):
> 
> On Mar 21, 2012, at 8:58 AM, Vikas Mayur wrote:
> 
>> Hi Jacopo,
>> 
>> I have few questions on the proposed idea for Extras.
>> 
>> -- Since the projects will be hosted as Apache OFBiz Extras and not 
>> officially under ASF, In future does this means these projects should 
>> strictly follow the ASF license? What if user group and/or the code 
>> maintainer of the project tries to change any such thing over time?
> 
> No, each project will be free to decide the license; of course the ASL2.0 
> will make it easier to contribute code with Apache OFBiz, but it will not be 
> a requirement.
> 
>> 
>> -- Will all committers from OFBiz other than the maintainer still have a 
>> commit rights to Extras? I believe maintainer would be any existing 
>> committer(s) or new committer(s) assigned to the project(s) in Extras.
> 
> Not necessarily: the maintainer could be also a non-committer and not all 
> OFBiz committers will automatically get access to the project in Extras (you 
> have to accept the agreement with Google etc...); this is definitely true for 
> new projects that will start from scratch; for projects that will be 
> contributed by the OFBiz community (by moving components out of OFBiz) we 
> will ask to the maintainer to invite each OFBiz committer to become a 
> committer: the ones that will accept will be setup there
> 
>> -- Will the OFBiz community in general still be keeping track of 
>> development, discussions, future of these projects or any other activities?
> 
> I would like something like this: the OFBiz community could encourage (not 
> oblige) the external project to send status updates to the OFBiz dev list 
> from time to time to keep the community updated (every month/quarter or based 
> on activity or milestones reached); I guess that the best mechanism will be 
> refined over time with some experience
> 
>> -- Is it necessary for Apache OFBiz Extras projects to follow the release 
>> policy similar to OFBiz?
> 
> No
> 
>> -- If no one come forward for a certain project under specialpurpose, it 
>> will be moved to Attic. What if, in future someone show interest in the 
>> project, will the project be moved Extras or not?
> 
> Yes, we can resurrect all the code in our repository; the Attic page in 
> Confluence will help to keep track of components that we remove.
> 
> Regards,
> 
> Jacopo
> 
> 
>> 
>> Regards
>> Vikas
>> 
>> On Mar 18, 2012, at 2:40 PM, Jacopo Cappellato wrote:
>> 
>>> In the last period the OFBiz project has grown a lot in shape: the 
>>> implicitly accepted (or tolerated) strategy operated by the active 
>>> committers was that the more features you could add to the official 
>>> repository the better was: you make happy the contributors, making them 
>>> feel like they are a part of something, and each committer could manage the 
>>> code implemented for his/her own projects directly in the OFBiz codebase.
>>> 
>>> We operated under the concept that, since the code if "free" and the author 
>>> (committer or not) is willing to contribute it, then no one should/could 
>>> complain if it is added to the repository, if it doesn't cause immediate 
>>> problems to others; all in all it is an additional feature that may be used 
>>> by someone else in the future or if not would simply stay there without 
>>> causing any harm.
>>> Following this strategy we got a lot of code like for example Webslinger, 
>>> seleniumxml, debian packages, all sort of specialpurpose applications etc...
>>> 
>>> Since there was not a central and agreed upon roadmap, no one could really 
>>> state that a contribution was not a good fit for the project: each and 
>>> every committer could add what, in his own personal vision, was good for 
>>> the project.
>>> 
>>> The wrong assumption is that, since the code if "free" then it doesn't harm 
>>> to include it. This is completely *wrong*: the code is not *free* at all 
>>> because as soon as you add it to the repository then you add a future cost 
>>> to the community: you all know that in the software industry the cost to 
>>> maintain a piece of code is by far greater than the cost to write it; and 
>>> you *have* to maintain the code un

Re: Is ofbiz going the sugarcrm, magento route? (essential extra's are commercial?)

[Vikas Mayur]

I do not see any issues if the existing projects that are slated to be moved to 
Extras adhere to the ASF 2.0 license but as I see it further I don't see any 
issues either if the license of any project is changed in future. I think it 
would be good for the project overall and while its not necessary that there 
would be just one company/maintainer of the code for any particular project, I 
believe anyone (individual or company) can use the base project (project at the 
moment with ASF 2.0) and enhance it, form a community in itself.  At a point of 
time there could be a number of different flavors of the same project with 
different user groups and maintainer (individual or company). Its like linux OS 
distributed in different flavors, right? The quality of these project will 
definitely improve with a stiff competition from similar projects and the end 
user eventually have more options to find a right project for himself.

New projects of course can have ASF 2.0 or any other commercial license.


On Mar 21, 2012, at 6:30 PM, Hans Bakker wrote:

> (I also copied the user list because users are heavily impacted here. Users 
> please read the development forum at http://www.ofbiz.info)
> 
> Hi Everybody interested in the future of ofbiz,
> -
> *i am very concerned with the current route which is proposed by Jacopo in 
> the development mailing list: "Lose Weight Program for OFBiz"*
> 
> Why?
> 
> Have only a minimal core ERP with minimal functionality, anything extra is 
> moved to either:
> 1. *Apache extras* (http://www.apache-extras.com) which is just a url link 
> menu into "Google projects" This will not be maintained by the Apache OFBiz 
> committers  and only outside the Apache environment.
> 2. *attic* (abandoned=deleted)
> 
> Pushing out complete components and functions like for example all components 
> in the specialized directory such as e-commerce, project manager, asset 
> manager and others and also Birt (Reporting) integration out of the OFBiz 
> core system will actually mean: components will be abandoned even when stored 
> in "apache extra's" and will be picked up by  commercial companies like mine 
> (Antwebsystems) and others and will promote them as commercial add-ons for a 
> fee.

As far I see the responses, devs are interested in keeping the e-commerce under 
the specialpurpose directory. Did I mis-read?

> 
> [my Antwebsystems CEO hat on]
> Actually we (AntWebsystems) already started the process a couple of months 
> ago, we have internal chat/live chat(see our website), twitter, sitemap, 
> saas/tenant extension, shindig/igoogle integration, task manager and more 
> because a number of committers objected that we added more functions, so we 
> stopped contributing major functions.


Not to mention that any such projects developed by AntWebsystems (I believe 
they are commercial right now) could be the next big projects in Extras and 
might attract a large number of users for contributions too. It may be easier 
for the customers to adopt to these projects if you decide to distribute it 
with ASF 2.0 :)

> 
> [my Apache PMC member hat on]
> This can now happen with anything that will be removed from the core system. 
> There are many articles about the commercialization of open source products 
> on the internet, examples are Sugercrm and Magento and OFBiz will be the next 
> one:
> 
> *In the future, a reasonable OFBiz system cannot be be run without commercial 
> extra's!
> *
> Please keep this in mind if you react on the proposal "Lose Weight Program 
> for OFBiz": do not agree too easily.

I am sure that this will help in large adoption of the project OFBiz.

Regards
Vikas

> 
> [my Antwebsystems CEO hat on]
>From a commercialization point of view please remove as much as 
> possible.
> [my Apache PMC member hat on]
>Only remove the component/functions which are not maintained.
> 
> Regards,
> Hans Bakker
> *Proud Apache OFBiz PMC member* and yes also CEO Antwebsystems Co.Ltd.
> 

Re: Renaming some ant tasks to improve consistency

[Vikas Mayur]

+1 

These new ones really make sense. IMO we don't need to keep the old ones.

Regards
Vikas

On Mar 26, 2012, at 7:27 PM, Jacopo Cappellato wrote:

> Hi all,
> 
> I have reviewed the names of our ant tasks and I would like to propose to 
> rename [*] some of them to make them more consistent with what they actually 
> do.
> In short, I would like to:
> * rename some "run" tasks with the word "start" because they actually start 
> OFBiz
> * rename "run-install*" tasks with the word "load" because they actually load 
> data
> ** rename the task that loads demo data from "run-install" to a more explicit 
> "load-demo"
> 
> Here is the complete list of proposed changes:
> 
> run --> start
> run-debug --> start-debug
> run-pos --> start-pos
> run-install --> load-demo
> run-install-* targets --> load-* (for example: run-install-seed --> load-seed 
> etc...)
> 
> What do you think?
> 
> Jacopo
> 
> [*] if we are worried about "backward compatibility" (even if this is not 
> actually a *compatibility* issue) we could keep the old ones (to call the new 
> ones); I personally don't think it is necessary and we could clean them to 
> have a cleaner build.xml file for future evolution but I would not be 
> against keeping the old ones as well if there is enough consensus.
> 

Re: svn commit: r1307836 - in /ofbiz/trunk: applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java build.xml

[Vikas Mayur]

Hi Erwan,

Isn't it a good practice to commit the indentation changes separately, since 
its just a one line change? Secondly, the changes in the build file seems 
unrelated?

Regards
Vikas

On Mar 31, 2012, at 9:15 PM, er...@apache.org wrote:

> Author: erwan
> Date: Sat Mar 31 15:45:12 2012
> New Revision: 1307836
> 
> URL: http://svn.apache.org/viewvc?rev=1307836&view=rev
> Log:
> no functional change: removing an array of 1 element
> 
> Modified:
>
> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java
>ofbiz/trunk/build.xml
> 
> Modified: 
> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java?rev=1307836&r1=1307835&r2=1307836&view=diff
> ==
> --- 
> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java
>  (original)
> +++ 
> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java
>  Sat Mar 31 15:45:12 2012
> @@ -168,42 +168,37 @@ public class ProductDisplayWorker {
> // keep track of how many times a product occurs in order to 
> find averages and rank by purchase amount
> productOccurances = new HashMap();
> 
> -// get all order role entities for user by customer role type
> -// final String[] USER_ORDER_ROLE_TYPES = 
> {"END_USER_CUSTOMER", "SHIP_TO_CUSTOMER", "BILL_TO_CUSTOMER", 
> "PLACING_CUSTOMER"};
> -final String[] USER_ORDER_ROLE_TYPES = {"PLACING_CUSTOMER"};
> -
> -for (int i = 0; i < USER_ORDER_ROLE_TYPES.length; i++) {
> -List orderRoles = 
> delegator.findByAnd("OrderRole", UtilMisc.toMap("partyId", 
> userLogin.get("partyId"), "roleTypeId", USER_ORDER_ROLE_TYPES[i]), null);
> -Iterator ordersIter = 
> UtilMisc.toIterator(orderRoles);
> -
> -while (ordersIter != null && ordersIter.hasNext()) {
> -GenericValue orderRole = ordersIter.next();
> -// for each order role get all order items
> -List orderItems = 
> orderRole.getRelated("OrderItem");
> -Iterator orderItemsIter = 
> UtilMisc.toIterator(orderItems);
> -
> -while (orderItemsIter != null && 
> orderItemsIter.hasNext()) {
> -GenericValue orderItem = orderItemsIter.next();
> -String productId = 
> orderItem.getString("productId");
> -if (UtilValidate.isNotEmpty(productId)) {
> -// for each order item get the associated 
> product
> -GenericValue product = 
> orderItem.getRelatedOneCache("Product");
> -
> -products.put(product.getString("productId"), 
> product);
> -
> -BigDecimal curQuant = 
> productQuantities.get(product.get("productId"));
> -
> -if (curQuant == null) curQuant = 
> BigDecimal.ZERO;
> -BigDecimal orderQuant = 
> orderItem.getBigDecimal("quantity");
> -
> -if (orderQuant == null) orderQuant = 
> BigDecimal.ZERO;
> -
> productQuantities.put(product.getString("productId"), 
> curQuant.add(orderQuant));
> -
> -Integer curOcc = 
> productOccurances.get(product.get("productId"));
> -
> -if (curOcc == null) curOcc = 
> Integer.valueOf(0);
> -
> productOccurances.put(product.getString("productId"), 
> Integer.valueOf(curOcc.intValue() + 1));
> -}
> +// get all order role entities for user by customer role 
> type : PLACING_CUSTOMER
> +List orderRoles = 
> delegator.findByAnd("OrderRole", UtilMisc.toMap("partyId", 
> userLogin.get("partyId"), "roleTypeId", "PLACING_CUSTOMER"), null);
> +Iterator ordersIter = 
> UtilMisc.toIterator(orderRoles);
> +
> +while (ordersIter != null && ordersIter.hasNext()) {
> +GenericValue orderRole = ordersIter.next();
> +// for each order role get all order items
> +List orderItems = 
> orderRole.getRelated("OrderItem");
> +Iterator orderItemsIter = 
> UtilMisc.toIterator(orderItems);
> +
> +while (orderItemsIter != null && 
> orderItemsIter.hasNext()) {
> +GenericValue orderItem = orderItemsIter.next();
> +String productId = orderItem.getString("productId");
> + 

Re: svn commit: r1307836 - in /ofbiz/trunk: applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java build.xml

[Vikas Mayur]

Thanks Erwan, I think it is easier for code review etc. if the changes are done 
separately. 

Regards
Vikas

On Apr 3, 2012, at 8:45 PM, Erwan de FERRIERES wrote:

> Hi Vikas,
> 
> thanks for the build.xml file. This is unrelated and should have not
> been committed.I'll work on it soon.
> For the indentation, I removed a loop, so the formating changes are
> coming with it.
> 
> Regards,
> 
> 2012/4/3 Vikas Mayur :
>> Hi Erwan,
>> 
>> Isn't it a good practice to commit the indentation changes separately, since 
>> its just a one line change? Secondly, the changes in the build file seems 
>> unrelated?
>> 
>> Regards
>> Vikas
>> 
>> On Mar 31, 2012, at 9:15 PM, er...@apache.org wrote:
>> 
>>> Author: erwan
>>> Date: Sat Mar 31 15:45:12 2012
>>> New Revision: 1307836
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=1307836&view=rev
>>> Log:
>>> no functional change: removing an array of 1 element
>>> 
>>> Modified:
>>>
>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java
>>>ofbiz/trunk/build.xml
>>> 
>>> Modified: 
>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java
>>> URL: 
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java?rev=1307836&r1=1307835&r2=1307836&view=diff
>>> ==
>>> --- 
>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java
>>>  (original)
>>> +++ 
>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductDisplayWorker.java
>>>  Sat Mar 31 15:45:12 2012
>>> @@ -168,42 +168,37 @@ public class ProductDisplayWorker {
>>> // keep track of how many times a product occurs in order 
>>> to find averages and rank by purchase amount
>>> productOccurances = new HashMap();
>>> 
>>> -// get all order role entities for user by customer role 
>>> type
>>> -// final String[] USER_ORDER_ROLE_TYPES = 
>>> {"END_USER_CUSTOMER", "SHIP_TO_CUSTOMER", "BILL_TO_CUSTOMER", 
>>> "PLACING_CUSTOMER"};
>>> -final String[] USER_ORDER_ROLE_TYPES = 
>>> {"PLACING_CUSTOMER"};
>>> -
>>> -for (int i = 0; i < USER_ORDER_ROLE_TYPES.length; i++) {
>>> -List orderRoles = 
>>> delegator.findByAnd("OrderRole", UtilMisc.toMap("partyId", 
>>> userLogin.get("partyId"), "roleTypeId", USER_ORDER_ROLE_TYPES[i]), null);
>>> -Iterator ordersIter = 
>>> UtilMisc.toIterator(orderRoles);
>>> -
>>> -while (ordersIter != null && ordersIter.hasNext()) {
>>> -GenericValue orderRole = ordersIter.next();
>>> -// for each order role get all order items
>>> -List orderItems = 
>>> orderRole.getRelated("OrderItem");
>>> -Iterator orderItemsIter = 
>>> UtilMisc.toIterator(orderItems);
>>> -
>>> -while (orderItemsIter != null && 
>>> orderItemsIter.hasNext()) {
>>> -GenericValue orderItem = orderItemsIter.next();
>>> -String productId = 
>>> orderItem.getString("productId");
>>> -if (UtilValidate.isNotEmpty(productId)) {
>>> -// for each order item get the associated 
>>> product
>>> -GenericValue product = 
>>> orderItem.getRelatedOneCache("Product");
>>> -
>>> -
>>> products.put(product.getString("productId"), product);
>>> -
>>> -BigDecimal curQuant = 
>>> productQuantities.get(product.get("productId"));
>>> -
>>> -if (curQuant == null) curQuant = 
>>> BigDecimal.ZERO;
>>> -BigDecimal orderQuant = 
>>> orderItem.getBigDecimal("quantity&q

Re: [VOTE] [RELEASE] Apache OFBiz 10.04.02

[Vikas Mayur]

+1 

Regards
Vikas

On Apr 11, 2012, at 4:14 PM, Jacopo Cappellato wrote:

> This is the vote thread to release a new (bug fix) release for the 10.04 
> branch. This new release, "Apache OFBiz 10.04.02" (major release number: 
> "10.04"; minor release number: "02"), will supersede the release "Apache 
> OFBiz 10.04" (aka 10.04.01).

Sorry, It may be out of context but should we add a note on the release page 
just to clarify 10.04 -> 10.04.01 ?

> 
> The release files can be downloaded from here:
> 
> https://dist.apache.org/repos/dist/dev/ofbiz/
> 
> (committers only?) or from here:
> 
> http://people.apache.org/~jacopoc/dist/
> 
> (everyone else)
> 
> and are:
> 
> * apache-ofbiz-10.04.02.zip: the release package, based on the 10.04 branch 
> at revision 1324645 (latest as of now)
> * KEYS: text file with keys
> * apache-ofbiz-10.04.02.zip.asc: the detached signature file
> * apache-ofbiz-10.04.02.zip.md5, apache-ofbiz-10.04.02.zip.sha: hashes
> 
> Please download and test the zip file and its signatures (for instructions on 
> testing the signatures see http://www.apache.org/info/verification.html).
> 
> Vote:
> 
> [ +1] release as Apache OFBiz 10.04.02
> [ -1] do not release
> 
> This vote will be closed in 72 hours.
> For more details about this process please read 
> http://www.apache.org/foundation/voting.html
> 
> The following text is quoted from the above url:
> "Votes on whether a package is ready to be released use majority approval -- 
> i.e. at least three PMC members must vote affirmatively for release, and 
> there must be more positive than negative votes. Releases may not be vetoed. 
> Generally the community will cancel the release vote if anyone identifies 
> serious problems, but in most cases the ultimate decision, lies with the 
> individual serving as release manager."
> 
> Kind Regards,
> 
> Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04.02

[Vikas Mayur]

Wonderful, thanks Jacopo

Regards
Vikas

On Apr 11, 2012, at 9:13 PM, Jacopo Cappellato wrote:

> On Apr 11, 2012, at 5:29 PM, Vikas Mayur wrote:
> 
>> Sorry, It may be out of context but should we add a note on the release page 
>> just to clarify 10.04 -> 10.04.01 ?
> 
> Yes, we will add a mention about this.
> 
> Thanks
> 
> Jacopo
> 

Re: Cleaning some of the Jira versions

[Vikas Mayur]

Jacopo,

Since 09.04.02 was the last release of the series 09.04, does the proposed new 
version 09.04.03 has any purpose?

Regards
Vikas

On Apr 17, 2012, at 3:55 PM, Jacopo Cappellato wrote:

> I would like to perform the following maintenance 
> 
> 1) "archive" the following versions (they will disappears from drop down when 
> tasks are created):
> Release 09.04
> Release 09.04.01
> Release 10.04
> because they are all for superseded releases; if there are open issues 
> assigned ("affects") to them we could bulk move them to versions "Release 
> Branch 09.04" and "Release Branch 10.04" 
> 
> 2) create new versions (for upcoming releases):
> Release 09.04.03
> Release 10.04.03
> however new bugs should always be reported ("affect") against the "Release 
> Branch 09.04", "Release Branch 10.04" and "Release Branch 11.04" ; we could 
> use the "Release 09.04.03" and "Release 10.04.03" when the task is fixed in 
> the branch as the "fixed in" version.
> 
> I think that #1 is rather important; I am not sure about #2.
> 
> What do you think?
> 
> Kind regards,
> 
> Jacopo
> 
> PS: I have also created "Release 11.04.01" with a tentative release date of 
> May 15: I am going to use this version to log a series of tasks that are 
> required before the release; after the release I will "archive" this version 
> as the versions in #2 above.
> 

Re: Cleaning some of the Jira versions

[Vikas Mayur]

No problem Jacopo :) 
The proposal otherwise looks good. We would perhaps need "Release Branch 
09.04", even though the code will not be committed to this release branch but 
still one can post bug (if any) and/or attach patch for the fixes etc.

Regards
Vikas

On Apr 17, 2012, at 5:55 PM, Jacopo Cappellato wrote:

> ah ah, you are right Vikas!
> Please disregard the proposal about 09.04.03... I probably need another coffee
> 
> Jacopo
> 
> On Apr 17, 2012, at 12:40 PM, Vikas Mayur wrote:
> 
>> Jacopo,
>> 
>> Since 09.04.02 was the last release of the series 09.04, does the proposed 
>> new version 09.04.03 has any purpose?
>> 
>> Regards
>> Vikas
>> 
>> On Apr 17, 2012, at 3:55 PM, Jacopo Cappellato wrote:
>> 
>>> I would like to perform the following maintenance 
>>> 
>>> 1) "archive" the following versions (they will disappears from drop down 
>>> when tasks are created):
>>> Release 09.04
>>> Release 09.04.01
>>> Release 10.04
>>> because they are all for superseded releases; if there are open issues 
>>> assigned ("affects") to them we could bulk move them to versions "Release 
>>> Branch 09.04" and "Release Branch 10.04" 
>>> 
>>> 2) create new versions (for upcoming releases):
>>> Release 09.04.03
>>> Release 10.04.03
>>> however new bugs should always be reported ("affect") against the "Release 
>>> Branch 09.04", "Release Branch 10.04" and "Release Branch 11.04" ; we could 
>>> use the "Release 09.04.03" and "Release 10.04.03" when the task is fixed in 
>>> the branch as the "fixed in" version.
>>> 
>>> I think that #1 is rather important; I am not sure about #2.
>>> 
>>> What do you think?
>>> 
>>> Kind regards,
>>> 
>>> Jacopo
>>> 
>>> PS: I have also created "Release 11.04.01" with a tentative release date of 
>>> May 15: I am going to use this version to log a series of tasks that are 
>>> required before the release; after the release I will "archive" this 
>>> version as the versions in #2 above.
>>> 
>> 
> 

Re: svn commit: r1328518 - /ofbiz/branches/release11.04/framework/base/config/test-containers.xml

[Vikas Mayur]

Not sure who you intend to send it but I believe 'argument' is the least little 
thing and OFBiz community can't afford it, so better apply some common sense 
while throwing away anything towards this community.

Regards
Vikas

On Apr 21, 2012, at 2:16 PM, Pierre Smits wrote:

> 
> Maybe you should ask yourself why you got involved in this project, this
> community and why you were asked to join either the PMC or the group of
> committers and whether you are still adhering to those principles or
> guidelines. From the outside (meaning not being a PMC or a committer, but
> being part of this community) it often seems like your not.
> 
> If you still feel you are then stay in touch with the community. If not,
> please state so and .

Re: April deadline for the creation of the 12.04 release branch

[Vikas Mayur]

To keep the release cycle simple and understandable, I think we should go with 
the first option. 

Regards
Vikas

On Apr 24, 2012, at 1:01 PM, Jacopo Cappellato wrote:

> This is just an early notice that we have 1 week before the end of April; if 
> we want to continue with the YY.04 pattern, and create a 12.04 branch, it 
> would be nice to cut the release sometime during this week.
> This thread is intended to help the synchronization between committers; 
> possible options:
> 
> 1) create the branch sometime before the end of April with name "release12.04"
> 2) delay a little bit (a few weeks?) the creation of the branch, that we will 
> still name "release12.04"
> 3) delay the creation of the branch and then we will call it 12.MM where MM 
> is the month of the creation of it
> 
> My preference would be #1; please express your preference and I will 
> implement accordingly.
> 
> Kind regards,
> 
> Jacopo

Re: Removing the dependency on "build" from all the "run-test*" ant targets

[Vikas Mayur]

+1

Regards
Vikas

On Apr 23, 2012, at 6:51 PM, Jacopo Cappellato wrote:

> What do you think? In order to run most of the tests successfully you need to 
> run load-data that already depends on "build"...
> 
> Here is the code change I would like to commit:
> 
> Index: build.xml
> ===
> --- build.xml (revision 1328357)
> +++ build.xml (working copy)
> @@ -868,7 +868,7 @@
> 
> 
> 
> - +   description="Run OFBiz default tests; you have to manually execute 
> 'ant load-demo' before and see results in 
> runtime/logs/test-results/html/all-tests.html.">
> 
> 
> @@ -910,7 +910,7 @@
> 
> 
> 
> - +   description="Run a single test, syntax eg: ant run-test 
> -Dtest.component=service -Dtest.case=service-soap-tests">
> test.component is a required parameter: 
> -Dtest.component=componentname
> test.case is a required parameter: 
> -Dtest.case=testcasename
> @@ -936,7 +936,7 @@
> 
> 
> 
> - + description="Run a single test suite, syntax eg: ant 
> run-test-suite -Dtest.component=mycomponent -Dtest.suiteName=mytests">
> test.component is a required parameter: 
> -Dtest.component=componentname
> test.suiteName is a required parameter: 
> -Dtest.suiteName=testsuitename
> 
> Jacopo
> 

Re: "Look up Product and Price" Displays many empty options in the Combo Box "Primary Product Category Id"

[Vikas Mayur]

I think it would be nice to use both something like description="${id} - 
${description}"

-
Vikas

On Apr 14, 2013, at 6:58 AM, Medhat AbdelBadie wrote:

> Hi,
> 
> When open "Look up Product and Price" Look up which is reached by the
> following Steps:
> 
> Order >> Quotes >>  find Quote or create new Quote >> Quote Items >> Create
> New Quote Item >>  open look up beside "Product Id"
> 
> The Combo Box "Primary Product Category Id" Contains many empty options
> when scroll down inside the Combo Box.
> 
> This is because Combo box displays data in the "DESCRIPTION" field in the
> entity "ProductCategory" Which maybe contains empty values in many records.
> 
> To solve this issue, I am suggesting the following:
> 
> In the File : /applications/product/widget/catalog/FieldLookupForms.xml
> 
> at lines 144 - 150,
> 
> 144
> 145
> 146 entity-name="ProductCategory" key-field-name="productCategoryId">
> 147
> 148
> 149
> 150
> 
> Add the following line after line 146
> 
> **
> 
> Then the above code snippet becomes:
> 
> 144
> 145
> 146 entity-name="ProductCategory" key-field-name="productCategoryId">
> 147* value="'',''"/>*
> 148
> 149
> 150
> 151
> 
> This will remove any empty "DESCRIPTION" field's value from being listed in
> the Combo Box.
> 
> This behavior is existing on "demo-trunk" and  ofbiz version 12.04.01.
> 
> What you think about that ?
> 
> Regards,
> Medhat



smime.p7s
Description: S/MIME cryptographic signature

Order Fulfillment Issues

[Vikas Mayur]

Hi Devs,

I’m testing the order fulfillment on ofbiz release branch 12.04 for a scenario 
when payment gateway decline the payments. I’m using OOTB service 
'alwaysDeclineCCProcessor’ to decline the payments which are earlier authorized 
by the service ‘alwaysApproveCCProcessor’. Once I create a sales order I click 
on the link ‘Pack Shipment For Ship Group’ to pack the order, the link is under 
the shipping information block on the order detail page. After packing the 
items, I click on ‘Complete’ button to complete the packing.

The order packing is initiated and completed by a main service completePack 
which do a lot of things. It creates shipment, packages, issue items to 
shipment (which in turns also change the item status to complete), apply items 
to packages etc. and update the shipment status to PACKED. We have a following 
eca, which triggers services that creates invoice and capture the payments.









I see few issues noted below while processing the order fulfillment. I believe 
the same issue exists on ofbiz trunk since that code around the packing & 
payment gateway service remains unchanged.

1. The service processCaptureResult (PaymentGatewayServices) contains a piece 
of code that creates payment and apply the payment to invoice but it does not 
check the status of the capture result. This leads to a invoice to PAID status 
even though the payments are declined.

2. The order status remains complete even though the payments are declined and 
is not rolled back to approved (preferably hold).

3. The order status ‘complete’ triggers an email to the customer through an eca 
defined on the service ‘changeOrderStatus’ in the order component.

I think If we add an attribute ignore-error="false" to the  
element it will roll-back the global transaction started by the service 
completePack() and hence will revert the oder back to its initial state 
(status) where we started packing the order but it will also rollback every 
changes done by the service completePack.

Should we fix all three issues above or just do a global rollback (which takes 
you back where you started)?

Regards
Vikas 

OrderItemPriceInfo Entity Referential integrity

[Vikas Mayur]

Hi Devs,

I’ve created a bad price rule action for a price rule and I can’t delete it 
because the price rule is already applied on some orders and ProductPriceAction 
is referenced by OrderItemPriceInfo through a foreign key. I just want to get 
rid of the bad price rule action, I think the easiest way would be to put a 
thru date on the existing price rule and create a new price rule with correct 
price rule action.

Of-course an update on the existing price rule action is still allowed as only 
productPriceRuleId & productPriceActionSeqId fields are referenced through 
foreign key by the OrderItemPriceInfo entity but if we update the action type 
to something else, lets say the action type was ‘Flat Amount Override’ and now 
you update it to ‘Percent of Default Price’ the existing referenced record in 
the OrderItemPriceInfo will still be obsolete (description, modify amount 
etc.), right?

I think we should just put foreign key reference on the productPriceRuleId 
field so that we can also delete any product price rule action.

Below is the snip from the OrderItemPriceInfo entity definition

{code}
  

  
  


   
{code}

and I think we should change this to

{code}
  

  d
  


  
{code}


What do you think?

Regards
Vikas

Re: svn commit: r1605056 - in /ofbiz/trunk/applications/party: servicedef/services.xml src/org/ofbiz/party/communication/CommunicationEventServices.java

[Vikas Mayur]

Pierre,

The permission service 'partyCommunicationEventPermissionCheck' currently
used to check permission already support the logic to bypass permission in
certain cases. I need to create a communication event when a customer on
the website cancel an order such that it can be used to notify a customer
service representative. Once an email is send, system update the
communication even status to complete but was failing to do so earlier.

Hope this helps.

Regards
Vikas


On Tue, Jun 24, 2014 at 5:05 PM, Pierre Smits 
wrote:

> Vikas,
>
> Could you give some examples of the use-cases?
>
> Regards,
>
> Pierre Smits
>
> *ORRTIZ.COM *
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>

Re: Order Fulfillment Issues

[Vikas Mayur]

Thanks Jacques, I think one ticket for all should be fine. I’ll open one soon.

Regards
Vikas

On Jun 23, 2014, at 1:51 AM, Jacques Le Roux  
wrote:

> Hi Vikas,
> 
> I'd prefer to fix the 3 issues and open 1 or 3(?) Jira for them...
> 
> Jacques
> 
> Le 02/06/2014 17:14, Vikas Mayur a écrit :
>> Hi Devs,
>> 
>> I’m testing the order fulfillment on ofbiz release branch 12.04 for a 
>> scenario when payment gateway decline the payments. I’m using OOTB service 
>> 'alwaysDeclineCCProcessor’ to decline the payments which are earlier 
>> authorized by the service ‘alwaysApproveCCProcessor’. Once I create a sales 
>> order I click on the link ‘Pack Shipment For Ship Group’ to pack the order, 
>> the link is under the shipping information block on the order detail page. 
>> After packing the items, I click on ‘Complete’ button to complete the 
>> packing.
>> 
>> The order packing is initiated and completed by a main service completePack 
>> which do a lot of things. It creates shipment, packages, issue items to 
>> shipment (which in turns also change the item status to complete), apply 
>> items to packages etc. and update the shipment status to PACKED. We have a 
>> following eca, which triggers services that creates invoice and capture the 
>> payments.
>> 
>> 
>> > to-field-name="oldStatusId"/>
>> > value="SHIPMENT_PACKED"/>
>> > value="SALES_SHIPMENT"/>
>> > run-as-user="system"/>
>> > run-as-user="system"/>
>> 
>> 
>> I see few issues noted below while processing the order fulfillment. I 
>> believe the same issue exists on ofbiz trunk since that code around the 
>> packing & payment gateway service remains unchanged.
>> 
>> 1. The service processCaptureResult (PaymentGatewayServices) contains a 
>> piece of code that creates payment and apply the payment to invoice but it 
>> does not check the status of the capture result. This leads to a invoice to 
>> PAID status even though the payments are declined.
>> 
>> 2. The order status remains complete even though the payments are declined 
>> and is not rolled back to approved (preferably hold).
>> 
>> 3. The order status ‘complete’ triggers an email to the customer through an 
>> eca defined on the service ‘changeOrderStatus’ in the order component.
>> 
>> I think If we add an attribute ignore-error="false" to the > ...> element it will roll-back the global transaction started by the service 
>> completePack() and hence will revert the oder back to its initial state 
>> (status) where we started packing the order but it will also rollback every 
>> changes done by the service completePack.
>> 
>> Should we fix all three issues above or just do a global rollback (which 
>> takes you back where you started)?
>> 
>> Regards
>> Vikas
>> 
>> 
>> 
>> 
> 
> -- 

Re: svn commit: r792578 - in /ofbiz/trunk/applications/product: config/ script/org/ofbiz/shipment/picklist/ servicedef/ webapp/facility/facility/ widget/facility/

[Vikas Mayur]

Initially the default behavior of the Picking screen was to group  
orders by shipping method and user does not have any choice to select  
any other grouping method. With the introduction of additional  
grouping methods like grouping by Warehouse Area and Number of Order  
Items, I tried to keep the same behavior of the screen, that is if  
user does not select any option then system will still show the  
grouping based on shipping method. The Group by Shipping Method  
checkbox will be checked automatically on Submit in this case.


The reason of adding explicitly an option No Grouping on this screen  
is that it will serve following purpose:


1. The default behavior of the screen will be preserved. If user does  
not select any option it still defaults to shipping method.

2. User can select No Grouping explicitly.
3. Any selection made by the user other than No Grouping method will  
be cleared by just clicking on No Grouping checkbox. Similarly if No  
Grouping was selected, it will be cleared if user try to select any  
other grouping method (Shipping Method, Warehouse Area and Number of  
Order Items). This part is not implemented yet but the idea is to keep  
this something like select all checkbox on multi form while making it  
explicitly clear to the user that he can also go with No Grouping.


Also in future this screen can be extended to add few more grouping  
methods so the way it is done would work nicely, IMO.


HTH

Vikas


On Jul 9, 2009, at 10:51 PM, David E. Jones wrote:



How is the "No Grouping" option different from just not selecting any
grouping options?

-David


On Thu, 2009-07-09 at 15:19 +, m...@apache.org wrote:

Author: mor
Date: Thu Jul  9 15:19:47 2009
New Revision: 792578

URL: http://svn.apache.org/viewvc?rev=792578&view=rev
Log:
On picking screen, added a new option called No Grouping. This  
option cannot be used with any other grouping methods (Shipping  
Method, Warehouse Area and

Number of Order Items) on this screen.

Modified:
   ofbiz/trunk/applications/product/config/ProductUiLabels.xml
   ofbiz/trunk/applications/product/script/org/ofbiz/shipment/ 
picklist/PicklistServices.xml

   ofbiz/trunk/applications/product/servicedef/services_picklist.xml
   ofbiz/trunk/applications/product/webapp/facility/facility/ 
PicklistOptions.ftl
   ofbiz/trunk/applications/product/widget/facility/ 
FacilityScreens.xml

Re: svn commit: r792826 - /ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml

[Vikas Mayur]

Thanks Ashish. Btw I observe a typo in the log message. foregn -->  
foreign


I hope someone could fix it :)

Vikas

On Jul 10, 2009, at 1:28 PM, ash...@apache.org wrote:


Author: ashish
Date: Fri Jul 10 07:58:40 2009
New Revision: 792826

URL: http://svn.apache.org/viewvc?rev=792826&view=rev
Log:
[java] 2009-07-10 13:09:23,343 (main) [   GenericDelegator.java: 
258:WARN ] [RelFKNameGT18] The foregn key name (length:19) was  
greater than 18 characters in length for relation  
InvoiceItemAssocType of entity InvoiceItemAssoc.


This thing always confuses me. I was in impression that the maximum  
length allowed for fk-name is 20 but came to know that it is 18.

Thanks Vikas for report, will remember this in future :-).

Modified:
   ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml

Modified: ofbiz/trunk/applications/accounting/entitydef/ 
entitymodel.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml?rev=792826&r1=792825&r2=792826&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml  
(original)
+++ ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml  
Fri Jul 10 07:58:40 2009

@@ -1284,14 +1284,14 @@
  
  
  
-  name="InvoiceItemAssocType">
+  name="InvoiceItemAssocType">


  
-  rel-entity-name="InvoiceItem">
+  rel-entity-name="InvoiceItem">
name="invoiceId"/>
name="invoiceItemSeqId"/>

  
-  rel-entity-name="InvoiceItem">
+  entity-name="InvoiceItem">


name="invoiceItemSeqId"/>

  
@@ -1311,7 +1311,7 @@
  
  
  
-  title="Parent" rel-entity-name="InvoiceItemAssocType">
+  title="Parent" rel-entity-name="InvoiceItemAssocType">
name="invoiceItemAssocTypeId"/>

  

Re: svn commit: r792578 - in /ofbiz/trunk/applications/product: config/ script/org/ofbiz/shipment/picklist/ servicedef/ webapp/facility/facility/ widget/facility/

[Vikas Mayur]

Okay, I did some changes again to this screen and this should be  
reflected in rev. 792855. I have removed the No Grouping checkbox and  
changed the screen default behavior to No Grouping whenever user  
browse to this screen. User now again have the ability to select any  
grouping method of his choice and results are displayed on the basis  
of grouping as desired.


To see the results without grouping, the user have to clear all of the  
selected grouping methods.


Vikas

On Jul 10, 2009, at 12:08 PM, David E Jones wrote:



That sounds pretty complicated. For an end-user wouldn't this result  
in confusing and unexpected behavior? In other words, if they  
unselected all of the check boxes wouldn't they expect to see nothing?


If the side effect is that coming to the screen results in only the  
top form showing, I'd say that's fine (yes, there is an issue with  
checkboxes since you can't tell if the user explicitly unchecked the  
box).


Does anyone else have thoughts on this?

-David


On Jul 10, 2009, at 12:05 AM, Vikas Mayur wrote:

Initially the default behavior of the Picking screen was to group  
orders by shipping method and user does not have any choice to  
select any other grouping method. With the introduction of  
additional grouping methods like grouping by Warehouse Area and  
Number of Order Items, I tried to keep the same behavior of the  
screen, that is if user does not select any option then system will  
still show the grouping based on shipping method. The Group by  
Shipping Method checkbox will be checked automatically on Submit in  
this case.


The reason of adding explicitly an option No Grouping on this  
screen is that it will serve following purpose:


1. The default behavior of the screen will be preserved. If user  
does not select any option it still defaults to shipping method.

2. User can select No Grouping explicitly.
3. Any selection made by the user other than No Grouping method  
will be cleared by just clicking on No Grouping checkbox. Similarly  
if No Grouping was selected, it will be cleared if user try to  
select any other grouping method (Shipping Method, Warehouse Area  
and Number of Order Items). This part is not implemented yet but  
the idea is to keep this something like select all checkbox on  
multi form while making it explicitly clear to the user that he can  
also go with No Grouping.


Also in future this screen can be extended to add few more grouping  
methods so the way it is done would work nicely, IMO.


HTH

Vikas


On Jul 9, 2009, at 10:51 PM, David E. Jones wrote:



How is the "No Grouping" option different from just not selecting  
any

grouping options?

-David


On Thu, 2009-07-09 at 15:19 +, m...@apache.org wrote:

Author: mor
Date: Thu Jul  9 15:19:47 2009
New Revision: 792578

URL: http://svn.apache.org/viewvc?rev=792578&view=rev
Log:
On picking screen, added a new option called No Grouping. This  
option cannot be used with any other grouping methods (Shipping  
Method, Warehouse Area and

Number of Order Items) on this screen.

Modified:
 ofbiz/trunk/applications/product/config/ProductUiLabels.xml
 ofbiz/trunk/applications/product/script/org/ofbiz/shipment/ 
picklist/PicklistServices.xml

 ofbiz/trunk/applications/product/servicedef/services_picklist.xml
 ofbiz/trunk/applications/product/webapp/facility/facility/ 
PicklistOptions.ftl
 ofbiz/trunk/applications/product/widget/facility/ 
FacilityScreens.xml

Re: svn commit: r792826 - /ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml

[Vikas Mayur]

Sorry, If I wasn't clear. I was referring to the following part of the  
log that is generated by the system.


[java] 2009-07-10 13:09:23,343 (main) [   GenericDelegator.java: 
258:WARN ] [RelFKNameGT18] The foregn key name (length:19) was  
greater than 18 characters in length for relation  
InvoiceItemAssocType of entity InvoiceItemAssoc.


Vikas

On Jul 10, 2009, at 1:56 PM, Vikas Mayur wrote:

Thanks Ashish. Btw I observe a typo in the log message. foregn -->  
foreign


I hope someone could fix it :)

Vikas

On Jul 10, 2009, at 1:28 PM, ash...@apache.org wrote:


Author: ashish
Date: Fri Jul 10 07:58:40 2009
New Revision: 792826

URL: http://svn.apache.org/viewvc?rev=792826&view=rev
Log:
[java] 2009-07-10 13:09:23,343 (main) [   GenericDelegator.java: 
258:WARN ] [RelFKNameGT18] The foregn key name (length:19) was  
greater than 18 characters in length for relation  
InvoiceItemAssocType of entity InvoiceItemAssoc.


This thing always confuses me. I was in impression that the maximum  
length allowed for fk-name is 20 but came to know that it is 18.

Thanks Vikas for report, will remember this in future :-).

Modified:
  ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml

Modified: ofbiz/trunk/applications/accounting/entitydef/ 
entitymodel.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml?rev=792826&r1=792825&r2=792826&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml  
(original)
+++ ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml  
Fri Jul 10 07:58:40 2009

@@ -1284,14 +1284,14 @@
 
 
 
-  entity-name="InvoiceItemAssocType">
+  name="InvoiceItemAssocType">

   
 
-  rel-entity-name="InvoiceItem">
+  rel-entity-name="InvoiceItem">
   name="invoiceId"/>
   name="invoiceItemSeqId"/>

 
-  rel-entity-name="InvoiceItem">
+  entity-name="InvoiceItem">

   
   name="invoiceItemSeqId"/>

 
@@ -1311,7 +1311,7 @@
 
 
 
-  title="Parent" rel-entity-name="InvoiceItemAssocType">
+  title="Parent" rel-entity-name="InvoiceItemAssocType">
   name="invoiceItemAssocTypeId"/>

 
   

Re: svn commit: r792402 - in /ofbiz/trunk/applications/order: config/OrderUiLabels.xml src/org/ofbiz/order/shoppingcart/CheckOutEvents.java src/org/ofbiz/order/shoppingcart/CheckOutHelper.java webapp/

[Vikas Mayur]

Hi Joe,

I am sorry that I did overlooked your comments.

The idea behind adding an additional note is to make the notes really  
distinct so that while adding notes during checkout user know very  
well the type of note, whether it is a private or public note.


Earlier user have to add a note and then make it public explicitly  
through the order detail page.


Hope that make sense.

Vikas


On Jul 9, 2009, at 11:27 PM, Joe Eckard wrote:


Don't we already have a place to enter shipping instructions?

Alternatively, don't order notes already have a public / private flag?


-Joe

On Jul 9, 2009, at 1:22 AM, m...@apache.org wrote:


Author: mor
Date: Thu Jul  9 05:22:02 2009
New Revision: 792402

URL: http://svn.apache.org/viewvc?rev=792402&view=rev
Log:
While placing an order through order manager user can add shipping  
notes. These notes are saved similar to internal order notes but  
shipping notes are public while internal

order notes are private. Patch from Akash Jain.

Modified:
  ofbiz/trunk/applications/order/config/OrderUiLabels.xml
  ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ 
CheckOutEvents.java
  ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ 
CheckOutHelper.java
  ofbiz/trunk/applications/order/webapp/ordermgr/entry/ 
optionsettings.ftl


Modified: ofbiz/trunk/applications/order/config/OrderUiLabels.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderUiLabels.xml?rev=792402&r1=792401&r2=792402&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/applications/order/config/OrderUiLabels.xml  
(original)
+++ ofbiz/trunk/applications/order/config/OrderUiLabels.xml Thu  
Jul  9 05:22:02 2009

@@ -8569,6 +8569,9 @@
   สà’√à¸Ωà¸≠ภ 
à¸Ωà¸¡à¸”à’•à¸¡à¸·à’√ภ 
มีสิà¸˙à¸≥à’≈ด
   æ˛≈货昶镙å√°value>

   
+
+Shipping Notes
+
   
   Versandanfrage
   Ship Request

Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/ 
shoppingcart/CheckOutEvents.java

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java?rev=792402&r1=792401&r2=792402&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ 
CheckOutEvents.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ 
CheckOutEvents.java Thu Jul  9 05:22:02 2009

@@ -667,6 +667,7 @@
   String shipBeforeDate = null;
   String shipAfterDate = null;
   String internalOrderNotes = null;
+String shippingNotes = null;

   String mode = request.getParameter("finalizeMode");
   Debug.logInfo("FinalizeMode: " + mode, module);
@@ -784,8 +785,9 @@
   shipBeforeDate =  
request.getParameter(shipGroupIndex + "_shipBeforeDate");
   shipAfterDate =  
request.getParameter(shipGroupIndex + "_shipAfterDate");
   internalOrderNotes =  
request.getParameter("internal_order_notes");
+shippingNotes =  
request.getParameter("shippingNotes");


-callResult =  
checkOutHelper.finalizeOrderEntryOptions(shipGroupIndex,  
shippingMethod, shippingInstructions, maySplit, giftMessage,  
isGift, internalCode, shipBeforeDate, shipAfterDate,  
internalOrderNotes);
+callResult =  
checkOutHelper.finalizeOrderEntryOptions(shipGroupIndex,  
shippingMethod, shippingInstructions, maySplit, giftMessage,  
isGift, internalCode, shipBeforeDate, shipAfterDate,  
internalOrderNotes, shippingNotes);
   ServiceUtil.addErrors(errorMessages, errorMaps,  
callResult);

   }
   }

Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/ 
shoppingcart/CheckOutHelper.java

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java?rev=792402&r1=792401&r2=792402&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ 
CheckOutHelper.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ 
CheckOutHelper.java Thu Jul  9 05:22:02 2009

@@ -1310,12 +1310,12 @@
* any error messages
*/
   public Map finalizeOrderEntryOptions(int shipGroupIndex, String  
shippingMethod, String shippingInstructions, String maySplit,
-String giftMessage, String isGift, String  
internalCode, String shipBeforeDate, String shipAfterDate, String  
orderAdditionalEmails, String internalOrderNotes) {
+String giftMessage, String isGift, String  
internalCode, String shipBeforeDate, String shipAfterDate, String  
orderAdditionalEmails) {

   this.cart.setOrderAdditionalEmails(orderAdditionalEmails);
-return finalizeOrder

Verify Pick Process

[Vikas Mayur]

Hi,

I have introduced a feature called Verify Pick in Facility component  
few months back based on a requirement. I was reviewing the code more  
closely and found some issues.


The pre-condition to run this process is that order is in approved  
status.


Steps to do Verify Pick are:

1) Create a Sales Order without split shipment option. Order should be  
in approved status.

2) Go to Facility and select the WebStoreWarehouse facility.
3) Lets first check whether the order is ready to pick or need stock  
move. To do this go to Picking tab.

4) If the order is ready to pick then click on Verify Pick tab.
5) Enter the order Id and click Verify Order. This will show the list  
of the items that need to be verified, by default all of the items are  
selected.

6) Click on Verify Items.
7) This will display the summary in another list at the bottom. User  
have the option to either cancel or complete the verify order process.

8) Click on Complete button to verify the order.

If step 8 is a success then it will create a shipment in Picked status  
and as well as generate an invoice with In-Process status. The  
existing code was working fine but not implemented correctly as it end  
up creating just an Invoice and Invoice Items at max but there are  
certain other processes (entities where data is stored as well) when  
an invoice is created as implemented in createInvoiceForOrder service  
in InvoiceService class.


There is also an eca on updateShipment service which look for shipment  
in PACKED status and then create the invoice. The service triggered on  
eca is createInvoicesFromShipment. This service then finally call  
createInvoiceForOrder and which create Invoice with In-Process status,  
Invoice Items as well few other things as well.


Depending on the ProductStore.autoApproveInvoice flag, the status of  
invoice is changed to INVOICE_READY and finally payment is captured by  
capturePaymentsByInvoice triggered on eca rule defined on  
createInvoiceForOrder. Finally, the invoice goes to PAID status,  
Payments are captured and applied.


Coming back to my question a little bit, in the Verify Order step 8, I  
do not want to capture payment and which is logical because Invoice  
status is In-Process status.


My question is why payment is captured when the invoice status is In- 
Process? Shouldn't the system look for Invoice Ready status to capture  
the payments.


If what I said above is true, I could use the existing artifacts and  
do some changes so that system validate against the invoice status  
before doing a capture.


Any suggestions are most welcome and appreciated.

Thanks,
Vikas

Re: Verify Pick Process

[Vikas Mayur]

I did some changes for what I described earlier and I think this would  
be the correct way to generate invoice for shipment. Changes are  
copied below for reference.


Vikas


Index: applications/product/src/org/ofbiz/shipment/verify/ 
VerifyPickSession.java

===
--- applications/product/src/org/ofbiz/shipment/verify/ 
VerifyPickSession.java	(revision 793812)
+++ applications/product/src/org/ofbiz/shipment/verify/ 
VerifyPickSession.java	(working copy)

@@ -303,12 +303,10 @@
 // check reserved quantity, it should be equal to verified  
quantity

 this.checkReservedQty(orderId, locale);
 String shipmentId =  
this.createShipment((this.getPickRows(orderId)).get(0));

+
 this.issueItemsToShipment(shipmentId, locale);
-invoiceId = this.createInvoice(orderId);
-for (VerifyPickSessionRow line: this.getPickRows(orderId)) {
-invoiceItemSeqId = this.createInvoiceItem(line,  
invoiceId, shipmentId);

-line.setInvoiceItemSeqId(invoiceItemSeqId);
-}
+Map context = UtilMisc.toMap("shipmentId", shipmentId,  
"userLogin", this.getUserLogin());
+this.getDispatcher().runSync("createInvoicesFromShipment",  
context);

 return shipmentId;
 }

@@ -419,45 +417,4 @@
 String shipmentId = (String) newShipResp.get("shipmentId");
 return shipmentId;
 }
-
-protected String createInvoice(String orderId) throws  
GeneralException {

-GenericDelegator delegator = this.getDelegator();
-Map createInvoiceContext = FastMap.newInstance();
-GenericValue orderHeader = delegator.findOne("OrderHeader",  
UtilMisc.toMap("orderId", orderId), false);
-GenericValue billingAccount =  
orderHeader.getRelatedOne("BillingAccount");
-String billingAccountId = billingAccount != null ?  
billingAccount.getString("billingAccountId") : null;
-createInvoiceContext.put("partyId",  
(EntityUtil.getFirst(delegator.findByAnd("OrderRole",  
UtilMisc.toMap("orderId", orderId, "roleTypeId",  
"BILL_TO_CUSTOMER".getString("partyId"));
-createInvoiceContext.put("partyIdFrom",  
(EntityUtil.getFirst(delegator.findByAnd("OrderRole",  
UtilMisc.toMap("orderId", orderId, "roleTypeId",  
"BILL_FROM_VENDOR".getString("partyId"));

-createInvoiceContext.put("billingAccountId", billingAccountId);
-createInvoiceContext.put("invoiceTypeId", "SALES_INVOICE");
-createInvoiceContext.put("statusId", "INVOICE_IN_PROCESS");
-createInvoiceContext.put("currencyUomId",  
orderHeader.getString("currencyUom"));

-createInvoiceContext.put("userLogin", this.getUserLogin());
-Map createInvoiceResult =  
this.getDispatcher().runSync("createInvoice", createInvoiceContext);

-if (ServiceUtil.isError(createInvoiceResult)) {
-throw new  
GeneralException(ServiceUtil.getErrorMessage(createInvoiceResult));

-}
-String invoiceId = (String)  
createInvoiceResult.get("invoiceId");

-return invoiceId;
-}
-
-protected String createInvoiceItem(VerifyPickSessionRow line,  
String invoiceId, String shipmentId) throws GeneralException {

-Map createInvoiceItemContext = FastMap.newInstance();
-createInvoiceItemContext.put("invoiceId", invoiceId);
-createInvoiceItemContext.put("orderId", line.getOrderId());
-createInvoiceItemContext.put("invoiceItemTypeId",  
"INV_FPROD_ITEM");

-createInvoiceItemContext.put("productId", line.getProductId());
-createInvoiceItemContext.put("quantity",  
line.getReadyToVerifyQty());

-createInvoiceItemContext.put("userLogin", this.getUserLogin());
-Map createInvoiceItemResult =  
this.getDispatcher().runSync("createInvoiceItem",  
createInvoiceItemContext);

-if (ServiceUtil.isError(createInvoiceItemResult)) {
-throw new  
GeneralException(ServiceUtil.getErrorMessage(createInvoiceItemResult));

-}
-String invoiceItemSeqId = (String)  
createInvoiceItemResult.get("invoiceItemSeqId");
-GenericValue shipmentItemBilling =   
this.getDelegator().makeValue("ShipmentItemBilling",  
UtilMisc.toMap("invoiceId", invoiceId, "invoiceItemSeqId",  
invoiceItemSeqId));

-shipmentItemBilling.put("shipmentId", shipmentId);
-shipmentItemBilling.put("shipmentItemSeqId",  
line.getShipmentItemSeqId());

-shipmentItemBilling.create();
-return invoiceItemSeqId;
-}
 }
\

Re: Verify Pick Process

[Vikas Mayur]

On Jul 15, 2009, at 7:21 PM, Jacopo Cappellato wrote:

Coming back to my question a little bit, in the Verify Order step  
8, I do not want to capture payment and which is logical because  
Invoice status is In-Process status.


My question is why payment is captured when the invoice status is  
In-Process? Shouldn't the system look for Invoice Ready status to  
capture the payments.




A simple solution: we could add a flag in the product store like  
this: ProductStore.autoCapturePayments (default is Y).


But then the problem is that we need an easy way to capture payments  
at a later moment (and not risk to forget them); we could do this  
based on the invoice status or on another shipment status or  
manually (but providing a good report/screen); what is your use  
case? when do you want to capture payments?


thanks for your comments, Jacopo!

The use case is

1. Picker picks the items and collect them in a bin and pass this bin  
along with Pick Sheet to Pick Verifier.
2. Pick Verifier verify the order items in bin against the Pick Sheet  
and if all the items does match with items listed on Pick Sheet, the  
Pick Verifier completes the verification.
3. Once the verification is complete, a shipment is created in PICKED  
status. Items are also issued at this moment and an invoice is created  
with In-Process status.


We are not doing payment capture at this moment.

Payment capture only happens when packing is complete.

Vikas

Re: Verify Pick Process

[Vikas Mayur]

On Jul 16, 2009, at 1:08 AM, David E Jones wrote:

My question is why payment is captured when the invoice status is  
In-Process? Shouldn't the system look for Invoice Ready status to  
capture the payments.


If what I said above is true, I could use the existing artifacts  
and do some changes so that system validate against the invoice  
status before doing a capture.


Yes, that sounds like the correct way to go. The payment capture  
trigger should not do anything if the invoice that triggered it is  
not in the Ready status (and perhaps just in that status, ie it  
shouldn't do anything in the In-Process status or the received  
status or anything.


I haven't dug into the code to see if it is needed to add the option  
that Jacopo mentioned. My opinion right now is that the current  
behavior is wrong and should be corrected, ie the trigger shouldn't  
cause payment capture for an invoice that isn't Ready.


thanks David for looking into it. I do have the same thought to do the  
correction to current behavior. I will start looking into it.


Jacopo, Do you have any thoughts with the new field on ProductStore  
you mentioned earlier?

Re: Verify Pick Process

[Vikas Mayur]

On Jul 16, 2009, at 12:35 PM, Jacopo Cappellato wrote:



On Jul 16, 2009, at 6:33 AM, Vikas Mayur wrote:



On Jul 16, 2009, at 1:08 AM, David E Jones wrote:

My question is why payment is captured when the invoice status is  
In-Process? Shouldn't the system look for Invoice Ready status to  
capture the payments.


If what I said above is true, I could use the existing artifacts  
and do some changes so that system validate against the invoice  
status before doing a capture.


Yes, that sounds like the correct way to go. The payment capture  
trigger should not do anything if the invoice that triggered it is  
not in the Ready status (and perhaps just in that status, ie it  
shouldn't do anything in the In-Process status or the received  
status or anything.


I haven't dug into the code to see if it is needed to add the  
option that Jacopo mentioned. My opinion right now is that the  
current behavior is wrong and should be corrected, ie the trigger  
shouldn't cause payment capture for an invoice that isn't Ready.


thanks David for looking into it. I do have the same thought to do  
the correction to current behavior. I will start looking into it.


Jacopo, Do you have any thoughts with the new field on ProductStore  
you mentioned earlier?




If, as David and you are saying, we will attach the  
"capturePaymentsByInvoice" to the status change of the invoice (to  
Invoice ready), and detach it from the "createInvoiceForOrder"  
service, then we don't probably need the field in the store.


In fact:

a) if ProductStore.autoApproveInvoice = Y then the invoice will be  
automatically moved to the ready status, this will trigger the  
capturePaymentsByInvoice sservice and everything will work as now
b) if ProductStore.autoApproveInvoice = N then the invoice will stay  
in the in-process status and payments will not be captured


We may have to redesign the way ECA rules are defined; here is what  
I would suggest (it should work and be enough flexible):


updateShipment --> PICKED: trigger createInvoiceForOrder (invoice in  
status IN PROCESS)
ProductStore.autoApproveInvoice = Y: calls updateInvoice to status  
READY
updateShipment --> PACKED: trigger updateInvoice to status READY (it  
is important to pass thru the status PICKED or make sure that  
invoices are created before the call to updateInvoice)

updateInvoice --> READY: trigger capturePaymentsByInvoice

Note: the above are just very generic notes and we will probably  
have to create small services for the above ECAs: for examplewhen a  
shipment is moved to PACKED then we will have to attach a service  
that find out all the invoices associated to the shipment and then  
for each of them it calls the updateInvoice service (in my notes I  
have simplified it saying that the event will call the updateInvoice  
Service)




Thanks Jacopo, Your notes helped a lot. I have attached a patch at 
https://issues.apache.org/jira/browse/OFBIZ-2740

I have tested the patch with various scenarios and it is working fine  
as desired. I will be doing some more testing and later on make the  
necessary changes to the Verify Pick process once this patch is in  
trunk.


Vikas


Jacopo

Re: Verify Pick Process

[Vikas Mayur]

This is fixed in rev. 795809 and 795814.

Now do we want to have ProductStore.autoApproveInvoice == N as default  
for OFBiz E-Commerce Store?


Vikas

On Jul 20, 2009, at 2:49 PM, Vikas Mayur wrote:



On Jul 16, 2009, at 12:35 PM, Jacopo Cappellato wrote:



On Jul 16, 2009, at 6:33 AM, Vikas Mayur wrote:



On Jul 16, 2009, at 1:08 AM, David E Jones wrote:

My question is why payment is captured when the invoice status  
is In-Process? Shouldn't the system look for Invoice Ready  
status to capture the payments.


If what I said above is true, I could use the existing artifacts  
and do some changes so that system validate against the invoice  
status before doing a capture.


Yes, that sounds like the correct way to go. The payment capture  
trigger should not do anything if the invoice that triggered it  
is not in the Ready status (and perhaps just in that status, ie  
it shouldn't do anything in the In-Process status or the received  
status or anything.


I haven't dug into the code to see if it is needed to add the  
option that Jacopo mentioned. My opinion right now is that the  
current behavior is wrong and should be corrected, ie the trigger  
shouldn't cause payment capture for an invoice that isn't Ready.


thanks David for looking into it. I do have the same thought to do  
the correction to current behavior. I will start looking into it.


Jacopo, Do you have any thoughts with the new field on  
ProductStore you mentioned earlier?




If, as David and you are saying, we will attach the  
"capturePaymentsByInvoice" to the status change of the invoice (to  
Invoice ready), and detach it from the "createInvoiceForOrder"  
service, then we don't probably need the field in the store.


In fact:

a) if ProductStore.autoApproveInvoice = Y then the invoice will be  
automatically moved to the ready status, this will trigger the  
capturePaymentsByInvoice sservice and everything will work as now
b) if ProductStore.autoApproveInvoice = N then the invoice will  
stay in the in-process status and payments will not be captured


We may have to redesign the way ECA rules are defined; here is what  
I would suggest (it should work and be enough flexible):


updateShipment --> PICKED: trigger createInvoiceForOrder (invoice  
in status IN PROCESS)
ProductStore.autoApproveInvoice = Y: calls updateInvoice to status  
READY
updateShipment --> PACKED: trigger updateInvoice to status READY  
(it is important to pass thru the status PICKED or make sure that  
invoices are created before the call to updateInvoice)

updateInvoice --> READY: trigger capturePaymentsByInvoice

Note: the above are just very generic notes and we will probably  
have to create small services for the above ECAs: for examplewhen a  
shipment is moved to PACKED then we will have to attach a service  
that find out all the invoices associated to the shipment and then  
for each of them it calls the updateInvoice service (in my notes I  
have simplified it saying that the event will call the  
updateInvoice Service)




Thanks Jacopo, Your notes helped a lot. I have attached a patch at 
https://issues.apache.org/jira/browse/OFBIZ-2740

I have tested the patch with various scenarios and it is working  
fine as desired. I will be doing some more testing and later on make  
the necessary changes to the Verify Pick process once this patch is  
in trunk.


Vikas


Jacopo

Re: svn commit: r795883 - in /ofbiz/trunk: applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webapp/ordermgr/WEB-INF/actions/entry/ applications/order/webapp/ordermgr/WEB-INF/act

[Vikas Mayur]

The functionality of receiving a Purchase Order is broken just after  
this commit. ProductStore is referred while creating an invoice for  
purchase order. See the reference in InvoiceServices class.


Steps to reproduce:
1. Create a purchase order.
2. Approve the order.
3. Under Actions block, Click on Quick Receive Purchase Order
4. Select the Shipment to Receive and click on Receive Selected Shipment
5. Select the checkbox Set Shipment As Received.
6. Click on Receive Selected Product(s)

Please update the trunk with the fix or revert this commit if it takes  
too much time.


Vikas

On Jul 20, 2009, at 9:22 PM, eckar...@apache.org wrote:


Author: eckardjf
Date: Mon Jul 20 15:52:05 2009
New Revision: 795883

URL: http://svn.apache.org/viewvc?rev=795883&view=rev
Log:
Changes to ShoppingCart & order entry to allow PO entry without  
requiring a ProductStore; updated seed data to remove productStoreId  
from the OrderEntry website


Modified:
   ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ 
CheckOutHelper.java
   ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ 
ShoppingCart.java
   ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/ 
entry/OptionSettings.groovy
   ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/ 
entry/OrderAgreements.groovy
   ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/ 
order/OrderView.groovy
   ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/ 
showcartitems.ftl
   ofbiz/trunk/applications/order/webapp/ordermgr/entry/ 
optionsettings.ftl
   ofbiz/trunk/applications/order/webapp/ordermgr/entry/ 
orderagreements.ftl

   ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml

Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/ 
shoppingcart/CheckOutHelper.java

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java?rev=795883&r1=795882&r2=795883&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ 
CheckOutHelper.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ 
CheckOutHelper.java Mon Jul 20 15:52:05 2009

@@ -789,8 +789,6 @@
}

private Map makeTaxContext(int shipGroup, GenericValue  
shipAddress, Map shoppingCartItemIndexMap) throws GeneralException {

-String productStoreId = cart.getProductStoreId();
-String billToPartyId = cart.getBillToCustomerPartyId();
ShoppingCart.CartShipInfo csi = cart.getShipInfo(shipGroup);
int totalItems = csi.shipItemInfo.size();

@@ -839,8 +837,9 @@
}
}

-Map serviceContext = UtilMisc.toMap("productStoreId",  
productStoreId);

-serviceContext.put("billToPartyId", billToPartyId);
+Map serviceContext = UtilMisc.toMap("productStoreId",  
cart.getProductStoreId());
+serviceContext.put("payToPartyId",  
cart.getBillFromVendorPartyId());
+serviceContext.put("billToPartyId",  
cart.getBillToCustomerPartyId());

serviceContext.put("itemProductList", product);
serviceContext.put("itemAmountList", amount);
serviceContext.put("itemPriceList", price);

Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/ 
shoppingcart/ShoppingCart.java

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java?rev=795883&r1=795882&r2=795883&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ 
ShoppingCart.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ 
ShoppingCart.java Mon Jul 20 15:52:05 2009

@@ -231,38 +231,35 @@

/** Creates new empty ShoppingCart object. */
public ShoppingCart(GenericDelegator delegator, String  
productStoreId, String webSiteId, Locale locale, String currencyUom,  
String billToCustomerPartyId, String billFromVendorPartyId) {

+
this.delegator = delegator;
this.delegatorName = delegator.getDelegatorName();
this.productStoreId = productStoreId;
this.webSiteId = webSiteId;
-this.currencyUom = currencyUom;
-this.locale = locale;
-if (this.locale == null) {
-this.locale = Locale.getDefault();
-}
+this.locale = (locale != null) ? locale :  
Locale.getDefault();
+this.currencyUom = (currencyUom != null) ? currencyUom :  
UtilProperties.getPropertyValue("general.properties",  
"currency.uom.id.default", "USD");

+this.billToCustomerPartyId = billToCustomerPartyId;
+this.billFromVendorPartyId = billFromVendorPartyId;

-if (productStoreId == null) {
-throw new IllegalArgumentException("productStoreId  
cannot be null");

-}
+if (productStoreId != null) 

Re: Question about bulk approve items.

[Vikas Mayur]

checkOrderItemStatus service is triggered everytime changeOrderItemStatus
service is invoked and this should move the status of order to approved once
every item on order goes into approved status?
Vikas

On Tue, Jul 21, 2009 at 6:34 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxmedia.com> wrote:

> yeah,
>
> Scott, you are mostly right... but we need to set the setItemStatus in
> parameter to Y if we want that the changeOrderStatus service will update
> order items.
> I'd say we can assume it as the default behavior for all the masschange
> service and probably we will not need to add the parameter to the masschange
> services.
>
> Jacopo
>
>
>
> On Jul 21, 2009, at 2:20 PM, Scott Gray wrote:
>
>  +1, you can just change the code as follows though right?
>> -  return massChangeItemStatus(dctx, context, "ITEM_APPROVED");
>> + return massChangeOrderStatus(dctx, context, "ORDER_APPROVED");
>>
>> Regards
>> Scott
>>
>> On 21/07/2009, at 11:55 PM, Jacopo Cappellato wrote:
>>
>>  From the search result page of the "find orders screen" it is possible to
>>> bulk "Approve orders" (selecting the proper action from the drop down field
>>> in the top right part of the list.
>>> However the event calls a service that only changes the order items to
>>> "approved", the order header is left in the "created" status.
>>> Wouldn't be better to change the code to call the "changeOrderStatus"
>>> service instead? This service is the one called from the "approve" link of
>>> the order detail screen and it approves both the header and the items.
>>>
>>> Jacopo
>>>
>>>
>>
>

Re: svn commit: r801882 - /ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/payment/ListNotAppliedInvoices.groovy

[Vikas Mayur]

Sumit, This fix is merged with release 09.04 in rev. 801907.

Vikas

On Aug 7, 2009, at 1:29 PM, Sumit Pandit wrote:


This fix should also reflect to released version - 9.04.

--
Thanks And Regards
Sumit Pandit
On Aug 7, 2009, at 10:32 AM, apa...@apache.org wrote:


Author: apatel
Date: Fri Aug  7 05:02:27 2009
New Revision: 801882

URL: http://svn.apache.org/viewvc?rev=801882&view=rev
Log:
Adding check to avoid NPE.

Modified:
  ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/ 
actions/payment/ListNotAppliedInvoices.groovy


Modified: ofbiz/trunk/applications/accounting/webapp/accounting/WEB- 
INF/actions/payment/ListNotAppliedInvoices.groovy

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/payment/ListNotAppliedInvoices.groovy?rev=801882&r1=801881&r2=801882&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/ 
actions/payment/ListNotAppliedInvoices.groovy (original)
+++ ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/ 
actions/payment/ListNotAppliedInvoices.groovy Fri Aug  7 05:02:27  
2009

@@ -65,7 +65,7 @@
   invoicesList = [];  // to pass back to the screeen list of  
unapplied invoices

   paymentApplied = PaymentWorker.getPaymentApplied(payment);
   paymentToApply =  
payment 
.getBigDecimal 
("amount").setScale(decimals,rounding).subtract(paymentApplied);

-if (actual) {
+if (actual && payment.actualCurrencyAmount) {
   paymentToApply =  
payment 
.getBigDecimal 
("actualCurrencyAmount 
").setScale(decimals,rounding).subtract(paymentApplied);

   }
   invoices.each { invoice ->








smime.p7s
Description: S/MIME cryptographic signature

Re: svn commit: r795884 - in /ofbiz/trunk/applications: order/config/OrderErrorUiLabels.xml product/webapp/facility/WEB-INF/actions/shipment/WeightPackage.groovy product/widget/facility/ShipmentScreen

[Vikas Mayur]

Hi Jacques,

Weigh Package Only was a new feature that was added after R9.04 and  
this commit was a minor improvement so this will not go in R9.04.


Regarding OFBIZ-2804, I am not really sure but since Joe fixed Product  
Store dependency on Purchase Orders in r795883 so he would be right  
person to comment on this.


Thanks,
Vikas


On Aug 17, 2009, at 8:10 PM, Jacques Le Roux wrote:


Hi Vikas,

Does this not need to be backported to R9.04 (along with r801770,  
please see https://issues.apache.org/jira/browse/OFBIZ-2804) ?  
Actually all this began because I wanted to close OFBIZ-2804.


Thanks

Jacques

From: 

Author: mor
Date: Mon Jul 20 15:54:40 2009
New Revision: 795884

URL: http://svn.apache.org/viewvc?rev=795884&view=rev
Log:
Minor correction to the label names and the script.

Modified:
  ofbiz/trunk/applications/order/config/OrderErrorUiLabels.xml
  ofbiz/trunk/applications/product/webapp/facility/WEB-INF/actions/ 
shipment/WeightPackage.groovy
  ofbiz/trunk/applications/product/widget/facility/ 
ShipmentScreens.xml


Modified: ofbiz/trunk/applications/order/config/ 
OrderErrorUiLabels.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderErrorUiLabels.xml?rev=795884&r1=795883&r2=795884&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/applications/order/config/OrderErrorUiLabels.xml  
(original)
+++ ofbiz/trunk/applications/order/config/OrderErrorUiLabels.xml  
Mon Jul 20 15:54:40 2009

@@ -658,7 +658,7 @@
   é”™è¯¯ï¼šæ²¡æœ‰ä¸ºè®¢å•æ ‡è¯†ï¼š$ 
{orderId} 找到有效的订单头 

   
   
-ERROR: Order #${orderId} has been  
already verified, go to Weight Package Only screen for further  
processing
+ERROR: Order #${orderId} has been  
already verified, go to Weigh Package Only screen for further  
processing

   
   
   ERROR: Order with ID [${orderId}] not  
found

@@ -709,7 +709,7 @@
   ใบสั่งซื้ภสภ
´à¸™à¸„้า ${orderId} ไม่เป็นรายกาภ
£à¸ªà¸±à¹ˆà¸‡à¸‹à¸·à¹‰à¸ 

   
   
-ERROR: Order #${orderId} is not  
verified, click Pack Order button instead of Weight Package Only  
for further processing
+ERROR: Order #${orderId} is not  
verified, click Pack Order button instead of Weigh Package Only for  
further processing

   
   
   ERROR: Order #${orderId} is not  
verified for packing


Modified: ofbiz/trunk/applications/product/webapp/facility/WEB-INF/ 
actions/shipment/WeightPackage.groovy

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/facility/WEB-INF/actions/shipment/WeightPackage.groovy?rev=795884&r1=795883&r2=795884&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/applications/product/webapp/facility/WEB-INF/ 
actions/shipment/WeightPackage.groovy (original)
+++ ofbiz/trunk/applications/product/webapp/facility/WEB-INF/ 
actions/shipment/WeightPackage.groovy Mon Jul 20 15:54:40 2009

@@ -94,10 +94,12 @@
   invoiceIds =  
EntityUtil.getFieldListFromEntityList(orderItemBillingList,  
"invoiceId", true);

   if (invoiceIds) {
   context.invoiceIds = invoiceIds;
-orderId = null;

   }
   }
+if (shipment.statusId && "SHIPMENT_PACKED" ==  
shipment.statusId) {

+orderId = null;
+}
   shipmentPackageRouteSegs =  
delegator.findByAnd("ShipmentPackageRouteSeg",  [shipmentId :  
shipmentId]);

   shipmentPackageRouteSegList = [];
   shipmentPackageRouteSegs.each { shipmentPackageRouteSeg ->

Modified: ofbiz/trunk/applications/product/widget/facility/ 
ShipmentScreens.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/facility/ShipmentScreens.xml?rev=795884&r1=795883&r2=795884&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/applications/product/widget/facility/ 
ShipmentScreens.xml (original)
+++ ofbiz/trunk/applications/product/widget/facility/ 
ShipmentScreens.xml Mon Jul 20 15:54:40 2009

@@ -301,7 +301,7 @@
   
   
   
-value="ProductWeightPackageOnly"/>
+value="ProductWeighPackageOnly"/>

   
   

   








smime.p7s
Description: S/MIME cryptographic signature

Re: ASL2 licence headers missing

[Vikas Mayur]

Jacques, Sorry about this if you think I responded too late.

Btw, I did a search and found only two files that were initially added  
by me.


applications/marketing/webapp/sfa/lead/mergeLeads.ftl - Fixed in trunk  
and R9.04 in rev. 807175 and 807177 resp.
specialpurpose/ecommerce/webapp/ecommerce/images/profile.js - Already  
fixed by Ashish (thanks Ashish!)


Vikas

On Aug 22, 2009, at 4:53 PM, Jacques Le Roux wrote:


Nobody cares ?

Jacques

From: "Jacques Le Roux" 

Hi,

Arghhh.. :( my ISP screwed up another time (ISP=SFR, don't even  
try : I'm cancelling right now). So for those interested (waiting
for patch to be commited etc.) I'm sorry but I'm with my analogic  
modem again (45 b/s) so can't do much :/


I have added some ASL2 licence header to some files where they were  
missing and commited them at r805307 and r806127
I consider this as a bug (these files should have a licence header  
and it can't hurt) so I will also backport to R9.04


There are some other files in the same situation. Maybe some do not  
require any licence headers but it is worth to check...
I ask here for some help from the persons who created these files  
and some questions too.
Please consider each file in each block if you are concerned (you  
created or commited 1st the file), thanks!


Why not putting a licence header in these files too ?
.classpath
.project

applications/marketing/data/sfaDemoData.xml
applications/marketing/webapp/marketing/contact/ 
ContactCommunicationPreview.ftl

applications/marketing/webapp/sfa/lead/mergeLeads.ftl

applications/securityext/src/org/ofbiz/securityext/test/ 
AuthorizationTests.java
applications/securityext/src/org/ofbiz/securityext/test/ 
DaTest2.groovy


debian/compat
debian/copyright.in
debian/ofbiz-framework.dirs
debian/ofbiz-framework.links
debian/ofbiz-framework.logrotate
debian/ofbiz-framework.templates
debian/po/POTFILES.in
debian/po/templates.pot

framework/appserver/templates/jboss422/application.xml
framework/appserver/templates/jboss422/deploy.sh
framework/appserver/templates/jboss422/run.conf
framework/appserver/templates/jboss422/patches/jboss-ee-cfg.patch

framework/base/cert/demoCA/index.txt
framework/base/cert/demoCA/index.txt.attr
framework/base/cert/demoCA/index.txt.attr.old
framework/base/cert/demoCA/index.txt.old
framework/base/cert/demoCA/serial
framework/base/cert/demoCA/serial.old

framework/base/src/org/ofbiz/base/util/NotifyLevel.java

framework/bi/webapp/bi/main.ftl

framework/catalina/src/org/ofbiz/catalina/container/ 
CrossSubdomainSessionValve.java


framework/entity/src/org/ofbiz/entity/connection/ 
ConnectionFactoryInterface.java
framework/entity/src/org/ofbiz/entity/connection/ 
DBCPConnectionFactory.java


framework/example/security/CreateExample.groovy
framework/example/security/UpdateExample.groovy

framework/images/webapp/images/calendar_date_select.js
framework/images/webapp/images/jsgantt.css
framework/images/webapp/images/jsgantt.js
framework/images/webapp/images/tabstyles.css

framework/images/webapp/images/dojo/build.txt

framework/resources/templates/AdminUserLoginData.xml
framework/resources/templates/CommonScreens.xml
framework/resources/templates/DemoData.xml
framework/resources/templates/Forms.xml
framework/resources/templates/Menus.xml
framework/resources/templates/Screens.xml
framework/resources/templates/SecurityData.xml
framework/resources/templates/Tests.xml
framework/resources/templates/TypeData.xml
framework/resources/templates/UiLabels.xml
framework/resources/templates/build.xml
framework/resources/templates/controller.xml
framework/resources/templates/entitymodel.xml
framework/resources/templates/error.jsp
framework/resources/templates/index.jsp
framework/resources/templates/ofbiz-component.xml
framework/resources/templates/services.xml
framework/resources/templates/web.xml

framework/service/src/org/ofbiz/service/semaphore/ 
SemaphoreFailException.java
framework/service/src/org/ofbiz/service/semaphore/ 
SemaphoreWaitException.java
framework/service/src/org/ofbiz/service/semaphore/ 
ServiceSemaphore.java


framework/start/src/org/ofbiz/base/start/Start.mf

framework/testtools/convertSeleniumIDE.bat
framework/testtools/convertSeleniumIDE.sh
framework/testtools/runSeleniumServer.bat
framework/testtools/runSeleniumServer.sh
framework/testtools/runSeleniumXml.bat
framework/testtools/runSeleniumXml.sh
framework/testtools/config/seleniumXml.properties
framework/testtools/testdef/seleniumxml/example/example_ajax.xml
framework/testtools/testdef/seleniumxml/example/example_login.xml
framework/testtools/testdef/seleniumxml/example/example_new.xml
framework/testtools/testdef/seleniumxml/example/example_search.xml
framework/testtools/testdef/seleniumxml/example/example_testsuite.xml
framework/testtools/testdef/seleniumxml/example/recorded/ 
AjaxExample.html
framework/testtools/testdef/seleniumxml/example/recorded/ 
AjaxExample.xml
framework/testtools/testdef/seleniumxml/example/recorded/ 
NewExample.html
framework/testtools/testdef/se

Re: svn commit: r810814 - in /ofbiz/trunk/applications/order: config/OrderUiLabels.xml webapp/ordermgr/entry/catalog/productsummary.ftl

[Vikas Mayur]

Just wanted to know when to prefix the component name with the key.  
AFAIK, the labels except those with prefix FormFieldTitle_ starts with  
the component name.


Vikas

On Sep 3, 2009, at 2:11 PM, jler...@apache.org wrote:


Author: jleroux
Date: Thu Sep  3 08:41:24 2009
New Revision: 810814

URL: http://svn.apache.org/viewvc?rev=810814&view=rev
Log:
A patch from Carsten Schinzer "ordermgr webapp - catalog -  
productsummary contains hard coded labels" (https://issues.apache.org/jira/browse/OFBIZ-OFBIZ-2856 
) - OFBIZ-2856


Modified:
   ofbiz/trunk/applications/order/config/OrderUiLabels.xml
   ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/ 
productsummary.ftl


Modified: ofbiz/trunk/applications/order/config/OrderUiLabels.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderUiLabels.xml?rev=810814&r1=810813&r2=810814&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==

--- ofbiz/trunk/applications/order/config/OrderUiLabels.xml (original)
+++ ofbiz/trunk/applications/order/config/OrderUiLabels.xml Thu Sep   
3 08:41:24 2009

@@ -10455,5 +10455,15 @@

Ship to Country

+
+Größe
+Size
+Taille
+
+
+Verfügbare Größen
+Sizes Available
+Tailles Disponibles
+




smime.p7s
Description: S/MIME cryptographic signature

Re: ofbiz Business Intellegence Documentation

[Vikas Mayur]

Hi,

Jacopo had given a presentation on this module during ApacheCon US  
2008 and the content of this presentation was located at http://us.apachecon.com/c/acus2008/sessions/123


but I see now the content has been moved to somewhere else by ASF. I  
think we need to bring up this thing at some point regarding the  
archives of original content of the presentation in ApacheCon.


Vikas

On Sep 11, 2009, at 11:55 AM, Anil Sharma wrote:



Hello Everybody,

Can anyone please give me a link where I can find out how Business
Intellegence module work in ofbiz

Thanks.
--
View this message in context: 
http://www.nabble.com/ofbiz-Business-Intellegence-Documentation-tp25395695p25395695.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Re: svn commit: r814553 - /ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml

[Vikas Mayur]

My initial thought was to have a user acceptance. Lets have it in  
there for sometime, if there is too much objection then acceptance we  
can pull it back.


Btw, We can implement this similar to checkout options where user can  
use any of the options based on his choice.


Vikas

On Sep 14, 2009, at 5:33 PM, Jacques Le Roux wrote:


I'm really not sure I prefer this one, why do we change ?

Jacques

From: 

Author: mor
Date: Mon Sep 14 10:08:27 2009
New Revision: 814553

URL: http://svn.apache.org/viewvc?rev=814553&view=rev
Log:
Changed the new profiles pages added a year back as the default one.

Modified:
  ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml

Modified: ofbiz/trunk/specialpurpose/ecommerce/widget/ 
CustomerScreens.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml?rev=814553&r1=814552&r2=814553&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml  
(original)
+++ ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml  
Mon Sep 14 10:08:27 2009

@@ -39,7 +39,8 @@
   
   
   
-
+

+
   
   
   
@@ -518,8 +520,7 @@
   
   
   
-

-

   
   

Re: svn commit: r814553 - /ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml

[Vikas Mayur]

Okay, this is reverted in rev. 816469 because of several reasons

1. The services written for these new pages need to be revisited again  
and are not mature yet. (Making them default would put them into use  
and hence going forward any reported issues would have been fixed)
2. With recent changes to the page structure, the layout of these  
pages need to be fixed.

3. And finally because all of you voted against it.

As an alternate option we can show links for both profile pages  
similar to checkout options as I mentioned earlier. I will look into  
the possibilities so that every one is happy :)


Vikas

On Sep 18, 2009, at 4:33 AM, Tim Ruppert wrote:


+1

Cheers,
Ruppert
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595

On Sep 17, 2009, at 12:58 PM, Jacques Le Roux wrote:


Thanks Rishi,

No other opinions ?

Jacques

From: "Rishi Solanki" 
IMO, We should keep the both profiles as we keep all checkout and  
from a

configuration screen go for one.
If it takes time then we should go for the older style profile as  
Jacques

says, and keep the old profile for now.

Rishi Solanki
Enterprise Software Developer
HotWax Media Pvt. Ltd.


On Thu, Sep 17, 2009 at 2:32 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Hi Vikas,

I'm sorry but I disagree with this change. As this stage, I'd far  
prefer to

keep the old profile wich has much more options and looks better.
So I ask the community opinion about that.
You can still see the old profile if you run an R9.04 version or at
http://ofbiz-vm.apache.org/ (
http://demo904.ofbiz.org/ecommerce/control/main fails at the  
moment)

You can see the new provilei if you run the trunk or at
http://demo.ofbiz.org/ecommerce/control/main but it fails at the  
moment,
you may try http://lamouline.myvnc.com:28080/ecommerce during  
Europe

nights (GMT+2)

Thanks

Jacques

From: 


Author: mor

Date: Mon Sep 14 10:08:27 2009
New Revision: 814553

URL: http://svn.apache.org/viewvc?rev=814553&view=rev
Log:
Changed the new profiles pages added a year back as the default  
one.


Modified:
ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml

Modified: ofbiz/trunk/specialpurpose/ecommerce/widget/ 
CustomerScreens.xml

URL:
http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/widget/CustomerScreens.xml?rev=814553&r1=814552&r2=814553&view=diff

= 
= 
= 
= 
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/specialpurpose/ecommerce/widget/ 
CustomerScreens.xml

(original)
+++ ofbiz/trunk/specialpurpose/ecommerce/widget/ 
CustomerScreens.xml Mon

Sep 14 10:08:27 2009
@@ -39,7 +39,8 @@
 
 
 
-
+
+
 
 
 
@@ -518,8 +520,7 @@
 
 
 
-
-

 
 

Re: svn commit: r820578 - in /ofbiz/trunk: applications/marketing/config/ applications/marketing/webapp/sfa/party/ applications/marketing/widget/sfa/ applications/marketing/widget/sfa/forms/ applicati

[Vikas Mayur]

Hans,

Please see my comments inline.

Btw, I think there are certain simple things that are easier to catch  
on first review before committing code, like this one :)


Thanks,
Vikas

On Oct 1, 2009, at 2:30 PM, hans...@apache.org wrote:


--- ofbiz/trunk/applications/party/config/PartyUiLabels.xml (original)
+++ ofbiz/trunk/applications/party/config/PartyUiLabels.xml Thu Oct   
1 09:00:19 2009

@@ -10086,4 +10086,22 @@
ไม่ได้ใส่รหภ
±à¸ªà¹„ปรษณีย์/รหัสพื้นที่

æ‰¾ä¸åˆ°é‚®æ”¿ç¼–ç 

+
+Related Company
+


Key should prefix the name of the component so that key should  
PartyRelatedCompany




+
+Party Id From
+


This exists in other component as well.



+
+Status ID
+

+
+Created
+

+
+Send
+


Duplicates. All three labels already exists in CommonUiLabels



+
+Create Opportunity
+


Might have been a more consistent and simple name for the key?

Re: File name pattern (Fwd: svn commit: r822169 - in /ofbiz/trunk/applications/marketing: ofbiz-component.xml testdef/MarketingTests.xml testdef/SeleniumTests.xml testdef/commeventCreateOpportunity_te

[Vikas Mayur]

+1

Btw, I also see issues with test data file location. Since it is just  
a data file I think it should be in data folder and not testdef.


I think we should also discuss about the naming pattern of data files,  
most of the files end with suffix Data but this pattern is not  
followed strictly.


Any thoughts?

Vikas

On Oct 7, 2009, at 1:19 AM, Anil Patel wrote:


Hi,
I have problem with the naming of  
commeventCreateOpportunity_testsuite.xml


This should be rather named commEventCreateOpportunityTests.xml. I  
don't see reason why we cannot stick to file naming conventions  
already in place. Its important indicator of quality of product.


Thanks and Regards
Anil Patel
HotWax Media Inc
http://www.hotwaxmedia.com

Begin forwarded message:


From: hans...@apache.org
Date: October 6, 2009 4:47:36 AM EDT
To: comm...@ofbiz.apache.org
Subject: svn commit: r822169 - in /ofbiz/trunk/applications/ 
marketing: ofbiz-component.xml testdef/MarketingTests.xml testdef/ 
SeleniumTests.xml testdef/commeventCreateOpportunity_testsuite.xml

Reply-To: dev@ofbiz.apache.org

Author: hansbak
Date: Tue Oct  6 08:47:35 2009
New Revision: 822169

URL: http://svn.apache.org/viewvc?rev=822169&view=rev
Log:
added a selenium test when a opportunity is created from an email

Added:
  ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml
(with props)
  ofbiz/trunk/applications/marketing/testdef/ 
commeventCreateOpportunity_testsuite.xml   (with props)

Modified:
  ofbiz/trunk/applications/marketing/ofbiz-component.xml
  ofbiz/trunk/applications/marketing/testdef/MarketingTests.xml

Modified: ofbiz/trunk/applications/marketing/ofbiz-component.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/ofbiz-component.xml?rev=822169&r1=822168&r2=822169&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
=

--- ofbiz/trunk/applications/marketing/ofbiz-component.xml (original)
+++ ofbiz/trunk/applications/marketing/ofbiz-component.xml Tue Oct   
6 08:47:35 2009

@@ -30,6 +30,7 @@
   location="data/MarketingSecurityData.xml"/>
   location="data/MarketingHelpData.xml"/>
   location="data/sfaDemoData.xml"/>
+location="testdef/SeleniumTests.xml"/>
   location="servicedef/services.xml"/>
   location="servicedef/services_opportunity.xml"/>
   


Modified: ofbiz/trunk/applications/marketing/testdef/ 
MarketingTests.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/testdef/MarketingTests.xml?rev=822169&r1=822168&r2=822169&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/applications/marketing/testdef/MarketingTests.xml  
(original)
+++ ofbiz/trunk/applications/marketing/testdef/MarketingTests.xml  
Tue Oct  6 08:47:35 2009

@@ -1,3 +1,4 @@
+

-
http://www.w3.org/2001/XMLSchema-instance";
   xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/test-suite.xsd 
">


Added: ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml?rev=822169&view=auto
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml  
(added)
+++ ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml  
Tue Oct  6 08:47:35 2009

@@ -0,0 +1,22 @@
+
+
+
+testSuiteName="commeventopportunity_testsuite"  
testSuitePath="applications/marketing/testdef/ 
commeventCreateOpportunity_testsuite.xml" description="test suite  
for create opportunity from communications event"/>

+

Propchange: ofbiz/trunk/applications/marketing/testdef/ 
SeleniumTests.xml

--
  svn:eol-style = native

Propchange: ofbiz/trunk/applications/marketing/testdef/ 
SeleniumTests.xml

--
  svn:keywords = "Date Rev Author URL Id"

Propchange: ofbiz/trunk/applications/marketing/testdef/ 
SeleniumTests.xml

--
  svn:mime-type = text/xml

Added: ofbiz/trunk/applications/marketing/testdef/ 
commeventCreateOpportunity_testsuite.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/testdef/commeventCreateOpportunity_testsuite.xml?rev=822169&view=auto
= 
= 
= 
= 
= 
= 
= 
= 
= 
=
--- ofbiz/trunk/applications/marketing/testdef/ 
commeventCreateOpportunity_testsuite.xml (added)
+++ ofbiz/trunk/applications/marketing/testdef/ 
commeventCreateOpportunity_testsuite.xml Tue Oct  6 08:47:35 2009

@@ -0,0 +1,49 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+option="label=Email" />
+option="label=Entered" />

+
+
+option="label=Internal Note via partyId" />
+

Re: File name pattern (Fwd: svn commit: r822169 - in /ofbiz/trunk/applications/marketing: ofbiz-component.xml testdef/MarketingTests.xml testdef/SeleniumTests.xml testdef/commeventCreateOpportunity_te

[Vikas Mayur]

Hi Hans,

Thanks for your reply. I would say its always better to form a pattern  
in early stage of the development.


Vikas

On Oct 7, 2009, at 2:21 PM, Hans Bakker wrote:


Hi Vikas,
This is new feature, these selenium tests. We are using it for our
customers and are looking now how to integrate it best in the current
test structure together with junit tests

At the moment we would like the test data to be together and over time
we will get the naming conventions as much as possible in line with  
the

junit tests.

We should also consider to upgrade junit itself. 7 jears old now.

Regards,
Hans

On Wed, 2009-10-07 at 14:08 +0530, Vikas Mayur wrote:

+1

Btw, I also see issues with test data file location. Since it is just
a data file I think it should be in data folder and not testdef.

I think we should also discuss about the naming pattern of data  
files,

most of the files end with suffix Data but this pattern is not
followed strictly.

Any thoughts?

Vikas

On Oct 7, 2009, at 1:19 AM, Anil Patel wrote:


Hi,
I have problem with the naming of
commeventCreateOpportunity_testsuite.xml

This should be rather named commEventCreateOpportunityTests.xml. I
don't see reason why we cannot stick to file naming conventions
already in place. Its important indicator of quality of product.

Thanks and Regards
Anil Patel
HotWax Media Inc
http://www.hotwaxmedia.com

Begin forwarded message:


From: hans...@apache.org
Date: October 6, 2009 4:47:36 AM EDT
To: comm...@ofbiz.apache.org
Subject: svn commit: r822169 - in /ofbiz/trunk/applications/
marketing: ofbiz-component.xml testdef/MarketingTests.xml testdef/
SeleniumTests.xml testdef/commeventCreateOpportunity_testsuite.xml
Reply-To: dev@ofbiz.apache.org

Author: hansbak
Date: Tue Oct  6 08:47:35 2009
New Revision: 822169

URL: http://svn.apache.org/viewvc?rev=822169&view=rev
Log:
added a selenium test when a opportunity is created from an email

Added:
 ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml
(with props)
 ofbiz/trunk/applications/marketing/testdef/
commeventCreateOpportunity_testsuite.xml   (with props)
Modified:
 ofbiz/trunk/applications/marketing/ofbiz-component.xml
 ofbiz/trunk/applications/marketing/testdef/MarketingTests.xml

Modified: ofbiz/trunk/applications/marketing/ofbiz-component.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/ofbiz-component.xml?rev=822169&r1=822168&r2=822169&view=diff
=
=
=
=
=
=
=
=
=
= 
= 
===
--- ofbiz/trunk/applications/marketing/ofbiz-component.xml  
(original)

+++ ofbiz/trunk/applications/marketing/ofbiz-component.xml Tue Oct
6 08:47:35 2009
@@ -30,6 +30,7 @@
  
  
  
+
  
  
  

Modified: ofbiz/trunk/applications/marketing/testdef/
MarketingTests.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/testdef/MarketingTests.xml?rev=822169&r1=822168&r2=822169&view=diff
=
=
=
=
=
=
=
=
=
= 
= 
===

--- ofbiz/trunk/applications/marketing/testdef/MarketingTests.xml
(original)
+++ ofbiz/trunk/applications/marketing/testdef/MarketingTests.xml
Tue Oct  6 08:47:35 2009
@@ -1,3 +1,4 @@
+

-
http://www.w3.org/2001/XMLSchema-instance";
  xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/test-suite.xsd
">

Added: ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml?rev=822169&view=auto
=
=
=
=
=
=
=
=
=
= 
= 
===

--- ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml
(added)
+++ ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml
Tue Oct  6 08:47:35 2009
@@ -0,0 +1,22 @@
+
+
+
+
+

Propchange: ofbiz/trunk/applications/marketing/testdef/
SeleniumTests.xml
--
 svn:eol-style = native

Propchange: ofbiz/trunk/applications/marketing/testdef/
SeleniumTests.xml
--
 svn:keywords = "Date Rev Author URL Id"

Propchange: ofbiz/trunk/applications/marketing/testdef/
SeleniumTests.xml
--
 svn:mime-type = text/xml

Added: ofbiz/trunk/applications/marketing/testdef/
commeventCreateOpportunity_testsuite.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/testdef/commeventCreateOpportunity_testsuite.xml?rev=822169&view=auto
=
=
=
=
=
=
=
=
=
= 
= 
===

--- ofbiz/trunk/applications/marketing/testdef/
commeventCreateOpportunity_testsuite.xml (added)
+++ ofbiz/trunk/applications/marketing/testdef/
commeventC

Re: File name pattern (Fwd: svn commit: r822169 - in /ofbiz/trunk/applications/marketing: ofbiz-component.xml testdef/MarketingTests.xml testdef/SeleniumTests.xml testdef/commeventCreateOpportunity_te

[Vikas Mayur]

Thanks Jacques, I hope people would not mind this big change with  
existing file renaming. Any other opinions?


Vikas

On Oct 7, 2009, at 2:25 PM, Jacques Le Roux wrote:


I will vote for having, at least, the word data in all data files

Jacques

From: "Vikas Mayur" 

+1

Btw, I also see issues with test data file location. Since it is  
just  a data file I think it should be in data folder and not  
testdef.


I think we should also discuss about the naming pattern of data  
files,  most of the files end with suffix Data but this pattern is  
not  followed strictly.


Any thoughts?

Vikas

On Oct 7, 2009, at 1:19 AM, Anil Patel wrote:


Hi,
I have problem with the naming of   
commeventCreateOpportunity_testsuite.xml


This should be rather named commEventCreateOpportunityTests.xml.  
I  don't see reason why we cannot stick to file naming  
conventions  already in place. Its important indicator of quality  
of product.


Thanks and Regards
Anil Patel
HotWax Media Inc
http://www.hotwaxmedia.com

Begin forwarded message:


From: hans...@apache.org
Date: October 6, 2009 4:47:36 AM EDT
To: comm...@ofbiz.apache.org
Subject: svn commit: r822169 - in /ofbiz/trunk/applications/  
marketing: ofbiz-component.xml testdef/MarketingTests.xml  
testdef/ SeleniumTests.xml testdef/ 
commeventCreateOpportunity_testsuite.xml

Reply-To: dev@ofbiz.apache.org

Author: hansbak
Date: Tue Oct  6 08:47:35 2009
New Revision: 822169

URL: http://svn.apache.org/viewvc?rev=822169&view=rev
Log:
added a selenium test when a opportunity is created from an email

Added:
 ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml 
(with props)
 ofbiz/trunk/applications/marketing/testdef/  
commeventCreateOpportunity_testsuite.xml   (with props)

Modified:
 ofbiz/trunk/applications/marketing/ofbiz-component.xml
 ofbiz/trunk/applications/marketing/testdef/MarketingTests.xml

Modified: ofbiz/trunk/applications/marketing/ofbiz-component.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/ofbiz-component.xml?rev=822169&r1=822168&r2=822169&view=diff
= = = = = = = = =  
= 
= 
===
--- ofbiz/trunk/applications/marketing/ofbiz-component.xml  
(original)
+++ ofbiz/trunk/applications/marketing/ofbiz-component.xml Tue  
Oct   6 08:47:35 2009

@@ -30,6 +30,7 @@
  location="data/MarketingSecurityData.xml"/>
  location="data/MarketingHelpData.xml"/>
  location="data/sfaDemoData.xml"/>
+loader="main"  location="testdef/SeleniumTests.xml"/>
  location="servicedef/services.xml"/>
  location="servicedef/services_opportunity.xml"/>
  location="servicedef/ secas.xml"/>


Modified: ofbiz/trunk/applications/marketing/testdef/  
MarketingTests.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/testdef/MarketingTests.xml?rev=822169&r1=822168&r2=822169&view=diff
= = = = = = = = =  
= 
= 
===
--- ofbiz/trunk/applications/marketing/testdef/ 
MarketingTests.xml  (original)
+++ ofbiz/trunk/applications/marketing/testdef/ 
MarketingTests.xml  Tue Oct  6 08:47:35 2009

@@ -1,3 +1,4 @@
+

-
http://www.w3.org/2001/XMLSchema-instance";
  xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/test-suite.xsd 
 ">


Added: ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml?rev=822169&view=auto
= = = = = = = = =  
= 
= 
===
--- ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml   
(added)
+++ ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml   
Tue Oct  6 08:47:35 2009

@@ -0,0 +1,22 @@
+
+
+
+testSuiteName="commeventopportunity_testsuite"  
testSuitePath="applications/marketing/testdef/  
commeventCreateOpportunity_testsuite.xml" description="test  
suite  for create opportunity from communications event"/>

+

Propchange: ofbiz/trunk/applications/marketing/testdef/  
SeleniumTests.xml

--
 svn:eol-style = native

Propchange: ofbiz/trunk/applications/marketing/testdef/  
SeleniumTests.xml

--
 svn:keywords = "Date Rev Author URL Id"

Propchange: ofbiz/trunk/applications/marketing/testdef/  
SeleniumTests.xml

--
 svn:mime-type = text/xml

Added: ofbiz/trunk/applications/marketing/testdef/  
commeventCreateOpportunity_testsuite.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/testdef/commeventCreateOpportunity_testsuite.xml?rev=822169&

Re: Question in Jira

[Vikas Mayur]

Thank you - Jacques for being on top of it.

Vikas

On Oct 27, 2009, at 7:03 PM, Jacques Le Roux wrote:


Hi,

Thanks to Gavin there is any longer a type question in Jira for OFBiz
https://issues.apache.org/jira/browse/INFRA-2206

Jacques

Re: Adding few more details for "admin" user (party) in demo data

[Vikas Mayur]

Hi Hans/Ashish,

Where does admin require this additional information?

DemoCustomer is in Customer role and is there to be used for eCommerce  
applications.


If your intention is to use admin user for front end app then I think  
it is not a good idea.


Vikas

On Dec 4, 2009, at 3:10 PM, Hans Bakker wrote:


+1

most of the time i use DemoCustomer because on admin this data is
missing, so sure why not add it

Regards,
Hans

On Fri, 2009-12-04 at 15:04 +0530, Ashish Vijaywargiya wrote:
WDYT if we add Shipping, Billing, Phone & Credit Card info to  
"admin" user

in a demo data?
So all this information will be loaded when you will run "ant run- 
install"

target.

Thoughts?

--
Ashish

--
Antwebsystems.com: Quality OFBiz services for competitive rates





smime.p7s
Description: S/MIME cryptographic signature

Re: [jira] Closed: (OFBIZ-1838) I created two entitys and added them to entitygroup file today. After compile, I check them on webtool. They are not there. Can you tell me what should I do? Thanks!

[Vikas Mayur]

In recent days, I have seen people starting asking questions more on dev
list (which supposed to go on user list), creating Jira issues for their
questions ( this is really funny) and possibly because of lack of knowledge
about distinguishing between user, dev list and now Jira issues.

I think in majority of these cases happens to be with those people who are
not aware of open source thingy.
I propose to put a brief information on OFBiz home site under Download OFBiz
> Getting Started (Read this first) or a title like "Must Read" highlighted
or any other place to get a user attention.

I am not sure how it will go onwards but still I would like thoughts on it.


Thank You,
Vikas



On Wed, Jun 11, 2008 at 1:49 AM, Jacques Le Roux (JIRA) <[EMAIL PROTECTED]>
wrote:

>
> [
> https://issues.apache.org/jira/browse/OFBIZ-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Jacques Le Roux closed OFBIZ-1838.
> --
>
>Resolution: Invalid
>  Assignee: Jacques Le Roux
>
> Please use rather user ML for such questions :
> http://docs.ofbiz.org/display/OFBADMIN/Mailing+Lists
>
> Thanks
>
> Jacques
>
>
>
> > I created two entitys and added them to entitygroup file today. After
> compile, I check them on webtool. They are not there. Can you tell me what
> should I do? Thanks!
> >
> -
> >
> > Key: OFBIZ-1838
> > URL: https://issues.apache.org/jira/browse/OFBIZ-1838
> > Project: OFBiz
> >  Issue Type: Bug
> >  Components: ecommerce
> > Environment: Windows  and tomcat application
> >Reporter: dev 2008
> >Assignee: Jacques Le Roux
> >
> > Today, I created two entities and added them to entitygroup file. After
> compile, I check them on web tool, and they are not there.
> > What should I do?
> > Thanks!
> > dev_2008
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Error in running test cases

[Vikas Mayur]

Hi,

I was testing few patches for test cases posted on Jira and thought to
modify  to use  instead.
But its giving following error ( This particular log is associated with when
test is run on example component )

Any thoughts, why this is happening ?

Vikas


Exception: java.lang.Exception
Message: Error in simple-method [test the create example service
[file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml#testCreateExampleService]]:
; [Assertion failed: (empty[=null])]
 stack trace
---
java.lang.Exception: Error in simple-method [test the create example service
[file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml#testCreateExampleService]]:
; [Assertion failed: (empty[=null])]
org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:311)
org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:258)
org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:875)
org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:134)
org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:116)
org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:76)
org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:51)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:384)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:213)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:149)
org.ofbiz.testtools.ServiceTest.run(ServiceTest.java:61)
junit.framework.TestSuite.runTest(TestSuite.java:208)
junit.framework.TestSuite.run(TestSuite.java:203)
org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:134)
org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:101)
org.ofbiz.base.start.Start.startStartLoaders(Start.java:263)
org.ofbiz.base.start.Start.startServer(Start.java:312)
org.ofbiz.base.start.Start.start(Start.java:316)
org.ofbiz.base.start.Start.main(Start.java:399)

Re: Error in running test cases

[Vikas Mayur]

Hi Scott,

It is working fine with "field-name" though it gives few errors like

UtilXml.java:660:ERROR] XmlFileLoader: File
file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml
process error. Line: 123. Error message: cvc-complex-type.3.2.2: Attribute
'field-name' is not allowed to appear in element 'if-empty'.

BTW, I see that its a issue with  tag only.

Vikas


On Fri, Jun 13, 2008 at 8:06 AM, Scott Gray <[EMAIL PROTECTED]> wrote:

> Hi Vikas
>
> The two attributes field-name and field should be interchangeable, are you
> sure that you don't have a problem even if you use field-name?
>
> Regards
> Scott
>
> 2008/6/13 Vikas Mayur <[EMAIL PROTECTED]>:
>
> > Hi,
> >
> > I was testing few patches for test cases posted on Jira and thought to
> > modify  to use  instead.
> > But its giving following error ( This particular log is associated with
> > when
> > test is run on example component )
> >
> > Any thoughts, why this is happening ?
> >
> > Vikas
> >
> >
> > Exception: java.lang.Exception
> > Message: Error in simple-method [test the create example service
> >
> >
> [file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml#testCreateExampleService]]:
> > ; [Assertion failed: (empty[=null])]
> >  stack trace
> > ---
> > java.lang.Exception: Error in simple-method [test the create example
> > service
> >
> >
> [file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml#testCreateExampleService]]:
> > ; [Assertion failed: (empty[=null])]
> >
> >
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:311)
> >
> >
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:258)
> > org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:875)
> > org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:134)
> > org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:116)
> >
> >
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:76)
> >
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:51)
> > org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:384)
> > org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:213)
> > org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:149)
> > org.ofbiz.testtools.ServiceTest.run(ServiceTest.java:61)
> > junit.framework.TestSuite.runTest(TestSuite.java:208)
> > junit.framework.TestSuite.run(TestSuite.java:203)
> > org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:134)
> > org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:101)
> > org.ofbiz.base.start.Start.startStartLoaders(Start.java:263)
> > org.ofbiz.base.start.Start.startServer(Start.java:312)
> > org.ofbiz.base.start.Start.start(Start.java:316)
> > org.ofbiz.base.start.Start.main(Start.java:399)
> >
>

Re: Error in running test cases

[Vikas Mayur]

Hi Scott,

I have seen this problem coming while running a test case.
For now you can run the test case for example component to see the problem
and file of interest is ExampleServices.xml,
method-name="testCreateExampleService".

Thanks,
Vikas

On Fri, Jun 13, 2008 at 10:27 AM, Scott Gray <[EMAIL PROTECTED]> wrote:

> Hi Vikas
>
> I can't see any reason why it would not work, where is the code I can use
> to
> replicate the issue?
>
> Thanks
> Scott
>
> 2008/6/13 Vikas Mayur <[EMAIL PROTECTED]>:
>
> > Hi Scott,
> >
> > It is working fine with "field-name" though it gives few errors like
> >
> > UtilXml.java:660:ERROR] XmlFileLoader: File
> >
> >
> file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml
> > process error. Line: 123. Error message: cvc-complex-type.3.2.2:
> Attribute
> > 'field-name' is not allowed to appear in element 'if-empty'.
> >
> > BTW, I see that its a issue with  tag only.
> >
> > Vikas
> >
> >
> > On Fri, Jun 13, 2008 at 8:06 AM, Scott Gray <[EMAIL PROTECTED]> wrote:
> >
> > > Hi Vikas
> > >
> > > The two attributes field-name and field should be interchangeable, are
> > you
> > > sure that you don't have a problem even if you use field-name?
> > >
> > > Regards
> > > Scott
> > >
> > > 2008/6/13 Vikas Mayur <[EMAIL PROTECTED]>:
> > >
> > > > Hi,
> > > >
> > > > I was testing few patches for test cases posted on Jira and thought
> to
> > > > modify  to use  instead.
> > > > But its giving following error ( This particular log is associated
> with
> > > > when
> > > > test is run on example component )
> > > >
> > > > Any thoughts, why this is happening ?
> > > >
> > > > Vikas
> > > >
> > > >
> > > > Exception: java.lang.Exception
> > > > Message: Error in simple-method [test the create example service
> > > >
> > > >
> > >
> >
> [file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml#testCreateExampleService]]:
> > > > ; [Assertion failed: (empty[=null])]
> > > >  stack trace
> > > > ---
> > > > java.lang.Exception: Error in simple-method [test the create example
> > > > service
> > > >
> > > >
> > >
> >
> [file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml#testCreateExampleService]]:
> > > > ; [Assertion failed: (empty[=null])]
> > > >
> > > >
> > >
> >
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:311)
> > > >
> > > >
> > >
> >
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:258)
> > > > org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:875)
> > > >
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:134)
> > > >
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:116)
> > > >
> > > >
> > >
> >
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:76)
> > > >
> > >
> >
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:51)
> > > >
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:384)
> > > >
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:213)
> > > >
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:149)
> > > > org.ofbiz.testtools.ServiceTest.run(ServiceTest.java:61)
> > > > junit.framework.TestSuite.runTest(TestSuite.java:208)
> > > > junit.framework.TestSuite.run(TestSuite.java:203)
> > > > org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:134)
> > > >
> > org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:101)
> > > > org.ofbiz.base.start.Start.startStartLoaders(Start.java:263)
> > > > org.ofbiz.base.start.Start.startServer(Start.java:312)
> > > > org.ofbiz.base.start.Start.start(Start.java:316)
> > > > org.ofbiz.base.start.Start.main(Start.java:399)
> > > >
> > >
> >
>

Re: Error in running test cases

[Vikas Mayur]

Hi David,

I have seen that work and was trying do similar modifications to test case
patches.
It worked nicely with "field-name" though with some errors as you said which
are fine, but
the test case fails using "field".


Vikas

On Fri, Jun 13, 2008 at 10:07 AM, David E Jones <[EMAIL PROTECTED]>
wrote:

>
> This is related to the cleanup of the simple-method attributes (and some
> elements). There is a summary of what has been done so far here:
>
> http://docs.ofbiz.org/display/OFBTECH/Simple+Method+Cleanup+Effort
>
> You will get XSD validation errors for unchanged elements, but the methods
> should still run just fine.
>
> If you change "field-name" to "field" then the validation error should go
> away, and things should work as before.
>
> If that is not happening, please let me know!
>
> -David
>
>
>
> On Jun 12, 2008, at 10:22 PM, Vikas Mayur wrote:
>
>  Hi Scott,
>>
>> It is working fine with "field-name" though it gives few errors like
>>
>> UtilXml.java:660:ERROR] XmlFileLoader: File
>>
>> file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml
>> process error. Line: 123. Error message: cvc-complex-type.3.2.2: Attribute
>> 'field-name' is not allowed to appear in element 'if-empty'.
>>
>> BTW, I see that its a issue with  tag only.
>>
>> Vikas
>>
>>
>> On Fri, Jun 13, 2008 at 8:06 AM, Scott Gray <[EMAIL PROTECTED]> wrote:
>>
>>  Hi Vikas
>>>
>>> The two attributes field-name and field should be interchangeable, are
>>> you
>>> sure that you don't have a problem even if you use field-name?
>>>
>>> Regards
>>> Scott
>>>
>>> 2008/6/13 Vikas Mayur <[EMAIL PROTECTED]>:
>>>
>>>  Hi,
>>>>
>>>> I was testing few patches for test cases posted on Jira and thought to
>>>> modify  to use  instead.
>>>> But its giving following error ( This particular log is associated with
>>>> when
>>>> test is run on example component )
>>>>
>>>> Any thoughts, why this is happening ?
>>>>
>>>> Vikas
>>>>
>>>>
>>>> Exception: java.lang.Exception
>>>> Message: Error in simple-method [test the create example service
>>>>
>>>>
>>>> [file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml#testCreateExampleService]]:
>>>
>>>> ; [Assertion failed: (empty[=null])]
>>>>  stack trace
>>>> ---
>>>> java.lang.Exception: Error in simple-method [test the create example
>>>> service
>>>>
>>>>
>>>> [file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml#testCreateExampleService]]:
>>>
>>>> ; [Assertion failed: (empty[=null])]
>>>>
>>>>
>>>> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:311)
>>>
>>>>
>>>>
>>>> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:258)
>>>
>>>> org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:875)
>>>> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:134)
>>>> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:116)
>>>>
>>>>
>>>> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:76)
>>>
>>>>
>>>> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:51)
>>>
>>>> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:384)
>>>> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:213)
>>>> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:149)
>>>> org.ofbiz.testtools.ServiceTest.run(ServiceTest.java:61)
>>>> junit.framework.TestSuite.runTest(TestSuite.java:208)
>>>> junit.framework.TestSuite.run(TestSuite.java:203)
>>>> org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:134)
>>>> org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:101)
>>>> org.ofbiz.base.start.Start.startStartLoaders(Start.java:263)
>>>> org.ofbiz.base.start.Start.startServer(Start.java:312)
>>>> org.ofbiz.base.start.Start.start(Start.java:316)
>>>> org.ofbiz.base.start.Start.main(Start.java:399)
>>>>
>>>>
>>>
>

Re: Error in running test cases

[Vikas Mayur]

Just run the following command on terminal

java -jar ofbiz.jar -test component='example'

and if you want to run a single test case under example test suite - comment
other in example/testdef/tests.xml


Please let me know if you need further information.


Thanks,
Vikas

On Fri, Jun 13, 2008 at 11:36 AM, Scott Gray <[EMAIL PROTECTED]> wrote:

> I'll take a look, how do I run the tests for just the example component?
>
> Thanks
> Scott
>
> 2008/6/13 Vikas Mayur <[EMAIL PROTECTED]>:
>
> > Hi Scott,
> >
> > I have seen this problem coming while running a test case.
> > For now you can run the test case for example component to see the
> problem
> > and file of interest is ExampleServices.xml,
> > method-name="testCreateExampleService".
> >
> > Thanks,
> > Vikas
> >
> > On Fri, Jun 13, 2008 at 10:27 AM, Scott Gray <[EMAIL PROTECTED]> wrote:
> >
> > > Hi Vikas
> > >
> > > I can't see any reason why it would not work, where is the code I can
> use
> > > to
> > > replicate the issue?
> > >
> > > Thanks
> > > Scott
> > >
> > > 2008/6/13 Vikas Mayur <[EMAIL PROTECTED]>:
> > >
> > > > Hi Scott,
> > > >
> > > > It is working fine with "field-name" though it gives few errors like
> > > >
> > > > UtilXml.java:660:ERROR] XmlFileLoader: File
> > > >
> > > >
> > >
> >
> file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml
> > > > process error. Line: 123. Error message: cvc-complex-type.3.2.2:
> > > Attribute
> > > > 'field-name' is not allowed to appear in element 'if-empty'.
> > > >
> > > > BTW, I see that its a issue with  tag only.
> > > >
> > > > Vikas
> > > >
> > > >
> > > > On Fri, Jun 13, 2008 at 8:06 AM, Scott Gray <[EMAIL PROTECTED]>
> wrote:
> > > >
> > > > > Hi Vikas
> > > > >
> > > > > The two attributes field-name and field should be interchangeable,
> > are
> > > > you
> > > > > sure that you don't have a problem even if you use field-name?
> > > > >
> > > > > Regards
> > > > > Scott
> > > > >
> > > > > 2008/6/13 Vikas Mayur <[EMAIL PROTECTED]>:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > I was testing few patches for test cases posted on Jira and
> thought
> > > to
> > > > > > modify  to use 
> instead.
> > > > > > But its giving following error ( This particular log is
> associated
> > > with
> > > > > > when
> > > > > > test is run on example component )
> > > > > >
> > > > > > Any thoughts, why this is happening ?
> > > > > >
> > > > > > Vikas
> > > > > >
> > > > > >
> > > > > > Exception: java.lang.Exception
> > > > > > Message: Error in simple-method [test the create example service
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> [file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml#testCreateExampleService]]:
> > > > > > ; [Assertion failed: (empty[=null])]
> > > > > >  stack trace
> > > > > > ---
> > > > > > java.lang.Exception: Error in simple-method [test the create
> > example
> > > > > > service
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> [file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml#testCreateExampleService]]:
> > > > > > ; [Assertion failed: (empty[=null])]
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:311)
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:258)
> > > > > > org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:875)
> > > > > >
> > > org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:134)
> > > > > >
> > > org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:116)
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:76)
> > > > > >
> > > > >
> > > >
> > >
> >
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:51)
> > > > > >
> > > org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:384)
> > > > > >
> > > org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:213)
> > > > > >
> > > org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:149)
> > > > > > org.ofbiz.testtools.ServiceTest.run(ServiceTest.java:61)
> > > > > > junit.framework.TestSuite.runTest(TestSuite.java:208)
> > > > > > junit.framework.TestSuite.run(TestSuite.java:203)
> > > > > >
> > org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:134)
> > > > > >
> > > >
> > org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:101)
> > > > > > org.ofbiz.base.start.Start.startStartLoaders(Start.java:263)
> > > > > > org.ofbiz.base.start.Start.startServer(Start.java:312)
> > > > > > org.ofbiz.base.start.Start.start(Start.java:316)
> > > > > > org.ofbiz.base.start.Start.main(Start.java:399)
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: Error in running test cases

[Vikas Mayur]

Thanks Scott - much appreciated.

Vikas

On Fri, Jun 13, 2008 at 12:16 PM, Scott Gray <[EMAIL PROTECTED]> wrote:

> Thanks Vikas, I found the problem and fixed it in rev. 667385
>
> Regards
> Scott
>
> 2008/6/13 Vikas Mayur <[EMAIL PROTECTED]>:
>
> > Just run the following command on terminal
> >
> > java -jar ofbiz.jar -test component='example'
> >
> > and if you want to run a single test case under example test suite -
> > comment
> > other in example/testdef/tests.xml
> >
> >
> > Please let me know if you need further information.
> >
> >
> > Thanks,
> > Vikas
> >
> > On Fri, Jun 13, 2008 at 11:36 AM, Scott Gray <[EMAIL PROTECTED]> wrote:
> >
> > > I'll take a look, how do I run the tests for just the example
> component?
> > >
> > > Thanks
> > > Scott
> > >
> > > 2008/6/13 Vikas Mayur <[EMAIL PROTECTED]>:
> > >
> > > > Hi Scott,
> > > >
> > > > I have seen this problem coming while running a test case.
> > > > For now you can run the test case for example component to see the
> > > problem
> > > > and file of interest is ExampleServices.xml,
> > > > method-name="testCreateExampleService".
> > > >
> > > > Thanks,
> > > > Vikas
> > > >
> > > > On Fri, Jun 13, 2008 at 10:27 AM, Scott Gray <[EMAIL PROTECTED]>
> > wrote:
> > > >
> > > > > Hi Vikas
> > > > >
> > > > > I can't see any reason why it would not work, where is the code I
> can
> > > use
> > > > > to
> > > > > replicate the issue?
> > > > >
> > > > > Thanks
> > > > > Scott
> > > > >
> > > > > 2008/6/13 Vikas Mayur <[EMAIL PROTECTED]>:
> > > > >
> > > > > > Hi Scott,
> > > > > >
> > > > > > It is working fine with "field-name" though it gives few errors
> > like
> > > > > >
> > > > > > UtilXml.java:660:ERROR] XmlFileLoader: File
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> file:/Users/vikas/work/projects/ofbiz/framework/example/script/org/ofbiz/example/example/ExampleServices.xml
> > > > > > process error. Line: 123. Error message: cvc-complex-type.3.2.2:
> > > > > Attribute
> > > > > > 'field-name' is not allowed to appear in element 'if-empty'.
> > > > > >
> > > > > > BTW, I see that its a issue with  tag only.
> > > > > >
> > > > > > Vikas
> > > > > >
> > > > > >
> > > > > > On Fri, Jun 13, 2008 at 8:06 AM, Scott Gray <[EMAIL PROTECTED]>
> > > wrote:
> > > > > >
> > > > > > > Hi Vikas
> > > > > > >
> > > > > > > The two attributes field-name and field should be
> > interchangeable,
> > > > are
> > > > > > you
> > > > > > > sure that you don't have a problem even if you use field-name?
> > > > > > >
> > > > > > > Regards
> > > > > > > Scott
> > > > > > >
> > > > > > > 2008/6/13 Vikas Mayur <[EMAIL PROTECTED]>:
> > > > > > >
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > I was testing few patches for test cases posted on Jira and
> > > thought
> > > > > to
> > > > > > > > modify  to use 
> > > instead.
> > > > > > > > But its giving following error ( This particular log is
> > > associated
> > > > > with
> > > > > > > > when
> > > > > > > > test is run on example component )
> > > > > > > >
> > > > > > > > Any thoughts, why this is happening ?
> > > > > > > >
> > > > > > > > Vikas
> > > > > > > >
> > > > > > > >
> > > > > > > > Exception: java.lang.Exception
> > > > > > > > Message: Error in simple-method [test the create example
> > service
> > >

Re: svn commit: r667448 - /ofbiz/trunk/framework/example/webapp/example/WEB-INF/actions/includes/findExampleFeatures.groovy

[Vikas Mayur]

Jacques, Looks like Scott name is in french :)

Vikas

On Fri, Jun 13, 2008 at 6:54 PM, Jacques Le Roux <
[EMAIL PROTECTED]> wrote:

> Thanks for the Set tip Scoot,
>
> Jacques
>
> From: "Scott Gray" <[EMAIL PROTECTED]>
>
>  Hi Jacques
>>
>> Looks good except for one thing:
>> +autocompleteOptions = delegator.findList("ExampleFeature",
>> entityConditionList,
>> +new TreeSet(['exampleFeatureId', 'description'],
>> ['-exampleFeatureId'], null, false);
>> Introduces a bug, there is no closing bracket for the TreeSet.  Also
>> instead
>> of using a TreeSet you can do this:
>> ['exampleFeatureId', 'description'] as Set
>>
>> Regards
>> Scott
>>
>> 2008/6/13 <[EMAIL PROTECTED]>:
>>
>>  Author: jleroux
>>> Date: Fri Jun 13 02:55:27 2008
>>> New Revision: 667448
>>>
>>> URL: http://svn.apache.org/viewvc?rev=667448&view=rev
>>> Log:
>>> My 1st bsh->groovy migration, please check. I will change the file name
>>> (uppercase className) remotely as I'm working on Windows currently (files
>>> names case insensitive)
>>>
>>> Modified:
>>>
>>>
>>>  
>>> ofbiz/trunk/framework/example/webapp/example/WEB-INF/actions/includes/findExampleFeatures.groovy
>>>
>>> Modified:
>>>
>>> ofbiz/trunk/framework/example/webapp/example/WEB-INF/actions/includes/findExampleFeatures.groovy
>>> URL:
>>>
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/example/webapp/example/WEB-INF/actions/includes/findExampleFeatures.groovy?rev=667448&r1=667447&r2=667448&view=diff
>>>
>>>
>>> ==
>>> ---
>>>
>>> ofbiz/trunk/framework/example/webapp/example/WEB-INF/actions/includes/findExampleFeatures.groovy
>>> (original)
>>> +++
>>>
>>> ofbiz/trunk/framework/example/webapp/example/WEB-INF/actions/includes/findExampleFeatures.groovy
>>> Fri Jun 13 02:55:27 2008
>>> @@ -18,30 +18,27 @@
>>>  */
>>>
>>>  import java.util.TreeSet;
>>> -import javolution.util.FastList;
>>>  import org.ofbiz.entity.condition.EntityCondition;
>>>  import org.ofbiz.entity.condition.EntityConditionList;
>>>  import org.ofbiz.entity.condition.EntityExpr;
>>>  import org.ofbiz.entity.condition.EntityFieldValue;
>>>  import org.ofbiz.entity.condition.EntityFunction;
>>>  import org.ofbiz.entity.condition.EntityOperator;
>>> -import org.ofbiz.base.util.UtilMisc;
>>> -import org.ofbiz.base.util.UtilValidate;
>>>
>>> -delegator = request.getAttribute("delegator");
>>>
>>> -andExprs = FastList.newInstance();
>>> -fieldValue = request.getParameter("exampleFeatureId");
>>> -if (UtilValidate.isNotEmpty(fieldValue)) {
>>> +andExprs = [];
>>> +fieldValue = parameters.exampleFeatureId;
>>> +if (fieldValue) {
>>>
>>>
>>> andExprs.add(EntityCondition.makeCondition(EntityFunction.UPPER(EntityFieldValue.makeFieldValue("exampleFeatureId")),
>>>EntityOperator.LIKE, "%" + fieldValue.toUpperCase() + "%"));
>>>  }
>>>
>>> -List autocompleteOptions = null;
>>> -if (andExprs.size() > 0) {
>>> +autocompleteOptions = [];
>>> +if (andExprs) {
>>>entityConditionList = EntityCondition.makeCondition(andExprs,
>>> EntityOperator.AND);
>>> -autocompleteOptions = delegator.findList("ExampleFeature",
>>> entityConditionList, new TreeSet(UtilMisc.toList("exampleFeatureId",
>>> "description")), UtilMisc.toList("-exampleFeatureId"), null, false);
>>> -//context.put("autocompleteOptions", autocompleteOptions);
>>> +autocompleteOptions = delegator.findList("ExampleFeature",
>>> entityConditionList,
>>> +new TreeSet(['exampleFeatureId', 'description'],
>>> ['-exampleFeatureId'], null, false);
>>> +//context.autocompleteOptions = autocompleteOptions;
>>>   request.setAttribute("autocompleteOptions", autocompleteOptions);
>>>  }
>>>  return "success";
>>> \ No newline at end of file
>>>
>>>
>>>
>>>
>>
>

Re: svn commit: r667667 - /ofbiz/trunk/applications/party/script/org/ofbiz/party/test/PartyTestServices.xml

[Vikas Mayur]

Thanks Scott - Interesting change.

BTW, I wasn't getting this error while running test case on Derby - and so
did this commit.

Vikas


On Sat, Jun 14, 2008 at 3:35 AM, <[EMAIL PROTECTED]> wrote:

> Author: lektran
> Date: Fri Jun 13 15:05:56 2008
> New Revision: 667667
>
> URL: http://svn.apache.org/viewvc?rev=667667&view=rev
> Log:
> Fix a problem that was causing the one of the party tests to fail.  The
> call-service operation adds the fields locale and userLogin to the in-map
> which was causing the find-by-primary-key operation to throw an error.
>
> Modified:
>
>  
> ofbiz/trunk/applications/party/script/org/ofbiz/party/test/PartyTestServices.xml
>
> Modified:
> ofbiz/trunk/applications/party/script/org/ofbiz/party/test/PartyTestServices.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/script/org/ofbiz/party/test/PartyTestServices.xml?rev=667667&r1=667666&r2=667667&view=diff
>
> ==
> ---
> ofbiz/trunk/applications/party/script/org/ofbiz/party/test/PartyTestServices.xml
> (original)
> +++
> ofbiz/trunk/applications/party/script/org/ofbiz/party/test/PartyTestServices.xml
> Fri Jun 13 15:05:56 2008
> @@ -33,14 +33,14 @@
> 
> -
> -
> -
> +
> +
> +
> 
> 
> 
>
> - map-name="serviceCtx" value-name="partyRoleDetailAndPartyDetail"/>
> + map-name="searchParams" value-name="partyRoleDetailAndPartyDetail"/>
> 
> 
> 
>
>
>

Re: svn commit: r667667 - /ofbiz/trunk/applications/party/script/org/ofbiz/party/test/PartyTestServices.xml

[Vikas Mayur]

Sorry Scott - for my wrong call.
I too check it again, the problem is there.

Thanks for the fix.

Vikas

On Sat, Jun 14, 2008 at 1:35 PM, Scott Gray <[EMAIL PROTECTED]> wrote:

> Hi Vikas
>
> I just double checked by reverting my change and running the test again and
> the problem is definitely there (I'm using derby as well):
> 2008-06-14 19:56:32,183 (main) [   SimpleMethod.java:1109:ERROR]
>  runtime exception report
> --
> Error in simple-method operation []:
> java.lang.IllegalArgumentException: [GenericEntity.set] "locale" is not a
> field of PartyRoleDetailAndPartyDetail, must be one of: personComments,
> partyGroupComments, partyId, partyTypeId, externalId,
> preferredCurrencyUomId, statusId, createdDate, createdByUserLogin,
> lastModifiedDate, lastModifiedByUserLogin, dataSourceId, isUnread,
> roleTypeId, parentTypeId, hasTable, description, salutation, firstName,
> middleName, lastName, personalTitle, suffix, nickname, firstNameLocal,
> middleNameLocal, lastNameLocal, otherLocal, memberId, gender, birthDate,
> height, weight, mothersMaidenName, maritalStatus, socialSecurityNumber,
> passportNumber, passportExpireDate, totalYearsWorkExperience,
> employmentStatusEnumId, residenceStatusEnumId, occupation,
> yearsWithEmployer, monthsWithEmployer, existingCustomer, groupName,
> groupNameLocal, officeSiteName, annualRevenue, numEmployees, tickerSymbol,
> logoImageUrl
> Exception: java.lang.IllegalArgumentException
> Message: [GenericEntity.set] "locale" is not a field of
> PartyRoleDetailAndPartyDetail, must be one of: personComments,
> partyGroupComments, partyId, partyTypeId, externalId,
> preferredCurrencyUomId, statusId, createdDate, createdByUserLogin,
> lastModifiedDate, lastModifiedByUserLogin, dataSourceId, isUnread,
> roleTypeId, parentTypeId, hasTable, description, salutation, firstName,
> middleName, lastName, personalTitle, suffix, nickname, firstNameLocal,
> middleNameLocal, lastNameLocal, otherLocal, memberId, gender, birthDate,
> height, weight, mothersMaidenName, maritalStatus, socialSecurityNumber,
> passportNumber, passportExpireDate, totalYearsWorkExperience,
> employmentStatusEnumId, residenceStatusEnumId, occupation,
> yearsWithEmployer, monthsWithEmployer, existingCustomer, groupName,
> groupNameLocal, officeSiteName, annualRevenue, numEmployees, tickerSymbol,
> logoImageUrl
>  stack trace
> ---
> java.lang.IllegalArgumentException: [GenericEntity.set] "locale" is not a
> field of PartyRoleDetailAndPartyDetail, must be one of: personComments,
> partyGroupComments, partyId, partyTypeId, externalId,
> preferredCurrencyUomId, statusId, createdDate, createdByUserLogin,
> lastModifiedDate, lastModifiedByUserLogin, dataSourceId, isUnread,
> roleTypeId, parentTypeId, hasTable, description, salutation, firstName,
> middleName, lastName, personalTitle, suffix, nickname, firstNameLocal,
> middleNameLocal, lastNameLocal, otherLocal, memberId, gender, birthDate,
> height, weight, mothersMaidenName, maritalStatus, socialSecurityNumber,
> passportNumber, passportExpireDate, totalYearsWorkExperience,
> employmentStatusEnumId, residenceStatusEnumId, occupation,
> yearsWithEmployer, monthsWithEmployer, existingCustomer, groupName,
> groupNameLocal, officeSiteName, annualRevenue, numEmployees, tickerSymbol,
> logoImageUrl
> org.ofbiz.entity.GenericEntity.set(GenericEntity.java:385)
> org.ofbiz.entity.GenericEntity.setFields(GenericEntity.java:908)
> org.ofbiz.entity.GenericEntity.init(GenericEntity.java:163)
> org.ofbiz.entity.GenericPK.create(GenericPK.java:51)
> org.ofbiz.entity.GenericDelegator.makePK(GenericDelegator.java:562)
> org.ofbiz.entity.GenericDelegator.findOne(GenericDelegator.java:1473)
>
> org.ofbiz.minilang.method.entityops.FindByPrimaryKey.exec(FindByPrimaryKey.java:88)
> org.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:1104)
> org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:744)
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:134)
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:110)
> org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:64)
> junit.framework.TestSuite.runTest(TestSuite.java:208)
> junit.framework.TestSuite.run(TestSuite.java:203)
> org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:134)
> org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:101)
> org.ofbiz.base.start.Start.startStartLoaders(Start.java:263)
> org.ofbiz.base.start.Start.startServer(Start.java:312)
> org.ofbiz.base.start.Start.start(Start.java:316)
> org.ofbiz.base.start.Start.main(Start.java:399)
>
> ---

Re: UPS shipping rate estimates

[Vikas Mayur]

Not sure I am 100% correct, but as per my understanding on how online ship
estimate are calculated - depends on certain attributes of Product entity
like inShippingBox, piecesIncluded, weight, shippingDepth, shippingHeight,
shippingWidth.

Case 1 : Lets suppose you have a Product A (productId = A), ordered quantity
= 2, piecesIncluded = 3, inShippingBox set to Y
   In this case 6 packages will be created for product partial
qty i.e 1/piecesIncluded

Case 2 : If you also have other attibutes set (shippingDepth,
shippingHeight, shippingWidth) along with Case 1 - than dimensions of the
product are
   also passed on to UPS. In this particular case the shipping
estimates might differ from the Case 1.

Case 3 : If inShippingBox is not set than the number of packages created
depends on max weight a package can hold - which can configured in
   shipment.properties (shipment.ups.max.estimate.weight). So
estimates will be weight based only.

Case 4 : If you think that case1, case 2 will result in higher shipping
rates as expected and you do not want to extra charge that to your
customer
   than you can always add custom field to the entity, code to
the existing service / methods.

  We have done a custom implementation for one of our client
where they want to split packages on the basis of 3 pieces in a package
+
  weight constraint as in Case 3. So Case 1 will result in 2
packages instead of 6 packages. This way charging less to the customer and
  also not loosing money.


 So, it all depends on how you set product attributes and
configure few properties to get correct estimates.


Hope this helps !

Vikas




On Sat, Jun 21, 2008 at 1:30 AM, mike_mcmillan <
[EMAIL PROTECTED]> wrote:

>
> at time the estimate is obtained from UPS and returned to Opentaps, the
> application does not know how many boxes the shipment will be.  This is
> because the estimate is returned at the time of order entry.  So, when it
> retrieves the estimate it tends to be off by a decent amount (low or high).
> We have experienced the high shipping cost for an order with a low
> weight.but technically only if the shipment is one box.  If the low
> weight order was boxed in multiple boxes, the estimate would be just about
> dead on to the real cost that's returned with the label. There is a BUT.
>
> But, in another instance I shipped an order with a medium-high weight (22
> lbs).  The shipping came back $18.59.  If we had shipped this in one box
> the
> shipping cost would have been $15.56 (I got this price by going to the UPS
> website) which we would have made $3.  but we didn't ship it in one
> box,
> we shipped it 3, and the actual cost that came back based on weight and box
> count came back $24.  So we lost $6
>
> Is there a way to configure the live UPS shipping rate so that we can get
> better estimates?
>
> AlsoUnder the service name in the shipping entity of the store there is
> a field "Config Props".  Can anyone tell me what this is used for?
>
> Mike
>
> --
> View this message in context:
> http://www.nabble.com/UPS-shipping-rate-estimates-tp18036458p18036458.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>
>

Re: Freemarker deprecated built-ins

[Vikas Mayur]

+1

Vikas

On Mon, Jun 23, 2008 at 10:56 PM, Jacques Le Roux <
[EMAIL PROTECTED]> wrote:

> Hi All,
>
> Why do you think about updating all our templates following
> http://freemarker.sourceforge.net/docs/ref_depr_builtin.html ?
> At least the second and the third could be done automatically.
>
> Jacques

Re: One Page Checkout

[Vikas Mayur]

FYI work on this issue is still in progress.
To make this process as generic as existing checkout process it will take a
little more time considering the permutation and combinations at
Shipping and Billing information steps.

Discussions / Ideas are most welcome and why not use an existing issue
https://issues.apache.org/jira/browse/OFBIZ-1462


Thank you,
Vikas




On Mon, Jul 7, 2008 at 10:57 AM, Enrique Ruibal <[EMAIL PROTECTED]>
wrote:

>
> Hello,
>
> Just for further feedback on this issue, I wonder if this one page checkout
> feature once it is finished can be taken further to the order managament
> app
> backend too, I guess it would smooth a lof of the testing and it would be
> useful for simple user operations not comming from the ecommerce front.
>
> Regards,
>
> -Enrique Ruibal
>
>
> Tim Ruppert wrote:
> >
> > It is a one page checkout - it is just not finished to the best of my
> > knowledge.  I believe the plan was for it to be finished by the end of
> > this week.
> >
> > Cheers,
> > Tim
> > --
> > Tim Ruppert
> > HotWax Media
> > http://www.hotwaxmedia.com
> >
> > o:801.649.6594
> > f:801.649.6595
> >
> >
> > On Jul 6, 2008, at 5:45 AM, Jacques Le Roux wrote:
> >
> >> Hi,
> >>
> >> Just for my information : why the eCommerce One Page Checkout is so
> >> called but is not really a one page checkout as is Quick Checkout ?
> >>
> >> Thanks
> >>
> >> Jacques
> >
> >
> >
> >
>
> --
> View this message in context:
> http://www.nabble.com/One-Page-Checkout-tp18301340p18310259.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>
>

Re: svn commit: r676607 - /ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy

[Vikas Mayur]

Hi Scott,
I double check it after reverting my changes and the got the same error on
Order submit.(tested only from ecommerce).

ScreenFactory.java:128:INFO ] Got 4 screens in 0.117s from:
file:/Users/vikas/work/projects/ofbiz/applications/order/widget/ordermgr/OrderPrintScreens.xml
2008-07-15 09:54:34,815 (default-invoker-Thread-7) [
 ModelScreen.java:398:ERROR] Error rendering screen
[component://order/widget/ordermgr/OrderPrintScreens.xml#CompanyLogo]:
groovy.lang.MissingPropertyException: No such property: nowTimestamp for
class: CompanyHeader. Rolling back transaction.
2008-07-15 09:54:34,818 (default-invoker-Thread-7) [
 TransactionUtil.java:311:WARN ]
 exception report
--
[TransactionUtil.setRollbackOnly] Calling transaction setRollbackOnly; this
stack trace shows where this is happening:
Exception: java.lang.Exception
Message: Error rendering screen
[component://order/widget/ordermgr/OrderPrintScreens.xml#CompanyLogo]:
groovy.lang.MissingPropertyException: No such property: nowTimestamp for
class: CompanyHeader
 stack trace
---
java.lang.Exception: Error rendering screen
[component://order/widget/ordermgr/OrderPrintScreens.xml#CompanyLogo]:
groovy.lang.MissingPropertyException: No such property: nowTimestamp for
class: CompanyHeader


For complete log please see the attached file.

BTW, I do not see nowTimestamp defined in groovy context.


Thanks,
Vikas

On Tue, Jul 15, 2008 at 1:25 AM, Scott Gray <[EMAIL PROTECTED]> wrote:

> Hi Vikas
>
> nowTimestamp should already be defined in the context, where were you
> seeing the problem?
>
> Thanks
> Scott
>
> 2008/7/15  <[EMAIL PROTECTED]>:
> > Author: mor
> > Date: Mon Jul 14 07:42:15 2008
> > New Revision: 676607
> >
> > URL: http://svn.apache.org/viewvc?rev=676607&view=rev
> > Log:
> > Fixed a small bug - I think introduced through bsh -> groovy conversion
> >
> > Modified:
> >
>  
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
> >
> > Modified:
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
> > URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy?rev=676607&r1=676606&r2=676607&view=diff
> >
> ==
> > ---
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
> (original)
> > +++
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
> Mon Jul 14 07:42:15 2008
> > @@ -37,6 +37,7 @@
> >  returnId = parameters.returnId;
> >  quote = null;
> >  quoteId = parameters.quoteId;
> > +nowTimestamp = UtilDateTime.nowTimestamp();
> >  fromPartyId = parameters.fromPartyId;
> >
> >  if (!orderHeader && orderId) {
> >
> >
> >
>

Re: svn commit: r679900 - /ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl

[Vikas Mayur]

Hi Scott,

This style has been deprecated for back-end apps as per document
http://docs.ofbiz.org/display/OFBIZ/Misc+UI+Refactor+Guidelines+2
But my question is a bit different. What guidelines to follow for back-end
files (as in this case) that are also being used in ecommerce. I did not
find a mention about that. Is it good to use deprecated styles in these
scenarios ?

Thoughts Please ?

Thanks,
- Vikas


On Sat, Jul 26, 2008 at 2:48 AM, <[EMAIL PROTECTED]> wrote:

> Author: lektran
> Date: Fri Jul 25 14:18:10 2008
> New Revision: 679900
>
> URL: http://svn.apache.org/viewvc?rev=679900&view=rev
> Log:
> Style the empty shopping cart div
>
> Modified:
>ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
>
> Modified:
> ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl?rev=679900&r1=679899&r2=679900&view=diff
>
> ==
> --- ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
> (original)
> +++ ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
> Fri Jul 25 14:18:10 2008
> @@ -71,7 +71,7 @@
>  href="<@ofbizUrl>checkoutoptions"
> class="buttontext">${uiLabelMap.EcommerceOnePageCheckout}
>   
> <#else>
> -  ${uiLabelMap.OrderShoppingCartEmpty}
> +   class="tabletext">${uiLabelMap.OrderShoppingCartEmpty}
> 
> 
>  
>
>
>

Re: svn commit: r680086 - in /ofbiz/trunk/applications: content/webapp/content/WEB-INF/ product/webapp/catalog/WEB-INF/ product/webapp/catalog/find/ product/webapp/catalog/includes/ product/widget/cat

[Vikas Mayur]

Hi Jacques,

Why not use extends="CommonAppBarMenu"
extends-resource="component://common/widget/CommonMenus.xml" in
catalog/Menus.xml to remove three menu items namely main, logout, login

- Vikas

On Sun, Jul 27, 2008 at 3:53 PM, <[EMAIL PROTECTED]> wrote:

> Author: jleroux
> Date: Sun Jul 27 03:23:34 2008
> New Revision: 680086
>
> URL: http://svn.apache.org/viewvc?rev=680086&view=rev
> Log:
> An enhancing patch from Bruno Busco "Using screenlets in Catalog Manager
> Application" (https://issues.apache.org/jira/browse/OFBIZ-1880) -
> OFBIZ-1880
>
> Added:
>ofbiz/trunk/applications/product/widget/catalog/Menus.xml   (with props)
> Removed:
>ofbiz/trunk/applications/product/webapp/catalog/includes/appheader.ftl
>ofbiz/trunk/applications/product/widget/catalog/CatalogCommonScreens.xml
> Modified:
>ofbiz/trunk/applications/content/webapp/content/WEB-INF/controller.xml
>ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/web.xml
>
>  ofbiz/trunk/applications/product/webapp/catalog/find/keywordsearchbox.ftl
>ofbiz/trunk/applications/product/webapp/catalog/find/miniproductlist.ftl
>ofbiz/trunk/applications/product/webapp/catalog/find/sidecatalogs.ftl
>
>  ofbiz/trunk/applications/product/webapp/catalog/find/sidedeepcategory.ftl
>ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml
>
> Modified:
> ofbiz/trunk/applications/content/webapp/content/WEB-INF/controller.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/webapp/content/WEB-INF/controller.xml?rev=680086&r1=680085&r2=680086&view=diff
>
> ==
> --- ofbiz/trunk/applications/content/webapp/content/WEB-INF/controller.xml
> (original)
> +++ ofbiz/trunk/applications/content/webapp/content/WEB-INF/controller.xml
> Sun Jul 27 03:23:34 2008
> @@ -1730,8 +1730,6 @@
>  page="component://content/widget/layout/LayoutScreens.xml#EditLayoutImage"
> type="screen"/>
>  page="component://content/widget/layout/LayoutScreens.xml#EditLayoutUrl"
> type="screen"/>
>
> -  page="component://content/widget/content/ContentScreens.xml#FindContent"
> type="screen"/>
> -
>  page="component://content/widget/SurveyScreens.xml#FindSurvey"
> type="screen"/>
>  page="component://content/widget/SurveyScreens.xml#EditSurvey"
> type="screen"/>
>  page="component://content/widget/SurveyScreens.xml#EditSurveyMultiResps"
> type="screen"/>
>
> Modified: ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/web.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/web.xml?rev=680086&r1=680085&r2=680086&view=diff
>
> ==
> --- ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/web.xml
> (original)
> +++ ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/web.xml Sun Jul
> 27 03:23:34 2008
> @@ -41,7 +41,7 @@
> 
> 
> mainDecoratorLocation
> -
>  
> component://product/widget/catalog/CatalogCommonScreens.xml
> +
>  
> component://product/widget/catalog/CommonScreens.xml
> The location of the main-decorator screen to use for
> this webapp; referred to as a context variable in screen def XML
> files.
> 
>
>
> Modified:
> ofbiz/trunk/applications/product/webapp/catalog/find/keywordsearchbox.ftl
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/find/keywordsearchbox.ftl?rev=680086&r1=680085&r2=680086&view=diff
>
> ==
> ---
> ofbiz/trunk/applications/product/webapp/catalog/find/keywordsearchbox.ftl
> (original)
> +++
> ofbiz/trunk/applications/product/webapp/catalog/find/keywordsearchbox.ftl
> Sun Jul 27 03:23:34 2008
> @@ -31,86 +31,64 @@
>  //-->
>  
>
> -
> -
> -
> -<#if isOpen>
> - href="<@ofbizUrl>main?SearchProductsState=close"
> class="lightbuttontext"> _ 
> -<#else>
> - href="<@ofbizUrl>main?SearchProductsState=open"
> class="lightbuttontext"> [] 
> -
> -
> -${uiLabelMap.ProductSearchProducts}
> -
> -<#if isOpen>
> -
> -
> - action="<@ofbizUrl>keywordsearch?VIEW_SIZE=25&PAGING=Y"
> style="margin: 0;">
> -   class="label">${uiLabelMap.ProductKeywords}: type="text"name="SEARCH_STRING" size="20" maxlength="50"
> value="${requestParameters.SEARCH_STRING?if_exists}"/>
> -  
> -${uiLabelMap.ProductCategoryId}:
> -  
> -   maxlength="20" value="${requestParameters.SEARCH_CATEGORY_ID?if_exists}"/> href="javascript:call_fieldlookup2(document.keywordsearchform.SEARCH_CATEGORY_ID,'LookupProductCategory');"> src='/images/fieldlookup.gif' width='15' height='14' border='0' alt='Click
> here For Field Lookup'/>
> -  
> -${uiLabelMap.CommonNoContains}
> -

Re: svn commit: r680630 - in /ofbiz/trunk/applications/ecommerce: script/org/ofbiz/ecommerce/customer/ webapp/ecommerce/images/ webapp/ecommerce/order/

[Vikas Mayur]

Thanks David for the suggestion.
I have reverted this commit in rev. 680926

I will take a pass through the name used on contactMechId for shipping. I
think it is used as shippingContactMechId and it can also be
changed to shipToContactMechId. Doing this will have all the names prefixed
with shipTo for shipping and billTo for billing.


- Vikas

On Wed, Jul 30, 2008 at 12:22 PM, David E Jones <[EMAIL PROTECTED]> wrote:

>
> Please revert this change. The term "bill to" is used in various places and
> has clear meaning in the business world. Unfortunately plain "billing"
> instead of "bill to" is less clear because you don't know if your talking
> about a bill from or a bill to.
>
> -David
>
>
>
> On Jul 29, 2008, at 12:30 AM, [EMAIL PROTECTED] wrote:
>
>  Author: mor
>> Date: Mon Jul 28 23:30:22 2008
>> New Revision: 680630
>>
>> URL: http://svn.apache.org/viewvc?rev=680630&view=rev
>> Log:
>> Changed contactMechId name for billing to be used as similar to shipping.
>> Reported by Jyotsna Rathore, patch from Rishi Solanki
>>
>> Modified:
>>
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CheckoutMapProcs.xml
>>
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>>
>> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/images/checkoutProcess.js
>>
>> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/order/OnePageCheckoutProcess.ftl
>>
>> Modified:
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CheckoutMapProcs.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CheckoutMapProcs.xml?rev=680630&r1=680629&r2=680630&view=diff
>>
>> ==
>> ---
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CheckoutMapProcs.xml
>> (original)
>> +++
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CheckoutMapProcs.xml
>> Mon Jul 28 23:30:22 2008
>> @@ -124,7 +124,7 @@
>>
>>
>>
>> -
>> +
>>
>>
>>
>>
>> Modified:
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml?rev=680630&r1=680629&r2=680630&view=diff
>>
>> ==
>> ---
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>> (original)
>> +++
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>> Mon Jul 28 23:30:22 2008
>> @@ -1154,7 +1154,7 @@
>>> from-field="partyId"/>
>>
>>> from-field="userLogin"/>
>> -
>> +
>>> list-name="pcmpList" filter-by-date="true">
>>> env-name="userLogin.partyId"/>
>>> value="BILLING_LOCATION"/>
>> @@ -1172,15 +1172,15 @@
>>> from-field="paymentMethod.paymentMethodId"/>
>>
>>> in-map-name="billToAddressAndCreditCardCtx">
>> -> field-name="parameters.billToContactMechId"/>
>> +> field-name="parameters.billingContactMechId"/>
>>> field-name="parameters.paymentMethodId"/>
>>
>>
>>
>> -> from-field="parameters.billToContactMechId"/>
>> +> from-field="parameters.billingContactMechId"/>
>>> from-field="parameters.paymentMethodId"/>
>>> in-map-name="billToAddressAndCreditCardCtx">
>> -> field-name="parameters.billToContactMechId"/>
>> +> field-name="parameters.billingContactMechId"/>
>>> field-name="parameters.paymentMethodId"/>
>>
>>> list-name="pcmpList" filter-by-date="true">
>> @@ -1188,7 +1188,7 @@
>>> value="BILLING_LOCATION"/>
>>
>>
>> -> operator="not-equals" to-field="pcmp.contactMechId">
>> +> operator="not-equals" to-field="pcmp.contactMechId">
>>
>>> service-name="deletePartyContactMechPurposeIfExists" map-name="pcmp"
>> to-map-name="deletePartyContactMechPurposeCtx"/>
>>> service-name="deletePartyContactMechPurposeIfExists"
>> in-map-name="deletePartyContactMechPurposeCtx"/>
>> @@ -1199,7 +1199,7 @@
>>
>>
>>> request-name="paymentMethodId"/>
>> -> request-name="billToContactMechId"/>
>> +> field-name="parameters.billingContactMechId"
>> request-name="billingContactMechId"/>
>>
>>
>>> operator="equals" value="Y">
>> @@ -1220,7 +1220,7 @@
>>   

Re: svn commit: r681750 - in /ofbiz/trunk/applications: ecommerce/script/org/ofbiz/ecommerce/customer/ ecommerce/webapp/ecommerce/ ecommerce/webapp/ecommerce/WEB-INF/ ecommerce/webapp/ecommerce/WEB-IN

[Vikas Mayur]

Hi Scott,

The only reason that I use this way depends on how the new one page checkout
is designed.
There are couple of json requests that being called on separate forms for
shipping, billing and payment etc on one page.
This will generate a new separate context and so is the reason to put the
input values in parameters to make them available on the forms irrespective
of the context.

Another reason I think is that we do keep values for input fields in
parameters to populate only recently filled values - if any error occur on
submitting a form.

Also I try to understand how it is done in EditContactMech.groovy where a
tryEntity attribute is used - I am not sure if it could be used. But I could
not figure out how it is set.

Please let me know your comments, best approach to follow - as I might be
wrong in my explanation.


Thanks,
Vikas

On Sat, Aug 2, 2008 at 3:33 AM, Scott Gray <[EMAIL PROTECTED]> wrote:

> Hi Vikas
>
> Why are the groovy scripts putting all their output variables into the
> parameters map rather than straight into the context?  I only ask
> because I've converted a lot of bsh scripts to groovy and I'm not used
> to seeing that done.
>
> Thanks
> Scott
>
> 2008/8/2  <[EMAIL PROTECTED]>:
> > Author: mor
> > Date: Fri Aug  1 10:04:44 2008
> > New Revision: 681750
> >
> > URL: http://svn.apache.org/viewvc?rev=681750&view=rev
> > Log:
> > From now One Page Checkout supports registered process. Thanks to Sumit
> Pandit, Jyotsna Rathore, Brajesh Patel and Rishi Solanki their efforts ...
> >
> > Added:
> >
>  
> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy
>   (with props)
> >
>  
> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditEmailAndTelecomNumber.groovy
>   (with props)
> >
>  
> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy
>   (with props)
> > Modified:
> >
>  
> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
> >
>  ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
> >ofbiz/trunk/applications/ecommerce/webapp/ecommerce/login.ftl
> >
>  
> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/order/OnePageCheckoutProcess.ftl
> >ofbiz/trunk/applications/ecommerce/widget/OrderScreens.xml
> >ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/minicart.ftl
> >
> > Modified:
> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
> > URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml?rev=681750&r1=681749&r2=681750&view=diff
> >
> ==
> > ---
> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
> (original)
> > +++
> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
> Fri Aug  1 10:04:44 2008
> > @@ -1023,8 +1023,8 @@
> > processor-name="shipToAddress" in-map-name="parameters"
> out-map-name="shipToAddressCtx"/>
> > 
> > 
> > + value="SHIPPING_LOCATION"/>
> > 
> > - value="SHIPPING_LOCATION"/>
> >  in-map-name="shipToAddressCtx">
> >  field-name="parameters.shipToContactMechId"/>
> > 
> > @@ -1042,7 +1042,6 @@
> >  service-name="deletePartyContactMechPurposeIfExists" map-name="pcmp"
> to-map-name="deletePartyContactMechPurposeCtx"/>
> >  service-name="deletePartyContactMechPurposeIfExists"
> in-map-name="deletePartyContactMechPurposeCtx"/>
> > 
> > - value="SHIPPING_LOCATION"/>
> >  in-map-name="shipToAddressCtx">
> >  field-name="parameters.shipToContactMechId"/>
> > 
> > @@ -1194,130 +1193,131 @@
> > 
> > 
> >
> > -
> > - xml-resource="org/ofbiz/accounting/payment/PaymentMapProcs.xml"
> > -processor-name="createCreditCard"
> in-map-name="parameters" out-map-name="creditCardContext"/>
> > +
> > +
> > +
> > +
> > + from-field="parameters.paymentMethodId"/>
> > + from-field="parameters.cardSecurityCode"/>
> > + session-name="userLogin"/>
> > +
> > +
> > +
> > +
> > +
> > + short-description="create and update billing address">
> >
> >  operator="not-equals" value="Y">
> > -  value="${parameters.firstNameOnCard} ${parameters.lastNameOnCard}"/>
> >  xml-resource="org/ofbiz/ecommerce/customer/CheckoutMapProcs.xml"
> > -processor-name="billToAddress"
> in-map-name="parameters" out-map-name="billToAddressContext"/>
> > - to-map-name="billToAddressAndCreditCardCtx"/>
> > - to-map-name="billTo

Re: svn commit: r685013 - in /ofbiz/trunk/specialpurpose/projectmgr: entitydef/entitymodel.xml widget/forms/TaskForms.xml

[Vikas Mayur]

Hi Hans,

I am getting couple of error and warnings on run-install and are  
followings:


1) [ModelViewEntity.populateFields] ERROR: could not find ModelField  
for entity name: WorkEffort and field: StatusId
 [java] 2008-08-12 12:55:37,248 (main) [ModelViewEntity.java: 
397:ERROR] [ModelViewEntity.populateFields (ProjectAndPhase)] ERROR:  
could not find ModelField for field name "StatusId" on entity with  
name: WorkEffort


WorkEffort has a field currentStatusId.

2) [java] 2008-08-12 12:55:37,607 (main) [   GenericDelegator.java: 
204:WARN ] =-=-=-=-= Found 3 warnings when checking the entity  
definitions:
 [java] 2008-08-12 12:55:37,607 (main) [   GenericDelegator.java: 
206:WARN ] [RelationFieldNotFound] The field workEffortId was  
specified in the keymaps but is not found for relation TimeEntry of  
entity ProjectAndPhase.
 [java] 2008-08-12 12:55:37,607 (main) [   GenericDelegator.java: 
206:WARN ] [RelationFieldNotFound] The field workEffortId was  
specified in the keymaps but is not found for relation  
WorkEffortSkillStandard of entity ProjectAndPhase.
 [java] 2008-08-12 12:55:37,607 (main) [   GenericDelegator.java: 
206:WARN ] [RelationFieldNotFound] The field workEffortId was  
specified in the keymaps but is not found for relation  
WorkEffortPartyAssignment of entity ProjectAndPhase.


 Did not look into yet.


Rest of comment is inline.


On Aug 12, 2008, at 6:42 AM, [EMAIL PROTECTED] wrote:


Author: hansbak
Date: Mon Aug 11 18:12:33 2008
New Revision: 685013

URL: http://svn.apache.org/viewvc?rev=685013&view=rev
Log:
enable the selection of a phase in a project even if it has no tasks

Modified:
   ofbiz/trunk/specialpurpose/projectmgr/entitydef/entitymodel.xml
   ofbiz/trunk/specialpurpose/projectmgr/widget/forms/TaskForms.xml

Modified: ofbiz/trunk/specialpurpose/projectmgr/entitydef/ 
entitymodel.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/entitydef/entitymodel.xml?rev=685013&r1=685012&r2=685013&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/specialpurpose/projectmgr/entitydef/entitymodel.xml  
(original)
+++ ofbiz/trunk/specialpurpose/projectmgr/entitydef/entitymodel.xml  
Mon Aug 11 18:12:33 2008

@@ -155,6 +155,32 @@

  

+  
+
+>

+


This alias WET is not associated to any entity. I think we need to  
first create a association using  ?

Though this does not seems to be used anywhere :)


Thanks,
Vikas



+
+name="projectName"/>
+name="projectStatusId"/>

+
+name="phaseName"/>
+name="phaseStatusId"/>

+
+  name="workEffortParentId"/>

+
+
+  
+
+
+  
+
+name="WorkEffortPartyAssignment">

+  
+
+  
+
  title="Time entry for Timesheets, time entries always have a  
timesheet and are always for one day only and recording the hours  
for one person which is defined on the timesheet. A timesheet will  
always have at least one time entry.">


Modified: ofbiz/trunk/specialpurpose/projectmgr/widget/forms/ 
TaskForms.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/widget/forms/TaskForms.xml?rev=685013&r1=685012&r2=685013&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/specialpurpose/projectmgr/widget/forms/TaskForms.xml  
(original)
+++ ofbiz/trunk/specialpurpose/projectmgr/widget/forms/TaskForms.xml  
Mon Aug 11 18:12:33 2008

@@ -659,8 +659,9 @@




-
-name="ProjectAndPhaseAndTask" description="${projectName} : $ 
{phaseName}">

+
+description="${projectName} : ${phaseName}" key-field-name="phaseId">

+



@@ -675,12 +676,9 @@




-name="ProjectPartyAndPhaseAndTask" description="${workEffortName} ($ 
{phaseName}-${projectName})">
-name="userLogin.partyId"/>
-value="TASK"/>

-
-
-
+name="ProjectPartyAndPhaseAndTask" description="${projectName} - $ 
{phaseName}"/>

+
+  
>



\ No newline at end of file

Re: svn commit: r685809 - in /ofbiz/trunk/applications/order/webapp/ordermgr: WEB-INF/actions/entry/catalog/InlineProductDetail.groovy entry/catalog/inlineProductDetail.ftl

[Vikas Mayur]

On Thu, Aug 14, 2008 at 2:07 PM, <[EMAIL PROTECTED]> wrote:

> Author: bibryam
> Date: Thu Aug 14 01:37:52 2008
> New Revision: 685809
>
> URL: http://svn.apache.org/viewvc?rev=685809&view=rev
> Log:
> Missed these files in my previous commit.
>
> Added:
>
>  
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/InlineProductDetail.groovy
>   (with props)
>
>  
> ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/inlineProductDetail.ftl
>   (with props)
>
> Added:
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/InlineProductDetail.groovy
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/InlineProductDetail.groovy?rev=685809&view=auto
>
> ==
> ---
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/InlineProductDetail.groovy
> (added)
> +++
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/InlineProductDetail.groovy
> Thu Aug 14 01:37:52 2008
> @@ -0,0 +1,311 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one
> + * or more contributor license agreements.  See the NOTICE file
> + * distributed with this work for additional information
> + * regarding copyright ownership.  The ASF licenses this file
> + * to you under the Apache License, Version 2.0 (the
> + * "License"); you may not use this file except in compliance
> + * with the License.  You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing,
> + * software distributed under the License is distributed on an
> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> + * KIND, either express or implied.  See the License for the
> + * specific language governing permissions and limitations
> + * under the License.
> + */
> +
> +import java.lang.*;
> +import java.util.*;
> +import java.text.NumberFormat;
> +import org.ofbiz.base.util.*;
> +import org.ofbiz.service.*;
> +import org.ofbiz.entity.*;
> +import org.ofbiz.entity.condition.*;
> +import org.ofbiz.entity.util.*;
> +import org.ofbiz.webapp.taglib.*;
> +import org.ofbiz.webapp.stats.VisitHandler;
> +import org.ofbiz.order.shoppingcart.ShoppingCartEvents;
> +import org.ofbiz.product.catalog.*;
> +import org.ofbiz.product.category.*;
> +import org.ofbiz.product.product.ProductWorker;
> +import org.ofbiz.product.product.ProductContentWrapper;
> +import org.ofbiz.product.product.ProductSearch;
> +import org.ofbiz.product.product.ProductSearchSession;
> +import org.ofbiz.product.store.*;
> +
> +inlineProductId = request.getAttribute("inlineProductId");
> +inlineCounter = request.getAttribute("inlineCounter");
> +context.inlineCounter = inlineCounter;
> +context.inlineProductId = inlineProductId;
> +
> +contentPathPrefix = CatalogWorker.getContentPathPrefix(request);
> +catalogName = CatalogWorker.getCatalogName(request);
> +currentCatalogId = CatalogWorker.getCurrentCatalogId(request);
> +
> +if (inlineProductId) {
> +inlineProduct = delegator.findByPrimaryKeyCache("Product", [productId
> : inlineProductId]);
> +if (inlineProduct) {
> +context.product = inlineProduct;
> +contentWrapper = new ProductContentWrapper(inlineProduct,
> request);
> +context.put("title", contentWrapper.get("PRODUCT_NAME"));
> +context.put("metaDescription", contentWrapper.get("DESCRIPTION"));
> +productTemplate = product.detailScreen;
> +if (productTemplate) {
> +detailScreen = productTemplate;
> +}
> +}
> +}
> +
> +templatePathPrefix = CatalogWorker.getTemplatePathPrefix(request);
> +if (templatePathPrefix) {
> +detailScreen = templatePathPrefix + detailScreen;
> +}
> +context.detailScreen = detailScreen;
> +
> +String buildNext(Map map, List order, String current, String prefix, Map
> featureTypes) {
> +def ct = 0;
> +def buf = new StringBuffer();
> +buf.append("function listFT" + inlineCounter + current + prefix + "()
> { ");
> +buf.append("document.forms[\"configform\"].elements[\"FT" +
> inlineCounter + current + "\"].options.length = 1;");
> +buf.append("document.forms[\"configform\"].elements[\"FT" +
> inlineCounter + current + "\"].options[0] = new Option(\"" +
> featureTypes[current] + "\",\"\",true,true);");
> +map.each { key, value ->
> +def optValue = null;
> +
> +if (order.indexOf(current) == (order.size()-1)) {
> +optValue = value.iterator().next();
> +} else {
> +optValue = prefix + "_" + ct;
> +}
> +
> +buf.append("document.forms[\"configform\"].elements[\"FT" +
> inlineCounter + current + "\"].options[" + (ct + 1) + "] = new Option(\"" +
> key + "\",\"" + optValue + "\");");
> +ct++;
> +}
> +buf.append(" }");
> +if (order.indexOf(cur

Re: svn commit: r689772 - in /ofbiz/trunk: applications/product/data/ applications/product/servicedef/ applications/product/src/org/ofbiz/product/product/ applications/product/webapp/catalog/WEB-INF/

[Vikas Mayur]

On Aug 28, 2008, at 3:32 PM, [EMAIL PROTECTED] wrote:


Author: jleroux
Date: Thu Aug 28 03:02:47 2008
New Revision: 689772

URL: http://svn.apache.org/viewvc?rev=689772&view=rev
Log:
A patch from Mridul Pathak "Added support for uploading additional  
Product Views (images)" (https://issues.apache.org/jira/browse/OFBIZ-1930 
) - OFBIZ-1930


I fixed an, unrelated to patch, problem in  
EditProductContentContent.groovy. This is not the 1st time I cross  
this type of issue. I checked it does not appear on demo server and  
I guess it was not appearing with bsh  before. I'm not sure of its  
origin but it seems related to my configuration. I use, from my  
machine default, "Central European Summer Time" and demo server uses  
"Central Daylight Time". But I can't see why it affects my machine  
and not the demo server : there is no origin here (maybe GMT, but  
obviously it's not the case)

The lines I added are (+ import)
} else {
   fromDate = ObjectType.simpleTypeConvert(fromDate, "Timestamp",  
null, null, false)

}
(I intentionnaly let the line without semi-colon as it's not  
mandatory in Groovy)



I think we should stick to some guidelines on usage of groovy features  
especially semi-colon not mandatory, in OFBiz. This is just to make  
sure that code looks alike.

My preference is to use semicolon. Thoughts ?

- Vikas





Added:
   ofbiz/trunk/framework/images/webapp/images/products/additional/
Modified:
   ofbiz/trunk/applications/product/data/ProductTypeData.xml
   ofbiz/trunk/applications/product/servicedef/services.xml
   ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ 
ProductServices.java
   ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/ 
product/EditProductContentContent.groovy
   ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/ 
controller.xml
   ofbiz/trunk/applications/product/webapp/catalog/product/ 
ProductForms.xml


Modified: ofbiz/trunk/applications/product/data/ProductTypeData.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/data/ProductTypeData.xml?rev=689772&r1=689771&r2=689772&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/product/data/ProductTypeData.xml  
(original)
+++ ofbiz/trunk/applications/product/data/ProductTypeData.xml Thu  
Aug 28 03:02:47 2008

@@ -231,6 +231,10 @@
hasTable="N" parentTypeId="" productContentTypeId="MEDIUM_IMAGE_ALT"/>
hasTable="N" parentTypeId="" productContentTypeId="LARGE_IMAGE_ALT"/>
hasTable="N" parentTypeId="" productContentTypeId="DETAIL_IMAGE_ALT"/>
+hasTable="N" parentTypeId=""  
productContentTypeId="ADDITIONAL_IMAGE_1"/>
+hasTable="N" parentTypeId=""  
productContentTypeId="ADDITIONAL_IMAGE_2"/>
+hasTable="N" parentTypeId=""  
productContentTypeId="ADDITIONAL_IMAGE_3"/>
+hasTable="N" parentTypeId=""  
productContentTypeId="ADDITIONAL_IMAGE_4"/>
parentTypeId="" productContentTypeId="ADDTOCART_LABEL"/>
parentTypeId="" productContentTypeId="ADDTOCART_IMAGE"/>
parentTypeId="" productContentTypeId="SHORT_SALES_PITCH"/>


Modified: ofbiz/trunk/applications/product/servicedef/services.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/servicedef/services.xml?rev=689772&r1=689771&r2=689772&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/product/servicedef/services.xml  
(original)
+++ ofbiz/trunk/applications/product/servicedef/services.xml Thu Aug  
28 03:02:47 2008

@@ -414,6 +414,16 @@



+
+name="ProductContent" engine="java"
+location="org.ofbiz.product.product.ProductServices"  
invoke="addAdditionalViewForProduct" auth="true">

+
+
+
+type="String"/>

+
+
+


name="SupplierProduct" engine="simple"


Modified: ofbiz/trunk/applications/product/src/org/ofbiz/product/ 
product/ProductServices.java

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductServices.java?rev=689772&r1=689771&r2=689772&view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ 
ProductServices.java (original)
+++ ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ 
ProductServices.java Thu Aug 28 03:02:47 2008

@@ -18,14 +18,23 @@
  
***/

package org.ofbiz.product.product;

+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.io.RandomAccessFile;
+import java.nio.ByteBuffer;
import java.sql.Timestamp;
import java.util.*;

+import javolution.util.FastList;
+import javolution.util.FastMap;
+
import org.ofbiz.base.util.Debug;
import org.ofbiz.base.util.UtilDateTime;
import org.ofbiz.base.

Re: svn commit: r689772 - in /ofbiz/trunk: applications/product/data/ applications/product/servicedef/ applications/product/src/org/ofbiz/product/product/ applications/product/webapp/catalog/WEB-INF/

[Vikas Mayur]

Yeah, it would be good to have consensus on usage of groovy features  
not just on this semi-colon issue but others - if any (which I am not  
able to think of).


- Vikas


On Aug 28, 2008, at 4:38 PM, Jacques Le Roux wrote:

I'm divided. The 1st time I saw that in groovy scripts I checked and  
saw that Groovy allows that.
My 1st reaction was, like you, to fix it.  For me it was the same  
than not using {} for a single line in Java. It's like a bomb :  
sooner or later it may explode...
But then I thought that there are other differences between Java and  
Goovy, why not allow this one ?
As I outlined above it's a bit dangerous, even Groovy authors point  
it out !

Of course I will follow consensus...

Jacques

From: "Vikas Mayur" <[EMAIL PROTECTED]>


On Aug 28, 2008, at 3:32 PM, [EMAIL PROTECTED] wrote:


Author: jleroux
Date: Thu Aug 28 03:02:47 2008
New Revision: 689772

URL: http://svn.apache.org/viewvc?rev=689772&view=rev
Log:
A patch from Mridul Pathak "Added support for uploading  
additional  Product Views (images)" (https://issues.apache.org/jira/browse/OFBIZ-1930 
 ) - OFBIZ-1930


I fixed an, unrelated to patch, problem in   
EditProductContentContent.groovy. This is not the 1st time I  
cross  this type of issue. I checked it does not appear on demo  
server and  I guess it was not appearing with bsh  before. I'm not  
sure of its origin but it seems related to my configuration. I  
use, from my  machine default, "Central European Summer Time" and  
demo server uses  "Central Daylight Time". But I can't see why it  
affects my machine  and not the demo server : there is no origin  
here (maybe GMT, but  obviously it's not the case)

The lines I added are (+ import)
} else {
  fromDate = ObjectType.simpleTypeConvert(fromDate, "Timestamp",   
null, null, false)

}
(I intentionnaly let the line without semi-colon as it's not   
mandatory in Groovy)



I think we should stick to some guidelines on usage of groovy  
features  especially semi-colon not mandatory, in OFBiz. This is  
just to make  sure that code looks alike.

My preference is to use semicolon. Thoughts ?

- Vikas





Added:
  ofbiz/trunk/framework/images/webapp/images/products/additional/
Modified:
  ofbiz/trunk/applications/product/data/ProductTypeData.xml
  ofbiz/trunk/applications/product/servicedef/services.xml
  ofbiz/trunk/applications/product/src/org/ofbiz/product/product/  
ProductServices.java
  ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/  
product/EditProductContentContent.groovy
  ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/  
controller.xml
  ofbiz/trunk/applications/product/webapp/catalog/product/  
ProductForms.xml


Modified: ofbiz/trunk/applications/product/data/ProductTypeData.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/data/ProductTypeData.xml?rev=689772&r1=689771&r2=689772&view=diff
= = = = = = = =  
= 
= 

--- ofbiz/trunk/applications/product/data/ProductTypeData.xml   
(original)
+++ ofbiz/trunk/applications/product/data/ProductTypeData.xml Thu   
Aug 28 03:02:47 2008

@@ -231,6 +231,10 @@
   hasTable="N" parentTypeId=""  
productContentTypeId="MEDIUM_IMAGE_ALT"/>
   hasTable="N" parentTypeId=""  
productContentTypeId="LARGE_IMAGE_ALT"/>
   hasTable="N" parentTypeId=""  
productContentTypeId="DETAIL_IMAGE_ALT"/>
+hasTable="N" parentTypeId=""  
productContentTypeId="ADDITIONAL_IMAGE_1"/>
+hasTable="N" parentTypeId=""  
productContentTypeId="ADDITIONAL_IMAGE_2"/>
+hasTable="N" parentTypeId=""  
productContentTypeId="ADDITIONAL_IMAGE_3"/>
+hasTable="N" parentTypeId=""  
productContentTypeId="ADDITIONAL_IMAGE_4"/>
   hasTable="N"  parentTypeId=""  
productContentTypeId="ADDTOCART_LABEL"/>
   hasTable="N"  parentTypeId=""  
productContentTypeId="ADDTOCART_IMAGE"/>
   hasTable="N"  parentTypeId=""  
productContentTypeId="SHORT_SALES_PITCH"/>


Modified: ofbiz/trunk/applications/product/servicedef/services.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/servicedef/services.xml?rev=689772&r1=689771&r2=689772&view=diff
= = = = = = = =  
= 
= 

--- ofbiz/trunk/applications/product/servicedef/services.xml   
(original)
+++ ofbiz/trunk/applications/product/servicedef/services.xml Thu  
Aug  28 03:02:47 2008

@@ -414,6 +414,16 @@
   
   
   
+
+name="ProductContent" engine="java"
+location="org.ofbiz.p

Re: svn commit: r688993 - in /ofbiz/trunk/applications: order/entitydef/ order/src/org/ofbiz/order/order/ order/src/org/ofbiz/order/shoppingcart/ order/webapp/ordermgr/WEB-INF/actions/entry/ order/web

[Vikas Mayur]

Getting following error on process order call and it is related to new field
added to OrderItemShipGroup entity.

Failure in create operation for entity [OrderItemShipGroup]:
org.ofbiz.entity.GenericEntityException: Error while inserting:
[GenericEntity:OrderItemShipGroup][carrierPartyId,UPS(java.lang.String)][carrierRoleTypeId,CARRIER(java.lang.String)][contactMechId,9015(java.lang.String)][createdStamp,2008-08-30
15:23:26.671(java.sql.Timestamp)][createdTxStamp,2008-08-30
15:23:23.768(java.sql.Timestamp)][facilityId,(java.lang.String)][giftMessage,(java.lang.String)][isGift,N(java.lang.String)][lastUpdatedStamp,2008-08-30
15:23:26.671(java.sql.Timestamp)][lastUpdatedTxStamp,2008-08-30
15:23:23.768(java.sql.Timestamp)][maySplit,N(java.lang.String)][orderId,WSCO1(java.lang.String)][shipAfterDate,null()][shipByDate,null()][shipGroupSeqId,1(java.lang.String)][shipmentMethodTypeId,NEXT_DAY(java.lang.String)][shippingInstructions,null()][supplierPartyId,null()][vendorPartyId,null()]
(SQL Exception while executing the following:INSERT INTO
OFBIZ.ORDER_ITEM_SHIP_GROUP (ORDER_ID, SHIP_GROUP_SEQ_ID,
SHIPMENT_METHOD_TYPE_ID, SUPPLIER_PARTY_ID, VENDOR_PARTY_ID,
CARRIER_PARTY_ID, CARRIER_ROLE_TYPE_ID, FACILITY_ID, CONTACT_MECH_ID,
TELECOM_CONTACT_MECH_ID, TRACKING_NUMBER, SHIPPING_INSTRUCTIONS, MAY_SPLIT,
GIFT_MESSAGE, IS_GIFT, SHIP_AFTER_DATE, SHIP_BY_DATE, LAST_UPDATED_STAMP,
LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table
'ORDER_ITEM_SHIP_GROUP' caused a violation of foreign key constraint
'ORDER_ITSG_FAC' for key ().  The statement has been rolled back.)). Rolling
back transaction.


- Vikas

On Tue, Aug 26, 2008 at 2:00 PM, <[EMAIL PROTECTED]> wrote:

> Author: bibryam
> Date: Tue Aug 26 01:30:05 2008
> New Revision: 688993
>
> URL: http://svn.apache.org/viewvc?rev=688993&view=rev
> Log:
> Applied (with few modifications) patch from Len Shein, OFBIZ-1928: "Allow
> the Shopping Cart to accept a facility per ship group to specify where
> inventory should be reserved from".
> Also added a dropdown button to choose a facility in order manager shipping
> screen.
>
>
> Modified:
>ofbiz/trunk/applications/order/entitydef/entitymodel.xml
>
>  ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
>
>  
> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
>
>  
> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
>
>  
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy
>ofbiz/trunk/applications/order/webapp/ordermgr/entry/shipsettings.ftl
>ofbiz/trunk/applications/product/config/ProductUiLabels.xml
>
>  
> ofbiz/trunk/applications/product/script/org/ofbiz/product/store/ProductStoreServices.xml
>ofbiz/trunk/applications/product/servicedef/services_store.xml
>
> Modified: ofbiz/trunk/applications/order/entitydef/entitymodel.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/entitydef/entitymodel.xml?rev=688993&r1=688992&r2=688993&view=diff
>
> ==
> --- ofbiz/trunk/applications/order/entitydef/entitymodel.xml (original)
> +++ ofbiz/trunk/applications/order/entitydef/entitymodel.xml Tue Aug 26
> 01:30:05 2008
> @@ -794,6 +794,7 @@
>   For use with
> multi-vendor stores, order will be split so that each ship group is
> associated with only one vendor (only if applicable)
>   
>   
> +  
>   
>   
>   
> @@ -826,6 +827,9 @@
> 
>  rel-field-name="roleTypeId"/>
>   
> +   rel-entity-name="Facility">
> +
> +  
>rel-entity-name="ShipmentMethodType">
> 
>   
>
> Modified:
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?rev=688993&r1=688992&r2=688993&view=diff
>
> ==
> ---
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
> (original)
> +++
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
> Tue Aug 26 01:30:05 2008
> @@ -1115,6 +1115,8 @@
> continue;
> }
> GenericValue orderItem = (GenericValue)
> itemValuesBySeqId.get(orderItemShipGroupAssoc.get("orderItemSeqId"));
> +GenericValue orderItemShipGroup =
> orderItemShipGroupAssoc.getRelatedOne("OrderItemShipGroup");
> +String shipGroupFacilityId =
> orderItemShipGroup.getString("facilityId");
> String itemStatus = orderItem.getString("statusId");
> if ("ITEM_REJECTED".equals(itemStatus) ||
> "ITEM_CANCELLED".equals(itemStatus) || "ITEM_COMPLETED".equals

Re: svn commit: r688993 - in /ofbiz/trunk/applications: order/entitydef/ order/src/org/ofbiz/order/order/ order/src/org/ofbiz/order/shoppingcart/ order/webapp/ordermgr/WEB-INF/actions/entry/ order/web

[Vikas Mayur]

Bilgin, I am sorry that I just post this in hurry.

The error comes when you click on create order link on order confirmation
screen on order manager screen.

Hope this helps !

- Vikas

On Sat, Aug 30, 2008 at 6:36 PM, Bilgin Ibryam <[EMAIL PROTECTED]> wrote:

> Quoting Vikas Mayur <[EMAIL PROTECTED]>:
>
>  Getting following error on process order call and it is related to new
>> field
>> added to OrderItemShipGroup entity.
>>
>>
> Vikas,
> can you provide some more information on how you get this error?
> I couldn't find "process order call" stuff.
>
> Bilgin
>
> 
> This message was sent using IMP, the Internet Messaging Program.
>
>

Re: svn commit: r690942 - in /ofbiz/trunk/applications/ecommerce: script/org/ofbiz/ecommerce/customer/CustomerEvents.xml webapp/ecommerce/WEB-INF/controller.xml

[Vikas Mayur]

Thanks David for review.
Done improvements in rev. 691119.

- Vikas

On Mon, Sep 1, 2008 at 7:01 PM, David E. Jones <[EMAIL PROTECTED]>wrote:

>
> You could use the ProductStore setting that already exists (and has
> previously been used on the new customer screen) to determine whether or not
> this is used.
>
> -David
>
>
> [EMAIL PROTECTED] wrote:
>
>> Author: mor
>> Date: Mon Sep  1 04:44:10 2008
>> New Revision: 690942
>>
>> URL: http://svn.apache.org/viewvc?rev=690942&view=rev
>> Log:
>> Added a new event that set userloginId from an email address. If user edit
>> email address then set it as a new userLoginId and disabled date to far in
>> the future for existing userLoginId.
>> This is a new feature to new profile page.
>>
>> Thanks to Rishi Solanki for this work and Sumit Pandit and Mridul Pathak
>> for review.
>>
>>
>> Modified:
>>
>>  
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>>
>>  ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>>
>> Modified:
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml?rev=690942&r1=690941&r2=690942&view=diff
>>
>> ==
>> ---
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>> (original)
>> +++
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>> Mon Sep  1 04:44:10 2008
>> @@ -1493,4 +1493,47 @@
>> 
>> 
>>  +> short-description="Set userloginId from email. If user edit email address
>> then set it as a new userLoginId and disabled date to far in the future for
>> existing userLoginId">
>> +> value="userLogin.userLoginId">
>> +> map-name="parameters" to-map-name="serviceContext"/>
>> +> from-field="userLogin"/>
>> +> in-map-name="serviceContext">
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +> from-field="parameters.disabledDateTime" type="Date"/>
>> +
>> +
>> +
>> +> from-field="nowTimeStamp" years="${parameters.disableForYear}"/>
>> +
>> +> from-field="nowTimeStamp" years="20"/>
>> +
>> +
>> +
>> +
>> +> from-field="disabledDateTime"/>
>> +
>> +
>> +
>> +
>> +
>> +> short-description="Update a customer profile and userloginId from email">
>> +
>> +> from-field="parameters.emailAddress"/>
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>>  
>> \ No newline at end of file
>>
>> Modified:
>> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml?rev=690942&r1=690941&r2=690942&view=diff
>>
>> ==
>> ---
>> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>> (original)
>> +++
>> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>> Mon Sep  1 04:44:10 2008
>> @@ -1719,6 +1719,8 @@
>> 
>> 
>> > path="org/ofbiz/ecommerce/customer/CustomerEvents.xml"
>> invoke="updateCustomerProfile"/>
>> +
>> +
>> 
>> 
>> 
>>
>>
>>

Re: svn commit: r690942 - in /ofbiz/trunk/applications/ecommerce: script/org/ofbiz/ecommerce/customer/CustomerEvents.xml webapp/ecommerce/WEB-INF/controller.xml

[Vikas Mayur]

Hi Jacques,

   I have this in my todo list and will try to do this soon.

Thanks,
- Vikas

On Mon, Sep 1, 2008 at 7:12 PM, Jacques Le Roux <
[EMAIL PROTECTED]> wrote:

> Hi Vikas,
>
> This and previous changes are great, but could you (and all concerned)
> please update
> http://docs.ofbiz.org/display/OFBIZ/Main+New+features ?
>
> I was ready to do it , but I think you (and others concerned) would do
> better than I
>
> TIA
>
> Jacques
>
>
>
>  Author: mor
>> Date: Mon Sep  1 04:44:10 2008
>> New Revision: 690942
>>
>> URL: http://svn.apache.org/viewvc?rev=690942&view=rev
>> Log:
>> Added a new event that set userloginId from an email address. If user edit
>> email address then set it as a new userLoginId and
>> disabled date to far in the future for existing userLoginId.
>> This is a new feature to new profile page.
>>
>> Thanks to Rishi Solanki for this work and Sumit Pandit and Mridul Pathak
>> for review.
>>
>>
>> Modified:
>>
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>>
>> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>>
>> Modified:
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>> URL:
>>
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml?rev=690942&r1=690941&r2=690942&view=diff
>>
>> ==
>> ---
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>> (original)
>> +++
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
>> Mon Sep  1 04:44:10 2008
>> @@ -1493,4 +1493,47 @@
>>
>>
>>
>> +> short-description="Set userloginId from email. If user edit email address
>> then set it as a new userLoginId and disabled date to far in the future
>> for existing userLoginId">
>> +> value="userLogin.userLoginId">
>> +> map-name="parameters" to-map-name="serviceContext"/>
>> +> from-field="userLogin"/>
>> +> in-map-name="serviceContext">
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +> from-field="parameters.disabledDateTime" type="Date"/>
>> +
>> +
>> +
>> +> from-field="nowTimeStamp" years="${parameters.disableForYear}"/>
>> +
>> +> from-field="nowTimeStamp" years="20"/>
>> +
>> +
>> +
>> +
>> +> from-field="disabledDateTime"/>
>> +
>> +
>> +
>> +
>> +
>> +> short-description="Update a customer profile and userloginId
>> from email">
>> +
>> +> from-field="parameters.emailAddress"/>
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> 
>> \ No newline at end of file
>>
>> Modified:
>> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>> URL:
>>
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml?rev=690942&r1=690941&r2=690942&view=diff
>>
>> ==
>> ---
>> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>> (original)
>> +++
>> ofbiz/trunk/applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>> Mon Sep  1 04:44:10 2008
>> @@ -1719,6 +1719,8 @@
>>
>>
>>> path="org/ofbiz/ecommerce/customer/CustomerEvents.xml"
>> invoke="updateCustomerProfile"/>
>> +
>> +
>>
>>
>>
>>
>>
>>
>

Re: Single word labels

[Vikas Mayur]

Hi Bruno,

I am sorry for bit late in reply.
If this urgent for you then please go ahead and else please wait as we  
haven't yet finished with this.


- Vikas

On Sep 4, 2008, at 1:37 AM, Bruno Busco wrote:


Of course,
if you have not time I will try to submit a patch for this.
-Bruno

2008/9/3 Bruno Busco <[EMAIL PROTECTED]>


Hi Vikas,
I was trying to translate the newly added labels into ecommerce  
profile
screens and I found out that several of them are formed up joining  
single

words instead of having the whole sentence into a single label.

For example in
applications\ecommerce\webapp\ecommerce\customer\profile 
\ManageAddress.ftl

 href="javascript:void(0)">${uiLabelMap.CommonAdd} $ 
{uiLabelMap.CommonNew}

${uiLabelMap.OrderAddress}
or
    ${uiLabelMap.EcommerceDefault}
${uiLabelMap.CommonAddresses}

This has been discussed in the ML and we agreed that should be  
avoided

because in other languages the words are swapped.

(Default Address -> Italian -> Indirizzo predefinito)

If you agree and have time please change this.

Many thanks,
Bruno

I think userPrefGroupId field on UserPrefGroupType should be userPrefGroupTypeId, as per conventions

[Vikas Mayur]

dev,

WDYT ?

If agreed I would submit a patch.


- Vikas