Re: [josm-dev] Automatic tiles downloading in WMSPlugin
On Sat, 13 Sep 2008, Petr Dlouhý wrote: Because I need to download the map through Yahoo map API. As far as I know, the arrangement with Yahoo was set in that manner. The map API needs a html browser with javascript support, that's why. I don't rely to PNG format, it is just something what is accepted by the java libraries, I am using. There are some references in the net about such stuff for Windows also. And probably we could make such a thing ourselves using QT 4.4.1 and the included webkit? It seems this would require something like 50 to 100 lines of code. Would be portable then as well. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Automatic tiles downloading in WMSPlugin
On Tue, 9 Sep 2008, Petr Dlouhý wrote: Hello, I made several changes to the ymap.html (the page which downloads the Yahoo map). It is commited yet. I am not sure, if my changes are covering also this bug, so please try it. Nothing changed. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Automatic tiles downloading in WMSPlugin
On Fri, 12 Sep 2008, Dirk Stöcker wrote: I got this fixed with a workaround. I use following download script: --- #! /bin/bash gnome-web-photo --mode=photo --format=ppm $1 /dev/stdout |pnmcrop -white |pnmtopng --- Now the other problem. I always get lowest resolution pictures. The plugin tells me to download at zoom 0. How can this be fixed? Ok. Found that out now also. It depends on the very first downloaded tile. Some improvements for this: a) Please detected The Yahoo-error images automatically. That can be done by a histogram: More than 50% (70%?) of the picture have color 204,204,204. Switch to higher download mode for the corresponding tile (or the whole system) then. b) Allow a way to redownload the tiles with another zoom level. Best would be, if Low and High quality tiles can be mixed. Lower quality tiles are displayed in background and higher accuracy tiles in front. This would allow to start with deep zoom and see helpful data in the areas were this is not available nevertheless. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] [PATCH] Bugfix for Proxy configuration
On Thu, 11 Sep 2008, Christoph Brill wrote: Please improve your patch a bit nevertheless: a) if the first checkbox is unckecked, all 5 elements should be disabled. b) if the second checkbox is checked, username and password should be disabled. You were right about your comments for enabling/disabling the components. My initial values where wrong. Attached is a patch to fix that. At least I can't find any other bug in there right now. If I was missing something, just let me know. Hmm, the josm-dev patch catcher got to work again. Please try sending with extension .txt or/and to my private mail. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bug in the Preferences (rev. 935)
On Tue, 9 Sep 2008, Christoph Seitz wrote: Today I found a bug in the Preferences. If you have no plugins, you get an NullPointerException. I described it on the josm-page. http://josm.openstreetmap.de/ticket/1520 Also added a patch for this problem :) But it would not work. null deletes the preferences entry and your fix prevented this :-) I fixed the bug in SVN. btw. I'm new to OSM and JOSM but I really really like it and I want to support the project, where I can, because I found it overwhelming to see, how much of Germany has been mapped. But I also so a lots of work to do. Maybe there is some work for a Java-Programmer here. :) Sure. We have 140 bug reports. Feel free to choose and fix. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bug in the Preferences (rev. 935)
On Tue, 9 Sep 2008, Dirk Stöcker wrote: Today I found a bug in the Preferences. If you have no plugins, you get an NullPointerException. I described it on the josm-page. http://josm.openstreetmap.de/ticket/1520 Also added a patch for this problem :) But it would not work. null deletes the preferences entry and your fix prevented this :-) I fixed the bug in SVN. Because I sometimes forget to write it and I got a remember to be more friendly, one note to you and all others: I value patches. Make them, send them, but be prepared that I do not always accept them. A note like above means in long: Thanks for your patch. I checked it. It is the right way, but there was an error with it. The error was this ..., but as it was a minor error I fixed it myself (in this case as I introduced the bug myself also). I'm waiting for your next patch. I know all beginning is hard and I myself had a hard learning time, because I needed to learn programming all by myself. Thus whenever I write a comment about a patch, it will always contain a text what was wrong and what to fix, so the author and its skills can improve. But be prepared that I sometimes forget the Thanks :-) Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Still looking for patch review
On Mon, 8 Sep 2008, [EMAIL PROTECTED] wrote: I'm still looking for someone to look at the patch I submitted to ticket 682[1] to add proxy server configuration to JOSM. I really like to see this patch included into JOSM so please let me know if anything is wrong with it and what I could do to fix is. Sorry. I had a look at it, but forgot about it afterwards. If I read the stuff correctly, you add a new settings menu. Correct? Please don't do that. We already have to many of these. Add the settings in the same menu, where the OSM user password is entered. There is enough space left. I did the same approach as every settings backend which encapsulates the settings within one class. But in JOSM the settings backend is decoupled from the presentation to the user. Therefore presentation is (as you suggest) on the same tab as the username+password fields. Applied. Please improve your patch a bit nevertheless: a) if the first checkbox is unckecked, all 5 elements should be disabled. b) if the second checkbox is checked, username and password should be disabled. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bug #973 Problem with AudioMarker
On Tue, 9 Sep 2008, Christoph Seitz wrote: but I'm not sure, whether this solution is good solution. And I think, the hole thing with the audio markers should be a bit more clear. Well, that's a true word :-) E.g. I had a short wav file which had to be at the end of my GPX track. I was unable to move the synchronisation behind the end of the wav and thus could not get it synchroniced. Also sometimes it tells it synchroniced, but when I play nothing changed. There are still some bugs hidden in audio stuff waiting to be fixed. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bug #973 Problem with AudioMarker
On Tue, 9 Sep 2008, David Earl wrote: E.g. I had a short wav file which had to be at the end of my GPX track. I was unable to move the synchronisation behind the end of the wav and thus could not get it synchroniced. Also sometimes it tells it synchroniced, but when I play nothing changed. There are still some bugs hidden in audio stuff waiting to be fixed. I'm sure there are. But as the original author of this, can I say I'm not psychic. If you'd put a bug report in about the above, I could try fixing it; if this 973 had been assigned to me I might have been aware of it. A good description also needs time and I did not have it yet :-) Please explain move the synchronisation behind the end of the wav some more. In order to synchronise you need a both a defined point in your audio and a defined point in your GPX. Were you syncing to an explicit waypoint, or to a point on the track (with SHIFT+DRAG)? Can you let me have the files (attach them to a bug report) so I can try (please say what the word you used to sync on was if it is in German). Have a wave e.g. 5 minutes and a GPX trace of e.g. 2 hours. Now the 5 minutes where about the last 5 of that track. I this SHIFT-MOVE'ed the playhead to the GPS-waypoint where it belonged to, but instead of syncing a message came telling me, that I go behind the file end. But as said I had not yet the time to check details. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Still looking for patch review
On Mon, 8 Sep 2008, [EMAIL PROTECTED] wrote: I'm still looking for someone to look at the patch I submitted to ticket 682[1] to add proxy server configuration to JOSM. I really like to see this patch included into JOSM so please let me know if anything is wrong with it and what I could do to fix is. Sorry. I had a look at it, but forgot about it afterwards. If I read the stuff correctly, you add a new settings menu. Correct? Please don't do that. We already have to many of these. Add the settings in the same menu, where the OSM user password is entered. There is enough space left. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list [EMAIL PROTECTED] http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] How to contribute changes to JOSM?
On Mon, 8 Sep 2008, Jan Peter Stotz wrote: Assuming you made http://josm.openstreetmap.de/ticket/1515 Why is this needed? We already have the option to zoom to the selection. Oh, I did not realize that. Could you please explain how to zoom to a selection? Select something. Press 3 or choose the corresponding menu point. There is also zoom to conflict, zoom to whole dataset and a fourth zoom I do not remember right now. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list [EMAIL PROTECTED] http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] How to contribute changes to JOSM?
On Mon, 8 Sep 2008, Jan Peter Stotz wrote: As my zoom to implementation differs a bit from the official implementation I may rewrite the patch so that it uses the official method where applicable or at least behaves similarly. Would that be an option? Ah, and when you are on it. I would like a go back to last selection button. That would be very helpful. Should be easy by storing the selection dataset. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list [EMAIL PROTECTED] http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Still looking for patch review
On Mon, 8 Sep 2008, [EMAIL PROTECTED] wrote: I'm still looking for someone to look at the patch I submitted to ticket 682[1] to add proxy server configuration to JOSM. I really like to see this patch included into JOSM so please let me know if anything is wrong with it and what I could do to fix is. Sorry. I had a look at it, but forgot about it afterwards. If I read the stuff correctly, you add a new settings menu. Correct? Please don't do that. We already have to many of these. Add the settings in the same menu, where the OSM user password is entered. There is enough space left. I did the same approach as every settings backend which encapsulates the settings within one class. But in JOSM the settings backend is decoupled from the presentation to the user. Therefore presentation is (as you suggest) on the same tab as the username+password fields. Ah ok. I will try the patch when I have time to do so (unless someone else does first :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Automatic tiles downloading in WMSPlugin
On Sat, 6 Sep 2008, Dirk Stöcker wrote: so the plugin is in josm like ewmsplugin. You can test the plugin easily now. I have a Yahoo display problem. The tiles are not scaled correctly: http://www.dstoecker.eu/ewms.png Another error. The ewmsplugin adds an Yahoo-URL entry each time preferences are handled. I have 16 entries at the moment. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] How to contribute changes to JOSM?
On Sun, 7 Sep 2008, Jan Peter Stotz wrote: I have just created a small patch for a JOSM class - how to I contribute it? I did not found where to create a JOSM-trac account that could be used for SVN access... Either post the patch here or make a new TRAC request containing a useful subject and [PATCH] in the subject. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Automatic tiles downloading in WMSPlugin
On Tue, 2 Sep 2008, Petr Dlouhý wrote: so the plugin is in josm like ewmsplugin. You can test the plugin easily now. I have a Yahoo display problem. The tiles are not scaled correctly: http://www.dstoecker.eu/ewms.png Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Automatic tiles downloading in WMSPlugin
On Sat, 6 Sep 2008, Dirk Stöcker wrote: so the plugin is in josm like ewmsplugin. You can test the plugin easily now. I have a Yahoo display problem. The tiles are not scaled correctly: http://www.dstoecker.eu/ewms.png A second comment. Instead of two menu entries to start and stop automatic loading, make a checkbox menu entry there (e.g. like for wireframe mode). Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Various problems with josm
On Fri, 5 Sep 2008, Rainer Rothkegel wrote: [... lots of tram realted stuff snipped] That's all one problem. The tram-style is overlayed with the tram-overlay style and thus makes it nearly invisible. I will fix this soon by removing overlays for identical base types. (Problem 3) Interestingly, tram lines don't even change colour when selected. Only the arrow-heads become highlighted. They change, but the overlay is to powerful, so you don't see it :-) (Problem 4) For some parts of the tram route, I was unable to select either the tram way or the street on which the tram way was located. From josm, there was no indication, that there was a tram way on top of a street, other than the drawing style of the way, which looked like a mixture of a street and a tram way. I think this happens, when two ways are constructed from the same nodes (or one is a subset of the other), like in this example: Probably you misinterpretet something here. If you see the tram, then the tram is displayed on top (which is BTW unpredictable). If you click, you always select the way on top, in this case the tram, Where you did not really see, that it was selected. To select the other way you need to use middle mouse-button + CTRL trick or use other means of way selection (e.g. drawing selection rectangle) and selection dialog to choose right element. (Problem 5) When trying to find the example above in the osm xml file, I looked for a method to identify the way xml element from the way selected in josm. Unfortunately, I could not see the id of the way in josm. Only the name was displayed, which is not unique. Middle click shows you ID. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] JOSM charset
Hello, now that I found a charset conflict in measurement plugin: Is there any definition in which charset the jar files are? Could we agree to use UTF-8 here or only plain ASCII? Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Patch for Align nodes straight and parallel action
On Sun, 31 Aug 2008, A Morris wrote: You're right, that the action probably needs more clicks. but making ways straight and aligned is not such an often done task, so for me the negative fact to have more different tools counts more :-) I'm not sure how having additional tools is a negative? I agree it JOSM already is know to be complicated. Addind lots of new tools wont help to make that better. Surely separate actions would be more useful (make parallel and make straight and parallel); it would be really annoying to have to select from a dialog box every time the action was used. (I don't see how the third option relative to first would work, how would the algorithm know which is first?) The selection is a list. So the first element is the first selected (at least I think so :-) What about making a patch against utils-plugin? You can implement the stuff there without the higher requirements I ask for main josm. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] how to create icons?
On Sun, 31 Aug 2008, Christoph Eckert wrote: I have implemented a new 'action' in josm, but it needs an icon in the menu. What is the preferred way to create these icons? instead of Dirk, I try to get modify some SVG in Inkscape. Then I export it as png. Are there SVG's of the internal program icons? Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Patch for Align nodes straight and parallel action
On Sun, 31 Aug 2008, A Morris wrote: if you want to make, for example, 4 ways straight and parallel using this action, you would simply shift-click 4 times, then press equals. If there was a method that made ways parallel (but did not automatically straighten them), then you would need click then L 4 times, then shift-click 4 times, then equals. The code for make ways parallel but preserve curves is going to be significantly more complicated, so I thought I would do them separately. You're right, that the action probably needs more clicks. but making ways straight and aligned is not such an often done task, so for me the negative fact to have more different tools counts more :-) I will happily integrate a patch which makes two ways parallel without needing special way design. This is also a long-standing feature request. http://josm.openstreetmap.de/ticket/67 You can also make a request: What do you want to do? straigthen ways, relative to first, relative to mean or something like that. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] how to create icons?
On Sat, 30 Aug 2008, A Morris wrote: I have implemented a new 'action' in josm, but it needs an icon in the menu. What is the preferred way to create these icons? a) You don't need an icon. Pass null and it works without. b) I use gimp to create icons. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Combining mappaint styles
Hello, as there have been no comments, I did what I want. So it is now implemented as follows: a) in style files there is a new type linemod b) this types parameters are equal to line. Only one additional type is mode. It may be over or under. Width also supports -x, +x and x% for specifications relative to main way. c) The colour field now also supports an alpha channel (using a forth set of hex values). d) All types also support parameter priority, which are used when multiple styles exists. For lines, nodes and areas the style with highest priority is used. e) Overlays are not limited. Multiple styles may get used here. I added one style for bridges and an highway/tram overlay style. The ones of you with more graphical determination, please fix the design, so it looks better :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Combining mappaint styles
On Wed, 27 Aug 2008, Ulf Lamping wrote: I was thinking about the representation, and the best idea I got aware of was to display the part of the way being a bridge (or tunnel) simply a little bit (1/2px?) wider than the normally used width. Don't think that is visible enough. My first thought was to use something like a specially dashed (dotted, ...) way, but that would be hard to distinguish from other dashed stuff (like tracks) and also probably hard to visually get for very short bridges (tunnels). What about alpha shaded lines? E.g. if you overlap a street with a 20% black line for tunnel or 20% green for bridge or something like that. Obviously, I haven't tried this out, so the best would be to have a prototype and have a look at it :-) Well, the design of the XML and the implementation depends a lot on the fact how to display it later. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Source code formatting template?
On Wed, 27 Aug 2008, Frederik Ramm wrote: As tr() is a static function that is called at runtime this should not make any difference. No. The translations are extracted from the sources, so the source design is important. You can't use whatever methods to join a string, as these will not be detected by the text extractor. Plainly it is a parser, which scans for tr( and takes everything till the next , or ). When it is a string literal, then it is translatable. Some more logic is used by gettext to make it more reliable. I am unsure how the process that extracts the string constants to be translated works. It can't possibly *execute* every branch of code that contains a tr()? But as I said, not my core competency ;-) But the joining of normal string laterals with + works. Example: src/org/openstreetmap/josm/tools/BugReportExceptionHandler.java:93 Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] slippymap plugin not wanting to make render requests
On Tue, 26 Aug 2008, Robin Rattay wrote: Dirk Stöcker schrieb: a) Temporary filename is final name+.tmp. b) Do the move as is done now. When move fails, leave the tmp file. c) On start check if there is a temp file and move it when possible. If not, inform the user. I've done it over. I called the new plugins files *.new instead of *.tmp, because latter sounds as if it were something you could delete after the programm has quit, which it isn't. I also cleaned up the use of hardcoded slashes in file paths in some places using File.separator instead. I wasn't sure what to write when informing the user that the moving failed, so if you have any ideas, please change that. Applied. Also added some better version display in dialog :-) Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Combining mappaint styles
Hello, I introduced the possibility to combine an area and an line style in current josm (thus reenabling the roundabout display). To combine two line styles (e.g. bridge, tunnel and street) someone needs to present an idea, how the displaying could be done for this. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] 865 as tested
Hello, Tuesday evening I will set revision 865 as tested if there no objections before. And then start to integrate Raphaels changes if I find no big problems with these :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Selecting objects in JOSM
On Sun, 24 Aug 2008, Raphael Mack wrote:
Am Sonntag, 24. August 2008 schrieb Dirk Stöcker:
On Sun, 24 Aug 2008, Raphael Mack wrote:
There is still some work left to get the latest features like virtual
nodes in, but I'd be glad to hear, that you are interested in my
changes, else I just stop working on it.
I would like to have the ability to clean out GPX files without the
current workaround to convert them into osm and back.
ok, so I went on merging changes and got a version, which seems to work
somehow.
Find a diff and a josm-custom.jar at
http://files.raphael-mack.de/josm/josm-selection/
It would be nice, if you could try the recently introduced features and
take a look at the code.
Beside the deprecation warnings, I get following errors:
[javac] src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java:647: cannot
find symbol
[javac] symbol : method
selectPrims(java.util.Setorg.openstreetmap.josm.data.osm.OsmPrimitive,boolean,boolean)
[javac] location: class org.openstreetmap.josm.gui.layer.OsmDataLayer
[javac]
selectPrims(Collections.singleton((OsmPrimitive)virtualNode), false, false);
[javac] ^
[javac] src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java:656: cannot
find symbol
[javac] symbol : variable Mode
[javac] location: class org.openstreetmap.josm.gui.layer.OsmDataLayer
[javac] if (mode == Mode.rotate affectedNodes.size() 2)
[javac] ^
[javac] src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java:664: cannot
find symbol
[javac] symbol : variable Mode
[javac] location: class org.openstreetmap.josm.gui.layer.OsmDataLayer
[javac] if (mode == Mode.move) {
[javac] ^
[javac] src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java:681: cannot
find symbol
[javac] symbol : variable Mode
[javac] location: class org.openstreetmap.josm.gui.layer.OsmDataLayer
[javac] } else if (mode == Mode.rotate) {
[javac]^
[javac] src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java:685: cannot
find symbol
[javac] symbol : constructor
RotateCommand(java.util.Collectionorg.openstreetmap.josm.data.osm.OsmPrimitive,org.openstreetmap.josm.data.coor.EastNorth,org.openstreetmap.josm.data.coor.EastNorth)
[javac] location: class org.openstreetmap.josm.command.RotateCommand
[javac] Main.main.undoRedo.add(new RotateCommand(selection,
mouseStartEN, mouseEN));
[javac]^
Ciao
--
http://www.dstoecker.eu/ (PGP key available)___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Reworked virtual nodes
On Sun, 24 Aug 2008, Robin Rattay wrote: - When quickly clicking and dragging a virtual node, then the mouse cursor is not directly on the new node, but slightly offset - the less time the is between pushing mouse button down and starting the dragging, the bigger the offset. Yes. This is the same as for normal node moving. Oh. Ok. Was wrong. I did the initial move twice. Fixed now. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Selecting objects in JOSM
On Mon, 25 Aug 2008, Raphael Mack wrote: Ooops, I wanted to make a patch against the latest revision in svn and did a svn up before making the patch. And I forgot to recompile... should be better now. (its a patch against r868 now) The deprecation messages are trivial to resolve and I'll do it before commiting of course. One of the problems are the conflicts with Jörg's patches. How complicated are they to resolve, when I checkin his patch before the stuff of yours? Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] slippymap plugin not wanting to make render requests
On Mon, 25 Aug 2008, Maarten Deen wrote: The automatic update from within JOSM doesn't work. It keeps saying there is a new version of the slippymap plugin and appears to download it, but it isn't updated. I've downloaded it manually and JOSM still says there is a new version of the slippymap plugin. In JOSM it says it's version 7821. After I downloaded it manually, the render request works. Thanks. You first need to update the list. Recent plugins hace something above 1 as revision. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] slippymap plugin not wanting to make render requests
On Mon, 25 Aug 2008, Robin Rattay wrote: Dirk Stöcker schrieb: On Mon, 25 Aug 2008, Robin Rattay wrote: Has this actually worked at all or only on specific environments? It seems that the update mechanism needs to be changed. Works on Linux, but probably you're right and it wont work on Windows due to the strange Windows file locking. Anyway I seldom use Windows, so that's not my problem :-) Maybe a solution would be to store files with an intermediate name in case of copy failure and copy these on restart before plugins get loaded. Here you go... Nah, that always creates a usually useless directory and also always creates the temporaryfile-on-start-copy. Both is not useful on non-Windows systems. Better: a) Temporary filename is final name+.tmp. b) Do the move as is done now. When move fails, leave the tmp file. c) On start check if there is a temp file and move it when possible. If not, inform the user. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Reworked virtual nodes
On Sun, 24 Aug 2008, Robin Rattay wrote: - The virtual nodes cover the segment numbers, which are IMHO quite important. Yes. Need to shift the segment numbers a bit, when drawing the virtual nodes. I don't use that option, :-) What is it good for? - When there are two ways sharing the same segment there is no way to choose into which way the new node is inserted. Actually the node probably should be inserted in all ways. Handling here is same as for nodes, which means you always get the topmost way. I will not change anything here, as this would result in a lot of complexity without much positive results. If other behaviour is desidered, the old method using draw tool and J command must be used. - When quickly clicking and dragging a virtual node, then the mouse cursor is not directly on the new node, but slightly offset - the less time the is between pushing mouse button down and starting the dragging, the bigger the offset. Yes. This is the same as for normal node moving. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Reworked virtual nodes
On Sun, 24 Aug 2008, Robin Rattay wrote: - When there are two ways sharing the same segment there is no way to choose into which way the new node is inserted. Actually the node probably should be inserted in all ways. Handling here is same as for nodes, which means you always get the topmost way. I will not change anything here, as this would result in a lot of complexity without much positive results. If other behaviour is desidered, the old method using draw tool and J command must be used. Good point. I think we need to find a better way to handle overlapping elements. The middle-click/ctrl/left-click combination is a useablity nightmare and doesn't allow things like moving the selected element. I changed that lately. Now when you select elements first (e.g. drawing a frame and choosing the element in selection), then clicking in the map again selects that element and no longer the topmost. Thus moving now is possible. Still not the best solution, but better than before. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Reworked virtual nodes
On Sun, 24 Aug 2008, Robin Rattay wrote: Good point. I think we need to find a better way to handle overlapping elements. The middle-click/ctrl/left-click combination is a useablity nightmare and doesn't allow things like moving the selected element. I changed that lately. Now when you select elements first (e.g. drawing a frame and choosing the element in selection), then clicking in the map again selects that element and no longer the topmost. Thus moving now is possible. Hmm, either I didn't understand that explanation or it's not working... Worked only for nodes :-) Now also works for ways (Rev 860). Also segment numbers are fixed. And to make it nicer, they are drawn like virtual nodes only in a certain zoom level and on top of the way. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Selecting objects in JOSM
On Sun, 24 Aug 2008, Raphael Mack wrote: There is still some work left to get the latest features like virtual nodes in, but I'd be glad to hear, that you are interested in my changes, else I just stop working on it. I would like to have the ability to clean out GPX files without the current workaround to convert them into osm and back. Thought I would not like do the necessary changes myself :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Reworked virtual nodes
On Sun, 24 Aug 2008, Robin Rattay wrote: However there is one bug: the stroke thickness isn't drawn anymore. Fixed. BTW, you can get the real size of the string with g.getFontMetrics().stringWidth(...) and g.getFontMetrics().getHeight() (if performance allows it). IMHO that's better than guesstimating using segmentNumberSpace. That's not the string size. Only the minimum size of the way length. This is not equal to string size, but probably a size test can be included as well. And while your at it, there's another irritating feature: Selected areas are filled solid blue, thus overpainting anything inside. Could Red for me :-) I fixed that as well. Now areas are always drawn with Alpha channel. And also area borders are always drawn. Code is easier and it seems to be more logical. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Small patch for Lambert projection
On Sun, 24 Aug 2008, Pieren wrote:
I created a patch to fix this issue.
First, it will not raise an exception anymore if the nodes are outside
the Lambert zones.
Second, it will display once an error message if someone tries to use
this Lambert projection beyond the latitudes it was designed for.
Third, I renamed the projection as Lambert Zone (France) to show
that this projection has limited coverage and is not for the whole
planet (I hope the new name is more clear).
If would be nice if someone with a write access could apply the patch
to the source Lambert.java.
One note regarding translations (to you also Frederik! :-):
- Translations must be unmodifyable strings:
tr(Text + variable + text) does never work.
Use tr(Text{0}text, variable)
- EVERY user visible string should be translatable.
I'm going through JOSM code for some time now and fixed such stuff in so
many places, don't make my life harder by introducing new problems of that
style.
Ciao
--
http://www.dstoecker.eu/ (PGP key available)
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Selecting objects in JOSM
On Sun, 24 Aug 2008, Raphael Mack wrote: Am Sonntag, 24. August 2008 schrieb Dirk Stöcker: On Sun, 24 Aug 2008, Raphael Mack wrote: There is still some work left to get the latest features like virtual nodes in, but I'd be glad to hear, that you are interested in my changes, else I just stop working on it. I would like to have the ability to clean out GPX files without the current workaround to convert them into osm and back. ok, so I went on merging changes and got a version, which seems to work somehow. Find a diff and a josm-custom.jar at http://files.raphael-mack.de/josm/josm-selection/ It would be nice, if you could try the recently introduced features and take a look at the code. Wow. Major changes. Can we break these into smaller pieces? I had a look at the whole diff and all the modifications seem to go into the right direction, but I would not like to introduce them in such a large pack. A step-by-step integration would be much more the style I would favour. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Selecting objects in JOSM
On Sun, 24 Aug 2008, Frederik Ramm wrote: Wow. Major changes. Can we break these into smaller pieces? I had a look at the whole diff and all the modifications seem to go into the right direction, but I would not like to introduce them in such a large pack. A step-by-step integration would be much more the style I would favour. Well now that we're establishing josm-tested, we could also wait a day or two, then make the current version with the virtual nodes into -tested, and apply Raphael's patch to -latest and see what happens ;-) Ok. Let's try this. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Performance optimizations
On Sat, 23 Aug 2008, Tobias Wendorff wrote: Dirk Stöcker schrieb: I compiled it for you: http://www.dstoecker.eu/josm-custom.jar Thanks a lot! I would love to read a HowTo someday :-) www.google.com If you have specific problems, you need to ask these directly. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Performance optimizations
On Sat, 23 Aug 2008, Tobias Wendorff wrote: Dirk Stöcker schrieb: www.google.com If you have specific problems, you need to ask these directly. Ah ... that's why I love OpenSource: You need support? Sorry, no support ... Google for it! Yes. That's the way it goes. When I think of the fact how expensive I myself am when at work, then this is logical. Take the fact the as consultant I cost more than 100 Euro an hour and that answering a little more complex email takes 10-30 minutes. So the result is - Support costs money. Help is for free, but only given, when I see that the other side already tried to solve the problems by reading available source himself first and the question is specific. Like this most other open source programmer work. Usually this also means, that if you did the initial searches, you get high quality answer which in the commercial field aren't naturally. BTW: Regarding consultants - I can't by myself - Don't get enough money a month to rent me :-) Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] patch for JOSM runtime error on MacOS
On Sat, 23 Aug 2008, A Morris wrote: I am trying to run the latest SVN revision of JOSM in eclipse on a Mac. The code builds, but does not run; it hangs inside the native method Object.wait() in ElemStyleHandler. The offending line is: curIcon = new ImageIcon(Toolkit.getDefaultToolkit().createImage(path)); I note that the file 'misc/no_icon.png' (which it is trying to load) does not exist anywhere in my filesystem. (Actually neither does 'amenity.png'). I have applied the following patch which seems to have fixed the problem on my system (the hang, that is, not the fact that icons seem to be missing): You use an external styles file? It must have some errors. The problem is, that the internal style names aren't properly initialized in case an external file is loaded. I will fix that. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] patch for JOSM runtime error on MacOS
On Sat, 23 Aug 2008, A Morris wrote: I don't knowingly use an external styles file - I simply tried to build and run the latest JOSM revision. I fixed that access. Should work now for you too. a) Could you paste any lines with mappaint in your josm-preferences here. b) Please list the whole content of your josm dir. (~/.josm under Linux). Is it not a problem that icon files that are referenced in the source code do not exist in SVN? They are there: images/styles/standard/ Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Layer order and active layer
On Sat, 23 Aug 2008, Bodo Meissner wrote: | I closed bug 371. Now it is no longer possible to change an inactive | layer. I don't like this change. I often select a GPX layer when drawing new ways or moving existing ways to my tracks. When the OSM data layer is active it is often difficult to see the tracks even if I change the color. That's why I prefer to have the ways displayed in grey color when tracing GPS tracks. An acceptable workaround would be a switch to dim the active data layer. Why don't you use the wireframe mode for that? Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Reworked virtual nodes
Hello, I reworked the virtual nodes in revision 853. The virtual nodes are no longer created on clicking a node, but only when you click the virtual node and also drag it. This should reduce the existing problems a lot and make the feature as intended originally. This means a single click now again selects the way. Note also, that creating node and moving no longer are two undo steps, but only one. Please retest the feature and tell me your test results. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Layer order and active layer
Hello, I closed bug 371. Now it is no longer possible to change an inactive layer. As some mappers probably rely on this feature, I also did some other modifications: a) The layer list order is now really 100%. This means active layer is no longer drawn on top. b) The order in the layer list menu changed. The topmost layer now is also at the top (because the layer list and the layer list display used different directions and the difference was not handled correctly). If this is too confusing (I find it more logical), we can turn it around again, but this time with proper handling of reversed layer list. c) New layers no longer get automatically active. Only new OSM data layers are automatically activated. I hope that prevents 'I can't draw anything' bug reports. Please report problems with this new setup, so these can be fixed. One noteable result for the most often used workflow: If you load GPX first and OSM later, the GPX data will be on top now (useful I think). Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] JOSM Bug Tracker
Hello, well, the josm bugtracker spam protection seems to work: --- Internal Server Error 500 Internal Server Error (Submission rejected as potential spam (Maximum number of posts per hour for this IP exceeded)) --- That's the result if you change too many bugs at once :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Small patch for Lambert projection
On Wed, 20 Aug 2008, Pieren wrote: Dear Josm-dev, Could one of the Josm developers having write access to the repository submit the following small patch for the Lambert projection class ? It's to avoid an unnecessery warning message when MAX_LAT / MAX_LON are used. Note that this time, I renamed the patch with the extension .TXT hoping that it will not be filterer by the ML. Maybe you will be able to see it. In the case not, I also copy it below. Probably you introduced a new bug with this: http://josm.openstreetmap.de/ticket/1441 Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] add-node idioticy
On Wed, 20 Aug 2008, Bodo Meissner wrote: | I would suggest to restrict adding nodes to click | and drag and not to a simple click. The click without dragging the | plus should remain select way as it was before. It will not be | necessary to add a node and leave it where it was, so click and drag | would be ideal for refining. I agree. This is a good idea IMHO. I will see, if I get this done. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Validator - layer for waterway
On Wed, 20 Aug 2008, Bodo Meissner wrote: I tried this once. After having added layer=-1 to the stream the it was partially no longer visible on the rendered map. Probably there were additional problems like the river not sharing the nodes of the forest or overlapping forest polygon and waterway but I did not want to fix/change the whole stream and/or forest because I simply added a street crossing the stream. I removed that check from the file. | As the first | produces many unwanted conflicts, when the bridges have been forgotten | (and usually many bridges are missing), this test is there. I think it would be better for the quality of the data if the validator encourages to add a bridge tag and think about the relative layers at this place than adding a general layer=-1 which may hide warnings about missing bridges. The validator has another warning about crossing ways. This already warns in case ways with same layer cross outside of nodes. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Small patch for Lambert projection
On Wed, 20 Aug 2008, Pieren wrote: Note that this time, I renamed the patch with the extension .TXT hoping that it will not be filterer by the ML. Maybe you will be able to see it. In the case not, I also copy it below. Seems .txt is a good idea. The attachement is encoded as TEXT/PLAIN and not stripped. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] HTML entities
Hello, I wanted to introduce a JOSM validator check, which checks for HTML entities in the tags and automatically fixes these. Now my question: Is there a Java function, which can can convert the HTML amp;, apos; and so on into UTF8? I did not find anything. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] HTML entities
On Wed, 20 Aug 2008, Bodo Meissner wrote: Is there a Java function, which can can convert the HTML amp;, apos; and so on into UTF8? I did not find anything. I found a reference to this but didn't try it myself. http://mindprod.com/products1.html#ENTITIES It is can be used for any non-military purpose. They use a table. This is something I wanted to avoid. When Java uses HTML, there must be entity support somewhere inside. But the question is, how to access it. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bug 595 - Virtual nodes - Comments requested
On Mon, 18 Aug 2008, David Earl wrote: That would have been high on my list to implement as well... Why would you want it, when SHIFT+CLICK does this? Or do you want it *exactly* half way? If you add a new node, I guess there are two things you might want to do next - extend a way from the new node, in which case you'd have to change mode, so the cross is less useful, or drag the new node to, say, improve a curve, which might be marginally easier if you are already in select mode (avoiding one 'S' keypress). If you have an old very inaccurate way (let's say the first entered primary streets here in Germany) and you want to change that to the GPS track you have. You have to switch dozens of times between S and A to create nodes, drag them, create more, check them, ... Personally I would prefer to work towards more modeless operation than introducing another way of doing the same thing to work around switching modes. Actually this is the same. Or where do you see the difference between modeless and everything can be done in one mode. Only 1 more step: - Implement drawing ways in select mode and Add is no longer required and you have modeless editing. Start drawing mode using a key and ESC to stop is probably the best way to do this. Is C like Create already used? Should be relatively easy. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bug 595 - Virtual nodes - Comments requested
Nice, quoting myself :-) On Mon, 18 Aug 2008, David Earl wrote: That would have been high on my list to implement as well... Why would you want it, when SHIFT+CLICK does this? Or do you want it *exactly* half way? If you add a new node, I guess there are two things you might want to do next - extend a way from the new node, in which case you'd have to change mode, so the cross is less useful, or drag the new node to, say, improve a curve, which might be marginally easier if you are already in select mode (avoiding one 'S' keypress). If you have an old very inaccurate way (let's say the first entered primary streets here in Germany) and you want to change that to the GPS track you have. You have to switch dozens of times between S and A to create nodes, drag them, create more, check them, ... Personally I would prefer to work towards more modeless operation than introducing another way of doing the same thing to work around switching modes. Actually this is the same. Or where do you see the difference between modeless and everything can be done in one mode. Only 1 more step: - Implement drawing ways in select mode and Add is no longer required and you have modeless editing. Start drawing mode using a key and ESC to stop is probably the best way to do this. Is C like Create already used? Should be relatively easy. After a bit of thinking it is much easier: Adding a listener, which checks ESC presses in Add-Modus and switches back to Select-Mode in case ESC was pressed. You still have the modes, but that would not affect workflow at all. Who implements it? Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bug 595 - Virtual nodes - Comments requested
On Mon, 18 Aug 2008, Matthias Julius wrote: Dirk Stöcker [EMAIL PROTECTED] writes: After a bit of thinking it is much easier: Adding a listener, which checks ESC presses in Add-Modus and switches back to Select-Mode in case ESC was pressed. You still have the modes, but that would not affect workflow at all. It doesn't make much difference to me whether I press ESC or S to get back to Select mode. You could adopt the Potlatch behavior and cancel Add mode when user clicks on the active node (the node a segment would be drawn from when a new node is inserted/selected, this is usually the last inserted node). Hmm, nice idea. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Update Plugins fails
On Mon, 18 Aug 2008, Frederik Ramm wrote: Other plugins are again one step more complex. They use the SVN revision number as their version and thus make manual intervention unnecessary. There is a catch, however, at least with subversion under Linux. If you make a change to the plugin, then commit (commited revision #1234), then build - your plugin will still be built with the OLD revision number! You change the wiki table to mention version #1234, and wo-hoo, round the user goes in download circles because your plugin still says it is # (or whatever) although having been built from revision 1234 sources! Why is that? It seems that the revision indicator used by the build process is not updated when checking in, only when checking out. So after changing your plugin, do svn commit (note down version number reported!), followed by svn update, and only THEN do ant do build the .jar; then do cd ../../dist and svn commit myplugin.jar, and then change the wiki page to the version number reported when you commited your source changes. I added a getversions script in dist directory for that purpose. So when checking in a new plugin, call this, check if all the SVN and time is correct, then commit the jar and then update wiki page according to what the getversions script call said :-). Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] add-node idioticy
On Mon, 18 Aug 2008, Henry Loenwind wrote: who had the brain-dead idea to put add-node hotspots into SELECT mode, exactly where we used to click to SELECT ways before---and to leave out a configuration setting to turn it off? First: You should learn to behave. Second: It can be turned off, even on the first settings page. Third: These crosses are very obvious. If you did not see them, I can't help you. *plonk* Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] add-node idioticy
On Mon, 18 Aug 2008, Dermot McNally wrote: PS: pissed, because I just found a couple of added nodes in my command stack and have to redo my last 20 minutes of work because I don't know where they are and don't want to upload bogus nodes... And that excuses rudeness on this scale directed against somebody else giving up his personal time for the project? I think you need to watch your temper. I also just noticed the selecting difficulties caused by the placement of the otherwise very useful node-adding handles. But they've been in there for less than 24 hours. If you can't take a bit of bleeding-edge, don't use -latest. There is a hidden setting mappaint.node.virtual-space with default 50, which defines the minimum length (unit: pixels (x+y)) of a way containing the virtual node. Probably increasing this value is required. Please try some higher values and tell me results. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] add-node idioticy
On Mon, 18 Aug 2008, Bodo Meissner wrote: I cannot see any crosses when I select a GPX layer in the layers list. I often use this because all ways will be displayed in dark gray colour which makes it easier to see the GPX tracks. Need to test if the element is in active layer. Display is correct, selection not. Noted. Maybe tomorrow. I think you should make sure the crosses (or whatever) can be seen even when the ways are displayed as gray lines. Hmm. Good question. I thought that mode should only be usable in active layer. Enabling the display is probably easier than fixing the selection :-) When adding a new feature, could you add a note to the page that is displayed when no data file is loaded? You also could do that :-) It's in the wiki. I will do tomorrow. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Color preferences for mappaint
On Sun, 17 Aug 2008, Martin Koppenhoefer wrote: would it also be possible to have /one/ setting for /all/ POI-layers (marker-layers)? At the moment it is possible to set a colour for each marker-layer in the layer-menu, but everytime the name of the layer changes (what means for me every time a load a marker-layer, as I name them by date) it has to be set again. This leads, beside of being annoying, to cluttering of the colour-table (they all remain in the table). The patch does not affect this. Also it is possible to have what you request. Set color.gps marker. Nevertheless I changed the color handling code a lot, so it now uses a central function and also the preferences are updated as they should be. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Validator
On Sun, 17 Aug 2008, Pierre-André Jacquod wrote: have selected. In any case, some violations are things that you care about (like missing refs) but can't always do anything about. (like tertiaries, where it can be difficult to determine the correct ref). Not in Germany. Here it is easy :-) But by me (Switzerland) none of tertiary road has a ref, at least absolutely no reference the public is aware of / is able to see. :-( So for me the validator fill up all tertiary with the no-ref, but even if I want, I am unable to avoid this error... I haven't yet worked out the full scope of the ignore option - but it doesn't seem to ignore all similar cases, only the specific object I Correct. which is not so a good solution in my opinion? Thanks for JOSM, great stuff. What you can do in any case: Instead of using the default file, copy it to your local harddisk and modify it. Then enter that file into the config and disable the default file (update validator to do so, there was an error in last version, which prevented using additional files). Probably I could add a dialog in configuration, where individual rules can be disabled. I think about it. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Patch for remembering last download area
On Sun, 17 Aug 2008, Rainer Rothkegel wrote: Please find attached a patch that makes josm remember the bounding box of the download area across sessions. Upon a download, the bounding box is stored in the preferences file. This information is used to pre-populate the download dialog when the map view area is not yet defined. Hmm, at least I see no attachement. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Bug 595 - Virtual nodes - Comments requested
Hello, in revision 805 I implemented a new feature I want to know your opinions about: Virtual nodes. When in select mode and the displayed way is long enough, in the middle of the way a little + is added. When clicking this, a new node is created, which can be used immediately. This makes adapting existing ways a lot easier I think. If unwanted, turn off in settings, but tell me why :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Patch for sorting members in the relation editor
On Sat, 16 Aug 2008, Juergen Buchner wrote: I changed the file layout in jar file a bit. Does ant clean (or whatever you use) help? I start it from within Eclipse. And a build clean doesn't help .. Even checking out in a new workspace didn't change the error message. Please send you preferences file (strip username/pwd). Maybe I overlooked something in my last changes. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Validator
On Sat, 16 Aug 2008, Dermot McNally wrote: Basically, the config file as it currently stands knows that nodes tagged with highway types are bad and it knows that certain classes of highway way that lack a ref attribute _may_ be bad. The drawback of the current validator as implemented is that only the message Illegal tag/value combinations is given. So in my case, before I read the config file, I looked at a highway tagged only highway=tertiary and had no way of knowing that the actual message is that a ref was missing. This information is shown in the ToolTip. You get this when waiting a short time over the error message. The validator would in the event of catching such a case, add a validation violation of severity info with the text Highway without a reference instead of Illegal tag/value combinations What do you think? My fear is that if a change of this sort isn't made, once this currently small ruleset grows to 20 times its current size, we'll all have lots of validator violations but not know what we're doing wrong. Actually this is already implemented. It's only moved to the ToolTip for two reasons: a) There is so little space there in the Validator window b) When I change the generic error message, the valdition dialog will be filled with lots of different message types. This makes finding certain types more difficult. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Validator
On Sat, 16 Aug 2008, Dermot McNally wrote: This information is shown in the ToolTip. You get this when waiting a short time over the error message. Ah yes, so it is... It does force me to mouseover each violation, though. For a large or detailed area, this is going to be very impractical. Suggestions welcome. Actually this is already implemented. It's only moved to the ToolTip for two reasons: a) There is so little space there in the Validator window True - but to me, the existing top-level message isn't actually useful, and could easily be replaced with the more specific message. Furthermore, if I decide (as I am likely to) that it will be generally acceptable for tertiary roads in my area not to have ref attributes, I would value the ability to collapse and ignore a whole set of violations. As it is, I'm going to have to search through a list of acceptable violations to find the ones I really care about. You can ignore them once and for all the time :-) Don't know how make an ignore for specific tests in the test-set. But it's a new feature. Give it some time to mature. b) When I change the generic error message, the valdition dialog will be filled with lots of different message types. This makes finding certain types more difficult. Which types? As far as I can see, the only violations that will be separated based on my suggestions are the ones that are already unlike each other. Yes. The other validation types. Think of e.g. 30 different TagChecker types and one unclosed way. You wont find it in this batch of TagChecker stuff. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Small patch for Zoom to selection combined with projection Lambert
On Sat, 16 Aug 2008, Pieren wrote: could someone with a write access to the Josm core repository commit the following (small) patch fixing an issue when Lambert projection is enabled. Again, the problem is that the code uses an initial value with LatLon(0,0) when we execute the zoom to selection menu action. I've attached the diff file as recommended but here is also the quick view of the change (in file org.openstreetmap.josm.actions.AutoScaleAction.java) Nothing attached. replace this line: EastNorth en = Main.proj.latlon2eastNorth(new LatLon(0.001, 0.001)); by this one: EastNorth en = new EastNorth(0,0); Nevertheless applied. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Patch for sorting members in the relation editor
On Sat, 16 Aug 2008, Robin Rattay wrote: The image loader used to look for the icons in /styles/standard/icons. You changed it to /images/styles/styleName (with stylename == standard), which however doesn't exist (as far as I can say - the josm's image directories are a bit confusing :-) Well. The build.xml of ant does correctly create that here. I not only changed the loader, but also the scripts to build the distribution. Ah. However the problem is that while that allows you to build JOSM, you can't run it from inside Eclipse - and that makes debugging a little bit difficult :-) Ah. Ok. Now I'm sure the settings of eclipse can be changed accordingly. Mainly the change is to have the internal directory /styles/standard/icons in /images now as /images/styles/standard (mainly to allow accessing it from other places as well). Anyone using eclipse, who can make that change. I don't use eclipse. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Validator
On Sat, 16 Aug 2008, Dermot McNally wrote: I'd still favour my original suggestion - rather than group all of these new errors under the single label they now occupy, group them instead under their respective, detailed, labels. That keeps un-reffed road errors away from, say, typoed landuse errors. But ultimately, what I'm saying is lose the tool tip, at least for information like this. A good rule of thumb here, would be that tool tips are good for followup information that might not be necessary in all cases, or for inexperienced users. But you shouldn't put data behind a tool-tip that is necessary in order to make use of the error message. Hmm, maybe I add a third level. I think about it. You can ignore them once and for all the time :-) I haven't yet worked out the full scope of the ignore option - but it doesn't seem to ignore all similar cases, only the specific object I Correct. have selected. In any case, some violations are things that you care about (like missing refs) but can't always do anything about. (like tertiaries, where it can be difficult to determine the correct ref). Not in Germany. Here it is easy :-) Don't know how make an ignore for specific tests in the test-set. But it's a new feature. Give it some time to mature. For sure. Lest there should be any doubt, I really like what you've done here. I'm just struggling with aspects of how the results are output. This was expectable. One of the problems is, that enabling individual tests is not possible. I'm not sure I see what you mean here. It doesn't matter to the user if a crossing way or unclosed area message isn't generated by the tag checker, even if another 30 messages are. Each violation message represents something that the mapper needs to review and either repair or accept in its current state. Do we really need to contain the tagchecker messages behind an overall label? Maybe there's a technical reason, but it feels unnecessary from a UI perspective. On my screen I usually have 2-5 lines for the TagChecker. Yes - it is important to have not too many toplevel entries. Ok, I will buy a new laptop soon, but that's no argument. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Patch for sorting members in the relation editor
On Sat, 16 Aug 2008, Robin Rattay wrote: Ah. Ok. Now I'm sure the settings of eclipse can be changed accordingly. Mainly the change is to have the internal directory /styles/standard/icons in /images now as /images/styles/standard (mainly to allow accessing it from other places as well). Anyone using eclipse, who can make that change. I don't use eclipse. I don't think that is possible. AFAIK Eclipse doesn't support symbolic links. How can eclipse assume the the local directory structure is equal to the final directory structure in the jar file. I can't believe that. However then I do get an exception while the validator plugin loads: Update the plugin. Already fixed. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Patch for sorting members in the relation editor
On Sat, 16 Aug 2008, Robin Rattay wrote: Dirk Stöcker schrieb: How can eclipse assume the the local directory structure is equal to the final directory structure in the jar file. I can't believe that. Unfortunatly one of the biggest weaknesses of Eclipse is the poor ant building and jar file integration. It can't use inforation from a build file to set things like class path and source directtories. And there is no other way to tell exclipse, what it needs to do? Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Color preferences for mappaint
Hello, to fix ticket 1177 http://josm.openstreetmap.de/ticket/1177 and because I also want to have the ability to change colors, I introduced a new feature into the mappaint file. Colors now can get names, which can be changed in the preferences of JOSM. Where it is now colour=#ff it can be colour=water:#ff in future. I described the way to use it in the styles file. The named colors will available as color.mappaint.name in the Einstein preferences. Ulf: You know the styles file better than I do. Could you add useful names to the colors? Only requirement is that one name does not get multiple values (it is no hard requirement, but a useful one). Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Patch for sorting members in the relation editor
Hello, since I was working with large relations I had the problem finding the right members in the relations editor. With the attached patch the member list gets sortable. Even relations with roles like stop_xx are sorted right. It would be great if someone would apply this patch. Nothing attached. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Ticket #351: Edit Relation dialog is always on top
On Tue, 12 Aug 2008, Florian Heer wrote:
attached patch solves #351, but I am not absolutely sure if that is a good
idea. The line
try { setAlwaysOnTop(true); } catch (SecurityException sx) {}
which had to be commented out for this, had been put there for a reason. I
don't see a reason, but maybe there is one.
Copied your patch into the bug-report. Don't know how to decide, so I move
it into the future :-)
Ciao
--
http://www.dstoecker.eu/ (PGP key available)
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Difference between JOSM and JOSM-NG
On Tue, 12 Aug 2008, Frederik Ramm wrote: Gervase Markham wrote: standard Java-isms industry best practice Structural design patterns I, for one, would like to also attract developers for whom maybe Java and OO are not the environment in which they spend all of their programming lifes and for whom a comment like using decorator pattern here is not very helpful. OSM is a project with an enormous breadth of programming languages and concepts, and I think we profit a lot from people being able to work across the board. This doesn't mean we should write Java as if it were Perl, but it also means that it is a good idea to keep things simple. Actually this reply goes more to Gerv than Frederik :-) I do software development in dozens of languages for about 20 years now (which is nearly 2/3 of my life. More than 10 years of these are commercial software development in different forms (BTW: I studied Geodesy, not informatics). While these theoretical design patterns and industry pratices are fine forms to press new programmers into a working sheme, they don't lead to the best results. Especially not in the field of open source. I myself am not interested to learn Java at all. 10 years ago I had last contact to Java and now with JOSM again. I know all the concepts so I write code and need to have a reference to find the function and variable names and types. But in no way I will follow a special language driven programming paradigm :-) A good book I really suggest to read: The Pragmatic Programmer - From Journeyman to Master. This leaves away all theoretical stuff and shows the pratice side. 99% of the texts inside I can agree with, as they show how it is and not how it should be. And yes, I also have books showing different software apporaches. Some of these don't work at all in free world, but only in laboratory. BTW: I will not continue this thread except for real useful code improvements. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Ticket #488: Unnecessarily prompted to select way to split even though only one way extends through node
On Tue, 12 Aug 2008, Florian Heer wrote: I think I have a solution for this nuisance, but first of all a question, as I don't know the data structure by heart yet: is the list of nodes of a way guaranteed to be sorted by their occurence in the way? Meaning: is the first node in the list always the first of the way and likewise with the last? Yes. If so, the attached patch solves Ticket #488. One comment for future stuff - check diff files before sending - You had some changes in .classpath, which shouldn't be there. Also I changed the warning message a bit to reflect new situation and did some optimizations :-). More fixes to follow? I hope so ... We are down to 90 defects. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Difference between JOSM and JOSM-NG
On Mon, 11 Aug 2008, [EMAIL PROTECTED] wrote: the main benefit of encapsulation is to make code more flexible for refactoring, internal changes, performance optimization through implementation hiding That is true for new developments. For existing code other rules apply. The main rule here is: Changes should improve the software. Changes for the main benefit of cleaner style will be rejected. This is based on the fact that every change has side effects and very likely introduces new bugs. And please do not assume that encapsulation is always good. It also has negative effects and the right balance is important. in case of modular software like josm with plugins is encapsulation a must for development and has not only something to do with clean style of code Nothing is a must. As you see it works fine also without. refactoring and cleanups in an early phase of project are not so expensive and time-consuming like in a big grown old project. sometime it is to late to make big changes... It is never to late. This is always possible. BTW: Your shift and return keys are defective. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] JOSM Ubunbtu debugger searched
Hello, ATM there are 7 reports related to an excpetion when calling preferences dialog on Ubuntu http://josm.openstreetmap.de/search?q=ToolbarPreferenceswiki=onchangeset=onticket=on None of the systems I have show that error, so I can't debug it. It seems GTK+ style usage is required for that. Anyone using Ubuntu, who can debug that? Minimum would be to find out, which value is causing that error (i.e. what is zero). Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] JOSM Ticket #263, cancelling an upload
On Sun, 10 Aug 2008, Florian Heer wrote: I hope ticket #263 can be closed with that (would have inserted in the svn, but apparently i have no access :-) ). Please supply a patch file. Sure, which format? And can svn create that directly? Sorry, all I have done with svn is to use it as a central storage... Standard unified diff is preferred in al projects I know (diff -u). svn exports this directly with svn diff. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] JOSM Ticket #263, cancelling an upload
On Sun, 10 Aug 2008, Florian Heer wrote:
Index: org/openstreetmap/josm/io/OsmConnection.java
===
--- org/openstreetmap/josm/io/OsmConnection.java(revision 761)
+++ org/openstreetmap/josm/io/OsmConnection.java(working copy)
@@ -127,8 +127,11 @@
Main.pleaseWaitDlg.currentAction.setText(tr(Aborting...));
cancel = true;
if (activeConnection != null) {
- activeConnection.setConnectTimeout(1);
- activeConnection.setReadTimeout(1);
+ activeConnection.setConnectTimeout(100);
+ activeConnection.setReadTimeout(100);
1 and a half minute is much to much for an cancel. Acceptable is anything
in a range 1 to 5 seconds I think. If you add such a long delay, then a
notification is necessary telling the user what is done - like Server
response is missing. Waiting not more than 60 seconds before finally
cancelling.
Ciao
--
http://www.dstoecker.eu/ (PGP key available)
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] JOSM Ticket #263, cancelling an upload
On Mon, 11 Aug 2008, Florian Heer wrote: Dirk Stöcker schrieb: 1 and a half minute is much to much for an cancel. Acceptable is anything That is not 100 seconds, it's 100 milliseconds. I added the higher timeout only to allow a _little_ more time to read a response instead of disconnecting at once. The main problem was that the cancel-boolean was not inherited. Ah. Ok then. Applied. P.S. Do not insert patches in text. Attach them. Mail-programs tend to modify white-space and that's not so good for patches. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Bug-fixing
On Thu, 7 Aug 2008, Pieren wrote: I can verify some of them. But you should explain how to proceed. Shall we add a comment in the tracker entry saying e.g. Yes, I checked this and it is still an issue ? Still exists in Rev xxx Could not verify in Rev xxx Requires following to be reproduced ... ... Everything, which seems helpful to get me or others faster to the piece of code, which actually produces the problem. E.g. Instead of download this or that usually a small example osm file is better (as this also works, when OSM data changes), ... One example is the lakewalker and WMS. I don't use it, but there are some reports related to these, which are somewhat older and WMS has been reworked lately, so probably the bugs are already fixed. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] i18n -- why not Locales Bundles?
On Tue, 5 Aug 2008, Jonathan Bennett wrote: Can anyone tell me why JOSM uses the xnap tools for i18n rather than the standard Java approach of Locales and StringBundles? My primary reason for asking is that I can't get JOSM to build under NetBeans -- the latest version of the xnap-commons library lacks the translation functions used. I'm willing to start hacking at the code to eliminate this dependency, but I want to check it won't be wasted effort first... When I remember correctly, Java has no original string based translation method like gettext. Also the GNU gettext toolchain cannot applied. I did research in this area half a year ago for another project and although powerfull, the Java internal methods disqualified for a number of important reasons. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Request to apply a small patch about the alignment in circle and rotate objects functions
On Tue, 5 Aug 2008, Pieren wrote: Could someone commit the following two changes regarding the features align nodes in circle and rotate objects ? Applied. Please do never attach plain text in normal mail body. The patch will not succeed due to changes the mail program does to the text. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
[josm-dev] Bug-fixing
Hello, probably some of you have seen, that in the last month I tried to reduce the entries in the bug-tracker. ATM there are 109 defect's left: http://josm.openstreetmap.de/query?status=newstatus=assignedstatus=reopenedtype=defectorder=iddesc=1 It would be nice, if others could check for some of these if they could be verified in newer versions, check for duplicates, ask for additional information on non-reproducable bugs, ... It's a lot of work to check all the reports and verify if they still apply. Sometimes also the descriptions aren't very helpful. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] JOSM interface for Tagwatch, OSBugs etc.
On Tue, 5 Aug 2008, Frederik Ramm wrote: The tagwacht links contains only key/values. If this is just a typo, this is no problem. Otherwise I just download the surounding area with josm after opening the osm file downloaded from tagwatch via xapi. So ideally, the remote control plugin would have to support a command that goes download the following from OsmXAPI, determine its coordinates, drop it, and then download a 'buffer area' around whatever you got from there from the normal API. Which could also be more than one download since the original XAPI query might return 10 results in different countries, right? Actually for fixing typos you don't need to load the surrounding area. So mainly the requirement would be that the JOSM download interface also supports OSMXAPI-style calls. Switching tagwatch.stoecker.eu to redirect to a local URL instead of the OSMXAPI URL shouldn't be the main problem. Don't know if the browsers will make problems here. We will see. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] Automatic tag correction
On Sun, 3 Aug 2008, Robin Rattay wrote:
here is a small update of the TagCorrector. Some code cleanup and
addition of the key prefixes/suffixes forward and backward.
This does not work:
+ return applyCorrections(
+ tagCorrections,
+ way,
+ tr(When reverting this way + nameVisitor.name
+ + , following changes to the properties are
suggested
+ + in order to maintain data consistency.));
You cannot join translatable strings.
Use {0} for arguments. tr( {0} yyy {1}..., arg1, arg2);
Ciao
--
http://www.dstoecker.eu/ (PGP key available)
___
josm-dev mailing list
josm-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/josm-dev
Re: [josm-dev] JOSM rendering improvements the last days - I'm guilty!
On Wed, 23 Jul 2008, Ulf Lamping wrote: a) Would it be useful to add a new key to condition? You now do 3 times (yes, true, 1) condition k=oneway v=yes/ I would suggest a condition k=oneway b=yes/ where b (boolean) catches all boolean values. Helpful? If yes, I would implement it. Sounds reasonable. Ok. Now two new options exist: a) replace k= by b= to make a boolean test (like also done e.g. in preset tester and other places). b) remove k= and b= totally to test against existence of the key. I changed the first part of the styles/standard/elemstyles.xml to introduce this new features, but left the remaining parts unmodified (I don't want to break anything :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list [EMAIL PROTECTED] http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] Unclosed ways
On Sat, 12 Jul 2008, Mark Williams wrote: Quite a few roundabouts aren't closed. Reason being, if it goes over one road then under another, you need different way sections to get layering bridge correct. An example: http://www.openstreetmap.org/?lat=51.49664lon=0.27121zoom=16layers=0B0FFF I don't think they need checking, I just don't like that assumption! Well, for sure the checks will produce false positives. That is always a balance between false positives and false negatives (i.e. not reported problems). The check already helped me to find a non-closed roundabout and lots of natural/build/landuse problems, so I consider it useful. Also different types are reported with different texts, so ignoring certain types is easy. Test it and report problems, when they are really disturbing. But keep in mind, that avoiding false positives always means an increase of false negatives. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] Presets in toolbar broken
On Sat, 12 Jul 2008, Christoph Eckert wrote: http://josm.openstreetmap.de/ticket/1088 Checked in a fix for this. Not closing yet, as some stuff to do (mainly adding icons :-). When you add an item like this now item name=Streets de:name=Straßen icon=presets/motorway.png/item then it will be displayed accordingly (current SVN) The de:name is only required as long as translation is not updated. I didn't understand it yet. I have: item name=Streets/Motorway icon=presets/motorway.png label text=Edit a Motorway / ... How can I now group them together with an icon for the group? Nah, no grouping. I didn't change the data structure that much. Only add item name=Streets icon=presets/motorway.png/item above the first Streets/... item as normal item. When the item has no sub-tags (nothing meaningful between item and /item) and also no / in the name, then it will be taken as icon-supplier (actually as main preset menu initiation, which is otherwise done automatically). Add de:name=Straßen to have the german translation working (or else you get an icon Streets menu without submenus and Straßen group without icon). Or you can update translation, has same effect :-) ATM it is: item name=Streets/item item name=Streets/Motorway/item Better would be group name=Straßen item name=Motorway/item /group but that's a major change I did not want to do right now. Ciao -- http://www.dstoecker.eu/ (PGP key available)___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] Unclosed ways
On Thu, 10 Jul 2008, Frederik Ramm wrote: I try to build my unclosed ways tester. Now it seems to run fairly good, but I'm not sure I catched all area types. Currently I have: If I were you I'd write a simple script to parse a planet file and dump the tags of every way where the last node equals the first. Straighforward to write, doesn't even require memory (node id equality is sufficient, node position not required), just a few hours of cpu time. That will give you a very good idea of how people tag areas; of yourse you'll have some circular roads, roundabouts etc. as well but it should be obvious to the human being which are meant so be areas. Well. Actually roundabouts are correct. I made an unclosed way checker and no area checker. And an roundabout should be closed too :-) I will see if I find time for that at weekend. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list [EMAIL PROTECTED] http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] true/false against yes/no
On Thu, 10 Jul 2008, Roland Ramthun wrote: I would like to fix the code accordingly and switch to using yes/no. Objections against this? If you use true/false, everyone who didn't sleep at school knows that it is a boolean value with only two possible values. Well, but that's not true :-) E.g. oneway can also be -1. And I do not argue what is more logical, because that would be 0,1, which takes less space in the database (and is used very very seldom). I want to make josm follow the majority and that's yes/no. yes/no is not that clear. True/false and boolean logic is mainly known by programmers. Normal humans find yes/no more intuitive as tagwatch shows. I personally wouldn't change it, as it adds no value. It helps unify the database a little bit. Also josm does not handle that unified ATM. Combo boxes use yes/no also (e.g. access key). Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] Save file dialog
On Mon, 7 Jul 2008, Frederik Ramm wrote: I need to add osm/gpx file extension seperation (first three files). Why? Currently, you *can* save any OSM layer as a GPX file. It seems to me that your code would disable this feature, woudln't it? No. It wouldn't. Currently when you save a GPX layer and enter test, then josm makes test.osm from this and later complains about invalid extension. The patch now adds osm for OSM and gpx for GPX files. As this is only the default extension, adding gpx for saving an OSM file is still possible. The result will be a GPX file? What's the purpose of this? This is actually what the bug report really is about - saving GPX, not OSM. Additionally I introduced a title line, so the dialog now tells you, whether you save GPX or OSM (Because until I researched for this bug I did not know, that selecting a different layer affects saving). And the bug clearly tells me I'm not the only one. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
[josm-dev] Save file dialog
Hello,
to fix bug http://josm.openstreetmap.de/ticket/836
I need to add osm/gpx file extension seperation (first three files). To
make more understandable, that a GPX is written instead of the normal data
I introduced a dialog title (other files).
Objections to this? If not I will check it in next days.
Index: src/org/openstreetmap/josm/actions/SaveActionBase.java
===
--- src/org/openstreetmap/josm/actions/SaveActionBase.java (Revision 681)
+++ src/org/openstreetmap/josm/actions/SaveActionBase.java (Arbeitskopie)
@@ -86,8 +86,8 @@
return true;
}
- public static File openFileDialog() {
- JFileChooser fc = createAndOpenFileChooser(false, false);
+ public static File openFileDialog(Layer layer) {
+ JFileChooser fc = createAndOpenFileChooser(false, false, layer
instanceof GpxLayer ? tr(Save GPX file) : tr(Save OSM file));
if (fc == null)
return null;
@@ -98,6 +98,8 @@
FileFilter ff = fc.getFileFilter();
if (ff instanceof ExtensionFileFilter)
fn += . +
((ExtensionFileFilter)ff).defaultExtension;
+ else if (layer instanceof GpxLayer)
+ fn += .gpx;
else
fn += .osm;
file = new File(fn);
Index: src/org/openstreetmap/josm/actions/SaveAction.java
===
--- src/org/openstreetmap/josm/actions/SaveAction.java (Revision 681)
+++ src/org/openstreetmap/josm/actions/SaveAction.java (Arbeitskopie)
@@ -39,6 +39,6 @@
return f;
}
}
- return openFileDialog();
+ return openFileDialog(layer);
}
}
Index: src/org/openstreetmap/josm/actions/SaveAsAction.java
===
--- src/org/openstreetmap/josm/actions/SaveAsAction.java(Revision 681)
+++ src/org/openstreetmap/josm/actions/SaveAsAction.java(Arbeitskopie)
@@ -25,6 +25,6 @@
}
@Override protected File getFile(Layer layer) {
- return openFileDialog();
+ return openFileDialog(layer);
}
}
Index: src/org/openstreetmap/josm/actions/DiskAccessAction.java
===
--- src/org/openstreetmap/josm/actions/DiskAccessAction.java(Revision 681)
+++ src/org/openstreetmap/josm/actions/DiskAccessAction.java(Arbeitskopie)
@@ -19,11 +19,14 @@
super(name, iconName, tooltip, shortCut, modifiers, true);
}
- protected static JFileChooser createAndOpenFileChooser(boolean open,
boolean multiple) {
+ protected static JFileChooser createAndOpenFileChooser(boolean open,
boolean multiple, String title) {
String curDir = Main.pref.get(lastDirectory);
if (curDir.equals())
curDir = .;
JFileChooser fc = new JFileChooser(new File(curDir));
+ if(title != null)
+ fc.setDialogTitle(title);
+
fc.setMultiSelectionEnabled(multiple);
for (int i = 0; i ExtensionFileFilter.filters.length; ++i)
fc.addChoosableFileFilter(ExtensionFileFilter.filters[i]);
Index: src/org/openstreetmap/josm/actions/GpxExportAction.java
===
--- src/org/openstreetmap/josm/actions/GpxExportAction.java (Revision 681)
+++ src/org/openstreetmap/josm/actions/GpxExportAction.java (Arbeitskopie)
@@ -54,7 +54,7 @@
return;
}
- JFileChooser fc = createAndOpenFileChooser(false, false);
+ JFileChooser fc = createAndOpenFileChooser(false, false, null);
if (fc == null)
return;
File file = fc.getSelectedFile();
Index: src/org/openstreetmap/josm/actions/OpenAction.java
===
--- src/org/openstreetmap/josm/actions/OpenAction.java (Revision 681)
+++ src/org/openstreetmap/josm/actions/OpenAction.java (Arbeitskopie)
@@ -40,7 +40,7 @@
}
public void actionPerformed(ActionEvent e) {
- JFileChooser fc = createAndOpenFileChooser(true, true);
+ JFileChooser fc = createAndOpenFileChooser(true, true, null);
if (fc == null)
return;
File[] files = fc.getSelectedFiles();
Ciao
--
http://www.dstoecker.eu/ (PGP key available)
___
josm-dev mailing list
[EMAIL PROTECTED]
Re: [josm-dev] Clockwise coastline, anti-clockwise water
On Mon, 7 Jul 2008, Matthias Julius wrote: I thought the same. But the check anyway only tests closed ways (there is no real useable way to determine this issue for non-closed ways. Think of e.g. a U or J shaped way. How will you determine on which side water is (You can probably detect minimum distances to 100% land related structures and assume the side with these structures is land, but this will be a big effort). Neighboring coastlines need to go in opposite direction. It is an error if they don't. Didn't somebody implement a test for that? How do you want to do that automatically? It's easy for a human to see that, but very complicated to convert this into an working algorithm. To make it a bit more useful, I will an an check, which tests for unclosed ways in case of natural=. That will be helpful. At least coastlines don't need to be closed. And it would be good if we could drop that requirement for other areas as well. It's no requirement, but an validation warning. And like all the others, it will be able to turn it off :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] Automatic tag correction
On Sun, 6 Jul 2008, Robin Rattay wrote: I've attached a patch, with the hope that someone could give their opinion on the idea in general and my implementation in particular. Idea in general is very nice. Implementation probably has some problems to be fixed, but I'm not yet the one to comment on these :-) Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
