[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346377#comment-16346377
 ] 

ASF GitHub Bot commented on SLING-7454:
---

karlpauls commented on issue #3: SLING-7454: Make the IT use the latest 
repoinit snapshots, enable dis…
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/3#issuecomment-361849654
 
 
   @kwin, I updated the PR to not attach artifacts and remove the unnecessary 
phases - thanks a lot for looking at it!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at 
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has 
> similar dependencies, and in that way they are executed at the right time, 
> before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Limited search and find a file after git repo split

[Robert Munteanu]

Hi Alex,

On Wed, 2018-01-31 at 01:30 +, Alexander Klimetschek wrote:
> One thing that doesn't work well anymore after the repo split is
> 
> a) quickly navigate to a file (hit key "T" in github) across all
> Sling code (e.g. if you know the api or have a stacktrace, but no
> idea what repo that is)
> b) search
> 
> Unfortunately, github only indexes the main branch for b), so you
> can't search the "old" code base in [1] anymore. Granted, that would
> soon only only for historical purposes.
> 
> For the current code, you can approach b) by searching in the entire
> "apache" organization, but then you might also find a lot of noise
> from other projects.
> 
> I can't tell you how often I have been using a) or b) to navigate and
> read Sling code, it's a key tool for me.
> 
> Any ideas?

After a quick look at the github pages my only suggestion is using the
advanced search page

  https://github.com/search/advanced

and filling in all the sling repos in the repo field. The search would
then be something like this

  org:apache repo:org-apache-sling-api ResourceResolver

Unfortunately it does not seem to work :-( . If we find something that
works this way we can create a custom search link on sling.apache.org
and allow searching from there.

Thanks,

Robert

[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346375#comment-16346375
 ] 

ASF GitHub Bot commented on SLING-7454:
---

karlpauls commented on a change in pull request #3: SLING-7454: Make the IT use 
the latest repoinit snapshots, enable dis…
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/3#discussion_r164972569
 
 

 ##
 File path: pom.xml
 ##
 @@ -110,35 +110,40 @@
 
 org.apache.sling
 slingstart-maven-plugin
-1.7.0
+1.7.16
 true
 
 
 prepare-launchpad-package
+pre-integration-test
 
 prepare-package
 
 
 
 build-launchpad-package
+pre-integration-test
 
 package
 
 
 
  start-container-before-IT
+pre-integration-test
 
 start
 
 
 
  stop-container-after-IT
+ post-integration-test
 
 Review comment:
   Yeah, I added that mostly for consistency as I need the other executions 
moved - but if you think it is clear enough without that I'm fine with removing 
it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at 
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has 
> similar dependencies, and in that way they are executed at the right time, 
> before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346374#comment-16346374
 ] 

ASF GitHub Bot commented on SLING-7454:
---

karlpauls commented on a change in pull request #3: SLING-7454: Make the IT use 
the latest repoinit snapshots, enable dis…
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/3#discussion_r164972562
 
 

 ##
 File path: pom.xml
 ##
 @@ -110,35 +110,40 @@
 
 org.apache.sling
 slingstart-maven-plugin
-1.7.0
+1.7.16
 true
 
 
 prepare-launchpad-package
+pre-integration-test
 
 prepare-package
 
 
 
 build-launchpad-package
+pre-integration-test
 
 package
 
 
 
  start-container-before-IT
+pre-integration-test
 
 Review comment:
   Yeah, I added that mostly for consistency as I need the other executions 
moved - but if you think it is clear enough without that I'm fine with removing 
it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at 
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has 
> similar dependencies, and in that way they are executed at the right time, 
> before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346371#comment-16346371
 ] 

ASF GitHub Bot commented on SLING-7454:
---

karlpauls commented on a change in pull request #3: SLING-7454: Make the IT use 
the latest repoinit snapshots, enable dis…
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/3#discussion_r164972267
 
 

 ##
 File path: pom.xml
 ##
 @@ -110,35 +110,40 @@
 
 org.apache.sling
 slingstart-maven-plugin
-1.7.0
+1.7.16
 true
 
 
 prepare-launchpad-package
+pre-integration-test
 
 prepare-package
 
 
 
 build-launchpad-package
+pre-integration-test
 
 package
 
 
 Review comment:
   Right, that makes sense.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at 
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has 
> similar dependencies, and in that way they are executed at the right time, 
> before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346369#comment-16346369
 ] 

ASF GitHub Bot commented on SLING-7454:
---

karlpauls commented on a change in pull request #3: SLING-7454: Make the IT use 
the latest repoinit snapshots, enable dis…
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/3#discussion_r164971980
 
 

 ##
 File path: pom.xml
 ##
 @@ -110,35 +110,40 @@
 
 org.apache.sling
 slingstart-maven-plugin
-1.7.0
 
 Review comment:
   I agree that usually is the case. It is not in this case. In parent 30 it is 
1.7.2 and this needs 1.7.16 - updating to the latest parent has other problems 
which I don't feel like addressing right now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at 
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has 
> similar dependencies, and in that way they are executed at the right time, 
> before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346328#comment-16346328
 ] 

ASF GitHub Bot commented on SLING-7454:
---

kwin commented on a change in pull request #3: SLING-7454: Make the IT use the 
latest repoinit snapshots, enable dis…
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/3#discussion_r164962904
 
 

 ##
 File path: pom.xml
 ##
 @@ -110,35 +110,40 @@
 
 org.apache.sling
 slingstart-maven-plugin
-1.7.0
+1.7.16
 true
 
 
 prepare-launchpad-package
+pre-integration-test
 
 prepare-package
 
 
 
 build-launchpad-package
+pre-integration-test
 
 package
 
 
 
  start-container-before-IT
+pre-integration-test
 
 Review comment:
   this is the default phase for start


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at 
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has 
> similar dependencies, and in that way they are executed at the right time, 
> before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346329#comment-16346329
 ] 

ASF GitHub Bot commented on SLING-7454:
---

kwin commented on a change in pull request #3: SLING-7454: Make the IT use the 
latest repoinit snapshots, enable dis…
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/3#discussion_r164962947
 
 

 ##
 File path: pom.xml
 ##
 @@ -110,35 +110,40 @@
 
 org.apache.sling
 slingstart-maven-plugin
-1.7.0
+1.7.16
 true
 
 
 prepare-launchpad-package
+pre-integration-test
 
 prepare-package
 
 
 
 build-launchpad-package
+pre-integration-test
 
 package
 
 
 
  start-container-before-IT
+pre-integration-test
 
 start
 
 
 
  stop-container-after-IT
+ post-integration-test
 
 Review comment:
   this is the default phase for stop


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at 
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has 
> similar dependencies, and in that way they are executed at the right time, 
> before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346330#comment-16346330
 ] 

ASF GitHub Bot commented on SLING-7454:
---

kwin commented on a change in pull request #3: SLING-7454: Make the IT use the 
latest repoinit snapshots, enable dis…
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/3#discussion_r164962867
 
 

 ##
 File path: pom.xml
 ##
 @@ -110,35 +110,40 @@
 
 org.apache.sling
 slingstart-maven-plugin
-1.7.0
+1.7.16
 true
 
 
 prepare-launchpad-package
+pre-integration-test
 
 prepare-package
 
 
 
 build-launchpad-package
+pre-integration-test
 
 package
 
 
 Review comment:
   You should configure attachArtifact to false to prevent the IT launchpad 
from being deployed with the release.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at 
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has 
> similar dependencies, and in that way they are executed at the right time, 
> before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346331#comment-16346331
 ] 

ASF GitHub Bot commented on SLING-7454:
---

kwin commented on a change in pull request #3: SLING-7454: Make the IT use the 
latest repoinit snapshots, enable dis…
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/3#discussion_r164962649
 
 

 ##
 File path: pom.xml
 ##
 @@ -110,35 +110,40 @@
 
 org.apache.sling
 slingstart-maven-plugin
-1.7.0
 
 Review comment:
   This version is usually managed. 1.7.16 should be managed in the latest 
parent pom.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at 
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has 
> similar dependencies, and in that way they are executed at the right time, 
> before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Limited search and find a file after git repo split

[Alexander Klimetschek]

One thing that doesn't work well anymore after the repo split is

a) quickly navigate to a file (hit key "T" in github) across all Sling code 
(e.g. if you know the api or have a stacktrace, but no idea what repo that is)
b) search

Unfortunately, github only indexes the main branch for b), so you can't search 
the "old" code base in [1] anymore. Granted, that would soon only only for 
historical purposes.

For the current code, you can approach b) by searching in the entire "apache" 
organization, but then you might also find a lot of noise from other projects.

I can't tell you how often I have been using a) or b) to navigate and read 
Sling code, it's a key tool for me.

Any ideas?

[1] https://github.com/apache/sling-old-svn-mirror
[2] https://github.com/search?q=org%3Aapache+InputStream=Code

Cheers,
Alex

Re: apache/sling as github landing repository

[Alexander Klimetschek]

On 30.01.2018, at 01:38, Robert Munteanu  wrote:
> The constraint that we worked with is that many links would be pointing
> to https://github.com/apache/sling and these would be broken if we
> added another 'sling' repository to the mix.  So we decided to keep the
> old 'sling' repository in place, renamed, so links would not break.

What new links were you thinking of?

IIUC, it would be only a README.md and some others markdown files, plus the few 
xml files in sling-aggregator [0] in the "master" branch. Which is by design 
not in the old repo which used subversions "trunk".

Note that any link to a file or subfolder in github would always include the 
branch name.  Not sure if you would ever create branches other than "master" 
for this "landing" repo, and any that would conflict with the few fixed 
branches from the old repo [1].

tl;dr I don't think there is any chance for conflicts.

> The Sling SVN repository is read-only to make sure we don't
> accidentally commit changes there. We would need to go through infra
> for each change so frequent updates

Would it be possible to transform the github apache/sling repo, being a 
read-only mirror of the svn one (IIUC), into an active github repo? This might 
be a one time change, but you can still protect the old stuff.

Something like this:
1. delete apache/sling-old-svn-mirror on github and disable the mirroring 
(infra team?)
2. re-create apache/sling from the git mirror repos available at ASF (infra 
team?)
3. make all the old branches protected so they can't be modified anymore
4. add the aggregator and new landing page readme on the master branch, which 
will be push-able for committers

wdyt?

[0] https://github.com/apache/sling-aggregator
[1] https://github.com/apache/sling-old-svn-mirror/branches/all

Cheers,
Alex

[HEADS-UP] Repoinit releases

[Karl Pauls]

All,

I was planning to cut releases of repoinit.parser and jcr.repoinit
soon. I think we have the most pressing issues addressed. Will wait
for Bertrand to review SLING-7454 but otherwise I think the following
two version would be it:

https://issues.apache.org/jira/projects/SLING/versions/12341654

https://issues.apache.org/jira/projects/SLING/versions/12341653

In other words, speak now, or forever hold your peace :-)

regards,

Karl

-- 
Karl Pauls
karlpa...@gmail.com

[jira] [Updated] (SLING-7143) Support complete set of symbols for paths

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-7143:
--
Fix Version/s: (was: Repoinit Parser 1.2.2)
   Repoinit Parser 1.2.4

> Support complete set of symbols for paths
> -
>
> Key: SLING-7143
> URL: https://issues.apache.org/jira/browse/SLING-7143
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Affects Versions: Repoinit Parser 1.2.0
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Repoinit Parser 1.2.4
>
>
> As discussed in SLING-6774 and suggested by [~olli], we should support a 
> complete set of symbols for paths.
> cc [~oli], [~bdelacretaz]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-6423) Allow for specifying ACL merge mode (ACHandling) in repoinit

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-6423:
--
Fix Version/s: (was: Repoinit JCR 1.1.8)
   Repoinit JCR 1.1.10

> Allow for specifying ACL merge mode (ACHandling) in repoinit
> 
>
> Key: SLING-6423
> URL: https://issues.apache.org/jira/browse/SLING-6423
> Project: Sling
>  Issue Type: New Feature
>  Components: Repoinit
>Reporter: Nitin Nizhawan
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Repoinit JCR 1.1.10
>
> Attachments: SLING-6423_parser_changes.patch, 
> SLING-6423_testcases.patch, SLING_6423_testcasesV2.patch
>
>
> Repoinit by default just add new ACLs if they are not already present.
> By contract package manager provides various strategies for ACL merging
> Extend repoinit to allow specifying these strategies 
> https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.html#MERGE



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7147) Support ACL remove * statement

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-7147:
--
Fix Version/s: (was: Repoinit JCR 1.1.8)
   Repoinit JCR 1.1.10

> Support ACL remove * statement
> --
>
> Key: SLING-7147
> URL: https://issues.apache.org/jira/browse/SLING-7147
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Repoinit JCR 1.1.10
>
>
> The repoinit parser supports removing all ACLs with the syntax
> {code}
> set ACL on 
> remove * for 
> end
> {code}
> and 
> {code}
> set ACL for 
> remove * on 
> end
> {code}
> However, the JCR implementation does not seem to support it.
> This issue is about implementing the {{remove *}} statements for ACLs in the 
> JCR repoinit implementation.
> cc [~bdelacretaz]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[Karl Pauls (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345953#comment-16345953
 ] 

Karl Pauls commented on SLING-7454:
---

[~bdelacretaz], I got it to work. Please review my PR. Notice, I changed some 
dependencies to older versions in order to still be compatible with the bundles 
in Sling-9. I don't think we should increase version ranges where we don't have 
to (makes it harder to use the artifact in older environments). 

> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at 
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has 
> similar dependencies, and in that way they are executed at the right time, 
> before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345947#comment-16345947
 ] 

ASF GitHub Bot commented on SLING-7454:
---

karlpauls opened a new pull request #3: SLING-7454: Make the IT use the latest 
repoinit snapshots, enable dis…
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/3
 
 
   …abled IT's that require the newer snapshots, and improve 
backwardscompatibilty by dependening on older version.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at 
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has 
> similar dependencies, and in that way they are executed at the right time, 
> before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding

[Justin Edelson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson resolved SLING-7344.
---
Resolution: Fixed

Although I still think this is really a bug in Jetty, we have already 
implemented a workaround for the same issue in the default GET servlet, so we 
can do the same here.

> Jackson Sling Model Exporter needs correct character encoding
> -
>
> Key: SLING-7344
> URL: https://issues.apache.org/jira/browse/SLING-7344
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Chris Millar
>Assignee: Justin Edelson
>Priority: Major
> Fix For: Sling Models Impl 1.4.8
>
> Attachments: observe-1.png, observe-2.png, observe-3.png
>
>
> This is a formal ticket of what [~justinedelson] and I discussed earlier in 
> December 2017.
> The Jackson Sling Model Exporter needs to correctly set the character 
> encoding so content can be correctly handled. It currently defaults out to 
> ISO-8859-1 which makes displaying localized content impossible.
> I have put together a sample project here: 
> https://github.com/auniverseaway/sling-exporter-sample
> This will show how the default JSON get servlet correctly handles the 
> content, but the Jackson exporter does not. I have also attached screenshots 
> of the behaviors to this ticket.
> It sounded like Justin had ideas on where to solve this, so I will defer to 
> him on where it should be done. If I can help implement a solution in the 
> place you want, let me know. Internally, we cannot use the Jackson Exporter 
> until this is fixed, so it's pretty high priority for me to contribute back 
> if I can.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7344) Jackson Sling Model Exporter needs correct character encoding

[Justin Edelson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson reassigned SLING-7344:
-

 Assignee: Justin Edelson
Fix Version/s: Sling Models Impl 1.4.8
  Component/s: Extensions

> Jackson Sling Model Exporter needs correct character encoding
> -
>
> Key: SLING-7344
> URL: https://issues.apache.org/jira/browse/SLING-7344
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Chris Millar
>Assignee: Justin Edelson
>Priority: Major
> Fix For: Sling Models Impl 1.4.8
>
> Attachments: observe-1.png, observe-2.png, observe-3.png
>
>
> This is a formal ticket of what [~justinedelson] and I discussed earlier in 
> December 2017.
> The Jackson Sling Model Exporter needs to correctly set the character 
> encoding so content can be correctly handled. It currently defaults out to 
> ISO-8859-1 which makes displaying localized content impossible.
> I have put together a sample project here: 
> https://github.com/auniverseaway/sling-exporter-sample
> This will show how the default JSON get servlet correctly handles the 
> content, but the Jackson exporter does not. I have also attached screenshots 
> of the behaviors to this ticket.
> It sounded like Justin had ideas on where to solve this, so I will defer to 
> him on where it should be done. If I can help implement a solution in the 
> place you want, let me know. Internally, we cannot use the Jackson Exporter 
> until this is fixed, so it's pretty high priority for me to contribute back 
> if I can.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling Testing PaxExam 1.0.0

[Daniel Klco]

+1

On Tue, Jan 30, 2018 at 5:02 AM, Robert Munteanu  wrote:

> On Mon, 2018-01-29 at 18:38 +0100, Oliver Lietz wrote:
> > Please vote to approve this release:
>
> +1
>
> Robert

Re: Gauging interest on Yet Another Way to Find Resources

[Jason E Bailey]

I'm thinking it might be better off splitting it into two different features.

1.  Creating a stream of resources from a given resource
2. Language which will creates a Predicate which could apply to any 
given Stream  regardless of the source of the stream

But yeah, for the second which I see as a package, I'll get into the 
whiteboard. The first one, I'm thinking of a story and a  pull request against 
ResourceUtil. 

- Jason

On Tue, Jan 30, 2018, at 5:19 AM, Robert Munteanu wrote:
> Hi Jason,
> 
> On Thu, 2018-01-25 at 12:35 -0500, Jason E Bailey wrote:
> > Another one of my side projects
> > 
> > https://github.com/JEBailey/sling-resourcelocator
> > 
> > I think there's enough difference between other ways of finding
> > resources that there's  value to bringing it in.  But I like
> > feedback,
> > since I'm a bit prejudiced.
> > It works by creating a Java8 Stream of resource objects starting from
> > a
> > resource that you provide and iterating through descendants based on
> > provided criteria.
> > 1. Handles limits, ranges, and depth
> > 2. Control traversal path by setting conditions on which child
> > resource
> >can be included3. Can define complex acceptance criteria for
> > resources based on
> >properties4. Definable via fluid api or a filtering language
> > 5. filtering language is extensible using custom functions
> 
> IMO you can add it to the whiteboard, and we can further discuss its
> evolution once you think it's ready for a first release.
> 
> Thanks,
> 
> Robert

[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344982#comment-16344982
 ] 

Bertrand Delacretaz commented on SLING-7454:


I have also emptied the 
[https://github.com/apache/sling-org-apache-sling-repoinit-it] module to avoid 
confusion and added a .sling-module.xml file to disable its Jenkins build.

> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at 
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has 
> similar dependencies, and in that way they are executed at the right time, 
> before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344972#comment-16344972
 ] 

Bertrand Delacretaz commented on SLING-7454:


I have moved the ITs in commit 
[https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/6ebeeccd7f69cbc741ae71fe46f207cb3af32f36]
 - they pass but they are not using the latest repoinit bundles snapshots so 
far, so I had to disable one of them, add TODOs in the code.

> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at 
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has 
> similar dependencies, and in that way they are executed at the right time, 
> before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7454) Move repoinit integration tests to the JCR repoinit module

[Bertrand Delacretaz (JIRA)]

Bertrand Delacretaz created SLING-7454:
--

 Summary: Move repoinit integration tests to the JCR repoinit module
 Key: SLING-7454
 URL: https://issues.apache.org/jira/browse/SLING-7454
 Project: Sling
  Issue Type: Task
  Components: Repoinit
Affects Versions: Repoinit JCR 1.1.6
Reporter: Bertrand Delacretaz
Assignee: Bertrand Delacretaz
 Fix For: Repoinit JCR 1.1.8


Currently those tests are at 
[https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are 
failing.

It makes more sense anyway to move them to the jcr-repoinit module which has 
similar dependencies, and in that way they are executed at the right time, 
before releasing that module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7245) Validate pull requests using Jenkins

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344947#comment-16344947
 ] 

Robert Munteanu commented on SLING-7245:


To answer my own question, there is a {{Jenkinsfile}} per repo, with a single 
line - see https://github.com/apache/maven-jxr/blob/master/Jenkinsfile . This 
might be tenable for the benefit we get in terms of pull requests.

> Validate pull requests using Jenkins
> 
>
> Key: SLING-7245
> URL: https://issues.apache.org/jira/browse/SLING-7245
> Project: Sling
>  Issue Type: Improvement
>  Components: Best practices
>Reporter: Robert Munteanu
>Priority: Major
>
> We should refine the work done in SLING-7163 and validate PRs using Jenkins.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7452) Document the handling of multiple value fields with SlingPostServlet

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7452.

Resolution: Fixed
  Assignee: Robert Munteanu

Patch applied, thanks [~dplaton].

> Document the handling of multiple value fields with SlingPostServlet
> 
>
> Key: SLING-7452
> URL: https://issues.apache.org/jira/browse/SLING-7452
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Daniel Platon
>Assignee: Robert Munteanu
>Priority: Major
>
> The SlingPostServlet documentation at 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html]
>  doesn't detail on how to manipulate multi-valued properties with the changes 
> introduced by SLING-1983.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7452) Document the handling of multiple value fields with SlingPostServlet

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344942#comment-16344942
 ] 

ASF GitHub Bot commented on SLING-7452:
---

rombert closed pull request #7: SLING-7452 Document the handling of multiple 
value fields with SlingPostServlet
URL: https://github.com/apache/sling-site/pull/7
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/src/main/jbake/content/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.md
 
b/src/main/jbake/content/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.md
index 2b04c1f8..324d3b1e 100644
--- 
a/src/main/jbake/content/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.md
+++ 
b/src/main/jbake/content/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.md
@@ -144,6 +144,8 @@ Would assign the `/content/page/multi` property the value 
*[ "one", "two" ]*.
 
 This is pretty much all there is to know about creating and modifying content. 
The following sections will now introduce more functionality which help you 
with more fine-grained control in your content management application.
 
+For more operations with multiple values you can use the [`@Patch`](#patch) 
suffix.
+
 # Automatic property values: last modified and created by
 
 To make it easier to set "last modified" and "created by" property


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Document the handling of multiple value fields with SlingPostServlet
> 
>
> Key: SLING-7452
> URL: https://issues.apache.org/jira/browse/SLING-7452
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Daniel Platon
>Priority: Major
>
> The SlingPostServlet documentation at 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html]
>  doesn't detail on how to manipulate multi-valued properties with the changes 
> introduced by SLING-1983.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7452) Document the handling of multiple value fields with SlingPostServlet

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344943#comment-16344943
 ] 

ASF GitHub Bot commented on SLING-7452:
---

rombert commented on issue #7: SLING-7452 Document the handling of multiple 
value fields with SlingPostServlet
URL: https://github.com/apache/sling-site/pull/7#issuecomment-361571112
 
 
   Looks good, thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Document the handling of multiple value fields with SlingPostServlet
> 
>
> Key: SLING-7452
> URL: https://issues.apache.org/jira/browse/SLING-7452
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Daniel Platon
>Priority: Major
>
> The SlingPostServlet documentation at 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html]
>  doesn't detail on how to manipulate multi-valued properties with the changes 
> introduced by SLING-1983.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7452) Document the handling of multiple value fields with SlingPostServlet

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344940#comment-16344940
 ] 

ASF GitHub Bot commented on SLING-7452:
---

rombert commented on issue #7: SLING-7452 Document the handling of multiple 
value fields with SlingPostServlet
URL: https://github.com/apache/sling-site/pull/7#issuecomment-361569957
 
 
   It's auto-generated by the markdown template, so the editor can't know about 
it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Document the handling of multiple value fields with SlingPostServlet
> 
>
> Key: SLING-7452
> URL: https://issues.apache.org/jira/browse/SLING-7452
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Daniel Platon
>Priority: Major
>
> The SlingPostServlet documentation at 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html]
>  doesn't detail on how to manipulate multi-valued properties with the changes 
> introduced by SLING-1983.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7452) Document the handling of multiple value fields with SlingPostServlet

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344937#comment-16344937
 ] 

ASF GitHub Bot commented on SLING-7452:
---

rombert commented on issue #7: SLING-7452 Document the handling of multiple 
value fields with SlingPostServlet
URL: https://github.com/apache/sling-site/pull/7#issuecomment-361569163
 
 
   Can't you use '#patch' as a link?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Document the handling of multiple value fields with SlingPostServlet
> 
>
> Key: SLING-7452
> URL: https://issues.apache.org/jira/browse/SLING-7452
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Daniel Platon
>Priority: Major
>
> The SlingPostServlet documentation at 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html]
>  doesn't detail on how to manipulate multi-valued properties with the changes 
> introduced by SLING-1983.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] bhardwajrahul20 commented on issue #1: Sling-7346-Json response converting response property value to string even if it is json object

[GitBox]

bhardwajrahul20 commented on issue #1: Sling-7346-Json response converting 
response property value to string even if it is json object
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/1#issuecomment-361568912
 
 
   @JEBailey  - Yes, I had a discussion with @karlpauls  and the other commit 
too fixes this issue. Closing this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bhardwajrahul20 closed pull request #1: Sling-7346-Json response converting response property value to string even if it is json object

[GitBox]

bhardwajrahul20 closed pull request #1: Sling-7346-Json response converting 
response property value to string even if it is json object
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/main/java/org/apache/sling/servlets/post/JSONResponse.java 
b/src/main/java/org/apache/sling/servlets/post/JSONResponse.java
index e65e90c..dcf9c72 100644
--- a/src/main/java/org/apache/sling/servlets/post/JSONResponse.java
+++ b/src/main/java/org/apache/sling/servlets/post/JSONResponse.java
@@ -24,6 +24,7 @@
 import javax.json.JsonObjectBuilder;
 import javax.servlet.http.HttpServletResponse;
 import java.io.IOException;
+import java.io.StringReader;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
@@ -103,9 +104,14 @@ JsonObject getJson() {
 JsonObjectBuilder jsonBuilder = Json.createObjectBuilder();
 for (Map.Entry entry : json.entrySet()) {
 if (entry.getValue() != null) {
-jsonBuilder.add(entry.getKey(), entry.getValue().toString());
-}
-else {
+//Check for org.apache.sling.commons.json.JSONObject for 
backward compatibility
+
if(entry.getValue().getClass().getName().equals("org.apache.sling.commons.json.JSONObject")
 || entry.getValue() instanceof JsonObject) {
+jsonBuilder.add(entry.getKey(),
+Json.createReader(new 
StringReader(entry.getValue().toString())).readObject());
+} else {
+jsonBuilder.add(entry.getKey(), 
entry.getValue().toString());
+}
+} else {
 jsonBuilder.addNull(entry.getKey());
 }
 }
diff --git a/src/test/java/org/apache/sling/servlets/post/JsonResponseTest.java 
b/src/test/java/org/apache/sling/servlets/post/JsonResponseTest.java
index d591628..1be0f29 100644
--- a/src/test/java/org/apache/sling/servlets/post/JsonResponseTest.java
+++ b/src/test/java/org/apache/sling/servlets/post/JsonResponseTest.java
@@ -115,11 +115,28 @@ public void testNoChangesOnError() throws Exception {
 assertEquals(0, obj.getJsonArray("changes").size());
 }
 
+public void testSendWithJsonAsPropertyValue() throws Exception {
+String testResponseJson = 
"{\"user\":\"testUser\",\"properties\":{\"id\":\"testId\", \"name\":\"test\"}}";
+JsonObject customProperty = Json.createReader(new 
StringReader(testResponseJson)).readObject();
+res.setProperty("response", customProperty);
+MockResponseWithHeader response = new MockResponseWithHeader();
+res.send(response, true);
+JsonObject result = Json.createReader(new 
StringReader(response.getOutput().toString())).readObject();
+assertProperty(result, "response", customProperty);
+}
+
 private static JsonValue assertProperty(JsonObject obj, String key) {
 assertTrue("JSON object does not have property " + key, 
obj.containsKey(key));
 return obj.get(key);
 }
 
+@SuppressWarnings({"unchecked"})
+private static JsonObject assertProperty(JsonObject obj, String key, 
JsonObject expected) {
+JsonObject res = (JsonObject) assertProperty(obj, key);
+assertEquals(expected, res);
+return res;
+}
+
 @SuppressWarnings({"unchecked"})
 private static JsonString assertProperty(JsonObject obj, String key, 
String expected) {
 JsonString res = (JsonString) assertProperty(obj, key);


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-7452) Document the handling of multiple value fields with SlingPostServlet

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344923#comment-16344923
 ] 

ASF GitHub Bot commented on SLING-7452:
---

rombert commented on issue #7: SLING-7452 Document the handling of multiple 
value fields with SlingPostServlet
URL: https://github.com/apache/sling-site/pull/7#issuecomment-361567910
 
 
   I know I'm nitpicking, but there's already an auto-generated patch anchor - 
https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#patch
 . Can you use that instead?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Document the handling of multiple value fields with SlingPostServlet
> 
>
> Key: SLING-7452
> URL: https://issues.apache.org/jira/browse/SLING-7452
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Daniel Platon
>Priority: Major
>
> The SlingPostServlet documentation at 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html]
>  doesn't detail on how to manipulate multi-valued properties with the changes 
> introduced by SLING-1983.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7346) Issues with custom fields in PostResponse as a result of fix for SLING-6681(Replace commons.json usage in org.apache.sling.servlets.post)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344926#comment-16344926
 ] 

ASF GitHub Bot commented on SLING-7346:
---

rombert commented on issue #3: SLING-7346: handle JSONResponse properties as 
json if possible.
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/3#issuecomment-361568270
 
 
   @npeltier  - we currently use http://johnzon.apache.org/ for JSON. What 
exactly did you have in mind?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Issues with custom fields in PostResponse as a result of fix for 
> SLING-6681(Replace commons.json usage in org.apache.sling.servlets.post)
> -
>
> Key: SLING-7346
> URL: https://issues.apache.org/jira/browse/SLING-7346
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Post 2.3.22
>Reporter: Rahul Bhardwaj
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Servlets Post 2.3.24
>
>
> If you set a value of type as map as a custom property in response type, 
> instead of parsing properly, whole map is converted into one string and 
> therefore, json response does not reach client side in an orderly fashion.
> This can be attributed to [0] which was merged as part of fix for 
> SLING-6681(Replace commons.json usage in org.apache.sling.servlets.post)
> [0] 
> -https://github.com/apache/sling/commit/a598bd4f6e9fc4f967e118de705643a04a47bc44#diff-2ff02a567147f2cbef2e344d5338dd14R106



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7452) Document the handling of multiple value fields with SlingPostServlet

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344925#comment-16344925
 ] 

ASF GitHub Bot commented on SLING-7452:
---

dplaton commented on issue #7: SLING-7452 Document the handling of multiple 
value fields with SlingPostServlet
URL: https://github.com/apache/sling-site/pull/7#issuecomment-361568162
 
 
   Ok, I wanted to use an internal link instead of the long one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Document the handling of multiple value fields with SlingPostServlet
> 
>
> Key: SLING-7452
> URL: https://issues.apache.org/jira/browse/SLING-7452
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Daniel Platon
>Priority: Major
>
> The SlingPostServlet documentation at 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html]
>  doesn't detail on how to manipulate multi-valued properties with the changes 
> introduced by SLING-1983.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] rombert commented on issue #3: SLING-7346: handle JSONResponse properties as json if possible.

[GitBox]

rombert commented on issue #3: SLING-7346: handle JSONResponse properties as 
json if possible.
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/3#issuecomment-361568270
 
 
   @npeltier  - we currently use http://johnzon.apache.org/ for JSON. What 
exactly did you have in mind?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-7452) Document the handling of multiple value fields with SlingPostServlet

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344886#comment-16344886
 ] 

ASF GitHub Bot commented on SLING-7452:
---

dplaton commented on issue #7: SLING-7452 Document the handling of multiple 
value fields with SlingPostServlet
URL: https://github.com/apache/sling-site/pull/7#issuecomment-361562068
 
 
   Ok @rombert , I added a link to the 'patch' section. That section covers 
everything there is to know.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Document the handling of multiple value fields with SlingPostServlet
> 
>
> Key: SLING-7452
> URL: https://issues.apache.org/jira/browse/SLING-7452
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Daniel Platon
>Priority: Major
>
> The SlingPostServlet documentation at 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html]
>  doesn't detail on how to manipulate multi-valued properties with the changes 
> introduced by SLING-1983.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7443) Actual build for standalone jar is not working with latest JDK

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344867#comment-16344867
 ] 

Robert Munteanu commented on SLING-7443:


Or rather 'Download Zip', the full zip looks broken on Sling 9.

> Actual build for standalone jar is not working with latest JDK
> --
>
> Key: SLING-7443
> URL: https://issues.apache.org/jira/browse/SLING-7443
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
> Environment: Windows 10, JDK 9 or latest 1.8
>Reporter: frederic rougeot
>Priority: Major
>  Labels: starter
>
> I tried to use your standalone jar with latest JDK, I mean JDK 9, or JDK 
> 1.8.0_162b12, but it does not work ... The following log is encountered with 
> JDK 1.8.162 when launching java -jar org.apache.sling.launchpad-9.jar:
> 24.01.2018 15:45:34.872 *ERROR* [FelixStartLevel] ERROR: Bundle '18' Error 
> starting 
> slinginstall:C:\projets\Veolia\tools\sling\startup\1\slf4j-api-1.7.21.jar 
> (org.osgi.framework.BundleException: Unable to resolve slf4j.api [18](R 
> 18.0): missing requirement [slf4j.api [18](R 18.0)] ...
>  
> So I will try now with JDK 1.8.0.161 (a colleague tells me it was quite OK 
> with JDK 1.8.0.77à



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7148) Do not fail when disabling or deleting a non existing service user

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-7148.
---
Resolution: Fixed

Done (I added a debug message).

> Do not fail when disabling or deleting a non existing service user
> --
>
> Key: SLING-7148
> URL: https://issues.apache.org/jira/browse/SLING-7148
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Timothee Maret
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Repoinit JCR 1.1.8
>
>
> SLING-6984 allows to disable service user. The existing implementation does 
> throw an exception if the service user to be disabled does not exist. This 
> prevent to remove the service user for new setups.
> This issue is about allowing to disable a non existing user, by simply 
> logging a warning message rather than throwing an exception.
> cc [~bdelacretaz]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7148) Do not fail when disabling or deleting a non existing service user

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344857#comment-16344857
 ] 

ASF GitHub Bot commented on SLING-7148:
---

karlpauls closed pull request #2: SLING-7148: Do not fail when disabling or 
deleting a non existing ser…
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/2
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Do not fail when disabling or deleting a non existing service user
> --
>
> Key: SLING-7148
> URL: https://issues.apache.org/jira/browse/SLING-7148
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Timothee Maret
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Repoinit JCR 1.1.8
>
>
> SLING-6984 allows to disable service user. The existing implementation does 
> throw an exception if the service user to be disabled does not exist. This 
> prevent to remove the service user for new setups.
> This issue is about allowing to disable a non existing user, by simply 
> logging a warning message rather than throwing an exception.
> cc [~bdelacretaz]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7443) Actual build for standalone jar is not working with latest JDK

[frederic rougeot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344855#comment-16344855
 ] 

frederic rougeot commented on SLING-7443:
-

Absolutely not ... I checked first with version 9 first, then with version 8 
b162, then b161 -> the pre-compiled version does not work, if I compile from 
source yes it works.

 

The precompiled version works with version 8 but release 77 (I did not check 
all the release, only this one).

 

 

> Actual build for standalone jar is not working with latest JDK
> --
>
> Key: SLING-7443
> URL: https://issues.apache.org/jira/browse/SLING-7443
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
> Environment: Windows 10, JDK 9 or latest 1.8
>Reporter: frederic rougeot
>Priority: Major
>  Labels: starter
>
> I tried to use your standalone jar with latest JDK, I mean JDK 9, or JDK 
> 1.8.0_162b12, but it does not work ... The following log is encountered with 
> JDK 1.8.162 when launching java -jar org.apache.sling.launchpad-9.jar:
> 24.01.2018 15:45:34.872 *ERROR* [FelixStartLevel] ERROR: Bundle '18' Error 
> starting 
> slinginstall:C:\projets\Veolia\tools\sling\startup\1\slf4j-api-1.7.21.jar 
> (org.osgi.framework.BundleException: Unable to resolve slf4j.api [18](R 
> 18.0): missing requirement [slf4j.api [18](R 18.0)] ...
>  
> So I will try now with JDK 1.8.0.161 (a colleague tells me it was quite OK 
> with JDK 1.8.0.77à



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7443) Actual build for standalone jar is not working with latest JDK

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344864#comment-16344864
 ] 

Robert Munteanu commented on SLING-7443:


Hm, interesting. Here are the steps that I took, in an empty directory:

{noformat}
$ wget -q 
http://repo1.maven.org/maven2/org/apache/sling/org.apache.sling.launchpad/9/org.apache.sling.launchpad-9.jar
$ java -version
java version "1.8.0_152"
Java(TM) SE Runtime Environment (build 1.8.0_152-b16)
Java HotSpot(TM) 64-Bit Server VM (build 25.152-b16, mixed mode)
$ java -jar org.apache.sling.launchpad-9.jar
{noformat}

Can you access http://localhost:8080/system/console/status-Bundles, press 
'Download Full Zip' and attach it here?

> Actual build for standalone jar is not working with latest JDK
> --
>
> Key: SLING-7443
> URL: https://issues.apache.org/jira/browse/SLING-7443
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
> Environment: Windows 10, JDK 9 or latest 1.8
>Reporter: frederic rougeot
>Priority: Major
>  Labels: starter
>
> I tried to use your standalone jar with latest JDK, I mean JDK 9, or JDK 
> 1.8.0_162b12, but it does not work ... The following log is encountered with 
> JDK 1.8.162 when launching java -jar org.apache.sling.launchpad-9.jar:
> 24.01.2018 15:45:34.872 *ERROR* [FelixStartLevel] ERROR: Bundle '18' Error 
> starting 
> slinginstall:C:\projets\Veolia\tools\sling\startup\1\slf4j-api-1.7.21.jar 
> (org.osgi.framework.BundleException: Unable to resolve slf4j.api [18](R 
> 18.0): missing requirement [slf4j.api [18](R 18.0)] ...
>  
> So I will try now with JDK 1.8.0.161 (a colleague tells me it was quite OK 
> with JDK 1.8.0.77à



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7453) Resource Editor uses jQuery version with known vulnerabilities

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-7453:
--

 Summary: Resource Editor uses jQuery version with known 
vulnerabilities
 Key: SLING-7453
 URL: https://issues.apache.org/jira/browse/SLING-7453
 Project: Sling
  Issue Type: Task
  Components: Extensions
Reporter: Robert Munteanu
 Fix For: Resource Editor 1.0.2


https://snyk.io/test/npm/jquery/1.11.2?severity=high=medium=low

[~sandro] - would be good to take a look at this when you have the time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7148) Do not fail when disabling or deleting a non existing service user

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344843#comment-16344843
 ] 

Bertrand Delacretaz commented on SLING-7148:


Thanks Karl, your changes look good, I'd just add a DEBUG log when ignoring 
instructions due to non-existing user or service user.

> Do not fail when disabling or deleting a non existing service user
> --
>
> Key: SLING-7148
> URL: https://issues.apache.org/jira/browse/SLING-7148
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Timothee Maret
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Repoinit JCR 1.1.8
>
>
> SLING-6984 allows to disable service user. The existing implementation does 
> throw an exception if the service user to be disabled does not exist. This 
> prevent to remove the service user for new setups.
> This issue is about allowing to disable a non existing user, by simply 
> logging a warning message rather than throwing an exception.
> cc [~bdelacretaz]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7148) Do not fail when disabling or deleting a non existing service user

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344827#comment-16344827
 ] 

ASF GitHub Bot commented on SLING-7148:
---

karlpauls opened a new pull request #2: SLING-7148: Do not fail when disabling 
or deleting a non existing ser…
URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/2
 
 
   …vice user.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Do not fail when disabling or deleting a non existing service user
> --
>
> Key: SLING-7148
> URL: https://issues.apache.org/jira/browse/SLING-7148
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Timothee Maret
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Repoinit JCR 1.1.8
>
>
> SLING-6984 allows to disable service user. The existing implementation does 
> throw an exception if the service user to be disabled does not exist. This 
> prevent to remove the service user for new setups.
> This issue is about allowing to disable a non existing user, by simply 
> logging a warning message rather than throwing an exception.
> cc [~bdelacretaz]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7148) Do not fail when disabling or deleting a non existing service user

[Karl Pauls (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344828#comment-16344828
 ] 

Karl Pauls commented on SLING-7148:
---

[~bdelacretaz], please review.

> Do not fail when disabling or deleting a non existing service user
> --
>
> Key: SLING-7148
> URL: https://issues.apache.org/jira/browse/SLING-7148
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Timothee Maret
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Repoinit JCR 1.1.8
>
>
> SLING-6984 allows to disable service user. The existing implementation does 
> throw an exception if the service user to be disabled does not exist. This 
> prevent to remove the service user for new setups.
> This issue is about allowing to disable a non existing user, by simply 
> logging a warning message rather than throwing an exception.
> cc [~bdelacretaz]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Gauging interest on Yet Another Way to Find Resources

[Robert Munteanu]

Hi Jason,

On Thu, 2018-01-25 at 12:35 -0500, Jason E Bailey wrote:
> Another one of my side projects
> 
> https://github.com/JEBailey/sling-resourcelocator
> 
> I think there's enough difference between other ways of finding
> resources that there's  value to bringing it in.  But I like
> feedback,
> since I'm a bit prejudiced.
> It works by creating a Java8 Stream of resource objects starting from
> a
> resource that you provide and iterating through descendants based on
> provided criteria.
> 1. Handles limits, ranges, and depth
> 2. Control traversal path by setting conditions on which child
> resource
>can be included3. Can define complex acceptance criteria for
> resources based on
>properties4. Definable via fluid api or a filtering language
> 5. filtering language is extensible using custom functions

IMO you can add it to the whiteboard, and we can further discuss its
evolution once you think it's ready for a first release.

Thanks,

Robert

[jira] [Commented] (SLING-7443) Actual build for standalone jar is not working with latest JDK

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344810#comment-16344810
 ] 

Robert Munteanu commented on SLING-7443:


I am running the 9 release with Java 8 without any issues. I think you're 
actually using Java 9, based on the errors, instead of Java 8. 

> Actual build for standalone jar is not working with latest JDK
> --
>
> Key: SLING-7443
> URL: https://issues.apache.org/jira/browse/SLING-7443
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
> Environment: Windows 10, JDK 9 or latest 1.8
>Reporter: frederic rougeot
>Priority: Major
>  Labels: starter
>
> I tried to use your standalone jar with latest JDK, I mean JDK 9, or JDK 
> 1.8.0_162b12, but it does not work ... The following log is encountered with 
> JDK 1.8.162 when launching java -jar org.apache.sling.launchpad-9.jar:
> 24.01.2018 15:45:34.872 *ERROR* [FelixStartLevel] ERROR: Bundle '18' Error 
> starting 
> slinginstall:C:\projets\Veolia\tools\sling\startup\1\slf4j-api-1.7.21.jar 
> (org.osgi.framework.BundleException: Unable to resolve slf4j.api [18](R 
> 18.0): missing requirement [slf4j.api [18](R 18.0)] ...
>  
> So I will try now with JDK 1.8.0.161 (a colleague tells me it was quite OK 
> with JDK 1.8.0.77à



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7148) Do not fail when disabling or deleting a non existing service user

[Karl Pauls (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344806#comment-16344806
 ] 

Karl Pauls commented on SLING-7148:
---

As there was some discussion about it in  SLING-6984 and as it seems to make 
sense I'll make it so that we will turn both, deleting and disabling of users 
that don't exist into a noop rather than an exception.

> Do not fail when disabling or deleting a non existing service user
> --
>
> Key: SLING-7148
> URL: https://issues.apache.org/jira/browse/SLING-7148
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Timothee Maret
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Repoinit JCR 1.1.8
>
>
> SLING-6984 allows to disable service user. The existing implementation does 
> throw an exception if the service user to be disabled does not exist. This 
> prevent to remove the service user for new setups.
> This issue is about allowing to disable a non existing user, by simply 
> logging a warning message rather than throwing an exception.
> cc [~bdelacretaz]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7148) Do not fail when disabling or deleting a non existing service user

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-7148:
--
Summary: Do not fail when disabling or deleting a non existing service user 
 (was: Do not fail when disabling non existing service user)

> Do not fail when disabling or deleting a non existing service user
> --
>
> Key: SLING-7148
> URL: https://issues.apache.org/jira/browse/SLING-7148
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Timothee Maret
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Repoinit JCR 1.1.8
>
>
> SLING-6984 allows to disable service user. The existing implementation does 
> throw an exception if the service user to be disabled does not exist. This 
> prevent to remove the service user for new setups.
> This issue is about allowing to disable a non existing user, by simply 
> logging a warning message rather than throwing an exception.
> cc [~bdelacretaz]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7148) Do not fail when disabling non existing service user

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls reassigned SLING-7148:
-

Assignee: Karl Pauls

> Do not fail when disabling non existing service user
> 
>
> Key: SLING-7148
> URL: https://issues.apache.org/jira/browse/SLING-7148
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Timothee Maret
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Repoinit JCR 1.1.8
>
>
> SLING-6984 allows to disable service user. The existing implementation does 
> throw an exception if the service user to be disabled does not exist. This 
> prevent to remove the service user for new setups.
> This issue is about allowing to disable a non existing user, by simply 
> logging a warning message rather than throwing an exception.
> cc [~bdelacretaz]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling Testing PaxExam 1.0.0

[Robert Munteanu]

On Mon, 2018-01-29 at 18:38 +0100, Oliver Lietz wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part

[jira] [Commented] (SLING-7452) Document the handling of multiple value fields with SlingPostServlet

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344765#comment-16344765
 ] 

ASF GitHub Bot commented on SLING-7452:
---

rombert commented on issue #7: SLING-7452 Document the handling of multiple 
value fields with SlingPostServlet
URL: https://github.com/apache/sling-site/pull/7#issuecomment-361537110
 
 
   @dplaton - would it work if you added a link from the 'multiple values' 
section to the 'patch' section? Also it would be good to review if your changes 
have any additions/clarifications over the current docs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Document the handling of multiple value fields with SlingPostServlet
> 
>
> Key: SLING-7452
> URL: https://issues.apache.org/jira/browse/SLING-7452
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Daniel Platon
>Priority: Major
>
> The SlingPostServlet documentation at 
> [http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html]
>  doesn't detail on how to manipulate multi-valued properties with the changes 
> introduced by SLING-1983.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: How to re-add the "contrib" and other repositories classifications?

[Robert Munteanu]

On Mon, 2018-01-29 at 17:08 +0100, Bertrand Delacretaz wrote:
> Hi,
> 
> On Mon, Jan 29, 2018 at 10:41 AM, Bertrand Delacretaz
>  wrote:
> > ...it would be nice to have additional tags for
> > repositories like contrib, experimental, core etc
> 
> turns out we already discussed this back in November and Robert has a
> nice proposal here:
> 
> https://cwiki.apache.org/confluence/display/SLING/Sling+module+descri
> ptor
> 
> Right now there's only a few modules which use it to tweak the
> generation of Jenkins jobs, but it's easy to expand with tags once we
> can consume those.

+1 :-)

Robert

Re: apache/sling as github landing repository

[Robert Munteanu]

Hi Alex,

Thanks for taking this discussion to the dev list, there is a real need
to improve our landing page.

Please see my individual response below. I'm explaining the process we
went through to arrive at this situation, not countering your
arguments.

In the end I'm happy to work with whatever solution we have an
agreement on, including reversing the current approach.

On Thu, 2018-01-25 at 23:54 +, Alexander Klimetschek wrote:
> 1. restore the apache/sling named repo, since that should help with
> SEO and "keeping" the existing brand

If you go to https://github.com/apache/sling it still works, just that
you're redirected to another repo. 

> 
> 2. have a readme in there as the github landing page, just like any
> github project nowadays, which should include an about project and
> most information how to use sling/download it, find source repos and
> how to build it. Similar to the project information page [3], but
> more easily digestible with less text.

Fully agreed, we can easily do this as a one-off change.

> 
> 3. move the aggregator [2] to apache/sling, as that feels like a
> natural place (since this all happens on the new "master" branch,
> there is no conflict with the old sling code base in there)

The constraint that we worked with is that many links would be pointing
to https://github.com/apache/sling and these would be broken if we
added another 'sling' repository to the mix.  So we decided to keep the
old 'sling' repository in place, renamed, so links would not break.

We also switched the default branch so that people would not start
browsing the code since it's now outdated. What is presented on the
landing page is actually

  https://svn.apache.org/repos/asf/sling/branches/archived/

> 4. have a curated list of repos in there (could be a separated
> markdown prominently linked from the main readme given its size),
> which would provide some categorization and e.g. start with the
> important stuff at the top. Guidelines for creating new
> repos/changing repos should hint at updating this readme. But even if
> it's not 100% up to date all the time, the vast majority of repos
> that don't change over time will be explorable.

The Sling SVN repository is read-only to make sure we don't
accidentally commit changes there. We would need to go through infra
for each change so frequent updates 

Thanks,

Robert

Re: [VOTE] Release Apache Sling Testing PaxExam 1.0.0

[Nicolas Peltier]

+ 1 (non binding)

(signatures and digests look good)

2018-01-29 18:51 GMT+01:00 Oliver Lietz :

> On Monday 29 January 2018 18:38:11 Oliver Lietz wrote:
> > Hi,
> >
> > we solved 11 issues in this release:
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12340234
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-1866/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > https://gitbox.apache.org/repos/asf?p=sling-tooling-
> release.git;a=blob;f=che
> > ck_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 1855 /tmp/sling-staging
>
> 1866 of course...
>
> O.
>
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > NOTE: Integration tests require Commons Threads 3.2.16 (under vote) and a
> > local build of upcoming Pipes 2.0.0.
> >
> > Regards,
> > O.
>
>