[jira] [Commented] (SLING-8418) Consolidate starter-startup and startupfilter/startupfilter-disabler to use Apache Felix HC ServiceUnavailableFilter
[ https://issues.apache.org/jira/browse/SLING-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850172#comment-16850172 ] Georg Henzler commented on SLING-8418: -- Updated https://sling.apache.org/downloads.cgi as suggested. > Consolidate starter-startup and startupfilter/startupfilter-disabler to use > Apache Felix HC ServiceUnavailableFilter > > > Key: SLING-8418 > URL: https://issues.apache.org/jira/browse/SLING-8418 > Project: Sling > Issue Type: Improvement > Components: Starter >Reporter: Georg Henzler >Assignee: Georg Henzler >Priority: Major > Fix For: Starter 12, Starter Content 1.0.4 > > > See > https://github.com/apache/felix/blob/trunk/healthcheck/README.md#service-unavailable-filter > for a general-purpose mechanism from Apache Felix to replace starter-startup > and startupfilter/startupfilter-disabler > [1] > http://apache-sling.73963.n3.nabble.com/DISCUSS-Consolidate-starter-startup-and-startupfilter-startupfilter-disabler-to-use-Apache-Felix-HC-r-tt4090963.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[DISCUSS] Best way of deprecating modules
Hi Robert, sorry to only get back to your comment [1] now - so I tried a couple of versions back and forth and I believe it would be best to do the following: * Create a branch "maintenance" with the last version before deprecation (but as it is a branch hotfix releases could be cut from it if necessary) * Leave the repo empty with a sole README.md file and add a line "For reference or potential bugfix releases use branch maintenance" See fork [2] in my user account to illustrate how this approach looks like. The advantage is that * the README file with the obsolete text is not overseen (with the long list of folders/files from src/main, CONTRIBUTING.md, to pom.xml the notice in the README would get easily overlooked) * if necessary it's still easy to look at the code (one click) or even release from it (maven-release-plugin does not worry too much about branch names) WDYT? -Georg [1] https://issues.apache.org/jira/browse/SLING-8418?focusedCommentId=16846509=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16846509 [2] https://github.com/ghenzler/sling-org-apache-sling-starter-startup
[jira] [Resolved] (SLING-8445) Provide SPI Fly Option
[ https://issues.apache.org/jira/browse/SLING-8445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-8445. - Resolution: Done > Provide SPI Fly Option > -- > > Key: SLING-8445 > URL: https://issues.apache.org/jira/browse/SLING-8445 > Project: Sling > Issue Type: New Feature > Components: Testing >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Testing PaxExam 3.0.0 > > > https://aries.apache.org/modules/spi-fly.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8445) Provide SPI Fly Option
[
https://issues.apache.org/jira/browse/SLING-8445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850142#comment-16850142
]
Oliver Lietz commented on SLING-8445:
-
Use in {{TestSupport}} and {{SlingOptionsTestSupport}} (required by upcoming
dependency updates).
> Provide SPI Fly Option
> --
>
> Key: SLING-8445
> URL: https://issues.apache.org/jira/browse/SLING-8445
> Project: Sling
> Issue Type: New Feature
> Components: Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 3.0.0
>
>
> https://aries.apache.org/modules/spi-fly.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8444) Update Felix Framework to 6.0.3
[ https://issues.apache.org/jira/browse/SLING-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-8444. - Resolution: Done > Update Felix Framework to 6.0.3 > --- > > Key: SLING-8444 > URL: https://issues.apache.org/jira/browse/SLING-8444 > Project: Sling > Issue Type: Task > Components: Testing >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Testing PaxExam 3.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8445) Provide SPI Fly Option
Oliver Lietz created SLING-8445: --- Summary: Provide SPI Fly Option Key: SLING-8445 URL: https://issues.apache.org/jira/browse/SLING-8445 Project: Sling Issue Type: New Feature Components: Testing Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Testing PaxExam 3.0.0 https://aries.apache.org/modules/spi-fly.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8444) Update Felix Framework to 6.0.3
Oliver Lietz created SLING-8444: --- Summary: Update Felix Framework to 6.0.3 Key: SLING-8444 URL: https://issues.apache.org/jira/browse/SLING-8444 Project: Sling Issue Type: Task Components: Testing Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Testing PaxExam 3.0.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [VOTE] Release Apache Sling JCR Base 3.1.0
+1 On Mon, May 27, 2019 at 11:18 AM Radu Cotescu wrote: > +1 > > > On 27 May 2019, at 13:32, Karl Pauls wrote: > > > > Please vote to approve these release: > > > > [ ] +1 Approve the releases > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > >
[jira] [Resolved] (SLING-8443) Simplify journal_available metric
[ https://issues.apache.org/jira/browse/SLING-8443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret resolved SLING-8443. --- Resolution: Fixed > Simplify journal_available metric > - > > Key: SLING-8443 > URL: https://issues.apache.org/jira/browse/SLING-8443 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Affects Versions: Content Distribution Journal Core 0.1.0 >Reporter: Christian Schneider >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Core 0.1.2 > > Time Spent: 20m > Remaining Estimate: 0h > > The current implementation creates a Gauge service "by hand" using the OSGi > API. It also uses the marker service to detect the journal availability which > requires an optional dynamic service reference. > I propose to change this to a DS component and uses a simple reference to > JournalAvailableChecker which is in the same package anyway. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8443) Simplify journal_available metric
[ https://issues.apache.org/jira/browse/SLING-8443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850079#comment-16850079 ] Timothee Maret commented on SLING-8443: --- Thanks [~cschneider]! Merged your PR. > Simplify journal_available metric > - > > Key: SLING-8443 > URL: https://issues.apache.org/jira/browse/SLING-8443 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Affects Versions: Content Distribution Journal Core 0.1.0 >Reporter: Christian Schneider >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Core 0.1.2 > > Time Spent: 20m > Remaining Estimate: 0h > > The current implementation creates a Gauge service "by hand" using the OSGi > API. It also uses the marker service to detect the journal availability which > requires an optional dynamic service reference. > I propose to change this to a DS component and uses a simple reference to > JournalAvailableChecker which is in the same package anyway. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8435) Provide Felix Health Check feature
[ https://issues.apache.org/jira/browse/SLING-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-8435. - Resolution: Done Fix Version/s: Karaf Launchpad Integration Tests (Oak Tar) 0.0.2 > Provide Felix Health Check feature > -- > > Key: SLING-8435 > URL: https://issues.apache.org/jira/browse/SLING-8435 > Project: Sling > Issue Type: Task > Components: Karaf >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Karaf Features 0.2.0, Karaf Integration Tests 0.2.0, > Karaf Distribution 0.2.0, Karaf Launchpad Integration Tests (Oak Tar) 0.0.2 > > > Sling Health Check moved to Felix: > https://felix.apache.org/documentation/subprojects/apache-felix-healthchecks.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-8443) Simplify journal_available metric
[ https://issues.apache.org/jira/browse/SLING-8443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret reassigned SLING-8443: - Assignee: Timothee Maret > Simplify journal_available metric > - > > Key: SLING-8443 > URL: https://issues.apache.org/jira/browse/SLING-8443 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Affects Versions: Content Distribution Journal Core 0.1.0 >Reporter: Christian Schneider >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Core 0.1.2 > > Time Spent: 10m > Remaining Estimate: 0h > > The current implementation creates a Gauge service "by hand" using the OSGi > API. It also uses the marker service to detect the journal availability which > requires an optional dynamic service reference. > I propose to change this to a DS component and uses a simple reference to > JournalAvailableChecker which is in the same package anyway. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8435) Provide Felix Health Check feature
[
https://issues.apache.org/jira/browse/SLING-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850075#comment-16850075
]
Oliver Lietz commented on SLING-8435:
-
Excluding
{{org.apache.sling.launchpad.webapp.integrationtest.teleporter.ServicesPresentTest}}
(using now missing {{org.apache.sling.hc.api.execution.HealthCheckExecutor}})
from {{org.apache.sling.karaf-launchpad-oak-tar-integration-tests}}.
> Provide Felix Health Check feature
> --
>
> Key: SLING-8435
> URL: https://issues.apache.org/jira/browse/SLING-8435
> Project: Sling
> Issue Type: Task
> Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Karaf Features 0.2.0, Karaf Integration Tests 0.2.0,
> Karaf Distribution 0.2.0
>
>
> Sling Health Check moved to Felix:
> https://felix.apache.org/documentation/subprojects/apache-felix-healthchecks.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-8435) Provide Felix Health Check feature
[ https://issues.apache.org/jira/browse/SLING-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz updated SLING-8435: Description: Sling Health Check moved to Felix: https://felix.apache.org/documentation/subprojects/apache-felix-healthchecks.html > Provide Felix Health Check feature > -- > > Key: SLING-8435 > URL: https://issues.apache.org/jira/browse/SLING-8435 > Project: Sling > Issue Type: Task > Components: Karaf >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Karaf Features 0.2.0, Karaf Integration Tests 0.2.0, > Karaf Distribution 0.2.0 > > > Sling Health Check moved to Felix: > https://felix.apache.org/documentation/subprojects/apache-felix-healthchecks.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SLING-8432) Provide support for running the Pax Exam tests on Java 9 and higher
[
https://issues.apache.org/jira/browse/SLING-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848393#comment-16848393
]
Oliver Lietz edited comment on SLING-8432 at 5/28/19 7:09 PM:
--
[~radu.cotescu], I will revert your single commit due to several points:
* Code is unnecessarily complicated and hard to read
* Silent update to Pax Exam 4.13.1
* Silent switch to Sling Bundle Parent 35
* Silent drop of Java 7 support (-not necessary- SLING-8440, enforced by SBP
35)
* Bundle versions in Java code (instead {{SlingVersionResolver}} via
{{SlingVersionResolver.hbs}})
Please create a dedicated JIRA task and commit for each unrelated change in the
future and keep this module clean.
was (Author: olli):
[~radu.cotescu], I will revert your single commit due to several points:
* Code is unnecessarily complicated and hard to read
* Silent update to Pax Exam 4.13.1
* Silent switch to Sling Bundle Parent 35
* Silent drop of Java 7 support (not necessary)
* Bundle versions in Java code (instead {{SlingVersionResolver}} via
{{SlingVersionResolver.hbs}})
Please create a dedicated JIRA task and commit for each unrelated change in the
future and keep this module clean.
> Provide support for running the Pax Exam tests on Java 9 and higher
> ---
>
> Key: SLING-8432
> URL: https://issues.apache.org/jira/browse/SLING-8432
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Reporter: Radu Cotescu
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 3.0.0
>
>
> The current setup of the PaxExam module does not allow running Pax tests on
> Java 9 and above.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8440) Use Sling Bundle Parent 35
[
https://issues.apache.org/jira/browse/SLING-8440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-8440.
-
Resolution: Done
> Use Sling Bundle Parent 35
> --
>
> Key: SLING-8440
> URL: https://issues.apache.org/jira/browse/SLING-8440
> Project: Sling
> Issue Type: Task
> Components: Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 3.0.0
>
>
> Switch to new Sling Bundle Parent, set {{sling.java.version}} to 8 and clean
> up bnd file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-8440) Use Sling Bundle Parent 35
[
https://issues.apache.org/jira/browse/SLING-8440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-8440:
Description: Switch to new Sling Bundle Parent, set {{sling.java.version}}
to 8 and clean up bnd file. (was: Switch to new Sling Bundle Parent and clean
up bnd file.)
> Use Sling Bundle Parent 35
> --
>
> Key: SLING-8440
> URL: https://issues.apache.org/jira/browse/SLING-8440
> Project: Sling
> Issue Type: Task
> Components: Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 3.0.0
>
>
> Switch to new Sling Bundle Parent, set {{sling.java.version}} to 8 and clean
> up bnd file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (SLING-8440) Use Sling Bundle Parent 35
[ https://issues.apache.org/jira/browse/SLING-8440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz reopened SLING-8440: - ??The value of the "sling.java.version" property should comply with the following pattern: ^(8|9|1[0-9])$.?? > Use Sling Bundle Parent 35 > -- > > Key: SLING-8440 > URL: https://issues.apache.org/jira/browse/SLING-8440 > Project: Sling > Issue Type: Task > Components: Testing >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Testing PaxExam 3.0.0 > > > Switch to new Sling Bundle Parent and clean up bnd file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [sling-org-apache-sling-servlet-helpers] rmcdouga commented on a change in pull request #6: Added support for simulating HTML forms (including file uploads)…
rmcdouga commented on a change in pull request #6: Added support for simulating HTML forms (including file uploads)… URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288219155 ## File path: src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java ## @@ -82,7 +83,7 @@ private final ResourceResolver resourceResolver; private final RequestPathInfo requestPathInfo; private Map attributeMap = new HashMap(); -private Map parameterMap = new LinkedHashMap(); +private Map parameterMap = new LinkedHashMap<>(); Review comment: I wondered about this too. The MockRequestParameterMap uses a HashMap while this class uses a LinkedHashMap. I was afraid to change that since I wasn't sure if ordering of parameters is important (I haven't looked at the Sling code to see what kind of behaviour it has). My assumption was that the original author chose a LinkedHashMap over HashMap for a reason. Do you have any idea on why? If I implemented this, should I make the MockRequestParameterMap use a LinkedHashMap instead? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [sling-org-apache-sling-scripting-sightly-testing] raducotescu opened a new pull request #3: SLING-6779 - The HTL compiler and Maven Plugin should warn when using potentially invalid options
raducotescu opened a new pull request #3: SLING-6779 - The HTL compiler and Maven Plugin should warn when using potentially invalid options URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/pull/3 * added all known expression and plugin options to the compiler * added the possibility to configure the compiler to ignore certain additional options * enhanced the HTL Script Engine to allow it to configure the compiler for additional options * enhanced the HTL Maven Plugin to rely on a new configuration option to pass down additional options to the compiler This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [sling-htl-maven-plugin] raducotescu opened a new pull request #1: SLING-6779 - The HTL compiler and Maven Plugin should warn when using potentially invalid options
raducotescu opened a new pull request #1: SLING-6779 - The HTL compiler and Maven Plugin should warn when using potentially invalid options URL: https://github.com/apache/sling-htl-maven-plugin/pull/1 * added all known expression and plugin options to the compiler * added the possibility to configure the compiler to ignore certain additional options * enhanced the HTL Script Engine to allow it to configure the compiler for additional options * enhanced the HTL Maven Plugin to rely on a new configuration option to pass down additional options to the compiler This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (SLING-6779) The HTL compiler and Maven Plugin should warn when using potentially invalid options
[
https://issues.apache.org/jira/browse/SLING-6779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-6779:
Fix Version/s: Scripting HTL Testing 1.0.18-1.4.0
> The HTL compiler and Maven Plugin should warn when using potentially invalid
> options
>
>
> Key: SLING-6779
> URL: https://issues.apache.org/jira/browse/SLING-6779
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting HTL Compiler 1.0.0, HTL Maven Plugin 1.0.6
>Reporter: Feike Visser
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Compiler 1.2.0-1.4.0, HTL Maven Plugin
> 1.3.0-1.4.0, Scripting HTL Engine 1.2.0-1.4.0, Scripting HTL Testing
> 1.0.18-1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I have the following code
> {code}
> ${currentPage.title @ contex = 'scriptString'}
> {code}
> No warning or error is given for the wrong option @ contex
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [sling-org-apache-sling-servlet-helpers] rmcdouga commented on a change in pull request #6: Added support for simulating HTML forms (including file uploads)…
rmcdouga commented on a change in pull request #6: Added support for simulating
HTML forms (including file uploads)…
URL:
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288212802
##
File path:
src/test/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequestTest.java
##
@@ -316,6 +317,47 @@ public void testRequestParameter() throws Exception {
assertEquals("param1",
((MockRequestParameter)request.getRequestParameter("param1")).getName());
}
+@Test
+public void testFormRequestParameters() throws Exception {
Review comment:
I had one such case (param4). I could add additional cases for the other
addRequestParameter() methods. I didn't at the time time because I thought the
test would be redundant. If I had created them, then I would have spotted the
issue that was highlighted by the consolidated helper function. Now that the
redundant code is consolidated however, I'm not sure if the extra tests are
required (since they all just call that same helper function).
Let me know what you think. I'm inclined not to want to do this as the
extra tests are mostly just calling the same code (only one line difference
between them). That one line difference is tested by the single value tests.
Having said that, if you feel differently, I don't mind adding them in.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-servlet-helpers] rmcdouga commented on a change in pull request #6: Added support for simulating HTML forms (including file uploads)…
rmcdouga commented on a change in pull request #6: Added support for simulating
HTML forms (including file uploads)…
URL:
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288209235
##
File path:
src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java
##
@@ -516,6 +529,36 @@ public RequestParameterMap getRequestParameterMap() {
return params;
}
+public void addRequestParameter(String name, String value) {
+ if (this.parameterMap.containsKey(name)) {
+ List list =
Arrays.asList(this.parameterMap.get(name));
Review comment:
Done. This was a particularly good idea as one of the versions was correct
but the other two had a bug in them. Consolidating them made the bug obvious.
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-servlet-helpers] rmcdouga commented on a change in pull request #6: Added support for simulating HTML forms (including file uploads)…
rmcdouga commented on a change in pull request #6: Added support for simulating
HTML forms (including file uploads)…
URL:
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288197092
##
File path:
src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java
##
@@ -516,6 +529,36 @@ public RequestParameterMap getRequestParameterMap() {
return params;
}
+public void addRequestParameter(String name, String value) {
Review comment:
Done. Update to PR is in progress.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-servlet-helpers] rmcdouga commented on a change in pull request #6: Added support for simulating HTML forms (including file uploads)…
rmcdouga commented on a change in pull request #6: Added support for simulating
HTML forms (including file uploads)…
URL:
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288193058
##
File path:
src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java
##
@@ -516,6 +529,36 @@ public RequestParameterMap getRequestParameterMap() {
return params;
}
+public void addRequestParameter(String name, String value) {
+ if (this.parameterMap.containsKey(name)) {
Review comment:
I've changed the settings in my IDE (Eclipse) and reformatted the whole
file. This has caused some incidental changes (putting spaces after commas,
etc.) that I think are positive so I have left them in. The only thing that
might be an issue is that my line wrapping is at 180 chars. A couple of lines
that were previously split are now merged to one line. Is that a problem? I
assume there is a style guide somewhere. If you could point me to it, I will
set my formatting settings appropriately.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (SLING-8443) Simplify journal_available metric
Christian Schneider created SLING-8443: -- Summary: Simplify journal_available metric Key: SLING-8443 URL: https://issues.apache.org/jira/browse/SLING-8443 Project: Sling Issue Type: Improvement Components: Content Distribution Affects Versions: Content Distribution Journal Core 0.1.0 Reporter: Christian Schneider Fix For: Content Distribution Journal Core 0.1.2 The current implementation creates a Gauge service "by hand" using the OSGi API. It also uses the marker service to detect the journal availability which requires an optional dynamic service reference. I propose to change this to a DS component and uses a simple reference to JournalAvailableChecker which is in the same package anyway. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-6779) The HTL compiler and Maven Plugin should warn when using potentially invalid options
[
https://issues.apache.org/jira/browse/SLING-6779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-6779:
Fix Version/s: Scripting HTL Engine 1.2.0-1.4.0
> The HTL compiler and Maven Plugin should warn when using potentially invalid
> options
>
>
> Key: SLING-6779
> URL: https://issues.apache.org/jira/browse/SLING-6779
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting HTL Compiler 1.0.0, HTL Maven Plugin 1.0.6
>Reporter: Feike Visser
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Compiler 1.2.0-1.4.0, HTL Maven Plugin
> 1.3.0-1.4.0, Scripting HTL Engine 1.2.0-1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I have the following code
> {code}
> ${currentPage.title @ contex = 'scriptString'}
> {code}
> No warning or error is given for the wrong option @ contex
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [RT] Remove dependency to launchpad starter api
On Tue, 2019-05-28 at 14:10 +0200, Carsten Ziegeler wrote: > > > For example the webconsole security provider has such a > > > dependency. > > > In > > > that case it covers the case of a buggy repository > > > implementation...which is actually a workaround. So I think we > > > can > > > simply remove that dependency without a replacement there > > > completely. > > > > Well, if we can remove it and nothing breaks, we're definitely good > > here :-) > > > > The repository implementation might still be buggy and register the > repository service although the repository is still not usable. > That's why we initially added the dependency. Clearly this is a > workaround, the workaround is in place for years now and it seems to > be > time to remove it I think we should be in a position to fix whatever made the repository buggy, so +1 to removing it. Thanks, Robert
[jira] [Assigned] (SLING-8424) Enhance Request Parameter Handling to Emulate HTML Forms
[ https://issues.apache.org/jira/browse/SLING-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert reassigned SLING-8424: - Assignee: Stefan Seifert Fix Version/s: Servlet Helpers 1.2.0 thanks, i've added some code review comments to the PR. > Enhance Request Parameter Handling to Emulate HTML Forms > > > Key: SLING-8424 > URL: https://issues.apache.org/jira/browse/SLING-8424 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Servlet Helpers 1.1.10 >Reporter: Rob McDougall >Assignee: Stefan Seifert >Priority: Major > Fix For: Servlet Helpers 1.2.0 > > > Currently, the MockSlingHttpServletRequest class is set up to mock query > parameters only. It assumes that all request parameters are Strings. It > does not track things like contentType of each parameter. > I've prototyped some changes to the code in order to allow the mocking of > HTML form submissions (including file uploads). I'd like to submit a PR with > those changes. > I'm raising this issue for discussion before generating the PR in case there > is any other ongoing work that I'm not aware of or if there are objections to > the idea. > If you want to preview the changes ahead of the PR, they are in a fork of the > code available here: > [https://github.com/rmcdouga/sling-org-apache-sling-servlet-helpers] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [sling-org-apache-sling-servlet-helpers] stefanseifert commented on a change in pull request #6: Added support for simulating HTML forms (including file uploads)…
stefanseifert commented on a change in pull request #6: Added support for
simulating HTML forms (including file uploads)…
URL:
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288082699
##
File path:
src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java
##
@@ -516,6 +529,36 @@ public RequestParameterMap getRequestParameterMap() {
return params;
}
+public void addRequestParameter(String name, String value) {
Review comment:
please add a bit of javadocs two this three new addRequestParameter methods
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-servlet-helpers] stefanseifert commented on a change in pull request #6: Added support for simulating HTML forms (including file uploads)…
stefanseifert commented on a change in pull request #6: Added support for
simulating HTML forms (including file uploads)…
URL:
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288085624
##
File path:
src/test/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequestTest.java
##
@@ -316,6 +317,47 @@ public void testRequestParameter() throws Exception {
assertEquals("param1",
((MockRequestParameter)request.getRequestParameter("param1")).getName());
}
+@Test
+public void testFormRequestParameters() throws Exception {
Review comment:
maybe add a use case where a parameter with multiple values is stored using
the new addRequestParameter methods.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-servlet-helpers] stefanseifert commented on a change in pull request #6: Added support for simulating HTML forms (including file uploads)…
stefanseifert commented on a change in pull request #6: Added support for
simulating HTML forms (including file uploads)…
URL:
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288082011
##
File path:
src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java
##
@@ -516,6 +529,36 @@ public RequestParameterMap getRequestParameterMap() {
return params;
}
+public void addRequestParameter(String name, String value) {
+ if (this.parameterMap.containsKey(name)) {
Review comment:
here (and in other lines) are tabs used instead of spaces.
please make sure to format your editor to use 4 spaces instead of tabs and
reformat your changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-servlet-helpers] stefanseifert commented on a change in pull request #6: Added support for simulating HTML forms (including file uploads)…
stefanseifert commented on a change in pull request #6: Added support for
simulating HTML forms (including file uploads)…
URL:
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288084260
##
File path:
src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java
##
@@ -516,6 +529,36 @@ public RequestParameterMap getRequestParameterMap() {
return params;
}
+public void addRequestParameter(String name, String value) {
+ if (this.parameterMap.containsKey(name)) {
+ List list =
Arrays.asList(this.parameterMap.get(name));
Review comment:
this code is redundant across all three methods of addRequestParameter -
maybe put it in one helper method?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-servlet-helpers] stefanseifert commented on a change in pull request #6: Added support for simulating HTML forms (including file uploads)…
stefanseifert commented on a change in pull request #6: Added support for simulating HTML forms (including file uploads)… URL: https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288084932 ## File path: src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java ## @@ -82,7 +83,7 @@ private final ResourceResolver resourceResolver; private final RequestPathInfo requestPathInfo; private Map attributeMap = new HashMap(); -private Map parameterMap = new LinkedHashMap(); +private Map parameterMap = new LinkedHashMap<>(); Review comment: maybe we can directly use MockRequestParameterMap here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (SLING-8442) Remove dependency from launchpad starter api
[ https://issues.apache.org/jira/browse/SLING-8442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8442. - Resolution: Fixed Removed in rev .1a69cca Also updated the parent pom to 35 and moved to bnd maven plugin > Remove dependency from launchpad starter api > > > Key: SLING-8442 > URL: https://issues.apache.org/jira/browse/SLING-8442 > Project: Sling > Issue Type: Task > Components: Extensions >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Web Console Security Provider 1.2.2 > > > The webconsole security provider has a dependency on the launchpad api which > is only provided if launchpad is used for starting the OSGi application. It > is not available standalone. > Here it covers the case of a buggy repository implementation...which is > actually a workaround. So I think we can simply remove that dependency > without a replacement -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8432) Provide support for running the Pax Exam tests on Java 9 and higher
[ https://issues.apache.org/jira/browse/SLING-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849679#comment-16849679 ] Oliver Lietz commented on SLING-8432: - [~radu.cotescu], please see [a63b64c|https://github.com/apache/sling-org-apache-sling-testing-paxexam/commit/a63b64ced730b9dfd9ba3ae6b9e2ecceb400d840]. > Provide support for running the Pax Exam tests on Java 9 and higher > --- > > Key: SLING-8432 > URL: https://issues.apache.org/jira/browse/SLING-8432 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Radu Cotescu >Assignee: Oliver Lietz >Priority: Major > Fix For: Testing PaxExam 3.0.0 > > > The current setup of the PaxExam module does not allow running Pax tests on > Java 9 and above. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8442) Remove dependency from launchpad starter api
Carsten Ziegeler created SLING-8442: --- Summary: Remove dependency from launchpad starter api Key: SLING-8442 URL: https://issues.apache.org/jira/browse/SLING-8442 Project: Sling Issue Type: Task Components: Extensions Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Web Console Security Provider 1.2.2 The webconsole security provider has a dependency on the launchpad api which is only provided if launchpad is used for starting the OSGi application. It is not available standalone. Here it covers the case of a buggy repository implementation...which is actually a workaround. So I think we can simply remove that dependency without a replacement -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8441) Update Pax Exam to 4.13.1
[ https://issues.apache.org/jira/browse/SLING-8441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-8441. - Resolution: Done > Update Pax Exam to 4.13.1 > - > > Key: SLING-8441 > URL: https://issues.apache.org/jira/browse/SLING-8441 > Project: Sling > Issue Type: Task > Components: Testing >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Testing PaxExam 3.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8440) Use Sling Bundle Parent 35
[ https://issues.apache.org/jira/browse/SLING-8440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-8440. - Resolution: Done > Use Sling Bundle Parent 35 > -- > > Key: SLING-8440 > URL: https://issues.apache.org/jira/browse/SLING-8440 > Project: Sling > Issue Type: Task > Components: Testing >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Testing PaxExam 3.0.0 > > > Switch to new Sling Bundle Parent and clean up bnd file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8440) Use Sling Bundle Parent 35
[ https://issues.apache.org/jira/browse/SLING-8440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz updated SLING-8440: Description: Switch to new Sling Bundle Parent and clean up bnd file. > Use Sling Bundle Parent 35 > -- > > Key: SLING-8440 > URL: https://issues.apache.org/jira/browse/SLING-8440 > Project: Sling > Issue Type: Task > Components: Testing >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Testing PaxExam 3.0.0 > > > Switch to new Sling Bundle Parent and clean up bnd file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8432) Provide support for running the Pax Exam tests on Java 9 and higher
[ https://issues.apache.org/jira/browse/SLING-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz updated SLING-8432: Summary: Provide support for running the Pax Exam tests on Java 9 and higher (was: Provide support for running the Pax tests on Java 9 and higher) > Provide support for running the Pax Exam tests on Java 9 and higher > --- > > Key: SLING-8432 > URL: https://issues.apache.org/jira/browse/SLING-8432 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Radu Cotescu >Assignee: Oliver Lietz >Priority: Major > Fix For: Testing PaxExam 3.0.0 > > > The current setup of the PaxExam module does not allow running Pax tests on > Java 9 and above. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8440) Use Sling Bundle Parent 35
Oliver Lietz created SLING-8440: --- Summary: Use Sling Bundle Parent 35 Key: SLING-8440 URL: https://issues.apache.org/jira/browse/SLING-8440 Project: Sling Issue Type: Task Components: Testing Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Testing PaxExam 3.0.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8441) Update Pax Exam to 4.13.1
Oliver Lietz created SLING-8441: --- Summary: Update Pax Exam to 4.13.1 Key: SLING-8441 URL: https://issues.apache.org/jira/browse/SLING-8441 Project: Sling Issue Type: Task Components: Testing Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Testing PaxExam 3.0.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SLING-8432) Provide support for running the Pax tests on Java 9 and higher
[
https://issues.apache.org/jira/browse/SLING-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848393#comment-16848393
]
Oliver Lietz edited comment on SLING-8432 at 5/28/19 12:14 PM:
---
[~radu.cotescu], I will revert your single commit due to several points:
* Code is unnecessarily complicated and hard to read
* Silent update to Pax Exam 4.13.1
* Silent switch to Sling Bundle Parent 35
* Silent drop of Java 7 support (not necessary)
* Bundle versions in Java code (instead {{SlingVersionResolver}} via
{{SlingVersionResolver.hbs}})
Please create a dedicated JIRA task and commit for each unrelated change in the
future and keep this module clean.
was (Author: olli):
* Do not put bundle versions in Java code but {{SlingVersionResolver}} via
{{SlingVersionResolver.hbs}}
* ...
> Provide support for running the Pax tests on Java 9 and higher
> --
>
> Key: SLING-8432
> URL: https://issues.apache.org/jira/browse/SLING-8432
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Reporter: Radu Cotescu
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 3.0.0
>
>
> The current setup of the PaxExam module does not allow running Pax tests on
> Java 9 and above.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [RT] Remove dependency to launchpad starter api
Hi Robert, Robert Munteanu wrote Hi Carsten, On Tue, 2019-05-28 at 09:41 +0200, Carsten Ziegeler wrote: Hi, we have some bundles that currently depend on the launchpad starter api, which provides a way to detect whether an instance is finished with starting. This was our first attempt to solve that problem, with the new Felix based solution we should probably move away from that approach. Especially as the launchpad starter is currently only supported if you're using launchpad to start your instance. Just to make sure I understand, is the Felix-based solution based on the Health Checks? Yes Therefore we should probably revisit this dependency in every module and either remove or replace it. For example the webconsole security provider has such a dependency. In that case it covers the case of a buggy repository implementation...which is actually a workaround. So I think we can simply remove that dependency without a replacement there completely. Well, if we can remove it and nothing breaks, we're definitely good here :-) The repository implementation might still be buggy and register the repository service although the repository is still not usable. That's why we initially added the dependency. Clearly this is a workaround, the workaround is in place for years now and it seems to be time to remove it Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [RT] Remove dependency to launchpad starter api
Hi Carsten, On Tue, 2019-05-28 at 09:41 +0200, Carsten Ziegeler wrote: > Hi, > > we have some bundles that currently depend on the launchpad starter > api, > which provides a way to detect whether an instance is finished with > starting. This was our first attempt to solve that problem, with the > new > Felix based solution we should probably move away from that approach. > Especially as the launchpad starter is currently only supported if > you're using launchpad to start your instance. Just to make sure I understand, is the Felix-based solution based on the Health Checks? > > Therefore we should probably revisit this dependency in every module > and > either remove or replace it. > > For example the webconsole security provider has such a dependency. > In > that case it covers the case of a buggy repository > implementation...which is actually a workaround. So I think we can > simply remove that dependency without a replacement there completely. Well, if we can remove it and nothing breaks, we're definitely good here :-) Thanks, Robert
[jira] [Resolved] (SLING-8420) Converter generates buggy vault packages
[ https://issues.apache.org/jira/browse/SLING-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi resolved SLING-8420. --- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/4 > Converter generates buggy vault packages > > > Key: SLING-8420 > URL: https://issues.apache.org/jira/browse/SLING-8420 > Project: Sling > Issue Type: Bug > Components: Feature Model >Reporter: Dominik Süß >Assignee: Simone Tripodi >Priority: Critical > Time Spent: 20m > Remaining Estimate: 0h > > The way the converter generates the empty hull packages for the flattened > container package is flawed as vault doesn't handle the filters correctly. > Vault expects the structures that are covered in the root paths of the > workspacefilter to be present otherwise the importmode = merge is getting > ignored. > To avoid this issue I suggest to set a global filter to the root path that > excludes everything and has importmode merge - this will not create any > significant snapshot packages even if manually installed and won't be > misinterpreted by vault. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-8420) Converter generates buggy vault packages
[ https://issues.apache.org/jira/browse/SLING-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi reassigned SLING-8420: - Assignee: Simone Tripodi > Converter generates buggy vault packages > > > Key: SLING-8420 > URL: https://issues.apache.org/jira/browse/SLING-8420 > Project: Sling > Issue Type: Bug > Components: Feature Model >Reporter: Dominik Süß >Assignee: Simone Tripodi >Priority: Critical > Time Spent: 20m > Remaining Estimate: 0h > > The way the converter generates the empty hull packages for the flattened > container package is flawed as vault doesn't handle the filters correctly. > Vault expects the structures that are covered in the root paths of the > workspacefilter to be present otherwise the importmode = merge is getting > ignored. > To avoid this issue I suggest to set a global filter to the root path that > excludes everything and has importmode merge - this will not create any > significant snapshot packages even if manually installed and won't be > misinterpreted by vault. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8439) Add VM Options for Java 9 and up
[ https://issues.apache.org/jira/browse/SLING-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-8439. - Resolution: Done > Add VM Options for Java 9 and up > > > Key: SLING-8439 > URL: https://issues.apache.org/jira/browse/SLING-8439 > Project: Sling > Issue Type: Task > Components: Karaf >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Karaf Integration Tests 0.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8439) Add VM Options for Java 9 and up
Oliver Lietz created SLING-8439: --- Summary: Add VM Options for Java 9 and up Key: SLING-8439 URL: https://issues.apache.org/jira/browse/SLING-8439 Project: Sling Issue Type: Task Components: Karaf Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Karaf Integration Tests 0.2.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[RT] Remove dependency to launchpad starter api
Hi, we have some bundles that currently depend on the launchpad starter api, which provides a way to detect whether an instance is finished with starting. This was our first attempt to solve that problem, with the new Felix based solution we should probably move away from that approach. Especially as the launchpad starter is currently only supported if you're using launchpad to start your instance. Therefore we should probably revisit this dependency in every module and either remove or replace it. For example the webconsole security provider has such a dependency. In that case it covers the case of a buggy repository implementation...which is actually a workaround. So I think we can simply remove that dependency without a replacement there completely. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
