Re: JUnit5 Jupiter support with Arquillian

2021-03-08 Thread Bruno Baptista

Thanks Jean-Louis, Richard!


On 08/03/21 08:44, Richard Zowalla wrote:

Hi all,

yes, I did some work related to JUnit5 for the old (legacy) code (via
InitialContext, see [1]), which shouldnt be used anymore but hinders
some users to migrate to JUnit5 (who are using the legacy approach).
This PR is merged into master and will be available with the next
release.

However, this does not necessarily apply to Arquillian /
ApplicationComposer code.

I might find some time looking at Arquillian / ApplicationComposer code
related to JUnit5. Afaik, Arquillian did not support JUnit5 for quite a
long time. However, since 1.7.0.Alpha5 [2], it should be included, so
we could definitley take a look at it and check, if we need to adjust
something. However, there is no 1.7.0 release available yet.

Gruss
Richard

[1] https://github.com/apache/tomee/pull/759
[2]
https://github.com/arquillian/arquillian-core/issues/137#issuecomment-536316718


Am Montag, den 08.03.2021, 09:18 +0100 schrieb Jean-Louis Monteiro:

Hi Bruno,

I think Richard worked on it.
Not sure about the status, but as far as I can recall, he created a
ticket
(TomEE-2966: JUnit5 OpenEJB Extension Module) and a PR for it.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Sat, Mar 6, 2021 at 8:11 PM brunobat  wrote:


Hi All!
2 years have passed. Any news about this?
Can we now test with Arquillian and TomEE with JUnit 5?
Cheers
Bruno Baptista
https://twitter.com/brunobat_



--
Sent from:
http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html



Re: JUnit5 Jupiter support with Arquillian

2019-03-11 Thread Bruno Baptista

Thanks for the help Thomas, Jean-Louis and Alex!

Bruno Baptista
https://twitter.com/brunobat_


On 11/03/19 18:32, Alex Soto wrote:

No, it is not supported.

Missatge de Bruno Baptista  del dia dl., 11 de març
2019 a les 19:28:


Hi Jean-Louis,

I'm hacking a comparison between multiple frameworks and all apart from
Arquillian seem to support JUnit 5 already.

I was hopping to be missing something, but it seems it's not supported yet.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 11/03/19 18:22, Jean-Louis Monteiro wrote:

Hey Bruno,

I don't know and did not try yet.
What does it bring out of curiosity?
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Mar 11, 2019 at 7:15 PM Bruno Baptista 

wrote:

Hi Folks,

Any idea if we can run tests using the Jupiter engine of JUnit 5 with
Arquillian on TomEE?

Has anyone tried it?

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_







Re: JUnit5 Jupiter support with Arquillian

2019-03-11 Thread Bruno Baptista

Hi Jean-Louis,

I'm hacking a comparison between multiple frameworks and all apart from 
Arquillian seem to support JUnit 5 already.


I was hopping to be missing something, but it seems it's not supported yet.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 11/03/19 18:22, Jean-Louis Monteiro wrote:

Hey Bruno,

I don't know and did not try yet.
What does it bring out of curiosity?
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Mar 11, 2019 at 7:15 PM Bruno Baptista  wrote:


Hi Folks,

Any idea if we can run tests using the Jupiter engine of JUnit 5 with
Arquillian on TomEE?

Has anyone tried it?

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_





JUnit5 Jupiter support with Arquillian

2019-03-11 Thread Bruno Baptista

Hi Folks,

Any idea if we can run tests using the Jupiter engine of JUnit 5 with 
Arquillian on TomEE?


Has anyone tried it?

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Apache TomEE channel in the-asf.slack.com

2019-03-01 Thread Bruno Baptista
Hi folks,
Can you please send me an invite too?
Cheers

Bruno Baptista
http://twitter.com/brunobat_

> On 1 Mar 2019, at 19:52, Ivan Junckes Filho  wrote:
> 
> It seems it forces you to have a apache email or to be invited. I can't
> join, can anyone invite me?
> 
>> On Fri, Mar 1, 2019 at 4:51 PM Daniel Cunha  wrote:
>> 
>> Hi Gabriel,
>> 
>> Yes!
>> 
>> Em sex, 1 de mar de 2019 às 16:48, Gabriel Ferreira 
>> escreveu:
>> 
>>> Cool, can everyone on the list participate?
>>> 
>>> Em sex, 1 de mar de 2019 às 16:30, David Blevins <
>> david.blev...@gmail.com>
>>> escreveu:
>>> 
>>>> Some time ago even the ASF Infra team stopped using IRC.  They now use
>>>> Slack and there is an "official" ASF Slack group.  I asked if it was ok
>>> if
>>>> projects could create themselves a channel and they said, "sure!"
>>>> 
>>>> Here it is!
>>>> 
>>>> - https://the-asf.slack.com/messages/CGN2PPR55
>>>> 
>>>> I invite everyone to jump in.  I explicitly caution, however, you must
>>>> understand this one critical directive of The Apache Way:
>>>> 
>>>> - "If it didn't happen on the dev list, it didn't happen."
>>>> 
>>>> This means you can never say "Oh we talked about that on slack and
>>> decided
>>>> x."  All Slack conversations of any substance need to be brought to the
>>> dev
>>>> list.
>>>> 
>>>> WARNING: If you are visible for weeks on the slack channel and
>> invisible
>>>> for weeks on the dev list, you will be removed from the slack channel.
>>>> 
>>>> 
>>>> --
>>>> David Blevins
>>>> http://twitter.com/dblevins
>>>> http://www.tomitribe.com
>>>> 
>>>> 
>>> 
>> 
>> 
>> --
>> Daniel "soro" Cunha
>> https://twitter.com/dvlc_
>> 


Re: Workshop on Fault Tolerance, Thursday

2019-02-21 Thread Bruno Baptista

Thanks everyone who joined,

Here are the slides:

https://docs.google.com/presentation/d/1pYqoYy4wQSRiv30gtQJ7dzq3qFbaqNzLhb9UrD4jJHw/edit?usp=sharing

See you next time!

Bruno Baptista
https://twitter.com/brunobat_


On 21/02/19 16:02, Bruno Baptista wrote:

Hi All,

The Fault Tolerance Workshop will take place in 1h, at 17h WET here:

https://tomitribe.zoom.us/j/4962297194

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 18/02/19 22:09, César Hernández Mendoza wrote:

thanks for the update Bruno and all the best in your workshop!

El lun., 18 feb. 2019 a las 10:04, Bruno Baptista ()
escribió:


Let's make it 17h WET.

Bruno Baptista
https://twitter.com/brunobat_


On 18/02/19 15:45, Bruno Baptista wrote:

Hi Folks,

I'm preparing a workshop about MP Fault Tolerance.

The idea is to go through some examples, explain the TCK, how to use
it and the work being developed in there.

I'm planing to do this on Thursday, 17h30 WET.

Will publish the hangout link on the day of the event.

Anyone can join!

Cheers.





Missing the M2 release on the site

2019-02-18 Thread Bruno Baptista

Hi Folks,

This is a dev follow up on the users email with subject "TomEE 8.0.0-M2 
no more available on download site ?"


The download-ng page is generated and it might have been written 
manually. Now, the generator was executed and replaced the M2 contents.


Were the M2 release changes made directly on the site?

Cheers.

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Workshop on Fault Tolerance, Thursday

2019-02-18 Thread Bruno Baptista

Let's make it 17h WET.

Bruno Baptista
https://twitter.com/brunobat_


On 18/02/19 15:45, Bruno Baptista wrote:

Hi Folks,

I'm preparing a workshop about MP Fault Tolerance.

The idea is to go through some examples, explain the TCK, how to use 
it and the work being developed in there.


I'm planing to do this on Thursday, 17h30 WET.

Will publish the hangout link on the day of the event.

Anyone can join!

Cheers.



Workshop on Fault Tolerance, Thursday

2019-02-18 Thread Bruno Baptista

Hi Folks,

I'm preparing a workshop about MP Fault Tolerance.

The idea is to go through some examples, explain the TCK, how to use it 
and the work being developed in there.


I'm planing to do this on Thursday, 17h30 WET.

Will publish the hangout link on the day of the event.

Anyone can join!

Cheers.

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Examples Missing README Files

2019-02-08 Thread Bruno Baptista

Hi Bogdan,

I've reviewed your PR and it looks good to go: 
https://github.com/apache/tomee/pull/383


Thanks very much!

Bruno Baptista
https://twitter.com/brunobat_


On 03/02/19 19:17, Bogdan Stirbat wrote:

Ok, thank you!

Bogdan

În dum., 3 feb. 2019 la 04:02, Roberto Cortez 
a scris:


Thank your for your PR. I’ll have a look later.

Sure. I’ve assigned the issue to you.

Cheers,
Roberto


On 2 Feb 2019, at 14:49, Bogdan Stirbat 

wrote:

Hi,

For the issue https://issues.apache.org/jira/browse/TOMEE-2375 I've

added a

pull request, https://github.com/apache/tomee/pull/383.

Can I work on https://issues.apache.org/jira/browse/TOMEE-2372?

Thanks,
Bogdan


În joi, 31 ian. 2019 la 17:28, Roberto Cortez



a scris:


Hi Bogdan and César,

Thank you for your availability. I’ve the tickets to the both of you.

Cheers,
Roberto


On 31 Jan 2019, at 15:18, César Hernández Mendoza <

cesargu...@gmail.com>

wrote:

Thanks for the email Roberto,

I can take https://jira.apache.org/jira/browse/TOMEE-2377, can some of

the

JIRA admins proceed to assign it to me, please.

El mié., 30 ene. 2019 a las 13:20, Bogdan Stirbat (<

bogdan.stir...@gmail.com>)

escribió:


Hi,

Can I pick https://issues.apache.org/jira/browse/TOMEE-2375 ?

Thanks,
Bogdan

În mie., 30 ian. 2019 la 17:43, Roberto Cortez


a scris:


Hi folks,

I was wondering if someone (maybe even more than 1 person), would

like

to

pick subtasks of this JIRA:
https://jira.apache.org/jira/browse/TOMEE-2369 <
https://jira.apache.org/jira/browse/TOMEE-2369>

And start adding README files to the example projects that are

missing

them?

Cheers,
Roberto


--
Atentamente:
César Hernández Mendoza.






Re: Feedback about TomEE-2465

2019-02-08 Thread Bruno Baptista

I don't, but one of the committers will sure do soon.

Thanks Salomon!

Bruno Baptista
https://twitter.com/brunobat_


On 08/02/19 12:04, Salomon wrote:

Great!
Can you assign me the ticket ? my username is : mayens

Le ven. 8 févr. 2019 à 12:59, Bruno Baptista  a écrit :


Sure, go for it!

Bruno Baptista
https://twitter.com/brunobat_


On 08/02/19 11:31, Salomon wrote:

Hi Bruno,

It works fine with TomEE 8. I made it work in TomEE 7.1.1 by applying the
same fixes of TomEE 8 in my local branch;
I can open a pull-request on it if you want.:)

Le ven. 8 févr. 2019 à 11:46, Bruno Baptista  a

écrit :

Saying this... Do you know if this same exception happens on TomEE 8?

It can be worked to TomEE 8 first. :)

Bruno Baptista
https://twitter.com/brunobat_


On 08/02/19 10:44, Bruno Baptista wrote:

Hi Salomon,

Thanks for the Jira!

I think that we should first focus our efforts in making TomEE 8
compatible with Java 11.

Some of that work can also be back-ported to the 7.1.* line and after
the TomEE 8 release there should be more time for that.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 07/02/19 21:46, Salomon wrote:

Hi guys,
I have opened this ticket TomEE-2465; It's about Java 11
compatibility with
Tomee 7.1.X
Can you please let me know your thoughts?
Thanks
Salomon



Re: Feedback about TomEE-2465

2019-02-08 Thread Bruno Baptista

Sure, go for it!

Bruno Baptista
https://twitter.com/brunobat_


On 08/02/19 11:31, Salomon wrote:

Hi Bruno,

It works fine with TomEE 8. I made it work in TomEE 7.1.1 by applying the
same fixes of TomEE 8 in my local branch;
I can open a pull-request on it if you want.:)

Le ven. 8 févr. 2019 à 11:46, Bruno Baptista  a écrit :


Saying this... Do you know if this same exception happens on TomEE 8?

It can be worked to TomEE 8 first. :)

Bruno Baptista
https://twitter.com/brunobat_


On 08/02/19 10:44, Bruno Baptista wrote:

Hi Salomon,

Thanks for the Jira!

I think that we should first focus our efforts in making TomEE 8
compatible with Java 11.

Some of that work can also be back-ported to the 7.1.* line and after
the TomEE 8 release there should be more time for that.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 07/02/19 21:46, Salomon wrote:

Hi guys,
I have opened this ticket TomEE-2465; It's about Java 11
compatibility with
Tomee 7.1.X
Can you please let me know your thoughts?
Thanks
Salomon



Re: Feedback about TomEE-2465

2019-02-08 Thread Bruno Baptista

Saying this... Do you know if this same exception happens on TomEE 8?

It can be worked to TomEE 8 first. :)

Bruno Baptista
https://twitter.com/brunobat_


On 08/02/19 10:44, Bruno Baptista wrote:

Hi Salomon,

Thanks for the Jira!

I think that we should first focus our efforts in making TomEE 8 
compatible with Java 11.


Some of that work can also be back-ported to the 7.1.* line and after 
the TomEE 8 release there should be more time for that.


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 07/02/19 21:46, Salomon wrote:

Hi guys,
I have opened this ticket TomEE-2465; It's about Java 11 
compatibility with

Tomee 7.1.X
Can you please let me know your thoughts?
Thanks
Salomon



Re: Feedback about TomEE-2465

2019-02-08 Thread Bruno Baptista

Hi Salomon,

Thanks for the Jira!

I think that we should first focus our efforts in making TomEE 8 
compatible with Java 11.


Some of that work can also be back-ported to the 7.1.* line and after 
the TomEE 8 release there should be more time for that.


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 07/02/19 21:46, Salomon wrote:

Hi guys,
I have opened this ticket TomEE-2465; It's about Java 11 compatibility with
Tomee 7.1.X
Can you please let me know your thoughts?
Thanks
Salomon



Re: Examples with cloud providers

2019-02-07 Thread Bruno Baptista

Hi César,

I've updated the PR with your suggestions.

Thanks very much!

Bruno Baptista
https://twitter.com/brunobat_




On 05/02/19 21:05, César Hernández Mendoza wrote:

Thanks for the pointer,
Yes the app name must  be unique globally in Azure because it becomes a
subdomain of  azurewebsites.net/

I left some comment on the PR with my findings and observation.


El mar., 5 feb. 2019 a las 11:17, Bruno Baptista ()
escribió:


Thanks César!

I left some follow ups. I'm afraid the app name might need to be
globally unique to Azure...

Bruno Baptista
https://twitter.com/brunobat_


On 05/02/19 16:54, César Hernández Mendoza wrote:

Hi Bruno,
I left my review on the PR.

El lun., 4 feb. 2019 a las 9:46, Bruno Baptista ()
escribió:


Hi all,

The first example, for Azure is here:

https://github.com/apache/tomee/pull/378

if someone could review it it would be great!

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 09/01/19 22:37, Bruno Baptista wrote:

Yup, sounds good to me. Everything that helps the users to make happy
deployments should give a nice example.

Bruno Baptista
https://twitter.com/brunobat_


On 09/01/19 18:01, César Hernández Mendoza wrote:

sounds good Bruno, I think the credentials issue should be something
just
mentioned as a side note in each document.
Now that you trigger this thread, I also wonder if a TomEE on Docker
examples or tutorial would be also good to add.

El mié., 9 ene. 2019 a las 10:56, Bruno Baptista (
)

escribió:


Hi Folks,

I was thinking that we could create a series of examples or tutorials
that use demo apps with TomEE deployed in major cloud providers like
Azure, AWS, Oracle, etc.

I would like to start by Azure...

Examples have some challenges because we cannot actually produce

fully

working examples due to the need of credentials. So maybe a
documentation tutorial would be more appropriate.

What do you guys think?

--
Bruno Baptista
https://twitter.com/brunobat_







Re: Examples with cloud providers

2019-02-04 Thread Bruno Baptista

Hi all,

The first example, for Azure is here:

https://github.com/apache/tomee/pull/378

if someone could review it it would be great!

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 09/01/19 22:37, Bruno Baptista wrote:
Yup, sounds good to me. Everything that helps the users to make happy 
deployments should give a nice example.


Bruno Baptista
https://twitter.com/brunobat_


On 09/01/19 18:01, César Hernández Mendoza wrote:
sounds good Bruno, I think the credentials issue should be something 
just

mentioned as a side note in each document.
Now that you trigger this thread, I also wonder if a TomEE on Docker
examples or tutorial would be also good to add.

El mié., 9 ene. 2019 a las 10:56, Bruno Baptista ()
escribió:


Hi Folks,

I was thinking that we could create a series of examples or tutorials
that use demo apps with TomEE deployed in major cloud providers like
Azure, AWS, Oracle, etc.

I would like to start by Azure...

Examples have some challenges because we cannot actually produce fully
working examples due to the need of credentials. So maybe a
documentation tutorial would be more appropriate.

What do you guys think?

--
Bruno Baptista
https://twitter.com/brunobat_





Re: OpenJPA recursiveness issue

2019-02-01 Thread Bruno Baptista

Hi Ivan,

If it's JAX-RS related, if you are using Jackson, you might need to add 
a serialization exclusion condition to prevent the circular dependency loop.


An alternative would be to implement a custom deserializer:

|@JsonDeserialize||(using = ItemDeserializer.||class||)|
|public| |class| |Item {|
|||...|
|}|

This seems to be happening on the serialization side, though.

Take a look around here: 
https://stackoverflow.com/questions/17393812/json-and-java-circular-reference


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 01/02/19 11:37, Ivan Junckes Filho wrote:

I apologize for the misleading title, probably I was unsure what the issue
was. But seems that is more related to jaxrs json provider.

On Fri, Feb 1, 2019 at 4:35 AM Jean-Louis Monteiro 
wrote:


Hi Ivan,

I'm a bit confused because you are talking about OpenJPA in the object of
the email but you are saying that it happens when JAX RS wants to serialize
the payload.

In the stacktrace I can't see OpenJPA unless I'm blind :-)

Regarding the migration I understand you don't want to change things (at
least as much as possible).
Remember JBuss runs Hibernate as the JPA provider, so as a backup solution
you can also use Hibernate in TomEE, we support both.

Hope it helps

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Jan 31, 2019 at 11:38 PM Roberto Cortez

wrote:


Can’t remember exactly how OpenJPA handles the case, but should’t you
reach a point where the subDeparment is null? For you to have the
recursion, it seems that it might have a data circular dependency between
Departments.

Also, would it be possible for you to separate into an Entity model and a
DTO model? Entities tend to give a couple of issues when you try to use
them outside the scope of JPA. Most of the times is fine, but who haven’t
heard about  the LazyInitializationException in Hibernate? :)


On 31 Jan 2019, at 21:06, Ivan Junckes Filho 

wrote:

I am actually migrating some legacy code from JBoss to TomEE, I don't

know

why they took that decision. If there isn't a way around it I will

probably

change that. I just don't know if there is a specific reason to be done
this way. But I wouldn't like to change the response payload as the

front

end may be impacted.

On Thu, Jan 31, 2019 at 6:52 PM César Hernández Mendoza <
cesargu...@gmail.com> wrote:


Hi Ivan,,
Not answering your question but actually asking one to you, why you

don't

have a foreign key like the following instead of the entire entity as

an

attribute?.

public class Department {

  private String name;
  private int subDepartment;
...
}

El jue., 31 ene. 2019 a las 14:21, Ivan Junckes Filho (<
ivanjunc...@gmail.com>) escribió:


This is TomEE 8 M1 btw

On Thu, Jan 31, 2019 at 6:20 PM Ivan Junckes Filho <

ivanjunc...@gmail.com>

wrote:


Hey guys I an getting an StackOverflowError issue because jaxrs is

trying

to convert an java object to json and going into a loop it seems.

The class is something like:

public class Department {

  private String name;
  private Department subDepartment;
...
}

How do I fix this?


31-Jan-2019 18:15:19.453 WARNING [http-nio-44807-exec-4]
org.apache.cxf.phase.PhaseInterceptorChain.doDefaultLogging

Interceptor

for

{

http://jaxrs.metrics.microprofile.geronimo.apache.org/}MetricsEndpoints

has thrown exception, unwinding now
org.apache.cxf.interceptor.Fault
at


org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleWriteException(JAXRSOutInterceptor.java:396)

at


org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.serializeMessage(JAXRSOutInterceptor.java:272)

at


org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.processResponse(JAXRSOutInterceptor.java:122)

at


org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleMessage(JAXRSOutInterceptor.java:84)

at


org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)

at


org.apache.cxf.interceptor.OutgoingChainInterceptor.handleMessage(OutgoingChainInterceptor.java:90)

at


org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)

at


org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)

at


org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:267)

at


org.apache.openejb.server.cxf.rs.CxfRsHttpListener.doInvoke(CxfRsHttpListener.java:253)

at


org.apache.tomee.webservices.CXFJAXRSFilter.doFilter(CXFJAXRSFilter.java:94)

at


org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)

at


org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)

at

org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)

at


org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)

at


org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFi

Re: Issue trying to run TCK web profile only tests

2019-01-30 Thread Bruno Baptista

One question,

Any idea why the runtests script uses tomcat-web for the webprofile?

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 30/01/19 03:15, César Hernández Mendoza wrote:

Looking at this lines of code from the rustest script[1]:

  tomee-plus|tomee-plume|tomee|tomcat|none)
 profile="full"
 true
 ;;
 tomcat-web)
 profile="web"
 appendOption "web-profile"
 true
 ;;

I tried to run only the web profile related test using the following
command:
./runtests --web tomcat-web -c com/sun/ts/tests/appclient

But I get the exception about "Missing required property: openejb.home" [2]

How can I run just web profile related tests via the ./runtest script?


[1] https://github.com/apache/tomee-tck/blob/master/runtests#L246-L258

[2]
[ERROR] Failed to execute goal
org.codehaus.gmaven:gmaven-plugin:1.5:execute (setup-environment) on
project openejb-tck: java.lang.Exception: Missing required property:
openejb.home -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
goal org.codehaus.gmaven:gmaven-plugin:1.5:execute (setup-environment) on
project openejb-tck: java.lang.Exception: Missing required property:
openejb.home
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException:
java.lang.Exception: Missing required property: openejb.home
at org.codehaus.gmaven.plugin.MojoSupport.execute(MojoSupport.java:87)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
... 20 more
Caused by: org.codehaus.gmaven.feature.ComponentException:
java.lang.Exception: Missing required property: openejb.home
at
org.codehaus.gmaven.runtime.support.ScriptExecutorSupport.invokeMethod(ScriptExecutorSupport.java:171)
at
org.codehaus.gmaven.runtime.support.ScriptExecutorSupport.execute(ScriptExecutorSupport.java:133)
at
org.codehaus.gmaven.runtime.support.ScriptExecutorSupport.execute(ScriptExecutorSupport.java:73)
at
org.codehaus.gmaven.plugin.execute.ExecuteMojo.process(ExecuteMojo.java:292)
at
org.codehaus.gmaven.plugin.ComponentMojoSupport.doExecute(ComponentMojoSupport.java:60)
at org.codehaus.gmaven.plugin.MojoSupport.execute(MojoSupport.java:71)
... 22 more
Caused by: java.lang.Exception: Missing required property: openejb.home
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at
org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:77)
at
org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:71)
at
org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
at
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:52)
at
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:192)
at
org.codehaus.groovy.runtime.callsite.AbstractCallSit

Re: Issue trying to run TCK web profile only tests

2019-01-30 Thread Bruno Baptista
The openejb.home property was not set globally on the pom.xml, hence the 
error. But if you set it, it messes the deployment.


The environment setup is outdated and is using apache-openejb-*, which 
also causes issues.


I'm researching where does this come from.

Bruno Baptista
https://twitter.com/brunobat_


On 30/01/19 03:15, César Hernández Mendoza wrote:

Looking at this lines of code from the rustest script[1]:

  tomee-plus|tomee-plume|tomee|tomcat|none)
 profile="full"
 true
 ;;
 tomcat-web)
 profile="web"
 appendOption "web-profile"
 true
 ;;

I tried to run only the web profile related test using the following
command:
./runtests --web tomcat-web -c com/sun/ts/tests/appclient

But I get the exception about "Missing required property: openejb.home" [2]

How can I run just web profile related tests via the ./runtest script?


[1] https://github.com/apache/tomee-tck/blob/master/runtests#L246-L258

[2]
[ERROR] Failed to execute goal
org.codehaus.gmaven:gmaven-plugin:1.5:execute (setup-environment) on
project openejb-tck: java.lang.Exception: Missing required property:
openejb.home -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
goal org.codehaus.gmaven:gmaven-plugin:1.5:execute (setup-environment) on
project openejb-tck: java.lang.Exception: Missing required property:
openejb.home
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException:
java.lang.Exception: Missing required property: openejb.home
at org.codehaus.gmaven.plugin.MojoSupport.execute(MojoSupport.java:87)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
... 20 more
Caused by: org.codehaus.gmaven.feature.ComponentException:
java.lang.Exception: Missing required property: openejb.home
at
org.codehaus.gmaven.runtime.support.ScriptExecutorSupport.invokeMethod(ScriptExecutorSupport.java:171)
at
org.codehaus.gmaven.runtime.support.ScriptExecutorSupport.execute(ScriptExecutorSupport.java:133)
at
org.codehaus.gmaven.runtime.support.ScriptExecutorSupport.execute(ScriptExecutorSupport.java:73)
at
org.codehaus.gmaven.plugin.execute.ExecuteMojo.process(ExecuteMojo.java:292)
at
org.codehaus.gmaven.plugin.ComponentMojoSupport.doExecute(ComponentMojoSupport.java:60)
at org.codehaus.gmaven.plugin.MojoSupport.execute(MojoSupport.java:71)
... 22 more
Caused by: java.lang.Exception: Missing required property: openejb.home
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at
org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:77)
at
org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:71)
at
org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
at
org.codehaus.groovy.runtime.callsite.CallSiteArray.d

Re: PR of MicroProfile Fault Tolerance Example to review.

2019-01-29 Thread Bruno Baptista

Thanks José.

The PR looks good to me now.

Cheers!

Bruno Baptista
https://twitter.com/brunobat_


On 28/01/19 14:56, Jose Henrique Ventura wrote:

Thanks for reviewing the PR Bruno!

I've finished your suggestions.


Best Regards,
José Henrique Ventura.

‐‐‐ Original Message ‐‐‐
On Monday, January 28, 2019 11:00 AM, Bruno Baptista  wrote:


Thanks for the PR José!

I've reviewed it and left a couple of suggestions.

Cheers

Bruno Baptista
https://twitter.com/brunobat_

On 26/01/19 22:13, Jose Henrique Ventura wrote:


Hi guys,
I have completed fault tolerance timeout example. =)
https://github.com/apache/tomee/pull/382
Best Regards,
José Henrique Ventura.




Re: PR review and merge

2019-01-29 Thread Bruno Baptista

Thanks a lot Roberto!

Bruno Baptista
https://twitter.com/brunobat_


On 29/01/19 17:19, Roberto Cortez wrote:

I think all of them are now merged, except for 
https://github.com/apache/tomee/pull/370 
<https://github.com/apache/tomee/pull/370>

My concern here is we are changing the equals implementation, which is usually 
auto generated by our IDE’s. So, most likely these changes will be lost if 
someone regenerates the equals method, unless their IDE is set to use 
Objects.equals. This is no blocker, but I would like to discuss it further 
before moving forward with the PR.

Maybe we should force all .equals to use Objects.equals? With a checkstyle 
check (not sure if they have a check for that)?

Cheers,
Roberto


On 28 Jan 2019, at 15:30, Bruno Baptista  wrote:

Thanks Roberto.

Bruno Baptista
https://twitter.com/brunobat_


On 28/01/19 15:29, Roberto Cortez wrote:

I’ll be looking into the current list of PR’s and try to merge the ones that 
are ready.

Cheers,
Roberto


On 24 Jan 2019, at 15:23, Otávio Gonçalves de Santana  
wrote:

Thank you for the explanation it Roberto.

On Thu, Jan 24, 2019 at 12:50 PM Roberto Cortez 
wrote:


We didn’t.

If we are moving forward with the release, I would prefer to keep these in
stand by until we are done. Right now, we are on a green build, and we
can’t be sure if any of these PR’s would break it, so better to be safe :)


On 24 Jan 2019, at 12:05, Otávio Gonçalves de Santana <

osant...@tomitribe.com> wrote:

Hello everyone, please don't forget these PRs

On Wed, Jan 23, 2019 at 8:01 AM Bruno Baptista 

wrote:

Hi,

Can one of the committers please take a look at these PRs?

https://github.com/apache/tomee/pull/377
https://github.com/apache/tomee/pull/376
https://github.com/apache/tomee/pull/375
https://github.com/apache/tomee/pull/370
https://github.com/apache/tomee/pull/366
https://github.com/apache/tomee/pull/363
https://github.com/apache/tomee/pull/362
https://github.com/apache/tomee/pull/361

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_







Re: JakartaEE TCK

2019-01-28 Thread Bruno Baptista

Hi Folks!

Any progress on executing the TCK tests?

Cheers

Bruno Baptista
https://twitter.com/brunobat_




On 23/01/19 15:00, César Hernández Mendoza wrote:

Where do we say to run the tests against a specific version of TomEE?

I'm blocked at this point too. Once the UI is open I don't know what to
open or how to properly create the javaee_web_profile filter.

El mié., 23 ene. 2019 a las 8:32, Bruno Baptista ()
escribió:


Hi César,

Thanks for this email. I was not aware of this UI.

I managed to make it work but I think I'm missing something Where do
we say to run the tests against a specific version of TomEE? This seems
to ignore the TomEE-TCK project.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 22/01/19 16:01, César Hernández Mendoza wrote:

I'm getting closer (hopefully) to visualize the test on the JT Harness

UI.

Following Jean-Louis and Gurkan direction this is where I'm so far:

cd  /Users/cesar/juniverse/ee8tck/javaeetck/bin
./ant gui

On the JT Harness UI, clicked: File->Open->TestSuite
and opened the folder: /Users/cesar/juniverse/ee8tck/javaeetck/src

On the JT Harness UI, Selected: View-> Filter -> ConfigureFilters
I couldn't create a new filter so I ended up updating the Custom filter
with the following data:
Keywords -> Match (Expression): javaee_web_profile
Click Apply and then Ok.

The Pi chard updated  slowly and the total amount of test cases is: 47219

This number of test cases differs from the one Gurkan mentioned ("17517
tests for Web Profile"), so either I'm not opening the right folder or

I'm

not applying correctly the filter .. or both.




El mar., 22 ene. 2019 a las 3:30, Bruno Baptista ()
escribió:


Hi Guys,

I wonder were can I find the full list of test executions, like this one
for EJB:

./runtests --web tomee-plume
com.sun.ts.tests.ejb30.bb.localaccess.statelessclient

That way we could prioritize and start working working on specific

fixes.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 21/01/19 22:20, Jean-Louis Monteiro wrote:

Ant will automatically look for a build.xml file.

`ant gui` will therefor look for the build.xml file and then look for a
target with the name `gui` and run it.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Jan 21, 2019 at 10:16 PM César Hernández Mendoza <
cesargu...@gmail.com> wrote:


Thank you for the reply, I have the following question now:

- Go to bin/ folder of TCK

Done:
cd  /Users/cesar/juniverse/ee8tck/javaeetck/bin

- Run ant gui

Where and how I execute the ant gui? I see
https://github.com/eclipse-ee4j/jakartaee-tck/issues/26 was closed

but

I

couldn't find any information on the wiki.

This is the content of my bin/ folder of TCK:
$ ls -A1
?/
build.xml
certificates/
client_policy.append
harness.policy
java.policy
jaxrpc-url-props.dat
jaxws-url-props.dat
jws-url-props.dat
ldap.ldif
login.config
server_policy.append
sig-test-pkg-list.txt
sig-test-pkg-list_se8.txt
sig-test-pkg-list_se9.txt
sig-test.map
sig-test_se8.map
sig-test_se8.map.orig
sig-test_se9.map
ts.java.security
ts.jte
ts.jte.bak
ts.jte.jdk9
ts.jte.orig
ts.jtx
tssql.stmt
version
webservices-url-props.dat
xml/

I see there are some options [1] [2] to have an ant gui but I'm not

sure if

you are referring something different.

[1] http://www.placidsystems.com/virtualant/doc/guioverview.aspx
[2] http://antelope.tigris.org/



El lun., 21 ene. 2019 a las 14:40, Gurkan Erdogdu (<

cgerdo...@gmail.com

)

escribió:


I think we need to run tests with javaee_webprofile keyword filter.

There

is also a GUI to run/see the tests. You can run it with :

  - Go to bin/ folder of TCK
  - Run ant gui
  - You need to create a custom filter configuration with keyword
  javaee_web_profile

When I filter, there exists 17517 tests for Web Profile.

On Mon, Jan 21, 2019 at 9:50 PM César Hernández Mendoza <
cesargu...@gmail.com> wrote:


@Gurkan
Thanks for the update.

@List I appreciate pointers/opinions in these two questions:
After reading the readme, I wonder if there is a proper way to split

the

entire set of tests in sub sets?
My questions arise when I try to think how we can spread the work

mentioned

in Stage 2 and Stage 3 from the readme.
I think having a shared document with status mapped to this sub sets

can

be

useful as a reference to people trying to find areas to help. What

do

you

think?


El vie., 18 ene. 2019 a las 2:41, Gurkan Erdogdu (<

cgerdo...@gmail.com

)

escribió:


Hi Cesar

My environment is macOS

Before updating, I received the following error when I run the

following

command from tomee-tck and also got some dev/tomee-tck/./target/lib

is

not

directory errors etc.

./runtests --web tomee-plume
com.sun.ts.tests.

Re: PR review and merge

2019-01-28 Thread Bruno Baptista

Thanks Roberto.

Bruno Baptista
https://twitter.com/brunobat_


On 28/01/19 15:29, Roberto Cortez wrote:

I’ll be looking into the current list of PR’s and try to merge the ones that 
are ready.

Cheers,
Roberto


On 24 Jan 2019, at 15:23, Otávio Gonçalves de Santana  
wrote:

Thank you for the explanation it Roberto.

On Thu, Jan 24, 2019 at 12:50 PM Roberto Cortez 
wrote:


We didn’t.

If we are moving forward with the release, I would prefer to keep these in
stand by until we are done. Right now, we are on a green build, and we
can’t be sure if any of these PR’s would break it, so better to be safe :)


On 24 Jan 2019, at 12:05, Otávio Gonçalves de Santana <

osant...@tomitribe.com> wrote:

Hello everyone, please don't forget these PRs

On Wed, Jan 23, 2019 at 8:01 AM Bruno Baptista 

wrote:

Hi,

Can one of the committers please take a look at these PRs?

https://github.com/apache/tomee/pull/377
https://github.com/apache/tomee/pull/376
https://github.com/apache/tomee/pull/375
https://github.com/apache/tomee/pull/370
https://github.com/apache/tomee/pull/366
https://github.com/apache/tomee/pull/363
https://github.com/apache/tomee/pull/362
https://github.com/apache/tomee/pull/361

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_







Re: [VOTE] Release Apache TomEE 8.0.0 MILESTONE 2

2019-01-28 Thread Bruno Baptista

Hi Jon,

About the failsafe-1.0.4.jar absence... This is no logger required by 
the new safeguard-impl-1.2.0.jar. We are good on that regard.


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 28/01/19 11:11, Jonathan Gallimore wrote:

Couple of queries:

Looks like failsafe-1.0.4.jar has been dropped (microprofile distribution)
- was that intended?

Looks like the following have been downgraded since 8.0.0.M1:

stax2-api (4.1 -> 3.1.4)
woodstox-core (5.1.0 -> 5.0.3)
xbean-asm6-shaded (4.10 -> 4.8) (other xbean deps upgraded from 4.10 to
4.12)

There's a xbean-asm6-shaded and a xbean-asm7-shaded - not an issue, but we
ought to look to bring everything up to xbean-asm7-shaded when we can
(happy to provide some guidance to someone who wants to tackle it).

These are queries rather than showstoppers requiring a re-roll. I'm
otherwise +1, and many thanks for getting this release out.

Cheers

Jon

On Sat, Jan 26, 2019 at 1:16 AM Roberto Cortez 
wrote:


Hi everyone,

Here is ML2 of TomEE 8. It took me way longer than I expected, since I
found a few issues that I had to fix to perform the release properly.
Please, realize that this is no way a FINAL release and it doesn’t need to
be perfect. We may have several Milestone versions until we reach a final
one.

Probably the most interesting feature of this release is the full support
of MP 2.0 in the microprofile TomEE flavour.

As part of the release, I also had to release a patched version of BVal2
with tomee groupId, alongside TomEE itself

Staging Repos:
https://repository.apache.org/content/repositories/orgapachetomee-1129/ <
https://repository.apache.org/content/repositories/orgapachetomee-1129/>
(BVal 2)
https://repository.apache.org/content/repositories/orgapachetomee-1132/ <
https://repository.apache.org/content/repositories/orgapachetomee-1132/>
(TomEE)

Source:

https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M2/bval-parent-2.0.1-83f28d8-source-release.zip
<
https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M2/bval-parent-2.0.1-83f28d8-source-release.zip
https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M2/tomee-project-8.0.0-M2-source-release.zip
<
https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M2/tomee-project-8.0.0-M2-source-release.zip
Dist Area:
https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M2/ <
https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M2/>

JIRA:
https://jira.apache.org/jira/projects/TOMEE/versions/12344300 <
https://jira.apache.org/jira/projects/TOMEE/versions/12344300>

Thank you!

Please vote:
+1: Release
0: I don’t care
-1 Do not release because ...

The vote will be open for 3 days or the consensus is binding (At least 3
binding votes).

Cheers,
Roberto


Re: PR of MicroProfile Fault Tolerance Example to review.

2019-01-28 Thread Bruno Baptista

Thanks for the PR José!

I've reviewed it and left a couple of suggestions.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 26/01/19 22:13, Jose Henrique Ventura wrote:

Hi guys,

I have completed fault tolerance timeout example. =)
https://github.com/apache/tomee/pull/382

Best Regards,
José Henrique Ventura.


Re: @Schedule being fired twice

2019-01-28 Thread Bruno Baptista

Is this happening only at startup?

Can you please post the log lines of a few scheduler executions to check 
the time?


The Scheduler should be active as soon as that singleton is 
instantiated, btw.


Bruno Baptista
https://twitter.com/brunobat_


On 25/01/19 20:50, exabrial12 wrote:

To clarify, this is happening on startup... could this be because startup is
taking longer than 15s?



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html


Re: [VOTE] Release Apache TomEE 8.0.0 MILESTONE 2

2019-01-28 Thread Bruno Baptista

+1

I've tested the webprofile, microprofile and plus flavors on linux with 
openjdk version "1.8.0_191.


Used several apps and it looks good to me.

Thanks Roberto!

Bruno Baptista
https://twitter.com/brunobat_



On 26/01/19 01:15, Roberto Cortez wrote:

Hi everyone,

Here is ML2 of TomEE 8. It took me way longer than I expected, since I found a 
few issues that I had to fix to perform the release properly. Please, realize 
that this is no way a FINAL release and it doesn’t need to be perfect. We may 
have several Milestone versions until we reach a final one.

Probably the most interesting feature of this release is the full support of MP 
2.0 in the microprofile TomEE flavour.

As part of the release, I also had to release a patched version of BVal2 with 
tomee groupId, alongside TomEE itself

Staging Repos:
https://repository.apache.org/content/repositories/orgapachetomee-1129/ 
<https://repository.apache.org/content/repositories/orgapachetomee-1129/> (BVal 
2)
https://repository.apache.org/content/repositories/orgapachetomee-1132/ 
<https://repository.apache.org/content/repositories/orgapachetomee-1132/> 
(TomEE)

Source:
https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M2/bval-parent-2.0.1-83f28d8-source-release.zip
 
<https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M2/bval-parent-2.0.1-83f28d8-source-release.zip>
https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M2/tomee-project-8.0.0-M2-source-release.zip
 
<https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M2/tomee-project-8.0.0-M2-source-release.zip>

Dist Area:
https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M2/ 
<https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M2/>

JIRA:
https://jira.apache.org/jira/projects/TOMEE/versions/12344300 
<https://jira.apache.org/jira/projects/TOMEE/versions/12344300>

Thank you!

Please vote:
+1: Release
0: I don’t care
-1 Do not release because ...

The vote will be open for 3 days or the consensus is binding (At least 3 
binding votes).

Cheers,
Roberto


Re: MicroProfile Integration in Plus and Plume

2019-01-24 Thread Bruno Baptista

Roberto,

I run a full build and it didn't finish. It got stuck on while running 
the tomee/tck/cdi-tomee tests.


Apart from that, I found these issues:

itests/legacy-server

[ERROR] Failures:
[ERROR]   LegacyServerTest.test:212->assertBalance:230 3 out of 1000 is 
too low


tck/cdi-embeddedrver
[ERROR] Failures:
[ERROR] 
EnterpriseSelectedAlternative02Test>Arquillian.arquillianBeforeClass:109 
» Deployment
[ERROR] 
EnterpriseSelectedAlternative03Test>Arquillian.arquillianBeforeClass:109 
» Deployment
[ERROR] EnterpriseBeanDiscoveryTest>Arquillian.arquillianBeforeClass:109 
» Deployment ...
[ERROR] LibraryInEarTest>Arquillian.arquillianBeforeClass:109 » 
Deployment can't deplo...
[ERROR] 
MultiWebModuleWithExtensionTest>Arquillian.arquillianBeforeClass:109 » 
Deployment
[ERROR] 
SingleWebModuleWithExtensionTest>Arquillian.arquillianBeforeClass:109 » 
Deployment
[ERROR] 
BeanRegistrationByExtensionInEarLibraryTest>Arquillian.arquillianBeforeClass:109 
» Deployment
[ERROR] 
EnabledManagedBeanInjectionAvailabilityTest>Arquillian.arquillianBeforeClass:109 
» Deployment
[ERROR] 
EnabledProducerFieldInjectionAvailabilityTest>Arquillian.arquillianBeforeClass:109 
» Deployment
[ERROR] 
EnabledProducerMethodInjectionAvailabilityTest>Arquillian.arquillianBeforeClass:109 
» Deployment
[ERROR] 
EnabledSessionBeanInjectionAvailabilityTest>Arquillian.arquillianBeforeClass:109 
» Deployment
[ERROR] InterModuleELResolutionTest>Arquillian.arquillianBeforeClass:109 
» Deployment ...
[ERROR] InterModuleLookupTest>Arquillian.arquillianBeforeClass:109 » 
Deployment can't ...
[ERROR] 
SelectedAlternativeManagedBeanInjectionAvailabilityTest>Arquillian.arquillianBeforeClass:109 
» Deployment
[ERROR] 
SelectedAlternativeSessionBeanInjectionAvailabilityTest>Arquillian.arquillianBeforeClass:109 
» Deployment
[ERROR] 
SpecializedProducerMethodInjectionNotAvailableTest>Arquillian.arquillianBeforeClass:109 
» Deployment
[ERROR] 
SpecializationModularity02Test>Arquillian.arquillianBeforeClass:109 » 
Deployment
[ERROR] 
SpecializationModularity04Test>Arquillian.arquillianBeforeClass:109 » 
Deployment
[ERROR] Specialization06Test>Arquillian.arquillianBeforeClass:109 » 
Deployment can't d...


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 23/01/19 12:26, Bruno Baptista wrote:

Hi Roberto,

I'll take a look at the PR.

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 23/01/19 11:30, Roberto Cortez wrote:

Hi folks,

Let me try to give a full overview on what I have been working on in 
the last couple of days. Progress has been a bit slow unfortunately, 
due to the amount of combinations and tests that I have to run every 
time I do a change. On the other hand, I know understand way better 
how TomEE does the deployment :) Anyway, I’m starting to question 
myself if I’m going in the right direction.


MP EAR Support:
MP CDI Extensions, or any CDI Extension is always loaded if found in 
the classpath via the ServiceLoader. For WAR this works fine. On EAR, 
CDI Deployment is deferred because it may be contained in the Webapp 
and not on the EJB jars, and EJB jars are deployed first (TOMEE-189 
and TOMEE-722). Until now, we didn’t rely on CDI to load any of the 
server features, so this was fine. With MP, we added the ability to 
include / exclude additional urls to be included in the CDI scanner 
(https://github.com/apache/tomee/commit/021b9ca8d01a78f5b7ee3438f30fd8901ff60d5b 
<https://github.com/apache/tomee/commit/021b9ca8d01a78f5b7ee3438f30fd8901ff60d5b>). 



The issue here is that we now need to load only the build in CDI 
features, while deferring the internal / possible CDI beans contained 
in the EAR file. This might be a possible solution:
https://github.com/apache/tomee/commit/c6397e26e191f717b96934f2e279acfe320451b9 
<https://github.com/apache/tomee/commit/c6397e26e191f717b96934f2e279acfe320451b9>. 



Servlet / MP Rest endpoint clashing:
If an existent app is only using servlets and has a servlet mapping 
to the root context or /*, MP endpoints will override the context 
root with a REST path and the servlet will 404. This has nothing to 
do with MP itself, if you write an app with a servlet mapping to /* 
and add a REST endpoint to /, the REST endpoint takes precedence and 
you are unable to reach the servlet. My concern here is that someone 
out there might run into this and we break their app with the new 
version of TomEE. This should probably do the trick: 
https://github.com/apache/tomee/commit/4ade980c56276a2ad4f2df921e12314e38e881cf 
<https://github.com/apache/tomee/commit/4ade980c56276a2ad4f2df921e12314e38e881cf> 



Tomcat TomEE Webapp (with Plus and Plume)
Deployment of the TomEE Webapp in Tomcat with MP was also not 
working. This was because CDI scanning for the TomEE web app was 
disabled by default (since we didn’t rely on any CDI services 
before). Also, the web.xml was marked as metadata complete, which 
also ski

Re: JakartaEE TCK

2019-01-23 Thread Bruno Baptista

Hi César,

Thanks for this email. I was not aware of this UI.

I managed to make it work but I think I'm missing something Where do 
we say to run the tests against a specific version of TomEE? This seems 
to ignore the TomEE-TCK project.


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 22/01/19 16:01, César Hernández Mendoza wrote:

I'm getting closer (hopefully) to visualize the test on the JT Harness UI.
Following Jean-Louis and Gurkan direction this is where I'm so far:

cd  /Users/cesar/juniverse/ee8tck/javaeetck/bin
./ant gui

On the JT Harness UI, clicked: File->Open->TestSuite
and opened the folder: /Users/cesar/juniverse/ee8tck/javaeetck/src

On the JT Harness UI, Selected: View-> Filter -> ConfigureFilters
I couldn't create a new filter so I ended up updating the Custom filter
with the following data:
Keywords -> Match (Expression): javaee_web_profile
Click Apply and then Ok.

The Pi chard updated  slowly and the total amount of test cases is: 47219

This number of test cases differs from the one Gurkan mentioned ("17517
tests for Web Profile"), so either I'm not opening the right folder or I'm
not applying correctly the filter .. or both.




El mar., 22 ene. 2019 a las 3:30, Bruno Baptista ()
escribió:


Hi Guys,

I wonder were can I find the full list of test executions, like this one
for EJB:

./runtests --web tomee-plume
com.sun.ts.tests.ejb30.bb.localaccess.statelessclient

That way we could prioritize and start working working on specific fixes.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 21/01/19 22:20, Jean-Louis Monteiro wrote:

Ant will automatically look for a build.xml file.

`ant gui` will therefor look for the build.xml file and then look for a
target with the name `gui` and run it.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Jan 21, 2019 at 10:16 PM César Hernández Mendoza <
cesargu...@gmail.com> wrote:


Thank you for the reply, I have the following question now:

   - Go to bin/ folder of TCK

Done:
cd  /Users/cesar/juniverse/ee8tck/javaeetck/bin

- Run ant gui

   Where and how I execute the ant gui? I see
https://github.com/eclipse-ee4j/jakartaee-tck/issues/26 was closed but

I

couldn't find any information on the wiki.

This is the content of my bin/ folder of TCK:
$ ls -A1
   ?/
   build.xml
   certificates/
   client_policy.append
   harness.policy
   java.policy
   jaxrpc-url-props.dat
   jaxws-url-props.dat
   jws-url-props.dat
   ldap.ldif
   login.config
   server_policy.append
   sig-test-pkg-list.txt
   sig-test-pkg-list_se8.txt
   sig-test-pkg-list_se9.txt
   sig-test.map
   sig-test_se8.map
   sig-test_se8.map.orig
   sig-test_se9.map
   ts.java.security
   ts.jte
   ts.jte.bak
   ts.jte.jdk9
   ts.jte.orig
   ts.jtx
   tssql.stmt
   version
   webservices-url-props.dat
   xml/

I see there are some options [1] [2] to have an ant gui but I'm not

sure if

you are referring something different.

[1] http://www.placidsystems.com/virtualant/doc/guioverview.aspx
[2] http://antelope.tigris.org/



El lun., 21 ene. 2019 a las 14:40, Gurkan Erdogdu (
)

escribió:


I think we need to run tests with javaee_webprofile keyword filter.

There

is also a GUI to run/see the tests. You can run it with :

 - Go to bin/ folder of TCK
 - Run ant gui
 - You need to create a custom filter configuration with keyword
 javaee_web_profile

When I filter, there exists 17517 tests for Web Profile.

On Mon, Jan 21, 2019 at 9:50 PM César Hernández Mendoza <
cesargu...@gmail.com> wrote:


@Gurkan
Thanks for the update.

@List I appreciate pointers/opinions in these two questions:
After reading the readme, I wonder if there is a proper way to split

the

entire set of tests in sub sets?
My questions arise when I try to think how we can spread the work

mentioned

in Stage 2 and Stage 3 from the readme.
I think having a shared document with status mapped to this sub sets

can

be

useful as a reference to people trying to find areas to help. What do

you

think?


El vie., 18 ene. 2019 a las 2:41, Gurkan Erdogdu (<

cgerdo...@gmail.com

)

escribió:


Hi Cesar

My environment is macOS

Before updating, I received the following error when I run the

following

command from tomee-tck and also got some dev/tomee-tck/./target/lib

is

not

directory errors etc.

./runtests --web tomee-plume
com.sun.ts.tests.ejb30.bb.localaccess.statelessclient

[INFO]




[ERROR] Failed to execute goal
org.codehaus.gmaven:gmaven-plugin:1.5:execute (setup-environment) on
project openejb-tck: java.lang.Exception: Expected one file to be

included

into path; dir=/dev/tomee-tck/./target/lib,

includes=openejb-lite*.jar,

excludes=null -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to

execute

goal org.codehaus.gmaven:gmaven-plugin:1.5:execute

(setup-environment)

on

project ope

Re: Another 8.0.0 milestone release

2019-01-23 Thread Bruno Baptista

+1

Bruno Baptista
https://twitter.com/brunobat_


On 23/01/19 01:59, David Blevins wrote:

There are plans to launch start.microprofile.io on January 29th.  We have a lot 
more MicroProfile support in master than we do in 8.0.0-M1.

What do we think about shooting out an 8.0.0-M2 asap and ensuring it's in the 
server list for start.microprofile.io?




Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread Bruno Baptista

Hi Roberto,

I'll take a look at the PR.

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 23/01/19 11:30, Roberto Cortez wrote:

Hi folks,

Let me try to give a full overview on what I have been working on in the last 
couple of days. Progress has been a bit slow unfortunately, due to the amount 
of combinations and tests that I have to run every time I do a change. On the 
other hand, I know understand way better how TomEE does the deployment :) 
Anyway, I’m starting to question myself if I’m going in the right direction.

MP EAR Support:
MP CDI Extensions, or any CDI Extension is always loaded if found in the classpath 
via the ServiceLoader. For WAR this works fine. On EAR, CDI Deployment is deferred 
because it may be contained in the Webapp and not on the EJB jars, and EJB jars are 
deployed first (TOMEE-189 and TOMEE-722). Until now, we didn’t rely on CDI to load 
any of the server features, so this was fine. With MP, we added the ability to 
include / exclude additional urls to be included in the CDI scanner 
(https://github.com/apache/tomee/commit/021b9ca8d01a78f5b7ee3438f30fd8901ff60d5b 
<https://github.com/apache/tomee/commit/021b9ca8d01a78f5b7ee3438f30fd8901ff60d5b>).

The issue here is that we now need to load only the build in CDI features, 
while deferring the internal / possible CDI beans contained in the EAR file. 
This might be a possible solution:
https://github.com/apache/tomee/commit/c6397e26e191f717b96934f2e279acfe320451b9 
<https://github.com/apache/tomee/commit/c6397e26e191f717b96934f2e279acfe320451b9>.

Servlet / MP Rest endpoint clashing:
If an existent app is only using servlets and has a servlet mapping to the root 
context or /*, MP endpoints will override the context root with a REST path and the 
servlet will 404. This has nothing to do with MP itself, if you write an app with a 
servlet mapping to /* and add a REST endpoint to /, the REST endpoint takes 
precedence and you are unable to reach the servlet. My concern here is that someone 
out there might run into this and we break their app with the new version of TomEE. 
This should probably do the trick: 
https://github.com/apache/tomee/commit/4ade980c56276a2ad4f2df921e12314e38e881cf 
<https://github.com/apache/tomee/commit/4ade980c56276a2ad4f2df921e12314e38e881cf>

Tomcat TomEE Webapp (with Plus and Plume)
Deployment of the TomEE Webapp in Tomcat with MP was also not working. This was 
because CDI scanning for the TomEE web app was disabled by default (since we didn’t 
rely on any CDI services before). Also, the web.xml was marked as metadata complete, 
which also skips any annotation deployment processing. I’m a little concern with the 
change here due to the previous comment that it might affect TomEE embedded, but so 
far it seemed fine: 
https://github.com/apache/tomee/commit/e55760d0e230612de7f99b7c4940b1305456dbaf 
<https://github.com/apache/tomee/commit/e55760d0e230612de7f99b7c4940b1305456dbaf>

ApplicationComposer on Arquillian Remote
Right now, I was not able to have this working. This is because 
ApplicationComposer, when using CDI, you manually state in the annotation which 
CDI beans are required. In this case, any additional Bean scanning is skipped. 
Again, we probably need to adjust it to also include the container provided CDI 
beans.

RestEndpoint / OpenAPI
I’ve run into a StringIndexOutOfBoundsException when OpenAPI is processing REST 
annotations. I’m now looking into that. Not sure if it might be a bug in 
OpenAPI implementation or something else.

Well, this is it for now. Sorry for the long email. All the work has been done 
in this PR:
https://github.com/apache/tomee/pull/304/ 
<https://github.com/apache/tomee/pull/304/>

It would definitely need a few set of eyes to review it.

Thank you!

Cheers,
Roberto


On 23 Jan 2019, at 11:28, Roberto Cortez  wrote:

We introduced a couple of new properties to allows additional jars to be added 
in the DeploymentLoader, so they can be scanned.

This was done here:
https://github.com/apache/tomee/commit/021b9ca8d01a78f5b7ee3438f30fd8901ff60d5b 
<https://github.com/apache/tomee/commit/021b9ca8d01a78f5b7ee3438f30fd8901ff60d5b>

What you probably need to do is have your custom classloader to also load the 
mp specific libraries, so they can be also scanned.

Yes, I’ve run into multiple other issues. I’m going to send an email about it, 
next. I think we can make it, we just need to validate if these changes make 
sense and if they are right.

Thank you,
Roberto


On 23 Jan 2019, at 10:55, j4fm  wrote:

Okay, so digging into this loader, there is this line:

SystemInstance.get().setComponent(ParentClassLoaderFinder.class, fallback ->
MyClassLoader._getOrCreateInstance(parent));

Commenting it out seems to make it play nicely with MP but brakes the class
loading of the webapps when openejb's scanning annotations.

So am currently looking at other solutions to make both work.  I think this
is somethi

Re: Looking for review on PR

2019-01-23 Thread Bruno Baptista

Hi Doychin,

The test passes but I don't know if the changes are subverting the 
original purpose of the test.


Let's wait for some more feedback on that.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 23/01/19 09:34, Doychin Bondzhev wrote:

I've added new commit to PR
https://github.com/apache/tomee/pull/360


On 21.1.2019 г. 18:14, brunobat [via TomEE & OpenEJB] wrote:

Sure Doychin,

Looking forward for that update.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 21/01/19 15:10, Doychin Bondzhev wrote:

> Hi Bruno,
>
> I think I found why AutoConnectionTrackerTest fails.
>
> In some cases GC is not fast enough to place leaked references into
> ReferenceQueue. When setEnvironment is called right after GC there is
> a small chance that some references did not manage to get to
> referenceQueue on time for the check that queue is empty. In order to
> test that theory I added small delay and second poll to the queue and
> suddenly I got reference.
>
> I will update my PR about AutoConnectionTracker and
> AutoConnectionTrackerTest with new changes.
>
> If you don't like the way I did the delay I'm open to suggestions.
>
> Have a nice day.
>
> On 20.1.2019 г. 14:13, brunobat [via TomEE & OpenEJB] wrote:
>> Hi Doychin,
>>
>> I've run all the tests on the merge of the 5 PRs.
>>
>> I encountered 2 errors. They might be transient ones. Can you please
>> take a look?
>>
>>
>> arquillian-tomee-jms-tests
>> [ERROR]   EnvEntryTest.test:105 » EJB The bean encountered a
>> non-application exception; ...
>>
>> openejb-core
>> [ERROR] AutoConnectionTrackerTest.test:203->assertLogs:209 Detected
>> abandoned connection expected:<1> but was:<0>
>>
>>
>> Cheers
>>
>> Bruno Baptista
>> https://twitter.com/brunobat_
>>
>>
>> On 18/01/19 18:32, Bruno Baptista wrote:
>>
>> >
>> > Hi Doychin,
>> >
>> > Thanks for the contribution!
>> >
>> > I've approved a couple and left comments in 2 others.
>> >
>> > Will run all the tests when I get home.
>> >
>> > Cheers
>> >
>> > Bruno Baptista
>> > https://twitter.com/brunobat_
>> >
>> >
>> > On 18/01/19 17:46, Bruno Baptista wrote:
>> >>
>> >> Hi Doychin,
>> >>
>> >> I'll have a look.
>> >>
>> >> Cheers
>> >>
>> >> Bruno Baptista
>> >> https://twitter.com/brunobat_
>> >>
>> >>
>> >> On 18/01/19 17:41, Doychin Bondzhev wrote:
>> >>>
>> >>> Hi guys,
>> >>>
>> >>> Can some one take a look at following PR's?
>> >>>
>> >>> Startup and shutdown fixes - TOMEE-2454
>> >>> <https://github.com/apache/tomee/pull/371>
>> >>> increase the time to wait for sweeps.
>> >>> <https://github.com/apache/tomee/pull/363>
>> >>> Make observers more CDI like. This will make the commented 
test to

>> >>> work. <https://github.com/apache/tomee/pull/362>
>> >>> Issue is closed and TomEE uses more recent version
>> >>> <https://github.com/apache/tomee/pull/361>
>> >>> Cleanup test code and also minor changes in the tested class.
>> >>> <https://github.com/apache/tomee/pull/360>
>> >>>
>> >>> thanks
>> >>> --
>> >>> Doychin Bondzhev
>> >>> dSoft-Bulgaria Ltd.
>> >>> PowerPro - billing & provisioning solution for Service providers
>> >>> http://www.dsoft-bg.com/
>> >>> Mobile: +359888243116
>>
>>
>> 


>> If you reply to this email, your message will be added to the
>> discussion below:
>> 
http://tomee-openejb.979440.n4.nabble.com/Looking-for-review-on-PR-tp4687577p4687596.html 


>>
>> To start a new topic under TomEE Dev, email
>> [hidden email] 
>> To unsubscribe from TomEE Dev, click here
>> <
>> NAML
>> 
<http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer=instant_html%21nabble%3Aemail.naml=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> 


>>
>
>
> --
> Doychin Bondzhev
> dSoft-Bulgaria Ltd.
>

PR review and merge

2019-01-23 Thread Bruno Baptista

Hi,

Can one of the committers please take a look at these PRs?

https://github.com/apache/tomee/pull/377
https://github.com/apache/tomee/pull/376
https://github.com/apache/tomee/pull/375
https://github.com/apache/tomee/pull/370
https://github.com/apache/tomee/pull/366
https://github.com/apache/tomee/pull/363
https://github.com/apache/tomee/pull/362
https://github.com/apache/tomee/pull/361

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Looking for review on PR

2019-01-21 Thread Bruno Baptista

Sure Doychin,

Looking forward for that update.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 21/01/19 15:10, Doychin Bondzhev wrote:

Hi Bruno,

I think I found why AutoConnectionTrackerTest fails.

In some cases GC is not fast enough to place leaked references into 
ReferenceQueue. When setEnvironment is called right after GC there is 
a small chance that some references did not manage to get to 
referenceQueue on time for the check that queue is empty. In order to 
test that theory I added small delay and second poll to the queue and 
suddenly I got reference.


I will update my PR about AutoConnectionTracker and 
AutoConnectionTrackerTest with new changes.


If you don't like the way I did the delay I'm open to suggestions.

Have a nice day.

On 20.1.2019 г. 14:13, brunobat [via TomEE & OpenEJB] wrote:

Hi Doychin,

I've run all the tests on the merge of the 5 PRs.

I encountered 2 errors. They might be transient ones. Can you please
take a look?


arquillian-tomee-jms-tests
[ERROR]   EnvEntryTest.test:105 » EJB The bean encountered a
non-application exception; ...

openejb-core
[ERROR]   AutoConnectionTrackerTest.test:203->assertLogs:209 Detected
abandoned connection expected:<1> but was:<0>


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 18/01/19 18:32, Bruno Baptista wrote:

>
> Hi Doychin,
>
> Thanks for the contribution!
>
> I've approved a couple and left comments in 2 others.
>
> Will run all the tests when I get home.
>
> Cheers
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 18/01/19 17:46, Bruno Baptista wrote:
>>
>> Hi Doychin,
>>
>> I'll have a look.
>>
>> Cheers
>>
>> Bruno Baptista
>> https://twitter.com/brunobat_
>>
>>
>> On 18/01/19 17:41, Doychin Bondzhev wrote:
>>>
>>> Hi guys,
>>>
>>> Can some one take a look at following PR's?
>>>
>>> Startup and shutdown fixes - TOMEE-2454
>>> <https://github.com/apache/tomee/pull/371>
>>> increase the time to wait for sweeps.
>>> <https://github.com/apache/tomee/pull/363>
>>> Make observers more CDI like. This will make the commented test to
>>> work. <https://github.com/apache/tomee/pull/362>
>>> Issue is closed and TomEE uses more recent version
>>> <https://github.com/apache/tomee/pull/361>
>>> Cleanup test code and also minor changes in the tested class.
>>> <https://github.com/apache/tomee/pull/360>
>>>
>>> thanks
>>> --
>>> Doychin Bondzhev
>>> dSoft-Bulgaria Ltd.
>>> PowerPro - billing & provisioning solution for Service providers
>>> http://www.dsoft-bg.com/
>>> Mobile: +359888243116



If you reply to this email, your message will be added to the 
discussion below:
http://tomee-openejb.979440.n4.nabble.com/Looking-for-review-on-PR-tp4687577p4687596.html 

To start a new topic under TomEE Dev, email 
ml+s979440n982480...@n4.nabble.com
To unsubscribe from TomEE Dev, click here 
<http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code=982480=ZG95Y2hpbkBkc29mdC1iZy5jb218OTgyNDgwfC0xNTI2MjM5MTA3>.
NAML 
<http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer=instant_html%21nabble%3Aemail.naml=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> 




--
Doychin Bondzhev
dSoft-Bulgaria Ltd.
PowerPro - billing & provisioning solution for Service providers
http://www.dsoft-bg.com/
Mobile: +359888243116


Re: How can I help?

2019-01-21 Thread Bruno Baptista

Thanks Bogdan,

I've approved your PR.

I see that you also submitted:

https://issues.apache.org/jira/browse/TOMEE-2455

with PR:

https://github.com/apache/tomee/pull/375

I'm building the container to see if it doesn't break anything.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 19/01/19 16:52, Bogdan Stirbat wrote:

Thanks!

I've added a new pull request, https://github.com/apache/tomee/pull/379 .

În sâm., 19 ian. 2019 la 14:58, Richard Monson-Haefel <
monsonhae...@gmail.com> a scris:


Welcome to TomEE, Bogdan!

On Thu, Jan 17, 2019 at 1:34 PM Bogdan Stirbat 
wrote:


Hi!


I am Bogdan Știrbăț, a software engineer located in Bucharest, Romania.

I'm

interested in JEE, Spring, enterprise computing, microservices.

I find working on this project is an opportunity to both learn more about
the topics I'm interested in, and to contribute something back to the
community. Therefore, I would kike to ask how can I help.


Thanks,
Bogdan



--
Richard Monson-Haefel
https://twitter.com/rmonson
https://www.linkedin.com/in/monsonhaefel/



Re: Looking for review on PR

2019-01-20 Thread Bruno Baptista

Hi Doychin,

I've run all the tests on the merge of the 5 PRs.

I encountered 2 errors. They might be transient ones. Can you please 
take a look?



arquillian-tomee-jms-tests
[ERROR]   EnvEntryTest.test:105 » EJB The bean encountered a 
non-application exception; ...


openejb-core
[ERROR]   AutoConnectionTrackerTest.test:203->assertLogs:209 Detected 
abandoned connection expected:<1> but was:<0>



Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 18/01/19 18:32, Bruno Baptista wrote:


Hi Doychin,

Thanks for the contribution!

I've approved a couple and left comments in 2 others.

Will run all the tests when I get home.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 18/01/19 17:46, Bruno Baptista wrote:


Hi Doychin,

I'll have a look.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 18/01/19 17:41, Doychin Bondzhev wrote:


Hi guys,

Can some one take a look at following PR's?

Startup and shutdown fixes - TOMEE-2454 
<https://github.com/apache/tomee/pull/371>
increase the time to wait for sweeps. 
<https://github.com/apache/tomee/pull/363>
Make observers more CDI like. This will make the commented test to 
work. <https://github.com/apache/tomee/pull/362>
Issue is closed and TomEE uses more recent version 
<https://github.com/apache/tomee/pull/361>
Cleanup test code and also minor changes in the tested class. 
<https://github.com/apache/tomee/pull/360>


thanks
--
Doychin Bondzhev
dSoft-Bulgaria Ltd.
PowerPro - billing & provisioning solution for Service providers
http://www.dsoft-bg.com/
Mobile: +359888243116


Re: Jakarta EE TCKs and compatibility logo

2019-01-19 Thread Bruno Baptista

+1 to use the logo.

Bruno Baptista
https://twitter.com/brunobat_


On 19/01/19 00:47, David Blevins wrote:

This would be a +1 from me.

Adding some additional context that this doesn't just affect use of the 
compatible logo, but ability to be listed with all the other certified servers 
on the jakarta.ee website.


-David


On 2019/01/18 22:53:08, Mark Thomas  wrote:

Hi all,>

I am writing to your dev@ lists (on BCC) as your project has, in the>
past, requested access to the Java EE TCKs while they were controlled by>
Sun and then Oracle.>

As I am sure you are aware, Java EE has moved to Eclipse and is now>
Jakarta EE. The good news is that the TCKs have been open sourced.>

https://github.com/eclipse-ee4j/jakartaee-tck>

(I haven't tried to build the latest TCK from source yet but it is on my>
TODO list.)>

Shipping compatible implementations of the Jakarta EE specs (and being>
able to make public statements to that effect) will be subject only to>
the spec [1] and TCK [2] licenses. There will no longer be a TCK>
agreement or NDA to sign. However...>

The question has arisen whether or not any ASF projects will want to use>
the Jakarta EE compatible logo [3]. If a project wants to be able to do>
this, there are some organisational hoops to jump through. Before the>
ASF starts down that path the board has asked me to see if there are any>
projects that want to use the Jakarta EE compatible logo. After all,>
there is no point jumping through the hoops if no-one wants to use the logo.>

With the above in mind can you please discuss this amongst your project>
community and reply back to jcp-o...@apache.org whether or not your>
project is interested in being able to use the Jakarta EE compatible>
logo. I ask that you complete this no later than the next board meeting>
(20th February 2019).>

If you have any questions about any of the above, please also use>
jcp-o...@apache.org to ask them.>

Thanks,>

Mark>


[1] https://www.eclipse.org/legal/efsl.php>
[2] https://www.eclipse.org/legal/tck.php>
[3] https://www.eclipse.org/legal/tck.php>
  


Re: Looking for review on PR

2019-01-18 Thread Bruno Baptista

Hi Doychin,

Thanks for the contribution!

I've approved a couple and left comments in 2 others.

Will run all the tests when I get home.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 18/01/19 17:46, Bruno Baptista wrote:


Hi Doychin,

I'll have a look.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 18/01/19 17:41, Doychin Bondzhev wrote:


Hi guys,

Can some one take a look at following PR's?

Startup and shutdown fixes - TOMEE-2454 
<https://github.com/apache/tomee/pull/371>
increase the time to wait for sweeps. 
<https://github.com/apache/tomee/pull/363>
Make observers more CDI like. This will make the commented test to 
work. <https://github.com/apache/tomee/pull/362>
Issue is closed and TomEE uses more recent version 
<https://github.com/apache/tomee/pull/361>
Cleanup test code and also minor changes in the tested class. 
<https://github.com/apache/tomee/pull/360>


thanks
--
Doychin Bondzhev
dSoft-Bulgaria Ltd.
PowerPro - billing & provisioning solution for Service providers
http://www.dsoft-bg.com/
Mobile: +359888243116


Re: Looking for review on PR

2019-01-18 Thread Bruno Baptista

Hi Doychin,

I'll have a look.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 18/01/19 17:41, Doychin Bondzhev wrote:


Hi guys,

Can some one take a look at following PR's?

Startup and shutdown fixes - TOMEE-2454 
<https://github.com/apache/tomee/pull/371>
increase the time to wait for sweeps. 
<https://github.com/apache/tomee/pull/363>
Make observers more CDI like. This will make the commented test to 
work. <https://github.com/apache/tomee/pull/362>
Issue is closed and TomEE uses more recent version 
<https://github.com/apache/tomee/pull/361>
Cleanup test code and also minor changes in the tested class. 
<https://github.com/apache/tomee/pull/360>


thanks
--
Doychin Bondzhev
dSoft-Bulgaria Ltd.
PowerPro - billing & provisioning solution for Service providers
http://www.dsoft-bg.com/
Mobile: +359888243116


Re: Update examples readme to include translation instructions - [TOMEE-2456]

2019-01-18 Thread Bruno Baptista

Hi César.

I left some comments.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 18/01/19 16:48, César Hernández Mendoza wrote:

Can you please review this PR:

https://github.com/apache/tomee/pull/376



Re: Ejemplos en Español

2019-01-16 Thread Bruno Baptista

Hi César,

The PR looks ok to me.

Thanks!

Bruno Baptista
https://twitter.com/brunobat_


On 16/01/19 23:44, César Hernández Mendoza wrote:

Hi!

I updated the code and now the PR is ready for review.
https://github.com/apache/tomee-site-generator/pull/16

@Bruno: I fixed the issue that was causing the test failure you identified.
@David: I implement your proposal of removing "en" to the path of the
default language (English).


El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
cesargu...@gmail.com>) escribió:


Thank you for the feedback,

  site navigation has links to /latest/examples/ and similar -- people were

issuing PRs for broken links in headers, footers, menues, all dec and
they're finally (hopefully) settled.

That's a good point, I was not aware of this /latest/examples/ reference
inside the docs and website. I only updated the doc.html page.

We don't have direct access to the second svn, so I don't know of any way

to avoid doubling the size of that second repo.

I don't follow you entirely on this one. So far my understanding is that
the process for building the site is divided into three major steps:

1) Download all the branches  into: tomee-site-generator/repos
2) Copy from /repos folder all the branches
into: tomee-site-generator/target/jbake/content
3) Bake the tomee-site-generator/target/jbake/content folder  structure
to generate the final website
in: tomee-site-generator/target/site-1.0-SNAPSHOT

My PR only touches step 2) without duplicating the content of the
documentation in English. I added /en  to standardize in the code the
indexing process that also is performed on step 2) to generate the
index.htmll per documentation Category, and Language on each Branch:

--tomee-site-generator/target/jbake/content/tomee-8.0
- en
  |--examples
- es
  |--examples
- index.adoc


Tomorrow I'm going to analyze how to remove /en from the website structure.


El lun., 14 ene. 2019 a las 17:45, David Blevins ()
escribió:


Little feedback on my side of the fence.  Can we avoid adding "en" to the
path of the default language?

Couple small reasons:

  - site navigation has links to /latest/examples/ and similar -- people
were issuing PRs for broken links in headers, footers, menues, all dec and
they're finally (hopefully) settled.

  - everything is in svn, the tomee-8.0 dir alone is 133M, and the site
overall is 1.7G.  The initial push took a few hours to sync and moving
everything into an 'en/' directory will double the size.  The process
actually involves one svn synching to another svn.  We don't have direct
access to the second svn, so I don't know of any way to avoid doubling the
size of that second repo.


--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com


On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <

cesargu...@gmail.com> wrote:

Thanks Bruno.
I'm working on fixing that test and will be back with an updated PR when
ready.

El lun., 14 ene. 2019 a las 5:33, Bruno Baptista ()
escribió:


Hi César,

I've reviewed the PR and found an error:


Tests in error:
   testProcess(org.apache.tomee.website.GroupedIndexTest):
java.io.FileNotFoundException:
/tmp/temp5520959884794493991dir/en/examples/index.html (No such file or
directory)

Tests run: 9, Failures: 0, Errors: 1, Skipped: 0

[INFO]




[INFO] BUILD FAILURE
[INFO]




Left a comment in the PR.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 11/01/19 22:23, César Hernández Mendoza wrote:

Hi all,
In case somebody is wondering how to review this PR
https://github.com/apache/tomee-site-generator/pull/16,
  once you have the PR on your local git:

1. build the project: `tomee-site-generator$ mvn clean install`
3. Build and run the project: `tomee-site-generator$ mvn  clean

compile

-Djbake.http=true`
4. The project should show in `http://localhost:8080/docs.html`

<http://localhost:8080/docs.html>

<http://localhost:8080/docs.html>

<http://localhost:8080/docs.html> the [es] link to the examples in

Spanish.

So far tomee master only has 1 readme translated into spanish but you

can

add more README_es.adoc files to any of your
`tomee-site-generator/repos/tomee-8.0/examples`.

I'm more than happy to resolve any questions that may arise for the

review

of this PR.



El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
cesargu...@gmail.com>) escribió:


Hi, The new PR with the requested changes is ready for review.

Now the internationalization for examples follows the format like:
example:  http://localhost:8080/tomee-8.0/es/examples/

I added a vide on the ticket:


https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926

El mié., 9 ene. 2019 a las 12:3

Re: JakartaEE TCK

2019-01-16 Thread Bruno Baptista

Also working here!

Thanks Daniel Cunha for the help you gave me.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 16/01/19 18:10, Daniel Cunha wrote:

I was missing to export the GF_HOME.
Now it is working as expected. Thanks! :)

Em qua, 16 de jan de 2019 às 13:27, Jonathan Gallimore <
jonathan.gallim...@gmail.com> escreveu:


Sounds like your TCK didn't build right. See if you have this:
classes/com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client.class
in the folder where you have extracted the TCK.

Jon

On Wed, Jan 16, 2019 at 4:22 PM Daniel Cunha 
wrote:


Hmm,

seems something wrong on my configuration?
Error: Could not find or load main class
com.sun.ts.tests.ejb30.bb.localaccess.statelessclient.
Client
Failed. unexpected exit code: exit code 1







Em qua, 16 de jan de 2019 às 13:18, Jonathan Gallimore <
jonathan.gallim...@gmail.com> escreveu:


Its better than some of the output we've seen but no. Those tests
should pass. Have a dig through the TomEE logs, and the javatest logs
(target/logs) and see if you can see any errors.

Jon

On Wed, Jan 16, 2019 at 4:02 PM Daniel Cunha 
wrote:


is expected to get this output:



===

 0/-1/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#exceptionTest1

- FAILED
 0/-2/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#exceptionTest2

- FAILED
 0/-3/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#exceptionTest3

- FAILED
 0/-4/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#exceptionTest4

- FAILED
 0/-5/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#exceptionTest5

- FAILED
 0/-6/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#passByReferenceTest1

- FAILED
 0/-7/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#passByReferenceTest2

- FAILED
 0/-8/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#passByReferenceTest3

- FAILED
 0/-9/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#passByReferenceTest4

- FAILED
 0/-10/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#passByReferenceTest5

- FAILED
 0/-11/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#passByValueTest

- FAILED
[ERROR] Java Result: 1
 0/-12/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#runtimeExceptionTest1

- FAILED
 0/-13/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#runtimeExceptionTest2

- FAILED
 0/-14/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#runtimeExceptionTest3

- FAILED
 0/-15/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#runtimeExceptionTest4

- FAILED
 0/-16/?0 -



com/sun/ts/tests/ejb30/bb/localaccess/statelessclient/Client#java#runtimeExceptionTest5

- FAILED




===

Completed running 16 tests (0:00:08.872):

 Passed: 0
 Failed: 16
 Errors: 0




===

?

Em qua, 16 de jan de 2019 às 12:48, Jean-Louis Monteiro <
jlmonte...@tomitribe.com> escreveu:


works much better. Thank you
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Jan 16, 2019 at 4:45 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:


Pushed a band-aid fix, that copies deps to target/lib and
${openejb.home}/lib. Hopefully this will at least get people

going.

Apologies for the issues.

Jon

On Wed, Jan 16, 2019 at 3:36 PM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:


I am working on it too, no worries. I'll keep you posted

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Jan 16, 2019 at 4:35 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:


Ok, weird. Something broke when I switched to
maven-dependency-plugin:copy-dependencies from
maven-dependency-plugin:copy.

Looking into it. Status of this is that it is incredibly raw

because

everyone seemed to want it right away, so any help to fix

issues

is

appreciated.
Jon

On Wed, Jan 16, 2019 at 3:29 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:


What command did you run?

Jon

On Wed, Jan 16, 2019 at 3:27 PM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:


Having this one now ...

[ERROR] Failed to execute goal
org.codehaus.gmaven:gmaven-plugin:1.5:execute

(setup-environment)

on

project openejb-tck: java.lang.AssertionError: Not a

directory

/Users/jlmonteiro/devs/apache/tomee-tck/./target/lib.

Expression:

dir.isDirectory() -> [Help 1]
org.apache.m

Re: JakartaEE TCK

2019-01-16 Thread Bruno Baptista

sure, taking a look.

Bruno Baptista
https://twitter.com/brunobat_


On 16/01/19 10:53, Jonathan Gallimore wrote:

I've just updated the instructions here:
https://github.com/apache/tomee-tck/blob/master/README.txt

It would be great if someone could try that out.

Thanks

Jon

On Wed, Jan 16, 2019 at 8:15 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:


Same status here 

Le mer. 16 janv. 2019 à 08:52, Gurkan Erdogdu  a
écrit :


I have successfully created the javaeetck-8.0_16-Jan-2019.zip.
My enviornment : macOS  Java(TM) SE Runtime Environment (build
1.8.0_161-b12)
Now, run some TCK tests :)
Regards.
Gurkan

On Tue, Jan 15, 2019 at 6:29 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:


Currently working on the harness here, and will update the README.

Thanks

for letting us know your result, glad its working.

Jon

On Tue, Jan 15, 2019 at 3:25 PM Bruno Baptista 

wrote:

Success here,

Thanks for the instructions, Jon!

Got this at the end:
drwxr-xr-x  3 brunobat brunobat  4096 jan 15 15:08 ./
drwxr-xr-x  3 brunobat brunobat  4096 jan 15 15:06 ../
-rw-r--r--  1 brunobat brunobat  4076 jan 15 15:06
cts-internal-8.0_15-Jan-2019.zip
-rw-r--r--  1 brunobat brunobat  2075 jan 15 15:08
excludelist_javaeetck-8.0_15-Jan-2019.zip
drwxr-xr-x 13 brunobat brunobat  4096 jan 15 15:06 javaeetck/
-rw-r--r--  1 brunobat brunobat 654049181 jan 15 15:08
javaeetck-8.0_15-Jan-2019.zip

at: jakartaee-tck/release/JAVAEE_BUILD/latest

Bruno Baptista
https://twitter.com/brunobat_


On 15/01/19 14:28, Jonathan Gallimore wrote:

Sorry, use the latest Ant 1.10 as opposed to 1.9.13.

(Copy/paste error!)

Thanks

Jon

On Tue, Jan 15, 2019 at 2:27 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:


Ok - could I get someone to give this a shot? (note the different
Glassfish URL):

git clone https://github.com/eclipse-ee4j/jakartaee-tck
cd jakaratee-tck
export WORKSPACE=$(pwd)
export GF_BUNDLE_URL=


https://jenkins.eclipse.org/glassfish/job/glassfish/job/EE4J_8/85/artifact/bundles/glassfish.zip

export GF_HOME=$WORKSPACE
export ANT_HOME=/home/jgallimore/Apps/apache-ant-1.9.13
export JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk-amd64
export PATH=$JAVA_HOME/bin:$ANT_HOME/bin/:$PATH
$WORKSPACE/docker/build_jakartaeetck.sh

Thanks

Jon

On Tue, Jan 15, 2019 at 2:24 PM César Hernández Mendoza <
cesargu...@gmail.com> wrote:


Hi,

I also left this running during the night, it seems my laptop

heated

the

office nicely but I also see a lot of this kind of errors [1]:
Then I kill the process since basically those `cannot find

symbol`

were

all
over the log.

[1]
   [ts.javac]   public void writeBytes(byte[] value) throws

JMSException {

   [ts.javac]   ^
   [ts.javac]   symbol:   class JMSException
   [ts.javac]   location: class BytesMessageTestImpl
   [ts.javac]



/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/BytesMessageTestImpl.java:804:

error: cannot find symbol
   [ts.javac]   throws JMSException {
   [ts.javac]  ^
   [ts.javac]   symbol:   class JMSException
   [ts.javac]   location: class BytesMessageTestImpl
   [ts.javac]



/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/BytesMessageTestImpl.java:833:

error: cannot find symbol
   [ts.javac]   public void writeObject(Object value) throws

JMSException {

   [ts.javac]^
   [ts.javac]   symbol:   class JMSException
   [ts.javac]   location: class BytesMessageTestImpl
   [ts.javac]



/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/BytesMessageTestImpl.java:872:

error: cannot find symbol
   [ts.javac]   public void reset() throws JMSException {
   [ts.javac]  ^
   [ts.javac]   symbol:   class JMSException
   [ts.javac]   location: class BytesMessageTestImpl
   [ts.javac]



/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/MessageTestImpl.java:46:

error: cannot find symbol
   [ts.javac]   private Destination JMSReplyTo;
   [ts.javac]   ^
   [ts.javac]   symbol:   class Destination
   [ts.javac]   location: class MessageTestImpl
   [ts.javac]



/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/MessageTestImpl.java:48:

error: cannot find symbol
   [ts.javac]   private Destination JMSDestination;
   [ts.javac]   ^
   [ts.javac]   symbol:   class Destination
   [ts.javac]   location: class MessageTestImpl
   [ts.javac]



/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/MessageTestImpl.java:90:

error: cannot find symbol
   [ts.javac]   public String getJMSMessageID() throws

JMSException

{

   [ts.javac]  ^
   [ts.javac]   symbol:   class JMSException
   [ts.javac]   location: class MessageTestImpl
   [ts.javac]



/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/MessageTestImpl.java:104:

error: cannot 

Re: JakartaEE TCK

2019-01-15 Thread Bruno Baptista

Success here,

Thanks for the instructions, Jon!

Got this at the end:
drwxr-xr-x  3 brunobat brunobat  4096 jan 15 15:08 ./
drwxr-xr-x  3 brunobat brunobat  4096 jan 15 15:06 ../
-rw-r--r--  1 brunobat brunobat  4076 jan 15 15:06 
cts-internal-8.0_15-Jan-2019.zip
-rw-r--r--  1 brunobat brunobat  2075 jan 15 15:08 
excludelist_javaeetck-8.0_15-Jan-2019.zip

drwxr-xr-x 13 brunobat brunobat  4096 jan 15 15:06 javaeetck/
-rw-r--r--  1 brunobat brunobat 654049181 jan 15 15:08 
javaeetck-8.0_15-Jan-2019.zip


at: jakartaee-tck/release/JAVAEE_BUILD/latest

Bruno Baptista
https://twitter.com/brunobat_


On 15/01/19 14:28, Jonathan Gallimore wrote:

Sorry, use the latest Ant 1.10 as opposed to 1.9.13.

(Copy/paste error!)

Thanks

Jon

On Tue, Jan 15, 2019 at 2:27 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:


Ok - could I get someone to give this a shot? (note the different
Glassfish URL):

git clone https://github.com/eclipse-ee4j/jakartaee-tck
cd jakaratee-tck
export WORKSPACE=$(pwd)
export GF_BUNDLE_URL=
https://jenkins.eclipse.org/glassfish/job/glassfish/job/EE4J_8/85/artifact/bundles/glassfish.zip
export GF_HOME=$WORKSPACE
export ANT_HOME=/home/jgallimore/Apps/apache-ant-1.9.13
export JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk-amd64
export PATH=$JAVA_HOME/bin:$ANT_HOME/bin/:$PATH
$WORKSPACE/docker/build_jakartaeetck.sh

Thanks

Jon

On Tue, Jan 15, 2019 at 2:24 PM César Hernández Mendoza <
cesargu...@gmail.com> wrote:


Hi,

I also left this running during the night, it seems my laptop heated the
office nicely but I also see a lot of this kind of errors [1]:
Then I kill the process since basically those `cannot find symbol` were
all
over the log.

[1]
  [ts.javac]   public void writeBytes(byte[] value) throws JMSException {
  [ts.javac]   ^
  [ts.javac]   symbol:   class JMSException
  [ts.javac]   location: class BytesMessageTestImpl
  [ts.javac]

/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/BytesMessageTestImpl.java:804:
error: cannot find symbol
  [ts.javac]   throws JMSException {
  [ts.javac]  ^
  [ts.javac]   symbol:   class JMSException
  [ts.javac]   location: class BytesMessageTestImpl
  [ts.javac]

/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/BytesMessageTestImpl.java:833:
error: cannot find symbol
  [ts.javac]   public void writeObject(Object value) throws JMSException {
  [ts.javac]^
  [ts.javac]   symbol:   class JMSException
  [ts.javac]   location: class BytesMessageTestImpl
  [ts.javac]

/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/BytesMessageTestImpl.java:872:
error: cannot find symbol
  [ts.javac]   public void reset() throws JMSException {
  [ts.javac]  ^
  [ts.javac]   symbol:   class JMSException
  [ts.javac]   location: class BytesMessageTestImpl
  [ts.javac]

/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/MessageTestImpl.java:46:
error: cannot find symbol
  [ts.javac]   private Destination JMSReplyTo;
  [ts.javac]   ^
  [ts.javac]   symbol:   class Destination
  [ts.javac]   location: class MessageTestImpl
  [ts.javac]

/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/MessageTestImpl.java:48:
error: cannot find symbol
  [ts.javac]   private Destination JMSDestination;
  [ts.javac]   ^
  [ts.javac]   symbol:   class Destination
  [ts.javac]   location: class MessageTestImpl
  [ts.javac]

/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/MessageTestImpl.java:90:
error: cannot find symbol
  [ts.javac]   public String getJMSMessageID() throws JMSException {
  [ts.javac]  ^
  [ts.javac]   symbol:   class JMSException
  [ts.javac]   location: class MessageTestImpl
  [ts.javac]

/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/MessageTestImpl.java:104:
error: cannot find symbol
  [ts.javac]   public void setJMSMessageID(String id) throws JMSException {
  [ts.javac] ^
  [ts.javac]   symbol:   class JMSException
  [ts.javac]   location: class MessageTestImpl
  [ts.javac]

/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/MessageTestImpl.java:118:
error: cannot find symbol
  [ts.javac]   public long getJMSTimestamp() throws JMSException {
  [ts.javac]^
  [ts.javac]   symbol:   class JMSException
  [ts.javac]   location: class MessageTestImpl
  [ts.javac]

/Users/cesar/git/jakartaee-tck/src/com/sun/ts/tests/jms/common/MessageTestImpl.java:132:
error: cannot find symbol
  [ts.javac]   public void setJMSTimestamp(long timestamp) throws
JMSException {
  [ts.javac]  ^
  [ts.javac]   symbol:   class JMSException
  [ts.javac]   location: class MessageTestImpl
  [ts.javac]

/Users/cesar/git/jakartaee-tck/sr

Re: Where do we remember outstanding dependency updates for release?

2019-01-15 Thread Bruno Baptista

Hi Frankie,

Nice topic. I'm not aware of a centralized place for that.  I think we 
could start by searching for *-SNAPSHOT dependencies.


Then we will need to research if the releases have been done and if not, 
shoot some emails and crate a subtask in that Jira to keep track.


Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 15/01/19 12:21, Frankie wrote:

Hi,

today I noticed that the Version of bval-jsr has to be updated to 2.0.1
because of missing properties for new Validation Constraints like NotEmpty.
But bval-jsr 2.0.1 is not yet released.
So before creating a redundant JIRA ticket I did some investigation and
found
http://tomee-openejb.979440.n4.nabble.com/Finish-the-bval-setup-td4685085.html.
In the there-mentioned PR the dependency is set to 2.0.1-SNAPSHOT.

I wondered if there is a place where I could have easily found such external
dependencies we are waiting for so that I can update it.
All I found was https://issues.apache.org/jira/browse/TOMEE-2115 ("TomEE-8
work"), but there are only two other tickets linked to ...

Any hints?

Thank you
Frankie



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html


Re: JakartaEE TCK

2019-01-15 Thread Bruno Baptista

Hey Jon,

On the Jakarta TCK min requirements they mention that it requires Ant 
1.10.5+


That might explain some errors.

Bruno Baptista
https://twitter.com/brunobat_


On 15/01/19 11:53, Jonathan Gallimore wrote:

need to change JAVA_HOME and ANT_HOME to match your environment. I'm
using Ant 1.9.13 and OpenJDK 8/Hotpsot from AdoptOpenJDK.


Re: How can I help?

2019-01-14 Thread Bruno Baptista

Hi Alfonso,

Welcome to TomEE!

Here you will find some useful reading about how to contribute:
http://tomee.apache.org/community/index.html

We have currently a couple of Epics targeted for new contributors, 
please check for instance:


Generation of MP examples: https://issues.apache.org/jira/browse/TOMEE-2285
Improving documentation: https://issues.apache.org/jira/browse/TOMEE-2369

In relation to the examples, depending on your interests, we can come up 
with some other suggestions.


If you have some other Idea just shout in the list!

Cheers

Bruno Baptista
https://twitter.com/brunobat_

Bruno Baptista
https://twitter.com/brunobat_


On 14/01/19 02:30, Alfonso Valdez wrote:

Hi folks, I'm interested in participate on this initiative. I'm a software
developer with at least 13 years of experience developing java solutions
principally based on java sdk 6,7 and 8 also I had experience using Java EE
6 and 7. Now I'm working with Java 8 and spring-boot with microservices for
fintech industry, please let me know How can I help?

Regards



Re: Ejemplos en Español

2019-01-14 Thread Bruno Baptista

Hi César,

I've reviewed the PR and found an error:


Tests in error:
  testProcess(org.apache.tomee.website.GroupedIndexTest): 
java.io.FileNotFoundException: 
/tmp/temp5520959884794493991dir/en/examples/index.html (No such file or 
directory)


Tests run: 9, Failures: 0, Errors: 1, Skipped: 0

[INFO] 


[INFO] BUILD FAILURE
[INFO] 



Left a comment in the PR.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 11/01/19 22:23, César Hernández Mendoza wrote:

Hi all,
In case somebody is wondering how to review this PR
https://github.com/apache/tomee-site-generator/pull/16,
  once you have the PR on your local git:

1. build the project: `tomee-site-generator$ mvn clean install`
3. Build and run the project: `tomee-site-generator$ mvn  clean compile
-Djbake.http=true`
4. The project should show in `http://localhost:8080/docs.html`
<http://localhost:8080/docs.html> the [es] link to the examples in Spanish.
So far tomee master only has 1 readme translated into spanish but you can
add more README_es.adoc files to any of your
`tomee-site-generator/repos/tomee-8.0/examples`.

I'm more than happy to resolve any questions that may arise for the review
of this PR.



El mié., 9 ene. 2019 a las 20:44, César Hernández Mendoza (<
cesargu...@gmail.com>) escribió:


Hi, The new PR with the requested changes is ready for review.

Now the internationalization for examples follows the format like:
example:  http://localhost:8080/tomee-8.0/es/examples/

I added a vide on the ticket:
https://issues.apache.org/jira/browse/TOMEE-2444?focusedCommentId=16738926=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16738926

El mié., 9 ene. 2019 a las 12:39, David Blevins ()
escribió:


On Jan 8, 2019, at 6:49 PM, César Hernández Mendoza <

cesargu...@gmail.com> wrote:

I have to be honest, I had to untie a couple of lambdas into loops
while I was studying and learning the code.
I need to improve my functional skills to refactor that code but in the
meantime, I'm moving forward and will tackle the code cleanup and

sharpness

once we all agree on the functionality itself.

That's absolutely fine.  Work at whatever language level you're
comfortable with.

I think as a project we should be very ok with people simplifying code so
they can understand it -- even if that means removing fancy new syntax.


-David




--
Atentamente:
César Hernández Mendoza.





Re: Safegard compile issue

2019-01-11 Thread Bruno Baptista

Thanks Jon.

I'll prepare a branch with the latest release, just in case.

Bruno Baptista
https://twitter.com/brunobat_


On 11/01/19 13:27, Jonathan Gallimore wrote:

I'll ask nicely on the Geronimo list and see if someone can deploy the
snapshot for us.

Jon

On Fri, Jan 11, 2019 at 1:26 PM Bruno Baptista  wrote:


yes, we are on the snapshot because it has unreleased bug fixes.

Unfortunately it seems that the snapshot isn't available. We could use
the previous release. The TCK should pass with it.

What do you think?

Bruno Baptista
https://twitter.com/brunobat_


On 11/01/19 13:06, Jonathan Gallimore wrote:

Hi

We're seeing this error on the build (


https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/996/steps/compile/logs/stdio

):

[ERROR] Failed to execute goal on project mp-common: Could not resolve
dependencies for project org.apache.tomee:mp-common:jar:8.0.0-SNAPSHOT:
Could not find artifact
org.apache.geronimo.safeguard:safeguard-impl:jar:1.2.1-SNAPSHOT in Apache
Snapshots (https://repository.apache.org/content/repositories/snapshots)

->

[Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
goal on project mp-common: Could not resolve dependencies for project
org.apache.tomee:mp-common:jar:8.0.0-SNAPSHOT: Could not find artifact
org.apache.geronimo.safeguard:safeguard-impl:jar:1.2.1-SNAPSHOT in Apache
Snapshots (https://repository.apache.org/content/repositories/snapshots)
at


org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:221)

at


org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:127)

at


org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:245)

at


org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:199)

at


org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)

at


org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)

at


org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)

at


org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)

at


org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)

at


org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)

at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at


sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

at


sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:498)
at


org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)

at


org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)

at


org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)

at

org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)

Caused by: org.apache.maven.project.DependencyResolutionException: Could
not resolve dependencies for project
org.apache.tomee:mp-common:jar:8.0.0-SNAPSHOT: Could not find artifact
org.apache.geronimo.safeguard:safeguard-impl:jar:1.2.1-SNAPSHOT in Apache
Snapshots (https://repository.apache.org/content/repositories/snapshots)
at


org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:211)

at


org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:195)

... 23 more
Caused by: org.eclipse.aether.resolution.DependencyResolutionException:
Could not find artifact
org.apache.geronimo.safeguard:safeguard-impl:jar:1.2.1-SNAPSHOT in Apache
Snapshots (https://repository.apache.org/content/repositories/snapshots)
at


org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:384)

at


org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:205)

... 24 more
Caused by: org.eclipse.aether.resolution.ArtifactResolutionException:

Could

not find artifact
org.apache.geronimo.safeguard:safeguard-impl:jar:1.2.1-SNAPSHOT in Apache
Snapshots (https://repository.apache.org/content/repositories/snapshots)
at


org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:

Re: Safegard compile issue

2019-01-11 Thread Bruno Baptista

yes, we are on the snapshot because it has unreleased bug fixes.

Unfortunately it seems that the snapshot isn't available. We could use 
the previous release. The TCK should pass with it.


What do you think?

Bruno Baptista
https://twitter.com/brunobat_


On 11/01/19 13:06, Jonathan Gallimore wrote:

Hi

We're seeing this error on the build (
https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/996/steps/compile/logs/stdio
):

[ERROR] Failed to execute goal on project mp-common: Could not resolve
dependencies for project org.apache.tomee:mp-common:jar:8.0.0-SNAPSHOT:
Could not find artifact
org.apache.geronimo.safeguard:safeguard-impl:jar:1.2.1-SNAPSHOT in Apache
Snapshots (https://repository.apache.org/content/repositories/snapshots) ->
[Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
goal on project mp-common: Could not resolve dependencies for project
org.apache.tomee:mp-common:jar:8.0.0-SNAPSHOT: Could not find artifact
org.apache.geronimo.safeguard:safeguard-impl:jar:1.2.1-SNAPSHOT in Apache
Snapshots (https://repository.apache.org/content/repositories/snapshots)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:221)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:127)
at
org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:245)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:199)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.project.DependencyResolutionException: Could
not resolve dependencies for project
org.apache.tomee:mp-common:jar:8.0.0-SNAPSHOT: Could not find artifact
org.apache.geronimo.safeguard:safeguard-impl:jar:1.2.1-SNAPSHOT in Apache
Snapshots (https://repository.apache.org/content/repositories/snapshots)
at
org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:211)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:195)
... 23 more
Caused by: org.eclipse.aether.resolution.DependencyResolutionException:
Could not find artifact
org.apache.geronimo.safeguard:safeguard-impl:jar:1.2.1-SNAPSHOT in Apache
Snapshots (https://repository.apache.org/content/repositories/snapshots)
at
org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:384)
at
org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:205)
... 24 more
Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: Could
not find artifact
org.apache.geronimo.safeguard:safeguard-impl:jar:1.2.1-SNAPSHOT in Apache
Snapshots (https://repository.apache.org/content/repositories/snapshots)
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:444)
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:246)
at
org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:367)
... 25 more
Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not
find artifact
org.apache.geronimo.safeguard:safeguard-impl:jar:1.2.1-SNAPSHOT in Apache
Snapshots (ht

Re: MP Metrics Counted / Docker

2019-01-11 Thread Bruno Baptista

Hi Jon,

Yes, please do add the profile.

Thanks

Bruno Baptista
https://twitter.com/brunobat_


On 11/01/19 13:20, Jonathan Gallimore wrote:

Hi

I merged a PR (yesterday, I think) that add docker to the MP Metrics
Counted example. It looks like plugin runs as part of the build, and if
docker isn't running and available, the build fails.

Any objections if I tweak this so you have to specify the actual goal or
use a profile to enable this? I think this is likely to fail on the CI
otherwise.

Many thanks

Jon



Re: Upgrade to Safeguard 1.2

2019-01-11 Thread Bruno Baptista

The new test run was successful.

It's ready for review.

Bruno Baptista
https://twitter.com/brunobat_


On 10/01/19 21:49, Bruno Baptista wrote:

Thanks Jean-Louis. It's appreciated. :)

The problem seems to be the testng version. Some TCK tests, on Config 
and JWT don't like the new v6.14.3. Will keep the old v6.8.21 globaly 
and override on the Fault Tolerance TCK.


We will have to come up with a migration plan.

I'm going to run all the tests again.

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 10/01/19 20:11, Jean-Louis Monteiro wrote:

We can go step by step, it's fine if it's not perfect.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Jan 10, 2019 at 3:43 PM Bruno Baptista  
wrote:



Talked too soon. I found some issues. Investigating now.

Bruno Baptista
https://twitter.com/brunobat_


On 10/01/19 14:34, Bruno Baptista wrote:

I've run the full build and it was green.

It should be good to go.

Bruno Baptista
https://twitter.com/brunobat_


On 09/01/19 23:24, Bruno Baptista wrote:

Hi,

The PR to integrate the latest Safeguard into TomEE is ready for
review here: https://github.com/apache/tomee/pull/365/

The TCK now passes with TomEE.

[INFO] Results:
[INFO]
[INFO] Tests run: 213, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]

I'll run a full build tomorrow because this upgrades a few
crosscutting libraries.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 18:06, Bruno Baptista wrote:

I think I found the problem.

The old version uses a different lifecycle event to declare the 
errors:


public void throwExceptions(@Observes AfterBeanDiscovery

afterBeanDiscovery) {
microProfileValidator.forThrowable(afterBeanDiscovery::addDefinitionError); 


}

The new one:
void addDefinitionErrors(@Observes AfterDeploymentValidation

validation) {
this.beansToValidate.stream().map(this::validate).filter(Objects::nonNull).forEach(validation::addDeploymentProblem); 


this.beansToValidate.clear();
}
/AfterBeanDiscovery/ happens before /AfterDeploymentValidation/.
My guess is that /AfterDeploymentValidation/ should not be used to
declare actual deployment problems.
This is probably a Safegard bug.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 17:53, Roberto Cortez wrote:
Yes, it was using a DefinitionException, but it shouldn’t matter 
that

much, since the problem should happen anyway as you describe.
On 8 Jan 2019, at 17:27, Bruno Baptista  
wrote:


Correct, but on the TCK, the FaultToleranceDefinitionException has

not been released yet...

I was also wondering about the old version while I was going for

some tea...

I'll run the same test on the old version and see want happens.

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 17:24, Roberto Cortez wrote:

Hum, I wonder how was that working before with the old version?

Are the expected exceptions new in the TCK? Looking into the 
code,

it seems they are there since 2017, and actually you changed the expect
from DefinitionException to FaultToleranceDefinitionException.

Anyway, in the previous Safeguard version the TCK executed fine,

and I guess the exception assertion was being done correctly, right?

On 8 Jan 2019, at 17:05, Bruno Baptista

wrote:

Hi folks,

This is a status update on the upgrade of Safeguard.

I was able to fix most issues, but a deeper problem remains.

When an app is being deployed, the /SafeguardExtension/ goes 
over

it's annotations and if something wrong is detected, a
/DefinitionException/ is thrown, as expected. This works perfectly 
in the

standalone library.

The problem is that TomEE sees that exception through

OpenWebBeans, where the exception is swollen here:


https://github.com/apache/openwebbeans/blob/4c7ee3d192b56cc74e5218f99f7e7f5a78e60d56/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java#L1129 


Thus, the Arquillian deployment doesn't receive

/DefinitionException as expected/ but a /DeploymentException/.

Any suggestion on how to tackle this?

There is a work in progress here:

https://github.com/apache/tomee/pull/365

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Upgrade to Safeguard 1.2

2019-01-10 Thread Bruno Baptista

Thanks Jean-Louis. It's appreciated. :)

The problem seems to be the testng version. Some TCK tests, on Config 
and JWT don't like the new v6.14.3. Will keep the old v6.8.21 globaly 
and override on the Fault Tolerance TCK.


We will have to come up with a migration plan.

I'm going to run all the tests again.

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 10/01/19 20:11, Jean-Louis Monteiro wrote:

We can go step by step, it's fine if it's not perfect.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Jan 10, 2019 at 3:43 PM Bruno Baptista  wrote:


Talked too soon. I found some issues. Investigating now.

Bruno Baptista
https://twitter.com/brunobat_


On 10/01/19 14:34, Bruno Baptista wrote:

I've run the full build and it was green.

It should be good to go.

Bruno Baptista
https://twitter.com/brunobat_


On 09/01/19 23:24, Bruno Baptista wrote:

Hi,

The PR to integrate the latest Safeguard into TomEE is ready for
review here: https://github.com/apache/tomee/pull/365/

The TCK now passes with TomEE.

[INFO] Results:
[INFO]
[INFO] Tests run: 213, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]

I'll run a full build tomorrow because this upgrades a few
crosscutting libraries.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 18:06, Bruno Baptista wrote:

I think I found the problem.

The old version uses a different lifecycle event to declare the errors:

public void throwExceptions(@Observes AfterBeanDiscovery

afterBeanDiscovery) {
microProfileValidator.forThrowable(afterBeanDiscovery::addDefinitionError);

}

The new one:
void addDefinitionErrors(@Observes AfterDeploymentValidation

validation) {
this.beansToValidate.stream().map(this::validate).filter(Objects::nonNull).forEach(validation::addDeploymentProblem);

  this.beansToValidate.clear();
}
/AfterBeanDiscovery/ happens before /AfterDeploymentValidation/.
My guess is that /AfterDeploymentValidation/ should not be used to
declare actual deployment problems.
This is probably a Safegard bug.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 17:53, Roberto Cortez wrote:

Yes, it was using a DefinitionException, but it shouldn’t matter that

much, since the problem should happen anyway as you describe.

On 8 Jan 2019, at 17:27, Bruno Baptista  wrote:

Correct, but on the TCK, the FaultToleranceDefinitionException has

not been released yet...

I was also wondering about the old version while I was going for

some tea...

I'll run the same test on the old version and see want happens.

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 17:24, Roberto Cortez wrote:

Hum, I wonder how was that working before with the old version?

Are the expected exceptions new in the TCK? Looking into the code,

it seems they are there since 2017, and actually you changed the expect
from DefinitionException to FaultToleranceDefinitionException.

Anyway, in the previous Safeguard version the TCK executed fine,

and I guess the exception assertion was being done correctly, right?

On 8 Jan 2019, at 17:05, Bruno Baptista

wrote:

Hi folks,

This is a status update on the upgrade of Safeguard.

I was able to fix most issues, but a deeper problem remains.

When an app is being deployed, the /SafeguardExtension/ goes over

it's annotations and if something wrong is detected, a
/DefinitionException/ is thrown, as expected. This works perfectly in the
standalone library.

The problem is that TomEE sees that exception through

OpenWebBeans, where the exception is swollen here:



https://github.com/apache/openwebbeans/blob/4c7ee3d192b56cc74e5218f99f7e7f5a78e60d56/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java#L1129

Thus, the Arquillian deployment doesn't receive

/DefinitionException as expected/ but a /DeploymentException/.

Any suggestion on how to tackle this?

There is a work in progress here:

https://github.com/apache/tomee/pull/365

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Upgrade to Safeguard 1.2

2019-01-10 Thread Bruno Baptista

Talked too soon. I found some issues. Investigating now.

Bruno Baptista
https://twitter.com/brunobat_


On 10/01/19 14:34, Bruno Baptista wrote:


I've run the full build and it was green.

It should be good to go.

Bruno Baptista
https://twitter.com/brunobat_


On 09/01/19 23:24, Bruno Baptista wrote:


Hi,

The PR to integrate the latest Safeguard into TomEE is ready for 
review here: https://github.com/apache/tomee/pull/365/


The TCK now passes with TomEE.

[INFO] Results:
[INFO]
[INFO] Tests run: 213, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]

I'll run a full build tomorrow because this upgrades a few 
crosscutting libraries.


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 18:06, Bruno Baptista wrote:


I think I found the problem.

The old version uses a different lifecycle event to declare the errors:

public void throwExceptions(@Observes AfterBeanDiscovery afterBeanDiscovery) {
 microProfileValidator.forThrowable(afterBeanDiscovery::addDefinitionError);
}

The new one:
void addDefinitionErrors(@Observes AfterDeploymentValidation validation) {
 
this.beansToValidate.stream().map(this::validate).filter(Objects::nonNull).forEach(validation::addDeploymentProblem);
 this.beansToValidate.clear();
}
/AfterBeanDiscovery/ happens before /AfterDeploymentValidation/.
My guess is that /AfterDeploymentValidation/ should not be used to 
declare actual deployment problems.

This is probably a Safegard bug.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 17:53, Roberto Cortez wrote:

Yes, it was using a DefinitionException, but it shouldn’t matter that much, 
since the problem should happen anyway as you describe.


On 8 Jan 2019, at 17:27, Bruno Baptista  wrote:

Correct, but on the TCK, the FaultToleranceDefinitionException has not been 
released yet...

I was also wondering about the old version while I was going for some tea...

I'll run the same test on the old version and see want happens.

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 17:24, Roberto Cortez wrote:

Hum, I wonder how was that working before with the old version?

Are the expected exceptions new in the TCK? Looking into the code, it seems 
they are there since 2017, and actually you changed the expect from 
DefinitionException to FaultToleranceDefinitionException.

Anyway, in the previous Safeguard version the TCK executed fine, and I guess 
the exception assertion was being done correctly, right?


On 8 Jan 2019, at 17:05, Bruno Baptista  wrote:

Hi folks,

This is a status update on the upgrade of Safeguard.

I was able to fix most issues, but a deeper problem remains.

When an app is being deployed, the /SafeguardExtension/ goes over it's 
annotations and if something wrong is detected, a /DefinitionException/ is 
thrown, as expected. This works perfectly in the standalone library.

The problem is that TomEE sees that exception through OpenWebBeans, where the 
exception is swollen here:

https://github.com/apache/openwebbeans/blob/4c7ee3d192b56cc74e5218f99f7e7f5a78e60d56/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java#L1129

Thus, the Arquillian deployment doesn't receive /DefinitionException as 
expected/ but a /DeploymentException/.

Any suggestion on how to tackle this?

There is a work in progress here:https://github.com/apache/tomee/pull/365

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Upgrade to Safeguard 1.2

2019-01-10 Thread Bruno Baptista

I've run the full build and it was green.

It should be good to go.

Bruno Baptista
https://twitter.com/brunobat_


On 09/01/19 23:24, Bruno Baptista wrote:


Hi,

The PR to integrate the latest Safeguard into TomEE is ready for 
review here: https://github.com/apache/tomee/pull/365/


The TCK now passes with TomEE.

[INFO] Results:
[INFO]
[INFO] Tests run: 213, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]

I'll run a full build tomorrow because this upgrades a few 
crosscutting libraries.


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 18:06, Bruno Baptista wrote:


I think I found the problem.

The old version uses a different lifecycle event to declare the errors:

public void throwExceptions(@Observes AfterBeanDiscovery afterBeanDiscovery) {
 microProfileValidator.forThrowable(afterBeanDiscovery::addDefinitionError);
}

The new one:
void addDefinitionErrors(@Observes AfterDeploymentValidation validation) {
 
this.beansToValidate.stream().map(this::validate).filter(Objects::nonNull).forEach(validation::addDeploymentProblem);
 this.beansToValidate.clear();
}
/AfterBeanDiscovery/ happens before /AfterDeploymentValidation/.
My guess is that /AfterDeploymentValidation/ should not be used to 
declare actual deployment problems.

This is probably a Safegard bug.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 17:53, Roberto Cortez wrote:

Yes, it was using a DefinitionException, but it shouldn’t matter that much, 
since the problem should happen anyway as you describe.


On 8 Jan 2019, at 17:27, Bruno Baptista  wrote:

Correct, but on the TCK, the FaultToleranceDefinitionException has not been 
released yet...

I was also wondering about the old version while I was going for some tea...

I'll run the same test on the old version and see want happens.

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 17:24, Roberto Cortez wrote:

Hum, I wonder how was that working before with the old version?

Are the expected exceptions new in the TCK? Looking into the code, it seems 
they are there since 2017, and actually you changed the expect from 
DefinitionException to FaultToleranceDefinitionException.

Anyway, in the previous Safeguard version the TCK executed fine, and I guess 
the exception assertion was being done correctly, right?


On 8 Jan 2019, at 17:05, Bruno Baptista  wrote:

Hi folks,

This is a status update on the upgrade of Safeguard.

I was able to fix most issues, but a deeper problem remains.

When an app is being deployed, the /SafeguardExtension/ goes over it's 
annotations and if something wrong is detected, a /DefinitionException/ is 
thrown, as expected. This works perfectly in the standalone library.

The problem is that TomEE sees that exception through OpenWebBeans, where the 
exception is swollen here:

https://github.com/apache/openwebbeans/blob/4c7ee3d192b56cc74e5218f99f7e7f5a78e60d56/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java#L1129

Thus, the Arquillian deployment doesn't receive /DefinitionException as 
expected/ but a /DeploymentException/.

Any suggestion on how to tackle this?

There is a work in progress here:https://github.com/apache/tomee/pull/365

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Upgrade to Safeguard 1.2

2019-01-09 Thread Bruno Baptista

Hi,

The PR to integrate the latest Safeguard into TomEE is ready for review 
here: https://github.com/apache/tomee/pull/365/


The TCK now passes with TomEE.

[INFO] Results:
[INFO]
[INFO] Tests run: 213, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]

I'll run a full build tomorrow because this upgrades a few crosscutting 
libraries.


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 18:06, Bruno Baptista wrote:


I think I found the problem.

The old version uses a different lifecycle event to declare the errors:

public void throwExceptions(@Observes AfterBeanDiscovery afterBeanDiscovery) {
 microProfileValidator.forThrowable(afterBeanDiscovery::addDefinitionError);
}

The new one:
void addDefinitionErrors(@Observes AfterDeploymentValidation validation) {
 
this.beansToValidate.stream().map(this::validate).filter(Objects::nonNull).forEach(validation::addDeploymentProblem);
 this.beansToValidate.clear();
}
/AfterBeanDiscovery/ happens before /AfterDeploymentValidation/.
My guess is that /AfterDeploymentValidation/ should not be used to 
declare actual deployment problems.

This is probably a Safegard bug.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 17:53, Roberto Cortez wrote:

Yes, it was using a DefinitionException, but it shouldn’t matter that much, 
since the problem should happen anyway as you describe.


On 8 Jan 2019, at 17:27, Bruno Baptista  wrote:

Correct, but on the TCK, the FaultToleranceDefinitionException has not been 
released yet...

I was also wondering about the old version while I was going for some tea...

I'll run the same test on the old version and see want happens.

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 17:24, Roberto Cortez wrote:

Hum, I wonder how was that working before with the old version?

Are the expected exceptions new in the TCK? Looking into the code, it seems 
they are there since 2017, and actually you changed the expect from 
DefinitionException to FaultToleranceDefinitionException.

Anyway, in the previous Safeguard version the TCK executed fine, and I guess 
the exception assertion was being done correctly, right?


On 8 Jan 2019, at 17:05, Bruno Baptista  wrote:

Hi folks,

This is a status update on the upgrade of Safeguard.

I was able to fix most issues, but a deeper problem remains.

When an app is being deployed, the /SafeguardExtension/ goes over it's 
annotations and if something wrong is detected, a /DefinitionException/ is 
thrown, as expected. This works perfectly in the standalone library.

The problem is that TomEE sees that exception through OpenWebBeans, where the 
exception is swollen here:

https://github.com/apache/openwebbeans/blob/4c7ee3d192b56cc74e5218f99f7e7f5a78e60d56/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java#L1129

Thus, the Arquillian deployment doesn't receive /DefinitionException as 
expected/ but a /DeploymentException/.

Any suggestion on how to tackle this?

There is a work in progress here:https://github.com/apache/tomee/pull/365

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Examples with cloud providers

2019-01-09 Thread Bruno Baptista
Yup, sounds good to me. Everything that helps the users to make happy 
deployments should give a nice example.


Bruno Baptista
https://twitter.com/brunobat_


On 09/01/19 18:01, César Hernández Mendoza wrote:

sounds good Bruno, I think the credentials issue should be something just
mentioned as a side note in each document.
Now that you trigger this thread, I also wonder if a TomEE on Docker
examples or tutorial would be also good to add.

El mié., 9 ene. 2019 a las 10:56, Bruno Baptista ()
escribió:


Hi Folks,

I was thinking that we could create a series of examples or tutorials
that use demo apps with TomEE deployed in major cloud providers like
Azure, AWS, Oracle, etc.

I would like to start by Azure...

Examples have some challenges because we cannot actually produce fully
working examples due to the need of credentials. So maybe a
documentation tutorial would be more appropriate.

What do you guys think?

--
Bruno Baptista
https://twitter.com/brunobat_





Examples with cloud providers

2019-01-09 Thread Bruno Baptista

Hi Folks,

I was thinking that we could create a series of examples or tutorials 
that use demo apps with TomEE deployed in major cloud providers like 
Azure, AWS, Oracle, etc.


I would like to start by Azure...

Examples have some challenges because we cannot actually produce fully 
working examples due to the need of credentials. So maybe a 
documentation tutorial would be more appropriate.


What do you guys think?

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Optmizes try catch #323

2019-01-09 Thread Bruno Baptista

The PR looks good to me.

Thanks Otávio and Happy Birthday to you!

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 09/01/19 10:59, Jean-Louis Monteiro wrote:

I reviewed it and though I merged it, but probably dreamt it. Sorry
about that
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Jan 9, 2019 at 11:54 AM Bruno Baptista  wrote:


Hi Otávio,

I will take a look.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 09/01/19 10:16, Otávio Gonçalves de Santana wrote:

Thank you for the review guys.
Could someone move it forward it, please?

On Fri, Dec 28, 2018 at 3:47 PM Otávio Gonçalves de Santana <
osant...@tomitribe.com> wrote:


 -

 Optimizes the try using the try-with-resources that allows us to
 declare resources to be used in a try block with the assurance that

the

 resources will be closed when after execution of that block. An ARM
 automatic resource management by the JVM.
 -

 The use of multi-catch that removes redundancies catch treatment.

https://github.com/apache/tomee/pull/323



Re: Optmizes try catch #323

2019-01-09 Thread Bruno Baptista

Hi Otávio,

I will take a look.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 09/01/19 10:16, Otávio Gonçalves de Santana wrote:

Thank you for the review guys.
Could someone move it forward it, please?

On Fri, Dec 28, 2018 at 3:47 PM Otávio Gonçalves de Santana <
osant...@tomitribe.com> wrote:


-

Optimizes the try using the try-with-resources that allows us to
declare resources to be used in a try block with the assurance that the
resources will be closed when after execution of that block. An ARM
automatic resource management by the JVM.
-

The use of multi-catch that removes redundancies catch treatment.

https://github.com/apache/tomee/pull/323



Re: Ejemplos en Español

2019-01-08 Thread Bruno Baptista

+1

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 19:22, David Blevins wrote:

My perspective is we should switch this around from:

  -http://localhost:8080/tomee-8.0/examples/fr/

To:

  -http://localhost:8080/tomee-8.0/fr/examples/


Re: Upgrade to Safeguard 1.2

2019-01-08 Thread Bruno Baptista

I think I found the problem.

The old version uses a different lifecycle event to declare the errors:

public void throwExceptions(@Observes AfterBeanDiscovery afterBeanDiscovery) {
microProfileValidator.forThrowable(afterBeanDiscovery::addDefinitionError);
}

The new one:
void addDefinitionErrors(@Observes AfterDeploymentValidation validation) {

this.beansToValidate.stream().map(this::validate).filter(Objects::nonNull).forEach(validation::addDeploymentProblem);
this.beansToValidate.clear();
}

/AfterBeanDiscovery/ happens before /AfterDeploymentValidation/.
My guess is that /AfterDeploymentValidation/ should not be used to 
declare actual deployment problems.

This is probably a Safegard bug.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 17:53, Roberto Cortez wrote:

Yes, it was using a DefinitionException, but it shouldn’t matter that much, 
since the problem should happen anyway as you describe.


On 8 Jan 2019, at 17:27, Bruno Baptista  wrote:

Correct, but on the TCK, the FaultToleranceDefinitionException has not been 
released yet...

I was also wondering about the old version while I was going for some tea...

I'll run the same test on the old version and see want happens.

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 17:24, Roberto Cortez wrote:

Hum, I wonder how was that working before with the old version?

Are the expected exceptions new in the TCK? Looking into the code, it seems 
they are there since 2017, and actually you changed the expect from 
DefinitionException to FaultToleranceDefinitionException.

Anyway, in the previous Safeguard version the TCK executed fine, and I guess 
the exception assertion was being done correctly, right?


On 8 Jan 2019, at 17:05, Bruno Baptista  wrote:

Hi folks,

This is a status update on the upgrade of Safeguard.

I was able to fix most issues, but a deeper problem remains.

When an app is being deployed, the /SafeguardExtension/ goes over it's 
annotations and if something wrong is detected, a /DefinitionException/ is 
thrown, as expected. This works perfectly in the standalone library.

The problem is that TomEE sees that exception through OpenWebBeans, where the 
exception is swollen here:

https://github.com/apache/openwebbeans/blob/4c7ee3d192b56cc74e5218f99f7e7f5a78e60d56/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java#L1129

Thus, the Arquillian deployment doesn't receive /DefinitionException as 
expected/ but a /DeploymentException/.

Any suggestion on how to tackle this?

There is a work in progress here: https://github.com/apache/tomee/pull/365

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Upgrade to Safeguard 1.2

2019-01-08 Thread Bruno Baptista
Correct, but on the TCK, the FaultToleranceDefinitionException has not 
been released yet...


I was also wondering about the old version while I was going for some 
tea...


I'll run the same test on the old version and see want happens.

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 17:24, Roberto Cortez wrote:

Hum, I wonder how was that working before with the old version?

Are the expected exceptions new in the TCK? Looking into the code, it seems 
they are there since 2017, and actually you changed the expect from 
DefinitionException to FaultToleranceDefinitionException.

Anyway, in the previous Safeguard version the TCK executed fine, and I guess 
the exception assertion was being done correctly, right?


On 8 Jan 2019, at 17:05, Bruno Baptista  wrote:

Hi folks,

This is a status update on the upgrade of Safeguard.

I was able to fix most issues, but a deeper problem remains.

When an app is being deployed, the /SafeguardExtension/ goes over it's 
annotations and if something wrong is detected, a /DefinitionException/ is 
thrown, as expected. This works perfectly in the standalone library.

The problem is that TomEE sees that exception through OpenWebBeans, where the 
exception is swollen here:

https://github.com/apache/openwebbeans/blob/4c7ee3d192b56cc74e5218f99f7e7f5a78e60d56/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java#L1129

Thus, the Arquillian deployment doesn't receive /DefinitionException as 
expected/ but a /DeploymentException/.

Any suggestion on how to tackle this?

There is a work in progress here: https://github.com/apache/tomee/pull/365

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_




Upgrade to Safeguard 1.2

2019-01-08 Thread Bruno Baptista

Hi folks,

This is a status update on the upgrade of Safeguard.

I was able to fix most issues, but a deeper problem remains.

When an app is being deployed, the /SafeguardExtension/ goes over it's 
annotations and if something wrong is detected, a /DefinitionException/ 
is thrown, as expected. This works perfectly in the standalone library.


The problem is that TomEE sees that exception through OpenWebBeans, 
where the exception is swollen here:


https://github.com/apache/openwebbeans/blob/4c7ee3d192b56cc74e5218f99f7e7f5a78e60d56/webbeans-impl/src/main/java/org/apache/webbeans/util/WebBeansUtil.java#L1129

Thus, the Arquillian deployment doesn't receive /DefinitionException as 
expected/ but a /DeploymentException/.


Any suggestion on how to tackle this?

There is a work in progress here: https://github.com/apache/tomee/pull/365

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Performance issue with JMS on Tomee 7.0.5

2019-01-08 Thread Bruno Baptista

That's fine.

I now use the Eclipse Analyzer: https://www.eclipse.org/mat/

I found it recently from Matthew Broadhead, here on the list. It's much 
faster than jVisualVM.


Just sort by the retained memory values.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 08/01/19 16:11, exabrial12 wrote:

Hey Bruno,

I'll contact you privately to get it to you. The heap is a little more
sensitive than the jstack :) You'll have to describe the process you're
doing with it though so we can all learn



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html


Re: Performance issue with JMS on Tomee 7.0.5

2019-01-08 Thread Bruno Baptista

Hi Jon,

I'd like to have a look at the memory heap dump when available.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 07/01/19 14:35, exabrial12 wrote:

Thanks,

Issue opened here:
https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2449

We'll try and create a project that demonstrates the issue.



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html


Re: MicroProfile Fault Tolerance 1.1?

2019-01-08 Thread Bruno Baptista

Hi Doychin,

The jitter issue has been fixed in the latest snapshot.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 07/01/19 14:31, Doychin Bondzhev wrote:

I see now two issues.

I will try to report the the problem I found with jitter now.

On 7.1.2019 г. 15:05, Roberto Cortez [via TomEE & OpenEJB] wrote:
Hum… weird. Apparently you need to be logged in. Do you have an 
Apache JIRA account? If not, just create one and try again, please.


> On 7 Jan 2019, at 12:42, Doychin Bondzhev <[hidden email] 
> wrote:

>
> Thanks Roberto,
>
> Strange thing is that when I click the link that should display 
unresolved issues of safeguard I don't see any issues.

>
> I also don't see any issues at all when I remove the filter for 
status.

>
> On 7.1.2019 г. 14:10, Roberto Cortez [via TomEE & OpenEJB] wrote:
>> Hi Doychin,
>>
>> Safeguard is implemented under the Geronimo project umbrella, so 
if you need to report any issue, you need to report them in Geronimo 
JIRA:
>> 
https://jira.apache.org/jira/projects/GERONIMO <https://jira.apache.org/jira/projects/GERONIMO> 
<https://jira.apache.org/jira/projects/GERONIMO <https://jira.apache.org/jira/projects/GERONIMO>> 


>>
>> Here you can find some issues:
>> 
https://jira.apache.org/jira/issues/?jql=project%20%3D%20GERONIMO%20AND%20resolution%20%3D%20Unresolved%20AND%20text%20~%20%22safeguard%22%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC <https://jira.apache.org/jira/issues/?jql=project%20%3D%20GERONIMO%20AND%20resolution%20%3D%20Unresolved%20AND%20text%20~%20%22safeguard%22%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC> 
<https://jira.apache.org/jira/issues/?jql=project%20=%20GERONIMO%20AND%20resolution%20=%20Unresolved%20AND%20text%20~%20%22safeguard%22%20ORDER%20BY%20priority%20DESC,%20updated%20DESC <https://jira.apache.org/jira/issues/?jql=project%20=%20GERONIMO%20AND%20resolution%20=%20Unresolved%20AND%20text%20~%20%22safeguard%22%20ORDER%20BY%20priority%20DESC,%20updated%20DESC>> 


>>
>> Hope it helps!
>>
>> Cheers,
>> Roberto
>>
>> > On 7 Jan 2019, at 11:46, Doychin Bondzhev <[hidden email] 
> wrote:

>> >
>> > Actually this version of safegurad is not behaving properly with 
some tests which fail for different reasons.

>> >
>> > For example there is a bug in the implementation for jitter 
where if you provide 0 as value it will fail.
>> > Another problem I've noticed is when you run the tests for fault 
tolerance they fail because some embedded classes in safeguard are 
not recognized as CDI beans and when and instance have to be injected 
during test run test fails.

>> >
>> > If I add the these classes as part of the module and also add 
metrics API as test dependency test passes.

>> >
>> > That is why I asked where such problems can be reported back to 
safeguard developers.

>> > I can't find anything in Jirra regarding safeguard.
>> >
>> > On 7.1.2019 г. 13:16, Roberto Cortez [via TomEE & OpenEJB] wrote:
>> >> Yes,
>> >>
>> >> There is already a 1.1 Geronimo implementation compliant 
version (Safeguard). JL added it, but it was failing the TCK. We 
think we need to do some integration code to be able to use it 
properly. Bruno was going to do that, so we reverted back to 1.0 
version so we can have a green build until we figure that out.

>> >>
>> >> Please check the following thread:
>> >> 
https://lists.apache.org/thread.html/0bc1c82d064f16f1cf0a5b70a9670cfcabe6b6aa9b0397fa396638f6@%3Cdev.tomee.apache.org%3E <https://lists.apache.org/thread.html/0bc1c82d064f16f1cf0a5b70a9670cfcabe6b6aa9b0397fa396638f6@%3Cdev.tomee.apache.org%3E> 
<https://lists.apache.org/thread.html/0bc1c82d064f16f1cf0a5b70a9670cfcabe6b6aa9b0397fa396638f6@%3Cdev.tomee.apache.org%3E <https://lists.apache.org/thread.html/0bc1c82d064f16f1cf0a5b70a9670cfcabe6b6aa9b0397fa396638f6@%3Cdev.tomee.apache.org%3E>> 
<https://lists.apache.org/thread.html/0bc1c82d064f16f1cf0a5b70a9670cfcabe6b6aa9b0397fa396638f6@%3Cdev.tomee.apache.org%3E <https://lists.apache.org/thread.html/0bc1c82d064f16f1cf0a5b70a9670cfcabe6b6aa9b0397fa396638f6@%3Cdev.tomee.apache.org%3E> 
<https://lists.apache.org/thread.html/0bc1c82d064f16f1cf0a5b70a9670cfcabe6b6aa9b0397fa396638f6@%3Cdev.tomee.apache.org%3E <https://lists.apache.org/thread.html/0bc1c82d064f16f1cf0a5b70a9670cfcabe6b6aa9b0397fa396638f6@%3Cdev.tomee.apache.org%3E>>> 


>> >>
>> >> Cheers,
>> >> Roberto
>> >>
>> >> > On 6 Jan 2019, at 19:47, David Blevins <[hidden email] 
> wrote:

>> >> >
>> >> > Noticed we're using Fault Tolerance 1

Re: Stabilize TomEE Build

2019-01-03 Thread Bruno Baptista

Yes, I can have a look, but only next week.

Bruno Baptista
https://twitter.com/brunobat_


On 03/01/19 11:26, Roberto Cortez wrote:

Maybe Bruno would like to work on that, since he is heavily involved with the 
EG and he did the integration for the last version?


Re: Apache Github Repo moved to Gitbox

2019-01-03 Thread Bruno Baptista

Thanks Roberto.

The command is really handy.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 03/01/19 10:13, Roberto Cortez wrote:

Hi folks,

The TomEE repo was just moved to Gitbox.

This only applies if you have cloned the repo from Apache. If you cloned your 
repo from Github, no change is required.

If you were using the old git url:
https://git-wip-us.apache.org/repos/asf/tomee.git 
<https://git-wip-us.apache.org/repos/asf/tomee.git>

You now need to change it to use:
https://gitbox.apache.org/repos/asf/tomee.git 
<https://gitbox.apache.org/repos/asf/tomee.git>

You can do this change with the command:
git remote set-url YOUR_REMOTE_NAME https://gitbox.apache.org/repos/asf/tomee.git 
<https://gitbox.apache.org/repos/asf/tomee.git>

Cheers,
Roberto


Re: TomEE logo poll

2019-01-03 Thread Bruno Baptista

+1 for the plan

Bruno Baptista
https://twitter.com/brunobat_


On 02/01/19 13:52, Ivan Junckes Filho wrote:

The idea I had in mind is:

1 - Give a 1 week time for people to advocate for a logo. (Share the logo
in github issue)
2 - Give a 1 week time for voting (we would gather all the logos that
people advocated for and add to another github issue and ask for thumbs up)

The logo that gets more thumbs up in a range of a week wins!

So, not asking for +1 in a specific logo, but for the willingness of the
community to choose a logo using a poll mechanism.

On Wed, Jan 2, 2019 at 11:37 AM Richard Monson-Haefel <
monsonhae...@gmail.com> wrote:


Hi Ivan,

Your call to action on this is awesome but what exactly are we +1ing
about?  The act of considering a logo or are we +1ing David's Logo (by the
way the link on your post didn't work for me personally).

thanks!

Richard

On Wed, Jan 2, 2019 at 5:40 AM Ivan Junckes Filho 
wrote:


Would be nice to get some +1 or -1 from some committers here :)

On Fri, Dec 28, 2018 at 9:31 PM Bruno Baptista 

wrote:

+1

Bruno Baptista
https://twitter.com/brunobat_


On 28/12/18 16:32, Ivan Junckes Filho wrote:

Hey guys, we have been through this discussion before but I don't

think

we

ever had a conclusion. In my opinion would be very important for the
project to have a logo and now TomEE is getting a lot of exposure why

not

take advantage of the moment and promote TomEE even more with a great

logo?

These are some options proposed in the past:
https://issues.apache.org/jira/browse/TOMEE-574

We could do something like David did here for JakartaEE:
https://github.com/eclipse-ee4j/ee4j/issues/11

And the winning logo would be the one with the most number of thumbs

up.

What do you guys think?



--
Richard Monson-Haefel
https://twitter.com/rmonson
https://www.linkedin.com/in/monsonhaefel/



Re: Problems with some tests on Windows and proposed fixes.

2019-01-03 Thread Bruno Baptista

Hi Doychin,

Thanks for the PRs.

I left comments on:

https://github.com/apache/tomee/pull/345

https://github.com/apache/tomee/pull/347

https://github.com/apache/tomee/pull/349

Cheers!

Bruno Baptista
https://twitter.com/brunobat_


On 03/01/19 09:24, Doychin Bondzhev wrote:

Hi guys and Happy new year!

I'm right now in the process of completing full build of Tomee 8 on 
Windows.


I already have some changes implemented to some tests but I want to 
complete all build issues before I send them.


Here is a short list:

https://github.com/apache/tomee/pull/344

https://github.com/apache/tomee/pull/345

https://github.com/apache/tomee/pull/346

https://github.com/apache/tomee/pull/347

https://github.com/apache/tomee/pull/348

https://github.com/apache/tomee/pull/349

I have one more but it is related to the safeguard 1.2.0 that was 
reverted.




Re: Ejemplos en Español

2019-01-03 Thread Bruno Baptista

Hi Carlos,

Just chose a few documents, create the jiras and let us know them.

Cheers!

Bruno Baptista
https://twitter.com/brunobat_


On 03/01/19 01:11, Carlos Chacín wrote:

+1 please let me know how I can help

On Mon, Dec 24, 2018, 8:24 PM Daniel Dias Dos Santos <
daniel.dias.analist...@gmail.com wrote:


+1  :  )
--

*Daniel Dias dos Santos*
Java Developer
SouJava & JCP Member
GitHub: https://github.com/Daniel-Dos
Linkedin: www.linkedin.com/in/danieldiasjava
Twitter: http://twitter.com/danieldiasjava


Em seg, 24 de dez de 2018 às 21:28, David Blevins 
I say “game on” to any languages people want to contribute :)

In fact, let the PRs fly. I’ll write the site logic this week.

-David

On Mon, Dec 24, 2018 at 2:45 PM Mohammed Aboullaite <
aboullaite.moham...@gmail.com> wrote:


I think its a brilliant idea. it'll open the door for not only Spanish,

but

other languages as well (I'm thinking of French as well).



On Mon, Dec 24, 2018, 11:35 PM David Blevins 
I was talking with Hillmer on twitter about potentially translating
examples into Spanish.

The idea is that we could potentially do examples and documentation

in

Spanish.  Perhaps:

  - http://tomee.apache.org/tomee-8.0/es/docs/
  - http://tomee.apache.org/tomee-8.0/es/ejemplos/

First note is that how we organize the files in the git repo and how

we

organize them on the website can be completely different.  We use the
following code to collect all the examples together and do various

things

to them:

  -


https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42

Right now it will do a copy and rename, for example:

  -


https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md

  - http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html

We could theoretically do something as simple as this:

  -


https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md

  -

http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html

I.e. make a new file next to the original, then update our copying

logic

to put the prefix in the path.


Thoughts?


--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com



--
Sent from my iPhone



Re: TOMEE-2361 - Improve main README file

2019-01-02 Thread Bruno Baptista

Glad to help :)

Bruno Baptista
https://twitter.com/brunobat_


On 02/01/19 21:13, César Hernández Mendoza wrote:

Thanks Bruno for the updates added in my initial PR.

This ticket and it's PR  is ready for Committer review:
https://issues.apache.org/jira/browse/TOMEE-2361
please move forward.

El dom., 23 dic. 2018 a las 22:10, César Hernández Mendoza (<
cesargu...@gmail.com>) escribió:


Hi Bruno,

I just gave you the grants, please try again and now should be fine.

El vie., 21 dic. 2018 a las 15:44, Bruno Baptista ()
escribió:


Hi Cesar,

I don't know why, but I cannot commit to your branch or create a PR
against it.

Can you please double check the config?

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 21/12/18 10:36, Bruno Baptista wrote:

Great Cesar! I'd like to help on that.

Bruno Baptista
https://twitter.com/brunobat_


On 21/12/18 02:39, César Hernández Mendoza wrote:

Hi,
This is still a WIP but I opened the PR for feedback:

https://github.com/apache/tomee/pull/299
Online result can be see here:
https://github.com/cesarhernandezgt/tomee/tree/TOMEE-2361

After holidays I'll continue with this improvement.

El jue., 13 dic. 2018 a las 8:43, Roberto Cortez
() escribió:


Done to César.


On 13 Dec 2018, at 14:35, Daniel Cunha 

wrote:

Ops, ok Cesar, go for it.

I can work on Download page area.

Em qui, 13 de dez de 2018 às 11:33, Daniel Cunha

escreveu:


Hey Roberto,

I can pick up it.
Please, assign the ticket to me.

Em qui, 13 de dez de 2018 às 09:41, Roberto Cortez
 escreveu:


Hi folks,

Maybe you have missed this from another thread. I’ve created a
JIRA to
improve our frontend README information on Github:
https://jira.apache.org/jira/browse/TOMEE-2361 <
https://jira.apache.org/jira/browse/TOMEE-2361>

Is anyone available to pick that up?

Cheers,
Roberto


--
Daniel "soro" Cunha
https://twitter.com/dvlc_


--
Daniel "soro" Cunha
https://twitter.com/dvlc_


--
Atentamente:
César Hernández Mendoza.





Re: Stabilize TomEE Build

2019-01-02 Thread Bruno Baptista

I think there's a vote for a minor release fixing an issue there.

Bruno Baptista
https://twitter.com/brunobat_


On 02/01/19 18:56, Roberto Cortez wrote:

The OpenTracing update was also failing the TCK. I’ve reverted it back until we 
figure out what is going on.


On 2 Jan 2019, at 16:50, Roberto Cortez  wrote:

It seems to fail intermittently. It took me a few tries to make it fail. On the 
latest buildbot it seems fine.

Not sure if it was like this before or if it was something we did.


On 2 Jan 2019, at 12:14, Jean-Louis Monteiro  wrote:

[ERROR] Failures:
[ERROR]   LegacyServerTest.test:208->assertBalance:219 Bad number of
invocations for the bean "green". expected:<2> but was:<1>

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Jan 2, 2019 at 1:14 PM Jean-Louis Monteiro 
wrote:


I also get this one locally

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Jan 2, 2019 at 1:05 PM Roberto Cortez 
wrote:


One issue at least was with the Safeguard upgrade. I’ve reverted it back.
Lets see if this helps.


On 2 Jan 2019, at 11:33, Roberto Cortez 

wrote:

Yeah, just noticed it as well. Was about to send a message too. I can

have a look.

On 2 Jan 2019, at 11:00, Jean-Louis Monteiro 

wrote:

Ok, looks like we are back to red.
Someone working on it?
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 21, 2018 at 12:59 AM Roberto Cortez



wrote:


By the way, lets try to keep it that way :)


On 20 Dec 2018, at 20:48, César Hernández Mendoza <

cesargu...@gmail.com>

wrote:

Nice work guys!

El jue., 20 dic. 2018 a las 13:55, Frankie (
)

escribió:


Great! Well Done!

Frankie



--
Sent from:
http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html



--
Atentamente:
César Hernández Mendoza.






Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Bruno Baptista

Sounds like a good plan. :)

Bruno Baptista
https://twitter.com/brunobat_


On 02/01/19 09:47, Gurkan Erdogdu wrote:

For me, using services-jar.xml approach is not so visible to users. All
defaults are configured in this file and packaged within JAR file. Users
are not able to read the parameter explanation from services-jar.xml files.
Also, services.-jar.xml is somebit different from using the system
properties to turn-on/off something. I am also thinking to introduce YAML
based configuration.

But first step is to centralise all of these system parameters into two
classes. Maybe, we will see that some of them are unnecessary etc.

On Wed, Jan 2, 2019 at 12:44 PM Bruno Baptista  wrote:


Yes, there is.

This is also the most basic MP spec and nothing prevents us from using
it everywhere.

There might be Jakarta EE restrictions in how to handle configurations
that need to be assessed.

Overall, I think that if we are going to mess with configs, we should
use state of the art.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 02/01/19 09:35, Jean-Louis Monteiro wrote:

I think with microprofile-config we may have a chicken and the egg

problem,

isn't it?
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Jan 2, 2019 at 10:30 AM Bruno Baptista 

wrote:

Hi Gurkan,

I agree we have a problem with the documentation of the different
properties and that we need to improve it.

Doing the inventory and using the proposed syntax looks ok to me but I
also think we should go even further.

How about to migrate all the properties to use microprofile-config?

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 02/01/19 07:20, Gurkan Erdogdu wrote:

Hello
There are lots of known and unknown system properties in the current

code

base. I would like to introduce TomEESystemProperties and
OpenEJBSystemProperties classes to hold these system property constants

and

provide clear comment what it does. For example:

class TomEESystemProperties{
   public static final String TOMEE_FORCE_RELOADABLE =
"tomee.force-reloadable";

}

class OpenEJBSystemProperties{
  public static final String OPENEJB_CROSSCONTEXT_PROPERTY =
"openejb.crosscontext";

}

WDYT?
Regards.
Gurkan



Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Bruno Baptista

Yes, there is.

This is also the most basic MP spec and nothing prevents us from using 
it everywhere.


There might be Jakarta EE restrictions in how to handle configurations 
that need to be assessed.


Overall, I think that if we are going to mess with configs, we should 
use state of the art.


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 02/01/19 09:35, Jean-Louis Monteiro wrote:

I think with microprofile-config we may have a chicken and the egg problem,
isn't it?
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Jan 2, 2019 at 10:30 AM Bruno Baptista  wrote:


Hi Gurkan,

I agree we have a problem with the documentation of the different
properties and that we need to improve it.

Doing the inventory and using the proposed syntax looks ok to me but I
also think we should go even further.

How about to migrate all the properties to use microprofile-config?

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 02/01/19 07:20, Gurkan Erdogdu wrote:

Hello
There are lots of known and unknown system properties in the current code
base. I would like to introduce TomEESystemProperties and
OpenEJBSystemProperties classes to hold these system property constants

and

provide clear comment what it does. For example:

class TomEESystemProperties{
  public static final String TOMEE_FORCE_RELOADABLE =
"tomee.force-reloadable";

}

class OpenEJBSystemProperties{
 public static final String OPENEJB_CROSSCONTEXT_PROPERTY =
"openejb.crosscontext";

}

WDYT?
Regards.
Gurkan



Re: How can I help?

2019-01-02 Thread Bruno Baptista

Hi Chege,

Welcome to TomEE!

Here you will find some useful reading about how to contribute:
http://tomee.apache.org/community/index.html

We have currently a couple of Epics targeted for new contributors, I'm 
sure you can find in there a task for you:


Generation of MP examples: https://issues.apache.org/jira/browse/TOMEE-2285
Improving documentation: https://issues.apache.org/jira/browse/TOMEE-2369

You can chose one and ask it to be assigned to you.

If you have some other Idea just shout in the list!

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 02/01/19 04:24, Chege Kĩnũthia wrote:

Hi,

I am Chege, a freelance Java developer based in Thika, Kenya. I have no
experience in developing application servers. I look forward in
starting small and learning my way up.

I have been developing Java EE and Spring  applications and  since
2012.

Thanks,
Chege.


Re: Hello

2019-01-02 Thread Bruno Baptista

Hi Rodrigo,

Welcome to TomEE!

Here you will find some useful reading about how to contribute:
http://tomee.apache.org/community/index.html

We have currently a couple of Epics targeted for new contributors, I'm 
sure you can find in there a task for you:


Generation of MP examples: https://issues.apache.org/jira/browse/TOMEE-2285
Improving documentation: https://issues.apache.org/jira/browse/TOMEE-2369

You can chose one and ask it to be assigned to you.

If you have some other Idea just shout in the list!

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 01/01/19 02:21, Rodrigo Graciano wrote:

Happy New year everyone.
I'm just starting here. I have been working with Java for some time and
would like to contribute.
Please let me know if I can be of any help.

Best,
Rodrigo Graciano


Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Bruno Baptista

Hi Gurkan,

I agree we have a problem with the documentation of the different 
properties and that we need to improve it.


Doing the inventory and using the proposed syntax looks ok to me but I 
also think we should go even further.


How about to migrate all the properties to use microprofile-config?

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 02/01/19 07:20, Gurkan Erdogdu wrote:

Hello
There are lots of known and unknown system properties in the current code
base. I would like to introduce TomEESystemProperties and
OpenEJBSystemProperties classes to hold these system property constants and
provide clear comment what it does. For example:

class TomEESystemProperties{
 public static final String TOMEE_FORCE_RELOADABLE =
"tomee.force-reloadable";

}

class OpenEJBSystemProperties{
public static final String OPENEJB_CROSSCONTEXT_PROPERTY =
"openejb.crosscontext";

}

WDYT?
Regards.
Gurkan



Re: Microprofile release train

2018-12-31 Thread Bruno Baptista
This improves a bit after updating the TestNG version to 6.9.9 and 
adding Hamcrest:



[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] 
CircuitBreakerTest>Arquillian.run:138->testCircuitInitialSuccessDefaultSuccessThreshold:292 
serviceA should throw an Exception in testCircuitDefaultSuccessThreshold 
on iteration 5
[ERROR] 
CircuitBreakerTest>Arquillian.run:138->testCircuitLateSuccessDefaultSuccessThreshold:370 
in serviceA no CircuitBreakerOpenException should be fired on iteration 1
[ERROR] 
IncompatibleFallbackMethodTest>Arquillian.arquillianBeforeClass:96 » 
Deployment
[ERROR] 
IncompatibleFallbackMethodWithArgsTest>Arquillian.arquillianBeforeClass:96 
» Deployment
[ERROR] IncompatibleFallbackTest>Arquillian.arquillianBeforeClass:96 » 
Deployment Unab...
[ERROR] 
InvalidBulkheadAsynchQueueTest>Arquillian.arquillianBeforeClass:96 » 
Deployment
[ERROR] InvalidBulkheadValueTest>Arquillian.arquillianBeforeClass:96 » 
Deployment Unab...
[ERROR] 
InvalidCircuitBreakerDelayTest>Arquillian.arquillianBeforeClass:96 » 
Deployment
[ERROR] 
InvalidCircuitBreakerFailureRatioNegTest>Arquillian.arquillianBeforeClass:96 
» Deployment
[ERROR] 
InvalidCircuitBreakerFailureRatioPosTest>Arquillian.arquillianBeforeClass:96 
» Deployment
[ERROR] 
InvalidCircuitBreakerFailureReqVol0Test>Arquillian.arquillianBeforeClass:96 
» Deployment
[ERROR] 
InvalidCircuitBreakerFailureReqVolNegTest>Arquillian.arquillianBeforeClass:96 
» Deployment
[ERROR] 
InvalidCircuitBreakerFailureSuccess0Test>Arquillian.arquillianBeforeClass:96 
» Deployment
[ERROR] 
InvalidCircuitBreakerFailureSuccessNegTest>Arquillian.arquillianBeforeClass:96 
» Deployment
[ERROR] 
InvalidRetryDelayDurationTest>Arquillian.arquillianBeforeClass:96 » 
Deployment
[ERROR] InvalidRetryDelayTest>Arquillian.arquillianBeforeClass:96 » 
Deployment Unable ...
[ERROR] InvalidRetryJitterTest>Arquillian.arquillianBeforeClass:96 » 
Deployment Unable...
[ERROR] InvalidRetryMaxRetriesTest>Arquillian.arquillianBeforeClass:96 » 
Deployment Un...
[ERROR] InvalidTimeoutValueTest>Arquillian.arquillianBeforeClass:96 » 
Deployment Unabl...
[ERROR] AllMetricsTest>Arquillian.run:138->testAllMetrics:60 » 
NoClassDefFound org/ham...
[ERROR] 
BulkheadMetricTest>Arquillian.run:138->bulkheadMetricAsyncTest:193 » 
NoClassDefFound
[ERROR] 
BulkheadMetricTest>Arquillian.run:138->bulkheadMetricHistogramTest:152 » 
NoClassDefFound
[ERROR] 
BulkheadMetricTest>Arquillian.run:138->bulkheadMetricRejectionTest:121 » 
NoClassDefFound
[ERROR] BulkheadMetricTest>Arquillian.run:138->bulkheadMetricTest:91 » 
NoClassDefFound
[ERROR] 
CircuitBreakerMetricTest>Arquillian.run:138->testCircuitBreakerMetric:87 
» NoClassDefFound
[ERROR] ClashingNameTest>Arquillian.run:138->testClashingName:55 » 
NoClassDefFound org...
[ERROR] 
ClassLevelMetricTest>Arquillian.run:138->testRetryMetricSuccessfulAfterRetry:80 
» NoClassDefFound
[ERROR] 
ClassLevelMetricTest>Arquillian.run:138->testRetryMetricSuccessfulImmediately:59 
» NoClassDefFound
[ERROR] 
ClassLevelMetricTest>Arquillian.run:138->testRetryMetricUnsuccessful:93 
» NoClassDefFound
[ERROR] 
FallbackMetricTest>Arquillian.run:138->fallbackMetricHandlerTest:80 » 
NoClassDefFound
[ERROR] 
FallbackMetricTest>Arquillian.run:138->fallbackMetricMethodTest:54 » 
NoClassDefFound
[ERROR] MetricsDisabledTest>Arquillian.run:138->testMetricsDisabled:66 
NoClassDefFound
[ERROR] 
RetryMetricTest>Arquillian.run:138->testRetryMetricSuccessfulAfterRetry:71 
» NoClassDefFound
[ERROR] 
RetryMetricTest>Arquillian.run:138->testRetryMetricSuccessfulImmediately:55 
» NoClassDefFound
[ERROR] 
RetryMetricTest>Arquillian.run:138->testRetryMetricUnsuccessful:87 » 
NoClassDefFound
[ERROR] TimeoutMetricTest>Arquillian.run:138->testTimeoutHistogram:85 » 
NoClassDefFound
[ERROR] TimeoutMetricTest>Arquillian.run:138->testTimeoutMetric:57 » 
NoClassDefFound o...

[INFO]
[ERROR] Tests run: 251, Failures: 37, Errors: 0, Skipped: 34
[INFO]
[INFO] 
----

[INFO] BUILD FAILURE
[INFO] 




Bruno Baptista
https://twitter.com/brunobat_


On 31/12/18 12:29, Bruno Baptista wrote:


Hi Folks,

I've also updated the MP FT version to 1.1.3, the same as the new 
Safeguard.


The Injection of the Executor service doesn't work.

Also, The TCK seems to pass all the tests when executed in the 
standalone library, but on the TomEE TCK it doesn't. Also, the Demo 
apps we have, they all fail to deploy for multiple reasons.


I recommend to revert to the previous version until we know why.

These are the results with our TCK:

[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] 
CircuitBreakerTest>Arquillian.run:138->testCircuitInitialSuccessDefaultSuccessThreshold:292 
serviceA should throw 

Re: MicroProfile Samples

2018-12-31 Thread Bruno Baptista

Great!

Thanks Ivan, will review it now.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 31/12/18 11:43, Ivan St. Ivanov wrote:

Hi folks!

I created a PR (https://github.com/apache/tomee/pull/333) for this issue:
https://jira.apache.org/jira/browse/TOMEE-2333

Cheers and happy and successful new year everyone!
Ivan

On Mon, Dec 10, 2018 at 3:10 PM Roberto Cortez 
wrote:


Hi Lucas,

I’ve assigned the issue to you. Let us know if you need any help.

Good luck and have fun :)

Cheers,
Roberto


On 9 Dec 2018, at 23:59, Lucas Farias de Oliveira <

lucasfaria...@gmail.com> wrote:

Hey Roberto, it sounds interesting! My username on Jira is "luksrn"

Em dom, 9 de dez de 2018 às 21:30, Roberto Cortez
 escreveu:


Hi Lucas,

Wonderful. I have one for you:

https://jira.apache.org/jira/browse/TOMEE-2351 <
https://jira.apache.org/jira/browse/TOMEE-2351> - MicroProfile
OpenTracing Example for Distributed Microservices. Would you like to

take

it?

Cheers,
Roberto


On 9 Dec 2018, at 01:36, Lucas Farias de Oliveira <

lucasfaria...@gmail.com> wrote:

Hey, Open Tracing spec would be nice. :D

Em sáb, 8 de dez de 2018 às 22:06, Roberto Cortez
 escreveu:


Hi Lucas,

Thank you for your interest.

Apparently, Jose Henrique Ventura is also interested in TOMEE-2335.

If you are interested in Health and OpenTracing specs, I can come up

with

a few other scenarios for you to work on. Is this interesting to you?

Cheers,
Roberto


On 8 Dec 2018, at 13:46, Lucas Farias de Oliveira <

lucasfaria...@gmail.com> wrote:

Sorry! I did not see other e-mails before reply, and there is someone
interested in TOMEE-2336. :( The other issue would be TOMEE-2335.

Em sáb, 8 de dez de 2018 às 11:41, Lucas Farias de Oliveira <
lucasfaria...@gmail.com> escreveu:


Hi Roberto! I'm a new member and I don't know if this is the right

place

to ask, but How can I help? I have a particular interest with

TOMEE-2336 or

TOMEE-2336

regards,
Lucas Farias


Em sex, 7 de dez de 2018 às 15:57, Roberto Cortez
 escreveu:


Hi folks,

We have a parent JIRA issue with a lot of work going on in

enriching

TomEE samples with MicroProfile:
https://jira.apache.org/jira/browse/TOMEE-2285 <
https://jira.apache.org/jira/browse/TOMEE-2285>

The following are up for grabs:

TOMEE-2336 - MicroProfile OpenTracing Example for @Traced

TOMEE-2335 - MicroProfile Health Example for custom HealthCheck

TOMEE-2334 - MicroProfile JWT Example for JsonWebToken as Principal
injection

TOMEE-2333 - MicroProfile JWT Example for mp.jwt.verify.publickey
configuration

TOMEE-2332 - MicroProfile JWT Example for JWK

TOMEE-2296 - MicroProfile Fault Tolerance Example for @Timeout

Thanks!

Cheers,
Roberto










Re: Microprofile release train

2018-12-31 Thread Bruno Baptista
gt;Arquillian.arquillianBeforeClass:96 » 
Deployment
[ERROR] InvalidBulkheadValueTest>Arquillian.arquillianBeforeClass:96 » 
Deployment Unab...
[ERROR] 
InvalidCircuitBreakerDelayTest>Arquillian.arquillianBeforeClass:96 » 
Deployment
[ERROR] 
InvalidCircuitBreakerFailureRatioNegTest>Arquillian.arquillianBeforeClass:96 
» Deployment
[ERROR] 
InvalidCircuitBreakerFailureRatioPosTest>Arquillian.arquillianBeforeClass:96 
» Deployment
[ERROR] 
InvalidCircuitBreakerFailureReqVol0Test>Arquillian.arquillianBeforeClass:96 
» Deployment
[ERROR] 
InvalidCircuitBreakerFailureReqVolNegTest>Arquillian.arquillianBeforeClass:96 
» Deployment
[ERROR] 
InvalidCircuitBreakerFailureSuccess0Test>Arquillian.arquillianBeforeClass:96 
» Deployment
[ERROR] 
InvalidCircuitBreakerFailureSuccessNegTest>Arquillian.arquillianBeforeClass:96 
» Deployment
[ERROR] 
InvalidRetryDelayDurationTest>Arquillian.arquillianBeforeClass:96 » 
Deployment
[ERROR] InvalidRetryDelayTest>Arquillian.arquillianBeforeClass:96 » 
Deployment Unable ...
[ERROR] InvalidRetryJitterTest>Arquillian.arquillianBeforeClass:96 » 
Deployment Unable...
[ERROR] InvalidRetryMaxRetriesTest>Arquillian.arquillianBeforeClass:96 » 
Deployment Un...
[ERROR] InvalidTimeoutValueTest>Arquillian.arquillianBeforeClass:96 » 
Deployment Unabl...
[ERROR] AllMetricsTest>Arquillian.run:138->testAllMetrics:60 » 
NoClassDefFound org/ham...
[ERROR] 
BulkheadMetricTest>Arquillian.run:138->bulkheadMetricAsyncTest:193 » 
NoClassDefFound
[ERROR] 
BulkheadMetricTest>Arquillian.run:138->bulkheadMetricHistogramTest:152 » 
NoClassDefFound
[ERROR] 
BulkheadMetricTest>Arquillian.run:138->bulkheadMetricRejectionTest:121 » 
NoClassDefFound
[ERROR] BulkheadMetricTest>Arquillian.run:138->bulkheadMetricTest:91 » 
NoClassDefFound
[ERROR] 
CircuitBreakerMetricTest>Arquillian.run:138->testCircuitBreakerMetric:87 
» NoClassDefFound
[ERROR] ClashingNameTest>Arquillian.run:138->testClashingName:55 » 
NoClassDefFound org...
[ERROR] 
ClassLevelMetricTest>Arquillian.run:138->testRetryMetricSuccessfulAfterRetry:80 
» NoClassDefFound
[ERROR] 
ClassLevelMetricTest>Arquillian.run:138->testRetryMetricSuccessfulImmediately:59 
» NoClassDefFound
[ERROR] 
ClassLevelMetricTest>Arquillian.run:138->testRetryMetricUnsuccessful:93 
» NoClassDefFound
[ERROR] 
FallbackMetricTest>Arquillian.run:138->fallbackMetricHandlerTest:80 » 
NoClassDefFound
[ERROR] 
FallbackMetricTest>Arquillian.run:138->fallbackMetricMethodTest:54 » 
NoClassDefFound
[ERROR] MetricsDisabledTest>Arquillian.run:138->testMetricsDisabled:66 
NoClassDefFound
[ERROR] 
RetryMetricTest>Arquillian.run:138->testRetryMetricSuccessfulAfterRetry:71 
» NoClassDefFound
[ERROR] 
RetryMetricTest>Arquillian.run:138->testRetryMetricSuccessfulImmediately:55 
» NoClassDefFound
[ERROR] 
RetryMetricTest>Arquillian.run:138->testRetryMetricUnsuccessful:87 » 
NoClassDefFound
[ERROR] TimeoutMetricTest>Arquillian.run:138->testTimeoutHistogram:85 » 
NoClassDefFound
[ERROR] TimeoutMetricTest>Arquillian.run:138->testTimeoutMetric:57 » 
NoClassDefFound o...

[INFO]
[ERROR] Tests run: 251, Failures: 73, Errors: 0, Skipped: 34
[INFO]
[INFO] 


[INFO] BUILD FAILURE
[INFO] 


[INFO] Total time: 14:49 min
[INFO] Finished at: 2018-12-31T12:13:46Z
[INFO] Final Memory: 33M/1020M
[INFO] 
----


Bruno Baptista
https://twitter.com/brunobat_


On 28/12/18 21:41, Jean-Louis Monteiro wrote:

Thanks Bruno.
I just pushed something there.

I did not check so if you have some time to give it a look, that'd be great
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 28, 2018 at 12:01 PM Bruno Baptista  wrote:


Hi,

As far as I can see, the API has changed and we now only need to
customize it like this:

@ApplicationScoped
public  class  MyExecutionManagerProvider  {
  @Resource
  @Produces
  @Safeguard
  private  ManagedScheduledExecutorService  executor;
}

See at the bottom of the doc: https://github.com/apache/geronimo-safeguard

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 28/12/18 07:55, Jean-Louis Monteiro wrote:

Hey Bruno,

I'll push it. Was fixing the build after some PR merges
Issue is in FailsafeContainerExecutionManagerProvider

If you get a chance to look at it. Otherwise I'll look right after the
breakfast.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Dec 27, 2018 at 4:08 PM Roberto Cortez



wrote:


Does it require anything special? Just adding the JAR is not enough?


On 27 Dec 2018, at 12:02, Bruno Baptista  wrote:

Do you want help with that?

Bruno Baptista
https://twitter.com/brunobat_


On 27/12/18 11:24, J

Re: [TOMEE-2435] New Pull Request

2018-12-31 Thread Bruno Baptista

Hi Gurkan,

Thanks for the PR. I left some notes on it.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 31/12/18 09:09, Gurkan Erdogdu wrote:

Hi
I have created a PR (https://github.com/apache/tomee/pull/332) for (TOMEE-2435)
Simplify the Code in org.apache.openejb.OpenEjbContainer$Provider
<https://issues.apache.org/jira/browse/TOMEE-2435>

If anybody can check and merge, it is appreciated :)
Regards.
Gurkan



Re: Microprofile jsonb configuration example proposal

2018-12-28 Thread Bruno Baptista

Hi Federico,

Usually it's set to solved after the PR is merged.

No worries. It should be fine.

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 28/12/18 18:48, Federico Mariani wrote:

Hi Roberto,
I did a pull request for the task TOMEE-2428
<https://issues.apache.org/jira/browse/TOMEE-2428>, but i have a doubt
about jira, I put the jira task in resolved state, is it correct?
Thanks,
Federico

Il giorno ven 28 dic 2018 alle ore 15:42 Roberto Cortez
 ha scritto:


Done! Thank you!


On 28 Dec 2018, at 13:37, Federico Mariani <

federico.mariani.1...@gmail.com> wrote:

Hi Roberto,
I've created tasks TOMEE-2428 and TOMEE-2429, you can assign them to me.
If you find out anything wrong, just let me know.

Thanks,
Federico

Il giorno ven 28 dic 2018 alle ore 10:49 Roberto Cortez
 ha scritto:


Hi Federico,

If we don’t have them, please go ahead :)

Can you just create a JIRA issue for each example with a small
description? I can assign them to you.

Thank you!

Cheers,
Roberto


On 28 Dec 2018, at 01:03, Federico Mariani <

federico.mariani.1...@gmail.com> wrote:

Hi everyone,
can be useful an example that shows jsonb configuration and custom
serialization/deserialization?
I have already worked on it and have some examples to share.

Cheers,
Federico






Re: Microprofile release train

2018-12-28 Thread Bruno Baptista

Sure, will take a look and will try to run the TCK.

Bruno Baptista
https://twitter.com/brunobat_


On 28/12/18 21:41, Jean-Louis Monteiro wrote:

Thanks Bruno.
I just pushed something there.

I did not check so if you have some time to give it a look, that'd be great
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 28, 2018 at 12:01 PM Bruno Baptista  wrote:


Hi,

As far as I can see, the API has changed and we now only need to
customize it like this:

@ApplicationScoped
public  class  MyExecutionManagerProvider  {
  @Resource
  @Produces
  @Safeguard
  private  ManagedScheduledExecutorService  executor;
}

See at the bottom of the doc: https://github.com/apache/geronimo-safeguard

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 28/12/18 07:55, Jean-Louis Monteiro wrote:

Hey Bruno,

I'll push it. Was fixing the build after some PR merges
Issue is in FailsafeContainerExecutionManagerProvider

If you get a chance to look at it. Otherwise I'll look right after the
breakfast.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Dec 27, 2018 at 4:08 PM Roberto Cortez



wrote:


Does it require anything special? Just adding the JAR is not enough?


On 27 Dec 2018, at 12:02, Bruno Baptista  wrote:

Do you want help with that?

Bruno Baptista
https://twitter.com/brunobat_


On 27/12/18 11:24, Jean-Louis Monteiro wrote:

TomEE integration in fault tolerance

Le jeu. 27 déc. 2018 à 11:58, Roberto Cortez



a écrit :


With the MP impls and TomEE integration?


On 27 Dec 2018, at 10:48, Jean-Louis Monteiro <

jlmonte...@tomitribe.com>

wrote:

Sorry for the delay guys, but there are some compilation issues to

fix.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 26, 2018 at 7:08 PM Bruno Baptista 

wrote:

All good for now.

Bruno Baptista
https://twitter.com/brunobat_


On 26/12/18 12:09, Roberto Cortez wrote:

Hi JL,

Please, go ahead.

I think Bruno had some ideas regarding Fault Tolerance.

Cheers,
Roberto


On 26 Dec 2018, at 11:57, Ivan Junckes Filho <

ivanjunc...@gmail.com>

wrote:

Cool JL thanks! I will need a change in geronimo-metrics to fix a

gauge

issue in  metrics. After that my pr

https://github.com/apache/tomee/pull/213

<https://github.com/apache/tomee/pull/213> should work.

On Wed, Dec 26, 2018 at 9:42 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:


Most of the implementations we are integrating in TomEE are

hosted in

Geronimo yes.
Release process is done, Romain has done it over the weekend.

So I'll proceed and create the tickets and do the upgrade in

TomEE

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 26, 2018 at 12:28 PM Matthew Broadhead
 wrote:


should we be on geronimo list?  i would like to monitor the

process

On 26/12/2018 12:08, Jean-Louis Monteiro wrote:

Hi,

In case you missed it, MicroProfile implementations are under

vote

on

the

geronimo side of things.

I'll proceed with the RESULT emails and with the process.
Is there any objection if I update them all in TomEE?

Jean-Louis
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


--
Mr MT Broadhead
Nigel Broadhead Mynard
See the latest jobs available at NBM @
https://nbmlaw.co.uk/recruitment.htm

32 Rainsford Road
Chelmsford Essex CM1 2QG
Tel: 01245 269909 Fax: 01245 261932
https://nbmlaw.co.uk

Partners: WJ Broadhead NP Eason SJ Lacey CR Broadhead D

Seepaul T

Carley

Nigel Broadhead Mynard Solicitors are authorised and regulated

by

the

Solicitors Regulation Authority. We are also bound by their

code

of

conduct. Registered no. 00061052

Nigel Broadhead Mynard also provide a will writing service, see
https://nbmlaw.co.uk/wills.htm for more information

Confidentiality: Information in this message is confidential

and

may

be

legally privileged. It is intended solely for the recipient to

whom

it is

addressed. If you receive the message in error, please notify

the

sender

and immediately destroy all copies.

Security warning: Please note that this e-mail has been created

in

the

knowledge that e-mail is not a 100% secure communications

medium. We

advise

you that you understand and observe this lack of security when

e-mailing

us. This e-mail does not constitute a legally binding document.

No

contracts may be concluded on behalf of Nigel Broadhead Mynard

Solicitors

by e-mail communications.

Disclaimer: Please be aware of cyber crime. Nigel Broadhead

Mynard

will

not take responsibility if you transfer money to a wrong bank

account.

Please speak to your Solicitor before transferring any money.

If

you

receive an email from Nigel Broadhead Mynard requesting your

bank

details

or telling you our bank details have changed, please contact

your

Solicitor

immediately to clarify.

PLEASE ALSO NOTE that Nigel Broadhea

Re: TomEE logo poll

2018-12-28 Thread Bruno Baptista

+1

Bruno Baptista
https://twitter.com/brunobat_


On 28/12/18 16:32, Ivan Junckes Filho wrote:

Hey guys, we have been through this discussion before but I don't think we
ever had a conclusion. In my opinion would be very important for the
project to have a logo and now TomEE is getting a lot of exposure why not
take advantage of the moment and promote TomEE even more with a great logo?

These are some options proposed in the past:
https://issues.apache.org/jira/browse/TOMEE-574

We could do something like David did here for JakartaEE:
https://github.com/eclipse-ee4j/ee4j/issues/11

And the winning logo would be the one with the most number of thumbs up.

What do you guys think?



Re: Microprofile release train

2018-12-28 Thread Bruno Baptista

Hi,

As far as I can see, the API has changed and we now only need to 
customize it like this:


@ApplicationScoped
public  class  MyExecutionManagerProvider  {
@Resource
@Produces
@Safeguard
private  ManagedScheduledExecutorService  executor;
}

See at the bottom of the doc: https://github.com/apache/geronimo-safeguard

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 28/12/18 07:55, Jean-Louis Monteiro wrote:

Hey Bruno,

I'll push it. Was fixing the build after some PR merges
Issue is in FailsafeContainerExecutionManagerProvider

If you get a chance to look at it. Otherwise I'll look right after the
breakfast.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Dec 27, 2018 at 4:08 PM Roberto Cortez 
wrote:


Does it require anything special? Just adding the JAR is not enough?


On 27 Dec 2018, at 12:02, Bruno Baptista  wrote:

Do you want help with that?

Bruno Baptista
https://twitter.com/brunobat_


On 27/12/18 11:24, Jean-Louis Monteiro wrote:

TomEE integration in fault tolerance

Le jeu. 27 déc. 2018 à 11:58, Roberto Cortez



a écrit :


With the MP impls and TomEE integration?


On 27 Dec 2018, at 10:48, Jean-Louis Monteiro <

jlmonte...@tomitribe.com>

wrote:

Sorry for the delay guys, but there are some compilation issues to

fix.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 26, 2018 at 7:08 PM Bruno Baptista 

wrote:

All good for now.

Bruno Baptista
https://twitter.com/brunobat_


On 26/12/18 12:09, Roberto Cortez wrote:

Hi JL,

Please, go ahead.

I think Bruno had some ideas regarding Fault Tolerance.

Cheers,
Roberto


On 26 Dec 2018, at 11:57, Ivan Junckes Filho <

ivanjunc...@gmail.com>

wrote:

Cool JL thanks! I will need a change in geronimo-metrics to fix a

gauge

issue in  metrics. After that my pr

https://github.com/apache/tomee/pull/213

<https://github.com/apache/tomee/pull/213> should work.

On Wed, Dec 26, 2018 at 9:42 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:


Most of the implementations we are integrating in TomEE are

hosted in

Geronimo yes.
Release process is done, Romain has done it over the weekend.

So I'll proceed and create the tickets and do the upgrade in TomEE
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 26, 2018 at 12:28 PM Matthew Broadhead
 wrote:


should we be on geronimo list?  i would like to monitor the

process

On 26/12/2018 12:08, Jean-Louis Monteiro wrote:

Hi,

In case you missed it, MicroProfile implementations are under

vote

on

the

geronimo side of things.

I'll proceed with the RESULT emails and with the process.
Is there any objection if I update them all in TomEE?

Jean-Louis
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


--
Mr MT Broadhead
Nigel Broadhead Mynard
See the latest jobs available at NBM @
https://nbmlaw.co.uk/recruitment.htm

32 Rainsford Road
Chelmsford Essex CM1 2QG
Tel: 01245 269909 Fax: 01245 261932
https://nbmlaw.co.uk

Partners: WJ Broadhead NP Eason SJ Lacey CR Broadhead D Seepaul T

Carley

Nigel Broadhead Mynard Solicitors are authorised and regulated by

the

Solicitors Regulation Authority. We are also bound by their code

of

conduct. Registered no. 00061052

Nigel Broadhead Mynard also provide a will writing service, see
https://nbmlaw.co.uk/wills.htm for more information

Confidentiality: Information in this message is confidential and

may

be

legally privileged. It is intended solely for the recipient to

whom

it is

addressed. If you receive the message in error, please notify the

sender

and immediately destroy all copies.

Security warning: Please note that this e-mail has been created

in

the

knowledge that e-mail is not a 100% secure communications

medium. We

advise

you that you understand and observe this lack of security when

e-mailing

us. This e-mail does not constitute a legally binding document.

No

contracts may be concluded on behalf of Nigel Broadhead Mynard

Solicitors

by e-mail communications.

Disclaimer: Please be aware of cyber crime. Nigel Broadhead

Mynard

will

not take responsibility if you transfer money to a wrong bank

account.

Please speak to your Solicitor before transferring any money. If

you

receive an email from Nigel Broadhead Mynard requesting your bank

details

or telling you our bank details have changed, please contact your

Solicitor

immediately to clarify.

PLEASE ALSO NOTE that Nigel Broadhead Mynard only use emails

which

end

with the suffix @nbmlaw.co.uk. If you receive any email from an

address

without that suffix or where that suffix does not appear in the

address

box

when you click "Reply" then you should not rely on the email

being

from

NBM

and you should immediately contact us on the above number or any

numbers

published on our website to verify the source of the email is

genuine

TOMEE-2301

2018-12-28 Thread Bruno Baptista

Hi,

I think TOMEE-2301 <https://issues.apache.org/jira/browse/TOMEE-2301> is 
done and can be closed.


Cheers

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Microprofile release train

2018-12-27 Thread Bruno Baptista

Do you want help with that?

Bruno Baptista
https://twitter.com/brunobat_


On 27/12/18 11:24, Jean-Louis Monteiro wrote:

TomEE integration in fault tolerance

Le jeu. 27 déc. 2018 à 11:58, Roberto Cortez 
a écrit :


With the MP impls and TomEE integration?


On 27 Dec 2018, at 10:48, Jean-Louis Monteiro 

wrote:

Sorry for the delay guys, but there are some compilation issues to fix.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 26, 2018 at 7:08 PM Bruno Baptista 

wrote:

All good for now.

Bruno Baptista
https://twitter.com/brunobat_


On 26/12/18 12:09, Roberto Cortez wrote:

Hi JL,

Please, go ahead.

I think Bruno had some ideas regarding Fault Tolerance.

Cheers,
Roberto


On 26 Dec 2018, at 11:57, Ivan Junckes Filho 

wrote:

Cool JL thanks! I will need a change in geronimo-metrics to fix a

gauge

issue in  metrics. After that my pr

https://github.com/apache/tomee/pull/213

<https://github.com/apache/tomee/pull/213> should work.

On Wed, Dec 26, 2018 at 9:42 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:


Most of the implementations we are integrating in TomEE are hosted in
Geronimo yes.
Release process is done, Romain has done it over the weekend.

So I'll proceed and create the tickets and do the upgrade in TomEE
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 26, 2018 at 12:28 PM Matthew Broadhead
 wrote:


should we be on geronimo list?  i would like to monitor the process

On 26/12/2018 12:08, Jean-Louis Monteiro wrote:

Hi,

In case you missed it, MicroProfile implementations are under vote

on

the

geronimo side of things.

I'll proceed with the RESULT emails and with the process.
Is there any objection if I update them all in TomEE?

Jean-Louis
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


--
Mr MT Broadhead
Nigel Broadhead Mynard
See the latest jobs available at NBM @
https://nbmlaw.co.uk/recruitment.htm

32 Rainsford Road
Chelmsford Essex CM1 2QG
Tel: 01245 269909 Fax: 01245 261932
https://nbmlaw.co.uk

Partners: WJ Broadhead NP Eason SJ Lacey CR Broadhead D Seepaul T

Carley

Nigel Broadhead Mynard Solicitors are authorised and regulated by

the

Solicitors Regulation Authority. We are also bound by their code of
conduct. Registered no. 00061052

Nigel Broadhead Mynard also provide a will writing service, see
https://nbmlaw.co.uk/wills.htm for more information

Confidentiality: Information in this message is confidential and may

be

legally privileged. It is intended solely for the recipient to whom

it is

addressed. If you receive the message in error, please notify the

sender

and immediately destroy all copies.

Security warning: Please note that this e-mail has been created in

the

knowledge that e-mail is not a 100% secure communications medium. We

advise

you that you understand and observe this lack of security when

e-mailing

us. This e-mail does not constitute a legally binding document. No
contracts may be concluded on behalf of Nigel Broadhead Mynard

Solicitors

by e-mail communications.

Disclaimer: Please be aware of cyber crime. Nigel Broadhead Mynard

will

not take responsibility if you transfer money to a wrong bank

account.

Please speak to your Solicitor before transferring any money. If you
receive an email from Nigel Broadhead Mynard requesting your bank

details

or telling you our bank details have changed, please contact your

Solicitor

immediately to clarify.

PLEASE ALSO NOTE that Nigel Broadhead Mynard only use emails which

end

with the suffix @nbmlaw.co.uk. If you receive any email from an

address

without that suffix or where that suffix does not appear in the

address

box

when you click "Reply" then you should not rely on the email being

from

NBM

and you should immediately contact us on the above number or any

numbers

published on our website to verify the source of the email is

genuine.

If you have any queries, please contact administra...@nbmlaw.co.uk






Re: How can I help?

2018-12-26 Thread Bruno Baptista

Hi Mitja,

Chose one and ask here to take it, please.

Those 2 Jira Epics have tasks that are not too complex and allow you to 
checkout the code, setup everything and be able to know us :)


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 26/12/18 19:13, Mitja Jeseničnik Kotnik wrote:

Hello Bruno,

thanks for the quick reply. I'll give it a look and start contributing. So
when I choose an issue I post it here or just under the issue that I've
chosen?

Best regards,
Mitja J. Kotnik

On Wed, Dec 26, 2018 at 8:08 PM Bruno Baptista  wrote:


Hi Mitja!

Welcome to TomEE!

Here you will find some useful reading about how to contribute:
http://tomee.apache.org/community/index.html

We have currently a couple of Epics targeted for new contributors. I'm
sure you can find in there a task for you:

Generation of MP examples:
https://issues.apache.org/jira/browse/TOMEE-2285
Improving documentation: https://issues.apache.org/jira/browse/TOMEE-2369

If you have some other Idea just shout in the list!

Bruno Baptista
https://twitter.com/brunobat_

Bruno Baptista
https://twitter.com/brunobat_


On 26/12/18 19:03, Mitja Jeseničnik Kotnik wrote:

Hello,

my name is Mitja J. Kotnik and I come from Slovenia. I'm a software
developer with approx. 3 years of Java/Jakarta EE experience.

I'd like to contribute to TomEE project where I could. I develop

production

software with Java language where I'm developing monolithic and
microservice applications.

So I'd really appreciate if someone would take some time and give me some
tips on how I could get involved in this project. Since for some time now
I'm searching for an opensource project where I could get involved more
seriously. And as I've seen on your website you're really open for new
contributions and guide newcomers, since it can be quite scary for us
starters to get involved. :)





Re: How can I help?

2018-12-26 Thread Bruno Baptista

Hi Mitja!

Welcome to TomEE!

Here you will find some useful reading about how to contribute:
http://tomee.apache.org/community/index.html

We have currently a couple of Epics targeted for new contributors. I'm 
sure you can find in there a task for you:


Generation of MP examples: https://issues.apache.org/jira/browse/TOMEE-2285
Improving documentation: https://issues.apache.org/jira/browse/TOMEE-2369

If you have some other Idea just shout in the list!

Bruno Baptista
https://twitter.com/brunobat_

Bruno Baptista
https://twitter.com/brunobat_


On 26/12/18 19:03, Mitja Jeseničnik Kotnik wrote:

Hello,

my name is Mitja J. Kotnik and I come from Slovenia. I'm a software
developer with approx. 3 years of Java/Jakarta EE experience.

I'd like to contribute to TomEE project where I could. I develop production
software with Java language where I'm developing monolithic and
microservice applications.

So I'd really appreciate if someone would take some time and give me some
tips on how I could get involved in this project. Since for some time now
I'm searching for an opensource project where I could get involved more
seriously. And as I've seen on your website you're really open for new
contributions and guide newcomers, since it can be quite scary for us
starters to get involved. :)



Re: Microprofile release train

2018-12-26 Thread Bruno Baptista

All good for now.

Bruno Baptista
https://twitter.com/brunobat_


On 26/12/18 12:09, Roberto Cortez wrote:

Hi JL,

Please, go ahead.

I think Bruno had some ideas regarding Fault Tolerance.

Cheers,
Roberto


On 26 Dec 2018, at 11:57, Ivan Junckes Filho  wrote:

Cool JL thanks! I will need a change in geronimo-metrics to fix a gauge
issue in  metrics. After that my pr https://github.com/apache/tomee/pull/213
<https://github.com/apache/tomee/pull/213> should work.

On Wed, Dec 26, 2018 at 9:42 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:


Most of the implementations we are integrating in TomEE are hosted in
Geronimo yes.
Release process is done, Romain has done it over the weekend.

So I'll proceed and create the tickets and do the upgrade in TomEE
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 26, 2018 at 12:28 PM Matthew Broadhead
 wrote:


should we be on geronimo list?  i would like to monitor the process

On 26/12/2018 12:08, Jean-Louis Monteiro wrote:

Hi,

In case you missed it, MicroProfile implementations are under vote on

the

geronimo side of things.

I'll proceed with the RESULT emails and with the process.
Is there any objection if I update them all in TomEE?

Jean-Louis
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


--
Mr MT Broadhead
Nigel Broadhead Mynard
See the latest jobs available at NBM @
https://nbmlaw.co.uk/recruitment.htm

32 Rainsford Road
Chelmsford Essex CM1 2QG
Tel: 01245 269909 Fax: 01245 261932
https://nbmlaw.co.uk

Partners: WJ Broadhead NP Eason SJ Lacey CR Broadhead D Seepaul T Carley

Nigel Broadhead Mynard Solicitors are authorised and regulated by the
Solicitors Regulation Authority. We are also bound by their code of
conduct. Registered no. 00061052

Nigel Broadhead Mynard also provide a will writing service, see
https://nbmlaw.co.uk/wills.htm for more information

Confidentiality: Information in this message is confidential and may be
legally privileged. It is intended solely for the recipient to whom it is
addressed. If you receive the message in error, please notify the sender
and immediately destroy all copies.

Security warning: Please note that this e-mail has been created in the
knowledge that e-mail is not a 100% secure communications medium. We

advise

you that you understand and observe this lack of security when e-mailing
us. This e-mail does not constitute a legally binding document. No
contracts may be concluded on behalf of Nigel Broadhead Mynard Solicitors
by e-mail communications.

Disclaimer: Please be aware of cyber crime. Nigel Broadhead Mynard will
not take responsibility if you transfer money to a wrong bank account.
Please speak to your Solicitor before transferring any money. If you
receive an email from Nigel Broadhead Mynard requesting your bank details
or telling you our bank details have changed, please contact your

Solicitor

immediately to clarify.

PLEASE ALSO NOTE that Nigel Broadhead Mynard only use emails which end
with the suffix @nbmlaw.co.uk. If you receive any email from an address
without that suffix or where that suffix does not appear in the address

box

when you click "Reply" then you should not rely on the email being from

NBM

and you should immediately contact us on the above number or any numbers
published on our website to verify the source of the email is genuine.

If you have any queries, please contact administra...@nbmlaw.co.uk




Concurrency utilities example improvement

2018-12-26 Thread Bruno Baptista

Hi Falks,

I've improved the concurrency-utils example by adding a 
ManagedThreadFactory example and by using CountDownLatch:


https://github.com/apache/tomee/pull/289

It's ready for review now.

Cheers.

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Microprofile release train

2018-12-26 Thread Bruno Baptista

We should create a PR and check what happens to the TCK before we merge.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 26/12/18 11:08, Jean-Louis Monteiro wrote:

Hi,

In case you missed it, MicroProfile implementations are under vote on the
geronimo side of things.

I'll proceed with the RESULT emails and with the process.
Is there any objection if I update them all in TomEE?

Jean-Louis
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com



Re: Ejemplos en Español

2018-12-26 Thread Bruno Baptista

+1

Bruno Baptista
https://twitter.com/brunobat_


On 24/12/18 22:35, David Blevins wrote:

I was talking with Hillmer on twitter about potentially translating examples 
into Spanish.

The idea is that we could potentially do examples and documentation in Spanish. 
 Perhaps:

  - http://tomee.apache.org/tomee-8.0/es/docs/
  - http://tomee.apache.org/tomee-8.0/es/ejemplos/

First note is that how we organize the files in the git repo and how we 
organize them on the website can be completely different.  We use the following 
code to collect all the examples together and do various things to them:

  - 
https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/Examples.java#L42

Right now it will do a copy and rename, for example:

  - 
https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README.md
  - http://tomee.apache.org/tomee-8.0/examples/cdi-request-scope.html

We could theoretically do something as simple as this:

  - 
https://github.com/apache/tomee/blob/master/examples/cdi-request-scope/README_es.md
  - http://tomee.apache.org/tomee-8.0/es/ejemplos/cdi-request-scope.html

I.e. make a new file next to the original, then update our copying logic to put 
the prefix in the path.


Thoughts?




Re: How can I help?

2018-12-24 Thread Bruno Baptista

Hi Puneeth,

Welcome to TomEE!

Here you will find some useful reading about how to contribute:
http://tomee.apache.org/community/index.html

We have currently a couple of Epics targeted for new contributors, I'm 
sure you can find in there a task for you:


Generation of MP examples: https://issues.apache.org/jira/browse/TOMEE-2285
Improving documentation: https://issues.apache.org/jira/browse/TOMEE-2369

If you have some other Idea just shout in the list!

Bruno Baptista
https://twitter.com/brunobat_


On 24/12/18 08:43, Puneeth PS wrote:

Hi,

I am Puneeth I live in Bangalore India. I am new to open-source contribution so 
I am willing to work on anything.




Re: How can I help?

2018-12-24 Thread Bruno Baptista

Hi Federico

Welcome to TomEE and thanks for wanting to contribute to open source!

Here you will find some useful reading about how to contribute:
http://tomee.apache.org/community/index.html

We have currently a couple of Epics targeted for new contributors, 
please check for instance:


Generation of MP examples: https://issues.apache.org/jira/browse/TOMEE-2285
Improving documentation: https://issues.apache.org/jira/browse/TOMEE-2369

If you have some other Idea just shout in the list!

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 23/12/18 09:45, Federico Mariani wrote:

Hello,
I'm Federico Mariani a 28 years old software developer from italy, actually
i'm working for a society called 'Engineering, ingegneria informatica'.
I've been working with javaEE for four years, i developed several web
applications for the italian's public administration. This would be my
first experience in contributing in an open source project, i don't really
know what to expect but i'm really looking forward to start contributing, i
mainly use open source software, i believe in open source and now it's time
to repay.

Kind regards,
Federico



Re: How can I help?

2018-12-24 Thread Bruno Baptista

Hi Santhosh,

Welcome to TomEE!

Were you will find some useful reading about how to contribute:
http://tomee.apache.org/community/index.html

We have currently a couple of Epics targeted for new contributors, 
please check for instance:


Generation of MP examples: https://issues.apache.org/jira/browse/TOMEE-2285
Improving documentation: https://issues.apache.org/jira/browse/TOMEE-2369

If you have some new Idea just shout in the list!

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 22/12/18 00:30, Santhosh Kumar wrote:

Dear Team,

This is Santhosh, from Chennai, India. I work for a Software Services
company & presently working in client location at Manila, Philippines.
I recently read an article published in Tomitribe on Open Source
Contribution Tips & I am interested in getting started.

At the moment, I don't have a particular interest & I'd just love to have
the chance to do some development work for TomEE.
Thank You!

With Kind Regards,
Santhosh Kumar B S



Re: TOMEE-2361 - Improve main README file

2018-12-21 Thread Bruno Baptista

Hi Cesar,

I don't know why, but I cannot commit to your branch or create a PR 
against it.


Can you please double check the config?

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 21/12/18 10:36, Bruno Baptista wrote:

Great Cesar! I'd like to help on that.

Bruno Baptista
https://twitter.com/brunobat_


On 21/12/18 02:39, César Hernández Mendoza wrote:

Hi,
This is still a WIP but I opened the PR for feedback:

https://github.com/apache/tomee/pull/299
Online result can be see here:
https://github.com/cesarhernandezgt/tomee/tree/TOMEE-2361

After holidays I'll continue with this improvement.

El jue., 13 dic. 2018 a las 8:43, Roberto Cortez
() escribió:


Done to César.


On 13 Dec 2018, at 14:35, Daniel Cunha  wrote:

Ops, ok Cesar, go for it.

I can work on Download page area.

Em qui, 13 de dez de 2018 às 11:33, Daniel Cunha 


escreveu:


Hey Roberto,

I can pick up it.
Please, assign the ticket to me.

Em qui, 13 de dez de 2018 às 09:41, Roberto Cortez
 escreveu:


Hi folks,

Maybe you have missed this from another thread. I’ve created a 
JIRA to

improve our frontend README information on Github:
https://jira.apache.org/jira/browse/TOMEE-2361 <
https://jira.apache.org/jira/browse/TOMEE-2361>

Is anyone available to pick that up?

Cheers,
Roberto



--
Daniel "soro" Cunha
https://twitter.com/dvlc_



--
Daniel "soro" Cunha
https://twitter.com/dvlc_




Re: TOMEE-2323 - MicroProfile Fault Tolerance Example for @Fallback

2018-12-21 Thread Bruno Baptista

Hi Weverthon,

It looks really nice! Thanks very much and congratulations! It has been 
merged.


Merry Christmas.

Bruno Baptista
https://twitter.com/brunobat_


On 21/12/18 15:29, Weverthon Medeiros wrote:

Hi guys,

I've submitted the PR for @Fallback example, please review:
https://github.com/apache/tomee/pull/303

Cheers,
Weverthon Medeiros
http://linkedin.com/in/weverthon



  1   2   3   >