[jira] [Created] (TWILL-209) Location test should validate permissions

[Andreas Neumann (JIRA)]

Andreas Neumann created TWILL-209:
-

 Summary: Location test should validate permissions
 Key: TWILL-209
 URL: https://issues.apache.org/jira/browse/TWILL-209
 Project: Apache Twill
  Issue Type: Improvement
  Components: yarn
Affects Versions: 0.10.0
Reporter: Andreas Neumann


The HDFSLocationtest and FileContextLocationTest use MiniDFSCluster. This does 
not seem to enforce permissions when creating directories. The followng test 
should throw an exception due to lack of permission but it does not:
{code}
  public void testPermissions() throws IOException {
// create a directory that does not permit anything
dfsCluster.getFileSystem().mkdir(new Path("/a"), 
FsPermission.valueOf("--"));
// creating a subdir should fail because even the owner has no write 
permission
dfsCluster.getFileSystem().mkdir(new Path("/a/b"), 
FsPermission.valueOf("--"));
  }
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TWILL-181) Control the maximum number of retries for failed application starts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TWILL-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837002#comment-15837002
 ] 

ASF GitHub Bot commented on TWILL-181:
--

Github user serranom commented on the issue:

https://github.com/apache/twill/pull/23
  
Thanks Henry!  No rush on my account, I was just checking in.


> Control the maximum number of retries for failed application starts
> ---
>
> Key: TWILL-181
> URL: https://issues.apache.org/jira/browse/TWILL-181
> Project: Apache Twill
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 0.7.0-incubating
>Reporter: Martin Serrano
>Assignee: Martin Serrano
> Fix For: 0.10.0
>
>
> If an application consistently exits with a non-zero code,  twill will 
> attempt to restart indefinitely.  I ran into this issue and a list search 
> also reveals [others|  http://markmail.org/message/dehx7r6tpqgcmjh4].  
> There should be a mechanism to specify the maximum number of retries until 
> the application fails.  Ideally by default there would be a non-infinite 
> maximum.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] twill issue #23: (TWILL-181) allow setting the maximum number of retries per...

[serranom]

Github user serranom commented on the issue:

https://github.com/apache/twill/pull/23
  
Thanks Henry!  No rush on my account, I was just checking in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TWILL-208) Location should have a way to set permissions when creating directories

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836976#comment-15836976
 ] 

ASF GitHub Bot commented on TWILL-208:
--

Github user anew commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97690501
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
@@ -251,6 +251,34 @@ public boolean mkdirs() throws IOException {
 return file.mkdirs();
   }
 
+  @Override
+  public boolean mkdirs(String permission) throws IOException {
--- End diff --

hmm that does not seem to apply the permissions correctly, it applies the 
umask to the permissions. What we want is the exact permissions as passed in.


> Location should have a way to set permissions when creating directories
> ---
>
> Key: TWILL-208
> URL: https://issues.apache.org/jira/browse/TWILL-208
> Project: Apache Twill
>  Issue Type: Bug
>Reporter: Andreas Neumann
>Assignee: Andreas Neumann
> Fix For: 0.10.0
>
>
> That is, we need to introduce a method
> {code}
> boolean mkdirs(String permissions);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TWILL-208) Location should have a way to set permissions when creating directories

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836970#comment-15836970
 ] 

ASF GitHub Bot commented on TWILL-208:
--

Github user anew commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97689935
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
@@ -98,8 +98,8 @@ public OutputStream getOutputStream() throws IOException {
 
   @Override
   public OutputStream getOutputStream(String permission) throws 
IOException {
-ensureDirectory(file.getParentFile());
 Set permissions = parsePermissions(permission);
+ensureDirectory(file.getParentFile(), permissions);
--- End diff --

yes, the intention of permissions is that others get access through, for 
example, group permission. So if I create the file with 700 but the directories 
are created with the default umask of 750, then that is not great. Even worse, 
if I create the file with 755, and the directories are created with 750, then 
world cannot access the file despite the intention. 


> Location should have a way to set permissions when creating directories
> ---
>
> Key: TWILL-208
> URL: https://issues.apache.org/jira/browse/TWILL-208
> Project: Apache Twill
>  Issue Type: Bug
>Reporter: Andreas Neumann
>Assignee: Andreas Neumann
> Fix For: 0.10.0
>
>
> That is, we need to introduce a method
> {code}
> boolean mkdirs(String permissions);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TWILL-208) Location should have a way to set permissions when creating directories

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836971#comment-15836971
 ] 

ASF GitHub Bot commented on TWILL-208:
--

Github user anew commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97689959
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
@@ -251,6 +251,34 @@ public boolean mkdirs() throws IOException {
 return file.mkdirs();
   }
 
+  @Override
+  public boolean mkdirs(String permission) throws IOException {
--- End diff --

oh, did not know about that. let me try.


> Location should have a way to set permissions when creating directories
> ---
>
> Key: TWILL-208
> URL: https://issues.apache.org/jira/browse/TWILL-208
> Project: Apache Twill
>  Issue Type: Bug
>Reporter: Andreas Neumann
>Assignee: Andreas Neumann
> Fix For: 0.10.0
>
>
> That is, we need to introduce a method
> {code}
> boolean mkdirs(String permissions);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] twill pull request #26: (TWILL-208) add Location.mkdirs(String permissions)

[anew]

Github user anew commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97689959
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
@@ -251,6 +251,34 @@ public boolean mkdirs() throws IOException {
 return file.mkdirs();
   }
 
+  @Override
+  public boolean mkdirs(String permission) throws IOException {
--- End diff --

oh, did not know about that. let me try.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #26: (TWILL-208) add Location.mkdirs(String permissions)

[anew]

Github user anew commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97689935
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
@@ -98,8 +98,8 @@ public OutputStream getOutputStream() throws IOException {
 
   @Override
   public OutputStream getOutputStream(String permission) throws 
IOException {
-ensureDirectory(file.getParentFile());
 Set permissions = parsePermissions(permission);
+ensureDirectory(file.getParentFile(), permissions);
--- End diff --

yes, the intention of permissions is that others get access through, for 
example, group permission. So if I create the file with 700 but the directories 
are created with the default umask of 750, then that is not great. Even worse, 
if I create the file with 755, and the directories are created with 750, then 
world cannot access the file despite the intention. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TWILL-208) Location should have a way to set permissions when creating directories

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836965#comment-15836965
 ] 

ASF GitHub Bot commented on TWILL-208:
--

Github user anew commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97689666
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/Location.java ---
@@ -207,6 +207,21 @@
   boolean mkdirs() throws IOException;
 
   /**
+   * Creates the directory named by this abstract pathname, including any 
necessary
+   * but nonexistent parent directories.
+   *
+   * @param permission A permission string. It has to be either a three 
digit or a nine character string.
+   *   For the three digit string, it is similar to the 
UNIX permission numeric representation.
+   *   The first digit is the permission for owner, second 
digit is the permission for group and
+   *   the third digit is the permission for all.
+   *   For the nine character string, it uses the format 
as specified by the
+   *   {@link PosixFilePermissions#fromString(String)} 
method.
+   *
+   * @return true if and only if the renaming succeeded; false otherwise
--- End diff --

good catch. I actually did not want that line :)


> Location should have a way to set permissions when creating directories
> ---
>
> Key: TWILL-208
> URL: https://issues.apache.org/jira/browse/TWILL-208
> Project: Apache Twill
>  Issue Type: Bug
>Reporter: Andreas Neumann
>Assignee: Andreas Neumann
> Fix For: 0.10.0
>
>
> That is, we need to introduce a method
> {code}
> boolean mkdirs(String permissions);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] twill pull request #26: (TWILL-208) add Location.mkdirs(String permissions)

[anew]

Github user anew commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97689666
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/Location.java ---
@@ -207,6 +207,21 @@
   boolean mkdirs() throws IOException;
 
   /**
+   * Creates the directory named by this abstract pathname, including any 
necessary
+   * but nonexistent parent directories.
+   *
+   * @param permission A permission string. It has to be either a three 
digit or a nine character string.
+   *   For the three digit string, it is similar to the 
UNIX permission numeric representation.
+   *   The first digit is the permission for owner, second 
digit is the permission for group and
+   *   the third digit is the permission for all.
+   *   For the nine character string, it uses the format 
as specified by the
+   *   {@link PosixFilePermissions#fromString(String)} 
method.
+   *
+   * @return true if and only if the renaming succeeded; false otherwise
--- End diff --

good catch. I actually did not want that line :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TWILL-208) Location should have a way to set permissions when creating directories

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836910#comment-15836910
 ] 

ASF GitHub Bot commented on TWILL-208:
--

Github user poornachandra commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97683616
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
@@ -251,6 +251,34 @@ public boolean mkdirs() throws IOException {
 return file.mkdirs();
   }
 
+  @Override
+  public boolean mkdirs(String permission) throws IOException {
--- End diff --

Should we use  
[Files.createDirectories](http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#createDirectories(java.nio.file.Path,%20java.nio.file.attribute.FileAttribute...))
 since it also takes permissions?


> Location should have a way to set permissions when creating directories
> ---
>
> Key: TWILL-208
> URL: https://issues.apache.org/jira/browse/TWILL-208
> Project: Apache Twill
>  Issue Type: Bug
>Reporter: Andreas Neumann
>Assignee: Andreas Neumann
> Fix For: 0.10.0
>
>
> That is, we need to introduce a method
> {code}
> boolean mkdirs(String permissions);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TWILL-208) Location should have a way to set permissions when creating directories

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836911#comment-15836911
 ] 

ASF GitHub Bot commented on TWILL-208:
--

Github user poornachandra commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97682185
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/Location.java ---
@@ -207,6 +207,21 @@
   boolean mkdirs() throws IOException;
 
   /**
+   * Creates the directory named by this abstract pathname, including any 
necessary
+   * but nonexistent parent directories.
+   *
+   * @param permission A permission string. It has to be either a three 
digit or a nine character string.
+   *   For the three digit string, it is similar to the 
UNIX permission numeric representation.
+   *   The first digit is the permission for owner, second 
digit is the permission for group and
+   *   the third digit is the permission for all.
+   *   For the nine character string, it uses the format 
as specified by the
+   *   {@link PosixFilePermissions#fromString(String)} 
method.
+   *
+   * @return true if and only if the renaming succeeded; false otherwise
--- End diff --

`@return true if and only if the renaming succeeded; false otherwise` => 
needs to change from renaming to mkdir


> Location should have a way to set permissions when creating directories
> ---
>
> Key: TWILL-208
> URL: https://issues.apache.org/jira/browse/TWILL-208
> Project: Apache Twill
>  Issue Type: Bug
>Reporter: Andreas Neumann
>Assignee: Andreas Neumann
> Fix For: 0.10.0
>
>
> That is, we need to introduce a method
> {code}
> boolean mkdirs(String permissions);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TWILL-208) Location should have a way to set permissions when creating directories

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836912#comment-15836912
 ] 

ASF GitHub Bot commented on TWILL-208:
--

Github user poornachandra commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97682463
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
@@ -98,8 +98,8 @@ public OutputStream getOutputStream() throws IOException {
 
   @Override
   public OutputStream getOutputStream(String permission) throws 
IOException {
-ensureDirectory(file.getParentFile());
 Set permissions = parsePermissions(permission);
+ensureDirectory(file.getParentFile(), permissions);
--- End diff --

Do we want to use the file permissions for the directory too?


> Location should have a way to set permissions when creating directories
> ---
>
> Key: TWILL-208
> URL: https://issues.apache.org/jira/browse/TWILL-208
> Project: Apache Twill
>  Issue Type: Bug
>Reporter: Andreas Neumann
>Assignee: Andreas Neumann
> Fix For: 0.10.0
>
>
> That is, we need to introduce a method
> {code}
> boolean mkdirs(String permissions);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] twill pull request #26: (TWILL-208) add Location.mkdirs(String permissions)

[poornachandra]

Github user poornachandra commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97682185
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/Location.java ---
@@ -207,6 +207,21 @@
   boolean mkdirs() throws IOException;
 
   /**
+   * Creates the directory named by this abstract pathname, including any 
necessary
+   * but nonexistent parent directories.
+   *
+   * @param permission A permission string. It has to be either a three 
digit or a nine character string.
+   *   For the three digit string, it is similar to the 
UNIX permission numeric representation.
+   *   The first digit is the permission for owner, second 
digit is the permission for group and
+   *   the third digit is the permission for all.
+   *   For the nine character string, it uses the format 
as specified by the
+   *   {@link PosixFilePermissions#fromString(String)} 
method.
+   *
+   * @return true if and only if the renaming succeeded; false otherwise
--- End diff --

`@return true if and only if the renaming succeeded; false otherwise` => 
needs to change from renaming to mkdir


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #26: (TWILL-208) add Location.mkdirs(String permissions)

[poornachandra]

Github user poornachandra commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97683616
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
@@ -251,6 +251,34 @@ public boolean mkdirs() throws IOException {
 return file.mkdirs();
   }
 
+  @Override
+  public boolean mkdirs(String permission) throws IOException {
--- End diff --

Should we use  
[Files.createDirectories](http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#createDirectories(java.nio.file.Path,%20java.nio.file.attribute.FileAttribute...))
 since it also takes permissions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TWILL-208) Location should have a way to set permissions when creating directories

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836890#comment-15836890
 ] 

ASF GitHub Bot commented on TWILL-208:
--

Github user albertshau commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97681685
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/Location.java ---
@@ -207,6 +207,21 @@
   boolean mkdirs() throws IOException;
 
   /**
+   * Creates the directory named by this abstract pathname, including any 
necessary
+   * but nonexistent parent directories.
+   *
+   * @param permission A permission string. It has to be either a three 
digit or a nine character string.
+   *   For the three digit string, it is similar to the 
UNIX permission numeric representation.
+   *   The first digit is the permission for owner, second 
digit is the permission for group and
+   *   the third digit is the permission for all.
+   *   For the nine character string, it uses the format 
as specified by the
+   *   {@link PosixFilePermissions#fromString(String)} 
method.
+   *
+   * @return true if and only if the renaming succeeded; false otherwise
--- End diff --

update javadoc


> Location should have a way to set permissions when creating directories
> ---
>
> Key: TWILL-208
> URL: https://issues.apache.org/jira/browse/TWILL-208
> Project: Apache Twill
>  Issue Type: Bug
>Reporter: Andreas Neumann
>Assignee: Andreas Neumann
> Fix For: 0.10.0
>
>
> That is, we need to introduce a method
> {code}
> boolean mkdirs(String permissions);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] twill pull request #26: (TWILL-208) add Location.mkdirs(String permissions)

[albertshau]

Github user albertshau commented on a diff in the pull request:

https://github.com/apache/twill/pull/26#discussion_r97681685
  
--- Diff: 
twill-common/src/main/java/org/apache/twill/filesystem/Location.java ---
@@ -207,6 +207,21 @@
   boolean mkdirs() throws IOException;
 
   /**
+   * Creates the directory named by this abstract pathname, including any 
necessary
+   * but nonexistent parent directories.
+   *
+   * @param permission A permission string. It has to be either a three 
digit or a nine character string.
+   *   For the three digit string, it is similar to the 
UNIX permission numeric representation.
+   *   The first digit is the permission for owner, second 
digit is the permission for group and
+   *   the third digit is the permission for all.
+   *   For the nine character string, it uses the format 
as specified by the
+   *   {@link PosixFilePermissions#fromString(String)} 
method.
+   *
+   * @return true if and only if the renaming succeeded; false otherwise
--- End diff --

update javadoc


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TWILL-181) Control the maximum number of retries for failed application starts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TWILL-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836876#comment-15836876
 ] 

ASF GitHub Bot commented on TWILL-181:
--

Github user hsaputra commented on the issue:

https://github.com/apache/twill/pull/23
  
Reference: https://issues.apache.org/jira/browse/TWILL-181

Hi @serranom , Could you also update the PR title to prefix with 
`(TWILL-181)` as shown in how to contribute page [1]?
This will trigger the Git hook to close the JIRA when PR is merged.

[1] http://twill.apache.org/HowToContribute.html


> Control the maximum number of retries for failed application starts
> ---
>
> Key: TWILL-181
> URL: https://issues.apache.org/jira/browse/TWILL-181
> Project: Apache Twill
>  Issue Type: Improvement
>  Components: yarn
>Affects Versions: 0.7.0-incubating
>Reporter: Martin Serrano
>Assignee: Martin Serrano
> Fix For: 0.10.0
>
>
> If an application consistently exits with a non-zero code,  twill will 
> attempt to restart indefinitely.  I ran into this issue and a list search 
> also reveals [others|  http://markmail.org/message/dehx7r6tpqgcmjh4].  
> There should be a mechanism to specify the maximum number of retries until 
> the application fails.  Ideally by default there would be a non-infinite 
> maximum.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] twill issue #23: Twill 181

[hsaputra]

Github user hsaputra commented on the issue:

https://github.com/apache/twill/pull/23
  
Let's trigger new build, @serranom could you close and reopen this PR 
please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TWILL-205) Location should have a way to set the group ownership

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TWILL-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836868#comment-15836868
 ] 

ASF GitHub Bot commented on TWILL-205:
--

Github user hsaputra commented on the issue:

https://github.com/apache/twill/pull/25
  
@anew feel free to merge this


> Location should have a way to set the group ownership
> -
>
> Key: TWILL-205
> URL: https://issues.apache.org/jira/browse/TWILL-205
> Project: Apache Twill
>  Issue Type: Bug
>  Components: core
>Affects Versions: 0.9.0
>Reporter: Andreas Neumann
>Assignee: Andreas Neumann
> Fix For: 0.10.0
>
>
> This is needed to control access to files, which is often done by giving 
> group permissions. Location already has a way to set the permissions, but it 
> would be good if the group id could be changed, too.
> Also it would be useful to get the owner and group of a location.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] twill issue #25: (TWILL-205) Add getOwner(), getGroup() and setGroup() to Lo...

[hsaputra]

Github user hsaputra commented on the issue:

https://github.com/apache/twill/pull/25
  
@anew feel free to merge this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill issue #23: Twill 181

[hsaputra]

Github user hsaputra commented on the issue:

https://github.com/apache/twill/pull/23
  
Hi @serranom , usually in about week you should get review. I apologize for 
the delay, but sometimes there is delay just due to volunteer time.
As for CI failures, it depends, sometime ZK is flaky so functional tests 
could fail.

You are doing right thing, we as committers needs to update our level of 
service. Thanks for your patience


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TWILL-208) Location should have a way to set permissions when creating directories

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836859#comment-15836859
 ] 

ASF GitHub Bot commented on TWILL-208:
--

GitHub user anew opened a pull request:

https://github.com/apache/twill/pull/26

(TWILL-208) add Location.mkdirs(String permissions)

- adds mkdirs() that takes permissions
- makes sure getOutputStream(permisssions) also uses that when creating the 
directories 
- add test case

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anew/twill twill-208

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/twill/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #26


commit 6d32277cc7cf03afd11e9bbef4d382fccb95d4ea
Author: anew 
Date:   2017-01-24T23:39:43Z

(TWILL-208) add Location.mkdirs(String permissions)




> Location should have a way to set permissions when creating directories
> ---
>
> Key: TWILL-208
> URL: https://issues.apache.org/jira/browse/TWILL-208
> Project: Apache Twill
>  Issue Type: Bug
>Reporter: Andreas Neumann
>Assignee: Andreas Neumann
> Fix For: 0.10.0
>
>
> That is, we need to introduce a method
> {code}
> boolean mkdirs(String permissions);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] twill pull request #26: (TWILL-208) add Location.mkdirs(String permissions)

[anew]

GitHub user anew opened a pull request:

https://github.com/apache/twill/pull/26

(TWILL-208) add Location.mkdirs(String permissions)

- adds mkdirs() that takes permissions
- makes sure getOutputStream(permisssions) also uses that when creating the 
directories 
- add test case

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anew/twill twill-208

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/twill/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #26


commit 6d32277cc7cf03afd11e9bbef4d382fccb95d4ea
Author: anew 
Date:   2017-01-24T23:39:43Z

(TWILL-208) add Location.mkdirs(String permissions)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill issue #23: Twill 181

[serranom]

Github user serranom commented on the issue:

https://github.com/apache/twill/pull/23
  
A couple of questions.  Note, I'm not irritated or anything like that... 
just want to have my expectations in line for planning purposes.

* What should I generally expect for feedback on the merging of a pull 
request?
* Is there any issue with this pull request (code-wise) that contributes to 
the time?
* Does the failing CI check (which I've seen is intermittent) a contributor 
to the time?  That is the fact that it has a failure means it would get less 
attention
* Should I be doing anything different?

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (TWILL-208) Location should have a way to set permissions when creating directories

[Andreas Neumann (JIRA)]

Andreas Neumann created TWILL-208:
-

 Summary: Location should have a way to set permissions when 
creating directories
 Key: TWILL-208
 URL: https://issues.apache.org/jira/browse/TWILL-208
 Project: Apache Twill
  Issue Type: Bug
Reporter: Andreas Neumann
Assignee: Andreas Neumann
 Fix For: 0.10.0


That is, we need to introduce a method
{code}
boolean mkdirs(String permissions);
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)