Re: [edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc: add github workflow to build python uefi with VS2022

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: Jayaprakash, N 
> Sent: Monday, July 22, 2024 11:12 PM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-libc Patch v2 1/1] edk2-libc: add github workflow to build
> python uefi with VS2022
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4815
> 
> edk2-libc has already been enabled to compile with VS2022 tool chain.
> This commit adds a new GitHub workflow to enable building python uefi
> with VS2022 compiler tool chain.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  .../workflows/build-python-uefi-vs2022.yaml   | 75 +++
>  1 file changed, 75 insertions(+)
>  create mode 100644 .github/workflows/build-python-uefi-vs2022.yaml
> 
> diff --git a/.github/workflows/build-python-uefi-vs2022.yaml
> b/.github/workflows/build-python-uefi-vs2022.yaml
> new file mode 100644
> index 000..ee1499c
> --- /dev/null
> +++ b/.github/workflows/build-python-uefi-vs2022.yaml
> @@ -0,0 +1,75 @@
> +# GitHub actions workflow to build python uefi using VS2022
> +#
> +# Copyright (c) 2023 - 2024, Intel Corporation. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +
> +name: Build Python Interpreter for UEFI using VS2022
> +
> +on: [push, pull_request]
> +
> +jobs:
> +  build:
> +runs-on: windows-latest
> +env:
> +  NASM_PREFIX: "C:\\Program Files\\NASM\\"
> +defaults:
> +  run:
> +shell: cmd
> +
> +steps:
> +- name: Checkout repository
> +  uses: actions/checkout@v4
> +
> +- name: Setup Python
> +  uses: actions/setup-python@v5
> +  with:
> +python-version: '3.10'
> +
> +- name: Install NASM
> +  run: choco install nasm
> +
> +- name: Clone EDK2
> +  run: |
> +git clone https://github.com/tianocore/edk2.git
> +cd edk2
> +git submodule update --init
> +
> +- name: Build EDK2 Base Tools
> +  run: |
> +cd edk2
> +dir
> +edksetup.bat ForceRebuild
> +
> +- name: Run srcprep.py
> +  run: |
> +echo switching to AppPkg\Applications\Python\Python-3.6.8\
> +cd AppPkg\Applications\Python\Python-3.6.8\
> +dir
> +echo run srcprep.py file
> +python srcprep.py
> +
> +- name: Build Python UEFI
> +  run: |
> +set PACKAGES_PATH=%CD%\edk2;%CD%;
> +set EDK2_LIBC_PATH=%CD%
> +cd edk2
> +call edksetup.bat
> +build -t VS2022 -a X64 -b RELEASE -p
> %EDK2_LIBC_PATH%\AppPkg\AppPkg.dsc -D BUILD_PYTHON368
> +
> +- name: Create Python UEFI package
> +  run: |
> +set WORKSPACE=%CD%\edk2
> +set EDK2_LIBC_PATH=%CD%
> +dir
> +call AppPkg\Applications\Python\Python-3.6.8\create_python_pkg.bat
> VS2022 RELEASE X64 myUEFIPy
> +
> +- name: List build artifacts
> +  run: |
> +dir /S edk2\myUEFIPy
> +
> +- name: Upload build output as artifact
> +  uses: actions/upload-artifact@v4
> +  with:
> +name: myUEFIPy-build-VS2022-output
> +path: edk2\myUEFIPy\**\*
> --
> 2.45.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120017): https://edk2.groups.io/g/devel/message/120017
Mute This Topic: https://groups.io/mt/107500265/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add github workflow to build python uefi with VS2022

[Michael D Kinney]

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Jayaprakash, N
> Sent: Monday, July 22, 2024 12:09 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add github workflow to
> build python uefi with VS2022
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4815
> 
> edk2-libc has already been enabled to compile with VS2022 tool chain.
> This commit adds a new workflow file to enable building python uefi
> with VS2022 compiler tool chain.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  .../workflows/build-python-uefi-vs2022.yaml   | 84 +++
>  1 file changed, 84 insertions(+)
>  create mode 100644 .github/workflows/build-python-uefi-vs2022.yaml
> 
> diff --git a/.github/workflows/build-python-uefi-vs2022.yaml
> b/.github/workflows/build-python-uefi-vs2022.yaml
> new file mode 100644
> index 000..4e36f09
> --- /dev/null
> +++ b/.github/workflows/build-python-uefi-vs2022.yaml
> @@ -0,0 +1,84 @@
> +# GitHub actions workflow to build python uefi using VS2022
> +#
> +# Copyright (c) 2023 - 2024, Intel Corporation. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +
> +name: Build Python Interpreter for UEFI using VS2022
> +
> +on: [push, pull_request]
> +
> +jobs:
> +  build:
> +runs-on: windows-latest
> +env:
> +  NASM_PREFIX: "C:\\Program Files\\NASM\\"
> +defaults:
> +  run:
> +shell: cmd
> +
> +steps:
> +- name: Checkout repository
> +  uses: actions/checkout@v4
> +
> +- name: Setup Python
> +  uses: actions/setup-python@v5
> +  with:
> +python-version: '3.10'
> +
> +- name: Install NASM
> +  run: choco install nasm
> +
> +- name: VSWhere
> +  run: |
> +"C:\Program Files (x86)\Microsoft Visual
> Studio\Installer\vswhere.exe" -products * -latest -requires
> Microsoft.Component.MSBuild -property installationPath
> +
> +- name: Setup environment for Visual Studio 2022 Build Tools
> +  run: |
> +"C:\Program Files\Microsoft Visual
> Studio\2022\BuildTools\VC\Auxiliary\Build\vcvarsall.bat" x86
> +set
> +

I though edksetup performs these steps above???

> +- name: Clone EDK2
> +  run: |
> +git clone https://github.com/tianocore/edk2.git
> +cd edk2
> +git submodule update --init
> +
> +- name: Build EDK2 Base Tools
> +  run: |
> +cd edk2
> +dir
> +edksetup.bat ForceRebuild
> +
> +- name: Run srcprep.py
> +  run: |
> +echo switching to AppPkg\Applications\Python\Python-3.6.8\
> +cd AppPkg\Applications\Python\Python-3.6.8\
> +dir
> +echo run srcprep.py file
> +python srcprep.py
> +
> +- name: Build Python UEFI
> +  run: |
> +set PACKAGES_PATH=%CD%\edk2;%CD%;
> +set EDK2_LIBC_PATH=%CD%
> +cd edk2
> +call edksetup.bat
> +build -t VS2022 -a X64 -b RELEASE -p
> %EDK2_LIBC_PATH%\AppPkg\AppPkg.dsc -D BUILD_PYTHON368
> +
> +- name: Create Python UEFI package
> +  run: |
> +set WORKSPACE=%CD%\edk2
> +set EDK2_LIBC_PATH=%CD%
> +dir
> +call AppPkg\Applications\Python\Python-3.6.8\create_python_pkg.bat
> VS2022 RELEASE X64 myUEFIPy
> +
> +- name: List build artifacts
> +  run: |
> +dir /S edk2\myUEFIPy
> +
> +- name: Upload build output as artifact
> +  uses: actions/upload-artifact@v4
> +  with:
> +name: myUEFIPy-build-VS2022-output
> +path: edk2\myUEFIPy\**\*
> --
> 2.45.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120007): https://edk2.groups.io/g/devel/message/120007
Mute This Topic: https://groups.io/mt/107481170/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc: Support for compiling Python UEFI interpreter with VS2022

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: Jayaprakash, N 
> Sent: Saturday, July 20, 2024 8:48 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-libc Patch v2 1/1] edk2-libc: Support for compiling Python
> UEFI interpreter with VS2022
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4811
> 
> While trying to compile Python UEFI 3.6.8 with VS2022, got several
> compiler warnings from other components within the edk2-libc project.
> These warnings were leading to compilation failure as they were
> treated as errors. All these issues have been fixed througn this
> commit. Besides this, updated the year in copy right of these file.
> 
> Summary of the issues is given below for reference:
> 1.AppPkg\Applications\Enquire\Enquire.c
>   Warning C4459: Declaration of 'bugs' hides global declaration.
>   Warning C4456: Multiple declarations of 'char_max' hide previous
>  local declarations.
>   Warning C4456: Declaration of 'char_min' hides previous local
>  declaration.
> 
> 2.AppPkg\Applications\OrderedCollectionTest\OrderedCollectionTest.c
>   Warning C4476: Unknown type field character '$' in format
>  specifier.
>   Warning C4474: Too many arguments passed for format string.
> 
> 3.StdLib\BsdSocketLib\getnetbyht.c
>   Warning C4459: Declaration of 'net' hides global declaration.
> 
> 4.StdLib\EfiSocketLib\Socket.c
>   Warning C4459: Multiple declarations of 'errno' hide global
>  declaration.
> 
> 5.AppPkg\Applications\Sockets\DataSource\DataSource.c
>   Warning C4459: Declaration of 'BytesSent' hides global declaration.
> 
> 6.AppPkg\Applications\Sockets\OobRx\OobRx.c
>   Warning C4475: Length modifier 'L' cannot be used with type field
>  character 'd' in format specifier.
> 
> 7.AppPkg\Applications\Sockets\RawIp4Rx\RawIp4Rx.c
>   Warning C4475: Length modifier 'L' cannot be used with type field
>  character 'd' in format specifier.
> 
> 8.StdLib\BsdSocketLib\ns_print.c
>   Warning C4456: Multiple declarations of 't' hide previous local
>  declarations.
>   Warning C4457: Declaration of 'type' hides function parameter.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  AppPkg/Applications/Enquire/Enquire.c | 48 +--
>  .../OrderedCollectionTest.c   | 10 +--
>  .../Sockets/DataSource/DataSource.c   | 10 +--
>  AppPkg/Applications/Sockets/OobRx/OobRx.c |  6 +-
>  .../Applications/Sockets/RawIp4Rx/RawIp4Rx.c  |  4 +-
>  StdLib/BsdSocketLib/getnetbyht.c  |  9 ++-
>  StdLib/BsdSocketLib/ns_print.c| 57 +++--
>  StdLib/EfiSocketLib/Socket.c  | 80 +--
>  8 files changed, 117 insertions(+), 107 deletions(-)
> 
> diff --git a/AppPkg/Applications/Enquire/Enquire.c
> b/AppPkg/Applications/Enquire/Enquire.c
> index 1e1db69..5e34f48 100644
> --- a/AppPkg/Applications/Enquire/Enquire.c
> +++ b/AppPkg/Applications/Enquire/Enquire.c
> @@ -5,7 +5,7 @@
>  Steven Pemberton, CWI, Amsterdam; "steven.pember...@cwi.nl"
>  Used with permission.
> 
> -Copyright (c) 2010 - 2011, Intel Corporation. All rights reserved.
> +Copyright (c) 2010 - 2024, Intel Corporation. All rights reserved.
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the
> BSD License
>  which accompanies this distribution. The full text of the license may be
> found at
> @@ -918,15 +918,15 @@ memeq(
>  }
> 
>  Void
> -farewell(int bugs)
> +farewell(int bugs_local)
>  {
> -  if (bugs == 0) exit(0);
> +  if (bugs_local == 0) exit(0);
>printf("\n%sFor hints on dealing with the ", co);
> -  if (bugs == 1) printf("problem");
> -  else printf("%d problems", bugs);
> +  if (bugs_local == 1) printf("problem");
> +  else printf("%d problems", bugs_local);
>printf(" above\n   see the section 'TROUBLESHOOTING' in the file ");
>printf("%s%s\n", FILENAME, oc);
> -  exit(bugs);
> +  exit(bugs_local);
>  }
> 
>  /* The program has received a signal where it wasn't expecting one */
> @@ -1927,51 +1927,51 @@ int cprop( void )
> 
>  if (c_signed) {
>  #ifndef NO_UC
> -/* Syntax error? Define NO_UC */ Volatile unsigned char c1, char_max;
> -  c1=0; char_max=0;
> +/* Syntax error? Define NO_UC */ Volatile unsigned char c1, char_max_local;
> +  c1=0; char_max_local=0;
>c1++;
> 

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: Support for compiling Python UEFI interpreter with VS2022

[Michael D Kinney]

Hi JP,

Thanks for adding details to the BZ.

For the commit message and PR description please add the
Summary of the types of compiler warnings being addressed.

For example, I did not know why declaring a different named
local variable resolved an issue.

Mike

> -Original Message-
> From: Jayaprakash, N 
> Sent: Wednesday, July 17, 2024 9:58 PM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Rebecca Cran 
> Subject: RE: [edk2-libc Patch 1/1] edk2-libc: Support for compiling Python
> UEFI interpreter with VS2022
> 
> Hi Mike,
> 
> It's a big list of warnings treated as errors in VS2022.
> So, I have captured all these compilation issues in the BZ:
> https://bugzilla.tianocore.org/show_bug.cgi?id=4811
> 
> GitHub actions with VS2019 and GCC building successfully post these fixes in
> my fork of edk2-libc.
> VS2019 Github action: https://github.com/jpshivakavi/edk2-libc-
> jp/actions/runs/9969663166
> GCC github action: https://github.com/jpshivakavi/edk2-libc-
> jp/actions/runs/9969663158
> 
> I have also verified the builds with VS2022  in my local workspace.
> 
> Regards,
> JP
> -Original Message-
> From: Kinney, Michael D 
> Sent: Wednesday, July 17, 2024 9:40 PM
> To: Jayaprakash, N ; devel@edk2.groups.io
> Cc: Rebecca Cran ; Kinney, Michael D
> 
> Subject: RE: [edk2-libc Patch 1/1] edk2-libc: Support for compiling Python
> UEFI interpreter with VS2022
> 
> Can you list the compiler errors that are being fixed by this patch?
> 
> Mike
> 
> > -Original Message-
> > From: Jayaprakash, N 
> > Sent: Tuesday, July 16, 2024 11:59 PM
> > To: devel@edk2.groups.io
> > Cc: Jayaprakash, N ; Rebecca Cran
> > ; Kinney, Michael D 
> > Subject: [edk2-libc Patch 1/1] edk2-libc: Support for compiling Python
> > UEFI interpreter with VS2022
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4811
> >
> > This commit fixes the compilation issues observed with several
> > components in the edk2-libc repo while trying to compile Python
> > interpreter for UEFI.
> >
> > Cc: Rebecca Cran 
> > Cc: Michael D Kinney 
> > Cc: Jayaprakash N 
> > Signed-off-by: Jayaprakash N 
> > ---
> >  AppPkg/Applications/Enquire/Enquire.c | 48 +--
> >  .../OrderedCollectionTest.c   | 10 +--
> >  .../Sockets/DataSource/DataSource.c   | 10 +--
> >  AppPkg/Applications/Sockets/OobRx/OobRx.c |  4 +-
> >  .../Applications/Sockets/RawIp4Rx/RawIp4Rx.c  |  4 +-
> >  StdLib/BsdSocketLib/getnetbyht.c  |  9 ++-
> >  StdLib/BsdSocketLib/ns_print.c| 57 +++--
> >  StdLib/EfiSocketLib/Socket.c  | 80 +--
> >  8 files changed, 116 insertions(+), 106 deletions(-)
> >
> > diff --git a/AppPkg/Applications/Enquire/Enquire.c
> > b/AppPkg/Applications/Enquire/Enquire.c
> > index 1e1db69..5e34f48 100644
> > --- a/AppPkg/Applications/Enquire/Enquire.c
> > +++ b/AppPkg/Applications/Enquire/Enquire.c
> > @@ -5,7 +5,7 @@
> >  Steven Pemberton, CWI, Amsterdam; "steven.pember...@cwi.nl"
> >  Used with permission.
> >
> > -Copyright (c) 2010 - 2011, Intel Corporation. All rights reserved.
> > +Copyright (c) 2010 - 2024, Intel Corporation. All rights
> > + reserved.
> >  This program and the accompanying materials
> >  are licensed and made available under the terms and conditions of
> > the BSD License
> >  which accompanies this distribution. The full text of the license
> > may be found at @@ -918,15 +918,15 @@ memeq(  }
> >
> >  Void
> > -farewell(int bugs)
> > +farewell(int bugs_local)
> >  {
> > -  if (bugs == 0) exit(0);
> > +  if (bugs_local == 0) exit(0);
> >printf("\n%sFor hints on dealing with the ", co);
> > -  if (bugs == 1) printf("problem");
> > -  else printf("%d problems", bugs);
> > +  if (bugs_local == 1) printf("problem");  else printf("%d problems",
> > + bugs_local);
> >printf(" above\n   see the section 'TROUBLESHOOTING' in the file ");
> >printf("%s%s\n", FILENAME, oc);
> > -  exit(bugs);
> > +  exit(bugs_local);
> >  }
> >
> >  /* The program has received a signal where it wasn't expecting one */
> > @@ -1927,51 +1927,51 @@ int cprop( void )
> >
> >  if (c_signed) {
> >  #ifndef NO_UC
> > -/* Syntax error? Define NO_UC */ Volatile unsigned char c1, char_max;
> > -  c1=0; char_max=0;
> > +/* Syntax error? Define NO_UC */ Vol

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: Support for compiling Python UEFI interpreter with VS2022

[Michael D Kinney]

Can you list the compiler errors that are being fixed by this patch?

Mike

> -Original Message-
> From: Jayaprakash, N 
> Sent: Tuesday, July 16, 2024 11:59 PM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-libc Patch 1/1] edk2-libc: Support for compiling Python UEFI
> interpreter with VS2022
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4811
> 
> This commit fixes the compilation issues observed with several
> components in the edk2-libc repo while trying to compile Python
> interpreter for UEFI.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  AppPkg/Applications/Enquire/Enquire.c | 48 +--
>  .../OrderedCollectionTest.c   | 10 +--
>  .../Sockets/DataSource/DataSource.c   | 10 +--
>  AppPkg/Applications/Sockets/OobRx/OobRx.c |  4 +-
>  .../Applications/Sockets/RawIp4Rx/RawIp4Rx.c  |  4 +-
>  StdLib/BsdSocketLib/getnetbyht.c  |  9 ++-
>  StdLib/BsdSocketLib/ns_print.c| 57 +++--
>  StdLib/EfiSocketLib/Socket.c  | 80 +--
>  8 files changed, 116 insertions(+), 106 deletions(-)
> 
> diff --git a/AppPkg/Applications/Enquire/Enquire.c
> b/AppPkg/Applications/Enquire/Enquire.c
> index 1e1db69..5e34f48 100644
> --- a/AppPkg/Applications/Enquire/Enquire.c
> +++ b/AppPkg/Applications/Enquire/Enquire.c
> @@ -5,7 +5,7 @@
>  Steven Pemberton, CWI, Amsterdam; "steven.pember...@cwi.nl"
>  Used with permission.
> 
> -Copyright (c) 2010 - 2011, Intel Corporation. All rights reserved.
> +Copyright (c) 2010 - 2024, Intel Corporation. All rights reserved.
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the
> BSD License
>  which accompanies this distribution. The full text of the license may be
> found at
> @@ -918,15 +918,15 @@ memeq(
>  }
> 
>  Void
> -farewell(int bugs)
> +farewell(int bugs_local)
>  {
> -  if (bugs == 0) exit(0);
> +  if (bugs_local == 0) exit(0);
>printf("\n%sFor hints on dealing with the ", co);
> -  if (bugs == 1) printf("problem");
> -  else printf("%d problems", bugs);
> +  if (bugs_local == 1) printf("problem");
> +  else printf("%d problems", bugs_local);
>printf(" above\n   see the section 'TROUBLESHOOTING' in the file ");
>printf("%s%s\n", FILENAME, oc);
> -  exit(bugs);
> +  exit(bugs_local);
>  }
> 
>  /* The program has received a signal where it wasn't expecting one */
> @@ -1927,51 +1927,51 @@ int cprop( void )
> 
>  if (c_signed) {
>  #ifndef NO_UC
> -/* Syntax error? Define NO_UC */ Volatile unsigned char c1, char_max;
> -  c1=0; char_max=0;
> +/* Syntax error? Define NO_UC */ Volatile unsigned char c1, char_max_local;
> +  c1=0; char_max_local=0;
>c1++;
> -  if (setjmp(lab)==0) { /* Yields char_max */
> -while (c1>char_max) {
> -  char_max=c1;
> +  if (setjmp(lab)==0) { /* Yields char_max_local */
> +while (c1>char_max_local) {
> +  char_max_local=c1;
>c1++;
>  }
>}
>Unexpected(4);
>if (sizeof(char) == sizeof(int)) {
>  u_define(D_UCHAR_MAX, "", "UCHAR", "_MAX",
> -   (ulong) char_max,
> +   (ulong) char_max_local,
> (ulong) UCHAR_MAX, "");
>} else {
>  i_define(D_UCHAR_MAX, "", "UCHAR", "_MAX",
> -   (long) char_max, 0L,
> +   (long) char_max_local, 0L,
> (long) UCHAR_MAX, "");
>}
>  #endif
>  } else {
>  #ifndef NO_SC
> -/* Syntax error? Define NO_SC */ Volatile signed char c1, char_max,
> char_min;
> -  c1=0; char_max=0;
> +/* Syntax error? Define NO_SC */ Volatile signed char c1, char_max_local,
> char_min_local;
> +  c1=0; char_max_local=0;
>c1++;
> -  if (setjmp(lab)==0) { /* Yields char_max */
> -while (c1>char_max) {
> -  char_max=c1;
> +  if (setjmp(lab)==0) { /* Yields char_max_local */
> +while (c1>char_max_local) {
> +  char_max_local=c1;
>c1++;
>  }
>}
> -  c1=0; char_min=0;
> +  c1=0; char_min_local=0;
>c1--;
> -  if (setjmp(lab)==0) { /* Yields char_min */
> -while (c1 -  char_min=c1;
> +  if (setjmp(lab)==0) { /* Yields char_min_local */
> +while (c1 +  char_min_

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure right line endings in .sh .bat

[Michael D Kinney]

+ Leif

.gitattributes is not used in other TianoCore repos.

This feature changes the line endings locally when checked out.

Instead, the edk2 repo uses a CI check like PatchCheck.py to make
sure files with specific extensions have the correct line endings
when they are checked in and files are checked out unmodified.

I know Leif has been evaluating some line ending changes to TianoCore
Repos.  Don't know if this direction is in alignment with those
ideas or not.

Mike

> -Original Message-
> From: Jayaprakash, N 
> Sent: Friday, July 12, 2024 7:27 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure right
> line endings in .sh .bat
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4809
> 
> This commit adds .gitattributes file with the right settings
> to preserve the correct line endings for .sh and .bat files
> as per the Linxu and Windows line ending conventions
> respectively.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  .gitattributes | 2 ++
>  1 file changed, 2 insertions(+)
>  create mode 100644 .gitattributes
> 
> diff --git a/.gitattributes b/.gitattributes
> new file mode 100644
> index 000..3fd9ec8
> --- /dev/null
> +++ b/.gitattributes
> @@ -0,0 +1,2 @@
> +*.bat text eol=crlf
> +*.sh text eol=lf
> \ No newline at end of file
> --
> 2.45.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119913): https://edk2.groups.io/g/devel/message/119913
Mute This Topic: https://groups.io/mt/107182920/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Call for EDK II Community Meeting agenda topics

[Michael D Kinney]

No topics received.  The meeting will be canceled this month.

Mike

From: Kinney, Michael D 
Sent: Wednesday, July 10, 2024 10:57 AM
To: devel@edk2.groups.io
Cc: Kinney, Michael D 
Subject: Call for EDK II Community Meeting agenda topics

Hello,

Are there any topics for this week's EDK II Community meeting?

Thanks,

Mike


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119881): https://edk2.groups.io/g/devel/message/119881
Mute This Topic: https://groups.io/mt/107147700/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Call for EDK II Community Meeting agenda topics

[Michael D Kinney]

Hello,

Are there any topics for this week's EDK II Community meeting?

Thanks,

Mike


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119877): https://edk2.groups.io/g/devel/message/119877
Mute This Topic: https://groups.io/mt/107147700/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Drop VS2015 Support

[Michael D Kinney]

What do you mean by drop?

Remove from CI or remove from both CI and tools_def.txt?

Mike

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Oliver Smith-
> Denny
> Sent: Tuesday, July 9, 2024 12:48 PM
> To: devel@edk2.groups.io; Rebecca Cran 
> Subject: [edk2-devel] Drop VS2015 Support
> 
> Hi Rebecca,
> 
> Per Liming's request I am moving this discussion to the mailing list.
> Now that VS2022 support has been added to edk2, can we drop VS2015
> support (honestly VS2017 could be dropped, too). This is an almost
> 10 year old toolchain that is unsupported, has many quirks, and will
> continue to require odd changes from new code to support it, for no
> gain. VS2015 (and 2017) users should move to VS2022.
> 
> Thanks,
> Oliver
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119856): https://edk2.groups.io/g/devel/message/119856
Mute This Topic: https://groups.io/mt/107129562/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Enable Wikis and Discussions in all Tianocore repos

[Michael D Kinney]

Hello,

There was a request to enable use of GitHub discussions in edk2-libc repo.

This is a feature that has been enabled on a few Tianocore repo such as the 
edk2 repo.

I have enabled Wikis and Discussions on all the active Tianocore repos.

Thanks,

Mike


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119853): https://edk2.groups.io/g/devel/message/119853
Mute This Topic: https://groups.io/mt/107124782/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch v2 0/1] add github actions workflow to build PyUEFI using gcc

[Michael D Kinney]

For the series:

Reviewed-by: Michael D Kinney 

Mike


> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Jayaprakash, N
> Sent: Monday, July 1, 2024 9:11 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N 
> Subject: [edk2-devel] [edk2-libc Patch v2 0/1] add github actions workflow to
> build PyUEFI using gcc
> 
> This patch request adds github actions workflow to build python uefi
> interpreter with gcc tool chain on Ubuntu Linux system.
> The build-python-uefi-gcc.yaml file under .github/workflows implements
> the build action for building the pyuefi interpreter with gcc tool
> chain. You may visit BZ4794 to know more about this.
> 
> 
> Jayaprakash N (1):
>   edk2-libc : add github actions workflow to build PyUEFI using gcc
> 
>  .github/workflows/build-python-uefi-gcc.yaml  | 69 +++
>  .../Python/Python-3.6.8/create_python_pkg.sh  | 40 +--
>  2 files changed, 89 insertions(+), 20 deletions(-)
>  create mode 100644 .github/workflows/build-python-uefi-gcc.yaml
> 
> --
> 2.45.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119746): https://edk2.groups.io/g/devel/message/119746
Mute This Topic: https://groups.io/mt/106982477/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc : add github actions workflow to build PyUEFI using gcc

[Michael D Kinney]

One comment below.

Mike

> -Original Message-
> From: Jayaprakash, N 
> Sent: Monday, July 1, 2024 1:44 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-libc Patch 1/1] edk2-libc : add github actions workflow to
> build PyUEFI using gcc
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4794
> 
> This commit adds github actions workflow to build python uefi
> interpreter with gcc tool chain on Ubuntu Linux system.
> The build-python-uefi-gcc.yaml file under .github/workflows
> implements the build action for building the pyuefi interpreter with
> gcc tool chain.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  .github/workflows/build-python-uefi-gcc.yaml | 71 
>  1 file changed, 71 insertions(+)
>  create mode 100644 .github/workflows/build-python-uefi-gcc.yaml
> 
> diff --git a/.github/workflows/build-python-uefi-gcc.yaml
> b/.github/workflows/build-python-uefi-gcc.yaml
> new file mode 100644
> index 000..5df6c5c
> --- /dev/null
> +++ b/.github/workflows/build-python-uefi-gcc.yaml
> @@ -0,0 +1,71 @@
> +# GitHub actions workflow to build python uefi using gcc
> +#
> +# Copyright (c) 2023-2024, Intel Corporation. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +
> +name: Build Python Interpreter for UEFI with GCC
> +
> +on: [push, pull_request]
> +
> +jobs:
> +  build:
> +runs-on: ubuntu-latest
> +
> +steps:
> +- name: Checkout repository
> +  uses: actions/checkout@v4
> +
> +- name: Setup Python
> +  uses: actions/setup-python@v5
> +  with:
> +python-version: '3.x'
> +
> +- name: Install dependencies
> +  run: |
> +sudo apt-get update
> +sudo apt-get install -y build-essential uuid-dev iasl git nasm
> python3-distutils dos2unix
> +
> +- name: Clone EDK2
> +  run: |
> +git clone https://github.com/tianocore/edk2.git
> +cd edk2
> +git submodule update --init
> +
> +- name: Build EDK2 Base Tools
> +  run: |
> +cd edk2
> +. edksetup.sh
> +make -C BaseTools
> +
> +- name: Run srcprep.py
> +  run: |
> +cd AppPkg/Applications/Python/Python-3.6.8/
> +python3 srcprep.py
> +
> +- name: Build Python UEFI
> +  run: |
> +export PACKAGES_PATH=`pwd`/edk2:`pwd`:
> +export EDK2_LIBC_PATH=`pwd`
> +cd edk2
> +. edksetup.sh
> +build -t GCC5 -a X64 -b RELEASE -p $EDK2_LIBC_PATH/AppPkg/AppPkg.dsc
> -D BUILD_PYTHON368
> +
> +- name: Create PyUEFI package
> +  run: |
> +export WORKSPACE=`pwd`/edk2
> +echo WORKSPACE is $WORKSPACE
> +export EDK2_LIBC_PATH=`pwd`
> +# run the shell script through dos2unix to update any CRLF to LF
> line ending format
> +dos2unix AppPkg/Applications/Python/Python-
> 3.6.8/create_python_pkg.sh
> +. AppPkg/Applications/Python/Python-3.6.8/create_python_pkg.sh GCC5

The create_python_pkg.sh and all .sh files should be changed in git repo
to use unix line endings and remove the need to use dos2unix.

> RELEASE X64 myUEFIPy
> +
> +- name: List build artifacts
> +  run: |
> +ls -R edk2/myUEFIPy
> +
> +- name: Upload build output as artifact
> +  uses: actions/upload-artifact@v4
> +  with:
> +name: myUEFIPy-build-gcc-output
> +path: edk2/myUEFIPy/**/*
> \ No newline at end of file
> --
> 2.45.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119739): https://edk2.groups.io/g/devel/message/119739
Mute This Topic: https://groups.io/mt/106974577/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Maintainers.txt: fix entry for SiFive U5SeriesPkg

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: Leif Lindholm 
> Sent: Monday, June 24, 2024 6:33 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Daniel Schaefer
> 
> Subject: [PATCH edk2-platforms 1/4] Maintainers.txt: fix entry for SiFive
> U5SeriesPkg
> 
> There was an error in the wildcard path described for U5SeriesPkg, so
> it failed to match. Fix the mistake.
> 
> Cc: Michael D Kinney 
> Cc: Daniel Schaefer 
> Signed-off-by: Leif Lindholm 
> ---
>  Maintainers.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index af688c3813f1..824838486072 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -285,8 +285,8 @@ F: Platform/RISC-V/PlatformPkg/
>  M: Sunil V L 
>  R: Daniel Schaefer 
> 
> -Platform/SiFive/U5Series
> -F:Platform/SiFive/U5Series/
> +Platform/SiFive/U5SeriesPkg
> +F: Platform/SiFive/U5SeriesPkg/
>  M: Daniel Schaefer 
> 
>  Silicon/Intel
> --
> 2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119696): https://edk2.groups.io/g/devel/message/119696
Mute This Topic: https://groups.io/mt/106849448/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

We are working on auto assignment.

Right now, maintainers need to watch new PRs and do assignments.

Mike

From: Dhaval Sharma 
Sent: Thursday, June 20, 2024 10:16 PM
To: Kinney, Michael D ; devel@edk2.groups.io
Subject: Re: [edk2-devel] GitHub PR Code Review process now active

Hi Michael,
Just to clarify my understanding. Once a PR is submitted (or it moves from 
draft to regular PR state), it automatically gets reviewers assigned? I 
submitted this one https://github.com/tianocore/edk2/pull/5802 and was 
wondering if I should be sending maintainers an email or be assured that they 
have seen it in which case I would not like to bother them.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119665): https://edk2.groups.io/g/devel/message/119665
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc : add github actions workflow to build PyUEFI using VS2019

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: Jayaprakash, N 
> Sent: Thursday, June 20, 2024 4:47 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-libc Patch v2 1/1] edk2-libc : add github actions workflow to
> build PyUEFI using VS2019
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4788
> 
> This commit adds github actions workflow to build python uefi
> interpreter with visual studio 2019 tool chain.
> The build-python-uefi-vs.yaml file under .github/workflows
> implements the build action for building the pyuefi interpreter with
> VS2019 tool chain.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  .github/workflows/build-python-uefi-vs.yaml | 84 +
>  1 file changed, 84 insertions(+)
>  create mode 100644 .github/workflows/build-python-uefi-vs.yaml
> 
> diff --git a/.github/workflows/build-python-uefi-vs.yaml
> b/.github/workflows/build-python-uefi-vs.yaml
> new file mode 100644
> index 000..a8393d8
> --- /dev/null
> +++ b/.github/workflows/build-python-uefi-vs.yaml
> @@ -0,0 +1,84 @@
> +# GitHub actions workflow to build python uefi using VS2019
> +#
> +# Copyright (c) 2023-2024, Intel Corporation. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +
> +name: Build Python Interpreter for UEFI using VS2019
> +
> +on: [push, pull_request]
> +
> +jobs:
> +  build:
> +runs-on: windows-2019
> +env:
> +  NASM_PREFIX: "C:\\Program Files\\NASM\\"
> +defaults:
> +  run:
> +shell: cmd
> +
> +steps:
> +- name: Checkout repository
> +  uses: actions/checkout@v4
> +
> +- name: Setup Python
> +  uses: actions/setup-python@v5
> +  with:
> +python-version: '3.10'
> +
> +- name: Install NASM
> +  run: choco install nasm
> +
> +- name: VSWhere
> +  run: |
> +"C:\Program Files (x86)\Microsoft Visual
> Studio\Installer\vswhere.exe"
> +
> +- name: Setup environment for Visual Studio 2019 Build Tools
> +  run: |
> +"C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Professional\VC\Auxiliary\Build\vcvarsall.bat" x86
> +set
> +
> +- name: Clone EDK2
> +  run: |
> +git clone https://github.com/tianocore/edk2.git;
> +cd edk2
> +git submodule update --init
> +
> +- name: Build EDK2 Base Tools
> +  run: |
> +cd edk2
> +dir
> +edksetup.bat ForceRebuild
> +
> +- name: Run srcprep.py
> +  run: |
> +echo switching to AppPkg\Applications\Python\Python-3.6.8\
> +cd AppPkg\Applications\Python\Python-3.6.8\
> +dir
> +echo run srcprep.py file
> +python srcprep.py
> +
> +- name: Build Python UEFI
> +  run: |
> +set PACKAGES_PATH=%CD%\edk2;%CD%;
> +set EDK2_LIBC_PATH=%CD%
> +cd edk2
> +call edksetup.bat
> +build -t VS2019 -a X64 -b RELEASE -p
> %EDK2_LIBC_PATH%\AppPkg\AppPkg.dsc -D BUILD_PYTHON368
> +
> +- name: Create Python UEFI package
> +  run: |
> +set WORKSPACE=%CD%\edk2
> +set EDK2_LIBC_PATH=%CD%
> +dir
> +call AppPkg\Applications\Python\Python-3.6.8\create_python_pkg.bat
> VS2019 RELEASE X64 myUEFIPy
> +
> +- name: List build artifacts
> +  run: |
> +dir /S edk2\myUEFIPy
> +
> +- name: Upload build output as artifact
> +  uses: actions/upload-artifact@v4
> +  with:
> +name: myUEFIPy-build-VS2019-output
> +path: edk2\myUEFIPy\**\*
> --
> 2.45.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119662): https://edk2.groups.io/g/devel/message/119662
Mute This Topic: https://groups.io/mt/106778225/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc : update build and packaging scripts to take EDK2_LIBC_PATH

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: Jayaprakash, N 
> Sent: Wednesday, June 19, 2024 12:53 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-libc Patch 1/1] edk2-libc : update build and packaging scripts
> to take EDK2_LIBC_PATH
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4791
> 
> This commit adds necessary changes to build and packaging scripts
> to take path to edk2-libc through an environment variable.
> It also updates the build and packaging instructions in
> GCCCompilationBKMs.rst file and Py368ReadMe.txt files.
> The Python368.inf file is also updated to take EDK2_LIBC_PATH
> instead of the current WORKSPACE path in the CC flags.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  .../Python-3.6.8/GCCCompilationBKMs.rst   | 21 +++--
>  .../Python/Python-3.6.8/Py368ReadMe.txt   | 22 --
>  .../Python/Python-3.6.8/Python368.inf |  6 ++---
>  .../Python/Python-3.6.8/create_python_pkg.bat | 21 ++---
>  .../Python/Python-3.6.8/create_python_pkg.sh  | 23 ---
>  5 files changed, 75 insertions(+), 18 deletions(-)
> 
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> b/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> index 0574977..667b408 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> +++ b/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> @@ -136,17 +136,17 @@ Now clone the edk2-libc git repo by following /
> executing the below commands::
> 
>  bash$ cd ~/src
>  bash$ git clone https://github.com/tianocore/edk2-libc.git
> -bash$ export PACKAGES_PATH=$HOME/src/edk2:$HOME/src/edk2-libc
> 
> +Set the PACKAGES_PATH and EDK2_LIBC_PATH using the commands below::
> +
> +bash$ export PACKAGES_PATH=$HOME/src/edk2:$HOME/src/edk2-libc
> +bash$ export EDK2_LIBC_PATH=$HOME/src/edk2-libc
> 
>  Verify that you can build the hello world application from AppPkg under
> edk2-libc by running the following commands
>  Build hello.inf from edk2-libc applications::
> 
> -$bash build -p AppPkg/AppPkg.dsc -m
> AppPkg/Applications/Hello/Hello.inf
> -
> -Copy the contents of edk2-libc to edk2 folder::
> +$bash build -p ../edk2-libc/AppPkg/AppPkg.dsc -m ../edk2-
> libc/AppPkg/Applications/Hello/Hello.inf
> 
> -bash$ cp -rf ~/src/edk2-libc/* ~/src/edk2/
> 
>  2.5.  Build Python Interpreter using GCC
>  
> @@ -156,7 +156,8 @@ Execute the below command to build the X64 version of the
> Python 3.6.8 interpret
>  bash$ cd AppPkg/Applications/Python/Python-3.6.8/
>  bash$ python srcprep.py
>  bash$ cd ~/src/edk2
> -bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc -m
> AppPkg/Applications/Python/Python-3.6.8/Python368.inf -D BUILD_PYTHON368
> +bash$ build -a X64 -b RELEASE -p ../edk2-libc/AppPkg/AppPkg.dsc \
> +  -m ../edk2-libc/AppPkg/Applications/Python/Python-
> 3.6.8/Python368.inf -D BUILD_PYTHON368
>   or
>  bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc -D
> BUILD_PYTHON368
> 
> @@ -166,7 +167,13 @@ Execute the below command to build the X64 version of
> the Python 3.6.8 interpret
> 
>  To create an usable Python UEFI package with all the dependencies from the
> build environment,
>  you can use the bash shell script create_python_pkg.sh available under
> /AppPkg/Applications/Python/Python-3.6.8
> -folder.
> +folder. Ensure that EDK2_LIBC_PATH environment variable to edk2-libc folder
> path.
> +
> +Ensure that EDK2_LIBC_PATH environment variable to edk2-libc folder path::
> +
> +bash$ echo $EDK2_LIBC_PATH
> +
> +The environment variable should be set to the folder path for the edk2-libc
> cloned repo.
> 
>  Use the following commands to create Python UEFI package::
> 
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> index 91f4c24..8a0b3fe 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> +++ b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> @@ -68,7 +68,24 @@ and that you can successfully build packages within that
> distribution.
>  gc  itertools   math  _operator
>  time
> 
> -  C.  Build AppPkg using the standard "build" command:
> +  C.  Set the PACKAGES_PATH and EDK2_LIBC_PATH environment variables to
> +the right values. PACKAGES_PATH s

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc : make python368.inf compile conditionally in AppPkg.dsc

[Michael D Kinney]

Reviewed-by: Michael D Kinney 


> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Jayaprakash, N
> Sent: Monday, June 17, 2024 11:46 PM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc : make python368.inf
> compile conditionally in AppPkg.dsc
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4789
> 
> This commit adds necessary changes to AppPkg.dsc file for
> conditional compilation of python368.inf. To enable compilation
> of python368.inf users need to pass an additional parameter
> to the build command as -D BUILD_PYTHON368.
> Also updated the Py368ReadMe.txt and the GCCCompilationBKMs.rst
> to include this additional information for building python368.inf.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  AppPkg/AppPkg.dsc| 9 ++---
>  .../Python/Python-3.6.8/GCCCompilationBKMs.rst   | 6 ++
>  AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt  | 9 +++--
>  3 files changed, 11 insertions(+), 13 deletions(-)
> 
> diff --git a/AppPkg/AppPkg.dsc b/AppPkg/AppPkg.dsc
> index e5a6c5e..89f9f1d 100644
> --- a/AppPkg/AppPkg.dsc
> +++ b/AppPkg/AppPkg.dsc
> @@ -7,7 +7,7 @@
>  #   for important information about configuring this package for your
>  #   environment.
>  #
> -#   Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.
> +#   Copyright (c) 2010 - 2024, Intel Corporation. All rights reserved.
>  #   SPDX-License-Identifier: BSD-2-Clause-Patent
>  ##
> 
> @@ -120,8 +120,11 @@
>gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80400040
>}
> 
> - Un-comment the following line to build Python 3.6.8.
> -# AppPkg/Applications/Python/Python-3.6.8/Python368.inf
> + Conditional compilation of python368.inf by passing -D BUILD_PYTHON368
> + through build command
> +  !if $(BUILD_PYTHON368)
> +AppPkg/Applications/Python/Python-3.6.8/Python368.inf
> +  !endif
> 
>   Un-comment the following line to build Lua.
>  #  AppPkg/Applications/Lua/Lua.inf
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> b/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> index 525bef8..0574977 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> +++ b/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst
> @@ -150,17 +150,15 @@ Copy the contents of edk2-libc to edk2 folder::
> 
>  2.5.  Build Python Interpreter using GCC
>  
> -Uncomment the line containing following inf file name in AppPkg/AppPkg.dsc
> file
> -AppPkg/Applications/Python/Python-3.6.8/Python368.inf
> 
>  Execute the below command to build the X64 version of the Python 3.6.8
> interpreter using GCC tool chain::
> 
>  bash$ cd AppPkg/Applications/Python/Python-3.6.8/
>  bash$ python srcprep.py
>  bash$ cd ~/src/edk2
> -bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc -m
> AppPkg/Applications/Python/Python-3.6.8/Python368.inf
> +bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc -m
> AppPkg/Applications/Python/Python-3.6.8/Python368.inf -D BUILD_PYTHON368
>   or
> -bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc
> +bash$ build -a X64 -b RELEASE -p AppPkg/AppPkg.dsc -D
> BUILD_PYTHON368
> 
> 
>  2.5  Create Python UEFI package with all dependencies
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> index a6e65fe..5753443 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> +++ b/AppPkg/Applications/Python/Python-3.6.8/Py368ReadMe.txt
> @@ -68,12 +68,9 @@ and that you can successfully build packages within that
> distribution.
>  gc  itertools   math  _operator
>  time
> 
> -  C.  Edit AppPkg/AppPkg.dsc to enable (uncomment) the Python368.inf line
> -within the [Components] section.
> -
> -  D.  Build AppPkg using the standard "build" command:
> +  C.  Build AppPkg using the standard "build" command:
>  For example, to build Python for an X64 CPU architecture:
> -build -a X64 -p AppPkg\AppPkg.dsc
> +build -a X64 -p AppPkg\AppPkg.dsc -D BUILD_PYTHON368
> 
>  4. Python-related paths and files
>  =
> @@ -133,7 +130,7 @@ system as follows:
>2. Uncomment BsdSocketLib and EfiSocketLib LibraryClasses in Python368.inf
>3. Uncomment the statem

Re: [edk2-devel] GitHub PRs and Mergify: " Allow edits from maintainers" needs to be enabled

[Michael D Kinney]

Hi Rebecca,

I see you have already attempted this.

I read the message/docs.  Perhaps the right thing to do here is for
contributors to change that setting.

What is strange is that the GitHub option to rebase the branch is also
not available, and it usually is.

Mike

> -Original Message-
> From: Kinney, Michael D 
> Sent: Monday, June 17, 2024 9:29 AM
> To: devel@edk2.groups.io; rebe...@bsdio.com; Michael Kubacki
> 
> Cc: Kinney, Michael D 
> Subject: RE: [edk2-devel] GitHub PRs and Mergify: " Allow edits from
> maintainers" needs to be enabled
> 
> I highlighted this issue in a summary before.
> 
> When this is seen, a Maintainer need to request a rebase.
> 
> Mike
> 
> > -Original Message-
> > From: devel@edk2.groups.io  On Behalf Of Rebecca Cran
> > Sent: Monday, June 17, 2024 8:43 AM
> > To: devel@edk2.groups.io; Kinney, Michael D ;
> > Michael Kubacki 
> > Subject: [edk2-devel] GitHub PRs and Mergify: " Allow edits from
> maintainers"
> > needs to be enabled
> >
> > I'm having problems merging https://github.com/tianocore/edk2/pull/5774
> > - Mergify reports:
> >
> >
> > The merge queue pull request can't be updated
> > Details:
> >
> > Pull request can't be updated with latest base branch changes
> >
> > Mergify needs the author permission to update the base branch of the
> > pull request.
> > @Beckhoff  needs to authorize
> > modification on its head branch
> >  > requests/working-with-forks/allowing-changes-to-a-pull-request-branch-
> > created-from-a-fork>.
> >
> >
> > It looks like we need to require users creating PRs to enable the "Allow
> > edits from maintainers" settin*g?*
> > *
> > *
> > *--
> > Rebecca Cran
> > *
> >
> >
> >
> > 
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119595): https://edk2.groups.io/g/devel/message/119595
Mute This Topic: https://groups.io/mt/106723083/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PRs and Mergify: " Allow edits from maintainers" needs to be enabled

[Michael D Kinney]

I highlighted this issue in a summary before.

When this is seen, a Maintainer need to request a rebase.

Mike

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Rebecca Cran
> Sent: Monday, June 17, 2024 8:43 AM
> To: devel@edk2.groups.io; Kinney, Michael D ;
> Michael Kubacki 
> Subject: [edk2-devel] GitHub PRs and Mergify: " Allow edits from maintainers"
> needs to be enabled
> 
> I'm having problems merging https://github.com/tianocore/edk2/pull/5774
> - Mergify reports:
> 
> 
> The merge queue pull request can't be updated
> Details:
> 
> Pull request can't be updated with latest base branch changes
> 
> Mergify needs the author permission to update the base branch of the
> pull request.
> @Beckhoff  needs to authorize
> modification on its head branch
>  requests/working-with-forks/allowing-changes-to-a-pull-request-branch-
> created-from-a-fork>.
> 
> 
> It looks like we need to require users creating PRs to enable the "Allow
> edits from maintainers" settin*g?*
> *
> *
> *--
> Rebecca Cran
> *
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119594): https://edk2.groups.io/g/devel/message/119594
Mute This Topic: https://groups.io/mt/106723083/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc : add github actions workflow to build PyUEFI using VS2019

[Michael D Kinney]

> -Original Message-
> From: Jayaprakash, N 
> Sent: Saturday, June 15, 2024 1:18 AM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Rebecca Cran 
> Subject: RE: [edk2-libc Patch 1/1] edk2-libc : add github actions workflow to
> build PyUEFI using VS2019
> 
> Thanks Mike for your comments.
> Please find my responses inline.
> 
> Regards,
> JP
> 
> -Original Message-
> From: Kinney, Michael D 
> Sent: Saturday, June 15, 2024 7:12 AM
> To: Jayaprakash, N ; devel@edk2.groups.io
> Cc: Rebecca Cran ; Kinney, Michael D
> 
> Subject: RE: [edk2-libc Patch 1/1] edk2-libc : add github actions workflow to
> build PyUEFI using VS2019
> 
> Comments below.
> 
> Mike
> 
> > -Original Message-
> > From: Jayaprakash, N 
> > Sent: Friday, June 14, 2024 10:02 AM
> > To: devel@edk2.groups.io
> > Cc: Jayaprakash, N ; Rebecca Cran
> > ; Kinney, Michael D 
> > Subject: [edk2-libc Patch 1/1] edk2-libc : add github actions workflow
> > to build PyUEFI using VS2019
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4788
> >
> > This commit adds github actions workflow to build python uefi
> > interpreter with visual studio 2019 tool chain.
> > The build-python-uefi-vs.yaml file under .github/workflows implements
> > the build action for building the pyuefi interpreter with VS2019 tool
> > chain. There is also a supporting python script under .github/scripts
> > folder which is used to uncomment the python uefi related .inf file in
> > AppPkg.dsc file.
> >
> > Cc: Rebecca Cran 
> > Cc: Michael D Kinney 
> > Cc: Jayaprakash N 
> > Signed-off-by: Jayaprakash N 
> > ---
> >  .github/scripts/enable_pyuefi_apppkg.py | 31 
> >  .github/workflows/build-python-uefi-vs.yaml | 84
> > +
> >  2 files changed, 115 insertions(+)
> >  create mode 100644 .github/scripts/enable_pyuefi_apppkg.py
> >  create mode 100644 .github/workflows/build-python-uefi-vs.yaml
> >
> > diff --git a/.github/scripts/enable_pyuefi_apppkg.py
> > b/.github/scripts/enable_pyuefi_apppkg.py
> > new file mode 100644
> > index 000..37b9e0a
> > --- /dev/null
> > +++ b/.github/scripts/enable_pyuefi_apppkg.py
> > @@ -0,0 +1,31 @@
> > +'''Script to enable the build of python UEFI interpreter
> > +   in AppPkg.dsc file
> > +'''
> 
> Copyright and License missing
> <> Will add copyright and license
> 
> > +import os
> > +
> > +
> > +script_path = os.path.abspath(__file__) script_dir =
> > +os.path.dirname(script_path)
> > +
> > +# path to the AppPkg.dsc file
> > +path_to_AppPkg_dsc = os.path.join(script_dir, '..', '..', 'edk2',
> > +'AppPkg',
> > 'AppPkg.dsc')
> > +print('Path to AppPkg dsc file : ', path_to_AppPkg_dsc)
> > +
> > +# Check if the file exists
> > +if not os.path.isfile(path_to_AppPkg_dsc):
> > +print(f"The file {path_to_AppPkg_dsc} does not exist.")
> > +else:
> > +# Read the content of the file
> > +with open(path_to_AppPkg_dsc, 'r') as file:
> > +lines = file.readlines()
> > +
> > +# Uncomment the line containing "Python368.inf"
> > +with open(path_to_AppPkg_dsc, 'w') as file:
> > +for line in lines:
> > +if 'Python368.inf' in line and line.strip().startswith('#'):
> > +# Uncomment the line
> > +file.write(line.lstrip('#'))
> > +else:
> > +file.write(line)
> 
> This is complicated to edit a DSC file.  Can this INF be uncommented in this
> DSC file or add another DSC files that is only used for this workflow to
> build python that has this INF uncommented.  Then this extra python script
> can be removed.
> 
> <>
> The reason I chose this approach is because we cannot uncomment this file by
> default in DSC file as it needs few additional steps to be done before the
> compilation.
> Also adding another DSC file can lead to regular maintenance of the DSC file
> whenever there are changes to it, we need update in two files.
> This custom script makes the process is and it keeps the github actions
> specific things are completely isolated from the rest of the code base.
> Would like to continue with this script rather than having a duplicate DCS
> file specifically for github actions.

You can add a !if statement around this INF so by default it is not built
and you can add a -D flag to the build command to build the interpreter.

> 
> > +
> > +print(f"The file {path_to_AppPkg_dsc

Re: [edk2-devel] CryptoPkg host test broken due to smoketest for RDRAND

[Michael D Kinney]

If the host test was updated to use GoogleTest/GoogleMock, then
the call to AsmCpuid() could be mocked instead of calling the
version of BaseLib that is safe to use from host envs.  Then
all the code paths can be tested properly.

Mike

> -Original Message-
> From: Li, Yi1 
> Sent: Friday, June 14, 2024 9:55 PM
> To: Ard Biesheuvel ; Yao, Jiewen 
> Cc: Gerd Hoffmann ; devel@edk2.groups.io; Hou, Wenxing
> ; Kinney, Michael D ;
> Pedro Falcato 
> Subject: RE: [edk2-devel] CryptoPkg host test broken due to smoketest for
> RDRAND
> 
> Hi Jiewen,
> 
> Currently Host lib using a dummy AsmCpuid implementation:
> BaseLib\X86UnitTestHost.c
> AsmCpuid -> UnitTestHostBaseLibAsmCpuid -> Return all zero (BIT30 of ECX
> hardcode to 1 after change of Gerd)
> 
> Did you mean prefer to use real AsmCpuid func in Host?
> Or only use cpuid to check RdRand bit and set it.
> 
> Regards,
> Yi
> 
> -Original Message-
> From: Ard Biesheuvel 
> Sent: Saturday, June 15, 2024 1:16 AM
> To: Yao, Jiewen 
> Cc: Li, Yi1 ; Gerd Hoffmann ;
> devel@edk2.groups.io; Hou, Wenxing ; Kinney, Michael D
> ; Pedro Falcato 
> Subject: Re: [edk2-devel] CryptoPkg host test broken due to smoketest for
> RDRAND
> 
> On Fri, 14 Jun 2024 at 18:45, Yao, Jiewen  wrote:
> >
> >
> > > -Original Message-
> > > From: Ard Biesheuvel 
> > > Sent: Saturday, June 15, 2024 12:14 AM
> > > To: Yao, Jiewen 
> > > Cc: Li, Yi1 ; Gerd Hoffmann ;
> > > devel@edk2.groups.io; Hou, Wenxing ; Kinney,
> > > Michael D ; Pedro Falcato
> > > 
> > > Subject: Re: [edk2-devel] CryptoPkg host test broken due to
> > > smoketest for RDRAND
> > >
> > > On Fri, 14 Jun 2024 at 18:09, Yao, Jiewen  wrote:
> > > >
> > > > Hey
> > > > This PR seems just a workaround.
> > > >
> > > > I don't feel it is right solution to hardcode BIT30.
> > > > What if the host platform does not have such capability? You will
> > > > get failure
> > > later.
> > > >
> > >
> > > Agreed. But that was already the case: RngLib assumed that RDRAND
> > > was implemented without checking CPUID at all, and so the code was
> > > already broken on systems without RDRAND.
> >
> > [Jiewen] Sorry, I don’t understand your comment. " implemented without
> checking CPUID at all "
> >
> > See below code. It does use CPUID to check the capability.
> >
> > EFI_STATUS
> > EFIAPI
> > BaseRngLibConstructor (
> >   VOID
> >   )
> > {
> >   UINT32  RegEcx;
> >
> >   //
> >   // Determine RDRAND support by examining bit 30 of the ECX register
> returned by
> >   // CPUID. A value of 1 indicates that processor support RDRAND
> instruction.
> >   //
> >   AsmCpuid (1, 0, 0, , 0);
> >
> >   mRdRandSupported = ((RegEcx & RDRAND_MASK) == RDRAND_MASK);
> >
> >   if (mRdRandSupported) {
> > mRdRandSupported = TestRdRand ();
> >   }
> >
> >   return EFI_SUCCESS;
> > }
> >
> >
> 
> See commit 9301e5644cef5a5234f71b178373dd508cabb9ee
> 
> The old code had
> 
> +BOOLEAN
> +EFIAPI
> +ArchIsRngSupported (
> +  VOID
> +  )
> +{
> +  /*
> + Existing software depends on this always returning TRUE, so for
> + now hard-code it.
> +
> + return mRdRandSupported;
> +  */
> +  return TRUE;
> +}
> 
> 
> 
> > >
> > > >
> > > > To fix this function, can we call real CPUID instruction to return real
> value?
> > > >
> > >
> > > That would be better. But this change just restores the old behavior.
> > > And on top of that, Yi Li already merged it.
> >
> > [Jiewen] I don’t think it is right to merge it without thorough review.
> >
> > I think we need follow 24 hour rule.
> > Any patch requires at least 24 hours before merge, to give people chance to
> review and feedback.
> >
> 
> Agreed.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119586): https://edk2.groups.io/g/devel/message/119586
Mute This Topic: https://groups.io/mt/10288/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Avoid efi memory allocation for SP type

[Michael D Kinney]

Liming,

It is here, but needs some commit message updates

https://github.com/tianocore/edk2/pull/5760

Mike

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of gaoliming via
> groups.io
> Sent: Friday, June 14, 2024 8:05 PM
> To: devel@edk2.groups.io; dha...@rivosinc.com
> Subject: 回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Avoid efi memory
> allocation for SP type
> 
> Can you create pull request for this change? I will add my review for it.
> 
> > -邮件原件-
> > 发件人: devel@edk2.groups.io  代表 Dhaval Sharma
> > 发送时间: 2024年6月11日 12:09
> > 收件人: devel@edk2.groups.io
> > 抄送: Liming Gao 
> > 主题: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Avoid efi memory
> allocation
> > for SP type
> >
> > Most of the times it is desirable not to use special purpose
> > memory for regular edk2 usages. That memory (HBm/CXL) are
> > either meant for special purposes or are less reliable to
> > be used. So avoid using them as long as possible. We could
> > also introduce PCD for this control.
> >
> > Cc: Liming Gao 
> > Signed-off-by: Dhaval Sharma 
> > ---
> >  MdeModulePkg/Core/Dxe/Mem/Page.c | 7 +++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/MdeModulePkg/Core/Dxe/Mem/Page.c
> > b/MdeModulePkg/Core/Dxe/Mem/Page.c
> > index 5a51d9df1a29..e4daa741b971 100644
> > --- a/MdeModulePkg/Core/Dxe/Mem/Page.c
> > +++ b/MdeModulePkg/Core/Dxe/Mem/Page.c
> > @@ -1183,6 +1183,13 @@ CoreFindFreePagesI (
> >continue;
> >
> >  }
> >
> >
> >
> > +//
> >
> > +// Don't allocate out of Special-Purpose memory.
> >
> > +//
> >
> > +if ((Entry->Attribute & EFI_MEMORY_SP) != 0) {
> >
> > +  continue;
> >
> > +}
> >
> > +
> >
> >  DescStart = Entry->Start;
> >
> >  DescEnd   = Entry->End;
> >
> >
> >
> > --
> > 2.40.1
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#119545): https://edk2.groups.io/g/devel/message/119545
> > Mute This Topic: https://groups.io/mt/106607739/4905953
> > Group Owner: devel+ow...@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > [gaolim...@byosoft.com.cn]
> > -=-=-=-=-=-=
> >
> 
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119584): https://edk2.groups.io/g/devel/message/119584
Mute This Topic: https://groups.io/mt/106683481/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc : add github actions workflow to build PyUEFI using VS2019

[Michael D Kinney]

Comments below.

Mike

> -Original Message-
> From: Jayaprakash, N 
> Sent: Friday, June 14, 2024 10:02 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-libc Patch 1/1] edk2-libc : add github actions workflow to
> build PyUEFI using VS2019
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4788
> 
> This commit adds github actions workflow to build python uefi
> interpreter with visual studio 2019 tool chain.
> The build-python-uefi-vs.yaml file under .github/workflows
> implements the build action for building the pyuefi interpreter
> with VS2019 tool chain. There is also a supporting python script
> under .github/scripts folder which is used to uncomment the python
> uefi related .inf file in AppPkg.dsc file.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  .github/scripts/enable_pyuefi_apppkg.py | 31 
>  .github/workflows/build-python-uefi-vs.yaml | 84 +
>  2 files changed, 115 insertions(+)
>  create mode 100644 .github/scripts/enable_pyuefi_apppkg.py
>  create mode 100644 .github/workflows/build-python-uefi-vs.yaml
> 
> diff --git a/.github/scripts/enable_pyuefi_apppkg.py
> b/.github/scripts/enable_pyuefi_apppkg.py
> new file mode 100644
> index 000..37b9e0a
> --- /dev/null
> +++ b/.github/scripts/enable_pyuefi_apppkg.py
> @@ -0,0 +1,31 @@
> +'''Script to enable the build of python UEFI interpreter
> +   in AppPkg.dsc file
> +'''

Copyright and License missing


> +import os
> +
> +
> +script_path = os.path.abspath(__file__)
> +script_dir = os.path.dirname(script_path)
> +
> +# path to the AppPkg.dsc file
> +path_to_AppPkg_dsc = os.path.join(script_dir, '..', '..', 'edk2', 'AppPkg',
> 'AppPkg.dsc')
> +print('Path to AppPkg dsc file : ', path_to_AppPkg_dsc)
> +
> +# Check if the file exists
> +if not os.path.isfile(path_to_AppPkg_dsc):
> +print(f"The file {path_to_AppPkg_dsc} does not exist.")
> +else:
> +# Read the content of the file
> +with open(path_to_AppPkg_dsc, 'r') as file:
> +lines = file.readlines()
> +
> +# Uncomment the line containing "Python368.inf"
> +with open(path_to_AppPkg_dsc, 'w') as file:
> +for line in lines:
> +if 'Python368.inf' in line and line.strip().startswith('#'):
> +# Uncomment the line
> +file.write(line.lstrip('#'))
> +else:
> +file.write(line)

This is complicated to edit a DSC file.  Can this INF be uncommented in this
DSC file or add another DSC files that is only used for this workflow to
build python that has this INF uncommented.  Then this extra python script
can be removed.

> +
> +print(f"The file {path_to_AppPkg_dsc} has been updated.")
> diff --git a/.github/workflows/build-python-uefi-vs.yaml
> b/.github/workflows/build-python-uefi-vs.yaml
> new file mode 100644
> index 000..aa5c317
> --- /dev/null
> +++ b/.github/workflows/build-python-uefi-vs.yaml
> @@ -0,0 +1,84 @@

Copyright and License missing

> +name: Build Python Interpreter for UEFI using VS2019
> +
> +on: [push, pull_request]
> +
> +jobs:
> +  build:
> +runs-on: windows-2019
> +env:
> +  NASM_PREFIX: "C:\\Program Files\\NASM\\"
> +defaults:
> +  run:
> +shell: cmd
> +
> +steps:
> +- name: Checkout repository
> +  uses: actions/checkout@v4
> +
> +- name: Setup Python
> +  uses: actions/setup-python@v5
> +  with:
> +python-version: '3.10'
> +
> +- name: Install NASM
> +  run: choco install nasm
> +
> +- name: VSWhere
> +  run: |
> +"C:\Program Files (x86)\Microsoft Visual
> Studio\Installer\vswhere.exe"
> +
> +- name: Setup environment for Visual Studio 2019 Build Tools
> +  run: |
> +"C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Professional\VC\Auxiliary\Build\vcvarsall.bat" x86
> +set
> +
> +- name: Clone EDK2
> +  run: |
> +git clone https://github.com/tianocore/edk2.git;
> +cd edk2
> +git submodule update --init
> +
> +- name: Copy edk2-libc contents to edk2
> +  run: |
> +dir
> +cmd /c xcopy /E /I /Y AppPkg edk2\AppPkg
> +cmd /c xcopy /E /I /Y StdLib edk2\StdLib
> +cmd /c xcopy /E /I /Y StdLibPrivateInternalFiles
> edk2\StdLibPrivateInternalFiles

Use PACKAGES_PATH instead of copying files into edk2 repo

> +
> +- name: Build EDK2 Base Tools
> +  run: |
> +cd edk2
> +  

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute

[Michael D Kinney]

Hi Oliver,

The DXE Core already has a policy to auto convert untested memory to
tested memory if the DXE Core runs out of memory.

Should we have a different memory type to allocate memory with the
EFI_MEMORY_SP attribute?

What would be the side effects of performing general allocations from
memory with the EFI_MEMORY_SP attribute?  If there are potentially bad 
side effects, then the DXE Core should never allocate from those
ranges and it is up to the platform to make sure there is enough normal
memory to boot.

Mike

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Oliver Smith-
> Denny
> Sent: Tuesday, June 11, 2024 10:04 AM
> To: devel@edk2.groups.io; dha...@rivosinc.com; Michael Kubacki
> 
> Subject: Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Add the
> EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute
> 
> On 6/9/2024 6:44 PM, Dhaval Sharma wrote:
> > Related to this, I also faced this issue where in order to prevent edk2
> > from allocating this memory I had to modify CoreFindFreePagesI
> >      //
> >      // Don't allocate out of Special-Purpose memory.
> >      //
> >      if ((Entry->Attribute & EFI_MEMORY_SP) != 0) {
> >        continue;
> >      }
> > Can't we add PCD based logic here to selectively NOT use SP memory for
> > edk2 allocations? I think "reserved-memory" attr does not work well
> > because it would force OS/drivers not to use it. Which is not what we
> > want. We really want special drivers to make use of it.
> 
> We've had some other conversations around this and I agree, we don't
> want DXE Core to allocate this memory unless it has no other option.
> I don't think this should be a PCD, I think DXE can make the statement
> that it won't allocate EFI_MEMORY_SP memory unless it has run out of
> other memory.
> 
> Thanks,
> Oliver
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119552): https://edk2.groups.io/g/devel/message/119552
Mute This Topic: https://groups.io/mt/106165072/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Call for TianoCore Community Meeting topics

[Michael D Kinney]

No topics received.  Meeting canceled.

Mike

From: Kinney, Michael D 
Sent: Tuesday, June 4, 2024 11:19 PM
To: edk2-devel-groups-io 
Cc: Kinney, Michael D 
Subject: Call for TianoCore Community Meeting topics

Hi,

Are there any topics for the TianoCore community meeting this month?

Thanks,

Mike


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119502): https://edk2.groups.io/g/devel/message/119502
Mute This Topic: https://groups.io/mt/106498468/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

Hi Guo,

Thanks.  Edk2 is running PatchCheck.py as part of CI.

The Maintainer still needs to verify the commit message contents
even if it passes PatchCheck.py.

Mike

> -Original Message-
> From: Dong, Guo 
> Sent: Wednesday, June 5, 2024 6:22 PM
> To: devel@edk2.groups.io; Kinney, Michael D 
> Subject: RE: [edk2-devel] GitHub PR Code Review process now active
> 
> 
> Hi Mike,
> 
> Glad to see EDK2 PR code review process is active.
> In Slim Bootloader project, it runs BaseTools/Scripts/PatchCheck.py to check
> the PR commit message when running QEMU CI test
> Maybe you could refer
> https://github.com/slimbootloader/slimbootloader/blob/48a24b87824321c053cccf3
> 67c7c3637ff581fdf/.azurepipelines/azure-pipelines.yml#L38 to check if EDK2
> could use similar check.
> 
> Thanks,
> Guo
> 
> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Michael D
> Kinney
> Sent: Wednesday, June 5, 2024 3:21 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D 
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> Hello,
> 
> The PR code review process has been active for a little over a week now.
> 
> There have been about 17 PRs merged since the switch and it appears to have
> been mostly working well. I also note that the emails per day on this mailing
> list is much smaller as the code reviews have migrated to PRs.
> 
> A few issues have been noted:
> 
> 1) Contributors that are not EDK II Maintainers do not have permissions
>to assign reviewers
> 
>* Mitigation #1: EDK II Maintainers review new PRs and assign reviewers
>* Mitigation #2: Use CODEOWNERS to auto assign maintainers.  WIP.
> 
> * EDK II Maintainers must review the commit message in each commit and
>   to make sure it follows the required commit message format and has
>   an appropriate Signed-off-by tag. GitHub does not provide a way to
>   provide review comments for a commit message. Instead, feedback on
>   commit messages must be provided in the main PR conversation and quote
>   commit message that requires changes as required.
> 
> * Slow CI Performance
> 
>   This appears to be due to longer than expected queues in Azure Pipelines.
>   Azure Pipelines is working through the backlog. It may help if the
>   number of requests to rebase and number of new commits to open PRs are
>   reduced. The Tools/CI team will continue to collect data and determine
>   if other changes are needed to reduce the CI overhead.
> 
> * Some PRs have been merged using the "Rebase and Merge" button in the
>   PR after all required reviews completed and all CI checks pass. Instead,
>   the "push" label should continue to be used. There does not appear to be
>   any unexpected side effects from the "Rebase and Merge" button, but that
>   option is not available if the PR needs to be rebased. This is what
>   Mergify handles through a merge queue, so the easiest way to merge right
>   now is the "push" label.
> 
>   If the most recent commit was not performed by an EDK II Maintainers, then
>   Mergify attempt to rebase may fail.
> 
> Mitigation #1: EDK II Maintainer perform a rebase
> Mitigation #2: Update Mergify to use a bot account with write permission
>to perform rebase operations.
> 
>   There was feedback earlier in the year that the git commit history does
>   not indicate which maintainer was the committer.  Instead it always shows
>   Mergify.
> 
>   The use of GitHub Merge Queues will be evaluated to see if it can be used
>   instead of Mergify and remove the need for the "push" label and allow the
>   "Rebase and Merge" button to be used and avoid the Mergify permission
> issues.
> 
> * Some PRs do not complete all CI checks waiting for "Workflow Approval".
>   this can occur when a PR is updated by an outside collaborator that does
>   not have any previous "Workflow Approvals" accepted.
> 
>   Mitigation #1: EDK II Maintainers review PRs and accept the "Workflow
> Approval"
>  if the PR looks like a good change request.
>   Mitigation #2: Relax the edk2 repo configuration settings related to
> workflows
> 
> * When a PR needs to be rebased, there are 2 options available through the
>   Web UI:
> 
>   * Update with merge commit (Never use - generates PatchCheck errors)
>   * Update with rebase (Only use this one)
> 
>   If Update with merge commit is accidently applied, then redo again
>   Using "Update with rebase"
> 
> Please provide feedback if you are seeing other issues or have other
> suggestions to improve the process.
> 
> Thanks,
> 

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

The Merge button may not work in that case either if there is
parallel activity by other developers or Mergify.  Using the
"push" label is recommended so Maintainers do not have to wait
and rebase.

I understand the desire to apply to other repos quickly.  Let's
work through some of these known issues for another week and
then evaluate if it should be applied to edk2-platforms yet.

Mike

> -Original Message-
> From: Rebecca Cran 
> Sent: Wednesday, June 5, 2024 3:48 PM
> To: devel@edk2.groups.io; Kinney, Michael D 
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> On 6/5/2024 4:21 PM, Michael D Kinney via groups.io wrote:
> > * Some PRs have been merged using the "Rebase and Merge" button in the
> >PR after all required reviews completed and all CI checks pass. Instead,
> >the "push" label should continue to be used. There does not appear to be
> >any unexpected side effects from the "Rebase and Merge" button, but that
> >option is not available if the PR needs to be rebased. This is what
> >Mergify handles through a merge queue, so the easiest way to merge right
> >now is the "push" label.
> >
> >If the most recent commit was not performed by an EDK II Maintainers,
> then
> >Mergify attempt to rebase may fail.
> >
> >  Mitigation #1: EDK II Maintainer perform a rebase
> >  Mitigation #2: Update Mergify to use a bot account with write
> permission
> > to perform rebase operations.
> >
> >There was feedback earlier in the year that the git commit history does
> >not indicate which maintainer was the committer.  Instead it always
> shows
> >Mergify.
> >
> >The use of GitHub Merge Queues will be evaluated to see if it can be
> used
> >instead of Mergify and remove the need for the "push" label and allow
> the
> >"Rebase and Merge" button to be used and avoid the Mergify permission
> issues.
> 
> So it sounds like using the "Merge" button is fine as long as the user
> understands they may need to rebase, wait for CI to finish and then merge?
> 
> Also, is there a timeline on enabling PRs for the other repos? I'd
> really like to switch to them for edk2-platforms, even if it means
> having to update settings in multiple repos as we find issues with the
> process.
> 
> 
> --
> Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119491): https://edk2.groups.io/g/devel/message/119491
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

Hello,

The PR code review process has been active for a little over
a week now.

There have been about 17 PRs merged since the switch and it appears
to have been mostly working well. I also note that the emails per
day on this mailing list is much smaller as the code reviews have
migrated to PRs.

A few issues have been noted:

1) Contributors that are not EDK II Maintainers do not have permissions
   to assign reviewers 

   * Mitigation #1: EDK II Maintainers review new PRs and assign reviewers
   * Mitigation #2: Use CODEOWNERS to auto assign maintainers.  WIP.

* EDK II Maintainers must review the commit message in each commit and 
  to make sure it follows the required commit message format and has 
  an appropriate Signed-off-by tag. GitHub does not provide a way to
  provide review comments for a commit message. Instead, feedback on
  commit messages must be provided in the main PR conversation and quote
  commit message that requires changes as required.

* Slow CI Performance

  This appears to be due to longer than expected queues in Azure Pipelines.
  Azure Pipelines is working through the backlog. It may help if the 
  number of requests to rebase and number of new commits to open PRs are
  reduced. The Tools/CI team will continue to collect data and determine 
  if other changes are needed to reduce the CI overhead.

* Some PRs have been merged using the "Rebase and Merge" button in the 
  PR after all required reviews completed and all CI checks pass. Instead,
  the "push" label should continue to be used. There does not appear to be
  any unexpected side effects from the "Rebase and Merge" button, but that
  option is not available if the PR needs to be rebased. This is what 
  Mergify handles through a merge queue, so the easiest way to merge right
  now is the "push" label.

  If the most recent commit was not performed by an EDK II Maintainers, then
  Mergify attempt to rebase may fail.

Mitigation #1: EDK II Maintainer perform a rebase
Mitigation #2: Update Mergify to use a bot account with write permission
   to perform rebase operations.

  There was feedback earlier in the year that the git commit history does
  not indicate which maintainer was the committer.  Instead it always shows
  Mergify.

  The use of GitHub Merge Queues will be evaluated to see if it can be used
  instead of Mergify and remove the need for the "push" label and allow the
  "Rebase and Merge" button to be used and avoid the Mergify permission issues.

* Some PRs do not complete all CI checks waiting for "Workflow Approval".
  this can occur when a PR is updated by an outside collaborator that does
  not have any previous "Workflow Approvals" accepted.

  Mitigation #1: EDK II Maintainers review PRs and accept the "Workflow 
Approval"
 if the PR looks like a good change request.
  Mitigation #2: Relax the edk2 repo configuration settings related to workflows

* When a PR needs to be rebased, there are 2 options available through the 
  Web UI:

  * Update with merge commit (Never use - generates PatchCheck errors)
  * Update with rebase (Only use this one)

  If Update with merge commit is accidently applied, then redo again 
  Using "Update with rebase"

Please provide feedback if you are seeing other issues or have other suggestions
to improve the process.

Thanks,

Mike

> -Original Message-
> From: Kinney, Michael D 
> Sent: Monday, June 3, 2024 12:38 PM
> To: Neal Gompa ; devel@edk2.groups.io
> Cc: Kinney, Michael D 
> Subject: RE: [edk2-devel] GitHub PR Code Review process now active
> 
> The reason to allow a draft PR is to allow contributors to run all the
> CI tests to see if they pass and resolve issues before starting a review.
> 
> The CI tests include combinations of OS/compiler that not all contributors
> have available.
> 
> Mike
> 
> > -Original Message-
> > From: Neal Gompa 
> > Sent: Monday, June 3, 2024 11:47 AM
> > To: devel@edk2.groups.io; Kinney, Michael D 
> > Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> >
> > Hmm, I don't see a setting for it anymore, maybe that's not a thing
> anymore?
> >
> > I seemingly recall that draft PRs didn't get CI runs, but if that's
> > not a thing anymore, then that's fine.
> >
> > That said, draft PRs cannot be reviewed, so we should not be telling
> > people to make draft PRs.
> >
> >
> > On Mon, Jun 3, 2024 at 12:26 PM Michael D Kinney via groups.io
> >
> >  wrote:
> > >
> > > CI jobs are dispatched to both GitHub Actions and Azure Pipelines.
> > >
> > > For Draft PRs, I see both GitHub Actions and Azure Pipelines jobs
> running.
> > >
> > > This must

[edk2-devel] Call for TianoCore Community Meeting topics

[Michael D Kinney]

Hi,

Are there any topics for the TianoCore community meeting this month?

Thanks,

Mike


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119468): https://edk2.groups.io/g/devel/message/119468
Mute This Topic: https://groups.io/mt/106498468/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

The reason to allow a draft PR is to allow contributors to run all the
CI tests to see if they pass and resolve issues before starting a review.

The CI tests include combinations of OS/compiler that not all contributors
have available.

Mike

> -Original Message-
> From: Neal Gompa 
> Sent: Monday, June 3, 2024 11:47 AM
> To: devel@edk2.groups.io; Kinney, Michael D 
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> Hmm, I don't see a setting for it anymore, maybe that's not a thing anymore?
> 
> I seemingly recall that draft PRs didn't get CI runs, but if that's
> not a thing anymore, then that's fine.
> 
> That said, draft PRs cannot be reviewed, so we should not be telling
> people to make draft PRs.
> 
> 
> On Mon, Jun 3, 2024 at 12:26 PM Michael D Kinney via groups.io
> 
>  wrote:
> >
> > CI jobs are dispatched to both GitHub Actions and Azure Pipelines.
> >
> > For Draft PRs, I see both GitHub Actions and Azure Pipelines jobs running.
> >
> > This must imply that edk2 repo allows this.  Do you happen to know where
> > this is configurable or a link to GitHub docs for configuration?
> >
> > Mike
> >
> > > -Original Message-
> > > From: Neal Gompa 
> > > Sent: Monday, June 3, 2024 9:13 AM
> > > To: devel@edk2.groups.io; Kinney, Michael D 
> > > Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> > >
> > > On Tue, May 28, 2024 at 2:53 PM Michael D Kinney via groups.io
> > >  wrote:
> > > >
> > > > Hello,
> > > >
> > > > The GitHub PR code review process is now active.  Please
> > > > use the new PR based code review process for all new
> > > > submissions starting today.
> > > >
> > > > * The Wiki has been updated with the process changes.
> > > >
> > > >   https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-
> Development-
> > > Process
> > > >
> > > >   Big thanks to Michael Kubacki for writing up all the
> > > >   changes based on the RFC proposal and community discussions.
> > > >
> > > >   We will learn by using, so if you see anything missing or
> > > >   incorrect or clarifications needed, please send feedback
> > > >   here so the Wiki pages can be updated quickly for everyone.
> > > >
> > > > * The edk2 repo settings have been updated to require
> > > >   a GitHub PR code review approval before merging and
> > > >   all conversations must be resolved before merging.
> > > >
> > > > * A PR has been opened that removes the requirement for
> > > >   Cc: tags in the commit messages and is the first PR
> > > >   that will use the new process. This PR needs to be
> > > >   reviewed and merged to support the revised commit
> > > >   message format.
> > > >
> > > >   https://github.com/tianocore/edk2/pull/5688
> > > >
> > > >   https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-
> > > Format
> > > >
> > > > * Please use "Draft" PRs to run CI without any reviews.
> > > >   Once ready for reviews, convert from "Draft" to
> > > >   "Ready for Review".
> > > >
> > >
> > > Generally GitHub doesn't allow CI to run on PRs created as draft pull
> > > requests. Was this changed for edk2?
> > >
> > >
> > > --
> > > 真実はいつも一つ！/ Always, there's only one truth!
> >
> >
> > 
> >
> >
> 
> 
> --
> 真実はいつも一つ！/ Always, there's only one truth!


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119434): https://edk2.groups.io/g/devel/message/119434
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

CI jobs are dispatched to both GitHub Actions and Azure Pipelines.

For Draft PRs, I see both GitHub Actions and Azure Pipelines jobs running.

This must imply that edk2 repo allows this.  Do you happen to know where
this is configurable or a link to GitHub docs for configuration?

Mike

> -Original Message-
> From: Neal Gompa 
> Sent: Monday, June 3, 2024 9:13 AM
> To: devel@edk2.groups.io; Kinney, Michael D 
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> On Tue, May 28, 2024 at 2:53 PM Michael D Kinney via groups.io
>  wrote:
> >
> > Hello,
> >
> > The GitHub PR code review process is now active.  Please
> > use the new PR based code review process for all new
> > submissions starting today.
> >
> > * The Wiki has been updated with the process changes.
> >
> >   https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-
> Process
> >
> >   Big thanks to Michael Kubacki for writing up all the
> >   changes based on the RFC proposal and community discussions.
> >
> >   We will learn by using, so if you see anything missing or
> >   incorrect or clarifications needed, please send feedback
> >   here so the Wiki pages can be updated quickly for everyone.
> >
> > * The edk2 repo settings have been updated to require
> >   a GitHub PR code review approval before merging and
> >   all conversations must be resolved before merging.
> >
> > * A PR has been opened that removes the requirement for
> >   Cc: tags in the commit messages and is the first PR
> >   that will use the new process. This PR needs to be
> >   reviewed and merged to support the revised commit
> >   message format.
> >
> >   https://github.com/tianocore/edk2/pull/5688
> >
> >   https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-
> Format
> >
> > * Please use "Draft" PRs to run CI without any reviews.
> >   Once ready for reviews, convert from "Draft" to
> >   "Ready for Review".
> >
> 
> Generally GitHub doesn't allow CI to run on PRs created as draft pull
> requests. Was this changed for edk2?
> 
> 
> --
> 真実はいつも一つ！/ Always, there's only one truth!


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119430): https://edk2.groups.io/g/devel/message/119430
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

Hi Michael,

Do you know why there would be dependabot commits in PRs not related to 
dependabot updates?

For example:

https://github.com/tianocore/edk2/pull/5708/commits

Thanks,

Mike



> -Original Message-
> From: Kinney, Michael D 
> Sent: Thursday, May 30, 2024 11:01 AM
> To: Kasbekar, Saloni ; devel@edk2.groups.io;
> mikub...@linux.microsoft.com; Rebecca Cran ;
> kra...@redhat.com; Kubacki, Michael 
> Cc: Kinney, Michael D 
> Subject: RE: [edk2-devel] GitHub PR Code Review process now active
> 
> Yes.
> 
> Mike
> 
> > -Original Message-
> > From: Kasbekar, Saloni 
> > Sent: Thursday, May 30, 2024 10:39 AM
> > To: devel@edk2.groups.io; mikub...@linux.microsoft.com; Kinney, Michael D
> > ; Rebecca Cran ;
> > kra...@redhat.com; Kubacki, Michael 
> > Subject: RE: [edk2-devel] GitHub PR Code Review process now active
> >
> > How are we planning to handle packages (like NetworkPkg) without a
> > maintainer? Would the stewards add in the reviewers in that case?
> >
> > -Original Message-
> > From: devel@edk2.groups.io  On Behalf Of Michael
> > Kubacki
> > Sent: Wednesday, May 29, 2024 5:51 PM
> > To: Kinney, Michael D ; devel@edk2.groups.io;
> > Rebecca Cran ; kra...@redhat.com; Kubacki, Michael
> > 
> > Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> >
> > I've updated the wiki process to clarify that maintainers need to ensure PR
> > reviewers are added and that a contributor cannot do so unless they are a
> > maintainer in this update:
> >
> > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-
> >
> Process/_compare/b9d1f34e40d8ecbc7b59632302c9b0c823f52ab8...dd846b296754da310
> > 03f8c2a70e9a0b861e600b6
> >
> > I did not include the @ ID process since there was not clear
> > consensus on that. I think it's tedious and for this small window of time
> > without automation, ideally the GitHub notifications mentioned earlier can
> be
> > used.
> >
> > Thanks,
> > Michael
> >
> > On 5/29/2024 4:06 PM, Kinney, Michael D wrote:
> > > We could, but that would require manually syncing CODEOWNERS with
> > > Maintainer.txt until that part of the process is automated.
> > >
> > > We also need a way to verify that CODEOWNERS and Maintainers.txt
> > > produce the exact same assignments.
> > >
> > > This was on the list of future enhancements when resources are
> > > available to help.  We need to focus on a process that works until
> > > those automations can be deployed and supported.
> > >
> > > Mike
> > >
> > >> -Original Message-
> > >> From: Michael Kubacki 
> > >> Sent: Wednesday, May 29, 2024 12:25 PM
> > >> To: devel@edk2.groups.io; Kinney, Michael D
> > >> ; Rebecca Cran ;
> > >> kra...@redhat.com; Kubacki, Michael 
> > >> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> > >>
> > >> Mike,
> > >>
> > >> I agree that automatically adding reviewers would be helpful.
> > >>
> > >> Do you think we could add a CODEOWNERS file now to assist with this?
> > >>
> > >> Benefits being:
> > >>
> > >> 1. CODEOWNERS is low overhead in that GitHub already supports it.
> > >>
> > >> 2. We do not need to require CODEOWNER enforcement yet. We can simply
> > >> use it for automating the process of adding maintainers.
> > >>
> > >> 3. Maintainers have write access so they are required to approve and
> > >> add the push label. This would add a relevant maintainer(s) with
> > >> write access to fulfill that role.
> > >>
> > >> Thanks,
> > >> Michael
> > >>
> > >> On 5/29/2024 2:27 PM, Michael D Kinney wrote:
> > >>> GitHub has notification settings.  Maintainers should configure
> > >>> GitHub so they are notified of all PR submissions to edk2 repo.
> > >>>
> > >>> The Wiki for the Maintainer Process provides a link to this page
> > >>> with the
> > >> details:
> > >>>
> > >>> https://docs.github.com/en/account-and-profile/managing-subscription
> > >>> s-and-
> > >> notifications-on-github/setting-up-notifications/configuring-notifica
> > >> tions
> > >>>
> > >>> https://docs.github.com/en/account-and-profile/managing-subscrip

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

Yes.

Mike

> -Original Message-
> From: Kasbekar, Saloni 
> Sent: Thursday, May 30, 2024 10:39 AM
> To: devel@edk2.groups.io; mikub...@linux.microsoft.com; Kinney, Michael D
> ; Rebecca Cran ;
> kra...@redhat.com; Kubacki, Michael 
> Subject: RE: [edk2-devel] GitHub PR Code Review process now active
> 
> How are we planning to handle packages (like NetworkPkg) without a
> maintainer? Would the stewards add in the reviewers in that case?
> 
> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Michael
> Kubacki
> Sent: Wednesday, May 29, 2024 5:51 PM
> To: Kinney, Michael D ; devel@edk2.groups.io;
> Rebecca Cran ; kra...@redhat.com; Kubacki, Michael
> 
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> I've updated the wiki process to clarify that maintainers need to ensure PR
> reviewers are added and that a contributor cannot do so unless they are a
> maintainer in this update:
> 
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-
> Process/_compare/b9d1f34e40d8ecbc7b59632302c9b0c823f52ab8...dd846b296754da310
> 03f8c2a70e9a0b861e600b6
> 
> I did not include the @ ID process since there was not clear
> consensus on that. I think it's tedious and for this small window of time
> without automation, ideally the GitHub notifications mentioned earlier can be
> used.
> 
> Thanks,
> Michael
> 
> On 5/29/2024 4:06 PM, Kinney, Michael D wrote:
> > We could, but that would require manually syncing CODEOWNERS with
> > Maintainer.txt until that part of the process is automated.
> >
> > We also need a way to verify that CODEOWNERS and Maintainers.txt
> > produce the exact same assignments.
> >
> > This was on the list of future enhancements when resources are
> > available to help.  We need to focus on a process that works until
> > those automations can be deployed and supported.
> >
> > Mike
> >
> >> -Original Message-
> >> From: Michael Kubacki 
> >> Sent: Wednesday, May 29, 2024 12:25 PM
> >> To: devel@edk2.groups.io; Kinney, Michael D
> >> ; Rebecca Cran ;
> >> kra...@redhat.com; Kubacki, Michael 
> >> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> >>
> >> Mike,
> >>
> >> I agree that automatically adding reviewers would be helpful.
> >>
> >> Do you think we could add a CODEOWNERS file now to assist with this?
> >>
> >> Benefits being:
> >>
> >> 1. CODEOWNERS is low overhead in that GitHub already supports it.
> >>
> >> 2. We do not need to require CODEOWNER enforcement yet. We can simply
> >> use it for automating the process of adding maintainers.
> >>
> >> 3. Maintainers have write access so they are required to approve and
> >> add the push label. This would add a relevant maintainer(s) with
> >> write access to fulfill that role.
> >>
> >> Thanks,
> >> Michael
> >>
> >> On 5/29/2024 2:27 PM, Michael D Kinney wrote:
> >>> GitHub has notification settings.  Maintainers should configure
> >>> GitHub so they are notified of all PR submissions to edk2 repo.
> >>>
> >>> The Wiki for the Maintainer Process provides a link to this page
> >>> with the
> >> details:
> >>>
> >>> https://docs.github.com/en/account-and-profile/managing-subscription
> >>> s-and-
> >> notifications-on-github/setting-up-notifications/configuring-notifica
> >> tions
> >>>
> >>> https://docs.github.com/en/account-and-profile/managing-subscription
> >>> s-and-
> >> notifications-on-github/setting-up-notifications/configuring-
> >> notifications#about-custom-notifications
> >>>
> >>> This allows Maintainers to receive notifications without being an
> >>> assigned reviewer.
> >>>
> >>> Mike
> >>>
> >>>> -Original Message-
> >>>> From: Rebecca Cran 
> >>>> Sent: Wednesday, May 29, 2024 11:19 AM
> >>>> To: devel@edk2.groups.io; Kinney, Michael D
> >>>> ; kra...@redhat.com; Kubacki, Michael
> >>>> 
> >>>> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> >>>>
> >>>> On 5/29/2024 12:09 PM, Michael D Kinney via groups.io wrote:
> >>>>> Hi Gerd,
> >>>>>
> >>>>> We can clarify the Wiki.  A Maintainer has to be involved in every
>

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

All Maintainer.txt rules are matches and all maintainers/reviewers are combined

CODEOWNERS only matches the last rule.

I do not think your suggestion works. 

Mike

> -Original Message-
> From: kra...@redhat.com 
> Sent: Thursday, May 30, 2024 1:33 AM
> To: Kinney, Michael D 
> Cc: Michael Kubacki ; devel@edk2.groups.io;
> Rebecca Cran ; Kubacki, Michael
> 
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> On Wed, May 29, 2024 at 08:06:00PM GMT, Kinney, Michael D wrote:
> > We could, but that would require manually syncing CODEOWNERS
> > with Maintainer.txt until that part of the process is automated.
> 
> https://github.com/tianocore/edk2/pull/5703 ;)
> 
> take care,
>   Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119396): https://edk2.groups.io/g/devel/message/119396
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] libspdm Breaking Builds

[Michael D Kinney]

Hi Pete,

https://github.com/tianocore/edk2/pull/5697 was merged and should
resolve your issue.

Please let us know if it does not.

Mike

> -Original Message-
> From: Pete Batard 
> Sent: Wednesday, May 29, 2024 3:01 PM
> To: Kinney, Michael D ; devel@edk2.groups.io;
> Yao, Jiewen ; mikub...@linux.microsoft.com
> Subject: Re: [edk2-devel] libspdm Breaking Builds
> 
> Thanks Michael,
> 
> After working around some weird rate-limiting from GitHub, I was finally
> able to apply your suggested workaround, and can validate that it indeed
> works:
> https://github.com/pbatard/UEFI-Shell/actions/runs/9293562444/job/25576978957
> 
> Still, I would assert that many people trying to use EDK2 as a submodule
> dependency in automated workflow will want to avoid having juggling with
> workarounds, so the sooner the breaking dependency is changed in EDK2,
> the better.
> 
> Regards,
> 
> /Pete
> 
> On 2024.05.29 20:40, Kinney, Michael D wrote:
> > Hi Pete,
> >
> > I just tested this config command and it works when cryptomilk is down.
> >
> >  git config --global url."https://github.com/tianocore/edk2-
> cmocka.git".insteadOf "https://git.cryptomilk.org/projects/cmocka.git;
> >
> > I updated edk2-cmocka mirror last week.
> >
> > I tested this with
> >
> >  git clone https://github.com/tianocore/edk2 --recursive
> >
> > Best regards,
> >
> > Mike
> >
> >> -Original Message-
> >> From: Kinney, Michael D 
> >> Sent: Wednesday, May 29, 2024 11:33 AM
> >> To: Pete Batard ; devel@edk2.groups.io; Yao, Jiewen
> >> ; mikub...@linux.microsoft.com
> >> Cc: Kinney, Michael D 
> >> Subject: RE: [edk2-devel] libspdm Breaking Builds
> >>
> >> Hi Pete,
> >>
> >> There is another option for developers and CI agents.
> >>
> >> Git supports a URL insteadof option to redirect git requests.
> >>
> >>  https://git-scm.com/docs/git-config#Documentation/git-config.txt-
> >> urlltbasegtinsteadOf
> >>
> >> We can use this to redirect a request from cryptomilk cmocka to the
> >> TianoCore mirror of cryptomilk cmocka.
> >>
> >> For developers, this can be a global config setting so it works
> >> for all edk2 trees on their system.
> >>
> >> For a CI agent, this could be ab early step in all CI jobs to perform
> >> a git config action.  Perhaps a feature Stuart could adopt to support
> >> URL redirects.
> >>
> >> Mike
> >>
> >>
> >>> -Original Message-
> >>> From: Pete Batard 
> >>> Sent: Wednesday, May 29, 2024 11:18 AM
> >>> To: devel@edk2.groups.io; Yao, Jiewen ; Kinney,
> >> Michael
> >>> D ; mikub...@linux.microsoft.com
> >>> Subject: Re: [edk2-devel] libspdm Breaking Builds
> >>>
> >>> Hello all,
> >>>
> >>> On 2024.05.24 03:13, Yao, Jiewen via groups.io wrote:
>  Please let us know if the preference for libspdm submodule. (Below
> >> options)
>  1) Keep current libspdm official 3.3.0 release, and update to next
> >> release
> >>> at the beginning of July.
>  2) Update libspdm immediately with the new cmocka submodule, which is
> NOT
> >>> an official release.
> >>>
> >>> Considering that I (and I expect anybody who tries to use EDK2 as a
> >>> submodule in their UEFI build projects with GitHub Actions), I have to
> >>> vote for option 2.
> >>>
> >>> An example of the current issue can be shown on a project that simply
> >>> attempts to build the UEFI Shell from the latest stable EDK2 release,
> >>> using EDK2 as a submodule, can be shown at
> >>> https://github.com/pbatard/UEFI-
> >> Shell/actions/runs/9290685065/job/25567879807
> >>> or
> >>> https://github.com/pbatard/UEFI-
> >> Shell/actions/runs/9290988138/job/25568511355
> >>> and as you can see, it makes building the project completely impossible
> >>> unless you ditch using EDK2 as a submodule (which isn't a viable option
> >>> IMO, because a build toolchain that cannot be used as a git submodule is
> >>> a very limiting toolchain).
> >>>
> >>> For information, there's only so much fine grained tuning GitHub Actions
> >>> offers on submodules, and no matter how you try to play with the fetch
> >>> depth, the fact that one of the libspdm sub-dependency has essentially
> >>> become M.I.A. is something that should be addressed as a matter of
> urgency.
> >>>
> >>> So I hope that a commit that updates libspdm to the new cmocka submodule
> >>> can find its way into EDK2 fairly soon, as it is currently halting a
> >>> projects that aims at producing trusted UEFI Shell releases.
> >>>
> >>> Regards,
> >>>
> >>> /Pete



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119371): https://edk2.groups.io/g/devel/message/119371
Mute This Topic: https://groups.io/mt/106250971/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

We could, but that would require manually syncing CODEOWNERS
with Maintainer.txt until that part of the process is automated.

We also need a way to verify that CODEOWNERS and Maintainers.txt
produce the exact same assignments.

This was on the list of future enhancements when resources are
available to help.  We need to focus on a process that works 
until those automations can be deployed and supported.

Mike

> -Original Message-
> From: Michael Kubacki 
> Sent: Wednesday, May 29, 2024 12:25 PM
> To: devel@edk2.groups.io; Kinney, Michael D ;
> Rebecca Cran ; kra...@redhat.com; Kubacki, Michael
> 
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> Mike,
> 
> I agree that automatically adding reviewers would be helpful.
> 
> Do you think we could add a CODEOWNERS file now to assist with this?
> 
> Benefits being:
> 
> 1. CODEOWNERS is low overhead in that GitHub already supports it.
> 
> 2. We do not need to require CODEOWNER enforcement yet. We can simply
> use it for automating the process of adding maintainers.
> 
> 3. Maintainers have write access so they are required to approve and add
> the push label. This would add a relevant maintainer(s) with write
> access to fulfill that role.
> 
> Thanks,
> Michael
> 
> On 5/29/2024 2:27 PM, Michael D Kinney wrote:
> > GitHub has notification settings.  Maintainers should configure
> > GitHub so they are notified of all PR submissions to edk2 repo.
> >
> > The Wiki for the Maintainer Process provides a link to this page with the
> details:
> >
> > https://docs.github.com/en/account-and-profile/managing-subscriptions-and-
> notifications-on-github/setting-up-notifications/configuring-notifications
> >
> > https://docs.github.com/en/account-and-profile/managing-subscriptions-and-
> notifications-on-github/setting-up-notifications/configuring-
> notifications#about-custom-notifications
> >
> > This allows Maintainers to receive notifications without being an
> > assigned reviewer.
> >
> > Mike
> >
> >> -Original Message-
> >> From: Rebecca Cran 
> >> Sent: Wednesday, May 29, 2024 11:19 AM
> >> To: devel@edk2.groups.io; Kinney, Michael D ;
> >> kra...@redhat.com; Kubacki, Michael 
> >> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> >>
> >> On 5/29/2024 12:09 PM, Michael D Kinney via groups.io wrote:
> >>> Hi Gerd,
> >>>
> >>> We can clarify the Wiki.  A Maintainer has to be involved in every
> >>> code review.  The first action a Maintainer does is verify that the
> >>> code change should be considered at all or rejected.  Then add
> >>> maintainers for the ones that look like good submissions.
> >>>
> >>> I agree that this may add a bit of delay.  You are welcome to add
> >>> a comment with @ tags to the maintainers and reviewers so
> >>> they know to look at it and do the assignments.  If you like that
> >>> idea we can add that to the Wiki as well.
> >>>
> >>> Since PRs can be also opened by outside contributors that have
> >>> limited access, maintainers have to be involved in reviewing newly
> >>> submitted PRs.
> >>
> >> "Then add maintainers for the ones that look like good submissions."
> >>
> >> Surely in order for the maintainers to know the PR should be looked at
> >> in the first place they need to already be added?
> >>
> >> --
> >>
> >> Rebecca Cran
> >
> >
> >
> > 
> >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119365): https://edk2.groups.io/g/devel/message/119365
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] libspdm Breaking Builds

[Michael D Kinney]

Hi Pete,

I just tested this config command and it works when cryptomilk is down.

git config --global 
url."https://github.com/tianocore/edk2-cmocka.git".insteadOf 
"https://git.cryptomilk.org/projects/cmocka.git;

I updated edk2-cmocka mirror last week.

I tested this with

git clone https://github.com/tianocore/edk2 --recursive

Best regards,

Mike

> -Original Message-
> From: Kinney, Michael D 
> Sent: Wednesday, May 29, 2024 11:33 AM
> To: Pete Batard ; devel@edk2.groups.io; Yao, Jiewen
> ; mikub...@linux.microsoft.com
> Cc: Kinney, Michael D 
> Subject: RE: [edk2-devel] libspdm Breaking Builds
> 
> Hi Pete,
> 
> There is another option for developers and CI agents.
> 
> Git supports a URL insteadof option to redirect git requests.
> 
> https://git-scm.com/docs/git-config#Documentation/git-config.txt-
> urlltbasegtinsteadOf
> 
> We can use this to redirect a request from cryptomilk cmocka to the
> TianoCore mirror of cryptomilk cmocka.
> 
> For developers, this can be a global config setting so it works
> for all edk2 trees on their system.
> 
> For a CI agent, this could be ab early step in all CI jobs to perform
> a git config action.  Perhaps a feature Stuart could adopt to support
> URL redirects.
> 
> Mike
> 
> 
> > -Original Message-
> > From: Pete Batard 
> > Sent: Wednesday, May 29, 2024 11:18 AM
> > To: devel@edk2.groups.io; Yao, Jiewen ; Kinney,
> Michael
> > D ; mikub...@linux.microsoft.com
> > Subject: Re: [edk2-devel] libspdm Breaking Builds
> >
> > Hello all,
> >
> > On 2024.05.24 03:13, Yao, Jiewen via groups.io wrote:
> > > Please let us know if the preference for libspdm submodule. (Below
> options)
> > > 1) Keep current libspdm official 3.3.0 release, and update to next
> release
> > at the beginning of July.
> > > 2) Update libspdm immediately with the new cmocka submodule, which is NOT
> > an official release.
> >
> > Considering that I (and I expect anybody who tries to use EDK2 as a
> > submodule in their UEFI build projects with GitHub Actions), I have to
> > vote for option 2.
> >
> > An example of the current issue can be shown on a project that simply
> > attempts to build the UEFI Shell from the latest stable EDK2 release,
> > using EDK2 as a submodule, can be shown at
> > https://github.com/pbatard/UEFI-
> Shell/actions/runs/9290685065/job/25567879807
> > or
> > https://github.com/pbatard/UEFI-
> Shell/actions/runs/9290988138/job/25568511355
> > and as you can see, it makes building the project completely impossible
> > unless you ditch using EDK2 as a submodule (which isn't a viable option
> > IMO, because a build toolchain that cannot be used as a git submodule is
> > a very limiting toolchain).
> >
> > For information, there's only so much fine grained tuning GitHub Actions
> > offers on submodules, and no matter how you try to play with the fetch
> > depth, the fact that one of the libspdm sub-dependency has essentially
> > become M.I.A. is something that should be addressed as a matter of urgency.
> >
> > So I hope that a commit that updates libspdm to the new cmocka submodule
> > can find its way into EDK2 fairly soon, as it is currently halting a
> > projects that aims at producing trusted UEFI Shell releases.
> >
> > Regards,
> >
> > /Pete


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119363): https://edk2.groups.io/g/devel/message/119363
Mute This Topic: https://groups.io/mt/106250971/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] libspdm Breaking Builds

[Michael D Kinney]

Hi Pete,

There is another option for developers and CI agents.

Git supports a URL insteadof option to redirect git requests.


https://git-scm.com/docs/git-config#Documentation/git-config.txt-urlltbasegtinsteadOf

We can use this to redirect a request from cryptomilk cmocka to the 
TianoCore mirror of cryptomilk cmocka.

For developers, this can be a global config setting so it works 
for all edk2 trees on their system.

For a CI agent, this could be ab early step in all CI jobs to perform
a git config action.  Perhaps a feature Stuart could adopt to support
URL redirects.

Mike


> -Original Message-
> From: Pete Batard 
> Sent: Wednesday, May 29, 2024 11:18 AM
> To: devel@edk2.groups.io; Yao, Jiewen ; Kinney, Michael
> D ; mikub...@linux.microsoft.com
> Subject: Re: [edk2-devel] libspdm Breaking Builds
> 
> Hello all,
> 
> On 2024.05.24 03:13, Yao, Jiewen via groups.io wrote:
> > Please let us know if the preference for libspdm submodule. (Below options)
> > 1) Keep current libspdm official 3.3.0 release, and update to next release
> at the beginning of July.
> > 2) Update libspdm immediately with the new cmocka submodule, which is NOT
> an official release.
> 
> Considering that I (and I expect anybody who tries to use EDK2 as a
> submodule in their UEFI build projects with GitHub Actions), I have to
> vote for option 2.
> 
> An example of the current issue can be shown on a project that simply
> attempts to build the UEFI Shell from the latest stable EDK2 release,
> using EDK2 as a submodule, can be shown at
> https://github.com/pbatard/UEFI-Shell/actions/runs/9290685065/job/25567879807
> or
> https://github.com/pbatard/UEFI-Shell/actions/runs/9290988138/job/25568511355
> and as you can see, it makes building the project completely impossible
> unless you ditch using EDK2 as a submodule (which isn't a viable option
> IMO, because a build toolchain that cannot be used as a git submodule is
> a very limiting toolchain).
> 
> For information, there's only so much fine grained tuning GitHub Actions
> offers on submodules, and no matter how you try to play with the fetch
> depth, the fact that one of the libspdm sub-dependency has essentially
> become M.I.A. is something that should be addressed as a matter of urgency.
> 
> So I hope that a commit that updates libspdm to the new cmocka submodule
> can find its way into EDK2 fairly soon, as it is currently halting a
> projects that aims at producing trusted UEFI Shell releases.
> 
> Regards,
> 
> /Pete


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119361): https://edk2.groups.io/g/devel/message/119361
Mute This Topic: https://groups.io/mt/106250971/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

GitHub has notification settings.  Maintainers should configure
GitHub so they are notified of all PR submissions to edk2 repo.

The Wiki for the Maintainer Process provides a link to this page with the 
details:

https://docs.github.com/en/account-and-profile/managing-subscriptions-and-notifications-on-github/setting-up-notifications/configuring-notifications

https://docs.github.com/en/account-and-profile/managing-subscriptions-and-notifications-on-github/setting-up-notifications/configuring-notifications#about-custom-notifications

This allows Maintainers to receive notifications without being an
assigned reviewer.

Mike

> -Original Message-
> From: Rebecca Cran 
> Sent: Wednesday, May 29, 2024 11:19 AM
> To: devel@edk2.groups.io; Kinney, Michael D ;
> kra...@redhat.com; Kubacki, Michael 
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> On 5/29/2024 12:09 PM, Michael D Kinney via groups.io wrote:
> > Hi Gerd,
> >
> > We can clarify the Wiki.  A Maintainer has to be involved in every
> > code review.  The first action a Maintainer does is verify that the
> > code change should be considered at all or rejected.  Then add
> > maintainers for the ones that look like good submissions.
> >
> > I agree that this may add a bit of delay.  You are welcome to add
> > a comment with @ tags to the maintainers and reviewers so
> > they know to look at it and do the assignments.  If you like that
> > idea we can add that to the Wiki as well.
> >
> > Since PRs can be also opened by outside contributors that have
> > limited access, maintainers have to be involved in reviewing newly
> > submitted PRs.
> 
> "Then add maintainers for the ones that look like good submissions."
> 
> Surely in order for the maintainers to know the PR should be looked at
> in the first place they need to already be added?
> 
> --
> 
> Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119360): https://edk2.groups.io/g/devel/message/119360
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

Hi Gerd,

We can clarify the Wiki.  A Maintainer has to be involved in every
code review.  The first action a Maintainer does is verify that the
code change should be considered at all or rejected.  Then add 
maintainers for the ones that look like good submissions.

I agree that this may add a bit of delay.  You are welcome to add
a comment with @ tags to the maintainers and reviewers so
they know to look at it and do the assignments.  If you like that
idea we can add that to the Wiki as well.

Since PRs can be also opened by outside contributors that have 
limited access, maintainers have to be involved in reviewing newly
submitted PRs.

Mike

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Gerd Hoffmann
> Sent: Wednesday, May 29, 2024 9:38 AM
> To: devel@edk2.groups.io; Kinney, Michael D 
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> On Wed, May 29, 2024 at 03:00:13PM GMT, Michael D Kinney wrote:
> > Hi Gerd,
> >
> > You are in the EDK II Reviewers team.
> >
> > The current settings only allow members of the EDK II Maintainers
> > team to assign reviewers.
> 
> That contradicts the wiki instructions which say I should assign
> reviewers myself.  And I think it makes sense to allow that for my
> own PRs, at least as long as there is no automatic process which
> consults Maintainers.txt and auto-assigns reviewers.
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119357): https://edk2.groups.io/g/devel/message/119357
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

Hi Gerd,

You are in the EDK II Reviewers team.

The current settings only allow members of the EDK II Maintainers 
team to assign reviewers.

The maintainers of the OvmfPkg are required to add all reviewers to the PR.

I have added niruiyu,ajfish to keep this PR moving while we continue
the process discussion. 

Best regards,

Mike

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Gerd Hoffmann
> Sent: Tuesday, May 28, 2024 11:39 PM
> To: devel@edk2.groups.io; Kinney, Michael D 
> Subject: Re: [edk2-devel] GitHub PR Code Review process now active
> 
> > The GitHub PR code review process is now active.  Please
> > use the new PR based code review process for all new
> > submissions starting today.
> >
> > * The Wiki has been updated with the process changes.
> >
> >   https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-
> Process
> >
> >   Big thanks to Michael Kubacki for writing up all the
> >   changes based on the RFC proposal and community discussions.
> >
> >   We will learn by using, so if you see anything missing or
> >   incorrect or clarifications needed, please send feedback
> >   here so the Wiki pages can be updated quickly for everyone.
> 
> $ gh pr edit kraxel:devel/emu-buildfix --add-reviewer niruiyu,ajfish
> GraphQL: kraxel does not have the correct permissions to execute
> `RequestReviews` (requestReviews)
> 
> Looks like the permissions need some tweaks ...
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119353): https://edk2.groups.io/g/devel/message/119353
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

Hi Abner,

Yes.  The plan is to apply to all repos.

We want to use it on edk2 for a while to make sure we get the
settings and process correct, then we will expand.

Mike

> -Original Message-
> From: Chang, Abner 
> Sent: Wednesday, May 29, 2024 3:41 AM
> To: devel@edk2.groups.io; Kinney, Michael D 
> Subject: RE: GitHub PR Code Review process now active
> 
> [AMD Official Use Only - AMD Internal Distribution Only]
> 
> Hi Mike,
> Wondering if we also plan to apply GitHub PR process on edk2-platforms repo?
> Or other repos under tianocore? I found there is another email thread "Enable
> GitHub PR, protected branches, and 'push' label" on edk2-platforms, but no
> further discussions then.
> 
> Thanks
> Abner
> 
> > -Original Message-
> > From: devel@edk2.groups.io  On Behalf Of Michael D
> > Kinney via groups.io
> > Sent: Wednesday, May 29, 2024 2:54 AM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D 
> > Subject: [edk2-devel] GitHub PR Code Review process now active
> >
> > Caution: This message originated from an External Source. Use proper
> caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > Hello,
> >
> > The GitHub PR code review process is now active.  Please
> > use the new PR based code review process for all new
> > submissions starting today.
> >
> > * The Wiki has been updated with the process changes.
> >
> >   https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-
> > Development-Process
> >
> >   Big thanks to Michael Kubacki for writing up all the
> >   changes based on the RFC proposal and community discussions.
> >
> >   We will learn by using, so if you see anything missing or
> >   incorrect or clarifications needed, please send feedback
> >   here so the Wiki pages can be updated quickly for everyone.
> >
> > * The edk2 repo settings have been updated to require
> >   a GitHub PR code review approval before merging and
> >   all conversations must be resolved before merging.
> >
> > * A PR has been opened that removes the requirement for
> >   Cc: tags in the commit messages and is the first PR
> >   that will use the new process. This PR needs to be
> >   reviewed and merged to support the revised commit
> >   message format.
> >
> >   https://github.com/tianocore/edk2/pull/5688
> >
> >   https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-
> > Format
> >
> > * Please use "Draft" PRs to run CI without any reviews.
> >   Once ready for reviews, convert from "Draft" to
> >   "Ready for Review".
> >
> > * For active code reviews that are almost complete and will
> >   be ready for merge in the next few days, the submitter may
> >   choose to either complete using the email review process,
> >   or switch to the PR based code review process.
> >
> > * For active code reviews that are expected to take more than
> >   a few days to complete, please convert to a PR based code review.
> >
> > Thanks,
> >
> > Mike
> >
> >
> >
> > 
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119351): https://edk2.groups.io/g/devel/message/119351
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] GitHub PR Code Review process now active

[Michael D Kinney]

Hello,

The GitHub PR code review process is now active.  Please 
use the new PR based code review process for all new 
submissions starting today.

* The Wiki has been updated with the process changes.

  
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

  Big thanks to Michael Kubacki for writing up all the 
  changes based on the RFC proposal and community discussions.

  We will learn by using, so if you see anything missing or 
  incorrect or clarifications needed, please send feedback 
  here so the Wiki pages can be updated quickly for everyone.

* The edk2 repo settings have been updated to require
  a GitHub PR code review approval before merging and
  all conversations must be resolved before merging.

* A PR has been opened that removes the requirement for 
  Cc: tags in the commit messages and is the first PR 
  that will use the new process. This PR needs to be 
  reviewed and merged to support the revised commit 
  message format.

  https://github.com/tianocore/edk2/pull/5688

  https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

* Please use "Draft" PRs to run CI without any reviews.
  Once ready for reviews, convert from "Draft" to 
  "Ready for Review".

* For active code reviews that are almost complete and will
  be ready for merge in the next few days, the submitter may
  choose to either complete using the email review process,
  or switch to the PR based code review process.

* For active code reviews that are expected to take more than
  a few days to complete, please convert to a PR based code review.

Thanks,

Mike



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119311): https://edk2.groups.io/g/devel/message/119311
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] PR Process Wiki Updates

[Michael D Kinney]

Hi Michael,

Reviewed-by: Michael D Kinney 

Mike

> -Original Message-
> From: Kinney, Michael D 
> Sent: Thursday, May 23, 2024 1:55 PM
> To: Michael Kubacki ; devel@edk2.groups.io;
> r...@edk2.groups.io
> Cc: quic_llind...@quicinc.com; af...@apple.com; Kinney, Michael D
> 
> Subject: RE: PR Process Wiki Updates
> 
> Hi Michael,
> 
> These updates look good.
> 
> Can you provide a brief overview/summary of the process changes
> in email to make sure there are no misunderstandings from the
> details in the wiki page updates.
> 
> Thanks,
> 
> Mike
> 
> > -Original Message-
> > From: Michael Kubacki 
> > Sent: Monday, May 20, 2024 6:32 PM
> > To: devel@edk2.groups.io; r...@edk2.groups.io
> > Cc: Kinney, Michael D ;
> > quic_llind...@quicinc.com; af...@apple.com
> > Subject: PR Process Wiki Updates
> >
> > In preparation for the transition to a pull request (PR) contribution
> > process, I've updated the TianoCore wiki.
> >
> > - Current official TianoCore wiki:
> > https://github.com/tianocore/tianocore.github.io/wiki/
> >
> > - My fork with proposed changes:
> > https://github.com/makubacki/tianocore.github.io/wiki
> >
> > - A PR that shows a diff of the changes:
> > https://github.com/makubacki/tianocore.github.io/pull/2
> >
> > This was presented in the TianoCore Tools & CI meeting today. I captured
> > feedback from the meeting as PR comments. The actionable items currently
> > there will be completed by Thursday, 5/23 this week.
> >
> > Please feel free to let me know if you have any feedback.
> >
> > Thanks,
> > Michael


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119310): https://edk2.groups.io/g/devel/message/119310
Mute This Topic: https://groups.io/mt/106216419/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] PR Process Wiki Updates

[Michael D Kinney]

Hi Michael,

These updates look good.

Can you provide a brief overview/summary of the process changes 
in email to make sure there are no misunderstandings from the
details in the wiki page updates.

Thanks,

Mike

> -Original Message-
> From: Michael Kubacki 
> Sent: Monday, May 20, 2024 6:32 PM
> To: devel@edk2.groups.io; r...@edk2.groups.io
> Cc: Kinney, Michael D ;
> quic_llind...@quicinc.com; af...@apple.com
> Subject: PR Process Wiki Updates
> 
> In preparation for the transition to a pull request (PR) contribution
> process, I've updated the TianoCore wiki.
> 
> - Current official TianoCore wiki:
> https://github.com/tianocore/tianocore.github.io/wiki/
> 
> - My fork with proposed changes:
> https://github.com/makubacki/tianocore.github.io/wiki
> 
> - A PR that shows a diff of the changes:
> https://github.com/makubacki/tianocore.github.io/pull/2
> 
> This was presented in the TianoCore Tools & CI meeting today. I captured
> feedback from the meeting as PR comments. The actionable items currently
> there will be completed by Thursday, 5/23 this week.
> 
> Please feel free to let me know if you have any feedback.
> 
> Thanks,
> Michael


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119167): https://edk2.groups.io/g/devel/message/119167
Mute This Topic: https://groups.io/mt/106216419/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH 3/3] edk2-platform/Maintainer: Add entries for AMD packages

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: abner.ch...@amd.com 
> Sent: Wednesday, May 22, 2024 9:12 PM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm ; Kinney, Michael D
> 
> Subject: [edk2-platforms][PATCH 3/3] edk2-platform/Maintainer: Add entries
> for AMD packages
> 
> From: Abner Chang 
> 
> Signed-off-by: Abner Chang 
> Cc: Leif Lindholm 
> Cc: Michael D Kinney 
> ---
>  Maintainers.txt | 14 +-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 877620a1b0..af688c3813 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -86,8 +86,20 @@ M: Leif Lindholm 
>  AMD
>  F: Platform/AMD
>  M: Abner Chang 
> -M: Abdul Lateef Attar 
> +M: Abdul Lateef Attar 
> +M: Paul Grimes 
> +
> +F: Platform/AMD/AgesaModulePkg
> +F: Platform/AMD/AgesaPkg
> +F: Platform/AMD/AmdCbsPkg
> +M: Paul Grimes 
> +R: Abdul Lateef Attar 
> +R: Abner Chang 
> +
> +F: Platform/AMD/AmdCpmPkg
> +M: Abdul Lateef Attar 
>  R: Paul Grimes 
> +R: Abner Chang 
> 
>  AMD Seattle
>  F: Platform/AMD/OverdriveBoard/
> --
> 2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119166): https://edk2.groups.io/g/devel/message/119166
Mute This Topic: https://groups.io/mt/106257081/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] libspdm Breaking Builds

[Michael D Kinney]

We have a mirror of cmocka in tianocore.

https://github.com/tianocore/edk2-cmocka

It is out of sync because GitHub keep disabling the workflow.

And the workflow can not run until cmocka repo is back up.

We updated UnitTestFrameworkPkg to use tianocore cmocka mirror long ago
for this exact failure case.

Since we do not have control over libspdm submodule link to cmocka, what
we need is an override or a failover submodule link to tianocore mirror.

Any ideas on how to implement that concept.  Does git have failover or 
override URL for git submodules?

Or do we need more stuart feature to have more fine grain control over 
Submodules?

Mike

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Michael
> Kubacki
> Sent: Wednesday, May 22, 2024 6:04 PM
> To: Kinney, Michael D ; devel@edk2.groups.io;
> Yao, Jiewen 
> Subject: Re: [edk2-devel] libspdm Breaking Builds
> 
> We looked at Stuart and it can prevent a recursive submodule update at
> the first level but then it would prevent further updates. Here Repo A
> can prevent a recursive update in edk2 but it would then not be able to
> get libspdm.
> 
>[Repo A] -[1]> [edk2] -[2]> [libspdm] -[3]> [cmocka]
> 
> At its root, the issue is that this is broken, not wasteful. Therefore,
> it is disruptive and a regression for existing workflows.
> 
> We, and I'm sure many other projects, recursively clone packages in edk2
> with submodules. For years, this has been fine except for a few brief
> exceptions. We pulled the change with the libspdm dependency into our
> codebase 8 days ago and this has been broken all day. The track record
> of cryptomilk.org in the past was also very poor and frequently caused
> problems. There is not an incident response team that I'm aware of at
> cryptomilk.org that provides status updates and proactively addresses
> services issues (i.e. https://www.githubstatus.com/).
> 
> Also, libspdm is now a dependency and cloning cmocka there may fail.
> Users should expect that they can clone and work in that repo as part of
> their firmware development process without frequent service disruptions
> in the way.
> 
> While I started this thread to raise the issue for users impacted here,
> I filed https://github.com/DMTF/libspdm/issues/2707 to track the request
> in the libspdm repo.
> 
> Thanks,
> Michael
> 
> On 5/22/2024 6:24 PM, Kinney, Michael D wrote:
> > Libspdm also depends on openssl.  We did not want to clone openssl twice.
> >
> > I though stuart config specifies which submodules to clone.  Can’t we skip
> > all the submodules within libspdm to fix CI?
> >
> > Can't devs choose to not use --recursive?
> >
> > Mike
> >
> >> -Original Message-
> >> From: Michael Kubacki 
> >> Sent: Wednesday, May 22, 2024 3:16 PM
> >> To: devel@edk2.groups.io; Kinney, Michael D ;
> >> Yao, Jiewen 
> >> Subject: Re: [edk2-devel] libspdm Breaking Builds
> >>
> >> I don't think that's a very good solution given the diversity of
> >> downstream projects dependent on the repo or even for the libspdm repo
> >> itself.
> >>
> >> Thanks,
> >> Michael
> >>
> >> On 5/22/2024 5:57 PM, Michael D Kinney wrote:
> >>> This was discussed and the decision was made to no use recursive clone on
> >> libspdm.
> >>>
> >>> Mike
> >>>
> >>>> -Original Message-
> >>>> From: Michael Kubacki 
> >>>> Sent: Wednesday, May 22, 2024 1:40 PM
> >>>> To: devel@edk2.groups.io; Yao, Jiewen 
> >>>> Cc: Kinney, Michael D 
> >>>> Subject: libspdm Breaking Builds
> >>>>
> >>>> Recently, the libspdm submodule was added to SecurityPkg
> >>>> (SecurityPkg/DeviceSecurity/SpdmLib/libspdm) [1].
> >>>>
> >>>> That submodule points to https://github.com/DMTF/libspdm.git.
> >>>>
> >>>> The libspdm repo contains a submodule for cmocka that is hosted on
> >>>> cryptomilk.org [2].
> >>>>
> >>>> Cloning that submodule is failing today, breaking all builds/CI
> >>>> dependent on SecurityPkg.
> >>>>
> >>>> This has been an issue in the past and it is very disruptive given the
> >>>> number of dependencies on edk2/SecurityPkg. Because of its reliability
> >>>> issues, edk2 moved to a version of the repo hosted in tianocore [3] in
> >>>> 2021 [4]
> >>>>
> >>>> Can you please make a similar change in libspdm and we get edk2 up

Re: [edk2-devel] libspdm Breaking Builds

[Michael D Kinney]

Libspdm also depends on openssl.  We did not want to clone openssl twice.

I though stuart config specifies which submodules to clone.  Can’t we skip
all the submodules within libspdm to fix CI?

Can't devs choose to not use --recursive?

Mike

> -Original Message-
> From: Michael Kubacki 
> Sent: Wednesday, May 22, 2024 3:16 PM
> To: devel@edk2.groups.io; Kinney, Michael D ;
> Yao, Jiewen 
> Subject: Re: [edk2-devel] libspdm Breaking Builds
> 
> I don't think that's a very good solution given the diversity of
> downstream projects dependent on the repo or even for the libspdm repo
> itself.
> 
> Thanks,
> Michael
> 
> On 5/22/2024 5:57 PM, Michael D Kinney wrote:
> > This was discussed and the decision was made to no use recursive clone on
> libspdm.
> >
> > Mike
> >
> >> -Original Message-
> >> From: Michael Kubacki 
> >> Sent: Wednesday, May 22, 2024 1:40 PM
> >> To: devel@edk2.groups.io; Yao, Jiewen 
> >> Cc: Kinney, Michael D 
> >> Subject: libspdm Breaking Builds
> >>
> >> Recently, the libspdm submodule was added to SecurityPkg
> >> (SecurityPkg/DeviceSecurity/SpdmLib/libspdm) [1].
> >>
> >> That submodule points to https://github.com/DMTF/libspdm.git.
> >>
> >> The libspdm repo contains a submodule for cmocka that is hosted on
> >> cryptomilk.org [2].
> >>
> >> Cloning that submodule is failing today, breaking all builds/CI
> >> dependent on SecurityPkg.
> >>
> >> This has been an issue in the past and it is very disruptive given the
> >> number of dependencies on edk2/SecurityPkg. Because of its reliability
> >> issues, edk2 moved to a version of the repo hosted in tianocore [3] in
> >> 2021 [4]
> >>
> >> Can you please make a similar change in libspdm and we get edk2 updated
> >> as soon as possible?
> >>
> >> Thanks,
> >> Michael
> >>
> >> [1]
> >>
> https://github.com/tianocore/edk2/commit/54a4fd9b35cac79e7c54b750d30fbb43
> >> dca1
> >>
> >> [2] https://github.com/DMTF/libspdm/blob/main/.gitmodules
> >>
> >> [3] https://github.com/tianocore/edk2-cmocka
> >>
> >> [4]
> >>
> https://github.com/tianocore/edk2/commit/2ad22420a710dc07e3b644f91a5b55c09c39
> >> ecf3
> >
> >
> > 
> >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119121): https://edk2.groups.io/g/devel/message/119121
Mute This Topic: https://groups.io/mt/106250971/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] libspdm Breaking Builds

[Michael D Kinney]

This was discussed and the decision was made to no use recursive clone on 
libspdm.

Mike

> -Original Message-
> From: Michael Kubacki 
> Sent: Wednesday, May 22, 2024 1:40 PM
> To: devel@edk2.groups.io; Yao, Jiewen 
> Cc: Kinney, Michael D 
> Subject: libspdm Breaking Builds
> 
> Recently, the libspdm submodule was added to SecurityPkg
> (SecurityPkg/DeviceSecurity/SpdmLib/libspdm) [1].
> 
> That submodule points to https://github.com/DMTF/libspdm.git.
> 
> The libspdm repo contains a submodule for cmocka that is hosted on
> cryptomilk.org [2].
> 
> Cloning that submodule is failing today, breaking all builds/CI
> dependent on SecurityPkg.
> 
> This has been an issue in the past and it is very disruptive given the
> number of dependencies on edk2/SecurityPkg. Because of its reliability
> issues, edk2 moved to a version of the repo hosted in tianocore [3] in
> 2021 [4]
> 
> Can you please make a similar change in libspdm and we get edk2 updated
> as soon as possible?
> 
> Thanks,
> Michael
> 
> [1]
> https://github.com/tianocore/edk2/commit/54a4fd9b35cac79e7c54b750d30fbb43
> dca1
> 
> [2] https://github.com/DMTF/libspdm/blob/main/.gitmodules
> 
> [3] https://github.com/tianocore/edk2-cmocka
> 
> [4]
> https://github.com/tianocore/edk2/commit/2ad22420a710dc07e3b644f91a5b55c09c39
> ecf3


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119119): https://edk2.groups.io/g/devel/message/119119
Mute This Topic: https://groups.io/mt/106250971/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

[Michael D Kinney]

Merged.  https://github.com/tianocore/edk2/pull/5667


Mike

> -Original Message-
> From: Michael Kubacki 
> Sent: Monday, May 20, 2024 6:41 PM
> To: Kinney, Michael D ; devel@edk2.groups.io;
> Andrew Fish ; Leif Lindholm ;
> Liming Gao 
> Cc: Feng, Bob C ; Joey Vagedes
> ; Rebecca Cran ; Sean Brogan
> ; Chen, Christine 
> Subject: Re: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3
> 
> Just wanted to send a reminder that I recommend
> https://github.com/tianocore/edk2/pull/5667 be merged to unblock CI for
> those that are currently trying to test changes.
> 
> Thanks,
> Michael
> 
> On 5/17/2024 8:10 PM, Kinney, Michael D wrote:
> > Approved. I agree there is no impact to FW.
> >
> > Mike
> >
> >> -Original Message-
> >> From: Michael Kubacki 
> >> Sent: Friday, May 17, 2024 4:28 PM
> >> To: Kinney, Michael D ; devel@edk2.groups.io;
> >> Andrew Fish ; Leif Lindholm ;
> >> Liming Gao 
> >> Cc: Feng, Bob C ; Joey Vagedes
> >> ; Rebecca Cran ; Sean Brogan
> >> ; Chen, Christine 
> >> Subject: Re: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3
> >>
> >> Forgot about the hard freeze.
> >>
> >> Added remaining stewards to consider merging this. It has no impact on
> >> firmware but is needed to unblock an immediate issue in CI where the
> >> CodeQL queries being fetched are newer and incompatible with the CodeQL
> >> CLI being used.
> >>
> >> As I mentioned in the release notes, I will follow up in the future for
> >> a change that should be able to lock the CodeQL query versions against
> >> the CLI version.
> >>
> >> Thanks,
> >> Michael
> >>
> >> On 5/17/2024 7:20 PM, Michael Kubacki wrote:
> >>> To ensure CI is unblocked, I am going to add the push tag now.
> >>>
> >>> On 5/17/2024 6:31 PM, Michael Kubacki wrote:
> >>>> Thanks Mike. Are you okay with me completing the PR now?
> >>>>
> >>>> On 5/17/2024 5:31 PM, Kinney, Michael D wrote:
> >>>>> Reviewed-by: Michael D Kinney 
> >>>>>
> >>>>>> -Original Message-
> >>>>>> From: mikub...@linux.microsoft.com 
> >>>>>> Sent: Friday, May 17, 2024 2:09 PM
> >>>>>> To: devel@edk2.groups.io
> >>>>>> Cc: Feng, Bob C ; Joey Vagedes
> >>>>>> ; Liming Gao ;
> >>>>>> Kinney,
> >>>>>> Michael D ; Rebecca Cran
> >>>>>> ;
> >>>>>> Sean Brogan ; Chen, Christine
> >>>>>> 
> >>>>>> Subject: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3
> >>>>>>
> >>>>>> From: Michael Kubacki 
> >>>>>>
> >>>>>> This fixes an issue where the CodeQL queries currently fetched in the
> >>>>>> pipeline are incompatible with the current executable used.
> >>>>>>
> >>>>>> Update to pick up functional and security fixes. See the following
> >>>>>> comparison for detailed differences:
> >>>>>>
> >>>>>> https://github.com/github/codeql-cli-
> binaries/compare/v2.16.1...v2.17.3
> >>>>>>
> >>>>>> Cc: Bob Feng 
> >>>>>> Cc: Joey Vagedes 
> >>>>>> Cc: Liming Gao 
> >>>>>> Cc: Michael D Kinney 
> >>>>>> Cc: Rebecca Cran 
> >>>>>> Cc: Sean Brogan 
> >>>>>> Cc: Yuwei Chen 
> >>>>>> Signed-off-by: Michael Kubacki 
> >>>>>> ---
> >>>>>>
> >>>>>> Notes:
> >>>>>>   This change fixes an immediate compatibility issue between
> >>>>>>   the latest queries being pulled and the CodeQL CLI being
> >>>>>>   used.
> >>>>>>
> >>>>>>   A follow up change will attempt to lock queries against a
> >>>>>>   compatibile version to prevent queries from pulling ahead
> >>>>>>   to incompatible versions in the future.
> >>>>>>
> >>>>>>   ---
> >>>>>>
> >>>>>>   This change was tested in edk2 CI:
> >>>>>>
> >>>>>>   https://github.com/tianocore/edk2/pull/56

Re: [edk2-devel] [PATCH] MdePkg:Update UEFI version to 2.10

[Michael D Kinney]

Have you verified that every feature from 2.10 is in edk2?

That includes both the include file content as well as all the 
Library/module implementations.

A platform can always update this version value in their tables
if the platform is using a subset of features that are all 2.10
conformant.

Thanks,

Mike

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Li, Walon
> Sent: Sunday, May 19, 2024 7:49 PM
> To: devel@edk2.groups.io
> Cc: Lin2, Derek ; Li, Walon ;
> gaolim...@byosoft.com.cn
> Subject: [edk2-devel] [PATCH] MdePkg:Update UEFI version to 2.10
> 
> Follow UEFI specification 2.10 to update system table revision.
> ---
>  MdePkg/Include/Uefi/UefiSpec.h | 8 +---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.h
> index 79fc8c72ca..5cabb196b7 100644
> --- a/MdePkg/Include/Uefi/UefiSpec.h
> +++ b/MdePkg/Include/Uefi/UefiSpec.h
> @@ -1,8 +1,8 @@
>  /** @file
> 
>Include file that supports UEFI.
> 
> 
> 
> -  This include file must contain things defined in the UEFI 2.7
> specification.
> 
> -  If a code construct is defined in the UEFI 2.7 specification it must be
> included
> 
> +  This include file must contain things defined in the UEFI 2.10
> specification.
> 
> +  If a code construct is defined in the UEFI 2.10 specification it must be
> included
> 
>by this include file.
> 
> 
> 
>  Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
> 
> @@ -1840,6 +1840,8 @@ EFI_STATUS
>  // EFI Runtime Services Table
> 
>  //
> 
>  #define EFI_SYSTEM_TABLE_SIGNATURE  SIGNATURE_64 ('I','B','I','
> ','S','Y','S','T')
> 
> +#define EFI_2_100_SYSTEM_TABLE_REVISION ((2 << 16) | (100))
> 
> +#define EFI_2_90_SYSTEM_TABLE_REVISION  ((2 << 16) | (90))
> 
>  #define EFI_2_80_SYSTEM_TABLE_REVISION  ((2 << 16) | (80))
> 
>  #define EFI_2_70_SYSTEM_TABLE_REVISION  ((2 << 16) | (70))
> 
>  #define EFI_2_60_SYSTEM_TABLE_REVISION  ((2 << 16) | (60))
> 
> @@ -1852,7 +1854,7 @@ EFI_STATUS
>  #define EFI_2_00_SYSTEM_TABLE_REVISION  ((2 << 16) | (00))
> 
>  #define EFI_1_10_SYSTEM_TABLE_REVISION  ((1 << 16) | (10))
> 
>  #define EFI_1_02_SYSTEM_TABLE_REVISION  ((1 << 16) | (02))
> 
> -#define EFI_SYSTEM_TABLE_REVISION   EFI_2_70_SYSTEM_TABLE_REVISION
> 
> +#define EFI_SYSTEM_TABLE_REVISION   EFI_2_100_SYSTEM_TABLE_REVISION
> 
>  #define EFI_SPECIFICATION_VERSION   EFI_SYSTEM_TABLE_REVISION
> 
> 
> 
>  #define EFI_RUNTIME_SERVICES_SIGNATURE  SIGNATURE_64
> ('R','U','N','T','S','E','R','V')
> 
> --
> 2.23.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#119071): https://edk2.groups.io/g/devel/message/119071
> Mute This Topic: https://groups.io/mt/106197340/1643496
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [michael.d.kin...@intel.com]
> -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119084): https://edk2.groups.io/g/devel/message/119084
Mute This Topic: https://groups.io/mt/106197340/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

[Michael D Kinney]

Approved. I agree there is no impact to FW.

Mike

> -Original Message-
> From: Michael Kubacki 
> Sent: Friday, May 17, 2024 4:28 PM
> To: Kinney, Michael D ; devel@edk2.groups.io;
> Andrew Fish ; Leif Lindholm ;
> Liming Gao 
> Cc: Feng, Bob C ; Joey Vagedes
> ; Rebecca Cran ; Sean Brogan
> ; Chen, Christine 
> Subject: Re: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3
> 
> Forgot about the hard freeze.
> 
> Added remaining stewards to consider merging this. It has no impact on
> firmware but is needed to unblock an immediate issue in CI where the
> CodeQL queries being fetched are newer and incompatible with the CodeQL
> CLI being used.
> 
> As I mentioned in the release notes, I will follow up in the future for
> a change that should be able to lock the CodeQL query versions against
> the CLI version.
> 
> Thanks,
> Michael
> 
> On 5/17/2024 7:20 PM, Michael Kubacki wrote:
> > To ensure CI is unblocked, I am going to add the push tag now.
> >
> > On 5/17/2024 6:31 PM, Michael Kubacki wrote:
> >> Thanks Mike. Are you okay with me completing the PR now?
> >>
> >> On 5/17/2024 5:31 PM, Kinney, Michael D wrote:
> >>> Reviewed-by: Michael D Kinney 
> >>>
> >>>> -Original Message-
> >>>> From: mikub...@linux.microsoft.com 
> >>>> Sent: Friday, May 17, 2024 2:09 PM
> >>>> To: devel@edk2.groups.io
> >>>> Cc: Feng, Bob C ; Joey Vagedes
> >>>> ; Liming Gao ;
> >>>> Kinney,
> >>>> Michael D ; Rebecca Cran
> >>>> ;
> >>>> Sean Brogan ; Chen, Christine
> >>>> 
> >>>> Subject: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3
> >>>>
> >>>> From: Michael Kubacki 
> >>>>
> >>>> This fixes an issue where the CodeQL queries currently fetched in the
> >>>> pipeline are incompatible with the current executable used.
> >>>>
> >>>> Update to pick up functional and security fixes. See the following
> >>>> comparison for detailed differences:
> >>>>
> >>>> https://github.com/github/codeql-cli-binaries/compare/v2.16.1...v2.17.3
> >>>>
> >>>> Cc: Bob Feng 
> >>>> Cc: Joey Vagedes 
> >>>> Cc: Liming Gao 
> >>>> Cc: Michael D Kinney 
> >>>> Cc: Rebecca Cran 
> >>>> Cc: Sean Brogan 
> >>>> Cc: Yuwei Chen 
> >>>> Signed-off-by: Michael Kubacki 
> >>>> ---
> >>>>
> >>>> Notes:
> >>>>  This change fixes an immediate compatibility issue between
> >>>>  the latest queries being pulled and the CodeQL CLI being
> >>>>  used.
> >>>>
> >>>>  A follow up change will attempt to lock queries against a
> >>>>  compatibile version to prevent queries from pulling ahead
> >>>>  to incompatible versions in the future.
> >>>>
> >>>>  ---
> >>>>
> >>>>  This change was tested in edk2 CI:
> >>>>
> >>>>  https://github.com/tianocore/edk2/pull/5667
> >>>>
> >>>>   BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml | 6 +++---
> >>>>   BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml   | 6 +++---
> >>>>   BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml | 6 +++---
> >>>>   3 files changed, 9 insertions(+), 9 deletions(-)
> >>>>
> >>>> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> >>>> b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> >>>> index 5ec56c6bf06f..dbc9c2ba0290 100644
> >>>> --- a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> >>>> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> >>>> @@ -16,9 +16,9 @@
> >>>>     "scope": "codeql-ext-dep",
> >>>>     "type": "web",
> >>>>     "name": "codeql_cli",
> >>>> -  "source": "https://github.com/github/codeql-cli-
> >>>> binaries/releases/download/v2.16.1/codeql.zip",
> >>>> -  "version": "2.16.1",
> >>>> -  "sha256":
> >>>> "86a98f6ebb8fd49efadf367f3275c438669fcb8426962c33415129aad8e093e6",
> >>>> +  "source": "https://github.

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: mikub...@linux.microsoft.com 
> Sent: Friday, May 17, 2024 2:09 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Joey Vagedes
> ; Liming Gao ; Kinney,
> Michael D ; Rebecca Cran ;
> Sean Brogan ; Chen, Christine
> 
> Subject: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3
> 
> From: Michael Kubacki 
> 
> This fixes an issue where the CodeQL queries currently fetched in the
> pipeline are incompatible with the current executable used.
> 
> Update to pick up functional and security fixes. See the following
> comparison for detailed differences:
> 
> https://github.com/github/codeql-cli-binaries/compare/v2.16.1...v2.17.3
> 
> Cc: Bob Feng 
> Cc: Joey Vagedes 
> Cc: Liming Gao 
> Cc: Michael D Kinney 
> Cc: Rebecca Cran 
> Cc: Sean Brogan 
> Cc: Yuwei Chen 
> Signed-off-by: Michael Kubacki 
> ---
> 
> Notes:
> This change fixes an immediate compatibility issue between
> the latest queries being pulled and the CodeQL CLI being
> used.
> 
> A follow up change will attempt to lock queries against a
> compatibile version to prevent queries from pulling ahead
> to incompatible versions in the future.
> 
> ---
> 
> This change was tested in edk2 CI:
> 
> https://github.com/tianocore/edk2/pull/5667
> 
>  BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml | 6 +++---
>  BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml   | 6 +++---
>  BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml | 6 +++---
>  3 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> index 5ec56c6bf06f..dbc9c2ba0290 100644
> --- a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> @@ -16,9 +16,9 @@
>"scope": "codeql-ext-dep",
>"type": "web",
>"name": "codeql_cli",
> -  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.16.1/codeql.zip",
> -  "version": "2.16.1",
> -  "sha256":
> "86a98f6ebb8fd49efadf367f3275c438669fcb8426962c33415129aad8e093e6",
> +  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.17.3/codeql.zip",
> +  "version": "2.17.3",
> +  "sha256":
> "e5ac1d87ab38e405c9af5db234a338b10dffabc98a648903f1664dd2a566dfd5",
>"compression_type": "zip",
>"internal_path": "/codeql/",
>"flags": ["set_shell_var", ],
> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> index 5b4a919f1de4..536322f2b331 100644
> --- a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> @@ -14,9 +14,9 @@
>"scope": "codeql-linux-ext-dep",
>"type": "web",
>"name": "codeql_linux_cli",
> -  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.16.1/codeql-linux64.zip",
> -  "version": "2.16.1",
> -  "sha256":
> "40dbb6c0c4064bd14601a02e60c61661fdc0271469f90eb91a2e7d51d4cbc171",
> +  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.17.3/codeql-linux64.zip",
> +  "version": "2.17.3",
> +  "sha256":
> "9fba000c4b821534d354bc16821aa066fdb1304446226ea449870e64a8ad3c7a",
>"compression_type": "zip",
>"internal_path": "/codeql/",
>"flags": ["set_shell_var", ],
> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> index c0c018c9538f..93a81ffd5020 100644
> --- a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> @@ -14,9 +14,9 @@
>"scope": "codeql-windows-ext-dep",
>"type": "web",
>"name": "codeql_windows_cli",
> -  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.16.1/codeql-win64.zip",
> -  "version": "2.16.1",
> -  "sha256":
> "9ebe5ea8a7d0a77425428d50d49912319117fccee24ecb62f6219c12584f4f28",
> +  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.17.3/codeql-win64.zip",
> +  "version": "2.17.3",
> +  "sha256":
> "4c6fbf2ea2eaf0f47bf0347eacf54c6b9d6bdf7acb6b63e17f9e6f2dd83b34e7",
>"compression_type": "zip",
>"internal_path": "/codeql/",
>"flags": ["set_shell_var", ],
> --
> 2.45.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119059): https://edk2.groups.io/g/devel/message/119059
Mute This Topic: https://groups.io/mt/106161774/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

[Michael D Kinney]

> -Original Message-
> From: Brian J. Johnson 
> Sent: Friday, May 10, 2024 1:58 PM
> To: r...@edk2.groups.io; pedro.falc...@gmail.com; Kinney, Michael D
> 
> Cc: devel@edk2.groups.io; Leif Lindholm ; Andrew Fish
> (af...@apple.com) 
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review
> from email to GitHub Pull Requests on 5-24-2024
> 
> On 5/3/24 12:38, Pedro Falcato wrote:
> > On Thu, May 2, 2024 at 7:17 PM Kinney, Michael D
> >  wrote:
> >>
> >>
> >>
> >>> -Original Message-
> >>> From: r...@edk2.groups.io  On Behalf Of Pedro Falcato
> >>> Sent: Thursday, May 2, 2024 10:51 AM
> >>> To: devel@edk2.groups.io; Kinney, Michael D 
> >>> Cc: r...@edk2.groups.io; Leif Lindholm ; Andrew Fish
> >>> (af...@apple.com) 
> >>> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> >>> Review from email to GitHub Pull Requests on 5-24-2024
> >>>
> >>> On Wed, May 1, 2024 at 6:44 PM Michael D Kinney via groups.io
> >>>  wrote:
> > 
> >>>> * All contributors, maintainers, and reviewers must have GitHub IDs.
> >>>> * The commit message would no longer require Cc:, Reviewed-by:, Acked-
> >>> by:
> >>>>or Tested-by: tags.  The only required tag would be Signed-off-by.
> >>>
> >>> I'd just like to note that losing the CC:, Reviewed-by:, etc is a big
> >>> loss. Gerrit auto-adds Rb's, github PR's do not (I'd guess there's a
> >>> way to pull that off with github actions, but I haven't looked). It'll
> >>> be a mess if I have to go through online GH PR backlogs just to find
> >>> who to CC/add-to-review. It kills the decentralized bit off of git too
> >>> :)
> >>>
> >>
> >> Can you provide more details on the impact of the loss?
> >
> > In my view, commits should be fairly self-describing. What changes,
> > why, are obvious, but who looked at it, who reviewed it, who was cc'd
> > but didn't respond, who tested are also pretty important. Git is
> > supposed to be decentralized, let's not forget. If we ever migrate
> > from GH, if GH ever goes down, if the links ever go down, you'll never
> > be able to know who looked at it. If you're looking at an EDK2 commit
> > deep into an Intel-internal fork, you won't know what "PR #478" is
> > (heck, rebase-and-merge doesn't reference PRs either).
> >
> 
> Well said.  That's my concern as well:  TianoCore won't use GitHub
> forever, and any GitHub metadata (PR numbers, GitHub IDs, bug numbers,
> etc.) will become meaningless once we change.  Never mind that the code
> can be disassociated from the metadata simply by forking to a new
> repository, as Pedro said

There are github actions that can archive this information in a portable format 
such as json:

https://github.com/marketplace/actions/github-archive-action

> 
> > Side-note: How are we supposed to find the PR for a given commit?
> > Searching doesn't seem to work well. For instance, I picked a random
> > non-trivial commit out of the current open PRs:
> > MdeModulePkg/Bus/Spi/SpiBus: Adding SpiBus Drivers.
> >
> https://github.com/tianocore/edk2/pulls?q=is%3Apr+is%3Aopen+MdeModulePkg%2FBu
> s%2FSpi%2FSpiBus%3A+Adding+SpiBus+Drivers
> > has no matches?
> >
> >>
> >> I am curious how other GitHub projects handle this topic. I see it
> >
> > I don't think they do, sadly. But I also don't know many people with a
> > positive opinion on GH PRs :)
> 
> Yeah... my opinions are decidedly mixed.  They are convenient, but have
> some serious gaps around archiving, auditing, and versioning of review
> requests.  They don't even let you review the commit messages (one of
> their most serious flaws!)

Can you propose a process to provide review comments on the commit messages
within a PR conversation?  Perhaps use of keywords/tags/links to indicate the
commit being discussed?  Could copy/paste commit message being reviewed into
PR conversation and provide feedback there.

> 
> > 
> >>> It is sad that we're moving to PRs after I finally got a nice and
> >>> sane(ish!) email workflow (openfw.io + b4). Otherwise, no objections,
> >>> it's better than edk2.git's half-email half-PR frankenprocess.
> >>> I'd guess this change only encompasses edk2.git? How about the other
> >>> repos? Any timeline for those?
> >>
> >> The plan is to apply this to all repos, one at a time.  Need to get the
> >> revised process documented and working in one repo before applying to all.
> >
> > Gotcha, thanks!
> >
> 
> --
> Brian J. Johnson
> Hewlett Packard Enterprise


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118927): https://edk2.groups.io/g/devel/message/118927
Mute This Topic: https://groups.io/mt/105873467/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

[Michael D Kinney]

Hi Liming,

My responses below in [Mike].

Mike


From: gaoliming 
Sent: Friday, May 10, 2024 8:29 AM
To: devel@edk2.groups.io; Kinney, Michael D ; 
'Andrew Fish' ; 'Leif Lindholm' 
Cc: 'Ard Biesheuvel' ; sam.kay...@arm.com; 
dougfl...@microsoft.com; Mathews, John ; Hou, Wenxing 

Subject: 回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

Stewards:
  Now, there are several patches to catch this table tag. Could you give the 
comments for them?


1. Adding support for verbose UEFI Table dumping to Dmem.c 
(https://edk2.groups.io/g/devel/message/118582)

[Liming] This patch set has been reviewed before soft feature freeze. It plans 
to catch this stable tag.



[Mike] I see this PR: https://github.com/tianocore/edk2/pull/5653 that is not 
passing CI and appears it will require additional code changes



[Mike] Reject for edk2-stable202405



2.  MdePkg/BaseLib: Fix AARCH64 compilation error 
(https://edk2.groups.io/g/devel/message/118690)

[Liming] This bug fix is reviewed in soft feature freeze phase. It plans to 
catch this stable tag.

[Mike] Approved for edk2-stable202405



3.  MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount 
(https://edk2.groups.io/g/devel/message/118745)

[Liming] This security fix is reviewed in soft feature freeze phase. It plans 
to catch this stable tag.


[Mike] Approved for edk2-stable202405



4.  NetworkPkg: CVE-2023-45236 and CVE-2023-45237 
(https://edk2.groups.io/g/devel/message/118768)

[Liming] This security fix is still under code review. It plans to catch this 
stable tag.



[Mike] Is the code review complete?  Is there a link to the PR?



5.  Add more crypt APIs based on Mbedtls 
(https://edk2.groups.io/g/devel/message/118772)

[Liming] This patch set passes code review in soft feature freeze phase. It 
plans to catch this stable tag.

[Mike] This patch series uses ‘..’ in INF to access source files in another 
component.  This is not legal.  I am surprised this was not caught in code 
review.

DEFINE OPENSSL_PATH= ../OpensslLib/openssl
DEFINE BASE_CRYPT_PATH = ../BaseCryptLib

[Mike] I see a reference to some “platform integration” testing.  Given that 
this patch series implements a number of
crypto service APIs and is a large number of new lines of code, it would be 
good to know if all of the newly added APIs
were tested in a platform integration. A table of the added APIs and the 
platform integration test status would be good to
know if there was any functional testing of each API.  If there are APIs that 
are not covered by any platform integration
testing, then I would be concerned with such a large change with limited 
testing.

Thanks
Liming
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> 
mailto:devel@edk2.groups.io>> 代表 gaoliming via groups.io
发送时间: 2024年5月7日 9:25
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; 
annou...@edk2.groups.io<mailto:annou...@edk2.groups.io>
抄送: 'Michael D Kinney' 
mailto:michael.d.kin...@intel.com>>; 'Andrew Fish' 
mailto:af...@apple.com>>; 'Leif Lindholm' 
mailto:quic_llind...@quicinc.com>>
主题: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

Hi, all

  We enter into Soft Feature Freeze phase now. In this phase,
the feature under review will not be allowed to be pushed. The feature
passed review can still be merged.

  The patch review can continue without break in edk2 community. If the
patch is sent before Soft Feature Freeze, and plans to catch this stable tag, 
the
patch contributor need reply to his patch and notify edk2 community. If the
patch is sent after Soft Feature Freeze, and plans to catch this stable tag,
please add edk2-stable202405 key words in the patch title and BZ, so the
community know this patch target and give the feedback.

  To avoid the unnecessary changes to be merged in edk2 stable tag release,
all edk2 maintainers' write access will be temporarily disabled until stable
tag is released on 05-24. That means edk2 maintainer can't set push label in
pull request after soft feature freeze starts.

  If the change wants to catch this stable tag 202405, please follow above
rules, then send the merge request to 
gaolim...@byosoft.com.cn<mailto:gaolim...@byosoft.com.cn> or
michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>.

  We will help merge the code change in soft feature freeze and hard feature
freeze phase.

Below is edk2-stable202405 tag planning Proposed Schedule
Date (00:00:00 UTC-8) Description

2024-02-23 Beginning of development
2024-05-06 Soft Feature Freeze
2024-05-10 Hard Feature Freeze
2024-05-24 Release

Thanks
Liming




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118892): https://edk2.groups.io/g/devel/message/118892
Mute This Topic: https://groups.io/mt/106098146/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel][edk2-stable202405][PATCH] MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount

[Michael D Kinney]

I agree it should catch edk2-stable202405

Mike

> -Original Message-
> From: gaoliming 
> Sent: Thursday, May 9, 2024 12:24 AM
> To: devel@edk2.groups.io; Pakkirisamy, ShanmugavelX
> 
> Cc: Liu, Zhiguang ; Bi, Dandan ;
> 'Leif Lindholm' ; 'Andrew Fish' ;
> Kinney, Michael D 
> Subject: 回复: [edk2-devel][edk2-stable202405][PATCH] MdeModulePkg: Potential
> UINT32 overflow in S3 ResumeCount
> 
> Reviewed-by: Liming Gao 
> 
> This is a security fix. So, I think it should catch this stable tag 202405
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io  代表 Pakkirisamy
> > ShanmugavelX
> > 发送时间: 2024年5月6日 17:53
> > 收件人: devel@edk2.groups.io
> > 抄送: Shanmugavel Pakkirisamy ;
> > Zhiguang Liu ; Dandan Bi ;
> > Liming Gao 
> > 主题: [edk2-devel] [PATCH] MdeModulePkg: Potential UINT32 overflow in S3
> > ResumeCount
> >
> > From: Shanmugavel Pakkirisamy 
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4677
> >
> > Attacker able to modify physical memory and ResumeCount.
> > System will crash/DoS when ResumeCount reaches its MAX_UINT32.
> >
> > Cc: Zhiguang Liu 
> > Cc: Dandan Bi 
> > Cc: Liming Gao 
> >
> > Signed-off-by: Pakkirisamy ShanmugavelX
> > 
> > ---
> >
> > MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePe
> > rformancePei.c | 14 +-
> >  1 file changed, 9 insertions(+), 5 deletions(-)
> >
> > diff --git
> > a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/Firmware
> > PerformancePei.c
> > b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/Firmware
> > PerformancePei.c
> > index 2f2b2a80b2..1035ed8640 100644
> > ---
> > a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/Firmware
> > PerformancePei.c
> > +++
> > b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/Firmware
> > PerformancePei.c
> > @@ -112,11 +112,15 @@ FpdtStatusCodeListenerPei (
> >//
> >S3ResumeTotal = MultU64x32 (AcpiS3ResumeRecord->AverageResume,
> > AcpiS3ResumeRecord->ResumeCount);
> >AcpiS3ResumeRecord->ResumeCount++;
> > -  AcpiS3ResumeRecord->AverageResume = DivU64x32 (S3ResumeTotal +
> > AcpiS3ResumeRecord->FullResume, AcpiS3ResumeRecord->ResumeCount);
> > -
> > -  DEBUG ((DEBUG_INFO, "FPDT: S3 Resume Performance - ResumeCount
> > = %d\n", AcpiS3ResumeRecord->ResumeCount));
> > -  DEBUG ((DEBUG_INFO, "FPDT: S3 Resume Performance - FullResume
> > = %ld\n", AcpiS3ResumeRecord->FullResume));
> > -  DEBUG ((DEBUG_INFO, "FPDT: S3 Resume Performance - AverageResume
> > = %ld\n", AcpiS3ResumeRecord->AverageResume));
> > +  if (AcpiS3ResumeRecord->ResumeCount > 0) {
> > +AcpiS3ResumeRecord->AverageResume = DivU64x32 (S3ResumeTotal +
> > AcpiS3ResumeRecord->FullResume, AcpiS3ResumeRecord->ResumeCount);
> > +DEBUG ((DEBUG_INFO, "\nFPDT: S3 Resume Performance -
> > AverageResume = 0x%x\n", AcpiS3ResumeRecord->AverageResume));
> > +  }
> > +  else {
> > +DEBUG ((DEBUG_ERROR, "\nFPDT: S3 ResumeCount reaches the
> > MAX_UINT32 value. S3 ResumeCount record reset to Zero."));
> > +  }
> > +  DEBUG ((DEBUG_INFO, "FPDT: S3 Resume Performance - ResumeCount   =
> > 0x%x\n", AcpiS3ResumeRecord->ResumeCount));
> > +  DEBUG ((DEBUG_INFO, "FPDT: S3 Resume Performance - FullResume=
> > 0x%x\n", AcpiS3ResumeRecord->FullResume));
> >
> >//
> >// Update S3 Suspend Performance Record.
> > --
> > 2.45.0.windows.1
> >
> >
> >
> > 
> >
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118891): https://edk2.groups.io/g/devel/message/118891
Mute This Topic: https://groups.io/mt/106097838/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] MdePkg: Add MmUnblockMemoryLib to MdeLibs.dsc

[Michael D Kinney]

Reviewed-by: Michael D Kinney 


> -Original Message-
> From: Wu, Jiaxin 
> Sent: Monday, May 6, 2024 9:55 PM
> To: Zhang, Hongbin1 ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Ni, Ray
> ; Liming Gao ; Liu, Zhiguang
> ; Xie, Yuanhao 
> Subject: RE: [PATCH v2] MdePkg: Add MmUnblockMemoryLib to MdeLibs.dsc
> 
> Reviewed-by: Jiaxin Wu 
> 
> 
> 
> > -Original Message-
> > From: Zhang, Hongbin1 
> > Sent: Monday, April 29, 2024 2:25 PM
> > To: devel@edk2.groups.io
> > Cc: Zhang, Hongbin1 ; Kinney, Michael D
> > ; Ni, Ray ; Liming Gao
> > ; Liu, Zhiguang ; Wu,
> > Jiaxin ; Xie, Yuanhao 
> > Subject: [PATCH v2] MdePkg: Add MmUnblockMemoryLib to MdeLibs.dsc
> >
> > MdeLibs.dsc.inc included some default libraries provided by MdePkg.
> > Platform can include MdeLibs.dsc.inc file to avoid some potential
> > incompatible changes to platform dsc file in future.
> >
> > Cc: Michael D Kinney 
> > Cc: Ray Ni 
> > Cc: Liming Gao 
> > Cc: Zhiguang Liu 
> > Cc: Jiaxin Wu 
> > Cc: Yuanhao Xie 
> > ---
> >  MdePkg/MdeLibs.dsc.inc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/MdeLibs.dsc.inc b/MdePkg/MdeLibs.dsc.inc
> > index d782dbf4ff..ddd27115f5 100644
> > --- a/MdePkg/MdeLibs.dsc.inc
> > +++ b/MdePkg/MdeLibs.dsc.inc
> > @@ -5,7 +5,7 @@
> >  # by using "!include MdePkg/MdeLibs.dsc.inc" to specify the library
> instances
> >  # of some EDKII basic/common library classes.
> >  #
> > -# Copyright (c) 2021 - 2022, Intel Corporation. All rights
> reserved.
> > +# Copyright (c) 2021 - 2024, Intel Corporation. All rights
> reserved.
> >  #
> >  #SPDX-License-Identifier: BSD-2-Clause-Patent
> >  #
> > @@ -18,3 +18,4 @@
> >
> > SmmCpuRendezvousLib|MdePkg/Library/SmmCpuRendezvousLibNull/SmmC
> > puRendezvousLibNull.inf
> >SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> >
> > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchroniz
> > ationLib.inf
> > +
> > MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo
> > ckMemoryLibNull.inf
> > --
> > 2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118645): https://edk2.groups.io/g/devel/message/118645
Mute This Topic: https://groups.io/mt/105796510/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

[Michael D Kinney]

Hi Ard,

Thais is an attribute of Mergify.  I do not see a way to change that
behavior.

I do not know if using the GitHub merge capability or other merge services
provides different behavior here or not.

This specific request is not related to the change to GitHub PRs
for code review.  There is no intention to change the requirement
for a maintainer to set the 'push' label and no intention to change
away from Mergify at this time.

Perhaps we can open your request as an independent request that we
can find an owner to evaluate options and provide recommendations.

Thanks,

Mike



> -Original Message-
> From: Ard Biesheuvel 
> Sent: Monday, May 6, 2024 8:31 AM
> To: Kinney, Michael D 
> Cc: r...@edk2.groups.io; devel@edk2.groups.io; Pedro Falcato
> ; Leif Lindholm ; Andrew
> Fish (af...@apple.com) 
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> Review from email to GitHub Pull Requests on 5-24-2024
> 
> On Mon, 6 May 2024 at 17:11, Kinney, Michael D
>  wrote:
> >
> > That information is in GitHub in the PR conversation.
> >
> > If you follow the link from the commit to the PR, the PR conversation
> shows
> > who set the 'push' label.
> >
> 
> But that is GitHub proprietary metadata, no? Is it not possible to set
> the committer field in Git itself to something meaningful?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118602): https://edk2.groups.io/g/devel/message/118602
Mute This Topic: https://groups.io/mt/105873467/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

[Michael D Kinney]

That information is in GitHub in the PR conversation.

If you follow the link from the commit to the PR, the PR conversation shows
who set the 'push' label.

Mike

> -Original Message-
> From: r...@edk2.groups.io  On Behalf Of Ard
> Biesheuvel
> Sent: Monday, May 6, 2024 3:01 AM
> To: devel@edk2.groups.io; Kinney, Michael D 
> Cc: Pedro Falcato ; r...@edk2.groups.io; Leif
> Lindholm ; Andrew Fish (af...@apple.com)
> 
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> Review from email to GitHub Pull Requests on 5-24-2024
> 
> This reminds me: would it be possible to keep track of who merged a
> PR? (i.e., the person that set the 'push' label)
> 
> Currently, commits just appear on the branch with the original author
> and the committer field set to something non-descript, e.g.,
> 
> commit 275d0a39c42ad73a6e4929822f56f5d8c16ede96 (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Gerd Hoffmann 
> AuthorDate: Fri Mar 1 08:44:00 2024 +0100
> Commit: mergify[bot]
> <37929162+mergify[bot]@users.noreply.github.com>
> CommitDate: Fri Mar 1 18:47:27 2024 +
> 
> which means we cannot tell from the git history which maintainer merged
> this.
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118600): https://edk2.groups.io/g/devel/message/118600
Mute This Topic: https://groups.io/mt/105873467/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

[Michael D Kinney]

> -Original Message-
> From: Kinney, Michael D 
> Sent: Friday, May 3, 2024 1:13 PM
> To: Pedro Falcato 
> Cc: r...@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm
> ; Andrew Fish (af...@apple.com) ;
> Kinney, Michael D 
> Subject: RE: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> Review from email to GitHub Pull Requests on 5-24-2024
> 
> 
> 
> > -Original Message-
> > From: Pedro Falcato 
> > Sent: Friday, May 3, 2024 10:39 AM
> > To: Kinney, Michael D 
> > Cc: r...@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm
> > ; Andrew Fish (af...@apple.com) 
> > Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> > Review from email to GitHub Pull Requests on 5-24-2024
> >
> > On Thu, May 2, 2024 at 7:17 PM Kinney, Michael D
> >  wrote:
> > >
> > >
> > >
> > > > -Original Message-
> > > > From: r...@edk2.groups.io  On Behalf Of Pedro
> > Falcato
> > > > Sent: Thursday, May 2, 2024 10:51 AM
> > > > To: devel@edk2.groups.io; Kinney, Michael D
> > 
> > > > Cc: r...@edk2.groups.io; Leif Lindholm ; Andrew
> > Fish
> > > > (af...@apple.com) 
> > > > Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore
> > Code
> > > > Review from email to GitHub Pull Requests on 5-24-2024
> > > >
> > > > On Wed, May 1, 2024 at 6:44 PM Michael D Kinney via groups.io
> > > >  wrote:
> > 
> > > > > * All contributors, maintainers, and reviewers must have GitHub
> > IDs.
> > > > > * The commit message would no longer require Cc:, Reviewed-by:,
> > Acked-
> > > > by:
> > > > >   or Tested-by: tags.  The only required tag would be Signed-
> off-
> > by.
> > > >
> > > > I'd just like to note that losing the CC:, Reviewed-by:, etc is a
> > big
> > > > loss. Gerrit auto-adds Rb's, github PR's do not (I'd guess there's
> a
> > > > way to pull that off with github actions, but I haven't looked).
> > It'll
> > > > be a mess if I have to go through online GH PR backlogs just to
> find
> > > > who to CC/add-to-review. It kills the decentralized bit off of git
> > too
> > > > :)
> > > >
> > >
> > > Can you provide more details on the impact of the loss?
> >
> > In my view, commits should be fairly self-describing. What changes,
> > why, are obvious, but who looked at it, who reviewed it, who was cc'd
> > but didn't respond, who tested are also pretty important. Git is
> > supposed to be decentralized, let's not forget. If we ever migrate
> > from GH, if GH ever goes down, if the links ever go down, you'll never
> > be able to know who looked at it. If you're looking at an EDK2 commit
> > deep into an Intel-internal fork, you won't know what "PR #478" is
> > (heck, rebase-and-merge doesn't reference PRs either).
> >
> > Side-note: How are we supposed to find the PR for a given commit?
> > Searching doesn't seem to work well. For instance, I picked a random
> > non-trivial commit out of the current open PRs:
> > MdeModulePkg/Bus/Spi/SpiBus: Adding SpiBus Drivers.
> >
> https://github.com/tianocore/edk2/pulls?q=is%3Apr+is%3Aopen+MdeModulePkg
> > %2FBus%2FSpi%2FSpiBus%3A+Adding+SpiBus+Drivers
> > has no matches?
> 
> If you have the sha of the commit, you can search in GitHub
> 
> For example, I selected a commit at random from recent edk2 commit
> history:
> 
>   https://github.com/tianocore/edk2/commit/032830e96841f2a752e364378c
> 3428ac5d2f59d1
> 
> Goto the "Pull Requests" tab for the repo and in the "Filters" search
> box enter
> 
>   is:pr is:merged 
> 
> In this example:
> 
>   is:pr is:merged 032830e96841f2a752e364378c3428ac5d2f59d1
> 
> This returns a single hit on PR #5560
> 
>   https://github.com/tianocore/edk2/pull/5560
> 
> There is also a 'gh' command line utility that can be used to write
> small scripts to collect this information

Here is the equivalent query and output using 'gh' CLI command:

gh pr list --repo tianocore/edk2 --state merged --search 
032830e96841f2a752e364378c3428ac5d2f59d1

Showing 1 of 1 pull request in tianocore/edk2 that matches your search

ID TITLE BRANCHCREATED AT
#5560  Loongcpu  niruiyu:loongcpu  about 17 days ago


> 
> >
> > >
> > > I am curious how other GitHub projects handle this topic. I see it
> >
> > I don't think they do, sadly. B

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

[Michael D Kinney]

> -Original Message-
> From: Pedro Falcato 
> Sent: Friday, May 3, 2024 10:39 AM
> To: Kinney, Michael D 
> Cc: r...@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm
> ; Andrew Fish (af...@apple.com) 
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> Review from email to GitHub Pull Requests on 5-24-2024
> 
> On Thu, May 2, 2024 at 7:17 PM Kinney, Michael D
>  wrote:
> >
> >
> >
> > > -Original Message-
> > > From: r...@edk2.groups.io  On Behalf Of Pedro
> Falcato
> > > Sent: Thursday, May 2, 2024 10:51 AM
> > > To: devel@edk2.groups.io; Kinney, Michael D
> 
> > > Cc: r...@edk2.groups.io; Leif Lindholm ; Andrew
> Fish
> > > (af...@apple.com) 
> > > Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore
> Code
> > > Review from email to GitHub Pull Requests on 5-24-2024
> > >
> > > On Wed, May 1, 2024 at 6:44 PM Michael D Kinney via groups.io
> > >  wrote:
> 
> > > > * All contributors, maintainers, and reviewers must have GitHub
> IDs.
> > > > * The commit message would no longer require Cc:, Reviewed-by:,
> Acked-
> > > by:
> > > >   or Tested-by: tags.  The only required tag would be Signed-off-
> by.
> > >
> > > I'd just like to note that losing the CC:, Reviewed-by:, etc is a
> big
> > > loss. Gerrit auto-adds Rb's, github PR's do not (I'd guess there's a
> > > way to pull that off with github actions, but I haven't looked).
> It'll
> > > be a mess if I have to go through online GH PR backlogs just to find
> > > who to CC/add-to-review. It kills the decentralized bit off of git
> too
> > > :)
> > >
> >
> > Can you provide more details on the impact of the loss?
> 
> In my view, commits should be fairly self-describing. What changes,
> why, are obvious, but who looked at it, who reviewed it, who was cc'd
> but didn't respond, who tested are also pretty important. Git is
> supposed to be decentralized, let's not forget. If we ever migrate
> from GH, if GH ever goes down, if the links ever go down, you'll never
> be able to know who looked at it. If you're looking at an EDK2 commit
> deep into an Intel-internal fork, you won't know what "PR #478" is
> (heck, rebase-and-merge doesn't reference PRs either).
> 
> Side-note: How are we supposed to find the PR for a given commit?
> Searching doesn't seem to work well. For instance, I picked a random
> non-trivial commit out of the current open PRs:
> MdeModulePkg/Bus/Spi/SpiBus: Adding SpiBus Drivers.
> https://github.com/tianocore/edk2/pulls?q=is%3Apr+is%3Aopen+MdeModulePkg
> %2FBus%2FSpi%2FSpiBus%3A+Adding+SpiBus+Drivers
> has no matches?

If you have the sha of the commit, you can search in GitHub

For example, I selected a commit at random from recent edk2 commit history:


https://github.com/tianocore/edk2/commit/032830e96841f2a752e364378c3428ac5d2f59d1

Goto the "Pull Requests" tab for the repo and in the "Filters" search box enter 

is:pr is:merged 

In this example:

is:pr is:merged 032830e96841f2a752e364378c3428ac5d2f59d1

This returns a single hit on PR #5560

https://github.com/tianocore/edk2/pull/5560

There is also a 'gh' command line utility that can be used to write
small scripts to collect this information 

> 
> >
> > I am curious how other GitHub projects handle this topic. I see it
> 
> I don't think they do, sadly. But I also don't know many people with a
> positive opinion on GH PRs :)
> 
> 
> > > It is sad that we're moving to PRs after I finally got a nice and
> > > sane(ish!) email workflow (openfw.io + b4). Otherwise, no
> objections,
> > > it's better than edk2.git's half-email half-PR frankenprocess.
> > > I'd guess this change only encompasses edk2.git? How about the other
> > > repos? Any timeline for those?
> >
> > The plan is to apply this to all repos, one at a time.  Need to get
> the
> > revised process documented and working in one repo before applying to
> all.
> 
> Gotcha, thanks!
> 
> --
> Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118563): https://edk2.groups.io/g/devel/message/118563
Mute This Topic: https://groups.io/mt/105873467/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

[Michael D Kinney]

Yes.  Many options on transition.  I would suggest we consider the
following steps.

1) Define a manual process where Maintainers/Reviewers look for 
   new PRs and make sure all the required maintainers/reviewers
   are invited to the review.  Current process has many manual
   steps.  Having this one does not seem like a bad transition 
   option.

2) Add CODEOWNERS support to automate assignment of maintainers
   And enforce maintainer approval requirements.

3) Add REVIEWEWS support to automate assignment of reviewers.

Mike

> -Original Message-
> From: r...@edk2.groups.io  On Behalf Of Michael
> Kubacki
> Sent: Friday, May 3, 2024 10:22 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> ; quic_llind...@quicinc.com;
> marcin.juszkiew...@linaro.org; r...@edk2.groups.io
> Cc: Leif Lindholm ; Andrew Fish (af...@apple.com)
> 
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> Review from email to GitHub Pull Requests on 5-24-2024
> 
> Hi Mike,
> 
> I've seen that repo in that past.
> 
> Are the steps defined for what's needed to move to CODEWONERS (and
> REVIEWERS) in terms of technical and process changes needed?
> 
> For example, could we start with CODEOWNERS manually synced to
> Maintainers.txt, Maintainers.txt dropped, and then add REVIEWERS in the
> future with additional actions to verify file coverage, etc.?
> 
> Thanks,
> Michael
> 
> On 5/2/2024 12:24 PM, Michael D Kinney wrote:
> > Hi Michael,
> >
> > I have a version of the auto assignment working, but needs to be
> > migrated to TianoCore and synced with the latest Maintainers.txt.
> >
> > My experience getting this running even as a POC was that it took a
> lot
> > of effort to make sure the best security practices were followed and
> > to configure the empty GitHub App with tokens and permissions. Anytime
> > custom actions are added, resources to implement, validate, and
> > support if they ever fail must be in place.
> >
> > My question is if there is a manual process that can be used to
> > start and these type of automations can be added over time as
> > dedicated resources are identified.
> >
> > Dionna's feedback about contributors not being able to add reviewers
> > to a PR is correct.  Contributors that are not members of the
> > EDK II Maintainers or EDK II Reviewers teams will either need to wait
> > for a Maintainer or Reviewer to add reviewers, or the contributor must
> > be added as an "outside collaborator" by an admin. For a manual
> process
> > this would require Maintainers to monitor new PRs and make sure the
> > correct set of Maintainers and Reviewers are added. Perhaps the
> > contributor can include @GitHubId mentions in the PR for the required
> > maintainers/reviewers so there are email notifications.
> >
> > Details on the auto assignment POC
> > ==
> > It uses CODEOWNERS so maintainers are auto assigned and can use GitHub
> > features to prevent merges without maintainer approval.  The idea is
> to
> > minimize the custom behavior and use as many built-in GitHub features
> as
> > possible.  It then reuses the CODEOWNERS syntax for a new file called
> > REVIEWERS along with some GitHub Actions to auto assign reviewers.
> The
> > actions are run by a registered empty GitHub application so it has a
> > TianoCore organization bot that is executing the actions with
> TianoCore
> > org permissions instead of an individual TianoCore member permissions.
> > Example PR with the bot with the name "tianocore-assign-reviewers"
> > performing assignments:
> >  https://github.com/tianocore/edk2-codereview/pull/91
> >
> > It was activated on this repo to run experiments:
> >  https://github.com/tianocore/edk2-codereview/tree/master/.github
> >
> > Example CODEOWNERS file:
> >  https://github.com/tianocore/edk2-
> codereview/blob/master/.github/CODEOWNERS
> >
> > Example REVIEWERS file using same format as CODEOWNERS
> >  https://github.com/tianocore/edk2-
> codereview/blob/master/.github/REVIEWERS
> >
> > Action to assign reviewers from REVIEWERS file:
> >  https://github.com/tianocore/edk2-
> codereview/blob/master/.github/workflows/AssignReviewers.yml
> >
> >  Depends on: https://github.com/mdkinney/github-action-assign-
> reviewers
> >
> > Action to verify that all files in a repo have CODEOWNES coverage
> >  https://github.com/tianocore/edk2-
> codereview/blob/master/.github/workflows/CheckCodeOwnerFiles.yml
> >
> > Action to verify that Maintainers.txt, CODEOWN

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

[Michael D Kinney]

> -Original Message-
> From: r...@edk2.groups.io  On Behalf Of Pedro Falcato
> Sent: Thursday, May 2, 2024 10:51 AM
> To: devel@edk2.groups.io; Kinney, Michael D 
> Cc: r...@edk2.groups.io; Leif Lindholm ; Andrew Fish
> (af...@apple.com) 
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> Review from email to GitHub Pull Requests on 5-24-2024
> 
> On Wed, May 1, 2024 at 6:44 PM Michael D Kinney via groups.io
>  wrote:
> >
> > Hello,
> >
> > I would like to propose that TianoCore move all code review from email
> > based code reviews to GitHub Pull Requests based code reviews.
> >
> > The proposed date to switch would be immediately after the next stable
> > tag which is currently scheduled for May 24, 2024.
> >
> > Updates to the following Wiki page would be required to describe the
> > required process when using GitHub Pull Requests for all code review
> > related activity.
> >
> > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-
> Development-Process
> >
> > A couple examples of the changes that would need to be documented are:
> >
> > * All contributors, maintainers, and reviewers must have GitHub IDs.
> > * The commit message would no longer require Cc:, Reviewed-by:, Acked-
> by:
> >   or Tested-by: tags.  The only required tag would be Signed-off-by.
> 
> I'd just like to note that losing the CC:, Reviewed-by:, etc is a big
> loss. Gerrit auto-adds Rb's, github PR's do not (I'd guess there's a
> way to pull that off with github actions, but I haven't looked). It'll
> be a mess if I have to go through online GH PR backlogs just to find
> who to CC/add-to-review. It kills the decentralized bit off of git too
> :)
> 

Can you provide more details on the impact of the loss?

I am curious how other GitHub projects handle this topic. I see it
is possible with squash and merge to amend the commit message, but
I do not see any features that allow all the commits in a series to
be amended.  TianoCore does not use squash and merge.

The main reason to remove this edit of the commit messages is that
the commit message edits look like a new version of the series to 
git/GitHub and requires review again.  This extra edit is also a
manual process and there is a history of maintainers missing who
did the reviews and acks.  The state in the GitHub PR is always
accurate.

> > * The Pull Request submitter is required to invite the required
> >   maintainers and reviewers to the pull request. This is the same
> >   set of maintainers and reviewers that are required to be listed in
> >   Cc: tags in today's process.
> > * Maintainers are responsible for verifying that all conversations in
> >   the code review are resolved and that all review approvals from the
> >   required set of maintainers are present before setting the 'push'
> label.
> >
> >
> > Please provide feedback
> > 1) If you are not in favor of this change.
> 
> It is sad that we're moving to PRs after I finally got a nice and
> sane(ish!) email workflow (openfw.io + b4). Otherwise, no objections,
> it's better than edk2.git's half-email half-PR frankenprocess.
> I'd guess this change only encompasses edk2.git? How about the other
> repos? Any timeline for those?

The plan is to apply this to all repos, one at a time.  Need to get the
revised process documented and working in one repo before applying to all.

> 
> --
> Pedro
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118539): https://edk2.groups.io/g/devel/message/118539
Mute This Topic: https://groups.io/mt/105873467/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Call or topics for May TianoCore Community Meeting

[Michael D Kinney]

There are 2 meeting times to accommodate time zones.

We can discuss in the meeting later today

Mike

> -Original Message-
> From: Oliver Smith-Denny 
> Sent: Thursday, May 2, 2024 10:04 AM
> To: devel@edk2.groups.io; Kinney, Michael D 
> Subject: Re: [edk2-devel] Call or topics for May TianoCore Community
> Meeting
> 
> Hi Mike,
> 
> Perhaps having a discussion on the PR transition would be good here?
> It would be ideal if we can have a meeting time that is friendly to
> folks on the thread about that (obviously can't accommodate every
> time zone).
> 
> Thanks,
> Oliver
> 
> On 5/1/2024 9:45 AM, Michael D Kinney wrote:
> > Please let me know if you have any topics for the TianoCore Community
> > Meeting this month.
> >
> > Thanks,
> >
> > Mike
> >
> >
> > 
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118537): https://edk2.groups.io/g/devel/message/118537
Mute This Topic: https://groups.io/mt/105846194/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

Mike

> -Original Message-
> From: Jayaprakash, N 
> Sent: Wednesday, April 24, 2024 11:14 AM
> To: devel@edk2.groups.io; Jayaprakash, N ;
> Kinney, Michael D 
> Cc: Rebecca Cran 
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex &
> wrmsr_ex functions to read/write cpu specific msrs
> 
> Hi Mike,
> 
> I have sent an updated patch v2 for review which uses the MP Services
> protocol API StarupThisAP() to read / write MSRs specific to CPU cores.
> Please review and do the needful.
> 
> Regards,
> JP
> 
> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of
> Jayaprakash, N
> Sent: Thursday, April 18, 2024 11:49 AM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Rebecca Cran 
> Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex &
> wrmsr_ex functions to read/write cpu specific msrs
> 
> Thanks Mike. I shall make necessary changes and submit the PR again for
> review.
> 
> Regards,
> JP
> 
> -Original Message-
> From: Kinney, Michael D 
> Sent: Thursday, April 18, 2024 10:46 AM
> To: Jayaprakash, N ; devel@edk2.groups.io
> Cc: Rebecca Cran ; Kinney, Michael D
> 
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex &
> wrmsr_ex functions to read/write cpu specific msrs
> 
> Please use MP Services Protocol APIs StartupAllAPs() or StarupThisAP()
> to read/write MSRs on other logical processors.
> 
> There and many examples of this in the UefiCpuPkg to programming MSRs on
> all the logical processors.
> 
> Mike
> 
> > -Original Message-
> > From: Jayaprakash, N 
> > Sent: Wednesday, April 17, 2024 8:16 PM
> > To: Kinney, Michael D ;
> > devel@edk2.groups.io
> > Cc: Rebecca Cran 
> > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex
> > & wrmsr_ex functions to read/write cpu specific msrs
> >
> > In the validation and debug scenarios, engineers tend to read MSRs and
> > write to MSRs of different CPUs.
> > So we are providing a simple mechanism through these APIs to enable
> > them to do these operations.
> >
> > These APIs will be part of the edk2 module of the Python interpreter
> > and will be used during the validation and debug scenarios only.
> >
> > This is not for switching the BSP for OS boot. This is only used
> > during the validation and debug use cases.
> >
> > Regards,
> > JP
> > -Original Message-
> > From: Kinney, Michael D 
> > Sent: Thursday, April 18, 2024 12:08 AM
> > To: Jayaprakash, N ; devel@edk2.groups.io
> > Cc: Rebecca Cran ; Kinney, Michael D
> > 
> > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex
> > & wrmsr_ex functions to read/write cpu specific msrs
> >
> > Hi JP,
> >
> > Is there a reason switch BSP is being used.  That is not a common
> > operation and is typically used if the current BSP is not stable or
> > there is a good reason to switch the BSP for OS boot.
> >
> > The MP Services can be used to execute a C function on APs to execute
> > MSR related instructions.
> >
> > Mike
> >
> > > -Original Message-
> > > From: Jayaprakash, N 
> > > Sent: Sunday, April 14, 2024 10:33 PM
> > > To: devel@edk2.groups.io; Jayaprakash, N 
> > > Cc: Rebecca Cran ; Kinney, Michael D
> > > 
> > > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add
> > rdmsr_ex
> > > & wrmsr_ex functions to read/write cpu specific msrs
> > >
> > > + Rebecca and Mike,
> > >
> > > Would you be able to review this PR?
> > >
> > > Regards,
> > > JP
> > >
> > > -Original Message-
> > > From: devel@edk2.groups.io  On Behalf Of
> > > Jayaprakash, N
> > > Sent: Wednesday, April 10, 2024 11:49 AM
> > > To: devel@edk2.groups.io
> > > Cc: Jayaprakash, N ; Rebecca Cran
> > > ; Kinney, Michael D 
> > > Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex &
> > > wrmsr_ex functions to read/write cpu specific msrs
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746
> > >
> > > The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr
> > > APIs supported in edk2 module. These extension APIs makes it
> > possible
> > > to read / write MSRs from specific processors and fills an existing
> > > gap in this area.
> > >
> > > Cc: Rebe

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

[Michael D Kinney]

> -Original Message-
> From: Leif Lindholm 
> Sent: Thursday, May 2, 2024 3:57 AM
> To: devel@edk2.groups.io; mikub...@linux.microsoft.com; Kinney, Michael
> D ; r...@edk2.groups.io
> Cc: Andrew Fish (af...@apple.com) 
> Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from
> email to GitHub Pull Requests on 5-24-2024
> 
> On 2024-05-02 04:08, Michael Kubacki wrote:
> > Thank you for this proposal. We've been anticipating this change for
> > years and are excited to help support it.
> >
> > Here's some items we'd like to raise for feedback that we could help
> > implement. Many could likely be done in time for the transition.
> >
> > 1. Automate reviewers - We've discussed CODEOWNERS in the past.
> However,
> > a simpler approach (in maintaining/syncing less files) would be to use
> > Maintainers.txt directly with a GitHub workflow since the file already
> > contains GitHub IDs.
> 
> That would be ideal. I know Mike worked on autogenerating CODEOWNERS
> from Maintainers.txt, but ultimately the latter supports more flexible
> use of wildcards (things like */AArch64/ currently requires reconciling
> against the repo contents).

I have a python script that can verify if there are any differences 
Between CODEOWNERS and Maintainers.txt.  I do not any tools that can
convert Maintainers.txt to CODEOWNERS.  That has been a manual process.

I recommend we identify a plan to switch to CODEOWNERS and drop 
Maintainers.txt. May take a while for everyone to get used to the
differences.

> 
> > 2. Make PR completion contingent on a GitHub review from at least one
> > package maintainer/reviewer for each package in the PR.
> 
> Yes.
> 
> > 3. Dependabot is already used today to automatically create PRs when
> > dependencies like pip modules have updates. To allow this to more
> > effectively keep dependencies up-to-date, allow dependabot PRs to be
> > completed (after normal acceptance criteria like CI and review
> > requirements) without a separate human creating a duplicate PR.
> 
> I am not sure what this means in practice :)
> This doesn't sound like one we need to worry about before switchover
> though.
> 
> > 4. Potentially warn users (with an automated comment on the PR) if
> they
> > add a push label to a PR that is less than 24 hours old.
> 
> That sounds good.
> Is there any way to prevent force-pushes within 24h of previous push?
> That would make setting up a transitional review-scraper less lossy.
> 
> > 5. Leave reminder comments on PRs with absolutely no activity after
> some
> > agreed upon time so reviewers are notified to review the PR without
> the
> > submitter having to watch it and send notifications.
> 
> Yes. But should take priority below 1, 2, and 4. Unless you have a
> pre-cooked thing to drop in of course.
> 
> > 6. Leave reminder comments on PRs that meet all requirements to be
> > completed (all reviews accounted for and status checks pass) but are
> > still open so those on the PR are notified to complete it without the
> > submitter having to manually watch and send reminders.
> 
> Not a response to this, but triggered by reading this:
> Is there any way to approve changes within a PR on a commit by commit
> basis?

Unfortunately, this is not supported.  The approval is al the PR level.
What this means in practice is if there is a single PR with changes
across multiple packages or maintainer responsibility, then the PR
will need approvals from all the required maintainers, and the 
maintainers that wants to apply the 'push' label to merge must
review the set of approvals and make sure all the required ones 
are present.

This check could be automated in the future.

> 
> > 7. We are happy to help with process documentation.
> 
> Always appreciated,thanks.
> 
> Regards,
> 
> Leif



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118533): https://edk2.groups.io/g/devel/message/118533
Mute This Topic: https://groups.io/mt/105847510/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

[Michael D Kinney]

> -Original Message-
> From: r...@edk2.groups.io  On Behalf Of Brian J.
> Johnson
> Sent: Thursday, May 2, 2024 8:59 AM
> To: devel@edk2.groups.io; dionnagl...@google.com;
> quic_llind...@quicinc.com
> Cc: Kinney, Michael D ; r...@edk2.groups.io;
> Andrew Fish (af...@apple.com) 
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> Review from email to GitHub Pull Requests on 5-24-2024
> 
> On 5/1/24 18:19, Dionna Glaze via groups.io wrote:
> > On Wed, May 1, 2024 at 11:12 AM Leif Lindholm via groups.io
> >  wrote:
> >>
> >> On 2024-05-01 18:43, Michael D Kinney wrote:
> >>> Hello,
> >>>
> >>> I would like to propose that TianoCore move all code review from
> email
> >>> based code reviews to GitHub Pull Requests based code reviews.
> >>>
> >>> The proposed date to switch would be immediately after the next
> stable
> >>> tag which is currently scheduled for May 24, 2024.
> >>
> >> Thanks Mike.
> >>
> >> I'm in favour of this change, and the date.
> >>
> >> I still want us to try to figure out how to retain review history
> beyond
> >> what github decides we need, but I don't think it justifies
> indefinitely
> >> delaying the switchover. And frankly, it will be easier to experiment
> >> with what works and not after the switch.
> >
> > +1. UI-based interactions don't export well for archival-permalinking
> > reasons, and Github archive behavior is for repositories only, not the
> > reviews.
> > But yes, wouldn't want to delay for a bot to echo conversations to
> > devel@edk2.groups.io or some other solution.
> >
> 
> +1 from me as well.  We need to maintain review history in some fairly
> permanent manner, both the reviewed code and review comments.
> 
> >>
> >> /
> >>   Leif
> >>
> >>> Updates to the following Wiki page would be required to describe the
> >>> required process when using GitHub Pull Requests for all code review
> >>> related activity.
> >>>
> >>>   https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-
> Development-Process
> >>>
> >>> A couple examples of the changes that would need to be documented
> are:
> >>>
> >>> * All contributors, maintainers, and reviewers must have GitHub IDs.
> >
> > It looks like this is already resolved for the existing
> > Maintainers.txt with the `[username]` syntax, but I don't see any
> > explanation of that expectation. Seems fine to me.
> >
> >>> * The commit message would no longer require Cc:, Reviewed-by:,
> Acked-by:
> >>> or Tested-by: tags.  The only required tag would be Signed-off-
> by.
> 
> Would those tags be optional?  Test and ack info can be helpful when
> researching a change, to find people who may be knowledgeable about it.
> 
> Similarly, the Reviewed-by info is nice to have in the history, without
> having to dig it out of archives.  But it's a bit awkward to add on
> github:  you have to push new commits with the Reviewed-by tags, but
> that changes the SHAs, so it's not obvious that the commits you're
> merging have the same code as the ones which were reviewed.  For the
> email flow, we trust maintainers to get this right.  For the github
> flow, are we deciding to rely exclusively on the PR archives?
> 
> What if a maintainer decides to tweak a commit before merging it, eg. to
> fix a trivial typo?  With the email flow they just go ahead and do it.
> With the github flow, would they need to post another PR, so it could
> make it through the process and be merged?
> 

Editing commit messages after reviews is something we want to avoid so
the PR does not need to be re-reviewed to be merged.  GitHub has history
of who did the reviews and the conversations that can include information
on testing and review activity.

Yes.  Even trivial changes to the code would require the PR to be updated
and re-reviewed.  It is a different process than email where we allowed
maintainers to make minor changes.  However, even a maintainer making a 
minor change could break things in unexpected ways.  It seems better to
have stricter control over changes and all changes are reviewed and go 
through CI.

> >>> * The Pull Request submitter is required to invite the required
> >>> maintainers and reviewers to the pull request. This is the same
> >>> set of maintainers and reviewers that are required to be listed
> in
> >>> Cc: tags in today's process.
> >
> > This is not configured on

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

[Michael D Kinney]

Hi Michael,

I have a version of the auto assignment working, but needs to be 
migrated to TianoCore and synced with the latest Maintainers.txt.

My experience getting this running even as a POC was that it took a lot
of effort to make sure the best security practices were followed and
to configure the empty GitHub App with tokens and permissions. Anytime
custom actions are added, resources to implement, validate, and 
support if they ever fail must be in place.

My question is if there is a manual process that can be used to 
start and these type of automations can be added over time as 
dedicated resources are identified.

Dionna's feedback about contributors not being able to add reviewers
to a PR is correct.  Contributors that are not members of the 
EDK II Maintainers or EDK II Reviewers teams will either need to wait
for a Maintainer or Reviewer to add reviewers, or the contributor must
be added as an "outside collaborator" by an admin. For a manual process
this would require Maintainers to monitor new PRs and make sure the
correct set of Maintainers and Reviewers are added. Perhaps the 
contributor can include @GitHubId mentions in the PR for the required
maintainers/reviewers so there are email notifications.

Details on the auto assignment POC
==
It uses CODEOWNERS so maintainers are auto assigned and can use GitHub
features to prevent merges without maintainer approval.  The idea is to
minimize the custom behavior and use as many built-in GitHub features as
possible.  It then reuses the CODEOWNERS syntax for a new file called
REVIEWERS along with some GitHub Actions to auto assign reviewers.  The
actions are run by a registered empty GitHub application so it has a
TianoCore organization bot that is executing the actions with TianoCore
org permissions instead of an individual TianoCore member permissions. 
Example PR with the bot with the name "tianocore-assign-reviewers" 
performing assignments:
https://github.com/tianocore/edk2-codereview/pull/91

It was activated on this repo to run experiments:
https://github.com/tianocore/edk2-codereview/tree/master/.github

Example CODEOWNERS file:
https://github.com/tianocore/edk2-codereview/blob/master/.github/CODEOWNERS

Example REVIEWERS file using same format as CODEOWNERS
https://github.com/tianocore/edk2-codereview/blob/master/.github/REVIEWERS

Action to assign reviewers from REVIEWERS file:

https://github.com/tianocore/edk2-codereview/blob/master/.github/workflows/AssignReviewers.yml

Depends on: https://github.com/mdkinney/github-action-assign-reviewers

Action to verify that all files in a repo have CODEOWNES coverage

https://github.com/tianocore/edk2-codereview/blob/master/.github/workflows/CheckCodeOwnerFiles.yml

Action to verify that Maintainers.txt, CODEOWNERS, and REVIEWERS are synced.
This is to support transition from using Maintainers.txt to using CODEOWNERS
and REVIEWERS and can be dropped when Maintainers.txt is removed.

https://github.com/tianocore/edk2-codereview/blob/master/.github/workflows/CheckCodeOwnerMaintainers.yml

Depends on: 
https://github.com/mdkinney/github-action-check-codeowners-maintainers

Thanks,

Mike

> -Original Message-
> From: Michael Kubacki 
> Sent: Thursday, May 2, 2024 8:21 AM
> To: devel@edk2.groups.io; quic_llind...@quicinc.com;
> marcin.juszkiew...@linaro.org; Kinney, Michael D
> ; r...@edk2.groups.io
> Cc: Leif Lindholm ; Andrew Fish (af...@apple.com)
> 
> Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from
> email to GitHub Pull Requests on 5-24-2024
> 
> On 5/2/2024 6:34 AM, Leif Lindholm wrote:
> > On 2024-05-02 07:33, Marcin Juszkiewicz wrote:
> >> W dniu 1.05.2024 o 19:43, Michael D Kinney via groups.io pisze:
> >>> I would like to propose that TianoCore move all code review from
> email
> >>> based code reviews to GitHub Pull Requests based code reviews.
> >>>
> >>> The proposed date to switch would be immediately after the next
> stable
> >>> tag which is currently scheduled for May 24, 2024.
> >>
> >> O yes! Fully for it!
> >>
> >> Does it mean edk2 only or edk2/edk2-platforms/edk2-non-osi and other
> >> tianocore/ repositories?
> >
> > I don't see why we couldn't switch all of them. Other than we need to
> > get all the Maintainers.txt updated with code forge usernames first.
> >
> > We may want to do one at a time though.
> >
> > /
> >      Leif
> >
> >>> * The Pull Request submitter is required to invite the required
> >>>    maintainers and reviewers to the pull request. This is the same
> >>>    set of maintainers and reviewers that are required to be listed
> in
> >>>    Cc: tags in today's process.
> >&g

[edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

[Michael D Kinney]

Hello,

I would like to propose that TianoCore move all code review from email
based code reviews to GitHub Pull Requests based code reviews.

The proposed date to switch would be immediately after the next stable
tag which is currently scheduled for May 24, 2024.

Updates to the following Wiki page would be required to describe the 
required process when using GitHub Pull Requests for all code review
related activity.


https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

A couple examples of the changes that would need to be documented are:

* All contributors, maintainers, and reviewers must have GitHub IDs.
* The commit message would no longer require Cc:, Reviewed-by:, Acked-by:
  or Tested-by: tags.  The only required tag would be Signed-off-by.
* The Pull Request submitter is required to invite the required
  maintainers and reviewers to the pull request. This is the same 
  set of maintainers and reviewers that are required to be listed in
  Cc: tags in today's process.
* Maintainers are responsible for verifying that all conversations in
  the code review are resolved and that all review approvals from the
  required set of maintainers are present before setting the 'push' label.


Please provide feedback
1) If you are not in favor of this change.
2) If you are not in favor of the proposed date of this change.
3) On the process changes you would like to see documented in the Wiki
   pages related to using GitHub Pull Request based code reviews.

There is some prototype work to automate/simplify some of the PR based
code review process steps. Those could be added over time as resources
are available to finish and support them. 

Best regards,

Mike


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118468): https://edk2.groups.io/g/devel/message/118468
Mute This Topic: https://groups.io/mt/105847510/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Call or topics for May TianoCore Community Meeting

[Michael D Kinney]

Please let me know if you have any topics for the TianoCore Community
Meeting this month.

Thanks,

Mike


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118467): https://edk2.groups.io/g/devel/message/118467
Mute This Topic: https://groups.io/mt/105846194/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Update my email address

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Anthony
> PERARD via groups.io
> Sent: Monday, April 29, 2024 9:06 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Yao, Jiewen
> ; Anthony PERARD 
> Subject: [edk2-devel] [PATCH 1/1] Maintainers.txt: Update my email
> address
> 
> From: Anthony PERARD 
> 
> Signed-off-by: Anthony PERARD 
> ---
>  Maintainers.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7d9cdca611fc..07fa50d65991 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -567,7 +567,7 @@ F: OvmfPkg/XenIoPvhDxe/
>  F: OvmfPkg/XenPlatformPei/
>  F: OvmfPkg/XenPvBlkDxe/
>  F: OvmfPkg/XenResetVector/
> -R: Anthony Perard  [tperard]
> +R: Anthony Perard  [tperard]
> 
>  OvmfPkg: RISC-V Qemu Virt Platform
>  F: OvmfPkg/RiscVVirt
> --
> Anthony PERARD
> 
> º.¦È¨.)䱊.­çŠ÷š–
> Yž²Æ zËžÛh¶¬‚º.¥XžÃô^¦\ŽžX§{]|ßÝa¶Úlÿ÷“h+¢êlŠàýׯz_æzˁïõ×ÍýÔË­y8b±
> :)‰Èm¶›?þ
> 躛"£ù­ÿ]9óMûó¯õëø÷¡«¢êNÂw«uëÞ—ê0êÞvM ®‹©²*žË›±Êâmèm¶›?ýçdÚ
> 躛"£ø?uëÞ—û§²ææ‰ÈZzWdŠyÞÊ)ízW(


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118392): https://edk2.groups.io/g/devel/message/118392
Mute This Topic: https://groups.io/mt/105803786/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 00/10] Add DeviceSecurity feature based on PFP 1.06 spec

[Michael D Kinney]

No objections.

For all patches related to adding libspdm submodule:

Reviewed-by: Michael D Kinney 

Mike

> -Original Message-
> From: Yao, Jiewen 
> Sent: Sunday, April 28, 2024 5:33 PM
> To: Hou, Wenxing ; devel@edk2.groups.io; Andrew
> Fish ; Leif Lindholm ;
> Kinney, Michael D ; Liming Gao
> ; Sean Brogan ;
> Joey Vagedes ; Liu, Zhiguang
> ; Kumar, Rahul R 
> Subject: RE: [edk2-devel] [PATCH v4 00/10] Add DeviceSecurity feature
> based on PFP 1.06 spec
> 
> Hi All
> It has been 4 work weeks and this V4 patch resolved previous comments
> and feedbacks.
> 
> If there is no further objection, I plan to merge it tomorrow.
> 
> Thank you
> Yao, Jiewen
> 
> 
> > -Original Message-
> > From: Hou, Wenxing 
> > Sent: Friday, April 26, 2024 9:52 AM
> > To: Yao, Jiewen ; devel@edk2.groups.io; Andrew
> Fish
> > ; Leif Lindholm ; Kinney,
> Michael
> > D ; Liming Gao ;
> > Sean Brogan ; Joey Vagedes
> > ; Liu, Zhiguang ;
> Kumar,
> > Rahul R 
> > Subject: RE: [edk2-devel] [PATCH v4 00/10] Add DeviceSecurity feature
> based on
> > PFP 1.06 spec
> >
> > Hi EDKII stewards,
> >
> > Could you please review the libspdm license?
> >
> > The libspdm(https://github.com/DMTF/libspdm) is a implementation that
> follows
> > the DMTF SPDM(https://www.dmtf.org/standards/spdm) spec.
> >
> > And the libspdm library is under DMTF repo.
> > The license is: https://github.com/DMTF/libspdm/blob/main/LICENSE.md
> >
> >
> >
> > Thanks,
> > Wenxing
> >
> >
> > -Original Message-
> > From: Yao, Jiewen 
> > Sent: Sunday, April 21, 2024 10:31 AM
> > To: Hou, Wenxing ; devel@edk2.groups.io; Andrew
> Fish
> > ; Leif Lindholm ; Kinney,
> Michael
> > D ; Liming Gao ;
> > Sean Brogan ; Joey Vagedes
> > ; Liu, Zhiguang ;
> Kumar,
> > Rahul R 
> > Subject: RE: [edk2-devel] [PATCH v4 00/10] Add DeviceSecurity feature
> based on
> > PFP 1.06 spec
> >
> > All series: Reviewed-by: Jiewen Yao 
> >
> > Dear Steward member
> > Do you have any concern on adding libspdm
> (https://github.com/DMTF/libspdm)
> > as one more submodule?
> >
> > Thank you
> > Yao, Jiewen
> >
> > > -Original Message-
> > > From: Hou, Wenxing 
> > > Sent: Thursday, April 18, 2024 6:16 PM
> > > To: devel@edk2.groups.io; Andrew Fish ; Leif
> Lindholm
> > > ; Kinney, Michael D
> > > ; Liming Gao ;
> > > Sean Brogan ; Joey Vagedes
> > > ; Liu, Zhiguang ;
> > > Kumar, Rahul R ; Yao, Jiewen
> > > 
> > > Subject: RE: [edk2-devel] [PATCH v4 00/10] Add DeviceSecurity
> feature
> > > based on PFP 1.06 spec
> > >
> > > Dear EDKII reviewers:
> > >
> > > Thank you for your previous review of this patch set.
> > > Currently, five patches have been reviewed by.
> > >
> > > But there are five patches need review.
> > >   Patch1:  MdePkg: Add SPDM1.2 support.
> > >   Patch2:  MdePkg: Add TCG PFP 1.06 support.
> > >   Patch4:  MdeModulePkg/Variable: Add TCG SPDM device measurement
> > > update
> > >   Patch8:  .gitmodule: Add libspdm submodule for EDKII
> > >   Patch10: ReadMe.rst: Add libspdm submodule license
> > >
> > > Could you please review the PATCH v4?
> > >
> > > PS: Jiewen has reviewed all the PATCH. And I have fixed his feedback
> in PATCH
> > v4.
> > > Jiewen has no questions about all the patches anymore.
> > >
> > > Thanks,
> > > Wenxing
> > >
> > >
> > > -Original Message-
> > > From: devel@edk2.groups.io  On Behalf Of
> Wenxing
> > > Hou
> > > Sent: Thursday, April 18, 2024 5:28 PM
> > > To: devel@edk2.groups.io
> > > Cc: Andrew Fish ; Leif Lindholm
> > > ; Kinney, Michael D
> > > ; Liming Gao ;
> > > Sean Brogan ; Joey Vagedes
> > > ; Liu, Zhiguang ;
> > > Kumar, Rahul R ; Yao, Jiewen
> > > 
> > > Subject: [edk2-devel] [PATCH v4 00/10] Add DeviceSecurity feature
> > > based on PFP
> > > 1.06 spec
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2479
> > >
> > > In PFP spec 1.06, platform firmware records the device certificate
> and
> > > device measurement for each SPDM responder.
> > > This PATCH set implement the DeviceSecurityLib to support spdm
> device
> > > Authentication and Measurement.
> > >

Re: [edk2-devel] [PATCH v4 1/1] OvmfPkg/VirtHstiDxe: do not load driver in confidential guests

[Michael D Kinney]

Hi Jiewen,

Michael Kubacki has been working on a CI issue and a change is being merged now.

Mike

> -Original Message-
> From: Yao, Jiewen 
> Sent: Wednesday, April 24, 2024 3:57 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> ; Sean Brogan 
> Cc: Gerd Hoffmann ; Ard Biesheuvel ;
> Oliver Steffen ; Ard Biesheuvel
> ; Srikanth Aithal 
> Subject: RE: [PATCH v4 1/1] OvmfPkg/VirtHstiDxe: do not load driver in
> confidential guests
> 
> Hi Mike/Sean
> Can someone look at the EDKII CI?
> 
> My PR has been blocked for 9 hours -
> https://github.com/tianocore/edk2/pull/5595.
> 
> Thank you
> Yao, Jiewen
> 
> 
> > -Original Message-
> > From: Ard Biesheuvel 
> > Sent: Thursday, April 25, 2024 1:05 AM
> > To: Yao, Jiewen 
> > Cc: Gerd Hoffmann ; devel@edk2.groups.io; Oliver
> Steffen
> > ; Ard Biesheuvel ;
> Srikanth
> > Aithal 
> > Subject: Re: [PATCH v4 1/1] OvmfPkg/VirtHstiDxe: do not load driver in
> > confidential guests
> >
> > On Wed, 24 Apr 2024 at 18:36, Yao, Jiewen 
> wrote:
> > >
> > > Thanks Ard.
> > >
> > > I have submitted https://github.com/tianocore/edk2/pull/5595 3 hours
> ago.
> > > But it seems the CI stops working...
> > >
> >
> > OK, I have dropped my PR.
> >
> >
> >
> > >
> > >
> > > > -Original Message-
> > > > From: Ard Biesheuvel 
> > > > Sent: Thursday, April 25, 2024 12:27 AM
> > > > To: Yao, Jiewen 
> > > > Cc: Gerd Hoffmann ; devel@edk2.groups.io;
> Oliver
> > Steffen
> > > > ; Ard Biesheuvel ;
> > Srikanth
> > > > Aithal 
> > > > Subject: Re: [PATCH v4 1/1] OvmfPkg/VirtHstiDxe: do not load
> driver in
> > > > confidential guests
> > > >
> > > > On Wed, 24 Apr 2024 at 08:45, Yao, Jiewen 
> wrote:
> > > > >
> > > > > Reviewed-by: Jiewen Yao 
> > > > >
> > > >
> > > > Thanks, I've queued this up.
> > > >
> > > >
> > > > > > -Original Message-
> > > > > > From: Gerd Hoffmann 
> > > > > > Sent: Wednesday, April 24, 2024 2:00 PM
> > > > > > To: devel@edk2.groups.io
> > > > > > Cc: Oliver Steffen ; Gerd Hoffmann
> > > > > > ; Ard Biesheuvel
> ; Yao,
> > > > Jiewen
> > > > > > ; Srikanth Aithal 
> > > > > > Subject: [PATCH v4 1/1] OvmfPkg/VirtHstiDxe: do not load
> driver in
> > > > confidential
> > > > > > guests
> > > > > >
> > > > > > The VirtHstiDxe does not work in confidential guests.  There
> also isn't
> > > > > > anything we can reasonably test, neither flash storage nor SMM
> mode will
> > > > > > be used in that case.  So just skip driver load when running
> in a
> > > > > > confidential guest.
> > > > > >
> > > > > > Cc: Ard Biesheuvel 
> > > > > > Cc: Jiewen Yao 
> > > > > > Fixes: 506740982bba ("OvmfPkg/VirtHstiDxe: add code flash
> check")
> > > > > > Signed-off-by: Gerd Hoffmann 
> > > > > > Tested-by: Srikanth Aithal 
> > > > > > ---
> > > > > >  OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf | 1 +
> > > > > >  OvmfPkg/VirtHstiDxe/VirtHstiDxe.c   | 6 ++
> > > > > >  2 files changed, 7 insertions(+)
> > > > > >
> > > > > > diff --git a/OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf
> > > > > > b/OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf
> > > > > > index 9514933011e8..b5c237288766 100644
> > > > > > --- a/OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf
> > > > > > +++ b/OvmfPkg/VirtHstiDxe/VirtHstiDxe.inf
> > > > > > @@ -49,6 +49,7 @@ [FeaturePcd]
> > > > > >gUefiOvmfPkgTokenSpaceGuid.PcdSmmSmramRequire
> > > > > >
> > > > > >  [Pcd]
> > > > > > +  gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr
> > > > > >gUefiOvmfPkgTokenSpaceGuid.PcdBfvBase
> > > > > >
> gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageVariableBase
> > > > > >
> > > > > > diff --git a/OvmfPkg/VirtHstiDxe/VirtHstiDxe.c
> > > > > > b/OvmfPkg/VirtHstiDxe/VirtHstiDxe.c
> > > > > > index b6e53a1219d1..efaff0d1f3cb 100644
> > > > > > --- a/OvmfPkg/VirtHstiDxe/VirtHstiDxe.c
> > > > > > +++ b/OvmfPkg/VirtHstiDxe/VirtHstiDxe.c
> > > > > > @@ -17,6 +17,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> > > > > >  #include 
> > > > > >  #include 
> > > > > >  #include 
> > > > > > +#include 
> > > > > >  #include 
> > > > > >
> > > > > >  #include 
> > > > > > @@ -140,6 +141,11 @@ VirtHstiDxeEntrypoint (
> > > > > >EFI_STATUS   Status;
> > > > > >EFI_EVENTEvent;
> > > > > >
> > > > > > +  if (PcdGet64 (PcdConfidentialComputingGuestAttr)) {
> > > > > > +DEBUG ((DEBUG_INFO, "%a: confidential guest\n",
> __func__));
> > > > > > +return EFI_UNSUPPORTED;
> > > > > > +  }
> > > > > > +
> > > > > >DevId = VirtHstiGetHostBridgeDevId ();
> > > > > >switch (DevId) {
> > > > > >  case INTEL_82441_DEVICE_ID:
> > > > > > --
> > > > > > 2.44.0
> > > > >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118238): https://edk2.groups.io/g/devel/message/118238
Mute This Topic: https://groups.io/mt/105705705/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] Update to CodeQL 2.16.1

[Michael D Kinney]

Go ahead and add the push label.

Mike

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Michael
> Kubacki
> Sent: Wednesday, April 24, 2024 2:55 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Liming Gao
> ; Rebecca Cran ; Sean
> Brogan ; Chen, Christine
> 
> Subject: Re: [edk2-devel] [PATCH v1 1/1] Update to CodeQL 2.16.1
> 
> Thanks for reviews. I've updated the PR
> (https://github.com/tianocore/edk2/pull/5597) to include them.
> 
> Although it has not been 24 hours, I suggest we merge the patch soon to
> ensure CI is unblocked. Please feel free to add the push tag or let me
> know if you'd like me to.
> 
> Thanks,
> Michael
> 
> On 4/24/2024 1:37 PM, Michael Kubacki wrote:
> > From: Michael Kubacki 
> >
> > Fixes current CI CodeQL failures due to old CodeQL CLI version.
> >
> > Updates CodeQL to work with the latest queries. Includes functional
> > and security fixes within the CodeQL CLI binary.
> >
> > For more information on release details see:
> >
> > https://github.com/github/codeql-cli-binaries/releases
> >
> > For changes between the previous version (2.14.5) and 2.16.1 see:
> >
> > https://github.com/github/codeql-cli-
> binaries/compare/v2.14.5...v2.16.1
> >
> > Cc: Bob Feng 
> > Cc: Joey Vagedes 
> > Cc: Liming Gao 
> > Cc: Michael D Kinney 
> > Cc: Rebecca Cran 
> > Cc: Sean Brogan 
> > Cc: Yuwei Chen 
> > Signed-off-by: Michael Kubacki 
> > ---
> >
> > Notes:
> >  Tested in https://github.com/tianocore/edk2/pull/5597
> >
> >   BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml | 6 +++---
> >   BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml   | 6 +++---
> >   BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml | 6 +++---
> >   3 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> > index 37c7c9f595ca..5ec56c6bf06f 100644
> > --- a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> > +++ b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> > @@ -16,9 +16,9 @@
> > "scope": "codeql-ext-dep",
> > "type": "web",
> > "name": "codeql_cli",
> > -  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.12.4/codeql.zip",
> > -  "version": "2.12.4",
> > -  "sha256":
> "f682f1155d627ad97f10b1bcad97f682011986717bd3823e9cf831ed83ac96e7",
> > +  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.16.1/codeql.zip",
> > +  "version": "2.16.1",
> > +  "sha256":
> "86a98f6ebb8fd49efadf367f3275c438669fcb8426962c33415129aad8e093e6",
> > "compression_type": "zip",
> > "internal_path": "/codeql/",
> > "flags": ["set_shell_var", ],
> > diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> > index a6ca5d0f34cc..5b4a919f1de4 100644
> > --- a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> > +++ b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> > @@ -14,9 +14,9 @@
> > "scope": "codeql-linux-ext-dep",
> > "type": "web",
> > "name": "codeql_linux_cli",
> > -  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.14.5/codeql-linux64.zip",
> > -  "version": "2.14.5",
> > -  "sha256":
> "72aa5d748ff9ab57cfd86045560683bdc4897e0fe6d9f9a2786d9394674ae733",
> > +  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.16.1/codeql-linux64.zip",
> > +  "version": "2.16.1",
> > +  "sha256":
> "40dbb6c0c4064bd14601a02e60c61661fdc0271469f90eb91a2e7d51d4cbc171",
> > "compression_type": "zip",
> > "internal_path": "/codeql/",
> > "flags": ["set_shell_var", ],
> > diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> > index e706a7cabf9f..c0c018c9538f 100644
> > --- a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> > +++ b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.

Re: [edk2-devel] [PATCH edk2-non-osi 1/1] Maintainers.txt: add maintainers for SbsaQemu platform

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: Leif Lindholm 
> Sent: Tuesday, April 23, 2024 7:40 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Kinney, Michael D
> ; Marcin Juszkiewicz
> 
> Subject: [PATCH edk2-non-osi 1/1] Maintainers.txt: add maintainers for
> SbsaQemu platform
> 
> Signed-off-by: Leif Lindholm 
> ---
> 
> p.s. Mike, could you add write access for Marcin in this repo as well?
>  It was a pure oversight not to ask this at the same time as for
>  edk2-platforms.
> 
>  Maintainers.txt | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index eaf13fda6af0..2cdff26facaf 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -63,6 +63,11 @@ Platform/Intel/CometlakeSiliconBinPkg
>  M: Kathappan Esakkithevar 
>  M: Sai Chaganty 
> 
> +Platform/Qemu/SbsaQemu
> +M: Ard Biesheuvel  [ardbiesheuvel]
> +M: Leif Lindholm  [leiflindholm]
> +M: Marcin Juszkiewicz  [hrw]
> +
>  Silicon/AMD
>  M: Abner Chang 
>  M: Abdul Lateef Attar 
> --
> 2.30.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118229): https://edk2.groups.io/g/devel/message/118229
Mute This Topic: https://groups.io/mt/105690641/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] Update to CodeQL 2.16.1

[Michael D Kinney]

Reviewed-by: Michael D Kinney 



> -Original Message-
> From: mikub...@linux.microsoft.com 
> Sent: Wednesday, April 24, 2024 10:37 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Joey Vagedes
> ; Liming Gao ; Kinney,
> Michael D ; Rebecca Cran
> ; Sean Brogan ; Chen,
> Christine 
> Subject: [PATCH v1 1/1] Update to CodeQL 2.16.1
> 
> From: Michael Kubacki 
> 
> Fixes current CI CodeQL failures due to old CodeQL CLI version.
> 
> Updates CodeQL to work with the latest queries. Includes functional
> and security fixes within the CodeQL CLI binary.
> 
> For more information on release details see:
> 
> https://github.com/github/codeql-cli-binaries/releases
> 
> For changes between the previous version (2.14.5) and 2.16.1 see:
> 
> https://github.com/github/codeql-cli-binaries/compare/v2.14.5...v2.16.1
> 
> Cc: Bob Feng 
> Cc: Joey Vagedes 
> Cc: Liming Gao 
> Cc: Michael D Kinney 
> Cc: Rebecca Cran 
> Cc: Sean Brogan 
> Cc: Yuwei Chen 
> Signed-off-by: Michael Kubacki 
> ---
> 
> Notes:
> Tested in https://github.com/tianocore/edk2/pull/5597
> 
>  BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml | 6 +++---
>  BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml   | 6 +++---
>  BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml | 6 +++---
>  3 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> index 37c7c9f595ca..5ec56c6bf06f 100644
> --- a/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
> @@ -16,9 +16,9 @@
>"scope": "codeql-ext-dep",
>"type": "web",
>"name": "codeql_cli",
> -  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.12.4/codeql.zip",
> -  "version": "2.12.4",
> -  "sha256":
> "f682f1155d627ad97f10b1bcad97f682011986717bd3823e9cf831ed83ac96e7",
> +  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.16.1/codeql.zip",
> +  "version": "2.16.1",
> +  "sha256":
> "86a98f6ebb8fd49efadf367f3275c438669fcb8426962c33415129aad8e093e6",
>"compression_type": "zip",
>"internal_path": "/codeql/",
>"flags": ["set_shell_var", ],
> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> index a6ca5d0f34cc..5b4a919f1de4 100644
> --- a/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
> @@ -14,9 +14,9 @@
>"scope": "codeql-linux-ext-dep",
>"type": "web",
>"name": "codeql_linux_cli",
> -  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.14.5/codeql-linux64.zip",
> -  "version": "2.14.5",
> -  "sha256":
> "72aa5d748ff9ab57cfd86045560683bdc4897e0fe6d9f9a2786d9394674ae733",
> +  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.16.1/codeql-linux64.zip",
> +  "version": "2.16.1",
> +  "sha256":
> "40dbb6c0c4064bd14601a02e60c61661fdc0271469f90eb91a2e7d51d4cbc171",
>"compression_type": "zip",
>"internal_path": "/codeql/",
>"flags": ["set_shell_var", ],
> diff --git a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> index e706a7cabf9f..c0c018c9538f 100644
> --- a/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> +++ b/BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
> @@ -14,9 +14,9 @@
>"scope": "codeql-windows-ext-dep",
>"type": "web",
>"name": "codeql_windows_cli",
> -  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.14.5/codeql-win64.zip",
> -  "version": "2.14.5",
> -  "sha256":
> "861fcb38365cc311efee0c3a28c77494e93c69a969885b72e53173ad473f61aa",
> +  "source": "https://github.com/github/codeql-cli-
> binaries/releases/download/v2.16.1/codeql-win64.zip",
> +  "version": "2.16.1",
> +  "sha256":
> "9ebe5ea8a7d0a77425428d50d49912319117fccee24ecb62f6219c12584f4f28",
>"compression_type": "zip",
>"internal_path": "/codeql/",
>"flags": ["set_shell_var", ],
> --
> 2.44.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118228): https://edk2.groups.io/g/devel/message/118228
Mute This Topic: https://groups.io/mt/105714919/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch v3 1/1] ek2-libc: wrmsr function available in edk2module is not working as expected

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: Jayaprakash, N 
> Sent: Friday, April 19, 2024 2:01 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-libc Patch v3 1/1] ek2-libc: wrmsr function available
> in edk2module is not working as expected
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4745
> 
> This commit fixes the issue reported in the BZ4745.
> The wrmsr was always writing 0 to the higher 32 bits of the msr
> register.
> This was due to a logical flaw in the code, where the input variable
> of
> type unsigned int was left shitted by 32 bits without explicitly
> converting it to a 64 bit value.
> 
> The issue is with the below statement.
> data = vedx << 32 | veax;
> Where the vedx which is an unsigned int, after left shifting by 32
> bits
> its value will be set to 0. Because of this the higher 32 bits of the
> MSR
> are always set to 0. This has been fixed by this commit.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  .../Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c| 2
> +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python-
> 3.6.8/PyMod-3.6.8/Modules/edk2module.c
> index d6af8da..f688b51 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c
> +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c
> @@ -3886,7 +3886,7 @@ edk2_wrmsr(PyObject *self, PyObject *args)
>UINT64   data = 0;
>if (!PyArg_ParseTuple(args, "III", , , ))
>  return NULL;
> -  data = vedx << 32 | veax;
> +  data = LShiftU64(vedx, 32) | veax;
>Py_BEGIN_ALLOW_THREADS
>AsmWriteMsr64(vecx, data);
>Py_END_ALLOW_THREADS
> --
> 2.44.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118035): https://edk2.groups.io/g/devel/message/118035
Mute This Topic: https://groups.io/mt/105614477/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V3 6/6] Maintainers.txt: Update maintainer for SPI modules

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Chang,
> Abner via groups.io
> Sent: Friday, April 19, 2024 12:40 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Andrew Fish
> ; Leif Lindholm ; Attar,
> AbdulLateef (Abdul Lateef) ; Chesley, Brit
> ; Wang, Jian J ; Liming
> Gao ; Wu, Hao A ; Ni,
> Ray ; Liu, Zhiguang 
> Subject: Re: [edk2-devel] [PATCH V3 6/6] Maintainers.txt: Update
> maintainer for SPI modules
> 
> [AMD Official Use Only - General]
> 
> Hi edk2 stewards,
> Per off-line discussion with Ray Ni, he considers Liming's RB is good
> enough for this patch set. Please help to review this and give your RB
> to the maintainship of MdeModulePkg/Bus/Spi If you don't have
> concerns.
> 
> Thank you!
> Abner
> 
> 
> > -Original Message-
> > From: Chang, Abner
> > Sent: Thursday, April 11, 2024 9:38 AM
> > To: devel@edk2.groups.io
> > Cc: Michael D Kinney ; Andrew Fish
> > ; Leif Lindholm ; Attar,
> > AbdulLateef (Abdul Lateef) ; Chesley,
> Brit
> > ; Jian J Wang ; Liming
> Gao
> > ; Hao A Wu ; Ray Ni
> > ; Zhiguang Liu 
> > Subject: RE: [edk2-devel] [PATCH V3 6/6] Maintainers.txt: Update
> maintainer
> > for SPI modules
> >
> > Hi maintainers,
> > Please help to check this update as we added an entry for Bus\Spi
> under
> > MdeModulePkg.
> >
> > Thanks
> > Abner
> >
> > > -Original Message-
> > > From: devel@edk2.groups.io  On Behalf Of
> Chang,
> > > Abner via groups.io
> > > Sent: Sunday, August 13, 2023 12:37 PM
> > > To: devel@edk2.groups.io
> > > Cc: Michael D Kinney ; Andrew Fish
> > > ; Leif Lindholm ;
> Attar,
> > > AbdulLateef (Abdul Lateef) ; Chesley,
> Brit
> > > ; Jian J Wang ;
> Liming Gao
> > > ; Hao A Wu ; Ray Ni
> > > ; Zhiguang Liu 
> > > Subject: [edk2-devel] [PATCH V3 6/6] Maintainers.txt: Update
> maintainer for
> > > SPI modules
> > >
> > > Caution: This message originated from an External Source. Use
> proper
> > > caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > From: Abner Chang 
> > >
> > > Add maintainer entry of MdeModulePkg/Bus/Spi.
> > >
> > > Cc: Michael D Kinney 
> > > Cc: Andrew Fish 
> > > Cc: Leif Lindholm 
> > > Cc: Abdul Lateef Attar 
> > > Cc: Brit Chesley 
> > > Cc: Jian J Wang 
> > > Cc: Liming Gao 
> > > Cc: Hao A Wu 
> > > Cc: Ray Ni 
> > > Cc: Zhiguang Liu 
> > > Signed-off-by: Abner Chang 
> > > ---
> > >  Maintainers.txt | 5 +
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/Maintainers.txt b/Maintainers.txt
> > > index 5a95929a14b..a6a5a9b4e03 100644
> > > --- a/Maintainers.txt
> > > +++ b/Maintainers.txt
> > > @@ -443,6 +443,11 @@ F:
> > > MdeModulePkg/Include/Protocol/UsbEthernetProtocol.h
> > >  M: Richard Ho  [richardho]
> > >  R: Rebecca Cran  [bcran]
> > >
> > > +MdeModulePkg: SPI Bus modules
> > > +F: MdeModulePkg/Bus/Spi
> > > +M: Abner Chang  [changab]
> > > +R: Brit Chesley  [BritChesley]
> > > +
> > >  MdePkg
> > >  F: MdePkg/
> > >  W: https://github.com/tianocore/tianocore.github.io/wiki/MdePkg
> > > --
> > > 2.37.1.windows.1
> > >
> > >
> > >
> > >
> > >
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118034): https://edk2.groups.io/g/devel/message/118034
Mute This Topic: https://groups.io/mt/105455146/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 2 1/1] ek2-libc: wrmsr function available in edk2module is not working as expected

[Michael D Kinney]

The use of BitFieldOr64() is really only required when updating
a portion of a 32-bit or 64-bit value that are not aligned on
a 32-bit boundary and do not have a 32-bit aligned width.  Since
this use case is setting the lower 32-bits, simpler logic should
be used.

  data = LShiftU64(vedx, 32) | veax;

Mike

> -Original Message-
> From: Jayaprakash, N 
> Sent: Thursday, April 18, 2024 5:55 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-libc Patch 2 1/1] ek2-libc: wrmsr function available in
> edk2module is not working as expected
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4745
> 
> This commit fixes the issue reported in the BZ4745.
> The wrmsr was always writing 0 to the higher 32 bits of the msr
> register.
> This was due to a logical flaw in the code, where the input variable
> of
> type unsigned int was left shitted by 32 bits without explicitly
> converting it to a 64 bit value.
> 
> The issue is with the below statement.
> data = vedx << 32 | veax;
> Where the vedx which is an unsigned int, after left shifting by 32
> bits
> its value will be set to 0. Because of this the higher 32 bits of the
> MSR
> are always set to 0. This has been fixed by this commit.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  .../Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c   | 3
> ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python-
> 3.6.8/PyMod-3.6.8/Modules/edk2module.c
> index 8786df8..06bcf82 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c
> +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c
> @@ -3886,7 +3886,8 @@ edk2_wrmsr(PyObject *self, PyObject *args)
>UINT64   data = 0;
>if (!PyArg_ParseTuple(args, "III", , , ))
>  return NULL;
> -  data = vedx << 32 | veax;
> +  data = LShiftU64(vedx, 32);
> +  data = BitFieldOr64(data, 0, 31, veax);
>Py_BEGIN_ALLOW_THREADS
>AsmWriteMsr64(vecx, data);
>Py_END_ALLOW_THREADS
> --
> 2.44.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117999): https://edk2.groups.io/g/devel/message/117999
Mute This Topic: https://groups.io/mt/105597214/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

[Michael D Kinney]

Please use MP Services Protocol APIs StartupAllAPs() or StarupThisAP() 
to read/write MSRs on other logical processors.

There and many examples of this in the UefiCpuPkg to programming MSRs
on all the logical processors.

Mike

> -Original Message-
> From: Jayaprakash, N 
> Sent: Wednesday, April 17, 2024 8:16 PM
> To: Kinney, Michael D ;
> devel@edk2.groups.io
> Cc: Rebecca Cran 
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex
> & wrmsr_ex functions to read/write cpu specific msrs
> 
> In the validation and debug scenarios, engineers tend to read MSRs and
> write to MSRs of different CPUs.
> So we are providing a simple mechanism through these APIs to enable
> them to do these operations.
> 
> These APIs will be part of the edk2 module of the Python interpreter
> and will be used during the validation and debug scenarios only.
> 
> This is not for switching the BSP for OS boot. This is only used
> during the validation and debug use cases.
> 
> Regards,
> JP
> -Original Message-
> From: Kinney, Michael D 
> Sent: Thursday, April 18, 2024 12:08 AM
> To: Jayaprakash, N ; devel@edk2.groups.io
> Cc: Rebecca Cran ; Kinney, Michael D
> 
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex
> & wrmsr_ex functions to read/write cpu specific msrs
> 
> Hi JP,
> 
> Is there a reason switch BSP is being used.  That is not a common
> operation and is typically used if the current BSP is not stable or
> there is a good reason to switch the BSP for OS boot.
> 
> The MP Services can be used to execute a C function on APs to execute
> MSR related instructions.
> 
> Mike
> 
> > -Original Message-
> > From: Jayaprakash, N 
> > Sent: Sunday, April 14, 2024 10:33 PM
> > To: devel@edk2.groups.io; Jayaprakash, N 
> > Cc: Rebecca Cran ; Kinney, Michael D
> > 
> > Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add
> rdmsr_ex
> > & wrmsr_ex functions to read/write cpu specific msrs
> >
> > + Rebecca and Mike,
> >
> > Would you be able to review this PR?
> >
> > Regards,
> > JP
> >
> > -Original Message-
> > From: devel@edk2.groups.io  On Behalf Of
> > Jayaprakash, N
> > Sent: Wednesday, April 10, 2024 11:49 AM
> > To: devel@edk2.groups.io
> > Cc: Jayaprakash, N ; Rebecca Cran
> > ; Kinney, Michael D 
> > Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex &
> > wrmsr_ex functions to read/write cpu specific msrs
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746
> >
> > The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr
> > APIs supported in edk2 module. These extension APIs makes it
> possible
> > to read / write MSRs from specific processors and fills an existing
> > gap in this area.
> >
> > Cc: Rebecca Cran 
> > Cc: Michael D Kinney 
> > Cc: Jayaprakash N 
> > Signed-off-by: Jayaprakash N 
> > ---
> >  .../PyMod-3.6.8/Modules/edk2module.c  | 159
> > +-
> >  .../Python/Python-3.6.8/Python368.inf |   3 +
> >  2 files changed, 158 insertions(+), 4 deletions(-)
> >
> > diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> > 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python-
> > 3.6.8/PyMod-3.6.8/Modules/edk2module.c
> > index d6af8da..f1b13a6 100644
> > --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> > 3.6.8/Modules/edk2module.c
> > +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> > 3.6.8/Modules/edk2mo
> > +++ dule.c
> > @@ -3,7 +3,7 @@
> >  Derived from posixmodule.c in Python 2.7.2.
> >
> >  Copyright (c) 2015, Daryl McDaniel. All rights reserved.
> > -Copyright (c) 2011 - 2023, Intel Corporation. All rights
> > reserved.
> > +Copyright (c) 2011 - 2024, Intel Corporation. All rights
> > + reserved.
> >  This program and the accompanying materials are licensed and
> made
> > available under
> >  the terms and conditions of the BSD License that accompanies
> this
> > distribution.
> >  The full text of the license may be found at @@ -22,16 +22,23
> @@
> > #include#include#include  
> > +#include// Needed for the definition of
> > EFI_AP_PROCEDURE
> >  #include  
> >  #include  
> >  #include  
> >  #include  
> > +#include  
> > +#include  
> >
> >  #ifdef __cplusplus
> >  extern "C" {
> >  #endif
> >
> >  PyTypeObject EfiGuidType;
> > +EFI_MP_S

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex & wrmsr_ex functions to read/write cpu specific msrs

[Michael D Kinney]

Hi JP,

Is there a reason switch BSP is being used.  That is not a common operation
and is typically used if the current BSP is not stable or there is a good
reason to switch the BSP for OS boot.

The MP Services can be used to execute a C function on APs to execute
MSR related instructions.

Mike

> -Original Message-
> From: Jayaprakash, N 
> Sent: Sunday, April 14, 2024 10:33 PM
> To: devel@edk2.groups.io; Jayaprakash, N 
> Cc: Rebecca Cran ; Kinney, Michael D
> 
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex
> & wrmsr_ex functions to read/write cpu specific msrs
> 
> + Rebecca and Mike,
> 
> Would you be able to review this PR?
> 
> Regards,
> JP
> 
> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of
> Jayaprakash, N
> Sent: Wednesday, April 10, 2024 11:49 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc:add rdmsr_ex &
> wrmsr_ex functions to read/write cpu specific msrs
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4746
> 
> The rdmsr_ex and wrmsr_ex are extension APIs to the rdmsr and wrmsr
> APIs supported in edk2 module. These extension APIs makes it possible
> to read / write MSRs from specific processors and fills an existing
> gap in this area.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  .../PyMod-3.6.8/Modules/edk2module.c  | 159
> +-
>  .../Python/Python-3.6.8/Python368.inf |   3 +
>  2 files changed, 158 insertions(+), 4 deletions(-)
> 
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python-
> 3.6.8/PyMod-3.6.8/Modules/edk2module.c
> index d6af8da..f1b13a6 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c
> +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2mo
> +++ dule.c
> @@ -3,7 +3,7 @@
>  Derived from posixmodule.c in Python 2.7.2.
> 
>  Copyright (c) 2015, Daryl McDaniel. All rights reserved.
> -Copyright (c) 2011 - 2023, Intel Corporation. All rights
> reserved.
> +Copyright (c) 2011 - 2024, Intel Corporation. All rights
> + reserved.
>  This program and the accompanying materials are licensed and made
> available under
>  the terms and conditions of the BSD License that accompanies this
> distribution.
>  The full text of the license may be found at @@ -22,16 +22,23 @@
> #include#include#include  
> +#include// Needed for the definition of
> EFI_AP_PROCEDURE
>  #include  
>  #include  
>  #include  
>  #include  
> +#include  
> +#include  
> 
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> 
>  PyTypeObject EfiGuidType;
> +EFI_MP_SERVICES_PROTOCOL   *gpMpService = NULL;
> +UINTN   gBSPProcessorNumber = 0;
> +UINTN   gNumberOfProcessors = 0;
> +UINTN   gNumberOfEnabledProcessors = 0;
> 
>  extern void _swsmi( unsigned int smi_code_data, unsigned int
> rax_value, unsigned int rbx_value, unsigned int rcx_value, unsigned
> int rdx_value, unsigned int rsi_value, unsigned int rdi_value );  // -
> - Support routines @@ -169,6 +176,35 @@ PyDoc_STRVAR(edk2__doc__,
>  /* dummy version. _PyVerify_fd() is already defined in fileobject.h
> */  #define _PyVerify_fd_dup2(A, B) (1)
> 
> +static EFI_STATUS
> +MpServicesWhoAmI (
> +  IN EFI_MP_SERVICES_PROTOCOL  *pMpService,
> +  OUT UINTN*pProcessorNumber
> +  )
> +{
> +  return pMpService->WhoAmI (pMpService, pProcessorNumber); }
> +
> +static EFI_STATUS
> +MpServicesGetNumberOfProcessors (
> +  IN EFI_MP_SERVICES_PROTOCOL  *pMpService,
> +  OUT UINTN*pNumberOfProcessors,
> +  OUT UINTN*pNumberOfEnabledProcessors
> +
> +  )
> +{
> +  return pMpService->GetNumberOfProcessors (pMpService,
> +pNumberOfProcessors, pNumberOfEnabledProcessors); }
> +
> +static EFI_STATUS
> +MpServicesSwitchBSP (
> +  IN EFI_MP_SERVICES_PROTOCOL  *pMpService,
> +  IN UINTN  ProcessorNumber
> +  )
> +{
> +  return pMpService->SwitchBSP(pMpService,  ProcessorNumber, TRUE); }
> +
>  #ifndef UEFI_C_SOURCE
>  /* Return a dictionary corresponding to the POSIX environment table
> */  extern char **environ; @@ -3865,6 +3901,56 @@ edk2_rdmsr(PyObject
> *self, PyObject *args)
>return Py_BuildValue("(II)", (unsigned long)veax, (unsigned
> long)vedx);  }
> 
> +PyDoc_STRVAR(efi_rdmsr_ex__doc__,
> 

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: wrmsr function available in edk2module is not working as expected

[Michael D Kinney]

> -Original Message-
> From: Jayaprakash, N 
> Sent: Tuesday, April 9, 2024 11:09 PM
> To: devel@edk2.groups.io; Jayaprakash, N 
> Cc: Rebecca Cran ; Kinney, Michael D
> 
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: wrmsr
> function available in edk2module is not working as expected
> 
> Reviewed-by : Jayaprakash N
> 
> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of
> Jayaprakash, N
> Sent: Thursday, April 4, 2024 3:14 PM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D 
> Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: wrmsr function
> available in edk2module is not working as expected
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4745
> 
> This commit fixes the issue reported in the BZ4745.
> The wrmsr function was always writing 0 to the higher 32 bits of the
> msr register. This was due to a logical flaw in the code, where the
> input variable of type unsigned int was left shitted by 32 bits
> without explicitly converting to a 64 bit value.
> 
> Problematic statement in the function edk2_wrmsr code:
> data = vedx << 32 | veax;
> Where the vedx an unsigned int, after left shifting by 32 bits its
> value will be set to 0. Because of this the higher 32 bits of the MSR
> are always set to 0. This statement has been modified as below:
>   data = (((UINT64)vedx) << 32) | veax;
> Verified the function by making this change and could see that the
> wrmsr is working as expected.
> 
> Cc: Rebecca Cran 
> Cc: Michael D Kinney 
> Cc: Jayaprakash N 
> Signed-off-by: Jayaprakash N 
> ---
>  .../Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c| 2
> +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python-
> 3.6.8/PyMod-3.6.8/Modules/edk2module.c
> index d6af8da..cec4332 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2module.c
> +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-
> 3.6.8/Modules/edk2mo
> +++ dule.c
> @@ -3886,7 +3886,7 @@ edk2_wrmsr(PyObject *self, PyObject *args)
>UINT64   data = 0;
>if (!PyArg_ParseTuple(args, "III", , , ))
>  return NULL;
> -  data = vedx << 32 | veax;
> +  data = (((UINT64)vedx) << 32) | veax;

On 32-bit builds, this will use an intrinsic.  Is BaseLib LShiftU64() available 
here?

>Py_BEGIN_ALLOW_THREADS
>AsmWriteMsr64(vecx, data);
>Py_END_ALLOW_THREADS
> --
> 2.40.0.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117929): https://edk2.groups.io/g/devel/message/117929
Mute This Topic: https://groups.io/mt/105437258/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe: Update UI according to UEFI spec

[Michael D Kinney]

Merged: https://github.com/tianocore/edk2/pull/5487



> -Original Message-
> From: Kinney, Michael D 
> Sent: Monday, April 15, 2024 10:32 PM
> To: devel@edk2.groups.io; Clark-williams, Zachary  willi...@intel.com>; Tan, Ming 
> Cc: Kasbekar, Saloni ; Bi, Dandan
> ; POLUDOV, FELIX ; Liu, Liqi
> ; Kinney, Michael D 
> Subject: RE: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe:
> Update UI according to UEFI spec
> 
> Acked-by: Michael D Kinney 
> 
> 
> > -Original Message-
> > From: devel@edk2.groups.io  On Behalf Of
> Clark-
> > williams, Zachary
> > Sent: Wednesday, April 10, 2024 9:03 AM
> > To: Tan, Ming ; devel@edk2.groups.io
> > Cc: Kasbekar, Saloni ; Bi, Dandan
> > ; POLUDOV, FELIX ; Liu, Liqi
> > 
> > Subject: Re: [edk2-devel] [PATCH]
> NetworkPkg/WifiConnectionManagerDxe:
> > Update UI according to UEFI spec
> >
> > Reviewed-by: Zachary Clark-Williams  willi...@intel.com>
> >
> > -Original Message-
> > From: Tan, Ming 
> > Sent: Thursday, March 21, 2024 6:16 PM
> > To: devel@edk2.groups.io
> > Cc: Kasbekar, Saloni ; Clark-williams,
> > Zachary ; Bi, Dandan
> > ; POLUDOV, FELIX ; Liu, Liqi
> > 
> > Subject: [PATCH] NetworkPkg/WifiConnectionManagerDxe: Update UI
> > according to UEFI spec
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4736
> >
> > In UEFI_Spec_2_10_Aug29.pdf page 1694 section 35.5.4 for
> > EFI_BROWSER_ACTION_FORM_OPEN:
> > NOTE: EFI_FORM_BROWSER2_PROTOCOL.BrowserCallback() cannot be used
> with
> > this browser action because question values have not been retrieved
> > yet.
> >
> > So should not call HiiGetBrowserData() and HiiSetBrowserData() in
> > FORM_OPEN call back function.
> >
> > Now use wifi list key and enroll cert key instead of the connect
> > action key, move wifi info display from open action to close action.
> >
> > Cc: Saloni Kasbekar 
> > Cc: Zachary Clark-williams 
> > Cc: Dandan Bi 
> > Cc: Felix Polyudov 
> > Signed-off-by: Liqi Liu 
> > Signed-off-by: Ming Tan 
> > ---
> >   PR: https://github.com/tianocore/edk2/pull/5487
> >
> >  .../WifiConnectionMgrHiiConfigAccess.c| 113 ---
> --
> > -
> >  1 file changed, 74 insertions(+), 39 deletions(-)
> >
> > diff --git
> >
> a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess
> > .c
> >
> b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess
> > .c
> > index 431fcbb33a..f242bdf056 100644
> > ---
> >
> a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess
> > .c
> > +++
> > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAcce
> > +++ ss.c
> > @@ -1412,7 +1412,9 @@ WifiMgrDxeHiiConfigAccessCallback (
> >  return EFI_OUT_OF_RESOURCES;   } -  HiiGetBrowserData
> > (, mVendorStorageName, BufferSize, (UINT8
> > *)IfrNvData);+  if (Action != EFI_BROWSER_ACTION_FORM_OPEN) {+
> > HiiGetBrowserData (, mVendorStorageName,
> > BufferSize, (UINT8 *)IfrNvData);+  }if (Action ==
> > EFI_BROWSER_ACTION_FORM_OPEN) { switch (QuestionId) {@@ -1438,43
> > +1440,6 @@ WifiMgrDxeHiiConfigAccessCallback (
> >   break; -  case KEY_CONNECT_ACTION:--if
> (Private-
> > >CurrentNic->UserSelectedProfile == NULL) {-  break;-
> > }--Profile = Private->CurrentNic->UserSelectedProfile;--
> > //-// Enter the network connection configuration page-
> > // Recovery from restored data-//-if (HiiSetString
> > (Private->RegisteredHandle, STRING_TOKEN (STR_SSID), Profile->SSId,
> > NULL) == 0) {-  return EFI_OUT_OF_RESOURCES;-}--
> > IfrNvData->SecurityType = Profile->SecurityType;-if
> > (HiiSetString (-  Private->RegisteredHandle,-
> > STRING_TOKEN (STR_SECURITY_TYPE),-
> > mSecurityType[IfrNvData->SecurityType],-  NULL-
> > ) == 0)-{-  return EFI_OUT_OF_RESOURCES;-}--
> > if ((IfrNvData->SecurityType == SECURITY_TYPE_WPA2_ENTERPRISE) ||-
> > (IfrNvData->SecurityType == SECURITY_TYPE_WPA3_ENTERPRISE))-
> {-
> > IfrNvData->EapAuthMethod   = Profile->EapAuthMethod;-
> > IfrNvData->EapSecondAuthMethod = Profile->EapSecondAuthMethod;-
> > StrCpyS (IfrNvData->EapIdentity, EAP_IDENTITY_SIZE, Profile-
> > >EapIdentity);-}--break;-   case
> > KEY_ENROLLED_CERT_NAME:  if (Private->Cu

Re: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe: Update UI according to UEFI spec

[Michael D Kinney]

Acked-by: Michael D Kinney 


> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Clark-
> williams, Zachary
> Sent: Wednesday, April 10, 2024 9:03 AM
> To: Tan, Ming ; devel@edk2.groups.io
> Cc: Kasbekar, Saloni ; Bi, Dandan
> ; POLUDOV, FELIX ; Liu, Liqi
> 
> Subject: Re: [edk2-devel] [PATCH] NetworkPkg/WifiConnectionManagerDxe:
> Update UI according to UEFI spec
> 
> Reviewed-by: Zachary Clark-Williams 
> 
> -Original Message-
> From: Tan, Ming 
> Sent: Thursday, March 21, 2024 6:16 PM
> To: devel@edk2.groups.io
> Cc: Kasbekar, Saloni ; Clark-williams,
> Zachary ; Bi, Dandan
> ; POLUDOV, FELIX ; Liu, Liqi
> 
> Subject: [PATCH] NetworkPkg/WifiConnectionManagerDxe: Update UI
> according to UEFI spec
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4736
> 
> In UEFI_Spec_2_10_Aug29.pdf page 1694 section 35.5.4 for
> EFI_BROWSER_ACTION_FORM_OPEN:
> NOTE: EFI_FORM_BROWSER2_PROTOCOL.BrowserCallback() cannot be used with
> this browser action because question values have not been retrieved
> yet.
> 
> So should not call HiiGetBrowserData() and HiiSetBrowserData() in
> FORM_OPEN call back function.
> 
> Now use wifi list key and enroll cert key instead of the connect
> action key, move wifi info display from open action to close action.
> 
> Cc: Saloni Kasbekar 
> Cc: Zachary Clark-williams 
> Cc: Dandan Bi 
> Cc: Felix Polyudov 
> Signed-off-by: Liqi Liu 
> Signed-off-by: Ming Tan 
> ---
>   PR: https://github.com/tianocore/edk2/pull/5487
> 
>  .../WifiConnectionMgrHiiConfigAccess.c| 113 -
> -
>  1 file changed, 74 insertions(+), 39 deletions(-)
> 
> diff --git
> a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess
> .c
> b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess
> .c
> index 431fcbb33a..f242bdf056 100644
> ---
> a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess
> .c
> +++
> b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAcce
> +++ ss.c
> @@ -1412,7 +1412,9 @@ WifiMgrDxeHiiConfigAccessCallback (
>  return EFI_OUT_OF_RESOURCES;   } -  HiiGetBrowserData
> (, mVendorStorageName, BufferSize, (UINT8
> *)IfrNvData);+  if (Action != EFI_BROWSER_ACTION_FORM_OPEN) {+
> HiiGetBrowserData (, mVendorStorageName,
> BufferSize, (UINT8 *)IfrNvData);+  }if (Action ==
> EFI_BROWSER_ACTION_FORM_OPEN) { switch (QuestionId) {@@ -1438,43
> +1440,6 @@ WifiMgrDxeHiiConfigAccessCallback (
>   break; -  case KEY_CONNECT_ACTION:--if (Private-
> >CurrentNic->UserSelectedProfile == NULL) {-  break;-
> }--Profile = Private->CurrentNic->UserSelectedProfile;--
> //-// Enter the network connection configuration page-
> // Recovery from restored data-//-if (HiiSetString
> (Private->RegisteredHandle, STRING_TOKEN (STR_SSID), Profile->SSId,
> NULL) == 0) {-  return EFI_OUT_OF_RESOURCES;-}--
> IfrNvData->SecurityType = Profile->SecurityType;-if
> (HiiSetString (-  Private->RegisteredHandle,-
> STRING_TOKEN (STR_SECURITY_TYPE),-
> mSecurityType[IfrNvData->SecurityType],-  NULL-
> ) == 0)-{-  return EFI_OUT_OF_RESOURCES;-}--
> if ((IfrNvData->SecurityType == SECURITY_TYPE_WPA2_ENTERPRISE) ||-
> (IfrNvData->SecurityType == SECURITY_TYPE_WPA3_ENTERPRISE))-{-
> IfrNvData->EapAuthMethod   = Profile->EapAuthMethod;-
> IfrNvData->EapSecondAuthMethod = Profile->EapSecondAuthMethod;-
> StrCpyS (IfrNvData->EapIdentity, EAP_IDENTITY_SIZE, Profile-
> >EapIdentity);-}--break;-   case
> KEY_ENROLLED_CERT_NAME:  if (Private->CurrentNic-
> >UserSelectedProfile == NULL) {@@ -1524,6 +1489,43 @@
> WifiMgrDxeHiiConfigAccessCallback (
>  }   } else if (Action == EFI_BROWSER_ACTION_FORM_CLOSE) {
> switch (QuestionId) {+  case KEY_EAP_ENROLL_CERT_FROM_FILE:++
> if (Private->CurrentNic->UserSelectedProfile == NULL) {+
> break;+}++Profile = Private->CurrentNic-
> >UserSelectedProfile;++//+// Enter the network
> connection configuration page+// Recovery from restored data+
> //+if (HiiSetString (Private->RegisteredHandle, STRING_TOKEN
> (STR_SSID), Profile->SSId, NULL) == 0) {+  return
> EFI_OUT_OF_RESOURCES;+}++IfrNvData->SecurityType =
> Profile->SecurityType;+if (HiiSetString (+
> Private->RegisteredHandle,+  STRING_TOKEN
> (STR_SECURITY_TYPE),+  mSecurityType[IfrNvData-
> >SecurityType],+  NULL+  ) == 0

Re: [edk2-devel] [PATCH 0/9] Add DeviceSecurity feature based on PFP 1.06 spec

[Michael D Kinney]

+Leif

Adding a new submodule requires review by the stewards to review
the license and the health and support of the submodule project.

The top level Readme also requires updates.  It lists all the submodules
and licenses used. Please update this series with the Readme changes.

https://github.com/tianocore/edk2?tab=readme-ov-file#license-details

I also notice that libspdm has its own .gitmodules file that pulls
in more submodules.

[submodule "os_stub/openssllib/openssl"]
path = os_stub/openssllib/openssl
url = https://github.com/openssl/openssl
[submodule "os_stub/mbedtlslib/mbedtls"]
path = os_stub/mbedtlslib/mbedtls
url = https://github.com/ARMmbed/mbedtls
[submodule "unit_test/cmockalib/cmocka"]
path = unit_test/cmockalib/cmocka
url = https://git.cryptomilk.org/projects/cmocka.git


edk2 already had openssl and mbedtls as submodules, does this mean that
openssl and mbedtls will be cloned twice in 2 different locations now?

The edk2 project had issues with the stability of the cmocka server
and changed to a tianocore mirror of the cmocka submodule to improve
CI stability. This is another submodule that will be cloned twice and
may reintroduce the potential for CI stability issues.

Thanks,

Mike

> -Original Message-
> From: Hou, Wenxing 
> Sent: Monday, April 1, 2024 7:31 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Joey Vagedes
> ; Kinney, Michael D
> ; Liming Gao ;
> Andrew Fish ; Liu, Zhiguang ;
> Kumar, Rahul R ; Yao, Jiewen
> 
> Subject: [PATCH 0/9] Add DeviceSecurity feature based on PFP 1.06 spec
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2479
> 
> In PFP spec 1.06, platform firmware records the device certificate and
> device measurement for each SPDM responder.
> This PATCH set implement the DeviceSecurityLib to support spdm device
> Authentication and Measurement.
> 
> Libspdm as submodule is to support DeviceSecurity feature:
> https://github.com/DMTF/libspdm
> 
> TCG PFP spec 1.06:
> https://trustedcomputinggroup.org/resource/pc-client-specific-
> platform-firmware-profile-specification/
> 
> The POC branch:
> https://github.com/tianocore/edk2-staging/tree/DeviceSecurity
> 
> And the PATCH set has passed the EDKII CI:
> https://github.com/tianocore/edk2/pull/5508
> 
> Cc: Sean Brogan 
> Cc: Joey Vagedes 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Andrew Fish 
> Cc: Zhiguang Liu 
> Cc: Rahul Kumar 
> Cc: Jiewen Yao 
> Signed-off-by: Wenxing Hou 
> 
> Wenxing Hou (9):
>   MdePkg: Add SPDM1.2 support.
>   MdePkg: Add TCG PFP 1.06 support.
>   MdePkg: Add devAuthBoot GlobalVariable
>   MdeModulePkg/Variable: Add TCG SPDM device measurement update
>   SecurityPkg: Add TCG PFP 1.06 support.
>   SecurityPkg: add DeviceSecurity support
>   .pytool/CISettings.py: add libspdm submodule.
>   .gitmodule: Add libspdm submodule for EDKII
>   SecurityPkg: Add libspdm submodule
> 
>  .gitmodules   |3 +
>  .pytool/CISettings.py |2 +
>  MdeModulePkg/MdeModulePkg.dec |5 +
>  .../Variable/RuntimeDxe/Measurement.c |   38 +-
>  .../RuntimeDxe/VariableRuntimeDxe.inf |3 +
>  .../RuntimeDxe/VariableSmmRuntimeDxe.inf  |3 +
>  MdePkg/Include/Guid/GlobalVariable.h  |8 +-
>  MdePkg/Include/Guid/ImageAuthentication.h |5 +-
>  MdePkg/Include/IndustryStandard/Spdm.h| 1112
> -
>  .../IndustryStandard/UefiTcgPlatform.h|  186 ++-
>  .../OsStub/CryptlibWrapper/CryptlibWrapper.c  |  970 ++
>  .../CryptlibWrapper/CryptlibWrapper.inf   |   38 +
>  .../OsStub/MemLibWrapper/MemLibWrapper.c  |  177 +++
>  .../OsStub/MemLibWrapper/MemLibWrapper.inf|   33 +
>  .../PlatformLibWrapper/PlatformLibWrapper.c   |   85 ++
>  .../PlatformLibWrapper/PlatformLibWrapper.inf |   33 +
>  .../SpdmLib/Include/Stub/SpdmLibStub.h|  347 +
>  .../SpdmLib/Include/hal/LibspdmStdBoolAlt.h   |   23 +
>  .../SpdmLib/Include/hal/LibspdmStdDefAlt.h|   16 +
>  .../SpdmLib/Include/hal/LibspdmStdIntAlt.h|   25 +
>  .../DeviceSecurity/SpdmLib/Include/hal/base.h |   94 ++
>  .../SpdmLib/Include/hal/library/debuglib.h|   39 +
>  .../SpdmLib/Include/library/spdm_lib_config.h |  394 ++
>  .../DeviceSecurity/SpdmLib/SpdmCommonLib.inf  |   47 +
>  .../DeviceSecurity/SpdmLib/SpdmCryptLib.inf   |   45 +
>  .../SpdmLib/SpdmDeviceSecretLibNull.inf   |   36 +
>  .../SpdmLib/SpdmRequesterLib.inf  |   59 +
>  .../SpdmLib/SpdmResponderLib.inf  |   61 +
>  .../SpdmLib/SpdmSecuredMessageLib.inf |   44 +
>  .../SpdmLib/SpdmTransportMctpLib.inf  |   38 +
>  .../SpdmLib/Spd

Re: [edk2-devel] Call or topics for April TianoCore Community Meeting

[Michael D Kinney]

MdeModulePkg has many different reviewers for different subsets.

We should also consider seeing if any of those reviewers that
are responsible for different subsets of MdeModulePkg would be 
willing to be a backup maintainer for the MdeModulePkg.

Zhiguang Liu  [LiuZhiguang001]
Dandan Bi  [dandanbi]
Zhichao Gao  [ZhichaoGao]
Ray Ni  [niruiyu]
Jiaxin Wu  [jiaxinwu]
Star Zeng  [lzeng14]
Gua Guo  [gguo11837463]
Prakashan Krishnadas Veliyathuparambil 
 [kprakas2]
K N Karthik  [karthikkabbigere1]
Richard Ho  [richardho]
Rebecca Cran  [bcran]
Abdul Lateef Attar  [abdattar]
Nickle Wang  [nicklela]

Mike

> -Original Message-
> From: Oliver Smith-Denny 
> Sent: Wednesday, April 3, 2024 3:02 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> ; Ard Biesheuvel 
> Subject: Re: [edk2-devel] Call or topics for April TianoCore Community
> Meeting
> 
> On 4/3/2024 1:38 PM, Michael D Kinney wrote:
> > Hi Oliver,
> >
> > I missed this response.  Did not show up in thread for some reason.
> 
> No worries.
> 
> >
> > But we can continue these topics on email.
> >
> > The TianoCore roles and responsibilities are documented here:
> >
> > https://github.com/tianocore/tianocore.github.io/wiki/TianoCore-
> Who-we-are
> >
> > If there are maintainers are not following their responsibilities,
> then
> > please let us know and we can work together to find additional
> maintainers.
> 
> Thanks, as I've mentioned in several of my last patches to
> MdeModulePkg,
> I think we need an additional top level maintainer there who is
> currently active. Liming has obviously been a huge part of edk2, but
> has
> many roles and has been quiet on MdeModulePkg patches for over a
> month.
> His input is greatly valued, but it seems he could use some help
> maintaining the package so we can keep up developer flow, I had
> multiple
> patches that contained items such as fixes for UEFI spec violations
> and
> boot breaks that were sitting with multiple reviews that were not
> getting the maintainer review and merging in.
> 
> I think it would be very valuable to have a second MdeModulePkg top
> level maintainer in any case, this covers areas such as DxeCore that
> are some of the most central and complex parts of the code base and
> bugs there need immediate resolution.
> 
> I don't want to put him on the spot, but I would be tempted to
> nominate Ard, if he wants the added responsibility, as he is very
> knowledgeable in UEFI and one of the few people who actively reviews
> patches closely and timely. If he does not want the additional
> maintenance burden, then I would ask the stewards to help find
> a community member to take on this role with Liming.
> 
> >
> > There is not much progress on PR process.  We need resources to work
> on the
> > list of action items documented here:
> >
> > https://github.com/orgs/tianocore/projects/5
> 
> Thanks for this pointer, I know the majority of active community
> members report in many different forums that moving to PRs is
> critical and I am confident that as a community we can make this
> happen.
> 
> Thanks,
> Oliver


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117396): https://edk2.groups.io/g/devel/message/117396
Mute This Topic: https://groups.io/mt/105299780/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Call or topics for April TianoCore Community Meeting

[Michael D Kinney]

Hi Oliver,

I missed this response.  Did not show up in thread for some reason.

But we can continue these topics on email.

The TianoCore roles and responsibilities are documented here:


https://github.com/tianocore/tianocore.github.io/wiki/TianoCore-Who-we-are

If there are maintainers are not following their responsibilities, then
please let us know and we can work together to find additional maintainers.

There is not much progress on PR process.  We need resources to work on the
list of action items documented here:

https://github.com/orgs/tianocore/projects/5

Mike

> -Original Message-
> From: Oliver Smith-Denny 
> Sent: Wednesday, April 3, 2024 10:25 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> 
> Subject: Re: [edk2-devel] Call or topics for April TianoCore Community
> Meeting
> 
> Hi Mike,
> 
> My two topics would be PRs and lack of maintainer response, the proper
> process there, etc.
> 
> Thanks,
> Oliver
> 
> On 4/2/2024 5:12 PM, Michael D Kinney wrote:
> > Please let me know if you have any topics for the TianoCore
> Community
> > Meeting this month.
> >
> > Thanks,
> >
> > Mike
> >
> >
> >
> >
> >
> > 
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117389): https://edk2.groups.io/g/devel/message/117389
Mute This Topic: https://groups.io/mt/105299780/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Call or topics for April TianoCore Community Meeting

[Michael D Kinney]

No topics received.  Meeting canceled this month.

Mike

> -Original Message-
> From: Kinney, Michael D 
> Sent: Tuesday, April 2, 2024 5:12 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D 
> Subject: Call or topics for April TianoCore Community Meeting
> 
> Please let me know if you have any topics for the TianoCore Community
> Meeting this month.
> 
> Thanks,
> 
> Mike
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117386): https://edk2.groups.io/g/devel/message/117386
Mute This Topic: https://groups.io/mt/105299780/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Question] using Flexible Array Member in Structure.

[Michael D Kinney]

Yes.  Use of flexible array members is supported and encouraged.

There are challenges with existing structure definitions that declare
arrays of size [1] when a flexible array is really intended. Those 
were defined before flexible array members were supported by all the
compilers.  Converting these to a flexible array member would not be
a backwards compatible change.

Mike

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of
> levi.yun
> Sent: Wednesday, April 3, 2024 2:27 AM
> To: devel@edk2.groups.io
> Cc: n...@arm.com; sami.muja...@arm.com
> Subject: [edk2-devel] [Question] using Flexible Array Member in
> Structure.
> 
> Hello all!
> 
> while I see the code. I have one question related using Flexible Array
> Member.
> 
> For example)
> 
> ///
> /// Socket Type Data.
> ///
> typedef struct {
>    EFI_ACPI_6_4_PMTT_COMMON_MEMORY_DEVICE CommonMemoryDeviceHeader;
>    UINT16 SocketIdentifier;
>    UINT16 Reserved;
>    // EFI_ACPI_6_4_PMTT_COMMON_MEMORY_DEVICE MemoryDeviceStructure[];
> } EFI_ACPI_6_4_PMTT_SOCKET_TYPE_DATA;
> 
> In here, why MemoryDeviceStructure should remain with comments?
> 
> IIUC, edk2 coding style guide doesn't seem to prevent use of Flexible
> Array Member which is C99 standard.
> 
> And consider the compiler used to compile edk2 uses defaults standard
> above of C99 standard.
> 
> Couldn't I use the flexible array member like:
> 
> ///
> /// Socket Type Data.
> ///
> typedef struct {
>    EFI_ACPI_6_4_PMTT_COMMON_MEMORY_DEVICE CommonMemoryDeviceHeader;
>    UINT16 SocketIdentifier;
>    UINT16 Reserved;
>    EFI_ACPI_6_4_PMTT_COMMON_MEMORY_DEVICE  MemoryDeviceStructure[]
> }
> 
> Thanks!
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117373): https://edk2.groups.io/g/devel/message/117373
Mute This Topic: https://groups.io/mt/105305209/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Call or topics for April TianoCore Community Meeting

[Michael D Kinney]

Please let me know if you have any topics for the TianoCore Community
Meeting this month.

Thanks,

Mike





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117339): https://edk2.groups.io/g/devel/message/117339
Mute This Topic: https://groups.io/mt/105299780/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Maintainers.txt: Update maintainers for Marvell platforms

[Michael D Kinney]

Reviewed-by: Michael D Kinney 

> -Original Message-
> From: Leif Lindholm 
> Sent: Tuesday, April 2, 2024 8:40 AM
> To: devel@edk2.groups.io
> Cc: Marcin Wojtas ; Narinder Dhillon
> ; Kinney, Michael D 
> Subject: [PATCH edk2-platforms 1/1] Maintainers.txt: Update maintainers
> for Marvell platforms
> 
> Marcin and Narinder are the people most familiar with the Marvell
> platforms, so make them the maintainers.
> I move myself down to Reviewer for now.
> 
> Cc: Marcin Wojtas 
> Cc: Narinder Dhillon 
> Cc: Michael D Kinney 
> Signed-off-by: Leif Lindholm 
> ---
>  Maintainers.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index ca36aa679470..877620a1b02c 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -357,8 +357,9 @@ Marvell platforms and silicon
>  F: Platform/Marvell/
>  F: Platform/SolidRun/
>  F: Silicon/Marvell/
> -R: Marcin Wojtas 
> -M: Leif Lindholm 
> +M: Marcin Wojtas  [wojtas-marcin]
> +M: Narinder Dhillon  [ndhillonm]
> +R: Leif Lindholm  [leiflindholm]
> 
>  Miscellaneous drivers
>  F: Silicon/Atmel/
> --
> 2.30.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117336): https://edk2.groups.io/g/devel/message/117336
Mute This Topic: https://groups.io/mt/105290056/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

[Michael D Kinney]

There are also utilities to partition and format.

https://www.intel.com/content/www/us/en/download/714351/uefi-shell-disk-utilities.html

Mike

From: devel@edk2.groups.io  On Behalf Of Andrew Fish via 
groups.io
Sent: Friday, March 29, 2024 3:11 PM
To: devel@edk2.groups.io; yuinyee.c...@starfivetech.com
Subject: Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf is a virtual storage 
device, so it just emulates an unformatted disk. You would need to partition or 
initialize the file system given you have a RAM disk.

The file system driver lives here: 
https://github.com/tianocore/edk2/tree/master/FatPkg/EnhancedFatDxe

The ArmPkg has a driver that lets you do a file system over JTAG: 
https://github.com/tianocore/edk2/blob/master/ArmPkg/Filesystem/SemihostFs/Arm/

You can make a ReadOnly file system out of contents on an FV (Firmware Volume): 
https://github.com/tianocore/edk2/tree/master/MdeModulePkg/Universal/FvSimpleFileSystemDxe
FV is defined in the PI Spec as a layout for flash that contains files, but no 
directories.

Thanks,

Andrew Fish


On Mar 29, 2024, at 1:21 AM, John Chew 
mailto:yuinyee.c...@starfivetech.com>> wrote:

[cid:attach_0_17C12E88E9BAF705_29633@groups.io]




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117247): https://edk2.groups.io/g/devel/message/117247
Mute This Topic: https://groups.io/mt/105212723/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

[Michael D Kinney]

Merged: https://github.com/tianocore/edk2/pull/5505

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Oliver
> Smith-Denny
> Sent: Friday, March 29, 2024 1:21 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Leif Lindholm
> ; Ard Biesheuvel ;
> Sami Mujawar ; Taylor Beebe
> 
> Subject: [edk2-devel] [PATCH v3 0/3] MdeModulePkg: ImagePropertiesRecordLib
> Fixes
> 
> ImagePropertiesRecordLib is currently creating Image Records that
> are not accurate. It is setting the CodeSegmentSize to be the size
> of the raw data in the image file, however, when the image is
> loaded into memory, the raw data size is aligned to the
> section alignment. This caused the memory attributes table to
> have incorrect entries for systems, like ARM64, where the section
> alignment is not 4k for all modules.
> 
> In fixing this, I noticed that MemoryProtection.c is using its own
> version of image record creation where this logic was actually
> correct. ImagePropertiesRecordLib was created to consolidate the
> logic around creating and managing image records, so this patchset
> also updates MemoryProtection.c to use ImagePropertiesRecordsLib
> after making a few small adjustments to ensure the same functionality
> is present.
> 
> This patchset was tested on ArmVirtQemu to ensure that all image
> records were the same before and after this, other than fixing
> the CodeSegmentSize.
> 
> v3:
> - Fix merge conflict in MemoryProtection.c
> 
> v2:
> - Align VirtualSize instead of SizeOfRawData
> 
> Github PR: https://github.com/tianocore/edk2/pull/5504
> 
> Cc: Liming Gao 
> Cc: Leif Lindholm 
> Cc: Ard Biesheuvel 
> Cc: Sami Mujawar 
> Cc: Taylor Beebe 
> 
> Oliver Smith-Denny (3):
>   MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for
> CodeSize
>   MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage
>   MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib
> 
> Oliver Smith-Denny (3):
>   MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for
> CodeSize
>   MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage
>   MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLib
> 
>  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c|
> 241 +++-
>  MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c |
> 86 +--
>  2 files changed, 94 insertions(+), 233 deletions(-)
> 
> --
> 2.40.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#117239): https://edk2.groups.io/g/devel/message/117239
> Mute This Topic: https://groups.io/mt/105223002/1643496
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [michael.d.kin...@intel.com]
> -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117246): https://edk2.groups.io/g/devel/message/117246
Mute This Topic: https://groups.io/mt/105223002/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

[Michael D Kinney]

Hi Oliver,

I am seeing a merge conflict with the V2 patches from the emails.

Can you please rebase, resolve conflicts, and resend?

Thanks,

Mike

> -Original Message-
> From: Oliver Smith-Denny 
> Sent: Friday, March 29, 2024 10:14 AM
> To: devel@edk2.groups.io; Kinney, Michael D ;
> Ard Biesheuvel 
> Cc: Liming Gao ; Ni, Ray ; Leif
> Lindholm ; Sami Mujawar ;
> Taylor Beebe 
> Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg:
> ImagePropertiesRecordLib Fixes
> 
> Thanks Mike!
> 
> Oliver
> 
> On 3/29/2024 10:12 AM, Michael D Kinney wrote:
> > Hi Ard,
> >
> > I have reviewed the discussion on the V1 and V2 versions of the series.
> > For the V2 Series:
> >
> >  Acked-by: Michael D Kinney 
> >
> > I will add the Rb/Ab tags and get this merged.
> >
> > Mike
> >
> >> -Original Message-
> >> From: Ard Biesheuvel 
> >> Sent: Friday, March 29, 2024 1:03 AM
> >> To: devel@edk2.groups.io; o...@linux.microsoft.com
> >> Cc: Liming Gao ; Kinney, Michael D
> >> ; Ni, Ray ; Leif Lindholm
> >> ; Sami Mujawar ; Taylor
> >> Beebe 
> >> Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg:
> >> ImagePropertiesRecordLib Fixes
> >>
> >> On Wed, 27 Mar 2024 at 20:14, Oliver Smith-Denny
> >>  wrote:
> >>>
> >>> Hi Mike and Ray,
> >>>
> >>> I'm here to bug you again :). I have another patchset that
> >>> unfortunately Liming has not gotten to review in a month's
> >>> time frame with weekly pings. When I bugged you last time,
> >>> he reviewed the next day, so something must have worked out
> >>> there. Can you please help get this merged?
> >>>
> >>> Liming, do you need the community to find another member
> >>> to help as a second MdeModulePkg maintainer? It's obviously
> >>> a large job and you have been less responsive the past few
> >>> months, which has slowed down getting some really
> >>> important fixes into MdeModulePkg.
> >>>
> >>
> >> Yes, could we please get this merged? These are important fixes.
> >>
> >> In case it was missed, for the series:
> >>
> >> Reviewed-by: Ard Biesheuvel 
> >
> >
> > 
> >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117237): https://edk2.groups.io/g/devel/message/117237
Mute This Topic: https://groups.io/mt/104873191/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

[Michael D Kinney]

Hi Ard,

I have reviewed the discussion on the V1 and V2 versions of the series.
For the V2 Series:

Acked-by: Michael D Kinney 

I will add the Rb/Ab tags and get this merged.

Mike

> -Original Message-
> From: Ard Biesheuvel 
> Sent: Friday, March 29, 2024 1:03 AM
> To: devel@edk2.groups.io; o...@linux.microsoft.com
> Cc: Liming Gao ; Kinney, Michael D
> ; Ni, Ray ; Leif Lindholm
> ; Sami Mujawar ; Taylor
> Beebe 
> Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg:
> ImagePropertiesRecordLib Fixes
> 
> On Wed, 27 Mar 2024 at 20:14, Oliver Smith-Denny
>  wrote:
> >
> > Hi Mike and Ray,
> >
> > I'm here to bug you again :). I have another patchset that
> > unfortunately Liming has not gotten to review in a month's
> > time frame with weekly pings. When I bugged you last time,
> > he reviewed the next day, so something must have worked out
> > there. Can you please help get this merged?
> >
> > Liming, do you need the community to find another member
> > to help as a second MdeModulePkg maintainer? It's obviously
> > a large job and you have been less responsive the past few
> > months, which has slowed down getting some really
> > important fixes into MdeModulePkg.
> >
> 
> Yes, could we please get this merged? These are important fixes.
> 
> In case it was missed, for the series:
> 
> Reviewed-by: Ard Biesheuvel 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117235): https://edk2.groups.io/g/devel/message/117235
Mute This Topic: https://groups.io/mt/104873191/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdePkg: Add PciVenNameLib to get vendor name.

[Michael D Kinney]

That is a lot of string data.

Where is this expected to be used?  If it is limited to a UEFI Shell command,
would it be better to add to ShellPkg so it does not get used for FW components?

Thanks,

Mike

> -Original Message-
> From: Simon Wang 
> Sent: Friday, March 15, 2024 2:05 AM
> To: devel@edk2.groups.io
> Cc: Simon Wang ; Kinney, Michael D
> ; Liming Gao ;
> Liu, Zhiguang 
> Subject: [PATCH] MdePkg: Add PciVenNameLib to get vendor name.
> 
> Add a new library, PciVenNameLib which provides a service to return
> the
> Pci vendor name string given the Pci vendor ID
> values.
> 
> Signed-off-by: Simon Wang 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> ---
>  MdePkg/Include/Library/PciVenNameLib.h|   27 +
>  MdePkg/Library/PciVenNameLib/PciVenNameLib.c  | 2394
> +
>  .../Library/PciVenNameLib/PciVenNameLib.inf   |   25 +
>  MdePkg/MdePkg.dec |4 +
>  MdePkg/MdePkg.dsc |2 +
>  5 files changed, 2452 insertions(+)
>  create mode 100644 MdePkg/Include/Library/PciVenNameLib.h
>  create mode 100644 MdePkg/Library/PciVenNameLib/PciVenNameLib.c
>  create mode 100644 MdePkg/Library/PciVenNameLib/PciVenNameLib.inf
> 
> diff --git a/MdePkg/Include/Library/PciVenNameLib.h
> b/MdePkg/Include/Library/PciVenNameLib.h
> new file mode 100644
> index 00..b04bf2e068
> --- /dev/null
> +++ b/MdePkg/Include/Library/PciVenNameLib.h
> @@ -0,0 +1,27 @@
> +/** @file
> +  Provides Pci vendor name functions.
> +
> +  Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights
> reserved.
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef PCI_VEN_NAME_LIB_H_
> +#define PCI_VEN_NAME_LIB_H_
> +
> +/**
> +  Looks up the PCI vendor name.
> +
> +  @param VenId PCI vendor ID.
> +
> +  @return  The PCI vendor string, or NULL if an error
> +   occurred or the PCI vendor ID isn't valid.
> +
> +**/
> +CONST CHAR8 *
> +EFIAPI
> +GetPciVenName (
> +  IN UINT16  VenId
> +  );
> +
> +#endif /* PCI_VEN_NAME_LIB_H_ */
> diff --git a/MdePkg/Library/PciVenNameLib/PciVenNameLib.c
> b/MdePkg/Library/PciVenNameLib/PciVenNameLib.c
> new file mode 100644
> index 00..0986100160
> --- /dev/null
> +++ b/MdePkg/Library/PciVenNameLib/PciVenNameLib.c
> @@ -0,0 +1,2394 @@
> +/** @file
> +  Provides Pci vendor name functions.
> +
> +  Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights
> reserved.
> +
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include 
> +#include 
> +
> +typedef struct {
> +  UINT16 VenId;
> +  CONST CHAR8*VenName;
> +} PCI_VENDORS;
> +
> +GLOBAL_REMOVE_IF_UNREFERENCED
> +STATIC CONST PCI_VENDORS  PciVendorsList[] = {
> +  { 0x0014, "Loongson Technology LLC"
> },
> +  { 0x0018, "Fn-Link Technology Limited"
> },
> +  { 0x001C, "PEAK-System Technik GmbH"
> },
> +  { 0x003D, "Lockheed Martin-Marietta Corp"
> },
> +  { 0x0070, "Hauppauge computer works Inc."
> },
> +  { 0x0071, "Nebula Electronics Ltd."
> },
> +  { 0x0100, "nCipher Security"
> },
> +  { 0x0123, "General Dynamics"
> },
> +  { 0x018A, "LevelOne"
> },
> +  { 0x01DE, "Oxide Computer Company"
> },
> +  { 0x021B, "Compaq Computer Corporation"
> },
> +  { 0x025E, "Solidigm"
> },
> +  { 0x02AC, "SpeedStream"
> },
> +  { 0x0315, "SK-Electronics Co., Ltd."
> },
> +  { 0x0432, "SCM Microsystems, Inc."
> },
> +  { 0x060E, "Lightelligence"
> },
> +  { 0x0675, "Dynalink"
> },
> +  { 0x0721, "Sapphire, Inc."
> },
> +  { 0x0731, "Jingjia Microelectronics Co Ltd"
> },
> +  { 0x0777, "Ubiquiti Networks, Inc."
> },
> +  { 0x0795, "Wired Inc."
> },
> +  { 0x07D1, "D-Link System Inc"
> },
> +  { 0x0824, "Freescale"
> },
> +  { 0x0A89, "BREA Technologies Inc"
> },
> +  { 0x0B0B, "Rhino Equipment Corp."
> },
> +  { 0x0BAE, "Bachmann electronic GmbH"
> },
> +  { 0x0CCD, "Preferred Networks, Inc."
> },
> +  { 0x0E11, "Compaq Computer Corporation"
> },
> +  { 0x0E55, "HaSoTec GmbH"
> },
> +  { 0x0EAC, "SHF Communication Technologies AG"
> },
> +  { 0x0F62, "Acrox Technologies Co., Ltd."
> },
> +  { 0x1000, "Broadcom"
> },
> +  { 0x1001, "Kolter Electronic&q

Re: [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData function description

[Michael D Kinney]

Merged: https://github.com/tianocore/edk2/pull/5463

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Qingyu
> Sent: Sunday, February 25, 2024 7:06 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData
> function description
> 
> Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId'
> description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function ReceiveData
> and SendData.
> 
> V4:
> Split patch so there is one patch per package
> 
> V3:
> Add maintainer to CC list.
> 
> V2:
> Update some functions description in C and H header files in MdeModulePkg
> and SecurityPkg.
> 
> V1:
> update the parameter description in
> MdePkg/Include/Protocol/StorageSecurityCommand.h.
> 
> Qingyu (3):
>   MdePkg: Update ReceiveData and SendData function description
>   MdeModulePkg: Update ReceiveData and SendData function description
>   SecurityPkg: Update ReceiveData and SendData function description
> 
>  MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c  |  8 ++--
>  MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h  |  8 ++--
>  .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c|  8 ++--
>  .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h|  8 ++--
>  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c |  8 ++--
>  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h |  8 ++--
>  MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c| 12 +---
>  MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h| 12 +---
>  MdePkg/Include/Protocol/StorageSecurityCommand.h |  8 ++--
>  SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c  |  8 ++--
>  10 files changed, 66 insertions(+), 22 deletions(-)
> 
> --
> 2.39.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116704): https://edk2.groups.io/g/devel/message/116704
Mute This Topic: https://groups.io/mt/104581208/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

[Michael D Kinney]

The MdePkg does have a standard location for CPU specific register
related includes.

Did you consider moving some of the content into

* MdePkg/Include/Register/Arm
* MdePkg/Include/Register/AArch64

Thanks,

Mike

> -Original Message-
> From: Leif Lindholm 
> Sent: Tuesday, March 12, 2024 9:47 AM
> To: Pierre Gondois ; devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Gerd Hoffmann
> ; Yao, Jiewen ; Liming Gao
> ; Kinney, Michael D ;
> Sami Mujawar ; Liu, Zhiguang 
> Subject: Re: [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg
> 
> On 2024-03-12 02:18, Pierre Gondois wrote:
> > This patch relies on [1].
> >
> > Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1],
> > move the Chipset/* files to the MdePkg as the Armlib.h relies on
> > them.
> >
> > These patches span over multiple packages as these Chipset/* files
> > are relocated to a new directory and include paths must be updated.
> 
> I like this!
> Traveling this week, so unable to test until Wednesday next week at the
> earliest, which I would like to do for something this core before giving
> a Reviewed-by. So for now, for the series:
> Acked-by: Leif Lindholm 
> 
> > [1] https://edk2.groups.io/g/devel/message/111566
> >
> > Cc: Ard Biesheuvel 
> > Cc: Gerd Hoffmann 
> > Cc: Jiewen Yao 
> > Cc: Leif Lindholm 
> > Cc: Liming Gao 
> > Cc: Michael D Kinney 
> > Cc: Pierre Gondois 
> > Cc: Sami Mujawar 
> > Cc: Zhiguang Liu 
> >
> > Pierre Gondois (2):
> >ArmPkg,MdePkg: Move ArmPkg/Chipset/ArmV7[|Mmu].h to MdePkg
> >ArmPkg,MdePkg: Move ArmPkg/Chipset/Aarch64[|Mmu].h to MdePkg
> >
> >   ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c | 2 +-
> >   ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S | 2 +-
> >   ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c | 2 +-
> >   ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c| 2 +-
> >   ArmPkg/Library/ArmLib/AArch64/AArch64Support.S| 2 +-
> >   ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c  | 2 +-
> >   ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c  | 2 +-
> >   ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibConvert.c   | 2 +-
> >   ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibCore.c  | 2 +-
> >   ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c| 2 +-
> >   ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 2 +-
> >   ArmPlatformPkg/PrePeiCore/AArch64/Helper.S| 2 +-
> >   ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
> >   ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S   | 2 +-
> >   ArmVirtPkg/PrePi/AArch64/ArchPrePi.c  | 2 +-
> >   {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h  | 2 +-
> >   .../Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h   | 0
> >   .../Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h   | 2 +-
> >   .../Chipset/ArmV7Mmu.h => MdePkg/Include/Arm/AArch32Mmu.h | 0
> >   MdePkg/Include/Library/ArmLib.h   | 4 ++--
> >   20 files changed, 19 insertions(+), 19 deletions(-)
> >   rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h
> (94%)
> >   rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h
> (100%)
> >   rename ArmPkg/Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h
> (95%)
> >   rename ArmPkg/Include/Chipset/ArmV7Mmu.h =>
> MdePkg/Include/Arm/AArch32Mmu.h (100%)
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116694): https://edk2.groups.io/g/devel/message/116694
Mute This Topic: https://groups.io/mt/104881290/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] EDK II CI issues installing choco dependencies - RESOLVED

[Michael D Kinney]

This issue appears to be resolved

Mike

> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Michael
> D Kinney
> Sent: Sunday, March 10, 2024 12:16 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D 
> Subject: [edk2-devel] EDK II CI issues installing choco dependencies
> 
> I am seeing some EDK II CI failures installing choco
> dependencies on windows CI agents.
> 
> Here is an example:
> 
> https://github.com/tianocore/edk2/pull/5454
> https://dev.azure.com/tianocore/edk2-
> ci/_build/results?buildId=120411=logs=d32104f1-f467-5bda-fd84-
> d1a8627a9794=da01f8aa-41f1-5e7f-f8f1-aaec629da65f=85
> 
> I see a similar description here that was opened yesterday and
> closed as a choco issue
> 
> https://github.com/actions/runner-images/issues/9476
> 
> Let me know if anyone notices any resolutions/workarounds.
> 
> Mike
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116576): https://edk2.groups.io/g/devel/message/116576
Mute This Topic: https://groups.io/mt/104858552/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] EDK II CI issues installing choco dependencies

[Michael D Kinney]

I am seeing some EDK II CI failures installing choco
dependencies on windows CI agents.

Here is an example:

https://github.com/tianocore/edk2/pull/5454
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=120411=logs=d32104f1-f467-5bda-fd84-d1a8627a9794=da01f8aa-41f1-5e7f-f8f1-aaec629da65f=85

I see a similar description here that was opened yesterday and
closed as a choco issue

https://github.com/actions/runner-images/issues/9476

Let me know if anyone notices any resolutions/workarounds.

Mike



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116569): https://edk2.groups.io/g/devel/message/116569
Mute This Topic: https://groups.io/mt/104849841/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-