[E-devel] key binding

[Jérémy Zurcher]

Hi,
I'm looking for a key binding to move focus from a screen to another.
Is there a way the achieve that that I can't think of ?
many thanks


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Keyboard sequence to escape Terminology from Enlightenment top bar toggled Fullscreen option

[Jérémy Zurcher]

Hi, are you looking for Alt+right click that brings in a contextual menu ?
or Alt+middle click that allows you to resize the window ?


On Wednesday 07 February 2024  22:51, jose@metztli.com wrote :
> Hello-
> Probably this is trivial but...
> 
> Maximized the Terminology 1.12.1 screen dimensions by selecting the upward
> arrow on its window bar. There was another application at the top of the
> same screen and Terminology upper position was offset downwards by the
> approximate dimension of the other application window top bar.
> Terminology/Enlightenment did not respect/calculate screen dimension edge at
> bottom and ended up with 'hanging' extreme off view of the screen.
> 
> I tried to resize Terminology from the Enlightenment 0.25.4 bar at the top
> -- which disappears unless I press my pointer towards the top. Resizing
> option was not available; thus, I selected Fullscreen option which took
> control of the current screen. Now I cannot bring up the Enlightenment bar
> again to exit Fullscreen option. Indeed, I could close the Terminology
> window tabs I have open but I am working on different tabs and I do not want
> to lose track of what I have going on.
> 
> Is there a way to exit Enlightenment/Terminology Fullscreen without closing
> Terminology app itself? Alternatively, is there a way to bring up the
> Enlightenment bar using keyboard sequence(s)?
> 
> Thanks.
> 
> -- 
> Best Professional Regards.
> 
> --
> Jose R R
> http://metztli.it
> -
> Download Metztli Reiser4: Debian Bullseye w/ Linux 5.16.20 AMD64
> -
> feats ZSTD compression https://sf.net/projects/metztli-reiser4/
> ---
> Official current Reiser4 resources: https://reiser4.wiki.kernel.org/
> 
> 
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E : little focus regression

[Jérémy Zurcher]

Sadly it's still not ok,
open terminology, launch a gtk app then open a modal dialog (gimp -> new)
terminology is stacked in between the app and the modal dialog.

On Thursday 06 January 2022  18:46, Jérémy Zurcher wrote :
> Hi,
> I'm on kind of daily git build.
> since ~1 week when I close a none e window (even elementary_test)
> focus does not go back to my previously focused app (terminology).
> 
> --- Hell'O from Yverdoom
> 
> Jérémy (jeyzu)
> 


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: e_client: revert focus instead of setting it to NULL

[Jérémy Zurcher]

you nailed it, thanks !

On Thursday 06 January 2022  12:17, Marcel Hollerbach wrote :
> bu5hm4n pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/enlightenment.git/commit/?id=2d86d75139c40e7365e34880b0e3b56f248b0e41
> 
> commit 2d86d75139c40e7365e34880b0e3b56f248b0e41
> Author: Marcel Hollerbach 
> Date:   Thu Jan 6 20:57:38 2022 +0100
> 
> e_client: revert focus instead of setting it to NULL
> 
> When closing a client a few different things can happen:
> 1. Client hides, this will destroy the e_client object, which will
>reverts focus to another client.
> 2. Client hook del, this will recover focus to the root window if no
>e_client is focused.
> 3. Client unfocus event, setted the focused to NULL and sets the focus 
> field to 0.
> 
> when first 1 happens then 2 or 3 everything is fine. However, it seems
> that sometimes first 3 happend, then 2, then 1. Which results in focus
> beeing first NULL, then recovered to the root window, resulting in the
> wrong things happening.
> ---
>  src/bin/e_client.c  | 10 +-
>  src/bin/e_comp_object.c |  5 +++--
>  2 files changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/src/bin/e_client.c b/src/bin/e_client.c
> index 6e605a339..85f5504a7 100644
> --- a/src/bin/e_client.c
> +++ b/src/bin/e_client.c
> @@ -400,8 +400,8 @@ _e_client_mouse_action_end(E_Client *ec)
> E_FREE_FUNC(ec->cur_mouse_action, e_object_unref);
>  }
>  
> -static void
> -_e_client_revert_focus(E_Client *ec)
> +E_API void
> +e_client_revert_focus(E_Client *ec)
>  {
> E_Client *pec;
> E_Desk *desk;
> @@ -644,7 +644,7 @@ _e_client_del(E_Client *ec)
>   evas_object_hide(ec->internal_elm_win);
>  
> if (ec->focused)
> - _e_client_revert_focus(ec);
> + e_client_revert_focus(ec);
> if (ec->frame) evas_object_focus_set(ec->frame, 0);
>  
> E_FREE_FUNC(ec->ping_poller, ecore_poller_del);
> @@ -1560,7 +1560,7 @@ _e_client_cb_evas_hide(void *data, Evas *e EINA_UNUSED, 
> Evas_Object *obj EINA_UN
> if (!ec->hidden)
>   {
>  if (ec->focused)
> -  _e_client_revert_focus(ec);
> +  e_client_revert_focus(ec);
>   }
> ec->want_focus = ec->take_focus = 0;
>  
> @@ -4642,7 +4642,7 @@ e_client_iconify(E_Client *ec)
>   {
>  if (!ec->new_client)
>{
> - _e_client_revert_focus(ec);
> + e_client_revert_focus(ec);
>   evas_object_hide(ec->frame);
>}
>  e_client_urgent_set(ec, ec->icccm.urgent);
> diff --git a/src/bin/e_comp_object.c b/src/bin/e_comp_object.c
> index 04b0bd330..77720aa19 100644
> --- a/src/bin/e_comp_object.c
> +++ b/src/bin/e_comp_object.c
> @@ -1877,8 +1877,9 @@ _e_comp_intercept_focus(void *data, Evas_Object *obj, 
> Eina_Bool focus)
>   }
> else
>   {
> -if (e_client_focused_get() == ec)
> -  e_client_focused_set(NULL);
> +if (e_client_focused_get() == ec) {
> +  e_client_revert_focus(ec);
> +}
>   }
> evas_object_focus_set(obj, focus);
>  }
> 
> -- 
> 
> 
--- Hell'O from Yverdoom

Jérémy (jeyzu)


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] E : little focus regression

[Jérémy Zurcher]

Hi,
I'm on kind of daily git build.
since ~1 week when I close a none e window (even elementary_test)
focus does not go back to my previously focused app (terminology).

--- Hell'O from Yverdoom

Jérémy (jeyzu)


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] enventor git build fail

[Jérémy Zurcher]

I just did

git clone ... && ./autogen.sh && ./configure && make

On Sunday 11 April 2021  16:38, leoutat...@gmx.fr wrote :
> Hi
> I try to build enventor git master version with but it fails.
> Is it really possible to build it this way? (efl git master)
> 
> checking whether gcc accepts -g... yes
> checking for gcc option to enable C11 features... none needed
> checking whether gcc understands -c and -o together... yes
> checking build system type... config.sub: missing argument
> Try `config.sub --help' for more information.
> configure: error: /bin/sh ./config.sub   failed
> 
> --
> Maderios
> 
> 
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Flat has landed

[Jérémy Zurcher]

yesss, very nice !!!

On Saturday 27 March 2021  16:10, Carsten Haitzler wrote :
> For those who are not watching git commits...
> 
> Flat theme has landed in git master efl today.
> 
> Yay!
> 
> -- 
> - Codito, ergo sum - "I code, therefore I am" --
> Carsten Haitzler - ras...@rasterman.com
> 
> 
> 
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/enlightenment] master 02/02: winlist - dont show anything at all if no windows in the winlist

[Jérémy Zurcher]

So that was it : 
https://git.enlightenment.org/core/efl.git/commit/?h=feature/themes/flat&id=a50af32c60b6192e4cb20d3821340b597703d02f

and I was using slow software rendering as opengl was pretty unsable for me for 
a while.

It seems much better right now, I had only 2 freeze on desktop switch last 2 
days.

On Tuesday 17 November 2020  12:27, Jérémy Zurcher wrote :
> On Tuesday 17 November 2020  09:25, Carsten Haitzler wrote :
> > On Mon, 16 Nov 2020 15:47:46 +0100 Jérémy Zurcher  said:
> > 
> > > Hi Raster,
> > > 
> > > wouldn't it be nice to add a timer before animation ?
> > 
> > No - as it then adds what some users would call latency and say it's "slow" 
> > as
> > it is slow to react. :)
> I get that slower is worst, I think that I missed the point.
> 
> On my win10 work machine I can switch to the next window in a blink of an eye.
> 
> With e flat-theme, my fingers are long away from the keyboard when the
> screen blinks because of winlist's blury bg coming.
> 
> maybe the whole winlist animation, should be immediatly stopped/canceled
> as soon as the user let the alt key go.
> 
> > It has both upsides and downsides doing this and thus
> > doesn't justify the actual work to redesign winlist to "do it's work" but 
> > not
> > have a gui at all until a short time later as they are written to be 
> > combined
> > at the moment. :)
> > 
> > > I do a lot of windows switching using alt-tab,
> > > I just have 2-3 windows per desktop and I know what they are,
> > > having that animation fire everytime I switch is a bit annoying.
> > > 
> > > regards
> > > 
> > > 
> > > On Monday 09 November 2020  02:51, Carsten Haitzler wrote :
> > > > raster pushed a commit to branch master.
> > > > 
> > > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=445b42b87649a716e4fff363d58ca06552a1095d
> > > > 
> > > > commit 445b42b87649a716e4fff363d58ca06552a1095d
> > > > Author: Carsten Haitzler (Rasterman) 
> > > > Date:   Mon Nov 9 10:49:19 2020 +
> > > > 
> > > > winlist - dont show anything at all if no windows in the winlist
> > > > ---
> > > >  src/modules/winlist/e_winlist.c | 10 ++
> > > >  1 file changed, 10 insertions(+)
> > > > 
> > > > diff --git a/src/modules/winlist/e_winlist.c
> > > > b/src/modules/winlist/e_winlist.c index f23258260..8684334e1 100644
> > > > --- a/src/modules/winlist/e_winlist.c
> > > > +++ b/src/modules/winlist/e_winlist.c
> > > > @@ -270,6 +270,16 @@ e_winlist_show(E_Zone *zone, E_Winlist_Filter 
> > > > filter)
> > > >  
> > > > if (!_wins)
> > > >   {
> > > > +if (_winlist_bg_object)
> > > > +  {
> > > > + evas_object_del(_winlist_bg_object);
> > > > + _winlist_bg_object = NULL;
> > > > +  }
> > > > +if (_winlist_fg_object)
> > > > +  {
> > > > + evas_object_del(_winlist_fg_object);
> > > > + _winlist_fg_object = NULL;
> > > > +  }
> > > >  e_winlist_hide();
> > > >  evas_event_thaw(e_comp->evas);
> > > >  return 1;
> > > > 
> > > > -- 
> > > > 
> > > > 
> > > --- Hell'O from Yverdoom
> > > 
> > > Jérémy (jeyzu)
> > > 
> > > 
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > 
> > 
> > -- 
> > - Codito, ergo sum - "I code, therefore I am" --
> > Carsten Haitzler - ras...@rasterman.com
> > 
> --- Hell'O from Yverdoom
> 
> Jérémy (jeyzu)
> 
> 
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/enlightenment] master 02/02: winlist - dont show anything at all if no windows in the winlist

[Jérémy Zurcher]

On Tuesday 17 November 2020  09:25, Carsten Haitzler wrote :
> On Mon, 16 Nov 2020 15:47:46 +0100 Jérémy Zurcher  said:
> 
> > Hi Raster,
> > 
> > wouldn't it be nice to add a timer before animation ?
> 
> No - as it then adds what some users would call latency and say it's "slow" as
> it is slow to react. :)
I get that slower is worst, I think that I missed the point.

On my win10 work machine I can switch to the next window in a blink of an eye.

With e flat-theme, my fingers are long away from the keyboard when the
screen blinks because of winlist's blury bg coming.

maybe the whole winlist animation, should be immediatly stopped/canceled
as soon as the user let the alt key go.

> It has both upsides and downsides doing this and thus
> doesn't justify the actual work to redesign winlist to "do it's work" but not
> have a gui at all until a short time later as they are written to be combined
> at the moment. :)
> 
> > I do a lot of windows switching using alt-tab,
> > I just have 2-3 windows per desktop and I know what they are,
> > having that animation fire everytime I switch is a bit annoying.
> > 
> > regards
> > 
> > 
> > On Monday 09 November 2020  02:51, Carsten Haitzler wrote :
> > > raster pushed a commit to branch master.
> > > 
> > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=445b42b87649a716e4fff363d58ca06552a1095d
> > > 
> > > commit 445b42b87649a716e4fff363d58ca06552a1095d
> > > Author: Carsten Haitzler (Rasterman) 
> > > Date:   Mon Nov 9 10:49:19 2020 +
> > > 
> > > winlist - dont show anything at all if no windows in the winlist
> > > ---
> > >  src/modules/winlist/e_winlist.c | 10 ++
> > >  1 file changed, 10 insertions(+)
> > > 
> > > diff --git a/src/modules/winlist/e_winlist.c
> > > b/src/modules/winlist/e_winlist.c index f23258260..8684334e1 100644
> > > --- a/src/modules/winlist/e_winlist.c
> > > +++ b/src/modules/winlist/e_winlist.c
> > > @@ -270,6 +270,16 @@ e_winlist_show(E_Zone *zone, E_Winlist_Filter filter)
> > >  
> > > if (!_wins)
> > >   {
> > > +if (_winlist_bg_object)
> > > +  {
> > > + evas_object_del(_winlist_bg_object);
> > > + _winlist_bg_object = NULL;
> > > +  }
> > > +if (_winlist_fg_object)
> > > +  {
> > > + evas_object_del(_winlist_fg_object);
> > > + _winlist_fg_object = NULL;
> > > +  }
> > >  e_winlist_hide();
> > >  evas_event_thaw(e_comp->evas);
> > >  return 1;
> > > 
> > > -- 
> > > 
> > > 
> > --- Hell'O from Yverdoom
> > 
> > Jérémy (jeyzu)
> > 
> > 
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 
> 
> -- 
> - Codito, ergo sum - "I code, therefore I am" --
> Carsten Haitzler - ras...@rasterman.com
> 
--- Hell'O from Yverdoom

Jérémy (jeyzu)


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/enlightenment] master 02/02: winlist - dont show anything at all if no windows in the winlist

[Jérémy Zurcher]

Hi Raster,

wouldn't it be nice to add a timer before animation ?
I do a lot of windows switching using alt-tab,
I just have 2-3 windows per desktop and I know what they are,
having that animation fire everytime I switch is a bit annoying.

regards


On Monday 09 November 2020  02:51, Carsten Haitzler wrote :
> raster pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/enlightenment.git/commit/?id=445b42b87649a716e4fff363d58ca06552a1095d
> 
> commit 445b42b87649a716e4fff363d58ca06552a1095d
> Author: Carsten Haitzler (Rasterman) 
> Date:   Mon Nov 9 10:49:19 2020 +
> 
> winlist - dont show anything at all if no windows in the winlist
> ---
>  src/modules/winlist/e_winlist.c | 10 ++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/src/modules/winlist/e_winlist.c b/src/modules/winlist/e_winlist.c
> index f23258260..8684334e1 100644
> --- a/src/modules/winlist/e_winlist.c
> +++ b/src/modules/winlist/e_winlist.c
> @@ -270,6 +270,16 @@ e_winlist_show(E_Zone *zone, E_Winlist_Filter filter)
>  
> if (!_wins)
>   {
> +if (_winlist_bg_object)
> +  {
> + evas_object_del(_winlist_bg_object);
> + _winlist_bg_object = NULL;
> +  }
> +if (_winlist_fg_object)
> +  {
> + evas_object_del(_winlist_fg_object);
> + _winlist_fg_object = NULL;
> +  }
>  e_winlist_hide();
>  evas_event_thaw(e_comp->evas);
>  return 1;
> 
> -- 
> 
> 
--- Hell'O from Yverdoom

Jérémy (jeyzu)


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [apps/terminology] master 01/01: termiolink: no need to double semicolons (they don't make a colon…)

[Jérémy Zurcher]

hahahah

On Thursday 04 June 2020  13:45, Boris Faure wrote :
> billiob pushed a commit to branch master.
> 
> http://git.enlightenment.org/apps/terminology.git/commit/?id=c37a16151c8389f1ad21104e2e7429da64ed578b
> 
> commit c37a16151c8389f1ad21104e2e7429da64ed578b
> Author: Boris Faure 
> Date:   Thu Jun 4 22:44:39 2020 +0200
> 
> termiolink: no need to double semicolons (they don't make a colon…)
> ---
>  src/bin/termiolink.c | 60 
> ++--
>  1 file changed, 30 insertions(+), 30 deletions(-)
> 
> diff --git a/src/bin/termiolink.c b/src/bin/termiolink.c
> index ed71816..1d976ce 100644
> --- a/src/bin/termiolink.c
> +++ b/src/bin/termiolink.c
> @@ -15,65 +15,65 @@ _isspace_unicode(const int codepoint)
> switch (codepoint)
>   {
>case 9: // character tabulation
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 10: // line feed
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 11: // line tabulation
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 12: // form feed
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 13: // carriage return
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 32: // space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 133: // next line
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 160: // no-break space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 5760: // ogham space mark
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 6158: // mongolian vowel separator
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8192: // en quad
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8193: // em quad
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8194: // en space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8195: // em space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8196: // three-per-em space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8197: // four-per-em space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8198: // six-per-em space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8199: // figure space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8200: // puncturation space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8201: // thin space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8202: // hair space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8203: // zero width space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8204: // zero width non-joiner
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8205: // zero width joiner
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8232: // line separator
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8233: // paragraph separator
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8239: // narrow no-break space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8287: // medium mathematical space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 8288: // word joiner
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 12288: // ideographic space
> - return EINA_TRUE;;
> + return EINA_TRUE;
>case 65279: // zero width non-breaking space
>   return EINA_TRUE;
>   }
> 
> -- 
> 
> 
--- Hell'O from Yverdoom

Jérémy (jeyzu)


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [apps/terminology] master 01/01: config: share translucent+opacity settings accross instances

[Jérémy Zurcher]

Hi Boris,

to answer to your questions :

- I use default theme, switching to mild theme  fixes it
  as reverting d138086df2c90b21 does

- GNU bash, version 5.0.16(1)-release (x86_64-pc-linux-gnu)
- PS1 is not multiline
- switching between software or OpenGL rendering has no impact
- I do use translucent bg, switching it off has no impact

cheers


On Tuesday 07 April 2020  12:54, Boris Faure wrote :
> On 20-04-06 09:25, Jérémy Zurcher wrote:
> > 
> > Hi,
> > 
> > this is not related to this commit, but this one : d138086df2c90b21
> > 
> > since the latter, I have 1 or 2 extra lines with a shortened prompt when I
> > open a new terminal.
> > 
> > cheers
> 
> Hi!
> 
> What shell do you use? Is your $PS1 on multiple lines? Are you running
> with software rendering or hardware-based rendering?
> Do you set terminology's background as translucent?
> Which theme do you use and is it better with the mild theme?
> 
> Cheers
> -- 
> Boris Faure
> Pointer Arithmetician




> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--- Hell'O from Yverdoom

Jérémy (jeyzu)


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [apps/terminology] master 01/01: config: share translucent+opacity settings accross instances

[Jérémy Zurcher]

Hi,

this is not related to this commit, but this one : d138086df2c90b21

since the latter, I have 1 or 2 extra lines with a shortened prompt when I
open a new terminal.

cheers


On Sunday 05 April 2020  14:20, Boris Faure wrote :
> billiob pushed a commit to branch master.
> 
> http://git.enlightenment.org/apps/terminology.git/commit/?id=cbbfe60aaea766165cb85197fbaeb200d6c721bd
> 
> commit cbbfe60aaea766165cb85197fbaeb200d6c721bd
> Author: Boris Faure 
> Date:   Sun Apr 5 22:59:46 2020 +0200
> 
> config: share translucent+opacity settings accross instances
> ---
>  src/bin/config.c |  2 ++
>  src/bin/main.c   |  4 ++--
>  src/bin/options_background.c |  4 ++--
>  src/bin/win.c| 34 +++---
>  src/bin/win.h|  2 +-
>  5 files changed, 14 insertions(+), 32 deletions(-)
> 
> diff --git a/src/bin/config.c b/src/bin/config.c
> index 97e10a9..78d9d27 100644
> --- a/src/bin/config.c
> +++ b/src/bin/config.c
> @@ -318,6 +318,8 @@ config_sync(const Config *config_src, Config *config)
> config->changedir_to_current = config_src->changedir_to_current;
> config->emoji_dbl_width = config_src->emoji_dbl_width;
> config->shine = config_src->shine;
> +   config->translucent = config_src->translucent;
> +   config->opacity = config_src->opacity;
>  }
>  
>  static void
> diff --git a/src/bin/main.c b/src/bin/main.c
> index c6dd7a3..35ddece 100644
> --- a/src/bin/main.c
> +++ b/src/bin/main.c
> @@ -413,7 +413,7 @@ main_ipc_new(Ipc_Instance *inst)
> if (win_term_set(wn, term) < 0)
>   return;
>  
> -   main_trans_update(config);
> +   main_trans_update();
> main_media_update(config);
> if (inst->pos)
>   {
> @@ -607,7 +607,7 @@ _start(Ipc_Instance *instance, Eina_Bool 
> need_scale_wizard)
>  goto exit;
>   }
>  
> -   main_trans_update(config);
> +   main_trans_update();
> main_media_update(config);
> win_sizing_handle(wn);
> win = win_evas_object_get(wn);
> diff --git a/src/bin/options_background.c b/src/bin/options_background.c
> index 530ade1..43241d2 100644
> --- a/src/bin/options_background.c
> +++ b/src/bin/options_background.c
> @@ -76,8 +76,8 @@ _cb_op_video_trans_chg(void *data,
>  
> config->translucent = elm_check_state_get(obj);
> elm_object_disabled_set(ctx->op_opacity, !config->translucent);
> -   main_trans_update(config);
> config_save(config);
> +   main_trans_update();
>  }
>  
>  static void
> @@ -91,8 +91,8 @@ _cb_op_video_opacity_chg(void *data,
> config->opacity = elm_slider_value_get(obj);
> if (!config->translucent)
>   return;
> -   main_trans_update(config);
> config_save(config);
> +   main_trans_update();
>  }
>  
>  static void
> diff --git a/src/bin/win.c b/src/bin/win.c
> index 0b305e9..1ccc34d 100644
> --- a/src/bin/win.c
> +++ b/src/bin/win.c
> @@ -1013,7 +1013,7 @@ win_evas_object_get(const Win *wn)
>  }
>  
>  static void
> -_win_trans(Win *wn, Term *term, Eina_Bool trans)
> +_win_trans(Win *wn, Term *term)
>  {
> Edje_Message_Int msg;
> Evas_Object *edje = elm_layout_edje_get(term->core);
> @@ -1025,7 +1025,7 @@ _win_trans(Win *wn, Term *term, Eina_Bool trans)
> edje_object_message_send(term->bg, EDJE_MESSAGE_INT, 1, &msg);
> edje_object_message_send(edje, EDJE_MESSAGE_INT, 1, &msg);
>  
> -   if (trans)
> +   if (term->config->translucent)
>   {
>  elm_win_alpha_set(wn->win, EINA_TRUE);
>  evas_object_hide(wn->backbg);
> @@ -1038,36 +1038,17 @@ _win_trans(Win *wn, Term *term, Eina_Bool trans)
>  }
>  
>  void
> -main_trans_update(const Config *config)
> +main_trans_update(void)
>  {
> Win *wn;
> -   Term *term, *term2;
> +   Term *term;
> Eina_List *l, *ll;
>  
> EINA_LIST_FOREACH(wins, l, wn)
>   {
>  EINA_LIST_FOREACH(wn->terms, ll, term)
>{
> - if (term->config == config)
> -   {
> -  if (config->translucent)
> -_win_trans(wn, term, EINA_TRUE);
> -  else
> -{
> -   Eina_Bool trans_exists = EINA_FALSE;
> -
> -   EINA_LIST_FOREACH(wn->terms, ll, term2)
> - {
> -if (term2->config->translucent)
> -  {
> - trans_exists = EINA_TRUE;
> - break;
> -  }
> - }
> -   _win_trans(wn, term, trans_exists);
> -}
> -  return;
> -   }
> + _win_trans(wn, term);
>}
>   }
>  }
> @@ -5831,7 +5812,7 @@ void change_theme(Evas_Object *win, Config *config)
> if (l) l = eina_list_last(l);
> if (l) elm_theme_overlay_del(NULL, l->data);
> elm_theme_overlay_add(NULL, config_theme_path_get(config));
> -   main_trans_update(config);
> +   main_t

[E-devel] E broken i915

[Jérémy Zurcher]

Hi,

since the latest upgrade to linux 5.1.2 e is totally broken on 1 of my 4 
machines,
all running archlinux

I find that in dmesg, after starting E
 drm:intel_set_cpu_fifo_underrun_reporting [i915] *ERROR* uncleared fifo 
underrun on pipe A
 drm:intel_cpu_fifo_underrun_irq_handler [i915] *ERROR* CPU pipe A FIFO underrun

is there something I can do on efl/e side to fix that ?

thanks,
Jérémy


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Terminology 1.4.0 lacks [copy/paste] support for Russian [Cyrillic], etc.

[Jérémy Zurcher]

thanks, I can again copy paste my name,
don't know about the cyrilic letters though.

On Friday 03 May 2019  23:30, Boris Faure wrote :
> On 19-05-03 18:38, Boris Faure wrote:
> > I think I understood the issue (not decoding the paste as utf8).  I'll
> > try to fix it over the weekend.  Then I'll release a hotfix version.
> 
> I've done the patch. Could you please test it and tell me if it fixes
> your issues?
> 
> Have a nice weekend
> -- 
> Boris Faure
> Pointer Arithmetician

--- Hell'O from Yverdoom

Jérémy (jeyzu)


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Terminology 1.4.0 lacks [copy/paste] support for Russian [Cyrillic], etc.

[Jérémy Zurcher]

git bisect tells me it's 756a45e6542c6bd58f3898077b2de2ca509ce5c1's fault

https://git.enlightenment.org/apps/terminology.git/commit/?id=756a45e6542c6bd58f3898077b2de2ca509ce5c1

make sense to me.

On Friday 03 May 2019  10:01, Carsten Haitzler wrote :
> On Thu, 2 May 2019 18:49:51 -0700 Jose R R  said:
> 
> > -- Forwarded message -
> > From: Boris Faure 
> > Date: Thu, May 2, 2019 at 1:08 AM
> > Subject: Re: [E-devel] Terminology 1.4.0 lacks support for Russian
> > [Cyrillic], etc.
> > To: Enlightenment developer list 
> > 
> > On 19-05-02 01:00, Jose R R wrote:
> > > Niltze, all-
> > >
> > > FYI feedback. Unlike Terminology 1.3.x, Terminology 1.4.0 lacks
> > > support for Russian [Cyricllic] characters, i.e., ё, as well as other
> > > characters, i.e., German, with apostrophes, etc.
> > 
> > > Which version of EFL are you using?
> > I used both, the last stable efl 1.21.1 as well as the early 1.22.0
> > 
> > > Is the issue about typing those characters or rendering them?
> > []
> > 
> > I meant copy-pasting referenced chars within Terminology 1.4.0 and
> > also into Terminology 1.4.0 from another application, i.e., text
> > editor like textadept or gedit.
> 
> I copy & pasted that Cyrillic yesterday into terminology (that was in my
> screenshot)...
> 
> is it an encoding issue? are you not using UTF8 locales?
> 
> http://www.enlightenment.org/ss/e-5ccc036788c1e1.09659960.png
> 
> I did that just now...
> 
> > Best Professional Regards.
> > 
> > -- 
> > Jose R R
> > http://metztli.it
> > -
> > Download Metztli Reiser4: Debian Stretch w/ Linux 5.0.10 AMD64
> > -
> > feats ZSTD compression https://sf.net/projects/metztli-reiser4/
> > ---
> > Official current Reiser4 resources: https://reiser4.wiki.kernel.org/
> > 
> > 
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 
> 
> -- 
> - Codito, ergo sum - "I code, therefore I am" --
> Carsten Haitzler - ras...@rasterman.com
> 
> 
> 
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Terminology 1.4.0 lacks [copy/paste] support for Russian [Cyrillic], etc.

[Jérémy Zurcher]

I confirm the issue, it's a very new regression.
I can't copy paste my name anymore ...
so sad, that's my favorite day to day activity.

On Thursday 02 May 2019  23:23, Christopher Michael wrote :
>R ... curious on this. Stuff used to work.
> 
>dh
> 
>On 5/2/19 9:49 PM, Jose R R wrote:
> 
> -- Forwarded message -
> From: Boris Faure [1]
> Date: Thu, May 2, 2019 at 1:08 AM
> Subject: Re: [E-devel] Terminology 1.4.0 lacks support for Russian
> [Cyrillic], etc.
> To: Enlightenment developer list 
> [2]
> 
> On 19-05-02 01:00, Jose R R wrote:
> 
> Niltze, all-
> 
> FYI feedback. Unlike Terminology 1.3.x, Terminology 1.4.0 lacks
> support for Russian [Cyricllic] characters, i.e., io, as well as other
> characters, i.e., German, with apostrophes, etc.
> 
> 
> Which version of EFL are you using?
> 
> I used both, the last stable efl 1.21.1 as well as the early 1.22.0
> 
> 
> Is the issue about typing those characters or rendering them?
> 
> []
> 
> I meant copy-pasting referenced chars within Terminology 1.4.0 and
> also into Terminology 1.4.0 from another application, i.e., text
> editor like textadept or gedit.
> 
> 
> Best Professional Regards.
> 
> References
> 
>1. mailto:bo...@fau.re
>2. mailto:enlightenment-devel@lists.sourceforge.net
> 
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)


___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Server/Gitlab/Etc... and our servers/sysadmins routinely letting us down.

[Jérémy Zurcher]

On Monday 17 December 2018  06:49, jaquil...@eagleeyet.net wrote :
> I am more than willing to take charge of this if Bieber is ok with it.
> 
> If we containerize things cant we go with a secure and stable super long
> term support distro like centos? Correct me if I am wrong each docker
> container is its own mini distro right or am I incorrect in that
> understanding?

Yes, use a stable distrib as host (CentOS/Debian), and sit Ubuntu dockers upon 
it.

> 
> -Original Message-
> From: Simon Lees  
> Sent: 17 December 2018 03:07
> To: enlightenment-devel@lists.sourceforge.net
> Subject: Re: [E-devel] Server/Gitlab/Etc... and our servers/sysadmins
> routinely letting us down.
> 
> 
> 
> On 15/12/2018 22:59, Carsten Haitzler (The Rasterman) wrote:
> > On Thu, 13 Dec 2018 11:36:55 -0600 Stephen Houston 
> said:
> > 
> >> A few months ago Mike set up  a test instance of gitlab on a server 
> >> for us... After testing and the like, I set up a slowvote on Phab 
> >> that covered
> >> 4 options:
> >>
> >> Gitlab with new infra
> >> Gitlab with current infra
> >> Phab with new infra
> >> Phab with current infra
> >>
> >> The overwhelming support was for new infra.  As in every single vote 
> >> except for one wanted new infra.  The majority also wanted gitlab, 
> >> but for the sake of this email, that is irrelevant.
> >>
> >> The arguments against new infra, having it sponsored, cloud, etc... 
> >> keep being that if someone leaves the project, or the owners of the 
> >> servers changes, or policies change, or etc... that we might lose 
> >> access.  To me this seems like an incredibly poor argument right now 
> >> especially considering that we have been experiencing this very thing 
> >> and even worse with our own current infra.  The problems I have seen are
> that we:
> > 
> > there was an offer for new corporate sponsored infra. you have no idea 
> > how close things were to that infra just vanishing a few weeks ago if 
> > it had been used. we'd be back to begging for someone else to provide 
> > it or everyone having to pony up and pay for some hosting and have 
> > given up osuosl who have served us well (when you know the details).
> > 
> >> A. Failed at maintaining the physical aspects of our server.
> > 
> > i personally ordered 2 replacement drives for our server recently(ish) 
> > and i care. i had hoped people physically closer would handle things 
> > first, but that didn't happen, so i did. there are other issues which 
> > i'm sorting through and have been blocked by other configuration issues.
> > 
> >> B. Keep having continued downtime over and over and over again.
> > 
> > actually we don't. we had downtime because of a software configuration 
> > issue for years regarding qemu and logging. this would have happened 
> > anywhere with any infra if we used vm's and had the same setup.
> > 
> >> C. Can never get in touch with or get a response from our server 
> >> admin in any kind of remotely adequate timeframe.
> > 
> > admin, server+hosting and what runs on them are different matters. 
> > conflating them all is a bad idea.
> > 
> > this is why our infra needs multiple hands from multiple people 
> > involved so there is always a backup. that is what i want to happen 
> > with e5 once its back up. it has to be easier to manage remotely for 
> > people who are not full-time looking at the system and know it 
> > backwards. so system has to be pretty boring and "standard" as 
> > possible. it may be less secure as a result but that's better than not
> having multiple hands making light work.
> > 
> >> Insanity is often said to be defined as doing the same thing over and 
> >> over again expecting a different result.  It is time to have an open 
> >> mind to the needs/wants of this community and make a change.
> > 
> > we just had a near fatal miss above AND osuosl have done a great job 
> > over the years. they have more recently been locked out of helping out 
> > much (the ipmi thing as well as server access to OS has not been given 
> > to them like a working account with root access).
> > 
> > the current e.org is not even running inside osuosl. it's a temporary 
> > server meant for "getting containers set up on our original server inside
> osuosl".
> > that has not happened after 1.5 years. i'm, not interested i going 
> > into blame or what should have been done when or by who. i do want to 
> > say that i consider beber a friend and he has done a lot of work over 
> > the years and invested his time and effort and more and i totally respect
> that.
> > 
> > now that temporary server runs somewhere only beber knows about right 
> > now and since it seems the host had physical problems, only he can do 
> > anything about that. i couldn't ssh in and do anything - no access was 
> > possible for me. this temporary machine is e6.
> > 
> > the osuosl machine (e5). is up and working but 1 drive isn't 
> > responding. fixing this has been delayed because ipmi access has not 
> > worke

Re: [E-devel] Esysinfo

[Jérémy Zurcher]

hats off, it's very nice !!

On Monday 04 June 2018  12:06, Al Poole wrote :
> Hi all,
> 
> I've been working on a system monitor.
> 
> https://git.enlightenment.org/devs/netstar/esysinfo.git
> 
> http://haxlab.org/images/esysinfo.png - screenshot
> 
> Working with Linux, MacOS, FreeBSD and OpenBSD.
> 
> I hope you can enjoy! It's a start and would be very happy for anyone
> to contribute.
> 
> Thanks guys!
> 
> Alastair (netstar)
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Off

[Jérémy Zurcher]

On Thursday 31 May 2018  18:26, Michael Jennings wrote :
> On Thu, May 31, 2018 at 8:16 AM, William L. Thomson Jr.
>  wrote:
> 
> > I will deviate with all others and to me this is good news!!! I have had
> > few if any interactions with Cedric. One of my first and maybe only was
> > nothing but insults from him... Which he jumped in out of no where...
> >
> > https://phab.enlightenment.org/T6221#102021
> >
> > His comments were uncalled for, insulting, and hardly the actions of an
> > respected leadership Or even a respectful person!!!
> >
> > He went on to insult more...
> > https://phab.enlightenment.org/T6221#102027
> >
> > Then saying I am rude and insulting... Pot calling the kettle black...
> > I did not hijack his bug report as he did mine... RUDE
> > He had no business commenting on that at all!!!
> 
> He was absolutely right, and you were absolutely wrong.  Your comments
> about his attitude and behavior were uncalled-for and out-of-line, but
> your racist and bigoted comments regarding his nationality/ethnicity
> were completely and utterly unacceptable in civilized discourse, not
> to mention in violation of our Community Guidelines.
> 
> "I see you are French so likely an immigrant to the US. That you are
> French says enough right there Now your conduct makes much more
> sense to me Samsung and Tizen is doomed"
> 
> That is an absolutely horrifying statement, no different than if you
> had said, "That you are black" or "That you are a woman."  We do not
> tolerate bigotry, racism, or any other intolerant/hate speech directed
> at *anyone*, let alone one of the longest-term and most valuable
> developers we have!
> 
> Furthermore, your constant rants and tirades are toxic to this
> community.  Your technical contributions are valued and appreciated,
> but the tone and attitude with which you regularly present them
> is...off-putting, to say the least.  With a little bit of effort, you
> could learn to say the same things without the snark and petty
> insults/jabs at the developers, and you'd be a lot less likely to
> receive the same in return.
> 
> What's worse, you frequently lecture the community on our rudeness,
> our hostility, our lack of self-reflection/self-awareness, and so
> forth...yet the fact that each of those things can be accurately said
> about *you* seems to somehow escape your notice.  I'm not sure if you
> are just unaware of how you come across to others and how your diction
> and tone hinder your effectiveness as a communicator (often causing
> your message to be lost or overshadowed) or if you simply don't care.
> For the sake of your future relationships, both professional and
> interpersonal, I would encourage you to focus less on the behavior of
> others -- something you cannot affect -- and more on your own approach
> to interaction -- upon which you can have significant impact! :-)
> 
> > Cedrics participation only ended up in my loss of my phabricator
> > account. Contributed nothing of technical value to that technical
> > issue. Which I do not believe that issue is resolved, as many others
> > with elm_code which still remain... Preventing progress with Ecrire.
> > https://github.com/Obsidian-StudiosInc/ecrire/issues
> >
> > None of which Cedric is working on, so why he got involved?
> 
> Because he is a senior member of this community (as am I), having been
> involved for many years, and bears a certain amount of personal
> responsibility for the health of the community.  So when we see a less
> senior developer getting verbally flogged for no good reason, as
> happened to Andy Williams in that Phab ticket, we sometimes feel
> compelled to intervene on behalf of the attacked.
> 
> The verbal berating Andy got from you for doing nothing more than
> removing an unnecessary and potentially confusing use of a TLA from a
> bug report (and by the way, SOL means "Shit Outta Luck," but it can
> also mean "Serial-Over-LAN" or "Simulation-Oriented Language" or over
> 300 other things...not to mention it's the actual name of the Sun, so
> Andy was right on!) was beyond inappropriate.  Literally the very
> first response from you was to snidely critique his time management
> skills, accuse him of trying to control other people, and ASSUME that
> he doesn't know what "SOL" stood for!  And later on you admonish him
> for how he handled the situation, saying he should "start out by being
> nice and thankful," and yet you *yourself* started out being
> judgmental and condescending, not "nice and thankful!"  Do you not see
> the immense hypocrisy?  Your constant attacks on others for exactly
> the same behaviors you yourself continue to exhibit is exhausting and
> toxic.
> 
> Cedric was absolutely justified in intervening.  Had I seen what
> transpired, I'd have done the exact same thing.
> 
> > IMHO these people who have been around for a long time are likely more
> > of the reason for the lack of new people, and direction things have
> > gone. They surely h

Re: [E-devel] Off

[Jérémy Zurcher]

On Thursday 31 May 2018  12:20, William L. Thomson Jr. wrote :
> On Thu, 31 May 2018 12:42:09 -0300
> Felipe Magno de Almeida  wrote:
> 
> > On Thu, May 31, 2018 at 12:37 PM, William L. Thomson Jr.
> >  wrote:
> > > On Thu, 31 May 2018 11:35:26 -0300
> > > Felipe Magno de Almeida  wrote:
> > >
> > > I am not here to be liked  
> > 
> > Then you're doing a good job.
> 
> Felipe,
> Do realize your comments are insulting? Maybe by intention.
> Have we ever interacted before?
> 
> Your first contact is to insult someone you do not know, to defend
> someone you do. That makes sense Guess I should like you?
> 
> > > IMHO to be an adult, you must learn to work with and deal with those
> > > you do not like. You cannot just cast people you dislike aside.  
> > 
> > Fortunately, some people I can.
> 
> Doors can swing both ways. When it is used against you. You may feel
> otherwise or not. Freedom is not about exclusion... or freedom for some.
> 
> That is really sad state of FOSS if people feel others should be
> excluded because they are not liked. What does that say to minorities?
> If you have such issues with me. What chance do others stand?
> Given the way some black and Hispanics conduct themselves in the US.
you said enough ...
> Or what about South America? Or poor African countries? They would also
> not be liked. I think you all fail to realize such...

you are mixing everything up,
skin colors, mother land, whatsoever,
it has strictly nothing to do with behaviour if FOSS !!!

beeing liked && minorities ...
I can't even undersand how you can link these two concepts together.

South Amireca, poor African countries not beeing liked ...

you are simply insuinating that people here are judging this,
and that is uttrly unacceptable.

> 
> California has massive Hispanic populations. Where are they in tech?
> Or African Americans?
> https://techcrunch.com/2018/04/29/black-founders-matter-wants-to-raise-10-million-to-fund-black-led-startups/
> 
> It is not about the color of their skin Its about they way they
> conduct themselves. It is different Thus not accepted... Sad!!!
> 
> -- 
> William L. Thomson Jr.



> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot

> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Off

[Jérémy Zurcher]

On Thursday 31 May 2018  14:55, William L. Thomson Jr. wrote :
> On Thu, 31 May 2018 18:42:07 +0100
> Andrew Williams  wrote:
> 
> > This is absolutely unacceptable William. We have community guidelines.
> 
> We have difference of opinions on acceptable. Going back to our 1 hour
> discussion on my use of the word ditch  I can provide the  IRC log.
> 
> I mentioned in a E presentation early on... I will see if I can find
> where I mention that and the rooms reaction... Different cultures...
> https://www.youtube.com/watch?v=jbDpKjznI3M
> 
> Some say its colour some say its color. Favourite to favorite. Many
> things in the world are seen and interpreted differently...
> 
> > https://www.enlightenment.org/contact
> > Note “Please treat everyone with kindness and respect.”
> 
> Except I should not receive that right?
> Have I been shown kindness and respect?
> You get what you put out...
> 
> You may think you have been kind and respect. When I am telling you I
> was insulted. Just like you say I am not kind or respectful...
> I even show you in in links, which are ignored
> Policies must be enforced equally for them to have any merit!!!
> 
> > Your behaviour is clearly in violation of the community that the team
> > are trying to defend and I hope that someone who can do so will take
> > action
> 
> You all already have... You disabled my phab account, banned my other
> email address. That is how you welcome new people to the community?
> What does that say to others? Do you think people want to join
> something when they see others being banned?
> 
> That also hurts you all more than it harms me. I cannot report
> unknown issues so they cannot be addressed. Much less any contributions.
> 
> I can move on and contribute else where. Most FOSS projects welcome all
> the help they can get. Many here have said you all could use more
> contributors and lost them over the years... I am sure bans will help!!!
> 
> FYI my Gentoo bans have lead to me replacing all Java on Gentoo, but
> Gentoo does not benefit. Their loss not mine

you are poisonous ...
you heaten up every thread,
I would ban you out of the www if I had the power to.

my very personal thought.

all of the above just proves that you do have behaviour issues, sorry.

> 
> Current
> https://github.com/Obsidian-StudiosInc/os-xtoo/tree/master/dev-java/
> 
> Bitrotting all old versions
> https://github.com/gentoo/gentoo/tree/master/dev-java
> 
> 2yr old PR I did long ago, as I used to maintain Tomcat on Gentoo...
> https://github.com/gentoo/gentoo/pull/1358
> 
> May - June 2017
> https://github.com/Obsidian-StudiosInc/os-xtoo/commits/master/www-servers/tomcat
> 
> You all need to seriously self reflect and STOP blaming others
> Others outside just reading all this, may not feel as you do. I have
> already seen that in Gentoo
> https://archives.gentoo.org/gentoo-dev/message/a6008dc2d2ebf57a90e1912ea53b1484
> 
> Gentoo has moved to restricted postings on its development mailing list
> https://archives.gentoo.org/gentoo-dev/message/1bf08a0150b840cc7ea4218ef05a3311
> 
> That only hurts Gentoo, not me or others... Look at this new
> persons comments and the response
> https://archives.gentoo.org/gentoo-dev/message/e98d2ef0c3916f6f1f020e8197b7535f
> 
> I have been banned from Gentoo mailing list since December, yet
> Gentoo problems persist.
> 
> They cut off my bugzilla access over my comments regarding EFL and E
> https://bugs.gentoo.org/648816#c16
> 
> Now I cannot respond to this issue regarding E on Wayland.
> https://bugs.gentoo.org/show_bug.cgi?id=652340
> 
> Just like I cannot respond to any bug I filed in phabricator
> for EFL or E
> https://phab.enlightenment.org/maniphest/query/oyqdpfh9GVBn/#R
> 
> All those tasks are orphaned now I cannot respond...
> 
> How does that help the community?
> How does that make anything any better?
> 
> You only hurt the EFL/E community you think your protecting
> Though I doubt that will be seen the same as we have differences of
> opinion on may things.
> 
> End of the day, I would not treat you all, the way you all treat me...
> 
> -- 
> William L. Thomson Jr.



> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot

> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enl

Re: [E-devel] latest efl lifecycle commits (from cedric)

[Jérémy Zurcher]

On Thursday 31 May 2018  21:35, Vincent Torri wrote :
> I am very sad about how behaviors are these days.
> 
> But i would like to recall that, whatever you think about raster,
> whatever has been said behind the scene, he is the one who started
> everything, the EFL and E.
> 
> Vincent

You worded my thouths,
it seems to me that everybody is releasing it's own personal frustration ...
for no one's benefit.

> 
> On Thu, May 31, 2018 at 6:01 PM, William L. Thomson Jr.
>  wrote:
> > Carsten,
> >
> > On Fri, 1 Jun 2018 00:24:24 +0900
> > Carsten Haitzler (The Rasterman)  wrote:
> >
> >> i'm ->||<- that close to quitting this e/efl myself.
> >
> > Never do that
> >
> >> what i have seen over the past few months is "bugger off raster - we
> >> don't want you". i'm sorely tempted to make you happy. it'll make me
> >> oh so much less stressed. i'm going to be away for about 2 weeks... i
> >> vaguely feel like not coming back given the kind of behaviour that is
> >> "let's make stuff up to make him look bad and while i'm at it call
> >> him a despot".
> >
> > This seems quite similar to when Gentoo community got Daniel Robbins to
> > give up his BDFL over Gentoo Technologies, Inc.. Then creating the
> > absolute mess that is Gentoo Foundation. Inc. Which of course Daniel
> > Robbins left and people were happy without him... FAIL
> >
> > Things have only gotten worse Let Daniel Robbins and Gentoo be an
> > example for Carsten and E/EFL. Please do not make that mistake again!!!
> >
> > I have never met Daniel. I do not condone all his conducts, or support
> > all his ideas. That is not my place. But I respect what he started and
> > did. No matter who has done more since. For all the respect shown to
> > Cedric for his work. Same should go to Carsten for starting this
> > project, and continuing to participate. Many start something and bail.
> >
> > Any one individual or group can always move on. Some have already like
> > Bohdi Linux. If you don't like Carsten etc, you always have the choice
> > of fork etc. Re-create what he started. That stuff is not trivial!!!
> >
> > I also have my own issues with Carsten, as I am sure he does with me. I
> > just look past that stuff. It is life...
> >
> > I am shocked no one has ever had a boss, teacher, or someone above them
> > they disliked. I guess they quit or something...
> >
> > --
> > William L. Thomson Jr.
> >
> > --
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Off

[Jérémy Zurcher]

On Thursday 31 May 2018  11:44, William L. Thomson Jr. wrote :
> On Fri, 1 Jun 2018 00:21:43 +0900
> Carsten Haitzler (The Rasterman)  wrote:
> 
> > On Thu, 31 May 2018 10:16:34 -0400 "William L. Thomson Jr."
> >  said:
> > 
> > dude... no need for that. :( cedric has done lots of good work. 
> 
> I never commented on his work, or said anything to that effect
> 
> > i  think a fair few people have had their tussles with you. in fact of
> > late i even commented to some people that you seem quite nice
> > lately... :)
> 
> You all have likely never met someone like me or interacted with them.
> I tend to respond as I am treated, golden rule. I most always start with

eye for an eye, tooth for a tooth, come on ...
that is not the place for such cocky talk !!!

> respect and politeness. But that can be interpreted differently based on
> language, culture etc. You see me as disrespectful, and I see the same
> in return about others. Who is correct? Neither.
> 
> I find many cultures to be insulting, but I understand that is their
> ways. That is life. Not all will get along or agree on conduct. The
> world is very diverse Accept other cultures and conduct, rather
> than change. Understand and figure ways for all to work together.
> 
> -- 
> William L. Thomson Jr.



> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot

> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] EFL Profiling Viewer 1.1 released

[Jérémy Zurcher]

Hi,

what is the value of your env var $DESTDIR ?
what is the value of -DCMAKE_INSTALL_PREFIX:PATH=$PREFIX when you invoke cmake ?

it's all about these
my cmake_install.cmake files are full of (PREFIX=/opt/efl)
"$ENV{DESTDIR}/opt/efl/bin/efl_profiling_viewer"
"$ENV{DESTDIR}/opt/efl/lib/libefl_profiler.so"

On Tuesday 27 March 2018  19:10, William L. Thomson Jr. wrote :
> Tried this again using make instead of ninja, the default cmake
> generator. Which had no problems with generated the pot file so must
> have been ninja specific. But I ran into install related issues.
> 
> l-profiler-viewer-1.1_build"
> [  3%] Generating pot
> [  7%] Built target time_interval_edj
> [ 10%] Built target create_edj
> [ 10%] Built target update_pot
> [ 14%] Generating po
> Updating po-files...
> en.po
>  done.
> ru.po
>  done.
> uk.po
>  done.
> [ 14%] Built target update_po
> [ 17%] Generating mo
> Generation mo-files...
> en.mo
> ru.mo
> uk.mo
> [ 17%] Built target generate_mo
> [ 85%] Built target efl_profiler
> [ 92%] Built target efl_profiler_time_interval
> [100%] Built target efl_profiling_viewer
> Install the project...
> -- Install configuration: "Gentoo"
> CMake Error at cmake_install.cmake:49 (file):
>   file called with network path DESTINATION.  This does not make sense
> when using DESTDIR.  Specify local absolute path or remove DESTDIR
> environment variable.
> 
>   DESTINATION=
> 
>   //lib/cmake/efl_profiler
> 
> make: *** [Makefile:86: install] Error 1
> 
> 
> On Fri, 22 Dec 2017 14:42:54 -0500
> "William L. Thomson Jr."  wrote:
> 
> > Ran into a build issue, maybe ninja specific not sure. I switched all
> > E cmake based ebuilds over to ninja generator from autotools. Cmake
> > supports both autotools/make and ninja. Thus far I have yet to see any
> > build issues specific to ninja. Though I suspect this maybe one.
> > 
> > ninja: error:
> > '/tmp/portage/dev-util/efl-profiler-viewer-1.1/work/v1.1/po/efl_profiler.pot',
> > needed by 'po/po', missing and no known rule to make it
> > 
> > I know meson has means to generate an initial pot file but I do not
> > believe cmake has such feature.
> > http://mesonbuild.com/Localisation.html
> > 
> > Aside from that one aspect I much prefer cmake to meson for po file
> > management. Though meson can update PO files it does not do that
> > during every build you have to run a target for that, same with the
> > main pot file, pros and cons.
> > 
> 
> 
> 
> -- 
> William L. Thomson Jr.



> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot

> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl.task - move to returning future insead of bool + exit event

[Jérémy Zurcher]

Hi,

just trying to follow here and maybe clarify a bit.

Of course everybody here knows about the conventions :
  - 0 is the success return code
  - anything else is an (hopefully documented) error

we all know about logical shell chaining :

  cmd1 && cmd2 && cmd3 || cmd4

but what I think I understood here is that promises chaining should be a
different construction where the chaining is not dependent on the return code
(success/failure) of any of the actions.

  { action 1 } then { action 2 } then { action 3 }

it's a 'then' meaning 'after that', not an '&&' that means 'on action success'

so with v beeing the value of the promise, you do

  { action 1 } then { if (v!=0) return action21 else return action22 } then { 
if (v==0) action 3 }

and with handy helpers (operator logic) like

  bypassOnFailure(if (v!=0) return v)
  bypassOnSuccess(if (v==0) return v)

you can do

  { action1 } then { bypassOnFailure(); action2 } then { bypassOnSuccess(); 
action3 } then { byPassOnFailure; action4 }

the chaining fails on "System errors" -> Exception on some languages
the logic is implemented in the futur

hope I'm not in outer space.

On Thursday 22 March 2018  09:36, Carsten Haitzler wrote :
> On Wed, 21 Mar 2018 14:18:39 -0400 Cedric Bail  said:
> 
> > On March 20, 2018 6:14 PM, Carsten Haitzler  wrote:
> > > On Tue, 20 Mar 2018 12:06:08 -0400 Cedric Bail ced...@ddlm.me said:
> > > > On March 20, 2018 7:38 AM, Carsten Haitzler ras...@rasterman.com wrote:
> > > > > On Tue, 20 Mar 2018 10:06:43 -0300 Gustavo Sverzut Barbieri
> > > > > barbi...@gmail.com said:
> > > > 
> > > > 
> > > > 
> > > > > > I said I'd give up... but seeing this makes me sad.
> > > > > > in two lines you: misused the Eina_Error AND missed the purpose of
> > > > > > resolve.
> > > > > > 
> > > > > > I hoped when you looked at it, written as code, you'd realize the
> > > > > > mistake... but seems not... so I'm pointing here.
> > > > > > 
> > > > > > eina_error conversion to string (which will be helpful to high level
> > > > > > languages) is missed, "+ 100" is an error that is not
> > > > > > registered...
> > > > > > 
> > > > > > OTOH success is always ZERO, so there is no value... IF that would 
> > > > > > be
> > > > > > right, then it should be a void promise (carries no value).
> > > > > > 
> > > > > > but my hope is that you'll simply move this to
> > > > > > eina_promise_resolve(pd->promise, eina_value_int_init(exit_code))
> > > > > > 
> > > > > > and listen to my advice that is to move the "!= 0" OUTSIDE of this
> > > > > > function, you're mixing roles :-/
> > > > > 
> > > > > eh? we only have 1 value to know of success or failure. an int. 0 ==
> > > > > success. anything else is failure. that's precisely what i did right
> > > > > there.
> > > > 
> > > > No. Think about what Eina_Error mean for binding. It will trigger an
> > > > exception in some language. Now the user as to catch exception and
> > > > instead of doing a switch on expected real error, it has to work around
> > > > this hack to get the real exit status. Additionnaly, there is no
> > > > requirement/guarantee in Eina_Error that this error code will never be
> > > > used for something else.
> > > 
> > > i'm not the one coming up with raising exceptions or not, BUT i mentioned
> > > this before. shell:
> > > 
> > > cmd1 && cmd2 && cmd3
> > >
> > > is a chain of promises. they are the same thing. if cmd1 succeedsm then 
> > > run 
> > > cmd2, if that succeeds run cmd3. if the "it doesnt succeed" is done via an
> > > exception - then promises are going to SUCK.
> > 
> > Great example. This is not a chain of error/success, but a logical and
> > operator, the same way you would do in C :
> > 
> > if (f1() && f2() && f3())
> 
> which is a chain of success only. fo f1, if that is true then f2, if that is
> true then f3.
> 
> if the promises don't fail when the error code is non-zero then you can't 
> chain
> like the above.
> 
> > A chain of future is not designed to just implement the above line, but you
> > should be able to do also :
> > 
> > do || fallback
> 
> and that is a different kind of chain which actually does both things
> irrespective, but logically or's the result. so if do AND fallback both errors
> your result will be "false" (promises just extend this logic over time async
> rather than in-line in a blocking kind of way like if's etc.)
> 
> > or even :
> > 
> > [$? -ne 5]
> > 
> > In all of this case, it is using $? value explicitely or implicitely. It
> 
> in this case you are checking the error code to see what kind of error. an 
> exit
> code of 5 never should imply success. not in the world of the command line
> shell. i didn't make those rules. i'm just following the pattern.
> 
> > would be the same in C, a value. So during a future resolution is when you
> > take a decision on what to do with the value, should it be a &&, ||, -ne, 
> > -eq
> > or whatever. future/promise are a generic construct, they are not supposed 
> > to
> > just handle t

Re: [E-devel] A step to improving communication - Meetings

[Jérémy Zurcher]

smack slack !!

https://get.slack.help/hc/en-us/articles/201727913-Connect-to-Slack-over-IRC-and-XMPP

long life to irc clients 

On Friday 09 March 2018  10:08, Jonathan Aquilina wrote :
> Hi Stefan you forgot there is slack and can speak in the channel on Irc that 
> way if we have the bot there as well they can join us through slack
> 
> Sent from my iPhone
> 
> > On 09 Mar 2018, at 10:03, Stefan Schmidt  wrote:
> > 
> > Hello.
> > 
> > 
> >> On 03/08/2018 06:40 PM, William L. Thomson Jr. wrote:
> >> One thing I have seen be of benefit in other communities is having
> >> regular meetings.
> >> 
> >> It was definitely beneficial to Gentoo Java Team, long ago. This some
> >> what helped create a team, and definitely helped keep people on the same
> >> page, helped with communication, etc. When meetings ended, so did the
> >> team over time. They helped make the team and broke it...
> >> 
> >> Does the E developer community ever meet beyond like EDD? Like regular
> >> monthly meetings in IRC or other?
> > 
> > No we don't and I think it is a good idea you brought up here.
> > 
> > I think we should try it out and see how it flies for us.
> > 
> > I would propose IRC as medium (already heavily in use, suitable for many 
> > attendees even if just lurking around, video calls might be awkward
> > and problematic with many attendees)
> > 
> > I would also propose it to be bi-weekly. That misses the nice regularity of 
> > weekly meetings, but I think that might be a bit to often. Maybe
> > I am wrong and weeklies would be better. Hard to say.
> > 
> > Finding the right time slot is problematic though. As far as I see it we 
> > might have attendance from US west and east coast, Europe as well
> > as Asia. What should we do about it?
> > 
> > regards
> > Stefan Schmidt
> > 
> > --
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Current State and Future Direction of E/EFL

[Jérémy Zurcher]

Rust uses github bot to post commits after testing thus ensure a good state 
master branch.

https://github.com/barosl/homu
https://www.youtube.com/watch?v=dIageYT0Vgg


On Tuesday 06 March 2018  17:01, Simon Lees wrote :
> 
> 
> On 06/03/18 15:50, jaquilina wrote:
> > Hi simon,
> > 
> > I think what you are talking about is gerrit code review. I know
> > Libreoffice use it and for them I think you need to have 3 reviewers
> > before the code is committed as well the code gets compiled and built as
> > well to ensure it works.
> > 
> > https://gerrit-review.googlesource.com/Documentation/intro-how-gerrit-works.html
> > 
> > 
> > I am not sure if jenkins has a flow like what you are describing, but at
> > least you have more control over the quality of whats committed.
> > 
> 
> Yeah I'm suggesting that we don't need to go as far as needing 1-3 (or
> any number of human reviewers) atleast for committers who have commit
> access.
> 
> I have contributed to projects via github that have an intergrated
> jenkins (or something similar) bot that blocks the pull request being
> accepted until atleast build tests have been done and other simple error
> checking is done. So in a sense rather then jenkins running once a day
> its running for every commit (or group) and giving direct feedback that
> these commits will break the build so you should go and fix them, rather
> then Stefan having to wait and check Jenkins then go bug people to fix
> there work for breaking things.
> 
> -- 
> 
> Simon Lees (Simotek)http://simotek.net
> 
> Emergency Update Team   keybase.io/simotek
> SUSE Linux   Adelaide Australia, UTC+10:30
> GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B
> 



> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot

> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/03: efl thread signal masks - fix up for various threads manually created

[Jérémy Zurcher]

Hi,

just jumping here as your are talking about late ecore signal changes
and working on them I guess,

git bisect tells me that it's because of ba16dee6b3,
that I can't send SIGINT to terminology using Ctrl-C anymore.

--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: music-control - install properly with meson build with icon

[Jérémy Zurcher]

nice !

so you did not chose to have the install commands themselves to use sudo ;)))

On Saturday 02 December 2017  00:10, marcel-hollerb...@t-online.de wrote :
> Hello,
> 
> so it turned out that this is a ninja bug.
> 
> Ninja has some sort of recompactination if the number of entries in the
> .ninja_log and .ninja_deps files are getting too big, then it will cut
> off a few, write that into a temp file, and rename that temp file later
> to .ninja_log or .ninja_deps, if you ran exactly this time ninja as root
> it will place .ninja_log and .ninja_deps as root owned files in the
> directory instead of maintaining the old gid / uid of the file.
> 
> tldr:
> There is a bugfix:
> https://github.com/ninja-build/ninja/pull/1362
> 
> Greetings,
>Marcel Hollerbach
> 
> On Thu, Nov 23, 2017 at 08:57:20AM +0900, Carsten Haitzler wrote:
> > On Wed, 22 Nov 2017 20:13:48 + Mike Blumenkrantz
> >  said:
> > 
> > > I'm on fedora with meson 0.42.1 and ninja 1.8.2
> > 
> > Can you try doing the "build as user, install as root/sudo" and hit the 
> > issue
> > and details exactly what files are owned by root at that point and what file
> > the problem is with and why the permission problem is there? I just can't 
> > see
> > the source of the issue in my build trees.
> > 
> > > On Wed, Nov 22, 2017 at 1:08 PM Andrew Williams 
> > > wrote:
> > > 
> > > > Hi,
> > > >
> > > > I'm on Arch and generally try to stay up to date so maybe they have 
> > > > fixed
> > > > it?
> > > > Mike?
> > > >
> > > > On Wed, 22 Nov 2017 at 15:55 Jérémy Zurcher  wrote:
> > > >
> > > > > I can't reproduce that root owner ship issue right now.
> > > > > I made the changes to my scripts on the 2017/08/17
> > > > > at that time on my archlinux boxes ninja was 1.7.2 and meson was 
> > > > > 0.41.2
> > > > > since then ninja has been upgraded to 1.8.2, and meson to 0.42.1 then
> > > > > 0.43.0
> > > > > maybe it has been fixed in one of them fixed now.
> > > > > (but I won't dive into their respective repos to check that ;)
> > > > >
> > > > >
> > > > > On Wednesday 22 November 2017  20:51, Carsten Haitzler wrote :
> > > > > > On Wed, 22 Nov 2017 10:36:36 + Andrew Williams <
> > > > a...@andywilliams.me>
> > > > > said:
> > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > I'm glad that it is not affecting you. Jeyzu and I both seem to 
> > > > > > > have
> > > > > hit
> > > > > > > this issue (and I guess zmike too as described earlier).
> > > > > > > Some times after a "sudo ninja install" I can no longer "ninja" 
> > > > > > > due
> > > > to
> > > > > > > permissions issues with files that have become root owned.
> > > > > > >
> > > > > > > It is unfortunate but it would be good to get a solution that 
> > > > > > > works
> > > > > all the
> > > > > > > time for everyone if possible.
> > > > > >
> > > > > > I checked what files were root owned. I currently don't see a reason
> > > > why
> > > > > it
> > > > > > should fail. Someone show me a reason where it does fail (a file
> > > > written
> > > > > to as
> > > > > > root has to be overwritten as a user or it cannot be deleted as a
> > > > user).
> > > > > I
> > > > > > don't see it. perhaps its a bug in meson in an older version? or a
> > > > newer
> > > > > one?
> > > > > >
> > > > > > > Andy
> > > > > > >
> > > > > > > On Wed, 22 Nov 2017 at 10:17 Carsten Haitzler 
> > > > > > > 
> > > > > wrote:
> > > > > > >
> > > > > > > > On Wed, 22 Nov 2017 10:33:05 +0100 Jérémy Zurcher 
> > > > > > > >  > > > >
> > > > > said:
> > > > > > > >
> > > > > > > > > Hi,
> > > > > > > > >
> > > > > > > > > I confirm, I had to add the abov

Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: music-control - install properly with meson build with icon

[Jérémy Zurcher]

I can't reproduce that root owner ship issue right now.
I made the changes to my scripts on the 2017/08/17
at that time on my archlinux boxes ninja was 1.7.2 and meson was 0.41.2
since then ninja has been upgraded to 1.8.2, and meson to 0.42.1 then 0.43.0
maybe it has been fixed in one of them fixed now.
(but I won't dive into their respective repos to check that ;)


On Wednesday 22 November 2017  20:51, Carsten Haitzler wrote :
> On Wed, 22 Nov 2017 10:36:36 + Andrew Williams  
> said:
> 
> > Hi,
> > 
> > I'm glad that it is not affecting you. Jeyzu and I both seem to have hit
> > this issue (and I guess zmike too as described earlier).
> > Some times after a "sudo ninja install" I can no longer "ninja" due to
> > permissions issues with files that have become root owned.
> > 
> > It is unfortunate but it would be good to get a solution that works all the
> > time for everyone if possible.
> 
> I checked what files were root owned. I currently don't see a reason why it
> should fail. Someone show me a reason where it does fail (a file written to as
> root has to be overwritten as a user or it cannot be deleted as a user). I
> don't see it. perhaps its a bug in meson in an older version? or a newer one?
> 
> > Andy
> > 
> > On Wed, 22 Nov 2017 at 10:17 Carsten Haitzler  wrote:
> > 
> > > On Wed, 22 Nov 2017 10:33:05 +0100 Jérémy Zurcher  said:
> > >
> > > > Hi,
> > > >
> > > > I confirm, I had to add the above in my build script :
> > > >
> > > > sudo -S chown $USER $BUILD_DIR/.ninja_deps $BUILD_DIR/.ninja_log
> > >
> > >  7:14PM ~/C/e/build ⎇ master > ls -al
> > > total 4.4M
> > > 4.0K drwxr-xr-x  9 raster raster 4.0K Nov 22 15:36 ./
> > > 4.0K drwxr-xr-x 10 raster raster 4.0K Nov 22 15:36 ../
> > > 1.6M -rw-r--r--  1 raster raster 1.6M Nov 22 15:36 .ninja_deps
> > >  64K -rw-r--r--  1 raster raster  61K Nov 22 15:36 .ninja_log
> > >
> > > written not as root. (make ninja install was as root). ... ?
> > >
> > > > On Wednesday 22 November 2017  08:18, Andrew Williams wrote :
> > > > > Hi,
> > > > >
> > > > > Compiling as root may be a bad thing but mike is right, ninja install
> > > hits
> > > > > log files and other - some times causing root ownership. I have seen 
> > > > > it
> > > > > occasionally myself and have had to either delete the build tree or
> > > chown
> > > > > it to myself.
> > > > >
> > > > > Perhaps this is a bug we should be reporting but in the meantime our
> > > docs
> > > > > should cover it somehow.
> > > > >
> > > > > Andy
> > > > > On Wed, 22 Nov 2017 at 00:19, Carsten Haitzler 
> > > wrote:
> > > > >
> > > > > > On Tue, 21 Nov 2017 16:37:09 + Mike Blumenkrantz
> > > > > >  said:
> > > > > >
> > > > > > > The wording is intentional. The meson build has a tendency to 
> > > > > > > touch
> > > > > > > build files during the install phase (which must be run as root to
> > > > > > > install to
> > > > > > the
> > > > > > > base system), meaning that failure to use sudo during general
> > > build will
> > > > > > > fail for subsequent builds anyway due to permissions errors when
> > > > > > attempting
> > > > > > > to modify root-owned files.
> > > > > >
> > > > > > i have never had a permission error after a "sudo ninja install" to
> > > just
> > > > > > run
> > > > > > ninja as me to rebuild whatever changed. it's just the gmo files 
> > > > > > (and
> > > > > > install
> > > > > > log which obviously is written as root) from gettext... and they are
> > > only
> > > > > > re-generated by root so ... root overwrites root files. you can
> > > delete
> > > > > > these
> > > > > > files because they are in a directory owned by you (the user).
> > > > > >
> > > > > > so where is the actual permission problem? a ninja && sudo ninja
> > > install
> > > > > > will
> > > > > > succeed without permission problems (see above). you as a user can
> > > delete

Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: music-control - install properly with meson build with icon

[Jérémy Zurcher]

Hi,

I confirm, I had to add the above in my build script :

sudo -S chown $USER $BUILD_DIR/.ninja_deps $BUILD_DIR/.ninja_log


On Wednesday 22 November 2017  08:18, Andrew Williams wrote :
> Hi,
> 
> Compiling as root may be a bad thing but mike is right, ninja install hits
> log files and other - some times causing root ownership. I have seen it
> occasionally myself and have had to either delete the build tree or chown
> it to myself.
> 
> Perhaps this is a bug we should be reporting but in the meantime our docs
> should cover it somehow.
> 
> Andy
> On Wed, 22 Nov 2017 at 00:19, Carsten Haitzler  wrote:
> 
> > On Tue, 21 Nov 2017 16:37:09 + Mike Blumenkrantz
> >  said:
> >
> > > The wording is intentional. The meson build has a tendency to touch build
> > > files during the install phase (which must be run as root to install to
> > the
> > > base system), meaning that failure to use sudo during general build will
> > > fail for subsequent builds anyway due to permissions errors when
> > attempting
> > > to modify root-owned files.
> >
> > i have never had a permission error after a "sudo ninja install" to just
> > run
> > ninja as me to rebuild whatever changed. it's just the gmo files (and
> > install
> > log which obviously is written as root) from gettext... and they are only
> > re-generated by root so ... root overwrites root files. you can delete
> > these
> > files because they are in a directory owned by you (the user).
> >
> > so where is the actual permission problem? a ninja && sudo ninja install
> > will
> > succeed without permission problems (see above). you as a user can delete
> > the
> > effected files too.
> >
> > but suggestion people compile as root is a bad idea.
> >
> > ???
> >
> > > On Mon, Nov 20, 2017 at 8:14 PM Carsten Haitzler 
> > > wrote:
> > >
> > > > On Mon, 20 Nov 2017 15:04:48 + Mike Blumenkrantz
> > > >  said:
> > > >
> > > > > Issues had been found at an inconvenient time during review, so I
> > left
> > > > the
> > > > > branch unmerged so that someone could either push while I was gone
> > or I
> > > > > could push when I returned.
> > > >
> > > > I saw you pushed now. so we know the status. This also clears up the
> > build
> > > > system state. I guess I should ensure it's documented. I see README
> > > > changed but
> > > > i am not sure it's correct as it's going to do a build as root... i'll
> > deal
> > > > with it. :)
> > > >
> > > > > On Sun, Nov 19, 2017 at 6:56 PM Carsten Haitzler <
> > ras...@rasterman.com>
> > > > > wrote:
> > > > >
> > > > > > On Sun, 19 Nov 2017 13:05:06 + Andrew Williams <
> > > > a...@andywilliams.me>
> > > > > > said:
> > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > As the autotool/Makefiles are still in place I fixed the build
> > for
> > > > users
> > > > > > > not yet using the E meson build.
> > > > > >
> > > > > > i was assuming autotools was dead - mike did say he'd push his
> > > > autotools
> > > > > > removal branch "in a day or 2 if no issues"... that about 1-2 weeks
> > > > back. i
> > > > > > didn't see it happen and didn't hear of issues...
> > > > > >
> > > > > > are there any? I'd consider merging his branch to remove autofoo at
> > > > this
> > > > > > point.
> > > > > > If meson has issues it should be tested and they should be fixed.
> > > > > >
> > > > > > > Andy
> > > > > > >
> > > > > > > On Fri, 17 Nov 2017 at 03:19 Carsten Haitzler <
> > ras...@rasterman.com>
> > > > > > wrote:
> > > > > > >
> > > > > > > > raster pushed a commit to branch master.
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > >
> > > >
> > http://git.enlightenment.org/core/enlightenment.git/commit/?id=f4d2d02ba0f15b7f36e7de61141ff88c145f5630
> > > > > > > >
> > > > > > > > commit f4d2d02ba0f15b7f36e7de61141ff88c145f5630
> > > > > > > > Author: Carsten Haitzler (Rasterman) 
> > > > > > > > Date:   Fri Nov 17 12:17:42 2017 +0900
> > > > > > > >
> > > > > > > > music-control - install properly with meson build with icon
> > > > > > > >
> > > > > > > > @fix
> > > > > > > > ---
> > > > > > > >  ...-module-music_control.edj => e-module-music-control.edj} |
> > Bin
> > > > > > > >  src/modules/music-control/meson.build
> >  |   2
> > > > --
> > > > > > > >  src/modules/music-control/module.desktop
> > |   2
> > > > +-
> > > > > > > >  3 files changed, 1 insertion(+), 3 deletions(-)
> > > > > > > >
> > > > > > > > diff --git
> > a/src/modules/music-control/e-module-music_control.edj
> > > > > > > > b/src/modules/music-control/e-module-music-control.edj
> > > > > > > > similarity index 100%
> > > > > > > > rename from
> > src/modules/music-control/e-module-music_control.edj
> > > > > > > > rename to src/modules/music-control/e-module-music-control.edj
> > > > > > > > diff --git a/src/modules/music-control/meson.build
> > > > > > > > b/src/modules/music-control/meson.build
> > > > > > > > index 996b4196f..a84f5ea8e 100644
> > > > > > > > --- a/src/modules/music-control/meson.build
> > > > > > > > +++ b/src/module

Re: [E-devel] Eina_Array step confusion

[Jérémy Zurcher]

Hello,

On Thursday 16 November 2017  11:00, Andrew Williams wrote :
> Hi,
> 
> Are there any objections to me:
> 
> 1) changing the parameter name on array creation to "size" from "step"

this is not the size of the array that is set here,
but the # of array elements used to automatically grow or shrink.

see eina_array_remove or eina_array_grow called from eina_array_push

> 2) adding eina_array_size_set which additionally does not take a sizeof
> param

that eina_array_size_set is weird,
the sizeof check is here to ... detect a wrong pointer I guess
plus if I'm not mistaken, it will silently leak if called on an non empty array 
!

> 3) deprecate the eina_array_step_set as it's semantics are strange (as per
> previous email).
> 
> Thanks.
> Andy
> 
> On Tue, 14 Nov 2017 at 13:04 Andrew Williams  wrote:
> 
> > Hi,
> >
> > When talking about arrays my understanding that "step" typically refers to
> > the number of items to jump when iterating (i.e. 1). However the eina docs
> > use step on initialisation and on step_set to indicate "size" or "count".
> >
> > Additionally eina_array_step_set takes a parameter sizeof_eina_array which
> > is documented to need to be sizeof(Eina_Array), but obviously the
> > eina_array is the first parameter. Is there any reason why we have to pass
> > that parameter?
> > What I am wonder is - can't we just create "eina_array_size_set(uint)"?
> >
> > Thanks,
> > Andy
> > --
> > http://andywilliams.me
> > http://ajwillia.ms
> >
> -- 
> http://andywilliams.me
> http://ajwillia.ms
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [tools/clouseau] master 01/01: ELM_PANES_CLASS -> EFL_UI_PANES_CLASS, follow efl commit 40945d9859

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/tools/clouseau.git/commit/?id=eca7479b59c9d1fac7ebaebf19073e3d024a7563

commit eca7479b59c9d1fac7ebaebf19073e3d024a7563
Author: Jérémy Zurcher 
Date:   Mon Aug 7 09:24:35 2017 +0200

ELM_PANES_CLASS -> EFL_UI_PANES_CLASS, follow efl commit 40945d9859
---
 src/lib/extensions/objects_introspection/gui.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/extensions/objects_introspection/gui.c 
b/src/lib/extensions/objects_introspection/gui.c
index 294360c..f149de2 100644
--- a/src/lib/extensions/objects_introspection/gui.c
+++ b/src/lib/extensions/objects_introspection/gui.c
@@ -106,7 +106,7 @@ gui_win_create(Eo *__main_parent)
 pub_widgets->highlight_ck = ck;
  }
 
-   panes = efl_add(ELM_PANES_CLASS, box);
+   panes = efl_add(EFL_UI_PANES_CLASS, box);
elm_obj_panes_content_right_size_set(panes, 0.60);
evas_object_size_hint_weight_set(panes, 1.00, 1.00);
efl_gfx_size_set(panes, 75, 75);

-- 

Re: [E-devel] ssh broken

[Jérémy Zurcher]

broken pipe error here too,
was working fine 2hours ago

On Tuesday 11 July 2017  12:23, Mike Blumenkrantz wrote :
> I've now lost all ssh access to all enlightenment-related servers on all my
> machines. The one computer which was previously working now fails with a
> broken pipe error, and the rest have the same connection closed error.
> 
> On Tue, Jul 11, 2017 at 6:22 AM Stefan Schmidt 
> wrote:
> 
> > Hello.
> >
> > On 07/11/2017 11:37 AM, Stefan Schmidt wrote:
> > >
> > >
> > > On 07/10/2017 09:24 PM, Davide Andreoli wrote:
> > >> 2017-07-10 15:33 GMT+02:00 Mike Blumenkrantz
> > >> mailto:michael.blumenkra...@gmail.com
> > >>:
> > >>
> > >> Hi,
> > >>
> > >> I've been getting this error for some time now on one of my machines
> > >> when I
> > >> try to do git/ssh operations:
> > >>
> > >> ssh_exchange_identification: Connection closed by remote host
> > >> fatal: Could not read from remote repository.
> > >>
> > >> Please make sure you have the correct access rights
> > >> and the repository exists.
> > >>
> > >> Others have been experiencing this issue as well, so it seems to be
> > >> a new
> > >> issue with server configuration.
> > >>
> > >>
> > >> Same here, I cannot perform any git operation anymore
> > >
> > > My situation is that I can pull and push to git just fine. But in the
> > > exact same shell I get a error when trying to log into a shell of our
> > > server.
> > >
> > > stefan@work efl (master) $ ssh download.enlightenment.org
> > > ssh_exchange_identification: Connection closed by remote host
> > >
> > > This blocks the upload of any efl beta2 tarballs right now.
> > > I will try to debug this a bit further on my end. As far as I can do
> > that.
> >
> > It looks like we have two different problems here:
> >
> > 1) Git access over ssh does not work. Zmike(?) as well as Dave seem to
> > have this problem. A lot of people are pushing and pulling without a
> > problem at the same time though.
> >
> > 2) SSH shell access to our server. Thanks to some hints from Marcel I
> > think we can narrow it down to a problem with our ssh proxy command
> > setup. I can access git.e.org as well as devs.e.org without a problem.
> > Both of them are not accessed via the proxy command, but directly.
> > For all server where I would need the proxy command (download, build,
> > etc) it fails for me and it also fails for Marcel. Which sounds to me
> > like a server side problem and nothing local.
> >
> > regards
> > Stefan Schmidt
> >
> >
> > --
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] chart library based on the EFL

[Jérémy Zurcher]

Hello Vincent,

nice start

there's lot of good stuff in that commercial js lib that I use
in my job http://www.fusioncharts.com/charts/

I had to add the following to compile on archlinux (might not be the
right way to do, I know nothing about meson yet) :

+cc = meson.get_compiler('c')
+
 dep_lib = [dependency('eina'),
dependency('evas'),
-   dependency('eina')]
+   dependency('eina'),
+   cc.find_library('m')]

cheers

On Thursday 29 June 2017  22:23, Vincent Torri wrote :
> Hello
> 
> I would like to introduce a small library which renders chart using
> Evas VG API :
> 
> https://github.com/vtorri/echart2
> 
> I try to mimic a bit the area chart of google :
> 
> https://developers.google.com/chart/interactive/docs/gallery/areachart
> 
> It consist of a library and a test example.
> 
> The library consists of
>  * a data API to fill data
>  * a chart API for the chart features
>  * an evas smart object for a "line" chart
> 
> the test example is the first 'area' example in google charts
> 
> I have attached a screenshot of the example
> 
> The library is in its very early state and is wip. There may be bugs
> and a lot of improvements can be done of course
> 
> the build system is meson + ninja (see README.md for instructions).
> Just install meson and ninja with your favorite package manager
> 
> I have tested echart on Windows and Fedora.
> 
> Any patches, remarks and ideas are welcome
> 
> Vincent


> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot

> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 01/01: eina: fix clang compilation with EINA_FALLTHROUGH

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=81bcc14615b7437f1548cee415347bdfb22bbede

commit 81bcc14615b7437f1548cee415347bdfb22bbede
Author: Jérémy Zurcher 
Date:   Tue Jun 6 09:58:06 2017 +0200

eina: fix clang compilation with EINA_FALLTHROUGH

btw, using clang 4.0.0, I can't produce fallthrough warnings using
-Weverything, -Wall or -Wimplicit-fallthrough
---
 src/lib/eina/eina_types.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/lib/eina/eina_types.h b/src/lib/eina/eina_types.h
index 1fd7a1e26c..57a1339fad 100644
--- a/src/lib/eina/eina_types.h
+++ b/src/lib/eina/eina_types.h
@@ -196,14 +196,15 @@
 #  define EINA_UNLIKELY(exp)__builtin_expect((exp), 0)
 #  define EINA_LIKELY(exp)  __builtin_expect((exp), 1)
 #  define EINA_SENTINEL __attribute__((__sentinel__))
-#  define EINA_FALLTHROUGH __attribute__ ((fallthrough));
 #  ifndef __clang__
+#   define EINA_FALLTHROUGH __attribute__ ((fallthrough));
 #   define EINA_PREFETCH(arg) (arg ? __builtin_prefetch(arg) : (void) arg)
 #   define EINA_PREFETCH_WRITE(arg) (arg ? __builtin_prefetch(arg, 1) : (void) 
arg)
 #   define EINA_PREFETCH_NOCACHE(arg) (arg ? __builtin_prefetch(arg, 0, 0) : 
(void) arg)
 #   define EINA_PREFETCH_NOCACHE_WRITE(arg) (arg ? __builtin_prefetch(arg, 1, 
0) : (void) arg)
 #  else
 /* LLVM Clang workaround (crash on compilation) */
+#   define EINA_FALLTHROUGH
 #   define EINA_PREFETCH(arg) ((void) (arg))
 #   define EINA_PREFETCH_WRITE(arg) ((void) (arg))
 #   define EINA_PREFETCH_NOCACHE(arg) ((void) (arg))

-- 

[E-devel] enlightenment + kernel 4.11 -> sudo fails

[Jérémy Zurcher]

Hi all,

I have to confirm that there is an enlightenment issue with sudo + kernel 4.11

 * Linux bigdaddy 4.11.2-1-ARCH #1 SMP PREEMPT Mon May 22 06:53:49 CEST 2017 
x86_64 GNU/Linux

starting fluxbox + terminology : sudo ls goes well
starting enlightenment + terminology : sudo ls =>
sudo: effective uid is not 0, is /usr/bin/sudo on a file system with 
the 'nosuid' option set or an NFS file system without root privileges?

I'll try to investigate, but don't have much time on my side ...


--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] http://git.enlightenment.org down for now

[Jérémy Zurcher]

Hello
everything about git protocols is here :  
https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols
cgit is 'only' a web presentation of git repos.

On Thursday 27 April 2017  08:07, Jonathan Aquilina wrote :
> Hi Carsten, 
> 
> What advantage does http for git have? Isn't git better to use to pull
> and push stuff to the repositories or is cgit more a web based ui to
> view the repository history etc?
> 
> ---
> Regards, 
> 
> Jonathan Aquilina 
> 
> On 2017-04-26 04:18, Carsten Haitzler wrote:
> 
> > I've had to disable the whole http support for now for git.enlightenment.org
> > because several bots are crawling it causing our VM to basically be loaded 
> > with
> > 10-20 cgit cgi's running git queries for history etc. continually. I/O and
> > system load is going through the roof as a result and causing other stuff 
> > like
> > phab to crawl and begin timing out.
> > 
> > So anyone using HTTP for doing cmdline git stuff is, at this moment, going 
> > to
> > find things not working. SSH and GIT protocol should still work. I'll keep 
> > this
> > shut down for a few hours hoping the bots give up.
> > 
> > I added a robots.txt and edited the cigtrc to deny all bots from indexing
> > git.enlightenment.org - but the bots seem to be ignoring that now that they
> > have decided to start indexing.
> > 
> > I am wondering if this has been the cause of our issues - being overloaded 
> > by
> > indexer bots. FYI I counted 3 different bots indexing cgit at the same time:
> > Baiduspider, Semrushbot, Ahrefsbot.
> > 
> > I hope later they will start listening to robots.txt, but for now I need to
> > keep things off until the bots give up.
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [E-b0rk] Build failed in Jenkins: nightly_efl_gcc_x86_64 #1417

[Jérémy Zurcher]

Hi,
I've taken care of some, maybe all, of the observations :

https://git.enlightenment.org/core/efl.git/tree/mtests.sh?h=devs/jeyzu/mtests
https://git.enlightenment.org/core/efl.git/tree/src/lib/eina/tests?h=devs/jeyzu/mtests
https://git.enlightenment.org/core/efl.git/tree/src/tests/test_macros.h?h=devs/jeyzu/mtests

colorized : http://cgit.asynk.ch/bin/tree/mtests.sh


p.s.
  sorry Raster for the noise,
  I just realized that I was answering to you instead of the ML :|


On Saturday 17 December 2016  11:55, Jérémy Zurcher wrote :
> 
> 
> Hi,
> I wrote a quick and dirty POC ...
> comments welcome
> 
> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
> #! /bin/sh
> 
> SRC_D=src
> BUILD_D=src
> CONFIG_SH=config.sh
> INIT_C=init.c
> SHUTDOWN_C=shutdown.c
> C_FILE=/tmp/__efl_test.c
> O_FILE=/tmp/__efl_test.o
> DEBUG=0
> 
> SCRIPT_DIR=${0%/*}
> SCRIPT_FILE=${0##*/}
> 
> CC=${CC:-"clang"}
> LD=""
> INCLUDE=""
> 
> function fatal {
>echo "FATAL $1"
>exit 1
> }
> 
> while [ $# -ge 1 ]; do
> case "$1" in
> -s*|--src*)
> shift
> [ $# -lt 1 ] && fatal "option -s is missing directory argument"
> SRC_D=$1
> shift
> ;;
> -b*|--build*)
> shift
> [ $# -lt 1 ] && fatal "option -b is missing directory argument"
> BUILD_D=$1
> shift
> ;;
> 
> -h|--help)
> echo "Usage:  $SCRIPT_FILE [options]"
> echo
> echo "Options:"
> echo "-s, --src directoryDirectory to search tests into"
> echo "-b, --build directory  Directory to search built files 
> into"
> echo "-h, --help This message."
> exit 0
> ;;
> 
> *)
> break
> esac
> done
> 
> SRC_D=$(readlink -f $SRC_D)
> BUILD_D=$(readlink -f $BUILD_D)
> 
> [ -d "$SRC_D" -a -r "$SRC_D" ] || fatal "$SRC_D is not a valid directory"
> [ -d "$BUILD_D" -a -r "$BUILD_D" ] || fatal "$BUILD_D is not a valid 
> directory"
> 
> function load_cfg {
>unset LDS
>unset INCLUDES
>LDF=""
>LDP=""
>INCLUDE="-I .."
>if [ -f $CONFIG_SH -a -r $CONFIG_SH ]
>then
>   echo "load $CONFIG_SH"
>   source ./$CONFIG_SH
>   for include in $INCLUDES
>   do
>  F=$(find $SRC_D -name $include)
>  if [ -z "$F" ]
>  then
> F=$(find $BUILD_D -name $include)
> [ ! -z "$F" ] || fatal "can't find $include in $SRC_D or $BUILD_D"
>  fi
>  INCLUDE="$INCLUDE -I ${F%/*}"
>   done
>   for ld in $LDS
>   do
>  F=$(find $BUILD_D -name $ld)
>  [ ! -z "$F" ] || fatal "can't find $ld in $BUILD_D"
>  F=$(readlink -f $F)
>  LDP="$LDP -L ${F%/*}"
>  lib=${F##*/lib}
>  lib=${lib%.so*}
>  LDF="$LDF -l$lib"
>   done
>fi
> }
> 
> echo "search for tests into $SRC_D"
> for dir in $(find $SRC_D -type d -name tests)
> do
>echo "  enter $dir"
>pushd $dir > /dev/null || fatal "cannot enter $dir"
>[ -f $INIT_C -a -r $INIT_C ] || fatal "missing mandatory file $INIT_C"
>[ -f $SHUTDOWN_C -a -r $SHUTDOWN_C ] || fatal "missing mandatory file 
> $SHUTDOWN_C"
>load_cfg
>for test_c in $(ls -1 test_*.c)
>do
>   echo -n "compile and run $test_c"
>   cat $INIT_C $test_c $SHUTDOWN_C > $C_FILE
>   CMD="$CC $INCLUDE $LDP $LDF -o $C_FILE.o $O_FILE"
>   [ $DEBUG -eq 1 ] && echo "$CMD"
>   $CMD || fatal "compilation failed"
>   $O_FILE.o && echo " PASS" || fatal "test run failed"
>done
>echo "  leave"
>popd > /dev/null
> done
> echo "done"
> <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

Re: [E-devel] [E-b0rk] Build failed in Jenkins: nightly_efl_gcc_x86_64 #1417

[Jérémy Zurcher]

I had a some fun with this moronic bash driven test suite

http://cgit.asynk.ch/bin/tree/mtests.sh

--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [E-b0rk] Build failed in Jenkins: nightly_efl_gcc_x86_64 #1417

[Jérémy Zurcher]

Hi,
I wrote a quick and dirty POC ...
comments welcome

<<<
#! /bin/sh

SRC_D=src
BUILD_D=src
CONFIG_SH=config.sh
INIT_C=init.c
SHUTDOWN_C=shutdown.c
C_FILE=/tmp/__efl_test.c
O_FILE=/tmp/__efl_test.o
DEBUG=0

SCRIPT_DIR=${0%/*}
SCRIPT_FILE=${0##*/}

CC=${CC:-"clang"}
LD=""
INCLUDE=""

function fatal {
   echo "FATAL $1"
   exit 1
}

while [ $# -ge 1 ]; do
case "$1" in
-s*|--src*)
shift
[ $# -lt 1 ] && fatal "option -s is missing directory argument"
SRC_D=$1
shift
;;
-b*|--build*)
shift
[ $# -lt 1 ] && fatal "option -b is missing directory argument"
BUILD_D=$1
shift
;;

-h|--help)
echo "Usage:  $SCRIPT_FILE [options]"
echo
echo "Options:"
echo "-s, --src directoryDirectory to search tests into"
echo "-b, --build directory  Directory to search built files 
into"
echo "-h, --help This message."
exit 0
;;

*)
break
esac
done

SRC_D=$(readlink -f $SRC_D)
BUILD_D=$(readlink -f $BUILD_D)

[ -d "$SRC_D" -a -r "$SRC_D" ] || fatal "$SRC_D is not a valid directory"
[ -d "$BUILD_D" -a -r "$BUILD_D" ] || fatal "$BUILD_D is not a valid directory"

function load_cfg {
   unset LDS
   unset INCLUDES
   LDF=""
   LDP=""
   INCLUDE="-I .."
   if [ -f $CONFIG_SH -a -r $CONFIG_SH ]
   then
  echo "load $CONFIG_SH"
  source ./$CONFIG_SH
  for include in $INCLUDES
  do
 F=$(find $SRC_D -name $include)
 if [ -z "$F" ]
 then
F=$(find $BUILD_D -name $include)
[ ! -z "$F" ] || fatal "can't find $include in $SRC_D or $BUILD_D"
 fi
 INCLUDE="$INCLUDE -I ${F%/*}"
  done
  for ld in $LDS
  do
 F=$(find $BUILD_D -name $ld)
 [ ! -z "$F" ] || fatal "can't find $ld in $BUILD_D"
 F=$(readlink -f $F)
 LDP="$LDP -L ${F%/*}"
 lib=${F##*/lib}
 lib=${lib%.so*}
 LDF="$LDF -l$lib"
  done
   fi
}

echo "search for tests into $SRC_D"
for dir in $(find $SRC_D -type d -name tests)
do
   echo "  enter $dir"
   pushd $dir > /dev/null || fatal "cannot enter $dir"
   [ -f $INIT_C -a -r $INIT_C ] || fatal "missing mandatory file $INIT_C"
   [ -f $SHUTDOWN_C -a -r $SHUTDOWN_C ] || fatal "missing mandatory file 
$SHUTDOWN_C"
   load_cfg
   for test_c in $(ls -1 test_*.c)
   do
  echo -n "compile and run $test_c"
  cat $INIT_C $test_c $SHUTDOWN_C > $C_FILE
  CMD="$CC $INCLUDE $LDP $LDF -o $C_FILE.o $O_FILE"
  [ $DEBUG -eq 1 ] && echo "$CMD"
  $CMD || fatal "compilation failed"
  $O_FILE.o && echo " PASS" || fatal "test run failed"
   done
   echo "  leave"
   popd > /dev/null
done
echo "done"
<<<


this is what I've got in src/lib/eina/tests

jeyzu@bigdaddy: tests (master) $ cat config.sh
INCLUDES="eina_config.h Eina.h Efl_Config.h"
LDS="libeina.so"

jeyzu@bigdaddy: tests (master) $ cat init.c
#include 

#define FAIL_IF(_x) if ((_x)) { fprintf(stderr, "fail\n"); exit(1); }

int main(int argc, char *argv[])
{
   eina_init();

jeyzu@bigdaddy: tests (master) $ cat shutdown.c
  eina_shutdown();
  return 0;
}

jeyzu@bigdaddy: tests (master) $ cat test_list_append.c
Eina_List *list = NULL;
list = eina_list_append(list, (void *)123L);
FAIL_IF(eina_list_data_find_list(list, (void *)123L) != list);


run from topdir
jeyzu@bigdaddy: efl (master) $ ./tests.sh -s src/lib/eina -b build
search for tests into /home/jeyzu/usr/git/efl/core/efl/src/lib/eina
  enter /home/jeyzu/usr/git/efl/core/efl/src/lib/eina/tests
load config.sh
compile and run test_list_append.c PASS
  leave
done


--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Making documentation for all elements of a eo file mandatory for new files

[Jérémy Zurcher]

On Thursday 24 November 2016  16:35, Stefan Schmidt wrote :
> Hello.
> 
> On 25/10/16 10:15, Stefan Schmidt wrote:
> > Hello.
> >
> > On 25/10/16 05:04, Carsten Haitzler (The Rasterman) wrote:
> >> On Sat, 22 Oct 2016 00:43:30 +0200 Stefan Schmidt  
> >> said:
> >>
> >>> Hello.
> >>>
> >>> TL;DR: If you are committing new eo files I expect them to have full
> >>> docs from now one. Also help with the ones you are currently working on.
> >>
> >> this is actually looking pretty decent below now in terms of progress. :)
> >
> > Indeed. :)
> >
> > With some more patches I've been working on right now I'm at 80% total
> > coverage.
> 
> With the last batch I pushed today we have 100% doc coverage in our eo 
> files! :)


+WaôaW+ ! very good job indeed.


> 
> Now we need to keep it like this, please. :)
> 
> The next steps from my side are to get these docs with the new doc 
> system from Daniel deployed to our E server to make it available to 
> everyone. Once that is done we need to improve the docs for consistency 
> and quality in general.
> 
> regards
> Stefan Schmidt
> 
> --
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [tools/eflete] master 01/01: fix out of src tree build

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/tools/eflete.git/commit/?id=839cf3e474dff0aae3d042aa4d25b1924695ce44

commit 839cf3e474dff0aae3d042aa4d25b1924695ce44
Author: Jérémy Zurcher 
Date:   Wed Oct 26 21:00:59 2016 +0200

fix out of src tree build
---
 src/bin/Makefile.am | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/bin/Makefile.am b/src/bin/Makefile.am
index 475aa8c..ae74630 100644
--- a/src/bin/Makefile.am
+++ b/src/bin/Makefile.am
@@ -174,6 +174,7 @@ libete_a_SOURCES = \
 eflete_SOURCES  = ../../src/bin/main.c
 
 eflete_CPPFLAGS = \
+-I$(top_builddir)/src/lib \
 -I${top_srcdir}/src/lib \
 -I${top_srcdir}/src/bin/alloc \
 -I${top_srcdir}/src/bin/editor \

-- 

Re: [E-devel] Python-Efl doesn't compile

[Jérémy Zurcher]

On Tuesday 25 October 2016  10:41, Al Poole wrote :
> >
> >
> > With a distro maintainer hat on a script like this shouldn't install to
> > /usr by default that will cause alot of issues with package managers etc
> > so either /usr/local or /opt is the correct place, at the same time this
> > means that the script probably needs to make some symlinks into /etc and
> > have a way to reset them.
> >
> > I'll add don't use /usr/local either as that's where FreeBSD and OpenBSD
> store third-party _packages_.
> 
> So that leaves.../opt or /sw or whatever you like, probably /opt!

I use PREFIX=/opt/efl for years now,

compile efl with :
  --with-dbus-services=/usr/share/dbus-1/services

compile enlightenment with
   --sysconfdir=/etc --libexecdir=$PREFIX/lib/enlightenment

and generate
   echo "$PREFIX/lib" > /etc/ld.so.conf.d/efl.conf

and
   echo -e "export EFLDIR=$PREFIX\nexport PATH=\$PATH:\$EFLDIR/bin\nexport 
PKG_CONFIG_PATH=\$PKG_CONFIG_PATH:\$EFLDIR/lib/pkgconfig" > 
/etc/profile.d/efl.sh

it works like a charm ;)
> 
> ! :)
> --
> The Command Line: Reinvented for Modern Developers
> Did the resurgence of CLI tooling catch you by surprise?
> Reconnect with the command line and become more productive. 
> Learn the new .NET and ASP.NET CLI. Get your free copy!
> http://sdm.link/telerik
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
The Command Line: Reinvented for Modern Developers
Did the resurgence of CLI tooling catch you by surprise?
Reconnect with the command line and become more productive. 
Learn the new .NET and ASP.NET CLI. Get your free copy!
http://sdm.link/telerik
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [apps/terminology] master 01/01: ty*: add unified --help / -h options to see a help page

[Jérémy Zurcher]

+1 ;)

On Friday 16 September 2016  04:44, Marcel Hollerbach wrote :
> bu5hm4n pushed a commit to branch master.
> 
> http://git.enlightenment.org/apps/terminology.git/commit/?id=b038ed7ff6fa112fe8b8742b101445502ae89380
> 
> commit b038ed7ff6fa112fe8b8742b101445502ae89380
> Author: Marcel Hollerbach 
> Date:   Thu Sep 1 15:14:39 2016 +0200
> 
> ty*: add unified --help / -h options to see a help page
> 
> This also adds documentation about the -h / --help options in the usages
> ---
>  src/bin/tyalpha.c  | 18 +-
>  src/bin/tybg.c | 21 +++--
>  src/bin/tycat.c|  7 ---
>  src/bin/tycommon.h | 17 +
>  src/bin/tyls.c | 25 ++---
>  src/bin/typop.c| 17 +
>  src/bin/tyq.c  | 17 +
>  7 files changed, 85 insertions(+), 37 deletions(-)
> 
> diff --git a/src/bin/tyalpha.c b/src/bin/tyalpha.c
> index 7b55b7a..e0b2646 100644
> --- a/src/bin/tyalpha.c
> +++ b/src/bin/tyalpha.c
> @@ -7,20 +7,28 @@
>  #include 
>  #include "tycommon.h"
>  
> +static void
> +print_usage(const char *argv0)
> +{
> +   printf("Usage: %s "HELP_ARGUMENT_SHORT"[-p] on|off|\n"
> +  "  Change the terminal transparency on or off\n"
> +  "  -p  Make change permanent (stored in config)\n"
> +  HELP_ARGUMENT_DOC"\n"
> +  "\n",
> +  argv0);
> +}
> +
>  int
>  main(int argc, char **argv)
>  {
> int i, perm = 0;
>  
> ON_NOT_RUNNING_IN_TERMINOLOGY_EXIT_1();
> +   ARGUMENT_ENTRY_CHECK(argc, argv, print_usage);
>  
> if (argc <= 1)
>   {
> -printf("Usage: %s [-p] on|off|\n"
> -   "  Change the terminal transparency on or off\n"
> -   "  -p  Make change permanent (stored in config)\n"
> -   "\n",
> -   argv[0]);
> +print_usage(argv[0]);
>  return 0;
>   }
> for (i = 1; i < argc; i++)
> diff --git a/src/bin/tybg.c b/src/bin/tybg.c
> index cc3df43..11969cc 100644
> --- a/src/bin/tybg.c
> +++ b/src/bin/tybg.c
> @@ -7,6 +7,16 @@
>  #include 
>  #include "tycommon.h"
>  
> +static void
> +print_usage(const char *argv0)
> +{
> +   printf("Usage: %s "HELP_ARGUMENT_SHORT" [-p] [FILE1 FILE2 ...]\n"
> +  "  Change the terminal background to the given file/uri\n"
> +  "  -p  Make change permanent (stored in config)\n"
> +  HELP_ARGUMENT_DOC"\n"
> +  "\n",
> +  argv0);
> +}
>  
>  int
>  main(int argc, char **argv)
> @@ -14,17 +24,8 @@ main(int argc, char **argv)
> int i, perm = 0;
>  
> ON_NOT_RUNNING_IN_TERMINOLOGY_EXIT_1();
> +   ARGUMENT_ENTRY_CHECK(argc, argv, print_usage);
>  
> -   if (argc > 1 &&
> -   (!strcmp(argv[1], "-h") || !strcmp(argv[1], "--help")))
> - {
> -printf("Usage: %s [-p] [FILE1 FILE2 ...]\n"
> -   "  Change the terminal background to the given file/uri\n"
> -   "  -p  Make change permanent (stored in config)\n"
> -   "\n",
> -   argv[0]);
> -return 0;
> - }
> if (argc <= 1)
>   {
>  char tbuf[32];
> diff --git a/src/bin/tycat.c b/src/bin/tycat.c
> index 709640d..c90dec5 100644
> --- a/src/bin/tycat.c
> +++ b/src/bin/tycat.c
> @@ -120,12 +120,13 @@ prnt(const char *path, int w, int h, int mode)
>  static void
>  print_usage(const char *argv0)
>  {
> -   printf("Usage: %s [-s|-f|-c] [-g x] FILE1 [FILE2 ...]\n"
> +   printf("Usage: %s "HELP_ARGUMENT_SHORT" [-s|-f|-c] [-g x] 
> FILE1 [FILE2 ...]\n"
>"\n"
>"  -s  Stretch file to fill nearest character cell size\n"
>"  -f  Fill file to totally cover character cells with no gaps\n"
>"  -c  Center file in nearest character cells but only scale down 
> (default)\n"
> -  "  -g x  Set maximum geometry for the image (cell 
> count)\n",
> +  "  -g x  Set maximum geometry for the image (cell 
> count)\n"
> +  HELP_ARGUMENT_DOC"\n",
>   argv0);
>  }
>  
> @@ -311,7 +312,7 @@ main(int argc, char **argv)
> Eina_List *file_q = NULL;
>  
> ON_NOT_RUNNING_IN_TERMINOLOGY_EXIT_1();
> -
> +   ARGUMENT_ENTRY_CHECK(argc, argv, print_usage);
> if (argc <= 1)
>   {
>  print_usage(argv[0]);
> diff --git a/src/bin/tycommon.h b/src/bin/tycommon.h
> index f29b247..da7af40 100644
> --- a/src/bin/tycommon.h
> +++ b/src/bin/tycommon.h
> @@ -14,5 +14,22 @@ Eina_Bool is_running_in_terminology(void);
>  }  \
>while (0)
>  
> +#define HELP_ARGUMENT_DOC  "  -h or --help Display this help."
> +#define HELP_ARGUMENT_SHORT "[-h]"
> +
> +#define ARGUMENT_ENTRY_CHECK(argc, argv, help_func) \
> +do \
> +  { \
> + int i = 0; \
> + for(i = 0; i < argc; i++) \
> +   { \
> + if (!strcmp(argv[i], "--help") || !strcmp(argv[i],"-h")) \
> +   { \
> +  help_func(argv[0]); \
> +  r

[EGIT] [tools/clouseau] master 01/01: follow namespace switch from Eo to Efl

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/tools/clouseau.git/commit/?id=0f9a7e2d0336555905f2adb9b51c9a285e085a02

commit 0f9a7e2d0336555905f2adb9b51c9a285e085a02
Author: Jérémy Zurcher 
Date:   Thu Aug 18 09:41:36 2016 +0200

follow namespace switch from Eo to Efl
---
 src/bin/clouseau_client.c |  18 ++--
 src/lib/Clouseau.h|   2 +-
 src/lib/clouseau_app.c|  22 ++---
 src/lib/clouseau_data.c   |  60 ++--
 src/lib/clouseau_object_information.c | 172 +-
 src/lib/clouseau_private.h|  28 +++---
 src/modules/client/canvas_checker.c   |   2 +-
 7 files changed, 152 insertions(+), 152 deletions(-)

diff --git a/src/bin/clouseau_client.c b/src/bin/clouseau_client.c
index 5155201..32fcb0a 100644
--- a/src/bin/clouseau_client.c
+++ b/src/bin/clouseau_client.c
@@ -1039,7 +1039,7 @@ static Eina_Bool
 _tree_it_is_elm(Clouseau_Tree_Item *treeit)
 {
Eina_List *l;
-   Eo_Dbg_Info *eo_root, *eo;
+   Efl_Dbg_Info *eo_root, *eo;
Eina_Value_List eo_list;
clouseau_tree_item_from_legacy_convert(treeit);
eo_root = treeit->new_eo_info;
@@ -1340,7 +1340,7 @@ _gl_selected(void *data, Evas_Object *pobj EINA_UNUSED, 
void *event_info)
 
  /* Populate the property list. */
{
-  Eo_Dbg_Info *eo_root, *eo;
+  Efl_Dbg_Info *eo_root, *eo;
   Eina_Value_List eo_list;
   /* FIXME: Do it before and save it like that. Probably at the
* eet conversion stage. */
@@ -2197,12 +2197,12 @@ _main_list_create(Evas_Object *panes)
 }
 
 static void
-_obj_info_compactable_list_to_buffer(Eo_Dbg_Info *root_eo, char* buffer, 
unsigned int buffer_size)
+_obj_info_compactable_list_to_buffer(Efl_Dbg_Info *root_eo, char* buffer, 
unsigned int buffer_size)
 {
Eina_List *l; // Iterator
Eina_Value_List list; // list of the elements in root_eo
eina_value_pget(&(root_eo->value), &list);
-   Eo_Dbg_Info *eo; // List element
+   Efl_Dbg_Info *eo; // List element
buffer += snprintf(buffer, buffer_size, "%s:", root_eo->name);
EINA_LIST_FOREACH(list.list, l, eo)
  {
@@ -2223,11 +2223,11 @@ _obj_info_compactable_list_to_buffer(Eo_Dbg_Info 
*root_eo, char* buffer, unsigne
 }
 
 static Eina_Bool
-_obj_info_can_list_be_compacted(Eo_Dbg_Info *root_eo)
+_obj_info_can_list_be_compacted(Efl_Dbg_Info *root_eo)
 {
Eina_List *l; // Iterator
Eina_Value_List list; // list of the elements in root_eo
-   Eo_Dbg_Info *eo; // List element
+   Efl_Dbg_Info *eo; // List element
eina_value_pget(&(root_eo->value), &list);
// We check that there is no list into this list. If such list exists,
// we can't compact the list.
@@ -2255,7 +2255,7 @@ _obj_info_gl_exp(void *data EINA_UNUSED, Evas_Object *obj 
EINA_UNUSED, void *eve
  {
 Eina_List *l;
 Eina_Value_List eo_list;
-Eo_Dbg_Info *eo_root, *eo;
+Efl_Dbg_Info *eo_root, *eo;
 eo_root = elm_object_item_data_get(glit);
 eina_value_pget(&(eo_root->value), &eo_list);
 
@@ -2305,7 +2305,7 @@ static char *
 _obj_info_gl_item_text_get(void *data, Evas_Object *obj EINA_UNUSED,
   const char *part EINA_UNUSED)
 {
-   Eo_Dbg_Info *eo = data;
+   Efl_Dbg_Info *eo = data;
char buf[1024] = "";
if (eina_value_type_get(&(eo->value)) == EINA_VALUE_TYPE_LIST)
  {
@@ -2338,7 +2338,7 @@ static char *
 _class_info_gl_item_text_get(void *data, Evas_Object *obj EINA_UNUSED,
   const char *part EINA_UNUSED)
 {
-   Eo_Dbg_Info *eo = data;
+   Efl_Dbg_Info *eo = data;
return strdup(eo->name);
 }
 
diff --git a/src/lib/Clouseau.h b/src/lib/Clouseau.h
index 864524e..cc14e40 100644
--- a/src/lib/Clouseau.h
+++ b/src/lib/Clouseau.h
@@ -32,7 +32,7 @@ struct _Clouseau_Tree_Item
 {
Eina_List *children;
Eina_List *eo_info;  /* The intermediate type we use for eet. */
-   Eo_Dbg_Info *new_eo_info;
+   Efl_Dbg_Info *new_eo_info;
const char *name;
unsigned long long ptr;  /* Just a ptr, we keep the value but not 
accessing mem */
Clouseau_Object *info;   /* Legacy */
diff --git a/src/lib/clouseau_app.c b/src/lib/clouseau_app.c
index 0778fc2..c4e96fa 100644
--- a/src/lib/clouseau_app.c
+++ b/src/lib/clouseau_app.c
@@ -26,11 +26,11 @@ libclouseau_item_add(Evas_Object *o, Clouseau_Tree_Item 
*parent)
treeit->ptr = (uintptr_t) o;
treeit->is_obj = EINA_TRUE;
 
-   treeit->name = eina_stringshare_add(eo_class_name_get(o));
+   treeit->name = eina_stringshare_add(efl_class_name_get(o));
 
/* FIXME: Hack to work with old smart inheritance.
 * Check if the class *is* (not just implements) Evas_Smart. */
-   if (eo_class_get(o) == EFL_CANVAS_GROUP_CLASS)
+   if (efl_class_get(o) == EFL_CANVAS_GROUP_CLASS)
  {
 char buf[1024];
 snprint

Re: [E-devel] a few newbie questions ...

[Jérémy Zurcher]

Hello,

On Sunday 01 May 2016  16:57, Jason Vas Dias wrote :
> Good day enlightened ones -
>
> SNIP SNIP SNIP
> 
> Also, I notice ALL the configuration files written under
>  ~/.e ~/.elementary
> are binary / encrypted in some way.  Is there a compile
> / runtime option  to disable use of binary / encrypted
> configuration files ?
no there is none
> 
> I am really against using them on principle , mainly for the
> reason it is very difficult to workaround situations like
> this (broken configuration) without being able to read
> the configuration files.
> 
a porper efl installation provides you with 'eet' and it's convenient vim
wrapper 'vieet'.

basic usage is : eet -d .e/e/config/standard/e.cfg config

now you're free to mess with your config files ;)

--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] harbuzz update mess with prompt

[Jérémy Zurcher]

On Friday 20 November 2015  13:47, Tom Hacohen wrote :
> On 20/11/15 10:32, Tom Hacohen wrote:
> > On 20/11/15 10:22, Jérémy Zurcher wrote:
> >> Hi there
> >>
> >> the following update on my archlinux boxes
> >>
> >> upgraded harfbuzz (1.0.6-2 -> 1.1.0-1)
> >> upgraded harfbuzz-icu (1.0.6-2 -> 1.1.0-1)
> >>
> >> messes a lot with terminology prompt and mutt,
> >> I disabled harfbuzz for now.
> >>
> >> see the attached img
> >
> > Could you please also file a bug with them?
> 
> Actually, it seems like it doesn't break textblock, just textgrid. I 
> wonder if it's just a textgrid bug. I really don't know that code at all 
> though. ;(

of course me neighter ;)
I will fill a bug report later tonight and provide the tests for event
freezing in eo events ...

> 
> --
> Tom.
> 
> 
> --
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] harbuzz update mess with prompt

[Jérémy Zurcher]

Hi there

the following update on my archlinux boxes

upgraded harfbuzz (1.0.6-2 -> 1.1.0-1)
upgraded harfbuzz-icu (1.0.6-2 -> 1.1.0-1)

messes a lot with terminology prompt and mutt,
I disabled harfbuzz for now.

see the attached img


--- Hell'O from Yverdoom

Jérémy (jeyzu)
--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: Eo: Optimise event callback call

[Jérémy Zurcher]

no bother,
I'll find some time today to do that.

On Monday 09 November 2015  14:17, Tom Hacohen wrote :
> True.
> If you have time to send a patch, that'd be greatly appreciated, 
> otherwise, let me know, and I'll write the tests.
> 
> --
> Tom.
> 
> On 09/11/15 14:18, Jérémy Zurcher wrote:
> > true,
> > so we might need tests to cover that ...
> >
> > On Monday 09 November 2015  14:08, Tom Hacohen wrote :
> >> Hey,
> >>
> >> I reverted this. The freeze state can change from within the callbacks
> >> so you have to test it every time.
> >>
> >> --
> >> Tom.
> >>
> >> On 09/11/15 14:01, Jérémy Zurcher wrote:
> >>> jeyzu pushed a commit to branch master.
> >>>
> >>> http://git.enlightenment.org/core/efl.git/commit/?id=4b116627c24a43248abf5a34a391241b1c0cf983
> >>>
> >>> commit 4b116627c24a43248abf5a34a391241b1c0cf983
> >>> Author: Jérémy Zurcher 
> >>> Date:   Mon Nov 9 15:03:03 2015 +0100
> >>>
> >>>   Eo: Optimise event callback call
> >>>
> >>>check if the event is frozen before walking the event list
> >>> ---
> >>>src/lib/eo/eo_base_class.c | 53 
> >>> ++
> >>>1 file changed, 25 insertions(+), 28 deletions(-)
> >>>
> >>> diff --git a/src/lib/eo/eo_base_class.c b/src/lib/eo/eo_base_class.c
> >>> index f99ca37..daf7a9d 100644
> >>> --- a/src/lib/eo/eo_base_class.c
> >>> +++ b/src/lib/eo/eo_base_class.c
> >>> @@ -671,48 +671,45 @@ _eo_base_event_callback_call(Eo *obj_id, 
> >>> Eo_Base_Data *pd,
> >>>
> >>>   pd->walking_list++;
> >>>
> >>> +   if (!desc->unfreezable && (event_freeze_count || 
> >>> pd->event_freeze_count))
> >>> + goto end;
> >>> +
> >>>   for (cb = pd->callbacks; cb; cb = cb->next)
> >>> {
> >>> -if (!cb->delete_me)
> >>> +if (cb->delete_me)
> >>> +  continue;
> >>> +
> >>> +if (cb->func_array)
> >>>  {
> >>> - if (cb->func_array)
> >>> -   {
> >>> -  const Eo_Callback_Array_Item *it;
> >>> + const Eo_Callback_Array_Item *it;
> >>>
> >>> -  for (it = cb->items.item_array; it->func; it++)
> >>> -{
> >>> -   if (!_cb_desc_match(it->desc, desc))
> >>> -  continue;
> >>> -   if (!it->desc->unfreezable &&
> >>> -   (event_freeze_count || 
> >>> pd->event_freeze_count))
> >>> -  continue;
> >>> -
> >>> -   /* Abort callback calling if the func says so. */
> >>> -   if (!it->func((void *) cb->func_data, obj_id, 
> >>> desc,
> >>> -(void *) event_info))
> >>> - {
> >>> -ret = EINA_FALSE;
> >>> -goto end;
> >>> - }
> >>> -}
> >>> -   }
> >>> - else
> >>> + for (it = cb->items.item_array; it->func; it++)
> >>>   {
> >>> -  if (!_cb_desc_match(cb->items.item.desc, desc))
> >>> -continue;
> >>> -  if (!cb->items.item.desc->unfreezable &&
> >>> -  (event_freeze_count || pd->event_freeze_count))
> >>> +  if (!_cb_desc_match(it->desc, desc))
> >>>continue;
> >>>
> >>>  /* Abort callback calling if the func says so. */
> >>> -  if (!cb->items.item.func((void *) cb->func_data, 
> >>> obj_id, desc,
> >>> -   (void *) event_info))
> >>> +  if (!it->func((void *) cb->func_data, obj_id, desc,
> >>> +(void *) event_info))
> >>>   

Re: [E-devel] [EGIT] [core/efl] master 01/01: Eo: Optimise event callback call

[Jérémy Zurcher]

true,
so we might need tests to cover that ...

On Monday 09 November 2015  14:08, Tom Hacohen wrote :
> Hey,
> 
> I reverted this. The freeze state can change from within the callbacks 
> so you have to test it every time.
> 
> --
> Tom.
> 
> On 09/11/15 14:01, Jérémy Zurcher wrote:
> > jeyzu pushed a commit to branch master.
> >
> > http://git.enlightenment.org/core/efl.git/commit/?id=4b116627c24a43248abf5a34a391241b1c0cf983
> >
> > commit 4b116627c24a43248abf5a34a391241b1c0cf983
> > Author: Jérémy Zurcher 
> > Date:   Mon Nov 9 15:03:03 2015 +0100
> >
> >  Eo: Optimise event callback call
> >
> >   check if the event is frozen before walking the event list
> > ---
> >   src/lib/eo/eo_base_class.c | 53 
> > ++
> >   1 file changed, 25 insertions(+), 28 deletions(-)
> >
> > diff --git a/src/lib/eo/eo_base_class.c b/src/lib/eo/eo_base_class.c
> > index f99ca37..daf7a9d 100644
> > --- a/src/lib/eo/eo_base_class.c
> > +++ b/src/lib/eo/eo_base_class.c
> > @@ -671,48 +671,45 @@ _eo_base_event_callback_call(Eo *obj_id, Eo_Base_Data 
> > *pd,
> >
> >  pd->walking_list++;
> >
> > +   if (!desc->unfreezable && (event_freeze_count || 
> > pd->event_freeze_count))
> > + goto end;
> > +
> >  for (cb = pd->callbacks; cb; cb = cb->next)
> >{
> > -if (!cb->delete_me)
> > +if (cb->delete_me)
> > +  continue;
> > +
> > +if (cb->func_array)
> > {
> > - if (cb->func_array)
> > -   {
> > -  const Eo_Callback_Array_Item *it;
> > + const Eo_Callback_Array_Item *it;
> >
> > -  for (it = cb->items.item_array; it->func; it++)
> > -{
> > -   if (!_cb_desc_match(it->desc, desc))
> > -  continue;
> > -   if (!it->desc->unfreezable &&
> > -   (event_freeze_count || pd->event_freeze_count))
> > -  continue;
> > -
> > -   /* Abort callback calling if the func says so. */
> > -   if (!it->func((void *) cb->func_data, obj_id, desc,
> > -(void *) event_info))
> > - {
> > -ret = EINA_FALSE;
> > -goto end;
> > - }
> > -}
> > -   }
> > - else
> > + for (it = cb->items.item_array; it->func; it++)
> >  {
> > -  if (!_cb_desc_match(cb->items.item.desc, desc))
> > -continue;
> > -  if (!cb->items.item.desc->unfreezable &&
> > -  (event_freeze_count || pd->event_freeze_count))
> > +  if (!_cb_desc_match(it->desc, desc))
> >   continue;
> >
> > /* Abort callback calling if the func says so. */
> > -  if (!cb->items.item.func((void *) cb->func_data, obj_id, 
> > desc,
> > -   (void *) event_info))
> > +  if (!it->func((void *) cb->func_data, obj_id, desc,
> > +(void *) event_info))
> >   {
> >  ret = EINA_FALSE;
> >  goto end;
> >   }
> >  }
> > }
> > +else
> > +  {
> > + if (!_cb_desc_match(cb->items.item.desc, desc))
> > +   continue;
> > +
> > + /* Abort callback calling if the func says so. */
> > + if (!cb->items.item.func((void *) cb->func_data, obj_id, desc,
> > +  (void *) event_info))
> > +   {
> > +  ret = EINA_FALSE;
> > +  goto end;
> > +   }
> > +  }
> >}
> >
> >   end:
> >
> 
> 
> --
> Presto, an open source distributed SQL query engine for big data, initially
> developed by Facebook, enables you to easily query your data on Hadoop in a 
> more interactive mann

Re: [E-devel] [EGIT] [core/efl] master 01/02: Eo do: optimise getting the thread call stack for the main loop thread.

[Jérémy Zurcher]

ok ...  neat ;)))

On Friday 16 October 2015  08:39, Tom Hacohen wrote :
> tasn pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/efl.git/commit/?id=3ee44dcef0ed30c0095eb3d690db6bca8d2dd64f
> 
> commit 3ee44dcef0ed30c0095eb3d690db6bca8d2dd64f
> Author: Tom Hacohen 
> Date:   Fri Oct 16 12:21:25 2015 +0100
> 
> Eo do: optimise getting the thread call stack for the main loop thread.
> 
> This may look like an insignificant change, but it doubles the speed of
> this function, and since this function is called so often, it actually
> improves my benchmarks by around 8%.
> ---
>  src/lib/eo/eo.c | 33 -
>  1 file changed, 20 insertions(+), 13 deletions(-)
> 
> diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
> index 5f56dfa..7868d2a 100644
> --- a/src/lib/eo/eo.c
> +++ b/src/lib/eo/eo.c
> @@ -375,12 +375,16 @@ _eo_call_stack_free(void *ptr)
> free(stack);
>  }
>  
> +static Eo_Call_Stack *main_loop_stack = NULL;
> +
> +#define _EO_CALL_STACK_GET(is_main_loop) ((EINA_LIKELY(is_main_loop)) ? 
> main_loop_stack : _eo_call_stack_get_thread())
> +
>  static inline Eo_Call_Stack *
> -_eo_call_stack_get(Eina_Bool is_main_loop)
> +_eo_call_stack_get_thread(void)
>  {
> -   static Eo_Call_Stack *main_loop_stack = NULL;
> -   Eo_Call_Stack *stack = is_main_loop ?
> - main_loop_stack : eina_tls_get(_eo_call_stack_key);
> +   Eo_Call_Stack *stack;
> +
> +   stack = eina_tls_get(_eo_call_stack_key);
>  
> if (stack) return stack;
>  
> @@ -391,11 +395,7 @@ _eo_call_stack_get(Eina_Bool is_main_loop)
>  return NULL;
>   }
>  
> -   if (is_main_loop)
> - {
> -main_loop_stack = stack;
> - }
> -   else if (!eina_tls_set(_eo_call_stack_key, stack))
> +   if (!eina_tls_set(_eo_call_stack_key, stack))
>   {
>  EINA_LOG_ERR("Could not set eo call stack in TLS key.");
>  _eo_call_stack_free(stack);
> @@ -493,7 +493,7 @@ _eo_do_start(const Eo *eo_id, const Eo_Class 
> *cur_klass_id, Eina_Bool is_super,
>  {
> Eina_Bool ret = EINA_TRUE;
> Eo_Stack_Frame *fptr, *pfptr;
> -   Eo_Call_Stack *stack = _eo_call_stack_get(eina_main_loop_is());
> +   Eo_Call_Stack *stack = _EO_CALL_STACK_GET(eina_main_loop_is());
>  
> if (stack->frame_ptr == stack->last_frame)
>   _eo_call_stack_resize(stack, EINA_TRUE);
> @@ -520,7 +520,7 @@ EAPI void
>  _eo_do_end(void)
>  {
> Eo_Stack_Frame *fptr;
> -   Eo_Call_Stack *stack = _eo_call_stack_get(eina_main_loop_is()); // Is it 
> possible to extract information from the scope ?
> +   Eo_Call_Stack *stack = _EO_CALL_STACK_GET(eina_main_loop_is()); // Is it 
> possible to extract information from the scope ?
>  
> fptr = stack->frame_ptr;
>  
> @@ -549,7 +549,7 @@ _eo_call_resolve(const char *func_name, const Eo_Op op, 
> Eo_Op_Call_Data *call, c
> const op_type_funcs *func;
> Eina_Bool is_obj;
>  
> -   fptr = _eo_call_stack_get(eina_main_loop_is())->frame_ptr;
> +   fptr = _EO_CALL_STACK_GET(eina_main_loop_is())->frame_ptr;
>  
> if (EINA_UNLIKELY(!fptr->o.obj))
>return EINA_FALSE;
> @@ -898,7 +898,7 @@ static Eo *
>  _eo_add_internal_end(Eo *eo_id)
>  {
> Eo_Stack_Frame *fptr;
> -   Eo_Call_Stack *stack = _eo_call_stack_get(eina_main_loop_is());
> +   Eo_Call_Stack *stack = _EO_CALL_STACK_GET(eina_main_loop_is());
>  
> fptr = stack->frame_ptr;
>  
> @@ -1813,6 +1813,13 @@ eo_init(void)
>}
>   }
>  
> +   main_loop_stack = _eo_call_stack_create();
> +   if (!main_loop_stack)
> + {
> +EINA_LOG_ERR("Could not alloc eo call stack.");
> +return EINA_FALSE;
> + }
> +
> return EINA_TRUE;
>  }
>  
> 
> -- 
> 
> 
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: Eo: Move mainloop checks inside Eo.

[Jérémy Zurcher]

On Friday 16 October 2015  07:53, Cedric BAIL wrote :
> Le 16 oct. 2015 6:53 AM, "Tom Hacohen"  a écrit :
> >
> > tasn pushed a commit to branch master.
> >
> >
> http://git.enlightenment.org/core/efl.git/commit/?id=b61556aa87ad134fe04fbdc8f953bd98d941a18e
> >
> > commit b61556aa87ad134fe04fbdc8f953bd98d941a18e
> > Author: Tom Hacohen 
> > Date:   Fri Oct 16 13:01:01 2015 +0100
> >
> > Eo: Move mainloop checks inside Eo.
> >
> > This breaks ABI in a harmless way, and it will give us the ability to
> > drastically improve Eo in the future without breaking ABI again, thus
> > allowing us to declare Eo stable for this release if we choose to.
> 
> Checking if a code is running in the main loop is costly. It is as costly
> as a tls access in my test. The purpose was to reuse the value. I don't
> know if the code evolved to a point we couldn't reuse the value anymore,
> but did you check any performance impact ?

I'm under the same questioning.

--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] eo refs

[Jérémy Zurcher]

that's what I think should be the correct behaviour:


regular case :
o = eo_add(CLASS, NULL);
eo_unref(o);
// o is destroyed, you own it, you do what it pleases you with it.


but :
o = eo_add(CLASS, parent);
eo_unref(o);
// o still leaves, it is referenced by parent.
// you gave up working with it, as you wish,
// but parent still owns a reference to it.


moreover :
o = eo_add(CLASS, parent);
eo_unref(o);
eo_unref(o);
// ERROR msg and no destruction.
// you try to steal the ref you gave to the parent, that's bad behaviour.


the only right way to do so is :
o = eo_add(CLASS, parent);
eo_parent_set(o, NULL);
eo_unref(o);
// o is destroyed. no question asked.


there is always an exception :
o = eo_add(CLASS, parent);
eo_del(o);
// eo_del is powerfull, it first clears the ref owned by parent,
// then destroys o. You are still almighty.



--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "Revert "Eo base: Change parent_set to be an assignment of ref.""

[Jérémy Zurcher]

ok sorry for the noise then.

On Wednesday 26 August 2015  11:01, Tom Hacohen wrote :
> On 26/08/15 11:02, Jérémy Zurcher wrote:
> > what about this ?
> >
> > obj = eo_add(CLASS, parent); /* Ref is 1 */
> > eo_ref(obj); /* Ref is 2 */
> > eo_ref(obj); /* Ref is 3 */
> > eo_do(obj, eo_parent_set(NULL)); /* Ref is 2, giving the ref to NULL */
> > eo_do(obj, eo_parent_set(parent)); /* Ref is 2 */
> > eo_do(obj, eo_parent_set(NULL)); /* Ref is 1, giving the ref to NULL */
> > eo_do(obj, eo_parent_set(parent)); /* Ref is 1 */
> > eo_do(obj, eo_parent_set(NULL)); /* Ref is 0, giving the ref to NULL */
> > eo_do(obj, eo_parent_set(parent)); /* Ref is 0 */
> 
> That's exactly what we are talking about on IRC now, and we talked about 
> before. There was an agreement this is expected, now there's a 
> discussion about it.
> 
> --
> Tom.
> 
> 
> --
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "Revert "Eo base: Change parent_set to be an assignment of ref.""

[Jérémy Zurcher]

what about this ?

obj = eo_add(CLASS, parent); /* Ref is 1 */
eo_ref(obj); /* Ref is 2 */
eo_ref(obj); /* Ref is 3 */
eo_do(obj, eo_parent_set(NULL)); /* Ref is 2, giving the ref to NULL */
eo_do(obj, eo_parent_set(parent)); /* Ref is 2 */
eo_do(obj, eo_parent_set(NULL)); /* Ref is 1, giving the ref to NULL */
eo_do(obj, eo_parent_set(parent)); /* Ref is 1 */
eo_do(obj, eo_parent_set(NULL)); /* Ref is 0, giving the ref to NULL */
eo_do(obj, eo_parent_set(parent)); /* Ref is 0 */


--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] OpenGL window not updating

[Jérémy Zurcher]

Hi,

my http://libgdx.badlogicgames.com (OpenGL ES 2.0) application stops
redrawing after a few seconds.

It works smoothly under fluxbox so it's an e/efl issue.

How can I debug this ?

--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: Eo: Fix typo in error message.

[Jérémy Zurcher]

Hi Tom,
it reminds me about that very old email

Subject: [EGIT] [core/efl] master 01/01: Eo add: beef up error
http://git.enlightenment.org/core/efl.git/commit/?id=40cb2cd3d44e3266b7a50a3c64626034da2817e4

this wasn't a mating call after all ;)


On Thursday 21 May 2015  02:53, Tom Hacohen wrote :
> tasn pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/efl.git/commit/?id=1d4c028034880cb7c591bd0ee2b48c74a4615ed4
> 
> commit 1d4c028034880cb7c591bd0ee2b48c74a4615ed4
> Author: Tom Hacohen 
> Date:   Thu May 21 10:52:26 2015 +0100
> 
> Eo: Fix typo in error message.
> 
> Thanjs to q66 for reporting.
> ---
>  src/lib/eo/eo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
> index 766b7d3..588e74a 100644
> --- a/src/lib/eo/eo.c
> +++ b/src/lib/eo/eo.c
> @@ -950,7 +950,7 @@ _eo_add_internal_end(Eo *eo_id)
>  
> if (EINA_UNLIKELY(!fptr->o.obj))
>   {
> -ERR("Corrupt call stuck, shouldn't happen, please report!");
> +ERR("Corrupt call stack, shouldn't happen, please report!");
>  return NULL;
>   }
>  
> 
> -- 
> 
> 
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Meet Erigo - the EFL GUI builder

[Jérémy Zurcher]

you do build in a separate tree, my bad

check your env ??

On Tuesday 17 February 2015  10:16, Jérémy Zurcher wrote :
> works fine here,
> 
> clean your tree with : grep -Rl 'set(CMAKE_INSTALL_PREFIX' | xargs rm
> 
> you should build in a separate dir
> $ mkdir build && cd build && cmake .. -DCMAKE_INSTALL_PREFIX=/usr 
> -DCMAKE_BUILD_TYPE=release
> 
> On Monday 16 February 2015  22:26, Thanatermesis wrote :
> > Hum, I was trying it and seems like the prefix is ignored:
> > 
> > example building:
> > 
> > cd build && cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=release ..
> > \
> > 
> > Stills install on /opt
> > 
> > 
> > 
> > 2015-02-16 9:24 GMT+01:00 Yakov Goldberg :
> > 
> > > Carnival is cool, enjoy!
> > > I'll be on vacation too. See you after Feb, 25th.
> > >
> > > Yakov.
> > >
> > >
> > > On 02/16/2015 02:14 AM, Martinx - ジェームズ wrote:
> > > > On 15 February 2015 at 12:12, Yakov Goldberg  > > > <mailto:yako...@samsung.com>> wrote:
> > > >
> > > > Hi!
> > > >
> > > > I was happy to help and thanks for packaging.
> > > > Installation of binary works and I'm ready to explain where to put
> > > > data/config files.
> > > >
> > > > One more note. This:
> > > > /$ apt-get source erigo /
> > > > produces an error:
> > > > /E: Unable to find a source package for erigo/
> > > >
> > > > And I'm usually in #e and #edevelop channels.
> > > >
> > > > Yakov.
> > > >
> > > >
> > > > Cool!! I'm glad you like it!   ^_^
> > > >
> > > > I forgot to mention that, when you add an Ubuntu PPA repository, the
> > > > source repository isn't enabled by default.
> > > >
> > > > To enable it, edit the following file:
> > > >
> > > > sudo vi /etc/apt/sources.list.d/martinx-ubuntu-enlightenment-utopic.list
> > > >
> > > > And remove the commentary "# " (and the extra space " ") out from the
> > > > line:
> > > >
> > > > # deb-src http://ppa.launchpad.net/martinx/enlightenment/ubuntu utopic
> > > > main
> > > >
> > > > You file should have at least, two lines, like this (binary / sources):
> > > >
> > > > deb http://ppa.launchpad.net/martinx/enlightenment/ubuntu utopic main
> > > > deb-src http://ppa.launchpad.net/martinx/enlightenment/ubuntu utopic
> > > main
> > > >
> > > > Than, you can run: "sudo apt-get update", "apt-get build-dep erigo"
> > > > and "apt-get source erigo"...a
> > > >
> > > > I'm in the middle of brazilian carnival (small vacation for me) these
> > > > days, next week, I'll join on IRC!
> > > >
> > > > With your help, I can work more on the package, to make it complete.
> > > >
> > > > Cheers!
> > >
> > >
> > >
> > > --
> > > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> > > from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> > > with Interactivity, Sharing, Native Excel Exports, App Integration & more
> > > Get technology previously reserved for billion-dollar corporations, FREE
> > >
> > > http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > >
> > --
> > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> > from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> > with Interactivity, Sharing, Native Excel Exports, App Integration & more
> > Get technology previously reserved for billion-dollar corporations, FREE
> > http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> --- Hell'O from Yverdoom
> 
> Jérémy (jeyzu)
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Meet Erigo - the EFL GUI builder

[Jérémy Zurcher]

works fine here,

clean your tree with : grep -Rl 'set(CMAKE_INSTALL_PREFIX' | xargs rm

you should build in a separate dir
$ mkdir build && cd build && cmake .. -DCMAKE_INSTALL_PREFIX=/usr 
-DCMAKE_BUILD_TYPE=release

On Monday 16 February 2015  22:26, Thanatermesis wrote :
> Hum, I was trying it and seems like the prefix is ignored:
> 
> example building:
> 
> cd build && cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=release ..
> \
> 
> Stills install on /opt
> 
> 
> 
> 2015-02-16 9:24 GMT+01:00 Yakov Goldberg :
> 
> > Carnival is cool, enjoy!
> > I'll be on vacation too. See you after Feb, 25th.
> >
> > Yakov.
> >
> >
> > On 02/16/2015 02:14 AM, Martinx - ジェームズ wrote:
> > > On 15 February 2015 at 12:12, Yakov Goldberg  > > > wrote:
> > >
> > > Hi!
> > >
> > > I was happy to help and thanks for packaging.
> > > Installation of binary works and I'm ready to explain where to put
> > > data/config files.
> > >
> > > One more note. This:
> > > /$ apt-get source erigo /
> > > produces an error:
> > > /E: Unable to find a source package for erigo/
> > >
> > > And I'm usually in #e and #edevelop channels.
> > >
> > > Yakov.
> > >
> > >
> > > Cool!! I'm glad you like it!   ^_^
> > >
> > > I forgot to mention that, when you add an Ubuntu PPA repository, the
> > > source repository isn't enabled by default.
> > >
> > > To enable it, edit the following file:
> > >
> > > sudo vi /etc/apt/sources.list.d/martinx-ubuntu-enlightenment-utopic.list
> > >
> > > And remove the commentary "# " (and the extra space " ") out from the
> > > line:
> > >
> > > # deb-src http://ppa.launchpad.net/martinx/enlightenment/ubuntu utopic
> > > main
> > >
> > > You file should have at least, two lines, like this (binary / sources):
> > >
> > > deb http://ppa.launchpad.net/martinx/enlightenment/ubuntu utopic main
> > > deb-src http://ppa.launchpad.net/martinx/enlightenment/ubuntu utopic
> > main
> > >
> > > Than, you can run: "sudo apt-get update", "apt-get build-dep erigo"
> > > and "apt-get source erigo"...a
> > >
> > > I'm in the middle of brazilian carnival (small vacation for me) these
> > > days, next week, I'll join on IRC!
> > >
> > > With your help, I can work more on the package, to make it complete.
> > >
> > > Cheers!
> >
> >
> >
> > --
> > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> > from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> > with Interactivity, Sharing, Native Excel Exports, App Integration & more
> > Get technology previously reserved for billion-dollar corporations, FREE
> >
> > http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> --
> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> with Interactivity, Sharing, Native Excel Exports, App Integration & more
> Get technology previously reserved for billion-dollar corporations, FREE
> http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: ee-win32 probably might compile now

[Jérémy Zurcher]

some might want to badly beat you down for this commit comment,
but I kind of like it

On Thursday 12 February 2015  13:22, Mike Blumenkrantz wrote :
> discomfitor pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/efl.git/commit/?id=38f1f9c5f243817c3db99e5584a447672163d6db
> 
> commit 38f1f9c5f243817c3db99e5584a447672163d6db
> Author: Mike Blumenkrantz 
> Date:   Thu Feb 12 16:21:52 2015 -0500
> 
> ee-win32 probably might compile now
> 
>  bad Mike !
>  the name of the function is not good, so compilation fails on 
> Windows
>  remove 'object' in the name of the definition of the function :)
> 
> @fix
> ---
>  src/modules/ecore_evas/engines/win32/ecore_evas_win32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/modules/ecore_evas/engines/win32/ecore_evas_win32.c 
> b/src/modules/ecore_evas/engines/win32/ecore_evas_win32.c
> index 36587b9..6af1803 100644
> --- a/src/modules/ecore_evas/engines/win32/ecore_evas_win32.c
> +++ b/src/modules/ecore_evas/engines/win32/ecore_evas_win32.c
> @@ -823,7 +823,7 @@ _ecore_evas_object_cursor_del(void *data, Evas *e 
> EINA_UNUSED, Evas_Object *obj
>  }
>  
>  static void
> -_ecore_evas_win32_object_cursor_unset(Ecore_Evas *ee)
> +_ecore_evas_win32_cursor_unset(Ecore_Evas *ee)
>  {
> evas_object_event_callback_del_full(ee->prop.cursor.object, 
> EVAS_CALLBACK_DEL, _ecore_evas_object_cursor_del, ee);
>  }
> 
> -- 
> 
> 
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: Eo add: beef up error reporting.

[Jérémy Zurcher]

Hi Tom, just a little typo :

On Friday 23 January 2015  08:51, Tom Hacohen wrote :
> tasn pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/efl.git/commit/?id=40cb2cd3d44e3266b7a50a3c64626034da2817e4
> 
> commit 40cb2cd3d44e3266b7a50a3c64626034da2817e4
> Author: Tom Hacohen 
> Date:   Fri Jan 23 16:51:02 2015 +
> 
> Eo add: beef up error reporting.
> 
> In some cases object ceration would fail without an error,
> this is bad and should not happen.
> 
> Thanks to cedric for reporting.
> ---
>  src/lib/eo/eo.c |  5 -
>  src/lib/eo/eo_ptr_indirection.h | 24 
>  2 files changed, 24 insertions(+), 5 deletions(-)
> 
> diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
> index 96f190d..a0adecd 100644
> --- a/src/lib/eo/eo.c
> +++ b/src/lib/eo/eo.c
> @@ -933,7 +933,10 @@ _eo_add_internal_end(Eo *eo_id)
>   }
>  
> if (EINA_UNLIKELY(!fptr->o.obj))
> -  return NULL;
> + {
> +ERR("Corrupt call stuck, shouldn't happen, please report!");
HEERE
> +return NULL;
> + }
>  
> if (!fptr->o.obj->condtor_done || fptr->o.obj->do_error)
>   {
> diff --git a/src/lib/eo/eo_ptr_indirection.h b/src/lib/eo/eo_ptr_indirection.h
> index 9978701..c801e47 100644
> --- a/src/lib/eo/eo_ptr_indirection.h
> +++ b/src/lib/eo/eo_ptr_indirection.h
> @@ -11,29 +11,45 @@
>  #define EO_OBJ_POINTER_RETURN_VAL(obj_id, obj, ret) \
> _Eo_Object *obj; \
> do { \
> +if (!obj_id) return ret; \
>  obj = _eo_obj_pointer_get((Eo_Id)obj_id); \
> -if (!obj) return ret; \
> +if (!obj) { \
> + ERR("Obj (%p) is an invalid ref.", obj_id); \
> + return ret; \
> +} \
> } while (0)
>  
>  #define EO_OBJ_POINTER_RETURN(obj_id, obj)   \
> _Eo_Object *obj; \
> do { \
> +if (!obj_id) return; \
>  obj = _eo_obj_pointer_get((Eo_Id)obj_id);   \
> -if (!obj) return; \
> +if (!obj) { \
> + ERR("Obj (%p) is an invalid ref.", obj_id); \
> + return; \
> +} \
> } while (0)
>  
>  #define EO_CLASS_POINTER_RETURN_VAL(klass_id, klass, ret) \
> _Eo_Class *klass; \
> do { \
> +if (!klass_id) return ret; \
>  klass = _eo_class_pointer_get(klass_id); \
> -if (!klass) return ret; \
> +if (!klass) { \
> + ERR("Klass (%p) is an invalid ref.", klass_id); \
> + return ret; \
> +} \
> } while (0)
>  
>  #define EO_CLASS_POINTER_RETURN(klass_id, klass)   \
> _Eo_Class *klass; \
> do { \
> +if (!klass_id) return; \
>  klass = _eo_class_pointer_get(klass_id); \
> -if (!klass) return; \
> +if (!klass) { \
> + ERR("Klass (%p) is an invalid ref.", klass_id); \
> + return; \
> +} \
> } while (0)
>  
>  #else
> 
> -- 
> 
> 
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 01/01: ecore: fix compilation, missing return value in ecore_thread_wait

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=cb670931d6000fda6c7e10ecccd41d69b86b53a7

commit cb670931d6000fda6c7e10ecccd41d69b86b53a7
Author: Jérémy Zurcher 
Date:   Wed Jan 7 22:12:29 2015 +0100

ecore: fix compilation, missing return value in ecore_thread_wait

@fix ecore_thread_wait return EINA_TRUE if execution is over or thread is 
NULL
---
 src/lib/ecore/ecore_thread.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/ecore/ecore_thread.c b/src/lib/ecore/ecore_thread.c
index 2be9db0..7266c09 100644
--- a/src/lib/ecore/ecore_thread.c
+++ b/src/lib/ecore/ecore_thread.c
@@ -780,7 +780,7 @@ ecore_thread_wait(Ecore_Thread *thread, double wait)
Ecore_Pthread_Worker *worker = (Ecore_Pthread_Worker*) thread;
Ecore_Thread_Waiter waiter;
 
-   if (!thread) return ;
+   if (!thread) return EINA_TRUE;
 
waiter.data = worker->data;
waiter.func_end = worker->func_end;

-- 

[EGIT] [bindings/ruby/ffi-efl] master 01/01: test_genlist: use defined callback types to avoid building FFI::Function by hand

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/bindings/ruby/ffi-efl.git/commit/?id=a9849b967d92b18b1960c00cc6e7be0d6c2eb49a

commit a9849b967d92b18b1960c00cc6e7be0d6c2eb49a
Author: Jérémy Zurcher 
Date:   Mon Dec 1 10:03:40 2014 +0100

test_genlist: use defined callback types to avoid building  FFI::Function 
by hand
---
 test/test_genlist.rb | 75 
 1 file changed, 47 insertions(+), 28 deletions(-)

diff --git a/test/test_genlist.rb b/test/test_genlist.rb
index 76303c5..86f7c51 100644
--- a/test/test_genlist.rb
+++ b/test/test_genlist.rb
@@ -3,17 +3,29 @@
 #
 require 'efl/elementary_all'
 #
-class ElmGenItemClass < FFI::Struct
-  layout  :version, :int,
-  :refcount, :uint,
-  :delete_me, :pointer,
-  :item_style, :pointer,
-  :decorate_item_style, :pointer,
-  :decorate_all_item_style, :pointer,
-  :text_get, :pointer,
-  :content_get, :pointer,
-  :state_get, :pointer,
-  :del, :pointer
+# require 'efl/native/elm/elm_gen'
+module Efl::Native
+class ElmGenItemClass < FFI::Struct
+  layout  :version, :int,
+  :refcount, :uint,
+  :delete_me, :pointer,
+  :item_style, :pointer,
+  :decorate_item_style, :pointer,
+  :decorate_all_item_style, :pointer,
+  # :text_get, :elm_gen_item_text_get_cb,
+  :text_get, :elm_gen_item_content_get_cb,
+  :content_get, :elm_gen_item_content_get_cb,
+  :state_get, :elm_gen_item_state_get_cb,
+  :del, :elm_gen_item_del_cb
+
+   def self.create style, text_get_fct, content_get_fct
+  i = ElmGenItemClass.new(Native.elm_genlist_item_class_new)
+  i[:item_style] = FFI::MemoryPointer.from_string(style)
+  i[:text_get] = text_get_fct
+  i[:content_get] = content_get_fct
+  i
+   end
+end
 end
 #
 include Efl
@@ -31,33 +43,40 @@ class Window < Elm::ElmWin
   show
 end
 resize_object_add(@bg)
-@itc = ElmGenItemClass.new(Native.elm_genlist_item_class_new)
-@itc[:item_style] = FFI::MemoryPointer.from_string("default")
-@itc[:text_get] = FFI::Function.new(:pointer, [:pointer, :pointer, 
:string]) do |data, *_|
-  ptr = FFI::MemoryPointer.from_string("Item # #{data.read_string}")
-  ptr.autorelease = false
-  ptr
-end
-@itc[:content_get] =  FFI::Function.new(:pointer, [:pointer, :pointer, 
:string]) do |data, obj, part|
-  Elm::ElmIcon.new(self) do
-standard_set(part == "elm.swallow.icon" ? "home" : "clock")
-size_hint_aspect_set 0, 1, 1
-  end.to_ptr
-end
+
 @list = Elm::ElmGenList.new(self) do
   size_hint_weight_expand
   show
 end
+resize_object_add(@list)
+
+@itc = Efl::Native::ElmGenItemClass.create('default', 
method(:item_text_get), method(:item_content_get))
 30.times do |i|
-  @list.item_append(@itc, i.to_s, nil, :elm_genlist_item_none,
-FFI::Function.new(:pointer, [:pointer, :pointer, :pointer]) {|data, 
obj, evt|
-  p [:selected, data.read_string] }, i.to_s)
+  @list.item_append(@itc, i.to_s, nil, :elm_genlist_item_none, 
method(:evt_callback), i.to_s)
 end
-resize_object_add(@list)
+
 smart_callback_add "delete,request", ->(*_) { Elm.exit }, nil
 resize 200, 300
 show
   end
+
+  def evt_callback data, obj, evt
+p [:selected, data.read_string]
+  end
+
+  def item_text_get data, obj, part
+ptr = FFI::MemoryPointer.from_string("Item # #{data.read_string}")
+ptr.autorelease = false
+ptr
+  end
+
+  def item_content_get data, obj, part
+Elm::ElmIcon.new(self) do
+  standard_set(part == "elm.swallow.icon" ? "home" : "clock")
+  size_hint_aspect_set 0, 1, 1
+end.to_ptr
+  end
+
 end
 #
 Window.new

-- 

Re: [E-devel] [EGIT] [core/efl] master 01/01: tests/eo: Do not test for an integer when you get a pointer.

[Jérémy Zurcher]

bad copy/paste ... but check 0.9.14 do not care about expr type
so I had no compiler complain

what i noticed is that fail_if and friends are all deprecated in favour
of ck_assert() and friends
http://check.sourceforge.net/doc/check_html/check_4.html


On Friday 21 November 2014  01:36, Stefan Schmidt wrote :
> stefan pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/efl.git/commit/?id=e42db35528189200d48e3052c4abac03a43b7b10
> 
> commit e42db35528189200d48e3052c4abac03a43b7b10
> Author: Stefan Schmidt 
> Date:   Fri Nov 21 10:20:36 2014 +0100
> 
> tests/eo: Do not test for an integer when you get a pointer.
> 
> It works but the compiler is right when complaining about it. 
> fail_unless()
> expects and integer but we passed in a pointer. Negate the pointer and use
> fail_if() like we do in all other places.
> ---
>  src/tests/eo/suite/eo_test_class_behaviour_errors.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/tests/eo/suite/eo_test_class_behaviour_errors.c 
> b/src/tests/eo/suite/eo_test_class_behaviour_errors.c
> index 1bd0e15..300f3fa 100644
> --- a/src/tests/eo/suite/eo_test_class_behaviour_errors.c
> +++ b/src/tests/eo/suite/eo_test_class_behaviour_errors.c
> @@ -43,10 +43,10 @@ START_TEST(eo_destructor_unref)
> };
>  
> klass = eo_class_new(&class_desc, SIMPLE_CLASS, NULL);
> -   fail_unless(klass);
> +   fail_if(!klass);
>  
> Eo *obj = eo_add(klass, NULL);
> -   fail_unless(obj);
> +   fail_if(!obj);
>  
> TEST_EO_ERROR("_eo_unref", "Object %p deletion already triggered. You 
> wrongly call eo_unref() within a destructor.");
> eo_unref(obj);
> 
> -- 
> 
> 
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 01/01: Eo: protect against recursive object destruction calls, fixes T1741

[Jérémy Zurcher]

tasn pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=18ceed4daf31d2f19261e0fe018c870581357ed0

commit 18ceed4daf31d2f19261e0fe018c870581357ed0
Author: Jérémy Zurcher 
Date:   Tue Nov 18 15:24:39 2014 +

Eo: protect against recursive object destruction calls, fixes T1741

Summary:
Eo: semantic obj->del replaced by obj->destructed
Eo: protect against recursive object destruction calls
Eo: add tests for bfada4b

Reviewers: JackDanielZ, tasn

Reviewed By: tasn

Subscribers: cedric

Maniphest Tasks: T1741

Differential Revision: https://phab.enlightenment.org/D1675

Fixes T1741

@fix
---
 src/Makefile_Eo.am |  1 +
 src/lib/eo/eo.c|  4 +-
 src/lib/eo/eo_private.h| 16 --
 src/tests/eo/suite/eo_suite.c  |  1 +
 src/tests/eo/suite/eo_suite.h  |  1 +
 .../eo/suite/eo_test_class_behaviour_errors.c  | 63 ++
 6 files changed, 80 insertions(+), 6 deletions(-)

diff --git a/src/Makefile_Eo.am b/src/Makefile_Eo.am
index 306c8c3..1b3ea4a 100644
--- a/src/Makefile_Eo.am
+++ b/src/Makefile_Eo.am
@@ -121,6 +121,7 @@ tests/eo/suite/eo_suite.h \
 tests/eo/suite/eo_error_msgs.h \
 tests/eo/suite/eo_error_msgs.c \
 tests/eo/suite/eo_test_class_errors.c \
+tests/eo/suite/eo_test_class_behaviour_errors.c \
 tests/eo/suite/eo_test_call_errors.c \
 tests/eo/suite/eo_test_general.c \
 tests/eo/suite/eo_test_value.c \
diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
index 37dae75..cc1f8b9 100644
--- a/src/lib/eo/eo.c
+++ b/src/lib/eo/eo.c
@@ -1855,7 +1855,7 @@ eo_destructed_is(const Eo *obj_id)
 {
EO_OBJ_POINTER_RETURN_VAL(obj_id, obj, EINA_FALSE);
 
-   return obj->del;
+   return obj->destructed;
 }
 
 EAPI void
@@ -1876,7 +1876,7 @@ eo_manual_free(Eo *obj_id)
 return EINA_FALSE;
  }
 
-   if (!obj->del)
+   if (!obj->destructed)
  {
 ERR("Tried deleting the object %p while still referenced(%d).", 
obj_id, obj->refcount);
 return EINA_FALSE;
diff --git a/src/lib/eo/eo_private.h b/src/lib/eo/eo_private.h
index c652271..7ea5014 100644
--- a/src/lib/eo/eo_private.h
+++ b/src/lib/eo/eo_private.h
@@ -104,7 +104,8 @@ struct _Eo_Object
  Eina_Bool finalized:1;
 
  Eina_Bool composite:1;
- Eina_Bool del:1;
+ Eina_Bool del_triggered:1;
+ Eina_Bool destructed:1;
  Eina_Bool manual_free:1;
 };
 
@@ -235,7 +236,7 @@ _eo_del_internal(const char *file, int line, _Eo_Object 
*obj)
   }
  }
 
-   obj->del = EINA_TRUE;
+   obj->destructed = EINA_TRUE;
obj->refcount--;
 }
 
@@ -278,9 +279,16 @@ _eo_unref(_Eo_Object *obj)
--(obj->refcount);
if (obj->refcount == 0)
  {
-if (obj->del)
+if (obj->del_triggered)
   {
- ERR("Object %p already deleted.", obj);
+ ERR("Object %p deletion already triggered. You wrongly call 
eo_unref() within a destructor.", obj);
+ return;
+  }
+obj->del_triggered = EINA_TRUE;
+
+if (obj->destructed)
+  {
+ ERR("Object %p already destructed.", obj);
  return;
   }
 
diff --git a/src/tests/eo/suite/eo_suite.c b/src/tests/eo/suite/eo_suite.c
index 42c6645..90f5577 100644
--- a/src/tests/eo/suite/eo_suite.c
+++ b/src/tests/eo/suite/eo_suite.c
@@ -20,6 +20,7 @@ static const Eo_Test_Case etc[] = {
   { "Eo init", eo_test_init },
   { "Eo general", eo_test_general },
   { "Eo class errors", eo_test_class_errors },
+  { "Eo class behaviour errors", eo_test_class_behaviour_errors },
   { "Eo call errors", eo_test_call_errors },
   { "Eo eina value", eo_test_value },
   { "Eo threaded eo calls", eo_test_threaded_calls },
diff --git a/src/tests/eo/suite/eo_suite.h b/src/tests/eo/suite/eo_suite.h
index 94d88bd..ba07799 100644
--- a/src/tests/eo/suite/eo_suite.h
+++ b/src/tests/eo/suite/eo_suite.h
@@ -6,6 +6,7 @@
 void eo_test_init(TCase *tc);
 void eo_test_general(TCase *tc);
 void eo_test_class_errors(TCase *tc);
+void eo_test_class_behaviour_errors(TCase *tc);
 void eo_test_call_errors(TCase *tc);
 void eo_test_value(TCase *tc);
 void eo_test_threaded_calls(TCase *tc);
diff --git a/src/tests/eo/suite/eo_test_class_behaviour_errors.c 
b/src/tests/eo/suite/eo_test_class_behaviour_errors.c
new file mode 100644
index 000..1bd0e15
--- /dev/null
+++ b/src/tests/eo/suite/eo_test_class_behaviour_errors.c
@@ -0,0 +1,63 @@
+#ifdef HAVE_CONFIG_H
+# include 
+#endif
+
+#include 
+
+#include "Eo.h"
+#include "eo_suite.h"
+#include "eo_error_msgs.h"
+#include "eo_test_class_simple.h"
+
+static struct log_ctx ctx;
+
+const Eo_Class *klass;
+
+static

[EGIT] [core/efl] master 01/01: eina_value_util_type_offset: abs(unsigned int) is nonsense

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=65b2dd391afd781243d44223df0b7d0d4ec0ef85

commit 65b2dd391afd781243d44223df0b7d0d4ec0ef85
Author: Jérémy Zurcher 
Date:   Wed Sep 24 11:15:58 2014 +0200

eina_value_util_type_offset: abs(unsigned int) is nonsense
---
 src/lib/eina/eina_inline_value_util.x | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/eina/eina_inline_value_util.x 
b/src/lib/eina/eina_inline_value_util.x
index 2cb96e4..a6a854e 100644
--- a/src/lib/eina/eina_inline_value_util.x
+++ b/src/lib/eina/eina_inline_value_util.x
@@ -58,7 +58,7 @@ eina_value_util_type_offset(const Eina_Value_Type *type, 
unsigned int base)
size = eina_value_util_type_size(type);
if (!(base % size))
  return base;
-   padding = abs(base - size);
+   padding = ( (base > size) ? (base - size) : (size - base));
return base + padding;
 }
 

-- 

Re: [E-devel] Edevelop IRC bot

[Jérémy Zurcher]

On Tuesday 23 September 2014  16:08, Tom Hacohen wrote :
> Hey,
> 
> I don't see the use. Send emails. :)
> 
> Anyhow though, OMG RUBY. :
I love ruby as much as i dislike python ;))
> 
> --
> Tom.
> 

--
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 01/01: evas/engines: avoid redefinition of typedef Outbuf

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=119134751fc0e4aa12d29faf8675a9e111ac5e08

commit 119134751fc0e4aa12d29faf8675a9e111ac5e08
Author: Jérémy Zurcher 
Date:   Tue Sep 23 11:15:11 2014 +0200

evas/engines: avoid redefinition of typedef Outbuf

'typedef struct _Outbuf Outbuf' is in 
software_generic/Evas_Engine_Software_Generic.h
that is always included
---
 src/modules/evas/engines/drm/evas_engine.h| 1 -
 src/modules/evas/engines/gl_drm/evas_engine.h | 1 -
 src/modules/evas/engines/gl_x11/evas_engine.h | 2 --
 src/modules/evas/engines/software_ddraw/evas_engine.h | 1 -
 src/modules/evas/engines/software_gdi/evas_engine.h   | 1 -
 src/modules/evas/engines/wayland_egl/evas_engine.h| 2 --
 src/modules/evas/engines/wayland_shm/evas_engine.h| 2 --
 7 files changed, 10 deletions(-)

diff --git a/src/modules/evas/engines/drm/evas_engine.h 
b/src/modules/evas/engines/drm/evas_engine.h
index 0e7ae1c..4bb6a91 100644
--- a/src/modules/evas/engines/drm/evas_engine.h
+++ b/src/modules/evas/engines/drm/evas_engine.h
@@ -51,7 +51,6 @@ extern int _evas_engine_drm_log_dom;
 
 typedef struct _Buffer Buffer;
 typedef struct _Plane Plane;
-typedef struct _Outbuf Outbuf;
 
 struct _Buffer
 {
diff --git a/src/modules/evas/engines/gl_drm/evas_engine.h 
b/src/modules/evas/engines/gl_drm/evas_engine.h
index 3e07f08..622f832 100644
--- a/src/modules/evas/engines/gl_drm/evas_engine.h
+++ b/src/modules/evas/engines/gl_drm/evas_engine.h
@@ -67,7 +67,6 @@ extern Evas_GL_Preload_Render_Call 
glsym_evas_gl_preload_render_unlock;
 
 typedef struct _Buffer Buffer;
 typedef struct _Plane Plane;
-typedef struct _Outbuf Outbuf;
 
 struct _Buffer
 {
diff --git a/src/modules/evas/engines/gl_x11/evas_engine.h 
b/src/modules/evas/engines/gl_x11/evas_engine.h
index 4ea9645..37ffb93 100644
--- a/src/modules/evas/engines/gl_x11/evas_engine.h
+++ b/src/modules/evas/engines/gl_x11/evas_engine.h
@@ -58,8 +58,6 @@ extern int _evas_engine_GL_X11_log_dom ;
 #endif
 #define CRI(...) EINA_LOG_DOM_CRIT(_evas_engine_GL_X11_log_dom, __VA_ARGS__)
 
-typedef struct _Outbuf Outbuf;
-
 struct _Outbuf
 {
 #ifdef GL_GLES
diff --git a/src/modules/evas/engines/software_ddraw/evas_engine.h 
b/src/modules/evas/engines/software_ddraw/evas_engine.h
index 4b5aea2..25b3f45 100644
--- a/src/modules/evas/engines/software_ddraw/evas_engine.h
+++ b/src/modules/evas/engines/software_ddraw/evas_engine.h
@@ -9,7 +9,6 @@
 
 #include "../software_generic/Evas_Engine_Software_Generic.h"
 
-typedef struct _OutbufOutbuf;
 typedef struct _Outbuf_Region Outbuf_Region;
 typedef struct _DD_Output_Buffer  DD_Output_Buffer;
 
diff --git a/src/modules/evas/engines/software_gdi/evas_engine.h 
b/src/modules/evas/engines/software_gdi/evas_engine.h
index b8d83bc..d8c08ff 100644
--- a/src/modules/evas/engines/software_gdi/evas_engine.h
+++ b/src/modules/evas/engines/software_gdi/evas_engine.h
@@ -36,7 +36,6 @@ extern int _evas_engine_soft_gdi_log_dom;
 #define CRI(...) EINA_LOG_DOM_CRIT(_evas_engine_soft_gdi_log_dom, __VA_ARGS__)
 
 typedef struct BITMAPINFO_GDI BITMAPINFO_GDI;
-typedef struct _OutbufOutbuf;
 typedef struct _Outbuf_Region Outbuf_Region;
 typedef struct _Gdi_Output_Buffer Gdi_Output_Buffer;
 
diff --git a/src/modules/evas/engines/wayland_egl/evas_engine.h 
b/src/modules/evas/engines/wayland_egl/evas_engine.h
index 68d8a1f..0d22968 100644
--- a/src/modules/evas/engines/wayland_egl/evas_engine.h
+++ b/src/modules/evas/engines/wayland_egl/evas_engine.h
@@ -49,8 +49,6 @@ extern int _evas_engine_wl_egl_log_dom;
 #  define EGL_BUFFER_AGE_EXT 0x313d
 # endif
 
-typedef struct _Outbuf Outbuf;
-
 struct _Outbuf
 {
struct wl_display *disp;
diff --git a/src/modules/evas/engines/wayland_shm/evas_engine.h 
b/src/modules/evas/engines/wayland_shm/evas_engine.h
index 7309596..9892449 100644
--- a/src/modules/evas/engines/wayland_shm/evas_engine.h
+++ b/src/modules/evas/engines/wayland_shm/evas_engine.h
@@ -43,8 +43,6 @@ extern int _evas_engine_way_shm_log_dom;
 
 #include "../software_generic/Evas_Engine_Software_Generic.h"
 
-typedef struct _Outbuf Outbuf;
-
 struct _Outbuf
 {
Evas_Engine_Info_Wayland_Shm *info;

-- 

[EGIT] [core/efl] master 02/09: eo: fix call stack shrink_frame

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=007efb5f05e33dee024da658077fe3e4977993bc

commit 007efb5f05e33dee024da658077fe3e4977993bc
Author: Jérémy Zurcher 
Date:   Tue Sep 23 10:24:06 2014 +0200

eo: fix call stack shrink_frame

- do never shrink under EO_CALL_STACK_DEPTH_MIN size
- set shrink_frame at (current_size/2) - EO_CALL_STACK_SHRINK_OFFSET
---
 src/lib/eo/eo.c | 18 +++---
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
index 5713f4e..3ab323f 100644
--- a/src/lib/eo/eo.c
+++ b/src/lib/eo/eo.c
@@ -259,7 +259,8 @@ EAPI Eo_Hook_Call eo_hook_call_post = NULL;
 #define EO_INVALID_DATA (void *) -1
 // 1024 entries == 8k or 16k (32 or 64bit) for eo call stack. that's 1024
 // recursion entires it can handle before barfing. i'd say that's ok
-#define EO_CALL_STACK_DEPTH 16
+#define EO_CALL_STACK_DEPTH_MIN 16
+#define EO_CALL_STACK_SHRINK_DROP 8
 
 typedef struct _Eo_Stack_Frame
 {
@@ -355,7 +356,7 @@ _eo_call_stack_create()
  return NULL;
 
 // XXX: leave in for noew in case this breaks, but remove later when ok
-//   stack->frames = calloc(EO_CALL_STACK_DEPTH, sizeof(Eo_Stack_Frame));
+//   stack->frames = calloc(EO_CALL_STACK_DEPTH_MIN, sizeof(Eo_Stack_Frame));
stack->max_size = 8192 * sizeof(Eo_Stack_Frame);
stack->frames = _eo_call_stack_mem_alloc(stack->max_size);
if (!stack->frames)
@@ -366,7 +367,7 @@ _eo_call_stack_create()
 
// first frame is never used
stack->frame_ptr = stack->frames;
-   stack->last_frame = &stack->frames[EO_CALL_STACK_DEPTH - 1];
+   stack->last_frame = &stack->frames[EO_CALL_STACK_DEPTH_MIN - 1];
stack->shrink_frame = stack->frames;
 
return stack;
@@ -461,12 +462,15 @@ _eo_call_stack_resize(Eo_Call_Stack *stack, Eina_Bool 
grow)
stack->frame_ptr = &stack->frames[frame_offset];
stack->last_frame = &stack->frames[next_sz - 1];
 
-   if (grow)
- frame_offset = (sz >> 1);
-   if (next_sz == EO_CALL_STACK_DEPTH)
+   if (next_sz == EO_CALL_STACK_DEPTH_MIN)
  frame_offset = 0;
else
- frame_offset = (next_sz >> 1);
+ {
+if (grow)
+  frame_offset = sz - EO_CALL_STACK_SHRINK_DROP;
+else
+  frame_offset = (next_sz / 2) - EO_CALL_STACK_SHRINK_DROP;
+ }
stack->shrink_frame = &stack->frames[frame_offset];
 }
 

-- 

[EGIT] [core/efl] master 08/09: eo: call stack depth is 1024

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=b3ffe9229ad8b91c455cc9d6f59463c83fd8a6a1

commit b3ffe9229ad8b91c455cc9d6f59463c83fd8a6a1
Author: Jérémy Zurcher 
Date:   Tue Sep 23 10:51:05 2014 +0200

eo: call stack depth is 1024
---
 src/lib/eo/eo.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
index 319eb09..e04e2a2 100644
--- a/src/lib/eo/eo.c
+++ b/src/lib/eo/eo.c
@@ -257,10 +257,10 @@ EAPI Eo_Hook_Call eo_hook_call_pre = NULL;
 EAPI Eo_Hook_Call eo_hook_call_post = NULL;
 
 #define EO_INVALID_DATA (void *) -1
-// 1024 entries == 8k or 16k (32 or 64bit) for eo call stack. that's 1024
-// recursion entires it can handle before barfing. i'd say that's ok
-#define EO_CALL_STACK_DEPTH_MIN 16
-#define EO_CALL_STACK_SHRINK_DROP 8
+// 1024 entries == 16k or 32k (32 or 64bit) for eo call stack. that's 1023
+// imbricated/recursive calls it can handle before barfing. i'd say that's ok
+#define EO_CALL_STACK_DEPTH_MIN 1024
+#define EO_CALL_STACK_SHRINK_DROP (EO_CALL_STACK_DEPTH_MIN >> 1)
 
 typedef struct _Eo_Stack_Frame
 {

-- 

[EGIT] [core/efl] master 07/09: eo: call stack can grow/shrink when not using mmap

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=389c6d35f2908018e8b6ae3f8294c02c6b5073a0

commit 389c6d35f2908018e8b6ae3f8294c02c6b5073a0
Author: Jérémy Zurcher 
Date:   Tue Sep 23 10:47:24 2014 +0200

eo: call stack can grow/shrink when not using mmap

- if HAVE_MMAP call stack do not shrink and abort() when should grow
- otherwise it's a growing/shrinking stack using realloc
---
 src/lib/eo/eo.c | 20 +---
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
index b27b221..319eb09 100644
--- a/src/lib/eo/eo.c
+++ b/src/lib/eo/eo.c
@@ -314,20 +314,27 @@ _eo_call_stack_mem_alloc(size_t size)
 static void
 _eo_call_stack_mem_resize(void **ptr EINA_UNUSED, size_t newsize, size_t size)
 {
-   // resize call stack down - currently won't ever be called
+   // FIXME we don't grow
if (newsize > size)
  {
 CRI("eo call stack overflow, abort.");
 abort();
  }
+   // FIXME resize call stack down
+   return;
size_t addr = MEM_PAGE_SIZE * ((newsize + MEM_PAGE_SIZE - 1) /
   MEM_PAGE_SIZE);
madvise(((unsigned char *)*ptr) + addr, size - addr, MADV_DONTNEED);
 #else
 static void
-_eo_call_stack_mem_resize(void **ptr EINA_UNUSED, size_t newsize EINA_UNUSED, 
size_t size EINA_UNUSED)
+_eo_call_stack_mem_resize(void **ptr, size_t newsize, size_t size EINA_UNUSED)
 {
-   // just grow in regular cases
+   *ptr = realloc(*ptr, newsize);
+   if (!*ptr)
+ {
+CRI("eo call stack resize failed, abort.");
+abort();
+ }
 #endif
 }
 
@@ -427,10 +434,9 @@ _eo_call_stack_resize(Eo_Call_Stack *stack, Eina_Bool grow)
frame_offset = stack->frame_ptr - stack->frames;
 
DBG("resize from %lu to %lu", (long unsigned int)sz, (long unsigned 
int)next_sz);
-   if (!grow)
- _eo_call_stack_mem_resize((void **)&(stack->frames),
-   next_sz * sizeof(Eo_Stack_Frame),
-   sz * sizeof(Eo_Stack_Frame));
+   _eo_call_stack_mem_resize((void **)&(stack->frames),
+ next_sz * sizeof(Eo_Stack_Frame),
+ sz * sizeof(Eo_Stack_Frame));
if (!stack->frames)
  {
 CRI("unable to resize call stack, abort.");

-- 

[EGIT] [core/efl] master 09/09: eolian: silence uninitialized var in goto end branch

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=cbcb8e29ec8217acf7eb6cdc210413158a5b32da

commit cbcb8e29ec8217acf7eb6cdc210413158a5b32da
Author: Jérémy Zurcher 
Date:   Tue Sep 23 10:56:57 2014 +0200

eolian: silence uninitialized var in goto end branch
---
 src/bin/eolian/eo_generator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/eolian/eo_generator.c b/src/bin/eolian/eo_generator.c
index 56e40ab..24e93bc 100644
--- a/src/bin/eolian/eo_generator.c
+++ b/src/bin/eolian/eo_generator.c
@@ -968,7 +968,7 @@ Eina_Bool
 eo_source_generate(const Eolian_Class *class, Eina_Strbuf *buf)
 {
Eina_Bool ret = EINA_FALSE;
-   Eina_Iterator *itr;
+   Eina_Iterator *itr = NULL;
 
Eina_Strbuf *str_bodyf = eina_strbuf_new();
 

-- 

[EGIT] [core/efl] master 06/09: eo: remove stack->max_size

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=88c5996dc16b6356ec03f9c4d0562203c6d0cb54

commit 88c5996dc16b6356ec03f9c4d0562203c6d0cb54
Author: Jérémy Zurcher 
Date:   Tue Sep 23 10:43:36 2014 +0200

eo: remove stack->max_size

- define EO_CALL_STACK_SIZE instead of stack->max_size
- we are talking about size here not maxsize
---
 src/lib/eo/eo.c | 30 +++---
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
index 6b0834a..b27b221 100644
--- a/src/lib/eo/eo.c
+++ b/src/lib/eo/eo.c
@@ -273,6 +273,8 @@ typedef struct _Eo_Stack_Frame
void  *obj_data;
 } Eo_Stack_Frame;
 
+#define EO_CALL_STACK_SIZE (EO_CALL_STACK_DEPTH_MIN * sizeof(Eo_Stack_Frame))
+
 static Eina_TLS _eo_call_stack_key = 0;
 
 typedef struct _Eo_Call_Stack {
@@ -280,20 +282,19 @@ typedef struct _Eo_Call_Stack {
Eo_Stack_Frame *frame_ptr;
Eo_Stack_Frame *last_frame;
Eo_Stack_Frame *shrink_frame;
-   size_t max_size;
 } Eo_Call_Stack;
 
 #define MEM_PAGE_SIZE 4096
 
 static void *
-_eo_call_stack_mem_alloc(size_t maxsize)
+_eo_call_stack_mem_alloc(size_t size)
 {
 #ifdef HAVE_MMAP
// allocate eo call stack via mmped anon segment if on linux - more
// secure and safe. also gives page aligned memory allowing madvise
void *ptr;
size_t newsize;
-   newsize = MEM_PAGE_SIZE * ((maxsize + MEM_PAGE_SIZE - 1) /
+   newsize = MEM_PAGE_SIZE * ((size + MEM_PAGE_SIZE - 1) /
   MEM_PAGE_SIZE);
ptr = mmap(NULL, newsize, PROT_READ | PROT_WRITE,
   MAP_PRIVATE | MAP_ANON, -1, 0);
@@ -305,26 +306,26 @@ _eo_call_stack_mem_alloc(size_t maxsize)
return ptr;
 #else
//in regular cases just use malloc
-   return calloc(1, maxsize);
+   return calloc(1, size);
 #endif
 }
 
 #ifdef HAVE_MMAP
 static void
-_eo_call_stack_mem_resize(void **ptr EINA_UNUSED, size_t newsize, size_t 
maxsize)
+_eo_call_stack_mem_resize(void **ptr EINA_UNUSED, size_t newsize, size_t size)
 {
// resize call stack down - currently won't ever be called
-   if (newsize > maxsize)
+   if (newsize > size)
  {
 CRI("eo call stack overflow, abort.");
 abort();
  }
size_t addr = MEM_PAGE_SIZE * ((newsize + MEM_PAGE_SIZE - 1) /
   MEM_PAGE_SIZE);
-   madvise(((unsigned char *)*ptr) + addr, maxsize - addr, MADV_DONTNEED);
+   madvise(((unsigned char *)*ptr) + addr, size - addr, MADV_DONTNEED);
 #else
 static void
-_eo_call_stack_mem_resize(void **ptr EINA_UNUSED, size_t newsize EINA_UNUSED, 
size_t maxsize EINA_UNUSED)
+_eo_call_stack_mem_resize(void **ptr EINA_UNUSED, size_t newsize EINA_UNUSED, 
size_t size EINA_UNUSED)
 {
// just grow in regular cases
 #endif
@@ -332,13 +333,13 @@ _eo_call_stack_mem_resize(void **ptr EINA_UNUSED, size_t 
newsize EINA_UNUSED, si
 
 #ifdef HAVE_MMAP
 static void
-_eo_call_stack_mem_free(void *ptr, size_t maxsize)
+_eo_call_stack_mem_free(void *ptr, size_t size)
 {
// free mmaped memory
-   munmap(ptr, maxsize);
+   munmap(ptr, size);
 #else
 static void
-_eo_call_stack_mem_free(void *ptr, size_t maxsize EINA_UNUSED)
+_eo_call_stack_mem_free(void *ptr, size_t size EINA_UNUSED)
 {
// free regular memory
free(ptr);
@@ -354,8 +355,7 @@ _eo_call_stack_create()
if (!stack)
  return NULL;
 
-   stack->max_size = 8192 * sizeof(Eo_Stack_Frame);
-   stack->frames = _eo_call_stack_mem_alloc(stack->max_size);
+   stack->frames = _eo_call_stack_mem_alloc(EO_CALL_STACK_SIZE);
if (!stack->frames)
  {
 free(stack);
@@ -378,7 +378,7 @@ _eo_call_stack_free(void *ptr)
if (!stack) return;
 
if (stack->frames)
- _eo_call_stack_mem_free(stack->frames, stack->max_size);
+ _eo_call_stack_mem_free(stack->frames, EO_CALL_STACK_SIZE);
 
free(stack);
 }
@@ -430,7 +430,7 @@ _eo_call_stack_resize(Eo_Call_Stack *stack, Eina_Bool grow)
if (!grow)
  _eo_call_stack_mem_resize((void **)&(stack->frames),
next_sz * sizeof(Eo_Stack_Frame),
-   stack->max_size);
+   sz * sizeof(Eo_Stack_Frame));
if (!stack->frames)
  {
 CRI("unable to resize call stack, abort.");

-- 

[EGIT] [core/efl] master 03/09: eo: call stack remove stack->dropcount

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=95e610d89a635027886849dc460d1ad3d6d9c50b

commit 95e610d89a635027886849dc460d1ad3d6d9c50b
Author: Jérémy Zurcher 
Date:   Tue Sep 23 10:26:33 2014 +0200

eo: call stack remove stack->dropcount

stack->shrink_frame does the same but more efficiently
change the value of EO_CALL_STACK_SHRINK_DROP if needed
---
 src/lib/eo/eo.c | 21 +++--
 1 file changed, 3 insertions(+), 18 deletions(-)

diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
index 3ab323f..3957e8f 100644
--- a/src/lib/eo/eo.c
+++ b/src/lib/eo/eo.c
@@ -281,7 +281,6 @@ typedef struct _Eo_Call_Stack {
Eo_Stack_Frame *last_frame;
Eo_Stack_Frame *shrink_frame;
size_t max_size;
-   int dropcount;
 } Eo_Call_Stack;
 
 #define MEM_PAGE_SIZE 4096
@@ -427,23 +426,9 @@ _eo_call_stack_resize(Eo_Call_Stack *stack, Eina_Bool grow)
 
sz = stack->last_frame - stack->frames + 1;
if (grow)
- {
-next_sz = sz * 2;
-// reset drop counter to avoid dropping stack for up to 2 ^ 18
-// requests/tries
-stack->dropcount = 1 << 18;
- }
+ next_sz = sz * 2;
else
- {
-// if we want to drop - delay if dropcounter still > 0 and drop it
-if (stack->dropcount > 0)
-  {
- stack->dropcount--;
- return;
-  }
-// actually drop
-next_sz = sz / 2;
- }
+ next_sz = sz / 2;
frame_offset = stack->frame_ptr - stack->frames;
 
DBG("resize from %lu to %lu", (long unsigned int)sz, (long unsigned 
int)next_sz);
@@ -568,7 +553,7 @@ _eo_do_end(const Eo **eo_id EINA_UNUSED)
 
stack->frame_ptr--;
 
-   if (fptr <= stack->shrink_frame)
+   if (fptr == stack->shrink_frame)
  _eo_call_stack_resize(stack, EINA_FALSE);
 }
 

-- 

[EGIT] [core/efl] master 04/09: eo: unify error msgs

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=a4c3299f413b559be00ee6c59fc920104d4b55b0

commit a4c3299f413b559be00ee6c59fc920104d4b55b0
Author: Jérémy Zurcher 
Date:   Tue Sep 23 10:29:44 2014 +0200

eo: unify error msgs
---
 src/lib/eo/eo.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
index 3957e8f..760dd39 100644
--- a/src/lib/eo/eo.c
+++ b/src/lib/eo/eo.c
@@ -299,7 +299,7 @@ _eo_call_stack_mem_alloc(size_t maxsize)
   MAP_PRIVATE | MAP_ANON, -1, 0);
if (ptr == MAP_FAILED)
  {
-ERR("mmap of eo callstack failed!");
+ERR("eo call stack mmap failed.");
 return NULL;
  }
return ptr;
@@ -316,7 +316,7 @@ _eo_call_stack_mem_resize(void **ptr EINA_UNUSED, size_t 
newsize, size_t maxsize
// resize call stack down - currently won't ever be called
if (newsize > maxsize)
  {
-ERR("eo callstack overflow");
+CRI("eo call stack overflow, abort.");
 abort();
  }
size_t addr = MEM_PAGE_SIZE * ((newsize + MEM_PAGE_SIZE - 1) /
@@ -547,7 +547,7 @@ _eo_do_end(const Eo **eo_id EINA_UNUSED)
 
if (fptr == stack->frames)
  {
-CRI("call stack underflow, abort.");
+CRI("eo call stack underflow, abort.");
 abort();
  }
 

-- 

[EGIT] [core/efl] master 01/09: eo: remove FIXME: Thread Local Storage

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=209a7506c336391e000f2b93c19fc1b2e1b317d9

commit 209a7506c336391e000f2b93c19fc1b2e1b317d9
Author: Jérémy Zurcher 
Date:   Tue Sep 23 10:21:26 2014 +0200

eo: remove FIXME: Thread Local Storage

done in d39d7050
---
 src/lib/eo/eo.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
index b5df088..5713f4e 100644
--- a/src/lib/eo/eo.c
+++ b/src/lib/eo/eo.c
@@ -256,7 +256,6 @@ _eo_kls_itr_next(const _Eo_Class *orig_kls, const _Eo_Class 
*cur_klass, Eo_Op op
 EAPI Eo_Hook_Call eo_hook_call_pre = NULL;
 EAPI Eo_Hook_Call eo_hook_call_post = NULL;
 
-// FIXME: Thread Local Storage
 #define EO_INVALID_DATA (void *) -1
 // 1024 entries == 8k or 16k (32 or 64bit) for eo call stack. that's 1024
 // recursion entires it can handle before barfing. i'd say that's ok

-- 

[EGIT] [core/efl] master 05/09: eo: remove XXX, it's ok now ...

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=dc3add048f3bdf5e0ed4a138bba89e70d5e1c0c4

commit dc3add048f3bdf5e0ed4a138bba89e70d5e1c0c4
Author: Jérémy Zurcher 
Date:   Tue Sep 23 10:41:13 2014 +0200

eo: remove XXX, it's ok now ...
---
 src/lib/eo/eo.c | 11 ++-
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
index 760dd39..6b0834a 100644
--- a/src/lib/eo/eo.c
+++ b/src/lib/eo/eo.c
@@ -354,8 +354,6 @@ _eo_call_stack_create()
if (!stack)
  return NULL;
 
-// XXX: leave in for noew in case this breaks, but remove later when ok
-//   stack->frames = calloc(EO_CALL_STACK_DEPTH_MIN, sizeof(Eo_Stack_Frame));
stack->max_size = 8192 * sizeof(Eo_Stack_Frame);
stack->frames = _eo_call_stack_mem_alloc(stack->max_size);
if (!stack->frames)
@@ -380,11 +378,8 @@ _eo_call_stack_free(void *ptr)
if (!stack) return;
 
if (stack->frames)
- {
-// XXX: leave in for noew in case this breaks, but remove later when ok
-//free(stack->frames);
-_eo_call_stack_mem_free(stack->frames, stack->max_size);
- }
+ _eo_call_stack_mem_free(stack->frames, stack->max_size);
+
free(stack);
 }
 
@@ -432,8 +427,6 @@ _eo_call_stack_resize(Eo_Call_Stack *stack, Eina_Bool grow)
frame_offset = stack->frame_ptr - stack->frames;
 
DBG("resize from %lu to %lu", (long unsigned int)sz, (long unsigned 
int)next_sz);
-// XXX: leave in for noew in case this breaks, but remove later when ok
-//   stack->frames = realloc(stack->frames, next_sz * sizeof(Eo_Stack_Frame));
if (!grow)
  _eo_call_stack_mem_resize((void **)&(stack->frames),
next_sz * sizeof(Eo_Stack_Frame),

-- 

[EGIT] [core/efl] master 01/01: eet: call LOCK_CACHE before altering Eet_File

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=2e5a5d6656e9fca4ee756819dcd17e875225e447

commit 2e5a5d6656e9fca4ee756819dcd17e875225e447
Author: Jérémy Zurcher 
Date:   Mon Sep 8 21:38:01 2014 +0200

eet: call LOCK_CACHE before altering Eet_File

even if not necessary in this particular case,
do as in eet_mmap() and eet_open(),
lock the cache before altering Eet_File struct.

fix CID 1039366 1039367 1039368 1039369
---
 src/lib/eet/eet_lib.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/lib/eet/eet_lib.c b/src/lib/eet/eet_lib.c
index 69d8bca..daa6d3b 100644
--- a/src/lib/eet/eet_lib.c
+++ b/src/lib/eet/eet_lib.c
@@ -1397,6 +1397,9 @@ eet_memopen_read(const void *data,
if (!ef)
  return NULL;
 
+   /* eet_internal_read expects the cache lock to be held when it is called */
+   LOCK_CACHE;
+
INIT_FILE(ef);
ef->ed = NULL;
ef->path = NULL;
@@ -1413,8 +1416,6 @@ eet_memopen_read(const void *data,
ef->sha1_length = 0;
ef->readfp_owned = EINA_FALSE;
 
-   /* eet_internal_read expects the cache lock to be held when it is called */
-   LOCK_CACHE;
ef = eet_internal_read(ef);
UNLOCK_CACHE;
return ef;

-- 

[EGIT] [core/enlightenment] master 01/01: add missing 'pragma GCC diagnostic push'

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=25aabe7aa75a4636430b1b07234464bb733bbd36

commit 25aabe7aa75a4636430b1b07234464bb733bbd36
Author: Jérémy Zurcher 
Date:   Wed Aug 27 09:22:27 2014 +0200

add missing 'pragma GCC diagnostic push'
---
 src/bin/e_comp_wl.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/bin/e_comp_wl.h b/src/bin/e_comp_wl.h
index dca0592..e68a624 100644
--- a/src/bin/e_comp_wl.h
+++ b/src/bin/e_comp_wl.h
@@ -5,6 +5,7 @@
 #  define E_COMP_WL_H
 
 /* NB: Turn off shadow warnings for Wayland includes */
+#  pragma GCC diagnostic push
 #  pragma GCC diagnostic ignored "-Wshadow"
 #  define WL_HIDE_DEPRECATED
 #  include 

-- 

Re: [E-devel] Question about eina_stringshare_refplace

[Jérémy Zurcher]

Hi,

On Monday 25 August 2014  20:45, ryuan Choi wrote :
> Hi,
> 
> While trying to use eina_stringshare_refplace(), I have newbie question in
> its code.
> 
> I can see the if (*p_str == news) check routine two times in
> eina_stringshare_refplace()
> 
> Can I know the example which we should check second if statement.

in case of : (1 < strlen(news) < 4) and news is a char*

eina_stringshare_refplace
eina_stringshare_ref
_eina_stringshare_small_add

thus eina_stringshare_ref will return a pointer to a new stringshare
which then have to be checked against p_str.

> 
> Best Regards,
> Ryuan Choi
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/elementary] master 02/02: fix wrong usage of EINA_FALSE as NULL

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=76ba46b2f952b4f087bcc90b4d574297f4bbef1f

commit 76ba46b2f952b4f087bcc90b4d574297f4bbef1f
Author: Jérémy Zurcher 
Date:   Fri Aug 22 10:20:57 2014 +0200

fix wrong usage of EINA_FALSE as NULL
---
 src/lib/elm_atspi_bridge.c  | 2 +-
 src/lib/elm_entry.c | 4 ++--
 src/lib/elm_interface_atspi_widget_action.c | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/lib/elm_atspi_bridge.c b/src/lib/elm_atspi_bridge.c
index e83757c..9594414 100644
--- a/src/lib/elm_atspi_bridge.c
+++ b/src/lib/elm_atspi_bridge.c
@@ -1867,7 +1867,7 @@ _value_properties_set(const Eldbus_Service_Interface 
*interface, const char *pro
const char *obj_path = eldbus_service_object_path_get(interface);
Eo *obj = _access_object_from_path(obj_path);
 
-   EINA_SAFETY_ON_NULL_RETURN_VAL(obj, EINA_FALSE);
+   EINA_SAFETY_ON_NULL_RETURN_VAL(obj, NULL);
 
if (!eldbus_message_iter_arguments_get(iter, "d", &value))
  {
diff --git a/src/lib/elm_entry.c b/src/lib/elm_entry.c
index f0df346..b772e52 100644
--- a/src/lib/elm_entry.c
+++ b/src/lib/elm_entry.c
@@ -5430,7 +5430,7 @@ _elm_entry_elm_interface_atspi_text_attributes_get(Eo 
*obj, Elm_Entry_Data *_pd
evas_textblock_cursor_free(cur1);
evas_textblock_cursor_free(cur2);
 
-   if (!formats) return EINA_FALSE;
+   if (!formats) return NULL;
 
EINA_LIST_FOREACH(formats, l , format)
  {
@@ -5454,7 +5454,7 @@ 
_elm_entry_elm_interface_atspi_text_default_attributes_get(Eo *obj EINA_UNUSED,
if (!txtblk) return NULL;
 
format = evas_textblock_node_format_first_get(txtblk);
-   if (!format) return EINA_FALSE;
+   if (!format) return NULL;
 
do
  {
diff --git a/src/lib/elm_interface_atspi_widget_action.c 
b/src/lib/elm_interface_atspi_widget_action.c
index 489ad81..8ab5e06 100644
--- a/src/lib/elm_interface_atspi_widget_action.c
+++ b/src/lib/elm_interface_atspi_widget_action.c
@@ -103,7 +103,7 @@ 
_elm_interface_atspi_widget_action_elm_interface_atspi_action_name_get(Eo *obj,
int tmp = 0;
 
eo_do(obj, actions = elm_interface_atspi_widget_action_elm_actions_get());
-   if (!actions) return EINA_FALSE;
+   if (!actions) return NULL;
 
while (actions[tmp].name)
  {

-- 

[EGIT] [core/elementary] master 01/02: Elm_App: protect against type redefinition

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=23dac2c86fd78d37d5057856e905922482875571

commit 23dac2c86fd78d37d5057856e905922482875571
Author: Jérémy Zurcher 
Date:   Fri Aug 22 10:20:22 2014 +0200

Elm_App: protect against type redefinition
---
 src/lib/elm_app_client_eo.h | 3 +++
 src/lib/elm_app_server_eo.h | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/src/lib/elm_app_client_eo.h b/src/lib/elm_app_client_eo.h
index 2163263..dac06cd 100644
--- a/src/lib/elm_app_client_eo.h
+++ b/src/lib/elm_app_client_eo.h
@@ -1,5 +1,8 @@
 typedef Eo Elm_App_Client;
+#define _ELM_APP_CLIENT_EO_CLASS_TYPE
+
 typedef Eo Elm_App_Client_View;
+#define _ELM_APP_CLIENT_VIEW_EO_CLASS_TYPE
 
 typedef Eldbus_Pending Elm_App_Client_Pending;
 
diff --git a/src/lib/elm_app_server_eo.h b/src/lib/elm_app_server_eo.h
index 1d02213..306535d 100644
--- a/src/lib/elm_app_server_eo.h
+++ b/src/lib/elm_app_server_eo.h
@@ -5,7 +5,10 @@
 #define ELM_APP_SERVER_VIEW_CREATE_DUPLICATE 
"org.enlightenment.Application.ViewDuplicate"
 
 typedef Eo Elm_App_Server;
+#define _ELM_APP_SERVER_EO_CLASS_TYPE
+
 typedef Eo Elm_App_Server_View;
+#define _ELM_APP_SERVER_VIEW_EO_CLASS_TYPE
 
 typedef Elm_App_Server_View *(*Elm_App_Server_Create_View_Cb)(Elm_App_Server 
*app, const Eina_Value *args, Eina_Stringshare **error_name, Eina_Stringshare 
**error_message);
 

-- 

[EGIT] [core/efl] master 01/01: Eo: add missing field initializer

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=ef91422e90313f546fcdf3c491f8beba1d854aef

commit ef91422e90313f546fcdf3c491f8beba1d854aef
Author: Jérémy Zurcher 
Date:   Fri Aug 22 10:09:58 2014 +0200

Eo: add missing field initializer
---
 src/lib/eo/Eo.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/eo/Eo.h b/src/lib/eo/Eo.h
index eaf673e..30ae45e 100644
--- a/src/lib/eo/Eo.h
+++ b/src/lib/eo/Eo.h
@@ -1056,7 +1056,7 @@ struct _Eo_Callback_Array_Item
   { \
  static Eo_Callback_Array_Item internal[sizeof ((Eo_Callback_Array_Item[]) 
{ __VA_ARGS__ }) / \
 sizeof (Eo_Callback_Array_Item) + \
-1] = { { 0 } }; \
+1] = { { 0, 0 } };  \
  if (internal[0].desc == NULL)  \
{\
   memcpy(internal,  \

-- 

[EGIT] [core/efl] master 01/02: Ecore_Common: protect against Ecore_Exe redefinition

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=4cbdd93b1392f4d0b0ce882e6908254b264c1080

commit 4cbdd93b1392f4d0b0ce882e6908254b264c1080
Author: Jérémy Zurcher 
Date:   Fri Aug 22 09:20:32 2014 +0200

Ecore_Common: protect against Ecore_Exe redefinition
---
 src/lib/ecore/Ecore_Common.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/lib/ecore/Ecore_Common.h b/src/lib/ecore/Ecore_Common.h
index c9b9f9a..6dbb555 100644
--- a/src/lib/ecore/Ecore_Common.h
+++ b/src/lib/ecore/Ecore_Common.h
@@ -893,6 +893,8 @@ typedef enum _Ecore_Exe_Win32_Priority 
Ecore_Exe_Win32_Priority;
 
 typedef Eo  Ecore_Exe; /**< A handle for spawned processes */
 
+#define _ECORE_EXE_EO_CLASS_TYPE
+
 /**
  * @typedef Ecore_Exe_Cb Ecore_Exe_Cb
  * A callback to run with the associated @ref Ecore_Exe, usually

-- 

[EGIT] [core/efl] master 02/02: Eolian: fix typo

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=68020daf1921a8b302442b1fea01e61a9370032e

commit 68020daf1921a8b302442b1fea01e61a9370032e
Author: Jérémy Zurcher 
Date:   Fri Aug 22 09:20:53 2014 +0200

Eolian: fix typo
---
 src/lib/eolian/eo_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/eolian/eo_parser.c b/src/lib/eolian/eo_parser.c
index 60a43c0..1931620 100644
--- a/src/lib/eolian/eo_parser.c
+++ b/src/lib/eolian/eo_parser.c
@@ -361,7 +361,7 @@ parse_expr_simple(Eo_Lexer *ls)
 expr->base.file = eina_stringshare_ref(ls->filename);
 expr->base.line = line;
 expr->base.column = col;
-expr->binop = unop;
+expr->unop = unop;
 expr->type = EOLIAN_EXPR_UNARY;
 expr->expr = exp;
 return expr;

-- 

[E-devel] [EGIT] [core/efl] master 01/01: build/drm: Fix broken build from scratch and add missing library dependency for evas_drm engine

[Jérémy Zurcher]

I was just about to propose another patch
which fixes the lib_LTLIBRARIES order as evas depends on ecore_drm :


diff --git a/src/Makefile.am b/src/Makefile.am
index 604ee4c..ac84447 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -47,11 +47,11 @@ include Makefile_Efreet.am
 include Makefile_Eeze.am
 
 if BUILD_GUI
+include Makefile_Ecore_Drm.am
 include Makefile_Evas.am
 include Makefile_Ecore_Input.am
 include Makefile_Ecore_Input_Evas.am
 include Makefile_Ecore_Cocoa.am
-include Makefile_Ecore_Drm.am
 include Makefile_Ecore_FB.am
 include Makefile_Ecore_Psl1ght.am
 include Makefile_Ecore_SDL.am



--
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [editors/vim-configs] master 20/20: Eo: Stop highlighting class names.

[Jérémy Zurcher]

Yeay for all of them !!

On Thursday 31 July 2014  01:09, Tom Hacohen wrote :
> tasn pushed a commit to branch master.
> 
> http://git.enlightenment.org/editors/vim-configs.git/commit/?id=d5489a857eea547c5d5e68c061b3a401e1cadfc3
> 
> commit d5489a857eea547c5d5e68c061b3a401e1cadfc3
> Author: Tom Hacohen 
> Date:   Thu Jul 31 08:51:01 2014 +0100
> 
> Eo: Stop highlighting class names.
> ---
>  syntax/eo.vim | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/syntax/eo.vim b/syntax/eo.vim
> index 45e482b..07b2eb2 100644
> --- a/syntax/eo.vim
> +++ b/syntax/eo.vim
> @@ -21,7 +21,7 @@ syn keywordeoTypeClass const own contained
>  syn keywordfunctionKeywords constructor destructor finalize virtual 
> legacy func
>  syn keywordeoStatements return
>  
> -syn match  className   "\(\w\+\.\)\+\w\+"
> +" syn match  className   "\(\w\+\.\)\+\w\+"
>  
>  syn match  attributes  
> "@\(inout\|out\|in\|class\|constructor\|extern\|protected\|const\|nonull\|warn_unused\|private\)"
>  
> 
> -- 
> 
> 
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [editors/vim-configs] master 01/01: slightly improve eo syntax file

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/editors/vim-configs.git/commit/?id=a47fed45d7d2cd7ef9a6d8955927833347542382

commit a47fed45d7d2cd7ef9a6d8955927833347542382
Author: Jérémy Zurcher 
Date:   Tue Jul 29 16:52:17 2014 +0200

slightly improve eo syntax file
---
 syntax/eo.vim | 15 +--
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/syntax/eo.vim b/syntax/eo.vim
index 8e9c68d..717fb2e 100644
--- a/syntax/eo.vim
+++ b/syntax/eo.vim
@@ -1,17 +1,19 @@
 " Vim syntax file
-" Language:Eo
-" Maintainer:  Daniel Zaoui
-" Last Change: 2014 06 01
+" Language: Eo
+" Maintainer:   Daniel Zaoui
+" Last Change:  2014 06 01
 
 " A bunch of useful keywords
-syn keywordclassKeywords  class legacy_prefix eo_prefix data 
contained
-syn keywordclassKeywords  constructors properties methods 
implements events contained
+syn keywordclassKeywords   class abstract legacy_prefix eo_prefix 
data contained
+syn keywordclassKeywords   constructors properties methods 
implements events contained
 
-syn keywordfunctionKeywordsset get keys values params constructor 
const contained
+syn keywordfunctionKeywordsset get keys values params constructor 
destructor finalize const contained return
 
 syn match  classKeywordsMatch  "\w\+" 
contains=classKeywords,functionKeywords
 syn match  className   "(\w\+::)*\w"
 
+syn match  attributes  "@\(inout\|out\|in\|class\)"
+
 syn region eo_comment start="\/\*" end="\*\/"
 
 " Define the default highlighting.
@@ -26,6 +28,7 @@ if version >= 508
 
   HiLink classKeywords Function
   HiLink functionKeywords Label
+  HiLink attributes Constant
   HiLink eo_comment Comment
 
   delcommand HiLink

-- 

[EGIT] [core/enlightenment] master 01/01: add dbus method org.enlightenment.wm.Core.Version

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=4ba2359ce983ca0ccacd506d5b634aac25a1b116

commit 4ba2359ce983ca0ccacd506d5b634aac25a1b116
Author: Jérémy Zurcher 
Date:   Tue Jul 29 10:26:14 2014 +0200

add dbus method org.enlightenment.wm.Core.Version

returns VERSION as in config.h
call: enlightenment_remote -version
---
 data/tools/enlightenment_remote | 11 +++
 src/bin/e_msgbus.c  | 13 +
 2 files changed, 24 insertions(+)

diff --git a/data/tools/enlightenment_remote b/data/tools/enlightenment_remote
index 45295bb..ae0f390 100644
--- a/data/tools/enlightenment_remote
+++ b/data/tools/enlightenment_remote
@@ -16,6 +16,7 @@ OPTIONS:
   --h This help
   --help-new Info about this tool
 
+  -version Show Enlightenment Version
   -restart Restart Enlightenment
   -exit Exit Enlightenment
 
@@ -220,6 +221,13 @@ er_lock(){
 }
 
 
#---
+#   E Version
+#---
+er_version(){
+   ERGS org.enlightenment.wm.Core.Version
+}
+
+#---
 #   E Restart
 
#---
 er_restart(){
@@ -436,6 +444,9 @@ case "$1" in
--help-new)
   show_help_new_tool
;;
+   -version)
+  er_version
+   ;;
-restart)
   er_restart
;;
diff --git a/src/bin/e_msgbus.c b/src/bin/e_msgbus.c
index 1d3f4eb..aaa54fb 100644
--- a/src/bin/e_msgbus.c
+++ b/src/bin/e_msgbus.c
@@ -4,6 +4,8 @@
 static void   _e_msgbus_request_name_cb(void *data, const 
Eldbus_Message *msg,
 Eldbus_Pending *pending);
 
+static Eldbus_Message *_e_msgbus_core_version_cb(const 
Eldbus_Service_Interface *iface,
+const Eldbus_Message *msg);
 static Eldbus_Message *_e_msgbus_core_restart_cb(const 
Eldbus_Service_Interface *iface,
 const Eldbus_Message *msg);
 static Eldbus_Message *_e_msgbus_core_shutdown_cb(const 
Eldbus_Service_Interface *iface,
@@ -48,6 +50,7 @@ E_MSGBUS_WIN_ACTION_CB_PROTO(unmaximize);
 static E_Msgbus_Data *_e_msgbus_data = NULL;
 
 static const Eldbus_Method core_methods[] = {
+   { "Version", NULL, ELDBUS_ARGS({"s", "version"}), _e_msgbus_core_version_cb 
},
{ "Restart", NULL, NULL, _e_msgbus_core_restart_cb },
{ "Shutdown", NULL, NULL, _e_msgbus_core_shutdown_cb },
{ }
@@ -183,6 +186,16 @@ _e_msgbus_request_name_cb(void *data __UNUSED__, const 
Eldbus_Message *msg,
 
 /* Core Handlers */
 static Eldbus_Message *
+_e_msgbus_core_version_cb(const Eldbus_Service_Interface *iface __UNUSED__,
+  const Eldbus_Message *msg)
+{
+   Eldbus_Message *reply = eldbus_message_method_return_new(msg);
+   EINA_SAFETY_ON_NULL_RETURN_VAL(reply, NULL);
+   eldbus_message_arguments_append(reply, "s", VERSION);
+   return reply;
+}
+
+static Eldbus_Message *
 _e_msgbus_core_restart_cb(const Eldbus_Service_Interface *iface __UNUSED__,
   const Eldbus_Message *msg)
 {

-- 

[EGIT] [core/enlightenment] master 01/01: e18.service -> enlightenment.service : Part II

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=28ac706fb0a61adeefa56db22046a3145b11f8da

commit 28ac706fb0a61adeefa56db22046a3145b11f8da
Author: Jérémy Zurcher 
Date:   Tue Jul 29 10:15:17 2014 +0200

e18.service -> enlightenment.service : Part II
---
 .gitignore | 2 +-
 data/units/Makefile.mk | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.gitignore b/.gitignore
index e881572..8277b1c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -43,6 +43,6 @@ default.edj
 /missing
 /mkinstalldirs
 /stamp-h1
-/data/units/e18.service
+/data/units/enlightenment.service
 *.eo.c
 *.eo.h
diff --git a/data/units/Makefile.mk b/data/units/Makefile.mk
index 4387289..58c76bc 100644
--- a/data/units/Makefile.mk
+++ b/data/units/Makefile.mk
@@ -1,6 +1,6 @@
 if HAVE_SYSTEMD_USER_SESSION
 unitsdir = $(USER_SESSION_DIR)
-units_DATA = data/units/e18.service
+units_DATA = data/units/enlightenment.service
 endif
 
 EXTRA_DIST += $(units_DATA)

-- 

[E-devel] calls to eo_do(NULL, ...)

[Jérémy Zurcher]

original thread is: [e-users] Func 'edje_obj_signal_emit' unknown in class 
'Evas_Smart'

On Tuesday 08 July 2014  20:18, Carsten Haitzler wrote :
> On Tue, 8 Jul 2014 10:32:24 +0200 Jérémy Zurcher  said:
> > 
> > shouldn't we even add WRN() to eo_do(NULL, ... ) calls ??
> > loads of them in elm because of NULL wd->resize_obj.
> 
> nah - it's one thing calling an unsupported method on an object - you intended
> for the obj to do X or Y. for a null object - no object, there simply is
> nothing to do. it's barely an issue. i'd say its not valuable to say anything.
> 

there is nothing to do, but we do a lot,
set an eo call stack frame with NULL in it,
go through all function calls, returning default value at _eo_call_resolve()
free the call stack frame.

a side effect of the will to be able to write: a = eo_do(obj, a_get());
http://git.enlightenment.org/core/efl.git/commit/?id=d77a7ce4


--
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 01/01: Revert "ecore: animator use eo_add() instead of eo_add_custom()"

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=a7dfaef21522ef239ed802eae125d655f537c757

commit a7dfaef21522ef239ed802eae125d655f537c757
Author: Jérémy Zurcher 
Date:   Thu Jul 3 23:05:57 2014 +0200

Revert "ecore: animator use eo_add() instead of eo_add_custom()"

mmhhmm, missing @ Constructor tag, bad for the bindings,
maybe we must split animator and timeline into 2 classes,
maybe support callback hot swaping ...

This reverts commit ec4ffb86d6bc9a3d4e4e81b80359abd7bbdb8f22.
---
 src/lib/ecore/ecore_anim.c| 84 ---
 src/lib/ecore/ecore_animator.eo   | 64 +-
 src/tests/ecore/ecore_test_animator.c |  7 +--
 3 files changed, 52 insertions(+), 103 deletions(-)

diff --git a/src/lib/ecore/ecore_anim.c b/src/lib/ecore/ecore_anim.c
index 0ff0169..892359f 100644
--- a/src/lib/ecore/ecore_anim.c
+++ b/src/lib/ecore/ecore_anim.c
@@ -154,35 +154,42 @@ _do_tick(void)
return ECORE_CALLBACK_RENEW;
 }
 
-EOLIAN static Eo *
-_ecore_animator_eo_base_finalize(Eo *obj, Ecore_Animator_Data *animator)
+static Eina_Bool
+_ecore_animator_add(Ecore_Animator *obj,
+Ecore_Animator_Data *animator,
+Ecore_Task_Cb func,
+const void   *data)
 {
-   if (!animator->func)
- {
-eo_error_set(obj);
-ERR("callback function must be set up for an object of class: '%s'", 
MY_CLASS_NAME);
-goto finalize;
- }
+if (EINA_UNLIKELY(!eina_main_loop_is()))
+  {
+ eo_error_set(obj);
+ EINA_MAIN_LOOP_CHECK_RETURN_VAL(EINA_FALSE);
+  }
+
+   animator->obj = obj;
+   eo_do_super(obj, MY_CLASS, eo_constructor());
+   eo_manual_free_set(obj, EINA_TRUE);
 
-   if (EINA_UNLIKELY(!eina_main_loop_is()))
+   if (!func)
  {
 eo_error_set(obj);
-EINA_MAIN_LOOP_CHECK_RETURN_VAL(
-   eo_do_super(obj, MY_CLASS, eo_finalize()));
-goto finalize;
+ERR("callback function must be set up for an object of class: '%s'", 
MY_CLASS_NAME);
+return EINA_FALSE;
  }
 
-   _ecore_lock();
-
-   eo_manual_free_set(obj, EINA_TRUE);
+   animator->func = func;
+   animator->data = (void *)data;
animator->just_added = EINA_TRUE;
animators = (Ecore_Animator_Data 
*)eina_inlist_append(EINA_INLIST_GET(animators), EINA_INLIST_GET(animator));
-
_begin_tick();
-   _ecore_unlock();
+   return EINA_TRUE;
+}
 
-finalize:
-   return eo_do_super(obj, MY_CLASS, eo_finalize());
+EOLIAN static void
+_ecore_animator_eo_base_constructor(Eo *obj, Ecore_Animator_Data *_pd 
EINA_UNUSED)
+{
+   eo_error_set(obj);
+   ERR("only custom constructor can be used with '%s' class", MY_CLASS_NAME);
 }
 
 EAPI Ecore_Animator *
@@ -191,27 +198,17 @@ ecore_animator_add(Ecore_Task_Cb func,
 {
Ecore_Animator *animator = NULL;
 
-   animator = eo_add(MY_CLASS, _ecore_parent,
- ecore_obj_animator_init(func, data));
+   animator = eo_add_custom(MY_CLASS, _ecore_parent,
+ecore_animator_constructor(func, data));
eo_unref(animator);
return animator;
 }
 
 EOLIAN static void
-_ecore_animator_init(Eo *obj, Ecore_Animator_Data *animator, Ecore_Task_Cb 
func, const void *data)
+_ecore_animator_constructor(Eo *obj, Ecore_Animator_Data *animator, 
Ecore_Task_Cb func, const void *data)
 {
-   if (animator->func != NULL)
- {
-ERR("do not call this function out of '%s' object construction", 
MY_CLASS_NAME);
-return;
- }
-
_ecore_lock();
-
-   animator->obj = obj;
-   animator->func = func;
-   animator->data = (void *)data;
-
+   _ecore_animator_add(obj, animator, func, data);
_ecore_unlock();
 }
 
@@ -221,32 +218,27 @@ ecore_animator_timeline_add(doubleruntime,
 const void   *data)
 {
Ecore_Animator *animator;
-   animator = eo_add(MY_CLASS, _ecore_parent,
- ecore_obj_animator_timeline_init(runtime, func, data));
+   animator = eo_add_custom(MY_CLASS, _ecore_parent,
+ecore_animator_timeline_constructor(runtime, func, 
data));
eo_unref(animator);
return animator;
 }
 
 EOLIAN static void
-_ecore_animator_timeline_init(Eo *obj, Ecore_Animator_Data *animator, double 
runtime, Ecore_Timeline_Cb func, const void *data)
+_ecore_animator_timeline_constructor(Eo *obj, Ecore_Animator_Data *animator, 
double runtime, Ecore_Timeline_Cb func, const void *data)
 {
-   if (animator->func != NULL)
- {
-ERR("do not call this function out of '%s' object construction", 
MY_CLASS_NAME);
-return;
- }
-   if (runtime < 0.0) runtime = 0.0;
-
_ecore_lock();
+   if (runtime <= 0.0) runtime = 0.0;
+
+   if (!_ecore_animator_add(obj, animator, _ecore_animat

[EGIT] [core/efl] master 01/01: ecore: animator use eo_add() instead of eo_add_custom()

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=ec4ffb86d6bc9a3d4e4e81b80359abd7bbdb8f22

commit ec4ffb86d6bc9a3d4e4e81b80359abd7bbdb8f22
Author: Jérémy Zurcher 
Date:   Thu Jul 3 22:33:15 2014 +0200

ecore: animator use eo_add() instead of eo_add_custom()

Summary:
- use defauld constructor instead of custom one.
- we don't allow construction of an animator with a NULL callback function,
  this is checked in overriden eo_finalize.
- we don't support changing this callback once the object is created,
  such calls will call ERR() and return.

see 46a78e8c and f92e5d50 for eo_add_custom() -> eo_add() details

Reviewers: tasn

Reviewed By: tasn

CC: cedric

Differential Revision: https://phab.enlightenment.org/D1113
---
 src/lib/ecore/ecore_anim.c| 84 +++
 src/lib/ecore/ecore_animator.eo   | 64 +-
 src/tests/ecore/ecore_test_animator.c |  7 ++-
 3 files changed, 103 insertions(+), 52 deletions(-)

diff --git a/src/lib/ecore/ecore_anim.c b/src/lib/ecore/ecore_anim.c
index 892359f..0ff0169 100644
--- a/src/lib/ecore/ecore_anim.c
+++ b/src/lib/ecore/ecore_anim.c
@@ -154,42 +154,35 @@ _do_tick(void)
return ECORE_CALLBACK_RENEW;
 }
 
-static Eina_Bool
-_ecore_animator_add(Ecore_Animator *obj,
-Ecore_Animator_Data *animator,
-Ecore_Task_Cb func,
-const void   *data)
+EOLIAN static Eo *
+_ecore_animator_eo_base_finalize(Eo *obj, Ecore_Animator_Data *animator)
 {
-if (EINA_UNLIKELY(!eina_main_loop_is()))
-  {
- eo_error_set(obj);
- EINA_MAIN_LOOP_CHECK_RETURN_VAL(EINA_FALSE);
-  }
-
-   animator->obj = obj;
-   eo_do_super(obj, MY_CLASS, eo_constructor());
-   eo_manual_free_set(obj, EINA_TRUE);
-
-   if (!func)
+   if (!animator->func)
  {
 eo_error_set(obj);
 ERR("callback function must be set up for an object of class: '%s'", 
MY_CLASS_NAME);
-return EINA_FALSE;
+goto finalize;
  }
 
-   animator->func = func;
-   animator->data = (void *)data;
+   if (EINA_UNLIKELY(!eina_main_loop_is()))
+ {
+eo_error_set(obj);
+EINA_MAIN_LOOP_CHECK_RETURN_VAL(
+   eo_do_super(obj, MY_CLASS, eo_finalize()));
+goto finalize;
+ }
+
+   _ecore_lock();
+
+   eo_manual_free_set(obj, EINA_TRUE);
animator->just_added = EINA_TRUE;
animators = (Ecore_Animator_Data 
*)eina_inlist_append(EINA_INLIST_GET(animators), EINA_INLIST_GET(animator));
+
_begin_tick();
-   return EINA_TRUE;
-}
+   _ecore_unlock();
 
-EOLIAN static void
-_ecore_animator_eo_base_constructor(Eo *obj, Ecore_Animator_Data *_pd 
EINA_UNUSED)
-{
-   eo_error_set(obj);
-   ERR("only custom constructor can be used with '%s' class", MY_CLASS_NAME);
+finalize:
+   return eo_do_super(obj, MY_CLASS, eo_finalize());
 }
 
 EAPI Ecore_Animator *
@@ -198,17 +191,27 @@ ecore_animator_add(Ecore_Task_Cb func,
 {
Ecore_Animator *animator = NULL;
 
-   animator = eo_add_custom(MY_CLASS, _ecore_parent,
-ecore_animator_constructor(func, data));
+   animator = eo_add(MY_CLASS, _ecore_parent,
+ ecore_obj_animator_init(func, data));
eo_unref(animator);
return animator;
 }
 
 EOLIAN static void
-_ecore_animator_constructor(Eo *obj, Ecore_Animator_Data *animator, 
Ecore_Task_Cb func, const void *data)
+_ecore_animator_init(Eo *obj, Ecore_Animator_Data *animator, Ecore_Task_Cb 
func, const void *data)
 {
+   if (animator->func != NULL)
+ {
+ERR("do not call this function out of '%s' object construction", 
MY_CLASS_NAME);
+return;
+ }
+
_ecore_lock();
-   _ecore_animator_add(obj, animator, func, data);
+
+   animator->obj = obj;
+   animator->func = func;
+   animator->data = (void *)data;
+
_ecore_unlock();
 }
 
@@ -218,27 +221,32 @@ ecore_animator_timeline_add(doubleruntime,
 const void   *data)
 {
Ecore_Animator *animator;
-   animator = eo_add_custom(MY_CLASS, _ecore_parent,
-ecore_animator_timeline_constructor(runtime, func, 
data));
+   animator = eo_add(MY_CLASS, _ecore_parent,
+ ecore_obj_animator_timeline_init(runtime, func, data));
eo_unref(animator);
return animator;
 }
 
 EOLIAN static void
-_ecore_animator_timeline_constructor(Eo *obj, Ecore_Animator_Data *animator, 
double runtime, Ecore_Timeline_Cb func, const void *data)
+_ecore_animator_timeline_init(Eo *obj, Ecore_Animator_Data *animator, double 
runtime, Ecore_Timeline_Cb func, const void *data)
 {
-   _ecore_lock();
-   if (runtime <= 0.0) runtime = 0.0;
+   if (animator->func != NULL)
+ {
+ERR("do not call this function out of 

[EGIT] [core/efl] master 01/01: eo: constructor tests do not use eo_add_custom(..)

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=46a78e8c9d46225f3cd3d6b3c6eca3ab7361f361

commit 46a78e8c9d46225f3cd3d6b3c6eca3ab7361f361
Author: Jérémy Zurcher 
Date:   Thu Jul 3 10:41:53 2014 +0200

eo: constructor tests do not use eo_add_custom(..)

as stated in f92e5d50, instead of using eo_add_custom() thus a custom
constructor and maybe overriding the default constructor to block it,

   - use the default constructor to build the object
   - add calls to eo_add(), to initialize the object
 eo_add(class, parent, val_a_set(1), val_b_set(2), ... );
   - override eo_finalize to validate the object and if needed,
 use eo_error_set(obj) to abort object construction
---
 src/tests/eo/constructors/constructors_main.c   | 17 +++--
 src/tests/eo/constructors/constructors_simple.c | 19 ---
 src/tests/eo/constructors/constructors_simple.h |  1 -
 3 files changed, 23 insertions(+), 14 deletions(-)

diff --git a/src/tests/eo/constructors/constructors_main.c 
b/src/tests/eo/constructors/constructors_main.c
index 7b7da02..cab5e7f 100644
--- a/src/tests/eo/constructors/constructors_main.c
+++ b/src/tests/eo/constructors/constructors_main.c
@@ -66,13 +66,26 @@ main(int argc, char *argv[])
fail_if(obj);
 
my_init_count = 0;
-   obj = eo_add_custom(SIMPLE_CLASS, NULL, simple_constructor(7));
+   obj = eo_add(SIMPLE_CLASS, NULL);
fail_if(!obj);
-
fail_if(my_init_count != 2);
eo_do(obj, a = simple_a_get());
+   fail_if(a != 0);
+
+   my_init_count = 0;
+   obj = eo_add(SIMPLE_CLASS, NULL, simple_a_set(7));
+   fail_if(!obj);
+   fail_if(my_init_count != 2);
+   eo_do(obj, a = simple_a_get(););
fail_if(a != 7);
 
+   my_init_count = 0;
+   obj = eo_add(SIMPLE_CLASS, NULL, simple_b_set(6), simple_a_set(-1),
+b = simple_b_get());
+   fail_if(obj);
+   fail_if(b != 6);
+   fail_if(my_init_count != 0);
+
eo_unref(obj);
 
eo_shutdown();
diff --git a/src/tests/eo/constructors/constructors_simple.c 
b/src/tests/eo/constructors/constructors_simple.c
index fa6b3fd..9a25e2b 100644
--- a/src/tests/eo/constructors/constructors_simple.c
+++ b/src/tests/eo/constructors/constructors_simple.c
@@ -40,24 +40,21 @@ _GET_SET_FUNC(b)
 extern int my_init_count;
 
 static void
-_simple_constructor(Eo *obj, void *class_data, int a)
+_constructor(Eo *obj, void *class_data EINA_UNUSED)
 {
-   Private_Data *pd = class_data;
-
eo_do_super(obj, MY_CLASS, eo_constructor());
 
-   pd->a = a;
-   printf("%s %d\n", __func__, pd->a);
-
my_init_count++;
 }
 
-static void
-_constructor(Eo *obj, void *class_data EINA_UNUSED)
+static Eo*
+_finalize(Eo *obj, void *class_data EINA_UNUSED)
 {
-   eo_do_super(obj, MY_CLASS, eo_constructor());
+   Private_Data *pd = class_data;
 
-   my_init_count++;
+   if (pd->a < 0) eo_error_set(obj);
+
+   return eo_do_super(obj, MY_CLASS, eo_finalize());
 }
 
 static void
@@ -85,7 +82,7 @@ EO_VOID_FUNC_BODYV(simple_constructor, EO_FUNC_CALL(a), int 
a);
 static Eo_Op_Description op_descs[] = {
  EO_OP_FUNC_OVERRIDE(eo_constructor, _constructor),
  EO_OP_FUNC_OVERRIDE(eo_destructor, _destructor),
- EO_OP_FUNC(simple_constructor, _simple_constructor, "Construct and set 
A."),
+ EO_OP_FUNC_OVERRIDE(eo_finalize, _finalize),
  EO_OP_FUNC(simple_a_set, _a_set, "Set property a"),
  EO_OP_FUNC(simple_a_get, _a_get, "Get property a"),
  EO_OP_FUNC(simple_b_set, _b_set, "Set property b"),
diff --git a/src/tests/eo/constructors/constructors_simple.h 
b/src/tests/eo/constructors/constructors_simple.h
index d8ab0e9..c4b3d7b 100644
--- a/src/tests/eo/constructors/constructors_simple.h
+++ b/src/tests/eo/constructors/constructors_simple.h
@@ -1,7 +1,6 @@
 #ifndef SIMPLE_H
 #define SIMPLE_H
 
-EAPI void simple_constructor(int a);
 EAPI void simple_a_set(int a);
 EAPI int simple_a_get(void);
 EAPI void simple_b_set(int b);

-- 

Re: [E-devel] [EGIT] [core/efl] master 01/03: lz4: fix possible security issue.

[Jérémy Zurcher]

> > 
> > if there was a liblz4... we'd be using it... :)
> > 
> 
> There actually is a liblz4, which seems to be usable and actively
> maintained, however, I'm not clear on the status of distros shipping it.
> 
> Gentoo does provide this package:
> [I] app-arch/lz4
>  Available versions:  0_p106-r1 **
>  Homepage:https://code.google.com/p/lz4/
>  Description: Extremely Fast Compression algorithm

archlinux r118  -  Sat 28 Jun 2014
debian jessie  r117
ubuntu r114 ?

> 
> It installs with the following files:
> /usr/bin/lz4c64
> /usr/bin/lz4c
> /usr/lib64/liblz4.so.0.0
> /usr/lib64/liblz4.so
> /usr/lib64/liblz4.a
> /usr/include/lz4.h
> /usr/include/lz4hc.h
> 

--
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 01/02: fix memory leak in Eina_Strbuf usage

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=70092ae92eb6fbd8ac4c04d5f0a8f2beb083eff4

commit 70092ae92eb6fbd8ac4c04d5f0a8f2beb083eff4
Author: Jérémy Zurcher 
Date:   Thu Jun 5 23:28:25 2014 +0200

fix memory leak in Eina_Strbuf usage

buf wasn't freed on success neighter on
edje_edit_image_compression_type_get(...) failure

CID 1194716
---
 src/lib/edje/edje_edit.c | 33 ++---
 1 file changed, 18 insertions(+), 15 deletions(-)

diff --git a/src/lib/edje/edje_edit.c b/src/lib/edje/edje_edit.c
index e13ff6f..9d56976 100644
--- a/src/lib/edje/edje_edit.c
+++ b/src/lib/edje/edje_edit.c
@@ -7488,7 +7488,7 @@ _edje_generate_source_of_style(Edje * ed, const char 
*name, Eina_Strbuf *buf);
  static Eina_Bool
 _edje_generate_source_of_colorclass(Edje * ed, const char *name, Eina_Strbuf 
*buf);
 
-static const char *
+static Eina_Strbuf *
 _edje_generate_image_source(Evas_Object *obj, const char *entry)
 {
Eina_Strbuf *buf = eina_strbuf_new();
@@ -7496,7 +7496,7 @@ _edje_generate_image_source(Evas_Object *obj, const char 
*entry)
if (!buf) return NULL;
 
int comp = edje_edit_image_compression_type_get(obj, entry);
-   if (comp < 0) return NULL;
+   if (comp < 0) goto error;
 
BUF_APPENDF("image: \"%s\" ", entry);
 
@@ -7513,14 +7513,14 @@ _edje_generate_image_source(Evas_Object *obj, const 
char *entry)
else
  BUF_APPEND("COMP;\n");
 
-   if (!ret)
- {
-ERR("Generating EDC for Image");
-eina_strbuf_free(buf);
-return NULL;
- }
+   if (!ret) goto error;
 
-   return eina_strbuf_string_get(buf);
+   return buf;
+
+error:
+   ERR("Generating EDC for Image");
+   eina_strbuf_free(buf);
+   return NULL;
 }
 
 
@@ -7609,9 +7609,11 @@ edje_edit_source_generate(Evas_Object *obj)
 
 EINA_LIST_FOREACH(images, l, entry)
   {
- const char *image_source = _edje_generate_image_source(obj, 
entry);
- if (!image_source) continue;
- BUF_APPENDF(I1"%s", image_source);
+ Eina_Strbuf *buf = _edje_generate_image_source(obj, entry);
+ if (!buf) continue;
+
+ BUF_APPENDF(I1"%s", eina_strbuf_string_get(buf));
+ eina_strbuf_free(buf);
   }
 
 BUF_APPEND(I0"}\n\n");
@@ -8473,10 +8475,11 @@ _edje_generate_source(Evas_Object *obj)
 
EINA_LIST_FOREACH(ll, l, entry)
  {
- const char *image_source = _edje_generate_image_source(obj, 
entry);
-if (!image_source) continue;
+ Eina_Strbuf *buf = _edje_generate_image_source(obj, entry);
+if (!buf) continue;
 
- BUF_APPENDF(I1"%s", image_source);
+ BUF_APPENDF(I1"%s", eina_strbuf_string_get(buf));
+ eina_strbuf_free(buf);
   }
BUF_APPEND(I0"}\n\n");
edje_edit_string_list_free(ll);

-- 

[EGIT] [core/efl] master 02/02: fix memory leak in Eina_Strbuf usage

[Jérémy Zurcher]

jeyzu pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=82b852850fa2643520eb2dc450c047b487b03c0e

commit 82b852850fa2643520eb2dc450c047b487b03c0e
Author: Jérémy Zurcher 
Date:   Fri Jun 6 00:05:06 2014 +0200

fix memory leak in Eina_Strbuf usage

buf was not freed on error, and never on success

CID 1194715
---
 src/lib/edje/Edje_Edit.h |  2 ++
 src/lib/edje/edje_edit.c | 10 --
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/lib/edje/Edje_Edit.h b/src/lib/edje/Edje_Edit.h
index 4210d77..701f5ca 100644
--- a/src/lib/edje/Edje_Edit.h
+++ b/src/lib/edje/Edje_Edit.h
@@ -4362,6 +4362,8 @@ EAPI const Eina_List 
*edje_edit_script_error_list_get(Evas_Object *obj);
 /**
  * Return source code of the current edje edit object.
  *
+ * Remember to free the string with edje_edit_string_free()
+ *
  * This function will return source code of the whole group, loaded previously.
  * This function also will collect all possible resources that is required and
  * mentioned in description blocks. For example: all images, fonts, data, 
styles,
diff --git a/src/lib/edje/edje_edit.c b/src/lib/edje/edje_edit.c
index 9d56976..9f2c73a 100644
--- a/src/lib/edje/edje_edit.c
+++ b/src/lib/edje/edje_edit.c
@@ -7534,7 +7534,8 @@ edje_edit_source_generate(Evas_Object *obj)
Edje_Part_Description_Text *part_desc_text;
unsigned int i, j;
const char *entry;
-   Eina_Strbuf *buf = eina_strbuf_new();
+   const char *str;
+   Eina_Strbuf *buf = NULL;
Eina_Bool ret = EINA_TRUE;
Eina_List *images = NULL, *color_classes = NULL, *styles = NULL, *fonts = 
NULL;
Eina_List *l;
@@ -7602,6 +7603,8 @@ edje_edit_source_generate(Evas_Object *obj)
   }
  }
 
+   buf = eina_strbuf_new();
+
/* if images were found, print them */
if (images)
  {
@@ -7659,11 +7662,14 @@ edje_edit_source_generate(Evas_Object *obj)
if (!ret)
  {
 ERR("Generating EDC for This Group.");
+eina_strbuf_free(buf);
 return NULL;
  }
 
/* return resulted source code of the group */
-   return eina_strbuf_string_get(buf);
+   str = eina_stringshare_add(eina_strbuf_string_get(buf));
+   eina_strbuf_free(buf);
+   return str;
 }
 
 #undef COLLECT_RESOURCE

-- 

Re: [E-devel] Migrating to Gitolite v3 - short Git downtime

[Jérémy Zurcher]

Hello Tom,

good news, can you take care of the adc's,
'ssh git.enlightenment.org help' advertises 'rm' and 'lock' cmds that do not 
work.

https://git.enlightenment.org/repos.txt lists repos that have been
trashed, shouldn't they be removed from this list ?

thanks

On Friday 23 May 2014  14:22, Tom Hacohen wrote :
> Hey guys,
> 
> Beber and I have started working on migrating our gitolite to v3.
> 
> Gitolite is what we use for git access control. We currently use v2, but 
> v3 has been around and recommended for a while now, and offers some 
> features we need (more fine grained access control), especially now that 
> we have probie support (they'll be able to change their info dirs on 
> their own!).
> 
> What does it mean for you?
> We'll have a short downtime (hopefully 30 minutes, might be longer if 
> issues arise) period during a Saturday/Sunday some point in the near 
> future. I'll keep you posted as to when exactly. Luckily, because git is 
> distributed, the impact is quite minimal.
> 
> Please let me know if you have any comments or concerns regarding the 
> switch.
> 
> --
> Tom.
> 
> 
> 
> --
> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
> Instantly run your Selenium tests across 300+ browser/OS combos.
> Get unparalleled scalability from the best Selenium testing platform available
> Simple to use. Nothing to install. Get started now for free."
> http://p.sf.net/sfu/SauceLabs
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--- Hell'O from Yverdoom

Jérémy (jeyzu)

--
The best possible search technologies are now affordable for all companies.
Download your FREE open source Enterprise Search Engine today!
Our experts will assist you in its installation for $59/mo, no commitment.
Test it for FREE on our Cloud platform anytime!
http://pubads.g.doubleclick.net/gampad/clk?id=145328191&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel