Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
I read through the source of rcverify before voting. Looks sufficient to cover the release checks. On Fri, Apr 26, 2019 at 18:48, Justin Mclean wrote: > Hi, > > +1 (binding) > > I checked: > - Incubating in name > - signatures and hash file fine > - DISCLAIMER exists > - LICENSE and NOTICE good > - code in release candidate matches code in version control > - No unexpected binary files > - Source files have correct header except one which has been fixed. > > Thanks, > Justin > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Matt Sicker
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
Hi, +1 (binding) I checked: - Incubating in name - signatures and hash file fine - DISCLAIMER exists - LICENSE and NOTICE good - code in release candidate matches code in version control - No unexpected binary files - Source files have correct header except one which has been fixed. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
Hi, One issue I see with the instructions script is that you are asking people to download it from head, this may make it hard to verify old releases or may give different results during the voting process if changes are made. It may be better to package the verifying script inside the release candidate. Another is from the output of the script it’s unclear where it downloaded the files or what rc it is testing, adding that may be useful. It also clones incubator-openwhisk-utilities which might be seen as misleading as should it be cloning incubator-openwhisk-composer so it can compare what’s in version control to what in the release candidate. Again this seem to be checking out head which would change over time so it might be possible for it to give inconstant results. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
Hi Dave, Thanks! I’m glad Bertrand has been a help. OpenWhisk is similar to Sling in that there are a number of repositories and release artifacts. Regards, Dave > On Apr 22, 2019, at 3:14 PM, David P Grove wrote: > > > > > On 2019/04/22 19:09:36, Dave Fisher wrote: >> Hi - >> >> I am concerned about an overly automated release process. Please explain > what the role of the Release Manager is in your process? How does the > release manager sign these automatically generated artifacts? How are > release artifacts moved from > https://dist.apache.org/repos/dist/dev/incubator/openwhisk/ to > https://dist.apache.org/repos/dist/release/incubator/openwhisk/ once the > vote is passed? Are there staged artifacts anywhere else like > repository.apache.org? Or to NPM. > > Hi Dave, > > Not sure how much detail is appropriate here. Will quickly summarize > and maybe it makes sense to move any detailed feedback you have to the > OpenWhisk dev list which is cc'ed? Our mentor Bertrand has been actively > involved in helping us refine this process. > > A Release Manager manually initiates each of the major steps in the > process. The gory details can be found at our release repo [1] and the > instructions for the release manager [2]. The basic workflow is that after > the completion of a DISCUSS thread, a Release Manager defines a config.json > that specifies the components being released (names, gitrepos, git commit > hash, version, release candidate number). This config file is then fed > into scripts that generate/sign the artifacts using the Release Manager's > key, push them to the right place in > https://dist.apache.org/repos/dist/dev/incubator/openwhisk/, and generates > an email body for a VOTE thread (this last script is brand new). After a > successful completion of the IPMC vote, the Release Manager initiates the > move from dist/dev to dist/release by running a script on their local > machine that does the svn operations. > > There are no staged artifacts during the voting process outside of > https://dist.apache.org/repos/dist/dev/incubator/openwhisk/. > >> >> BTW - The link to the commit currently leads to a 404. >> > > Noted. Bug in the still-being-worked-on script to generate the email. It > should have been outputting a URL in > https://dist.apache.org/repos/dist/dev/incubator/openwhisk/ not in github. > > --dave > > [1] https://github.com/apache/incubator-openwhisk-release > [2] > https://github.com/apache/incubator-openwhisk-release/blob/master/docs/release_instructions.md - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
We do still need one more binding +1 vote from an IMPC member to be able to close this vote and finally make this release. If someone would be willing to either use the rcverify.sh script we use in the OpenWhisk project as described below or otherwise check the artifacts at https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-0.11.0-incubating-rc2/ using whatever method you prefer and cast a binding vote it would be greatly appreciated. In his previous non-vote in this thread Justin pointed out a file with a short-form license header; it has been fixed in master (for next release). thanks, --dave On 2019/04/26 13:59:27, "David P Grove" wrote: > > > > Justin Mclean wrote on 04/25/2019 10:41:28 PM:> > >> > > Hi,> > >> > > > If that URL was missing what where people actually voting on?> > > Looking at the vote thread on the dev list it seem it was a GitHub hash??> > >> > > Can anyone answer this?> > > Per the original dev list vote email [1]> > > > You can use this UNIX script to download the release and verify the> > checklist below:> > >> > https://gitbox.apache.org/repos/asf?p=incubator-openwhisk-release.git;a=blob_plain;f=tools/rcverify.sh;hb=HEAD> > > >> > > rcverify.sh openwhisk-composer 'OpenWhisk Composer' 0.11.0-incubating rc2> > > Running the referenced script on your local machine with those arguments> > downloads the specified artifacts and produces a log of what was verified> > that is included in our individual votes as in [2].> > > --dave> > > [1]> > https://lists.apache.org/thread.html/71290ca376a3a1ef591c655dfb92ad9f355b5489ae31dc093c0c54bf@%3Cdev.openwhisk.apache.org%3E> > [2]> > https://lists.apache.org/thread.html/940bc4d86675ae4a26d514cf5f6070be86eca9d6077da47c03a1a5b4@%3Cdev.openwhisk.apache.org%3E> >
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
Justin Mclean wrote on 04/25/2019 10:41:28 PM: > > Hi, > > > If that URL was missing what where people actually voting on? > Looking at the vote thread on the dev list it seem it was a GitHub hash?? > > Can anyone answer this? Per the original dev list vote email [1] > You can use this UNIX script to download the release and verify the checklist below: > https://gitbox.apache.org/repos/asf?p=incubator-openwhisk-release.git;a=blob_plain;f=tools/rcverify.sh;hb=HEAD > > rcverify.sh openwhisk-composer 'OpenWhisk Composer' 0.11.0-incubating rc2 Running the referenced script on your local machine with those arguments downloads the specified artifacts and produces a log of what was verified that is included in our individual votes as in [2]. --dave [1] https://lists.apache.org/thread.html/71290ca376a3a1ef591c655dfb92ad9f355b5489ae31dc093c0c54bf@%3Cdev.openwhisk.apache.org%3E [2] https://lists.apache.org/thread.html/940bc4d86675ae4a26d514cf5f6070be86eca9d6077da47c03a1a5b4@%3Cdev.openwhisk.apache.org%3E
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
Hi, > If that URL was missing what where people actually voting on? Looking at the > vote thread on the dev list it seem it was a GitHub hash?? Can anyone answer this? Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
On 2019/04/22 19:09:36, Dave Fisher wrote: > Hi - > > I am concerned about an overly automated release process. Please explain what the role of the Release Manager is in your process? How does the release manager sign these automatically generated artifacts? How are release artifacts moved from https://dist.apache.org/repos/dist/dev/incubator/openwhisk/ to https://dist.apache.org/repos/dist/release/incubator/openwhisk/ once the vote is passed? Are there staged artifacts anywhere else like repository.apache.org? Or to NPM. Hi Dave, Not sure how much detail is appropriate here. Will quickly summarize and maybe it makes sense to move any detailed feedback you have to the OpenWhisk dev list which is cc'ed? Our mentor Bertrand has been actively involved in helping us refine this process. A Release Manager manually initiates each of the major steps in the process. The gory details can be found at our release repo [1] and the instructions for the release manager [2]. The basic workflow is that after the completion of a DISCUSS thread, a Release Manager defines a config.json that specifies the components being released (names, gitrepos, git commit hash, version, release candidate number). This config file is then fed into scripts that generate/sign the artifacts using the Release Manager's key, push them to the right place in https://dist.apache.org/repos/dist/dev/incubator/openwhisk/, and generates an email body for a VOTE thread (this last script is brand new). After a successful completion of the IPMC vote, the Release Manager initiates the move from dist/dev to dist/release by running a script on their local machine that does the svn operations. There are no staged artifacts during the voting process outside of https://dist.apache.org/repos/dist/dev/incubator/openwhisk/. > > BTW - The link to the commit currently leads to a 404. > Noted. Bug in the still-being-worked-on script to generate the email. It should have been outputting a URL in https://dist.apache.org/repos/dist/dev/incubator/openwhisk/ not in github. --dave [1] https://github.com/apache/incubator-openwhisk-release [2] https://github.com/apache/incubator-openwhisk-release/blob/master/docs/release_instructions.md
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
Hi, > We've been automating more of our release process (including generating the > call-to-vote email) and in had streamlined out the list of URLs from the > call-to-vote email. If that URL was missing what where people actually voting on? Looking at the vote thread on the dev list it seem it was a GitHub hash?? Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
Hi - I am concerned about an overly automated release process. Please explain what the role of the Release Manager is in your process? How does the release manager sign these automatically generated artifacts? How are release artifacts moved from https://dist.apache.org/repos/dist/dev/incubator/openwhisk/ to https://dist.apache.org/repos/dist/release/incubator/openwhisk/ once the vote is passed? Are there staged artifacts anywhere else like repository.apache.org? Or to NPM. BTW - The link to the commit currently leads to a 404. Regards, Dave > On Apr 22, 2019, at 11:53 AM, Dave Grove wrote: > > Hi, > > Yes the artifact being voted on was [1]. > > We've been automating more of our release process (including generating the > call-to-vote email) and in had streamlined out the list of URLs from the > call-to-vote email. From your feedback, it seems like that was not > appropriate. I will open an issue to put them back into the generated email. > > Thanks for voting & apologies for the delay in responding. I was completely > off-line last week on vacation. > > --dave > > On 2019/04/22 00:26:21, Justin Mclean wrote: >> Hi, >> >> Can someone please confirm this is the case and the vote was not just on the >> GitHub repo? >> >>> Assuming the artefact voted on was [1]. >>> >>> 1. >>> https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-0.11.0-incubating-rc2/ >> >> Thanks, >> Justin >> - >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
Hi, Yes the artifact being voted on was [1]. We've been automating more of our release process (including generating the call-to-vote email) and in had streamlined out the list of URLs from the call-to-vote email. From your feedback, it seems like that was not appropriate. I will open an issue to put them back into the generated email. Thanks for voting & apologies for the delay in responding. I was completely off-line last week on vacation. --dave On 2019/04/22 00:26:21, Justin Mclean wrote: > Hi, > > Can someone please confirm this is the case and the vote was not just on the > GitHub repo? > > > Assuming the artefact voted on was [1]. > > > > 1. > > https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-0.11.0-incubating-rc2/ > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
Hi, Can someone please confirm this is the case and the vote was not just on the GitHub repo? > Assuming the artefact voted on was [1]. > > 1. > https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-0.11.0-incubating-rc2/ Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
Hi,. Assuming the artefact voted on was [1]. I checked: - Incubating in name - signatures and hash file - DISCLAIMER exists - LICENSE and NOTICE good - No unexpected binary files - Source files have correct header except [2] This file [2] has an incorrect header [3], please fix for the next release. Some instruction on out to use the source code in the package rather than just doing an npm install IMO would be nice. Thanks, Justin 1. https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-0.11.0-incubating-rc2/ 2. incubator-openwhisk-composer-0.11.0-incubating/travis/scancode.sh 3. https://www.apache.org/legal/src-headers.html#is-a-short-form-of-the-source-header-available - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
Hi, It unclear what is being voted on here, please post a link to the actual artefacts being voted on not the GitHub repo. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
While running the verification script I got an error.. $ ./rcverify.sh openwhisk-composer 'OpenWhisk Composer' 0.11.0-incubating rc2 rcverify.sh (script SHA1: 80DC 4134 B419 D699 1E19 9BBC 847A E346 EB63 57D1) working in the following directory: /var/folders/vw/1bd7pypn3qn295bdyvqrbx4cgn/T/tmp.hjyGBMPi fetching openwhisk-composer-0.11.0-incubating-sources.tar.gz fetching openwhisk-composer-0.11.0-incubating-sources.tar.gz.asc fetching openwhisk-composer-0.11.0-incubating-sources.tar.gz.sha512 fetching release keys importing keys gpg: key 72AF0CC22C4CF320: "Vincent Hou (Release manager of OpenWhisk) < houshen...@apache.org>" not changed gpg: key 22907064147F886E: "Dave Grove " not changed gpg: key 44667BC927C86D51: "Rodric Rabbah " not changed gpg: Total number processed: 3 gpg: unchanged: 3 unpacking tar ball cloning scancode Cloning into 'incubator-openwhisk-utilities'... remote: Enumerating objects: 60, done. remote: Counting objects: 100% (60/60), done. remote: Compressing objects: 100% (43/43), done. remote: Total 60 (delta 21), reused 43 (delta 14), pack-reused 0 Unpacking objects: 100% (60/60), done. computing sha512 for openwhisk-composer-0.11.0-incubating-sources.tar.gz SHA512: openwhisk-composer-0.11.0-incubating-sources.tar.gz: 16726F0F 6F75BA0D 475E5268 2DF1751F 5860ECD4 D41C14C9 3A71BB29 52810487 2F768EAC 4B56D9FC 38D7B307 5A10D2F6 85BBFF33 207D0F2E 9CC3A330 2F124C1F validating sha512... passed verifying asc... passed (signed-by: Vincent Hou (Release manager of OpenWhisk) ) verifying disclaimer... passed verifing notice... passed verifying license... passed verifying sources have proper headers... passed scanning for binaries... failed (/var/folders/vw/1bd7pypn3qn295bdyvqrbx4cgn/T/tmp.hjyGBMPi/incubator-openwhisk-composer-0.11.0-incubating/bin/compose.js /var/folders/vw/1bd7pypn3qn295bdyvqrbx4cgn/T/tmp.hjyGBMPi/incubator-openwhisk-composer-0.11.0-incubating/bin/deploy.js) scanning for archives... passed scanning for packages... passed On Fri, Apr 12, 2019 at 7:51 PM Dave Grove wrote: > We need 1 more binding +1 vote on this release to proceed. Thank you for > your help. > > --dave > > On 2019/04/08 17:32:05, "David P Grove" wrote: > > > > > > The Apache OpenWhisk community has voted to release Apache OpenWhisk > > Composer (incubating) version 0.11.0. > > Apache OpenWhisk Composer is a programming model for composing cloud > > functions built on Apache OpenWhisk. This will be the third Apache > Release > > of OpenWhisk Composer. > > > > The voting thread can be found here: > > > https://lists.apache.org/thread.html/71290ca376a3a1ef591c655dfb92ad9f355b5489ae31dc093c0c54bf@%3Cdev.openwhisk.apache.org%3E > > > > Two binding +1 vote from mentors Matt Sicker and Bertrand Delacretaz > carry > > over from the podling voting thread; at least one more +1 vote is needed. > > > > We request that IPMC Members please review and vote on this incubator > > release as described below. > > > > OpenWhisk Composer: 6bc3405280176e55618853ee8eae284c6e603806 > > > > > https://github.com/apache/incubator-openwhisk-composer.git/commits/6bc3405280176e55618853ee8eae284c6e603806 > > > > > > This release comprises of source code distribution only. > > > > You can use this UNIX script to download the release and verify the > > checklist below: > > > https://gitbox.apache.org/repos/asf?p=incubator-openwhisk-release.git;a=blob_plain;f=tools/rcverify.sh;hb=HEAD > > > > > > Usage: > > curl -s " > > > https://gitbox.apache.org/repos/asf?p=incubator-openwhisk-release.git;a=blob_plain;f=tools/rcverify.sh;hb=HEAD > > > > " -o rcverify.sh > > chmod +x rcverify.sh > > rcverify.sh openwhisk-composer 'OpenWhisk Composer' 0.11.0-incubating rc2 > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > Release verification checklist for reference: > > [ ] Download links are valid. > > [ ] Checksums and PGP signatures are valid. > > [ ] DISCLAIMER is included. > > [ ] Source code artifacts have correct names matching the current > > release. > > [ ] LICENSE and NOTICE files are correct for each OpenWhisk repository. > > [ ] All files have license headers if necessary. > > [ ] No compiled archives bundled in source archive. > > > > This majority vote is open for at least 72 hours. > > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache OpenWhisk Composer 0.11.0 (incubating)
We need 1 more binding +1 vote on this release to proceed. Thank you for your help. --dave On 2019/04/08 17:32:05, "David P Grove" wrote: > > > The Apache OpenWhisk community has voted to release Apache OpenWhisk > Composer (incubating) version 0.11.0. > Apache OpenWhisk Composer is a programming model for composing cloud > functions built on Apache OpenWhisk. This will be the third Apache Release > of OpenWhisk Composer. > > The voting thread can be found here: > https://lists.apache.org/thread.html/71290ca376a3a1ef591c655dfb92ad9f355b5489ae31dc093c0c54bf@%3Cdev.openwhisk.apache.org%3E > > Two binding +1 vote from mentors Matt Sicker and Bertrand Delacretaz carry > over from the podling voting thread; at least one more +1 vote is needed. > > We request that IPMC Members please review and vote on this incubator > release as described below. > > OpenWhisk Composer: 6bc3405280176e55618853ee8eae284c6e603806 > > https://github.com/apache/incubator-openwhisk-composer.git/commits/6bc3405280176e55618853ee8eae284c6e603806 > > > This release comprises of source code distribution only. > > You can use this UNIX script to download the release and verify the > checklist below: > https://gitbox.apache.org/repos/asf?p=incubator-openwhisk-release.git;a=blob_plain;f=tools/rcverify.sh;hb=HEAD > > > Usage: > curl -s " > https://gitbox.apache.org/repos/asf?p=incubator-openwhisk-release.git;a=blob_plain;f=tools/rcverify.sh;hb=HEAD > > " -o rcverify.sh > chmod +x rcverify.sh > rcverify.sh openwhisk-composer 'OpenWhisk Composer' 0.11.0-incubating rc2 > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > Release verification checklist for reference: > [ ] Download links are valid. > [ ] Checksums and PGP signatures are valid. > [ ] DISCLAIMER is included. > [ ] Source code artifacts have correct names matching the current > release. > [ ] LICENSE and NOTICE files are correct for each OpenWhisk repository. > [ ] All files have license headers if necessary. > [ ] No compiled archives bundled in source archive. > > This majority vote is open for at least 72 hours. > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
