Build failure of network:osmocom:nightly/open5gs in Debian_10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/i586 Package network:osmocom:nightly/open5gs failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: types -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/nnrf-handler.c.o' -MF 'src/udr/e340f29@@udr@sta/nnrf-handler.c.o.d' -o 'src/udr/e340f29@@udr@sta/nnrf-handler.c.o' -c ../src/udr/nnrf-handler.c [ 524s] [1926/2112] cc -Isrc/udr/e340f29@@open5gs-udrd@exe -Isrc/udr -I../src/udr -Isrc -I../src -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -pthread '-DDEFAULT_CONFIG_FILENAME="/etc/open5gs/udr.yaml"' -MD -MQ 'src/udr/e340f29@@open5gs-udrd@exe/app.c.o' -MF 'src/udr/e340f29@@open5gs-udrd@exe/app.c.o.d' -o 'src/udr/e340f29@@open5gs-udrd@exe/app.c.o' -c ../src/udr/app.c [ 524s] [1927/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/sbi-path.c.o' -MF 'src/udr/e340f29@@udr@sta/sbi-path.c.o.d' -o 'src/udr/e340f29@@udr@sta/sbi-path.c.o' -c ../src/udr/sbi-path.c [ 525s] [1928/2112] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types
Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.10/i586 Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 211s] [1919/2112] cc -Isrc/nrf/src@nrf@@nrf@sta -Isrc/nrf -I../src/nrf -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/nrf/src@nrf@@nrf@sta/nrf-sm.c.o' -MF 'src/nrf/src@nrf@@nrf@sta/nrf-sm.c.o.d' -o 'src/nrf/src@nrf@@nrf@sta/nrf-sm.c.o' -c ../src/nrf/nrf-sm.c [ 211s] [1920/2112] cc -Isrc/pcrf/src@pcrf@@pcrf@sta -Isrc/pcrf -I../src/pcrf -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/diameter/rx -I../lib/diameter/rx -Ilib/diameter/common -I../lib/diameter/common -Isubprojects/freeDiameter/include -I../subprojects/freeDiameter/include -Isubprojects/freeDiameter -I../subprojects/freeDiameter -Ilib/diameter/gx -I../lib/diameter/gx -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/pcrf/src@pcrf@@pcrf@sta/pcrf-gx-path.c.o' -MF 'src/pcrf/src@pcrf@@pcrf@sta/pcrf-gx-path.c.o.d' -o 'src/pcrf/src@pcrf@@pcrf@sta/pcrf-gx-path.c.o' -c ../src/pcrf/pcrf-gx-path.c [ 211s] [1921/2112] rm -f src/pcrf/libpcrf.a && gcc-ar csrD src/pcrf/libpcrf.a 'src/pcrf/src@pcrf@@pcrf@sta/pcrf-init.c.o' 'src/pcrf/src@pcrf@@pcrf@sta/pcrf-context.c.o' 'src/pcrf/src@pcrf@@pcrf@sta/pcrf-fd-path.c.o' 'src/pcrf/src@pcrf@@pcrf@sta/pcrf-gx-path.c.o' 'src/pcrf/src@pcrf@@pcrf@sta/pcrf-rx-path.c.o' [ 211s] [1922/2112] cc -Isrc/nrf/src@nrf@@nrf@sta -Isrc/nrf -I../src/nrf -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections
Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.04/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.04/i586
Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly open5gs
Last lines of build log:
[ 187s] [1940/2112] cc -Isrc/udm/udm@sta -Isrc/udm -I../src/udm -Ilib/app
-I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt
-Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi
-I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu
-fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra
-Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith
-Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn
-Werror=missing-prototypes -Werror=missing-declarations
-Werror=implicit-function-declaration -Werror=return-type
-Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes
-Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3
-Wwrite-strings -Werror=overflow -Werror=shift-count-overflow
-Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused
-Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare
-Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector
-fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections
-fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/udm@sta/nudm-handler.c.o'
-MF 'src/udm/udm@sta/nudm-handler.c.o.d' -o 'src/udm/udm@sta/nudm-handler.c.o'
-c ../src/udm/nudm-handler.c
[ 187s] [1941/2112] cc -Isrc/udm/udm@sta -Isrc/udm -I../src/udm -Ilib/app
-I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt
-Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi
-I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu
-fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra
-Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith
-Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn
-Werror=missing-prototypes -Werror=missing-declarations
-Werror=implicit-function-declaration -Werror=return-type
-Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes
-Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3
-Wwrite-strings -Werror=overflow -Werror=shift-count-overflow
-Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused
-Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare
-Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector
-fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections
-fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/udm@sta/context.c.o' -MF
'src/udm/udm@sta/context.c.o.d' -o 'src/udm/udm@sta/context.c.o' -c
../src/udm/context.c
[ 187s] FAILED: src/udm/udm@sta/context.c.o
[ 187s] cc -Isrc/udm/udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app
-Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi
-I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1
-I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes
-Werror=missing-declarations -Werror=implicit-function-declaration
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4
-ffunction-sections -fdata-sections -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ
'src/udm/udm@sta/context.c.o' -MF 'src/udm/udm@sta/context.c.o.d' -o
'src/udm/udm@sta/context.c.o' -c ../src/udm/context.c
[ 187s] ../src/udm/context.c: In function ‘udm_ue_add’:
[ 187s] ../src/udm/context.c:129:38: error: format ‘%ld’ expects argument of
type ‘long int’, but argument 2 has type ‘int’ [-Werror=format=]
[ 187s] udm_ue->ctx_id = ogs_msprintf("%ld", ogs_pool_index(_ue_pool,
udm_ue));
[ 187s] ~~^
[ 187s] %d
[ 187s] cc1: some warnings being treated as errors
[ 187s]
Change in osmo-gsm-tester[master]: sysmocom/ttcn3/jenkins-run.sh: Pass confg file as cmdline
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18744 ) Change subject: sysmocom/ttcn3/jenkins-run.sh: Pass confg file as cmdline .. sysmocom/ttcn3/jenkins-run.sh: Pass confg file as cmdline Fix after recent huge refactoring. Change-Id: If0bcc9f7cb70e4ef324b3295d2174d11982a4bde --- M sysmocom/ttcn3/jenkins-run.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/sysmocom/ttcn3/jenkins-run.sh b/sysmocom/ttcn3/jenkins-run.sh index 2bc687d..1688b88 100755 --- a/sysmocom/ttcn3/jenkins-run.sh +++ b/sysmocom/ttcn3/jenkins-run.sh @@ -44,7 +44,7 @@ # jenkins build job. # On failure, first clean up below and then return the exit code. exit_code="1" -if python3 -u "$(which osmo-gsm-tester.py)" "$trial_dir" $OSMO_GSM_TESTER_OPTS ; then +if python3 -u "$(which osmo-gsm-tester.py)" -c "$OSMO_GSM_TESTER_CONF" "$trial_dir" $OSMO_GSM_TESTER_OPTS ; then exit_code="0" fi -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: If0bcc9f7cb70e4ef324b3295d2174d11982a4bde Gerrit-Change-Number: 18744 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: sysmocom/ttcn3/jenkins-run.sh: Pass confg file as cmdline
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18744 ) Change subject: sysmocom/ttcn3/jenkins-run.sh: Pass confg file as cmdline .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: If0bcc9f7cb70e4ef324b3295d2174d11982a4bde Gerrit-Change-Number: 18744 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 20:40:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/18644 to look at the new patch set (#5). Change subject: osmo-mgw: refactor endpoint and trunk handling .. osmo-mgw: refactor endpoint and trunk handling The trunk and endpoint handling in osmo-mgw is still very complex and implemented in various places (mostly mgcp_protocol.c). Also we use still integers for endpoint identification, which is not flexible enough to address timeslots/subslots on an E1 trunk. Some refactoring is needed. - get rid of integers as endpoint identifiers, use strings instead and find the endpoint based on its string name on the trunk. - identify the trunk based on the trunk prefix given in the endpoint name. - refactor trunk and endpoint allocation. Aggregate functionality in in mgcp_endp.c and mgcp_trunk.c. Also remove non-reusable code that relates to the still exisiting, but unfinished E1 trunk support. - refactor rate counters, put them into a separate module and do no longer allocate them per trunk. Allocate them globally instead. Change-Id: Ia8cf4d6caf05a4e13f1f507dc68cbabb7e6239aa Related: OS#2659 --- M include/osmocom/mgcp/Makefile.am M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_common.h M include/osmocom/mgcp/mgcp_endp.h M include/osmocom/mgcp/mgcp_internal.h A include/osmocom/mgcp/mgcp_ratectr.h A include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/Makefile.am M src/libosmo-mgcp/mgcp_codec.c M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_msg.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_osmux.c M src/libosmo-mgcp/mgcp_protocol.c A src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_sdp.c A src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c 21 files changed, 903 insertions(+), 629 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/44/18644/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia8cf4d6caf05a4e13f1f507dc68cbabb7e6239aa Gerrit-Change-Number: 18644 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: trunk: parse E1 trunk number
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-mgw/+/18752 )
Change subject: trunk: parse E1 trunk number
..
trunk: parse E1 trunk number
The E1 trunk number is currently not parsed, whenever a trunk prefix is
detected that indicates an E1 trunk, then the entire request is
rejected.
Parse the trunk number and select the trunk accordingly
Related: OS#2547
Change-Id: Ifdaab953544151e73b58cc3e95d21afdb40765f4
---
M src/libosmo-mgcp/mgcp_trunk.c
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/52/18752/1
diff --git a/src/libosmo-mgcp/mgcp_trunk.c b/src/libosmo-mgcp/mgcp_trunk.c
index 7774e40..33ca116 100644
--- a/src/libosmo-mgcp/mgcp_trunk.c
+++ b/src/libosmo-mgcp/mgcp_trunk.c
@@ -137,9 +137,7 @@
* e1 trunk for now. */
prefix_len = sizeof(MGCP_ENDPOINT_PREFIX_E1_TRUNK) - 1;
if (strncmp(epname, MGCP_ENDPOINT_PREFIX_E1_TRUNK, prefix_len) == 0) {
- LOGP(DLMGCP, LOGL_ERROR,
-"endpoint name \"%s\" suggests an E1 trunk, but E1 trunks
are not implemented in this version of osmo-mgw!\n", epname);
- return NULL;
+ return mgcp_trunk_by_num(cfg, atoi(epname+prefix_len));
}
/* Earlier versions of osmo-mgw were accepting endpoint names
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18752
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ifdaab953544151e73b58cc3e95d21afdb40765f4
Gerrit-Change-Number: 18752
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
Build failure of network:osmocom:nightly/open5gs in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/armv7l Package network:osmocom:nightly/open5gs failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 541s] [1933/2112] cc -o src/pcrf/open5gs-pcrfd 'src/pcrf/9bf4e44@@open5gs-pcrfd@exe/app-init.c.o' 'src/pcrf/9bf4e44@@open5gs-pcrfd@exe/.._main.c.o' -Wl,--no-undefined -Wl,--as-needed -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -Wl,--start-group src/pcrf/libpcrf.a lib/app/libogsapp.so.1.2.5 lib/core/libogscore.so.1.2.5 lib/dbi/libogsdbi.so.1.2.5 lib/crypt/libogscrypt.so.1.2.5 lib/diameter/rx/libogsdiameter-rx.so.1.2.5 lib/diameter/common/libogsdiameter-common.so.1.2.5 subprojects/freeDiameter/libfdcore/libfdcore.so.1.3.2 subprojects/freeDiameter/libfdproto/libfdproto.so.1.3.2 lib/diameter/gx/libogsdiameter-gx.so.1.2.5 /usr/lib/arm-linux-gnueabihf/libyaml.so /usr/lib/gcc/arm-linux-gnueabihf/8/../../../arm-linux-gnueabihf/libmongoc-1.0.so /usr/lib/gcc/arm-linux-gnueabihf/8/../../../arm-linux-gnueabihf/libbson-1.0.so -lidn -ldl -lsctp -lgcrypt -lgnutls -lidn -ldl -lsctp -lgcrypt -lgnutls -lidn -ldl -lsctp -lgcrypt -lgnutls -lidn -ldl -lsctp -lgcrypt -lgnutls -Wl,--end-group -pthread '-Wl,-rpath,$ORIGIN/:$ORIGIN/../../lib/app:$ORIGIN/../../lib/core:$ORIGIN/../../lib/dbi:$ORIGIN/../../lib/crypt:$ORIGIN/../../lib/diameter/rx:$ORIGIN/../../lib/diameter/common:$ORIGIN/../../subprojects/freeDiameter/libfdcore:$ORIGIN/../../subprojects/freeDiameter/libfdproto:$ORIGIN/../../lib/diameter/gx' -Wl,-rpath-link,/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/src/pcrf:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/app:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/core:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/dbi:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/crypt:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/diameter/rx:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/diameter/common:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/subprojects/freeDiameter/libfdcore:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/subprojects/freeDiameter/libfdproto:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/diameter/gx [ 541s] [1934/2112] rm -f src/udr/libudr.a && gcc-ar csrD src/udr/libudr.a 'src/udr/e340f29@@udr@sta/context.c.o' 'src/udr/e340f29@@udr@sta/event.c.o' 'src/udr/e340f29@@udr@sta/timer.c.o' 'src/udr/e340f29@@udr@sta/nnrf-handler.c.o' 'src/udr/e340f29@@udr@sta/nf-sm.c.o' 'src/udr/e340f29@@udr@sta/nudr-handler.c.o' 'src/udr/e340f29@@udr@sta/sbi-path.c.o' 'src/udr/e340f29@@udr@sta/udr-sm.c.o' 'src/udr/e340f29@@udr@sta/init.c.o' [ 541s] [1935/2112] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/3eca12a@@udm@sta/nudm-handler.c.o' -MF 'src/udm/3eca12a@@udm@sta/nudm-handler.c.o.d' -o 'src/udm/3eca12a@@udm@sta/nudm-handler.c.o' -c ../src/udm/nudm-handler.c [ 541s] [1936/2112] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5
Change in osmo-bsc[master]: gsm_data.h: Remove period at end of counter description
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18749 ) Change subject: gsm_data.h: Remove period at end of counter description .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18749/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/18749/1//COMMIT_MSG@7 PS1, Line 7: gsm_data.h: Remove period at end of counter descriptionn > Now you need to send a patch named […] I blame my fast computer. It registered two keystrokes where I only intended on :-) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18749 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I045cef207603074bd018e40f984263d03db31405 Gerrit-Change-Number: 18749 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 17:32:28 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-bsc[master]: abis_rsl: Count successful channel requests
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18719 to look at the new patch set (#3). Change subject: abis_rsl: Count successful channel requests .. abis_rsl: Count successful channel requests Ticket: SYS#4877 Change-Id: I5c51956569223e802f4789dc5ed1605d18f80aea --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/abis_rsl.c 2 files changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/18719/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c51956569223e802f4789dc5ed1605d18f80aea Gerrit-Change-Number: 18719 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: Count assignment rates per BTS as well
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18720 to look at the new patch set (#4). Change subject: Count assignment rates per BTS as well .. Count assignment rates per BTS as well This adds the assignment counters for the BTS as well and changes the assignment_count() macro to increase both the counters for the BSC as well as the BTS. Related: SYS#4877 Change-Id: I0009e51d4caf68e762138d98e2e23d49acc3cc1a --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/assignment_fsm.c 2 files changed, 29 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/20/18720/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0009e51d4caf68e762138d98e2e23d49acc3cc1a Gerrit-Change-Number: 18720 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: gsm_data.h: Remove period at end of counter description
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18749 to look at the new patch set (#2). Change subject: gsm_data.h: Remove period at end of counter description .. gsm_data.h: Remove period at end of counter description Change-Id: I045cef207603074bd018e40f984263d03db31405 --- M include/osmocom/bsc/gsm_data.h 1 file changed, 18 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/49/18749/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18749 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I045cef207603074bd018e40f984263d03db31405 Gerrit-Change-Number: 18749 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: endp: add name generator function for E1 endpoints
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18745 ) Change subject: endp: add name generator function for E1 endpoints .. Patch Set 2: (2 comments) (ensure all messages are sent) https://gerrit.osmocom.org/c/osmo-mgw/+/18745/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/18745/1//COMMIT_MSG@10 PS1, Line 10: correct. Lets add an endpoint name generator function that derives a > Let's Done https://gerrit.osmocom.org/c/osmo-mgw/+/18745/1/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18745/1/src/libosmo-mgcp/mgcp_endp.c@87 PS1, Line 87: gen_e1_epname(ep_name_buf, trunk->trunk_nr, index / 14, index % 14); > So you'll be in the end crafting an index value to pass it to > mgcp_endp_alloc(), to then uncraft it […] When the trunk is allocated all it knows is how many endpoints it has to allocate. The index is just for the moment of allocation so that the endp alloc function can generate the name. I had the name generation in mgcp_trunk.c before but I think that the "knowlege" on how the name is generated should only be in mgcp_endp.c. We also remove complexity, the trunk no longer has to distinguish between the E1 and virtual when generating the name. An alternate solution would be to let mgcp_endp_alloc() allocate all endpoints, then the index would not have to passed as a parameter. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18745 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I70e0c3f96aa3947165f992815ee5614c8f57 Gerrit-Change-Number: 18745 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 17:00:15 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-mgw[master]: endp: add name generator function for E1 endpoints
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/18745 to look at the new patch set (#2). Change subject: endp: add name generator function for E1 endpoints .. endp: add name generator function for E1 endpoints Currently the endpoint name that is generated for an E1 endpoint is not correct. Let's add an endpoint name generator function that derives a full endpoint name for a given E1 index Change-Id: I70e0c3f96aa3947165f992815ee5614c8f57 Related: OS#2547 --- M src/libosmo-mgcp/mgcp_endp.c 1 file changed, 23 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/45/18745/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18745 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I70e0c3f96aa3947165f992815ee5614c8f57 Gerrit-Change-Number: 18745 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: scheduler: Fix reading out of buffer during tx of dummy burst on PDCH...
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18751 ) Change subject: scheduler: Fix reading out of buffer during tx of dummy burst on PDCH TS with EGPRS enabled .. Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/18751/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/18751/1//COMMIT_MSG@7 PS1, Line 7: Fix reading out of buffer during tx of dummy burst on PDCH TS with EGPRS enabled Commit description is a bit too long, it could be just "... fix dummy burst buffer overrun". -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18751 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iba6ccceed5c0f1db810259768678f174d39cbf8b Gerrit-Change-Number: 18751 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 09 Jun 2020 16:19:24 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: scheduler.c: Fix trailing whitespace
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18750 ) Change subject: scheduler.c: Fix trailing whitespace .. scheduler.c: Fix trailing whitespace Change-Id: I9842470fcad074863bd30550ac63640754de1d37 --- M src/common/scheduler.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 5b398d1..55cb36a 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -827,7 +827,7 @@ } -/* +/* * ready-to-send indication (to upper layer) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9842470fcad074863bd30550ac63640754de1d37 Gerrit-Change-Number: 18750 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-bsc[master]: Count assignment rates per BTS as well
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18720 ) Change subject: Count assignment rates per BTS as well .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0009e51d4caf68e762138d98e2e23d49acc3cc1a Gerrit-Change-Number: 18720 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 16:14:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: abis_rsl: Count successful channel requests
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18719 ) Change subject: abis_rsl: Count successful channel requests .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c51956569223e802f4789dc5ed1605d18f80aea Gerrit-Change-Number: 18719 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 16:14:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: gsm_data.h: Remove period at end of counter descriptionn
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18749 ) Change subject: gsm_data.h: Remove period at end of counter descriptionn .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18749/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/18749/1//COMMIT_MSG@7 PS1, Line 7: gsm_data.h: Remove period at end of counter descriptionn Now you need to send a patch named "Remove character n at the end of commit descriptionn" and you enter an infinite loop. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18749 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I045cef207603074bd018e40f984263d03db31405 Gerrit-Change-Number: 18749 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 16:14:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: scheduler.c: Fix trailing whitespace
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18750 ) Change subject: scheduler.c: Fix trailing whitespace .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9842470fcad074863bd30550ac63640754de1d37 Gerrit-Change-Number: 18750 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 09 Jun 2020 16:09:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: scheduler.c: Fix trailing whitespace
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18750 ) Change subject: scheduler.c: Fix trailing whitespace .. scheduler.c: Fix trailing whitespace Change-Id: I9842470fcad074863bd30550ac63640754de1d37 --- M src/common/scheduler.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/50/18750/1 diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 5b398d1..55cb36a 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -827,7 +827,7 @@ } -/* +/* * ready-to-send indication (to upper layer) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9842470fcad074863bd30550ac63640754de1d37 Gerrit-Change-Number: 18750 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in osmo-bts[master]: scheduler: Fix reading out of buffer during tx of dummy burst on PDCH...
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18751 ) Change subject: scheduler: Fix reading out of buffer during tx of dummy burst on PDCH TS with EGPRS enabled .. scheduler: Fix reading out of buffer during tx of dummy burst on PDCH TS with EGPRS enabled If for whatever reason (eg fn-advance too small) there's no burst available for a PDCH TS where EGPRS is enabled, a dummy burst of size GSM_BURST_LEN would be selected in _sched_dl_burst(), but the nbits length would still be set to EGPRS_BURST_LEN above by func() pointer (tx_pdtch_fn()). As a result, trx_if_send_burst() would later read EGPRS_BURST_LEN from the dummy burst of size GSM_BURST_LEN. The issue was found by ASan. See OS#4606 for more info. Fixes: OS#4606 Change-Id: Iba6ccceed5c0f1db810259768678f174d39cbf8b --- M src/common/scheduler.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/18751/1 diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 55cb36a..021a4cd 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -1211,6 +1211,8 @@ trx_chan_desc[chan].name, fn, tn, bid); #endif bits = (ubit_t *) dummy_burst; + if (nbits) + *nbits = ARRAY_SIZE(dummy_burst); } return bits; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18751 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iba6ccceed5c0f1db810259768678f174d39cbf8b Gerrit-Change-Number: 18751 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Build failure of network:osmocom:nightly/open5gs in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Raspbian_10/armv7l Package network:osmocom:nightly/open5gs failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 435s] [1929/2112] cc -Isrc/udr/e340f29@@open5gs-udrd@exe -Isrc/udr -I../src/udr -Isrc -I../src -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -pthread '-DDEFAULT_CONFIG_FILENAME="/etc/open5gs/udr.yaml"' -MD -MQ 'src/udr/e340f29@@open5gs-udrd@exe/app.c.o' -MF 'src/udr/e340f29@@open5gs-udrd@exe/app.c.o.d' -o 'src/udr/e340f29@@open5gs-udrd@exe/app.c.o' -c ../src/udr/app.c [ 435s] [1930/2112] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/3eca12a@@udm@sta/timer.c.o' -MF 'src/udm/3eca12a@@udm@sta/timer.c.o.d' -o 'src/udm/3eca12a@@udm@sta/timer.c.o' -c ../src/udm/timer.c [ 435s] [1931/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/udr-sm.c.o' -MF 'src/udr/e340f29@@udr@sta/udr-sm.c.o.d' -o 'src/udr/e340f29@@udr@sta/udr-sm.c.o' -c ../src/udr/udr-sm.c [ 435s] [1932/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core
Change in osmocom-bb[master]: firmware/layer1: cosmetic: add missing comma to debug print
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18748 ) Change subject: firmware/layer1: cosmetic: add missing comma to debug print .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18748 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icfc403e500c24628da722ab378fba31923afd1a1 Gerrit-Change-Number: 18748 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 15:52:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware/apps/rssi: enlarge text buffer in refresh_display()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18747 ) Change subject: firmware/apps/rssi: enlarge text buffer in refresh_display() .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/18747/1/src/target/firmware/apps/rssi/main.c File src/target/firmware/apps/rssi/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/18747/1/src/target/firmware/apps/rssi/main.c@197 PS1, Line 197: sprintf(text, "%c%cE%c%c", (power >= 40) ? 'D':'G', Would be great using snprintf too. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18747 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7980727b78f7622d792d82170f73c90ac5770397 Gerrit-Change-Number: 18747 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 15:52:06 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: osmo-bsc: Use designated initializer in bts_stat_desc
daniel has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/18718 )
Change subject: osmo-bsc: Use designated initializer in bts_stat_desc
..
osmo-bsc: Use designated initializer in bts_stat_desc
Change-Id: Ic29f3a7e6fb16955bc74cc163d45a243b373183a
---
M src/osmo-bsc/gsm_data.c
1 file changed, 45 insertions(+), 24 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 46e26ac..9bf6f82 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -345,30 +345,51 @@
}
static const struct osmo_stat_item_desc bts_stat_desc[] = {
- { "chanloadavg", "Channel load average", "%", 16, 0 },
- { "chan_ccch_sdcch4:used", "Number of CCCH+SDCCH4 channels used", "",
16, 0 },
- { "chan_ccch_sdcch4:total", "Number of CCCH+SDCCH4 channels total", "",
16, 0 },
- { "chan_tch_f:used", "Number of TCH/F channels used", "", 16, 0 },
- { "chan_tch_f:total", "Number of TCH/F channels total", "", 16, 0 },
- { "chan_tch_h:used", "Number of TCH/H channels used", "", 16, 0 },
- { "chan_tch_h:total", "Number of TCH/H channels total", "", 16, 0 },
- { "chan_sdcch8:used", "Number of SDCCH8 channels used", "", 16, 0 },
- { "chan_sdcch8:total", "Number of SDCCH8 channels total", "", 16, 0 },
- { "chan_tch_f_pdch:used", "Number of TCH/F_PDCH channels used", "", 16,
0 },
- { "chan_tch_f_pdch:total", "Number of TCH/F_PDCH channels total", "",
16, 0 },
- { "chan_ccch_sdcch4_cbch:used", "Number of CCCH+SDCCH4+CBCH channels
used", "", 16, 0 },
- { "chan_ccch_sdcch4_cbch:total", "Number of CCCH+SDCCH4+CBCH channels
total", "", 16, 0 },
- { "chan_sdcch8_cbch:used", "Number of SDCCH8+CBCH channels used", "",
16, 0 },
- { "chan_sdcch8_cbch:total", "Number of SDCCH8+CBCH channels total", "",
16, 0 },
- { "chan_tch_f_tch_h_pdch:used", "Number of TCH/F_TCH/H_PDCH channels
used", "", 16, 0 },
- { "chan_tch_f_tch_h_pdch:total", "Number of TCH/F_TCH/H_PDCH channels
total", "", 16, 0 },
- { "T3122", "T3122 IMMEDIATE ASSIGNMENT REJECT wait indicator", "s", 16,
GSM_T3122_DEFAULT },
- { "rach_busy", "RACH slots with signal above threshold", "%", 16, 0 },
- { "rach_access", "RACH slots with access bursts in them", "%", 16, 0 },
- { "oml_connected", "Number of OML links connected", "", 16, 0 },
- { "rsl_connected", "Number of RSL links connected", "", 16, 0 },
- { "lchan_borken", "Number of lchans in the BORKEN state", "", 16, 0 },
- { "ts_borken", "Number of timeslots in the BORKEN state", "", 16, 0 },
+ [BTS_STAT_CHAN_LOAD_AVERAGE] = { "chanloadavg",
"Channel load average", "%", 16, 0 },
+ [BTS_STAT_CHAN_CCCH_SDCCH4_USED] = {
"chan_ccch_sdcch4:used",
+ "Number of
CCCH+SDCCH4 channels used", "", 16, 0 },
+ [BTS_STAT_CHAN_CCCH_SDCCH4_TOTAL] = {
"chan_ccch_sdcch4:total",
+ "Number of
CCCH+SDCCH4 channels total", "", 16, 0 },
+ [BTS_STAT_CHAN_TCH_F_USED] ={ "chan_tch_f:used",
+ "Number of TCH/F
channels used", "", 16, 0 },
+ [BTS_STAT_CHAN_TCH_F_TOTAL] = { "chan_tch_f:total",
+ "Number of TCH/F
channels total", "", 16, 0 },
+ [BTS_STAT_CHAN_TCH_H_USED] ={ "chan_tch_h:used",
+ "Number of TCH/H
channels used", "", 16, 0 },
+ [BTS_STAT_CHAN_TCH_H_TOTAL] = { "chan_tch_h:total",
+ "Number of TCH/H
channels total", "", 16, 0 },
+ [BTS_STAT_CHAN_SDCCH8_USED] = { "chan_sdcch8:used",
+ "Number of SDCCH8
channels used", "", 16, 0 },
+ [BTS_STAT_CHAN_SDCCH8_TOTAL] = { "chan_sdcch8:total",
+ "Number of SDCCH8
channels total", "", 16, 0 },
+ [BTS_STAT_CHAN_TCH_F_PDCH_USED] = {
"chan_tch_f_pdch:used",
+ "Number of TCH/F_PDCH
channels used", "", 16, 0 },
+ [BTS_STAT_CHAN_TCH_F_PDCH_TOTAL] = {
"chan_tch_f_pdch:total",
+ "Number of TCH/F_PDCH
channels total", "", 16, 0 },
+ [BTS_STAT_CHAN_CCCH_SDCCH4_CBCH_USED] = {
"chan_ccch_sdcch4_cbch:used",
+ "Number of
CCCH+SDCCH4+CBCH channels used", "",
Change in osmo-bsc[master]: Count assignment rates per BTS as well
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/18720 )
Change subject: Count assignment rates per BTS as well
..
Patch Set 3:
(2 comments)
https://gerrit.osmocom.org/c/osmo-bsc/+/18720/2/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/18720/2/include/osmocom/bsc/gsm_data.h@1441
PS2, Line 1441: [BTS_CTR_CHREQ_SUCCESSFUL] =
{"chreq:successful", "Successful channel requests (immediate assign sent)."},
> That's for the previous patch, not for this one, right?
You're right, moved it (and removed the period)
https://gerrit.osmocom.org/c/osmo-bsc/+/18720/2/include/osmocom/bsc/gsm_data.h@1487
PS2, Line 1487: [BTS_CTR_ASSIGNMENT_ATTEMPTED] =
{"assignment:attempted", "Assignment attempts."},
> Remove dot at the end
Ok, I have also added a separate commit to remove the period in other counter
descriptions.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18720
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0009e51d4caf68e762138d98e2e23d49acc3cc1a
Gerrit-Change-Number: 18720
Gerrit-PatchSet: 3
Gerrit-Owner: daniel
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-CC: pespin
Gerrit-Comment-Date: Tue, 09 Jun 2020 15:29:35 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-bsc[master]: gsm_data.h: Remove period at end of counter descriptionn
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/18749 )
Change subject: gsm_data.h: Remove period at end of counter descriptionn
..
gsm_data.h: Remove period at end of counter descriptionn
Change-Id: I045cef207603074bd018e40f984263d03db31405
---
M include/osmocom/bsc/gsm_data.h
1 file changed, 18 insertions(+), 18 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/49/18749/1
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 1e7e88f..bb8b764 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1429,25 +1429,25 @@
};
static const struct rate_ctr_desc bts_ctr_description[] = {
- [BTS_CTR_CHREQ_TOTAL] = {"chreq:total", "Received
channel requests."},
- [BTS_CTR_CHREQ_NO_CHANNEL] ={"chreq:no_channel", "Sent to
MS no channel available."},
- [BTS_CTR_CHAN_RF_FAIL] ={"chan:rf_fail", "Received a RF
failure indication from BTS."},
- [BTS_CTR_CHAN_RLL_ERR] ={"chan:rll_err", "Received a
RLL failure with T200 cause from BTS."},
- [BTS_CTR_BTS_OML_FAIL] ={"oml_fail", "Received a TEI
down on a OML link."},
- [BTS_CTR_BTS_RSL_FAIL] ={"rsl_fail", "Received a TEI
down on a OML link."},
- [BTS_CTR_CODEC_AMR_F] = {"codec:amr_f", "Count the
usage of AMR/F codec by channel mode requested."},
- [BTS_CTR_CODEC_AMR_H] = {"codec:amr_h", "Count the
usage of AMR/H codec by channel mode requested."},
- [BTS_CTR_CODEC_EFR] = {"codec:efr", "Count the usage
of EFR codec by channel mode requested."},
- [BTS_CTR_CODEC_V1_FR] = {"codec:fr", "Count the usage
of FR codec by channel mode requested."},
- [BTS_CTR_CODEC_V1_HR] = {"codec:hr", "Count the usage
of HR codec by channel mode requested."},
+ [BTS_CTR_CHREQ_TOTAL] = {"chreq:total", "Received
channel requests"},
+ [BTS_CTR_CHREQ_NO_CHANNEL] ={"chreq:no_channel", "Sent to
MS no channel available"},
+ [BTS_CTR_CHAN_RF_FAIL] ={"chan:rf_fail", "Received a RF
failure indication from BTS"},
+ [BTS_CTR_CHAN_RLL_ERR] ={"chan:rll_err", "Received a
RLL failure with T200 cause from BTS"},
+ [BTS_CTR_BTS_OML_FAIL] ={"oml_fail", "Received a TEI
down on a OML link"},
+ [BTS_CTR_BTS_RSL_FAIL] ={"rsl_fail", "Received a TEI
down on a OML link"},
+ [BTS_CTR_CODEC_AMR_F] = {"codec:amr_f", "Count the
usage of AMR/F codec by channel mode requested"},
+ [BTS_CTR_CODEC_AMR_H] = {"codec:amr_h", "Count the
usage of AMR/H codec by channel mode requested"},
+ [BTS_CTR_CODEC_EFR] = {"codec:efr", "Count the usage
of EFR codec by channel mode requested"},
+ [BTS_CTR_CODEC_V1_FR] = {"codec:fr", "Count the usage
of FR codec by channel mode requested"},
+ [BTS_CTR_CODEC_V1_HR] = {"codec:hr", "Count the usage
of HR codec by channel mode requested"},
- [BTS_CTR_PAGING_ATTEMPTED] ={"paging:attempted", "Paging
attempts for a subscriber."},
- [BTS_CTR_PAGING_ALREADY] = {"paging:already", "Paging
attempts ignored as subscriber was already being paged."},
- [BTS_CTR_PAGING_RESPONDED] ={"paging:responded", "Paging
attempts with successful paging response."},
- [BTS_CTR_PAGING_EXPIRED] = {"paging:expired", "Paging
Request expired because of timeout T3113."},
- [BTS_CTR_PAGING_NO_ACTIVE_PAGING] = {"paging:no_active_paging",
"Paging response without an active paging request (arrived after paging
expiration?)."},
- [BTS_CTR_PAGING_MSC_FLUSH] ={"paging:msc_flush", "Paging
flushed due to MSC Reset BSSMAP message."},
- [BTS_CTR_CHAN_ACT_TOTAL] = {"chan_act:total", "Total
number of Channel Activations."},
+ [BTS_CTR_PAGING_ATTEMPTED] ={"paging:attempted", "Paging
attempts for a subscriber"},
+ [BTS_CTR_PAGING_ALREADY] = {"paging:already", "Paging
attempts ignored as subscriber was already being paged"},
+ [BTS_CTR_PAGING_RESPONDED] ={"paging:responded", "Paging
attempts with successful paging response"},
+ [BTS_CTR_PAGING_EXPIRED] = {"paging:expired", "Paging
Request expired because of timeout T3113"},
+ [BTS_CTR_PAGING_NO_ACTIVE_PAGING] = {"paging:no_active_paging",
"Paging response without an active paging request (arrived after paging
expiration?)"},
+ [BTS_CTR_PAGING_MSC_FLUSH] ={"paging:msc_flush", "Paging
flushed due to MSC Reset BSSMAP message"},
+ [BTS_CTR_CHAN_ACT_TOTAL] =
Change in osmo-bsc[master]: Count assignment rates per BTS as well
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18720 to look at the new patch set (#3). Change subject: Count assignment rates per BTS as well .. Count assignment rates per BTS as well This adds the assignment counters for the BTS as well and changes the assignment_count() macro to increase both the counters for the BSC as well as the BTS. Related: SYS#4877 Change-Id: I0009e51d4caf68e762138d98e2e23d49acc3cc1a --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/assignment_fsm.c 2 files changed, 29 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/20/18720/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0009e51d4caf68e762138d98e2e23d49acc3cc1a Gerrit-Change-Number: 18720 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: abis_rsl: Count successful channel requests
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18719 to look at the new patch set (#2). Change subject: abis_rsl: Count successful channel requests .. abis_rsl: Count successful channel requests Ticket: SYS#4877 Change-Id: I5c51956569223e802f4789dc5ed1605d18f80aea --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/abis_rsl.c 2 files changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/18719/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c51956569223e802f4789dc5ed1605d18f80aea Gerrit-Change-Number: 18719 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmocom-bb[master]: firmware/layer1: cosmetic: add missing comma to debug print
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmocom-bb/+/18748 )
Change subject: firmware/layer1: cosmetic: add missing comma to debug print
..
firmware/layer1: cosmetic: add missing comma to debug print
Change-Id: Icfc403e500c24628da722ab378fba31923afd1a1
---
M src/target/firmware/layer1/l23_api.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/48/18748/1
diff --git a/src/target/firmware/layer1/l23_api.c
b/src/target/firmware/layer1/l23_api.c
index e0fee84..d52d8f6 100644
--- a/src/target/firmware/layer1/l23_api.c
+++ b/src/target/firmware/layer1/l23_api.c
@@ -376,7 +376,7 @@
struct l1ctl_info_ul *ul = (struct l1ctl_info_ul *) l1h->data;
struct l1ctl_rach_req *rach_req = (struct l1ctl_rach_req *) ul->payload;
- printd("L1CTL_RACH_REQ (ra=0x%02x, offset=%d combined=%d)\n",
+ printd("L1CTL_RACH_REQ (ra=0x%02x, offset=%d, combined=%d)\n",
rach_req->ra, ntohs(rach_req->offset), rach_req->combined);
l1a_rach_req(ntohs(rach_req->offset), rach_req->combined,
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18748
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Icfc403e500c24628da722ab378fba31923afd1a1
Gerrit-Change-Number: 18748
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmocom-bb[master]: firmware/apps/rssi: enlarge text buffer in refresh_display()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmocom-bb/+/18747 )
Change subject: firmware/apps/rssi: enlarge text buffer in refresh_display()
..
firmware/apps/rssi: enlarge text buffer in refresh_display()
This change fixes several warnings reported by GCC 10.1.0:
apps/rssi/main.c:238:30: warning: 'sprintf' may write a terminating
nul past the end of the destination
apps/rssi/main.c:238:4: note: 'sprintf' output between 10 and 17
bytes into a destination of size 16
apps/rssi/main.c:413:26: warning: '.' directive writing 1 byte into
a region of size between 0 and 9
apps/rssi/main.c:413:3: note: 'sprintf' output between 10 and 20
bytes into a destination of size 16
Change-Id: I7980727b78f7622d792d82170f73c90ac5770397
---
M src/target/firmware/apps/rssi/main.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/47/18747/1
diff --git a/src/target/firmware/apps/rssi/main.c
b/src/target/firmware/apps/rssi/main.c
index e137806..4b33ee3 100644
--- a/src/target/firmware/apps/rssi/main.c
+++ b/src/target/firmware/apps/rssi/main.c
@@ -170,7 +170,7 @@
static void refresh_display(void)
{
- char text[16];
+ char text[32];
int bat = battery_info.battery_percent;
fb_clear();
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18747
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7980727b78f7622d792d82170f73c90ac5770397
Gerrit-Change-Number: 18747
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-bts[master]: pcu_sock: Change log about tx PCH confirm INFO->DEBUG
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18746 ) Change subject: pcu_sock: Change log about tx PCH confirm INFO->DEBUG .. pcu_sock: Change log about tx PCH confirm INFO->DEBUG It's not something useful to see unless someone's really debugging that part, and it shows up quite frequently. Change-Id: I3c0dee36c7d34e6b1341b517ce3bcd1b275e69c1 --- M src/common/pcu_sock.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/46/18746/1 diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 7ced69c..f4a8c0a 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -474,7 +474,7 @@ /* FIXME: allow multiple BTS */ bts = llist_entry(net->bts_list.next, struct gsm_bts, list); - LOGP(DPCU, LOGL_INFO, "Sending PCH confirm\n"); + LOGP(DPCU, LOGL_DEBUG, "Sending PCH confirm\n"); msg = pcu_msgb_alloc(PCU_IF_MSG_DATA_CNF, bts->nr); if (!msg) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18746 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3c0dee36c7d34e6b1341b517ce3bcd1b275e69c1 Gerrit-Change-Number: 18746 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in osmo-msc[master]: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18740 ) Change subject: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6b1b55b3f5a3092d9557dc2512020c766a9ff744 Gerrit-Change-Number: 18740 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 14:44:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: endp: add name generator function for E1 endpoints
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18745 ) Change subject: endp: add name generator function for E1 endpoints .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/18745/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/18745/1//COMMIT_MSG@10 PS1, Line 10: correct. Lets add an endpoint name generator function that derives a Let's https://gerrit.osmocom.org/c/osmo-mgw/+/18745/1/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18745/1/src/libosmo-mgcp/mgcp_endp.c@87 PS1, Line 87: gen_e1_epname(ep_name_buf, trunk->trunk_nr, index / 14, index % 14); So you'll be in the end crafting an index value to pass it to mgcp_endp_alloc(), to then uncraft it to convert it into a string. Does that really make sense? If IDs are really strings, then simply pass a string to mgcp_endp_alloc? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18745 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I70e0c3f96aa3947165f992815ee5614c8f57 Gerrit-Change-Number: 18745 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 14:40:17 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-msc[master]: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18740 ) Change subject: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST .. Patch Set 3: (1 comment) (ensur all messages are sent) https://gerrit.osmocom.org/c/osmo-msc/+/18740/2/src/libmsc/msc_ho.c File src/libmsc/msc_ho.c: https://gerrit.osmocom.org/c/osmo-msc/+/18740/2/src/libmsc/msc_ho.c@406 PS2, Line 406: .call_id = cc_trans->callref, > NO . […] Thats indeed not required. The generator function unconditionally picks it, which is ok. The struct member is only used when the MSC receives messages and decodes them. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6b1b55b3f5a3092d9557dc2512020c766a9ff744 Gerrit-Change-Number: 18740 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 14:36:20 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-msc[master]: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST
Hello neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/18740 to look at the new patch set (#3). Change subject: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST .. msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST When msc_ho_send_handover_request() generates the HANDOVER REQUEST message, it does not populate the call_id struct member. In ran_msg_a.c the struct member call_id is used, but the call_id_present flag is not set, which also prevents the call_id being added to the message Change-Id: I6b1b55b3f5a3092d9557dc2512020c766a9ff744 Related: OS#4582 --- M src/libmsc/msc_ho.c M src/libmsc/ran_msg_a.c 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/18740/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6b1b55b3f5a3092d9557dc2512020c766a9ff744 Gerrit-Change-Number: 18740 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: osmo-bts-trx: Change default for clock_advance to 3
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17766 ) Change subject: osmo-bts-trx: Change default for clock_advance to 3 .. Patch Set 1: Using with osmo-trx-uhd B200 with multi-arfcn (2TRX) as requested by Daniel: osmotrx fn-advance 2 osmotrx rts-advance 3 I see lots of issues in osmo-bts-trx like this: 20200609163224911 DL1P <0007> scheduler.c:669 1027203/774/21/12/27 (bts=0,trx=1,ts=7) PDTCH: Prim 2715644 is out of range (100), or channel (bts=0,trx=1,ts=7,ss=0) with type PDTCH is already disabled. If this happens in conjunction with PCU, increase 'rts-advance' by 5. No issue shows up in osmo-trx. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7da3d0948f38e12342fb714b29f8edc5e9d0933d Gerrit-Change-Number: 17766 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 14:34:20 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: fix latest: enable IPA stream ID patching
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18743 ) Change subject: ttcn3-bts-test/jenkins.sh: fix latest: enable IPA stream ID patching .. ttcn3-bts-test/jenkins.sh: fix latest: enable IPA stream ID patching Change-Id: I9d76acc717f5aafbfbecafb30160b02486d341fd Depends: I66cecc9ea24ba79e1a03492e3fda2874951d37a0 --- M ttcn3-bts-test/BTS_Tests.cfg M ttcn3-bts-test/jenkins.sh 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Verified diff --git a/ttcn3-bts-test/BTS_Tests.cfg b/ttcn3-bts-test/BTS_Tests.cfg index 7e734c8..4ea1e59 100644 --- a/ttcn3-bts-test/BTS_Tests.cfg +++ b/ttcn3-bts-test/BTS_Tests.cfg @@ -15,6 +15,9 @@ L1CTL_PortType.m_l1ctl_sock_path := "/data/unix/osmocom_l2" BTS_Tests.mp_ctrl_ip := "172.18.9.20" +# Workaround for osmo-bts-latest: enable IPA stream ID patching +RSL_Emulation.mp_rslem_patch_ipa_cid := false; + [MAIN_CONTROLLER] [EXECUTE] diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 0d0473b..20ad748 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -99,6 +99,13 @@ mkdir $VOL_BASE_DIR/bts-tester/unix cp BTS_Tests.cfg $VOL_BASE_DIR/bts-tester/ +# Work around for a bug in osmo-bts when all transceivers use IPAC_PROTO_RSL_TRX0. +# Enables patching of IPA stream ID. TODO: remove as soon as we make a new release. +if [ "$IMAGE_SUFFIX" = "latest" ]; then + sed "s/RSL_Emulation.mp_rslem_patch_ipa_cid := false/RSL_Emulation.mp_rslem_patch_ipa_cid := true/g" -i \ + "$VOL_BASE_DIR/bts-tester/BTS_Tests.cfg" +fi + mkdir $VOL_BASE_DIR/bsc cp osmo-bsc.cfg $VOL_BASE_DIR/bsc/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9d76acc717f5aafbfbecafb30160b02486d341fd Gerrit-Change-Number: 18743 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: fix latest: enable IPA stream ID patching
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18743 ) Change subject: ttcn3-bts-test/jenkins.sh: fix latest: enable IPA stream ID patching .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9d76acc717f5aafbfbecafb30160b02486d341fd Gerrit-Change-Number: 18743 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 14:30:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: library/RSL_Emulation: optional IPA stream ID patching
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18741 )
Change subject: library/RSL_Emulation: optional IPA stream ID patching
..
library/RSL_Emulation: optional IPA stream ID patching
Unfortunately, the latest release of osmo-bts still has a bug,
that has been fixed [1] in the recent master. Because of that,
most of the test cases in ttcn3-bts-test-latest currently fail.
The problem is that all transceivers use IPAC_PROTO_RSL_TRX0,
regardless of what the BSC tells them to use. Let's work this
around by patching IPA stream ID in ASP_RSL_Unitdata messages
coming from the IPA emulation.
[1] I5927f59a49724170a63e87be604973f7c9d5d8be
Change-Id: I66cecc9ea24ba79e1a03492e3fda2874951d37a0
---
M library/RSL_Emulation.ttcn
1 file changed, 25 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Verified
pespin: Looks good to me, approved
diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index 9a07417..bb11340 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -35,6 +35,12 @@
import from IPA_Emulation all;
+modulepar {
+ /* Work around switch for ttcn3-bts-test-latest, enables patching of IPA
+* stream ID in the "BSC" mode. See
I5927f59a49724170a63e87be604973f7c9d5d8be. */
+ boolean mp_rslem_patch_ipa_cid := false;
+};
+
/* General "base class" component definition, of which specific implementations
* derive themselves by means of the "extends" feature */
type component RSL_DchanHdlr {
@@ -396,6 +402,19 @@
return TrxConnMap[trx_nr];
}
+/* Work around for a bug in osmo-bts when all transceivers use
IPAC_PROTO_RSL_TRX0 */
+private function f_trx_conn_map_patch_ud(inout ASP_RSL_Unitdata ud)
+runs on RSL_Emulation_CT {
+ for (var integer i := 0; i < sizeof(TrxConnMap); i := i + 1) {
+ if (ud.conn_id == TrxConnMap[i]) {
+ ud.streamId := f_streamId_by_trx(i);
+ return; /* We're done */
+ }
+ }
+
+ testcase.stop("Failed to patch IPA stream ID in ASP RSL UD: ", ud);
+}
+
type component RSL_Emulation_CT {
/* port facing down towards IPA emulation */
port IPA_RSL_PT IPA_PT;
@@ -537,11 +556,17 @@
/* Forward common channel management to the special port for it
*/
[] IPA_PT.receive(tr_ASP_RSL_UD(tr_RSL_MsgTypeT(?), sid := ?))
-> value rx_rsl {
+ if (not bts_role and mp_rslem_patch_ipa_cid) {
+ f_trx_conn_map_patch_ud(rx_rsl);
+ }
CCHAN_PT.send(rx_rsl);
}
/* Forward common channel management to the special port for it
*/
[] IPA_PT.receive(tr_ASP_RSL_UD(tr_RSL_MsgTypeC(?), sid := ?))
-> value rx_rsl {
+ if (not bts_role and mp_rslem_patch_ipa_cid) {
+ f_trx_conn_map_patch_ud(rx_rsl);
+ }
CCHAN_PT.send(rx_rsl);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18741
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I66cecc9ea24ba79e1a03492e3fda2874951d37a0
Gerrit-Change-Number: 18741
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/18644 to look at the new patch set (#4). Change subject: osmo-mgw: refactor endpoint and trunk handling .. osmo-mgw: refactor endpoint and trunk handling The trunk and endpoint handling in osmo-mgw is still very complex and implemented in various places (mostly mgcp_protocol.c). Also we use still integers for endpoint identification, which is not flexible enough to address timeslots/subslots on an E1 trunk. Some refactoring is needed. - get rid of integers as endpoint identifiers, use strings instead and find the endpoint based on its string name on the trunk. - identify the trunk based on the trunk prefix given in the endpoint name. - refactor trunk and endpoint allocation. Aggregate functionality in in mgcp_endp.c and mgcp_trunk.c. Also remove non-reusable code that relates to the still exisiting, but unfinished E1 trunk support. - refactor rate counters, put them into a separate module and do no longer allocate them per trunk. Allocate them globally instead. Change-Id: Ia8cf4d6caf05a4e13f1f507dc68cbabb7e6239aa Related: OS#2659 --- M include/osmocom/mgcp/Makefile.am M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_common.h M include/osmocom/mgcp/mgcp_endp.h M include/osmocom/mgcp/mgcp_internal.h A include/osmocom/mgcp/mgcp_ratectr.h A include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/Makefile.am M src/libosmo-mgcp/mgcp_codec.c M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_msg.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_osmux.c M src/libosmo-mgcp/mgcp_protocol.c A src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_sdp.c A src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c 21 files changed, 903 insertions(+), 629 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/44/18644/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia8cf4d6caf05a4e13f1f507dc68cbabb7e6239aa Gerrit-Change-Number: 18644 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: endp: add name generator function for E1 endpoints
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-mgw/+/18745 )
Change subject: endp: add name generator function for E1 endpoints
..
endp: add name generator function for E1 endpoints
Currently the endpoint name that is generated for an E1 endpoint is not
correct. Lets add an endpoint name generator function that derives a
full endpoint name for a given E1 index
Change-Id: I70e0c3f96aa3947165f992815ee5614c8f57
Related: OS#2547
---
M src/libosmo-mgcp/mgcp_endp.c
1 file changed, 23 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/45/18745/1
diff --git a/src/libosmo-mgcp/mgcp_endp.c b/src/libosmo-mgcp/mgcp_endp.c
index e357010..0eeda08 100644
--- a/src/libosmo-mgcp/mgcp_endp.c
+++ b/src/libosmo-mgcp/mgcp_endp.c
@@ -41,6 +41,26 @@
MGCP_ENDPOINT_PREFIX_VIRTUAL_TRUNK, index, domain);
}
+/* Generate E1 endpoint name from given numeric parameters */
+static void gen_e1_epname(char *epname, uint8_t trunk_nr, uint8_t ts_nr,
+ uint8_t ss_nr)
+{
+ static const uint8_t rates[] =
+ { 32, 32, 16, 16, 16, 16, 8, 8, 8, 8, 8, 8, 8, 8 };
+ static const uint8_t offsets[] =
+ { 0, 4, 0, 2, 4, 6, 0, 1, 2, 3, 4, 5, 6, 7 };
+ unsigned int rate;
+ unsigned int offset;
+
+ OSMO_ASSERT(ss_nr < sizeof(rates));
+
+ rate = rates[ss_nr];
+ offset = offsets[ss_nr];
+
+ snprintf(epname, MGCP_ENDPOINT_MAXLEN, "%s%u/s-%u/su%u-%u",
+MGCP_ENDPOINT_PREFIX_E1_TRUNK, trunk_nr, ts_nr, rate, offset);
+}
+
/*! allocate an endpoint and set default values.
* \param[in] trunk configuration
* \returns endpoint on success, NULL on failure */
@@ -64,10 +84,9 @@
gen_virtual_epname(ep_name_buf, trunk->cfg->domain, index);
break;
case MGCP_TRUNK_E1:
- /* FIXME: E1 trunk implementation is work in progress, this
endpoint
-* name is incomplete (subslots) */
- snprintf(ep_name_buf, sizeof(ep_name_buf), "%s-1/%x",
-MGCP_ENDPOINT_PREFIX_E1_TRUNK, index);
+ gen_e1_epname(ep_name_buf, trunk->trunk_nr, index / 14, index %
14);
+
+ /* FIXME: remove this message when E1 support is complete */
LOGP(DLMGCP, LOGL_FATAL, "E1 trunks not implemented!\n");
break;
default:
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18745
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I70e0c3f96aa3947165f992815ee5614c8f57
Gerrit-Change-Number: 18745
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: sysmocom/ttcn3/jenkins-run.sh: Pass confg file as cmdline
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18744 ) Change subject: sysmocom/ttcn3/jenkins-run.sh: Pass confg file as cmdline .. sysmocom/ttcn3/jenkins-run.sh: Pass confg file as cmdline Fix after recent huge refactoring. Change-Id: If0bcc9f7cb70e4ef324b3295d2174d11982a4bde --- M sysmocom/ttcn3/jenkins-run.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/44/18744/1 diff --git a/sysmocom/ttcn3/jenkins-run.sh b/sysmocom/ttcn3/jenkins-run.sh index 2bc687d..1688b88 100755 --- a/sysmocom/ttcn3/jenkins-run.sh +++ b/sysmocom/ttcn3/jenkins-run.sh @@ -44,7 +44,7 @@ # jenkins build job. # On failure, first clean up below and then return the exit code. exit_code="1" -if python3 -u "$(which osmo-gsm-tester.py)" "$trial_dir" $OSMO_GSM_TESTER_OPTS ; then +if python3 -u "$(which osmo-gsm-tester.py)" -c "$OSMO_GSM_TESTER_CONF" "$trial_dir" $OSMO_GSM_TESTER_OPTS ; then exit_code="0" fi -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: If0bcc9f7cb70e4ef324b3295d2174d11982a4bde Gerrit-Change-Number: 18744 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: Fix ttcn3 testsuites after recent refactors
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18742 )
Change subject: Fix ttcn3 testsuites after recent refactors
..
Fix ttcn3 testsuites after recent refactors
Change-Id: I545e3141ef56980e4ef2474b990bd4e4d4c21322
---
M sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
M sysmocom/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
b/sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
index 0eceef7..f0e8667 100644
--- a/sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
+++ b/sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
@@ -4,13 +4,13 @@
from osmo_gsm_tester.testenv import *
-def run_ttcn3(tenv, test_obj, testdir, bts, osmocon, nat_rsl_ip,
ttcn3_test_execute, ttcn3_test_extra_module_params=""):
+def run_ttcn3(tenv, testdir, bts, osmocon, nat_rsl_ip, ttcn3_test_execute,
ttcn3_test_extra_module_params=""):
own_dir = testdir
script_file = os.path.join(testdir, 'scripts', 'run_ttcn3_docker.sh')
bts_tmpl_file = os.path.join(testdir, 'scripts', 'BTS_Tests.cfg.tmpl')
-script_run_dir = test_obj.get_run_dir().new_dir('ttcn3')
+script_run_dir = tenv.test().get_run_dir().new_dir('ttcn3')
bts_cfg_file = os.path.join(str(script_run_dir), 'BTS_Tests.cfg')
-junit_ttcn3_dst_file =
os.path.join(str(tenv.suite().trial().get_run_dir()), 'trial-') +
test_obj.basename + '.xml'
+junit_ttcn3_dst_file =
os.path.join(str(tenv.suite().trial().get_run_dir()), 'trial-') +
tenv.test().basename + '.xml'
if bts.bts_type() == 'osmo-bts-trx':
pcu_available = True
pcu_sk = bts.pcu_socket_path()
diff --git a/sysmocom/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
b/sysmocom/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
index b7c5781..4382454 100755
--- a/sysmocom/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
+++ b/sysmocom/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
@@ -46,4 +46,4 @@
osmocon.start()
testdir = os.path.dirname(os.path.realpath(__file__))
-run_ttcn3(tenv. test, testdir, bts, osmocon, nat_rsl_ip, ttcn3_test_execute)
+run_ttcn3(tenv, testdir, bts, osmocon, nat_rsl_ip, ttcn3_test_execute)
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18742
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I545e3141ef56980e4ef2474b990bd4e4d4c21322
Gerrit-Change-Number: 18742
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: library/RSL_Emulation: optional IPA stream ID patching
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18741 ) Change subject: library/RSL_Emulation: optional IPA stream ID patching .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18741 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I66cecc9ea24ba79e1a03492e3fda2874951d37a0 Gerrit-Change-Number: 18741 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 14:10:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: fix latest: enable IPA stream ID patching
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18743 ) Change subject: ttcn3-bts-test/jenkins.sh: fix latest: enable IPA stream ID patching .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9d76acc717f5aafbfbecafb30160b02486d341fd Gerrit-Change-Number: 18743 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 14:10:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: fix latest: enable IPA stream ID patching
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/docker-playground/+/18743 ) Change subject: ttcn3-bts-test/jenkins.sh: fix latest: enable IPA stream ID patching .. ttcn3-bts-test/jenkins.sh: fix latest: enable IPA stream ID patching Change-Id: I9d76acc717f5aafbfbecafb30160b02486d341fd Depends: I66cecc9ea24ba79e1a03492e3fda2874951d37a0 --- M ttcn3-bts-test/BTS_Tests.cfg M ttcn3-bts-test/jenkins.sh 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/43/18743/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9d76acc717f5aafbfbecafb30160b02486d341fd Gerrit-Change-Number: 18743 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-MessageType: newpatchset
Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: fix latest: enable IPA stream ID patching
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/18743 ) Change subject: ttcn3-bts-test/jenkins.sh: fix latest: enable IPA stream ID patching .. ttcn3-bts-test/jenkins.sh: fix latest: enable IPA stream ID patching Change-Id: I9d76acc717f5aafbfbecafb30160b02486d341fd Depends: I66cecc9ea24ba79e1a03492e3fda2874951d37a0 --- M ttcn3-bts-test/jenkins.sh 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/43/18743/1 diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 0d0473b..20ad748 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -99,6 +99,13 @@ mkdir $VOL_BASE_DIR/bts-tester/unix cp BTS_Tests.cfg $VOL_BASE_DIR/bts-tester/ +# Work around for a bug in osmo-bts when all transceivers use IPAC_PROTO_RSL_TRX0. +# Enables patching of IPA stream ID. TODO: remove as soon as we make a new release. +if [ "$IMAGE_SUFFIX" = "latest" ]; then + sed "s/RSL_Emulation.mp_rslem_patch_ipa_cid := false/RSL_Emulation.mp_rslem_patch_ipa_cid := true/g" -i \ + "$VOL_BASE_DIR/bts-tester/BTS_Tests.cfg" +fi + mkdir $VOL_BASE_DIR/bsc cp osmo-bsc.cfg $VOL_BASE_DIR/bsc/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9d76acc717f5aafbfbecafb30160b02486d341fd Gerrit-Change-Number: 18743 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: Fix ttcn3 testsuites after recent refactors
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18742 )
Change subject: Fix ttcn3 testsuites after recent refactors
..
Fix ttcn3 testsuites after recent refactors
Change-Id: I545e3141ef56980e4ef2474b990bd4e4d4c21322
---
M sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
M sysmocom/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/42/18742/1
diff --git a/sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
b/sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
index 0eceef7..f0e8667 100644
--- a/sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
+++ b/sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
@@ -4,13 +4,13 @@
from osmo_gsm_tester.testenv import *
-def run_ttcn3(tenv, test_obj, testdir, bts, osmocon, nat_rsl_ip,
ttcn3_test_execute, ttcn3_test_extra_module_params=""):
+def run_ttcn3(tenv, testdir, bts, osmocon, nat_rsl_ip, ttcn3_test_execute,
ttcn3_test_extra_module_params=""):
own_dir = testdir
script_file = os.path.join(testdir, 'scripts', 'run_ttcn3_docker.sh')
bts_tmpl_file = os.path.join(testdir, 'scripts', 'BTS_Tests.cfg.tmpl')
-script_run_dir = test_obj.get_run_dir().new_dir('ttcn3')
+script_run_dir = tenv.test().get_run_dir().new_dir('ttcn3')
bts_cfg_file = os.path.join(str(script_run_dir), 'BTS_Tests.cfg')
-junit_ttcn3_dst_file =
os.path.join(str(tenv.suite().trial().get_run_dir()), 'trial-') +
test_obj.basename + '.xml'
+junit_ttcn3_dst_file =
os.path.join(str(tenv.suite().trial().get_run_dir()), 'trial-') +
tenv.test().basename + '.xml'
if bts.bts_type() == 'osmo-bts-trx':
pcu_available = True
pcu_sk = bts.pcu_socket_path()
diff --git a/sysmocom/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
b/sysmocom/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
index b7c5781..4382454 100755
--- a/sysmocom/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
+++ b/sysmocom/ttcn3/suites/ttcn3_bts_tests/ttcn3_bts_tests.py
@@ -46,4 +46,4 @@
osmocon.start()
testdir = os.path.dirname(os.path.realpath(__file__))
-run_ttcn3(tenv. test, testdir, bts, osmocon, nat_rsl_ip, ttcn3_test_execute)
+run_ttcn3(tenv, testdir, bts, osmocon, nat_rsl_ip, ttcn3_test_execute)
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18742
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I545e3141ef56980e4ef2474b990bd4e4d4c21322
Gerrit-Change-Number: 18742
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: Fix ttcn3 testsuites after recent refactors
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18742 ) Change subject: Fix ttcn3 testsuites after recent refactors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18742 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I545e3141ef56980e4ef2474b990bd4e4d4c21322 Gerrit-Change-Number: 18742 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 09 Jun 2020 13:59:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18644 ) Change subject: osmo-mgw: refactor endpoint and trunk handling .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/18644/3/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18644/3/src/libosmo-mgcp/mgcp_endp.c@59 PS3, Line 59: /* FIXME: E1 trunk implementation is work in progress, this endpoint I'm not sure this simplification of only passing 1 index is going to be enough to describing the E1 endp, but I may be wrong. Did you think about that? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia8cf4d6caf05a4e13f1f507dc68cbabb7e6239aa Gerrit-Change-Number: 18644 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 13:56:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: library/RSL_Emulation: optional IPA stream ID patching
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18741 ) Change subject: library/RSL_Emulation: optional IPA stream ID patching .. Patch Set 1: Verified+1 Makes ttcn3-bts-test-latest happy on my machine. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18741 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I66cecc9ea24ba79e1a03492e3fda2874951d37a0 Gerrit-Change-Number: 18741 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 13:55:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18740 ) Change subject: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/18740/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/18740/2//COMMIT_MSG@14 PS2, Line 14: edded to the message typo: added https://gerrit.osmocom.org/c/osmo-msc/+/18740/2/src/libmsc/msc_ho.c File src/libmsc/msc_ho.c: https://gerrit.osmocom.org/c/osmo-msc/+/18740/2/src/libmsc/msc_ho.c@406 PS2, Line 406: .call_id = cc_trans->callref, NO .call_id_present = true here? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6b1b55b3f5a3092d9557dc2512020c766a9ff744 Gerrit-Change-Number: 18740 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 13:54:44 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/18644 to look at the new patch set (#3). Change subject: osmo-mgw: refactor endpoint and trunk handling .. osmo-mgw: refactor endpoint and trunk handling The trunk and endpoint handling in osmo-mgw is still very complex and implemented in various places (mostly mgcp_protocol.c). Also we use still integers for endpoint identification, which is not flexible enough to address timeslots/subslots on an E1 trunk. Some refactoring is needed. - get rid of integers as endpoint identifiers, use strings instead and find the endpoint based on its string name on the trunk. - identify the trunk based on the trunk prefix given in the endpoint name. - refactor trunk and endpoint allocation. Aggregate functionality in in mgcp_endp.c and mgcp_trunk.c. Also remove non-reusable code that relates to the still exisiting, but unfinished E1 trunk support. - refactor rate counters, put them into a separate module and do no longer allocate them per trunk. Allocate them globally instead. Change-Id: Ia8cf4d6caf05a4e13f1f507dc68cbabb7e6239aa Related: OS#2659 --- M include/osmocom/mgcp/Makefile.am M include/osmocom/mgcp/mgcp.h M include/osmocom/mgcp/mgcp_common.h M include/osmocom/mgcp/mgcp_endp.h M include/osmocom/mgcp/mgcp_internal.h A include/osmocom/mgcp/mgcp_ratectr.h A include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/Makefile.am M src/libosmo-mgcp/mgcp_codec.c M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_msg.c M src/libosmo-mgcp/mgcp_network.c M src/libosmo-mgcp/mgcp_osmux.c M src/libosmo-mgcp/mgcp_protocol.c A src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_sdp.c A src/libosmo-mgcp/mgcp_trunk.c M src/libosmo-mgcp/mgcp_vty.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c 21 files changed, 893 insertions(+), 629 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/44/18644/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia8cf4d6caf05a4e13f1f507dc68cbabb7e6239aa Gerrit-Change-Number: 18644 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: library/RSL_Emulation: optional IPA stream ID patching
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18741 )
Change subject: library/RSL_Emulation: optional IPA stream ID patching
..
library/RSL_Emulation: optional IPA stream ID patching
Unfortunately, the latest release of osmo-bts still has a bug,
that has been fixed [1] in the recent master. Because of that,
most of the test cases in ttcn3-bts-test-latest currently fail.
The problem is that all transceivers use IPAC_PROTO_RSL_TRX0,
regardless of what the BSC tells them to use. Let's work this
around by patching IPA stream ID in ASP_RSL_Unitdata messages
coming from the IPA emulation.
[1] I5927f59a49724170a63e87be604973f7c9d5d8be
Change-Id: I66cecc9ea24ba79e1a03492e3fda2874951d37a0
---
M library/RSL_Emulation.ttcn
1 file changed, 25 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/41/18741/1
diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index 9a07417..bb11340 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -35,6 +35,12 @@
import from IPA_Emulation all;
+modulepar {
+ /* Work around switch for ttcn3-bts-test-latest, enables patching of IPA
+* stream ID in the "BSC" mode. See
I5927f59a49724170a63e87be604973f7c9d5d8be. */
+ boolean mp_rslem_patch_ipa_cid := false;
+};
+
/* General "base class" component definition, of which specific implementations
* derive themselves by means of the "extends" feature */
type component RSL_DchanHdlr {
@@ -396,6 +402,19 @@
return TrxConnMap[trx_nr];
}
+/* Work around for a bug in osmo-bts when all transceivers use
IPAC_PROTO_RSL_TRX0 */
+private function f_trx_conn_map_patch_ud(inout ASP_RSL_Unitdata ud)
+runs on RSL_Emulation_CT {
+ for (var integer i := 0; i < sizeof(TrxConnMap); i := i + 1) {
+ if (ud.conn_id == TrxConnMap[i]) {
+ ud.streamId := f_streamId_by_trx(i);
+ return; /* We're done */
+ }
+ }
+
+ testcase.stop("Failed to patch IPA stream ID in ASP RSL UD: ", ud);
+}
+
type component RSL_Emulation_CT {
/* port facing down towards IPA emulation */
port IPA_RSL_PT IPA_PT;
@@ -537,11 +556,17 @@
/* Forward common channel management to the special port for it
*/
[] IPA_PT.receive(tr_ASP_RSL_UD(tr_RSL_MsgTypeT(?), sid := ?))
-> value rx_rsl {
+ if (not bts_role and mp_rslem_patch_ipa_cid) {
+ f_trx_conn_map_patch_ud(rx_rsl);
+ }
CCHAN_PT.send(rx_rsl);
}
/* Forward common channel management to the special port for it
*/
[] IPA_PT.receive(tr_ASP_RSL_UD(tr_RSL_MsgTypeC(?), sid := ?))
-> value rx_rsl {
+ if (not bts_role and mp_rslem_patch_ipa_cid) {
+ f_trx_conn_map_patch_ud(rx_rsl);
+ }
CCHAN_PT.send(rx_rsl);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18741
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I66cecc9ea24ba79e1a03492e3fda2874951d37a0
Gerrit-Change-Number: 18741
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-msc[master]: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/18740 to look at the new patch set (#2). Change subject: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST .. msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST When msc_ho_send_handover_request() generates the HANDOVER REQUEST message, it does not populate the call_id struct member. In ran_msg_a.c the struct member call_id is used, but the call_id_present flag is not set, which also prevents the call_id being edded to the message Change-Id: I6b1b55b3f5a3092d9557dc2512020c766a9ff744 Related: OS#4582 --- M src/libmsc/msc_ho.c M src/libmsc/ran_msg_a.c 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/18740/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6b1b55b3f5a3092d9557dc2512020c766a9ff744 Gerrit-Change-Number: 18740 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-msc[master]: msc_a: add callref as call id to ASSIGNMENT REQ.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18692 ) Change subject: msc_a: add callref as call id to ASSIGNMENT REQ. .. Patch Set 2: (2 comments) > Patch Set 1: > > I would prefer to merge the addition of this IE to all relevant messages (I > wrote it in the osmcoom issue), but if you prefer we can also do one commit > per command - but let's make sure we don't forget about other messages > besides ASSIGNMENT CMD I was having a look at the other messages now, I think its better to do it in separate commits. https://gerrit.osmocom.org/c/osmo-msc/+/18692/1/src/libmsc/msc_a.c File src/libmsc/msc_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/18692/1/src/libmsc/msc_a.c@544 PS1, Line 544: call_id_present = true, : .call_id = cc_trans->callref > you are adding it unconditionally here. If we only support AoIP, we can do > this unconditionally. […] I think the sccplite support was only in the BSC. I have put it as an optional field because the spec has it optional, but in the end I think that hardcoding the presence flag everywhere in the end is also not a good idea. https://gerrit.osmocom.org/c/osmo-msc/+/18692/1/src/libmsc/ran_msg_a.c File src/libmsc/ran_msg_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/18692/1/src/libmsc/ran_msg_a.c@1000 PS1, Line 1000: if(ac->call_id_present) > if if was a function... […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4288f47e4a6d61ec672f431723f6e72c7c6b0799 Gerrit-Change-Number: 18692 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 09 Jun 2020 12:51:01 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in osmo-msc[master]: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-msc/+/18740 )
Change subject: msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST
..
msc_ho: fix CALL IDENTIFIER in HANDOVER REQUEST
When msc_ho_send_handover_request() generates the HANDOVER REQUEST
message, it does not populate the call_id struct member.
In ran_msg_a.c the struct member call_id is used, but the
call_id_present flag is not set, which also prevents the call_id being
edded to the message
Change-Id: I6b1b55b3f5a3092d9557dc2512020c766a9ff744
---
M src/libmsc/msc_ho.c
M src/libmsc/ran_msg_a.c
2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/18740/1
diff --git a/src/libmsc/msc_ho.c b/src/libmsc/msc_ho.c
index aa513eb..2422703 100644
--- a/src/libmsc/msc_ho.c
+++ b/src/libmsc/msc_ho.c
@@ -383,6 +383,7 @@
struct vlr_subscr *vsub = msc_a_vsub(msc_a);
struct gsm_network *net = msc_a_net(msc_a);
struct gsm0808_channel_type channel_type;
+ struct gsm_trans *cc_trans = msc_a->cc.active_trans;
struct ran_msg ran_enc_msg = {
.msg_type = RAN_MSG_HANDOVER_REQUEST,
.handover_request = {
@@ -402,6 +403,7 @@
/* Don't send AoIP Transport Layer Address for
inter-MSC Handover */
.rtp_ran_local = (msc_a->ho.new_cell.type ==
MSC_NEIGHBOR_TYPE_LOCAL_RAN_PEER)
? call_leg_local_ip(msc_a->cc.call_leg,
RTP_TO_RAN) : NULL,
+ .call_id = cc_trans->callref,
},
};
diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c
index 667e758..6e5e7da 100644
--- a/src/libmsc/ran_msg_a.c
+++ b/src/libmsc/ran_msg_a.c
@@ -1117,6 +1117,7 @@
.imsi = n->imsi,
.codec_list_msc_preferred = n->codec_list_msc_preferred,
+ .call_id_present = true,
.call_id = n->call_id,
.global_call_reference = n->global_call_reference,
.global_call_reference_len = n->global_call_reference_len,
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18740
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I6b1b55b3f5a3092d9557dc2512020c766a9ff744
Gerrit-Change-Number: 18740
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
Change in osmo-ci[master]: jobs: osmo-gsm-tester: Run mass LU and ttcn3 BTS tests nightly
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/18739 ) Change subject: jobs: osmo-gsm-tester: Run mass LU and ttcn3 BTS tests nightly .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/18739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie42fc1e686d29740e14aaacd69659fe09e66801a Gerrit-Change-Number: 18739 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 12:33:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ci[master]: jobs: osmo-gsm-tester: Run mass LU and ttcn3 BTS tests nightly
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/18739 ) Change subject: jobs: osmo-gsm-tester: Run mass LU and ttcn3 BTS tests nightly .. jobs: osmo-gsm-tester: Run mass LU and ttcn3 BTS tests nightly Before they were executed almost in a loop, so let's simply run them once per day. Change-Id: Ie42fc1e686d29740e14aaacd69659fe09e66801a --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/39/18739/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 041ef93..4cdd383 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -187,9 +187,7 @@ scm: - 'osmo-gsm-tester-repo' triggers: - - timed: "H H/2 * * *" - - pollscm: - cron: "H/5 * * * *" + - timed: "H 23 * * *" builders: - shell: | # make sure no bin artifacts from a previous run remain @@ -214,9 +212,7 @@ scm: - 'osmo-gsm-tester-repo' triggers: - - timed: "H H/2 * * *" - - pollscm: - cron: "H/5 * * * *" + - timed: "H 22 * * *" builders: - shell: | # make sure no bin artifacts from a previous run remain -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/18739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie42fc1e686d29740e14aaacd69659fe09e66801a Gerrit-Change-Number: 18739 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in osmo-ci[master]: jobs: osmo-gsm-tester_ttcn3: Fix path to jenkins script
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/18738 ) Change subject: jobs: osmo-gsm-tester_ttcn3: Fix path to jenkins script .. jobs: osmo-gsm-tester_ttcn3: Fix path to jenkins script There was a directry refactoring a few weeks ago in osmo-gsm-tester and this path was not updated correctly. Change-Id: I580cd9d4a602b3ed1839fb0990ac3816c5e42cbe --- M jobs/osmo-gsm-tester_ttcn3.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/38/18738/1 diff --git a/jobs/osmo-gsm-tester_ttcn3.sh b/jobs/osmo-gsm-tester_ttcn3.sh index c844d22..767cafb 100644 --- a/jobs/osmo-gsm-tester_ttcn3.sh +++ b/jobs/osmo-gsm-tester_ttcn3.sh @@ -11,4 +11,4 @@ ln -s resources.conf.prod osmo-gsm-tester/sysmocom/ttcn3/resources.conf PATH="$PWD/osmo-gsm-tester/src:$PATH" \ - ./osmo-gsm-tester/ttcn3/jenkins-run.sh + ./osmo-gsm-tester/sysmocom/ttcn3/jenkins-run.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/18738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I580cd9d4a602b3ed1839fb0990ac3816c5e42cbe Gerrit-Change-Number: 18738 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in osmo-ci[master]: jobs: osmo-gsm-tester_ttcn3: Fix path to jenkins script
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/18738 ) Change subject: jobs: osmo-gsm-tester_ttcn3: Fix path to jenkins script .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/18738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I580cd9d4a602b3ed1839fb0990ac3816c5e42cbe Gerrit-Change-Number: 18738 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 12:11:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ci[master]: jobs: osmo-gsm-tester_ttcn3: Fix path to jenkins script
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/18738 ) Change subject: jobs: osmo-gsm-tester_ttcn3: Fix path to jenkins script .. jobs: osmo-gsm-tester_ttcn3: Fix path to jenkins script There was a directry refactoring a few weeks ago in osmo-gsm-tester and this path was not updated correctly. Change-Id: I580cd9d4a602b3ed1839fb0990ac3816c5e42cbe --- M jobs/osmo-gsm-tester_ttcn3.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/jobs/osmo-gsm-tester_ttcn3.sh b/jobs/osmo-gsm-tester_ttcn3.sh index c844d22..767cafb 100644 --- a/jobs/osmo-gsm-tester_ttcn3.sh +++ b/jobs/osmo-gsm-tester_ttcn3.sh @@ -11,4 +11,4 @@ ln -s resources.conf.prod osmo-gsm-tester/sysmocom/ttcn3/resources.conf PATH="$PWD/osmo-gsm-tester/src:$PATH" \ - ./osmo-gsm-tester/ttcn3/jenkins-run.sh + ./osmo-gsm-tester/sysmocom/ttcn3/jenkins-run.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/18738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I580cd9d4a602b3ed1839fb0990ac3816c5e42cbe Gerrit-Change-Number: 18738 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-bsc[master]: abis_rsl: Count successful channel requests
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18719 ) Change subject: abis_rsl: Count successful channel requests .. Patch Set 1: Code-Review+1 I am sort-of undecided if this coulnter should be in the function that transmits an immediate assignment. In the end, it is about successful processing of a channel request. Yes, in reality, and particularly in the current code those two are the same. However, I'm not sure if e.g. it would make sense at some point to re-transmit immediate assignments? Or what about the immediate assignment without paging that the PCU does for tbf establishment in some states? It maybe doesn't go thorugh this code path, but I'm trying to express why it feels a bit odd to me. I'm not convinced it's much better inside the lchan_fsm where rsl_tx_imm_assignment() is called. So maybe just leave it as-is but maybe put a comment on top explaining why we - at least so far - count here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c51956569223e802f4789dc5ed1605d18f80aea Gerrit-Change-Number: 18719 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 11:05:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: osmo-bsc: Use designated initializer in bts_stat_desc
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18718 ) Change subject: osmo-bsc: Use designated initializer in bts_stat_desc .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic29f3a7e6fb16955bc74cc163d45a243b373183a Gerrit-Change-Number: 18718 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 11:01:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-trx: Change default for clock_advance to 3
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17766 ) Change subject: osmo-bts-trx: Change default for clock_advance to 3 .. Patch Set 1: would be good to move this ahead. It's a relatively simple but very important improvement -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7da3d0948f38e12342fb714b29f8edc5e9d0933d Gerrit-Change-Number: 17766 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 11:00:10 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: gsm0808: fix endieness of call identifier
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/18694 )
Change subject: gsm0808: fix endieness of call identifier
..
gsm0808: fix endieness of call identifier
The call identifier in the ASSIGNMENT COMMAND is encoded in the wrong
endieness. 3GPP TS 48.008, section 3.2.2.105 specifies that the least
significant byte should be transmitted first, which means that the
endieness here is little endian. Lets make sure that the endieness is
correctly transmitted, regardless of the host byte order.
Change-Id: I6468e502f552f99ab54aec9d4b1c169fdc0adfb8
Related: OS#4582
---
M src/gsm/gsm0808.c
M tests/gsm0808/gsm0808_test.c
2 files changed, 14 insertions(+), 4 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 23468c3..9fdf379 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -24,6 +24,7 @@
#include
#include
+#include
#include
#include
#include
@@ -515,7 +516,16 @@
/* AoIP: Call Identifier 3.2.2.105 */
if (ci) {
- ci_sw = osmo_htonl(*ci);
+ /* NOTE: 3GPP TS 48.008, section 3.2.2.105 specifies that
+ the least significant byte should be transmitted first.
+ On x86, this would mean that the endieness is already
+ correct, however a platform independed implementation
+ is required: */
+#ifndef OSMO_IS_LITTLE_ENDIAN
+ ci_sw = osmo_swab32(*ci);
+#else
+ ci_sw = *ci;
+#endif
msgb_tv_fixed_put(msg, GSM0808_IE_CALL_ID, sizeof(ci_sw),
(uint8_t *) & ci_sw);
}
diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c
index d9640aa..5c1a931 100644
--- a/tests/gsm0808/gsm0808_test.c
+++ b/tests/gsm0808/gsm0808_test.c
@@ -438,8 +438,8 @@
0x04, GSM0808_IE_AOIP_TRASP_ADDR, 0x06, 0xc0, 0xa8, 0x64, 0x17,
0x04, 0xd2, GSM0808_IE_SPEECH_CODEC_LIST, 0x07,
GSM0808_SCT_FR3 | 0x50, 0xef, 0xcd, GSM0808_SCT_FR2 | 0xa0, 0x9f,
- GSM0808_SCT_CSD | 0x90, 0xc0, GSM0808_IE_CALL_ID, 0xaa, 0xbb,
- 0xcc, 0xdd };
+ GSM0808_SCT_CSD | 0x90, 0xc0, GSM0808_IE_CALL_ID, 0xdd, 0xcc,
+ 0xbb, 0xaa };
struct msgb *msg;
struct gsm0808_channel_type ct;
@@ -499,7 +499,7 @@
GSM0808_SCT_CSD | 0x90,
0xc0,
GSM0808_IE_CALL_ID,
- 0xde, 0xad, 0xfa, 0xce, /* CallID */
+ 0xce, 0xfa, 0xad, 0xde, /* CallID */
0x83, 0x45, 0x45, 0x45, 0x45, 0x45, 0x45, 0x45, 0x45, 0x45,
0x45, 0x45, 0x45, 0x45, 0x45, 0x45, 0x45, /* Kc */
GSM0808_IE_GLOBAL_CALL_REF, 0x0d, /* GCR, length */
0x03, 0x44, 0x44, 0x44, /* GCR, Net ID */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18694
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6468e502f552f99ab54aec9d4b1c169fdc0adfb8
Gerrit-Change-Number: 18694
Gerrit-PatchSet: 4
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: gsm0808: fix endieness of call identifier
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18694 ) Change subject: gsm0808: fix endieness of call identifier .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6468e502f552f99ab54aec9d4b1c169fdc0adfb8 Gerrit-Change-Number: 18694 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 10:57:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: UHDDevice: Implement getNominalTxPower() based on TxFrequency
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18721 ) Change subject: UHDDevice: Implement getNominalTxPower() based on TxFrequency .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If7ef5bf95ffe4afe5864c0f051853aa38b9639eb Gerrit-Change-Number: 18721 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jun 2020 10:56:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in pysim[master]: utils.py add LOCI EFs decode functions
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18737 ) Change subject: utils.py add LOCI EFs decode functions .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibb513ff7d1dc6d33b354ae26cbd9c390ea3c8efc Gerrit-Change-Number: 18737 Gerrit-PatchSet: 2 Gerrit-Owner: gui...@gmail.com Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jun 2020 10:56:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch
pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18655 ) Change subject: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch .. ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch The test mentioned above is added in osmo-ttcn3-hacks.git Ieb7444c6312bbeab64da2732393b3facf3e1f003. config files are updated to make sense: * "nominal power" in osmo-bsc.cfg reflects correct default nominal tx power of fake_trx. * "osmotrx tx-attenuation" in osmo-bts.cfg is removed to let osmo-bts use the value received through OML (max_power_red 20). * "power-ramp step-size" in osmo-bts.cfg is increased to speed up the test. There's no good reason to keep it lower. Change-Id: I878d329dde3d2089ee3b68f56271fcb88d210025 --- M ttcn3-bts-test/osmo-bsc.cfg M ttcn3-bts-test/osmo-bts.cfg 2 files changed, 8 insertions(+), 12 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved; Verified diff --git a/ttcn3-bts-test/osmo-bsc.cfg b/ttcn3-bts-test/osmo-bsc.cfg index 3d025c0..3064595 100644 --- a/ttcn3-bts-test/osmo-bsc.cfg +++ b/ttcn3-bts-test/osmo-bsc.cfg @@ -138,7 +138,7 @@ trx 0 rf_locked 0 arfcn 871 - nominal power 23 + nominal power 50 max_power_red 20 rsl e1 tei 0 timeslot 0 @@ -168,7 +168,7 @@ trx 1 rf_locked 0 arfcn 873 - nominal power 23 + nominal power 50 max_power_red 20 rsl e1 tei 1 timeslot 0 @@ -198,7 +198,7 @@ trx 2 rf_locked 0 arfcn 875 - nominal power 23 + nominal power 50 max_power_red 20 rsl e1 tei 2 timeslot 0 @@ -228,7 +228,7 @@ trx 3 rf_locked 0 arfcn 877 - nominal power 23 + nominal power 50 max_power_red 20 rsl e1 tei 3 timeslot 0 diff --git a/ttcn3-bts-test/osmo-bts.cfg b/ttcn3-bts-test/osmo-bts.cfg index 8ada1ba..45e491c 100644 --- a/ttcn3-bts-test/osmo-bts.cfg +++ b/ttcn3-bts-test/osmo-bts.cfg @@ -60,16 +60,12 @@ osmotrx rts-advance 5 instance 0 osmotrx rx-gain 10 - osmotrx tx-attenuation 0 instance 1 osmotrx rx-gain 10 - osmotrx tx-attenuation 0 instance 2 osmotrx rx-gain 10 - osmotrx tx-attenuation 0 instance 3 osmotrx rx-gain 10 - osmotrx tx-attenuation 0 bts 0 band DCS1800 ipa unit-id 1234 0 @@ -90,22 +86,22 @@ pcu-socket /data/unix/pcu_sock trx 0 power-ramp max-initial 0 mdBm - power-ramp step-size 2000 mdB + power-ramp step-size 8000 mdB power-ramp step-interval 1 phy 0 instance 0 trx 1 power-ramp max-initial 0 mdBm - power-ramp step-size 2000 mdB + power-ramp step-size 8000 mdB power-ramp step-interval 1 phy 0 instance 1 trx 2 power-ramp max-initial 0 mdBm - power-ramp step-size 2000 mdB + power-ramp step-size 8000 mdB power-ramp step-interval 1 phy 0 instance 2 trx 3 power-ramp max-initial 0 mdBm - power-ramp step-size 2000 mdB + power-ramp step-size 8000 mdB power-ramp step-interval 1 phy 0 instance 3 ctrl -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I878d329dde3d2089ee3b68f56271fcb88d210025 Gerrit-Change-Number: 18655 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in docker-playground[master]: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18655 ) Change subject: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I878d329dde3d2089ee3b68f56271fcb88d210025 Gerrit-Change-Number: 18655 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 10:54:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bts: Introduce test TC_tx_power_start_ramp_up_bcch
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654 )
Change subject: bts: Introduce test TC_tx_power_start_ramp_up_bcch
..
bts: Introduce test TC_tx_power_start_ramp_up_bcch
This test verifies power ramping (up) is working fine during BTS
startup.
config files are updated to make sense:
* "nominal power" in osmo-bsc.cfg reflects correct default nominal tx
power of fake_trx.
* "osmotrx tx-attenuation" in osmo-bts.cfg is removed to let osmo-bts
use the value received through OML (max_power_red 20).
* "power-ramp step-size" in osmo-bts.cfg is increased to speed up the
test. There's no good reason to keep it lower.
Change-Id: Ieb7444c6312bbeab64da2732393b3facf3e1f003
---
M bts/BTS_Tests.ttcn
M bts/osmo-bsc.cfg
M bts/osmo-bts.cfg
3 files changed, 82 insertions(+), 3 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 8a297fb..012327e 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -100,6 +100,8 @@
integer mp_rxlev_exp := 57;
integer mp_ul_rxlev_exp := 10;
integer mp_ms_power_level_exp := 7;
+ integer mp_bts_tx_nom_pwr_exp := 50; /* Expected Tx Nominal Output
Power of the BTS, in dBm */
+ integer mp_bts_tx_pwr_att_exp := 20; /* Expected Tx Power attenuation
wrt to Tx Nominal Output Power, in dB */
integer mp_ms_actual_ta_exp := 0;
integer mp_timing_offset_256syms_exp := 512;
/* Time to wait for RSL conn from BTS during startup of test */
@@ -2017,6 +2019,83 @@
f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);
}
+/* Verify Tx power reduction and ramping up during BTS bring up */
+function f_TC_tx_power_start_ramp_up_bcch(charstring id) runs on ConnHdlr {
+ var L1ctlDlMessage l1_dl;
+ f_l1_tune(L1CTL);
+ RSL.clear;
+
+ var integer initial_rx_lvl := -1;
+ var integer last_rx_lvl := -1;
+ var integer max_rx_lvl := mp_bts_tx_nom_pwr_exp - mp_bts_tx_pwr_att_exp;
+
+ timer T := 2.0;
+ alt {
+ [] L1CTL.receive(tr_L1CTL_DATA_IND(t_RslChanNr_BCCH(0), ?)) -> value
l1_dl {
+ var GsmRxLev rx_lvl := l1_dl.dl_info.rx_level;
+ log("Received rx_level=", rx_lvl);
+ if (initial_rx_lvl == -1) {
+ initial_rx_lvl := rx_lvl;
+ last_rx_lvl := rx_lvl;
+
+ /* Expect a somehow low value during first received
messages */
+ if (initial_rx_lvl >= max_rx_lvl / 2) {
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__,
fail,
+ log2str("Detected high
initial tx power during ramp up: ",
+ initial_rx_lvl
, ", full power is", max_rx_lvl));
+ }
+ }
+
+ /* received Rx level bigger than maximum allowed power by CN */
+ if (rx_lvl > max_rx_lvl) {
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
+ log2str("Detected Tx power
higher than full power: ",
+ rx_lvl , " > ",
max_rx_lvl));
+ }
+
+ /* Make sure it never decreases, since we are rumping up */
+ if (last_rx_lvl > rx_lvl) {
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
+ log2str("Detected Tx power
decrease during ramp up: ",
+ last_rx_lvl , " -> ",
rx_lvl));
+ }
+
+ if (rx_lvl == max_rx_lvl and not T.running) {
+ /* We reached the maximum power, start timer and receive
+ /* a few more to make sure we don't surpass it */
+ log("Reached full power, wating a bit more until
success");
+ T.start;
+ }
+
+ last_rx_lvl := rx_lvl;
+ repeat;
+ }
+ [] L1CTL.receive { repeat; }
+ [] T.timeout { }
+ }
+
+ /* We didn't increase tx power during ramp up */
+ if (initial_rx_lvl < last_rx_lvl) {
+ log("Tx power increased during ramp up: ", initial_rx_lvl , "
-> ", last_rx_lvl);
+ } else {
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail,
+ log2str("No Tx power increase during
whole ramp up: ",
+ initial_rx_lvl , " -> ",
last_rx_lvl));
+ }
+
+ setverdict(pass);
+}
+testcase
Change in osmo-ttcn3-hacks[master]: bts: Introduce test TC_tx_power_start_ramp_up_bcch
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654 ) Change subject: bts: Introduce test TC_tx_power_start_ramp_up_bcch .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieb7444c6312bbeab64da2732393b3facf3e1f003 Gerrit-Change-Number: 18654 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 10:54:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-trx: Re-apply tx power if nominal power is received after POWERON
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18652 ) Change subject: bts-trx: Re-apply tx power if nominal power is received after POWERON .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2ec8dba61393be6edfab9e7e478e096e2d0933ad Gerrit-Change-Number: 18652 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 10:51:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-trx: Implement power ramping during BTS bring up
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18488 ) Change subject: bts-trx: Implement power ramping during BTS bring up .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia7c353e4c199e0fc3bcab55c45a4abda2c66d2c1 Gerrit-Change-Number: 18488 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Tue, 09 Jun 2020 10:49:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gsm0808: fix endieness of call identifier
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18694 ) Change subject: gsm0808: fix endieness of call identifier .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6468e502f552f99ab54aec9d4b1c169fdc0adfb8 Gerrit-Change-Number: 18694 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 10:40:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gsm0808: fix endieness of call identifier
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/18694 to look at the new patch set (#4). Change subject: gsm0808: fix endieness of call identifier .. gsm0808: fix endieness of call identifier The call identifier in the ASSIGNMENT COMMAND is encoded in the wrong endieness. 3GPP TS 48.008, section 3.2.2.105 specifies that the least significant byte should be transmitted first, which means that the endieness here is little endian. Lets make sure that the endieness is correctly transmitted, regardless of the host byte order. Change-Id: I6468e502f552f99ab54aec9d4b1c169fdc0adfb8 Related: OS#4582 --- M src/gsm/gsm0808.c M tests/gsm0808/gsm0808_test.c 2 files changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/18694/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6468e502f552f99ab54aec9d4b1c169fdc0adfb8 Gerrit-Change-Number: 18694 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: bts: Introduce test TC_tx_power_start_ramp_up_bcch
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654 ) Change subject: bts: Introduce test TC_tx_power_start_ramp_up_bcch .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieb7444c6312bbeab64da2732393b3facf3e1f003 Gerrit-Change-Number: 18654 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 10:22:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18655 ) Change subject: ttcn3-bts: Update cfg for test TC_tx_power_start_ramp_up_bcch .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I878d329dde3d2089ee3b68f56271fcb88d210025 Gerrit-Change-Number: 18655 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jun 2020 10:09:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: NS: Optionally disable NS-{RESET, BLOCK, UNBLOCK} when using UDP/IP
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/18706 )
Change subject: NS: Optionally disable NS-{RESET,BLOCK,UNBLOCK} when using
UDP/IP
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/18706/2/src/gb/gprs_ns_vty.c
File src/gb/gprs_ns_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/18706/2/src/gb/gprs_ns_vty.c@517
PS2, Line 517: vty_nsi->nsip.use_reset_block_unblock = true;
> that returns a positive/negative integer, I prefer to keep it explicit. […]
Ok, but << !strcmp(argv[0], "enabled") >> doesn't return a negative/positive
integer, since you are applying a boolean operator, it will return either 0 or
(NOT 0), which is going to be 1, so one can assume false/true values.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18706
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic4eba1b4dcbeac00f5879db295e0a9f1a50f71d8
Gerrit-Change-Number: 18706
Gerrit-PatchSet: 3
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Tue, 09 Jun 2020 09:55:40 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Comment-In-Reply-To: laforge
Gerrit-MessageType: comment
Change in osmo-trx[master]: UHDDevice: Compute TxGain on UHD API based on expected Tx output power
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18723 ) Change subject: UHDDevice: Compute TxGain on UHD API based on expected Tx output power .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/18723/2/Transceiver52M/device/uhd/UHDDevice.cpp File Transceiver52M/device/uhd/UHDDevice.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/18723/2/Transceiver52M/device/uhd/UHDDevice.cpp@216 PS2, Line 216: tx_gain_db > if you subtract something from gain, then it is attenuation. […] AFAIU power attenuation is what you subtract from power to attenuate it, giving a lower power (attenuated power). So here I'm basically first getting an attenuation by getting the difference between 2 gain values (as in how much do you need to attenuate the nominal UHD Tx Gain to get to the required UHD gain): att = (desc.nom_uhd_tx_gain - tx_gain_db) Then I'm simply applying that attenuation to get nominal output Tx power (assuming slope is 1:1 with UHD tx Gain values here), by which I get and return an attenuated power: return desc.nom_out_tx_power - att; I'm happy to change any terminology you feel it's more clear. That's what I'm also trying to do in this commit by also decoupling UHD Tx Gain (internal/implementation specific to the radiODevice class) and the real output power (the one the upper layers are interested in). -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6f432465dce5c6ec1f1bc4653f6149efb18c3f43 Gerrit-Change-Number: 18723 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 09 Jun 2020 09:51:05 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in osmo-trx[master]: UHDDevice: Implement getNominalTxPower() based on TxFrequency
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/18721 to look at the new patch set (#2). Change subject: UHDDevice: Implement getNominalTxPower() based on TxFrequency .. UHDDevice: Implement getNominalTxPower() based on TxFrequency The table with nominal UHD Tx Gains and real transmit power is filled with values measured experimentally. More information can be found in OS#4583. Related: OS#4583 Change-Id: If7ef5bf95ffe4afe5864c0f051853aa38b9639eb --- M Transceiver52M/device/uhd/UHDDevice.cpp M Transceiver52M/device/uhd/UHDDevice.h 2 files changed, 90 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/21/18721/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If7ef5bf95ffe4afe5864c0f051853aa38b9639eb Gerrit-Change-Number: 18721 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in pysim[master]: utils.py add LOCI EFs decode functions
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/18737 to look at the new patch set (#2). Change subject: utils.py add LOCI EFs decode functions .. utils.py add LOCI EFs decode functions The LOCI, PSLOCI and EPSLOCI contain some info, including the PLMN, added helper functions to decode it Change-Id: Ibb513ff7d1dc6d33b354ae26cbd9c390ea3c8efc --- M pySim/ts_31_102.py M pySim/utils.py 2 files changed, 36 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/37/18737/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibb513ff7d1dc6d33b354ae26cbd9c390ea3c8efc Gerrit-Change-Number: 18737 Gerrit-PatchSet: 2 Gerrit-Owner: gui...@gmail.com Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in pysim[master]: utils.py add LOCI EFs decode functions
gui...@gmail.com has uploaded this change for review. (
https://gerrit.osmocom.org/c/pysim/+/18737 )
Change subject: utils.py add LOCI EFs decode functions
..
utils.py add LOCI EFs decode functions
The LOCI, PSLOCI and EPSLOCI contain some info,
including the PLMN, added helper functions to
decode it
Change-Id: Ibb513ff7d1dc6d33b354ae26cbd9c390ea3c8efc
---
M pySim/ts_31_102.py
M pySim/utils.py
2 files changed, 36 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/37/18737/1
diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py
index 473e595..215ed4c 100644
--- a/pySim/ts_31_102.py
+++ b/pySim/ts_31_102.py
@@ -137,6 +137,12 @@
111: 'ePDG configuration Information for Emergency Service configured',
}
+LOCI_STATUS_map = {
+ 0: 'updated',
+ 1: 'not updated',
+ 2: 'plmn not allowed',
+ 3: 'locatation area not allowed'
+}
EF_USIM_ADF_map = {
'LI': '6F05',
'ARR': '6F06',
diff --git a/pySim/utils.py b/pySim/utils.py
index 496b918..2ca6165 100644
--- a/pySim/utils.py
+++ b/pySim/utils.py
@@ -183,6 +183,36 @@
s += "\t%s # %s\n" % (rec_data, rec_str)
return s
+def dec_loci(hexstr):
+ res = {'tmsi': '', 'mcc': 0, 'mnc': 0, 'lac': '', 'status': 0}
+ res['tmsi'] = hexstr[:8]
+ res['mcc'] = dec_mcc_from_plmn(hexstr[8:14])
+ res['mnc'] = dec_mnc_from_plmn(hexstr[8:14])
+ res['lac'] = hexstr[14:18]
+ res['status'] = h2i(hexstr[20:22])
+ return res
+
+def dec_psloci(hexstr):
+ res = {'p-tmsi': '', 'p-tmsi-sig': '', 'mcc': 0, 'mnc': 0, 'lac': '',
'rac': '', 'status': 0}
+ res['p-tmsi'] = hexstr[:8]
+ res['p-tmsi-sig'] = hexstr[8:14]
+ res['mcc'] = dec_mcc_from_plmn(hexstr[14:20])
+ res['mnc'] = dec_mnc_from_plmn(hexstr[14:20])
+ res['lac'] = hexstr[20:24]
+ res['rac'] = hexstr[24:26]
+ res['status'] = h2i(hexstr[26:28])
+ return res
+
+def dec_epsloci(hexstr):
+ res = {'guti': '', 'mcc': 0, 'mnc': 0, 'tac': '', 'status': 0}
+ res['guti'] = hexstr[:24]
+ res['tai'] = hexstr[24:34]
+ res['mcc'] = dec_mcc_from_plmn(hexstr[24:30])
+ res['mnc'] = dec_mnc_from_plmn(hexstr[24:30])
+ res['tac'] = hexstr[30:34]
+ res['status'] = h2i(hexstr[34:36])
+ return res
+
def derive_milenage_opc(ki_hex, op_hex):
"""
Run the milenage algorithm to calculate OPC from Ki and OP
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/18737
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibb513ff7d1dc6d33b354ae26cbd9c390ea3c8efc
Gerrit-Change-Number: 18737
Gerrit-PatchSet: 1
Gerrit-Owner: gui...@gmail.com
Gerrit-MessageType: newchange
Change in osmo-bts[master]: oml.c: Log ADM STATE change locked/unlocked
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18726 ) Change subject: oml.c: Log ADM STATE change locked/unlocked .. oml.c: Log ADM STATE change locked/unlocked Use same forma tuse for other OMl states, like OPER and AVAIL states. Change-Id: Icb176e2215841509bf15a6dfc163ceddcb602954 --- M src/common/oml.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/oml.c b/src/common/oml.c index d7cc7bb..c2c1248 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -1002,6 +1002,10 @@ if (mo->nm_state.administrative == adm_state) LOGPFOH(DOML, LOGL_NOTICE, foh, "ADM state already was %s\n", get_value_string(abis_nm_adm_state_names, adm_state)); + else + LOGPFOH(DOML, LOGL_NOTICE, foh, "ADM STATE %s -> %s\n", + get_value_string(abis_nm_adm_state_names, mo->nm_state.administrative), + get_value_string(abis_nm_adm_state_names, adm_state)); /* Step 3: Ask BTS driver to apply the state chg */ return bts_model_chg_adm_state(bts, mo, obj, adm_state); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icb176e2215841509bf15a6dfc163ceddcb602954 Gerrit-Change-Number: 18726 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in libosmo-abis[master]: e1_input: Initialize list struct
pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18731 ) Change subject: e1_input: Initialize list struct .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I850fdc43d597267aa66c6975aca9c1753231ac65 Gerrit-Change-Number: 18731 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: abandon
Change in osmo-bts[master]: oml.c: Fix whitespace in log line
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/18725 )
Change subject: oml.c: Fix whitespace in log line
..
oml.c: Fix whitespace in log line
Change-Id: I5e9b07303dda374e9196d7d4503ad652970ab6c5
---
M src/common/oml.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/common/oml.c b/src/common/oml.c
index 7e3b834..d7cc7bb 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -1316,8 +1316,8 @@
}
in.s_addr = htonl(ip);
- LOGP(DOML, LOGL_INFO, "%s: Rx IPA RSL CONNECT IP=%s PORT=%u
STREAM=0x%02x\n",
- trx_name, inet_ntoa(in), port, stream_id);
+ LOGP(DOML, LOGL_INFO, "%s: Rx IPA RSL CONNECT IP=%s PORT=%u
STREAM=0x%02x\n",
+trx_name, inet_ntoa(in), port, stream_id);
if (trx->bts->variant == BTS_OSMO_OMLDUMMY) {
rc = 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18725
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5e9b07303dda374e9196d7d4503ad652970ab6c5
Gerrit-Change-Number: 18725
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-trx[master]: UHDDevice: Compute TxGain on UHD API based on expected Tx output power
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18723 ) Change subject: UHDDevice: Compute TxGain on UHD API based on expected Tx output power .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/18723/2/Transceiver52M/device/uhd/UHDDevice.cpp File Transceiver52M/device/uhd/UHDDevice.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/18723/2/Transceiver52M/device/uhd/UHDDevice.cpp@216 PS2, Line 216: tx_gain_db if you subtract something from gain, then it is attenuation. I think we really should clean up the terminology here. I'm completely confused at this point, to be honest - to the point I am unabl to review the code. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6f432465dce5c6ec1f1bc4653f6149efb18c3f43 Gerrit-Change-Number: 18723 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 09 Jun 2020 07:42:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-trx[master]: radioInterface: Operate on real Tx power attenuation rather than on d...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18722 ) Change subject: radioInterface: Operate on real Tx power attenuation rather than on device specific gains .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4f8a1bcbed74aa9310306b97b0b1bfb02f7855e6 Gerrit-Change-Number: 18722 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jun 2020 07:40:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: UHDDevice: Implement getNominalTxPower() based on TxFrequency
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/18721 )
Change subject: UHDDevice: Implement getNominalTxPower() based on TxFrequency
..
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/c/osmo-trx/+/18721/1/Transceiver52M/device/uhd/UHDDevice.cpp
File Transceiver52M/device/uhd/UHDDevice.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/18721/1/Transceiver52M/device/uhd/UHDDevice.cpp@143
PS1, Line 143: { std::make_tuple(B210, GSM_BAND_1900), { 89.75, 7.7 } },
you can add the values for B200, too. After all, the B200 is just a B210 with
analog parts for the second RF channel not populated on the PCB.
https://gerrit.osmocom.org/c/osmo-trx/+/18721/1/Transceiver52M/device/uhd/UHDDevice.cpp@244
PS1, Line 244: WARNING
I would actually elevate that to ERROR
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18721
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: If7ef5bf95ffe4afe5864c0f051853aa38b9639eb
Gerrit-Change-Number: 18721
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge
Gerrit-Comment-Date: Tue, 09 Jun 2020 07:39:37 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in osmo-bts[master]: oml.c: Log ADM STATE change locked/unlocked
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18726 ) Change subject: oml.c: Log ADM STATE change locked/unlocked .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icb176e2215841509bf15a6dfc163ceddcb602954 Gerrit-Change-Number: 18726 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jun 2020 07:37:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-abis[master]: e1_input: refcount inc line during e1_sign_link_create, not during li...
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/18730 )
Change subject: e1_input: refcount inc line during e1_sign_link_create, not
during line update
..
e1_input: refcount inc line during e1_sign_link_create, not during line update
Increase reference count when a new sign_link using the line is created.
Otherwise the line is freed too quickly during e1inp_sign_link_destroy()
with several TRX being used, since each RSL link is missing a reference.
That extra refcoutny in update() is not really needed given that we already
have a link assigned on the line when we call update.
Fixes: OS#3612
Fixes: OS#4094
Change-Id: I74405b0e87a89c17d58e87024f4aedbd30832013
---
M src/e1_input.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/e1_input.c b/src/e1_input.c
index 7066acf..9ea4f17 100644
--- a/src/e1_input.c
+++ b/src/e1_input.c
@@ -586,6 +586,8 @@
link->tei = tei;
link->sapi = sapi;
+ e1inp_line_get(link->ts->line);
+
llist_add_tail(>list, >sign.sign_links);
return link;
@@ -855,8 +857,6 @@
struct input_signal_data isd;
int i, rc;
- e1inp_line_get(line);
-
if (line->driver && line->ops && line->driver->line_update) {
rc = line->driver->line_update(line);
} else
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18730
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I74405b0e87a89c17d58e87024f4aedbd30832013
Gerrit-Change-Number: 18730
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in libosmo-abis[master]: e1_input: refcount inc line during e1_sign_link_create, not during li...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18730 ) Change subject: e1_input: refcount inc line during e1_sign_link_create, not during line update .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I74405b0e87a89c17d58e87024f4aedbd30832013 Gerrit-Change-Number: 18730 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jun 2020 07:36:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: oml.c: Fix whitespace in log line
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18725 ) Change subject: oml.c: Fix whitespace in log line .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5e9b07303dda374e9196d7d4503ad652970ab6c5 Gerrit-Change-Number: 18725 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jun 2020 07:37:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-abis[master]: e1_input: Initialize list struct
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18731 ) Change subject: e1_input: Initialize list struct .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmo-abis/+/18731/2/src/e1_input.c File src/e1_input.c: https://gerrit.osmocom.org/c/libosmo-abis/+/18731/2/src/e1_input.c@571 PS2, Line 571: talloc_zero > If we were not using zero-initialization everywhere, we would notice this > problem much earlier. In general I agree, but not in this specific case. Zero-initializing all llist_heads by talloc_zero of the entire struct makes sure that anyone performing an illegal operation on the llist_head (such as adding something) will cause a null pointer dereference rather than dereferencing some random part of memory (which might be valid! [unlikely, but still]) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I850fdc43d597267aa66c6975aca9c1753231ac65 Gerrit-Change-Number: 18731 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jun 2020 07:35:13 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in libosmo-abis[master]: e1_input: Initialize list struct
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18731 ) Change subject: e1_input: Initialize list struct .. Patch Set 2: Code-Review-2 this is wrong. INIT_LLIST_HEAD is *only* to be called on the "master" list to which siblings are added. The cases you modify initialize a "slave" list entry that is added to a (properly initialized) master list (e1inp_line_list, e.g.). If you ever miss a required INIT_LLIST_HEAD on a "master" list_head, then you will see a crash due to null pointer derefence the first time you try to use that. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I850fdc43d597267aa66c6975aca9c1753231ac65 Gerrit-Change-Number: 18731 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jun 2020 07:33:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libusrp[master]: debian/control: Add python as BuildRequires, as edit-gpif uses it
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libusrp/+/18736 ) Change subject: debian/control: Add python as BuildRequires, as edit-gpif uses it .. debian/control: Add python as BuildRequires, as edit-gpif uses it This hopefully should fix the libusrp build errors on OBS for Debian testing + unstable. Change-Id: I6525e90b63c442b5ec69b4730e92f576694ea1a2 --- M debian/control 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/control b/debian/control index 54bc7af..247a661 100644 --- a/debian/control +++ b/debian/control @@ -9,6 +9,7 @@ doxygen, libtool, pkg-config, + python, sdcc, libusb-1.0-0-dev, libboost-all-dev -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/18736 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: I6525e90b63c442b5ec69b4730e92f576694ea1a2 Gerrit-Change-Number: 18736 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in libusrp[master]: debian/control: Add python as BuildRequires, as edit-gpif uses it
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libusrp/+/18736 ) Change subject: debian/control: Add python as BuildRequires, as edit-gpif uses it .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/18736 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: I6525e90b63c442b5ec69b4730e92f576694ea1a2 Gerrit-Change-Number: 18736 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jun 2020 07:17:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
