Re: datagrid body is disappeared!! height is zero!!
datagrid inside a flex table would not invoke the resize of the grid. Add a resizelayoutPanel inside your dockLayout, override the resize method and set the height of the grid. On Tue, Jan 15, 2013 at 1:25 PM, tong123123 tong123...@gmail.com wrote: DataGrid inside a FlexTable which is then inside a DockLayoutPanel. it seem it is a bug of DataGrid inside a DockLayoutPanel as mentioned in http://code.google.com/p/google-web-toolkit/issues/detail?can=2start=0num=100q=colspec=ID%20Type%20Status%20Owner%20Milestone%20Summary%20Starsgroupby=sort=id=7065 but the provided workaround (add a selectionHandler in TabLayoutPanel and then redraw the DataGrid) is not worked properly, the scrollbar inside the DataGrid is not shown. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/1zTaWe9wARQJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: datagrid body is disappeared!! height is zero!!
On Tuesday, January 15, 2013 8:07:23 AM UTC+1, tong123123 wrote: I see the following link http://code.google.com/p/google-web-toolkit/issues/detail?can=2start=0num=100q=colspec=ID%20Type%20Status%20Owner%20Milestone%20Summary%20Starsgroupby=sort=id=7065 and I follow the suggestion to add a SelectionHandler to the TabLayoutPanel, but the result is the datagrid scrollbar is not shown. I also add the comment to the above link. I am using GWT 2.4 Probably a silly question but why don't you just update to GWT 2.5? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/aENq0zG8mdcJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: datagrid body is disappeared!! height is zero!!
See http://code.google.com/p/google-web-toolkit/issues/detail?id=6996 It is only happen with IE? 2013/1/14 tong123123 tong123...@gmail.com and I check api, there is DataGrid.Style, but I cannot find how to use it, any example could be given? I think this is related to setting the style of DataGrid. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: GWT app crashing on iOS 6
No. It still persists. Are you facing a similar problem ? Oscar El lunes, 14 de enero de 2013 20:54:41 UTC+1, mkn escribió: Hi Could you solve your problem in the meantime? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/Wo5dI1R6ANwJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: GWT app crashing on iOS 6
Yes. The problem is that I cannot reproduce the crash every time. I have a view which sometimes crashes (safari just closes), but there is no specific way to reproduce the crash. It just sometimes happens. When I look at the crash report of the ipad, it just says invalid memory access. It looks like that the safari browser allocates to much space (javascript runtime size I guess) and then safari frees something up, which is being read afterwards causing the crash. Remote debugging does also not help here, because as soon as the browser crashes, the remote debugging window shuts down too. On Tuesday, January 15, 2013 10:53:40 AM UTC+1, Óscar Frías Barranco wrote: No. It still persists. Are you facing a similar problem ? Oscar El lunes, 14 de enero de 2013 20:54:41 UTC+1, mkn escribió: Hi Could you solve your problem in the meantime? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/ftU3FdCZGn4J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
How to simulate a left mouse click on rightclick?
Hi,
I'm trying to build a CellTree where Right and Left click perform the same
action. I already have the left click implemented, everything works fine.
I'm trying to attach a right-click handler to a CellTree. Therefore I
extend the tree and override onBrowserEvent().
The rightclick already gets executed. The Window.alert is shown (see code
below).
BUT the fireNativeEvent() does not seem to have any impact on my handler.
Somehow the simulated BUTTON_LEFT click is not executed. Could someone help
me?
@Override
public void onBrowserEvent(Event event) {
switch (DOM.eventGetType(event)) {
case Event.ONMOUSEDOWN:
if (DOM.eventGetButton(event) == Event.BUTTON_RIGHT) {
Window.alert(rightclick); //this works!
NativeEvent nativeEvent =
Document.get().createMouseDownEvent(-1, event.getScreenX(),
event.getScreenY(), event.getClientX(),
event.getClientY(), event.getCtrlKey(),
event.getAltKey(), event.getShiftKey(),
event.getMetaKey(), NativeEvent.BUTTON_LEFT);
DomEvent.fireNativeEvent(nativeEvent, this);
} else {
super.onBrowserEvent(event);
}
break;
}
}
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To view this discussion on the web visit
https://groups.google.com/d/msg/google-web-toolkit/-/pue6wqArEukJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Hi suggestion needed....
Go with MVP if you are comfortable with the GWT basics and ready for advanced usages. If your page design is mostly static in nature, the UiBinder is easier. On Monday, January 14, 2013 4:48:33 PM UTC-5, nalin...@googlemail.com wrote: I am new to GWT... and building a prototype for a company 1.Should I stick to MVP pattern? Or without that pattern is also advisable? I feel that without that pattern is not a bad design as the project creation itself splits up into client and server code... 2.Which method of UI build is better.. with GWT widgets with Java code or with GWT tags using UiBinder..? Regards, Nalini.K -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/o1B3XS6g7RIJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
bugs in 2.5
hello, I lost all of yesterday to two bugs. one is within the provided core jre libraries of 2.5, one is within the core prototypes within V8. Remember the clean room/testing-team-not-developer-team-no-access-to-code/makes-things-which-work movement IBM pushed long ago. I wish it would come back. Although maybe it was all a PR fantasy anyway. Anyhow. The bugs are $1000 for the JRE, and $2000 for the V8. Let me know if you want them. I'm sorry to charge, but, time=money. Bugs bug everywhere. Oh and btw. Sometimes your GWT compiler fails (not the stackoverflow issue reading caches (who wrote that? do you really need to do whatever you are doing recursively?)), and then I run it again, and it succeeds. Pretty sucky. And strange to tell you the truth. Not saying other companies are necessarily less sucky. Btw. Just sucky in different ways. And pretty bad ways actually, the whole destroying privacy thing... not a fan. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/sFqWp4ydnz8J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
CellTable MouseOver / Cell Change
When you mouseover/rollover a song in Google Music/Play, it shows a drop-down arrow at then end of the title cell, and shows icons in the last cell. How do I get this type of effect (the drop-down arrow) in GWT? There is a addCellPreviewHandler method, but then I would need to show the drop-down for the cell which only takes up one column (is it a CellWrapper of some sort?), and hide any that are not still moused over. Thoughts? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/Mp5KP0NzMSYJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: bugs in 2.5
You have a very confused idea of how open source projects work. Good luck getting your bugs fixed. On Tue, Jan 15, 2013 at 7:31 AM, timp timprepsc...@gmail.com wrote: hello, I lost all of yesterday to two bugs. one is within the provided core jre libraries of 2.5, one is within the core prototypes within V8. Remember the clean room/testing-team-not-developer-team-no-access-to-code/makes-things-which-work movement IBM pushed long ago. I wish it would come back. Although maybe it was all a PR fantasy anyway. Anyhow. The bugs are $1000 for the JRE, and $2000 for the V8. Let me know if you want them. I'm sorry to charge, but, time=money. Bugs bug everywhere. Oh and btw. Sometimes your GWT compiler fails (not the stackoverflow issue reading caches (who wrote that? do you really need to do whatever you are doing recursively?)), and then I run it again, and it succeeds. Pretty sucky. And strange to tell you the truth. Not saying other companies are necessarily less sucky. Btw. Just sucky in different ways. And pretty bad ways actually, the whole destroying privacy thing... not a fan. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/sFqWp4ydnz8J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: bugs in 2.5
troll 2013/1/15 timp timprepsc...@gmail.com hello, I lost all of yesterday to two bugs. one is within the provided core jre libraries of 2.5, one is within the core prototypes within V8. Remember the clean room/testing-team-not-developer-team-no-access-to-code/makes-things-which-work movement IBM pushed long ago. I wish it would come back. Although maybe it was all a PR fantasy anyway. Anyhow. The bugs are $1000 for the JRE, and $2000 for the V8. Let me know if you want them. I'm sorry to charge, but, time=money. Bugs bug everywhere. Oh and btw. Sometimes your GWT compiler fails (not the stackoverflow issue reading caches (who wrote that? do you really need to do whatever you are doing recursively?)), and then I run it again, and it succeeds. Pretty sucky. And strange to tell you the truth. Not saying other companies are necessarily less sucky. Btw. Just sucky in different ways. And pretty bad ways actually, the whole destroying privacy thing... not a fan. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/sFqWp4ydnz8J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- Nel mondo esistono 10 categorie di persone, quelle che capiscono il binario e quelle che non lo capiscono. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: How to dynamically load css style in GWT-based application
I have 2 CSS loaders.
One relies on link tags. This is the preferred way to load CSS as long as
you don't need to be notified when the stylesheet is loaded.
Another one updates the page with CSS loaded via a separate HTTP request
and you can register a callback to be notified when the CSS is loaded.
On Wednesday, December 12, 2007 4:22:59 AM UTC-5, yadong wrote:
I am working on an web application in which the css style varies based
on different user, I am curious how to load css file dynamically.
Currently we use JSTL tag to access server side parameter to determine
which css file needs to be used.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To view this discussion on the web visit
https://groups.google.com/d/msg/google-web-toolkit/-/6oUGJ0wL408J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
package escort.client.utils;
import com.google.gwt.dom.client.Document;
import com.google.gwt.dom.client.Element;
import --;
public class CssLinkLoader {
private static Logger LOGGER = LoggerFactory.getLogger(CssLinkLoader.class);
public static interface OnLoad {
void loaded();
}
private static final String SCREEN_CSS_SERVER_FOLDER = resources/css/screens/;
/**
* All screen related CSS files are kept in one folder on the server. This is a convenience method
* which knows in which folder the those CSS files are located. When referencing images and other
* resources from the CSS use paths relative to this CSS file.
*
* @param cssFileName
*/
public static void loadScreenCss(String cssFileName) {
String screenCssFileName = SCREEN_CSS_SERVER_FOLDER + cssFileName;
if (Document.get().getElementById(screenCssFileName) == null) {
loadCss(screenCssFileName);
}
}
public static void unloadCss(String cssFileName) {
Element cssElement = Document.get().getElementById(cssFileName);
if (cssElement != null) {
cssElement.removeFromParent();
}
}
private static native Boolean isCssLinkLoaded(String cssFileName) /*-{
var link = $doc.getElementById(cssFileName);
try {
if (link.sheet link.sheet.cssRules.length 0) {
return true;
} else if (link.styleSheet link.styleSheet.cssText.length 0) {
return true;
} else if (link.innerHTML link.innerHTML.length 0) {
return true;
}
} catch (ex) {
}
return false;
}-*/;
private static native void loadCss(String url) /*-{
var l = $doc.createElement(link);
l.setAttribute(id, url);
l.setAttribute(rel, stylesheet);
l.setAttribute(type, text/css);
l.setAttribute(href, url + ?v=1); // Make sure this request is not cached
$doc.getElementsByTagName(head)[0].appendChild(l);
}-*/;
}
package escort.client.utils;
import com.google.gwt.core.client.Scheduler;
import com.google.gwt.core.client.Scheduler.ScheduledCommand;
import com.google.gwt.core.shared.GWT;
import com.google.gwt.dom.client.Document;
import com.google.gwt.dom.client.Element;
import com.google.gwt.http.client.Request;
import com.google.gwt.http.client.RequestBuilder;
import com.google.gwt.http.client.RequestCallback;
import com.google.gwt.http.client.RequestException;
import com.google.gwt.http.client.Response;
import --
public class CssStyleLoader {
private static Logger LOGGER = LoggerFactory.getLogger(CssStyleLoader.class);
public static interface OnLoad {
void loaded();
}
private static final String SCREEN_CSS_SERVER_FOLDER = resources/css/screens/;
/**
* When referencing images and other resources from the CSS use paths relative to the application.
**/
public static void loadScreenCss(String cssFileName, OnLoad callback) {
// loadCss(SCREEN_CSS_SERVER_FOLDER + cssFileName, callback);
loadCss(SCREEN_CSS_SERVER_FOLDER + cssFileName, callback);
}
public static void loadCss(final String cssFileName, final OnLoad callback) {
if (Document.get().getElementById(cssFileName) != null) {
return;
}
RequestBuilder requestBuilder = new RequestBuilder(RequestBuilder.GET, cssFileName + ?v=1); // Do not cache
requestBuilder.setCallback(new RequestCallback() {
@Override
public void onResponseReceived(Request request, Response response) {
if (!createStyleElement(cssFileName, response.getText())) {
return;
}
Scheduler.get().scheduleDeferred(new ScheduledCommand() {
@Override
public void execute() {
GWT.log(Loaded stylecheet: + cssFileName);
callback.loaded();
}
});
}
@Override
public void onError(Request request, Throwable exception) {
GWT.log(Failed to load stylecheet: + cssFileName);
LOGGER.error(Failed to load stylecheet: + cssFileName);
}
});
try {
requestBuilder.send();
} catch
Re: Help! com.google.gwt.user.client.rpc.StatusCodeException: 500 The call failed on the server; see server log for details
Are you are able to run the debugger on your server code? Try adding a break point, or add your own logging, or System.out.println() messages to your server code. If it never reaches there, it probably is, as others suggest, a serialization issue. Mike. On Saturday, January 12, 2013 2:47:51 PM UTC-10, Sevak Asadorian wrote: server log is empty. any ideas as to why? how to fix it so it can log? On Monday, December 19, 2011 2:12:06 PM UTC-8, Ed wrote: is there any one that has ever met this error? Yep, we all see them during development. what should I do to solve it? Do what the exception say's: look in the server log Tip: make sure your backend runs well without using gwt. Test your backend through unit tests that will catch the above errors. If you throw checked exceptions to the front end you will get more exception details in the client btw. See GWT doc for more info. - Ed -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/bQFfBy5diEMJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: IE10 support in Gwt
Thanks for the reply. Could you tell me what are the steps required to make it work? I might have to modify the GWT code locally to make it compile to IE10 On Tuesday, January 15, 2013 3:25:44 AM UTC+2, Thomas Broyer wrote: On Monday, January 14, 2013 9:43:48 PM UTC+1, Erik Sapir wrote: Hello, Are there any plans to support compilation to IE10 in GWT? Yes. If there are such plans, when should it happen? I'm not aware of anyone working on it (which doesn't necessarily mean nobody is working on it currently); so no ETA yet. We're preparing the 2.5.1 release and we'll start building a roadmap (with versions, not necessarily dates) for the future versions. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/oZzLcNHs08MJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: bugs in 2.5
Sounds like you're going to want to ask Google to refund the money you paid for GWT. Or you can just report the bugs you found, which is how this works. On Tuesday, January 15, 2013 7:31:33 AM UTC-8, timp wrote: hello, I lost all of yesterday to two bugs. one is within the provided core jre libraries of 2.5, one is within the core prototypes within V8. Remember the clean room/testing-team-not-developer-team-no-access-to-code/makes-things-which-work movement IBM pushed long ago. I wish it would come back. Although maybe it was all a PR fantasy anyway. Anyhow. The bugs are $1000 for the JRE, and $2000 for the V8. Let me know if you want them. I'm sorry to charge, but, time=money. Bugs bug everywhere. Oh and btw. Sometimes your GWT compiler fails (not the stackoverflow issue reading caches (who wrote that? do you really need to do whatever you are doing recursively?)), and then I run it again, and it succeeds. Pretty sucky. And strange to tell you the truth. Not saying other companies are necessarily less sucky. Btw. Just sucky in different ways. And pretty bad ways actually, the whole destroying privacy thing... not a fan. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/O2MOib2i7VMJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Horizontal scrolling fro DockLayoutPanel?
Hi, how can I get scolling in a website that is composide by an outer enclosing DockLayoutPanel? My page consists of the DockLayoutPanel having north, south, east, west, center. Now if I shrink the window everything is shrunk accordingly. Which is quite nice if working with PCT. BUT if the page is bigger than the screen size by default, I would love to see scrollbar on the right. I tried wrapping the DockLayoutPanel into a ScrollPanel, which results just in an empty page. How can I get horizontal scrolling? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/ug5DupDUAmsJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Using public tag in gwt.xml to exclude/include public content in build output
I have a GWT custom widget library that is delivered to my users as a JAR. Each widget has its own gwt.xml file. When a particular consuming application wants to use some of the widgets, they inherit the widget-specific gwt.xml files that they need. However, in my JAR, I have a public folder that contains resources (JS files and CSS files and images) for all of the widgets in the library. There is one widget that is resource intensive that has its own subfolder in the public directory. I would like to configure my gwt.xml files such that the subfolder is only included in the application's build when they use the widget that needs that subfolder. I have been trying to use the public tag in the gwt.xml files that I deliver with no success. Here is what I tried to do: In a base gwt.xml file that all the widget specific gwt.xml files inherit put the following: public path=public/HTML/public public path=public/script/public and then in the widget specific gwt.xml file for the widget that needs the other resources put: public path=public/widget10/public The hope was that for projects that do not use widget10, they would get the public/HTML and public/script contents in their build output. Then in a project that uses widget10, it would get public/HTML, public/script and public/widget10 content in its build output. When I have tried this with GWT 2.1, the build output gets the widget10 subfolder regardless of whether I inherit widget10.gwt.xml or not. I have also tried using the includes attribute on the public tag as well, with the same result: public path=public includes=HTML/*/*,script/*.*/public Can someone tell me whether this is possible, and if so provide me an example? Thanks. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/rEq_rkkLrscJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Horizontal scrolling fro DockLayoutPanel?
A LayoutPanel inside a ScrollPanel does not work and really does not make that much sense. The parent of a LayoutPanel needs a size otherwise LayoutPanel does not work. On the other hand a ScrollPanel has an inner scrollable element that can not have any specific size as it must adapt to its child size. Otherwise ScrollPanel can not show scroll bars. Normally you would have ScrollPanels inside center and maybe inside east/west. DockLayoutPanel should be used to layout the very basic areas of a *web application* and a web application typically has fixed header/footer/sidebars and a scrollable center area. You dont want to scroll the entire web application, only its content. If you need a more *website like* layout with vertical/horizontal scrollbars that scroll the whole website you better not use LayoutPanels. -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/zb3jxM8Hp5YJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: SuperDev Mode Java files are not sent to the browser
I built trunk (you guys make this easy, thanks). I used the sdk that I built from trunk (gwt0.0.0.0) and switched my project to this new sdk. That worked (after I fixed the path to gwt-codeserver.jar in my run configuration to point to the new codeserver). Thanks for your help. Ed On Monday, January 14, 2013 6:23:24 PM UTC-8, Thomas Broyer wrote: We'll release 2.5.1 in the coming weeks, and it will have the fix. If you really need it, then either patch your GWT 2.5.0 or build GWT from trunk (we'll cut 2.5.1 from trunk) On Tuesday, January 15, 2013 3:14:06 AM UTC+1, emurmur wrote: Well, I'm not sure how to rollback to Chrome 23. I tried updating my GWT plugin and SDK to latest (SDK 2.5.0 from 12/12/12 I think), but no dice. Now I'm really stuck. I depend on code server and chrome dev tools. Code server was supposed to be the way to avoid issues with browser upgrades. Does anyone from the GWT team have a suggestion? Is anyone out there successfully using Chrome 24/25 and Code Server and Source Maps? Thanks for your help. Ed On Monday, January 14, 2013 5:23:02 PM UTC-8, emurmur wrote: That makes sense. I just uninstalled Chrome 25 and installed latest Chrome (24) and still have the issue. I probably need to back up to 23, which is what I had this morning when everything worked. Thanks for finding that. Ed On Monday, January 14, 2013 5:16:13 PM UTC-8, Paul Stockley wrote: I think the issue could be related to this: https://gwt-review.googlesource.com/#/c/1300/1 On Monday, January 14, 2013 7:46:26 PM UTC-5, emurmur wrote: Unfortunately, I'm just now experiencing the same thing. It started happening immediately after I update to Chrome 25. It's not clear yet that Chrome 25 is the issue. Here is what I did; 1) I was in Chrome 23, happily using code server for compiling and source maps and chrome dev tools for debuggging. 2) I wanted to try the new speech features in Chrome 25, so installed the beta, the restarted chrome (while eclipse and code server were running). 3) I opened up the html file again. I made some changed to my source and compiled it in chrome using the code server bookmark. It compiled correctly, but only javascript source was available. The compiler output shows the source maps are enabled. I checked the chrome dev tools setting and they indicate source maps are still enabled in chrome. 4) I then did a bunch of stuff in various combinations,refreshing the page, clearing the cache, restarting chrome, restarting code server, doing full GWT compile then starting code servers, etc. Still no source maps. So, I'm not sure if it was the upgrading of the browser, or restarting the browser while code server was running. I'll continue to work on this and let you know what I find. If you figure this out, please reply and let me know what you found. Thanks much. Ed On Sunday, January 13, 2013 1:06:24 AM UTC-8, ustakraharez wrote: Dear All, I have a strange problem with SuperDev mode. Sometimes it sends the java files to the browser, sometimes (and sadly more times :-)) it don't. - SuperDev mode run configuration set, and working. - Superdev mode url working - Bookmarks are working, and when I hit Dev Mode On, compiling working (console logged in Eclipse) - But here, nothing happens. When I follow the modulename url from the browser, I can see the compiled source files, but when I open Chrome Web tools, on Sources (and Profiling) tabs only the cache.js can be seen. Source Maps enabled in Chrome of course. I also aware, that if source maps working properly, the *[WARN] : Source maps sent for module : moduleName* can be seen in Eclipse logs. I only don't understand, what is the reason why it is sometimes working and more times not. Thanks a lot for your help! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/xUVW3o9TMj8J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: datagrid body is disappeared!! height is zero!!
finally I give up and change back to use celltable inside a scrollpanel. client do not want to upgrade to GWT 2.5, so upgrade is not possible. it happen in IE9 and FF13. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Horizontal scrolling fro DockLayoutPanel?
Ok thanks for your opinion! I played around with this a bit, and probably you're right that best approach is to have fixed header/footer and a scrollable content area in my case. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/GpMh6BpbAJsJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
GWT webapp for local desktop application.
Hi all, I want to buy an application where the GUI is done using GWT with any servlets. I'm aware that GWT compiles to javascript files and is embedded in a html file. Thus, i assume it a run locally without any server side code. Correct me if i'm wrong. Which files should i use? In the war folder, there are 2 files(html and javascript) file. However when i access the html locally without any webserver (by double clicking the file). I created a generated sample app using eclipse: TestApp. In the war directory has a TestApp.html and TestApp.css with a testapp folder which has the javascripts. When i access the TestApp.html locally, a dialog box shows GWT Module testapp needs to be (re)compiled. Anyhow know how can i create a GUI with only client side? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/Trop7SeKXN0J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
[gwt-contrib] Re: Fix issue 6959. (issue1587803)
http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/EditorSource.java File user/src/com/google/gwt/editor/client/adapters/EditorSource.java (right): http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/EditorSource.java#newcode60 user/src/com/google/gwt/editor/client/adapters/EditorSource.java:60: * For backwards compatibility with GWT 2.5.0 and earlier, the default implemtation calls On 2013/01/15 02:55:22, skybrian wrote: sp: implementation Done. http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java File user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java (right): http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode44 user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:44: return new IndexedEditorT(-1, null); On 2013/01/15 02:55:22, skybrian wrote: If IndexedEditor's index is -1 then getValue() always returns null and setValue() probably throws an exception eventually in data.setRowData (I didn't trace it). It seems like it would be clearer to return an anonymous subclass of LeafValueEditor that implements getValue() and setValue() to do this directly? I'm assuming setValue() shouldn't be called at all, not sure about getValue. I was assuming getValue/setValue wouldn't be called, but user code can actually call them (from the EditorVisitor passed to EditorContext#traverseSyntheticCompositeEditor). I can't see any use case for that, but still. So I fixed IndexedEditor to no longer throw if data is null. Then dispose() can do an instanceof check and ignore this instance. Or perhaps keep it in a constant and use ==. Actually, dispose() won't be called; that was a leftover from a previous iteration where I only moved the create(0) to createEditorForTraversal; I then moved both create(0) and dispose() so, in the case of HasDataEditor, dispose is no longer called for the synthetic editor. http://gwt-code-reviews.appspot.com/1587803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Developing a new remote RunStyle for PhantomJS
I see, it's probably perfectly applicable to Travis CI (I would just
start the phantomjs webdriver server before executing tests) but what about:
http://code.google.com/p/google-web-toolkit/issues/detail?id=7768
Am 15.01.2013 02:29, schrieb Thomas Broyer:
Note that, while probably not applicable to Travis CI, there's
GhostDriver (WebDriver for PhantomJS) which should allow you to use
the Selenium RunStyle to drive PhantomJS.
On Monday, January 14, 2013 8:59:14 PM UTC+1, Maik Riechert wrote:
Hi all,
As htmlunit isn't suited for all testing scenarios (in particular
layout specific ones), I'd like to use PhantomJS as an alternative
(production mode only). It is a headless webkit engine and can be
easily controlled with JS files, meaning that the new RunStyle
would fork a shell process phantomjs pageload.js where
pageload.js would be written to disk beforehand containing:
var page = require('webpage').create();
var url = 'http://host/gwt...';
page.open(url, function (status) {
//Page is loaded!
phantom.exit();
});
This is particularly great for CI, in my case Travis CI, as it
already has phantomjs installed. Is there a way that I can write a
new RunStyle class and make it available as a kind of plugin? Or
do I really have to submit it as a patch and hope that it gets
included in the official GWT distribution?
Thanks for your support!
Maik
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: simple typo
Daniel Kurka has abandoned this change. Change subject: simple typo .. Abandoned commited -- To view, visit https://gwt-review.googlesource.com/1730 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If17d1c835a05df4409e242bd27c52fbc673ccd90 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: updated javadoc n DeckPanel.getVisibleWidget() fixes issue 7...
Daniel Kurka has abandoned this change. Change subject: updated javadoc n DeckPanel.getVisibleWidget() fixes issue 7680 .. Abandoned commited -- To view, visit https://gwt-review.googlesource.com/1720 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I457b2238ee2f36b0958fed47ed012329a860e0d1 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: AbstractMap.remove() is incorrect, accessing entry after del...
Daniel Kurka has abandoned this change. Change subject: AbstractMap.remove() is incorrect, accessing entry after deletion fixes issue 7856 .. Abandoned commited -- To view, visit https://gwt-review.googlesource.com/1740 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I4d3d92d7aaf13e499c8e12b680ecae66864f8a3a Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Developing a new remote RunStyle for PhantomJS
On Tuesday, January 15, 2013 10:27:57 AM UTC+1, Maik Riechert wrote: I see, it's probably perfectly applicable to Travis CI (I would just start the phantomjs webdriver server before executing tests) but what about: http://code.google.com/p/google-web-toolkit/issues/detail?id=7768 Ah, good catch! Patches welcome! ;-) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] GWT 2.5.1 release - Call for help
Anything I can do with https://codereview.appspot.com/6132056/ to help get it ready to go out with whatever release is deemed appropriate? On 13 January 2013 18:24, Patrick Tucker tucker...@gmail.com wrote: Any chance these can get committed? http://gwt-code-reviews.appspot.com/1876803/ http://gwt-code-reviews.appspot.com/1762803/ http://gwt-code-reviews.appspot.com/1833803/ http://gwt-code-reviews.appspot.com/1785803/ http://gwt-code-reviews.appspot.com/1736804/ On Saturday, January 12, 2013 11:02:41 AM UTC-5, Daniel Kurka wrote: Repost from gwt-steering: Hi Everyone, a quick status update. In the last week a lot of patches have been contributed and some have already been submitted. At the beginning of next week I want to close of for any new patches, so that we can finish the work we are started. We are aiming for a code freeze at the 24th of Januar and a release a short time after that. So once again, if you feel strongly that you need to have something included in GWT 2.5.1 now is the time to act. We also have a couple of open issues that we would like to see in GWT 2.5.1, but might not make it (see: https://docs.google.com/** spreadsheet/ccc?key=**0AuK8EZ6jAAQrdDk1ME1lcmtWOWt3M**ngxOUlTMGJSVEEhttps://docs.google.com/spreadsheet/ccc?key=0AuK8EZ6jAAQrdDk1ME1lcmtWOWt3MngxOUlTMGJSVEE ). Feel free to to contribute patches and do code reviews on the issues listed in the document. -Daniel On Saturday, January 12, 2013 4:17:29 PM UTC+1, Thomas Broyer wrote: On Saturday, January 12, 2013 3:40:42 PM UTC+1, Julien Dramaix wrote: It would be nice to adapt the following paragraph [1] to explain the procedure for submitting code in gerrit. This paragraph is still mentioning svn [1] : https://developers.google.com/**web-toolkit/makinggwtbetter?#** submittingpatcheshttps://developers.google.com/web-toolkit/makinggwtbetter?#submittingpatches I think the idea was to wait until the move to Git is complete. For now the Git repo is still a mirror of the SVN repo (git-svn) which is a mirror of Google's internal Perforce. To complete the move, we'll rewrite the history to remove all big files (prebuilt plugins and api-checker reference jars) so all contributors will have to re-sync their Git repo. So in the mean time, SVN and Rietveld is still OK, though deprecated. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] GWT 2.5.1 release - Call for help
On Tuesday, January 15, 2013 12:02:54 PM UTC+1, James Horsley wrote: Anything I can do with https://codereview.appspot.com/6132056/ to help get it ready to go out with whatever release is deemed appropriate? Won't make it to 2.5.1 sorry. For the next release after 2.5.1, my first task is to finish modularizing and mavenizing GWT, and only then I'll get back to fully work on fixing issues. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Hello Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/1750 to look at the new patch set (#5). Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. avoid busy waiting in SchedulerImpl.runRepeatingTasks If all task are finished in the queue, the code was doing busy waiting. Added detection for finished task, thus returning as soon as possible. fixes issue 7307 Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb --- M user/src/com/google/gwt/core/client/impl/SchedulerImpl.java M user/test/com/google/gwt/core/client/impl/SchedulerImplTest.java 2 files changed, 118 insertions(+), 48 deletions(-) -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Daniel Kurka has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 5: nit picking -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Thomas Broyer has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 5: IIUC, the test as written now would timeout without the fix, right? It might be worth documenting… -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Daniel Kurka has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 5: Where would we document that? -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Thomas Broyer has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 5: For me, it would be enough to add to the never expire comment; somethin like: never expire, would loop indefinitely if the loop always waited TIME_SLICE, and the test would timeout, and add a link to the issue in the javadoc for the test. (I would have done it entirely differently: call runRepeatingTasks directly, and in the mock Duration assert that it hasn't been called more times than the task +/-1, and when it returns, check that the returned list is empty and the task has been called enough times; your test is fine though, I'm possibly/probably too low-level here) -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: Issue 7713 - Float/Double parsing of NaN/Infinity
Matthew Dempsky has abandoned this change. Change subject: Issue 7713 - Float/Double parsing of NaN/Infinity .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/1670 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibc14d48df05e2029d4bcc780c77883f07b7f07f4 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: increased zIndex of compile dialog to avoid it being hidden
Matthew Dempsky has abandoned this change. Change subject: increased zIndex of compile dialog to avoid it being hidden .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/1530 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id1a541fc108e0a9087276a3fe104f5ec129e56cf Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Tom Carchrae carch...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: use java.net.HttpCookie instead of Crockfords json.org
Matthew Dempsky has abandoned this change. Change subject: use java.net.HttpCookie instead of Crockfords json.org .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/1600 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If3568a459f7a196140fa7af5b38850716a71fdd6 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Koch tho...@koch.ro Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Thomas Koch tho...@koch.ro -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Hello Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/1750 to look at the new patch set (#6). Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. avoid busy waiting in SchedulerImpl.runRepeatingTasks If all task are finished in the queue, the code was doing busy waiting. Added detection for finished task, thus returning as soon as possible. fixes issue 7307 Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb --- M user/src/com/google/gwt/core/client/impl/SchedulerImpl.java M user/test/com/google/gwt/core/client/impl/SchedulerImplTest.java 2 files changed, 122 insertions(+), 48 deletions(-) -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: Update to use ICU4J 50.1.1
Andrew Bachmann has posted comments on this change. Change subject: Update to use ICU4J 50.1.1 .. Patch Set 2: Code-Review+1 To clarify, my pending patch is to update the gwt tools for the current CLDR (22.1). Public review forthcoming. -- To view, visit https://gwt-review.googlesource.com/1700 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75c9e0e07c4d29a75573701a676a19d6e83b91d9 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Andrew Bachmann andrewbachm...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: Update to use ICU4J 50.1.1
Andrew Bachmann has posted comments on this change. Change subject: Update to use ICU4J 50.1.1 .. Patch Set 2: (1 comment) File eclipse/tools/cldr-import/.classpath Line 13: classpathentry kind=var path=GWT_TOOLS/lib/icu4j/50.1.1/utilities.jar / John do you think that it is still required to have icu4j.jar and utilities.jar in the cldr/22.1 subdirectory or is it sufficient to keep it in icu4j only? -- To view, visit https://gwt-review.googlesource.com/1700 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75c9e0e07c4d29a75573701a676a19d6e83b91d9 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Andrew Bachmann andrewbachm...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Goktug Gokdogan has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 6: Hi Daniel. Did you see my previous comment? -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Daniel Kurka has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 6: I actually replied on it: The repeating command needs to be run a second time to be in the task queue. Without it we would not be able to test the behavior of runRepeatingTasks -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Daniel Kurka has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 6: my bad: I did not publish it, I am new to gerrit, sorry! -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Goktug Gokdogan has posted comments on this change.
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Patch Set 6:
Now I see what you are doing. Just a nit but perhaps you can add a comment
to document that?
// Command needs to run for the second time to be executed in
runScheduledTasks
if (command.commandRanSecondTime) {
Alternatively, you can call runScheduledTasks directly with a one task and
if returns that means your test is passing.
--
To view, visit https://gwt-review.googlesource.com/1750
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com
Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Hello Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/1750 to look at the new patch set (#7). Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. avoid busy waiting in SchedulerImpl.runRepeatingTasks If all task are finished in the queue, the code was doing busy waiting. Added detection for finished task, thus returning as soon as possible. fixes issue 7307 Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb --- M user/src/com/google/gwt/core/client/impl/SchedulerImpl.java M user/test/com/google/gwt/core/client/impl/SchedulerImplTest.java 2 files changed, 123 insertions(+), 48 deletions(-) -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Daniel Kurka has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 7: Added the comment. I prefer not to call a private function here and test this via a public API, even though this yields a test that is less readable. -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Goktug Gokdogan has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 7: Code-Review+1 That is fair. Thanks for fixing it. -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Developing a new remote RunStyle for PhantomJS
Am 15.01.2013 11:22, schrieb Thomas Broyer: On Tuesday, January 15, 2013 10:27:57 AM UTC+1, Maik Riechert wrote: I see, it's probably perfectly applicable to Travis CI (I would just start the phantomjs webdriver server before executing tests) but what about: http://code.google.com/p/google-web-toolkit/issues/detail?id=7768 http://code.google.com/p/google-web-toolkit/issues/detail?id=7768 Ah, good catch! Patches welcome! ;-) Alright, I did a quick prototype based on the selenium run style and guess what, it works! https://github.com/neothemachine/gwt-webdriver-junit-runstyle It's a shame though that the gwt-maven-plugin doesn't support arbitrary run styles. I guess I'll open an issue on GitHub for that. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: use java.net.HttpCookie instead of Crockfords json.org
Daniel Kurka has posted comments on this change. Change subject: use java.net.HttpCookie instead of Crockfords json.org .. Patch Set 2: no worries this is committed and will be included in GWT 2.5.1 (see Matthews comment) -- To view, visit https://gwt-review.googlesource.com/1600 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3568a459f7a196140fa7af5b38850716a71fdd6 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Koch tho...@koch.ro Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Thomas Koch tho...@koch.ro Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix issue 6959. (issue1587803)
Seems fine. (I'll take care of these nits.)
http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
File user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
(right):
http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode71
user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:71:
public Q getValue() {
@Override?
http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode75
user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:75:
public void setIndex(int index) {
Doesn't need to be public since we only call it from
HasDataEditorSource.setIndex.
http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode81
user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:81:
public void setValue(Q value) {
@Override?
http://gwt-code-reviews.appspot.com/1587803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] GWT 2.5.1 release - Call for help
Hi Patrick, thanks for putting in the work, it's really appreciated! I have added the reviews to the list for GWT 2.5.1, there is no guarantee that everything will land in GWT 2.5.1, but at least someone will take a look. Do you have an open issue for http://gwt-code-reviews.appspot.com/1736804/ ? Thanks again, Daniel Am 13.01.2013 um 19:24 schrieb Patrick Tucker tucker...@gmail.com: http://gwt-code-reviews.appspot.com/1736804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: Emit a warning if (some) incompatible options are used.
Brian Slesinsky has posted comments on this change.
Change subject: Emit a warning if (some) incompatible options are used.
..
Patch Set 1:
(1 comment)
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
Line 490: if (options.isClosureCompilerEnabled()
options.isCompilerMetricsEnabled() {
This is okay, but it seems like it would be clearer like this?
if (options.isClosureCompilerEnabled()) {
... log warnings based on options ...
} else {
... run reports based on options ...
}
--
To view, visit https://gwt-review.googlesource.com/1760
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e73b0107c23e54b69b9e648bff05d2135ff0b77
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
